Mike Blumenkrantz [Fri, 24 Feb 2023 18:56:10 +0000 (13:56 -0500)]
lavapipe: be slightly more permissive for bad apps (and cts) with dynrender
this is stupid, but it makes the default color output "write the output"
instead of zero, which is still wrong, but at least maybe it's wrong
in a way that's useful instead of just being confusing
Acked-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24278>
Yonggang Luo [Sun, 4 Jun 2023 20:45:34 +0000 (04:45 +0800)]
ac/radv: decouple radv vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24464>
Yonggang Luo [Sun, 4 Jun 2023 20:23:38 +0000 (04:23 +0800)]
nouveau/drm-shim: Decouple from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24463>
Jordan Justen [Wed, 2 Aug 2023 16:44:25 +0000 (09:44 -0700)]
intel/tools: Use 'env bash' to find bash executable
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24453>
Yonggang Luo [Thu, 3 Aug 2023 06:42:37 +0000 (14:42 +0800)]
meson: Remove arm_neon_workaround
Suddenly found this workaround doesn't need anymore
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24461>
Yonggang Luo [Sun, 4 Jun 2023 20:59:16 +0000 (04:59 +0800)]
glx: decouple from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Yonggang Luo [Sun, 4 Jun 2023 20:44:55 +0000 (04:44 +0800)]
freedreno: decouple compiler and vulkan driver from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Yonggang Luo [Sun, 4 Jun 2023 20:43:53 +0000 (04:43 +0800)]
pvr: decouple vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-By: Matt Coster <matt.coster@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:32:43 +0000 (10:32 +0200)]
broadcom/compiler: drop execution environment from the shader key
We are no longer using this for anything.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:26:55 +0000 (10:26 +0200)]
broadcom/compiler: always clamp results from logic ops
We have also been clamping our integer RTs in GL for a while now.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:29:51 +0000 (10:29 +0200)]
v3dv: don't set lower_wpos_pntc for Vulkan
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 07:48:00 +0000 (09:48 +0200)]
broadcom/compiler: move vulkan's point coord lowering to the driver
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 07:21:52 +0000 (09:21 +0200)]
broadcom/compiler: move uniform offset lowering from compiler to GL driver
We only need this in GL so move it there.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 07:59:48 +0000 (09:59 +0200)]
broadcom/compiler: use NIR's lowering for dispatch base
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 04:56:48 +0000 (06:56 +0200)]
broadcom/compiler: stop asserting on Vulkan environment
The idea is to eventually get rid of key->environment.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Tue, 1 Aug 2023 09:43:15 +0000 (11:43 +0200)]
v3dv: fix incorrect key setup
We had this incorrectly included inside the body of loop over
the subpass attachments so when all attachments are unused we
would not set this correctly.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 08:48:05 +0000 (10:48 +0200)]
nir/lower_robustness: drop skip_ubo_0 option
v3dv was the only user and it no longer requires this.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 04:53:44 +0000 (06:53 +0200)]
v3dv: stop incrementing UBO indices by one
This matches what we do for OpenGL, allowing us to
have the same compiler behavior for both worlds.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Samuel Pitoiset [Wed, 26 Jul 2023 11:01:42 +0000 (13:01 +0200)]
radv: add radv_graphics_shaders_compile() to compile graphics shaders
Similar to radv_compile_cs() but for all graphics stages.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 1 Aug 2023 08:04:25 +0000 (10:04 +0200)]
radv: add a struct for the retained shaders and GPL
This will be used to remove the pipeline dependency completely when
compiling graphics shaders.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Wed, 26 Jul 2023 10:47:27 +0000 (12:47 +0200)]
radv: inline radv_pipeline_get_nir() in radv_graphics_pipeline_compile()
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 25 Jul 2023 11:25:16 +0000 (13:25 +0200)]
radv: stop passing a graphics pipeline to radv_pipeline_nir_to_asm()
Also rename the function.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 25 Jul 2023 11:14:26 +0000 (13:14 +0200)]
radv: remove unnecessary check in radv_pipeline_nir_to_asm()
If a NIR stage is present, there shouldn't be any compiled binaries
in the same stage slot.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Jordan Justen [Wed, 29 Jun 2022 06:22:28 +0000 (23:22 -0700)]
intel/dev: Support xe2 device init (for intel_device_info_test)
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24419>
Jordan Justen [Tue, 28 Jun 2022 18:54:41 +0000 (11:54 -0700)]
intel/dev: Add LNL platform enum
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24421>
Dave Airlie [Wed, 2 Aug 2023 02:17:27 +0000 (12:17 +1000)]
llvmpipe: fix fragdata/lastfragdata heuristic a bit more.
This heuristic broke when zmike lowered fragcolor using NIR,
This fixes a regression in:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.last_frag_data
Fixes:
db1371cce1d4 ("llvmpipe: fix handling of unused color attachments")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24435>
Eric Engestrom [Wed, 2 Aug 2023 19:39:53 +0000 (20:39 +0100)]
docs: update calendar for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Eric Engestrom [Wed, 2 Aug 2023 19:39:39 +0000 (20:39 +0100)]
docs: add sha256sum for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Eric Engestrom [Wed, 2 Aug 2023 19:34:12 +0000 (20:34 +0100)]
docs: add release notes for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Gert Wollny [Tue, 1 Aug 2023 08:33:55 +0000 (10:33 +0200)]
r600/sfn: AR loads should depend on all previous non ALU instructions
These instructions could be re-ordered, so depending just on the last one
is not sufficient.
Fixes:
d21054b4bc92a1a9240841dca719f81a142fd5cc
r600/sfn: Add pass to split address and index register loads
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24454>
Gert Wollny [Tue, 1 Aug 2023 08:29:34 +0000 (10:29 +0200)]
r600/sfn: Only switch to other CF if no AR uses are pending
Otherwise we end up with an incorrect array load (or an assertion failure).
Fixes:
d617052db6b2f359d7242875013603ec63b069fc
r600/sfn: take address loads into account when scheduling
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24454>
Eric Engestrom [Wed, 2 Aug 2023 14:12:24 +0000 (15:12 +0100)]
ci: drop rule for non-existent src/include/
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24449>
Eric Engestrom [Wed, 2 Aug 2023 14:06:35 +0000 (15:06 +0100)]
ci: add .core-rules to .gallium-core-rules
All the users of the latter were already getting the former through
other rules so there's no functional change, but it's more correct.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24449>
Samuel Pitoiset [Mon, 31 Jul 2023 14:19:52 +0000 (16:19 +0200)]
radv: add support for emitting TCS epilogs in cmdbuf
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 13:49:25 +0000 (15:49 +0200)]
radv: add support for a TCS epilogs cache in the device
Similar to VS prologs and PS epilogs.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Wed, 2 Aug 2023 13:17:08 +0000 (15:17 +0200)]
radv: add infra for creating TCS epilogs
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 13:54:27 +0000 (15:54 +0200)]
radv: add radv_tcs_epilog_key
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 14:15:27 +0000 (16:15 +0200)]
radv: declare new argument for the TCS epilog PC
To jump to the TCS epilog.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 16:12:01 +0000 (18:12 +0200)]
radv: track if TES reads tess factors differently
This information will be passed through the TCS epilog key.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 14:24:08 +0000 (16:24 +0200)]
radv: do not write tess factors in main TCS when it has an epilog
Tess factors will be written by TCS epilogs.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Wed, 2 Aug 2023 06:54:43 +0000 (08:54 +0200)]
radv: assume a TCS needs an epilog unless it's linked with a TES
For shader object.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Wed, 2 Aug 2023 06:53:18 +0000 (08:53 +0200)]
radv,aco: move has_epilog to radv_shader_info
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Eric Engestrom [Fri, 14 Jul 2023 17:51:06 +0000 (18:51 +0100)]
broadcom/ci: reduce v3dv-rpi4-vk timeout to 30min (instead of 1h)
This means that when things go wrong, we don't hold the runner (and Marge)
for as long, while still having a 2x margin over the usual run time.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24402>
Eric Engestrom [Fri, 14 Jul 2023 17:50:43 +0000 (18:50 +0100)]
broadcom/ci: reduce v3d-rpi4-traces timeout to 30min (instead of 1h)
This means that when things go wrong, we don't hold the runner (and Marge)
for as long, while still having a 2x margin over the usual run time.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24402>
Eric Engestrom [Fri, 14 Jul 2023 17:50:07 +0000 (18:50 +0100)]
broadcom/ci: reduce v3d-rpi4-gl timeout to 30min (instead of 1h)
This means that when things go wrong, we don't hold the runner (and Marge)
for as long, while still having a 2x margin over the usual run time.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24402>
Eric Engestrom [Fri, 14 Jul 2023 17:49:36 +0000 (18:49 +0100)]
broadcom/ci: reduce vc4-rpi3-gl timeout to 30min (instead of 1h)
This means that when things go wrong, we don't hold the runner (and Marge)
for as long, while still having a 2x margin over the usual run time.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24402>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:50:38 +0000 (10:50 -0400)]
nir: Remove register load/store builders
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24450>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:35:21 +0000 (10:35 -0400)]
nir: Remove reg_intrinsics parameter to convert_from_ssa
All users must set it.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24450>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:33:11 +0000 (10:33 -0400)]
nir: Remove lower_vec_to_movs
Unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24450>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:32:24 +0000 (10:32 -0400)]
nir: Remove lower_to_source_mods
Unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24450>
Eric Engestrom [Mon, 31 Jul 2023 16:21:18 +0000 (17:21 +0100)]
ci: reduce bare-metal retries of poe_run to only 3 attempts
10 is overkill, if we fail that many times in a row we should stop
trying on this runner.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24407>
Eric Engestrom [Tue, 1 Aug 2023 16:01:46 +0000 (17:01 +0100)]
ci: add a 10min job timeout to formatting checks
They both take only a few seconds, but it can take up to a minute for
setting up the job, and various external factors such as network can add
delays, so let's round it up to a generous 10 minutes.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24431>
David Heidelberg [Tue, 1 Aug 2023 10:34:58 +0000 (13:34 +0300)]
ci/freedreno: document another mapbuffer flake on a530
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24441>
Juan A. Suarez Romero [Tue, 1 Aug 2023 07:13:28 +0000 (09:13 +0200)]
broadcom/ci: update expected results
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24437>
Samuel Pitoiset [Wed, 2 Aug 2023 06:24:47 +0000 (08:24 +0200)]
aco: add infra for compiling TCS epilogs
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24417>
Qiang Yu [Wed, 2 Aug 2023 06:23:57 +0000 (08:23 +0200)]
aco: extract aco_compile_shader_part from aco_compile_ps_epilog
Will be shared with radeonsi tcs epilog and other shader parts build.
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24417>
Samuel Pitoiset [Wed, 2 Aug 2023 06:22:58 +0000 (08:22 +0200)]
aco: add aco_shader_info::tcs::has_epilog
This will be used by both RADV and RadeonSI to jump from the main TCS
to the epilog.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24417>
Samuel Pitoiset [Tue, 1 Aug 2023 13:30:19 +0000 (15:30 +0200)]
radv: allow to use fixed IO locations for VS<->TCS<->TES without linking
For shader objects.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24408>
Samuel Pitoiset [Tue, 1 Aug 2023 11:54:30 +0000 (13:54 +0200)]
amd,radeonsi: move si_shader_io_get_unique_index_patch() to common code
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24408>
Yonggang Luo [Tue, 8 Nov 2022 08:12:10 +0000 (16:12 +0800)]
util/meson: Getting mesa util core to be self contained
Guard util to be standalone by move subdir('util') just behind subdir('android_stub')
texcompress_rgtc_tmp.h is not a standard c header, do not treat it as source
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Tue, 8 Nov 2022 08:12:10 +0000 (16:12 +0800)]
util:Move only gallium used u_debug_refcnt.* and u_debug_describe.* into src/gallium/auxiliary/util/
Because these files indeed doesn't belongs to src/util, they are tightly coupled with
src/gallium/auxiliary
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Mon, 7 Nov 2022 07:14:47 +0000 (15:14 +0800)]
util: Remove include "pipe/*.h" in src/util/* files
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Sun, 4 Jun 2023 09:22:09 +0000 (17:22 +0800)]
util: Move u_pack_color.h and dbughelp.h into src/util from/src/gallium/auxiliary/util/
As u_pack_color.h is used in vulkan drivers, so decouple it from gallium by this move
And dbghelp.h is included in u_debug_symbol.c and that's resident in src/util/
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Sun, 4 Jun 2023 09:25:36 +0000 (17:25 +0800)]
util: Move pipe_color_union from p_defines.h into u_formats.h
As pipe_color_union is used in vulkan drivers, so decouple it from gallium by this move
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Sun, 4 Jun 2023 09:15:31 +0000 (17:15 +0800)]
util: Move PIPE_MASK_* from p_defines.h to u_formats.h
PIPE_MASK_* is used by src/util/*, so do the move to decouple src/util/* from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Yonggang Luo [Sun, 4 Jun 2023 09:12:10 +0000 (17:12 +0800)]
util: Move pipe_swizzle from p_defines.h to u_formats.h
pipe_swizzle is used by src/util/*, so do the move to decouple src/util/* from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19522>
Mike Blumenkrantz [Wed, 26 Jul 2023 20:30:56 +0000 (16:30 -0400)]
lavapipe: don't check geometry for fb attachments
this is broken since surfaces always have minified geometry
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24339>
Mike Blumenkrantz [Wed, 26 Jul 2023 20:21:08 +0000 (16:21 -0400)]
lavapipe: zero fb attachment array at rp start
this avoids invalid access if an attachment moves to a lower index
in a smaller renderpass
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24339>
Mike Blumenkrantz [Wed, 26 Jul 2023 20:20:50 +0000 (16:20 -0400)]
lavapipe: statically allocate fb attachment array
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24339>
Mike Blumenkrantz [Mon, 17 Jul 2023 13:11:01 +0000 (09:11 -0400)]
glsl: only explicitly check GS components in PSIZ injection with output variables
if no output variables exist then there's plenty of room for a psiz
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24182>
Mike Blumenkrantz [Mon, 31 Jul 2023 15:11:50 +0000 (11:11 -0400)]
zink: add feedback loop exts to optimal profile
base feedback loop ext is more like a hard requirement, but it's tough to
pin down exactly which version requires it, and also it might "just work"
magically, so...yeah here we are
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24403>
David Heidelberg [Mon, 31 Jul 2023 15:21:21 +0000 (18:21 +0300)]
ci/nouveau: add 20 minutes timeout to gk20a and align gm20b
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24405>
Alyssa Rosenzweig [Fri, 28 Jul 2023 19:08:00 +0000 (15:08 -0400)]
nir: Rename scoped_barrier -> barrier
sed + ninja clang-format + fix up spacing for common code.
If you are unhappy that I did not manually change the whitespace of your driver,
you need to enable clang-format for it so the formatting would happen
automatically.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:43:59 +0000 (10:43 -0400)]
panfrost: Gate overdraw_alpha on Bifrost+
Not used on Midgard, deals with a -Wunused-function warning.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:43:32 +0000 (10:43 -0400)]
panfrost: Add missing inline
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:42:03 +0000 (10:42 -0400)]
panfrost: Only define pan_blitter_get_blend_shaders for midgard
Unused otherwise, responds to a -Wunused-function warning.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:40:59 +0000 (10:40 -0400)]
panfrost: Drop unused decode_position for samples
There's a Gallium helper for this now.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:40:32 +0000 (10:40 -0400)]
pan/mdg: Add missing static inline annotation
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:40:23 +0000 (10:40 -0400)]
pan/decode: Drop unused debug function
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:40:11 +0000 (10:40 -0400)]
panfrost: Add missing static inline annotation
Quiets -Wunused-function
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:45:28 +0000 (10:45 -0400)]
nir/passthrough_gs: Drop unused array_size_for_prim
../src/compiler/nir/nir_passthrough_gs.c:96:1: warning: ‘array_size_for_prim’ defined but not used [-Wunused-function]
96 | array_size_for_prim(enum mesa_prim prim)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:45:12 +0000 (10:45 -0400)]
nir/loop_analyze: Drop unused inverse_comparison
../src/compiler/nir/nir_loop_analyze.c:1134:1: warning: ‘inverse_comparison’ defined but not used [-Wunused-function]
1134 | inverse_comparison(nir_op alu_op)
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:42:54 +0000 (10:42 -0400)]
gallium/u_transfer_helper: Remove dead forward decl
Doesn't point to anything.
../src/gallium/auxiliary/util/u_transfer_helper.c:255:1: warning: ‘u_transfer_helper_deinterleave_transfer_map’ declared ‘static’ but never defined [-Wunused-function]
255 | u_transfer_helper_deinterleave_transfer_map(struct pipe_context *pctx,
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24428>
Nanley Chery [Tue, 9 May 2023 00:48:22 +0000 (17:48 -0700)]
iris: Sample more texture view fast-clears on gfx11+
On platforms with an indirect clear color BO, the clear color used when
sampling is in the form of a pixel. The sampler can interpret the pixel
correctly regardless of the format, so allow fast clears in more cases
within iris_resource_prepare_texture.
On gfx12, this completely removes partial resolves in a couple game
traces I tested:
- 72 partial resolves in a 500 frame trace of CS:GO.
- 1207 partial resolves in a 500 frame trace of Dota 2.
The resolves were triggered when ISL_FORMAT_A8_UNORM surfaces were
sampled as ISL_FORMAT_R8_UNORM.
Reviewed-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24323>
José Roberto de Souza [Mon, 31 Jul 2023 18:29:14 +0000 (11:29 -0700)]
anv: Return earlier in anv_reloc_list functions
Xe KMD don't need relocs, so calling a nop function and avoiding the
CPU cycles and memory waste with reloc.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24411>
José Roberto de Souza [Mon, 31 Jul 2023 18:13:04 +0000 (11:13 -0700)]
anv: Remove VkAllocationCallbacks parameter from reloc functions
Mismatch allocator could cause bad things, so better set the allocator
on anv_reloc_list_init() and use it in every reloc function.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24411>
José Roberto de Souza [Mon, 31 Jul 2023 18:53:48 +0000 (11:53 -0700)]
anv: Nuke unused READ_ONCE() from anv_batch_chain.c
Only genX_cmd_buffer.c makes use of READ_ONCE() but that file also
defines it so it can be removed from anv_batch_chain.c.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24411>
David Rosca [Tue, 1 Aug 2023 12:50:20 +0000 (14:50 +0200)]
ci/amd: Skip VAAPI CreateSurfacesWithConfigAttribs/1121 test
It now times out with surfaces being allocated non-interlaced
by default due to a slower path being taken in clear_render_target.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24361>
David Rosca [Fri, 28 Jul 2023 07:40:07 +0000 (09:40 +0200)]
radeonsi: Don't prefer interlaced for video decode
Preferring interlaced results in all surfaces being allocated
as interlaced for H264 decode regardless of whether the decoded
pic is interlaced or progressive, which makes VA postproc
apply deinterlacing even for progressive pics.
Deinterlacing interlaced pics still works because VA frontend
will now reallocate surface as interlaced when decoding interlaced
pics.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24361>
David Rosca [Fri, 28 Jul 2023 16:14:10 +0000 (18:14 +0200)]
frontends/vdpau: Alloc interlaced surface for interlaced pics
When decoding interlaced pics, the output surface should
also be allocated as interlaced to make the deinterlace
postproc filter work correctly.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24361>
David Rosca [Fri, 28 Jul 2023 07:25:00 +0000 (09:25 +0200)]
frontends/va: Alloc interlaced surface for interlaced pics
When decoding interlaced pics, the output surface should
also be allocated as interlaced to make the deinterlace
postproc filter work correctly.
This makes deinterlacing work for drivers that supports, but
not prefers, interlaced surfaces.
Use extra buffer instead of reallocating as non-interlaced
when exporting interlaced surfaces.
v2: Avoid reallocating in vlVaExportSurfaceHandle
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24361>
Italo Nicola [Tue, 21 Feb 2023 16:32:03 +0000 (16:32 +0000)]
mesa/main: allow readpix/teximage to read from implicitly multisampled fbos
The GL_EXT_multisampled_render_to_texture spec explicitly allow reading
from these FBOs.
"Similarly, for ReadPixels:
'An INVALID_OPERATION error is generated if the value of READ_-
FRAMEBUFFER_BINDING (see section 9) is non-zero, the read framebuffer is
framebuffer complete, and the value of SAMPLE_BUFFERS for the read
framebuffer is one.'
These errors do not apply to textures and renderbuffers that have
associated multisample data specified by the mechanisms described in
this extension, i.e., the above operations are allowed even when
SAMPLE_BUFFERS is non-zero for renderbuffers created via Renderbuffer-
StorageMultisampleEXT or textures attached via FramebufferTexture2D-
MultisampleEXT."
Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10747>
Italo Nicola [Fri, 14 May 2021 11:25:42 +0000 (11:25 +0000)]
mesa/main: account for RTT samples when updating framebuffer
For EXT_multisampled_render_to_texture, we store the number of samples
in Attachment->NumSamples instead of Renderbuffer->NumSamples. This
meant that the previous code ignored that the framebuffer was
multisampled. Because of this, pipe_rasterizer_state::multisample is set
incorrectly, leading to visual artifacts on drivers that support MS-RTT
extension, such as panfrost.
Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Rob Clark <robclark@freedesktop.org>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10747>
Mike Blumenkrantz [Fri, 21 Jul 2023 16:48:19 +0000 (12:48 -0400)]
gallium: bump PIPE_MAX_SO_OUTPUTS to 128
this is the number of components supported for streamout
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24285>
Mike Blumenkrantz [Fri, 21 Jul 2023 16:48:19 +0000 (12:48 -0400)]
ir3: bump max xfb output to 128
this is the number of components supported for streamout
Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24285>
Mike Blumenkrantz [Fri, 21 Jul 2023 16:48:19 +0000 (12:48 -0400)]
radv: bump max xfb output to 128
this is the number of components supported for streamout
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24285>
jazzfool [Tue, 1 Aug 2023 15:24:36 +0000 (01:24 +1000)]
zink: Hash only first 32 bits of zink_gfx_pipeline_state with full DS3
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8245
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24430>
José Roberto de Souza [Mon, 17 Apr 2023 17:10:37 +0000 (10:10 -0700)]
intel/genxml/gen125: Set MI_MATH MOCS field as non-zero
All MOCS tables have 0 as a invalid value, so this will asssert
in case some place misset to set MI_MATH MOCS field.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22508>
José Roberto de Souza [Mon, 17 Jul 2023 21:15:39 +0000 (14:15 -0700)]
intel/tests/mi_builder: Set MI_MATH MOCS field
MOCS = 0 is a invalid MOCS index on MTL, so it is necessary get a
valid value and set to MI_MATH instructions.
So here the mocs index is set with mi_builder_set_mocs(), it can be
always set but it is required when mi_build will emit MI_MATH
instructions.
The mocs index will only be stored and used in gfx12.5+ platforms
so no changes were are required in crocus or hasvk.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22508>
José Roberto de Souza [Mon, 17 Jul 2023 21:14:38 +0000 (14:14 -0700)]
anv: Set MI_MATH MOCS field
MOCS = 0 is a invalid MOCS index, so it is necessary get a valid value
and set to MI_MATH instructions.
So here the mocs index is set with mi_builder_set_mocs(), it can be
always set but it is required when mi_build will emit MI_MATH
instructions.
The mocs index will only be stored and used in gfx12.5+ platforms
so no changes were are required in crocus or hasvk.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22508>
projects / platform / upstream / mesa.git / log