platform/upstream/libSkiaSharp.git
11 years agoAdding kMultiply_Mode (as an alias to kModulate_Mode) in SkBlendImageFilter.h to...
robertphillips@google.com [Thu, 31 Jan 2013 01:47:58 +0000 (01:47 +0000)]
Adding kMultiply_Mode (as an alias to kModulate_Mode) in SkBlendImageFilter.h to get Chrome compiling

git-svn-id: http://skia.googlecode.com/svn/trunk@7482 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReadding kMultiply_Mode (as an alias to kModulate_Mode) in SkXfermode.h to get Chrome...
robertphillips@google.com [Thu, 31 Jan 2013 01:23:39 +0000 (01:23 +0000)]
Readding kMultiply_Mode (as an alias to kModulate_Mode) in SkXfermode.h to get Chrome to compile

git-svn-id: http://skia.googlecode.com/svn/trunk@7480 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkImageFilterUtils.h to effects.gypi
robertphillips@google.com [Thu, 31 Jan 2013 00:03:27 +0000 (00:03 +0000)]
Add SkImageFilterUtils.h to effects.gypi

git-svn-id: http://skia.googlecode.com/svn/trunk@7479 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Fix multi-level page count calculation.
vandebo@chromium.org [Wed, 30 Jan 2013 21:44:40 +0000 (21:44 +0000)]
[PDF] Fix multi-level page count calculation.

BUG=1091

Review URL: https://codereview.appspot.com/7220045

git-svn-id: http://skia.googlecode.com/svn/trunk@7478 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoclone of https://codereview.appspot.com/7208043/
reed@google.com [Wed, 30 Jan 2013 21:36:11 +0000 (21:36 +0000)]
clone of https://codereview.appspot.com/7208043/
Review URL: https://codereview.appspot.com/7232062

git-svn-id: http://skia.googlecode.com/svn/trunk@7476 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkNextLog2 requires positive values.
bungeman@google.com [Wed, 30 Jan 2013 21:23:13 +0000 (21:23 +0000)]
SkNextLog2 requires positive values.

git-svn-id: http://skia.googlecode.com/svn/trunk@7474 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkNextLog2 requires values > 0.
bungeman@google.com [Wed, 30 Jan 2013 21:10:05 +0000 (21:10 +0000)]
SkNextLog2 requires values > 0.

git-svn-id: http://skia.googlecode.com/svn/trunk@7472 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded option of profiling GPU backend to debugger
robertphillips@google.com [Wed, 30 Jan 2013 21:09:09 +0000 (21:09 +0000)]
Added option of profiling GPU backend to debugger

https://codereview.appspot.com/7248045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7471 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid possible O(n) stack space use by skqsort.
bungeman@google.com [Wed, 30 Jan 2013 21:01:26 +0000 (21:01 +0000)]
Avoid possible O(n) stack space use by skqsort.
https://codereview.appspot.com/7222043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7470 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStart addressing the clang static analyzer issues
robertphillips@google.com [Wed, 30 Jan 2013 20:33:12 +0000 (20:33 +0000)]
Start addressing the clang static analyzer issues

https://codereview.appspot.com/7249043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7469 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_compare proper spacing and tab option.
bungeman@google.com [Wed, 30 Jan 2013 19:22:51 +0000 (19:22 +0000)]
bench_compare proper spacing and tab option.
https://codereview.appspot.com/6908056/

git-svn-id: http://skia.googlecode.com/svn/trunk@7468 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for...
senorblanco@chromium.org [Wed, 30 Jan 2013 19:08:47 +0000 (19:08 +0000)]
This changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for input and output, and removes the rect param.  This allows us to return textures which are larger than the actual result, such as when GrAutoScratchTextures are used.  The SkBitmap's size represents the active region, while the GrTexture's size is the full texture size.

This fixes the bicubic image filter GM on the GPU, which otherwise draws garbage outside the filtered region.  It also moves us closer to unifying the signatures of SkImageFilter::onFilterImage() and SkImageFilter::filterImageGPU().

Review URL: https://codereview.appspot.com/7180048

git-svn-id: http://skia.googlecode.com/svn/trunk@7467 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws...
bsalomon@google.com [Wed, 30 Jan 2013 16:12:41 +0000 (16:12 +0000)]
Add GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws in subclasses.
Review URL: https://codereview.appspot.com/7237045

git-svn-id: http://skia.googlecode.com/svn/trunk@7466 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding a new unit test that demonstrates that dithering affects constant gradients
junov@chromium.org [Wed, 30 Jan 2013 15:52:06 +0000 (15:52 +0000)]
Adding a new unit test that demonstrates that dithering affects constant gradients
Related bug: crbug.com/169602
Review URL: https://codereview.appspot.com/7220063

git-svn-id: http://skia.googlecode.com/svn/trunk@7465 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreturn if we're invertible for the fast scale+trans case when we have no inverse
reed@google.com [Wed, 30 Jan 2013 15:47:42 +0000 (15:47 +0000)]
return if we're invertible for the fast scale+trans case when we have no inverse
matrix to return.
Review URL: https://codereview.appspot.com/7231063

git-svn-id: http://skia.googlecode.com/svn/trunk@7464 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdds SkMWCRandom, which generates random numbers using a variant of George Marsaglia...
jvanverth@google.com [Wed, 30 Jan 2013 15:42:19 +0000 (15:42 +0000)]
Adds SkMWCRandom, which generates random numbers using a variant of George Marsaglia's multiply-with-carry "mother-of-all" method. This passes the tuftests suite so it should be much better than the current method (which does not).

https://codereview.appspot.com/7235056/

git-svn-id: http://skia.googlecode.com/svn/trunk@7463 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enbling blurrect gm test wich no longer fails with rtree/tileGrid
junov@chromium.org [Wed, 30 Jan 2013 15:34:57 +0000 (15:34 +0000)]
Re-enbling blurrect gm test wich no longer fails with rtree/tileGrid
Some re-baselining may be necessary since the existing ones may be out of date.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7462 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK option, to disable check for
reed@google.com [Wed, 30 Jan 2013 13:17:32 +0000 (13:17 +0000)]
add SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK option, to disable check for
lock-count-balance when we use pixelrefs.

git-svn-id: http://skia.googlecode.com/svn/trunk@7460 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Wed, 30 Jan 2013 12:50:38 +0000 (12:50 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7459 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 30 Jan 2013 07:05:59 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7458 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 29 Jan 2013 20:28:49 +0000 (20:28 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7453 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark SkPictureStateTree::Draw::operator< as const.
bungeman@google.com [Tue, 29 Jan 2013 19:04:14 +0000 (19:04 +0000)]
Mark SkPictureStateTree::Draw::operator< as const.
https://codereview.appspot.com/7222043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7452 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Japanese font issue for devices running JB MR1 and higher.
djsollen@google.com [Tue, 29 Jan 2013 15:39:35 +0000 (15:39 +0000)]
Fix Japanese font issue for devices running JB MR1 and higher.

Android JB MR1 is using a new format of /system/etc/fallback_fonts.xml.
This CL preserves backwards compatibility, while also recognizing the
new fallback_fonts.xml format ("lang" attrbiute in <file/>).

NOTE: This CL was originally sumbitted for Chrome on Android (m18)

Review URL: https://codereview.appspot.com/7226053

git-svn-id: http://skia.googlecode.com/svn/trunk@7448 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 29 Jan 2013 14:34:03 +0000 (14:34 +0000)]
shape ops work in progress

update gyp files

git-svn-id: http://skia.googlecode.com/svn/trunk@7445 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_API to SkMutex (for chrome)
reed@google.com [Tue, 29 Jan 2013 13:03:36 +0000 (13:03 +0000)]
add SK_API to SkMutex (for chrome)

git-svn-id: http://skia.googlecode.com/svn/trunk@7443 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Tue, 29 Jan 2013 12:25:35 +0000 (12:25 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7442 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
rmistry@google.com [Tue, 29 Jan 2013 12:23:53 +0000 (12:23 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7441 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 29 Jan 2013 07:05:52 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7439 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotweak to comments, ws change to trigger bots
reed@google.com [Mon, 28 Jan 2013 22:36:34 +0000 (22:36 +0000)]
tweak to comments, ws change to trigger bots

git-svn-id: http://skia.googlecode.com/svn/trunk@7435 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove a workaround in gm/xfermodes.cpp
scroggo@google.com [Mon, 28 Jan 2013 21:14:21 +0000 (21:14 +0000)]
Remove a workaround in gm/xfermodes.cpp

We were performing a deep copy of the pixels in a SkBitmap to work around a bug where drawing an SkBitmap whose pixel memory was set with setPixels to an SkPicture did not preserve the pixel memory.

Since the workaround was written, we have fixed the bug in two ways:
1. If setPixels is called with a pointer, we wrap the pixels in an SkPixelRef.
2. Picture recording now makes a deep copy of mutable bitmaps.

Also switch to using onOnceBeforeDraw, an existing feature on GM that performs the purpose of the init function.

BUG=http://code.google.com/p/skia/issues/detail?id=224

Review URL: https://codereview.appspot.com/7220054

git-svn-id: http://skia.googlecode.com/svn/trunk@7433 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing params to renderer->resetState().
jvanverth@google.com [Mon, 28 Jan 2013 21:09:05 +0000 (21:09 +0000)]
Add missing params to renderer->resetState().

https://codereview.appspot.com/7234051/

git-svn-id: http://skia.googlecode.com/svn/trunk@7431 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing crash in cloning empty SkPicture object
junov@chromium.org [Mon, 28 Jan 2013 21:04:44 +0000 (21:04 +0000)]
Fixing crash in cloning empty SkPicture object

BUG=https://code.google.com/p/chromium/issues/detail?id=172062
TEST=Pictures unit test, test_clone_empty
Review URL: https://codereview.appspot.com/7223048

git-svn-id: http://skia.googlecode.com/svn/trunk@7430 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assert
robertphillips@google.com [Mon, 28 Jan 2013 20:55:42 +0000 (20:55 +0000)]
Fix assert

https://codereview.appspot.com/7234050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7428 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build
reed@google.com [Mon, 28 Jan 2013 20:53:22 +0000 (20:53 +0000)]
fix build
Review URL: https://codereview.appspot.com/7229052

git-svn-id: http://skia.googlecode.com/svn/trunk@7426 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoREBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build...
reed@google.com [Mon, 28 Jan 2013 20:43:09 +0000 (20:43 +0000)]
REBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build guard.
Review URL: https://codereview.appspot.com/7225056

git-svn-id: http://skia.googlecode.com/svn/trunk@7425 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange the method for timing individual tiles in bench_pictures.
scroggo@google.com [Mon, 28 Jan 2013 20:40:24 +0000 (20:40 +0000)]
Change the method for timing individual tiles in bench_pictures.

When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.

Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).

Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.

resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).

render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.

BUG=http://code.google.com/p/skia/issues/detail?id=1066

Review URL: https://codereview.appspot.com/7101060

git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove vertex layout definitions from GrDrawTarget to GrDrawState.
jvanverth@google.com [Mon, 28 Jan 2013 20:39:48 +0000 (20:39 +0000)]
Move vertex layout definitions from GrDrawTarget to GrDrawState.

This is the first step in revising vertex layouts so that the currently
installed GrEffects determine the current vertex layout.

https://codereview.appspot.com/7235051/

git-svn-id: http://skia.googlecode.com/svn/trunk@7423 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded toString to SkDrawLooper-derived classes
robertphillips@google.com [Mon, 28 Jan 2013 20:21:59 +0000 (20:21 +0000)]
Added toString to SkDrawLooper-derived classes

https://codereview.appspot.com/7195054/

git-svn-id: http://skia.googlecode.com/svn/trunk@7422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 28 Jan 2013 19:25:51 +0000 (19:25 +0000)]
shape ops work in progress

good checkpoint: nearly all tests pass solidly here

git-svn-id: http://skia.googlecode.com/svn/trunk@7420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd data() to all QString::toASCII Qt calls to help out Linux compiler
robertphillips@google.com [Mon, 28 Jan 2013 19:25:43 +0000 (19:25 +0000)]
Add data() to all QString::toASCII Qt calls to help out Linux compiler

https://codereview.appspot.com/7232052/

git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd command line options to debugger
robertphillips@google.com [Mon, 28 Jan 2013 17:43:26 +0000 (17:43 +0000)]
Add command line options to debugger

https://codereview.appspot.com/7221048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd (disabled) test for big dashing
reed@google.com [Mon, 28 Jan 2013 16:57:29 +0000 (16:57 +0000)]
add (disabled) test for big dashing

git-svn-id: http://skia.googlecode.com/svn/trunk@7417 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debug build. Unreviewed.
senorblanco@chromium.org [Mon, 28 Jan 2013 16:48:51 +0000 (16:48 +0000)]
Fix debug build.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build break after r7411 when GR_STATIC_RECT_VB is enabled.
bsalomon@google.com [Mon, 28 Jan 2013 16:46:55 +0000 (16:46 +0000)]
Fix build break after r7411 when GR_STATIC_RECT_VB is enabled.
Review URL: https://codereview.appspot.com/7220051

git-svn-id: http://skia.googlecode.com/svn/trunk@7415 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd an origin flag for backend (external) textures. Some textures in WebKit have...
senorblanco@chromium.org [Mon, 28 Jan 2013 16:42:38 +0000 (16:42 +0000)]
Add an origin flag for backend (external) textures.  Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down.

Review URL: https://codereview.appspot.com/7200048

git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't...
bsalomon@google.com [Mon, 28 Jan 2013 15:35:28 +0000 (15:35 +0000)]
Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7228048

git-svn-id: http://skia.googlecode.com/svn/trunk@7413 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unnecessary ptr derefs int r7411 (deref result is not used).
bsalomon@google.com [Mon, 28 Jan 2013 14:31:19 +0000 (14:31 +0000)]
Remove unnecessary ptr derefs int r7411 (deref result is not used).

git-svn-id: http://skia.googlecode.com/svn/trunk@7412 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove getter of writable GrEffectStage from GrDrawState.
bsalomon@google.com [Mon, 28 Jan 2013 14:26:09 +0000 (14:26 +0000)]
Remove getter of writable GrEffectStage from GrDrawState.

Upcoming changes will require GrDrawState to know things about the set of installed effects. Thus all setting of effects must go through a GrDrawState function (setEffect()). This change accomplishes that.
Review URL: https://codereview.appspot.com/7214045

git-svn-id: http://skia.googlecode.com/svn/trunk@7411 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd missing parameter to overridden onFindClickHandler
mike@reedtribe.org [Mon, 28 Jan 2013 02:21:27 +0000 (02:21 +0000)]
add missing parameter to overridden onFindClickHandler

git-svn-id: http://skia.googlecode.com/svn/trunk@7410 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Sun, 27 Jan 2013 17:17:19 +0000 (17:17 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7409 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Sun, 27 Jan 2013 00:10:39 +0000 (00:10 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7408 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Sat, 26 Jan 2013 17:51:52 +0000 (17:51 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7407 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 26 Jan 2013 07:06:02 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7406 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest for (SkipBuildbotRuns) II
rmistry@google.com [Fri, 25 Jan 2013 22:06:14 +0000 (22:06 +0000)]
Test for (SkipBuildbotRuns) II

git-svn-id: http://skia.googlecode.com/svn/trunk@7405 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest for (SkipBuildbotRuns)
rmistry@google.com [Fri, 25 Jan 2013 21:41:12 +0000 (21:41 +0000)]
Test for (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7404 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoManually parse arguments in submit_try
borenet@google.com [Fri, 25 Jan 2013 20:55:35 +0000 (20:55 +0000)]
Manually parse arguments in submit_try

Argparse not supported with Python < 2.7.
Review URL: https://codereview.appspot.com/7206054

git-svn-id: http://skia.googlecode.com/svn/trunk@7403 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test (SkipBuildbotRuns)
rmistry@google.com [Fri, 25 Jan 2013 20:25:30 +0000 (20:25 +0000)]
Whitespace change to test (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7402 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Handle invalid glyph IDs on drawText methods.
vandebo@chromium.org [Fri, 25 Jan 2013 19:27:23 +0000 (19:27 +0000)]
[PDF] Handle invalid glyph IDs on drawText methods.

Review URL: https://codereview.appspot.com/7179053

git-svn-id: http://skia.googlecode.com/svn/trunk@7401 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix nextRangeU(0, MAX_UINT) div by zero.
bsalomon@google.com [Fri, 25 Jan 2013 19:19:20 +0000 (19:19 +0000)]
Fix nextRangeU(0, MAX_UINT) div by zero.

R=reed@google.com
Review URL: https://codereview.appspot.com/7201058

git-svn-id: http://skia.googlecode.com/svn/trunk@7400 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPresubmit should check that source files end in atleast one newline
rmistry@google.com [Fri, 25 Jan 2013 18:27:34 +0000 (18:27 +0000)]
Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLeave one and only one newline at the end of source files
rmistry@google.com [Fri, 25 Jan 2013 18:26:58 +0000 (18:26 +0000)]
Leave one and only one newline at the end of source files
Review URL: https://codereview.appspot.com/7216043

git-svn-id: http://skia.googlecode.com/svn/trunk@7398 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid O(n) stack space usage in qsort.
bungeman@google.com [Fri, 25 Jan 2013 18:25:17 +0000 (18:25 +0000)]
Avoid O(n) stack space usage in qsort.

git-svn-id: http://skia.googlecode.com/svn/trunk@7397 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreduce array size in debug builds for sortbench. This avoids a stack-overflow
reed@google.com [Fri, 25 Jan 2013 17:49:49 +0000 (17:49 +0000)]
reduce array size in debug builds for sortbench. This avoids a stack-overflow
due to (1) SkTQSort's bad behavior on repeated-keys, and (2) windows-debug doesn't
implement tail-recursion.

Not an issue, since we don't care about perf in our debug builds anyway.

git-svn-id: http://skia.googlecode.com/svn/trunk@7396 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove random from core to utils
bsalomon@google.com [Fri, 25 Jan 2013 17:49:03 +0000 (17:49 +0000)]
Move random from core to utils
Review URL: https://codereview.appspot.com/7193064

git-svn-id: http://skia.googlecode.com/svn/trunk@7395 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test (SkipBuildbotRuns) locally
rmistry@google.com [Fri, 25 Jan 2013 15:28:23 +0000 (15:28 +0000)]
Whitespace change to test (SkipBuildbotRuns) locally

git-svn-id: http://skia.googlecode.com/svn/trunk@7394 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly clear the part of the texture used by the device (duh!)
bsalomon@google.com [Fri, 25 Jan 2013 15:03:18 +0000 (15:03 +0000)]
Only clear the part of the texture used by the device (duh!)

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7205055

git-svn-id: http://skia.googlecode.com/svn/trunk@7393 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodoh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine
reed@google.com [Fri, 25 Jan 2013 14:52:11 +0000 (14:52 +0000)]
doh: use *srcPtr instead of src (which is now obsolete) when we check for specialLine

git-svn-id: http://skia.googlecode.com/svn/trunk@7392 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHid large dashed line optimization behind compiler flag
robertphillips@google.com [Fri, 25 Jan 2013 14:47:48 +0000 (14:47 +0000)]
Hid large dashed line optimization behind compiler flag

https://codereview.appspot.com/7133078/

git-svn-id: http://skia.googlecode.com/svn/trunk@7391 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Fri, 25 Jan 2013 13:30:20 +0000 (13:30 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7390 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Fri, 25 Jan 2013 13:09:15 +0000 (13:09 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7388 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTriggering rebuilds after r7386
rmistry@google.com [Fri, 25 Jan 2013 12:16:34 +0000 (12:16 +0000)]
Triggering rebuilds after r7386

git-svn-id: http://skia.googlecode.com/svn/trunk@7387 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 25 Jan 2013 07:06:46 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7385 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Fri, 25 Jan 2013 04:54:41 +0000 (04:54 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7384 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove ConcaveToTriangles.
bungeman@google.com [Thu, 24 Jan 2013 22:31:01 +0000 (22:31 +0000)]
Remove ConcaveToTriangles.

git-svn-id: http://skia.googlecode.com/svn/trunk@7383 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBottom-up heapsort.
bungeman@google.com [Thu, 24 Jan 2013 22:18:56 +0000 (22:18 +0000)]
Bottom-up heapsort.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7382 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix missing-case-statement warning
reed@google.com [Thu, 24 Jan 2013 22:09:06 +0000 (22:09 +0000)]
fix missing-case-statement warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7381 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 24 Jan 2013 21:47:16 +0000 (21:47 +0000)]
shape ops work in progress

first 100,000 random cubic/cubic intersections working

git-svn-id: http://skia.googlecode.com/svn/trunk@7380 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModify submit_try to work on windows
borenet@google.com [Thu, 24 Jan 2013 21:38:51 +0000 (21:38 +0000)]
Modify submit_try to work on windows
Review URL: https://codereview.appspot.com/7199053

git-svn-id: http://skia.googlecode.com/svn/trunk@7379 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd optional cull-rect to patheffects, so they can do less work if their results
reed@google.com [Thu, 24 Jan 2013 21:03:11 +0000 (21:03 +0000)]
add optional cull-rect to patheffects, so they can do less work if their results
lie outside of the current clip-bounds (the cull rect).
Review URL: https://codereview.appspot.com/7206044

git-svn-id: http://skia.googlecode.com/svn/trunk@7378 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SampleApp ANGLE mode.
bsalomon@google.com [Thu, 24 Jan 2013 20:47:18 +0000 (20:47 +0000)]
Fix SampleApp ANGLE mode.
Review URL: https://codereview.appspot.com/7206052

git-svn-id: http://skia.googlecode.com/svn/trunk@7377 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix spelling error.
bsalomon@google.com [Thu, 24 Jan 2013 19:00:02 +0000 (19:00 +0000)]
Fix spelling error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7376 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange giantdashline test to use 4 intervals, to explicitly avoid the asPoints
reed@google.com [Thu, 24 Jan 2013 18:43:32 +0000 (18:43 +0000)]
change giantdashline test to use 4 intervals, to explicitly avoid the asPoints
special case code (which we may test separately later).

git-svn-id: http://skia.googlecode.com/svn/trunk@7375 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodoh. drawRRect is not on SkDevice.... yet
reed@google.com [Thu, 24 Jan 2013 18:37:53 +0000 (18:37 +0000)]
doh. drawRRect is not on SkDevice.... yet

git-svn-id: http://skia.googlecode.com/svn/trunk@7374 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix logic bug introduced in r7346.
bsalomon@google.com [Thu, 24 Jan 2013 18:28:51 +0000 (18:28 +0000)]
Fix logic bug introduced in r7346.

git-svn-id: http://skia.googlecode.com/svn/trunk@7373 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooverride drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
reed@google.com [Thu, 24 Jan 2013 18:27:42 +0000 (18:27 +0000)]
override drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
and possibly crash trying to raster into an empty device.

http://code.google.com/p/skia/issues/detail?id=1086
Review URL: https://codereview.appspot.com/7193057

git-svn-id: http://skia.googlecode.com/svn/trunk@7372 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate to emphasis the culling aspect of the test (making the line much longer,
reed@google.com [Thu, 24 Jan 2013 17:33:21 +0000 (17:33 +0000)]
update to emphasis the culling aspect of the test (making the line much longer,
and adding hairline and non-hairline cases.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7371 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for giant dashed lines, to test future optimizations for culling
reed@google.com [Thu, 24 Jan 2013 17:17:28 +0000 (17:17 +0000)]
add bench for giant dashed lines, to test future optimizations for culling

git-svn-id: http://skia.googlecode.com/svn/trunk@7368 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH for clarity
reed@google.com [Thu, 24 Jan 2013 16:56:36 +0000 (16:56 +0000)]
use DEF_BENCH for clarity

git-svn-id: http://skia.googlecode.com/svn/trunk@7367 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove method calls on invalid "this" pointer.
bungeman@google.com [Thu, 24 Jan 2013 16:38:23 +0000 (16:38 +0000)]
Remove method calls on invalid "this" pointer.
https://codereview.appspot.com/7198050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7366 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe oval path bench tests used to draw a circle, but I changed them to an oval
jvanverth@google.com [Thu, 24 Jan 2013 15:45:35 +0000 (15:45 +0000)]
The oval path bench tests used to draw a circle, but I changed them to an oval
so that we could track performance changes for ovals. However, rendering the
stroked oval cases are now ~5ms slower since they're larger. This restores them
to something close to their original performance by slightly shrinking the
bounds. This will help determine what effect r7304 may have had.

git-svn-id: http://skia.googlecode.com/svn/trunk@7365 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix sort test.
bungeman@google.com [Thu, 24 Jan 2013 15:06:47 +0000 (15:06 +0000)]
Fix sort test.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7364 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 15:01:22 +0000 (15:01 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7363 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake all GrContext members that return a texture also ref the texture for the caller.
bsalomon@google.com [Thu, 24 Jan 2013 14:46:47 +0000 (14:46 +0000)]
Make all GrContext members that return a texture also ref the texture for the caller.
Review URL: https://codereview.appspot.com/7198049

git-svn-id: http://skia.googlecode.com/svn/trunk@7362 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv
junov@chromium.org [Thu, 24 Jan 2013 14:38:23 +0000 (14:38 +0000)]
Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv

The purpose of this code move is to make it re-usable in order to implement
occlusion culling optimizations in SkPicture similar to what we have now
in SkDeferredCanvas.

BUG=https://code.google.com/p/chromium/issues/detail?id=164530
Review URL: https://codereview.appspot.com/7196046

git-svn-id: http://skia.googlecode.com/svn/trunk@7361 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 24 Jan 2013 07:06:13 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7357 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 04:15:57 +0000 (04:15 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7356 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd deferred count to GrResource.
bsalomon@google.com [Wed, 23 Jan 2013 21:37:01 +0000 (21:37 +0000)]
Add deferred count to GrResource.

This will be used to determine whether a resource can either be deleted or reinserted in the cache when its ref count reaches zero.
Review URL: https://codereview.appspot.com/7202046

git-svn-id: http://skia.googlecode.com/svn/trunk@7355 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug introduced in r7348, deleting wrapped resources.
bsalomon@google.com [Wed, 23 Jan 2013 21:32:32 +0000 (21:32 +0000)]
Fix bug introduced in r7348, deleting wrapped resources.

git-svn-id: http://skia.googlecode.com/svn/trunk@7354 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace gcl_try with submit_try
borenet@google.com [Wed, 23 Jan 2013 20:54:29 +0000 (20:54 +0000)]
Replace gcl_try with submit_try

submit_try supports both git and svn and hooks directly into depot_tools rather
than calling it in a subprocess.
Review URL: https://codereview.appspot.com/7202044

git-svn-id: http://skia.googlecode.com/svn/trunk@7352 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanges per-tile bench values to use the average of repetitions from new bench log...
bensong@google.com [Wed, 23 Jan 2013 20:51:17 +0000 (20:51 +0000)]
Changes per-tile bench values to use the average of repetitions from new bench log output.
Corresponding logs change was done at https://codereview.appspot.com/7101060/ and this CL needs to be submitted together with that one for data consistency. Then we can turn on timePerTile.
Review URL: https://codereview.appspot.com/7193051

git-svn-id: http://skia.googlecode.com/svn/trunk@7351 2bbb7eff-a529-9590-31e7-b0007b416f81