Keerat Singh [Tue, 8 Jan 2019 23:59:29 +0000 (15:59 -0800)]
Merge pull request dotnet/corefx#34268 from AfsanehR/CredentialsFixMaster
Fix passing null for credentials in SqlConnectionPoolKey in master
Commit migrated from https://github.com/dotnet/corefx/commit/
2ff4a40aa0865e4bcaf85016188c77d52b24ec56
Santiago Fernandez Madero [Tue, 8 Jan 2019 23:59:07 +0000 (15:59 -0800)]
Fix Helix Repo Name to be dotnet/corefx in telemetry (dotnet/corefx#34448)
Commit migrated from https://github.com/dotnet/corefx/commit/
bbc48e258b10344207cc329c4340f3babf3aadb3
Santiago Fernandez Madero [Tue, 8 Jan 2019 23:42:09 +0000 (15:42 -0800)]
Enable helix telemetry for official builds and PRs (dotnet/corefx#34441)
* Enable helix telemetry for official builds and PRs
* Only send telemetry for official builds
Commit migrated from https://github.com/dotnet/corefx/commit/
2acc3e4858d5305bbf8b51d5f3797c1cd41c3912
Dan Moseley [Tue, 8 Jan 2019 23:36:06 +0000 (15:36 -0800)]
Fix sorted list syncroot test (dotnet/corefx#34446)
Commit migrated from https://github.com/dotnet/corefx/commit/
cba3c6416f311779dc77e25161d450b1456ec0ab
dotnet-maestro-bot [Tue, 8 Jan 2019 22:23:42 +0000 (14:23 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27308-03, preview.19058.1, beta-27308-00, beta-27308-00, respectively (dotnet/corefx#34375)
Commit migrated from https://github.com/dotnet/corefx/commit/
d9f66e827ccec86f8663878206a7431f1a1c2cf9
Dan Moseley [Tue, 8 Jan 2019 18:16:06 +0000 (10:16 -0800)]
Fix path length 255 (dotnet/corefx#34389)
* long name test
* typo
* typo
* Enable test as WSL fixed
* Disable test for WSL
* Test update
* Fix tests
* Properly reuse buffer length
* Fix actual bug
* Tests for create on Linux
* Extend to unix
* netfx
* Update interop file
Commit migrated from https://github.com/dotnet/corefx/commit/
23521cc75428e38b8ff62cbac188c86b32184d42
Viktor Hofer [Tue, 8 Jan 2019 17:01:35 +0000 (18:01 +0100)]
Stop building native components for netfx (dotnet/corefx#34382)
* Stop building native components for netfx
* Remove unnecessary condition in build.proj
Commit migrated from https://github.com/dotnet/corefx/commit/
492a1f993c347f3c4b0f64ab7fc20b3b095b5f1d
Viktor Hofer [Tue, 8 Jan 2019 16:46:36 +0000 (17:46 +0100)]
Add SyncSortedList serialization test and remove SyncRoot (dotnet/corefx#34339)
* Add SyncSortedList serialization tests and remove SyncRoot
* Disable blob comparison for SyncSortedList
On UWP we get different blobs for SyncSortedList as reflection behaves
differently as the amount of types that we tests is less than in
.NET Core and .NET Framework. The order of fields that are serialized
into the payload are different in such a case.
Therefore we just disable the blob comparison for this type entirely.
Commit migrated from https://github.com/dotnet/corefx/commit/
de591233c04efa019ea2aed0a8fc5181f6d4210b
Stephen Toub [Tue, 8 Jan 2019 14:09:24 +0000 (09:09 -0500)]
Fix UriParser static table thread safety (dotnet/corefx#34411)
There are two static Dictionaries in UriParser that are read without holding a lock and modified while holding a lock; while it is safe for any number of readers to be concurrently accessing a dictionary, it is not safe for any positive number of readers to be doing so while there's at least one writer. Based on how this code is written, my assumption is that at some point is was implemented using Hashtable, which does make such a situation safe. As such, I'm fixing it by just switching back to using Hashtable; in the process, I'm also removing the static cctor and fixing a few readonly statics to instead be const.
I considered a few alternate implementations, including using an immutable dictionary, but this approach is simple and fast enough, and doesn't incur some of the costs other schemes would.
Commit migrated from https://github.com/dotnet/corefx/commit/
47b47e0b2247856f1cf630535b7d821ea2ad60eb
Tomasz Heimowski [Tue, 8 Jan 2019 08:12:24 +0000 (09:12 +0100)]
Add EventLog Reader to the System.Diagnostics.EventLog dll/package (dotnet/corefx#33662)
* Adding EventLog Reader to the System.Diagnostics.EventLog dll/package.
This addresses issue https://github.com/dotnet/corefx/issues/31358
The code came from https://github.com/PowerShell/PowerShell/tree/master/src/Microsoft.PowerShell.CoreCLR.Eventing, which in turn came from the .NET Desktop framework Dll System.Core.dll. It was slightly modified to conform to codeing conventions, but there should be no semantic changes.
Note that System.Diagnostic.EventLog already exists as a Nuget package and is part of the Microsoft.Windows.Compatability Nuget package. Previously this package/DLL only containd the 'write' APIs associated with the Windows EventLog. This adds the EventLogReader and associated classes.
This package is mostly useful for .NET Core users who need to read the windows EventLog.
This PR is not ready to check in because there are no tests for the reader functionality. This is where we need some community help. Basicaly we need
some tests (fill out hte EventReaderTests.cs file).
If you are willing to help please leave a comment to that effect. You can pull this pull request to your fork and immediately start adding tests. We will
figure out how to get all edits pushed in when that time arrives.
* Application Event Log Record test
* Application Event Log Query Record test
* Nested Event Log tests
* Event Log Watcher tests
* Fix copyright headers
* Ran VS formatter on all files
* Combine tests using Theory in EventLogReaderTests
* Add more tests
* Reach 60% Code coverage
* - Removes SecurityCritical and SecuritySafeCritical attributes
- Removes unecessary or duplicated comments
- Removed extra blank lines
- Use nameof on ArgumentNullException calls
* Fix XML doc
* Remove dead EventPropertyContext
* Test fixes
* - Fix failing tests, moves test statements to ..Throws/..ReturnsEmpty
- Uses exact type rather than var
- lower case for variable name
- Remove [UnmanagedType.Bool] when redundant in UnsafeNativeMethods
Conflicts:
src/System.Diagnostics.EventLog/tests/EventLogReaderTests/EventLogSessionTests.cs
* - Minor comment cleanup
- using goes outside of namespace
* - Removes SuppressUnmanagedCodeSecurityAttribute attribute
- Minor comment and spacing cleanup
* - Move tests to proper folder and add coverage
* Add more test coverage and apply some review feedbacks
* - Switch condition for two more tests to IsElevatedAndSupportsEventLogs
- Simplify ReadEventPsh using ReadEvent rather than duplicated code block
- Remove comment
- Add comment explaining why I comment out: session.ClearLog(logName: "Application")
- Remove and sort usings
- code cleanup
* Attempt to fix CI failures
* Skip test on netfx fixing FormatDescription bug
* Add test for EventLogSesstion.ClearLog(..)
* Add missing Dispose on EventRecord
Commit migrated from https://github.com/dotnet/corefx/commit/
ca9550b649151c30698fbd6e0445f50d3b7385d4
Davis Goodin [Tue, 8 Jan 2019 01:00:41 +0000 (19:00 -0600)]
Revert "Fix runtime.depproj allconfigurations restore" (dotnet/corefx#34409)
This reverts commit dotnet/corefx@
98aac1eab50bcc379c14e85fb1f530d2858cc8f6.
Commit migrated from https://github.com/dotnet/corefx/commit/
97d3ca8b3ed8c0af48ac4f346b00553e1d2cecd8
Santiago Fernandez Madero [Mon, 7 Jan 2019 23:17:03 +0000 (15:17 -0800)]
Use VS2017 always as project generator in native build (dotnet/corefx#34412)
Commit migrated from https://github.com/dotnet/corefx/commit/
875c9842c94fdf3885a7cd28497d492bdd584543
Josh Free [Mon, 7 Jan 2019 21:58:18 +0000 (13:58 -0800)]
Update issue-guide.md
Minor January corefx namespace ownership shuffle
1. JeremyKuhne ->
1. changes from Primary to Backup owner for System.Buffers (moves to layomia)
2. krwq ->
1. changes from Primary to Backup owner for System.Text.Encoding (moves to layomia)
2. removed as Backup owner for System.Text.Encodings.Web
3. layomia ->
1. add as Primary owner for System.Buffers
2. add as Primary owner for System.Text.Encoding
3. add as Backup owner for System.Text.Encodings.Web
Commit migrated from https://github.com/dotnet/corefx/commit/
cfc15f4413215449a75dbb44f16cafa569aacf4a
Joseph Lennox [Mon, 7 Jan 2019 19:34:23 +0000 (11:34 -0800)]
dotnet/corefxdotnet/corefx#34200 Bring `XmlRawTextWriterGenerator.cxx` up to date. (dotnet/corefx#34224)
* dotnet/corefxdotnet/corefx#34200 Bring `XmlRawTextWriterGenerator.cxx` up to date.
* dotnet/corefxdotnet/corefx#34200 Convert `XmlRawTextWriterGenerator.cxx` to t4.
* dotnet/corefxdotnet/corefx#34200 Normalize the inconsistent use of `this`
* dotnet/corefxdotnet/corefx#34200 Make XmlRawTextWriterGenerator run at compile time.
* dotnet/corefxdotnet/corefx#34200 Generate Xml*RawTextWriterAsync.cs files.
These files appear to of never been from a generation process but are
near identical.
* dotnet/corefxdotnet/corefx#34200 Normalize `this` in XmlRawTextWriterGeneratorAsync
* dotnet/corefxdotnet/corefx#34200 Convert Html*RawTextWriter.cs to t4 template.
* dotnet/corefxdotnet/corefx#34200 Convert Text*RawTextWriter.cs to t4 template.
* dotnet/corefxdotnet/corefx#34200 Normalize use of `this` in Html*RawTextWriter.
* dotnet/corefxdotnet/corefx#34200 Fix leading whitespace/bug #
* dotnet/corefxdotnet/corefx#34200 Add warning to generate files about modifying them.
Also fix the oversight that XmlRawTextWriterGeneratorAsync.ttinclude didn't
use the newer RawTextWriter.ttinclude abstraction.
* dotnet/corefxdotnet/corefx#34200 Make code generation produce better formatted code.
Commit migrated from https://github.com/dotnet/corefx/commit/
a0e5f73d0c0876840bc4f3745e1ca8385a91cfcf
Viktor Hofer [Sat, 5 Jan 2019 19:06:23 +0000 (20:06 +0100)]
Remove HAVE_VSNPRINTF block from CMakeLists
Commit migrated from https://github.com/dotnet/corefx/commit/
66985ca21f89e4d2230f5fcb99f4e8b3d618c9af
Viktor Hofer [Sat, 5 Jan 2019 18:03:37 +0000 (19:03 +0100)]
Add include for check symbol exists in cmakelists
Commit migrated from https://github.com/dotnet/corefx/commit/
0c1d1d43170f259600749ce93850962374692e97
Viktor Hofer [Sat, 5 Jan 2019 17:58:35 +0000 (18:58 +0100)]
Update cmakelists vs check
Commit migrated from https://github.com/dotnet/corefx/commit/
bfe0055b8bfdccf4834d7ff576bae4064e90fa3e
Viktor [Sat, 5 Jan 2019 13:34:49 +0000 (14:34 +0100)]
Move minimum VS version to 2017
Commit migrated from https://github.com/dotnet/corefx/commit/
d2724104fc711c5f0d47c4c23bf3a1d50f036286
Davis Goodin [Mon, 7 Jan 2019 19:16:45 +0000 (13:16 -0600)]
Fix runtime.depproj allconfigurations restore (dotnet/corefx#34332)
* Fix runtime.depproj allconfigurations restore
Use default PackageRID for RuntimeIdentifier, not the overridden value
from build args. In allconfigurations mode, using PackageRID can cause
the wrong assets to be restored for other configurations.
* Incorporate $(RuntimeOS)-$(ArchGroup) defaulting
Commit migrated from https://github.com/dotnet/corefx/commit/
98aac1eab50bcc379c14e85fb1f530d2858cc8f6
Santiago Fernandez Madero [Mon, 7 Jan 2019 17:57:41 +0000 (09:57 -0800)]
Cleanup publish.proj to use arcade's target to push to blob feed (dotnet/corefx#34373)
Commit migrated from https://github.com/dotnet/corefx/commit/
21e5926a140fc76dfa54e3e80e4cb87b04e33a6d
Viktor [Mon, 7 Jan 2019 13:48:34 +0000 (14:48 +0100)]
Fix S.Drawing.Common perf runs
Commit migrated from https://github.com/dotnet/corefx/commit/
b6d532f5f408560ecec2fb217390f9ac274f370c
Stephen Toub [Sun, 6 Jan 2019 23:00:34 +0000 (18:00 -0500)]
Disable failing ValidateToStringUsingWhoami/ValidateToString tests (dotnet/corefx#34396)
* Disable failing ValidateToStringUsingWhoami test
* Also disable ValidateToString
It similarly assumes the sddl begins with S-1-5-, which mine does not.
Commit migrated from https://github.com/dotnet/corefx/commit/
2bf00161a1e89db28d62330043165d7c30da25b3
Stephen Toub [Sat, 5 Jan 2019 18:45:29 +0000 (13:45 -0500)]
Remove some unnecessary Substrings in System.Net.Http (dotnet/corefx#34356)
Commit migrated from https://github.com/dotnet/corefx/commit/
bcd20ce6fa0c7580ac4976cb50747687d07d96b2
Viktor [Sat, 5 Jan 2019 10:46:50 +0000 (11:46 +0100)]
Fix paths with spaces in ilproj
Commit migrated from https://github.com/dotnet/corefx/commit/
e38bad57a66fd6140da5953a182cd1c3a4ef332a
Viktor [Sat, 5 Jan 2019 10:46:35 +0000 (11:46 +0100)]
Fix python invocation in perf runs
Commit migrated from https://github.com/dotnet/corefx/commit/
271aa6c8bc65d0e9232f44646ca3ef3afacbb818
Viktor [Fri, 4 Jan 2019 14:52:45 +0000 (15:52 +0100)]
Initialize TraceEvent dependencies correctly
Commit migrated from https://github.com/dotnet/corefx/commit/
9c736899cd63805d7bbf69095d9b32915b9e1858
Viktor [Fri, 4 Jan 2019 13:45:04 +0000 (14:45 +0100)]
Fix unix perf runs
Commit migrated from https://github.com/dotnet/corefx/commit/
6ec1a4e15a89ddcbe0dce1f31f0a9eda268aa729
Anirudh Agnihotry [Fri, 4 Jan 2019 23:20:57 +0000 (15:20 -0800)]
set the nanoseconds properties deterministically (dotnet/corefx#34362)
Commit migrated from https://github.com/dotnet/corefx/commit/
db259b0302a866e2ff31a7d2c343abcc176ba4f4
Dan Moseley [Fri, 4 Jan 2019 23:05:34 +0000 (15:05 -0800)]
Disable TestService tests on NETFX (dotnet/corefx#34365)
Commit migrated from https://github.com/dotnet/corefx/commit/
96a13e8f2ddad96f065dfe64e074fb099899bc5d
Geoff Kizer [Fri, 4 Jan 2019 22:40:30 +0000 (14:40 -0800)]
Merge pull request dotnet/corefx#34347 from geoffkizer/decomptests
consolidate decompression tests
Commit migrated from https://github.com/dotnet/corefx/commit/
814775ca14faff98602ad2d33f8f443e1e7dce24
Viktor [Thu, 3 Jan 2019 16:12:56 +0000 (17:12 +0100)]
React to ApiCompat and GenAPI cmd changes
Commit migrated from https://github.com/dotnet/corefx/commit/
bffbb115f0c02051836ca72790b85d3a2c8aa71f
Viktor [Wed, 2 Jan 2019 16:51:05 +0000 (17:51 +0100)]
Fix build error with space in pathFix buildtools restore with paths with spaces
Commit migrated from https://github.com/dotnet/corefx/commit/
76ad9b00cc1b7d7ed40b16934d534df756c0ffed
Santiago Fernandez Madero [Fri, 4 Jan 2019 22:19:31 +0000 (14:19 -0800)]
Split official build tests results type and print mc url (dotnet/corefx#34371)
Commit migrated from https://github.com/dotnet/corefx/commit/
579dcb0ec20aed31e2cd9e172eb278543d3935be
Dan Moseley [Fri, 4 Jan 2019 21:18:46 +0000 (13:18 -0800)]
Disable ProcessStart_OpenFileOnLinux_UsesSpecifiedProgramUsingArgumentList on Alpine (dotnet/corefx#34360)
Commit migrated from https://github.com/dotnet/corefx/commit/
ddbbb7c83211f07a8731601a8cf26b85dd16ff76
Josh Free [Fri, 4 Jan 2019 19:28:23 +0000 (11:28 -0800)]
Merge pull request dotnet/corefx#34354 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx to preview-27304-02, preview.19054.1, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
4f3baf982bbeacdd164cf125f839f91787816d2d
Stephen Toub [Fri, 4 Jan 2019 18:31:44 +0000 (13:31 -0500)]
Remove stale comments from System.Linq.Queryable (dotnet/corefx#34357)
Commit migrated from https://github.com/dotnet/corefx/commit/
491631805be037bdf05dc67cab873874fadcd01e
dotnet-maestro-bot [Fri, 4 Jan 2019 15:12:11 +0000 (07:12 -0800)]
Update CoreClr, CoreFx to preview-27304-02, preview.19054.1, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
5f009736e46746fb6aaef810dc2bb2f64ed6bf84
Liudmila Molkova [Fri, 4 Jan 2019 14:00:07 +0000 (06:00 -0800)]
Do not add Request-Id header when its added already (dotnet/corefx#34321)
Commit migrated from https://github.com/dotnet/corefx/commit/
fe6e895de1fe78c5e677895a1dcf1f6339561153
dotnet-maestro-bot [Fri, 4 Jan 2019 12:40:08 +0000 (04:40 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27304-00, beta-27304-00, respectively (dotnet/corefx#34348)
Commit migrated from https://github.com/dotnet/corefx/commit/
58163f5881deff10680fcc590ead08532cbf6f54
Stephen Toub [Fri, 4 Jan 2019 02:26:46 +0000 (21:26 -0500)]
Add StringExtensions.Concat to fix Microsoft.IO.Redist assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
52dddbb7c067442b093735a6856d4ef76430753a
dotnet-maestro-bot [Fri, 4 Jan 2019 06:13:51 +0000 (22:13 -0800)]
Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview1-03603-01, preview-27304-01, preview.19053.3, beta-27303-00, beta-27303-00, respectively (dotnet/corefx#34323)
Commit migrated from https://github.com/dotnet/corefx/commit/
f74b39562ad0e3b33715172d48eced02c7ca384f
Jeremy Barton [Fri, 4 Jan 2019 06:07:55 +0000 (22:07 -0800)]
Merge pull request dotnet/corefx#34324 from vcsjones/32913-oaep-cek
Support SHA2 for OAEP decryption in EnvelopedCms
Commit migrated from https://github.com/dotnet/corefx/commit/
3c6662c9b96b8fae2c3fb3191d14b9b0a76909a5
Kevin Jones [Thu, 3 Jan 2019 06:18:19 +0000 (01:18 -0500)]
Added SHA2 OAEP decryption support for EnvelopedCms CEK.
Fixes dotnet/corefx#32913.
Commit migrated from https://github.com/dotnet/corefx/commit/
1de58afa5edd914cbc50cb2cbcf87cc4278b10b8
Kevin Jones [Thu, 3 Jan 2019 02:06:31 +0000 (21:06 -0500)]
Fix typo in parameter name.
Commit migrated from https://github.com/dotnet/corefx/commit/
74f041bdfb2ccf9a42ffeb5a000808c24a1a18d9
Anirudh Agnihotry [Fri, 4 Jan 2019 02:00:04 +0000 (18:00 -0800)]
increase tries to 20 (dotnet/corefx#34342)
Commit migrated from https://github.com/dotnet/corefx/commit/
df4c956d32654e77e799e538a67a2c7b13e656d4
Geoff Kizer [Fri, 4 Jan 2019 01:33:45 +0000 (17:33 -0800)]
consolidate decompression tests
Commit migrated from https://github.com/dotnet/corefx/commit/
474b87aeaa9c0ddfe411d3a5d473a20c35f28622
Geoff Kizer [Thu, 3 Jan 2019 22:58:52 +0000 (14:58 -0800)]
Merge pull request dotnet/corefx#34307 from geoffkizer/redirecttests
split redirect tests into separate file
Commit migrated from https://github.com/dotnet/corefx/commit/
b4ff5f37b4e425e8ab8a5f6cbe62b0373d72437f
Stephen Toub [Thu, 3 Jan 2019 16:34:52 +0000 (11:34 -0500)]
Use ValueStringBuilder instead of StringBuilderCache in PathInternal.Windows.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
94cf6be593098451257e96406b39fd9790d121b5
Santiago Fernandez Madero [Thu, 3 Jan 2019 21:04:44 +0000 (13:04 -0800)]
Update ubuntu arm64 queues to 1804 in official builds (dotnet/corefx#34337)
Commit migrated from https://github.com/dotnet/corefx/commit/
020b88ca7cd23ccff37eea8eba9d59d52ec8d3cd
zivillian [Thu, 3 Jan 2019 20:07:19 +0000 (21:07 +0100)]
Fix missing dash in LDAP test server example (dotnet/corefx#34336)
* fix missing dash
* fix copied configuration
Commit migrated from https://github.com/dotnet/corefx/commit/
e48041feb1a4b9660eb0d26e2e43241237da0eaf
Davis Goodin [Thu, 3 Jan 2019 19:44:30 +0000 (13:44 -0600)]
Fix testhost depproj chmod when win host restored (dotnet/corefx#34335)
When building on Linux, this Exec assumes a Linux configuration is
restored so the testhost package it picks up will have dotnet. This
fails with '-allconfigurations' when a Windows configuration is used and
the restore actually got dotnet.exe. This change detects whatever dotnet
file was actually restored and runs chmod on that.
Commit migrated from https://github.com/dotnet/corefx/commit/
70d08ae0b1f2487f0684a66be364a988f181567d
Roman Marusyk [Thu, 3 Jan 2019 18:28:46 +0000 (20:28 +0200)]
Refactor DllImports for System.Security.Cryptography.Pkcs to share in Common/Interop
Commit migrated from https://github.com/dotnet/corefx/commit/
e32bdde06baadcc02143e012bdc7929ceb57c071
Dong Xie [Thu, 3 Jan 2019 16:10:08 +0000 (16:10 +0000)]
Per issue dotnet/corefx#34302, removed an extra 0x1a at end of file. (dotnet/corefx#34328)
Commit migrated from https://github.com/dotnet/corefx/commit/
5c55936c24bb6a2038d3eb5a68d4a51011d02284
Swaroop Sridhar [Thu, 3 Jan 2019 04:53:10 +0000 (20:53 -0800)]
Revert "Expose Marshall.LoadLibrary API" (dotnet/corefx#34322)
In API review: https://github.com/dotnet/corefx/issues/32015,
The LoadLibrary APIs were originally Approved to live in
System.Runtime.InteropServices.Marshal class.
https://github.com/dotnet/corefx/issues/32015#issuecomment-
428775858
However, recently the decision was changed such that the APIs are in a new NativeLibrary class.
https://github.com/dotnet/corefx/issues/32015#issuecomment-
448324606
Therefore, undoing the changes to Marshal API.
I'll submit another PR for System.Runtime.InteropServices.NativeLibrary
once the corresponding change in CoreCLR is checked in.
This reverts commit dotnet/corefx@
859351c2f65e73e94c9c40983e53b33c5b45014a.
Commit migrated from https://github.com/dotnet/corefx/commit/
6d59e6ab54bb313ea5eb6a809dc64a7cebe8ee64
Anirudh Agnihotry [Wed, 2 Jan 2019 23:12:21 +0000 (15:12 -0800)]
Using FUTIMENS instead of FUTIMES (dotnet/corefx#34271)
* test added
* rearranging order for if statements
* reducing thread sleep time and reverting millisecond test change
* adding comment
* removing comment, adding tick equality check, failing if not able to create file with non-zero nano or milli second
* correcting test for hfs system
* NanoSeconds -> Nanoseconds, Millisec -> milliseconds
HFs assert converted to false
Commit migrated from https://github.com/dotnet/corefx/commit/
83e468591a0212f109c179c2f4b75ef03c92432b
dotnet-maestro-bot [Wed, 2 Jan 2019 18:02:30 +0000 (10:02 -0800)]
Update CoreClr, CoreFx to preview-27302-02, preview.19052.1, respectively (dotnet/corefx#34311)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e8d162c1486d1473a74263894e509bc85a1b861
dotnet-maestro-bot [Wed, 2 Jan 2019 13:48:06 +0000 (05:48 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27302-01, preview.19051.1, beta-27302-00, beta-27302-00, respectively (dotnet/corefx#34245)
Commit migrated from https://github.com/dotnet/corefx/commit/
3e84824e93861dbf0b53a7f111ec211d9f787c2b
Koundinya Veluri [Wed, 2 Jan 2019 13:31:47 +0000 (05:31 -0800)]
Don't Sleep(1) in some spin-wait loops (Fx) (dotnet/corefx#34288)
Fx counterpart to https://github.com/dotnet/coreclr/pull/21722
Commit migrated from https://github.com/dotnet/corefx/commit/
4b6cc4f99e3af21525da967cfbba219b6620a51e
Jan Kotas [Wed, 2 Jan 2019 13:31:06 +0000 (03:31 -1000)]
Delete one-off AppDomain setter for uapaot first chance exception handler (dotnet/corefx#34304)
This should not be one-off. It should be either nowhere or everywhere.
Commit migrated from https://github.com/dotnet/corefx/commit/
344aca842de08a897a560e3465f2885480a1e318
Geoff Kizer [Tue, 1 Jan 2019 23:53:35 +0000 (15:53 -0800)]
split redirect tests into separate file
Commit migrated from https://github.com/dotnet/corefx/commit/
33aa830e7975d6fdf50143348cb78f2924d673de
Geoff Kizer [Tue, 1 Jan 2019 20:58:34 +0000 (12:58 -0800)]
Merge pull request dotnet/corefx#34298 from geoffkizer/flakytest-SchSendAuxRecordHttpTest
disable flaky test SchSendAuxRecordHttpTest
Commit migrated from https://github.com/dotnet/corefx/commit/
fed12d49fd08018d2b31300f0d591071e0da7c12
Geoff Kizer [Mon, 31 Dec 2018 23:30:36 +0000 (15:30 -0800)]
disable flaky test SchSendAuxRecordHttpTest
Commit migrated from https://github.com/dotnet/corefx/commit/
d08226feeb0af0ff41c8d41b36ba8f6bb97c1785
Egor Bogatov [Mon, 31 Dec 2018 02:05:27 +0000 (05:05 +0300)]
Remove Interop.ReadDir.cs (dotnet/corefx#34274)
* Remove Interop.ReadDir.cs
* pass bufferPtr to FindNextEntry
* Update src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Unix.cs
Co-Authored-By: EgorBo <egorbo@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
91589339e6fd3da57d8e6c15937253037e727a04
Marco Rossignoli [Sun, 30 Dec 2018 16:59:39 +0000 (17:59 +0100)]
Improve dogfooding guide (dotnet/corefx#34284)
Commit migrated from https://github.com/dotnet/corefx/commit/
6c94c21afe03d2b9ffbbd80df26ad49587559a9b
Afsaneh Rafighi [Fri, 28 Dec 2018 18:12:13 +0000 (10:12 -0800)]
fix passing credentials null
Commit migrated from https://github.com/dotnet/corefx/commit/
f168162c018b3e215e008d0bee94be85c76a8fe7
Jan Kotas [Thu, 27 Dec 2018 07:36:20 +0000 (23:36 -0800)]
Use common copy of System.Numerics.Hashing.HashHelpers
Commit migrated from https://github.com/dotnet/corefx/commit/
4e3797e2ff40575b08f08849970f100b2ab5ced1
Marco Rossignoli [Thu, 27 Dec 2018 13:45:30 +0000 (14:45 +0100)]
Update dogfooding guide (dotnet/corefx#34246)
Commit migrated from https://github.com/dotnet/corefx/commit/
e001e65c6ceef7fc06fd569c871f604014de76e7
Dan Moseley [Thu, 27 Dec 2018 03:53:15 +0000 (19:53 -0800)]
Update pinvoke guidelines (dotnet/corefx#34249)
* Update pinvoke guidelines
Added some clarification on the width of types, on padding, and the `fixed` keyword. All these were things I had to figure out recently, so it would be useful to document for others.
* Update interop-pinvokes.md
* Update interop-pinvokes.md
* Update interop-pinvokes.md
* Update interop-pinvokes.md
* Update interop-pinvokes.md
* Update interop-pinvokes.md
Commit migrated from https://github.com/dotnet/corefx/commit/
103ef55a43b93815277a0b6771e19675730e8ab7
dotnet-maestro-bot [Wed, 26 Dec 2018 08:04:09 +0000 (00:04 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27226-01, preview.18625.2, beta-27226-00, beta-27226-00, respectively (dotnet/corefx#34241)
Commit migrated from https://github.com/dotnet/corefx/commit/
04d5f81efc341cf7f682f5cd05dffe71d7813148
dotnet-maestro-bot [Tue, 25 Dec 2018 18:40:57 +0000 (10:40 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27225-02, preview.18625.1, beta-27225-00, beta-27225-00, respectively (dotnet/corefx#34235)
Commit migrated from https://github.com/dotnet/corefx/commit/
74b4172bf0c4ae9842d67fb066760eec2e435164
Jan Kotas [Sun, 23 Dec 2018 00:41:06 +0000 (16:41 -0800)]
Stop building System.Threading.Tasks.Extensions package
Fixes build breaks after shared CoreLib updates
Commit migrated from https://github.com/dotnet/corefx/commit/
f83cc7ec2e4aadf07c0f943a50906a144ad2e544
Stanislav Ushakov [Mon, 24 Dec 2018 17:17:29 +0000 (20:17 +0300)]
Removed global suppression of CS1573 and CS1591 warnings (dotnet/corefx#34232)
* Removed global suppression of CS1573 and CS1591, moved suppression to the project level.
* Fixes for netfx build, added 2 projects
Commit migrated from https://github.com/dotnet/corefx/commit/
adb4d48fe65d48b6dd1c2ff15c8a60e5f96bf266
dotnet-maestro-bot [Mon, 24 Dec 2018 17:15:44 +0000 (09:15 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27224-02, preview.18624.1, beta-27224-00, beta-27224-00, respectively (dotnet/corefx#34231)
Commit migrated from https://github.com/dotnet/corefx/commit/
c0638cff18ac86b755d84cbc1fb5bd81aa0a36e7
dotnet-maestro-bot [Mon, 24 Dec 2018 05:49:53 +0000 (21:49 -0800)]
Update CoreClr, CoreFx to preview-27224-01, preview.18623.2, respectively (dotnet/corefx#34230)
Commit migrated from https://github.com/dotnet/corefx/commit/
1d1bdc18310ecc2c7b99e23b379d75ad6feab8da
dotnet-maestro-bot [Sun, 23 Dec 2018 20:50:09 +0000 (12:50 -0800)]
Update CoreClr, CoreFx to preview-27223-02, preview.18623.1, respectively (dotnet/corefx#34226)
Commit migrated from https://github.com/dotnet/corefx/commit/
bb5532e04529b4fc015ec725fd871593683f08a4
dotnet-maestro-bot [Sun, 23 Dec 2018 08:18:13 +0000 (00:18 -0800)]
Update CoreClr, CoreFx to preview-27222-01, preview.18621.2, respectively (master) (dotnet/corefx#34215)
* Update CoreClr, CoreFx to preview-27222-01, preview.18621.2, respectively
* CLR test fixes
* Disable test for NETFX
Commit migrated from https://github.com/dotnet/corefx/commit/
dac6b995066b98f8048f7390ea67d4664e75eaa4
Omair Majid [Sat, 22 Dec 2018 20:06:18 +0000 (15:06 -0500)]
Use HMAC_CTX_free() instead of free() on a HMAC_CTX* (dotnet/corefx#34222)
This is a leftover from before the OpenSSL 1.0/1.1 hybridization. There
was no HMAC_CTX_free() in 1.0.
Fixes dotnet/corefx#34210
Commit migrated from https://github.com/dotnet/corefx/commit/
597a07ee0945abc28b38f44e2083445c92365152
Dan Moseley [Sat, 22 Dec 2018 05:25:03 +0000 (21:25 -0800)]
Casing fixes (dotnet/corefx#34214)
* Kernel32
* Advapi32
Commit migrated from https://github.com/dotnet/corefx/commit/
352444860f8405a02d45db86cbc4aacc667536f0
Stephen Toub [Sat, 22 Dec 2018 00:39:34 +0000 (19:39 -0500)]
Replace an empty array with Array.Empty (dotnet/corefx#34209)
Happened to notice it, so changing it.
Commit migrated from https://github.com/dotnet/corefx/commit/
9a0e15d1777de9c951cec081699be03304b99bda
Dan Moseley [Sat, 22 Dec 2018 00:22:14 +0000 (16:22 -0800)]
Remove syncroot fields from collections (dotnet/corefx#34198)
* Syncroot
* Fix typo in build-native
* Specialized
* Remove noise
* Revert non generic SortedList
* Test fixups
* CLR test fixes
* Revert "CLR test fixes"
This reverts commit dotnet/corefx@
8db135c07bc0963ef3c9e01c370f06494a988a1f.
* Disable syncroot tests for NETFX
* Update QueueTests.cs
* Test fixes
* Typo
Commit migrated from https://github.com/dotnet/corefx/commit/
1fd3717d73da3ae7440841e8fded4adbba5b0770
Ahson Khan [Sat, 22 Dec 2018 00:00:54 +0000 (16:00 -0800)]
Optimize ReadOnlySequence.First for the common case (dotnet/corefx#33000)
* Optimize ReadOnlySequence.First for the common case
* Add back bit mask flags
* Revert back to type-safe casts
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
a7b5f8c08710dedf0baac4706186074ad67b5de1
Stanislav Ushakov [Fri, 21 Dec 2018 22:24:10 +0000 (01:24 +0300)]
XML documentation errors - removed references to '*.uex' files (dotnet/corefx#34203)
* Removed CS1589 warning suppression and references to non-existing 'SystemEvents.uex' file
* Fixed CS1589 for System.Drawing.*
Removed references to non-existing 'KnownColor.uex' file.
* Fixed CS1589 for System.Private.Xml.
Removed references to non-existing '*.uex' files.
* Fixed broken XML doc reference for SafeHandleCache.cs
* Fixed indents.
Commit migrated from https://github.com/dotnet/corefx/commit/
42cdb266788d970476417ba3421e999904c58991
Stephen Toub [Fri, 21 Dec 2018 21:26:58 +0000 (16:26 -0500)]
Update ExecutorTests command for Unix (dotnet/corefx#34207)
Hopefully this fixes https://github.com/dotnet/corefx/pull/34185#issuecomment-
449246163
Commit migrated from https://github.com/dotnet/corefx/commit/
646a539c8654000ae014085abbaf8167d811a827
Vasiliy Novikov [Fri, 21 Dec 2018 21:15:12 +0000 (23:15 +0200)]
Fixed IPv6 address parsing on Linux from /proc/net/tcp6, /proc/net/udp6 (dotnet/corefx#34135)
* Fixed IPv6 address parsing on Linux from /proc/net/tcp6, /proc/net/udp6
* Re-enabled IPv6-related tests in IPGlobalPropertiesTest on linux
Commit migrated from https://github.com/dotnet/corefx/commit/
70af0db84ebe722c8679210ce731f10087bd16b9
Tanner Gooding [Fri, 21 Dec 2018 21:13:25 +0000 (13:13 -0800)]
Ensure that the existing Vector2/Vector3/Vector4 intrinsic methods are marked as such. (dotnet/corefx#34167)
Commit migrated from https://github.com/dotnet/corefx/commit/
ecb9b490857a50bb8372ef221836181c9e51a333
Caesar Chen [Fri, 21 Dec 2018 21:01:03 +0000 (13:01 -0800)]
fix internal bug 645542 (dotnet/corefx#34191)
Commit migrated from https://github.com/dotnet/corefx/commit/
c5f0d445bd52222cae7418ee81d74df40e0cf3fb
Stephen Toub [Fri, 21 Dec 2018 19:19:00 +0000 (14:19 -0500)]
Remove some char[] allocations when creating XML strings (dotnet/corefx#34196)
Commit migrated from https://github.com/dotnet/corefx/commit/
d2252b283a851ce6c5c1d74da1dbbcd18c8685a3
Joseph Lennox [Fri, 21 Dec 2018 18:09:39 +0000 (10:09 -0800)]
Fix `XmlUtf8RawTextWriter` out of bounds read. (dotnet/corefx#34116)
* dotnet/corefxdotnet/corefx#34115 Fix `XmlUtf8RawTextWriter` out of bounds read.
* dotnet/corefxdotnet/corefx#34115 Fix `HtmlEncodedRawTextWriter` out of bounds read.
* dotnet/corefxdotnet/corefx#34115 Update out of bounds checks per review.
Commit migrated from https://github.com/dotnet/corefx/commit/
a3bdd04b2866f7c892da718070e78bf43cda7e5f
Max Kerr [Fri, 21 Dec 2018 18:02:46 +0000 (10:02 -0800)]
Improve handling of disallowed HTTP/2 frames (dotnet/corefx#34188)
Additional tests and minor error handling changes.
Commit migrated from https://github.com/dotnet/corefx/commit/
d5c4c725c2ee768c93be94a90342f88ef3a584d4
dotnet-maestro-bot [Fri, 21 Dec 2018 16:59:17 +0000 (08:59 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27221-02, preview.18621.1, beta-27221-00, beta-27221-00, respectively (dotnet/corefx#34201)
Commit migrated from https://github.com/dotnet/corefx/commit/
cd402c39b04d5d007b33ac7724b52b2313862b38
Wraith2 [Fri, 21 Dec 2018 16:07:20 +0000 (16:07 +0000)]
Optimize SqlClient tds state to remove handle boxing (dotnet/corefx#34044)
* change TdsParserStateObject to pass packets using a ref struct to avoid boxing of IntPtr in native mode
* add project define for FEATURE_INTEROPSNI on windows non uap builds
* update interop to use SniPacketHandle type name
* rename SNIPacketHandle to SNIPacket
* split PacketHandle and SessionHandle into separate files and implementations
* add comments to PacketHandle and SessionHandle
remove unused packethandle variable in IsConnectionAlive
remove identidal overridden implementations of EmptyReadHandle
* move lazy bool into debug region
* re-add EmptyReadPackt and provide correctly types valid but empty packets in implementations
define IsValidPacket implementations more stringently with type checks
* change implementation switch name to make more sense
* add packet type assertion in IsValiePacket
Commit migrated from https://github.com/dotnet/corefx/commit/
d3d8c74919c9ad831ecbae66dd86bd9d60379010
Stephen Toub [Fri, 21 Dec 2018 15:45:42 +0000 (10:45 -0500)]
Replace several `new string(ch, 1)` with `char.ToString(ch)` in System.Xml (dotnet/corefx#34197)
The latter is simpler and faster.
Commit migrated from https://github.com/dotnet/corefx/commit/
a8a1957f5a632529eb55327f7a4677afeac7689c
Tomas Weinfurt [Fri, 21 Dec 2018 07:09:14 +0000 (23:09 -0800)]
make test conditional on availability of Drawing instead of Nano platform (dotnet/corefx#34195)
Commit migrated from https://github.com/dotnet/corefx/commit/
c025e8a1e2a9a582fbc3a742ca44fd55e6996a67
Ben Adams [Fri, 21 Dec 2018 02:21:00 +0000 (02:21 +0000)]
Optimize SqlClient SNIPacket async paths (dotnet/corefx#34184)
* Optimize SNIPacket async paths
* Feedback
* NET Core vs NET Std
* csproj
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6870c4ed70f6aa39c5a622c9eaa86bd7e01b8fe7
Tomas Weinfurt [Fri, 21 Dec 2018 01:42:05 +0000 (17:42 -0800)]
Stabilize System.Net.NameResolution.Pal.Tests on FreeBSD (dotnet/corefx#34171)
* use same Linux & OSX strategy on FreeBSD for lookup failures
* use PlatformID.Unix instead of list of OSes
Commit migrated from https://github.com/dotnet/corefx/commit/
8fd4d1d8803678115a96ef17a11d3242cfba7f08
dotnet-maestro-bot [Fri, 21 Dec 2018 01:33:03 +0000 (17:33 -0800)]
Update CoreClr, CoreFx to preview-27220-04, preview.18620.2, respectively (dotnet/corefx#34189)
Commit migrated from https://github.com/dotnet/corefx/commit/
86ef9fe66d65afd8d6364f588d2c806921ecd50c
Viktor Hofer [Fri, 21 Dec 2018 01:04:53 +0000 (02:04 +0100)]
Fix calling build script for perf runs (dotnet/corefx#34194)
Commit migrated from https://github.com/dotnet/corefx/commit/
2ee58875b9921bfd46505106399cf53ec92f8266
Viktor Hofer [Thu, 20 Dec 2018 23:22:47 +0000 (00:22 +0100)]
Update coverlet and enable sourcelink paths (dotnet/corefx#34186)
Commit migrated from https://github.com/dotnet/corefx/commit/
9b29df867936acf16c6364482ccd195c06f7aaed
Ulises Hernandez Garcia [Thu, 20 Dec 2018 21:06:45 +0000 (13:06 -0800)]
Change Helix queue to 18.04 (dotnet/corefx#33439)
Commit migrated from https://github.com/dotnet/corefx/commit/
a0fdbbaae4217bc5f6a985d95c8912e0bdcac5d1
Tomas Weinfurt [Thu, 20 Dec 2018 21:02:49 +0000 (13:02 -0800)]
fix process tests on FreeBSD (dotnet/corefx#34170)
* fix process tests on FreeBSD
* OSPlatform.FreeBSD does not exist in netstandard
* correct platform check
* use DateTime.UnixEpoch
Commit migrated from https://github.com/dotnet/corefx/commit/
4ef6b2dbb715838344fc2937e6f9d858fb9d4cc7