Martin Probst [Thu, 7 Nov 2019 22:37:06 +0000 (23:37 +0100)]
clang-format: [JS] test declared fields.
Summary:
TypeScript now supports declaring fields:
class Foo {
declare field: string;
}
clang-format happens to already format this fine, so this change just
adds a regression test.
Reviewers: krasimir
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69972
Martin Probst [Thu, 7 Nov 2019 22:39:03 +0000 (23:39 +0100)]
clang-format: [JS] support null operators.
Summary:
JavaScript / TypeScript is adding two new operators: the null
propagating operator `?.` and the nullish coalescing operator `??`.
const x = foo ?? 'default';
const z = foo?.bar?.baz;
This change adds support to lex and format both.
Reviewers: krasimir
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69971
Louis Dionne [Mon, 11 Nov 2019 15:21:57 +0000 (10:21 -0500)]
[libc++] Mark __call_once_proxy as hidden and internal
We effectively never want to export that function, which is an
implementation detail of libc++. This was previously tried in
603715c66b6b and then reverted in
8335dd314f36 because it caused
linker warnings. These linker warnings should go away now that we
use internal_linkage instead of always_inline to implement per-TU
insulation.
joanlluch [Mon, 11 Nov 2019 15:15:33 +0000 (16:15 +0100)]
[TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (4) (Baseline tests)
Summary: Baseline tests before applying D70042
Reviewers: spatel, asl
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70083
Sanjay Patel [Mon, 11 Nov 2019 14:56:03 +0000 (09:56 -0500)]
Revert "[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723) (3rd try)"
This reverts commit
3db8a3ef86e7b3331ab466a78c10a62be9e69829.
This caused a different memory-sanitizer failure than earlier attempts,
but it's still not right.
Sanjay Patel [Mon, 11 Nov 2019 14:27:17 +0000 (09:27 -0500)]
[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723) (3rd try)
Re-try because earlier attempts were reverted due to use-after-free.
Hopefully, diagnosed correctly this time - we replace/remove the
invariant.start first rather than the invariant.end to avoid angering
worklist-based iteration.
We gather a set of white-listed instructions in isAllocSiteRemovable() and then
replace/erase them. But we don't know in general if the instructions in the set
have uses amongst themselves, so order of deletion makes a difference.
There's already a special-case for the llvm.objectsize intrinsic, so add another
for llvm.invariant.start.
Should fix:
https://bugs.llvm.org/show_bug.cgi?id=43723
Differential Revision: https://reviews.llvm.org/D69977
Tom Weaver [Mon, 11 Nov 2019 14:13:33 +0000 (14:13 +0000)]
Revert "[DBG][OPT] Attempt to salvage or undef debug info when removing trivially deletable instructions in the Reassociate Expression pass."
This reverts commit
1984a27db58e9053371ab6d6dc288c81c8a071ac.
Tom Weaver [Mon, 11 Nov 2019 13:47:13 +0000 (13:47 +0000)]
[DBG][OPT] Attempt to salvage or undef debug info when removing trivially deletable instructions in the Reassociate Expression pass.
Reviewed By: aprantl, vsk
Differential revision: https://reviews.llvm.org/D69943
Tom Weaver [Mon, 11 Nov 2019 13:38:34 +0000 (13:38 +0000)]
[NFC][TEST_COMMIT] Add fullstop to comment.
Utkarsh Saxena [Mon, 11 Nov 2019 11:38:17 +0000 (12:38 +0100)]
[clangd] Use name of Macro to compute its SymbolID, NFC.
Summary:
We use the name from the IdentifierInfo of the Macro to compute its
SymbolID. It is better to just take the Name as a parameter to avoid
storing the IdentifierInfo whenever we need the SymbolID for the Macro.
Patch by UTKARSH SAXENA!
Reviewers: hokein
Reviewed By: hokein
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69937
Simon Pilgrim [Mon, 11 Nov 2019 11:24:09 +0000 (11:24 +0000)]
AArch64FunctionInfo - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Mon, 11 Nov 2019 11:18:44 +0000 (11:18 +0000)]
Fix -Wcovered-switch-default warning. NFCI.
Simon Pilgrim [Mon, 11 Nov 2019 11:13:32 +0000 (11:13 +0000)]
Fix -Wparentheses warning. NFCI.
Simon Pilgrim [Mon, 11 Nov 2019 10:53:47 +0000 (10:53 +0000)]
Remove superfluous ';' to fix Wpedantic. NFC.
Nuno Lopes [Mon, 11 Nov 2019 10:45:42 +0000 (10:45 +0000)]
docs: fix warning in LangRef parsing
Jay Foad [Fri, 12 Jul 2019 16:33:54 +0000 (17:33 +0100)]
[InstCombine] Simplify binary op when only one operand is a select
Summary:
SimplifySelectsFeedingBinaryOp simplified binary ops when both operands
were selects with the same condition. This patch extends it to handle
these cases where only one operand is a select:
X op (C ? P : Q) -> C ? (X op P) : (X op Q)
// if X op P and X op Q both simplify
(C ? P : Q) op Y -> C ? (P op Y) : (Q op Y)
// if P op Y and Q op Y both simplify
For example: X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0
Reviewers: mcberg2017, majnemer, craig.topper, qcolombet, mcrosier
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64713
Michał Górny [Mon, 11 Nov 2019 10:01:21 +0000 (11:01 +0100)]
[lldb] [test] Fix typo in TestSendSignal
Hans Wennborg [Mon, 11 Nov 2019 09:51:11 +0000 (10:51 +0100)]
Revert
cdcf58e5af0 "[RISCV] enable LTO support, pass some options to linker."
This started passing target-features on the linker line, not just for RISCV but
for all targets, leading to error messages in Chromium Android build:
'+soft-float-abi' is not a recognized feature for this target (ignoring feature)
'+soft-float-abi' is not a recognized feature for this target (ignoring feature)
See Phabricator review for details.
Reverting until this can be fixed properly.
> Summary:
> 1. enable LTO need to pass target feature and abi to LTO code generation
> RISCV backend need the target feature to decide which extension used in
> code generation.
> 2. move getTargetFeatures to CommonArgs.h and add ForLTOPlugin flag
> 3. add general tools::getTargetABI in CommonArgs.h because different target uses different
> way to get the target ABI.
>
> Patch by Kuan Hsu Chen (khchen)
>
> Reviewers: lenary, lewis-revill, asb, MaskRay
>
> Reviewed By: lenary
>
> Subscribers: hiraditya, dschuff, aheejin, fedor.sergeev, mehdi_amini, inglorion, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, steven_wu, rogfer01, MartinMosbeck, brucehoult, the_o, dexonsmith, rkruppe, PkmX, jocewei, psnobl, benna, Jim, lenary, s.egerton, pzheng, cfe-commits
>
> Tags: #clang
>
> Differential Revision: https://reviews.llvm.org/D67409
Michał Górny [Mon, 11 Nov 2019 09:53:39 +0000 (10:53 +0100)]
[lldb] [test] Mark TestSendSignal XFAIL on NetBSD
Luís Marques [Mon, 11 Nov 2019 09:46:54 +0000 (09:46 +0000)]
[RISCV][NFC] Add nounwind to LKK test functions
Differential Revision: https://reviews.llvm.org/D70067
Haojian Wu [Mon, 11 Nov 2019 09:34:29 +0000 (10:34 +0100)]
[clangd] Fix a regression of not showing documentation from forward declarations.
Summary:
There is a regression from https://reviews.llvm.org/D68467. Unlike class
forward declarations, function ducomentation is written in the declaration in
headers, the function definition doesn't contain any documentation, cases like:
```
foo.h
// this is foo.
void foo();
foo.cc
void foo() {}
```
we should still show documentation from the foo declaration.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69961
QingShan Zhang [Mon, 11 Nov 2019 09:44:13 +0000 (09:44 +0000)]
[NFC] Add one test to verify the sign_extend of vector type.
joanlluch [Mon, 11 Nov 2019 09:17:57 +0000 (10:17 +0100)]
[TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (3)
Summary:
Additional filtering of undesired shifts for targets that do not support them efficiently.
Related with D69116 and D69120
Applies the TLI.getShiftAmountThreshold hook to prevent undesired generation of shifts for the following IR code:
```
define i16 @testShiftBits(i16 %a) {
entry:
%and = and i16 %a, -64
%cmp = icmp eq i16 %and, 64
%conv = zext i1 %cmp to i16
ret i16 %conv
}
define i16 @testShiftBits_11(i16 %a) {
entry:
%cmp = icmp ugt i16 %a, 63
%conv = zext i1 %cmp to i16
ret i16 %conv
}
define i16 @testShiftBits_12(i16 %a) {
entry:
%cmp = icmp ult i16 %a, 64
%conv = zext i1 %cmp to i16
ret i16 %conv
}
```
The attached diff file shows the piece code in TargetLowering that is responsible for the generation of shifts in relation to the IR above.
Before applying this patch, shifts will be generated to replace non-legal icmp immediates. However, shifts may be undesired if they are even more expensive for the target.
For all my previous patches in this series (cited above) I added test cases for the MSP430 target. However, in this case, the target is not suitable for showing improvements related with this patch, because the MSP430 does not implement "isLegalICmpImmediate". The default implementation returns always true, therefore the patched code in TargetLowering is never reached for that target. Targets implementing both "isLegalICmpImmediate" and "getShiftAmountThreshold" will benefit from this.
The differential effect of this patch can only be shown for the MSP430 by temporarily implementing "isLegalICmpImmediate" to return false for large immediates. This is simulated with the implementation of a command line flag that was incorporated in D69975
This patch belongs to a initiative to "relax" the generation of shifts by LLVM for targets requiring it
Reviewers: spatel, lebedev.ri, asl
Reviewed By: spatel
Subscribers: lenary, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69326
Georgii Rymar [Mon, 11 Nov 2019 09:11:54 +0000 (12:11 +0300)]
[FixBB] - Fix one more std::min -> std::min<uint64_t> to make BB happy.
BB: http://lab.llvm.org:8011/builders/clang-armv7-linux-build-cache/builds/22133/steps/build%20stage%201/logs/stdio
Matt Arsenault [Mon, 11 Nov 2019 08:24:21 +0000 (13:54 +0530)]
Use MCRegister in copyPhysReg
Georgii Rymar [Mon, 11 Nov 2019 08:59:38 +0000 (11:59 +0300)]
[FixBB] - An attemp to fix clang-armv7-linux-build-cache builder.
http://lab.llvm.org:8011/builders/clang-armv7-linux-build-cache/builds/22130/steps/build%20stage%201/logs/stdio
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/ObjectYAML -I/home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/llvm/lib/ObjectYAML -I/usr/include/libxml2 -Iinclude -I/home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/llvm/include -mthumb -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -UNDEBUG -fno-exceptions -fno-rtti -std=c++14 -MMD -MT lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/YAML.cpp.o -MF lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/YAML.cpp.o.d -o lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/YAML.cpp.o -c /home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/llvm/lib/ObjectYAML/YAML.cpp
/home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/llvm/lib/ObjectYAML/YAML.cpp:42:41: error: no matching function for call to 'min'
OS.write((const char *)Data.data(), std::min(N, Data.size()));
^~~~~~~~
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/algorithmfwd.h:370:5: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long long' vs. 'unsigned int')
min(const _Tp&, const _Tp&);
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/stl_algo.h:3451:5: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'unsigned long long'
min(initializer_list<_Tp> __l, _Compare __comp)
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/algorithmfwd.h:375:5: note: candidate function template not viable: requires 3 arguments, but 2 were provided
min(const _Tp&, const _Tp&, _Compare);
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/stl_algo.h:3445:5: note: candidate function template not viable: requires single argument '__l', but 2 arguments were provided
min(initializer_list<_Tp> __l)
^
/home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/llvm/lib/ObjectYAML/YAML.cpp:46:28: error: no matching function for call to 'min'
for (uint64_t I = 0, E = std::min(N, Data.size() / 2); I != E; ++I) {
^~~~~~~~
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/algorithmfwd.h:370:5: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long long' vs. 'unsigned int')
min(const _Tp&, const _Tp&);
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/stl_algo.h:3451:5: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'unsigned long long'
min(initializer_list<_Tp> __l, _Compare __comp)
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/algorithmfwd.h:375:5: note: candidate function template not viable: requires 3 arguments, but 2 were provided
min(const _Tp&, const _Tp&, _Compare);
^
/usr/bin/../lib/gcc/arm-linux-gnueabihf/5.4.0/../../../../include/c++/5.4.0/bits/stl_algo.h:3445:5: note: candidate function template not viable: requires single argument '__l', but 2 arguments were provided
min(initializer_list<_Tp> __l)
Fix: specify the type for std::min call.
Sander de Smalen [Tue, 5 Nov 2019 16:54:54 +0000 (16:54 +0000)]
[AArch64][SVE] Spilling/filling of SVE callee-saves.
Implement the spills/fills of callee-saved SVE registers using STR and LDR
instructions.
Also adds the `aarch64_sve_vector_pcs` attribute to specify the
callee-saved registers to be used for functions that return SVE vectors or
take SVE vectors as arguments. The callee-saved registers are vector
registers z8-z23 and predicate registers p4-p15.
The overal frame-layout with SVE will be as follows:
+-------------+
| stack args |
+-------------+
| Callee Saves|
| X29, X30 |
|-------------| <- FP
| SVE Callee | < //////////////
| saved regs | < //////////////
| z23 | < //////////////
| : | < // SCALABLE //
| z8 | < //////////////
| p15 | < /// STACK ////
| : | < //////////////
| p4 | < //// AREA ////
+-------------+ < //////////////
| : | < //////////////
| SVE locals | < //////////////
| : | < //////////////
+-------------+
|/////////////| alignment gap.
| : |
| Stack objs |
| : |
+-------------+ <- SP after call and frame-setup
Reviewers: cameron.mcinally, efriedma, greened, thegameg, ostannard, rengolin
Reviewed By: ostannard
Differential Revision: https://reviews.llvm.org/D68996
Georgii Rymar [Fri, 1 Nov 2019 12:24:58 +0000 (15:24 +0300)]
[yaml2obj] - Add a way to describe the custom data that is not part of an output section.
Currently there is no way to describe the data that is not a part of an output section.
It can be a data used to align sections or to fill the gaps with something,
or another kind of custom data. In this patch I suggest a way to describe it. It looks like that:
```
Sections:
- Type: CustomFiller
Pattern: "CCDD"
Size: 4
- Name: .bar
Type: SHT_PROGBITS
Content: "FF"
```
I.e. I've added a kind of synthetic section with a synthetic type "CustomFiller".
In the code it is called a "SyntheticFiller", which is "a synthetic section which
might be used to write the custom data around regular output sections. It does
not present in the sections header table, but it might affect the output file size and
program headers produced. Think about it as about piece of data."
`SyntheticFiller` currently has a `Pattern` field and a `Size` field + an optional `Name`.
When written, `Size` of bytes in the output will be filled with a `Pattern`.
It is possible to reference a named filler it by name from the program headers description,
just like any other normal section.
Differential revision: https://reviews.llvm.org/D69709
Ilya Biryukov [Fri, 8 Nov 2019 15:04:07 +0000 (16:04 +0100)]
[clangd] Fixes colon escaping on Windows
vscode always escapes the colon on the file uri, which causes the semantic highlighting fails on windows.
fixes: https://github.com/clangd/clangd/issues/176
marshall [Sun, 10 Nov 2019 13:44:10 +0000 (13:44 +0000)]
libc++ status page: New papers and issues adopted in Belfast
QingShan Zhang [Mon, 11 Nov 2019 06:54:26 +0000 (06:54 +0000)]
[NFC] Add one test to verify the dependency brings by Macro-Fusion.
Tsang Whitney W.H [Sun, 10 Nov 2019 20:00:30 +0000 (20:00 +0000)]
[DirectedGraph]: Add setTargetNode member function
Summary:Add the setTargetNode member function to class DGEdge.
Authored By:etiotto
Reviewer:bmahjour, Whitney, jdoerfert, Meinersbur, fhahn, kbarton,
dmgreen
Reviewed By:Meinersbur
Subscribers:dexonsmith, kristina, llvm-commits
Tag:LLVM
Differential Revision:https://reviews.llvm.org/D68474
Vladimir Vereschaka [Mon, 11 Nov 2019 01:58:29 +0000 (17:58 -0800)]
Revert "Fixed a profdata file size detection on Windows system."
This reverts commit
bcbb121ff6c8440382abfce8f2911a095f14602b.
Using 'ls -o' is not compatible way to fix the problem. FreeBSD and OSX
version of 'ls' do not support -o flag and test gets failed on these
platforms.
Differential Revision: https://reviews.llvm.org/D69317
Craig Topper [Mon, 11 Nov 2019 00:20:19 +0000 (16:20 -0800)]
[InstCombine] Turn (extractelement <1 x i64/double> (bitcast (x86_mmx))) into a single bitcast from x86_mmx to i64/double.
The _m64 type is represented in IR as <1 x i64>. The x86-64 ABI
on Linux passes <1 x i64> as a double. MMX intrinsics use x86_mmx
type in IR.These things result in a lot of bitcasts in mmx code.
There's another instcombine that tries to turn bitcast <1 x i64>
to double into extractelement and a bitcast.
The combine here tries to reverse this extractelement conversion
if we see an mmx type.
Craig Topper [Sun, 10 Nov 2019 08:34:32 +0000 (00:34 -0800)]
[InstCombine] Add a test case for suboptimal handling of (double (bitcast (<1 x i64> (bitcast (x86_mmx)))))
The outer bitcast gets turned into an extractelement and another
bitcast rather than combining away to a single bitcast from mmx
to double.
Sanjay Patel [Sun, 10 Nov 2019 23:47:49 +0000 (18:47 -0500)]
Revert "[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723) (2nd try)"
This reverts commit
56b2aee1875a1ee47ddf859a6584f8728787fb7b.
Still causes a use-after-free on sanitizer bots.
Sanjay Patel [Sun, 10 Nov 2019 22:24:48 +0000 (17:24 -0500)]
[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723) (2nd try)
Re-try rGef02831f0a4e (reverted due to use-after-free), but bail out completely
if we encounter an unexpected llvm.invariant.start.
We gather a set of white-listed instructions in isAllocSiteRemovable() and then
replace/erase them. But we don't know in general if the instructions in the set
have uses amongst themselves, so order of deletion makes a difference.
There's already a special-case for the llvm.objectsize intrinsic, so add another
for llvm.invariant.end.
Should fix:
https://bugs.llvm.org/show_bug.cgi?id=43723
Differential Revision: https://reviews.llvm.org/D69977
Stefan Stipanovic [Sun, 10 Nov 2019 20:45:11 +0000 (21:45 +0100)]
getArgOperandNo helper function.
Summary: A helper function to get argument number of a arg operand Use.
Reviewers: jdoerfert, uenoku
Subscribers: hiraditya, lebedev.ri, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66844
Duncan P. N. Exon Smith [Sun, 10 Nov 2019 18:31:03 +0000 (10:31 -0800)]
clang/Modules: Remove unused parameter from ModuleManager::removeModules
The other paremeters appear to be sufficient to determine which modules
have just been loaded and need to be removed, so stop collecting and
sending in that set explicitly.
Roman Lebedev [Sun, 10 Nov 2019 16:44:46 +0000 (19:44 +0300)]
[NFC][Codegen] Add `x u% C1 == C2` with C1 u> C2 non-tautological tests
drichards-87 [Sun, 10 Nov 2019 16:27:32 +0000 (09:27 -0700)]
Docs: Updates Sphinx Quickstart template for new contributors
Sanjay Patel [Sun, 10 Nov 2019 16:18:05 +0000 (11:18 -0500)]
Revert "[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723)"
This reverts commit
ef02831f0a4e3b3ccaa45a5589e4cabecbf527ab.
Sanitizer bots fail with this change.
Luís Marques [Sun, 10 Nov 2019 16:04:43 +0000 (16:04 +0000)]
[RISCV] Fix CFA when doing split sp adjustment with fp
Summary: When using the split sp adjustment and using the frame-pointer
we were still emitting CFI CFA directives based on the sp value. The
final sp-based offset also didn't reflect the two-stage sp adjust. There
remain CFI issues that aren't related to the split sp adjustment, and
thus will be addressed in a separate patch.
Reviewers: asb, lenary, shiva0217
Reviewed By: lenary, shiva0217
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69385
Luís Marques [Sun, 10 Nov 2019 15:56:51 +0000 (15:56 +0000)]
[RISCV][NFC] Add CFI-related tests
Summary: Adds tests necessary to properly show the impact of other
patches that affect the emission of CFI directives.
Reviewers: asb, lenary
Reviewed By: lenary
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69721
Sanjay Patel [Sun, 10 Nov 2019 14:16:32 +0000 (09:16 -0500)]
[InstCombine] avoid crash from deleting an instruction that still has uses (PR43723)
We gather a set of white-listed instructions in isAllocSiteRemovable() and then
replace/erase them. But we don't know in general if the instructions in the set
have uses amongst themselves, so order of deletion makes a difference.
There's already a special-case for the llvm.objectsize intrinsic, so add another
for llvm.invariant.end.
Should fix:
https://bugs.llvm.org/show_bug.cgi?id=43723
Differential Revision: https://reviews.llvm.org/D69977
Simon Pilgrim [Sun, 10 Nov 2019 12:15:49 +0000 (12:15 +0000)]
Remove unused variable (which allows us to remove vector include). NFC.
Benjamin Kramer [Sun, 10 Nov 2019 11:53:19 +0000 (12:53 +0100)]
[Driver] Remove unused variable. NFC.
Roman Lebedev [Sun, 10 Nov 2019 11:21:50 +0000 (14:21 +0300)]
[NFC][Codegen] Add `x u% C1 == C2` with C1 u<= C2 tautological tests
Simon Pilgrim [Sun, 10 Nov 2019 11:21:43 +0000 (11:21 +0000)]
Twine - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Sun, 10 Nov 2019 11:19:50 +0000 (11:19 +0000)]
TableGen - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Sun, 10 Nov 2019 11:18:15 +0000 (11:18 +0000)]
PODSmallVector - fix MSVC uninitialized variable warnings. NFCI.
Simon Pilgrim [Sun, 10 Nov 2019 11:15:39 +0000 (11:15 +0000)]
Path - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Sun, 10 Nov 2019 11:14:58 +0000 (11:14 +0000)]
CodeGenRegBank - make functions const to fix cppcheck warnings.
Fangrui Song [Sat, 9 Nov 2019 23:20:20 +0000 (15:20 -0800)]
[MC] Clean up MacroInstantiation. NFC
Tsang Whitney W.H [Sun, 10 Nov 2019 05:39:40 +0000 (05:39 +0000)]
[NFC]: Fix PVS Studio warning in LoopNestAnalysis
Summary:This patch fixes the following warnings uncovered by PVS
Studio:
/home/xbolva00/LLVM/llvm-project/llvm/lib/Analysis/LoopCacheAnalysis.cpp
353 warn V612 An unconditional 'return' within a loop.
/home/xbolva00/LLVM/llvm-project/llvm/lib/Analysis/LoopCacheAnalysis.cpp
456 err V502 Perhaps the '?:' operator works in a different way than it
was expected. The '?:' operator has a lower priority than the '=='
operator.
Authored By:etiotto
Reviewer:Meinersbur, kbarton, bmahjour, Whitney, xbolva00
Reviewed By:xbolva00
Subscribers:hiraditya, llvm-commits
Tag:LLVM
Differential Revision:https://reviews.llvm.org/D69821
Craig Topper [Sun, 10 Nov 2019 01:58:56 +0000 (17:58 -0800)]
[X86] Handle MO_ConstantPoolIndex in X86AsmPrinter::PrintOperand
Fixes PR43952
Simon Pilgrim [Sat, 9 Nov 2019 22:15:26 +0000 (22:15 +0000)]
Try to fix sphinx "Could not lex literal_block as "llvm"" warning.
Code block isn't IR - so treat it as "none" instead.
Simon Pilgrim [Sat, 9 Nov 2019 22:11:50 +0000 (22:11 +0000)]
YAMLParser - fix SimpleKey uninitialized variable warnings. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 22:10:09 +0000 (22:10 +0000)]
Reduce scope of variable to silence cppcheck warning. NFC
Simon Pilgrim [Sat, 9 Nov 2019 18:38:19 +0000 (18:38 +0000)]
RegisterCoalescer - remove duplicate variable to fix Wshadow warning. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 18:16:07 +0000 (18:16 +0000)]
RegisterCoalescer - fix uninitialized variables. NFCI.
Gil Rapaport [Mon, 7 Oct 2019 14:24:33 +0000 (17:24 +0300)]
[LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI)
This recommits
11ed1c0239fd51fd2f064311dc7725277ed0a994 (reverted in
9f08ce0d2197d4f163dfa4633eae2347ce8fc881 for failing an assert) with a fix:
tryToWidenMemory() now first checks if the widening decision is to interleave,
thus maintaining previous behavior where tryToInterleaveMemory() was called
first, giving priority to interleave decisions over widening/scalarization. This
commit adds the test case that exposed this bug as a LIT.
Michał Górny [Sat, 9 Nov 2019 18:40:31 +0000 (19:40 +0100)]
[lldb] [test] Un-XFAIL tests that work on NetBSD 9
Simon Pilgrim [Sat, 9 Nov 2019 17:23:53 +0000 (17:23 +0000)]
Fix variable ‘LookedUpGetterSetter’ set but not used warning. NFCI.
Dávid Bolvanský [Sat, 9 Nov 2019 17:31:17 +0000 (18:31 +0100)]
Fixed dia file
Dávid Bolvanský [Sat, 9 Nov 2019 17:26:21 +0000 (18:26 +0100)]
Fixed c-index test
Dávid Bolvanský [Sat, 9 Nov 2019 17:13:34 +0000 (18:13 +0100)]
Fixed more -Wreturn-type tests
Simon Pilgrim [Sat, 9 Nov 2019 17:02:51 +0000 (17:02 +0000)]
Fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 17:01:32 +0000 (17:01 +0000)]
Fix shadow variable warning with llvm::SrcMgr. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 16:37:20 +0000 (16:37 +0000)]
Fix operator precedence warning. NFC.
Dávid Bolvanský [Sat, 9 Nov 2019 15:15:53 +0000 (16:15 +0100)]
[Diagnostics] Try to improve warning message for -Wreturn-type
Summary: I agree with https://easyaspi314.github.io/gcc-vs-clang.html?fbclid=IwAR1VA0qxiWVUusOQUv5z7JESS7ZpeJy-UqAI5mnJscofGLqXcqeErIUB2gU, current warning message is not very good. We should try to improve it..
Reviewers: rsmith, aaron.ballman, easyaspi314
Reviewed By: aaron.ballman
Subscribers: arphaman, Quuxplusone, mehdi_amini, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D69762
Yonghong Song [Sat, 9 Nov 2019 16:32:44 +0000 (08:32 -0800)]
Revert "[BPF] Add preserve_access_index attribute for record definition"
This reverts commit
4a5aa1a7bf8b1714b817ede8e09cd28c0784228a.
There are some other test failures. Investigate them first.
Yonghong Song [Sat, 2 Nov 2019 05:16:59 +0000 (22:16 -0700)]
[BPF] Add preserve_access_index attribute for record definition
This patch introduced a new bpf specific attribute which can
be added to struct or union definition. For example,
struct s { ... } __attribute__((preserve_access_index));
union u { ... } __attribute__((preserve_access_index));
The goal is to simplify user codes for cases
where preserve access index happens for certain struct/union,
so user does not need to use clang __builtin_preserve_access_index
for every members.
The attribute has no effect if -g is not specified.
When the attribute is specified and -g is specified, any member
access defined by that structure or union, including array subscript
access and inner records, will be preserved through
__builtin_preserve_{array,struct,union}_access_index()
IR intrinsics, which will enable relocation generation
in bpf backend.
The following is an example to illustrate the usage:
-bash-4.4$ cat t.c
#define __reloc__ __attribute__((preserve_access_index))
struct s1 {
int c;
} __reloc__;
struct s2 {
union {
struct s1 b[3];
};
} __reloc__;
struct s3 {
struct s2 a;
} __reloc__;
int test(struct s3 *arg) {
return arg->a.b[2].c;
}
-bash-4.4$ clang -target bpf -g -S -O2 t.c
A relocation with access string "0:0:0:0:2:0" will be generated
representing access offset of arg->a.b[2].c.
forward declaration with attribute is also handled properly such
that the attribute is copied and populated in real record definition.
Differential Revision: https://reviews.llvm.org/D69759
Mark de Wever [Sat, 9 Nov 2019 16:01:37 +0000 (17:01 +0100)]
[libc++] Validate the entire regex is consumed
This change would have warned about the bug found in D62451.
No unit tests since the exception should never throw.
Differential Revision: https://reviews.llvm.org/D62452
Mark de Wever [Sat, 9 Nov 2019 14:32:35 +0000 (15:32 +0100)]
[Parser] Warn when ScopeDepthOrObjCQuals overflows
Before when the overflow occured an assertion was triggered. Now check
whether the maximum has been reached and warn properly.
This patch fixes the original submission of PR19607.
Differential Revision: https://reviews.llvm.org/D63975
Richard Smith [Sat, 9 Nov 2019 13:52:18 +0000 (05:52 -0800)]
[NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.
Patch by Wang Tianqing!
Differential Revision: https://reviews.llvm.org/D69792
Simon Pilgrim [Sat, 9 Nov 2019 13:47:53 +0000 (13:47 +0000)]
Fix builds where LLVM_ENABLE_STATS is disabled
Missed Stats->EnableStats rename in rG3fb832fe8bdc317687d5a4d2ca20f5f73b089341
Simon Pilgrim [Sat, 9 Nov 2019 13:43:09 +0000 (13:43 +0000)]
llvm-exegesis - fix shadow variable warnings. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 13:00:36 +0000 (13:00 +0000)]
Remarks - fix static analyzer warnings. NFCI.
- Fix uninitialized variable warnings.
- Reuse BitstreamEntry iterator to avoid Wshadow warning.
- Match declaration + definition arg names in BitstreamRemarkParser::processCommonMeta
- Make BitstreamRemarkParser(StringRef) constructor explicit
Simon Pilgrim [Sat, 9 Nov 2019 12:56:24 +0000 (12:56 +0000)]
Remove duplicate MemVT to fix shadow variable warning. NFCI.
Simon Pilgrim [Sat, 9 Nov 2019 12:50:25 +0000 (12:50 +0000)]
Statistic - Fix shadow variable warning. NFCI.
Rename option 'Stats' to 'EnableStats' and prevent clash with StatisticInfo::Stats member
Simon Pilgrim [Fri, 8 Nov 2019 22:38:19 +0000 (22:38 +0000)]
Remove superfluous break after return. NFC.
Simon Pilgrim [Fri, 8 Nov 2019 22:37:11 +0000 (22:37 +0000)]
Fix shadow variable warning by reducing scope of CC/InverseCC CondCodes. NFCI.
Simon Pilgrim [Fri, 8 Nov 2019 22:30:12 +0000 (22:30 +0000)]
Remarks - fix shadow variable warnings. NFCI.
Avoid conflict with llvm::remarks::Magic global variable.
Richard Smith [Sat, 9 Nov 2019 09:17:57 +0000 (01:17 -0800)]
[cxx_status] Update with Belfast motions.
Jay Foad [Fri, 8 Nov 2019 23:08:24 +0000 (23:08 +0000)]
Refactor SimplifySelectsFeedingBinaryOp for D64713. NFC.
Dávid Bolvanský [Sat, 9 Nov 2019 08:02:40 +0000 (09:02 +0100)]
[Diagnostics] Fixed crash with non pointer type (PR43950)
Artem Dergachev [Sat, 9 Nov 2019 02:06:40 +0000 (18:06 -0800)]
[analyzer] Fix skipping the call during inlined defensive check suppression.
When bugreporter::trackExpressionValue() is invoked on a DeclRefExpr,
it tries to do most of its computations over the node in which
this DeclRefExpr is computed, rather than on the error node (or whatever node
is stuffed into it). One reason why we can't simply use the error node is
that the binding to that variable might have already disappeared from the state
by the time the bug is found.
In case of the inlined defensive checks visitor, the DeclRefExpr node
is in fact sometimes too *early*: the call in which the inlined defensive check
has happened might have not been entered yet.
Change the visitor to be fine with tracking dead symbols (which it is totally
capable of - the collapse point for the symbol is still well-defined), and fire
it up directly on the error node. Keep using "LVState" to find out which value
should we be tracking, so that there weren't any problems with accidentally
loading an ill-formed value from a dead variable.
Differential Revision: https://reviews.llvm.org/D67932
Artem Dergachev [Sat, 9 Nov 2019 02:04:27 +0000 (18:04 -0800)]
[analyzer] Nullability: Don't infer nullable when passing as nullable parameter.
You can't really infer anything from that.
Jason Molenda [Sat, 9 Nov 2019 02:20:27 +0000 (18:20 -0800)]
Temporarily change the default for use-g-packet-for-reading to false,
until we can automatically fall back to p/P if g/G are not supported;
it looks like there is a bug in debugserver's g/G packets taht needs
to be fixed, or debugserver should stop supporting g/G until that bug
is fixed. But we need lldb to be able to fall back to p/P correctly
for that to be a viable workaround.
Jonas Devlieghere [Sat, 9 Nov 2019 02:16:44 +0000 (18:16 -0800)]
Revert "Add a testcase for .dSYM path remapping dictionaries."
This reverts commit
2bbc4fdd8fa0ed58d610ab6260cb664c7cfef204.
Puyan Lotfi [Sat, 9 Nov 2019 02:06:23 +0000 (21:06 -0500)]
[clang][IFS][test] Fixing buildbot test fails for clang-ifs.
Checking for the exact triple fails on many bots. Leaving the triple
check blank.
Puyan Lotfi [Sat, 9 Nov 2019 01:21:28 +0000 (20:21 -0500)]
[clang][IFS] Adds support for more decl types in clang interface stubs.
Adding support for processing the following Decls: NonTypeTemplateParmDecl,
CXXConversionDecl, UnresolvedUsingValueDecl, UsingDecl, UsingShadowDecl,
TypeAliasTemplateDecl, TypeAliasDecl, VarTemplateDecl,
VarTemplateSpecializationDecl, UsingDirectiveDecl, TemplateTemplateParmDecl,
ClassTemplatePartialSpecializationDecl, IndirectFieldDecl.
Also, this allows for processing NamedDecls that don't have an identifier and
skips over VarDecls that are dependent on template types.
Differential Revision: https://reviews.llvm.org/D69995
Teresa Johnson [Fri, 8 Nov 2019 23:50:55 +0000 (15:50 -0800)]
ThinLTO : Import always_inline functions irrespective of the threshold
Summary: A user can force a function to be inlined by specifying the always_inline attribute. Currently, thinlto implementation is not aware of always_inline functions and does not guarantee import of such functions, which in turn can prevent inlining of such functions.
Patch by Bharathi Seshadri <bseshadr@cisco.com>
Reviewers: tejohnson
Reviewed By: tejohnson
Subscribers: mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith, arphaman, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70014
Jason Molenda [Fri, 8 Nov 2019 23:55:46 +0000 (15:55 -0800)]
Test case to verify that lldb falls back to p/P if g is unsupported
and that lldb uses the expedited register values in the ? packet
aka stop packet (T11 etc) and does not re-fetch them with the p packet.
This test is currently failing from the "[lldb-server] Add setting to
force 'g' packet use" commit; I'm marking it as @expectedFailureAll
until we can get this fixed.
David Blaikie [Fri, 8 Nov 2019 23:31:15 +0000 (15:31 -0800)]
DebugInfo: Remove redundant conditionals/checks from macro info emission
These checks fall out naturally from the current implementation without
needing to be explicitly considered anymore.
David Blaikie [Fri, 8 Nov 2019 23:26:17 +0000 (15:26 -0800)]
DebugInfo: Do not create a debug_macinfo section if no CUs have associated macros
Patch based on Sourabh Singh's D69839 patch.
Sam Clegg [Fri, 8 Nov 2019 19:13:10 +0000 (11:13 -0800)]
llvm-ranlib/nm: Don't print usage message except for usage errors
Also, fix a bug in ranlib where it didn't correctly detect being run
without any argument and would try to operate on the empty string.
Differential Revision: https://reviews.llvm.org/D70021
David Blaikie [Fri, 8 Nov 2019 23:14:58 +0000 (15:14 -0800)]
NVPTX: Don't insert an extra empty line at the end of the last section.
This was arbitrarily appearing in only the last section emitted - which
made tests more sensitive than they needed to be (removing the last
section - like the macinfo section change that's coming after this)
would, surprisingly, move the blank line to the previous section.
Adrian Prantl [Fri, 8 Nov 2019 17:24:31 +0000 (09:24 -0800)]
Debug Info: Nest Objective-C property function decls inside their container.
This has the nice side-effect of also fixing a crash in Clang.
Starting with DWARF 5 we are emitting ObjC method declarations as
children of their containing entity. This worked for interfaces, but
didn't consider the case of synthessized properties. When a property
of a protocol is synthesized in an interface implementation the
ObjCMethodDecl that was passed to CGF::StartFunction was the property
*declaration* which obviously couldn't have a containing
interface. This patch passes the containing interface all the way
through to CGDebugInfo, so the function declaration can be created
with the correct parent (= the class implementing the protocol).
rdar://problem/
53782400
Differential Revision: https://reviews.llvm.org/D66121