Shanqing Cai [Fri, 4 May 2018 13:08:57 +0000 (09:08 -0400)]
Merge pull request #19072 from caisq/branch_195301913
Branch
195301913
Sergii Khomenko [Fri, 4 May 2018 02:22:09 +0000 (04:22 +0200)]
Fix minor typos (#19070)
Shanqing Cai [Fri, 4 May 2018 00:34:51 +0000 (20:34 -0400)]
Merge commit for internal changes
Shanqing Cai [Thu, 3 May 2018 20:30:12 +0000 (13:30 -0700)]
tfdbg + tflearn: replace deprecated classes and methods in example & docs
* `tf.contrib.learn.Experiment` is deprecated. Remove it from debug_tflearn_iris.py.
* Use `tf.estimator.DNNClassifier`, instead of the older one from `tf.contrib.learn`.
* Use `train()`, instead of `fit()` of Estimators.
* `Estimator.predict()` supports hooks. Add example lines for that.
PiperOrigin-RevId:
195301913
Allen Lavoie [Thu, 3 May 2018 20:22:33 +0000 (13:22 -0700)]
Checkpointable: Utilities to read object metadata
Useful for inspecting checkpoints programatically (e.g. in unit tests).
PiperOrigin-RevId:
195300780
A. Unique TensorFlower [Thu, 3 May 2018 20:09:30 +0000 (13:09 -0700)]
Fix bugs in model pruner.
PiperOrigin-RevId:
195298816
Benoit Steiner [Thu, 3 May 2018 20:09:28 +0000 (13:09 -0700)]
Simplified the implementation of shape_n since the optimized code path isn't needed anymore and can be incorrect in some rare cases.
PiperOrigin-RevId:
195298813
Ruoxin Sang [Thu, 3 May 2018 20:03:48 +0000 (13:03 -0700)]
Change all std::bind usages in GCS to lambdas. Fix the wrong #define Guard name in retrying_file_system.h.
PiperOrigin-RevId:
195297877
A. Unique TensorFlower [Thu, 3 May 2018 20:00:56 +0000 (13:00 -0700)]
Enable unary chain hoisting optimization for concat/split/splitv by default.
PiperOrigin-RevId:
195297330
Sanjoy Das [Thu, 3 May 2018 19:59:33 +0000 (12:59 -0700)]
[TF:XLA] Bump open source llvm revision to r331442
PiperOrigin-RevId:
195297133
Allen Lavoie [Thu, 3 May 2018 19:53:47 +0000 (12:53 -0700)]
Small fix for an eager colab notebook.
PiperOrigin-RevId:
195296384
Yao Zhang [Thu, 3 May 2018 19:19:01 +0000 (12:19 -0700)]
Simplify file reading and support SavedModel.
PiperOrigin-RevId:
195291836
A. Unique TensorFlower [Thu, 3 May 2018 19:00:57 +0000 (12:00 -0700)]
Do not delegate temporary tensors to NNAPI.
- also added delegation for MUL, and set the default scale to be 0.0f.
PiperOrigin-RevId:
195288948
A. Unique TensorFlower [Thu, 3 May 2018 18:16:06 +0000 (11:16 -0700)]
[XLA] Redesign: add ExecuteGraph to grpc service.
PiperOrigin-RevId:
195281004
Aditya Yogi [Thu, 3 May 2018 18:13:40 +0000 (23:43 +0530)]
Update learning.py (#19064)
Nicholas Nadeau, P.Eng., AVS [Thu, 3 May 2018 17:47:06 +0000 (13:47 -0400)]
Fixed Typos (#18806)
* fixed typos
A. Unique TensorFlower [Thu, 3 May 2018 16:10:06 +0000 (09:10 -0700)]
Post-transform pass to dedupe large constant arrays.
PiperOrigin-RevId:
195260578
ctiijima [Thu, 3 May 2018 15:34:07 +0000 (08:34 -0700)]
Grammar fixes on architecture.md (#19035)
Amit Patankar [Thu, 3 May 2018 14:18:04 +0000 (07:18 -0700)]
Merge pull request #19040 from tensorflow/merge_branch
Merge r1.8 back to master after 1.8.0 release.
Letian Feng [Thu, 3 May 2018 13:46:16 +0000 (15:46 +0200)]
correct code snippets to python3 style (#19052)
Suharsh Sivakumar [Thu, 3 May 2018 07:16:09 +0000 (00:16 -0700)]
Use tensorflow size to determine number of elements instead of the static shape, which can sometimes be missing.
PiperOrigin-RevId:
195209826
Elson Rodriguez [Thu, 3 May 2018 04:58:44 +0000 (21:58 -0700)]
Enabling support for S3 and Google Storage for the MKL Docker image. (#19039)
Tony Wang [Thu, 3 May 2018 04:37:04 +0000 (21:37 -0700)]
Simplify getter and setter method for GraphOptimizationPass::name_
PiperOrigin-RevId:
195199912
Andrew Selle [Thu, 3 May 2018 04:15:01 +0000 (21:15 -0700)]
Expose Interpreter to tensorflow.contrib.lite
PiperOrigin-RevId:
195198645
Taehoon Lee [Thu, 3 May 2018 03:01:04 +0000 (12:01 +0900)]
Fix typos (#18475)
Mostafa Alaa [Thu, 3 May 2018 02:53:18 +0000 (19:53 -0700)]
Fix tf.variable_scope unique name after entering root scope
Closes #18702.
PiperOrigin-RevId:
195192460
A. Unique TensorFlower [Thu, 3 May 2018 02:19:12 +0000 (19:19 -0700)]
Update ops-related pbtxt files.
PiperOrigin-RevId:
195190335
A. Unique TensorFlower [Thu, 3 May 2018 01:52:02 +0000 (18:52 -0700)]
Replaced calls to tensorflow::StringPiece::ToString with std::string conversions.
That is, instances of sp.ToString() are replaced with std::string(sp).
This will allow tensorflow::StringPiece::ToString to be removed, which is necessary before it can be replaced with absl::string_view.
PiperOrigin-RevId:
195188185
A. Unique TensorFlower [Thu, 3 May 2018 01:35:55 +0000 (18:35 -0700)]
Compute shape of segment_ids dynamically in _unsorted_segment_N
PiperOrigin-RevId:
195186950
A. Unique TensorFlower [Thu, 3 May 2018 01:19:16 +0000 (18:19 -0700)]
Remove duplicated emplace_back floor operator.
PiperOrigin-RevId:
195185567
A. Unique TensorFlower [Thu, 3 May 2018 01:11:25 +0000 (18:11 -0700)]
Automated g4 rollback of changelist
195091587
PiperOrigin-RevId:
195184798
RJ Ryan [Thu, 3 May 2018 00:57:27 +0000 (17:57 -0700)]
Add complex128 support to FFT, FFT2D, FFT3D, IFFT, IFFT2D, and IFFT3D.
NumPy automatically upcasts to complex128 when computing FFTs, leading to issues like:
#10749
This change allows users to choose between 32-bit and 64-bit precision FFTs on CPU and GPU.
PiperOrigin-RevId:
195183206
Yong Tang [Thu, 3 May 2018 00:45:29 +0000 (02:45 +0200)]
Add go_package to proto definition files (#17262)
* Add go_package to proto definition files
This fix tries to address the issue raised in 16282 by
add go_package to proto files, so that generated go files
have correct path.
This fix fixes 16282.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Add go_package to proto definition in tensorflow/core/framework
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Add go_package to proto definition in tensorflow/core/example
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Add go_package to proto definition in tensorflow/core/example
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Anna R [Thu, 3 May 2018 00:41:26 +0000 (17:41 -0700)]
Add a collect_trace option to run_op_benchmark for cases when callers just want
to pass RunOptions.FULL_TRACE but don't want to store trace in extras.
PiperOrigin-RevId:
195181533
Jeremy Lau [Thu, 3 May 2018 00:25:10 +0000 (17:25 -0700)]
BufferValue is a new base class for LogicalBuffer and HloValue. This makes it
easier to migrate from TuplePointsToAnalysis/LogicalBuffer to
HloDataflowAnalysis/HloValue. No functional changes.
PiperOrigin-RevId:
195179676
Benoit Steiner [Thu, 3 May 2018 00:00:16 +0000 (17:00 -0700)]
Handle negative values when slicing symbolic shapes
PiperOrigin-RevId:
195176133
Francois Chollet [Wed, 2 May 2018 23:58:35 +0000 (16:58 -0700)]
Allow `Layer.add_loss` to receive non-tensor; fixes error triggered when using a weight regularizer of factor 0.
PiperOrigin-RevId:
195175909
Ayush Dubey [Wed, 2 May 2018 23:13:06 +0000 (16:13 -0700)]
Enable reshape of _ScopedAllocatorConcat output.
The _ScopedAllocatorConcat kernel outputs the backing tensor after performing
runtime bounds checks. However, the shape of the backing tensor may not match
the desired output shape of the concat operation.
This change adds a "reshape" boolean attribute to _ScopedAllocatorConcat kernel.
When this attribute is set to true, the kernel outputs a reshaped backing tensor
according to the "shape" attribute.
PiperOrigin-RevId:
195169105
A. Unique TensorFlower [Wed, 2 May 2018 23:05:43 +0000 (16:05 -0700)]
Add RNNEstimator which takes in arbitrary heads.
PiperOrigin-RevId:
195167853
A. Unique TensorFlower [Wed, 2 May 2018 23:04:09 +0000 (16:04 -0700)]
Mark all nodes processed by AddOpsRewrite/MinBCast stages with a tag.
PiperOrigin-RevId:
195167597
A. Unique TensorFlower [Wed, 2 May 2018 22:51:16 +0000 (15:51 -0700)]
Allow evaluation and prediction through warm-starting (no current checkpoint / model_dir).
PiperOrigin-RevId:
195165732
Jianwei Xie [Wed, 2 May 2018 22:36:54 +0000 (15:36 -0700)]
Adds the EvalListener support for run_local.
PiperOrigin-RevId:
195163507
A. Unique TensorFlower [Wed, 2 May 2018 22:35:11 +0000 (15:35 -0700)]
Adding a version of rolled triangular solver code for the right-multiply case, which is used in Cholesky decomposition. Replacing the unrolled version with a While loop drastically reduces XLA compilation times which allows much larger models to be run on TPU.
PiperOrigin-RevId:
195163298
Priya Gupta [Wed, 2 May 2018 22:30:30 +0000 (15:30 -0700)]
Add prefetching to one device distribution strategy.
PiperOrigin-RevId:
195162570
Peter Hawkins [Wed, 2 May 2018 23:22:41 +0000 (16:22 -0700)]
Replaced calls to tensorflow::StringPiece::ToString with std::string conversions.
That is, instances of sp.ToString() are replaced with std::string(sp).
This will allow tensorflow::StringPiece::ToString to be removed, which is necessary before it can be replaced with absl::string_view.
PiperOrigin-RevId:
195162126
gracehoney [Wed, 2 May 2018 22:50:03 +0000 (15:50 -0700)]
Merge pull request #18909 from samikama/optimization_pass
Optimization pass and Memory allocator integration
Yifei Feng [Wed, 2 May 2018 22:24:50 +0000 (15:24 -0700)]
Merge 1.8.0 back to master.
A. Unique TensorFlower [Wed, 2 May 2018 22:21:17 +0000 (15:21 -0700)]
Optimize LogicalOr and LogicalAnd with all true or false inputs:
LogicalOr(x, true) = true
LogicalOr(x, false) = x
LogicalAnd(x, true) = x
LogicalAnd(x, false) = false
and similar if the first argument is constant.
PiperOrigin-RevId:
195161140
Yuanzhong Xu [Wed, 2 May 2018 22:14:08 +0000 (15:14 -0700)]
[XLA] BF16 propagation: do not change if propagation is confined inside a fusion.
We now use a set to track all the potential changes, and do the actual changes
on the HLOs at the end. This also makes the boolean return value (whether
anything is changed) correct.
PiperOrigin-RevId:
195160025
Sanjoy Das [Wed, 2 May 2018 22:05:58 +0000 (15:05 -0700)]
[TF:XLA] Bump open source llvm revision to r331338
PiperOrigin-RevId:
195158710
Chris Ying [Wed, 2 May 2018 22:03:33 +0000 (15:03 -0700)]
Add steps_per_run to LoggingTensorHook and StepCounterHook and other logging bug fixes.
PiperOrigin-RevId:
195158238
A. Unique TensorFlower [Wed, 2 May 2018 21:58:57 +0000 (14:58 -0700)]
Fix support for batch_normalization with mixed precision
When the type of the input tensor `x` is not the same as the type of
the parameters `mean`, `variance`, `offset`, and `scale`, a cast is
required.
This mixed precision case occurs when using the BatchNormalization
layer with a data type of float16 or bfloat16.
PiperOrigin-RevId:
195157279
gracehoney [Wed, 2 May 2018 21:46:12 +0000 (14:46 -0700)]
Fix breaking tests
annarev [Wed, 2 May 2018 21:45:53 +0000 (14:45 -0700)]
Merge pull request #19030 from annarev/copy_modules_before_iterating
Copy module list before iterating over it
A. Unique TensorFlower [Wed, 2 May 2018 20:44:30 +0000 (13:44 -0700)]
Updated ABSL to latest version in workspace.bzl.
PiperOrigin-RevId:
195144612
A. Unique TensorFlower [Wed, 2 May 2018 20:42:40 +0000 (13:42 -0700)]
Fix a bug in create_python_api.py
I got an error complaining about "RuntimeError: dictionary changed size during iteration", this change fixes it.
PiperOrigin-RevId:
195144333
Anna R [Wed, 2 May 2018 20:44:32 +0000 (13:44 -0700)]
Copy module list file in the while statement instead of creating a new variable
Sanjoy Das [Wed, 2 May 2018 20:36:31 +0000 (13:36 -0700)]
[XLA] Add new optimization that sinks constants into while loop bodies
Example transformation:
state = (..., const, ...)
while (pred(state)) {
(..., v, ...) = state
use(v)
state = (..., v, ...)
}
=>
state = (..., const, ...)
while (pred(state)) {
(..., v, ...) = state
use(const)
state = (..., v, ...)
}
PiperOrigin-RevId:
195143323
Jiri Simsa [Wed, 2 May 2018 20:29:01 +0000 (13:29 -0700)]
Re-enabling a test.
PiperOrigin-RevId:
195142105
Saurabh Saxena [Wed, 2 May 2018 20:23:56 +0000 (13:23 -0700)]
Fix tsan failure in batch_dataset_op_test.
The error was being caused because we were trying to save invocation_results_` while the function call was in progress. Now we wait for all invocations to finish before saving both `invocation_results_` and `batch_results_`.
Did local A/B testing for tsan.
Before: 12/100 failed
After: All passed
PiperOrigin-RevId:
195141349
Jiri Simsa [Wed, 2 May 2018 20:05:51 +0000 (13:05 -0700)]
Increasing test size to reflect recent additions and prevent test timeouts.
PiperOrigin-RevId:
195138565
A. Unique TensorFlower [Wed, 2 May 2018 20:05:15 +0000 (13:05 -0700)]
[XLA] Redesign: Dump HloSnapshot in local service as well. And support replaying HloSnapshot.
PiperOrigin-RevId:
195138472
Amit Patankar [Wed, 2 May 2018 20:07:37 +0000 (13:07 -0700)]
Merge pull request #19031 from smitshilu/patch-3
command Typo
Benoit Steiner [Wed, 2 May 2018 19:58:06 +0000 (12:58 -0700)]
Added support for packing of symbolic shapes
PiperOrigin-RevId:
195137239
Asim Shankar [Wed, 2 May 2018 19:32:28 +0000 (12:32 -0700)]
docs: Link to the appropriately branched version of the live colab notebooks.
And update that link on release changes.
PiperOrigin-RevId:
195133689
Smit Shilu [Wed, 2 May 2018 19:23:31 +0000 (15:23 -0400)]
command Typo
Bixia Zheng [Wed, 2 May 2018 18:57:24 +0000 (11:57 -0700)]
Turn on two half precision tests for GPU.
PiperOrigin-RevId:
195128326
A. Unique TensorFlower [Wed, 2 May 2018 18:45:15 +0000 (11:45 -0700)]
Replaced calls to tensorflow::StringPiece::ToString with std::string conversions.
That is, instances of sp.ToString() are replaced with std::string(sp).
This will allow tensorflow::StringPiece::ToString to be removed, which is necessary before it can be replaced with absl::string_view.
PiperOrigin-RevId:
195126422
Justin Lebar [Wed, 2 May 2018 18:40:09 +0000 (11:40 -0700)]
Internal-only change.
PiperOrigin-RevId:
195125476
Anna R [Wed, 2 May 2018 18:38:44 +0000 (11:38 -0700)]
Copy module list before iterating over it. Also, import python module for clarity
gracehoney [Wed, 2 May 2018 18:21:02 +0000 (11:21 -0700)]
Fix formatting and linter issues
Benjamin Kramer [Wed, 2 May 2018 18:17:47 +0000 (11:17 -0700)]
[XLA:GPU] Unroll unfused elementwise op kernels.
So far we only unrolled loop fusions, elementwise ops is a logical extension.
We don't spend a lot of time in unfused elementwise ops in benchmarks, so this
is only worth a small speedup on V100.
PiperOrigin-RevId:
195121530
Peter Hawkins [Wed, 2 May 2018 18:12:58 +0000 (11:12 -0700)]
Automated g4 rollback of changelist
194981511
PiperOrigin-RevId:
195120627
A. Unique TensorFlower [Wed, 2 May 2018 17:57:49 +0000 (10:57 -0700)]
Renames _regression_head_with_mean_squared_error_loss to _regression_head.
PiperOrigin-RevId:
195117425
A. Unique TensorFlower [Wed, 2 May 2018 17:57:13 +0000 (10:57 -0700)]
Initialize all members of CollectiveParams at construction time to avoid
warnings of uninit memory access by dynamic analysis tools.
PiperOrigin-RevId:
195117321
Sanjoy Das [Wed, 2 May 2018 17:43:25 +0000 (10:43 -0700)]
Fix some nits in cpu_literal_caching_test that I noticed after submission
PiperOrigin-RevId:
195114829
Justin Lebar [Wed, 2 May 2018 17:36:26 +0000 (10:36 -0700)]
Internal-only change.
PiperOrigin-RevId:
195113702
Andrew Selle [Wed, 2 May 2018 17:33:07 +0000 (10:33 -0700)]
Fix Makefile to not use benchmark anymore (switch to minimal) (#19019)
Minimal uses nothing and does almost nothing, but it does nothing
requiring protos or rest of tensorflow runtime.
Benchmark_model originally was more like this, but it became
useful for actually benchmarking, making it less useful as a minimal
example.
Shanqing Cai [Wed, 2 May 2018 17:32:47 +0000 (13:32 -0400)]
Merge pull request #19025 from caisq/branch_195061425
Branch
195061425
Benoit Steiner [Wed, 2 May 2018 17:07:13 +0000 (10:07 -0700)]
Optimized the analysis of rank and size operations.
PiperOrigin-RevId:
195108832
A. Unique TensorFlower [Wed, 2 May 2018 17:02:09 +0000 (10:02 -0700)]
Instantiate SwapDimension1And2InTensor3 for Eigen::half
PiperOrigin-RevId:
195107839
Tony Wang [Wed, 2 May 2018 16:52:10 +0000 (09:52 -0700)]
Add Name String to GraphOptimizationPass and Log Registered Passes
Added a name string to GraphOptimization class and set to the class name through REGISTER_OPTIMIZATION macro.
Modified RunGrouping function to log the name and phase of optimization pass that's running.
Added two additional functions to log all registered optimization passes in the order of execution.
PiperOrigin-RevId:
195106355
A. Unique TensorFlower [Wed, 2 May 2018 15:51:07 +0000 (08:51 -0700)]
Automated g4 rollback of changelist
195091587
PiperOrigin-RevId:
195098224
Amit Patankar [Wed, 2 May 2018 15:53:34 +0000 (08:53 -0700)]
Merge pull request #18989 from ctiijima/fix-benchmarks.md
Grammar fixes in BENCHMARKS.md
gracehoney [Wed, 2 May 2018 15:52:39 +0000 (08:52 -0700)]
Merge branch 'master' of https://github.com/tensorflow/tensorflow into optimization_pass
Priya Gupta [Wed, 2 May 2018 15:04:09 +0000 (08:04 -0700)]
Use experimental auto_sharding in multi worker dataset.
PiperOrigin-RevId:
195092992
A. Unique TensorFlower [Wed, 2 May 2018 14:51:53 +0000 (07:51 -0700)]
ArraysExtraInfo: Add name_regexp field and regexp name matching.
PiperOrigin-RevId:
195091587
Paul Van Eck [Wed, 2 May 2018 14:08:30 +0000 (07:08 -0700)]
Allow tfdbg mouse down scroll in curses UI (#18942)
* Allow tfdbg mouse down scroll in curses UI
This commit allows users to continuously scroll the screen when the mouse
is held down on the scroll bar when using the curses UI.
* Only allow click-hold scrolling on scroll bar arrows
Clayne Robison [Wed, 2 May 2018 13:47:58 +0000 (06:47 -0700)]
Reverting changes from 495d511 that break install_pip_packages.sh in Ubuntu 16.04 containers, causing nightly mkl ci builds to fail. (#18888)
Sergii Khomenko [Wed, 2 May 2018 13:39:46 +0000 (15:39 +0200)]
Fix string issue for temp_export_dir (#18951)
* Fix string issue for temp_export_dir
Shanqing Cai [Wed, 2 May 2018 13:36:14 +0000 (09:36 -0400)]
Merge commit for internal changes
A. Unique TensorFlower [Wed, 2 May 2018 08:36:18 +0000 (01:36 -0700)]
BUGFIX: Convert inputs and list of gradients into tuple if they are not instance of tuple. Otherwise this causes "unhashable keys" error when we try to hash.
Also fixed lint error.
PiperOrigin-RevId:
195061425
Mark Heffernan [Wed, 2 May 2018 03:14:29 +0000 (20:14 -0700)]
Add missing colocated element in test in buffer_assignment_test.
This was resulting in a flaky test because sometimes the live set would include this missing colocated element perhaps because the buffers in the allocation has some nondeterministic order (read from a map?).
PiperOrigin-RevId:
195039311
Dan Moldovan [Wed, 2 May 2018 02:05:39 +0000 (19:05 -0700)]
Minor refactor: establish some operator naming conventions and apply them, so that the interface is a bit more consistent.
PiperOrigin-RevId:
195034691
Patrick Nguyen [Wed, 2 May 2018 02:02:10 +0000 (19:02 -0700)]
Make the CRF work when sequence_lengths are int32.
PiperOrigin-RevId:
195034218
Sanjoy Das [Wed, 2 May 2018 01:46:31 +0000 (18:46 -0700)]
[XLA:CPU] Re-use the same llvm::GlobalVariable for identical literals
This isn't necessary today, but it will be after an optimization change I'm
about to make.
LLVM has a constant merging pass too, but one of the motivations here is to
avoid the LLVM compile time overhead of having many large arrays in the IR.
PiperOrigin-RevId:
195032900
A. Unique TensorFlower [Wed, 2 May 2018 00:59:59 +0000 (17:59 -0700)]
Internal change
PiperOrigin-RevId:
195028221
A. Unique TensorFlower [Wed, 2 May 2018 00:57:02 +0000 (17:57 -0700)]
Internal change.
PiperOrigin-RevId:
195027918
Patrick Nguyen [Wed, 2 May 2018 00:48:36 +0000 (17:48 -0700)]
Re-apply CL
194140820, which reverts #18251 (convolution change).
PiperOrigin-RevId:
195027049
Mustafa Ispir [Wed, 2 May 2018 00:21:24 +0000 (17:21 -0700)]
test fix
PiperOrigin-RevId:
195023740