Dennis Kaarsemaker [Sun, 10 Nov 2013 22:17:38 +0000 (23:17 +0100)]
Make tests work with detached git dir
In my jenkins replacement, I run all tests with .git outside the work tree,
pointed to by $GIT_DIR. This is fairly common git practice, so let's make the
testsuite support this and run the relevant porting tests that are skipped
without this patch.
Tony Cook [Sun, 15 Dec 2013 22:35:00 +0000 (09:35 +1100)]
fix format string warnings in regcomp.c
Father Chrysostomos [Sun, 15 Dec 2013 20:39:18 +0000 (12:39 -0800)]
[perl #72406] Bad read with do{} until CONST
According to the original bug report, ‘do{print("foobar");}until(1)}’
crashes. In recent perls it doesn’t, partly because of the slab allo-
cator, partly because such crashes are naturally fleeting.
‘foo while bar’ and ‘foo until bar’ make their way through newLOOPOP,
which then usually calls S_new_logop, to create and AND or OR op with
special pointers that turn it into a loop.
Because S_new_logop knows about folding ‘$x if 1’ down to a simple $x,
and because ‘do{foo()} while 0’ should still execute the do block,
newLOOPOP skips the call to S_new_logop in that case.
Hence, it assumes that if it has seen a do block on its lhs, then
S_new_logop must return an AND or OR op.
‘foo until bar’ is actually changed early on (in perly.y) to ‘foo
while !bar’, before it reaches newLOOPOP. Constant folding usually
folds !1 down to a simple ""/0 (actually &PL_sv_no), so newLOOPOP sees
‘foo while 0’ for ‘foo until 1’.
If constant folding fails (e.g., because the parser has seen an
unmatched } and constant folding is skipped after such errors), then
newLOOPOP will see the unfolded !1.
S_new_logop has a special optimisation that changes ‘!foo && bar’ to
‘foo || bar’, etc.
That optimisation allows it to ‘see through’ the unoptimised !1 (a NOT
with a CONST kid) and get to the constant, folding the resulting op
and returning something that newLOOPOP is not expecting to be folded.
In the case of ‘do{print("foobar");}until(1)}’, it optimises the do
block away, which is wrong.
So newLOOPOP reads past the end of the op in this line:
o->op_next = ((LOGOP*)cUNOPo->op_first)->op_other;
because it is treating an SVOP as a LOGOP.
I can trigger this condition by defeating constant folding some other
way. Croaking in boolean overloading, but just the first time, will
do that, and crashes with blead:
{ package o; use overload bool => sub { die unless $::ok++; return 1 } }
use constant OK => bless [], o::;
do{print("foobar");}until OK;
__END__
Bus error: 10
My reading of the source code leads me to believe that this bad read
has been present since perl 5.000. But back then it was not possible
to trigger it with this particular test case involving fatal overload-
ing (as of
b7f7fd0bb it seems*), but ‘do{print("foobar");}until(1)}’
would have triggered it.
* Thanks to Matthew Horsfall for finding it.
Matthew Horsfall [Sun, 15 Dec 2013 03:25:22 +0000 (22:25 -0500)]
Also optimise returning lists: 'return ($one, $two);'
Matthew Horsfall (alh) [Fri, 13 Dec 2013 17:57:47 +0000 (12:57 -0500)]
Tests for rpeep optimisations in
e45d8982ae
Father Chrysostomos [Sat, 14 Dec 2013 01:48:34 +0000 (17:48 -0800)]
Fix ‘Can't declare null operation in "my"’
This message is very unhelpful. This was brought up in
ticket #115688.
Father Chrysostomos [Sat, 14 Dec 2013 01:01:46 +0000 (17:01 -0800)]
op.c: Factor out two identical yyerror calls
James E Keenan [Sat, 14 Dec 2013 00:08:09 +0000 (01:08 +0100)]
Explain how '--' works in command-line invocation.
Excerpted from 'man bash': GNU Bash-2.05b, 2002 July 15.
For: RT #120732, as requested by bulk88.
Matthew Horsfall [Wed, 11 Dec 2013 23:28:21 +0000 (18:28 -0500)]
Optimise out PUSHMARK/RETURN if return is the last statement in a sub.
This makes:
sub baz { return $cat; }
Behave like:
sub baz { $cat; }
Which is notably faster.
Unpatched:
./perl -Ilib/ ~/stuff/bench.pl
Benchmark: timing
40000000 iterations of normal, ret...
normal: 3 wallclock secs ( 1.60 usr + 0.01 sys = 1.61 CPU) @
24844720.50/s (n=
40000000)
ret: 3 wallclock secs ( 2.08 usr + 0.00 sys = 2.08 CPU) @
19230769.23/s (n=
40000000)
Patched:
./perl -Ilib ~/stuff/bench.pl
Benchmark: timing
40000000 iterations of aret, normal...
normal: 2 wallclock secs ( 1.72 usr + 0.00 sys = 1.72 CPU) @
23255813.95/s (n=
40000000)
ret: 2 wallclock secs ( 1.72 usr + 0.00 sys = 1.72 CPU) @
23255813.95/s (n=
40000000)
The difference in OP trees can be seen here:
Unpatched:
$ perl -MO=Concise,baz -e 'sub baz { return $cat }'
main::baz:
5 <1> leavesub[1 ref] K/REFC,1 ->(end)
- <@> lineseq KP ->5
1 <;> nextstate(main 1 -e:1) v ->2
4 <@> return K ->5
2 <0> pushmark s ->3
- <1> ex-rv2sv sK/1 ->4
3 <#> gvsv[*cat] s ->4
-e syntax OK
Patched:
$ ./perl -Ilib -MO=Concise,baz -e 'sub baz { return $cat }'
main::baz:
3 <1> leavesub[1 ref] K/REFC,1 ->(end)
- <@> lineseq KP ->3
1 <;> nextstate(main 1 -e:1) v ->2
- <@> return K ->-
- <0> pushmark s ->2
- <1> ex-rv2sv sK/1 ->-
2 <$> gvsv(*cat) s ->3
-e syntax OK
(Includes some modifications from Steffen)
Brian Fraser [Mon, 18 Nov 2013 18:49:22 +0000 (15:49 -0300)]
cflags.SH: Fix a typo, cflags should be ccflags
This went undetected for the longest time since most flags are
irrelevant at this point, but is vital if you are using --sysroot.
Karl Williamson [Mon, 9 Dec 2013 23:06:01 +0000 (16:06 -0700)]
pod/perlhacktips: Further info on glibc bug
Commit
6bfe0388956736a32b874cc5e31cc6437260b227 prompted me to do some
more digging. The bug in glibc has apparently been fixed in 2.17.
David Mitchell [Mon, 9 Dec 2013 14:18:44 +0000 (14:18 +0000)]
perlfunc: clarify subroutine value of caller()
The docs don't actually say what the fourth value returned by caller()
is; in particular, the $subroutine value is a bit confusing because
it's the sub called by the call site, not the sub containing the call
site. [perl #120696].
Daniel Dragan [Mon, 9 Dec 2013 00:46:19 +0000 (19:46 -0500)]
WinCE makefile will now hypothetically build git_version.h
The dependency on $(CONFIGPM) is for git_version.h to exist early enough
to be copied to the CORE dir. In real life, git_version.h still is built
by a Desktop build since WinCE doesn't yet support being built with a
system Perl. This commit is a step in getting WinCE to build without
needing a Desktop build first and for better integration with Castaway's
Cross changes in the future. The changes in this commit were tested with
other unpublished changes that tried to do a WinCE build with a system
Perl.
Daniel Dragan [Mon, 9 Dec 2013 00:38:49 +0000 (19:38 -0500)]
cleanup ..\git_version.h rule in win32/Makefile
Group the nmake line onto 1 line similar to the dmake version, for 1 shell
call out vs 3. "&&" makes sure the build stops if miniperl returns non-0
instead of ignoring the code, cd'ing back to dir win32, and continuing
the build. Part of RT #120727.
Tony Cook [Mon, 9 Dec 2013 03:39:20 +0000 (14:39 +1100)]
Tony Cook [Wed, 4 Dec 2013 00:30:57 +0000 (01:30 +0100)]
Brian Childs is now a perl AUTHOR
Brian Childs [Tue, 3 Dec 2013 05:33:41 +0000 (06:33 +0100)]
Fixes the case where on 64bit big-endian boxes, calls to semctl(id,semnum,SETVAL,$wantedval) will ignore the passed in $wantedval, and always use 0
James E Keenan [Sun, 8 Dec 2013 15:10:01 +0000 (16:10 +0100)]
Test previously untested branches in lib/File/Find.pm.
Karl Williamson [Sun, 8 Dec 2013 16:48:55 +0000 (09:48 -0700)]
Improve comments
These improve some comments introduced by
99dd98225733b6b66a524dfeb20a486e012e39b3.
Suggested by Lukas Mai
Karl Williamson [Sun, 8 Dec 2013 15:20:58 +0000 (08:20 -0700)]
Silence core test Useless use of greediness modifier
There are two .t files that have useless greediness modifiers. A
warning was instroduced in commit
4fa6dd16d2149c2aeeb32633e3a796d5ebc5b657 when this occurs. This
silences those warnings in the two .t files
Craig A. Berry [Sun, 8 Dec 2013 14:06:58 +0000 (08:06 -0600)]
Error check VMS's backticks stdin inheritance.
This is a follow-up to
e2d6c6fbf5bb. The use case I've seen is
that the translation of SYS$INPUT succeeds but the stat on the
resulting file/device fails, possibly due to object protections.
So we would be giving the child something it can't open.
Add error checking to the logic so in order to set up inheritance
of SYS$INPUT:
1.) The translation of SYS$INPUT must succeed.
2.) stat() on the resulting spec must succeed.
3.) The resulting spec must not be a directory.
Karl Williamson [Sat, 7 Dec 2013 16:32:51 +0000 (09:32 -0700)]
regcomp.c: Silence compiler warnings
This changes some formats to add an 'l' modifier, and adds a cast.
Karl Williamson [Fri, 6 Dec 2013 22:50:52 +0000 (15:50 -0700)]
PATCH: [Perl #42957] Suggesting warning for useless greediness operator
This adds the requested warning. Now we'll see if anything breaks as a
result.
Karl Williamson [Fri, 6 Dec 2013 22:26:53 +0000 (15:26 -0700)]
regcomp.c: White-space only
Vertically stack ? : ternary operators for better visibility
James E Keenan [Sat, 7 Dec 2013 13:45:16 +0000 (14:45 +0100)]
Remove tests of $File::Find::untaint_pattern.
This in effect reverts commit
5ea8618bf5cf20c62d2ccca6aca10d97e0945b89.
The effects of this package variable are not yet well enough understood to
write tests that pass consistently. The block of tests removed was failing on
Win32 in all situations and on Linux in some.
For: RT #120711
Chris 'BinGOs' Williams [Sat, 7 Dec 2013 09:40:43 +0000 (09:40 +0000)]
Update Unicode-Collate to CPAN version 1.04
[DELTA]
1.04 Sat Dec 7 11:34:18 2013
- XS: a workaround for perl 5.6.x to handle U+FFFF correctly.
unpack_U() is implemented by using XS again as well as that in 1.02,
but now that is used only in the versions before perl 5.8.0.
Father Chrysostomos [Sat, 7 Dec 2013 02:41:08 +0000 (18:41 -0800)]
[Merge] Get minitest passing again
One significant change is to the way miniperl gets its @INC set up.
Now buildcustomize.pl replaces lib with its special list, instead of
clobbering the entirety of @INC. This allows tests to use runperl
with -I, without having to go through hoops to get things to work.
Father Chrysostomos [Wed, 4 Dec 2013 14:12:56 +0000 (06:12 -0800)]
t/uni/variables.t: Skip $[ test under miniperl
Father Chrysostomos [Wed, 4 Dec 2013 14:12:35 +0000 (06:12 -0800)]
Skip eintr_print.t under miniperl
Father Chrysostomos [Wed, 4 Dec 2013 14:00:01 +0000 (06:00 -0800)]
crlf.t: Add skip count
Father Chrysostomos [Wed, 4 Dec 2013 13:56:08 +0000 (05:56 -0800)]
Get switches.t to pass under miniperl
Father Chrysostomos [Wed, 4 Dec 2013 13:46:40 +0000 (05:46 -0800)]
Do not clobber @INC completely in buildcustomize.pl
buildcustomize.pl (for miniperl) replaces @INC (usually qw(lib .))
with the whole list of build directories we need followed by
qw(lib .).
runperl from test.pl is such that this:
runperl(switches => [ "-Irun/flib" ], ...)
turns into:
/path/to/perl.git/miniperl "-I../lib" -Irun/flib
The end result is that -Irun/flib gets stripped out and clobbered, and
switchM.t fails under minitest.
Father Chrysostomos [Wed, 4 Dec 2013 13:28:20 +0000 (05:28 -0800)]
Add DO NOT EDIT notice to buildcustomize.pl
Karl Williamson [Fri, 6 Dec 2013 21:23:43 +0000 (14:23 -0700)]
perlapi, sv.c: Comments and API documentation
Karl Williamson [Fri, 6 Dec 2013 21:03:51 +0000 (14:03 -0700)]
perlretut: Spelling
Karl Williamson [Fri, 6 Dec 2013 20:56:51 +0000 (13:56 -0700)]
perlrebackslash: Add clarifying note about \X
Karl Williamson [Thu, 12 Sep 2013 03:41:32 +0000 (21:41 -0600)]
perlhacktips: Note sprintf glibc bug and workarounds
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2013-09/msg00506.htmlP
Karl Williamson [Fri, 6 Dec 2013 05:19:09 +0000 (22:19 -0700)]
utf8.c: White-space only
Rearrange this multi-line conditional to be easier to read.
Karl Williamson [Tue, 3 Dec 2013 04:55:55 +0000 (21:55 -0700)]
utf8.h: Add parameter checking to some macros in DEBUGGING builds
This change should catch some wrong calls to these macros. The meat of
the macros is extracted out into two internal-only macros, and the other
macros are rearranged to call these.
Karl Williamson [Thu, 5 Dec 2013 06:56:34 +0000 (23:56 -0700)]
perlapi: Grammar nits
"The" referring to a parameter here does not look right to me, a native
English speaker.
Karl Williamson [Thu, 5 Dec 2013 06:53:14 +0000 (23:53 -0700)]
utf8.c: Remove hard-coded names.
The names of these hashes stored in some disk files is retrievable by a
standardized lookup. There is no need to have them hard-coded in C
code. This is one less opportunity for the file and the code to get out
of sync.
Karl Williamson [Thu, 5 Dec 2013 06:01:30 +0000 (23:01 -0700)]
regcomp.c: Rmv inaccurate and tangential comment
This comment contained inaccuracies and referred to behavior that has
been removed from the core for years. isPRINT() is sufficiently
documented elsewhere to not need to have its use justified here.
I considered moving part of it to perlebcdic, but it's not generally
true: it's not true for one of Perl's supported EBCDIC code pages, for
example.
Karl Williamson [Thu, 5 Dec 2013 05:46:08 +0000 (22:46 -0700)]
mktables: Add comments to output tables
Father Chrysostomos [Thu, 5 Dec 2013 00:00:48 +0000 (16:00 -0800)]
[perl #120694] Fix ->SUPER::foo and AUTOLOAD
Commit
aae438050a20 (5.17.4) broke ->SUPER::foo with AUTOLOAD by look-
ing up AUTOLOAD from the current package, rather than the current
package’s superclass.
Instead of keeping track of whether it was doing a SUPER lookup via a
::SUPER prefix on the package name, that commit changed method lookup
to pass a GV_SUPER flag around (to fix another bug) and to pass the
current stash, rather than __PACKAGE__::SUPER. But it did not update
gv_autoload_pvn to pass that flag through to gv_fetchmeth_pvn when
actually looking up the method.
Karl Williamson [Thu, 5 Dec 2013 04:24:38 +0000 (21:24 -0700)]
regexec.c: No statements before declarations
Commit
b99851e1941e002dd4816ee6c76fd49bbee1d7f3 moved a statement to
before the declarations in its block. Mea culpa. It turns out that I
missed the warnings that were shown for -W=declaration-after-statement.
I'm henceforth changing that to -Werror=declaration-after-statement.
Karl Williamson [Thu, 5 Dec 2013 02:50:04 +0000 (19:50 -0700)]
perllocale: Add info about locale testing.
Karl Williamson [Thu, 5 Dec 2013 02:47:19 +0000 (19:47 -0700)]
perllocale: Nit, and clarification
Karl Williamson [Wed, 4 Dec 2013 17:06:04 +0000 (10:06 -0700)]
PATCH: [perl #120675] Unexpected tainting via regex using locale
Tainting should only be turned on if something that could be tainted is
actually tried. Hence in a [bracketed character class], if the
character being matched is something like
"a" =~ /([a-z])/l;
tainting isn't turned on because the match doesn't actually depend on
the locale definition. That is, it would match regardless of the
locale. Similarly,
"A" =~ /([a-z])/l;
shouldn't turn on tainting because it shouldn't match no matter what
locale is in effect. However, until this commit, this worked only
because of a compilte time optimization. The following (from the
ticket) isn't optimized and didn't work until this commit:
"foo.bar_baz" =~ /^(.*)[._](.*?)$/';
The [._] was causing tainting even though there is nothing in the
pattern that is locale-dependent.
This commit just moves the tainting to code branches where the locale
actually does matter. It was just turning it on for any bracketed
character class where the target character didn't match any of the
explicit characters in the class.
Karl Williamson [Tue, 3 Dec 2013 06:23:50 +0000 (23:23 -0700)]
mktables: Clean up relict usage
The 'status' of a table generated by mktables was split into two
concepts; these lines should have been changed to reflect that split,
but weren't. This didn't affect what actually gets generated.
concept
Karl Williamson [Tue, 3 Dec 2013 05:44:36 +0000 (22:44 -0700)]
mktables: Default those tables whose names begin with '_' to internal
Some tables that mktables generates are for specialized internal core
use, and should not be accessible through Unicode::UCD nor listed in
perluniprops. The creation code for _Perl_Any_Folds was moved by commit
8d88896d10ee81fb95a9494ca771f9d2b14f5fc7, but it wasn't a clean move and
the line that caused it to be marked as internal was accidentally removed.
This commit changes things to default to internal-only if the name
begins with an underscore, overridable by an explicit setting. Thus the
line that got omitted is no longer necessary, and future mistakes like
this won't have any effect. This is the only property currently
affected by this change.
Karl Williamson [Tue, 3 Dec 2013 05:20:51 +0000 (22:20 -0700)]
perluniprops: Nit
This uses the singular, but might be output applying to more than one.
Karl Williamson [Tue, 3 Dec 2013 05:00:31 +0000 (22:00 -0700)]
perlapi: Nits
Karl Williamson [Tue, 3 Dec 2013 04:54:37 +0000 (21:54 -0700)]
utf8.h: Fix grammar in comment
Karl Williamson [Tue, 3 Dec 2013 02:28:52 +0000 (19:28 -0700)]
lib/locale.t: Only output debug message if relevant
This message telling people to set an environment variable was output
even if the variable was already set; this is potentially confusing
David Mitchell [Wed, 4 Dec 2013 17:05:16 +0000 (17:05 +0000)]
perllocale.pod: clarify tainting of $1 et al
[perl #120675]
The docs weren't clear that *any* locale info used in a regex taints *all*
of $1, $2,...
Father Chrysostomos [Wed, 4 Dec 2013 12:24:32 +0000 (04:24 -0800)]
toke.c: Pass GV_NOTQUAL for override lookup
We know in this code path that the name is unqualified, so tell
gv_fetchpvn_flags to skip the parser that looks for package
separators.
Chris 'BinGOs' Williams [Wed, 4 Dec 2013 08:46:07 +0000 (08:46 +0000)]
Update CPAN-Meta to CPAN version 2.133380
[DELTA]
2.133380 2013-12-03 23:01:07 America/New_York
[FIXED]
- Improved bad version handling during META conversion
- When downgrading multiple licenses to version 1.x META formats, if all
the licenses are open source, the downgraded license will be
"open_source", not "unknown"
Chris 'BinGOs' Williams [Wed, 4 Dec 2013 08:21:39 +0000 (08:21 +0000)]
Update Time-Piece to CPAN version 1.24
[DELTA]
1.24 2013-12-03
- add repository metadata (thanks, David Steinbrunner)
James E Keenan [Wed, 4 Dec 2013 02:56:13 +0000 (03:56 +0100)]
Add test for previously uncovered case.
Explicitly assigned $File::Find::untaint_pattern.
James E Keenan [Sun, 1 Dec 2013 18:24:06 +0000 (19:24 +0100)]
Standardize dir_path() and file_path() in package Testing.
The versions of dir_path() and file_path() previously found in find.t and
taint.t differed only in VMS-specific provisions in taint.t. Move the
taint.t-versions to the package and use them in both files.
Karl Williamson [Sun, 1 Dec 2013 18:25:34 +0000 (11:25 -0700)]
lib/locale.t: Test /il matching
Case-insensitive matching was essentially being skipped here. This was
because some locales were broken on some platforms which caused locale.t
to always fail somewhere. However, the previous commit has changed that
so if just a few locales are bad, the tests are marked as TODOs. Thus
we can make the /il match tests robust.
Karl Williamson [Tue, 3 Dec 2013 01:28:34 +0000 (18:28 -0700)]
lib/locale.t: Make another test TODO if it fails
Many platforms have a few locales whose casing functionality is buggy.
However if only a few locales have failures, it probably means that Perl
is ok; and its the platform's locale definitions that are bad. Earlier,
commit
6d5d702a337e9161f8eb85180a83c4469a8f7ed7 enhanced locale.t, if
only a few locales fail, to mark some tests which were showing these
kinds of bugs as TODOs. This allowed robust tests to be added to
locale.t which previously were ommitted so as to not cause the tests to
fail if any locale on any platform was bad. Not having these tests
allowed real Perl bugs to creep in.
This commit adds the /il match testing to the list of these tests.
Currently, it is set to hardly catch anything; and this allowed
another real bug to be introduced into Perl.
This commit was prompted by bugs in Darwin with ISO8859-4 and ISO8859-13
locales.
Karl Williamson [Tue, 3 Dec 2013 01:06:10 +0000 (18:06 -0700)]
lib/locale.t: Use lexical instead of $_ in a block
This is because $_ will be used in a future commit for something else
Karl Williamson [Sun, 1 Dec 2013 18:07:44 +0000 (11:07 -0700)]
lib/locale.t: Add some debugging info
Karl Williamson [Sun, 1 Dec 2013 17:55:47 +0000 (10:55 -0700)]
lib/locale.t: Add debug verbosity level
Several prints were commented out (by using an 'if 0'). Instead convert
them to use the function that displays characters using only ASCII
printables, and subject to output when the PERL_DEBUG_FULL_TEST is more
than 1.
Karl Williamson [Sun, 1 Dec 2013 17:47:41 +0000 (10:47 -0700)]
lib/locale.t: Shorten function name
This is just so that future commits won't have to wrap so many lines to
fit in 79 columns
Karl Williamson [Sun, 1 Dec 2013 17:43:39 +0000 (10:43 -0700)]
utf8.c: Use U8 instead of UV in several places
These temporaries are all known to fit into 8 bits; by using a U8 it
should be more obvious to an optimizing compiler, and so the bounds
checking need not be done.
Karl Williamson [Sat, 30 Nov 2013 22:26:07 +0000 (15:26 -0700)]
Fix broken locale case-insensitive matching
Commit
68067e4e501e2ae1c0fb44558b6aa5c0a80a4143 inadvertently
broke regular expression /i matching under locale. The tests for this
were defective, so the breakage was not caught. A later commit will fix
the tests, but this commit restores the functionality.
It also casts the input parameter to some functions to be U8 to make
sure that optimizing compilers can omit bounds checks
Karl Williamson [Tue, 3 Dec 2013 04:46:37 +0000 (21:46 -0700)]
perlapi: May want to use savesharedpv on threaded Win32
Adds a note to savepv (and similar) that on threaded Windows
that you may need to use the saveshared version because the memory is
deallocated when the thread ends.
Karl Williamson [Fri, 29 Nov 2013 17:27:47 +0000 (10:27 -0700)]
doio.c: Remove EBCDIC dependency
For non-EBCDIC this file used \012 instead of \n. This may have been a
MAC OS Classic hack, which we no longer support.
Karl Williamson [Wed, 27 Nov 2013 19:46:42 +0000 (12:46 -0700)]
regcomp.c: Slight optimization
A swash is accessed either through its inversion list or its hash (only
large swashes actually have hashes; this is usually transparent). At
this point in regcomp.c, we only will be looking at the inversion list;
by telling swash_init function that via the flag, later accesses
automatically have a level of indirection removed.
Karl Williamson [Wed, 27 Nov 2013 17:19:22 +0000 (10:19 -0700)]
perlop: Add note about (?[])
Craig A. Berry [Sun, 1 Dec 2013 23:16:47 +0000 (17:16 -0600)]
Check unlink on directory for all users, not just root.
For cross-platform consistency, it makes more sense to reject
unlink attempts on directories in the same way for all users
rather than only for root. geteuid() always returns zero on
Windows, never returns zero on VMS, and is a poor indicator
of privilege on modern unixen, so the code really hasn't been
working as intended on all platforms anyway.
Evan Zacks [Tue, 26 Nov 2013 14:56:11 +0000 (09:56 -0500)]
Make unlink on directory as root set errno.
If unlink is called on an existing directory while running as root without -U
(PL_unsafe), the unlink call fails but does not set $!, because unlink(2) is
not actually called in this case.
If unlink is called as a user (or as root with -U), unlink(2) is invoked, so
attempting to remove a directory would set errno to EISDIR as expected. If
running as root without -U (PL_unsafe is false), lstat and S_ISDIR are called
instead. If the lstat succeeds and S_ISDIR returns true, the argument is
skipped without warning and without setting $!, meaning Perl's unlink can
return failure while leaving the previous value of errno in place.
This commit sets errno to EISDIR for this case.
Chris 'BinGOs' Williams [Mon, 2 Dec 2013 12:56:23 +0000 (12:56 +0000)]
Update Locale-Codes to CPAN version 3.28
Steve Hay [Mon, 2 Dec 2013 09:12:24 +0000 (09:12 +0000)]
Merge branch 'dirnames' into blead
Father Chrysostomos [Mon, 2 Dec 2013 06:40:19 +0000 (22:40 -0800)]
Page number for caretx.c Tolkien quote
Tom Christiansen kindly provided it in <30867.
1385946564@chthon>.
Father Chrysostomos [Sun, 1 Dec 2013 20:16:09 +0000 (12:16 -0800)]
sv.c: Rewrite COW logic
for readability, maintainability, and my sanity.
The comment about swipe and COW having ‘much in common’ notwithstand-
ing (actually they only shared two lines of code), I separated those
two code paths, splitting the horribly complex ‘if’ condition into
two. I also made the code slightly more repetitive, resulting in
fewer #ifdefs and more clarity.
James E Keenan [Sun, 1 Dec 2013 17:35:54 +0000 (18:35 +0100)]
Extract subroutines used to test File-Find into separate package.
t/porting/manifest.t and pod_rules.t: Add comments describing how to handle a
MANIFEST which is not sorted properly (per recommendation by Nicholas Clark).
James E Keenan [Sun, 1 Dec 2013 15:43:47 +0000 (16:43 +0100)]
Standardize subroutine definitions between tests.
In taint.t, replace touch() with create_file_ok() and MkDir() with mkdir_ok().
Make definition of wanted_File_Dir() identical in both test files.
This is a step on the road to eliminating repeated code.
Chris 'BinGOs' Williams [Sun, 1 Dec 2013 15:21:38 +0000 (15:21 +0000)]
Update Unicode-Collate to CPAN version 1.03
[DELTA]
1.03 Sun Dec 1 21:45:46 2013
- XS: now unpack_U() uses unpack('U*') in pure perl.
avoid XS for the internal "utf8" encoding of perl.
David Mitchell [Sun, 1 Dec 2013 11:16:52 +0000 (11:16 +0000)]
don't check format args on taint_proper
My recent commit
5d37acd6b65eb enabled (among other things)
format-arg checking of taint_proper(). This was not a good idea since
taint_proper() adds extra args before it actually calls a printf-style
function. This was masked since on some gcc systems, a NULLOK format arg
disables this check.
Chris 'BinGOs' Williams [Sat, 30 Nov 2013 22:55:42 +0000 (22:55 +0000)]
Update ExtUtils-MakeMaker to CPAN version 6.84
[DELTA]
6.84 Sat Nov 30 15:22:35 GMT 2013
No changes from 6.83_06
6.83_06 Fri Nov 29 21:50:51 GMT 2013
Doc fixes:
* Correct the documentation for MAGICXS
6.83_05 Mon Nov 25 22:51:11 GMT 2013
New Features:
* Added MAGICXS attribute to explicitly enable automagic
XS building.
Bug fixes:
* RT#90780 fix Macro `BOOTSTRAP' redefined warnings
* Only enable automatic OBJECT generation if MAGICXS is true
6.83_04 Sun Nov 17 11:41:43 GMT 2013
New Features:
* OBJECT can now be specified as an array
* build C_FILES/O_FILES/OBJECT automatically from XS
6.83_03 Fri Nov 15 09:44:26 GMT 2013
Bug fixes:
* Don't recurse into stale dist dirs
6.83_02 Tue Nov 12 11:11:34 GMT 2013
Misc:
* Enable bootstrapping to work on v5.10.x again
6.83_01 Tue Nov 5 11:43:50 GMT 2013
Misc:
* disable make parallelism for pure_all target
Father Chrysostomos [Sat, 30 Nov 2013 20:56:56 +0000 (12:56 -0800)]
sv.c: Clarify COW comments further
I was getting confused even when I wrote these comments.
Craig A. Berry [Sat, 30 Nov 2013 14:47:09 +0000 (08:47 -0600)]
Fix stdin inheritance for system and backticks on VMS.
The documentation to LIB$SPAWN says that standard input will be
inherited from the parent if not specified, and we've been
depending on that. But it seems not to actually work that way
as a simple
$ perl -e "system('edit foo.tmp');"
was failing due to the input not being a terminal. So set up the
input explicitly using the same mechanism we've always used for
output and error.
Except when SYS$INPUT is a "directory," which probably means it's
a channel open on a volume that holds a command procedure.
Father Chrysostomos [Sat, 30 Nov 2013 14:43:00 +0000 (06:43 -0800)]
regen pod issues
Father Chrysostomos [Sat, 30 Nov 2013 14:16:57 +0000 (06:16 -0800)]
sv.c: Fix Darwin g++ build
Father Chrysostomos [Sat, 30 Nov 2013 13:55:54 +0000 (05:55 -0800)]
[Merge] Swiping PADTMPs’ string buffers
This branch allows PADTMPs’ string buffers to be stolen, benefiting
programs that use long strings by avoiding a few copies.
Father Chrysostomos [Sat, 30 Nov 2013 13:55:40 +0000 (05:55 -0800)]
Peek.t: Update skip version
I did not have this branch ready in time for 5.19.6.
Father Chrysostomos [Sat, 30 Nov 2013 02:58:36 +0000 (18:58 -0800)]
Increase $constant::VERSION to 1.30
Father Chrysostomos [Wed, 20 Nov 2013 14:19:05 +0000 (06:19 -0800)]
sv.c: String copy comments
This layout, which goes back to
765f542df2 in 2002, I find a bit con-
fusing. The comments help. (Though rewriting it might be better.)
Granted, back in 2002 there wasn’t nearly as much code in any of
the branches.
Father Chrysostomos [Thu, 14 Nov 2013 02:10:49 +0000 (18:10 -0800)]
Allow PADTMPs’ strings to be swiped
While copy-on-write does speed things up, it is not perfect. Take
this snippet for example:
$a = "$b$c";
$a .= $d;
The concatenation operator on the rhs of the first line has its own
scalar that it reuses every time that operator is called (its target).
When the assignment happens, $a and that target share the same string
buffer, which is good, because we didn’t have to copy it. But because
it is shared between two scalars, the concatenation on the second line
forces it to be copied.
While copy-on-write may be fast, string swiping surpasses it, because
it has no later bookkeeping overhead. If we allow stealing targets’
strings, then $a = "$b$c" no longer causes $a to share the same string
buffer as the target; rather, $a steals that buffer and leaves the tar-
get undefined. The result is that neither ‘$a =’ nor ‘$a .= $d’ needs
to copy any strings. Only the "$b$c" will copy strings (unavoidably).
This commit only applies that to long strings, however. This is why:
Simply swiping the string from any swipable TARG (which I tried at
first) resulted in a significant slowdown. By swiping the string from
a TARG that is going to be reused (as opposed to a TEMP about to be
freed, which is where swipe was already happening), we force it to
allocate another string next time, greatly increasing the number
of malloc calls. malloc overhead exceeds the overhead of copying
short strings.
I tried swiping TARGs for short strings only when the buffer on the
lhs was not big enough for a copy (or there wasn’t one), but simple
benchmarks with mktables show that even checking SvLEN(dstr) is enough
to slow things down, since the speed-up this provides is minimal where
short strings are involved.
Then I tried checking just the string length, and saw a consistent
speed increase. So that’s what this patch uses. Programs using short
strings will not benefit. Programs using long strings may see a 1.5%
increase in speed, due to fewer string copies.
Father Chrysostomos [Wed, 13 Nov 2013 13:52:00 +0000 (05:52 -0800)]
op.c: Turn on read-only flag for folded constants
They are marked PADTMP, which causes them to be copied in any contexts
where readonliness makes a difference, so marking them as read-only
does not change the behaviour. What it does is allow a future commit
to implement string swiping for PADTMPs.
Father Chrysostomos [Wed, 13 Nov 2013 04:40:11 +0000 (20:40 -0800)]
constant.pm: Make elements of list consts read-only
Now that Internals::SvREADONLY turns on the PADTMP flag for all the
elements, the read-only flag on the elements themselves will not
actually make the returned elements read-only, because PADTMPs get
copied in all cases where readonliness matters. What this does is
prevent the original SV from being modified, allowing for more opti-
misations in perl’s internals (e.g., string buffers being stolen from
PADTMPs not marked read-only).
The order of the statements needs to be rearranged, otherwise we end
up setting the flag on a temporary copy of each element due to ‘for’.
David Mitchell [Sat, 30 Nov 2013 12:20:50 +0000 (12:20 +0000)]
silence -Wformat-nonliteral in pp_formline
David Mitchell [Sat, 30 Nov 2013 12:16:17 +0000 (12:16 +0000)]
revert pp_formline -Wformat-nonliteral fix
Revert the part of
5d37acd6b65eb421e938a3fde62cc1edde467dae that was
intended to silence non-literal format warnings. It's giving compiler
errors on AIX due (I suspect) to overlong macro expansions.
The next commit will fix the warning in a more prosaic fashion
Chris 'BinGOs' Williams [Fri, 29 Nov 2013 21:07:00 +0000 (21:07 +0000)]
Update HTTP-Tiny to CPAN version 0.039
[DELTA]
0.039 2013-11-27 19:48:29 America/New_York
[FIXED]
- Temporary file creating during mirror() is now opened with O_EXCL
for added security
David Mitchell [Fri, 29 Nov 2013 17:44:12 +0000 (17:44 +0000)]
fix -Wsign-compare in core
There were a few places that were doing
unsigned_var = cond ? signed_val : unsigned_val;
or similar. Fixed by suitable casts etc.
The four in utf8.c were fixed by assigning to an intermediate
unsigned var; this has the happy side-effect of collapsing
a large macro expansion, where toUPPER_LC() etc evaluate their arg
multiple times.
David Mitchell [Fri, 29 Nov 2013 16:12:20 +0000 (16:12 +0000)]
Move Cwd and List-Util: UNIX followup
the previous commit worked on win32; this commit makes it work under UNIX
too.
Basically Configure determines a list of "logical" extension names
such as "IPC/SysV", based on physical dirs under cpan/ etc such as
"IPC-SysV".
In this case, keep the original logical names "Cwd" and "List/Util",
even though the physical paths have been changed to "PathTools" and
"Scalar/List/Utils".
Father Chrysostomos [Fri, 29 Nov 2013 00:05:30 +0000 (16:05 -0800)]
Revert part of
2efab60d9
As Karl Williamson pointed out in <
5296C04E.10103@khwilliamson.com>,
sv_setpv will do SvOK_off if Strerror returns null, so this SvOK check
is not redundant.