platform/upstream/mesa.git
15 months agogallium: Remove `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
Lucas Fryzek [Fri, 7 Jul 2023 19:15:20 +0000 (15:15 -0400)]
gallium: Remove `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`

Since the mesa state tracker can promote RGB texture formats
to RGBA texture formats (among other formats) without exposing
any of that information to a driver, it is more desirable to
have the behaviour of `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
be the default. This avoids rendering bugs where an application
sets `DST_ALPHA` blending on a format where there is no alpha
channel, that has been promoted to a format that actually has an
alpha channel. The driver can instead rely on the common code
in the state tracker to convert the blending parameter to one
that reflects the limitations of the application requested format,
as long as `PIPE_CAP_INDEP_BLEND_FUNC` is supported.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24044>

15 months agotu: Fix zombie VMAs array not initialized when first BOs may be freed
Danylo Piliaiev [Tue, 11 Jul 2023 10:13:08 +0000 (12:13 +0200)]
tu: Fix zombie VMAs array not initialized when first BOs may be freed

First BOs were allocated before zombie_vmas was initialized so on
failure their clean up paths used uninitialized zombie_vmas.

Fixes
 dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic
 dEQP-VK.api.object_management.alloc_callback_fail.device_group

See https://gitlab.freedesktop.org/mesa/mesa/-/issues/9247

Fixes: 63904240f21b192a5fb1e79046a2c351fbd98ace
("tu: Re-enable bufferDeviceAddressCaptureReplay")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24086>

15 months agoci: set priority:low tag only on non-Marge pipelines
Eric Engestrom [Mon, 3 Jul 2023 16:30:38 +0000 (17:30 +0100)]
ci: set priority:low tag only on non-Marge pipelines

This allows dynamically setting the priority to avoid starving Marge.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23976>

15 months agoci: document workflow rules
Eric Engestrom [Mon, 3 Jul 2023 16:37:46 +0000 (17:37 +0100)]
ci: document workflow rules

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23976>

15 months agoradeonsi/gfx11: fix a regression with PAIRS packets due to shader changes
Marek Olšák [Tue, 11 Jul 2023 09:04:09 +0000 (05:04 -0400)]
radeonsi/gfx11: fix a regression with PAIRS packets due to shader changes

When the vertex shader switches from hw GS to hw HS and vice versa, we need
to re-emit all draw user SGPRs.

Fixes: 1753b321f876 - radeonsi/gfx11: use SET_SH_REG_PAIRS_PACKED for gfx by buffering reg writes

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24087>

15 months agoamd: Do shader binary alignment for prefetch at memory allocation time.
Daniel Schürmann [Thu, 22 Jun 2023 11:42:37 +0000 (13:42 +0200)]
amd: Do shader binary alignment for prefetch at memory allocation time.

This makes it consistent between drivers and compilers.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23799>

15 months agoamd: move end-of-code marker padding to ACO.
Daniel Schürmann [Thu, 22 Jun 2023 11:24:16 +0000 (13:24 +0200)]
amd: move end-of-code marker padding to ACO.

This makes it consistent between drivers and compilers.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23799>

15 months agoradeonsi: fix gfx9 regression causing GPU hangs
Marek Olšák [Tue, 11 Jul 2023 03:19:39 +0000 (23:19 -0400)]
radeonsi: fix gfx9 regression causing GPU hangs

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Fixes: 283be8ac3b8610a77b2 - radeonsi: handle GE_CNTL and IA_MULTI_VGT_PARAM as a tracked register
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2651
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9249
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24082>

15 months agoetnaviv: linker: clean up etna_link_shader(..)
Christian Gmeiner [Thu, 6 Jul 2023 06:24:03 +0000 (08:24 +0200)]
etnaviv: linker: clean up etna_link_shader(..)

There is no case that etna_link_shader(..) can fail now.

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24030>

15 months agoetnaviv: linker: handle scenario where there are FS inputs without matching VS output
Christian Gmeiner [Thu, 6 Jul 2023 06:08:16 +0000 (08:08 +0200)]
etnaviv: linker: handle scenario where there are FS inputs without matching VS output

If there is a FS input but no VS output the behavior is undefined
but okay. Use a register 0 (position) for such cases.

glsl-routing test triggers it with e.g. the following subtest.

Test: VS(C0 -- T0 -- T2 -- T4 T5)
      FS(C0 C1 T0 T1 T2 T3 T4 T5)

This will now end with following linker debug output:

link result:
  vs  -> fs  comps use     pa_attr
  t1  -> t1  xyzw  0,0,0,0 0x000002f1
  t2  -> t2  xyzw  0,0,0,0 0x000002f1
  t0  -> t3  xyzw  0,0,0,0 0x000002f1
  t3  -> t4  xyzw  0,0,0,0 0x000002f1
  t0  -> t5  xyzw  0,0,0,0 0x000002f1
  t4  -> t6  xyzw  0,0,0,0 0x000002f1
  t5  -> t7  xyzw  0,0,0,0 0x000002f1

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24030>

15 months agoci/freedreno: another batch of a530 flakes
David Heidelberg [Tue, 11 Jul 2023 00:17:01 +0000 (02:17 +0200)]
ci/freedreno: another batch of a530 flakes

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24081>

15 months agodocs: Add inital PowerVR driver documentation
Karmjit Mahil [Fri, 23 Jun 2023 09:38:16 +0000 (10:38 +0100)]
docs: Add inital PowerVR driver documentation

Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8048
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23992>

15 months agoradv: migrate radv_shader hash to BLAKE3
Daniel Schürmann [Wed, 28 Jun 2023 16:35:08 +0000 (18:35 +0200)]
radv: migrate radv_shader hash to BLAKE3

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23974>

15 months agoradv/meta: disable disk cache for meta shaders
Daniel Schürmann [Wed, 28 Jun 2023 10:15:51 +0000 (12:15 +0200)]
radv/meta: disable disk cache for meta shaders

Meta shaders are already stored in a separate cache file,
inserting them into the disk cache is unnecessary.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23909>

15 months agovulkan/pipeline_cache: add 'skip_disk_cache' option
Daniel Schürmann [Tue, 27 Jun 2023 15:47:18 +0000 (17:47 +0200)]
vulkan/pipeline_cache: add 'skip_disk_cache' option

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23909>

15 months agoaco/assembler: change prefetch mode on GFX10.3+ during loops if beneficial
Daniel Schürmann [Wed, 21 Jun 2023 12:08:06 +0000 (14:08 +0200)]
aco/assembler: change prefetch mode on GFX10.3+ during loops if beneficial

Totals from 8864 (6.68% of 132726) affected shaders: GFX11

CodeSize: 90776128 -> 90923760 (+0.16%)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23748>

15 months agoaco/assembler: align loops if it reduces the number of cache lines
Daniel Schürmann [Tue, 20 Jun 2023 17:03:35 +0000 (19:03 +0200)]
aco/assembler: align loops if it reduces the number of cache lines

This is especially beneficial on GFX6-9.

Totals from 11229 (8.46% of 132726) affected shaders: GFX11

CodeSize: 109608640 -> 109840916 (+0.21%)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23748>

15 months agoaco/assembler: align resume shaders with cache lines
Daniel Schürmann [Tue, 20 Jun 2023 13:36:38 +0000 (15:36 +0200)]
aco/assembler: align resume shaders with cache lines

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23748>

15 months agoaux/trace: fix (u)int dump
Julia Tatz [Sat, 8 Jul 2023 19:37:40 +0000 (15:37 -0400)]
aux/trace: fix (u)int dump

The PRI* macros don't include the required introductory % character

Fixes: d29bb6467e2 ("aux/trace: use stdint.h types")
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24057>

15 months agozink: drop linear D32_SFLOAT_S8_UINT requirement
Lionel Landwerlin [Mon, 10 Jul 2023 22:06:04 +0000 (01:06 +0300)]
zink: drop linear D32_SFLOAT_S8_UINT requirement

Very likely a typo. Afaict radv/anv don't support this.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24078>

15 months agovirgl/video: Fix out-of-bounds access in fill_mpeg4_picture_desc()
Feng Jiang [Mon, 22 May 2023 06:27:25 +0000 (14:27 +0800)]
virgl/video: Fix out-of-bounds access in fill_mpeg4_picture_desc()

An out-of-bounds access has occurred to array ref[2] and it needs
to be fixed.

Fixes: 6b5aecb19558 ("virgl: add support for hardware video acceleration")
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23160>

15 months agozink: fix batch disambiguation on first submit
Mike Blumenkrantz [Thu, 6 Jul 2023 12:57:29 +0000 (08:57 -0400)]
zink: fix batch disambiguation on first submit

submit_count is used to disambiguate a batch_id based on the generation
id of a given batch: this value is incremented once on submit and once on
reset such that the diff of the values is > 1 any time the batch does not
represent the fence it was last submitted with

in the case of a batch's first use, however, this value was being incorrectly
incremented such that the first submit would cause disambiguation checks
to erroneously determine that the batch had already completed, breaking synchronization

fixes #9313

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24016>

15 months agozink: update profile vulkan version requirements
Lionel Landwerlin [Mon, 10 Jul 2023 14:00:28 +0000 (17:00 +0300)]
zink: update profile vulkan version requirements

Pretty much all the profiles references Vulkan 1.2 or 1.3 only
structures but only say they need a 1.0.X version.

This fails parsing of the Vulkan Profile scripts for generating
implementation checks against a particular profile.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24072>

15 months agoradeonsi/vcn: Remove unnecessary type conversion
Feng Jiang [Wed, 24 May 2023 07:47:00 +0000 (15:47 +0800)]
radeonsi/vcn: Remove unnecessary type conversion

The types of both 'encrypted' and 'picture->protected_playback'
are bool, so there is no need. I guess this is a typo.

Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23202>

15 months agofrontends/va: Fix memory leak of decrypt_key
Feng Jiang [Wed, 24 May 2023 07:33:07 +0000 (15:33 +0800)]
frontends/va: Fix memory leak of decrypt_key

pipe_picture_desc.decrypt_key was alloced in function
handleVAProtectedSliceDataBufferType(), but nowhere to
free it. Now, it will be freed as the vlVaContext is
destroyed.

Fixes: deb7dc82f62 ("frontends/va: handle protected slice data buffer")
Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23202>

15 months agogallium/va: fix superres av1 decoding.
Dave Airlie [Wed, 14 Jun 2023 20:05:44 +0000 (06:05 +1000)]
gallium/va: fix superres av1 decoding.

On a superres sample, vulkan was decoding fine, but vaapi failed,
fix the micols calculations.

Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23715>

15 months agoci/zink+radv: fix flake definition
Eric Engestrom [Mon, 10 Jul 2023 10:20:16 +0000 (11:20 +0100)]
ci/zink+radv: fix flake definition

Fixes: 741bfb52e674950e7731 ("zink/ci: add more tests to the flake list of vangogh")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24068>

15 months agoci/traces: switch from xvfb to Weston XWayland
David Heidelberg [Sat, 8 Jul 2023 11:14:58 +0000 (13:14 +0200)]
ci/traces: switch from xvfb to Weston XWayland

 - Drop now unused RUN_CMD_WRAPPER.
 - Copy-paste Weston initiation code from init-stage2.sh with slightly adjustments.

Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24056>

15 months agoci/container: we need to keep the wine inside
David Heidelberg [Sat, 8 Jul 2023 16:00:15 +0000 (18:00 +0200)]
ci/container: we need to keep the wine inside

Needed for testing with wine apitrace.

Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24056>

15 months agoci/container: add weston into Vulkan container
David Heidelberg [Sat, 8 Jul 2023 11:34:51 +0000 (13:34 +0200)]
ci/container: add weston into Vulkan container

Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24056>

15 months agonir: Remove nir_builder_init, it's not used anymore
Yonggang Luo [Tue, 4 Jul 2023 09:48:40 +0000 (17:48 +0800)]
nir: Remove nir_builder_init, it's not used anymore

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24038>

15 months agotreewide: remove unused nir_builder
Yonggang Luo [Fri, 7 Jul 2023 12:46:14 +0000 (20:46 +0800)]
treewide: remove unused nir_builder

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24038>

15 months agotreewide: Remove all usage of nir_builder_init with nir_builder_create and nir_builder_at
Yonggang Luo [Tue, 4 Jul 2023 09:26:56 +0000 (17:26 +0800)]
treewide: Remove all usage of nir_builder_init with nir_builder_create and nir_builder_at

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24038>

15 months agodocs: update etnaviv extensions
Christian Gmeiner [Tue, 4 Jul 2023 07:19:05 +0000 (09:19 +0200)]
docs: update etnaviv extensions

I went through the list and updated the extensions that are supported
and passing (most) of the piglit's and deqp's.

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24032>

15 months agoradv/rt: Miss rays that hit the triangle's v edge
Friedrich Vock [Sun, 9 Jul 2023 19:12:00 +0000 (21:12 +0200)]
radv/rt: Miss rays that hit the triangle's v edge

The hardware seems to do this as well. Avoids invoking hit shaders twice
at shared edges.
Fixes the fails in watertightness tests on emulated RT.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24063>

15 months agoradv/rt: Enable exact on software intersection functions
Friedrich Vock [Sun, 9 Jul 2023 19:09:11 +0000 (21:09 +0200)]
radv/rt: Enable exact on software intersection functions

These functions need exact output, otherwise watertightness can't be
guaranteed in some cases.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24063>

15 months agoiris: Drop depth cache flush requirement after depth clear/resolve
Sagar Ghuge [Thu, 6 Jul 2023 16:34:44 +0000 (09:34 -0700)]
iris: Drop depth cache flush requirement after depth clear/resolve

From Bspec 46959, a programming note applicable to Gfx12+:

   "Since HZ_OP has to be sent twice (first time set the clear/resolve
   state and 2nd time to clear the state), and HW internally flushes the
   depth cache on HZ_OP, there is no need to explicitly send a Depth
   Cache flush after Clear or Resolve."

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24027>

15 months agoanv: Drop depth cache flush requirement after depth clear/resolve
Sagar Ghuge [Thu, 6 Jul 2023 16:29:31 +0000 (09:29 -0700)]
anv: Drop depth cache flush requirement after depth clear/resolve

From Bspec 46959, a programming note applicable to Gfx12+:

   "Since HZ_OP has to be sent twice (first time set the clear/resolve
   state and 2nd time to clear the state), and HW internally flushes the
   depth cache on HZ_OP, there is no need to explicitly send a Depth
   Cache flush after Clear or Resolve."

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24027>

15 months agofreedreno/ci: add KHR-GL46.buffer_storage.map_persistent_flush to flakes
Italo Nicola [Mon, 10 Jul 2023 15:00:56 +0000 (15:00 +0000)]
freedreno/ci: add KHR-GL46.buffer_storage.map_persistent_flush to flakes

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Suggested-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21219>

15 months agomesa/main: add PIPE_FORMAT_VYUY and PIPE_FORMAT_B8R8_G8R8
Italo Nicola [Thu, 9 Feb 2023 13:14:29 +0000 (13:14 +0000)]
mesa/main: add PIPE_FORMAT_VYUY and PIPE_FORMAT_B8R8_G8R8

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21219>

15 months agomesa/main: add PIPE_FORMAT_YVYU and PIPE_FORMAT_R8B8_R8G8
Italo Nicola [Thu, 9 Feb 2023 11:32:12 +0000 (11:32 +0000)]
mesa/main: add PIPE_FORMAT_YVYU and PIPE_FORMAT_R8B8_R8G8

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21219>

15 months agogallium/st: add support for PIPE_FORMAT_NV21 and PIPE_FORMAT_G8_B8R8_420
Italo Nicola [Wed, 1 Feb 2023 21:59:38 +0000 (21:59 +0000)]
gallium/st: add support for PIPE_FORMAT_NV21 and PIPE_FORMAT_G8_B8R8_420

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21219>

15 months agonir: add options to lower y_vu, yv_yu, yx_xvxu and xy_vxux
Italo Nicola [Thu, 9 Feb 2023 12:39:33 +0000 (12:39 +0000)]
nir: add options to lower y_vu, yv_yu, yx_xvxu and xy_vxux

`y_vu` will be used to convert NV21 to RGB.
`yv_yu` will be used to convert YVYU and VYUY to RGB when the
subsampling formats PIPE_FORMAT_R8B8_R8G8 and PIPE_FORMAT_B8R8_G8R8
are supported.
`yx_xvxu` and `xy_vxux` will be used to convert YVYU and VYUY to RGB
when those subsampling formats are not supported.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21219>

15 months agoci/freedreno: add execution@varying-struct-copy-return-vs flake
David Heidelberg [Mon, 10 Jul 2023 11:28:48 +0000 (13:28 +0200)]
ci/freedreno: add execution@varying-struct-copy-return-vs flake

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24069>

15 months agoci/freedreno: add KHR-GL46.buffer_storage flakes
David Heidelberg [Mon, 10 Jul 2023 11:27:27 +0000 (13:27 +0200)]
ci/freedreno: add KHR-GL46.buffer_storage flakes

Both flakes occuring time to time on Adreno 6xx series.

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24069>

15 months agod3d12/ci: add piglit arb_clear_texture-integer fail to CI expectations
Italo Nicola [Mon, 10 Jul 2023 12:56:37 +0000 (12:56 +0000)]
d3d12/ci: add piglit arb_clear_texture-integer fail to CI expectations

Likely related to other ARB_texture_integer fails, instead of something
specific to ARB_clear_texture.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agolima/ci: add some ARB_clear_texture piglit tests to lima-fails.txt
Italo Nicola [Fri, 7 Jul 2023 15:44:28 +0000 (15:44 +0000)]
lima/ci: add some ARB_clear_texture piglit tests to lima-fails.txt

Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agogallium: remove PIPE_CAP_CLEAR_TEXTURE
Italo Nicola [Tue, 20 Jun 2023 20:24:01 +0000 (20:24 +0000)]
gallium: remove PIPE_CAP_CLEAR_TEXTURE

ARB_clear_texture is now implemented in common code.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agogallium: cleanup util_blitter_clear_render_target
Italo Nicola [Thu, 22 Jun 2023 17:41:16 +0000 (17:41 +0000)]
gallium: cleanup util_blitter_clear_render_target

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agoclover: use fallback path when pipe->clear_texture is not available
Italo Nicola [Sun, 9 Jul 2023 22:45:47 +0000 (19:45 -0300)]
clover: use fallback path when pipe->clear_texture is not available

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agorusticl: use fallback path when pipe->clear_texture is not available
Italo Nicola [Wed, 21 Jun 2023 14:46:02 +0000 (14:46 +0000)]
rusticl: use fallback path when pipe->clear_texture is not available

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agomesa/st: use fallback path when pipe->clear_texture is not available
Italo Nicola [Thu, 22 Jun 2023 18:45:18 +0000 (18:45 +0000)]
mesa/st: use fallback path when pipe->clear_texture is not available

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agogallium: rename util_clear_texture to util_clear_texture_sw
Italo Nicola [Thu, 22 Jun 2023 18:32:45 +0000 (18:32 +0000)]
gallium: rename util_clear_texture to util_clear_texture_sw

This better explain what this function does, making it less likely that
people mistakenly use it instead of util_default_clear_texture.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agogallium: use u_default_clear_texture where applicable
Italo Nicola [Thu, 22 Jun 2023 18:35:06 +0000 (18:35 +0000)]
gallium: use u_default_clear_texture where applicable

This removes some shared code between backends that implemented their
version of pipe->clear_texture without anything driver-specific code.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agogallium: implement u_default_clear_texture
Italo Nicola [Mon, 19 Jun 2023 22:04:15 +0000 (22:04 +0000)]
gallium: implement u_default_clear_texture

util_clear_texture implements clear_texture through a memset.
This patch implements u_default_clear_texture, which tries to clear the
given texture using a surface plus clear_render_target or
clear_depth_stencil.

In case this path fails, either because the formats are non-renderable
or for some other reason, we fallback to `util_clear_texture`, which is
guaranteed to work.

This will allow us to make ARB_clear_texture available to every driver,
as well as provide HW acceleration for the clear_texture operation.

If some hardware doesn't want to use it, such as llvmpipe, it can always
just directly point to the software version using pipe->clear_texture.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agod3d12: fix clear_depth_stencil texture deref
Italo Nicola [Sun, 9 Jul 2023 22:47:43 +0000 (19:47 -0300)]
d3d12: fix clear_depth_stencil texture deref

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agovc4: implement clear_render_target and clear_depth_stencil
Italo Nicola [Wed, 28 Jun 2023 14:23:39 +0000 (14:23 +0000)]
vc4: implement clear_render_target and clear_depth_stencil

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agov3d: implement clear_render_target and clear_depth_stencil
Italo Nicola [Wed, 28 Jun 2023 14:23:27 +0000 (14:23 +0000)]
v3d: implement clear_render_target and clear_depth_stencil

Also added some related piglit failures to broadcom-rpi4-fails.txt.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agofreedreno: implement clear_render_target and clear_depth_stencil
Italo Nicola [Wed, 28 Jun 2023 14:23:02 +0000 (14:23 +0000)]
freedreno: implement clear_render_target and clear_depth_stencil

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23735>

15 months agonir: do not needlessly rely on optimizations
Erik Faye-Lund [Mon, 5 Jun 2023 13:11:32 +0000 (15:11 +0200)]
nir: do not needlessly rely on optimizations

We're going to do this rewrite once we get to nir_opt_algebraic anyway,
so let's save a little bit of needless work here.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24004>

15 months agoradv: do not rely on constant-folding
Erik Faye-Lund [Mon, 5 Jun 2023 11:32:07 +0000 (13:32 +0200)]
radv: do not rely on constant-folding

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24004>

15 months agonir: use nir_intrinsic_get_var
Erik Faye-Lund [Mon, 5 Jun 2023 10:06:01 +0000 (12:06 +0200)]
nir: use nir_intrinsic_get_var

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24004>

15 months agonir: constify intrin
Erik Faye-Lund [Thu, 6 Jul 2023 12:07:31 +0000 (14:07 +0200)]
nir: constify intrin

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24004>

15 months agoci: Uprev virglrenderer
Corentin Noël [Mon, 10 Jul 2023 08:41:31 +0000 (10:41 +0200)]
ci: Uprev virglrenderer

Enable the latest changes with vrend-video

Change the default branch of virglrenderer to main as upstream did

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24067>

15 months agorogue: Remove commented convert_from_ssa call
Alyssa Rosenzweig [Thu, 6 Jul 2023 11:21:58 +0000 (07:21 -0400)]
rogue: Remove commented convert_from_ssa call

Currently, the rogue compiler does not support control flow upstream.
Imagination's plan is to implement an SSA-based register allocation (I wish them
well in this endeavour). As such they won't be needing convert_from_ssa. remove
the commented call so nobody is tempted to put it back in. This takes care of
the rogue portion of #9051.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Simon Perretta <simon.perretta@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24015>

15 months agovirgl: remove check of VIRGL_CAP_V2_UNTYPED_RESOURCE
Julia Zhang [Thu, 15 Jun 2023 12:04:12 +0000 (20:04 +0800)]
virgl: remove check of VIRGL_CAP_V2_UNTYPED_RESOURCE

Remove check of VIRGL_CAP_V2_UNTYPED_RESOURCE flag in
virgl_resource_from_handle() so that guest can still call
into virglrenderer to import external vulkan resource via
OpenGL APIs even if egl is not initialized.

Signed-off-by: Julia Zhang <julia.zhang@amd.com>
Signed-off-by: Huang Rui <ray.huang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23680>

15 months agoglsl: do vs attribute validation in NIR linker
Timothy Arceri [Fri, 7 Jul 2023 05:45:04 +0000 (15:45 +1000)]
glsl: do vs attribute validation in NIR linker

This allows us to tidy up the code and call the attribute location
code a single time rather than doing a "dry run".

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24035>

15 months agoglsl: remove dead varyings before assigning attr locations
Timothy Arceri [Fri, 7 Jul 2023 05:20:42 +0000 (15:20 +1000)]
glsl: remove dead varyings before assigning attr locations

The GLSL IR code used to clean these up. Some apps such as the Heaven
benchmark fail linking if we don't eliminate them before the linker
validation.

Fixes: a8534c7b4cfc ("glsl: drop the dce of global vars from GLSL IR linker")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9319

Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24035>

15 months agopanfrost: fix refcnt imbalance related to blitter
Patrick Lerda [Thu, 6 Jul 2023 11:43:27 +0000 (13:43 +0200)]
panfrost: fix refcnt imbalance related to blitter

This issue is mainly a consequence of a call to util_blitter_clear()
with unnecessary blitter states, these states are never freed.

This change is inspired from radeonsi and r600.

Note: PAN_SAVE_FRAGMENT_STATE is added and always enabled
at this stage.

For instance, this issue is triggered on Mali-T720 with
"piglit/bin/fcc-read-after-clear sample tex -auto -fbo", "piglit/bin/cubemap -auto"
and "piglit/bin/fbo-srgb -auto" or on Mali-T820 with "piglit/bin/longprim -auto -fbo"
and "piglit/bin/ext_render_snorm-render -auto -fbo"
while setting GALLIUM_REFCNT_LOG=refcnt.log.

cc: mesa-stable

Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22522>

15 months agoradeonsi/gfx11: only use SET_*_PAIRS* packets on dGPUs
Marek Olšák [Wed, 5 Jul 2023 14:57:51 +0000 (10:57 -0400)]
radeonsi/gfx11: only use SET_*_PAIRS* packets on dGPUs

They are not available on APUs.

This adds a new template parameter HAS_PAIRS. into draw functions.
Other places add back the non-pairs code for gfx11.

Fixes: 22f3bcfb - radeonsi/gfx11: use SET_*_REG_PAIRS_PACKED packets for pm4 states
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9259

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24010>

15 months agowgl: Fix depth/stencil image support when using zink kopper
Billy Laws [Thu, 29 Jun 2023 21:59:29 +0000 (22:59 +0100)]
wgl: Fix depth/stencil image support when using zink kopper

Kopper requires that any depth/stencil images are created through winsys which
was not taken into account by the WGL frontend causing it to hit an assert:
'Assertion failed: ctx->fb_state.zsbuf->texture->bind & PIPE_BIND_DISPLAY_TARGET'

fixes #9256
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24055>

15 months agoci/zink+radv: document another flake
Eric Engestrom [Sat, 8 Jul 2023 14:22:40 +0000 (15:22 +0100)]
ci/zink+radv: document another flake

https://gitlab.freedesktop.org/mesa/mesa/-/jobs/45129393

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24053>

15 months agoRevert "Revert "radv: Enable ray tracing pipelines by default""
Friedrich Vock [Mon, 3 Jul 2023 17:54:38 +0000 (19:54 +0200)]
Revert "Revert "radv: Enable ray tracing pipelines by default""

This reverts commit 49b400423ce2ac3f0d868a38a51bcd9d02cccd1b.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23978>

15 months agoRevert "radv/rt: Enable RT pipelines on GFX10_3+ excluding vangogh"
Friedrich Vock [Mon, 3 Jul 2023 17:53:45 +0000 (19:53 +0200)]
Revert "radv/rt: Enable RT pipelines on GFX10_3+ excluding vangogh"

This reverts commit 7f3874981dd11821a4001671b5ee505868f9aa7d.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23978>

15 months agoradv/ci: Skip ray tracing tests on vangogh
Friedrich Vock [Wed, 5 Jul 2023 16:37:42 +0000 (18:37 +0200)]
radv/ci: Skip ray tracing tests on vangogh

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23978>

15 months agoci/freedreno: document number of a630 devices available
David Heidelberg [Sat, 8 Jul 2023 01:18:41 +0000 (03:18 +0200)]
ci/freedreno: document number of a630 devices available

Acked-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24050>

15 months agoci/freedreno: re-enable a530 as it's now stable with multiple skips
David Heidelberg [Tue, 18 Apr 2023 08:24:06 +0000 (10:24 +0200)]
ci/freedreno: re-enable a530 as it's now stable with multiple skips

Extend a530 skips and flakes to make possible test again.

Acked-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24050>

15 months agoci/freedreno: switch a630_{piglit,skqp} and a618_gl to Weston
David Heidelberg [Fri, 7 Jul 2023 14:37:45 +0000 (16:37 +0200)]
ci/freedreno: switch a630_{piglit,skqp} and a618_gl to Weston

Slightly faster runtime.

Acked-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24050>

15 months agoadd initial .git-blame-ignore-revs
Eric Engestrom [Mon, 26 Jun 2023 16:49:38 +0000 (17:49 +0100)]
add initial .git-blame-ignore-revs

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24049>

15 months agoclang-format: enforce formatting of egl
Eric Engestrom [Thu, 1 Jun 2023 12:51:41 +0000 (13:51 +0100)]
clang-format: enforce formatting of egl

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoegl: re-format using clang-format
Eric Engestrom [Thu, 1 Jun 2023 13:54:56 +0000 (14:54 +0100)]
egl: re-format using clang-format

No manual changes here, this is simply running
$ ninja -C build/ clang-format

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoegl: prevent clang-format from reordering some headers
Eric Engestrom [Sun, 4 Jun 2023 09:48:23 +0000 (10:48 +0100)]
egl: prevent clang-format from reordering some headers

vulkan_xcb.h is missing an include of xcb.h, breaking the build if the headers are ordered alphabetically.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoegl: protect the formatting in a couple of places
Eric Engestrom [Thu, 1 Jun 2023 13:48:50 +0000 (14:48 +0100)]
egl: protect the formatting in a couple of places

These do no follow the normal rules, but it's done on purpose because
it's easier to read like this.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoegl: add a few trailing commas
Eric Engestrom [Thu, 1 Jun 2023 13:48:50 +0000 (14:48 +0100)]
egl: add a few trailing commas

This prevents clang-format from collapsing the closing brace into the
previous line.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoegl: change a couple of clang-format settings
Eric Engestrom [Thu, 1 Jun 2023 13:54:56 +0000 (14:54 +0100)]
egl: change a couple of clang-format settings

This code was written with 80-char lines in mind; changing that to 100
with the common .clang-format unnecessarily reflows a lot of code that
looks fine like this.

`AlwaysBreakAfterReturnType: All` might be something that we want
everywhere, but for now only set it here, to match existing code.

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoclang-format: add wayland foreach macros
Eric Engestrom [Thu, 1 Jun 2023 21:50:11 +0000 (22:50 +0100)]
clang-format: add wayland foreach macros

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoclang-format: add egl foreach macro
Eric Engestrom [Thu, 1 Jun 2023 12:48:43 +0000 (13:48 +0100)]
clang-format: add egl foreach macro

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23398>

15 months agoci/amd: switch all possible jobs from X11 to Wayland
David Heidelberg [Sun, 2 Jul 2023 21:10:53 +0000 (23:10 +0200)]
ci/amd: switch all possible jobs from X11 to Wayland

Saved time is around 3 - 4 minutes per job,
decreasing runtime from ~ 19 minutes to ~ 15 minutes.

Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23964>

15 months agod3d12: Fix indexing of local_reference_state
Jesse Natalie [Fri, 7 Jul 2023 16:00:19 +0000 (09:00 -0700)]
d3d12: Fix indexing of local_reference_state

Instead of manually indexing a single-dimensional array as 2-dimensional
(and using the wrong stride for the outer array) just actually make it
a 2-dimensional array.

Fixes: 7edae456 ("d3d12: Track up to 16 contexts worth of batch references locally in bos")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24041>

15 months agointel/genxml: Drop incorrect compute aux-inv register entry
Sagar Ghuge [Fri, 30 Jun 2023 22:31:32 +0000 (15:31 -0700)]
intel/genxml: Drop incorrect compute aux-inv register entry

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agointel/genxml: Fix typo in CCS cache flush enable
Sagar Ghuge [Sat, 1 Jul 2023 18:37:15 +0000 (11:37 -0700)]
intel/genxml: Fix typo in CCS cache flush enable

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agoiris: Use correct CCS0 aux-map register offset
Sagar Ghuge [Fri, 30 Jun 2023 21:46:20 +0000 (14:46 -0700)]
iris: Use correct CCS0 aux-map register offset

According to Bspec, COMPCS0_CCS_AUX_INV register offset
is 042C8h and COMPCS0_AUX_TABLE_BASE_ADDR is defined to 042C0h.

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agoanv: Use correct CCS0 aux-map register offset in pipe flush
Jordan Justen [Mon, 25 May 2020 09:51:36 +0000 (02:51 -0700)]
anv: Use correct CCS0 aux-map register offset in pipe flush

According to Bspec, COMPCS0_CCS_AUX_INV register offset
is 042C8h and COMPCS0_AUX_TABLE_BASE_ADDR is defined to 042C0h.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agoanv: Program compute aux-map base address during queue init
Jordan Justen [Tue, 14 Aug 2018 09:34:16 +0000 (02:34 -0700)]
anv: Program compute aux-map base address during queue init

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agointel/genxml: Add COMPCS0 aux-table registers
Jordan Justen [Fri, 20 Mar 2020 20:29:55 +0000 (13:29 -0700)]
intel/genxml: Add COMPCS0 aux-table registers

Bspec 43904 defines COMPCS0_CCS_AUX_INV to 042C8h and Bspec 43882
defines COMPCS0_AUX_TABLE_BASE_ADDR to 042C4h.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23958>

15 months agoci/windows: Re-enable Windows builds
Jesse Natalie [Fri, 7 Jul 2023 16:05:43 +0000 (09:05 -0700)]
ci/windows: Re-enable Windows builds

Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24042>

15 months agomicrosoft/clc: Fix usage of nir_builder_at
Jesse Natalie [Fri, 7 Jul 2023 16:39:11 +0000 (09:39 -0700)]
microsoft/clc: Fix usage of nir_builder_at

nir_builder_at requires a block to chase back to the function impl,
but for an empty function impl, the previous code produced a cursor
with a null pointer. It was also just extra complicated.

While I'm here, use the new foreach helper since this code needs an impl.

Fixes: 12a268ea ("microsoft: Use nir_builder_at")
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24042>

15 months agoradv: Fix label name
Jesse Natalie [Fri, 7 Jul 2023 16:18:21 +0000 (09:18 -0700)]
radv: Fix label name

Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24042>

15 months agovirgl/ci: fix skips definition
Eric Engestrom [Thu, 6 Jul 2023 16:56:46 +0000 (17:56 +0100)]
virgl/ci: fix skips definition

Skips are regexes, not globs :)

Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24026>

15 months agov3dv/ci: skip more tests that are timing out
Eric Engestrom [Fri, 7 Jul 2023 15:12:42 +0000 (16:12 +0100)]
v3dv/ci: skip more tests that are timing out

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24018>