YeongJong Lee [Tue, 5 Jan 2021 07:09:17 +0000 (16:09 +0900)]
[NUI] remove unnecessary using in Size2D.cs (#2487)
Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
Jiyun Yang [Mon, 4 Jan 2021 07:15:09 +0000 (16:15 +0900)]
[NUI] Fix null exception in Loading and improve code (#2478)
This fixes null pointer exception in Loading when running following sample,
```C#
var loading1 = new Loading(new LoadingStyle
{
Size = new Size(100, 100),
Position = new Position(0, 100),
Images = imageArray
});
```
Plus, this patch removes redundant behaviors when applying a style to a Loading component.
All components copies a default style to the component properties when it is created.
When copying a style, all bindable properties defined in the style class that is not null value are copied to the component properties,
so it is important to keep null value for the property that is not set by user.
Hence this patch removes code that allocates empty list object in the getter of ImageList bindable property.
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
[NUI] Fix build error and large text size issue
zhouleonlei [Tue, 29 Dec 2020 09:45:56 +0000 (17:45 +0800)]
[NUI] Fix CA2000 issues for Visuals (#2473)
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
Moonhee, Choi [Tue, 29 Dec 2020 06:51:55 +0000 (15:51 +0900)]
[NUI] Fix CA1716 build warning
YeongJong Lee [Tue, 29 Dec 2020 02:54:02 +0000 (11:54 +0900)]
[NUI] remove needless null validation in LayoutItem.SetFrame (#2469)
guowei.wang [Fri, 25 Dec 2020 06:03:03 +0000 (14:03 +0800)]
[NUI] Fix CA2000 issues in Model3dView and RenderTask.
Wander Lairson Costa [Tue, 1 Dec 2020 18:05:25 +0000 (15:05 -0300)]
Use correct calling convention
Some callback and functions from DALi expected the calling convention to
be cdecl, this commit makes it right. The amd64 platforms this is rarely
a problem since arguments are passed through CPU registers, but in x86
this leads to stack corruption.
zhouleonlei [Thu, 24 Dec 2020 09:23:44 +0000 (17:23 +0800)]
[NUI] Modify CA2000 Warnings for TextVisual and VisualAnimator
huiyueun [Fri, 25 Dec 2020 03:03:34 +0000 (12:03 +0900)]
[NUI] Add ImageList property (#2449)
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
guowei.wang [Thu, 24 Dec 2020 09:26:08 +0000 (17:26 +0800)]
[NUI] Fix crash issue in PaginationStyle. (#2448)
Jiyun Yang [Thu, 24 Dec 2020 08:47:35 +0000 (17:47 +0900)]
Revert "[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)" (#2463)
This reverts commit
cff3fd4d9fd6fd461263e742e296a5397e9563a0.
This causes segfault to dispose styles after passing them through `AddStyleWithoutClone` method.
Because the theme object holds the passed style objects.
Which means the responsibility to dispose the object is transferred to the theme object.
In this case, we can suppress this warning.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000
Instead revert the patch, it suppressed CA2000 warning.
zhouleonlei [Thu, 24 Dec 2020 06:25:15 +0000 (14:25 +0800)]
[NUI] Modify CA2000 Warnings for VisualMap (#2460)
Jaehyun Cho [Tue, 22 Dec 2020 12:31:09 +0000 (21:31 +0900)]
[NUI] Override Dispose() in Navigator
Pages pushed into Navigator are disposed if Navigator is disposed.
To override Dispose() in Navigator, two dictionaries are required to
remove disposed navigator from dictionary.
TODO: Needs to consider how to remove disposed window from dictionary.
Jiyun Yang [Thu, 24 Dec 2020 03:02:53 +0000 (12:02 +0900)]
Revert "[NUI] Modify CA2000 warnings for Visual"
This reverts commit
afa5fef90e7c8b370fc0e505d2420a7a87083344.
Yeongjong Lee [Wed, 23 Dec 2020 02:25:58 +0000 (11:25 +0900)]
[NUI] Add Obsolete Attribute for ControlStates enum
`ControlStates` enum will be removed in API10.
We can use `ControlState` class instead.
zhouleonlei [Wed, 23 Dec 2020 07:55:21 +0000 (15:55 +0800)]
[NUI] Modify CA2000 warnings for Visual
Seungho Baek [Wed, 23 Dec 2020 14:57:17 +0000 (23:57 +0900)]
[NUI] Adds StopBehavior and CurrentFrame properties to the AnimatedImageView
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Dongsug Song [Thu, 24 Dec 2020 01:35:19 +0000 (10:35 +0900)]
[NUI] Fix the behavior as for View.BackgroundImage to be cleared when null set
- Change the behavior of View.BackgroundImage property from API9
- https://code.sec.samsung.net/jira/browse/GRE-2078
Dongsug Song [Tue, 22 Dec 2020 11:18:22 +0000 (20:18 +0900)]
[NUI] Add internal and hidden APIs which are currently used
- Add internal and hidden APIs which are currently used. otherwise removing them causes build errors.
- Let users to use proper APIs by deleting these deprecated APIs
- User can be informed that these are deprecated and should not be used by warning messeges during build time.
guowei.wang [Tue, 22 Dec 2020 10:33:09 +0000 (18:33 +0800)]
[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)
Daekwang Ryu [Thu, 17 Dec 2020 06:52:14 +0000 (15:52 +0900)]
[NUI] Fix CA2002
Do not lock on objects with weak identity
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2002
zhouleonlei [Tue, 22 Dec 2020 10:13:21 +0000 (18:13 +0800)]
Modify dispose issue for window
zhouleonlei [Tue, 22 Dec 2020 06:24:01 +0000 (14:24 +0800)]
[NUI] Fix CA2000 warning for Window
Seoyeon2Kim [Wed, 23 Dec 2020 01:55:05 +0000 (10:55 +0900)]
[NUI] Fix a build warning CA1717 (#2422)
- Only FlagsAttribute enums should have plural names
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1717
- Some enums cannot be fixed because they're already public APIs,
so added suppress messages for CA1717 build warning.
- Some enums are already used as hidden APIs,
so added Obsolete tags and made a fixed version as singular name.
- Tizen.NUI.Components.ControlStates enum should be marked with the FlagsAttribute.
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
huiyueun [Mon, 11 Jan 2021 05:37:18 +0000 (14:37 +0900)]
Revert "[NUI] Rebase DevelNUI (#2507)" (#2508)
This reverts commit
48aea0ba4111a0f164f0b0eb2f686ce4f53f6401.
huiyueun [Mon, 11 Jan 2021 05:29:41 +0000 (14:29 +0900)]
[NUI] Rebase DevelNUI (#2507)
* [NUI] Fix a build warning CA1717 (#2422)
- Only FlagsAttribute enums should have plural names
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1717
- Some enums cannot be fixed because they're already public APIs,
so added suppress messages for CA1717 build warning.
- Some enums are already used as hidden APIs,
so added Obsolete tags and made a fixed version as singular name.
- Tizen.NUI.Components.ControlStates enum should be marked with the FlagsAttribute.
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix CA2000 warning for Window
* Modify dispose issue for window
* [NUI] Fix CA2002
Do not lock on objects with weak identity
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2002
* [NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)
* [NUI] Add internal and hidden APIs which are currently used
- Add internal and hidden APIs which are currently used. otherwise removing them causes build errors.
- Let users to use proper APIs by deleting these deprecated APIs
- User can be informed that these are deprecated and should not be used by warning messeges during build time.
* [NUI] Fix the behavior as for View.BackgroundImage to be cleared when null set
- Change the behavior of View.BackgroundImage property from API9
- https://code.sec.samsung.net/jira/browse/GRE-2078
* [NUI] Adds StopBehavior and CurrentFrame properties to the AnimatedImageView
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
* [NUI] Modify CA2000 warnings for Visual
* [NUI] Add Obsolete Attribute for ControlStates enum
`ControlStates` enum will be removed in API10.
We can use `ControlState` class instead.
* Revert "[NUI] Modify CA2000 warnings for Visual"
This reverts commit
afa5fef90e7c8b370fc0e505d2420a7a87083344.
* [NUI] Override Dispose() in Navigator
Pages pushed into Navigator are disposed if Navigator is disposed.
To override Dispose() in Navigator, two dictionaries are required to
remove disposed navigator from dictionary.
TODO: Needs to consider how to remove disposed window from dictionary.
* [NUI] Modify CA2000 Warnings for VisualMap (#2460)
* Revert "[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)" (#2463)
This reverts commit
cff3fd4d9fd6fd461263e742e296a5397e9563a0.
This causes segfault to dispose styles after passing them through `AddStyleWithoutClone` method.
Because the theme object holds the passed style objects.
Which means the responsibility to dispose the object is transferred to the theme object.
In this case, we can suppress this warning.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000
Instead revert the patch, it suppressed CA2000 warning.
* [NUI] Fix crash issue in PaginationStyle. (#2448)
* [NUI] Add ImageList property (#2449)
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
* [NUI] Modify CA2000 Warnings for TextVisual and VisualAnimator
* Use correct calling convention
Some callback and functions from DALi expected the calling convention to
be cdecl, this commit makes it right. The amd64 platforms this is rarely
a problem since arguments are passed through CPU registers, but in x86
this leads to stack corruption.
* [NUI] Fix CA2000 issues in Model3dView and RenderTask.
* [NUI] remove needless null validation in LayoutItem.SetFrame (#2469)
* [NUI] Fix CA1716 build warning
* [NUI] Fix CA2000 issues for Visuals (#2473)
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix build error and large text size issue
* [NUI] Fix null exception in Loading and improve code (#2478)
This fixes null pointer exception in Loading when running following sample,
```C#
var loading1 = new Loading(new LoadingStyle
{
Size = new Size(100, 100),
Position = new Position(0, 100),
Images = imageArray
});
```
Plus, this patch removes redundant behaviors when applying a style to a Loading component.
All components copies a default style to the component properties when it is created.
When copying a style, all bindable properties defined in the style class that is not null value are copied to the component properties,
so it is important to keep null value for the property that is not set by user.
Hence this patch removes code that allocates empty list object in the getter of ImageList bindable property.
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
* [NUI] remove unnecessary using in Size2D.cs (#2487)
Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Add AppBar class (#2435)
AppBar shows title text and provides navigation and action functions on
Page.
Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
* [NUI] Fix CA2000 issues for Visual (#2491)
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] fixed memory leak
* [NUI] Update AccessibilitySample for readability (#2500)
- Updated the sample to fit the size and make it easier to read.
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
* [NUI] Fix CA2000 warning issues of View and ViewImpl.
* [NUI] Fix the incorrect parameter for XamlBinding
- Change to `SizeTypeConverter` for the correct compiledVersion
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
* [NUI] Fix CA2000 issues for Render Shadow (#2493)
* [NUI] Fix CA2000 issues for Render Shadow
* [NUI] Fix CA2000 for Render
* [NUI] Fix CA2000 Warnings
* [NUI] Update description of Transition classes
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Remove since_tizen tag for internal APIs
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix build warning CA1712
CA1712: Do not prefix enum values with type name
The name can not be changed becuase this enum is publicly open.
Suppress warning messages.
* Revert "[NUI] Fix CA2000 Warnings"
This reverts commit
92f2d926ec881a0ccacd447401526dcd19cf01b0.
* Revert "[NUI] Fix CA2000 warning issues of View and ViewImpl."
This reverts commit
424bdae58a6f7d71ad3e531fd157a92d513255c4.
Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: zhouleonlei <zhouleon.lei@samsung.com>
Co-authored-by: Daekwang Ryu <dkdk.ryu@samsung.com>
Co-authored-by: guowei.wang <guowei.wang@samsung.com>
Co-authored-by: Dongsug Song <dongsug.song@samsung.com>
Co-authored-by: Seungho Baek <sbsh.baek@samsung.com>
Co-authored-by: Yeongjong Lee <cleanlyj@naver.com>
Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: zhouleonlei <56956725+zhouleonlei@users.noreply.github.com>
Co-authored-by: Wander Lairson Costa <wander.lairson@gmail.com>
Co-authored-by: Moonhee, Choi <mh0310.choi@samsung.com>
Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jaehyun Cho <29364140+jaehyun0cho@users.noreply.github.com>
Co-authored-by: Joogab Yun <joogab.yun@samsung.com>
Co-authored-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Bowon Ryu <bowon.ryu@samsung.com>
Wootak Jung [Fri, 8 Jan 2021 00:47:07 +0000 (09:47 +0900)]
[Bluetooth][Non-ACR] Fix BluetoothDevice.Name converting issue (#2498)
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
jeremy-jang [Tue, 5 Jan 2021 06:20:03 +0000 (15:20 +0900)]
[Packagemanager] Fix registering internal event callback (#2481)
Do not invoke Interop.PackageManager.PackageManagerSetEvent().
This will unset all internal callback information and this may make user cannot
listen the package event completely.
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Co-authored-by: pjh9216 <jh9216.park@samsung.com>
dh79pyun [Mon, 4 Jan 2021 23:05:56 +0000 (08:05 +0900)]
[Bluetooth][Non-ACR] Fix unhandled exception in GetBondedDevices() (#2485)
I/DOTNET_LAUNCHER (P 2613, T 2617): Unhandled exception.
I/DOTNET_LAUNCHER (P 2613, T 2617): System.Runtime.InteropServices.COMException (0x8007007A):
The data area passed to a system call is too small.
I/DOTNET_LAUNCHER (P 2613, T 2617): (0x8007007A)
I/DOTNET_LAUNCHER (P 2613, T 2617): at System.StubHelpers.ValueClassMarshaler.ConvertToNative(IntPtr dst, IntPtr src,
IntPtr pMT, CleanupWorkListElement& pCleanupWorkList)
I/DOTNET_LAUNCHER (P 2613, T 2617): at Tizen.Network.Bluetooth.BluetoothAdapterImpl.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617): at Tizen.Network.Bluetooth.BluetoothAdapter.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617): at Tizen.Network.Bluetooth.Tests.BluetoothAdapterTests.GetBondedDevices_RETURN_LIST_OF_DEVICES()
in /var/lib/jenkins/jobs/CsharpTCT/TCT_6.0/api/tct-suite-vs/Tizen.Bluetooth.Manual.Tests/testcase/TSBluetoothAdapter.cs:line 435
I/DOTNET_LAUNCHER (P 2613, T 2617): Fatal error.
I/DOTNET_LAUNCHER (P 2613, T 2617): Internal CLR error. (0x80131506)
I/DOTNET_LAUNCHER (P 2613, T 2617): DLOG_ERROR_NOMSG
I/DOTNET_LAUNCHER (P 2613, T 2617): at Interop+Bluetooth.GetBondedDevices(BondedDeviceCallback, IntPtr)
I/DOTNET_LAUNCHER (P 2613, T 2617): at Tizen.Network.Bluetooth.BluetoothAdapterImpl.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617): at Tizen.Network.Bluetooth.BluetoothAdapter.GetBondedDevices()
Change-Id: I04a0a89d75dc973a752950c9274b80d9988a11ed
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Co-authored-by: Anupam Roy <anupam.r@samsung.com>
jeremy-jang [Wed, 30 Dec 2020 07:37:12 +0000 (16:37 +0900)]
Revert "[Packagemanager] Fix registering internal event callback (#2477)" (#2479)
This reverts commit
32bcccffca94e9f7a55d316a78b6273730e56371.
jeremy-jang [Wed, 30 Dec 2020 06:48:30 +0000 (15:48 +0900)]
[Packagemanager] Fix registering internal event callback (#2477)
Do not reset internal event callback. This can cause unexpected result
when user add event handler during package installation.
(user may not be able to listen the package event completely.)
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Lee Chang Joo [Tue, 29 Dec 2020 07:42:25 +0000 (16:42 +0900)]
[System] Add internal APIs for power off and reboot (#2472)
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Yeongjong Lee [Tue, 15 Dec 2020 08:25:44 +0000 (17:25 +0900)]
[NUI] make RelativeLayout public
- ACR: https://code.sec.samsung.net/jira/browse/TCSACR-392
huiyu.eun [Tue, 22 Dec 2020 07:23:48 +0000 (16:23 +0900)]
[NUI] Fix ScrollBar Unparent bug
ScrollBar.Unparent() is not working.
ScrollBar.Unparent() -> ScrollableBase.Remove(view)
Remove() of ScrollableBase is overridden to be removed based on ContentContainer.
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
guowei.wang [Mon, 21 Dec 2020 06:52:54 +0000 (14:52 +0800)]
[NUI] Fix wrong thumb position in Scrollbar.
Jaehyun Cho [Tue, 22 Dec 2020 06:18:50 +0000 (15:18 +0900)]
[NUI] Fix RadioButton not to invoke duplicate SelectedChanged (#2115)
RadioButton does not change its state to unselected if button or key is
unpressed while its state is selected.
Previously, RadioButton invoked duplicate SelectedChanged if button or
key is unpressed while its state is selected.
Now, RadioButton does not invoke duplicate SelectedChanged if button or
key is unpressed while its state is selected.
Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
zhouleonlei [Tue, 22 Dec 2020 01:45:18 +0000 (09:45 +0800)]
[NUI] Fix build errors for NUISample
huiyu.eun [Tue, 22 Dec 2020 03:46:26 +0000 (12:46 +0900)]
[NUI]Fix build warning[CA1001]
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1001
CA1001: Types that own disposable fields should be disposable
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Jiyun Yang [Tue, 22 Dec 2020 05:00:38 +0000 (14:00 +0900)]
[NUI] Fix view style initialization bug (#2442)
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
YeongJong Lee [Tue, 22 Dec 2020 04:00:32 +0000 (13:00 +0900)]
[NUI] rewrite theme resource (#2405)
Theme resources would only be updated by Tizen Theme Manager.
So, this patch remove xaml support for theme resources.
Dongsug Song [Mon, 21 Dec 2020 11:06:33 +0000 (20:06 +0900)]
[NUI] Version update (nui2206)
YeongJong Lee [Tue, 22 Dec 2020 03:56:28 +0000 (12:56 +0900)]
[NUI] deprecate unused FocusRequestArgs class (#2411)
`FocusChangeREquested` event was removed in
https://github.com/Samsung/TizenFX/pull/903.
dongsug-song [Tue, 15 Dec 2020 06:49:08 +0000 (15:49 +0900)]
[NUI] Version update (nui2205) (#2406)
- matched with dali2-2.0.5
Dongsug Song [Mon, 21 Dec 2020 11:06:33 +0000 (20:06 +0900)]
[NUI] Version update (nui2206)
huiyu.eun [Mon, 21 Dec 2020 08:16:20 +0000 (17:16 +0900)]
[NUI] Remove RegisterCallback function
stringDelegate registration is aledy called from the constructor.
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
huiyueun [Mon, 21 Dec 2020 03:43:16 +0000 (12:43 +0900)]
Update ViewPublicMethods.cs
huiyu.eun [Mon, 21 Dec 2020 02:19:34 +0000 (11:19 +0900)]
[NUI] Add an exception when deleting a view that is not child
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
zhouleonlei [Fri, 18 Dec 2020 09:06:22 +0000 (17:06 +0800)]
[NUI] Use PascalCase for private fields
zhouleonlei [Fri, 18 Dec 2020 06:35:48 +0000 (14:35 +0800)]
[NUI] Fix CA2000 issue for Application Builder(disposed)
Wonsik Jung [Fri, 18 Dec 2020 09:39:21 +0000 (18:39 +0900)]
[NUI] Fixing the emtpy finalizers(CA1821)
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1821
Jiyun Yang [Thu, 17 Dec 2020 07:08:36 +0000 (16:08 +0900)]
[NUI] Initialize feedback instance only when the Feedback property is on.
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Wonsik Jung [Mon, 14 Dec 2020 10:57:58 +0000 (19:57 +0900)]
[NUI] Fix build warning (CA1032)
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1032
guowei.wang [Thu, 17 Dec 2020 08:25:56 +0000 (16:25 +0800)]
[NUI] Fix CA2000 issues in WidgetView.
Dongsug Song [Wed, 9 Dec 2020 12:46:00 +0000 (21:46 +0900)]
[NUI] Fix CA1054
- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1054
- This rule splits the parameter name into tokens based on the camel casing convention and checks whether each token equals "uri", "Uri", "urn", "Urn", "url", or "Url". If there is a match, the rule assumes that the parameter represents a uniform resource identifier (URI). A string representation of a URI is prone to parsing and encoding errors, and can lead to security vulnerabilities. If a method takes a string representation of a URI, a corresponding overload should be provided that takes an instance of the Uri class, which provides these services in a safe and secure manner.
Dongsug Song [Wed, 9 Dec 2020 10:04:07 +0000 (19:04 +0900)]
[NUI] Fix CS0108
Yeongjong Lee [Tue, 15 Dec 2020 02:56:44 +0000 (11:56 +0900)]
[NUI] Rename EventHandler WithReturnType to end in EventHandler
Fixes CA1710
Dongsug Song [Wed, 9 Dec 2020 11:56:39 +0000 (20:56 +0900)]
[NUI] Fix CA1044
- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1044
- Get accessors provide read access to a property and set accessors provide write access. Although it is acceptable and often necessary to have a read-only property, the design guidelines prohibit the use of write-only properties. This is because letting a user set a value and then preventing the user from viewing the value does not provide any security. Also, without read access, the state of shared objects cannot be viewed, which limits their usefulness.
Dongsug Song [Fri, 11 Dec 2020 07:41:12 +0000 (16:41 +0900)]
[NUI] Fix CA1063
- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1063
- Every unsealed type that declares and implements the IDisposable interface must provide its own protected virtual void Dispose(bool) method. Dispose() should call Dispose(true), and the finalizer should call Dispose(false). If you create an unsealed type that declares and implements the IDisposable interface, you must define Dispose(bool) and call it. For more information, see Clean up unmanaged resources (.NET guide) and Dispose pattern.
Bowon Ryu [Wed, 16 Dec 2020 06:12:03 +0000 (15:12 +0900)]
[NUI] Fix build warning CA2213
CA2213: Disposable fields should be disposed
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Wed, 16 Dec 2020 05:36:27 +0000 (14:36 +0900)]
[NUI] Fix build warning CA1820
CA1820: Test for empty strings using string length
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
seungho [Thu, 10 Dec 2020 03:21:17 +0000 (12:21 +0900)]
[NUI] Fix build warning CA1308
- CA1308: Normalize strings to uppercase
Signed-off-by: seungho <sbsh.baek@samsung.com>
Yeongjong Lee [Tue, 15 Dec 2020 03:22:02 +0000 (12:22 +0900)]
[NUI] suppress CA1710 code analysis violation for deprecased APIs
guowei.wang [Tue, 15 Dec 2020 06:14:11 +0000 (14:14 +0800)]
[NUI] Fix the issue that the TrackColor fails to take effect.
huiyu [Tue, 15 Dec 2020 07:05:55 +0000 (16:05 +0900)]
[NUI] Fix build warning & clean code [CA1051]
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1051
- change private (swigCPtr)
Signed-off-by: huiyu <huiyu.eun@samsung.com>
Daekwang Ryu [Mon, 14 Dec 2020 05:23:05 +0000 (14:23 +0900)]
[NUI] Fix CA1066
CA1066:Implement IEquatable when overriding Equals
guowei.wang [Tue, 15 Dec 2020 07:45:06 +0000 (15:45 +0800)]
[NUI] Fix CA2000 issues of UIComponents.
Jaehyun Cho [Wed, 25 Nov 2020 05:29:45 +0000 (14:29 +0900)]
[NUI] Add AlertDialog class
AlertDialog is used to show a dialog with title, message and action
buttons.
Navigator provides static method ShowAlertDialog which pushes Page
containing AlertDialog.
Jaehyun Cho [Mon, 16 Nov 2020 08:34:51 +0000 (17:34 +0900)]
[NUI] Add Dialog class
Dialog is used to show a popup content with background scrim.
Navigator provides static method ShowDialog which pushes Page containing
Dialog.
huayong.xu [Thu, 19 Nov 2020 08:27:10 +0000 (16:27 +0800)]
[NUI] Add left/right shadow effect for the scrollablebase.
This patch is to implement left/right shadow effect for the
scrollablebase.
zhouleonlei [Tue, 15 Dec 2020 05:25:36 +0000 (13:25 +0800)]
[NUI] Fix svace issue for texture
hyotaekshim [Thu, 17 Dec 2020 05:34:02 +0000 (14:34 +0900)]
[Log] Modify documentation about dlog priorities (#2421)
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Co-authored-by: WonYoung Choi <wy80.choi@samsung.com>
bshsqa [Wed, 16 Dec 2020 05:52:10 +0000 (14:52 +0900)]
[NUI] Null check of Owner property of LayoutItem for Independent View. (#2416)
- Current implementation, we didn't check whether the Owner Property is null or not in the Layout method.
- This patch add null check of it to avoid null exception
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
dongsug-song [Tue, 15 Dec 2020 06:49:08 +0000 (15:49 +0900)]
[NUI] Version update (nui2205) (#2406)
- matched with dali2-2.0.5
Sunghyun Kim [Thu, 10 Dec 2020 10:18:22 +0000 (19:18 +0900)]
[NUI] Fix build warning CA1720
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1720
CA1720: Identifiers should not contain type names
These warnings need to suppress.
because it is very common name and it's already published.
According to the document described about the rule, we can suppress warnings.
huiyu [Tue, 15 Dec 2020 04:45:11 +0000 (13:45 +0900)]
[NUI] Delete warning messages
Add SuppressMessage code to the API to be deleted.
Signed-off-by: huiyu <huiyu.eun@samsung.com>
Dongsug Song [Tue, 15 Dec 2020 02:54:44 +0000 (11:54 +0900)]
[NUI] Change "IsTapGestureFeedback" as "Feedback"
huiyueun [Tue, 15 Dec 2020 03:23:05 +0000 (12:23 +0900)]
[NUI] Remove build warning - CA1055 (#2338)
CA1055: URI return values should not be strings
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1055
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: dongsug-song <35130733+dongsug-song@users.noreply.github.com>
huiyu [Tue, 15 Dec 2020 02:10:34 +0000 (11:10 +0900)]
Revert "[NUI] Fix build warning[CA1000]"
This reverts commit
4cef848feaaefe4abac0b5f7890b8402e37fbcf6.
bshsqa [Tue, 15 Dec 2020 01:44:12 +0000 (10:44 +0900)]
[NUI] Fix build warning CA1724 (#2394)
- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1724
- This warning requires to discuss to fix the name of the Class.
Signed-off-by: seungho <sbsh.baek@samsung.com>
ali198724 [Tue, 8 Dec 2020 08:46:51 +0000 (10:46 +0200)]
[NUI] text: Add property for primary cursor (caret) position in TextField/TextEditor
huiyu [Mon, 14 Dec 2020 04:49:29 +0000 (13:49 +0900)]
[NUI] Fix build warning[CA1000]
Signed-off-by: huiyu <huiyu.eun@samsung.com>
huiyu [Mon, 14 Dec 2020 03:30:18 +0000 (12:30 +0900)]
[NUI] Fix build warning[CA1064]
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1065
Signed-off-by: huiyu <huiyu.eun@samsung.com>
Sunghyun Kim [Mon, 14 Dec 2020 07:27:40 +0000 (16:27 +0900)]
[NUI] Fix build warning CS1064
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1064
CA1064: Exceptions should be public
Jaeun Choi [Tue, 6 Oct 2020 02:33:12 +0000 (11:33 +0900)]
[NUI] Add TabView and related classes
TabView and its related classes, TabBar, TabContent, TabButton and
TabButtonGroup, are added.
TabView consists of TabBar and TabContent.
TabBar consists of a list of TabButton.
TabContent consists of a list of View.
TabView.AddTab() adds TabButton and View to TabBar and TabContent in
TabView.
TabView.RemoveTab() removes TabButton and View from TabBar and
TabContent in TabView.
Jiyun Yang [Mon, 7 Dec 2020 04:19:40 +0000 (13:19 +0900)]
[NUI] Improve Theme load
* Provide default theme in C#: Xaml file IO and parsing time reduced
* Provide on demand theme loading for packages: This enables to avoid unnecessary package load
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
JoogabYun [Mon, 14 Dec 2020 07:09:41 +0000 (16:09 +0900)]
Change SCROLL_FINAL_X to ScrollFinalX (#2382)
Yeongjong Lee [Thu, 3 Dec 2020 09:26:08 +0000 (18:26 +0900)]
[NUI] Fix CA1710, change name with with the correct suffix
Yeongjong Lee [Thu, 3 Dec 2020 08:29:30 +0000 (17:29 +0900)]
[NUI] Add RelativeLayout sample
Yeongjong Lee [Wed, 21 Oct 2020 06:45:02 +0000 (15:45 +0900)]
[NUI] introduce RelativeLayout
RelativeLayout calculates the size and position of all the
children based on their relationship to each other.
Please see confluence pages for more details.
zhouleonlei [Fri, 11 Dec 2020 08:46:01 +0000 (16:46 +0800)]
[NUI] Modify SwitchSample and warnings
zhouleonlei [Fri, 11 Dec 2020 07:42:04 +0000 (15:42 +0800)]
[NUI] Modify 6.0 to 6.5
zhouleonlei [Fri, 11 Dec 2020 07:31:03 +0000 (15:31 +0800)]
[NUI] Add sound feedback for Control
guowei.wang [Thu, 12 Nov 2020 10:10:53 +0000 (18:10 +0800)]
[NUI] Fix CA2000 warning issues of Application / ImageView.
huiyu.eun [Fri, 11 Dec 2020 01:23:54 +0000 (10:23 +0900)]
[NUI] Call show winodw on ApplicationInit
- When preload application, the show is called before the appcore is created.
- Call the window show at OnInit and notify the app core
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Dongsug Song [Fri, 11 Dec 2020 01:17:08 +0000 (10:17 +0900)]
[NUI] Suppress CA1716, CA1052, CA1034 for deprecated APIs
- Since the detected classes will be deprecated, CA1716 warning message is suppressed.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1716
- This is conflict resolving patch for https://github.com/Samsung/TizenFX/pull/2374
Yeongjong Lee [Thu, 3 Dec 2020 09:48:44 +0000 (18:48 +0900)]
[NUI] use discard to ignore unused return value
Fixes CA1806
Sunghyun Kim [Thu, 10 Dec 2020 09:10:49 +0000 (18:10 +0900)]
[NUI] Fix build warning CS0109
https://docs.microsoft.com/ko-kr/dotnet/csharp/misc/cs0109
seungho [Thu, 10 Dec 2020 08:53:13 +0000 (17:53 +0900)]
[NUI] Prevent unnecessary Layout call, make independent if it has true ExcludeLayouting and root.
- Make changed flag in Layout method true when the layout is really changed.
- If a layout has true value of ExcludeLayouting and it also a root layout, currently it couldn't handled as independent.
- This patch adds to check ExcludeLayouting Property when it call Layout method.
Signed-off-by: seungho <sbsh.baek@samsung.com>
Jiyun Yang [Thu, 10 Dec 2020 05:59:35 +0000 (14:59 +0900)]
[NUI] Remove DropDown class since it is moved to fhub-nui
Signed-off-by: Jiyun Yang <ji.yang@samsung.com>