Paul Wilkins [Mon, 11 Feb 2013 12:56:02 +0000 (12:56 +0000)]
Remove NEWCOEFCONTEXT experiment.
Removal of the NEWCOEFCONTEXT experiment to
reduce code clutter and make it easier to experiment with
some other changes to the coefficient coding context.
Change-Id: Icd17b421384c354df6117cc714747647c5eb7e98
Paul Wilkins [Mon, 11 Feb 2013 12:35:28 +0000 (12:35 +0000)]
Removal of Hybrid DWT/DCT experiment.
Removal of experiment to simplify code base for other
changes.
Change-Id: If0a33952504558511926ad212bc311fc2bffb19a
Christian Duvivier [Wed, 13 Feb 2013 01:08:00 +0000 (17:08 -0800)]
Merge "Faster vp9_regular_quantize_b_8x8." into experimental
Christian Duvivier [Tue, 12 Feb 2013 01:43:27 +0000 (17:43 -0800)]
Faster vp9_regular_quantize_b_8x8.
A couple of scalar optimizations speeding up quantization by about 1.6x. Overall encoder speedup is around 3%.
Change-Id: I19981d1ef0b33e4e5732739574f367fe82771a84
Yunqing Wang [Tue, 12 Feb 2013 23:52:31 +0000 (15:52 -0800)]
Merge "Rewrote fdct8x8" into experimental
John Koleszar [Tue, 12 Feb 2013 21:59:04 +0000 (13:59 -0800)]
Merge "Replace as_mv struct with array" into experimental
Ronald S. Bultje [Wed, 6 Feb 2013 23:30:21 +0000 (15:30 -0800)]
Add tile column size limits (256 pixels min, 4096 pixels max).
This is after discussion with the hardware team. Update the unit test
to take these sizes into account. Split out some duplicate code into
a separate file so it can be shared.
Change-Id: I8311d11b0191d8bb37e8eb4ac962beb217e1bff5
Ronald S. Bultje [Tue, 12 Feb 2013 17:47:29 +0000 (09:47 -0800)]
Merge "Clean up detokenize contextualization to be like tokenizer." into experimental
Scott LaVarnway [Tue, 12 Feb 2013 16:45:24 +0000 (08:45 -0800)]
Merge "Bug fix: ssse3 version of subpixel did not match C code" into experimental
Yunqing Wang [Tue, 12 Feb 2013 06:04:34 +0000 (22:04 -0800)]
Rewrote fdct8x8
Use consistent algorithm.
Change-Id: Ib8484821ebc454b9d3380a3d6571798decd037f3
Ronald S. Bultje [Tue, 12 Feb 2013 01:21:37 +0000 (17:21 -0800)]
Clean up detokenize contextualization to be like tokenizer.
Change-Id: I47174f797df2103da8913c6fb4f4e741817bae82
Christian Duvivier [Mon, 11 Feb 2013 23:34:08 +0000 (15:34 -0800)]
Faster convolve8_avg.
Implement convolve8_avg using common functions which are already optimized
instead of using more obscure ones which have only C versions. Encoder
overall speed-up of about 12%.
Change-Id: I8c57aa76936c8a48f22b115f19f61d9f2ae1e4b6
Jingning Han [Mon, 11 Feb 2013 22:46:06 +0000 (14:46 -0800)]
Merge "butterfly inverse 4x4 ADST" into experimental
Yunqing Wang [Mon, 11 Feb 2013 20:15:26 +0000 (12:15 -0800)]
Merge "Integerization of dct32x32" into experimental
Jingning Han [Sat, 9 Feb 2013 00:19:42 +0000 (16:19 -0800)]
butterfly inverse 4x4 ADST
fixed format issues.
Implement the inverse 4x4 ADST using 9 multiplications. For this
particular dimension, the original ADST transform can be
factorized into simpler operations, hence is retained.
Change-Id: Ie5d9749942468df299ab74e90d92cd899569e960
Ronald S. Bultje [Mon, 11 Feb 2013 16:20:12 +0000 (08:20 -0800)]
Merge "Port sadNxNx4d functions to x86inc.asm." into experimental
Paul Wilkins [Tue, 5 Feb 2013 10:13:25 +0000 (10:13 +0000)]
Change rd thresholds and add speed trade off flags.
Experimental tweaks to various thresholds to measure
quality / speed trade off.
Add flag that allows static segmentation to be turned off
and disables it unless in the second pass of a two pass
encode.
Change-Id: I219702ffe858412a83db801cbbbd869924b8c61b
Scott LaVarnway [Sat, 9 Feb 2013 23:15:14 +0000 (15:15 -0800)]
Bug fix: ssse3 version of subpixel did not match C code
A 16 bit overflow condition occurs when using the EIGHTTAP_SMOOTH filters.
(vp9_sub_pel_filters_8lp) Changed the order of the adds to fix this problem.
Also added ssse3 support for 4x4 subpixel filtering.
Change-Id: I475eaadae920794c2de5e01e9735c059a856518e
Paul Wilkins [Sat, 9 Feb 2013 12:21:08 +0000 (04:21 -0800)]
Merge "Nearest / Zero Mv default entropy tweak." into experimental
John Koleszar [Sat, 9 Feb 2013 03:46:36 +0000 (19:46 -0800)]
Replace as_mv struct with array
Replace as_mv.{first, second} with a two element array, so that they
can easily be processed with an index variable.
Change-Id: I1e429155544d2a94a5b72a5b467c53d8b8728190
John Koleszar [Sat, 9 Feb 2013 04:20:37 +0000 (20:20 -0800)]
Merge "Pass macroblock index to pick inter functions" into experimental
Ronald S. Bultje [Fri, 8 Feb 2013 01:28:56 +0000 (17:28 -0800)]
Port sadNxNx4d functions to x86inc.asm.
Change-Id: Ic639f5742f7a007753d7a3fa5c66235172eb31d8
Ronald S. Bultje [Thu, 7 Feb 2013 18:24:46 +0000 (10:24 -0800)]
Add sad64x64 and sad32x32 SSE2 versions.
Also port the 4x4, 16x16, 8x16 and 16x8 versions to x86inc.asm; this
makes them all slightly faster, particularly on x86-64. Remove SSE3
sad16x16 version, since the SSE2 version is now faster.
About 1.5% overall encoding speedup.
Change-Id: Id4011a78cce7839f554b301d0800d5ca021af797
Ronald S. Bultje [Thu, 7 Feb 2013 01:16:36 +0000 (17:16 -0800)]
Make cost_coeffs() more efficient.
Cache the constant offset in one variable to prevent re-loading that
in each loop iteration, and mark the function as inline so we can use
the fact that the transform size is always known in the caller.
Almost 1% faster encoding overall.
Change-Id: Id78325a60b025057d8f4ecd9003a74086ccbf85a
John Koleszar [Thu, 7 Feb 2013 18:09:05 +0000 (10:09 -0800)]
Pass macroblock index to pick inter functions
Pass the current mb row and column around rather than the
recon_yoffset and recon_uvoffset, since those offsets will
change from predictor to predictor, based on the reference
frame selection.
Change-Id: If3f9df059e00f5048ca729d3d083ff428e1859c1
John Koleszar [Fri, 8 Feb 2013 22:20:05 +0000 (14:20 -0800)]
Merge changes Icd1a2a5a,I204d17a1,I3ed92117 into experimental
* changes:
Initial support for resolution changes on P-frames
Avoid allocating memory when resizing frames
Adds a test for the VP8E_SET_SCALEMODE control
John Koleszar [Fri, 8 Feb 2013 21:19:47 +0000 (13:19 -0800)]
Merge changes Ife0d8147,I7d469716,Ic9a5615f into experimental
* changes:
Restore SSSE3 subpixel filters in new convolve framework
Convert subpixel filters to use convolve framework
Add 8-tap generic convolver
John Koleszar [Wed, 6 Feb 2013 23:54:52 +0000 (15:54 -0800)]
Initial support for resolution changes on P-frames
Allows inter-frames to change resolution. Currently these are
almost equivalent to keyframes, as only intra prediction modes
are allowed, but without the other context resets that occur on
keyframes.
Change-Id: Icd1a2a5af0d9462cc792588427b0a1f5b12e40d3
John Koleszar [Wed, 6 Feb 2013 22:22:17 +0000 (14:22 -0800)]
Avoid allocating memory when resizing frames
As long as the new frame is smaller than the size that was originally
allocated, we don't need to free and reallocate the memory allocated.
Instead, do the allocation on the size of the first frame. We could
make this passed in from the application instead, if we wanted to
support external upscaling.
Change-Id: I204d17a130728bbd91155bb4bd863a99bb99b038
John Koleszar [Wed, 6 Feb 2013 20:44:20 +0000 (12:44 -0800)]
Adds a test for the VP8E_SET_SCALEMODE control
Tests that the external interface to set the internal codec scaling
works as expected. Also updates the test to pull the height from
the decoded frame size rather than parsing the keyframe header,
in anticipation of allowing resolution changes on non-keyframes.
Change-Id: I3ed92117d8e5288fbbd1e7b618f2f233d0fe2c17
John Koleszar [Fri, 8 Feb 2013 01:00:37 +0000 (17:00 -0800)]
Restore SSSE3 subpixel filters in new convolve framework
This commit adds the 8 tap SSSE3 subpixel filters back into the code
underneath the convolve API. The C code is still called for 4x4
blocks, as well as compound prediction modes. This restores the
encode performance to be within about 8% of the baseline.
Change-Id: Ife0d81477075ae33c05b53c65003951efdc8b09c
Yunqing Wang [Sat, 19 Jan 2013 01:04:58 +0000 (17:04 -0800)]
Integerization of dct32x32
Test on derf set showed 0.047% overall psnr change.
Change-Id: Id16c276c251a3943850ac9b95e9b09a56cf42b19
Paul Wilkins [Wed, 6 Feb 2013 13:02:53 +0000 (13:02 +0000)]
Nearest / Zero Mv default entropy tweak.
Tweak to default mode context to account for the fact
that when there are no non zero motion candidates
Nearest is now the preferred mode for coding a 0,0
vector.
Also resolve duplicate function name and typos.
Change-Id: I76802788d46c84e3d1c771be216a537ab7b12817
Yaowu Xu [Thu, 7 Feb 2013 19:51:23 +0000 (11:51 -0800)]
move dct/idct constants to a header file
also removed some un-unsed functions.
Change-Id: Ie363bcc8d94441d054137d2ef7c4fe59f56027e5
Jingning Han [Tue, 5 Feb 2013 20:37:13 +0000 (12:37 -0800)]
Butterfly ADST based hybrid transform
Refactor the 8x8 inverse hybrid transform. It is now consistent
with the new inverse DCT. Overall performance loss (due to the
use of this variant ADST, and the rounding errors in the butterfly
implementation) for std-hd is -0.02.
Fixed BUILD warning.
Devise a variant of the original ADST, which allows butterfly
computation structure. This new transform has kernel of the
form: sin((2k+1)*(2n+1) / (4N)). One of its butterfly structures
using floating-point multiplications was reported in Z. Wang,
"Fast algorithms for the discrete W transform and for the discrete
Fourier transform", IEEE Trans. on ASSP, 1984.
This patch includes the butterfly implementation of the inverse
ADST/DCT hybrid transform of dimension 8x8.
Change-Id: I3533cb715f749343a80b9087ce34b3e776d1581d
Paul Wilkins [Tue, 5 Feb 2013 12:54:09 +0000 (12:54 +0000)]
Added skip switches for SB32 and SB64
Added switches and code to skip/breakout from
doing SB32 and SB64 tests based on whether
the 16x16 MB tests used split modes. Also to
optionally skip 64x64 if 16x16 was chosen over
32x32.
Impact varies depending on clip from a few %
up to almost 50% on encode speed. Only the
split mode breakout is currently enabled.
Change-Id: Ib5836140b064b350ffa3057778ed2cadcc495cf8
Ronald S. Bultje [Wed, 6 Feb 2013 22:13:05 +0000 (14:13 -0800)]
Use fdct8x4 instead of fdct4x4 where the block size allows it.
This allows for faster SIMD implementations in the future (currently
there is no speed impact).
Change-Id: I732647e9148b5dcb44e6bc8728138f0141218329
Ronald S. Bultje [Wed, 6 Feb 2013 20:45:28 +0000 (12:45 -0800)]
Use configure checks for various inline keywords.
Change-Id: I8508f1a3d3430f998bb9295f849e88e626a52a24
Ronald S. Bultje [Wed, 6 Feb 2013 19:20:59 +0000 (11:20 -0800)]
Add sse2 versions of sub_pixel_variance{32x32,64x64}.
7.5% faster overall encoding.
Change-Id: Ie9bb7f9fdf93659eda106404cb342525df1ba02f
Ronald S. Bultje [Wed, 6 Feb 2013 18:07:30 +0000 (10:07 -0800)]
Merge "Reindent segmentation code." into experimental
Ronald S. Bultje [Wed, 6 Feb 2013 17:08:30 +0000 (09:08 -0800)]
Reindent segmentation code.
Indentation was off by 2 spaces for this particular block.
Change-Id: I1e587b7ad3eff77ade5521252d20c7bb2daa0f6d
John Koleszar [Wed, 6 Feb 2013 16:22:48 +0000 (08:22 -0800)]
Eliminate tautology
Unreachable code
that does nothing anyway
removed forever.
Change-Id: I14105d2dd9dbc9d558f36464055e350dbeb45488
Paul Wilkins [Wed, 6 Feb 2013 12:06:31 +0000 (04:06 -0800)]
Merge "Change definition of NearestMV." into experimental
Ronald S. Bultje [Wed, 6 Feb 2013 01:15:04 +0000 (17:15 -0800)]
Fix mismatch after merge of the tiling patch.
Change-Id: I8ecc178b4d4069e721c7fec6d7631c00e4a3e5d5
Ronald S. Bultje [Fri, 1 Feb 2013 17:35:28 +0000 (09:35 -0800)]
[WIP] Add column-based tiling.
This patch adds column-based tiling. The idea is to make each tile
independently decodable (after reading the common frame header) and
also independendly encodable (minus within-frame cost adjustments in
the RD loop) to speed-up hardware & software en/decoders if they used
multi-threading. Column-based tiling has the added advantage (over
other tiling methods) that it minimizes realtime use-case latency,
since all threads can start encoding data as soon as the first SB-row
worth of data is available to the encoder.
There is some test code that does random tile ordering in the decoder,
to confirm that each tile is indeed independently decodable from other
tiles in the same frame. At tile edges, all contexts assume default
values (i.e. 0, 0 motion vector, no coefficients, DC intra4x4 mode),
and motion vector search and ordering do not cross tiles in the same
frame.
t log
Tile independence is not maintained between frames ATM, i.e. tile 0 of
frame 1 is free to use motion vectors that point into any tile of frame
0. We support 1 (i.e. no tiling), 2 or 4 column-tiles.
The loopfilter crosses tile boundaries. I discussed this briefly with Aki
and he says that's OK. An in-loop loopfilter would need to do some sync
between tile threads, but that shouldn't be a big issue.
Resuls: with tiling disabled, we go up slightly because of improved edge
use in the intra4x4 prediction. With 2 tiles, we lose about ~1% on derf,
~0.35% on HD and ~0.55% on STD/HD. With 4 tiles, we lose another ~1.5%
on derf ~0.77% on HD and ~0.85% on STD/HD. Most of this loss is
concentrated in the low-bitrate end of clips, and most of it is because
of the loss of edges at tile boundaries and the resulting loss of intra
predictors.
TODO:
- more tiles (perhaps allow row-based tiling also, and max. 8 tiles)?
- maybe optionally (for EC purposes), motion vectors themselves
should not cross tile edges, or we should emulate such borders as
if they were off-frame, to limit error propagation to within one
tile only. This doesn't have to be the default behaviour but could
be an optional bitstream flag.
Change-Id: I5951c3a0742a767b20bc9fb5af685d9892c2c96f
Ronald S. Bultje [Tue, 5 Feb 2013 23:40:46 +0000 (15:40 -0800)]
Merge "Add SSE3 versions for sad{32x32,64x64}x4d functions." into experimental
Yaowu Xu [Tue, 5 Feb 2013 23:26:47 +0000 (15:26 -0800)]
Merge "fix a build issue with MSVC on windows" into experimental
Yaowu Xu [Tue, 5 Feb 2013 23:26:36 +0000 (15:26 -0800)]
Merge "rewrite 4x4 idct and fdct" into experimental
Ronald S. Bultje [Tue, 5 Feb 2013 23:21:47 +0000 (15:21 -0800)]
Add SSE3 versions for sad{32x32,64x64}x4d functions.
Overall encoding about 15% faster.
Change-Id: I176a775c704317509e32eee83739721804120ff2
John Koleszar [Tue, 29 Jan 2013 00:59:03 +0000 (16:59 -0800)]
Convert subpixel filters to use convolve framework
Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.
There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.
This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.
Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.
Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
John Koleszar [Fri, 25 Jan 2013 17:47:09 +0000 (09:47 -0800)]
Add 8-tap generic convolver
This commit introduces a new convolution function which will be used to
replace the existing subpixel interpolation functions. It is much the
same as the existing functions, but allows for changing the filter
kernel on a per-pixel basis, and doesn't bake in knowledge of the
filter to be applied or the size of the resulting block into the
function name.
Replacing the existing subpel filters will come in a later commit.
Change-Id: Ic9a5615f2f456cb77f96741856fc650d6d78bb91
Yaowu Xu [Mon, 4 Feb 2013 23:22:55 +0000 (15:22 -0800)]
fix a build issue with MSVC on windows
for idct 16x16 unit test
Change-Id: I51da9405c3a4d7bb3f4cdf062aaccaa90b33dca4
Yaowu Xu [Mon, 4 Feb 2013 23:22:32 +0000 (15:22 -0800)]
rewrite 4x4 idct and fdct
This commit changes the 4x4 iDCT to use same algorithm & constants as
other iDCTs. The 4x4 fDCT is also changed to be based on the new iDCT.
Change-Id: Ib1a902693228af903862e1f5a08078c36f2089b0
Paul Wilkins [Tue, 5 Feb 2013 10:28:26 +0000 (10:28 +0000)]
Change definition of NearestMV.
This commit makes the NearestMV match the chosen
best reference MV. It can be a 0,0 or non zero vector
which means the the compound nearest mv mode can
combine a 0,0 and a non zero vector.
Change-Id: I2213d09996ae2916e53e6458d7d110350dcffd7a
Scott LaVarnway [Tue, 5 Feb 2013 16:56:05 +0000 (08:56 -0800)]
Merge "Added vp9_short_idct1_32x32_c" into experimental
Paul Wilkins [Tue, 5 Feb 2013 10:12:45 +0000 (02:12 -0800)]
Merge "Re-factor code for rd thresholds." into experimental
Scott LaVarnway [Tue, 5 Feb 2013 00:49:17 +0000 (16:49 -0800)]
Added vp9_short_idct1_32x32_c
and called this function in vp9_dequant_idct_add_32x32_c when
eob == 1. For the test clip used, the decoder performance improved
by 21+%. Based on Yaowu's 16 point idct work.
Change-Id: Ib579a90fed531d45777980e04bf0c9b23c093c43
Paul Wilkins [Mon, 4 Feb 2013 17:43:02 +0000 (17:43 +0000)]
Re-factor code for rd thresholds.
Separate out code to set the main encode speed
related rd thresholds. Some values changed from
the initial defaults for various new modes.
Quality test results pending but even the addition
of some further non-zero defaults helps encode speed
somewhat in limited testing on derf clips.
Adjustment of thresholds for quality / speed tradeoff
to follow.
Change-Id: I117ee473157e151a1b93193d5f393449328de20d
Yaowu Xu [Mon, 4 Feb 2013 18:16:59 +0000 (10:16 -0800)]
Added INT16_MIN and INT16_MAX for MSVC builds
These macros were not defined in earlier version of MSVC
Change-Id: I8270a3abb7c6e9ead1931a653d7e41f877a1017b
Yaowu Xu [Fri, 1 Feb 2013 19:02:42 +0000 (11:02 -0800)]
enable 16x16 iDCT unit test
test for forward transform will be enabled later after re-do forward
transform
Change-Id: Ie7c7cf88baf7ecbebbe52fe027e1c3b33d3b9d49
Yaowu Xu [Fri, 1 Feb 2013 23:34:28 +0000 (15:34 -0800)]
re-write 8 point idct
to be consistent with idct16 and idct32.
Change-Id: Ie89dbd32b65c33274b7fecb4b41160fcf1962204
Yaowu Xu [Sat, 2 Feb 2013 00:45:54 +0000 (16:45 -0800)]
a couple of minor fixes
fixed a function prototypes to prevent compiler warnings;
removed a function not in use;
un-capitialize "Refstride" to ref_stride
Change-Id: Ib4472b6084f357d96328c6a06e795b6813a9edba
Yaowu Xu [Fri, 1 Feb 2013 16:22:20 +0000 (08:22 -0800)]
Merge "Changes 16 point idct" into experimental
Yaowu Xu [Fri, 1 Feb 2013 13:57:41 +0000 (05:57 -0800)]
Merge "fix a small bug in 16 point forward dct" into experimental
Yaowu Xu [Fri, 1 Feb 2013 00:16:28 +0000 (16:16 -0800)]
Changes 16 point idct
This commit changes the inverse 16 point dct to use the same algorithm
as the one for 32 point idct. In fact, now 16 point dct uses the exact
version of the souce code for even portion of the 32 point idct.
Tests showed current implementation has significant better accuracy
than the previous version. With this implementation and the minor bug
fix on forward 16 point dct, encoding tests showed about 0.2% better
compression of CIF set, test results on std-hd setting pending.
Change-Id: I68224b60c816ba03434e9f08bee147c7e344fb63
Yaowu Xu [Thu, 31 Jan 2013 23:39:41 +0000 (15:39 -0800)]
fix a small bug in 16 point forward dct
The commit fixes a minor error in 16 point fdct where in a rotation can
produce result of -1 instead of 0.
Change-Id: I45aac4a52bcd06225c6d04e643547a13e1c1aade
Yaowu Xu [Thu, 31 Jan 2013 18:48:01 +0000 (10:48 -0800)]
Merge "A fix point implementation of 32x32 idct" into experimental
Yaowu Xu [Wed, 30 Jan 2013 21:01:49 +0000 (13:01 -0800)]
A fix point implementation of 32x32 idct
This commit changes the 32x32 idct to use integer only. The algorithm
was taken directly from "A Fast Computational Algorithm for the
Discrete Cosine Tranform" by W. Chen, et al., which was published in
IEEE Transaction on Communication Vol. Com.-25 No. 9, 1977. The signal
flow graph in the original paper is for a 32 point forward dct, the
current implementation of inverse DCT was done by follow the graph in
reversed direction.
With this implementation, the 32 point inverse dct contains a 16 point
inverse dct in its even portion, similarly the 16 point idct further
contains 8 point and 4 point inverse dcts.
As of patch 4, encoding tests showed there is no compression loss when
compared against the floating point baseline. Numbers even showed very
small postives. (cif: .01%, std-hd: .05%).
Change-Id: I2d2d17a424b0b04b42422ef33ec53f5802b0f378
Deb Mukherjee [Wed, 30 Jan 2013 20:03:45 +0000 (12:03 -0800)]
Merge "Adding a frame parallel decoding mode" into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 18:02:51 +0000 (10:02 -0800)]
Merge "don't code the branch for the predicted seg_id if that flag is false." into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 17:30:46 +0000 (09:30 -0800)]
don't code the branch for the predicted seg_id if that flag is false.
Change-Id: Icb6e21dc0c2d9918faa33c8bf70943660df7ad88
Ronald S. Bultje [Wed, 30 Jan 2013 17:12:17 +0000 (09:12 -0800)]
Merge "Default superblock skip flag to 32x32 for skip-blocks." into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 17:12:02 +0000 (09:12 -0800)]
Merge "Reset skip flag in superblock RD loop." into experimental
Deb Mukherjee [Wed, 30 Jan 2013 16:38:17 +0000 (08:38 -0800)]
Merge "Further improvement on compound inter-intra expt" into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 05:46:31 +0000 (21:46 -0800)]
Default superblock skip flag to 32x32 for skip-blocks.
This is identical to the later decisions made in encode_superblock().
This commit doesn't actually change anything, but makes the mbmi state
more consistent between the RD loop and the final encode result.
Change-Id: I9e735afb7c5a52e5b61728cb88c67ef9b9bf59be
Ronald S. Bultje [Wed, 30 Jan 2013 05:42:46 +0000 (21:42 -0800)]
Reset skip flag in superblock RD loop.
This is the superblock equivalent of commit 290b83a.
Change-Id: Ib3945dd9e992fa9ec1fdea5a11e17a3cc0e37637
Ronald S. Bultje [Wed, 30 Jan 2013 00:58:52 +0000 (16:58 -0800)]
Write only visible area (for better comparison with rec.yuv).
Change-Id: I32bf4ee532a15af78619cbcd8a193224029fab50
Ronald S. Bultje [Tue, 29 Jan 2013 20:49:42 +0000 (12:49 -0800)]
Merge "Fix block pointer corruption in intra8x8 prediction with 4x4 transform." into experimental
Ronald S. Bultje [Tue, 29 Jan 2013 20:49:22 +0000 (12:49 -0800)]
Merge "Fix overread/write reported by valgrind if (mb_cols) & 3 != 0." into experimental
Paul Wilkins [Tue, 29 Jan 2013 17:29:45 +0000 (09:29 -0800)]
Merge "Remove eob_max_offset markers." into experimental
Paul Wilkins [Tue, 29 Jan 2013 17:29:26 +0000 (09:29 -0800)]
Merge "Segment Skip Flag" into experimental
Scott LaVarnway [Tue, 29 Jan 2013 17:19:58 +0000 (09:19 -0800)]
Merge "Added eob == 0 check to vp9_dequant_idct_add_32x32_c" into experimental
Ronald S. Bultje [Sat, 26 Jan 2013 00:08:19 +0000 (16:08 -0800)]
Fix block pointer corruption in intra8x8 prediction with 4x4 transform.
The RD loop would change the pointer after the first mode (DC) was tested,
leading to corrupt block objects being provided for the others. This
would essentially render the i8x8 predictor useless.
Change-Id: I16c5906ca64fb34878ac32ce59af8974e4582bb8
Paul Wilkins [Tue, 29 Jan 2013 13:33:17 +0000 (13:33 +0000)]
Remove eob_max_offset markers.
Remove eob_max_offset markers and replace
with the generic skip_block flag to indicate
to the quantizer that all coeffs to be set to 0
and eob position set to 0;
Change-Id: Id477e8f8d4ec1a5562758904071013c24b76bfd7
Deb Mukherjee [Thu, 24 Jan 2013 23:22:57 +0000 (15:22 -0800)]
Further improvement on compound inter-intra expt
Adds a special combination mode specific to intra prediciton
mode D45.
Current results with the compound inter/intra experiment:
derf: 0.2%
yt: 0.55%
std-hd: 0.75%
hd: 0.74%
Change-Id: I8976bdf3b9b0b66ab8c5c628bbc62c14fc72ca86
Paul Wilkins [Mon, 28 Jan 2013 15:22:53 +0000 (15:22 +0000)]
Segment Skip Flag
First step in simplifying the segment mode and
segment EOB flags into a simpler segment skip
flag that implies 0,0 mv and EOB at position 0.
Change-Id: Ib750cac31a7a02dc21082580498efd9f7d8d72a5
Paul Wilkins [Mon, 28 Jan 2013 16:35:36 +0000 (08:35 -0800)]
Merge "Simplify Zero bin and zero bin run code." into experimental
Paul Wilkins [Thu, 24 Jan 2013 18:28:33 +0000 (18:28 +0000)]
Simplify Zero bin and zero bin run code.
Simplification to eliminate a number of very large data
data structures. All zero run, zbin boosts for different
transform sizes are now limited to a maximum run length
of 15 before they max out the boost.
Some further work still needs be done to refactor, rationalize
and optimize the multiple quantizer functions.
The simplification coupled with tweaks to the 16 element array
now used for all transform sizes, has minimal effect on quality.
Change-Id: I6f3948b8ca0418b60d4db9030ff19026a34ed423
John Koleszar [Sat, 26 Jan 2013 01:48:18 +0000 (17:48 -0800)]
Tweak DropFramesWithoutRecovery params
The previous parameters did not pass with VP8.
Change-Id: I1505171fbd713d21029541828ebdbe4c7dea79b8
Ronald S. Bultje [Sat, 26 Jan 2013 00:03:15 +0000 (16:03 -0800)]
Fix overread/write reported by valgrind if (mb_cols) & 3 != 0.
We'd backup and restore all cols for a 64x64 SB, but the array wouldn't
be big enough to hold all that data.
Change-Id: Ic68ea721bf07e0b2f3937bd16b0b734bcc743ce1
Deb Mukherjee [Fri, 25 Jan 2013 19:30:28 +0000 (11:30 -0800)]
Adding a frame parallel decoding mode
Adds a flag to disable features that would inhibit frame parallel
decoding. This includes backward adaptation and MV sorting based
on search in ref frame buffer.
Also includes some minor clean-ups.
Change-Id: I434846717a47b7bcb244b37ea670c5cdf776f14d
Ronald S. Bultje [Fri, 25 Jan 2013 17:43:42 +0000 (09:43 -0800)]
Merge "Remove "update_context" variable from VP9_COMP context." into experimental
Scott LaVarnway [Fri, 25 Jan 2013 01:09:56 +0000 (17:09 -0800)]
Added eob == 0 check to vp9_dequant_idct_add_32x32_c
Added a quick eob == 0 check. Once the integer version of the dct32x32 is
complete, we can check for other eob cases.
For the 1080p clip used, the decoder performance improved by 4%.
Change-Id: I9390b6ed3c8be0c0c0a0c44c578d9a031d6e026e
Ronald S. Bultje [Fri, 25 Jan 2013 00:28:53 +0000 (16:28 -0800)]
Remove "update_context" variable from VP9_COMP context.
The variable is always zero.
Change-Id: Id5cdbecad543bca465a5b1d471badaec7e112c8d
Paul Wilkins [Thu, 24 Jan 2013 12:52:13 +0000 (12:52 +0000)]
Mvref speedup
Quality / decode speed trade off changes.
Simpler insert method without sort. Quality impact small.
Change-Id: Id0c0941bc508d985405abd06a13ffe7489170b62
Paul Wilkins [Thu, 24 Jan 2013 17:21:49 +0000 (09:21 -0800)]
Merge "MSVS compiler error" into experimental
Paul Wilkins [Thu, 24 Jan 2013 11:42:38 +0000 (11:42 +0000)]
MSVS compiler error
Visual Studio reports and error on the line
static const int bsize2 = bsize >> 1;
"error C2099: initializer is not a constant"
Also warnings on signed/unsigned mismatch
Change-Id: I76cb06f736bd9c90107a26bfb3c130ec3f6c33de
Scott LaVarnway [Thu, 24 Jan 2013 16:45:22 +0000 (08:45 -0800)]
Merge "Intrinsic version of loopfilter now matches C code" into experimental
Deb Mukherjee [Tue, 15 Jan 2013 14:43:35 +0000 (06:43 -0800)]
Adds an error-resilient mode with test
Adds an error-resilient mode where frames can be continued
to be decoded even when there are errors (due to network losses)
on a prior frame. Specifically, backward updates are turned off
and probabilities of various symbols are reset to defaults at
the beginning of each frame. Further, the last frame's mvs are
not used for the mv reference list, and the sorting of the
initial list based on search on previous frames is turned off
as well.
Also adds a test where an arbitrary set of frames are skipped
from decoding to simulate errors. The test verifies (1) that if
the error frames are droppable - i.e. frame buffer updates have
been turned off - there are no mismatch errors for the remaining
frames after the error frames; and (2) if the error-frames are non
droppable, there are not only no decoding errors but the mismatch
PSNR between the decoder's version of the post-error frames and the
encoder's version is at least 20 dB.
Change-Id: Ie6e2bcd436b1e8643270356d3a930e8989ff52a5
John Koleszar [Wed, 23 Jan 2013 22:52:22 +0000 (14:52 -0800)]
Merge "Support multiple codecs in test infrastructure" into experimental