platform/core/csapi/xsf.git
5 years ago[Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes...
Pavel Yakovlev [Tue, 19 Mar 2019 20:05:38 +0000 (23:05 +0300)]
[Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes #5460

* [Android] Fixes cancel Webview Navigation

* - added fix 4891
- refactoring

* Fix obsolete message

Co-authored-by: Ralph Brackert <brackert@baselineconnect.com>
5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Tue, 19 Mar 2019 20:01:21 +0000 (13:01 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Controls] Fix build
Rui Marinho [Tue, 19 Mar 2019 20:00:02 +0000 (20:00 +0000)]
[Controls] Fix build

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Tue, 19 Mar 2019 18:58:17 +0000 (11:58 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[UITest] Disable old 1461 test (#5605)
Samantha Houts [Tue, 19 Mar 2019 18:08:56 +0000 (11:08 -0700)]
[UITest] Disable old 1461 test (#5605)

5 years ago[MacOS] Fix rendering small text (#5443) fixes #2204
Rui Marinho [Tue, 19 Mar 2019 09:48:11 +0000 (09:48 +0000)]
[MacOS] Fix rendering small text (#5443) fixes #2204

* [MacOS] Draft push test fix macOS test

* Refactor

* [Controls] Add repo test case #2204

* [Controls] Remove demo page

* [iOS,macOS] Refactor FontExtensions

* [iOS] Change visibility of shared method

* [Controls] Cleanup test #2204

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Tue, 19 Mar 2019 01:25:50 +0000 (18:25 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Android] fall back to using native get identifier if reflection fails to retrieve...
Shane Neuville [Tue, 19 Mar 2019 01:22:34 +0000 (19:22 -0600)]
[Android] fall back to using native get identifier if reflection fails to retrieve drawable (#5585)

* - first try to use native get identifier before reflection

* add dummy types

* - try reflection first

* - add null check for resource requests

* fix fall through checks

* Update Xamarin.Forms.Platform.Android/ResourceManager.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* - remove "smart" code for simpler code

* - fix replace

* - cleanup

* remove using

* - better if placement

* - hide LogInfoToPreviewer

* - hide LogInfoToPreviewer

5 years ago[X] intercepts FindByName exceptions (#5599)
Stephane Delcroix [Mon, 18 Mar 2019 23:43:59 +0000 (00:43 +0100)]
[X] intercepts FindByName exceptions (#5599)

for previewer

- fixes #5572

5 years ago[X] resilient to random text content (#5557)
Stephane Delcroix [Mon, 18 Mar 2019 22:45:15 +0000 (23:45 +0100)]
[X] resilient to random text content (#5557)

- fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/817588

5 years ago[X] Allow empty property xaml-elements (#5550)
Stephane Delcroix [Mon, 18 Mar 2019 21:58:36 +0000 (22:58 +0100)]
[X] Allow empty property xaml-elements (#5550)

- fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/817710?src=WorkItemMention&src-action=artifact_link
- reverts #4582

5 years ago[iOS,Shell] Fix tab bar style color alignment to match Android (#5075)
David Ortinau [Mon, 18 Mar 2019 18:52:49 +0000 (13:52 -0500)]
[iOS,Shell] Fix tab bar style color alignment to match Android (#5075)

* Set the same TabBar color styles as Android

* unified on title color, made names consistent, and commented unused properties.

5 years agoHandle CollectionView multiple selection on Android and iOS (#5352)
E.Z. Hart [Mon, 18 Mar 2019 14:46:41 +0000 (08:46 -0600)]
Handle CollectionView multiple selection on Android and iOS (#5352)

* Handle multiple selection on Android and iOS

* Fire SelectionChanged events and commands when switching modes

* Do not fire the selection change if the mode change results in identical selection

* Fix rebase

* Temporarily patching EditorRenderer to get iOS tests running

* Fix bug where native selection is lost when items are off-screen

* [Core] Cleanup drop private o SelectionList

* [Android] Use local variable on foreach

5 years ago- Move renderer registration to Assembly Info (#5584)
Shane Neuville [Mon, 18 Mar 2019 11:47:23 +0000 (05:47 -0600)]
- Move renderer registration to Assembly Info (#5584)

5 years ago[X] recover from memberaccessEx
Stephane Delcroix [Mon, 18 Mar 2019 10:25:47 +0000 (11:25 +0100)]
[X] recover from memberaccessEx

- fixes #5589

5 years agoremove maps.design (#5583)
Shane Neuville [Mon, 18 Mar 2019 09:27:22 +0000 (03:27 -0600)]
remove maps.design (#5583)

5 years agoMerge branch '3.6.0' into 4.0.0
Stephane Delcroix [Mon, 18 Mar 2019 08:40:11 +0000 (09:40 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoremove left over sealed on Material Entry Renderer (#5586)
Shane Neuville [Sat, 16 Mar 2019 01:19:53 +0000 (19:19 -0600)]
remove left over sealed on Material Entry Renderer (#5586)

5 years ago[Android] Fix issue when Message is null on Android API19 (#5562)
Rui Marinho [Sat, 16 Mar 2019 01:13:14 +0000 (01:13 +0000)]
[Android] Fix issue when Message is null on Android API19 (#5562)

* [Android] Fix issue when Message is null on Android API19

* added kitkat check and moved check to extension method

* - remove awaken for kit kat and just catch all NPE

* - remove using

5 years ago[XamlC] Resolve complex property type (#5086)
Akihiko Odaki [Fri, 15 Mar 2019 22:12:57 +0000 (07:12 +0900)]
[XamlC] Resolve complex property type (#5086)

5 years ago[Shell,Core] Add better exception messages for wrong or non existing content (#5566)
Rui Marinho [Fri, 15 Mar 2019 21:45:17 +0000 (21:45 +0000)]
[Shell,Core] Add better exception messages for wrong or non existing content (#5566)

fixes #5081

5 years ago[Android] fix focus event on android and add UI Tests (#5528)
Shane Neuville [Fri, 15 Mar 2019 21:43:04 +0000 (15:43 -0600)]
[Android] fix focus event on android and add UI Tests (#5528)

* fix focus event for material entry and add ui tests

* fix iOS

* - Focused
fixes #5509

5 years ago[iOS] Fix crash when going from empty to having items (#5430)
E.Z. Hart [Fri, 15 Mar 2019 11:32:17 +0000 (05:32 -0600)]
[iOS] Fix crash when going from empty to having items (#5430)

* Fix crash on iOS when going from empty to having items

* Temporarily patching EditorRenderer so iOS tests can run

5 years ago[X] resilient to unyped x:Name (#5552)
Stephane Delcroix [Fri, 15 Mar 2019 00:42:54 +0000 (01:42 +0100)]
[X] resilient to unyped x:Name (#5552)

Allow the previewer to recover from an x:Name attribute on a element
with unresolved type.

- fixes #5546
- closes #5547

5 years ago[Controls] Only register AppCompact renderer if running in that context
Rui Marinho [Thu, 14 Mar 2019 15:31:44 +0000 (15:31 +0000)]
[Controls] Only register AppCompact renderer if running in that context

5 years ago[XamlC] Correctly load addresses of values in compiled binding paths (#5082)
Akihiko Odaki [Thu, 14 Mar 2019 12:39:29 +0000 (21:39 +0900)]
[XamlC] Correctly load addresses of values in compiled binding paths (#5082)

5 years ago[X] resilience on markup (#5532)
Stephane Delcroix [Thu, 14 Mar 2019 08:21:19 +0000 (09:21 +0100)]
[X] resilience on markup (#5532)

let the previewer intercepts and recover from misformatted markups

- fixes #5508
- closes #5527

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Wed, 13 Mar 2019 22:40:27 +0000 (15:40 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Housekeeping] Be more polite (#5539)
Samantha Houts [Wed, 13 Mar 2019 21:51:38 +0000 (14:51 -0700)]
[Housekeeping] Be more polite (#5539)

5 years agoFix Map ItemsSource bp name (#5499)
Andrei Nitescu [Wed, 13 Mar 2019 19:24:22 +0000 (21:24 +0200)]
Fix Map ItemsSource bp name (#5499)

5 years ago[Android] ensure scrollbar has been initialized (#5462)
Shane Neuville [Wed, 13 Mar 2019 16:03:32 +0000 (10:03 -0600)]
[Android] ensure scrollbar has been initialized (#5462)

* [Android] ensure scrollbar has been initialized

* fix comments

* Update Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs

5 years agoCorrect Grid Height When Aspect Fit Image Gets Shrinked (#4990)
spruceDevelopment [Wed, 13 Mar 2019 11:39:58 +0000 (12:39 +0100)]
Correct Grid Height When Aspect Fit Image Gets Shrinked  (#4990)

- fixes #4933

* Grid size incorrect when using with Image #4990

* Unit Test for Grid size incorrect when using with Image #4933

* Grid size incorrect when using with Image #4933

* Unit Test for Grid size incorrect when using with Image #4933

5 years ago[UWP] added Win2D.uwp dependency to nuget (#5475)
Pavel Yakovlev [Tue, 12 Mar 2019 23:58:05 +0000 (02:58 +0300)]
[UWP] added Win2D.uwp dependency to nuget (#5475)

fixes #5188

5 years ago[XamlC] Identify generic instance types correctly when importing ctor (#5309)
Akihiko Odaki [Fri, 22 Feb 2019 00:56:42 +0000 (09:56 +0900)]
[XamlC] Identify generic instance types correctly when importing ctor (#5309)

The old implementation fails to identify generic instance types for typed
binding getter, whose type is:
System.Func`2<TSource, ValueTuple<TProperty, bool>>

This fixes the issue by taking generic arguments into account.

5 years agoFix NamedSize in Previewer (#5496)
Tim Barham [Tue, 12 Mar 2019 21:36:12 +0000 (07:36 +1000)]
Fix NamedSize in Previewer (#5496)

In the previewer, ConvertTextAppearanceToSize() returns -0.5 for all values. Return default value if we get a size of 0 or less.

5 years agoFix up Sandbox to work with previewer and add android material reference in (#5513)
Shane Neuville [Mon, 11 Mar 2019 20:45:38 +0000 (14:45 -0600)]
Fix up Sandbox to work with previewer and add android material reference in (#5513)

* fix sandbox to work with previewer

* small page fixes

5 years ago[X] recover from missing markup type (#5485)
Stephane Delcroix [Mon, 11 Mar 2019 13:38:34 +0000 (14:38 +0100)]
[X] recover from missing markup type (#5485)

- fixes #5484

5 years agoMerge branch '3.6.0' into 4.0.0
Stephane Delcroix [Mon, 11 Mar 2019 08:19:20 +0000 (09:19 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Maps} move design dll to the design folder (#5481)
Samantha Houts [Thu, 7 Mar 2019 22:44:10 +0000 (14:44 -0800)]
[Maps} move design dll to the design folder (#5481)

- fixes #5472

5 years agoContextCompat.getColor if API < 23 (#5450)
kingces95 [Thu, 7 Mar 2019 17:18:57 +0000 (07:18 -1000)]
ContextCompat.getColor if API < 23 (#5450)

Update Xamarin.Forms.Platform.Android/Forms.cs

Does this do all the suggestions?

Co-Authored-By: kingces95 <kingces95@users.noreply.github.com>
ContextCompat.getColor if API < 23

5 years ago[UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)
Shane Neuville [Thu, 7 Mar 2019 17:17:43 +0000 (10:17 -0700)]
[UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)

* [UWP] pass the correct object to ItemView

* - remove object from source

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Wed, 6 Mar 2019 00:54:26 +0000 (16:54 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agoUwp restart uitests on crash (#5420)
Shane Neuville [Tue, 5 Mar 2019 18:07:57 +0000 (11:07 -0700)]
Uwp restart uitests on crash (#5420)

* [UWP] if a UI tests crashes the UWP window this will restart the window so all the rest of the tests can run

* simplify

5 years ago[iOS] Check new element before creating placeholder label (#5432)
E.Z. Hart [Tue, 5 Mar 2019 18:06:27 +0000 (11:06 -0700)]
[iOS] Check new element before creating placeholder label (#5432)

* Check new element before creating placeholder label

* additional checks

* create placeholder once

5 years ago[Android] remove android specific target (#5442)
Shane Neuville [Mon, 4 Mar 2019 23:43:22 +0000 (16:43 -0700)]
[Android] remove android specific target (#5442)

* [Android] get rid of specific android targets

* change to AndroidApplication

* remove before/after targets

* MonoAndroid

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 2 Mar 2019 03:16:42 +0000 (19:16 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agofix changed apis (#5426)
Shane Neuville [Sat, 2 Mar 2019 03:15:08 +0000 (20:15 -0700)]
fix changed apis (#5426)

* fix changed apis

* increment language version

* bring some back

* update font

* VisualElement fixes

fixes #4644
fixes #5170

5 years agoFix WPFResources, EntryCell (#5361)
Matthijs ter Woord [Fri, 1 Mar 2019 23:49:49 +0000 (00:49 +0100)]
Fix WPFResources, EntryCell (#5361)

Also bind Isenabled
fixes #5360

5 years ago[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)
Gerald Versluis [Fri, 1 Mar 2019 23:47:31 +0000 (00:47 +0100)]
[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)

* Implemented Core and iOS

* Implemented Android

* Supressed platform specific obsolete warnings for now

* Implemented UWP

* Make selected page on UWP not rely on title

* Review feedback

* Removed references to (now) obsolete members

* Review feedback fixes

* Code review feedback

* Changed obsolete msg to reflect right XF version

* Apply suggestions from code review

Co-Authored-By: jfversluis <github@geraldversluis.nl>
fixes #3478

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Fri, 1 Mar 2019 18:07:45 +0000 (10:07 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Fri, 1 Mar 2019 18:06:34 +0000 (10:06 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years agoReverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping...
Samantha Houts [Fri, 1 Mar 2019 17:59:21 +0000 (09:59 -0800)]
Reverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping if starts with '{' (#5169)" (#5424)

* Revert "[X] only require escaping if starts with '{' (#5169)"

This reverts commit cd73391c3a2d7ff60a95449cac255c1425e81a43.

* Revert "[Xaml] require escaping curly braces (#4723)"

This reverts commit 6753ace40e68f8aa6d45eefa90117f5650984c6f.

* Make sure parsing doesn't fail when there *are* curly braces now

5 years ago[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987
Pavel Yakovlev [Fri, 1 Mar 2019 17:22:18 +0000 (20:22 +0300)]
[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987

5 years agoMerge branch '3.6.0'
Samantha Houts [Fri, 1 Mar 2019 02:12:27 +0000 (18:12 -0800)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Fri, 1 Mar 2019 02:10:53 +0000 (18:10 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years ago[X] bubble markup exception to previewer (#5411)
Stephane Delcroix [Fri, 1 Mar 2019 00:17:13 +0000 (01:17 +0100)]
[X] bubble markup exception to previewer (#5411)

- fixes #5407

5 years agoFix iOS EmptyView crash; properly handle EmptyView swapping (#5353)
E.Z. Hart [Thu, 28 Feb 2019 20:02:49 +0000 (13:02 -0700)]
Fix iOS EmptyView crash; properly handle EmptyView swapping (#5353)

5 years ago[X] allow previewer fallback on rootnode (#5413)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)

* [X] allow previewer fallback on rootnode

- fixes #5410

* additional test case

5 years ago[X] allow previewer fallback on rootnode (#5413)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)

* [X] allow previewer fallback on rootnode

- fixes #5410

* additional test case

5 years ago[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible...
Shane Neuville [Thu, 28 Feb 2019 18:57:20 +0000 (11:57 -0700)]
[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5398)

* return IVisualElementRenderer to previous state

* set to internal

5 years agopreviewer; PageRenderer trap for missing bg image (#5342)
kingces95 [Thu, 28 Feb 2019 02:32:57 +0000 (16:32 -1000)]
previewer; PageRenderer trap for missing bg image (#5342)

* previewer; PageRenderer trap for missing bg image

* previewer; PageRenderer trap for missing bg image

* fix macOS; remove ext for macOS

fixes #5300

5 years agoMerge branch '3.6.0'
Samantha Houts [Thu, 28 Feb 2019 02:22:37 +0000 (18:22 -0800)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Thu, 28 Feb 2019 02:21:59 +0000 (18:21 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years ago[iOS, Android] Prevent NREs in ScrollViews (#5383)
Samantha Houts [Thu, 28 Feb 2019 02:08:47 +0000 (18:08 -0800)]
[iOS, Android] Prevent NREs in ScrollViews (#5383)

* Add null checks on new code paths added in #4522

fixes #5161

* Fix cast...

Fixes #5247

5 years agoAllow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the Recycler...
E.Z. Hart [Thu, 28 Feb 2019 02:06:48 +0000 (19:06 -0700)]
Allow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the RecyclerView's child collection (#5358)

Fixes #5078

5 years ago[X] more conv exception, bubble to previewer (#5400)
Stephane Delcroix [Thu, 28 Feb 2019 01:58:58 +0000 (02:58 +0100)]
[X] more conv exception, bubble to previewer (#5400)

Catch more exception cases, make sure the previewer can recover from them

- fixes #5397

5 years ago[Android, iOS] added re-measure of TimePicker after change value (#4999)
Pavel Yakovlev [Thu, 28 Feb 2019 01:49:11 +0000 (04:49 +0300)]
[Android, iOS] added re-measure of TimePicker after change value (#4999)

5 years agoMerge branch '3.6.0'
ShaneN [Thu, 28 Feb 2019 01:20:24 +0000 (18:20 -0700)]
Merge branch '3.6.0'

5 years ago[UITests] remove extra reference
ShaneN [Thu, 28 Feb 2019 01:19:57 +0000 (18:19 -0700)]
[UITests]  remove extra reference

5 years ago[Android] move android renderers to separate nuget (#5405)
Shane Neuville [Thu, 28 Feb 2019 01:04:52 +0000 (18:04 -0700)]
[Android] move android renderers to separate nuget (#5405)

* [Android] move renderers to separate nuget

* additional android dependency

* rebase with material changes

* add android to material check

* simplify assembly info

* - add context to Init for future cases

5 years ago[Visual] Visual tidy (#5356)
Shane Neuville [Wed, 27 Feb 2019 23:48:45 +0000 (16:48 -0700)]
[Visual] Visual tidy (#5356)

* [Visual] remove visual flag and tidy up code

* - added basic loading ui test

* change material namespaces to be Xamarin.Forms.Material.<Platform>

* api 19 fixes

* fix casing on resources

5 years agodirectly load specified Font Family or other valid PostScript Font Name fixes #5372...
Dan Siegel [Wed, 27 Feb 2019 21:20:14 +0000 (13:20 -0800)]
directly load specified Font Family or other valid PostScript Font Name fixes #5372 (#5373)

5 years agoFix the issue when building on a mac (#5406)
Matthew Leibowitz [Wed, 27 Feb 2019 21:03:40 +0000 (23:03 +0200)]
Fix the issue when building on a mac (#5406)

- mac should not build this assembly, but as it has to do so, exclude everything

5 years agofix https://github.com/xamarin/Xamarin.Forms/issues/5346 (#5379)
Andrei [Wed, 27 Feb 2019 21:02:49 +0000 (00:02 +0300)]
fix https://github.com/xamarin/Xamarin.Forms/issues/5346 (#5379)

5 years ago[C] deprecate GetValues (#5324)
Stephane Delcroix [Wed, 27 Feb 2019 07:56:27 +0000 (08:56 +0100)]
[C] deprecate GetValues (#5324)

* [C] deprecate GetValues

Deprecate GetValues, as it no longer make snes now that the properties
store is a Dictionary and no longer a List.

Update the code to be C#7-ish.

Take this refactoring opportunity to move similar method next to each other.

- fixes #5015

* Apply suggestions from code review

Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
5 years agoBindableProperty: More explanatory exception message (#5384)
Andrei Nitescu [Wed, 27 Feb 2019 07:55:47 +0000 (09:55 +0200)]
BindableProperty: More explanatory exception message (#5384)

5 years ago[UWP] fix so tests are compatible with UWP (#4984)
Shane Neuville [Wed, 27 Feb 2019 00:58:40 +0000 (17:58 -0700)]
[UWP] fix so tests are compatible with UWP (#4984)

* [UWP] fix so tests are compatible with UWP

* [UWP] when UI tests run don't load issues list

* [uwp] add preload of tests back in

* added UWP Ignore

5 years ago[Visual] Material Editor (#5345)
Shane Neuville [Tue, 26 Feb 2019 19:46:48 +0000 (12:46 -0700)]
[Visual] Material Editor (#5345)

* [Material] Visual

* - gallery and simplify android renderers

* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs

* Update Xamarin.Forms.Platform.Android/Material/MaterialEditorRenderer.cs

* wire up done and fix ph bug

* - ios fix auto sizing issues

* fix NRE

* - Android: fix bounce and IsreadOnly
- iOS: fix IsReadonly and sizing issue

* - fix editor

* Fix ios Editor to shrink when lines are deleted

* Update Xamarin.Forms.Material.iOS/MaterialMultiLineTextField.cs

* - formatting fixes

5 years agoMerge branch '3.6.0'
Stephane Delcroix [Tue, 26 Feb 2019 19:12:27 +0000 (20:12 +0100)]
Merge branch '3.6.0'

5 years ago[previewer] resilience on createvalue (#5369)
Stephane Delcroix [Tue, 26 Feb 2019 19:09:16 +0000 (20:09 +0100)]
[previewer] resilience on createvalue (#5369)

- fixes #5171

5 years ago[X] wrap typeconverter exceptions in XPE (#5388)
Stephane Delcroix [Tue, 26 Feb 2019 19:07:17 +0000 (20:07 +0100)]
[X] wrap typeconverter exceptions in XPE (#5388)

- fixes #5378

5 years ago[Visual] Check if assembly is dynamic before calling GetExportedTypes (#5389)
Shane Neuville [Tue, 26 Feb 2019 17:38:10 +0000 (10:38 -0700)]
[Visual] Check if assembly is dynamic before calling GetExportedTypes (#5389)

* check if assembly is dynamic

* add filenotfound catch

5 years ago[Android] add build error if TargetFramework is too low (#5350)
Shane Neuville [Tue, 26 Feb 2019 17:22:48 +0000 (10:22 -0700)]
[Android] add build error if TargetFramework is too low (#5350)

* [Android] add build error if TargetFramework is to low

* change to Corecompile

* add disable condition

5 years agoVisual equality (#5380)
Matthew Leibowitz [Tue, 26 Feb 2019 13:59:29 +0000 (15:59 +0200)]
Visual equality (#5380)

No one gets to go to the top, not even the great Material Design. All pages are equal, and are listed alphabetically.

5 years ago[Visual] Visual xaml and Visual registrations (#5304)
Shane Neuville [Mon, 25 Feb 2019 20:54:02 +0000 (13:54 -0700)]
[Visual] Visual xaml and Visual registrations (#5304)

* [visual] add intellisense popups for visual

* Add visual registrations into type converter

* combine VisualMarker and VisualRendererMarker

* remove visual from class name for intellisense

* set Match Parent to internal

* Remove register code and just scan assemblies

* [Visual] Add Visual Attribute and some additional attribute checks

* remove registrar changes

* renamed to specific VisualTypes

* - move check up to LINQ statement

* Make sure the other platforms can create visuals

* fix renderer names

* move stepper renderer

* rename converter

5 years agoUpdate BindableLayout.cs to fix #5213 (#5243)
Jeremy Marcus [Mon, 25 Feb 2019 19:44:00 +0000 (14:44 -0500)]
Update BindableLayout.cs to fix #5213 (#5243)

- fixes #5213

* Add Test for BindableLayout RemoveAll

* Update BindableLayout.cs to fix RemoveAll exception

* Missing using statements

5 years ago┬──┬◡ノ(° -°ノ)
Stephane Delcroix [Mon, 25 Feb 2019 09:46:32 +0000 (10:46 +0100)]
┬──┬◡ノ(° -°ノ)

5 years agoMerge branch '3.6.0'
Stephane Delcroix [Mon, 25 Feb 2019 07:33:25 +0000 (08:33 +0100)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Stephane Delcroix [Mon, 25 Feb 2019 07:20:29 +0000 (08:20 +0100)]
Merge branch '3.5.0' into 3.6.0

5 years ago[Visual] Material Pickers (#5194)
Shane Neuville [Mon, 25 Feb 2019 03:21:39 +0000 (20:21 -0700)]
[Visual] Material Pickers (#5194)

* [Material] Change Picker EditText fields to Material

* [Visual] add material placeholder properties

* - add ios placeholder changes

* - remove placeholder apis

* - shrink entry fields when they have no place holder

* - invalidate measure

* - remove marshalling

5 years ago[Android CollectionView] Fixes crash when ItemSource Changed (#5146)
Pavel Yakovlev [Sun, 24 Feb 2019 18:00:31 +0000 (21:00 +0300)]
[Android CollectionView] Fixes crash when ItemSource Changed (#5146)

5 years ago[Android iOS Visual] fixes background in ActivityIndicator (#5283)
Pavel Yakovlev [Sat, 23 Feb 2019 09:30:47 +0000 (12:30 +0300)]
[Android iOS Visual] fixes background in ActivityIndicator (#5283)

* [Android, iOS Visual] fixes background in AcrivityIndicator

* [Android] reduce nesting layouts

* [Android] simplification

* Some calculations for iOS

* [Android] removed padding, added size limit
[iOS] fixes stroke width

* [iOS] default size as in Android

* Use the Android ratio of 10 instead of the spec of 12

* [Android] fix API23

* [iOS] fix unexpected padding

* [Android] fixes padding in API 23 -- IsRunning -- added gallery

* [Android] fixes start with IsRunning = false

* [Android] again fix isRunning

* address comments

5 years ago[Material] [Android, iOS] Materializing the stepper (#5027)
Matthew Leibowitz [Fri, 22 Feb 2019 19:51:45 +0000 (21:51 +0200)]
[Material] [Android, iOS] Materializing the stepper (#5027)

* [Android] [Material] Refactored the Stepper on Android #5011
 - reuse code between default and material
 - added material stepper

* [Android] [Material] Using the "Fast" renderer style for the stepper #5011
 - switched the button style to the outlined buttons

* [Android] [Material] Adding the tab stops support (#5000)

* [Android] [Material] Switching back to a traditional renderer for now to get tabstops working

* [Material] [iOS] Added a Material stepper for iOS

* [Material] [Android, iOS] Addressed the PR feedback

* [Material] Remove private

* Update MaterialStepperRenderer.cs

* Update StepperRendererManager.cs

* Fixed the merge issues

* add steppers to visual gallery

* The material stepper buttons now resize to fit the available space.

* Update Xamarin.Forms.Controls/ControlGalleryPages/VisualGallery.xaml

Co-Authored-By: mattleibow <mattleibow@live.com>
* [Material] [Stepper] Don't set the background color for steppers
 - we still need to decide on the logic behind the coloring of outline buttons

* Fixed the Android accessibility

* Change UI tests to not use a Text search for locating stepper controls

5 years ago[Material] rename iOS assembly to be non platform specific (#5332)
Shane Neuville [Fri, 22 Feb 2019 15:29:25 +0000 (08:29 -0700)]
[Material] rename iOS assembly to be non platform specific (#5332)

* [Material] rename iOS assembly

* fix title and Internals Visible To

5 years agoAdd UI test to B41600 (#5174)
Ione Souza Junior [Fri, 22 Feb 2019 01:08:31 +0000 (22:08 -0300)]
Add UI test to B41600 (#5174)

5 years ago[CSS] fix mapping for vertical-align (#5275)
Stephane Delcroix [Fri, 22 Feb 2019 00:59:48 +0000 (01:59 +0100)]
[CSS] fix mapping for vertical-align (#5275)

5 years ago[XamlC] Identify generic instance types correctly when importing ctor (#5309)
Akihiko Odaki [Fri, 22 Feb 2019 00:56:42 +0000 (09:56 +0900)]
[XamlC] Identify generic instance types correctly when importing ctor (#5309)

The old implementation fails to identify generic instance types for typed
binding getter, whose type is:
System.Func`2<TSource, ValueTuple<TProperty, bool>>

This fixes the issue by taking generic arguments into account.

5 years ago[Android] Fix SearchBar renderer height on API24 (#5329)
Rui Marinho [Fri, 22 Feb 2019 00:23:32 +0000 (00:23 +0000)]
[Android] Fix SearchBar renderer height on API24 (#5329)

5 years ago[Android] Include default proguard file so user doesn't have to create rules for...
Shane Neuville [Thu, 21 Feb 2019 20:22:39 +0000 (15:22 -0500)]
[Android] Include default proguard file so user doesn't have to create rules for XF (#5143)

* [2709] Add default proguard config file

* add proguard.cfg file to nuspec

5 years agoFix NRE in Android ResourceManager when reference resource in Previewer (#5331)
Tim Barham [Thu, 21 Feb 2019 01:24:18 +0000 (11:24 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5331)

Fixes part of #5300

(cherry picked from commit fb59591580ea474e7f48e5941854fd790dc5a8cb)