platform/upstream/dotnet/runtime.git
7 years agoRemove dead remoting.cpp
danmosemsft [Mon, 13 Feb 2017 05:01:16 +0000 (21:01 -0800)]
Remove dead remoting.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/c3eb35629731e40bf4ee826db88311f636f9ad36

7 years agoRemove dead objectclone.cpp
danmosemsft [Mon, 13 Feb 2017 05:00:22 +0000 (21:00 -0800)]
Remove dead objectclone.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/0627527ec3b9921928e7ed3ba9f7d1c34cbdb627

7 years agoRemove dead mixedmode.cpp
danmosemsft [Mon, 13 Feb 2017 04:58:49 +0000 (20:58 -0800)]
Remove dead mixedmode.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/aac8c16336872daae128ad531720dcbafe7a98f5

7 years agoRemove dead message.cpp
danmosemsft [Mon, 13 Feb 2017 04:57:29 +0000 (20:57 -0800)]
Remove dead message.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/0226a2eb0c600d06d43ad54514b595a7d7a3f751

7 years agoRemove dead mdadac.cpp
danmosemsft [Mon, 13 Feb 2017 04:54:30 +0000 (20:54 -0800)]
Remove dead mdadac.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/01cd52961742f595ca710027fd3b0714ad594262

7 years agoRemove dead mda.cpp
danmosemsft [Mon, 13 Feb 2017 04:53:44 +0000 (20:53 -0800)]
Remove dead mda.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/b15fd281c15c39d26418e94d422e6eee148046a8

7 years agoRemove dead gchost.cpp
danmosemsft [Mon, 13 Feb 2017 04:52:42 +0000 (20:52 -0800)]
Remove dead gchost.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/85443510ce834866f2bc899e8512c2b7b90ee3ed

7 years agoRemove dead crossdomaincalls.cpp
danmosemsft [Mon, 13 Feb 2017 04:51:31 +0000 (20:51 -0800)]
Remove dead crossdomaincalls.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/41a53ba525c708b229d1c545249bf95c40c10a38

7 years agoRemove constrainedexecutionregion.cpp
danmosemsft [Mon, 13 Feb 2017 04:42:42 +0000 (20:42 -0800)]
Remove constrainedexecutionregion.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/6f05c7c8d283345b811cfe7abe1c2ad416301a12

7 years agoRemove commethodrental
danmosemsft [Mon, 13 Feb 2017 04:25:22 +0000 (20:25 -0800)]
Remove commethodrental

Commit migrated from https://github.com/dotnet/coreclr/commit/54a687af2ab167060392ea95dd2f8fac643c6880

7 years agoRemove clrpriv* dead code
danmosemsft [Mon, 13 Feb 2017 04:21:08 +0000 (20:21 -0800)]
Remove clrpriv* dead code

Commit migrated from https://github.com/dotnet/coreclr/commit/4a252cee944e66e7ad709bc11a31037c78fcdfe9

7 years agoRemove dead assemblynamesconfigfactory etc files
danmosemsft [Mon, 13 Feb 2017 03:55:22 +0000 (19:55 -0800)]
Remove dead assemblynamesconfigfactory etc files

Commit migrated from https://github.com/dotnet/coreclr/commit/57aaf669076c1fb4c756251192f301b7b6db22dc

7 years agoRemove dead appdomainhelper* files
danmosemsft [Mon, 13 Feb 2017 03:55:22 +0000 (19:55 -0800)]
Remove dead appdomainhelper* files

Commit migrated from https://github.com/dotnet/coreclr/commit/4adbd6765d79c25dbae8bce48083c8a4e81934f6

7 years agoMerge pull request dotnet/coreclr#9542 from danmosemsft/defines3
Dan Moseley [Mon, 13 Feb 2017 05:54:57 +0000 (21:54 -0800)]
Merge pull request dotnet/coreclr#9542 from danmosemsft/defines3

Remove code corresponding to always defined symbols

Commit migrated from https://github.com/dotnet/coreclr/commit/2efbb9282c059eb9742ba5a59b8a1d52ac4dfa4c

7 years agoAddendum for FEATURE_FUSION
danmosemsft [Mon, 13 Feb 2017 03:17:39 +0000 (19:17 -0800)]
Addendum for FEATURE_FUSION

Commit migrated from https://github.com/dotnet/coreclr/commit/9e3a2fa2faa2a79285fc472c7090821b405469d0

7 years agoAddendum for FEATURE_APPX_BINDER
danmosemsft [Mon, 13 Feb 2017 03:15:47 +0000 (19:15 -0800)]
Addendum for FEATURE_APPX_BINDER

Commit migrated from https://github.com/dotnet/coreclr/commit/3e2323d3c240f12242f6202695032d744c69a9f2

7 years agoAddendum for FEATURE_CODEPAGES_FILE
danmosemsft [Mon, 13 Feb 2017 03:10:52 +0000 (19:10 -0800)]
Addendum for FEATURE_CODEPAGES_FILE

Commit migrated from https://github.com/dotnet/coreclr/commit/981accc3246e25b48ab8be9c1fbd246f3613f65f

7 years agoMerge pull request dotnet/coreclr#9516 from sdmaclea/PR-ARM64-FAILS
Russ Keldorph [Mon, 13 Feb 2017 01:49:30 +0000 (17:49 -0800)]
Merge pull request dotnet/coreclr#9516 from sdmaclea/PR-ARM64-FAILS

[Arm64/Unix] Add list of known arm64 fails

Commit migrated from https://github.com/dotnet/coreclr/commit/8f3b42948fd24d13666ddd1bcfcbd4a5ac74a9ab

7 years agoMerge pull request dotnet/coreclr#9446 from seanshpark/stkalign_helpers
Bruce Forstall [Mon, 13 Feb 2017 01:24:21 +0000 (17:24 -0800)]
Merge pull request dotnet/coreclr#9446 from seanshpark/stkalign_helpers

[x86/Linux] Fix stack alignment in helper stub

Commit migrated from https://github.com/dotnet/coreclr/commit/eae0a0cf6a22bf189844eaf36c773dd0c125b27a

7 years agoMerge pull request dotnet/coreclr#9543 from mskvortsov/fix-9536
Bruce Forstall [Mon, 13 Feb 2017 01:22:03 +0000 (17:22 -0800)]
Merge pull request dotnet/coreclr#9543 from mskvortsov/fix-9536

[Windows/Arm32] Fix a build break

Commit migrated from https://github.com/dotnet/coreclr/commit/357f1178c195bb743025d68f1d075793317b5ebf

7 years agoRemove never defined FEATURE_FUSION
danmosemsft [Mon, 13 Feb 2017 00:51:48 +0000 (16:51 -0800)]
Remove never defined FEATURE_FUSION

Commit migrated from https://github.com/dotnet/coreclr/commit/b9f410b7b85d3948aece3aa009885df244f11e41

7 years agoRemove remainder of FEATURE_CORECLR (tool missed some files, also comments)
danmosemsft [Sun, 12 Feb 2017 23:32:54 +0000 (15:32 -0800)]
Remove remainder of FEATURE_CORECLR (tool missed some files, also comments)

Commit migrated from https://github.com/dotnet/coreclr/commit/206b6a7efbc2e947eff900f448b86573b77ae392

7 years agoComment for Gaurav
danmosemsft [Sun, 12 Feb 2017 22:31:56 +0000 (14:31 -0800)]
Comment for Gaurav

Commit migrated from https://github.com/dotnet/coreclr/commit/764b57ba3b7494a8391f32fea688c46247dc9336

7 years agoRemove never defined FEATURE_CRYPTO
danmosemsft [Sun, 12 Feb 2017 22:30:52 +0000 (14:30 -0800)]
Remove never defined FEATURE_CRYPTO

Commit migrated from https://github.com/dotnet/coreclr/commit/b19c2192fb77f7a9488426520857740c59ffaf2a

7 years agoRemove never defined FEATURE_COMPRESSEDSTACK
danmosemsft [Sun, 12 Feb 2017 22:26:40 +0000 (14:26 -0800)]
Remove never defined FEATURE_COMPRESSEDSTACK

Commit migrated from https://github.com/dotnet/coreclr/commit/527c3a1cbb99c6d9b9f11b250bc73487b2c41120

7 years agoRemove never defined FEATURE_COMINTEROP_WINRT_DESKTOP_HOST
danmosemsft [Sun, 12 Feb 2017 22:23:34 +0000 (14:23 -0800)]
Remove never defined FEATURE_COMINTEROP_WINRT_DESKTOP_HOST

Commit migrated from https://github.com/dotnet/coreclr/commit/e14f9e5a6eacdc1ae0ff51a23d192cf457f7f5cc

7 years agoRemove never defined FEATURE_COMINTEROP_TLB_SUPPORT and files that require it to...
danmosemsft [Sun, 12 Feb 2017 20:46:46 +0000 (12:46 -0800)]
Remove never defined FEATURE_COMINTEROP_TLB_SUPPORT and files that require it to be defined

Commit migrated from https://github.com/dotnet/coreclr/commit/c2ef095b02c2751f304f43d4c529a1fbac6079d2

7 years agoRemove never defined FEATURE_COMINTEROP_REGISTRATION
danmosemsft [Sun, 12 Feb 2017 20:37:06 +0000 (12:37 -0800)]
Remove never defined FEATURE_COMINTEROP_REGISTRATION

Commit migrated from https://github.com/dotnet/coreclr/commit/c9a8100ddeaf106f61bd7837ff17ef2ecc069b0b

7 years agoRemove never defined FEATURE_CODEPAGES_FILE and file
danmosemsft [Sun, 12 Feb 2017 20:28:16 +0000 (12:28 -0800)]
Remove never defined FEATURE_CODEPAGES_FILE and file

Commit migrated from https://github.com/dotnet/coreclr/commit/2ae9e448d2746814ec0045713ced712cb556bd1d

7 years agoRemove never defined FEATURE_CLICKONCE
danmosemsft [Sun, 12 Feb 2017 20:24:42 +0000 (12:24 -0800)]
Remove never defined FEATURE_CLICKONCE

Commit migrated from https://github.com/dotnet/coreclr/commit/8e07276c8da06900db4f6072197ce7beecc0481e

7 years agoRemove never defined FEATURE_CER and header
danmosemsft [Sun, 12 Feb 2017 20:19:09 +0000 (12:19 -0800)]
Remove never defined FEATURE_CER and header

Commit migrated from https://github.com/dotnet/coreclr/commit/3d3333347351975148854e83603241b84764eb32

7 years agoRemove never defined FEATURE_APTCA
danmosemsft [Sun, 12 Feb 2017 20:14:01 +0000 (12:14 -0800)]
Remove never defined FEATURE_APTCA

Commit migrated from https://github.com/dotnet/coreclr/commit/71abc31bcdb631b739bee606930e63d1384aea2f

7 years agoRemove never defined FEATURE_APPX_BINDER
danmosemsft [Sun, 12 Feb 2017 20:08:12 +0000 (12:08 -0800)]
Remove never defined FEATURE_APPX_BINDER

Commit migrated from https://github.com/dotnet/coreclr/commit/2f50fd27bfde5f2bc32c081e6a2196f92fc03992

7 years agoRemove never defined FEATURE_APPDOMAINMANAGER_INITOPTIONS
danmosemsft [Sun, 12 Feb 2017 19:34:37 +0000 (11:34 -0800)]
Remove never defined FEATURE_APPDOMAINMANAGER_INITOPTIONS

Commit migrated from https://github.com/dotnet/coreclr/commit/f2704e6d0b45d37a638ef320a908ff0e3b23f0b5

7 years agoRemove always defined FEATURE_VERSIONING
danmosemsft [Sun, 12 Feb 2017 19:19:46 +0000 (11:19 -0800)]
Remove always defined FEATURE_VERSIONING

Commit migrated from https://github.com/dotnet/coreclr/commit/f7585ef29164a2f3f9d3913eb9f87943094d30b3

7 years agoRemove defined but wrapping dead code FEATURE_SYNTHETIC_CULTURES
danmosemsft [Sun, 12 Feb 2017 19:15:41 +0000 (11:15 -0800)]
Remove defined but wrapping dead code FEATURE_SYNTHETIC_CULTURES

Commit migrated from https://github.com/dotnet/coreclr/commit/cb8a7b899283653156cc32fe5f3f45924207ad3e

7 years agoRemove always defined FEATURE_SYNCHRONIZATIONCONTEXT_WAIT
danmosemsft [Sun, 12 Feb 2017 19:12:36 +0000 (11:12 -0800)]
Remove always defined FEATURE_SYNCHRONIZATIONCONTEXT_WAIT

Commit migrated from https://github.com/dotnet/coreclr/commit/5b9f6a1c0f09d74ea7fe870c7b6c14fe9b5002cc

7 years agoRemove always defined FEATURE_SPAN_OF_T
danmosemsft [Sun, 12 Feb 2017 19:05:31 +0000 (11:05 -0800)]
Remove always defined FEATURE_SPAN_OF_T

Commit migrated from https://github.com/dotnet/coreclr/commit/c65413fd6470e853ceb02649906cdbc164700a97

7 years agoRemove never used FEATURE_NORM_IDNA_ONLY
danmosemsft [Sun, 12 Feb 2017 19:02:08 +0000 (11:02 -0800)]
Remove never used FEATURE_NORM_IDNA_ONLY

Commit migrated from https://github.com/dotnet/coreclr/commit/108b00f5f76e1133497dbcfc4f4bece6a4181f79

7 years agoRemove never used FEATURE_MERGE_CULTURE_SUPPORT_AND_ENGINE
danmosemsft [Sun, 12 Feb 2017 18:59:14 +0000 (10:59 -0800)]
Remove never used FEATURE_MERGE_CULTURE_SUPPORT_AND_ENGINE

Commit migrated from https://github.com/dotnet/coreclr/commit/c444460928696fbf348840a355678f649211db94

7 years agoRemove always defined FEATURE_MAIN_CLR_MODULE_USES_CORE_NAME
danmosemsft [Sun, 12 Feb 2017 18:58:11 +0000 (10:58 -0800)]
Remove always defined FEATURE_MAIN_CLR_MODULE_USES_CORE_NAME

Commit migrated from https://github.com/dotnet/coreclr/commit/9e65011e958ea1668333f63bbd029da67e2db4c9

7 years agoRemove always defined FEATURE_HOST_ASSEMBLY_RESOLVER
danmosemsft [Sun, 12 Feb 2017 18:54:14 +0000 (10:54 -0800)]
Remove always defined FEATURE_HOST_ASSEMBLY_RESOLVER

Commit migrated from https://github.com/dotnet/coreclr/commit/c9850c6172e09fe824e02a6f2e7eb6c4863952d5

7 years agoRemove always defined FEATURE_EXCEPTIONDISPATCHINFO
danmosemsft [Sun, 12 Feb 2017 18:46:48 +0000 (10:46 -0800)]
Remove always defined FEATURE_EXCEPTIONDISPATCHINFO

Commit migrated from https://github.com/dotnet/coreclr/commit/9c93286cb13d9f50f1f25cdcbcbc3719a178b374

7 years agoRemove always defined FEATURE_EXCEPTION_NOTIFICATIONS
danmosemsft [Sun, 12 Feb 2017 18:43:35 +0000 (10:43 -0800)]
Remove always defined FEATURE_EXCEPTION_NOTIFICATIONS

Commit migrated from https://github.com/dotnet/coreclr/commit/2215a4e81c0d4f10edf9ff440c51b240586865e1

7 years agoRemove never used FEATURE_ASYNC_IO
danmosemsft [Sun, 12 Feb 2017 18:36:01 +0000 (10:36 -0800)]
Remove never used FEATURE_ASYNC_IO

Commit migrated from https://github.com/dotnet/coreclr/commit/ba2dc9d177a63701e176c793df7fd9c21fe85548

7 years agoFix indentation in cmake
danmosemsft [Sun, 12 Feb 2017 18:34:28 +0000 (10:34 -0800)]
Fix indentation in cmake

Commit migrated from https://github.com/dotnet/coreclr/commit/a82435dd2c90f5ba91da0b70b6f88cd12fde4b6b

7 years agoAdd RuntimeHelpers.IsReferenceOrContainsReferences<T>() (dotnet/coreclr#9541)
Jan Kotas [Mon, 13 Feb 2017 00:50:50 +0000 (16:50 -0800)]
Add RuntimeHelpers.IsReferenceOrContainsReferences<T>() (dotnet/coreclr#9541)

Rename JitHelpers.ContainsReferences<T>() to RuntimeHelpers.IsReferenceOrContainsReferences<T>() and make it public.

Work towards https://github.com/dotnet/corefx/issues/14047

Commit migrated from https://github.com/dotnet/coreclr/commit/7b66079154b3d703225fbd4cc680d4be537592a8

7 years agoMerge pull request dotnet/coreclr#9544 from stephentoub/delete_unused_const
Stephen Toub [Sun, 12 Feb 2017 23:59:05 +0000 (18:59 -0500)]
Merge pull request dotnet/coreclr#9544 from stephentoub/delete_unused_const

Remove unused const in ArraySortHelper

Commit migrated from https://github.com/dotnet/coreclr/commit/7d18263441b2dca466b082ed498f39b768638141

7 years agoOptimize List Clear+Remove (dotnet/coreclr#9540)
Ben Adams [Sun, 12 Feb 2017 21:56:15 +0000 (21:56 +0000)]
Optimize List Clear+Remove (dotnet/coreclr#9540)

* List Clear+Remove
* Tail call Array.Clear

Commit migrated from https://github.com/dotnet/coreclr/commit/d400876fe3e006d78d2ef39143ff9448c9dd8dc1

7 years agoRemove unused const in ArraySortHelper
Stephen Toub [Sun, 12 Feb 2017 21:02:32 +0000 (16:02 -0500)]
Remove unused const in ArraySortHelper

Commit migrated from https://github.com/dotnet/coreclr/commit/9ef5f9d25687ad0a1e57da26fd2c62edf811afbe

7 years agoWindows/Arm32: Fix a build break.
Mikhael Skvortsov [Sun, 12 Feb 2017 19:57:59 +0000 (22:57 +0300)]
Windows/Arm32: Fix a build break.

Commit migrated from https://github.com/dotnet/coreclr/commit/5524e978cf92dbd46e96a6081e167068feeee267

7 years agoMerge pull request dotnet/coreclr#9525 from danmosemsft/defines2
Dan Moseley [Sun, 12 Feb 2017 01:06:20 +0000 (17:06 -0800)]
Merge pull request dotnet/coreclr#9525 from danmosemsft/defines2

Remove redundant defines from CoreCLR native code

Commit migrated from https://github.com/dotnet/coreclr/commit/52a816d3011f4d03b80b5940dc036b40d701f52d

7 years agoMerge pull request dotnet/coreclr#9471 from stephentoub/task_perf
Stephen Toub [Sun, 12 Feb 2017 00:58:51 +0000 (19:58 -0500)]
Merge pull request dotnet/coreclr#9471 from stephentoub/task_perf

Reduce Task and async method overheads

Commit migrated from https://github.com/dotnet/coreclr/commit/2b7a76cbdb60c7c26cdc445958483eeba795c2ae

7 years agoFix checks for methods that use StackCrawlMark (dotnet/coreclr#9537)
Jan Kotas [Sat, 11 Feb 2017 22:25:04 +0000 (14:25 -0800)]
Fix checks for methods that use StackCrawlMark (dotnet/coreclr#9537)

* Fix checks for methods that use StackCrawlMark

My recent changed these methods to be marked using IsMdRequireSecObject instead, but some
places that have to check for it were not updated correctly.

Commit migrated from https://github.com/dotnet/coreclr/commit/15c2148000f3bf08e95b88f942e9875f74b64d1b

7 years agoMerge pull request dotnet/coreclr#9495 from pgavlin/OptConfig
Pat Gavlin [Sat, 11 Feb 2017 18:34:56 +0000 (10:34 -0800)]
Merge pull request dotnet/coreclr#9495 from pgavlin/OptConfig

Add a flag to enable fine-grained optimize control.

Commit migrated from https://github.com/dotnet/coreclr/commit/3ea68c8ae152ef64b41e1a1e6733261d5b30a81d

7 years agoMerge pull request dotnet/coreclr#9523 from jashook/up_arm64_timeout
Jarret Shook [Sat, 11 Feb 2017 17:04:43 +0000 (09:04 -0800)]
Merge pull request dotnet/coreclr#9523 from jashook/up_arm64_timeout

Up the timeout for arm64 jobs that run tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/f6a455da27aeb01e8943b6ff452fc43e50ec8145

7 years agoInadvertent inline redundant define in threadsuspend.cpp
danmosemsft [Sat, 11 Feb 2017 16:07:02 +0000 (08:07 -0800)]
Inadvertent inline redundant define in threadsuspend.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/994e5e72a54489e9629ae8ad5c9b2e9ab867472e

7 years agoInadvertent inline redundant define in pal
danmosemsft [Sat, 11 Feb 2017 15:50:25 +0000 (07:50 -0800)]
Inadvertent inline redundant define in pal

Commit migrated from https://github.com/dotnet/coreclr/commit/be8d4a4c49573d20bf10b547e2c0e60a9185f96f

7 years agoInadvertent inline redundant define in fxretarget.h
danmosemsft [Sat, 11 Feb 2017 15:45:34 +0000 (07:45 -0800)]
Inadvertent inline redundant define in fxretarget.h

Commit migrated from https://github.com/dotnet/coreclr/commit/64a9bfa3392bbb4fdf8fcc1e57d36175679aa726

7 years agoRevert inadvertent remove of #if FASTLOOP
danmosemsft [Sat, 11 Feb 2017 15:28:22 +0000 (07:28 -0800)]
Revert inadvertent remove of #if FASTLOOP

Commit migrated from https://github.com/dotnet/coreclr/commit/7e61a9201758dc0f6e2c099dde571d1c1af82cff

7 years agoDead comment
danmosemsft [Sat, 11 Feb 2017 15:23:01 +0000 (07:23 -0800)]
Dead comment

Commit migrated from https://github.com/dotnet/coreclr/commit/ebd6a7f81d2930d6e19025db8b6de3cb443abd5d

7 years agoRevert "Remove always defined FEATURE_CORESYSTEM"
danmosemsft [Sat, 11 Feb 2017 15:20:12 +0000 (07:20 -0800)]
Revert "Remove always defined FEATURE_CORESYSTEM"

This reverts commit dotnet/coreclr@751771a8976f909af772e35c167bd7e3ffbe44c8.

Commit migrated from https://github.com/dotnet/coreclr/commit/56d4ba8a9338c3ff7378d18378f38ad847f130f2

7 years agoRevert "Remove more always defined FEATURE_CORESYSTEM"
danmosemsft [Sat, 11 Feb 2017 15:12:07 +0000 (07:12 -0800)]
Revert "Remove more always defined FEATURE_CORESYSTEM"

This reverts commit dotnet/coreclr@52009b8919ba55690f21cdc8f04e012a53eb8ef4.

Commit migrated from https://github.com/dotnet/coreclr/commit/8be2f9bb0039e2c49f59c4fb66cebf5467485ba2

7 years agoMerge pull request dotnet/coreclr#9437 from JosephTremoulet/UpdateFormat
Joseph Tremoulet [Sat, 11 Feb 2017 15:06:29 +0000 (10:06 -0500)]
Merge pull request dotnet/coreclr#9437 from JosephTremoulet/UpdateFormat

Update format.py to use dotnet cli rc3

Commit migrated from https://github.com/dotnet/coreclr/commit/be943edc7273c53ffedaa89b1c689779cf77f943

7 years agoPerf improvements to Task/Task<T>
Stephen Toub [Thu, 9 Feb 2017 22:01:56 +0000 (17:01 -0500)]
Perf improvements to Task/Task<T>

- Remove some unecessary intermediate functions, e.g. Execute(), manually inlining it into its one caller
- Make the common completion path (no exceptions, no cancellation, etc.) more inlineable, and avoid calling some functions (like AddExceptionsFromChildren) when we know they will be nops.
- Make FinishContinuations inlineable.  When there aren't any continuations, this shaves off a measurable percentage of time.  When there are, we're no worse off, as the FinishContinuations entrypoint gets inlined, so we still only have the one function call to RunContinuations.
- Make TaskCompletionSource.TrySetResult more inlineable.  It was just on the cusp, with an extra branch / call to IsCompleted putting it over the edge.  But the common path for calling TrySetResult is when the call will successfully transition, in which case we don't need the IsCompleted call; it's only necessary if/when we lose the race condition, in which case we can pay a bit more to call SpinUntilCompleted.
- Avoid some duplicate logging-related calls
- Remove AggressiveInlining from an ETW-related method that did not need it; the call sites can instead just check IsEnabled before calling it.
- Remove some unnecessary writes, casts, locals, etc., make some fields readonly
- Change CompareExchange to Exchange in Task.WhenAny completion

Commit migrated from https://github.com/dotnet/coreclr/commit/f45a33639d7d8ab1bfcda6de7b5cb74abb95662a

7 years agoStreamline AsyncTaskMethodBuilders
Stephen Toub [Thu, 9 Feb 2017 21:46:03 +0000 (16:46 -0500)]
Streamline AsyncTaskMethodBuilders

- Slim down AsyncTaskMethodBuilder`1.Task and make it aggressively inlined.  The common case we care to optimize for is synchronous completion, in which case the first access to Task will already fine m_task non-null, and we want that access inlined.
- Slim down AsyncTaskMethodBuilder`1.SetResult.  As with Task, we care most about the synchronous completion path, as when perf matters, most async method invocations complete synchronously.  The code path is streamlined so that the synchronous completion path can mostly be inlined.
- Replace some throws with ThrowHelper
- Mark GetTaskForResult as aggressive inlining.  It contains a lot of C# code, but for a given TResult, the JIT trims away the majority of the implementation.

Commit migrated from https://github.com/dotnet/coreclr/commit/88a4a25312d091dcb44cae738a49bd8b981303eb

7 years agoRevert "Remove always defined FEATURE_CORRUPTING_EXCEPTIONS"
danmosemsft [Sat, 11 Feb 2017 06:15:01 +0000 (22:15 -0800)]
Revert "Remove always defined FEATURE_CORRUPTING_EXCEPTIONS"

This reverts commit dotnet/coreclr@b0dab0d6de90a38dfbf0d6b2039a7b8f5269d802.

Commit migrated from https://github.com/dotnet/coreclr/commit/87f8b67a4ee90ef807927f5083e237cb88b34725

7 years agoMissed part of file delete
danmosemsft [Sat, 11 Feb 2017 06:04:44 +0000 (22:04 -0800)]
Missed part of file delete

Commit migrated from https://github.com/dotnet/coreclr/commit/b45b7e4eb467bca44f9d77959df0337bdcecbd3c

7 years agoRemove always defined FEATURE_CORRUPTING_EXCEPTIONS
danmosemsft [Sat, 11 Feb 2017 05:53:12 +0000 (21:53 -0800)]
Remove always defined FEATURE_CORRUPTING_EXCEPTIONS

Commit migrated from https://github.com/dotnet/coreclr/commit/b0dab0d6de90a38dfbf0d6b2039a7b8f5269d802

7 years agoRemove more always defined FEATURE_CORESYSTEM
danmosemsft [Sat, 11 Feb 2017 05:43:40 +0000 (21:43 -0800)]
Remove more always defined FEATURE_CORESYSTEM

Commit migrated from https://github.com/dotnet/coreclr/commit/52009b8919ba55690f21cdc8f04e012a53eb8ef4

7 years agoDead files
danmosemsft [Sat, 11 Feb 2017 05:29:23 +0000 (21:29 -0800)]
Dead files

Commit migrated from https://github.com/dotnet/coreclr/commit/cbbfc7a109a41c5506d28d9b4e91202cf5a9143c

7 years agoRemove always undefined FEATURE_CAS_POLICY
danmosemsft [Sat, 11 Feb 2017 05:08:47 +0000 (21:08 -0800)]
Remove always undefined FEATURE_CAS_POLICY

Commit migrated from https://github.com/dotnet/coreclr/commit/1f75aecd267e4d2d322ce6a812a34d6a34cae1f9

7 years agoRedundant ASSERTE blocks
danmosemsft [Sat, 11 Feb 2017 04:51:05 +0000 (20:51 -0800)]
Redundant ASSERTE blocks

Commit migrated from https://github.com/dotnet/coreclr/commit/6517da4563a47fb370f35c082ae709215f5d0b28

7 years agoRemove always defined FEATURE_CORECLR
danmosemsft [Sat, 11 Feb 2017 01:12:53 +0000 (17:12 -0800)]
Remove always defined FEATURE_CORECLR

Commit migrated from https://github.com/dotnet/coreclr/commit/54891e0650e69f08832f75a40dc102efc6115d38

7 years agoDead files
danmosemsft [Sat, 11 Feb 2017 01:01:50 +0000 (17:01 -0800)]
Dead files

Commit migrated from https://github.com/dotnet/coreclr/commit/396f7d43b3c0f3ca7034a6d1d9cd7d6914778a1e

7 years agoRemove always undefined FEATURE_APTCA
danmosemsft [Sat, 11 Feb 2017 00:07:45 +0000 (16:07 -0800)]
Remove always undefined FEATURE_APTCA

Commit migrated from https://github.com/dotnet/coreclr/commit/6302d7a50884c6cf239e74bad85988be7403fe72

7 years ago[Unix] Skipped tests should report exit code 2 (dotnet/coreclr#9510)
Steve MacLean [Sat, 11 Feb 2017 03:54:07 +0000 (22:54 -0500)]
[Unix] Skipped tests should report exit code 2 (dotnet/coreclr#9510)

Commit migrated from https://github.com/dotnet/coreclr/commit/843a4cf61463adfea8b3a720fcfa586c2ec1187c

7 years agoTurn segfauts into asserts in debug build (dotnet/coreclr#9509)
Steve MacLean [Sat, 11 Feb 2017 03:53:27 +0000 (22:53 -0500)]
Turn segfauts into asserts in debug build (dotnet/coreclr#9509)

* Prevent segfault if method table is null

* ValidateInner() check method table is not null

Commit migrated from https://github.com/dotnet/coreclr/commit/4ac52ffaac430c929b0e80cca84bf53fdf189b41

7 years agoUp the timeout for arm64 jobs that run tests.
jashook [Sat, 11 Feb 2017 03:51:42 +0000 (19:51 -0800)]
Up the timeout for arm64 jobs that run tests.

With the new test update arm64 jobs run too long to fit into the default 120 minutes.

Commit migrated from https://github.com/dotnet/coreclr/commit/25efc45036541aedb7af5a5b83c669466fff82c2

7 years agoMerge pull request dotnet/coreclr#9501 from chcosta/mscorlib_race
chcosta [Sat, 11 Feb 2017 03:50:36 +0000 (19:50 -0800)]
Merge pull request dotnet/coreclr#9501 from chcosta/mscorlib_race

Fix race condition building System.Private.CoreLib.dll and SOS.NETCore.dll

Commit migrated from https://github.com/dotnet/coreclr/commit/dcd5eeaf0948e2c5abed49b1c025d65f85c921d3

7 years agoUpdate lsra-throughput.md
Carol Eidt [Sat, 11 Feb 2017 03:28:22 +0000 (19:28 -0800)]
Update lsra-throughput.md

Commit migrated from https://github.com/dotnet/coreclr/commit/6f33e3be7d2c0f508bcdb0bd5f00367ec7a4c5be

7 years agoMerge pull request dotnet/coreclr#9519 from CarolEidt/FixCoreFx15713
Carol Eidt [Sat, 11 Feb 2017 03:15:25 +0000 (19:15 -0800)]
Merge pull request dotnet/coreclr#9519 from CarolEidt/FixCoreFx15713

Add a test case for PR dotnet/coreclr#9496

Commit migrated from https://github.com/dotnet/coreclr/commit/54062ca4aabcdc299df36efa1e7ddfdc7b1550f6

7 years ago[Arm64/Unix] Remove aarch64 unsupported message (dotnet/coreclr#9508)
Steve MacLean [Sat, 11 Feb 2017 01:08:35 +0000 (20:08 -0500)]
[Arm64/Unix] Remove aarch64 unsupported message (dotnet/coreclr#9508)

Commit migrated from https://github.com/dotnet/coreclr/commit/ea3b879472c2f3d06780112f0c1d9b5cf75f6fcd

7 years ago[Arm64/Unix] Fix gdbjit support (dotnet/coreclr#9512)
Steve MacLean [Sat, 11 Feb 2017 01:08:05 +0000 (20:08 -0500)]
[Arm64/Unix] Fix gdbjit support (dotnet/coreclr#9512)

Commit migrated from https://github.com/dotnet/coreclr/commit/ebe301ad19f203c0bd95d16767c7828397160b7e

7 years ago[Arm64] Add more GCROOTS logging (dotnet/coreclr#9514)
Steve MacLean [Sat, 11 Feb 2017 01:07:48 +0000 (20:07 -0500)]
[Arm64] Add more GCROOTS logging (dotnet/coreclr#9514)

Commit migrated from https://github.com/dotnet/coreclr/commit/578567c88692d6b7b10912cd9f825fdd33ac793e

7 years agoRemove always defined FEATURE_CORESYSTEM
danmosemsft [Sat, 11 Feb 2017 00:07:45 +0000 (16:07 -0800)]
Remove always defined FEATURE_CORESYSTEM

Commit migrated from https://github.com/dotnet/coreclr/commit/751771a8976f909af772e35c167bd7e3ffbe44c8

7 years agoAdd a test case for PR dotnet/coreclr#9496
Carol Eidt [Sat, 11 Feb 2017 01:05:34 +0000 (17:05 -0800)]
Add a test case for PR dotnet/coreclr#9496

Commit migrated from https://github.com/dotnet/coreclr/commit/106379c0432f1ed5320d102a5c71d220138ac702

7 years agoMerge pull request dotnet/coreclr#9491 from jkotas/NoInlining
Jan Kotas [Sat, 11 Feb 2017 00:58:48 +0000 (16:58 -0800)]
Merge pull request dotnet/coreclr#9491 from jkotas/NoInlining

Use DynamicSecurityMethod attribute to mark methods with StackCrawlMark

Commit migrated from https://github.com/dotnet/coreclr/commit/e5f2df239b546ac9ed2417506c90af222eaf1013

7 years agoMerge pull request dotnet/coreclr#9496 from CarolEidt/FixCoreFx15713
Carol Eidt [Sat, 11 Feb 2017 00:50:47 +0000 (16:50 -0800)]
Merge pull request dotnet/coreclr#9496 from CarolEidt/FixCoreFx15713

Fix System.Numerics.Vectors CoreFx test failures

Commit migrated from https://github.com/dotnet/coreclr/commit/0604f7efc549b46e24240aa5b9aaf6d41b19f21b

7 years agoFix formatting.
Pat Gavlin [Sat, 11 Feb 2017 00:47:22 +0000 (16:47 -0800)]
Fix formatting.

Commit migrated from https://github.com/dotnet/coreclr/commit/2b9f8cfddeb3d0fbcd18fae36b6ceade1d99d8b2

7 years agoMerge pull request dotnet/coreclr#9499 from jashook/arm64_dyn_block_assert
Jarret Shook [Sat, 11 Feb 2017 00:40:59 +0000 (16:40 -0800)]
Merge pull request dotnet/coreclr#9499 from jashook/arm64_dyn_block_assert

ARM64 Modify genCodeForInitBlk assert

Commit migrated from https://github.com/dotnet/coreclr/commit/735cd1ef01946eb46293f598a030eeff33fadedd

7 years agoMerge pull request dotnet/coreclr#9085 from mskvortsov/ryujit-arm32-eh
Bruce Forstall [Sat, 11 Feb 2017 00:03:42 +0000 (16:03 -0800)]
Merge pull request dotnet/coreclr#9085 from mskvortsov/ryujit-arm32-eh

[RyuJIT/ARM32] EH, switch implementation and various updates

Commit migrated from https://github.com/dotnet/coreclr/commit/5c2459a1b4c31ca467d9a50fe76e37a4412bc872

7 years ago[Arm64/Unix] Add list of known arm64 fails
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Fri, 27 Jan 2017 19:41:44 +0000 (19:41 +0000)]
[Arm64/Unix] Add list of known arm64 fails

Commit migrated from https://github.com/dotnet/coreclr/commit/8f61dd7a2ce5fcc98ec78c5e6a0bc93289fff24a

7 years agoARM64 Modify genCodeForInitBlk assert
jashook [Fri, 10 Feb 2017 22:28:51 +0000 (14:28 -0800)]
ARM64 Modify genCodeForInitBlk assert

Assert in codegenarm64 was incorrect for the GT_STORE_DYN_BLK oper.
If it is that oper then there will not be a temp reg used and instead
the size is computed and stored into REG_2. Add an assert to assert
this is done.

Commit migrated from https://github.com/dotnet/coreclr/commit/310632c37a7143f8b88811b5e4f2e82ffe1aab3e

7 years agoremove additional slash
Christopher Costa [Fri, 10 Feb 2017 22:50:40 +0000 (14:50 -0800)]
remove additional slash

Commit migrated from https://github.com/dotnet/coreclr/commit/0a85d909e62b860a2cef7f9218974ad6bda3439a

7 years agoFix the release build with OPT_CONFIG and address PR feedback.
Pat Gavlin [Fri, 10 Feb 2017 22:36:03 +0000 (14:36 -0800)]
Fix the release build with OPT_CONFIG and address PR feedback.

Commit migrated from https://github.com/dotnet/coreclr/commit/bc3280b9d6d56ada0e9c4604aa7838fcbe40a278

7 years agoFix race condition building System.Private.CoreLib and SOS.NETCore.dll
Christopher Costa [Fri, 10 Feb 2017 22:39:00 +0000 (14:39 -0800)]
Fix race condition building System.Private.CoreLib and SOS.NETCore.dll

Commit migrated from https://github.com/dotnet/coreclr/commit/00b7d15a27174689522e1dffc27f098663752d28

7 years agoCreate lsra-throughput.md
Carol Eidt [Fri, 10 Feb 2017 22:33:12 +0000 (14:33 -0800)]
Create lsra-throughput.md

Commit migrated from https://github.com/dotnet/coreclr/commit/8be736608577fb1cd0b88c0b72048955bcc38b00

7 years agoUse DynamicSecurityMethod attribute to mark methods with StackCrawlMark
Jan Kotas [Fri, 10 Feb 2017 09:10:23 +0000 (01:10 -0800)]
Use DynamicSecurityMethod attribute to mark methods with StackCrawlMark

CoreCLR does not have CAS, and so we can conveniently use it to mark methods with StackCrawlMark to
decouple it from NoInlining. The original purpose of DynamicSecurityMethod was to disable inlining
of the caller and to insert CAS security checks, so we are basically just keeping the first part.

Fixes dotnet/coreclr#8102

Commit migrated from https://github.com/dotnet/coreclr/commit/49d2d8f711286bf4ab3ffcd7b9f89a2ec80725bd

7 years agoRevert "JIT: fix confusing inline failure reason"
Jan Kotas [Fri, 10 Feb 2017 18:59:33 +0000 (10:59 -0800)]
Revert "JIT: fix confusing inline failure reason"

This reverts commit dotnet/coreclr@0826f9dee6a8fdf8266523945708a684376b0280.

Commit migrated from https://github.com/dotnet/coreclr/commit/ab98635befe574626e9ebb65e33fec3a060b4db6