platform/core/csapi/tizenfx.git
3 years ago[NUI] Fix CA2000 Warnings for View (#2556)
zhouleonlei [Tue, 26 Jan 2021 05:18:16 +0000 (13:18 +0800)]
[NUI] Fix CA2000 Warnings for View (#2556)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoAdd API for delete widgetView (#2521)
tscholb [Tue, 26 Jan 2021 03:41:33 +0000 (12:41 +0900)]
Add API for delete widgetView (#2521)

WidgetViewManager provide API for delete widgetView instead TerminateWidget().
TerminateWidget() will be deprecated.

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA1819 : Properties should not return arrays (#2409)
AdunFang [Tue, 26 Jan 2021 03:33:52 +0000 (11:33 +0800)]
[NUI] Fix CA1819 : Properties should not return arrays (#2409)

* [NUI] Fix CA1819

* [NUI] Fix CA1819

* [NUI] Rename private member

* [NUI] Modify code by HQ's comments

* [NUI] Change the category of SuppressMessage

Co-authored-by: Fang Xiaohui <xiaohui fang>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA2000 Warnings for View (#2546)
zhouleonlei [Fri, 22 Jan 2021 04:35:36 +0000 (12:35 +0800)]
[NUI] Fix CA2000 Warnings for View (#2546)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Support selector for PixelSize in TextLabelStyle and TextEditorStyle (#2539)
Jiyun Yang [Thu, 21 Jan 2021 11:45:05 +0000 (20:45 +0900)]
[NUI] Support selector for PixelSize in TextLabelStyle and TextEditorStyle (#2539)

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix TV AmbientMode empty screen (#2538)
dongsug-song [Thu, 21 Jan 2021 10:07:38 +0000 (19:07 +0900)]
[NUI] Fix TV AmbientMode empty screen (#2538)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] respect margin and padding for relative layout (#2524)
YeongJong Lee [Thu, 21 Jan 2021 07:15:26 +0000 (16:15 +0900)]
[NUI] respect margin and padding for relative layout (#2524)

For now child's `Margin` and RelativeLayout's `Padding` work correctly.

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] remove internal child properly when child view of FlexLayout is removed (#2522)
YeongJong Lee [Thu, 21 Jan 2021 06:30:07 +0000 (15:30 +0900)]
[NUI] remove internal child properly when child view of FlexLayout is removed (#2522)

In `FlexLayout`, when we add new view, the existing view shrink.
but when removed they are in shrinked state. they should change back.

To fix this issue, this patch remove internal child(child of yoga
layout) when child view of `FlexLayout` is removed.

For now, `OnChildRemove` API will work correctly.

Thank you Aman Jeph for the report.

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] change size specification in changed callback of bindable property (#2516)
YeongJong Lee [Thu, 21 Jan 2021 06:22:09 +0000 (15:22 +0900)]
[NUI] change size specification in changed callback of bindable property (#2516)

If we change size2D by using Size2DProperty, size specification is not
changed. this patch will fix that issue.

Here is sample code:
```cs
View view = new View();
view.Size2D = new Size2D(100, 50);
Tizen.Log.Error("NUI", $"WidthSpecification : {view.WidthSpecification}, HeightSpecification : {view.HeightSpecification}");

View view2 = new View();
view2.SetValue(View.Size2DProperty, new Size2D(100, 50));
Tizen.Log.Error("NUI", $"WidthSpecification : {view2.WidthSpecification}, HeightSpecification : {view2.HeightSpecification}");
```

Before:
```
WidthSpecification : 100, HeightSpecification : 50
WidthSpecification : -2, HeightSpecification : -2
```

After:
```
WidthSpecification : 100, HeightSpecification : 50
WidthSpecification : 100, HeightSpecification : 50
```

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] add type check validation in ApplyPropertiesVisitor (#2489)
YeongJong Lee [Thu, 21 Jan 2021 06:04:44 +0000 (15:04 +0900)]
[NUI] add type check validation in ApplyPropertiesVisitor (#2489)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoRevert "[NUI] Add DeleteAccessibilityAttribute"
huiyu.eun [Thu, 21 Jan 2021 05:24:32 +0000 (14:24 +0900)]
Revert "[NUI] Add DeleteAccessibilityAttribute"

This reverts commit d6a57e870b299c228b5ac11d4d2970758906e49c.

3 years ago[NUI] Sync unmanaged or managed data type to csharp-binder (#2536)
Jiyun Yang [Thu, 21 Jan 2021 04:39:48 +0000 (13:39 +0900)]
[NUI] Sync unmanaged or managed data type to csharp-binder (#2536)

+ Remove unused code

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Add DeleteAccessibilityAttribute
huiyu.eun [Wed, 20 Jan 2021 09:17:12 +0000 (18:17 +0900)]
[NUI] Add DeleteAccessibilityAttribute

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] fix CA2000 Warning for proterty
zhouleonlei [Fri, 8 Jan 2021 06:58:16 +0000 (14:58 +0800)]
[NUI] fix CA2000 Warning for proterty

3 years ago[NUI] Overide Dispose to release native memory
huiyu.eun [Tue, 19 Jan 2021 08:45:20 +0000 (17:45 +0900)]
[NUI] Overide Dispose to release native memory

Override Dispose function
- ViewWrapperImpl
- ViewImpl
- ViewWrapper

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[MessagePort] Fix bug for getting remote value (#2554)
kilig [Tue, 26 Jan 2021 01:06:34 +0000 (10:06 +0900)]
[MessagePort] Fix bug for getting remote value (#2554)

Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years ago[NUI] Fix AccessibilityManager Event handler
Seoyeon Kim [Mon, 18 Jan 2021 09:35:49 +0000 (18:35 +0900)]
[NUI] Fix AccessibilityManager Event handler

- Changed the old-fashioned code of event handler

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI] Add View.FindChildByID() as hidden API
dongsug.song [Fri, 15 Jan 2021 07:29:05 +0000 (16:29 +0900)]
[NUI] Add View.FindChildByID() as hidden API

3 years ago[NUI] use Size2DProperty for GetNaturalSize() instead of local field (#2515)
YeongJong Lee [Thu, 14 Jan 2021 01:43:01 +0000 (10:43 +0900)]
[NUI] use Size2DProperty for GetNaturalSize() instead of local field (#2515)

Since we can take the size value using `Size2DProperty`, we don't need to
save Size2D value in local value.
It will save a bit of memory.

3 years ago[NUI] remove redundant private field in View class (#2513)
YeongJong Lee [Tue, 12 Jan 2021 03:03:19 +0000 (12:03 +0900)]
[NUI] remove redundant private field in View class (#2513)

* [NUI] remove redundant private field in View class

No logical changes.

3 years ago[NUI] remove unused measure specification size properties of View class (#2511)
YeongJong Lee [Tue, 12 Jan 2021 02:37:09 +0000 (11:37 +0900)]
[NUI] remove unused measure specification size properties of View class (#2511)

No logical changes.

3 years ago[NUI] fix a c&p error in RelativeLayout (#2510)
YeongJong Lee [Tue, 12 Jan 2021 02:31:24 +0000 (11:31 +0900)]
[NUI] fix a c&p error in RelativeLayout (#2510)

Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
3 years ago[NUI] Fix runtime exception
Dongsug Song [Mon, 11 Jan 2021 09:09:59 +0000 (18:09 +0900)]
[NUI] Fix runtime exception

3 years ago[NUI] Modify acr apis
huiyu [Mon, 28 Dec 2020 02:23:29 +0000 (11:23 +0900)]
[NUI] Modify acr apis

Signed-off-by: huiyu <huiyu.eun@samsung.com>
3 years ago[Bluetooth][Non-ACR] Fix unhandled exception in GetBondedDevice() (#2514)
dh79pyun [Tue, 12 Jan 2021 22:49:13 +0000 (07:49 +0900)]
[Bluetooth][Non-ACR] Fix unhandled exception in GetBondedDevice() (#2514)

Device is not bonded : System.NullReferenceException: Object reference not set to an instance of an object.
    at System.SpanHelpers.IndexOf(Byte& searchSpace, Byte value, Int32 length)
    at System.String.Ctor(SByte* value)
    at System.Runtime.InteropServices.Marshal.PtrToStringAnsi(IntPtr ptr)
    at Tizen.Network.Bluetooth.BluetoothUtils.ConvertStructToDeviceClass(BluetoothDeviceStruct device)
    at Tizen.Network.Bluetooth.BluetoothAdapterImpl.GetBondedDevice(String address)
    at Tizen.Network.Bluetooth.BluetoothAdapter.GetBondedDevice(String address)

Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
3 years ago[Build] Add coverage.sh script (#2519)
WonYoung Choi [Tue, 12 Jan 2021 07:30:24 +0000 (16:30 +0900)]
[Build] Add coverage.sh script (#2519)

Co-authored-by: TizenAPI-Bot <37820187+TizenAPI-Bot@users.noreply.github.com>
3 years agoRevert "[NUI] Fix CA2000 warning issues of View and ViewImpl."
Jiyun Yang [Thu, 7 Jan 2021 12:07:13 +0000 (21:07 +0900)]
Revert "[NUI] Fix CA2000 warning issues of View and ViewImpl."

This reverts commit 424bdae58a6f7d71ad3e531fd157a92d513255c4.

3 years agoRevert "[NUI] Fix CA2000 Warnings"
Jiyun Yang [Thu, 7 Jan 2021 12:40:19 +0000 (21:40 +0900)]
Revert "[NUI] Fix CA2000 Warnings"

This reverts commit 92f2d926ec881a0ccacd447401526dcd19cf01b0.

3 years ago[NUI] Fix build warning CA1712
Bowon Ryu [Mon, 4 Jan 2021 09:52:34 +0000 (18:52 +0900)]
[NUI] Fix build warning CA1712

CA1712: Do not prefix enum values with type name

The name can not be changed becuase this enum is publicly open.
Suppress warning messages.

3 years ago[NUI] Remove since_tizen tag for internal APIs
Jiyun Yang [Tue, 5 Jan 2021 02:19:06 +0000 (11:19 +0900)]
[NUI] Remove since_tizen tag for internal APIs

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Update description of Transition classes
Jiyun Yang [Tue, 5 Jan 2021 09:03:06 +0000 (18:03 +0900)]
[NUI] Update description of Transition classes

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA2000 Warnings
zhouleonlei [Wed, 6 Jan 2021 06:51:21 +0000 (14:51 +0800)]
[NUI] Fix CA2000 Warnings

3 years ago[NUI] Fix CA2000 issues for Render Shadow (#2493)
zhouleonlei [Thu, 7 Jan 2021 09:39:49 +0000 (17:39 +0800)]
[NUI] Fix CA2000 issues for Render Shadow (#2493)

* [NUI] Fix CA2000 issues for Render Shadow

* [NUI] Fix CA2000 for Render

3 years ago[NUI] Fix the incorrect parameter for XamlBinding
Seoyeon Kim [Thu, 7 Jan 2021 07:40:05 +0000 (16:40 +0900)]
[NUI] Fix the incorrect parameter for XamlBinding

 - Change to `SizeTypeConverter` for the correct compiledVersion

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI] Fix CA2000 warning issues of View and ViewImpl.
guowei.wang [Wed, 6 Jan 2021 10:10:32 +0000 (18:10 +0800)]
[NUI] Fix CA2000 warning issues of View and ViewImpl.

3 years ago[NUI] Update AccessibilitySample for readability (#2500)
Seoyeon2Kim [Thu, 7 Jan 2021 04:33:49 +0000 (13:33 +0900)]
[NUI] Update AccessibilitySample for readability (#2500)

- Updated the sample to fit the size and make it easier to read.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
3 years ago[NUI] fixed memory leak
Joogab Yun [Wed, 6 Jan 2021 16:10:25 +0000 (01:10 +0900)]
[NUI] fixed memory leak

3 years ago[NUI] Fix CA2000 issues for Visual (#2491)
zhouleonlei [Tue, 5 Jan 2021 09:03:46 +0000 (17:03 +0800)]
[NUI] Fix CA2000 issues for Visual (#2491)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Add AppBar class (#2435)
Jaehyun Cho [Tue, 5 Jan 2021 08:44:50 +0000 (17:44 +0900)]
[NUI] Add AppBar class (#2435)

AppBar shows title text and provides navigation and action functions on
Page.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
3 years ago[NUI] remove unnecessary using in Size2D.cs (#2487)
YeongJong Lee [Tue, 5 Jan 2021 07:09:17 +0000 (16:09 +0900)]
[NUI] remove unnecessary using in Size2D.cs (#2487)

Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix null exception in Loading and improve code (#2478)
Jiyun Yang [Mon, 4 Jan 2021 07:15:09 +0000 (16:15 +0900)]
[NUI] Fix null exception in Loading and improve code (#2478)

This fixes null pointer exception in Loading when running following sample,

```C#
var loading1 = new Loading(new LoadingStyle
{
    Size = new Size(100, 100),
    Position = new Position(0, 100),
    Images  = imageArray
});
```

Plus, this patch removes redundant behaviors when applying a style to a Loading component.
All components copies a default style to the component properties when it is created.
When copying a style, all bindable properties defined in the style class that is not null value are copied to the component properties,
so it is important to keep null value for the property that is not set by user.
Hence this patch removes code that allocates empty list object in the getter of ImageList bindable property.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
3 years ago[NUI] Fix build error and large text size issue
송동석/Tizen Platform Lab(SR)/Principal Engineer/삼성전자 [Wed, 30 Dec 2020 06:32:46 +0000 (15:32 +0900)]
[NUI] Fix build error and large text size issue

3 years ago[NUI] Fix CA2000 issues for Visuals (#2473)
zhouleonlei [Tue, 29 Dec 2020 09:45:56 +0000 (17:45 +0800)]
[NUI] Fix CA2000 issues for Visuals (#2473)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix CA1716 build warning
Moonhee, Choi [Tue, 29 Dec 2020 06:51:55 +0000 (15:51 +0900)]
[NUI] Fix CA1716 build warning

3 years ago[NUI] remove needless null validation in LayoutItem.SetFrame (#2469)
YeongJong Lee [Tue, 29 Dec 2020 02:54:02 +0000 (11:54 +0900)]
[NUI] remove needless null validation in LayoutItem.SetFrame (#2469)

3 years ago[NUI] Fix CA2000 issues in Model3dView and RenderTask.
guowei.wang [Fri, 25 Dec 2020 06:03:03 +0000 (14:03 +0800)]
[NUI] Fix CA2000 issues in Model3dView and RenderTask.

3 years agoUse correct calling convention
Wander Lairson Costa [Tue, 1 Dec 2020 18:05:25 +0000 (15:05 -0300)]
Use correct calling convention

Some callback and functions from DALi expected the calling convention to
be cdecl, this commit makes it right. The amd64 platforms this is rarely
a problem since arguments are passed through CPU registers, but in x86
this leads to stack corruption.

3 years ago[NUI] Modify CA2000 Warnings for TextVisual and VisualAnimator
zhouleonlei [Thu, 24 Dec 2020 09:23:44 +0000 (17:23 +0800)]
[NUI] Modify CA2000 Warnings for TextVisual and VisualAnimator

3 years ago[NUI] Add ImageList property (#2449)
huiyueun [Fri, 25 Dec 2020 03:03:34 +0000 (12:03 +0900)]
[NUI] Add ImageList property (#2449)

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
3 years ago[NUI] Fix crash issue in PaginationStyle. (#2448)
guowei.wang [Thu, 24 Dec 2020 09:26:08 +0000 (17:26 +0800)]
[NUI] Fix crash issue in PaginationStyle. (#2448)

3 years agoRevert "[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope...
Jiyun Yang [Thu, 24 Dec 2020 08:47:35 +0000 (17:47 +0900)]
Revert "[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)" (#2463)

This reverts commit cff3fd4d9fd6fd461263e742e296a5397e9563a0.

This causes segfault to dispose styles after passing them through `AddStyleWithoutClone` method.
Because the theme object holds the passed style objects.
Which means the responsibility to dispose the object is transferred to the theme object.

In this case, we can suppress this warning.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000

Instead revert the patch, it suppressed CA2000 warning.

3 years ago[NUI] Modify CA2000 Warnings for VisualMap (#2460)
zhouleonlei [Thu, 24 Dec 2020 06:25:15 +0000 (14:25 +0800)]
[NUI] Modify CA2000 Warnings for VisualMap (#2460)

3 years ago[NUI] Override Dispose() in Navigator
Jaehyun Cho [Tue, 22 Dec 2020 12:31:09 +0000 (21:31 +0900)]
[NUI] Override Dispose() in Navigator

Pages pushed into Navigator are disposed if Navigator is disposed.

To override Dispose() in Navigator, two dictionaries are required to
remove disposed navigator from dictionary.

TODO: Needs to consider how to remove disposed window from dictionary.

3 years agoRevert "[NUI] Modify CA2000 warnings for Visual"
Jiyun Yang [Thu, 24 Dec 2020 03:02:53 +0000 (12:02 +0900)]
Revert "[NUI] Modify CA2000 warnings for Visual"

This reverts commit afa5fef90e7c8b370fc0e505d2420a7a87083344.

3 years ago[NUI] Add Obsolete Attribute for ControlStates enum
Yeongjong Lee [Wed, 23 Dec 2020 02:25:58 +0000 (11:25 +0900)]
[NUI] Add Obsolete Attribute for ControlStates enum

`ControlStates` enum will be removed in API10.

We can use `ControlState` class instead.

3 years ago[NUI] Modify CA2000 warnings for Visual
zhouleonlei [Wed, 23 Dec 2020 07:55:21 +0000 (15:55 +0800)]
[NUI] Modify CA2000 warnings for Visual

3 years ago[NUI] Adds StopBehavior and CurrentFrame properties to the AnimatedImageView
Seungho Baek [Wed, 23 Dec 2020 14:57:17 +0000 (23:57 +0900)]
[NUI] Adds StopBehavior and CurrentFrame properties to the AnimatedImageView

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
3 years ago[NUI] Fix the behavior as for View.BackgroundImage to be cleared when null set
Dongsug Song [Thu, 24 Dec 2020 01:35:19 +0000 (10:35 +0900)]
[NUI] Fix the behavior as for View.BackgroundImage to be cleared when null set

- Change the behavior of View.BackgroundImage property from API9
- https://code.sec.samsung.net/jira/browse/GRE-2078

3 years ago[NUI] Add internal and hidden APIs which are currently used
Dongsug Song [Tue, 22 Dec 2020 11:18:22 +0000 (20:18 +0900)]
[NUI] Add internal and hidden APIs which are currently used

- Add internal and hidden APIs which are currently used. otherwise removing them causes build errors.
- Let users to use proper APIs by deleting these deprecated APIs
- User can be informed that these are deprecated and should not be used by warning messeges during build time.

3 years ago[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)
guowei.wang [Tue, 22 Dec 2020 10:33:09 +0000 (18:33 +0800)]
[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)

3 years ago[NUI] Fix CA2002
Daekwang Ryu [Thu, 17 Dec 2020 06:52:14 +0000 (15:52 +0900)]
[NUI] Fix CA2002

Do not lock on objects with weak identity
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2002

3 years agoModify dispose issue for window
zhouleonlei [Tue, 22 Dec 2020 10:13:21 +0000 (18:13 +0800)]
Modify dispose issue for window

3 years ago[NUI] Fix CA2000 warning for Window
zhouleonlei [Tue, 22 Dec 2020 06:24:01 +0000 (14:24 +0800)]
[NUI] Fix CA2000 warning for Window

3 years ago[NUI] Fix a build warning CA1717 (#2422)
Seoyeon2Kim [Wed, 23 Dec 2020 01:55:05 +0000 (10:55 +0900)]
[NUI] Fix a build warning CA1717 (#2422)

- Only FlagsAttribute enums should have plural names
 https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1717

- Some enums cannot be fixed because they're already public APIs,
 so added suppress messages for CA1717 build warning.
- Some enums are already used as hidden APIs,
 so added Obsolete tags and made a fixed version as singular name.
- Tizen.NUI.Components.ControlStates enum should be marked with the FlagsAttribute.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years agoRevert "[NUI] Rebase DevelNUI (#2507)" (#2508)
huiyueun [Mon, 11 Jan 2021 05:37:18 +0000 (14:37 +0900)]
Revert "[NUI] Rebase DevelNUI (#2507)" (#2508)

This reverts commit 48aea0ba4111a0f164f0b0eb2f686ce4f53f6401.

3 years ago[NUI] Rebase DevelNUI (#2507)
huiyueun [Mon, 11 Jan 2021 05:29:41 +0000 (14:29 +0900)]
[NUI] Rebase DevelNUI (#2507)

* [NUI] Fix a build warning CA1717 (#2422)

- Only FlagsAttribute enums should have plural names
 https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1717

- Some enums cannot be fixed because they're already public APIs,
 so added suppress messages for CA1717 build warning.
- Some enums are already used as hidden APIs,
 so added Obsolete tags and made a fixed version as singular name.
- Tizen.NUI.Components.ControlStates enum should be marked with the FlagsAttribute.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix CA2000 warning for Window

* Modify dispose issue for window

* [NUI] Fix CA2002

Do not lock on objects with weak identity
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2002

* [NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)

* [NUI] Add internal and hidden APIs which are currently used

- Add internal and hidden APIs which are currently used. otherwise removing them causes build errors.
- Let users to use proper APIs by deleting these deprecated APIs
- User can be informed that these are deprecated and should not be used by warning messeges during build time.

* [NUI] Fix the behavior as for View.BackgroundImage to be cleared when null set

- Change the behavior of View.BackgroundImage property from API9
- https://code.sec.samsung.net/jira/browse/GRE-2078

* [NUI] Adds StopBehavior and CurrentFrame properties to the AnimatedImageView

Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
* [NUI] Modify CA2000 warnings for Visual

* [NUI] Add Obsolete Attribute for ControlStates enum

`ControlStates` enum will be removed in API10.

We can use `ControlState` class instead.

* Revert "[NUI] Modify CA2000 warnings for Visual"

This reverts commit afa5fef90e7c8b370fc0e505d2420a7a87083344.

* [NUI] Override Dispose() in Navigator

Pages pushed into Navigator are disposed if Navigator is disposed.

To override Dispose() in Navigator, two dictionaries are required to
remove disposed navigator from dictionary.

TODO: Needs to consider how to remove disposed window from dictionary.

* [NUI] Modify CA2000 Warnings for VisualMap (#2460)

* Revert "[NUI] Fix CA2000 issue in DefaultTheme(Dispose object before losing scope)" (#2463)

This reverts commit cff3fd4d9fd6fd461263e742e296a5397e9563a0.

This causes segfault to dispose styles after passing them through `AddStyleWithoutClone` method.
Because the theme object holds the passed style objects.
Which means the responsibility to dispose the object is transferred to the theme object.

In this case, we can suppress this warning.
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000

Instead revert the patch, it suppressed CA2000 warning.

* [NUI] Fix crash issue in PaginationStyle. (#2448)

* [NUI] Add ImageList property (#2449)

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
* [NUI] Modify CA2000 Warnings for TextVisual and VisualAnimator

* Use correct calling convention

Some callback and functions from DALi expected the calling convention to
be cdecl, this commit makes it right. The amd64 platforms this is rarely
a problem since arguments are passed through CPU registers, but in x86
this leads to stack corruption.

* [NUI] Fix CA2000 issues in Model3dView and RenderTask.

* [NUI] remove needless null validation in LayoutItem.SetFrame (#2469)

* [NUI] Fix CA1716 build warning

* [NUI] Fix CA2000 issues for Visuals (#2473)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix build error and large text size issue

* [NUI] Fix null exception in Loading and improve code (#2478)

This fixes null pointer exception in Loading when running following sample,

```C#
var loading1 = new Loading(new LoadingStyle
{
    Size = new Size(100, 100),
    Position = new Position(0, 100),
    Images  = imageArray
});
```

Plus, this patch removes redundant behaviors when applying a style to a Loading component.
All components copies a default style to the component properties when it is created.
When copying a style, all bindable properties defined in the style class that is not null value are copied to the component properties,
so it is important to keep null value for the property that is not set by user.
Hence this patch removes code that allocates empty list object in the getter of ImageList bindable property.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
* [NUI] remove unnecessary using in Size2D.cs (#2487)

Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Add AppBar class (#2435)

AppBar shows title text and provides navigation and action functions on
Page.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
* [NUI] Fix CA2000 issues for Visual (#2491)

Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] fixed memory leak

* [NUI] Update AccessibilitySample for readability (#2500)

- Updated the sample to fit the size and make it easier to read.

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
* [NUI] Fix CA2000 warning issues of View and ViewImpl.

* [NUI] Fix the incorrect parameter for XamlBinding

 - Change to `SizeTypeConverter` for the correct compiledVersion

Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
* [NUI] Fix CA2000 issues for Render Shadow (#2493)

* [NUI] Fix CA2000 issues for Render Shadow

* [NUI] Fix CA2000 for Render

* [NUI] Fix CA2000 Warnings

* [NUI] Update description of Transition classes

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Remove since_tizen tag for internal APIs

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
* [NUI] Fix build warning CA1712

CA1712: Do not prefix enum values with type name

The name can not be changed becuase this enum is publicly open.
Suppress warning messages.

* Revert "[NUI] Fix CA2000 Warnings"

This reverts commit 92f2d926ec881a0ccacd447401526dcd19cf01b0.

* Revert "[NUI] Fix CA2000 warning issues of View and ViewImpl."

This reverts commit 424bdae58a6f7d71ad3e531fd157a92d513255c4.

Co-authored-by: Seoyeon2Kim <34738918+Seoyeon2Kim@users.noreply.github.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: zhouleonlei <zhouleon.lei@samsung.com>
Co-authored-by: Daekwang Ryu <dkdk.ryu@samsung.com>
Co-authored-by: guowei.wang <guowei.wang@samsung.com>
Co-authored-by: Dongsug Song <dongsug.song@samsung.com>
Co-authored-by: Seungho Baek <sbsh.baek@samsung.com>
Co-authored-by: Yeongjong Lee <cleanlyj@naver.com>
Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: zhouleonlei <56956725+zhouleonlei@users.noreply.github.com>
Co-authored-by: Wander Lairson Costa <wander.lairson@gmail.com>
Co-authored-by: Moonhee, Choi <mh0310.choi@samsung.com>
Co-authored-by: Yeongjong Lee <yj34.lee@samsung.com>
Co-authored-by: Jaehyun Cho <29364140+jaehyun0cho@users.noreply.github.com>
Co-authored-by: Joogab Yun <joogab.yun@samsung.com>
Co-authored-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Co-authored-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[Bluetooth][Non-ACR] Fix BluetoothDevice.Name converting issue (#2498)
Wootak Jung [Fri, 8 Jan 2021 00:47:07 +0000 (09:47 +0900)]
[Bluetooth][Non-ACR] Fix BluetoothDevice.Name converting issue (#2498)

Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 years ago[Packagemanager] Fix registering internal event callback (#2481)
jeremy-jang [Tue, 5 Jan 2021 06:20:03 +0000 (15:20 +0900)]
[Packagemanager] Fix registering internal event callback (#2481)

Do not invoke Interop.PackageManager.PackageManagerSetEvent().
This will unset all internal callback information and this may make user cannot
listen the package event completely.

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Co-authored-by: pjh9216 <jh9216.park@samsung.com>
3 years ago[Bluetooth][Non-ACR] Fix unhandled exception in GetBondedDevices() (#2485)
dh79pyun [Mon, 4 Jan 2021 23:05:56 +0000 (08:05 +0900)]
[Bluetooth][Non-ACR] Fix unhandled exception in GetBondedDevices() (#2485)

I/DOTNET_LAUNCHER (P 2613, T 2617): Unhandled exception.
I/DOTNET_LAUNCHER (P 2613, T 2617): System.Runtime.InteropServices.COMException (0x8007007A):
The data area passed to a system call is too small.
I/DOTNET_LAUNCHER (P 2613, T 2617):  (0x8007007A)
I/DOTNET_LAUNCHER (P 2613, T 2617):    at System.StubHelpers.ValueClassMarshaler.ConvertToNative(IntPtr dst, IntPtr src,
IntPtr pMT, CleanupWorkListElement& pCleanupWorkList)
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Tizen.Network.Bluetooth.BluetoothAdapterImpl.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Tizen.Network.Bluetooth.BluetoothAdapter.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Tizen.Network.Bluetooth.Tests.BluetoothAdapterTests.GetBondedDevices_RETURN_LIST_OF_DEVICES()
in /var/lib/jenkins/jobs/CsharpTCT/TCT_6.0/api/tct-suite-vs/Tizen.Bluetooth.Manual.Tests/testcase/TSBluetoothAdapter.cs:line 435
I/DOTNET_LAUNCHER (P 2613, T 2617): Fatal error.
I/DOTNET_LAUNCHER (P 2613, T 2617): Internal CLR error. (0x80131506)
I/DOTNET_LAUNCHER (P 2613, T 2617): DLOG_ERROR_NOMSG
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Interop+Bluetooth.GetBondedDevices(BondedDeviceCallback, IntPtr)
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Tizen.Network.Bluetooth.BluetoothAdapterImpl.GetBondedDevices()
I/DOTNET_LAUNCHER (P 2613, T 2617):    at Tizen.Network.Bluetooth.BluetoothAdapter.GetBondedDevices()

Change-Id: I04a0a89d75dc973a752950c9274b80d9988a11ed
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Co-authored-by: Anupam Roy <anupam.r@samsung.com>
3 years agoRevert "[Packagemanager] Fix registering internal event callback (#2477)" (#2479)
jeremy-jang [Wed, 30 Dec 2020 07:37:12 +0000 (16:37 +0900)]
Revert "[Packagemanager] Fix registering internal event callback (#2477)" (#2479)

This reverts commit 32bcccffca94e9f7a55d316a78b6273730e56371.

3 years ago[Packagemanager] Fix registering internal event callback (#2477)
jeremy-jang [Wed, 30 Dec 2020 06:48:30 +0000 (15:48 +0900)]
[Packagemanager] Fix registering internal event callback (#2477)

Do not reset internal event callback. This can cause unexpected result
when user add event handler during package installation.
(user may not be able to listen the package event completely.)

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years ago[System] Add internal APIs for power off and reboot (#2472)
Lee Chang Joo [Tue, 29 Dec 2020 07:42:25 +0000 (16:42 +0900)]
[System] Add internal APIs for power off and reboot (#2472)

Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
3 years ago[NUI] make RelativeLayout public
Yeongjong Lee [Tue, 15 Dec 2020 08:25:44 +0000 (17:25 +0900)]
[NUI] make RelativeLayout public

 - ACR: https://code.sec.samsung.net/jira/browse/TCSACR-392

3 years ago[NUI] Fix ScrollBar Unparent bug
huiyu.eun [Tue, 22 Dec 2020 07:23:48 +0000 (16:23 +0900)]
[NUI] Fix ScrollBar Unparent bug

ScrollBar.Unparent() is not working.

ScrollBar.Unparent() -> ScrollableBase.Remove(view)
Remove() of ScrollableBase is overridden to be removed based on ContentContainer.

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Fix wrong thumb position in Scrollbar.
guowei.wang [Mon, 21 Dec 2020 06:52:54 +0000 (14:52 +0800)]
[NUI] Fix wrong thumb position in Scrollbar.

3 years ago[NUI] Fix RadioButton not to invoke duplicate SelectedChanged (#2115)
Jaehyun Cho [Tue, 22 Dec 2020 06:18:50 +0000 (15:18 +0900)]
[NUI] Fix RadioButton not to invoke duplicate SelectedChanged (#2115)

RadioButton does not change its state to unselected if button or key is
unpressed while its state is selected.

Previously, RadioButton invoked duplicate SelectedChanged if button or
key is unpressed while its state is selected.

Now, RadioButton does not invoke duplicate SelectedChanged if button or
key is unpressed while its state is selected.

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Co-authored-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix build errors for NUISample
zhouleonlei [Tue, 22 Dec 2020 01:45:18 +0000 (09:45 +0800)]
[NUI] Fix build errors for NUISample

3 years ago[NUI]Fix build warning[CA1001]
huiyu.eun [Tue, 22 Dec 2020 03:46:26 +0000 (12:46 +0900)]
[NUI]Fix build warning[CA1001]

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1001
CA1001: Types that own disposable fields should be disposable

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Fix view style initialization bug (#2442)
Jiyun Yang [Tue, 22 Dec 2020 05:00:38 +0000 (14:00 +0900)]
[NUI] Fix view style initialization bug (#2442)

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
Co-authored-by: YeongJong Lee <cleanlyj@naver.com>
3 years ago[NUI] rewrite theme resource (#2405)
YeongJong Lee [Tue, 22 Dec 2020 04:00:32 +0000 (13:00 +0900)]
[NUI] rewrite theme resource (#2405)

Theme resources would only be updated by Tizen Theme Manager.
So, this patch remove xaml support for theme resources.

3 years ago[NUI] Version update (nui2206)
Dongsug Song [Mon, 21 Dec 2020 11:06:33 +0000 (20:06 +0900)]
[NUI] Version update (nui2206)

3 years ago[NUI] deprecate unused FocusRequestArgs class (#2411)
YeongJong Lee [Tue, 22 Dec 2020 03:56:28 +0000 (12:56 +0900)]
[NUI] deprecate unused FocusRequestArgs class (#2411)

`FocusChangeREquested` event was removed in
https://github.com/Samsung/TizenFX/pull/903.

3 years ago[NUI] Version update (nui2205) (#2406)
dongsug-song [Tue, 15 Dec 2020 06:49:08 +0000 (15:49 +0900)]
[NUI] Version update (nui2205) (#2406)

- matched with dali2-2.0.5

3 years ago[NUI] Version update (nui2206)
Dongsug Song [Mon, 21 Dec 2020 11:06:33 +0000 (20:06 +0900)]
[NUI] Version update (nui2206)

3 years ago[NUI] Remove RegisterCallback function
huiyu.eun [Mon, 21 Dec 2020 08:16:20 +0000 (17:16 +0900)]
[NUI] Remove RegisterCallback function

stringDelegate registration is aledy called from the constructor.

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years agoUpdate ViewPublicMethods.cs
huiyueun [Mon, 21 Dec 2020 03:43:16 +0000 (12:43 +0900)]
Update ViewPublicMethods.cs

3 years ago[NUI] Add an exception when deleting a view that is not child
huiyu.eun [Mon, 21 Dec 2020 02:19:34 +0000 (11:19 +0900)]
[NUI] Add an exception when deleting a view that is not child

Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
3 years ago[NUI] Use PascalCase for private fields
zhouleonlei [Fri, 18 Dec 2020 09:06:22 +0000 (17:06 +0800)]
[NUI] Use PascalCase for private fields

3 years ago[NUI] Fix CA2000 issue for Application Builder(disposed)
zhouleonlei [Fri, 18 Dec 2020 06:35:48 +0000 (14:35 +0800)]
[NUI] Fix CA2000 issue for Application Builder(disposed)

3 years ago[NUI] Fixing the emtpy finalizers(CA1821)
Wonsik Jung [Fri, 18 Dec 2020 09:39:21 +0000 (18:39 +0900)]
[NUI] Fixing the emtpy finalizers(CA1821)

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1821

3 years ago[NUI] Initialize feedback instance only when the Feedback property is on.
Jiyun Yang [Thu, 17 Dec 2020 07:08:36 +0000 (16:08 +0900)]
[NUI] Initialize feedback instance only when the Feedback property is on.

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
3 years ago[NUI] Fix build warning (CA1032)
Wonsik Jung [Mon, 14 Dec 2020 10:57:58 +0000 (19:57 +0900)]
[NUI] Fix build warning (CA1032)

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1032

3 years ago[NUI] Fix CA2000 issues in WidgetView.
guowei.wang [Thu, 17 Dec 2020 08:25:56 +0000 (16:25 +0800)]
[NUI] Fix CA2000 issues in WidgetView.

3 years ago[NUI] Fix CA1054
Dongsug Song [Wed, 9 Dec 2020 12:46:00 +0000 (21:46 +0900)]
[NUI] Fix CA1054

- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1054
- This rule splits the parameter name into tokens based on the camel casing convention and checks whether each token equals "uri", "Uri", "urn", "Urn", "url", or "Url". If there is a match, the rule assumes that the parameter represents a uniform resource identifier (URI). A string representation of a URI is prone to parsing and encoding errors, and can lead to security vulnerabilities. If a method takes a string representation of a URI, a corresponding overload should be provided that takes an instance of the Uri class, which provides these services in a safe and secure manner.

3 years ago[NUI] Fix CS0108
Dongsug Song [Wed, 9 Dec 2020 10:04:07 +0000 (19:04 +0900)]
[NUI] Fix CS0108

3 years ago[NUI] Rename EventHandler WithReturnType to end in EventHandler
Yeongjong Lee [Tue, 15 Dec 2020 02:56:44 +0000 (11:56 +0900)]
[NUI] Rename EventHandler WithReturnType to end in EventHandler

Fixes CA1710

3 years ago[NUI] Fix CA1044
Dongsug Song [Wed, 9 Dec 2020 11:56:39 +0000 (20:56 +0900)]
[NUI] Fix CA1044

- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1044
- Get accessors provide read access to a property and set accessors provide write access. Although it is acceptable and often necessary to have a read-only property, the design guidelines prohibit the use of write-only properties. This is because letting a user set a value and then preventing the user from viewing the value does not provide any security. Also, without read access, the state of shared objects cannot be viewed, which limits their usefulness.

3 years ago[NUI] Fix CA1063
Dongsug Song [Fri, 11 Dec 2020 07:41:12 +0000 (16:41 +0900)]
[NUI] Fix CA1063

- https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1063
- Every unsealed type that declares and implements the IDisposable interface must provide its own protected virtual void Dispose(bool) method. Dispose() should call Dispose(true), and the finalizer should call Dispose(false). If you create an unsealed type that declares and implements the IDisposable interface, you must define Dispose(bool) and call it. For more information, see Clean up unmanaged resources (.NET guide) and Dispose pattern.

3 years ago[NUI] Fix build warning CA2213
Bowon Ryu [Wed, 16 Dec 2020 06:12:03 +0000 (15:12 +0900)]
[NUI] Fix build warning CA2213

CA2213: Disposable fields should be disposed

Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
3 years ago[NUI] Fix build warning CA1820
Bowon Ryu [Wed, 16 Dec 2020 05:36:27 +0000 (14:36 +0900)]
[NUI] Fix build warning CA1820

CA1820: Test for empty strings using string length

Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>