Frank Ch. Eigler [Tue, 30 Mar 2021 17:22:43 +0000 (13:22 -0400)]
debuginfod: Set child thread names via pthread_setname_np()
In order to assist problem diagnosis / monitoring, use this
gnu-flavoured pthread function to set purpose names to the various
child threads debuginfod starts. libmicrohttpd already sets this for
its threads.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Timm Bäder [Sun, 7 Mar 2021 18:02:29 +0000 (13:02 -0500)]
debuginfod-client: Don't compare a double to a long
Clang warns about this:
../../debuginfod/debuginfod-client.c:899:28: error: implicit conversion from 'long' to 'double' changes value from
9223372036854775807 to
9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]
pa = (dl > LONG_MAX ? LONG_MAX : (long)dl);
~ ^~~~~~~~
/usr/lib64/clang/10.0.1/include/limits.h:47:19: note: expanded from macro 'LONG_MAX'
^~~~~~~~~~~~
<built-in>:38:22: note: expanded from here
^~~~~~~~~~~~~~~~~~~~
Modified for jakub's observation about LONG_MAX overflow.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Piotr Drąg [Sun, 21 Feb 2021 14:33:43 +0000 (15:33 +0100)]
Update Polish translation
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
Piotr Drąg [Sun, 21 Feb 2021 13:54:46 +0000 (14:54 +0100)]
Update POTFILES.in
https://sourceware.org/bugzilla/show_bug.cgi?id=27450
Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
Timm Bäder [Wed, 17 Feb 2021 09:27:08 +0000 (10:27 +0100)]
build: Check for -Wno-packed-not-aligned support
Clang does not support this warning, so check for compiler support
before using it.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 09:27:07 +0000 (10:27 +0100)]
build: Check for -Wtrampolines support
Clang does not support -Wtrampolines, so check if the compiler supports
it before using it.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 5 Mar 2021 18:36:15 +0000 (13:36 -0500)]
debuginfod-client: Fix typo in curl feature detection
CURLINFO_CURLINFO_CONTENT_LENGTH_DOWNLOAD_T is one CURLINFO_ too much.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Mark Wielaard [Wed, 3 Mar 2021 20:40:53 +0000 (21:40 +0100)]
readelf: Sanity check verneed and verdef offsets in handle_symtab.
We are going through vna_next, vn_next and vd_next in a while loop.
Make sure that all offsets are sane. We don't want things to wrap
around so we go in cycles.
https://sourceware.org/bugzilla/show_bug.cgi?id=27501
Signed-off-by: Mark Wielaard <mark@klomp.org>
Timm Bäder [Tue, 2 Mar 2021 08:05:33 +0000 (09:05 +0100)]
elfcompress: Replace cleanup() with label
This unifies the error handling with the rest of the code base and gets
rid of a nested function.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 09:27:06 +0000 (10:27 +0100)]
build: Check for -Wimplicit-fallthrough=5 separately
GCC accepts the =5, which means it doesn't try to parse any comments
and only accepts the fallthrough attribute in code. Clang does not ever
parse any comments and always wants the fallthrough attribute anyway.
Clang also doesn't accept the =n parameter for -Wimplicit-fallthrough.
Test for =5 separately and use it if supported and fall back to just
-Wimplicit-fallthrough otherwise.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:46:05 +0000 (09:46 +0100)]
tests: Pull new_data_buf() into file scope for elfstrmerge.
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:46:04 +0000 (09:46 +0100)]
tests: Pull newsecndx() info file scope for elfstrmerge
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:45:09 +0000 (09:45 +0100)]
elfcompress: Pull get_sections() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:45:08 +0000 (09:45 +0100)]
elfcompress: Pull get_section() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:45:07 +0000 (09:45 +0100)]
elfcompress: Pull set_section() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:43:48 +0000 (09:43 +0100)]
unstrip: Remove nested next() function
This is a simple one-liner, so inline this into the few callers.
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:43:47 +0000 (09:43 +0100)]
unstrip: Pull warn() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:43:46 +0000 (09:43 +0100)]
unstrip: Inline find_unalloc_section() into only caller
Get rid of an unnecessary nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:43:45 +0000 (09:43 +0100)]
unstrip: Pull check_match() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:43:44 +0000 (09:43 +0100)]
unstrip: Pull adjust_reloc() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:42:19 +0000 (09:42 +0100)]
elflint: Pull left() in file scope
And rename it to buffer_left() to be a bit more descriptive
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Wed, 17 Feb 2021 08:42:18 +0000 (09:42 +0100)]
elflint: Pull pos() info file scope
Rename it to buffer_pos() to be a bit more descriptive and get rid of a
nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Frank Ch. Eigler [Thu, 25 Feb 2021 19:04:20 +0000 (14:04 -0500)]
debuginfod: filter webapi for bad keywords early
Prevent some unnecessary processing of user data and
keep invalid request types out of metrics.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Frank Ch. Eigler [Thu, 18 Feb 2021 00:34:09 +0000 (19:34 -0500)]
testsuite: run-debuginfod-find.sh: Fix grooming test indeterminacy
We were looking at a less-than-ideal metric to check the effects
of grooming on the database. It turns out there is a counter
just for removed files/archives, which will have the same value
regardless of the presence of other test configurations.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Frank Ch. Eigler [Wed, 17 Feb 2021 20:20:25 +0000 (15:20 -0500)]
NEWS: add a debuginfod blurb re. bsdtar
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Frank Ch. Eigler [Wed, 17 Feb 2021 20:38:43 +0000 (15:38 -0500)]
testsuite: run-debuginfod-find.sh: Be more verbose on failure
To help diagnose timing glitches in debuginfod testing, print more
diagnostics on a metric-timeout failure.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Mark Wielaard [Fri, 12 Feb 2021 15:42:44 +0000 (16:42 +0100)]
readelf: Type DIE offset is from start of CU.
While inspecting some type units I noticed the type offset seemed off.
We were printing the offset as is, but it should include the offset of
the unit. There was actually a testcase for this, run-readelf-types.sh
but that had the same bug in the expected output. Fixed both.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Mark Wielaard [Fri, 12 Feb 2021 15:28:50 +0000 (16:28 +0100)]
readelf, libdw: blocks aren't expressions for DWARF version 4
For DWARF version 4 or higher a block form really encodes a block,
not an expression location. Also constant offsets can be expressed
as DW_FORM_implicit_const in DWARF version 5.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Frank Ch. Eigler [Sun, 14 Feb 2021 21:02:05 +0000 (16:02 -0500)]
PR27413: use bsdtar to unpack deb-related formats
dpkg-deb has been reported to be fragile when running under
debuginfod, whereas bsdtar (libarchive) is happy with all these
flavors of files. Switch to a bsdtar based pipeline, now
equipped with an escaped glob pattern that adapts to a variety
of interior data.tar* compression formats.
No testsuite impact. .ipk format tested with some random openwrt and
kino-extension binaries found on the net. Some of these are built
with out buildid, and hardly any with debuginfo, but whatever, bsdtar
and elfutils extract whatever info is there.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
Alexander Miller via Elfutils-devel [Sun, 7 Feb 2021 15:48:17 +0000 (16:48 +0100)]
tests: Quote make variables in TESTS_ENVIRONMENT
Commit
eb922a1b8f3a ("tests: use ${CC} instead of 'gcc' in tests")
exports ${CC} into the test environment, but doesn't quote the
value for the assignment. That doesn't work properly if the value
contains whitespace. In a multilib/biarch environment however, it's
common to set CC="gcc -m32" or similar. That causes tests to print
error messages: "/bin/sh: line 2: -m32: command not found".
Fix that by adding quotes around all make variables (not just $CC)
used in setting up TESTS_ENVIRONMENT.
Signed-off-by: Alexander Miller <alex.miller@gmx.de>
Mark Wielaard [Fri, 12 Feb 2021 15:36:04 +0000 (16:36 +0100)]
elfutils.spec.in: Escape %%check in comment.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Érico Rolim [Tue, 9 Feb 2021 00:56:50 +0000 (19:56 -0500)]
tests/run-debuginfod-find.sh: skip test if cpio isn't available.
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
Frank Ch. Eigler [Sat, 6 Feb 2021 01:18:39 +0000 (20:18 -0500)]
NEWS: add one more debuginfod brag
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Mark Wielaard [Fri, 5 Feb 2021 21:55:10 +0000 (22:55 +0100)]
Prepare for 0.183
Set version to 0.183
Update NEWS and elfutils.spec.in.
Set copyright year in configure.ac and printversion.
Regenerate po/*.po files.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Érico Rolim [Fri, 5 Feb 2021 17:52:06 +0000 (14:52 -0300)]
backends/ppc_initreg.c: include <asm/ptrace.h>.
Necessary on musl for struct pt_regs definition, doesn't affect the
build on glibc, since <sys/user.h> includes the same header.
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
Timm Bäder [Wed, 3 Feb 2021 14:44:46 +0000 (15:44 +0100)]
ar: Pull should_truncate_fname() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Frank Ch. Eigler [Fri, 5 Feb 2021 01:31:56 +0000 (20:31 -0500)]
PR27092: debuginfod low-memory handling
A couple of closely related pieces of work allow more early warning
about low storage/memory conditions:
- New prometheus metrics to track filesystem freespace, and more
details about some errors.
- Frequent checking of $TMPDIR freespace, to trigger fdcache
emergency flushes.
- Switch to floating point prometheus metrics, to communicate
fractions - and short time intervals - accurately.
- Fix startup-time pthread-creation error handling.
Testing is smoke-test-level only as it is hard to create
free-space-limited $TMPDIRs. Locally tested against tiny through
medium tmpfs filesystems, with or without sqlite db also there. Shows
a pleasant stream of diagnostics and metrics during shortage but
generally does not fail outright. However, catching an actual
libstdc++- or kernel-level OOM is beyond our ken.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Frank Ch. Eigler [Tue, 2 Feb 2021 21:49:19 +0000 (16:49 -0500)]
PR27323 debuginfod: improve query concurrency with grooming
Start using a second sqlite3 database connection for webapi query
servicing. This allows much better concurrency when long-running
grooming operations are in progress.
No testsuite impact. Grooming times are too short to try to hit with
concurrent requests. OTOH the existing tests did show some
interesting regressions that needed fixing, like needing not to
dual-wield db and dbq when doing rpm-dwz-related lookups from during
scanning, and the way in which corrupted databases are reported.
These needed some automated invocations of gdb on the running
debuginfod binaries that just failed their testing, for in-situ
debugging.
Hand-tested for function on a huge 20GB index file. Allowed webapi
queries to be run throughout random points of the grooming process,
including especially the long count(*) report loops before & after.
Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
Timm Bäder [Tue, 2 Feb 2021 10:23:24 +0000 (11:23 +0100)]
readelf: Remove show_op_index variable
advance_pc() uses show_op_index to save whether the current op_index is
> 0 OR the new op_index is > 0.
The new op index is calculated via
new_op_index = (op_index + op_advance) % max_ops_per_instr;
since all of the variables involved are unsigned,
new_op_index >= op_index is always true.
So...
if op_index > 0, then new_op_index > 0
if op_index == 0, then new_op_index >= 0
and if the new_op_index is > 0, then the old one was as well.
In any case, we only need to check the new_op_index, since show_op_index
used to OR the two comparisons.
In other words:
op_index > 0 | new_op_index > 0 || show_op_index
------------------------------------------------
true true true
false true true
true false true xx
false false false
... but since the third line (marked with xx) is not possible,
the table becomes:
op_index > 0 | new_op_index > 0 || show_op_index
------------------------------------------------
true true true
false true true
false false false
... and show_op_index is equal to (new_op_index > 0).
So, remove the show_op_index variable and simply replace it by comparing
the new op_index > 0.
Érico Rolim [Tue, 2 Feb 2021 00:16:56 +0000 (21:16 -0300)]
libdwfl: use GNU strerror_r only when available.
Some C libraries don't provide the GNU version of strerror_r, only the
XSI-compliant one. We use the GNU version when available, since it fits
the code better, and otherwise use the XSI-compliant one.
https://sourceware.org/bugzilla/show_bug.cgi?id=21010
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
Sergei Trofimovich via Elfutils-devel [Sun, 31 Jan 2021 15:49:13 +0000 (15:49 +0000)]
tests: use ${CC} instead of 'gcc' in tests
To better support cross-compilation Gentoo provides a way
to configure system without 'gcc' binary and only provide
tool-prefixed tools, like 'x86_64-pc-linux-gnu-gcc'.
The packages are built as ./configure --host=x86_64-pc-linux-gnu.
In https://bugs.gentoo.org/718872 Agostino Sarubbo found
a few test failures that use hardcoded 'gcc' instead of
expected ${CC}. The change propagates detected ${CC} at
configure time to test scripts.
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Timm Bäder [Fri, 8 Jan 2021 08:16:32 +0000 (09:16 +0100)]
readelf: Pull regname() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:16:31 +0000 (09:16 +0100)]
readelf: Pull left() info file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:16:30 +0000 (09:16 +0100)]
readelf: Pull same_set() info file scope
Get rid of a nested function this way
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:16:29 +0000 (09:16 +0100)]
readelf: Pull add_dump_section() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:13:28 +0000 (09:13 +0100)]
arlib-argp: Pull text_for_default() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:13:26 +0000 (09:13 +0100)]
zstrptr: Pull print_string() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:13:25 +0000 (09:13 +0100)]
addr2line: Pull show_note() and show_int() in file scope
Get rid of the nested functions
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:09:56 +0000 (09:09 +0100)]
elf-from-memory: Refactor to get rid of nested function
Try to unify the 32/64 bit code paths and get rid of the nested
handle_segment() this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:09:55 +0000 (09:09 +0100)]
elf-from-memory: Restructure code to get rid of nested handle_segment()
Use one loop for both 32 and 64 bit case. This allows for only one call
site of the old handle_segment(), which we can then inline into the for
loop.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:04:49 +0000 (09:04 +0100)]
strip: Remove no_symtab_updates() function
The no_symtab_updates() function was being called at the beginning of
all case labels in this switch, so we can just call it once before the
switch. Then it only has one call-site, so inline this short function
there.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:04:48 +0000 (09:04 +0100)]
strip: Pull update_section_size() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:04:47 +0000 (09:04 +0100)]
strip: Pull relocate() info file scope
Pull relocate() info file scope and get rid of a nested function this
way. Refactor remove_debug_relocations() to minimize the parameters we
need to pass to relocate().
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Fri, 8 Jan 2021 08:04:46 +0000 (09:04 +0100)]
strip: Replace nested check_preserved function with loop
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Mark Wielaard [Tue, 12 Jan 2021 10:35:10 +0000 (11:35 +0100)]
elflint: Recognize SHF_GNU_RETAIN as extra section flag.
SHF_GNU_RETAIN is like SHF_LINK_ORDER it can appear on any section
and should be ignored by elflint. Add all such flags to a new
EXTRA_SHFLAGS and use it consistently in check_sections.
https://sourceware.org/bugzilla/show_bug.cgi?id=27134
Signed-off-by: Mark Wielaard <mark@klomp.org>
Dmitry V. Levin [Tue, 12 Jan 2021 08:00:00 +0000 (08:00 +0000)]
Add coverage target
Implement a target for capturing code coverage using lcov.
It is available when elfutils is configured using --enable-gcov.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode --enable-gcov &&
make && make check && make coverage
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Sergei Trofimovich [Thu, 31 Dec 2020 12:11:34 +0000 (12:11 +0000)]
src/elflint.c: add debug print for GNU_RETAIN and others
Signed-off-by: Mark Wielaard <mark@klomp.org>
Sergei Trofimovich [Thu, 31 Dec 2020 12:11:42 +0000 (12:11 +0000)]
src/elflint.c: fix printing of unknown flags
before the change section_flags_string() ignored unknown section
flags: snprintf() did write numeric value into buffer, but
"*cp = '\0'" negated the effect.
The change advances the 'cp' pointer'.
While at it add a '|' separator between known and unknown flags.
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Érico Rolim [Wed, 16 Dec 2020 22:30:12 +0000 (19:30 -0300)]
src/readelf: use qsort instead of qsort_r.
This program is single threaded, so using qsort with a global variable
isn't a danger. The interface for qsort_r isn't standardized (and
diverges between glibc and FreeBSD, for example), which makes usage of
qsort, where possible, preferrable.
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
Dmitry V. Levin [Sun, 20 Dec 2020 08:00:00 +0000 (08:00 +0000)]
Split the top level .gitignore file
Move subdirectory parts of the top level .gitignore into appropriate
subdirectories. This would be consistent with ChangeLog files,
currently one has to update the top level ChangeLog file when
the top level .gitignore file is changed in a way that affects
a specific subdirectory only.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sun, 20 Dec 2020 08:00:00 +0000 (08:00 +0000)]
.gitignore: update
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Érico Rolim [Wed, 16 Dec 2020 18:56:14 +0000 (15:56 -0300)]
libcpu: linking i386_gendis requires obstack.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Mark Wielaard [Sat, 12 Dec 2020 22:36:15 +0000 (23:36 +0100)]
Handle SHF_GNU_RETAIN in eu-readelf and eu-elflint.
readelf -S now shows 'R' when SHF_GNU_RETAIN is set.
elflint accepts SHF_GNU_RETAIN when set on section in --gnu mode.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Mark Wielaard [Sat, 12 Dec 2020 19:48:40 +0000 (20:48 +0100)]
libelf: Sync elf.h from glibc.
Adds SHF_GNU_RETAIN.
Signed-off-by: Mark Wielaard <mark@klomp.org>
Dmitry V. Levin [Tue, 15 Dec 2020 08:00:00 +0000 (08:00 +0000)]
Modernize gettext infrastructure
Switch to use AM_GNU_GETTEXT, AM_GNU_GETTEXT_VERSION, and
AM_GNU_GETTEXT_REQUIRE_VERSION, this allows to stop bundling gettext
infrastructure files and let autoreconf invoke autopoint which will set
the gettext infrastructure up.
Use this opportunity to create separate .gitignore files for m4/ and po/
directories.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 16 Dec 2020 08:00:00 +0000 (08:00 +0000)]
src: consistently use _(Str) instead of gettext(Str)
Make use of the _(Str) macro provided by <config.h>.
The change was made automatically using the following command:
$ git grep -l '\<gettext *(' src |xargs sed -i 's/\<gettext *(/_(/g'
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 16 Dec 2020 08:00:00 +0000 (08:00 +0000)]
libcpu: consistently use _(Str) instead of gettext(Str)
eu-config.h defines _(Str) to dgettext ("elfutils", Str) instead of
a simple gettext (Str) for a reason: the library might be indirectly
used by clients that called bindtextdomain with a domain different
from "elfutils".
The change was made automatically using the following command:
$ git grep -l '\<gettext *(' libcpu |xargs sed -i 's/\<gettext *(/_(/g'
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 16 Dec 2020 08:00:00 +0000 (08:00 +0000)]
lib: consistently use _(Str) instead of gettext(Str)
eu-config.h defines _(Str) to dgettext ("elfutils", Str) instead of
a simple gettext (Str) for a reason: the library might be indirectly
used by clients that called bindtextdomain with a domain different
from "elfutils".
The change was made automatically using the following command:
$ git grep -l '\<gettext *(' lib |xargs sed -i 's/\<gettext *(/_(/g'
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 16 Dec 2020 08:00:00 +0000 (08:00 +0000)]
Consistently define _(Str) using dgettext ("elfutils", Str)
Move the definition of _(Str) macro to lib/eu-config.h which already
provides a definition of N_(Str) macro. Since lib/eu-config.h is
appended to config.h, it is included into every compilation unit
and therefore both macros are now universally available.
Remove all other definitions of N_(Str) and _(Str) macros from other files
to avoid conflicts and redundancies.
The next step is to replace all uses of gettext(Str) with _(Str).
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Tue, 15 Dec 2020 08:00:00 +0000 (08:00 +0000)]
libebl: consistently use _(Str) instead of gettext(Str)
libeblP.h defines _(Str) to dgettext ("elfutils", Str) instead of
a simple gettext (Str) for a reason: the library might be indirectly
used by clients that called bindtextdomain with a domain different
from "elfutils".
The change was made automatically using the following command:
$ git grep -l '\<gettext *(' libebl |xargs sed -i 's/\<gettext *(/_(/g'
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Mark Wielaard [Wed, 16 Dec 2020 09:57:22 +0000 (10:57 +0100)]
libelf: Make sure we have at least a full ELF header available.
When elf_memory is called we could get a slightly too small image
that doesn't contain a full ELF header (but does contain at least
the e_ident values). Require the full header before even validating
the rest of the ELF header fields.
https://sourceware.org/bugzilla/show_bug.cgi?id=27076
Signed-off-by: Mark Wielaard <mark@klomp.org>
Mark Wielaard [Tue, 15 Dec 2020 20:49:43 +0000 (21:49 +0100)]
elflint: Always print symbol name (if known) in error messages.
Adding the symbol name associated with the symbol index number
makes the error messages a little bit more useful. We used to say:
section [59] '.symtab': symbol 9: st_value out of bounds
But now says:
section [59] '.symtab': symbol 9 (.annobin_size.c.hot): st_value out of bounds
Signed-off-by: Mark Wielaard <mark@klomp.org>
Dmitry V. Levin [Tue, 15 Dec 2020 20:56:37 +0000 (23:56 +0300)]
po: remove empty translation files
Remove translation files that do not contain any translation strings,
not even a single fuzzy one. These files are also unused because they
are not listed in the LINGUAS file.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Tue, 15 Dec 2020 14:40:38 +0000 (17:40 +0300)]
m4: remove unneeded Makefile.am
m4 files do not have to listed in EXTRA_DIST, in fact,
biarch.m4 has not been listed since its very beginning in 2013,
and nobody seems to have noticed so far.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Tue, 15 Dec 2020 14:40:01 +0000 (17:40 +0300)]
configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])
Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4",
that is enough for autoreconf to do the right thing.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:52:49 +0000 (19:52 +0300)]
Fix spelling typos in NEWS, NOTES, TODO, and in comments of configure.ac
accidently -> accidentally
approriate -> appropriate
depencies -> dependencies
endianess -> endianness
funtions -> functions
indeces -> indices
indentified -> identified
ist -> is
mutliple -> multiple
nessesary -> necessary
optimze -> optimize
severly -> severely
suport -> support
tranformation -> transformation
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:52:43 +0000 (19:52 +0300)]
tests: fix spelling typos in error diagnostics and comments
Cannnot -> Cannot
decriptors -> descriptors
experssions -> expressions
explit -> explicit
falg -> flag
irrelevent -> irrelevant
mininum -> minimum
outselves -> ourselves
proces -> process
versio -> version
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:52:37 +0000 (19:52 +0300)]
src: fix spelling typos in comments and ChangeLog
Indeces -> Indices
adress -> address
affort -> afford
dont' -> don't
futher -> further
higest -> highest
indeces -> indices
interate -> iterate
occured -> occurred
overlow -> overflow
sectin -> section
succesful -> successful
teminated -> terminated
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:52:26 +0000 (19:52 +0300)]
libelf: fix spelling typos in comments
Auxialiary -> Auxiliary
constucted -> constructed
desriptor -> descriptor
endianess -> endianness
responsibilty -> responsibility
sufficent -> sufficient
elf.h comes from glibc and therefore is excluded.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:51:24 +0000 (19:51 +0300)]
libdwfl: fix spelling typos in comments and ChangeLog
adresses -> addresses
boundery -> boundary
explictly -> explicitly
fo -> for
layed -> laid
partical -> particular
setion -> section
substract -> subtract
wil -> will
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:51:15 +0000 (19:51 +0300)]
libdwelf: fix spelling typos in comments
algorith -> algorithm
occured -> occurred
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:51:08 +0000 (19:51 +0300)]
libdw: fix spelling typos in comments and ChangeLog
Retieve -> Retrieve
apporiate -> appropriate
distinquish -> distinguish
dynamicly -> dynamically
indeces -> indices
lenght -> length
minium -> minimum
occured -> occurred
setion -> section
unknow -> unknown
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:50:57 +0000 (19:50 +0300)]
libcpu: fix spelling typos in comments
layed -> laid
adressing -> addressing
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:50:45 +0000 (19:50 +0300)]
libasm: fix spelling typos in comments
endianess -> endianness
setion -> section
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:50:33 +0000 (19:50 +0300)]
config: fix spelling typos in comments and %changelog
directoy -> directory
fo -> for
funtions -> functions
ist -> is
mutliple -> multiple
priviliges -> privileges
reenable -> re-enable
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:50:20 +0000 (19:50 +0300)]
backends: fix spelling typos in comments
adress -> address
sigle -> single
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 16:50:12 +0000 (19:50 +0300)]
debuginfod: fix spelling typos in error diagnostics and comments
Initalize -> Initialize
Unsucessful -> Unsuccessful
expession -> expression
incompatiblity -> incompatibility
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 01:27:37 +0000 (04:27 +0300)]
src: fix spelling typos in argp help text and error diagnostics
Since all these help text strings are marked for translation, apply the fixes
to translation strings as well, this helps to avoid translations becoming fuzzy.
lenght -> length
occured -> occurred
endianess -> endianness
reversable -> reversible
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Sat, 12 Dec 2020 01:06:00 +0000 (04:06 +0300)]
libdwelf: fix spelling typos in strings returned by dwelf_elf_e_machine_string
embeded -> embedded
Semicondutor -> Semiconductor
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Fri, 11 Dec 2020 13:01:55 +0000 (16:01 +0300)]
doc: fix spelling typos
filesytem -> filesystem
requries -> requires
hte -> the
recieve -> receive
varients -> variants
preceeded -> preceded
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Fri, 11 Dec 2020 01:43:35 +0000 (04:43 +0300)]
Remove unused tests/configure.ac
tests/configure.ac was introduced 15 years ago by commit
d7f8d0caa7a357f9f4765e5dc93255f5057eba2e. However, the ability to build
tests as a separate project was broken by the same author 4 years later
by commit
22359e265395fd2f8267190ef97f5417770e6206, if not earlier.
An attempt to run autoreconf in tests would currently fail
with the following automake error:
automake: error: cannot open < config/eu.am: No such file or directory
Apparently, nobody builds tests as a separate project for more than 10
years, so cleanup the remains of that unused and broken code.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Fri, 11 Dec 2020 00:59:40 +0000 (03:59 +0300)]
configure.ac: simplify argp check
Rewrite argp check using the same AC_SEARCH_LIBS based method used
earlier in the fts check.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Fri, 11 Dec 2020 00:59:00 +0000 (03:59 +0300)]
configure.ac: fix typo in error diagnostics
Fixes:
da855fc9c ("Support building when fts and obstack aren't part of libc")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Fri, 11 Dec 2020 00:27:24 +0000 (03:27 +0300)]
Remove unused Makefile variable GCC_INCLUDE
It appears to be unused since the first commit in the revision history.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Timm Bäder [Mon, 7 Dec 2020 11:11:06 +0000 (12:11 +0100)]
link_map: Pull read_addrs() into file scope
Get rid of a nested function this way.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Timm Bäder [Mon, 7 Dec 2020 11:11:05 +0000 (12:11 +0100)]
link_map: Pull release_buffer() into file scope
Get rid of a nested function this way. Add a memory_closure struct to
keep the functions clean.
Signed-off-by: Timm Bäder <tbaeder@redhat.com>
Dmitry V. Levin [Wed, 9 Dec 2020 23:34:55 +0000 (02:34 +0300)]
Fix automake warnings
Apparently, commit
2f02e81510946a4c8e9157ad0b72d92894b9acd7 that removed
$(EXEEXT) suffix from shared libraries was incomplete: it missed the
fact that some libraries were included into noinst_PROGRAMS, resulting
to the following automake warnings:
libasm/Makefile.am:66: warning: deprecated feature: target 'libasm.so' overrides 'libasm.so$(EXEEXT)'
libdw/Makefile.am:114: warning: deprecated feature: target 'libdw.so' overrides 'libdw.so$(EXEEXT)'
libelf/Makefile.am:116: warning: deprecated feature: target 'libelf.so' overrides 'libelf.so$(EXEEXT)'
Fix this by renaming noinst_PROGRAMS to noinst_DATA and removing no
longer needed lib{asm,dw,elf}_so_SOURCES variables and add lib{asm,dw,elf).so
to CLEANFILES.
Fixes:
2f02e8151094 ("Drop $(EXEEXT) suffix from shared libraries")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Mark Wielaard <mark@klomp.org>
Dmitry V. Levin [Wed, 9 Dec 2020 00:13:27 +0000 (03:13 +0300)]
libdwfl: switch to DEBUGINFOD_SONAME, remove libdebuginfod.so fallback
Since DEBUGINFOD_SONAME is as good as ("libdebuginfod-" VERSION ".so")
for dlopen, switch to use the name which is a part of the API.
Given that DEBUGINFOD_SONAME is always available now, remove the no longer
needed fall back to dlopen of "libdebuginfod.so".
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 9 Dec 2020 00:13:12 +0000 (03:13 +0300)]
debuginfod: create libdebuginfod.so.1 before libdebuginfod.so
This would allow to switch from "libdebuginfod-" VERSION ".so"
to DEBUGINFOD_SONAME in __libdwfl_debuginfod_init, and to remove the
fall back to dlopen of "libdebuginfod.so" which would no longer be needed.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Dmitry V. Levin [Wed, 9 Dec 2020 00:12:53 +0000 (03:12 +0300)]
debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h
Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod
clients that would like to dlopen the library in the same way as
__libdwfl_debuginfod_init does.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>