Stefan Schmidt [Tue, 5 Feb 2019 08:53:48 +0000 (09:53 +0100)]
ecore: tests: add missing include path to make ecore_audio build in distcheck
We missed the include path to the tests folder where the generated
ecore_audio_ou_test files are located. Found by our relentless TravisCI
cron job.
Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7877
Mike Blumenkrantz [Mon, 4 Feb 2019 15:04:46 +0000 (10:04 -0500)]
tests: improve efl loop test (concentric)
I forgot to spin the sub-loop, so this was previously just a test to verify
that the IDLE callback was working.
now this spins the sub-loop on the idle callback and tests the idle enter
callback to verify that the main loop is being iterated
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D7874
Mike Blumenkrantz [Mon, 4 Feb 2019 15:42:25 +0000 (10:42 -0500)]
eo: implement class overriding (+unit tests)
this enables an app or a platform to add an override for a given class,
then return a different object when that class is created. the benefit is
that a class can be internally customized by the app without needing to
modify upstream versions of that class
@feature
fix T7516
Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7702
Stefan Schmidt [Mon, 4 Feb 2019 12:10:40 +0000 (13:10 +0100)]
examples: ecore: bring back inet.h include for inet_pton()
In commit
f7c560c311d0ba0da94346e17c8b20f40a0ed152 this include has been
removed while we still need it for inet_pton() as the compliler warns us
about.
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D7873
Marcel Hollerbach [Fri, 1 Feb 2019 14:49:06 +0000 (15:49 +0100)]
build: fix macos race condition
There was the problem that evas_ector_software_buffer.eo was not arround
but required by the gl_generic engine, this fixes that by adding the
generated source and dependencies to the software_generic dependency.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7871
Mike Blumenkrantz [Fri, 1 Feb 2019 20:11:04 +0000 (15:11 -0500)]
tests: add explicit test for concentric loop usage
having multiple loops which interact is a valid use case that should be
tested to ensure functionality
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D7868
Mike Blumenkrantz [Fri, 1 Feb 2019 19:42:40 +0000 (19:42 +0000)]
tests/elm: speed up all main loop timer execution
this spins a second loop which manages a timer to trigger the canvas tick
and increase the loop timer by a fixed interval on every timer call
by increasing the loop time manually, timers such as edje animation timers
which would usually take a very long time (e.g., 0.5s) to run will instead
complete almost instantly, making tests run much faster
the second loop is necessary in this case in order to accurately provide ticks
at a consistent interval without any modifications to timing
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
Differential Revision: https://phab.enlightenment.org/D6791
Larry Lira [Fri, 1 Feb 2019 19:03:24 +0000 (14:03 -0500)]
efl_interfaces: missing interfaces prefix
Summary: efl_ui_direction_readonly.c is missing "interfaces" prefix path in .eo.c include
Reviewers: lauromoura, cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7848
Felipe Magno de Almeida [Fri, 1 Feb 2019 19:03:02 +0000 (14:03 -0500)]
eolian-mono: Provide constructor parameters based on the constructors
section of the Eo files.
Reviewers: woohyun, segfaultxavi, bu5hm4n, felipealmeida
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7789
Lauro Moura [Fri, 1 Feb 2019 18:54:35 +0000 (13:54 -0500)]
examples: Example still use IPPROTO_CTP from in.h
../src/examples/ecore/ecore_fd_handler_gnutls_example.c: In function ‘tcp_connect’:
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:93:23: error: storage size of ‘sa’ isn’t known
struct sockaddr_in sa;
^~
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:101:19: error: ‘IPPROTO_TCP’ undeclared (first use in this function)
setsockopt(sd, IPPROTO_TCP, TCP_NODELAY, (char *)&flag, sizeof(int));
^~~~~~~~~~~
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:101:19: note: each undeclared identifier is reported only once for each function it appears in
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:106:4: warning: implicit declaration of function ‘inet_pton’; did you mean ‘eina_htonl’? [-Wimplicit-function-declaration]
inet_pton(AF_INET, SERVER, &sa.sin_addr);
^~~~~~~~~
eina_htonl
../src/examples/ecore/ecore_fd_handler_gnutls_example.c:93:23: warning: unused variable ‘sa’ [-Wunused-variable]
struct sockaddr_in sa;
^~
Reviewers: vtorri, raster, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7867
Vincent Torri [Fri, 1 Feb 2019 11:04:17 +0000 (11:04 +0000)]
replace hton and ntoh family functions with ones defined in eina
Summary: This fixes especially the execution of edje_cc on Windows
Test Plan: execution of edje_cc
Reviewers: cedric, raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7834
Felipe Magno de Almeida [Fri, 1 Feb 2019 10:46:52 +0000 (10:46 +0000)]
efl-cxx: Fix compilation error when using a ptr to const any_value
Reviewers: lauromoura, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7858
Marcel Hollerbach [Fri, 1 Feb 2019 10:08:34 +0000 (11:08 +0100)]
eo: fix efl_isa to work propertly with interfaces
mro only contains special interfaces, not in general all, in order to
have a working function, while NOT having a bad performance. In order to
achive that we just copy the code that is done on efl_isa for a object.
which is a linear walk of a list
ref D7857
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7860
Jihoon Kim [Fri, 1 Feb 2019 07:44:57 +0000 (16:44 +0900)]
ecore_imf: fix wrong sample code
Change-Id: Iad016ed76468cc39ac63c0c28df496f8150e8546
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jaehyun Cho [Fri, 1 Feb 2019 06:17:26 +0000 (15:17 +0900)]
Revert "evas: make efl_canvas_animation abstract"
Efl.Canvas.Animation class can be used for custom animation with
Efl.Player class' event callbacks as follows.
Example code:
void _anim_running_cb(void *data, const Efl_Event *event)
{
//Do custom animation
}
{
Eo *anim = efl_add(EFL_CANVAS_ANIMATION_CLASS, win);
Eo *player = efl_add(EFL_CANVAS_ANIMATION_PLAYER_CLASS,
efl_animation_player_animation_set(efl_added,
anim));
efl_event_callback_add(player, EFL_ANIMATION_PLAYER_EVENT_RUNNING,
_anim_running_cb, NULL);
}
As a result, Efl.Canvas.Animation is required to be a regular class
instead of an abstract class.
This reverts commit
ea9ff9f547b54255d36973da8e8ba378c5ad2684.
WooHyun Jung [Fri, 1 Feb 2019 02:28:42 +0000 (11:28 +0900)]
efl_ui_win_part: remove unused interface
Summary:
Efl.Gfx.Entity is not used in Efl.Ui.Win.Part.
The interface can be added when it is needed later.
ref T5719
Test Plan: make check
Reviewers: zmike, bu5hm4n, cedric, Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5719
Differential Revision: https://phab.enlightenment.org/D7844
Derek Foreman [Thu, 31 Jan 2019 20:10:44 +0000 (15:10 -0500)]
evas_private: Fix typo
Summary: Depends on D7853
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7854
Derek Foreman [Thu, 31 Jan 2019 20:06:46 +0000 (15:06 -0500)]
evas_object_smart: Consistently use MY_CLASS
Summary:
While it may not be popular opinion that MY_CLASS is confusing and does
more harm than good, using it sometimes and not others in the same file
is pretty obviously not helpful to casual readers.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7852
Mike Blumenkrantz [Thu, 31 Jan 2019 16:54:58 +0000 (11:54 -0500)]
efl_ui_win: add 'exit_on_close' property and unit test
Summary:
this property can enable the associated window to quit the main loop with
the passed exit code when the window is destroyed
@feature
fix T5494
Depends on D7594
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5494
Differential Revision: https://phab.enlightenment.org/D7595
Mike Blumenkrantz [Thu, 31 Jan 2019 16:54:54 +0000 (11:54 -0500)]
efl_ui_win: add 'exit_on_all_windows_closed' class property and unit test
Summary:
this property causes the main loop to exit with the passed exit code
when the standby event is triggered
@feature
ref T5494
Reviewers: cedric, bu5hm4n, segfaultxavi
Reviewed By: cedric, bu5hm4n, segfaultxavi
Subscribers: segfaultxavi, bu5hm4n, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5494
Differential Revision: https://phab.enlightenment.org/D7594
Christopher Michael [Thu, 31 Jan 2019 13:45:42 +0000 (08:45 -0500)]
elput: Update doxygen parameters
NB: No functional changes
Michaël Bouchaud (yoz) [Thu, 31 Jan 2019 13:41:04 +0000 (08:41 -0500)]
ecore_drm2: Add API to allow settings tap-to-click on pointer device
Summary:
Add a way to configure pointer device with tap-to-click features.
@feature
Depends on D7843
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7847
Michaël Bouchaud (yoz) [Thu, 31 Jan 2019 13:39:41 +0000 (08:39 -0500)]
elput: Add API to allow settings tap-to-click on pointer device
Summary:
Add a way to configure pointer device with tap-to-click features.
@feature
Reviewers: ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7843
Chris Michael [Thu, 31 Jan 2019 13:28:34 +0000 (08:28 -0500)]
elm_code: Fix formatting of error string
the ERR line here used %s for 'mode', but 'mode is an unsigned int
thus causing compiler warning. Fix it.
Chris Michael [Thu, 31 Jan 2019 13:11:54 +0000 (08:11 -0500)]
ecore-evas-buffer: Fix formatting
NB: No functional changes
Bowon Ryu [Thu, 31 Jan 2019 09:56:26 +0000 (18:56 +0900)]
efl_ui_tab_bar: fix tab sizing issue
Summary:
The default value of hint_align has changed.
So change the hint_align of tab(layout) to HINT_FILL.
* Recently, the size_hint_fill API has been added,
but currently tab_bar is not available because it uses evas_object_box.
* I plan to change evas_object_box to efl.ui.box in the future.
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, YOhoho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7835
SangHyeon Jade Lee [Thu, 31 Jan 2019 04:35:34 +0000 (13:35 +0900)]
efl_model : rename all efl_model based classes.
Summary:
As the result of discussion in T7458,
we need to rename all efl_model based classes with efl_XXX_Model sequence.
I've run few vote for this, see V42, V43
few classes are totally renamed as our consideration of misnaming.
| Efl.Model_Loop | Efl.Loop_Model |
| Efl.Model_Item | Efl.Generic_Model |
| Efl.Model_Container | Efl.Container_Model |
| Efl.Model_Container_Item | Efl.Container_Model_Item |
| Efl.Model_Composite | Efl.Composite_Model |
| Efl.Model_Composite_Boolean | Efl.Boolean_Model |
| Efl.Model_Composite_Boolean_Chlidren | Efl.Boolean_Model_Item |
| Efl.Model_Composite_Selection | Efl.Select_Model |
| Efl.Model_Composite_Selection_Chlidren | Efl.Select_Model_Item |
| Efl.Model_View | Efl.View_Model |
| Eio.Model | Efl.Io.Model |
| Efl.Ui.Model_State | Efl.Ui.State_Model |
| Efl.Ui.Model_Size | Efl.Ui.Size_Model |
| Efl.Ui.Model_Exact | Efl.Ui.Exact_Model |
| Efl.Ui.Model_Average | Efl.Ui.Average_Model |
| Efl.Ui.Model_Homogeneous | Efl.Ui.Homogeneous_Model |
I worried about Efl.Io.Model changes, cause it is widely used,
but as I tested, there is no issue found yet.
Eldbus.Model also may can changed Efl.Dbus.Model,
but I cannot found any class who using Efl.Dbus namespace,
so I left it future work.
Test Plan:
Run the Make Test,
it works well except Efl test about selection.
there are class inheritance problem exist in select_model,
I reported it and will fix it in another patch.
Reviewers: cedric, felipealmeida, woohyun, Hermet
Reviewed By: cedric
Subscribers: lauromoura
Tags: #efl, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D7533
Cedric BAIL [Thu, 31 Jan 2019 02:08:46 +0000 (11:08 +0900)]
elementary: add test for Efl.Ui.Model_Average.
Summary: Depends on D7664
Reviewers: SanghyeonLee, felipealmeida, segfaultxavi, zmike
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7382
Differential Revision: https://phab.enlightenment.org/D7665
Hermet Park [Fri, 1 Feb 2019 08:07:28 +0000 (17:07 +0900)]
enable rlottie.
the renamed-package was successfully submitted.
now efl can depend on it.
Change-Id: Ia1d4c0339146701da0c0222fbec11cae26564b5e
Wonki Kim [Thu, 31 Jan 2019 06:34:47 +0000 (15:34 +0900)]
meson: make tbm module of ecore_buffer being built
tbm module doesn't exist on upstream repo
so that this patch enables it to being built.
Change-Id: I7e93ef24c60e88c3fd119759a3b8c5682527fdc1
Wonki Kim [Thu, 31 Jan 2019 06:31:22 +0000 (15:31 +0900)]
meson: add a definition for tizen only image data
this patch contains a meson definition for
installing a image data that is used under tizen environment only
Change-Id: I19206babd6fc85a93b704fc1ca6a8d121180f191
Jihoon Kim [Fri, 1 Feb 2019 07:44:57 +0000 (16:44 +0900)]
ecore_imf: fix wrong sample code
Change-Id: Ia56ebe057da6ee1fc715a2efd04d154df512edd2
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Fri, 1 Feb 2019 00:19:57 +0000 (09:19 +0900)]
ecore_imf: Add since_tizen about ECORE_IMF_INPUT_HINT_AUTOFILL enums
Change-Id: Ib5c45f8cc7e5bc2170d6bde7d4de8261160057d6
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Thu, 31 Jan 2019 23:00:53 +0000 (08:00 +0900)]
ecore_imf: Add since_tizen about ECORE_IMF_ECORE_IMF_INPUT_PANEL_LAYOUT_VOICE enum
Change-Id: Id9d18d7573cc35db7b12159e48643e828b7278b6
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Wonki Kim [Thu, 31 Jan 2019 08:44:47 +0000 (17:44 +0900)]
meson: modify install pathes for modules of ecore_buffer
Summary:
there are differences between meson and autotools.
autotools installs them under ${libdir}/ecore_buffer/modules/module/version/ as module.so
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7837
Change-Id: Ide30c45b8df8136188876eeda81fc119d9c6d237
Wonki Kim [Thu, 31 Jan 2019 06:19:02 +0000 (15:19 +0900)]
meson: modify install path of bqmgr binary
Summary:
bqmgr is installed under ${libdir}/ecore_buffer/bin/ on autotools.
and it's not on meson.
this patch modify the install path on meson to a place that autotools installs outputs under
and this contains file name of binary also
Reviewers: bu5hm4n, #reviewers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7836
Change-Id: I1a514c9ab97ede25b78c2dcd8a205a93df02cb9a
Jihoon Kim [Thu, 31 Jan 2019 06:24:43 +0000 (15:24 +0900)]
ecore_imf: Add since_tizen about transaction callback types
Change-Id: I208e49cba032215675baa09815cf4827d7da221b
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Thu, 31 Jan 2019 06:00:08 +0000 (15:00 +0900)]
ecore_imf: Add since_tizen about ECORE_IMF_CALLBACK_COMMIT_CONTENT
Change-Id: If9379d74e87ac33d45c54817ea1612dd49ff59a8
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Wed, 30 Jan 2019 09:55:44 +0000 (18:55 +0900)]
docs: introduce how to receive media content
Change-Id: I2f5e9e210e3c0986705888ae5c79dfed8ab2f625
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Marcel Hollerbach [Wed, 30 Jan 2019 16:06:50 +0000 (16:06 +0000)]
meson: fix race condition in building
the error
```
./src/modules/evas/engines/gl_generic/../software_generic/evas_ector_software.h:31:10: fatal error: 'evas_ector_software_buffer.eo.h' file not found
```
Came up when building efl on osx with meson. This is caused by the fact that gl_generic was build before the .eo files of evas_ector have been created in software_generic, this fixes this race condition by adding a new dependency to avoid that.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7831
Change-Id: I12e6413307c552c5b4fef7510cadc7678215874f
Myoungwoon Roy, Kim [Wed, 30 Jan 2019 19:54:36 +0000 (14:54 -0500)]
elm: fix dereferencing issue and add error handling and remove unreachable codes.
Summary:
I had fixed dereferencing issue and added chmod error handling(elm_code_file)
I had removed unreachable codes which remains after changing arguments initiallization(efl_ui_win)
Test Plan: Run unit test cases
Reviewers: eagleeye, Jaehyun_Cho, Hermet, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7816
Cedric BAIL [Wed, 16 Jan 2019 22:11:51 +0000 (14:11 -0800)]
elementary: add a test for Efl.Ui.Model_Exact.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7664
Cedric BAIL [Sat, 12 Jan 2019 01:59:31 +0000 (17:59 -0800)]
elementary: add a test for Efl.Ui.Model_Homogeneous.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7663
Cedric BAIL [Fri, 11 Jan 2019 00:40:25 +0000 (16:40 -0800)]
elementary: add internal Efl_Ui_Model_Average.
This model enable View that require to compute the size of their item
to rely on its logic to store all items size independently. It has the
same interface as the Homogeneous and should be exchangeable for a View.
It provide an average total size at all time. It use Efl.Ui.Model_Exact
to do most of the work and is a good example on how to alter a Model
logic.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7661
Cedric BAIL [Thu, 3 Jan 2019 22:56:13 +0000 (14:56 -0800)]
elementary: add internal Efl_Ui_Model_Exact.
This model enable View that require to compute the size of their item
to rely on its logic to store all items size independently. It has the
same interface as the Homogeneous and should be exchangeable for a View.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7660
Cedric BAIL [Fri, 28 Dec 2018 23:41:44 +0000 (15:41 -0800)]
elementary: add internal Efl_Ui_Model_Homogeneous.
This model enable View that require to compute the size of their item
to rely on its logic to have all items of the same size. It is the
equivalent of the Homogeneous behavior of Genlist, except that now this
behavior can be customized outside of the View logic itself.
Differential Revision: https://phab.enlightenment.org/D7659
Cedric BAIL [Sat, 29 Dec 2018 00:39:44 +0000 (16:39 -0800)]
elementary: add internal Efl_Ui_Model_Size.
This model enable View that require to compute the size of their items
to rely on an interface to provide the properties they need to get the object
size. This is the base class for all the sizing logic of the new List/Grid View.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7658
Cedric BAIL [Thu, 3 Jan 2019 22:54:18 +0000 (14:54 -0800)]
ecore: add an index property on Efl.Model_Composite and handle children_slice_get.
This will enable inheriting class to not have to implement as much code. This patch
fix also all class that use Efl.Model_Composite and its test.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7654
Stefan Schmidt [Wed, 30 Jan 2019 19:51:30 +0000 (14:51 -0500)]
ci: travis: switch mingw cross build to also use Fedora 29 as base
Summary:
The new image also contains the ewpi install in a different location.
Updating the references here.
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7833
Cedric BAIL [Sat, 19 Jan 2019 02:01:23 +0000 (18:01 -0800)]
elementary: update Efl.Ui.Caching_Factory to rely on Efl.Ui.Widget_Factory for Efl.Ui.Widget.
I am not sure we really need Efl.Ui.Caching_Factory after this, but in case we want a Caching_Factory
for non Efl.Ui.Widget, this is supported by this patch (And is the reason why most of the complexity).
The benefit from inheriting from Efl.Ui.Widget_Factory allow to get the style of an Efl.Ui.Widget
defined by an Efl.Model properly done at creation time.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Reviewed-by: Larry Lira <larry@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7705
Cedric BAIL [Sat, 19 Jan 2019 01:58:39 +0000 (17:58 -0800)]
elementary: add Efl.Ui.Widget_Factory.
The Widget_Factory is in charge of creating any object that inherit from Efl.Ui.Widget Class.
If the style property is connected to a model property, it will fetch it and build the widget
with that style. This factory is to be used with every View.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D7704
Marcel Hollerbach [Wed, 30 Jan 2019 18:44:45 +0000 (13:44 -0500)]
efl_ui: mulibuttonentry is now tags
Summary:
further more it can be just included here, without this warning.
Depends on D7819
Reviewers: zmike, cedric, stefan_schmidt
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7830
Marcel Hollerbach [Wed, 30 Jan 2019 16:06:50 +0000 (16:06 +0000)]
meson: fix race condition in building
the error
```
./src/modules/evas/engines/gl_generic/../software_generic/evas_ector_software.h:31:10: fatal error: 'evas_ector_software_buffer.eo.h' file not found
```
Came up when building efl on osx with meson. This is caused by the fact that gl_generic was build before the .eo files of evas_ector have been created in software_generic, this fixes this race condition by adding a new dependency to avoid that.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7831
Mike Blumenkrantz [Wed, 30 Jan 2019 14:05:05 +0000 (09:05 -0500)]
efl.file: move 'save' method into separate efl.file_save interface
the save method is implemented very rarely, and most objects which use efl.file
will not be able to use a save method
ref T5719
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Marcel Hollerbach <marcel-hollerbach@t-online.de>
Differential Revision: https://phab.enlightenment.org/D7786
Change-Id: I169c7efc06a4ecb60afb7073b20c41a8ce0751c3
Marcel Hollerbach [Wed, 30 Jan 2019 16:07:08 +0000 (17:07 +0100)]
Revert "meson: fix race condition in building"
This reverts commit
e1f3a4232e65c487dcbb4d62206a8181959e712d.
git push on the wrong branch - sorry
Marcel Hollerbach [Wed, 30 Jan 2019 13:48:04 +0000 (14:48 +0100)]
meson: fix race condition in building
this came up on travis with osx. However, it should hit everyone, and
its questionable why it did not happened ever before.
Differential Revision: https://phab.enlightenment.org/D7831
Xavi Artigas [Wed, 30 Jan 2019 15:16:37 +0000 (16:16 +0100)]
docs: Add links to Efl.Loop_Consumer
Jaehyun Cho [Wed, 30 Jan 2019 12:03:20 +0000 (12:03 +0000)]
eo: check memory allocation of table data
Memory allocation is checked for the given domain's table data like
other cases for main and shared table data.
Differential Revision: https://phab.enlightenment.org/D7810
Woochanlee [Fri, 4 Jan 2019 08:03:52 +0000 (08:03 +0000)]
efl_ui_win: Load config values into gesture manager.
https://phab.enlightenment.org/T7544
The other config values will be added Later.
Differential Revision: https://phab.enlightenment.org/D7540
Mike Blumenkrantz [Mon, 28 Jan 2019 16:10:40 +0000 (11:10 -0500)]
efl.text_markup: move cursor-related methods to efl.text_markup_interactive
many users of the markup property are not interactive text cases, so splitting
off the interactive methods resolves a number of unimplemented method issues
ref T5719
Differential Revision: https://phab.enlightenment.org/D7787
Mike Blumenkrantz [Tue, 29 Jan 2019 17:46:17 +0000 (12:46 -0500)]
efl_ui_scroll_manager: avoid some safety check errors on deletion
only remove callbacks if pan_obj is still alive
Differential Revision: https://phab.enlightenment.org/D7822
Mike Blumenkrantz [Tue, 29 Jan 2019 18:50:40 +0000 (13:50 -0500)]
tests: move efl_ui focus tests into efl_ui_suite
ref T6815
Differential Revision: https://phab.enlightenment.org/D7827
Mike Blumenkrantz [Tue, 29 Jan 2019 19:04:23 +0000 (14:04 -0500)]
efl_ui: add proto for efl_ui_focus_relation_free() into header
ref T7667
Differential Revision: https://phab.enlightenment.org/D7826
Xavi Artigas [Wed, 30 Jan 2019 11:49:31 +0000 (12:49 +0100)]
docs: Improve Efl.Ui.Tags documentation
Jihoon Kim [Wed, 30 Jan 2019 09:55:44 +0000 (18:55 +0900)]
docs: introduce how to receive media content
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Mike Blumenkrantz [Tue, 29 Jan 2019 17:56:32 +0000 (12:56 -0500)]
tests: move efl_ui_image test -> efl_ui_suite
ref T6815
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7825
Mike Blumenkrantz [Tue, 29 Jan 2019 17:07:54 +0000 (12:07 -0500)]
tests: move efl_ui_layout tests into efl_ui_suite
also use legacy api for elm_layout swallow test
ref T6815
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7824
Mike Blumenkrantz [Tue, 29 Jan 2019 17:47:41 +0000 (12:47 -0500)]
efl_ui: include layout header in Efl_Ui.h
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7823
Mike Blumenkrantz [Mon, 28 Jan 2019 19:38:38 +0000 (14:38 -0500)]
tests: move image_zoomable into efl_ui_suite
ref T6815
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7807
Mike Blumenkrantz [Mon, 28 Jan 2019 19:03:26 +0000 (14:03 -0500)]
tests: add atspi test for efl_ui_suite
this is just a copy of the existing suite but with some small changes to
use (mostly) eo apis
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7806
Mike Blumenkrantz [Mon, 28 Jan 2019 18:42:56 +0000 (13:42 -0500)]
tests: formatting
make this consistent for possible sed later
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7805
Mike Blumenkrantz [Mon, 28 Jan 2019 18:38:24 +0000 (13:38 -0500)]
tests: modify efl_ui_suite to use same test infrastructure as elm_suite
this should enable us to begin moving efl_ui tests into the proper suite
instead of sticking them all into elm_suite
also move grid tests to efl_ui_suite
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D7765
Myoungwoon Roy, Kim [Wed, 30 Jan 2019 00:38:11 +0000 (09:38 +0900)]
efl_ui_list_view: Handling failed memory allocation
Summary: Add a logic for handling failed memory allocation to prevent null pointer exception
Test Plan: Run unit test cases
Reviewers: eagleeye, Jaehyun_Cho, Hermet, zmike, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: SanghyeonLee, cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7829
Chris Michael [Tue, 29 Jan 2019 16:03:09 +0000 (11:03 -0500)]
evas_test_textblock: Fix unused variable warning
In evas_textblock_cursor test, the variable 'dir' is only used if
HAVE_FRIBIDI is defined. If that is not defined, then we get an unused
variable warning when compiling. This patch wraps the variable around
an #ifdef so that it does not get declared without FRIBIDI support.
Cedric BAIL [Tue, 29 Jan 2019 14:26:51 +0000 (09:26 -0500)]
elementary: enable efl_ui_suite tests for meson build.
Summary: Depends on D7661
Reviewers: SanghyeonLee, felipealmeida, segfaultxavi, zmike
Reviewed By: SanghyeonLee, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7382
Differential Revision: https://phab.enlightenment.org/D7662
WooHyun Jung [Tue, 29 Jan 2019 14:23:44 +0000 (09:23 -0500)]
elm: prevent from accessing null pointer after memory allocation
Summary: Add null checking code just after allocating memory
Test Plan: make check
Reviewers: jypark, Jaehyun_Cho, zmike
Reviewed By: Jaehyun_Cho, zmike
Subscribers: devilhorns, zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7801
Christopher Michael [Tue, 29 Jan 2019 13:43:57 +0000 (08:43 -0500)]
efl_ui_grid: Fix return value from macros
The function _grid_item_unpack_internal does not return a value, so
these macros should not be trying to return EINA_FALSE.
Amitesh Singh [Tue, 29 Jan 2019 11:28:25 +0000 (16:58 +0530)]
eina modinfo: improve eina modinfo guide.
Hermet Park [Tue, 29 Jan 2019 10:56:03 +0000 (19:56 +0900)]
efl gfx_frame_controller: improve doc.
Hosang Kim [Tue, 29 Jan 2019 10:30:45 +0000 (19:30 +0900)]
ecore: check fcntl return.
Summary: Found by svace
Reviewers: Jaehyun_Cho, woohyun, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7808
Hermet Park [Tue, 29 Jan 2019 09:36:09 +0000 (18:36 +0900)]
efl_gfx_map: free alloc' memory at exception case.
SangHyeon Jade Lee [Tue, 29 Jan 2019 06:38:49 +0000 (15:38 +0900)]
efl_ui : fix minor defects from converity check.
Summary: This is first coverity defect after efl_ui_grid merged.
Test Plan: build test and check exmaples.
Reviewers: eagleeye
Reviewed By: eagleeye
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7812
Jaehyun Cho [Tue, 29 Jan 2019 04:51:47 +0000 (13:51 +0900)]
examples: fix slider cxx example not to call content_set
Since Efl.Content is removed from Efl.Ui.Slider, slider should not call
content_set.
This patch is for the commit
4c44c44e1a46bc05ea812259474cbc8c83659769.
Christopher Michael [Mon, 28 Jan 2019 19:45:23 +0000 (14:45 -0500)]
ecore-drm2: Support multiple gpus during vblank
Summary:
When we try to calculate a drm vblank type, we should take into
account the output's pipe value which is used to determine if we are
using multiple gpus (if so, we need to use the high_crtc_mask.
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7803
Mike Blumenkrantz [Mon, 28 Jan 2019 18:08:56 +0000 (13:08 -0500)]
elm_prefs: remove efl.file usage
Summary:
this is a legacy-only api which does not need to drag in unimplemented methods
from interfaces
ref T5719
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T5719
Differential Revision: https://phab.enlightenment.org/D7804
Marcel Hollerbach [Mon, 28 Jan 2019 18:08:51 +0000 (13:08 -0500)]
efl_model_loop: make it abstract
Summary:
there is no user, additionally, there is undefined API on this object,
thus make it abstract. This resolves the missing APIs of efl_model_loop.
ref T5719
Depends on D7790
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5719
Differential Revision: https://phab.enlightenment.org/D7791
Xavi Artigas [Mon, 28 Jan 2019 17:35:44 +0000 (12:35 -0500)]
focus: do not allow focus to exit a popup
Summary:
Popup windows dim the background and do not allow the user
to click outside the popup. However, pressing TAB can take
you to widgets on the background. This didn't happen in
legacy.
Fixes T7432
Test Plan: Instructions in T7432
Reviewers: bu5hm4n, stephenmhouston, Jaehyun_Cho, herb, Blackmole, zmike
Reviewed By: zmike
Subscribers: zmike, felipealmeida, lauromoura, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7432
Differential Revision: https://phab.enlightenment.org/D7171
Marcel Hollerbach [Mon, 28 Jan 2019 17:11:48 +0000 (12:11 -0500)]
efl_net_server_udp: add empty functions
Summary:
these functions are never called from within this class, thus they are
empty here. They are not used because setting up the client does
require here more API than just a fd.
ref T5719
Depends on D7791
Reviewers: segfaultxavi, zmike
Reviewed By: segfaultxavi, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5719
Differential Revision: https://phab.enlightenment.org/D7802
Marcel Hollerbach [Mon, 28 Jan 2019 17:11:37 +0000 (12:11 -0500)]
elm_map: convert paused to animation property
Summary:
this commit migrates the paused property over to the property defined by
efl.ui.zoom. This is done in order to implement all APIs in the elm_map
object.
ref T5719
Depends on D7783
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T5719
Differential Revision: https://phab.enlightenment.org/D7784
Stefan Schmidt [Mon, 28 Jan 2019 17:00:26 +0000 (12:00 -0500)]
ci: travis: shorten job descriptions
Summary:
This makes job descriptions shorter and also clearer to see what env
variable belongs to what job and os.
Moving the release ready build to an earlier start position in the cron
job to shorten the total build time.
Depends on D7799
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7800
Stefan Schmidt [Mon, 28 Jan 2019 17:00:24 +0000 (12:00 -0500)]
ci: travis: enable a meson/ninja build on osx
Summary:
This cuts down the time the osx builld takes from ~30min to ~20min
Keeping the autotools osx build in the cron job for now.
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7799
Christopher Michael [Mon, 28 Jan 2019 16:58:49 +0000 (11:58 -0500)]
evas-clip: Remove unused variable
NB: No functional changes
Xavi Artigas [Mon, 28 Jan 2019 12:14:20 +0000 (13:14 +0100)]
docs: Fix assorted typos in legacy documentation
Samsung reported a long list of typos in our legacy docs, this fixes them.
Yeongjong Lee [Mon, 28 Jan 2019 08:15:34 +0000 (17:15 +0900)]
epp: fix correct parameters for cpp_error_with_line
Reviewers: zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7795
Taehyub Kim [Mon, 28 Jan 2019 07:58:35 +0000 (16:58 +0900)]
efl_ui_dnd: fix the wrong parameter passing
Summary: fix the wrong parameter passing
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7797
Lauro Moura [Mon, 28 Jan 2019 07:20:02 +0000 (16:20 +0900)]
eolian-cxx: Add constructor_def
Summary: To be used generating argument-aware constructors in C#.
Reviewers: felipealmeida, vitor.sousa
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7794
Lauro Moura [Mon, 28 Jan 2019 07:16:26 +0000 (16:16 +0900)]
elementary: Declare style as a Widget constructor
Summary: Despite being required as a use case for C# constructors, style is not yet listed as a constructing property.
Reviewers: bu5hm4n, Jaehyun_Cho, segfaultxavi, zmike, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7793
Lauro Moura [Mon, 28 Jan 2019 07:10:43 +0000 (16:10 +0900)]
eo: Replace ptr(Eina.Strbuf) with plain strbuf.
Summary: Also fix CXX compilation after this change.
Reviewers: cedric, felipealmeida
Reviewed By: felipealmeida
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7792
Larry Lira [Mon, 28 Jan 2019 06:39:35 +0000 (15:39 +0900)]
efl_ui_list_view_seg_array: remove seg_array from Elementary.h
Summary:
Change seg_array to private
This is a leftover of https://phab.enlightenment.org/D7724
Reviewers: felipealmeida, cedric, SanghyeonLee
Reviewed By: felipealmeida
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7780
Shinwoo Kim [Mon, 28 Jan 2019 05:49:02 +0000 (14:49 +0900)]
evas_clip: do not set clip->changed to true
Summary:
[Issuse]
The issue solved by this commit occurs with 'export EVAS_GL_PARTIAL_DISABLE=0'.
The _efl_canvas_object_clip_set set clip->changed to true, but did not add the
clip object to e->pending_objects. So there is no chance to reset it to false.
(Please refer to evas_render_object_recalc.)
The clip->changed is always ture so its clipees cannot change its 'changed'
to true. Because if 'changed' is true, evas_object_change returns before
calling evas_object_change for its clipees. (Please see evas_object_change.)
So 'changed' of clipees is false always, and clipees cannot call render_pre
in _evas_render_phase1_direct, and eglSwapBuffersWithDamage is not called.
This caused rendering issue.
This could be rare case. The _efl_canvas_object_clip_set is called when the
clipper and its clipees are out of view.
[Solution]
I would like to explain why removing line setting clip->changed to true makes
sense. First, the following commit added line setting clip->changed to true.
(1) committ
5e8d46e884930f109a28147cda4ce002e6836017
Author: Carsten Haitzler <raster@rasterman.com>
Date: Wed Sep 22 04:37:51 2004 +0000
clip bug fix :)
And following commit removed line calling evas_damage_rectangle_add which is
part of commit (1) above.
(2) commit
8767a80b0dbda4e2c3a6b2a41a04bf35f43a3ed1
Author: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Wed Apr 16 16:14:16 2014 +0900
fix overdraw issue in evas when clips change
Between above two commits, another commit calling evas_object_change(clip) was
added. This commit sets clip->changed to ture, and adds clip object to
e->pending_objects by evas_object_change -> evas_render_object_recalc.
(3) commit
4aca7949f581eaaf943785759b542acd8fc6794c
Author: Carsten Haitzler <raster@rasterman.com>
Date: Wed Nov 2 04:03:55 2005 +0000
fix excess overdraw bug
So we do not need the remains of commit (1). REMOVE!! :-]
Reviewers: raster, Hermet, jypark
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7767