platform/upstream/libSkiaSharp.git
10 years agoMore gpu rebaselines
bsalomon@google.com [Thu, 20 Mar 2014 15:35:33 +0000 (15:35 +0000)]
More gpu rebaselines

Review URL: https://codereview.chromium.org/204353006

git-svn-id: http://skia.googlecode.com/svn/trunk@13875 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: image URLs are relative to JSON file's location
commit-bot@chromium.org [Thu, 20 Mar 2014 15:27:34 +0000 (15:27 +0000)]
rebaseline_server: image URLs are relative to JSON file's location

BUG=skia:1455, skia:2230
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/205273002

git-svn-id: http://skia.googlecode.com/svn/trunk@13874 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline minor pixel diffs from recent GPU changes.
senorblanco@chromium.org [Thu, 20 Mar 2014 15:24:39 +0000 (15:24 +0000)]
Rebaseline minor pixel diffs from recent GPU changes.

TBR=bsalomon

Review URL: https://codereview.chromium.org/206223004

git-svn-id: http://skia.googlecode.com/svn/trunk@13873 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "hide Config8888 entirely". Broke a bunch of builds.
bsalomon@google.com [Thu, 20 Mar 2014 13:26:45 +0000 (13:26 +0000)]
Revert "hide Config8888 entirely". Broke a bunch of builds.

This reverts commit fa11c49cc11a6c9ebafbf9c59e118917f9b3cc56.

Revert "Sanitizing source files in Housekeeper-Nightly" to make the above revert clean.

This reverts commit b5787422c8eb2a27a9576777597fd9e06784acdb.

TBR=reed@google.com
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/205963003

git-svn-id: http://skia.googlecode.com/svn/trunk@13872 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 20 Mar 2014 03:02:31 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13871 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix Windows build break introduced in r13864.
bungeman@google.com [Wed, 19 Mar 2014 23:26:50 +0000 (23:26 +0000)]
Fix Windows build break introduced in r13864.

Need SkToBool(...).

git-svn-id: http://skia.googlecode.com/svn/trunk@13870 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSilence warning after f5e315ccf1a.
commit-bot@chromium.org [Wed, 19 Mar 2014 22:58:52 +0000 (22:58 +0000)]
Silence warning after f5e315ccf1a.

(clang 3.3):

../tools/PictureRenderer.cpp:350:13: error: variable 'hash' is used uninitialized whenever 'if' condition is false
      [-Werror,-Wsometimes-uninitialized]
        if (!generatedHash) {
            ^~~~~~~~~~~~~~
../tools/PictureRenderer.cpp:354:53: note: uninitialized use occurs here
        jsonSummaryPtr->add(outputFilename.c_str(), hash);
                                                    ^~~~
../tools/PictureRenderer.cpp:350:9: note: remove the 'if' if its condition is always true
        if (!generatedHash) {
        ^~~~~~~~~~~~~~~~~~~~
../tools/PictureRenderer.cpp:334:18: note: initialize the variable 'hash' to silence this warning
    uint64_t hash;
                 ^
                  = 0

The warning is wrong, but the compiler does have a point: generatedHash is always false at that point.

R=epoger@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/196823004

git-svn-id: http://skia.googlecode.com/svn/trunk@13869 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix non-gpu build
commit-bot@chromium.org [Wed, 19 Mar 2014 22:54:40 +0000 (22:54 +0000)]
fix non-gpu build

BUG=
R=bungeman@google.com
TBR=bungeman@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/197283040

git-svn-id: http://skia.googlecode.com/svn/trunk@13868 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOnly use analytic effect-based clipping when AA is required by at least one element.
commit-bot@chromium.org [Wed, 19 Mar 2014 21:26:35 +0000 (21:26 +0000)]
Only use analytic effect-based clipping when AA is required by at least one element.

BUG=352718
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/204983003

git-svn-id: http://skia.googlecode.com/svn/trunk@13867 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agostub for ganesh veto
commit-bot@chromium.org [Wed, 19 Mar 2014 21:24:25 +0000 (21:24 +0000)]
stub for ganesh veto

BUG=skia:
R=bsalomon@google.com, nduca@chromium.org

Author: humper@google.com

Review URL: https://codereview.chromium.org/197803002

git-svn-id: http://skia.googlecode.com/svn/trunk@13866 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agohide Config8888 entirely
commit-bot@chromium.org [Wed, 19 Mar 2014 21:20:24 +0000 (21:20 +0000)]
hide Config8888 entirely

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/203993002

git-svn-id: http://skia.googlecode.com/svn/trunk@13865 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding a new SkSurface factory for generating surfaces from the scratch texture pool.
commit-bot@chromium.org [Wed, 19 Mar 2014 21:19:16 +0000 (21:19 +0000)]
Adding a new SkSurface factory for generating surfaces from the scratch texture pool.

TEST=Surface unit test
BUG=crbug.com/351798
R=bsalomon@google.com, robertphillips@google.com, reed@google.com

Author: junov@chromium.org

Review URL: https://codereview.chromium.org/201153023

git-svn-id: http://skia.googlecode.com/svn/trunk@13864 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse rounding to 8888 in lighting filters, raster path.
senorblanco@chromium.org [Wed, 19 Mar 2014 19:44:41 +0000 (19:44 +0000)]
Use rounding to 8888 in lighting filters, raster path.

when converting float -> 8-bit BGRA in lighting filters, use rounding
rather than floor(). This makes the GPU and raster paths match more
closely (as tested by Blink test
feDiffuseLighting-linearrgb-lighting-color.svg).

Will affect the LSB of lighting, imagefiltersscaled GMs.

R=junov@chromium.org
BUG=skia:

Review URL: https://codereview.chromium.org/205073002

git-svn-id: http://skia.googlecode.com/svn/trunk@13863 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed cross compilation with mingw.
commit-bot@chromium.org [Wed, 19 Mar 2014 19:28:00 +0000 (19:28 +0000)]
Fixed cross compilation with mingw.

Tested in Mozilla source tree. I tried to use skia build system, but it's up to the task for cross compilation.

SkHRESULT.cpp - Use proper file name (that matters on case sensitive OSes)

SkAtomics_win.h - Don't use pragma intrinsic on GCC (this causes massive warnings)

SkOSFile_win.cpp - This one is tricky. GCC doesn't allow (void*) casts in template argument constants and INVALID_HANDLE_VALUE looks like this:
((HANDLE)(LONG_PTR)-1)
where HANDLE is typedefed to void*. Changed the code to use LONG_PTR as template argument and cast it when needed.

BUG=skia:
R=bungeman@google.com, reed@google.com

Author: cjacek@gmail.com

Review URL: https://codereview.chromium.org/198643004

git-svn-id: http://skia.googlecode.com/svn/trunk@13862 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd quiet mode to lua_pictures.
commit-bot@chromium.org [Wed, 19 Mar 2014 19:23:17 +0000 (19:23 +0000)]
Add quiet mode to lua_pictures.

This allows:

for i in {0..5}; do
    out/Debug/lua_pictures -q --skpPath $SKP_PATH -l $SCRIPT --modulo $i 6
done

to generate output similar to what telemetry will generate.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197793007

git-svn-id: http://skia.googlecode.com/svn/trunk@13861 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix accessBitmap() with deferred clear, GPU path.
senorblanco@chromium.org [Wed, 19 Mar 2014 18:24:04 +0000 (18:24 +0000)]
Fix accessBitmap() with deferred clear, GPU path.

When accessBitmap() is called on a GPU device which has deferred clear,
and no drawing has been done, force the clear before returning the
bitmap.

This is covered by the top right test case in the imagefilterscropexpand
GM, where an offset image filter is drawn but the resulting bitmap is
cropped out, resulting in no drawing to the offscreen. It should be
empty, but without this fix it results in garbage (previous scratch
texture contents).

BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/204903002

git-svn-id: http://skia.googlecode.com/svn/trunk@13860 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd --writeChecksumBasedFilenames flag to render_pictures
commit-bot@chromium.org [Wed, 19 Mar 2014 17:26:07 +0000 (17:26 +0000)]
add --writeChecksumBasedFilenames flag to render_pictures

BUG=skia:1455,skia:2230
R=robertphillips@google.com, robertphillips@chromium.org

Author: epoger@google.com

Review URL: https://codereview.chromium.org/202983003

git-svn-id: http://skia.googlecode.com/svn/trunk@13859 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of SkPaint: eliminate some dead bytes in 64-bit build. (https://codereview...
commit-bot@chromium.org [Wed, 19 Mar 2014 14:36:29 +0000 (14:36 +0000)]
Revert of SkPaint: eliminate some dead bytes in 64-bit build. (https://codereview.chromium.org/203203003/)

Reason for revert:
Causing RunTest failures on Android.

Original issue's description:
> SkPaint: eliminate some dead bytes in 64-bit build.
>
> + memcpy-based copy constructor was hiding this gap -> manual copy constructor.
> + Split tests for finer-grained failures.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13856

R=reed@google.com, mtklein@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/204543002

git-svn-id: http://skia.googlecode.com/svn/trunk@13858 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhitespace change to verify that buildbot scripts are fixed.
commit-bot@chromium.org [Wed, 19 Mar 2014 14:22:18 +0000 (14:22 +0000)]
Whitespace change to verify that buildbot scripts are fixed.

BUG=skia:2312
NOTRY=true
NOTREECHECKS=true
R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/199273006

git-svn-id: http://skia.googlecode.com/svn/trunk@13857 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkPaint: eliminate some dead bytes in 64-bit build.
commit-bot@chromium.org [Wed, 19 Mar 2014 11:42:34 +0000 (11:42 +0000)]
SkPaint: eliminate some dead bytes in 64-bit build.

+ memcpy-based copy constructor was hiding this gap -> manual copy constructor.
+ Split tests for finer-grained failures.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/203203003

git-svn-id: http://skia.googlecode.com/svn/trunk@13856 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 19 Mar 2014 03:02:22 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13855 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline imagefiltersscaled GM.
senorblanco@chromium.org [Tue, 18 Mar 2014 17:59:47 +0000 (17:59 +0000)]
Rebaseline imagefiltersscaled GM.

Rebaseline imagefiltersscaled GM for new test cases added in
https://code.google.com/p/skia/source/detail?r=13798.

TBR=jcgregorio@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/203093004

git-svn-id: http://skia.googlecode.com/svn/trunk@13854 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a means of extracting active operations from SkPicture
commit-bot@chromium.org [Tue, 18 Mar 2014 17:45:32 +0000 (17:45 +0000)]
Add a means of extracting active operations from SkPicture

For the "pull forward" task I will be comparing the two cases:
  analyze the whole skp and use the BBH information
  analyze only the active portion of the skp

In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it.

Committed: http://code.google.com/p/skia/source/detail?r=13836

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/195793010

git-svn-id: http://skia.googlecode.com/svn/trunk@13853 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd reg test for http://crbug.com/348821
commit-bot@chromium.org [Tue, 18 Mar 2014 17:38:34 +0000 (17:38 +0000)]
Add reg test for http://crbug.com/348821

BUG=348821
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/189373008

git-svn-id: http://skia.googlecode.com/svn/trunk@13852 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoupdate comment on setShader to clarify alpha-bitmap behavior in bitmapshaders
commit-bot@chromium.org [Tue, 18 Mar 2014 16:28:12 +0000 (16:28 +0000)]
update comment on setShader to clarify alpha-bitmap behavior in bitmapshaders

BUG=skia:2293
R=bsalomon@google.com, yunchao.he@intel.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/203203005

git-svn-id: http://skia.googlecode.com/svn/trunk@13851 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of r13836 due to Chromium cc_unittests failures
robertphillips@google.com [Tue, 18 Mar 2014 13:56:09 +0000 (13:56 +0000)]
Revert of r13836 due to Chromium cc_unittests failures

https://codereview.chromium.org/203333005/

git-svn-id: http://skia.googlecode.com/svn/trunk@13850 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SkCanvas matrix ops return value.
commit-bot@chromium.org [Tue, 18 Mar 2014 12:51:48 +0000 (12:51 +0000)]
Remove SkCanvas matrix ops return value.

The internal SkMatrix ops can no longer fail -> we can remove the bool
return value.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com, scroggo@google.com, fmalita@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/200223008

git-svn-id: http://skia.googlecode.com/svn/trunk@13849 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPut SimpleOffsetFilter on heap.
commit-bot@chromium.org [Tue, 18 Mar 2014 10:28:27 +0000 (10:28 +0000)]
Put SimpleOffsetFilter on heap.

Effects want to live on the heap!

BUG=skia:
R=senorblanco@chromium.org, dominikg@chromium.org, scroggo@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/203273002

git-svn-id: http://skia.googlecode.com/svn/trunk@13848 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSlightly faster quadtree searching
commit-bot@chromium.org [Tue, 18 Mar 2014 09:07:27 +0000 (09:07 +0000)]
Slightly faster quadtree searching

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, robertphillips@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/196383026

git-svn-id: http://skia.googlecode.com/svn/trunk@13847 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoshort-term fix for RunToolSelfTests
commit-bot@chromium.org [Tue, 18 Mar 2014 05:41:33 +0000 (05:41 +0000)]
short-term fix for RunToolSelfTests

BUG=skia:2307
NOTREECHECKS=True
NOTRY=True
R=bensong@google.com
TBR=bensong

Author: epoger@google.com

Review URL: https://codereview.chromium.org/202203010

git-svn-id: http://skia.googlecode.com/svn/trunk@13846 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 18 Mar 2014 03:02:11 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13845 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix GPU displacement with expanding crop rects.
senorblanco@chromium.org [Mon, 17 Mar 2014 23:41:40 +0000 (23:41 +0000)]
Fix GPU displacement with expanding crop rects.

Fix GPU displacement with expanding crop rects, and re-enable the
imagefilterscropexpand GM. There were two bugs: the result texture was
being created at input color bitmap size, not the cropped bounds size,
and the matrix in GrContext was not being set to identity before draw.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/195973007

git-svn-id: http://skia.googlecode.com/svn/trunk@13844 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd initial scraper for dashing
commit-bot@chromium.org [Mon, 17 Mar 2014 23:09:47 +0000 (23:09 +0000)]
add initial scraper for dashing

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/196603027

git-svn-id: http://skia.googlecode.com/svn/trunk@13843 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate SkXPSDevice.cpp too
robertphillips@google.com [Mon, 17 Mar 2014 22:34:32 +0000 (22:34 +0000)]
Update SkXPSDevice.cpp too

git-svn-id: http://skia.googlecode.com/svn/trunk@13842 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWindows build fix
robertphillips@google.com [Mon, 17 Mar 2014 22:09:34 +0000 (22:09 +0000)]
Windows build fix

git-svn-id: http://skia.googlecode.com/svn/trunk@13841 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd new readPixels with direct memory parameters
commit-bot@chromium.org [Mon, 17 Mar 2014 21:31:26 +0000 (21:31 +0000)]
add new readPixels with direct memory parameters

BUG=skia:
R=scroggo@google.com, bsalomon@google.com, robertphillips@google.com, fmalita@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/199413013

git-svn-id: http://skia.googlecode.com/svn/trunk@13840 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd nine patch type to SkRRect.
commit-bot@chromium.org [Mon, 17 Mar 2014 21:17:30 +0000 (21:17 +0000)]
Add nine patch type to SkRRect.

BUG=skia:2181

Committed: http://code.google.com/p/skia/source/detail?r=13833

R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/196343015

git-svn-id: http://skia.googlecode.com/svn/trunk@13839 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogen_bench_expectations to generate bench expectations files.
commit-bot@chromium.org [Mon, 17 Mar 2014 21:16:29 +0000 (21:16 +0000)]
gen_bench_expectations to generate bench expectations files.

BUG=skia:2225
NOTRY=true
R=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/201423002

git-svn-id: http://skia.googlecode.com/svn/trunk@13838 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Add nine patch type to SkRRect. (https://codereview.chromium.org/196343015/)
commit-bot@chromium.org [Mon, 17 Mar 2014 19:47:40 +0000 (19:47 +0000)]
Revert of Add nine patch type to SkRRect. (https://codereview.chromium.org/196343015/)

Reason for revert:
causes tests to have infinite loop

Original issue's description:
> Add nine patch type to SkRRect.
>
> BUG=skia:2181
>
> Committed: http://code.google.com/p/skia/source/detail?r=13833

R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2181

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/202163004

git-svn-id: http://skia.googlecode.com/svn/trunk@13837 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a means of extracting active operations from SkPicture
commit-bot@chromium.org [Mon, 17 Mar 2014 18:11:57 +0000 (18:11 +0000)]
Add a means of extracting active operations from SkPicture

For the "pull forward" task I will be comparing the two cases:
  analyze the whole skp and use the BBH information
  analyze only the active portion of the skp

In the first case we need a way to get the BBH information out of the picture in order to extract the relevant portions of the whole-skp analysis. This adds caching of the active ops so that work isn't duplicated between when the optimization path queries for that information and when the usual draw path queries for it.

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/195793010

git-svn-id: http://skia.googlecode.com/svn/trunk@13836 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code
commit-bot@chromium.org [Mon, 17 Mar 2014 17:03:18 +0000 (17:03 +0000)]
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG -- dead code

BUG=skia:
R=halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/201973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13834 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd nine patch type to SkRRect.
commit-bot@chromium.org [Mon, 17 Mar 2014 15:39:01 +0000 (15:39 +0000)]
Add nine patch type to SkRRect.

BUG=skia:2181
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/196343015

git-svn-id: http://skia.googlecode.com/svn/trunk@13833 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r13831 (Add a means of extracting active operations from SkPicture) due...
robertphillips@google.com [Mon, 17 Mar 2014 15:10:02 +0000 (15:10 +0000)]
Reverting r13831 (Add a means of extracting active operations from SkPicture) due to Mac compiler issue

git-svn-id: http://skia.googlecode.com/svn/trunk@13832 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a means of extracting active operations from SkPicture
robertphillips@google.com [Mon, 17 Mar 2014 14:56:13 +0000 (14:56 +0000)]
Add a means of extracting active operations from SkPicture

https://codereview.chromium.org/195793010/

git-svn-id: http://skia.googlecode.com/svn/trunk@13831 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: make intermediate JSON specify base urls for diff images
commit-bot@chromium.org [Mon, 17 Mar 2014 14:22:02 +0000 (14:22 +0000)]
rebaseline_server: make intermediate JSON specify base urls for diff images

BUG=skia:1919,skia:2230
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/196533021

git-svn-id: http://skia.googlecode.com/svn/trunk@13830 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkFontStyleSet_DirectWrite::getStyle to properly handle NULL out params.
bungeman@google.com [Mon, 17 Mar 2014 14:04:50 +0000 (14:04 +0000)]
SkFontStyleSet_DirectWrite::getStyle to properly handle NULL out params.

R=reed@google.com

Review URL: https://codereview.chromium.org/201213003

git-svn-id: http://skia.googlecode.com/svn/trunk@13829 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix result order reliance
commit-bot@chromium.org [Mon, 17 Mar 2014 12:14:48 +0000 (12:14 +0000)]
Fix result order reliance

The old tests presumed result order in a way was safe because SkPicture was sorting the paint calls.
This fixes the tests to not check result ordering, just presence

BUG=skia:
R=robertphillips@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/197813011

git-svn-id: http://skia.googlecode.com/svn/trunk@13828 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange tilegrid test to test it directly, rather than through SkPicture
commit-bot@chromium.org [Mon, 17 Mar 2014 10:51:44 +0000 (10:51 +0000)]
Change tilegrid test to test it directly, rather than through SkPicture
This is necessary because it makes assumptions that picture will draw all the rects that match the grids, which may not hold if picture decides to improve the accuracy of the results.

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/199083004

git-svn-id: http://skia.googlecode.com/svn/trunk@13827 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFast implementation of QuadTree
commit-bot@chromium.org [Mon, 17 Mar 2014 10:38:34 +0000 (10:38 +0000)]
Fast implementation of QuadTree

Rewritten to avoid memory allocations.

BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/187233002

git-svn-id: http://skia.googlecode.com/svn/trunk@13826 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Mon, 17 Mar 2014 03:02:17 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13825 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd NewRasterDirect for creating a canvas drawing to pre-allocated pixels
commit-bot@chromium.org [Mon, 17 Mar 2014 02:13:07 +0000 (02:13 +0000)]
add NewRasterDirect for creating a canvas drawing to pre-allocated pixels

R=reed@google.com
TBR=scroggo@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/196923004

git-svn-id: http://skia.googlecode.com/svn/trunk@13824 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove SkNoSaveLayerCanvas.h to include/utils
robertphillips@google.com [Sun, 16 Mar 2014 21:59:11 +0000 (21:59 +0000)]
Move SkNoSaveLayerCanvas.h to include/utils

https://codereview.chromium.org/197243005

git-svn-id: http://skia.googlecode.com/svn/trunk@13823 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoProposed SkCanvas API for preLoading textures to VRAM v2.0
commit-bot@chromium.org [Sun, 16 Mar 2014 19:46:36 +0000 (19:46 +0000)]
Proposed SkCanvas API for preLoading textures to VRAM v2.0

This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)).

Committed: http://code.google.com/p/skia/source/detail?r=13810

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197123003

git-svn-id: http://skia.googlecode.com/svn/trunk@13822 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselining stragglers.
senorblanco@chromium.org [Sat, 15 Mar 2014 14:20:35 +0000 (14:20 +0000)]
Rebaselining stragglers.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/197283024

git-svn-id: http://skia.googlecode.com/svn/trunk@13821 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 15 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13820 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore imagefiltersclipped and displacement rebaselines.
senorblanco@chromium.org [Sat, 15 Mar 2014 00:37:33 +0000 (00:37 +0000)]
More imagefiltersclipped and displacement rebaselines.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/197283022

git-svn-id: http://skia.googlecode.com/svn/trunk@13819 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemoves bench expectations files. New place is skia-autogen svn repo. See https:...
commit-bot@chromium.org [Fri, 14 Mar 2014 23:42:16 +0000 (23:42 +0000)]
Removes bench expectations files. New place is skia-autogen svn repo. See https://codereview.chromium.org/196653010/

BUG=skia:2225
NOTRY=true
NOTREECHECKS=true
TBR=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/199143004

git-svn-id: http://skia.googlecode.com/svn/trunk@13818 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange tooBitForLCD to compare against linear size of the text, not the area
commit-bot@chromium.org [Fri, 14 Mar 2014 22:59:05 +0000 (22:59 +0000)]
change tooBitForLCD to compare against linear size of the text, not the area

BUG=skia:
R=bungeman@google.com, alokp@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/200643003

git-svn-id: http://skia.googlecode.com/svn/trunk@13817 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for displacement, imagefiltersclipped GMs.
senorblanco@chromium.org [Fri, 14 Mar 2014 21:55:15 +0000 (21:55 +0000)]
New baselines for displacement, imagefiltersclipped GMs.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/196383021

git-svn-id: http://skia.googlecode.com/svn/trunk@13816 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGet correct text metrics for distance fields, and fix dropouts due to thin features.
commit-bot@chromium.org [Fri, 14 Mar 2014 21:22:38 +0000 (21:22 +0000)]
Get correct text metrics for distance fields, and fix dropouts due to thin features.

BUG=skia:2173
R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/200423003

git-svn-id: http://skia.googlecode.com/svn/trunk@13815 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix a leak
commit-bot@chromium.org [Fri, 14 Mar 2014 21:22:22 +0000 (21:22 +0000)]
fix a leak

R=sugoi@chromium.org, bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/195763025

git-svn-id: http://skia.googlecode.com/svn/trunk@13814 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agodon't reference config() -- use colorType() instead
reed@google.com [Fri, 14 Mar 2014 20:48:05 +0000 (20:48 +0000)]
don't reference config() -- use colorType() instead

BUG=skia:

Review URL: https://codereview.chromium.org/200853002

git-svn-id: http://skia.googlecode.com/svn/trunk@13813 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSuppress imagefilterscropexpand GM temporarily to fix Win Debug failures.
commit-bot@chromium.org [Fri, 14 Mar 2014 19:02:15 +0000 (19:02 +0000)]
Suppress imagefilterscropexpand GM temporarily to fix Win Debug failures.
NOTREECHECKS=true
NOTRY=true
R=halcanary@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/200703002

git-svn-id: http://skia.googlecode.com/svn/trunk@13812 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0)
robertphillips@google.com [Fri, 14 Mar 2014 18:50:07 +0000 (18:50 +0000)]
Revert r13810 (Proposed SkCanvas API for preLoading textures to VRAM v2.0)

git-svn-id: http://skia.googlecode.com/svn/trunk@13811 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoProposed SkCanvas API for preLoading textures to VRAM v2.0
commit-bot@chromium.org [Fri, 14 Mar 2014 18:23:12 +0000 (18:23 +0000)]
Proposed SkCanvas API for preLoading textures to VRAM v2.0

This is an update to (Proposed SkCanvas API for preLoading textures to VRAM - https://codereview.chromium.org/192853002/). It takes into account in-person feedback on the initial proposal. The main feedback was to land this closer to where we will ultimately wind up with the reordered rendering capability (and don't have an SkCanvas entry point (yet)).

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197123003

git-svn-id: http://skia.googlecode.com/svn/trunk@13810 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for expanding crop rects in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 17:44:41 +0000 (17:44 +0000)]
Implement support for expanding crop rects in image filters

NOTE: this patch set is based on https://codereview.chromium.org/189913021/,
and needs that patch to land first.

Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.

In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/189913021/.

Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().

BUG=skia:
R=bsalomon@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13805

Review URL: https://codereview.chromium.org/198003008

git-svn-id: http://skia.googlecode.com/svn/trunk@13809 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG
reed@google.com [Fri, 14 Mar 2014 17:26:15 +0000 (17:26 +0000)]
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG

BUG=skia:

Review URL: https://codereview.chromium.org/200533002

git-svn-id: http://skia.googlecode.com/svn/trunk@13808 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
reed@google.com [Fri, 14 Mar 2014 17:24:05 +0000 (17:24 +0000)]
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES

BUG=skia:

Review URL: https://codereview.chromium.org/195763023

git-svn-id: http://skia.googlecode.com/svn/trunk@13807 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Implement support for expanding crop rects in image filters"
senorblanco@chromium.org [Fri, 14 Mar 2014 16:48:39 +0000 (16:48 +0000)]
Revert "Implement support for expanding crop rects in image filters"

Breaking ImageFilterTests unit test.

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/196353021

git-svn-id: http://skia.googlecode.com/svn/trunk@13806 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for expanding crop rects in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 16:35:08 +0000 (16:35 +0000)]
Implement support for expanding crop rects in image filters

NOTE: this patch set is based on https://codereview.chromium.org/189913021/,
and needs that patch to land first.

Until now, crop rects in Skia have only been able to reduce
the size of the destination bounds, but not expand them.
SVG semantics require the latter as well. The heart of
the change is in applyCropRect(), which now assigns each
edge, instead of doing an intersection with the crop rect.

In order to support this (and still work well with tiled
drawing) we need to clip the resulting crop rect to the
clipping region of the filters. This uses the Context struct
previously landed from https://codereview.chromium.org/189913021/.

Many of the pixel loops are not yet ready to handle a
destination rect larger than the source rect. So we provide
a convenience version of applyCropRect() which creates an
offscreen and pads it out with transparent black. Once the
pixel loops and shaders have been fixed to support larger
destination bounds, they should be switched back to the
non-drawing version of applyCropRect().

BUG=skia:
R=bsalomon@google.com, reed@google.com

Review URL: https://codereview.chromium.org/198003008

git-svn-id: http://skia.googlecode.com/svn/trunk@13805 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agotools/roll_deps: add '-m tryserver.chromium' to git-cl-try
commit-bot@chromium.org [Fri, 14 Mar 2014 15:50:39 +0000 (15:50 +0000)]
tools/roll_deps:  add '-m tryserver.chromium' to git-cl-try

R=rmistry@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/200203003

git-svn-id: http://skia.googlecode.com/svn/trunk@13804 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement support for a Context parameter in image filters
senorblanco@chromium.org [Fri, 14 Mar 2014 15:44:01 +0000 (15:44 +0000)]
Implement support for a Context parameter in image filters

Some upcoming work (support for expanding crop rects) requires
the clip bounds to be available during filter traversal. This change
replaces the SkMatrix parameter in the onFilterImage() traversals
with a Context parameter. It contains the CTM, as well as the clip
bounds.

BUG=skia:
R=reed@google.com

Review URL: https://codereview.chromium.org/189913021

git-svn-id: http://skia.googlecode.com/svn/trunk@13803 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agocheck for null-device pixels in onWritePixels, so we don't crash
reed@google.com [Fri, 14 Mar 2014 14:02:58 +0000 (14:02 +0000)]
check for null-device pixels in onWritePixels, so we don't crash

https://code.google.com/p/chromium/issues/detail?id=352616

Review URL: https://codereview.chromium.org/196223013

git-svn-id: http://skia.googlecode.com/svn/trunk@13802 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agokeep kVector enum in legacy mode for getDeviceProperties
reed@google.com [Fri, 14 Mar 2014 12:32:07 +0000 (12:32 +0000)]
keep kVector enum in legacy mode for getDeviceProperties

git-svn-id: http://skia.googlecode.com/svn/trunk@13801 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 14 Mar 2014 03:02:26 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13800 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDe-virtualize SkCanvas matrix ops.
commit-bot@chromium.org [Thu, 13 Mar 2014 20:03:58 +0000 (20:03 +0000)]
De-virtualize SkCanvas matrix ops.

This moves the matrix management logic into non-virtual SkCanvas
methods, and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com, bsalomon@google.com
BUG=skia:2297

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/195793012

git-svn-id: http://skia.googlecode.com/svn/trunk@13799 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdded Z scale when X and Y scale to spot lights and point lights
commit-bot@chromium.org [Thu, 13 Mar 2014 19:45:41 +0000 (19:45 +0000)]
Added Z scale when X and Y scale to spot lights and point lights

Z scale is set as the average of X scale and Y scale.

BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/198013002

git-svn-id: http://skia.googlecode.com/svn/trunk@13798 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogetDeviceCapabilities is no longer need, so remove it
commit-bot@chromium.org [Thu, 13 Mar 2014 19:38:10 +0000 (19:38 +0000)]
getDeviceCapabilities is no longer need, so remove it

BUG=skia:
R=bungeman@google.com, vandebo@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/198943003

git-svn-id: http://skia.googlecode.com/svn/trunk@13797 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAttempt to fix -1->unsigned warning on mac 10.6
bsalomon@google.com [Thu, 13 Mar 2014 19:20:32 +0000 (19:20 +0000)]
Attempt to fix -1->unsigned warning on mac 10.6

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/199433002

git-svn-id: http://skia.googlecode.com/svn/trunk@13796 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow toString capability to be toggled independent of developer mode.
commit-bot@chromium.org [Thu, 13 Mar 2014 18:02:17 +0000 (18:02 +0000)]
Allow toString capability to be toggled independent of developer mode.

This change is motivated by the desire to see the text information in the debugger when not in developer mode. It is structured so user's can disable it if the capability is not wanted.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/197763008

git-svn-id: http://skia.googlecode.com/svn/trunk@13795 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd effect-based clip for nine-patch SkRRects.
commit-bot@chromium.org [Thu, 13 Mar 2014 18:01:05 +0000 (18:01 +0000)]
Add effect-based clip for nine-patch SkRRects.

BUG=skia:2181
R=jvanverth@google.com, robertphillips@google.com, rmistry@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/194703011

git-svn-id: http://skia.googlecode.com/svn/trunk@13794 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd comment for gcc compiler bug work-around for SK_COMPILE_ASSERT.
bungeman@google.com [Thu, 13 Mar 2014 17:51:05 +0000 (17:51 +0000)]
Add comment for gcc compiler bug work-around for SK_COMPILE_ASSERT.

If this comment had existed previously, I could have avoided breaking
some bots.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/196473013

git-svn-id: http://skia.googlecode.com/svn/trunk@13793 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake rebaseline_server client check schema version number
commit-bot@chromium.org [Thu, 13 Mar 2014 17:44:01 +0000 (17:44 +0000)]
make rebaseline_server client check schema version number

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/195763013

git-svn-id: http://skia.googlecode.com/svn/trunk@13792 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix distance field edge detection.
commit-bot@chromium.org [Thu, 13 Mar 2014 17:11:44 +0000 (17:11 +0000)]
Fix distance field edge detection.

When computing the initial edges for distance field generation, I was skipping
the outer pixels of glyphs to avoid accessing out of range memory. However,
there might be an edge transition on those pixels. This detects those cases.

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/197423003

git-svn-id: http://skia.googlecode.com/svn/trunk@13791 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd schema version to rebaseline_server intermediate JSON
commit-bot@chromium.org [Thu, 13 Mar 2014 16:33:36 +0000 (16:33 +0000)]
add schema version to rebaseline_server intermediate JSON

NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/196343009

git-svn-id: http://skia.googlecode.com/svn/trunk@13790 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChanges to SkFontHost_linux
commit-bot@chromium.org [Thu, 13 Mar 2014 16:24:49 +0000 (16:24 +0000)]
Changes to SkFontHost_linux

* Use SkOSPath::SkPathJoin() rather than append so that
  SK_FONT_FILE_PREFIX does not have to end in a '/'.

* Add another font to the default font list.

Motivation: Some tests fail when there are no default fonts.

BUG=skia:2282
R=bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/195733007

git-svn-id: http://skia.googlecode.com/svn/trunk@13789 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark strokerects_gpu GM as ignore-failure on Win7/Perspective
commit-bot@chromium.org [Thu, 13 Mar 2014 16:23:20 +0000 (16:23 +0000)]
Mark strokerects_gpu GM as ignore-failure on Win7/Perspective

BUG=skia:2295
R=bsalomon@google.com, epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/198923003

git-svn-id: http://skia.googlecode.com/svn/trunk@13788 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago--dryRun flag for bench
commit-bot@chromium.org [Thu, 13 Mar 2014 16:22:00 +0000 (16:22 +0000)]
--dryRun flag for bench

causes bench to print out what tests it would be running, without actually running them.

BUG=skia:2294
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/197873010

git-svn-id: http://skia.googlecode.com/svn/trunk@13787 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix memory leak introduced in 9e5f85e8
commit-bot@chromium.org [Thu, 13 Mar 2014 16:18:49 +0000 (16:18 +0000)]
fix memory leak introduced in 9e5f85e8

R=sugoi@chromium.org, robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/199173002

git-svn-id: http://skia.googlecode.com/svn/trunk@13786 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years ago--dryRun flag for gm
commit-bot@chromium.org [Thu, 13 Mar 2014 16:16:36 +0000 (16:16 +0000)]
--dryRun flag for gm

Causes gm to not actually run any tests / create any directories, just print its normal output.  Useful for showing what tests would be run without actually taking the time to run them.

BUG=skia:2294
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/199093002

git-svn-id: http://skia.googlecode.com/svn/trunk@13785 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew GPU baselines for colormatrix GM.
senorblanco@chromium.org [Thu, 13 Mar 2014 15:33:02 +0000 (15:33 +0000)]
New GPU baselines for colormatrix GM.

TBR=halcanary@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/198973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13784 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: generate JSON that can be viewed without a live server
commit-bot@chromium.org [Thu, 13 Mar 2014 14:56:29 +0000 (14:56 +0000)]
rebaseline_server: generate JSON that can be viewed without a live server

BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/195943004

git-svn-id: http://skia.googlecode.com/svn/trunk@13783 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 13 Mar 2014 03:02:23 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13782 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd required parens for r13779.
bungeman@google.com [Wed, 12 Mar 2014 21:56:23 +0000 (21:56 +0000)]
Add required parens for r13779.

git-svn-id: http://skia.googlecode.com/svn/trunk@13781 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_COPYTO_CONFIG
commit-bot@chromium.org [Wed, 12 Mar 2014 21:47:51 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG

TBR=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/196413009

git-svn-id: http://skia.googlecode.com/svn/trunk@13780 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix (1 << 31) to (1u << 31) in SkOTTable_OS_2.
bungeman@google.com [Wed, 12 Mar 2014 21:41:06 +0000 (21:41 +0000)]
Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.

When ints are 32 bits, (1 << 31) is undefined.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13757

Review URL: https://codereview.chromium.org/189093020

git-svn-id: http://skia.googlecode.com/svn/trunk@13779 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix GPU colormatrix color filter with saturated alpha.
senorblanco@chromium.org [Wed, 12 Mar 2014 21:37:42 +0000 (21:37 +0000)]
Fix GPU colormatrix color filter with saturated alpha.

Clamp RGBA values before unpremultiplying, to match the raster path. This causes a problem when the resulting
alpha is >1.0, resulting in overly saturated RGB.

Covered by the setYUV2RGB() test case in the colormatrix GM.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/196133006

git-svn-id: http://skia.googlecode.com/svn/trunk@13778 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd gm to show bug in stroked-text in drawPosText
commit-bot@chromium.org [Wed, 12 Mar 2014 20:31:24 +0000 (20:31 +0000)]
add gm to show bug in stroked-text in drawPosText

BUG=skia:
R=fmalita@google.com, bungeman@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/198083003

git-svn-id: http://skia.googlecode.com/svn/trunk@13777 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDe-virtualize SkCanvas save/restore.
commit-bot@chromium.org [Wed, 12 Mar 2014 20:21:48 +0000 (20:21 +0000)]
De-virtualize SkCanvas save/restore.

This moves the state management logic into non-virtual SkCanvas methods,
and turns the virtuals into protected notifiers.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/194713008

git-svn-id: http://skia.googlecode.com/svn/trunk@13776 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorender_pictures unittests: run over a dir with multiple SKPs, like production
commit-bot@chromium.org [Wed, 12 Mar 2014 20:09:46 +0000 (20:09 +0000)]
render_pictures unittests: run over a dir with multiple SKPs, like production

BUG=skia:1942
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/194563004

git-svn-id: http://skia.googlecode.com/svn/trunk@13775 2bbb7eff-a529-9590-31e7-b0007b416f81