platform/upstream/coreclr.git
5 years agoMerge pull request #24131 from sandreenko/addAReproTest
Sergey Andreenko [Sat, 20 Apr 2019 08:49:30 +0000 (01:49 -0700)]
Merge pull request #24131 from sandreenko/addAReproTest

Add a repro test for #24114.

5 years agoFix Timezone whitespace (#24137)
Steve MacLean [Sat, 20 Apr 2019 06:07:42 +0000 (02:07 -0400)]
Fix Timezone whitespace (#24137)

5 years agoThe thread triggering finalizer shutdown events should be in an alertable state....
Aaron Robinson [Sat, 20 Apr 2019 05:11:39 +0000 (22:11 -0700)]
The thread triggering finalizer shutdown events should be in an alertable state. (#24133)

5 years agoPulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (#24123)
Tanner Gooding [Sat, 20 Apr 2019 03:33:46 +0000 (20:33 -0700)]
Pulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (#24123)

* Update dependencies from https://github.com/dotnet/corefx build 20190419.5

    - Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.5
    - Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.5

* Removing the Sse2.StoreLow(long/ulong*, ...) methods that have been replaced

* Moving the Sse2.StoreLow(long/ulong*, ...) tests to be Sse2.StoreScalar tests

* Fixing some existing usages of Sse2.StoreLow(long/ulong*, ...)

5 years agoImplement APIs for some threading metrics (CoreCLR) (#24113)
Koundinya Veluri [Sat, 20 Apr 2019 02:22:53 +0000 (19:22 -0700)]
Implement APIs for some threading metrics (CoreCLR) (#24113)

Implement APIs for some threading metrics (CoreCLR)

API review: https://github.com/dotnet/corefx/issues/35500

5 years agoAdd a repro test.
Sergey Andreenko [Fri, 19 Apr 2019 22:42:23 +0000 (15:42 -0700)]
Add a repro test.

5 years agoMerge pull request #24126 from sandreenko/fixStmtBug
Sergey Andreenko [Sat, 20 Apr 2019 01:05:58 +0000 (18:05 -0700)]
Merge pull request #24126 from sandreenko/fixStmtBug

Fix bug in impGetStructAddr.

5 years agoFix `impGetStructAddr`.
Sergey Andreenko [Fri, 19 Apr 2019 22:49:39 +0000 (15:49 -0700)]
Fix `impGetStructAddr`.

5 years agoMerge pull request #24127 from sandreenko/fixArmUbuntuCoreFXTesting
Sergey Andreenko [Sat, 20 Apr 2019 00:15:02 +0000 (17:15 -0700)]
Merge pull request #24127 from sandreenko/fixArmUbuntuCoreFXTesting

Fix Arm32 Ubuntu CoreFX script.

5 years agoFix Arm32 Ubuntu CoreFX script.
Sergey Andreenko [Fri, 19 Apr 2019 23:15:34 +0000 (16:15 -0700)]
Fix Arm32 Ubuntu CoreFX script.

5 years ago[master] Update dependencies from dotnet/corefx (#24058)
dotnet-maestro[bot] [Fri, 19 Apr 2019 22:49:32 +0000 (15:49 -0700)]
[master] Update dependencies from dotnet/corefx (#24058)

* Update dependencies from https://github.com/dotnet/corefx build 20190418.11

- Microsoft.NETCore.Platforms - 3.0.0-preview5.19218.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19218.11

* Disable outdated test

5 years agoLarge Pages on Linux & macOS (#24098)
Mukul Sabharwal [Fri, 19 Apr 2019 21:54:35 +0000 (14:54 -0700)]
Large Pages on Linux & macOS (#24098)

5 years agoExclude failing tests on all platforms/architectures (#24121)
Fadi Hanna [Fri, 19 Apr 2019 21:17:18 +0000 (14:17 -0700)]
Exclude failing tests on all platforms/architectures (#24121)

5 years agoFix project metadata in test (#24119)
Fadi Hanna [Fri, 19 Apr 2019 21:10:09 +0000 (14:10 -0700)]
Fix project metadata in test (#24119)

* Fix project metadata in test

5 years agoRemove commit triggered linux_arm ReadyToRun jobs
Russ Keldorph [Fri, 19 Apr 2019 13:35:55 +0000 (06:35 -0700)]
Remove commit triggered linux_arm ReadyToRun jobs

We don't have the capacity to run these on every commit

5 years ago[master] Update dependencies from dotnet/core-setup (#24059)
dotnet-maestro[bot] [Fri, 19 Apr 2019 16:10:22 +0000 (09:10 -0700)]
[master] Update dependencies from dotnet/core-setup (#24059)

Microsoft.NETCore.App - 3.0.0-preview5-27618-16

5 years agoMove CLR_ADDITIONAL_COMPILER_OPTIONS to be set after default options (#24044)
Andrew Wang [Fri, 19 Apr 2019 16:08:12 +0000 (09:08 -0700)]
Move CLR_ADDITIONAL_COMPILER_OPTIONS to be set after default options (#24044)

CLR_ADDITIONAL_COMPILER_OPTIONS was set before visibility settings and
thus adding additional compiler options would be overwritten.

5 years agoFix build errors in Interop.Errors
Santiago Fernandez Madero [Fri, 19 Apr 2019 05:45:29 +0000 (22:45 -0700)]
Fix build errors in Interop.Errors

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoDisable warning in ValueStringBuilder.ToString
Santiago Fernandez Madero [Fri, 19 Apr 2019 01:43:28 +0000 (18:43 -0700)]
Disable warning in ValueStringBuilder.ToString

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoBlock usage of default interfaces feature in COM scenarios (#23970)
Aaron Robinson [Fri, 19 Apr 2019 16:05:23 +0000 (09:05 -0700)]
Block usage of default interfaces feature in COM scenarios (#23970)

* Block default interface usage in COM scenarios

Add additional test cases and move some CCW functions to a more
consolidated layout.

5 years agoLook for IBC data outside Windows (#24062)
Michal Strehovský [Fri, 19 Apr 2019 13:59:52 +0000 (15:59 +0200)]
Look for IBC data outside Windows (#24062)

#23363 added a crossplat implementation of `GetWin32Resource`, but forgot to enable places that call it.

5 years agoNullable: couple of missing #nullable enable (#24094)
Krzysztof Wicher [Fri, 19 Apr 2019 01:37:37 +0000 (18:37 -0700)]
Nullable: couple of missing #nullable enable (#24094)

5 years agoNullable: System.Collections.Concurrent (#24054)
Stephen Toub [Fri, 19 Apr 2019 01:36:10 +0000 (21:36 -0400)]
Nullable: System.Collections.Concurrent (#24054)

5 years agoFix performance regression on glibc on Linux (#24099)
Filip Navara [Fri, 19 Apr 2019 13:07:47 +0000 (15:07 +0200)]
Fix performance regression on glibc on Linux (#24099)

5 years agoMove R2R-specific code to be outside FEATURE_PREJIT (#24075)
Jan Kotas [Fri, 19 Apr 2019 02:57:17 +0000 (19:57 -0700)]
Move R2R-specific code to be outside FEATURE_PREJIT (#24075)

This refactoring is preparation for disabling fragile NGen support in the runtime. It keeps fragile-NGen specific code under FEATURE_PREJIT and moves the code required to support R2R to be outside FEATURE_PREJIT.

The eventual goal is to compile the runtime without FEATURE_PREJIT defined to avoid fragile-NGen specific overhead.

5 years agoAdding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128...
Tanner Gooding [Fri, 19 Apr 2019 00:44:56 +0000 (17:44 -0700)]
Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128) (#24102)

5 years agoDon't return value types as const (#24103)
Omair Majid [Fri, 19 Apr 2019 00:33:22 +0000 (20:33 -0400)]
Don't return value types as const (#24103)

These types are value types; they are returned by copying. Marking the
return type as const has no effect: since the value is copied, the
caller can modify it anyway.

This resolves all the -Wignored-qualifiers warnings produced by clang 7
(when those warnings are explicitly enabled).

5 years agoMerge pull request #24105 from BruceForstall/ReduceLinuxArm32PeriodicJobs
Bruce Forstall [Thu, 18 Apr 2019 23:29:38 +0000 (16:29 -0700)]
Merge pull request #24105 from BruceForstall/ReduceLinuxArm32PeriodicJobs

Reduce the number of Linux arm32 periodic jobs triggered

5 years agoAllow UpperVector Save and Restore without base type (#24080)
Carol Eidt [Thu, 18 Apr 2019 23:05:34 +0000 (16:05 -0700)]
Allow UpperVector Save and Restore without base type (#24080)

Fixes an issue with crossgen on Arm64/linux

5 years agoReduce the number of Linux arm32 periodic jobs triggered
Bruce Forstall [Thu, 18 Apr 2019 22:45:05 +0000 (15:45 -0700)]
Reduce the number of Linux arm32 periodic jobs triggered

Only the corefx jobs are left. The rest should be done in AzDO,
and scheduling both AzDO and Jenkins is causing too much work
for the few machines we have.

5 years agoFix RVA field placement order (#24047)
Fadi Hanna [Thu, 18 Apr 2019 21:16:47 +0000 (14:16 -0700)]
Fix RVA field placement order (#24047)

* Static RVA fields should be placed sequentially after the qsort operation to not break Managed C++ binaries in R2R

* Add regression test

5 years agoDisable native-client tests on IL round-trip (#24041)
Jeremy Koritzinsky [Thu, 18 Apr 2019 20:49:36 +0000 (15:49 -0500)]
Disable native-client tests on IL round-trip (#24041)

5 years agoIf IPC connections fails, then remove active session. (#24082)
José Rivero [Thu, 18 Apr 2019 20:18:26 +0000 (13:18 -0700)]
If IPC connections fails, then remove active session. (#24082)

5 years agoMerge pull request #24071 from AndyAyersMS/Fix24055
Russ Keldorph [Thu, 18 Apr 2019 18:11:59 +0000 (11:11 -0700)]
Merge pull request #24071 from AndyAyersMS/Fix24055

JIT: fix arm64 crossgen simd issue

5 years agoAdd a destructor for sos::GCHeap (#24072)
Omair Majid [Thu, 18 Apr 2019 17:36:25 +0000 (13:36 -0400)]
Add a destructor for sos::GCHeap (#24072)

The constructor allocates memory via new[]. It should be freed up via
delete[] by a destructor to avoid a memory leak.

5 years agoMerge pull request #23853 from jkoritzinsky/cmake-ninja-fix
Jan Vorlicek [Thu, 18 Apr 2019 15:42:30 +0000 (17:42 +0200)]
Merge pull request #23853 from jkoritzinsky/cmake-ninja-fix

Fix CMake warning about clrjit.exports.in file when using Ninja generator

5 years agoMerge pull request #24066 from janvorli/put-back-cpu-limits
Jan Vorlicek [Thu, 18 Apr 2019 14:53:57 +0000 (16:53 +0200)]
Merge pull request #24066 from janvorli/put-back-cpu-limits

Put back the CPU limiting in GC

5 years agoSkip type sanity checks for CoreLib (#24074)
Jan Kotas [Thu, 18 Apr 2019 14:13:33 +0000 (07:13 -0700)]
Skip type sanity checks for CoreLib (#24074)

5 years agoFixed ChunkEnumerator.Current NRE (#24076)
Benjamin Bartels [Thu, 18 Apr 2019 12:53:22 +0000 (13:53 +0100)]
Fixed ChunkEnumerator.Current NRE (#24076)

* Fixed ChunkEnumerator.Current NRE

* Added Nullable Flow analysis annotation comment

* Changed TODO-NULLABLE comment to link to appropriate issue

5 years agoMerge pull request #23934 from franksinankaya/gcc_cleanup_18
Jan Vorlicek [Thu, 18 Apr 2019 08:27:27 +0000 (10:27 +0200)]
Merge pull request #23934 from franksinankaya/gcc_cleanup_18

Integer Conversion Issues from GCC

5 years agoMerge pull request #23762 from dotnet/NullableFeature
Santiago Fernandez Madero [Thu, 18 Apr 2019 01:17:55 +0000 (20:17 -0500)]
Merge pull request #23762 from dotnet/NullableFeature

Nullable feature into master

5 years agoanother similar fix
Andy Ayers [Thu, 18 Apr 2019 00:03:12 +0000 (17:03 -0700)]
another similar fix

5 years agoRemoving the unnecessary friend relationship
Andrew Au [Wed, 17 Apr 2019 18:37:26 +0000 (11:37 -0700)]
Removing the unnecessary friend relationship

5 years agoMerge pull request #24067 from briansull/desktop-fix2
Brian Sullivan [Wed, 17 Apr 2019 22:23:02 +0000 (15:23 -0700)]
Merge pull request #24067 from briansull/desktop-fix2

Fix for Desktop build break

5 years agoAdded comment on #endif
Brian Sullivan [Wed, 17 Apr 2019 22:21:03 +0000 (15:21 -0700)]
Added comment on #endif

5 years agoJIT: fix arm64 crossgen simd issue
Andy Ayers [Wed, 17 Apr 2019 21:32:07 +0000 (14:32 -0700)]
JIT: fix arm64 crossgen simd issue

Need to check `supportSIMDType()` and not `featureSIMD` in rationalize.

Fixes #24055.

5 years agoJIT: ignore pinning of non-gc types (#24010)
Andy Ayers [Wed, 17 Apr 2019 21:23:11 +0000 (14:23 -0700)]
JIT: ignore pinning of non-gc types (#24010)

We may see pin modifiers on locals that are not gc types.
Ignore these modifiers.

Closes #23950.

Also added a missing copyright header on an unrelated test.

5 years agoFix StringBuilder annotations and debug.asserts (#24069)
Santiago Fernandez Madero [Wed, 17 Apr 2019 20:10:13 +0000 (15:10 -0500)]
Fix StringBuilder annotations and debug.asserts (#24069)

5 years agoRuntime counters naming change and setting default rates. (#24052)
Sung Yoon Whang [Wed, 17 Apr 2019 20:05:57 +0000 (13:05 -0700)]
Runtime counters naming change and setting default rates.  (#24052)

* Renaming runtime counters and giving them DisplayNames

* fix build err

* Adding default DisplayRateTimeScale to runtime counters

5 years agoRestrict morph add rearrangement. (#23984)
Eugene Rozenfeld [Wed, 17 Apr 2019 19:59:31 +0000 (12:59 -0700)]
Restrict morph add rearrangement. (#23984)

Morph has transformations
((x + const) + y) => ((x + y) + const)
and
((x + const1) + (y + const2)) => ((x + y) + (const1 + const2))

If x or y is a GC pointer and one of the int operands may be negative,
this may result in a byref temp that points outside of the ref object.
If the code is in a non-interruptible region and a GC happens, the byref
won't be updated.

This change disallows the transformations if one of the non-const
operands is a GC pointer.

Fixes #23792.

5 years agoMerge pull request #24065 from sandreenko/fixCoreFXScripts
Sergey Andreenko [Wed, 17 Apr 2019 19:31:33 +0000 (12:31 -0700)]
Merge pull request #24065 from sandreenko/fixCoreFXScripts

Add --runtime-path to CoreFX test runner.

5 years agoFix for Desktop build break
Brian Sullivan [Wed, 17 Apr 2019 18:18:09 +0000 (11:18 -0700)]
Fix for Desktop build break

5 years agoAdd lvIsImplicitByRef information to lvaSetStruct (#19223)
Jarret Shook [Wed, 17 Apr 2019 18:06:16 +0000 (11:06 -0700)]
Add lvIsImplicitByRef information to lvaSetStruct (#19223)

Before implicit byrefs were tracked by setting lvIsParam and lvIsTemp.
This change explicitly adds a flag for implicitByRef instead of overloading.
In addition, it fixes the decision to copy an implicitByRef for arm64 varargs.

Temporarily bump weight on byref params to match old behavior and avoid codegen
diffs.

Re-enabled various tests and parts of tests.

Closes #20046
Closes #19860

5 years agoPut back the CPU limiting in GC
Jan Vorlicek [Wed, 17 Apr 2019 17:59:41 +0000 (10:59 -0700)]
Put back the CPU limiting in GC

The CPU limiting was accidentally removed during refactoring of the CPU
groups support in GC. This change puts them back.

5 years agoAdd --runtime-path to CoreFX test runner.
Sergey Andreenko [Wed, 17 Apr 2019 17:52:05 +0000 (10:52 -0700)]
Add --runtime-path to CoreFX test runner.

5 years agoUpdate the types consumers of Index and Range (#24036)
Tarek Mahmoud Sayed [Wed, 17 Apr 2019 16:54:51 +0000 (17:54 +0100)]
Update the types consumers of Index and Range (#24036)

* Update the types consumers of Index and Range

The C# compiler now can automatically support the indexers with Index and Range parameters on any type meet the conditions:
- The type exposes Length or Count property which returning integer.
- The type has indexer of integer parameter.
- The type has a Slice method which takes 2 integers

The change here is to remove the methods and indexers of the types which we previously added it as the compiler will automatically provide those.

* Remove the JIT failing test

5 years agoExclude ToString_NullFrame_ThrowsNullReferenceException test from nullable change
Santiago Fernandez Madero [Wed, 17 Apr 2019 04:19:13 +0000 (21:19 -0700)]
Exclude ToString_NullFrame_ThrowsNullReferenceException test from nullable change

5 years agoFix a ZeroMemory call in methodcontext.cpp (#23843)
Omair Majid [Wed, 17 Apr 2019 03:18:37 +0000 (23:18 -0400)]
Fix a ZeroMemory call in methodcontext.cpp (#23843)

The argument is of type `GetArgTypeValue` and so the `sizeof()` should be
done on `GetArgTypeValue`, not on the different type `GetArgType`.

5 years agoNit: Update comment (#23896)
Next Turn [Wed, 17 Apr 2019 03:17:33 +0000 (11:17 +0800)]
Nit: Update comment (#23896)

5 years agoUpdate CoreClr to preview5-27616-71 (#24020)
dotnet-maestro-bot [Wed, 17 Apr 2019 03:15:18 +0000 (20:15 -0700)]
Update CoreClr to preview5-27616-71 (#24020)

5 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190415.16 (#24030)
dotnet-maestro[bot] [Wed, 17 Apr 2019 03:14:41 +0000 (20:14 -0700)]
Update dependencies from https://github.com/dotnet/corefx build 20190415.16 (#24030)

- Microsoft.NETCore.Platforms - 3.0.0-preview5.19215.16
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19215.16

5 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190415.12 (#24029)
dotnet-maestro[bot] [Wed, 17 Apr 2019 03:14:22 +0000 (20:14 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20190415.12 (#24029)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19215.12
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19215.12

5 years agoRemove limits on IVT public key lengths. (#24042)
Jeremy Koritzinsky [Wed, 17 Apr 2019 03:13:29 +0000 (20:13 -0700)]
Remove limits on IVT public key lengths. (#24042)

5 years agoChanging Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitude to propagate...
Tanner Gooding [Wed, 17 Apr 2019 03:13:12 +0000 (20:13 -0700)]
Changing Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitude to propagate NaN inputs (#24039)

5 years agoFix incorrect EHCount calculation (#24048)
Levi Broderick [Wed, 17 Apr 2019 03:12:12 +0000 (20:12 -0700)]
Fix incorrect EHCount calculation (#24048)

5 years agoFix incorrect thread affinitization (#24045)
Jan Vorlicek [Wed, 17 Apr 2019 03:11:35 +0000 (05:11 +0200)]
Fix incorrect thread affinitization (#24045)

The PAL_SetCurrentThreadAffinity was incorrectly adding the specified processor
to the current thread affinity set instead of setting the affinity to only
the processor specified.
It was causing significant performance hit in aspnet benchmarks on machines with
many cores.
This change crept in when I was refactoring the related code while removing
CPU groups emulation.

5 years ago[EventPipe] Minor bug fixes, and remove redundant/unused code. (#23956)
José Rivero [Wed, 17 Apr 2019 01:58:31 +0000 (18:58 -0700)]
[EventPipe] Minor bug fixes, and remove redundant/unused code. (#23956)

- Update MicrosoftDiagnosticsTracingTraceEventPackageVersion
- Delete connection if the request is unknown/unhandled
- Adding missing error handling.
  - Provider names must be defined.
- Some renaming, error handling, and build warnings.
- Removing test code, and merge EventPipe::Enable functions.
- Remove commented/non-used lines.

5 years agoMerge pull request #24037 from BruceForstall/ReduceStackRequirement
Bruce Forstall [Tue, 16 Apr 2019 23:28:49 +0000 (16:28 -0700)]
Merge pull request #24037 from BruceForstall/ReduceStackRequirement

Reduce stack requirements of test

5 years agoMerge pull request #24002 from sandreenko/fixDesktopFailure
Sergey Andreenko [Tue, 16 Apr 2019 21:52:15 +0000 (14:52 -0700)]
Merge pull request #24002 from sandreenko/fixDesktopFailure

Another surgery fix for genPutArgStk to fix desktop build.

5 years agoFix if condition in AssemblyLoadContext
Santiago Fernandez Madero [Tue, 16 Apr 2019 20:24:55 +0000 (13:24 -0700)]
Fix if condition in AssemblyLoadContext

5 years agoMerge pull request #23947 from sandreenko/reenableSystem.ComponentModel.Composition...
Sergey Andreenko [Tue, 16 Apr 2019 19:48:27 +0000 (12:48 -0700)]
Merge pull request #23947 from sandreenko/reenableSystem.ComponentModel.Composition.Tests

Reenable System.ComponentModel.Composition.Tests arm64 Windows.

5 years agoReduce stack requirements of test
Bruce Forstall [Tue, 16 Apr 2019 18:52:04 +0000 (11:52 -0700)]
Reduce stack requirements of test

Fixes #24021

5 years agoUse lvaGetDesc.
Sergey Andreenko [Tue, 16 Apr 2019 18:12:13 +0000 (11:12 -0700)]
Use lvaGetDesc.

5 years agoNullable: Addition COM types (#24032)
Stephen Toub [Tue, 16 Apr 2019 17:24:31 +0000 (13:24 -0400)]
Nullable: Addition COM types (#24032)

Somehow these slipped through previous rounds of annotating.

5 years agoMerge remote-tracking branch 'dotnet/master' into NullableFeature
Santiago Fernandez Madero [Tue, 16 Apr 2019 16:55:59 +0000 (09:55 -0700)]
Merge remote-tracking branch 'dotnet/master' into NullableFeature

5 years agoDowngrade xUnit package version (#23944)
Egor Chesakov [Tue, 16 Apr 2019 16:49:38 +0000 (09:49 -0700)]
Downgrade xUnit package version (#23944)

* Use the same version of xUnit that arcade uses (2.4.1-pre.build.4059)

5 years agoArm64 vector ABI (#23675)
Carol Eidt [Tue, 16 Apr 2019 16:35:49 +0000 (09:35 -0700)]
Arm64 vector ABI (#23675)

* Support for Arm64 Vector ABI

Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Also, fix and re-enable the disabled Arm64 Simd tests.

Fix #16022

5 years agoTest remove ContextualReflectionProxy (#24006)
Steve MacLean [Tue, 16 Apr 2019 15:23:43 +0000 (11:23 -0400)]
Test remove ContextualReflectionProxy (#24006)

5 years agoUpdate ContextualReflection doc (#24018)
Steve MacLean [Tue, 16 Apr 2019 15:20:31 +0000 (11:20 -0400)]
Update ContextualReflection doc (#24018)

* Update ContextualReflection doc

* PR Feedback

5 years agoUse delete [] on array types (#24027)
Omair Majid [Tue, 16 Apr 2019 14:43:09 +0000 (10:43 -0400)]
Use delete [] on array types (#24027)

Calling delete on types allocated with new[] leads to undefined
behaviour.

5 years agoMove EventSource to shared CoreLib partition (#23925)
Filip Navara [Tue, 16 Apr 2019 13:52:53 +0000 (15:52 +0200)]
Move EventSource to shared CoreLib partition (#23925)

* Move most of EventSource to shared CoreLib partition

* Reenable some code that can be shared with Microsoft.Diagnostics.Tracing.EventSource.Redist in CoreFX

* Remove unused functions

* Fix placement of #endregion

* Clean up P/Invoke prototypes

* Move remaining code from EventSource_CoreCLR to shared partition (guarded by !CORERT)

* Remove more unnecessary marshalling attributes

* Move remaining CoreRT/ProjectN code to shared partition

* Avoid using Windows errors on non-Windows platforms

5 years agoMerge pull request #24009 from sandreenko/fixLsraBlockEpochCheck
Sergey Andreenko [Tue, 16 Apr 2019 08:49:23 +0000 (01:49 -0700)]
Merge pull request #24009 from sandreenko/fixLsraBlockEpochCheck

Fix lsraBlockEpoch check.

5 years agoUse NewArrayHolder for array types in src/debug (#24013)
Omair Majid [Tue, 16 Apr 2019 05:14:48 +0000 (01:14 -0400)]
Use NewArrayHolder for array types in src/debug (#24013)

Using a NewHolder with array types means that when the holder is ready
to release the  memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.

Use NewArrayHolder isntead to fix this.

5 years agoUse NewArrayHolder for array types (#24017)
Omair Majid [Tue, 16 Apr 2019 05:12:39 +0000 (01:12 -0400)]
Use NewArrayHolder for array types (#24017)

This touches all the code outside of src/debug/.

Using a NewHolder with array types means that when the holder is ready
to release the memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.

Use NewArrayHolder instead to fix this.

5 years agoConversion issues
Sinan Kaya [Fri, 12 Apr 2019 05:57:37 +0000 (05:57 +0000)]
Conversion issues

5 years agoFix an issue with literal 0xFFFFFFFFFFFFF000LL being treated as unsigned long long...
Egor Chesakov [Tue, 16 Apr 2019 04:07:33 +0000 (21:07 -0700)]
Fix an issue with literal 0xFFFFFFFFFFFFF000LL being treated as unsigned long long int (#24011)

5 years agoUpdate clr-configuration-knobs and cleanups (#24016)
Adeel Mujahid [Tue, 16 Apr 2019 02:36:44 +0000 (03:36 +0100)]
Update clr-configuration-knobs and cleanups (#24016)

5 years agoFix incorrect bit match pattern in UTF-16 validation (#24015)
Levi Broderick [Tue, 16 Apr 2019 01:28:39 +0000 (18:28 -0700)]
Fix incorrect bit match pattern in UTF-16 validation (#24015)

5 years agoFold ResourceSet::CommonInit into constructor (#23993)
Jan Kotas [Tue, 16 Apr 2019 00:37:41 +0000 (17:37 -0700)]
Fold ResourceSet::CommonInit into constructor (#23993)

5 years agoFix lsraBlockEpoch check.
Sergey Andreenko [Mon, 15 Apr 2019 22:38:44 +0000 (15:38 -0700)]
Fix lsraBlockEpoch check.

5 years agoInitialize IsolatedComponentLoadContext.Name (#24001)
Steve MacLean [Mon, 15 Apr 2019 23:59:36 +0000 (19:59 -0400)]
Initialize IsolatedComponentLoadContext.Name (#24001)

5 years agoAdd "partial" to MarshalAsAttribute (#24014)
Egor Bogatov [Mon, 15 Apr 2019 23:44:04 +0000 (02:44 +0300)]
Add "partial" to MarshalAsAttribute (#24014)

5 years agoDelete unused YieldProcessorScalingFactor from GC (#23994)
Jan Kotas [Mon, 15 Apr 2019 23:30:00 +0000 (16:30 -0700)]
Delete unused YieldProcessorScalingFactor from GC (#23994)

5 years agoRemove redundant UnderlyingSystemType calls (#24000)
Jan Kotas [Mon, 15 Apr 2019 23:29:41 +0000 (16:29 -0700)]
Remove redundant UnderlyingSystemType calls (#24000)

UnderlyingSystemType is virtual

5 years agoCheck for null methodhandle before checking if the method is in the same version...
Fadi Hanna [Mon, 15 Apr 2019 23:25:16 +0000 (16:25 -0700)]
Check for null methodhandle before checking if the method is in the same version bubble (#23940)

5 years agoFix precompiling CoreRoot overlay with crossgen for Windows arm/arm64 (#23946)
Sergiy Kuryata [Mon, 15 Apr 2019 23:07:35 +0000 (16:07 -0700)]
Fix precompiling CoreRoot overlay with crossgen for Windows arm/arm64 (#23946)

5 years agoOpt COM methods out of the new Windows instance-method handling. (#23974)
Jeremy Koritzinsky [Mon, 15 Apr 2019 22:54:51 +0000 (15:54 -0700)]
Opt COM methods out of the new Windows instance-method handling. (#23974)

* Opt COM methods out of the new Windows instance-method handling.

* Add test for an HResult "struct" returned from a COM method.

* Update ErrorMarshalTesting.cs

* Update "is member function" check on the ilmarshalers.h side to only consider thiscall.

5 years agoImproved performance of System.Reflection.Emit API (#23833)
Benjamin Bartels [Mon, 15 Apr 2019 22:09:10 +0000 (23:09 +0100)]
Improved performance of System.Reflection.Emit API (#23833)

* Improved performance of System.Reflection.Emit API

* Moved heap allocation to stack

* Eliminating conditional branch by casting sbyte to byte

* Reduced heap allocation of ScopeTree

* Removed redundant `unsafe` from function signature

5 years agoMerge pull request #23997 from safern/merge-master-nullable
Santiago Fernandez Madero [Mon, 15 Apr 2019 21:19:32 +0000 (16:19 -0500)]
Merge pull request #23997 from safern/merge-master-nullable

Merge master into nullable feature

5 years agoFix build errors from merge conflicts and compiler update
Santiago Fernandez Madero [Mon, 15 Apr 2019 18:25:36 +0000 (11:25 -0700)]
Fix build errors from merge conflicts and compiler update