profile/ivi/webkit-efl.git
12 years agoWebKit should throttle memory pressure notifications in proportion to handler time
msaboff@apple.com [Mon, 2 Apr 2012 18:13:37 +0000 (18:13 +0000)]
WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674

Reviewed by Geoffrey Garen.

Changed the MemoryPressureHandler hold off timer to start timing after
respondToMemoryPressure runs.  The delay time is now 20 times longer than the
time it took for respondToMemoryPressure to run with a minimum of 5 seconds.
This throttles the response to low memory events in the extreme case where
we are spending most of our time paging / swapping.
This is a Mac only change.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112163.
commit-queue@webkit.org [Mon, 2 Apr 2012 18:06:58 +0000 (18:06 +0000)]
Unreviewed, rolling out r112163.
http://trac.webkit.org/changeset/112163
https://bugs.webkit.org/show_bug.cgi?id=82914

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8Proxy.h:
(WebCore::toV8):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112318.
commit-queue@webkit.org [Mon, 2 Apr 2012 17:56:58 +0000 (17:56 +0000)]
Unreviewed, rolling out r112318.
http://trac.webkit.org/changeset/112318
https://bugs.webkit.org/show_bug.cgi?id=82912

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
schenney@chromium.org [Mon, 2 Apr 2012 17:52:10 +0000 (17:52 +0000)]
<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
https://bugs.webkit.org/show_bug.cgi?id=81631

Unreviewed Chromium expectations update.

* platform/chromium-linux-x86/tables: Removed.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
* platform/chromium-win-vista/tables: Removed.
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt:
* platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/writing-mode/block-level-images-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, skip failing inspector test on GTK.
philn@webkit.org [Mon, 2 Apr 2012 17:46:51 +0000 (17:46 +0000)]
Unreviewed, skip failing inspector test on GTK.

* platform/gtk/Skipped: Skip inspector/styles/override-screen-size.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMissing NULL check for vendor string from glGetString()
commit-queue@webkit.org [Mon, 2 Apr 2012 17:32:17 +0000 (17:32 +0000)]
Missing NULL check for vendor string from glGetString()
https://bugs.webkit.org/show_bug.cgi?id=82859

Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-02
Reviewed by Kentaro Hara.

glGetString() possible to return NULL value.
Refer to http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml
for more information. The missing null check crashes webkit when
vendor name is not set (null) by glGetString().

No new tests because this is missing NULL check for
for openGL API response.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::validateAttributes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSuppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
fischman@chromium.org [Mon, 2 Apr 2012 17:16:01 +0000 (17:16 +0000)]
Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
https://bugs.webkit.org/show_bug.cgi?id=82906

Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleLoad):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: CPU time bar missing on top-level events in timeline panel
caseq@chromium.org [Mon, 2 Apr 2012 17:13:12 +0000 (17:13 +0000)]
Web Inspector: CPU time bar missing on top-level events in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82909

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.addRecord):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRenaming parameters for positioning a track cue
eric.carlson@apple.com [Mon, 2 Apr 2012 17:10:34 +0000 (17:10 +0000)]
Renaming parameters for positioning a track cue
https://bugs.webkit.org/show_bug.cgi?id=78706

Source/WebCore:

Change WebVTT settings identifiers for spec change: D: -> vertical:, L: -> line:,
T: -> position:, S: -> size:, A: -> align:

Reviewed by Sam Weinig.

No new tests, existing tests updated for spec changes.

* html/track/TextTrackCue.cpp:
(WebCore::verticalGrowingLeftKeyword): Drive-by change to improve readability.
(WebCore::TextTrackCue::settingName): New, parse the settings keyword.
(WebCore::TextTrackCue::parseSettings): Update to match the current spec.
* html/track/TextTrackCue.h:

* html/track/WebVTTParser.h:
(WebCore::WebVTTParser::isValidSettingDelimiter): New.

LayoutTests:

Reviewed by Sam Weinig.

* media/track/captions-webvtt/missed-cues.vtt:
* media/track/captions-webvtt/sorted-dispatch.vtt:
* media/track/captions-webvtt/tc005-default-styles.vtt:
* media/track/captions-webvtt/tc014-alignment-bad.vtt:
* media/track/captions-webvtt/tc014-alignment-ltr.vtt:
* media/track/captions-webvtt/tc014-alignment.vtt:
* media/track/captions-webvtt/tc015-positioning-bad.vtt:
* media/track/captions-webvtt/tc015-positioning-ltr.vtt:
* media/track/captions-webvtt/tc015-positioning.vtt:
* media/track/captions-webvtt/tc016-align-positioning-bad.vtt:
* media/track/captions-webvtt/tc016-align-positioning.vtt:
* media/track/captions-webvtt/tc017-line-position-bad.vtt:
* media/track/captions-webvtt/tc017-line-position.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position.vtt:
* media/track/captions-webvtt/tc019-cue-size-bad.vtt:
* media/track/captions-webvtt/tc019-cue-size.vtt:
* media/track/captions-webvtt/tc020-cue-size-align-bad.vtt:
* media/track/captions-webvtt/tc020-cue-size-align.vtt:
* media/track/captions-webvtt/tc021-valign-bad.vtt:
* media/track/captions-webvtt/tc021-valign-ltr.vtt:
* media/track/captions-webvtt/tc021-valign.vtt:
* media/track/captions-webvtt/tc022-entities-wrong.vtt:
* media/track/captions-webvtt/tc022-entities.vtt:
* media/track/captions-webvtt/tc023-markup-bad.vtt:
* media/track/captions-webvtt/tc023-markup.vtt:
* media/track/captions-webvtt/tc024-timestamp-bad.vtt:
* media/track/captions-webvtt/tc024-timestamp.vtt:
* media/track/captions-webvtt/tc025-class-bad.vtt:
* media/track/captions-webvtt/tc025-class.vtt:
* media/track/captions-webvtt/tc026-voice-bad.vtt:
* media/track/captions-webvtt/tc026-voice.vtt:
* media/track/captions-webvtt/tc027-empty-cue.vtt:
* media/track/captions-webvtt/tc028-unsupported-markup.vtt:
    Update settings for spec change.

* media/track/captions-webvtt/tc013-settings-bad-separation.vtt:
* media/track/captions-webvtt/tc013-settings.vtt:
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc013-settings.html:
    Update test and results to skip illegal settings delimiters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, CCLayerTreeHost runMultiThread is flaky.
apavlov@chromium.org [Mon, 2 Apr 2012 16:39:14 +0000 (16:39 +0000)]
[Chromium] Unreviewed, CCLayerTreeHost runMultiThread is flaky.
Related bug: https://bugs.webkit.org/show_bug.cgi?id=80811

Disabled CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread.

* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, mark http/tests/xmlhttprequest/upload-progress-events.html...
apavlov@chromium.org [Mon, 2 Apr 2012 16:23:30 +0000 (16:23 +0000)]
[Chromium] Unreviewed, mark http/tests/xmlhttprequest/upload-progress-events.html as crashy on Linux Debug

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd setting to disable Java for local files even if it is otherwise enabled
weinig@apple.com [Mon, 2 Apr 2012 16:22:25 +0000 (16:22 +0000)]
Add setting to disable Java for local files even if it is otherwise enabled
https://bugs.webkit.org/show_bug.cgi?id=82685

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Export setting setter.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::canEmbedJava):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* page/Navigator.cpp:
(WebCore::Navigator::javaEnabled):
Check for both isJavaEnabled and isJavaEnabledForLocalFiles.

* page/Settings.cpp:
(WebCore::Settings::setJavaEnabledForLocalFiles):
* page/Settings.h:
(WebCore::Settings::isJavaEnabledForLocalFiles):
Add new setting.

Source/WebKit2:

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaEnabledForLocalFiles):
(WKPreferencesGetJavaEnabledForLocalFiles):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add pref as SPI and forward to WebCore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSome SVG tests are crashing
schenney@chromium.org [Mon, 2 Apr 2012 16:13:16 +0000 (16:13 +0000)]
Some SVG tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=82232

Unreviewed Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Device metrics emulation should turn off when zero width and height...
apavlov@chromium.org [Mon, 2 Apr 2012 16:07:53 +0000 (16:07 +0000)]
Web Inspector: Device metrics emulation should turn off when zero width and height are passed in
https://bugs.webkit.org/show_bug.cgi?id=82907

Currently this also requires the fontScaleFactor of 1 to be passed in, too. However, it results in
downsizing the FrameView to (0x0) on navigation with the open Inspector when the emulation is disabled.

Reviewed by Yury Semikhatsky.

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
schenney@chromium.org [Mon, 2 Apr 2012 15:41:26 +0000 (15:41 +0000)]
LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469

Unreviewed Chromium test_expectations update.

These tests are skipped on Mac and the Mac baselines are hence wrong.
Comments on Bug 82469 indicate that our results are correct.

* platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Set up plugin process on Unix
kbalazs@webkit.org [Mon, 2 Apr 2012 15:35:37 +0000 (15:35 +0000)]
[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

* Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

* GNUmakefile.am:
* PluginProcess.pro: Added.

* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit):
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

* Shared/ProcessExecutablePath.h: Added.
(WebKit):
* Shared/gtk/ProcessExecutablePathGtk.cpp: Added.
(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):
* Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.
(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

* qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.
(WebKit):
(main):

Tools:

* qmake/mkspecs/features/features.prf: Reenable plugins
and turn on plugin process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, update test expectations.
apavlov@chromium.org [Mon, 2 Apr 2012 15:27:29 +0000 (15:27 +0000)]
[Chromium] Unreviewed, update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112868, r112879, and r112881.
kbalazs@webkit.org [Mon, 2 Apr 2012 15:17:12 +0000 (15:17 +0000)]
Unreviewed, rolling out r112868, r112879, and r112881.
http://trac.webkit.org/changeset/112868
http://trac.webkit.org/changeset/112879
http://trac.webkit.org/changeset/112881
https://bugs.webkit.org/show_bug.cgi?id=82901

"Build fail on bots." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

.:

* Source/QtWebKit.pro:

Source/WebKit2:

* GNUmakefile.am:
* PluginProcess.pro: Removed.
* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
* Shared/Plugins/Netscape/NetscapePluginModule.h:
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::initializeGTK):
(WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad):
(WebKit::NetscapePluginModule::setMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/ProcessExecutablePath.h: Removed.
* Shared/gtk/ProcessExecutablePathGtk.cpp: Removed.
* Shared/qt/ProcessExecutablePathQt.cpp: Removed.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit):
(WebKit::findWebKitProcess):
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* qt/PluginMainQt.cpp: Removed.

Tools:

* MiniBrowser/gtk/GNUmakefile.am:
* qmake/mkspecs/features/features.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline after r112882.
philn@webkit.org [Mon, 2 Apr 2012 15:06:38 +0000 (15:06 +0000)]
Unreviewed, GTK rebaseline after r112882.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Skip inspector/profiler/heap-snapshot-inspect-dom-wrapper.html in
yurys@chromium.org [Mon, 2 Apr 2012 14:48:44 +0000 (14:48 +0000)]
Unreviewed. Skip inspector/profiler/heap-snapshot-inspect-dom-wrapper.html in
debug mode as it crashes.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Implement frontend for device metrics emulation
apavlov@chromium.org [Mon, 2 Apr 2012 14:45:29 +0000 (14:45 +0000)]
Web Inspector: Implement frontend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82891

This change implements the backend-based device metrics emulation capability discovery,
UI (enablement checkbox + input controls), and a persistence setting
for the user-specified device metrics (screen width/height and an auxiliary font scale factor).

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
(WebInspector.SettingsScreen.prototype.set _applyDeviceMetricsUserInput):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride.set if):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.createInput):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
* inspector/front-end/UserAgentSupport.js: Added.
(WebInspector.UserAgentSupport.DeviceMetrics):
(WebInspector.UserAgentSupport.DeviceMetrics.parseSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.parseUserInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isWidthValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isHeightValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isFontScaleFactorValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.toSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.widthToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.heightToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.fontScaleFactorToInput):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/helpScreen.css:
(.help-table > tr > th):
(.help-table > tr > td):
(#resolution-override-section):
* inspector/front-end/inspector.css:
(.hidden):
(.error-input):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Enable shadow-dom in build-webkit.
philn@webkit.org [Mon, 2 Apr 2012 14:29:43 +0000 (14:29 +0000)]
[GTK] Enable shadow-dom in build-webkit.

Rubber-stamped by Gustavo Noronha Silva.

* Scripts/build-webkit: Enable shadow-dom build, this is need to
have a working build currently.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOne more try to fix Qt build after r112868.
kbalazs@webkit.org [Mon, 2 Apr 2012 14:28:22 +0000 (14:28 +0000)]
One more try to fix Qt build after r112868.

It's a misery why I don't have these build failures
locally.

* PluginProcess.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename CSSPropertyLonghand class to StylePropertyShorthand.
alexis.menard@openbossa.org [Mon, 2 Apr 2012 14:19:46 +0000 (14:19 +0000)]
Rename CSSPropertyLonghand class to StylePropertyShorthand.
https://bugs.webkit.org/show_bug.cgi?id=82624

Reviewed by Antti Koivisto.

Rename CSSPropertyLonghand to StylePropertyShorthand as what CSSPropertyLonghand
is representing is not a longhand but the list of longhands for a given shorthand.
Also in the same time switch all shorthand declarations to use CSSPropertyID enum
rather than a int so it is clear on what kind of data we are dealing with.

In a following patch I will rename CSSPropertyLonghand file.

No new tests : This is a refactoring, no behaviour change intended

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
* css/CSSPropertyLonghand.cpp:
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):
* css/CSSPropertyLonghand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(StylePropertyShorthand):
(WebCore):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* editing/EditingStyle.cpp:
(WebCore):
(WebCore::removePropertiesInStyle):
* page/animation/AnimationBase.cpp:
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::addShorthandProperties):
* page/animation/CompositeAnimation.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Qt build after r112868.
kbalazs@webkit.org [Mon, 2 Apr 2012 14:15:34 +0000 (14:15 +0000)]
Fix Qt build after r112868.

* PluginProcess.pro: Add WTF into includepath.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, baseline for fast/dom/shadow/form-in-shadow.html
apavlov@chromium.org [Mon, 2 Apr 2012 14:02:55 +0000 (14:02 +0000)]
[Chromium] Unreviewed, baseline for fast/dom/shadow/form-in-shadow.html

* platform/chromium/fast/dom/shadow/form-in-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding Zalan Bujtas to committers list.
kling@webkit.org [Mon, 2 Apr 2012 13:58:45 +0000 (13:58 +0000)]
Adding Zalan Bujtas to committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: refactor UI breakpoint listeners.
podivilov@chromium.org [Mon, 2 Apr 2012 13:55:50 +0000 (13:55 +0000)]
Web Inspector: refactor UI breakpoint listeners.
https://bugs.webkit.org/show_bug.cgi?id=82481

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are currently dispatched on UISourceCode.
That allows us to move handlers that manage SourceFrame's breakpoint decorations from ScriptsPanel to SourceFrame.
SourceFrame's "Loaded" event is removed as it was only used by ScriptsPanel to restore SourceFrame's breakpoints.

* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointRemoved):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextViewerContentLoaded):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):
* inspector/debugger/live-edit.html:
* inspector/debugger/set-breakpoint.html:
* inspector/debugger/source-frame.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Mon, 2 Apr 2012 13:44:48 +0000 (13:44 +0000)]
[Qt] Unreviewed gardening.

Web Inspector: Implement support for InspectorClient::overrideDeviceMetrics() in platforms other than Chromium
https://bugs.webkit.org/show_bug.cgi?id=82886

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-02

* platform/qt/Skipped: Skip inspector/styles/override-screen-size.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling chromium DEPS.
kinuko@chromium.org [Mon, 2 Apr 2012 13:42:54 +0000 (13:42 +0000)]
Unreviewed, rolling chromium DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt: Doc: Fix typo which marks document to be printed in console font.
commit-queue@webkit.org [Mon, 2 Apr 2012 13:41:58 +0000 (13:41 +0000)]
Qt: Doc: Fix typo which marks document to be printed in console font.
https://bugs.webkit.org/show_bug.cgi?id=82893

Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-04-02
Reviewed by Simon Hausmann.

The qtwebkit-bridge.qdoc file contained a typo where a \c {} was
missing its closing curly bracket, this marked the rest of the page as
text to be printed using the code/console font.
* docs/qtwebkit-bridge.qdoc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Call resize on frameview in WebPage::resizeToContentsIfNeeded only when...
commit-queue@webkit.org [Mon, 2 Apr 2012 13:37:43 +0000 (13:37 +0000)]
[Qt][WK2] Call resize on frameview in WebPage::resizeToContentsIfNeeded only when the size changes.
https://bugs.webkit.org/show_bug.cgi?id=82892

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-02
Reviewed by Kenneth Rohde Christiansen.

Check against the expanded size before calling resize on frameview.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFixedVisibleContentRect):
(WebKit::WebPage::resizeToContentsIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Take into account policy checks in ClipboardBlackBerry
rwlbuis@webkit.org [Mon, 2 Apr 2012 13:36:48 +0000 (13:36 +0000)]
[BlackBerry] Take into account policy checks in ClipboardBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82651

Reviewed by George Staikos.

Add policy checks in the methods we implemented.

Covered by existing tests.

* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(WebCore::ClipboardBlackBerry::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2012-04-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 2 Apr 2012 13:12:41 +0000 (13:12 +0000)]
2012-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html as
        slow.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Set up plugin process on Unix
kbalazs@webkit.org [Mon, 2 Apr 2012 13:08:27 +0000 (13:08 +0000)]
[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

* Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

* GNUmakefile.am:
* PluginProcess.pro: Added.

* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit):
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

* Shared/ProcessExecutablePath.h: Added.
(WebKit):
* Shared/gtk/ProcessExecutablePathGtk.cpp: Added.
(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):
* Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.
(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

* qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.
(WebKit):
(main):

Tools:

* qmake/mkspecs/features/features.prf: Reenable plugins
and turn on plugin process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK][WK2] Initial FullScreen support
philn@webkit.org [Mon, 2 Apr 2012 13:06:37 +0000 (13:06 +0000)]
[GTK][WK2] Initial FullScreen support
https://bugs.webkit.org/show_bug.cgi?id=75553

Reviewed by Martin Robinson.

Full screen display support in WebKitWebViewBase. Two functions
have been added to handle this. They're called by the
WebFullScreenManagerProxy when full screen display needs to be
managed for an HTML element.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate):
(webkitWebViewBaseCreateWebPage):
(onFullscreenGtkKeyPressEvent):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2012-04-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 2 Apr 2012 13:01:07 +0000 (13:01 +0000)]
2012-04-02  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark newly added test as slow.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameContr...
caseq@chromium.org [Mon, 2 Apr 2012 12:49:29 +0000 (12:49 +0000)]
Web Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameController
https://bugs.webkit.org/show_bug.cgi?id=82735

Reviewed by Pavel Feldman.

- factor out frame aggregation logic from TimelineVerticalOverview into TimelineFrameController;
- if we don't have frames, pretend each top-level event is a frame (this preserves behavior of vertical overview);
- factor out time-by-category stats aggregation into class methods of TimelineModel for reuse accross timeline modules;
- do not filter top-level events by type in vertical overview mode;

* WebCore.gypi: Added TimelineFrameController.js
* WebCore.vcproj/WebCore.vcproj: ditto.
* inspector/compile-front-end.py: ditto.
* inspector/front-end/TimelineFrameController.js: Added.
(WebInspector.TimelineFrameController):
(WebInspector.TimelineFrameController.prototype._onRecordAdded):
(WebInspector.TimelineFrameController.prototype._onRecordsCleared):
(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): create a "frame" based on a single top-level record.
(WebInspector.TimelineFrameController.prototype.dispose): Remove listeners that we added in constructor.
(WebInspector.TimelineFrame):
* inspector/front-end/TimelineModel.js: Added utilities for aggregating times by categories.
(WebInspector.TimelineModel.aggregateTimeByCategories):
(WebInspector.TimelineModel.aggregateTimeForRecord):
* inspector/front-end/TimelineOverviewPane.js: Use frame information supplied by TimelineFrameController.
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype.reset): Clear stored frames upon reset()
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
* inspector/front-end/TimelinePanel.js: Create/dispose TimelineFrameController when switching to/from vertical overview mode.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats): Factored out statistics aggregation to utilities method in the model.
* inspector/front-end/WebKit.qrc: Added TimelineFrameController.js
* inspector/front-end/inspector.html: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Implement backend for device metrics emulation
apavlov@chromium.org [Mon, 2 Apr 2012 12:20:44 +0000 (12:20 +0000)]
Web Inspector: Implement backend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82827

Source/WebCore:

This change implements the inspector backend for the device metrics override feature,
as well as the respective InspectorClient capability detection.
When a navigation occurs in the override mode, the page auto-zooming ("fit width")
is initiated upon the first layout after the DOMContentLoaded event.

Reviewed by Pavel Feldman.

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canOverrideDeviceMetrics):
(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):
(InspectorClient):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didLayoutImpl):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateViewMetrics):
* inspector/InspectorPageAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::getDouble):
(WebCore):
* inspector/InspectorState.h:
(InspectorState):
(WebCore::InspectorState::setDouble):

LayoutTests:

Follow the Web Inspector Protocol change.

Reviewed by Pavel Feldman.

* inspector/styles/override-screen-size.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112813 and r112837.
commit-queue@webkit.org [Mon, 2 Apr 2012 12:16:19 +0000 (12:16 +0000)]
Unreviewed, rolling out r112813 and r112837.
http://trac.webkit.org/changeset/112813
http://trac.webkit.org/changeset/112837
https://bugs.webkit.org/show_bug.cgi?id=82885

It made two tests crash on WK2 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedAngle.h:
(WebCore):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedEnumeration.cpp: Removed.
* svg/SVGAnimatedEnumeration.h:
(WebCore):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
(WebCore):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGAnimatedType.h:
(SVGAnimatedType):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGMarkerElement.cpp:
(WebCore):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:

LayoutTests:

* svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Removed.
* svg/animations/animate-marker-orient-from-angle-to-angle.html: Removed.
* svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Removed.
* svg/animations/animate-marker-orient-from-angle-to-auto.html: Removed.
* svg/animations/animate-marker-orient-to-angle-expected.txt: Removed.
* svg/animations/animate-marker-orient-to-angle.html: Removed.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Removed.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Removed.
* svg/animations/script-tests/animate-marker-orient-to-angle.js: Removed.
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgenum-animation-1.js: Removed.
* svg/animations/script-tests/svgenum-animation-10.js: Removed.
* svg/animations/script-tests/svgenum-animation-11.js: Removed.
* svg/animations/script-tests/svgenum-animation-12.js: Removed.
* svg/animations/script-tests/svgenum-animation-13.js: Removed.
* svg/animations/script-tests/svgenum-animation-2.js: Removed.
* svg/animations/script-tests/svgenum-animation-3.js: Removed.
* svg/animations/script-tests/svgenum-animation-4.js: Removed.
* svg/animations/script-tests/svgenum-animation-5.js: Removed.
* svg/animations/script-tests/svgenum-animation-6.js: Removed.
* svg/animations/script-tests/svgenum-animation-7.js: Removed.
* svg/animations/script-tests/svgenum-animation-8.js: Removed.
* svg/animations/script-tests/svgenum-animation-9.js: Removed.
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svgenum-animation-1-expected.txt: Removed.
* svg/animations/svgenum-animation-1.html: Removed.
* svg/animations/svgenum-animation-10-expected.txt: Removed.
* svg/animations/svgenum-animation-10.html: Removed.
* svg/animations/svgenum-animation-11-expected.txt: Removed.
* svg/animations/svgenum-animation-11.html: Removed.
* svg/animations/svgenum-animation-12-expected.txt: Removed.
* svg/animations/svgenum-animation-12.html: Removed.
* svg/animations/svgenum-animation-13-expected.txt: Removed.
* svg/animations/svgenum-animation-13.html: Removed.
* svg/animations/svgenum-animation-2-expected.txt: Removed.
* svg/animations/svgenum-animation-2.html: Removed.
* svg/animations/svgenum-animation-3-expected.txt: Removed.
* svg/animations/svgenum-animation-3.html: Removed.
* svg/animations/svgenum-animation-4-expected.txt: Removed.
* svg/animations/svgenum-animation-4.html: Removed.
* svg/animations/svgenum-animation-5-expected.txt: Removed.
* svg/animations/svgenum-animation-5.html: Removed.
* svg/animations/svgenum-animation-6-expected.txt: Removed.
* svg/animations/svgenum-animation-6.html: Removed.
* svg/animations/svgenum-animation-7-expected.txt: Removed.
* svg/animations/svgenum-animation-7.html: Removed.
* svg/animations/svgenum-animation-8-expected.txt: Removed.
* svg/animations/svgenum-animation-8.html: Removed.
* svg/animations/svgenum-animation-9-expected.txt: Removed.
* svg/animations/svgenum-animation-9.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112651.
ossy@webkit.org [Mon, 2 Apr 2012 12:13:31 +0000 (12:13 +0000)]
Unreviewed, rolling out r112651.
http://trac.webkit.org/changeset/112651
https://bugs.webkit.org/show_bug.cgi?id=82887

It doesn't work with older Qt5 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

Source/WebKit/qt:

* declarative/experimental/plugin.cpp:
* declarative/plugin.cpp:
(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

* UIProcess/API/qt/qquicknetworkreply_p.h:
* UIProcess/API/qt/qquicknetworkrequest_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
* UIProcess/qt/QtDialogRunner.cpp:
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):
* UIProcess/qt/QtFlickProvider.cpp:
* UIProcess/qt/QtFlickProvider.h:
(QtFlickProvider):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/main.cpp:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node to...
yurys@chromium.org [Mon, 2 Apr 2012 12:13:08 +0000 (12:13 +0000)]
[V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node to JS object
https://bugs.webkit.org/show_bug.cgi?id=82872

Reviewed by Pavel Feldman.

Source/WebCore:

Don't resolve heap object to a JS object if it is a wrapper boilerplate.

Test: inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

LayoutTests:

* inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Added.
* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWrite a test to confirm form elements work in Shadow DOM.
shinyak@chromium.org [Mon, 2 Apr 2012 12:06:01 +0000 (12:06 +0000)]
Write a test to confirm form elements work in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=82431

Reviewed by Dimitri Glazkov.

The Shadow DOM spec says form should work even if it is in a shadow tree.
This test confirms it.

* fast/dom/shadow/form-in-shadow.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112659.
commit-queue@webkit.org [Mon, 2 Apr 2012 11:57:12 +0000 (11:57 +0000)]
Unreviewed, rolling out r112659.
http://trac.webkit.org/changeset/112659
https://bugs.webkit.org/show_bug.cgi?id=82884

Undo the rollout of 112489 since this was not the cause of
failures (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

* css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd mechanism for mapping from StyleRules back to fully constructed CSSStyleRules
antti@apple.com [Mon, 2 Apr 2012 11:50:00 +0000 (11:50 +0000)]
Add mechanism for mapping from StyleRules back to fully constructed CSSStyleRules
https://bugs.webkit.org/show_bug.cgi?id=82847

Reviewed by Andreas Kling.

Inspector is using CSSStyleSelector to calculate the CSS rules matched by a given element and
expects to be able to walk the parent chain. After 82728 the stylesheet object tree won't have
parent pointers and we are going to need another mechanism to support this.

The new code does not actually run without 82728.

* css/CSSStyleSelector.cpp:
(WebCore):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

Add ensureFullCSSOMWrapperForStyleRule() method which traverses through all style
sheets that apply to the document and constucts wrappers for the rules. These wrappers
are cached to a map. The map can then be used for StyleRule -> CSSStyleRule lookups.

This uses quite a bit of memory so should not be used for any normal engine functions.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

Use the new mechanism to get fully functional wrappers for rule objects without parent pointer.

* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip a new failing test because
ossy@webkit.org [Mon, 2 Apr 2012 11:45:36 +0000 (11:45 +0000)]
[Qt] Unreviewed gardening, skip a new failing test because
ENABLE(SHADOW_DOM) is disabled.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-02

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Add baselines for fast/text/international/text-spliced-font.html
apavlov@chromium.org [Mon, 2 Apr 2012 11:22:48 +0000 (11:22 +0000)]
[Chromium] Add baselines for fast/text/international/text-spliced-font.html

* platform/chromium-linux/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-linux/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-win/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-win/fast/text/international/text-spliced-font-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fix make distcheck issues.
carlosgc@webkit.org [Mon, 2 Apr 2012 11:16:06 +0000 (11:16 +0000)]
Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing file.

Source/WebCore:

* GNUmakefile.list.am: Remove duplicated files and add missing
header.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, skipping one more crashing svg test in GTK because of
philn@webkit.org [Mon, 2 Apr 2012 11:15:39 +0000 (11:15 +0000)]
Unreviewed, skipping one more crashing svg test in GTK because of
bug 82876.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
carlosgc@webkit.org [Mon, 2 Apr 2012 11:06:42 +0000 (11:06 +0000)]
[GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82877

Reviewed by Philippe Normand.

* Scripts/run-gtk-tests:
(TestRunner.run_tests): Use replace instead of lstrip to remove
the programs_path from the full path of unit tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd rounding to Plugin creation in SubframeLoader
leviw@chromium.org [Mon, 2 Apr 2012 10:47:36 +0000 (10:47 +0000)]
Add rounding to Plugin creation in SubframeLoader
https://bugs.webkit.org/show_bug.cgi?id=82221

Reviewed by Eric Seidel.

Adding rounding to the LayoutSize used to construct Plugins in SubframeLoader. Plugins, which
are widgets, are always placed on integer boundaries, which means their sizes can be rounded
without considering their location. See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::loadPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoin page anchor and keyboard navigation
mario@webkit.org [Mon, 2 Apr 2012 10:28:26 +0000 (10:28 +0000)]
in page anchor and keyboard navigation
https://bugs.webkit.org/show_bug.cgi?id=17450

Reviewed by Chris Fleizach.

Source/WebCore:

Ensure that the position of the caret and the focused element
get updated when following an anchor link.

The implementation is moved from platform specific files out to
AXObjectCache.cpp since it should be a cross-platform valid
solution. However, the new code is currently activated for the Mac
and GTK ports only, since the windows and chromium ports provide
their own specific code, and removing it now might break things.

Test: accessibility/anchor-link-selection-and-focus.html

* accessibility/AXObjectCache.cpp:
(WebCore):
(WebCore::AXObjectCache::handleScrolledToAnchor): Cross-platform
implementation of the fix, only activated for Mac and GTK for now.
* accessibility/gtk/AXObjectCacheAtk.cpp: Removed the GTK-specific
implementation of WebCore::AXObjectCache::handleScrolledToAnchor.
* accessibility/mac/AXObjectCacheMac.mm: Removed the Mac-specific
implementation of WebCore::AXObjectCache::handleScrolledToAnchor.

LayoutTests:

Added new test and expectations.

* accessibility/anchor-link-selection-and-focus-expected.txt: Added.
* accessibility/anchor-link-selection-and-focus.html: Added.
* platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Added.
* platform/chromium/test_expectations.txt: Skipped test for chromium.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, skipping 2 crashing svg tests in GTK.
philn@webkit.org [Mon, 2 Apr 2012 10:20:28 +0000 (10:20 +0000)]
Unreviewed, skipping 2 crashing svg tests in GTK.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
keishi@webkit.org [Mon, 2 Apr 2012 10:20:25 +0000 (10:20 +0000)]
[chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
https://bugs.webkit.org/show_bug.cgi?id=82863

Reviewed by Kent Tamura.

* features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, add baselines for fast/forms/date/date-appearance.html
apavlov@chromium.org [Mon, 2 Apr 2012 10:12:45 +0000 (10:12 +0000)]
[Chromium] Unreviewed, add baselines for fast/forms/date/date-appearance.html

* platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Added.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Added.
* platform/chromium-win/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Move a number of virtual functions from WebKitPlatformSupport.h into Platf...
abarth@webkit.org [Mon, 2 Apr 2012 10:02:47 +0000 (10:02 +0000)]
[Chromium] Move a number of virtual functions from WebKitPlatformSupport.h into Platform.h
https://bugs.webkit.org/show_bug.cgi?id=82865

Reviewed by Kent Tamura.

Source/Platform:

Moving these functions into Platform.h allows them to be called from
Platform (aka WebCore/platform), as discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::mimeRegistry):
(WebKit::Platform::audioHardwareSampleRate):
(WebKit::Platform::audioHardwareBufferSize):
(WebKit::Platform::createAudioDevice):
(WebKit::Platform::sampleGamepads):
(WebKit::Platform::visitedLinkHash):
(WebKit::Platform::isLinkVisited):
(WebKit::Platform::signedPublicKeyAndChallengeString):
(WebKit::Platform::memoryUsageMB):
(WebKit::Platform::actualMemoryUsageMB):
(WebKit::Platform::lowMemoryUsageMB):
(WebKit::Platform::highMemoryUsageMB):
(WebKit::Platform::highUsageDeltaMB):
(WebKit::Platform::prefetchHostName):
(WebKit::Platform::createSocketStreamHandle):
(WebKit::Platform::userAgent):
(WebKit::Platform::cacheMetadata):
(WebKit::Platform::createThread):
(WebKit::Platform::currentThread):
(WebKit::Platform::decrementStatsCounter):
(WebKit::Platform::incrementStatsCounter):
(WebKit::Platform::loadResource):
(WebKit::Platform::loadAudioResource):
(WebKit::Platform::sandboxEnabled):
(WebKit::Platform::suddenTerminationChanged):
(WebKit::Platform::defaultLocale):
(WebKit::Platform::currentTime):
(WebKit::Platform::monotonicallyIncreasingTime):
(WebKit::Platform::setSharedTimerFiredFunction):
(WebKit::Platform::setSharedTimerFireInterval):
(WebKit::Platform::stopSharedTimer):
(WebKit::Platform::callOnMainThread):
(WebKit::Platform::getTraceCategoryEnabledFlag):
(WebKit::Platform::addTraceEvent):
(WebKit::Platform::histogramCustomCounts):
(WebKit::Platform::histogramEnumeration):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Shadow DOM] Introduce ComposedShadowTreeWalker as a successor of ReifiedTreeTraversa...
hayato@chromium.org [Mon, 2 Apr 2012 09:54:53 +0000 (09:54 +0000)]
[Shadow DOM] Introduce ComposedShadowTreeWalker as a successor of ReifiedTreeTraversal APIs
https://bugs.webkit.org/show_bug.cgi?id=82009

Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

ComposedShadowTreeWalker is intended to be a successor of current ReifiedTreeTraversal APIs.
ComposedShadowTreeWalker uses a cursor pattern and takes a starting node in its constructor.

A typical usage is:

  for (ComposedShadowTreeWalker walker(node); walker.get(); walker.next()) {
        ...
  }

Follow-up patches will update clients which use current ReifiedTreeTraversal APIs so that they use the Walker.
More tests will come along with these actual use cases in follow-up patches.
After that, I'll get rid of ReifiedTreeTraversal APIs in favor of the Walker.

Note that 'ComposedShadowTree' and 'ReifiedTree' has the same meaning.
Because ReifiedTree is not intuitive name, we are starting to use 'ComposedShadowTree' from now.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp: Added.
(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::fromFirstChild):
(WebCore::ComposedShadowTreeWalker::firstChild):
(WebCore::ComposedShadowTreeWalker::traverseFirstChild):
(WebCore::ComposedShadowTreeWalker::lastChild):
(WebCore::ComposedShadowTreeWalker::traverseLastChild):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::nextSibling):
(WebCore::ComposedShadowTreeWalker::previousSibling):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ComposedShadowTreeWalker::escapeFallbackContentElement):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::parent):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
(WebCore::ComposedShadowTreeWalker::traverseNextSibling):
(WebCore::ComposedShadowTreeWalker::traversePreviousSibling):
(WebCore::ComposedShadowTreeWalker::next):
(WebCore::ComposedShadowTreeWalker::previous):
* dom/ComposedShadowTreeWalker.h: Added.
(WebCore):
(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::get):
(WebCore::ComposedShadowTreeWalker::canCrossUpperBoundary):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore::ComposedShadowTreeWalker::assertPostcondition):
* testing/Internals.cpp:
(WebCore::Internals::nextSiblingByWalker):
(WebCore):
(WebCore::Internals::firstChildByWalker):
(WebCore::Internals::lastChildByWalker):
(WebCore::Internals::nextNodeByWalker):
(WebCore::Internals::previousNodeByWalker):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* fast/dom/shadow/composed-shadow-tree-walker-expected.txt: Added.
* fast/dom/shadow/composed-shadow-tree-walker.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Skip flaky unit tests.
carlosgc@webkit.org [Mon, 2 Apr 2012 09:37:42 +0000 (09:37 +0000)]
Unreviewed. Skip flaky unit tests.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: breakpoints are not shown in sidebar pane after switching pretty-print...
podivilov@chromium.org [Mon, 2 Apr 2012 09:29:24 +0000 (09:29 +0000)]
Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=82768

Reviewed by Yury Semikhatsky.

Source/WebCore:

When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

* inspector/debugger/script-formatter-breakpoints-expected.txt:
* inspector/debugger/script-formatter-breakpoints.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTeach RuleSet about modern memory management
eric@webkit.org [Mon, 2 Apr 2012 09:18:01 +0000 (09:18 +0000)]
Teach RuleSet about modern memory management
https://bugs.webkit.org/show_bug.cgi?id=82856

Reviewed by Adam Barth.

No change in behavior, thus no tests.

* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::create):
(RuleSet):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a calendar picker indicator to date-type input fields
tkent@chromium.org [Mon, 2 Apr 2012 09:05:32 +0000 (09:05 +0000)]
Add a calendar picker indicator to date-type input fields
https://bugs.webkit.org/show_bug.cgi?id=80478

Reviewed by Hajime Morita.

Source/WebCore:

Add an indicator to date-type controls. The bahevior change is enclosed
with ENABLE_CALENDAR_PICKER.

- Remove spin buttons from date-type controls.
It's not so helpful if we have a calendar picker. We introduce
TextFieldInputType::shouldHaveSpinButton().

- Add CalendarPickerElement.
This is added into a shadow tree of a date-type control. It uses
RenderDetailsMarker.

We're going to add click handler and so on to CalendarPickerElement.

Test: fast/forms/date/date-appearance.html

* WebCore.gypi: Add CalendarPickerElement.{cpp,h}
* css/html.css:
(input::-webkit-calendar-picker-indicator):
* html/DateInputType.cpp:
(WebCore::DateInputType::createShadowSubtree): Insert CalendarPickerElement.
(WebCore::DateInputType::needsContainer):
Alwyas return true because we have an extra decoration element.
(WebCore::DateInputType::shouldHaveSpinButton):
Always return false to disable spin button.
* html/DateInputType.h:
(DateInputType): Add declarations.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::createShadowSubtree): Move some code to shouldHaveSpinButton().
* html/TextFieldInputType.h:
(TextFieldInputType): Add a declartion.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::create):
(WebCore::CalendarPickerElement::createRenderer): Creates RenderDetailsMarker.
* html/shadow/CalendarPickerElement.h: Added.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen): Always show a down arrow if this is in <input>.
* rendering/RenderDetailsMarker.h:

Source/WebKit/chromium:

* features.gypi: Enable CALENDAR_PICKER for non-Android platforms. This
doesn't affect any bahevior because INPUT_TYPE_DATE is disabled.

LayoutTests:

* fast/forms/date/date-appearance.html: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: make timeline overview a view
caseq@chromium.org [Mon, 2 Apr 2012 08:46:06 +0000 (08:46 +0000)]
Web Inspector: make timeline overview a view
https://bugs.webkit.org/show_bug.cgi?id=82861

Reviewed by Yury Semikhatsky.

- make TimelineOverviewPane a view;
- only update it if it's visible or upon wasShown().

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.wasShown): forced update.
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh): skip refresh if not showing;
* inspector/front-end/TimelinePanel.js: timelineOverviewPane.show() instead of appendChild();
(WebInspector.TimelinePanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for ENABLE(SVG) && !ENABLE(FILTERS) after r112813.
paroga@webkit.org [Mon, 2 Apr 2012 08:24:13 +0000 (08:24 +0000)]
Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r112813.

* svg/SVGAnimatedEnumeration.cpp:
(WebCore::enumerationValueForTargetAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy rebaseline.
rniwa@webkit.org [Mon, 2 Apr 2012 08:12:29 +0000 (08:12 +0000)]
webkitpy rebaseline.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rebaseline after r112825.
philn@webkit.org [Mon, 2 Apr 2012 07:43:23 +0000 (07:43 +0000)]
Unreviewed, rebaseline after r112825.

The test baseline updated in r112825 is specific to GURL's way of
printing URLs so it belongs to the chromium platform directory.

* http/tests/security/no-popup-from-sandbox-top-expected.txt:
* platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt: Copied from LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Move another block of headers from WebKit/chromium/public/platform to...
abarth@webkit.org [Mon, 2 Apr 2012 07:31:41 +0000 (07:31 +0000)]
[Chromium] Move another block of headers from WebKit/chromium/public/platform to Platform/chromium/public
https://bugs.webkit.org/show_bug.cgi?id=82862

Rubber-stamped by Eric Seidel.

Source/Platform:

* Platform.gypi:
* chromium/public/WebAudioBus.h: Copied from Source/WebKit/chromium/public/platform/WebAudioBus.h.
* chromium/public/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/platform/WebAudioDevice.h.
* chromium/public/WebGamepad.h: Copied from Source/WebKit/chromium/public/platform/WebGamepad.h.
* chromium/public/WebGamepads.h: Copied from Source/WebKit/chromium/public/platform/WebGamepads.h.
* chromium/public/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamError.h.
* chromium/public/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandle.h.
* chromium/public/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandleClient.h.

Source/WebCore:

This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

* WebCore.gypi:
* platform/chromium/support/WebAudioBus.cpp: Copied from Source/WebKit/chromium/src/WebAudioBus.cpp.

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebAudioBus.h: Replaced.
* public/platform/WebAudioDevice.h: Replaced.
* public/platform/WebGamepad.h: Replaced.
* public/platform/WebGamepads.h: Replaced.
* public/platform/WebSocketStreamError.h: Replaced.
* public/platform/WebSocketStreamHandle.h: Replaced.
* public/platform/WebSocketStreamHandleClient.h: Replaced.
* src/WebAudioBus.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK svg rebaseline after r112806.
philn@webkit.org [Mon, 2 Apr 2012 07:00:26 +0000 (07:00 +0000)]
Unreviewed, GTK svg rebaseline after r112806.

* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
* platform/gtk/svg/[...]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Move thread-related APIs from WebKit into Platform
abarth@webkit.org [Mon, 2 Apr 2012 06:54:18 +0000 (06:54 +0000)]
[Chromium] Move thread-related APIs from WebKit into Platform
https://bugs.webkit.org/show_bug.cgi?id=82858

Reviewed by Eric Seidel.

Source/Platform:

* Platform.gypi:
* chromium/public/WebThread.h: Copied from Source/WebKit/chromium/public/platform/WebThread.h.
* chromium/public/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/platform/WebThreadSafeData.h.

Source/WebCore:

This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

* WebCore.gypi:
* platform/chromium/support/WebThreadSafeData.cpp: Copied from Source/WebKit/chromium/src/WebThreadSafeData.cpp.

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebThread.h: Replaced.
* public/platform/WebThreadSafeData.h: Replaced.
* src/WebThreadSafeData.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPerf-o-matic build fix after 112829 for Chromium-style tests.
rniwa@webkit.org [Mon, 2 Apr 2012 05:21:32 +0000 (05:21 +0000)]
Perf-o-matic build fix after 112829 for Chromium-style tests.

* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix some problems of text field decoration
tkent@chromium.org [Mon, 2 Apr 2012 05:07:53 +0000 (05:07 +0000)]
Fix some problems of text field decoration
https://bugs.webkit.org/show_bug.cgi?id=82693

Reviewed by Dimitri Glazkov.

- Fix a problem that decorations are not removed when the input type is
changed.
- Add a comment to the 'willDetach' callback.

No new tests because the behavior changes are not visible yet.

* GNUMakefile.list.am: Add HTMLShadowElement.*.
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
Remove all of ShadowRoot contents, and add a <shadow> element to each of
them. We don't remove ShadowRoots from the tree because it's not
supported well.
* html/shadow/TextFieldDecorationElement.cpp:
(getDecorationRootAndDecoratedRoot): A helper function for decorate().
If the input element has a ShadowRoot with single <shadow> child, we
don't create new ShadowRoot and reuse it.
(WebCore::TextFieldDecorationElement::decorate):
Use getDecorationRootAndDecoratedRoot().
* html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorator): Add a comment to willDetach().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoperf-o-matic should store test results' units
rniwa@webkit.org [Mon, 2 Apr 2012 04:48:35 +0000 (04:48 +0000)]
perf-o-matic should store test results' units
https://bugs.webkit.org/show_bug.cgi?id=82852

Reviewed by Kentaro Hara.

.:

* Websites/webkit-perf.appspot.com/models.py:
(Test):
(Test.update_or_insert): Added "unit" to the argument list.
(Test.update_or_insert.execute): Store the unit.
(ReportLog.results_are_well_formed): Moved from ReportHandler.
(ReportLog.results_are_well_formed._is_float_convertible): Ditto.
* Websites/webkit-perf.appspot.com/models_unittest.py:
(TestModelTests.test_update_or_insert): Added a test case for "unit" argument.
(TestModelTests.test_update_or_insert_to_update): Ditto.
(ReportLogTests.test_results_are_well_formed): Added.
(ReportLogTests.test_results_are_well_formed.assert_results_are_well_formed): Added.
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post): Calls ReportLog.results_are_well_formed.
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post): Passes results['unit'] to Test.update_or_insert.

Tools:

Include units in the results JSON.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix incorrect path for libWTF.a in Mac project file.
darin@apple.com [Mon, 2 Apr 2012 04:36:47 +0000 (04:36 +0000)]
Fix incorrect path for libWTF.a in Mac project file.

* JavaScriptCore.xcodeproj/project.pbxproj: Removed the "../Release" prefix that
would cause other configurations to try to link with the "Release" version of
libWTF.a instead of the correct version.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCode review tool no longer needs to work around position:fixed handling on iPad
abarth@webkit.org [Mon, 2 Apr 2012 03:51:50 +0000 (03:51 +0000)]
Code review tool no longer needs to work around position:fixed handling on iPad
https://bugs.webkit.org/show_bug.cgi?id=82850

Reviewed by Eric Seidel.

We no longer need to avoid position:fixed on iPad because Mobile Safari
now does something reasonable with position:fixed elements.

* code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
commit-queue@webkit.org [Mon, 2 Apr 2012 02:53:32 +0000 (02:53 +0000)]
[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-04-01
Reviewed by Kent Tamura.

Source/WebCore:

When it had no negotiated deflate-frame extension, if browser received the frame with
setting compressed bit, it should fail the connection, and it should cover both
enabling ZLIB port and disabling ZLIB port.

Test:  http/tests/websocket/tests/hybi/reserved-bits.html

* Modules/websockets/WebSocketDeflateFramer.cpp:
(WebCore::WebSocketDeflateFramer::inflate):

LayoutTests:

Solve the problem that Qt Webkit failed when runing the reserved-bits.html
Support both enabled ZLIB and disabled ZLIB scenarios.

* http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
* http/tests/websocket/tests/hybi/reserved-bits_wsh.py:
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up Document::canNavigate
abarth@webkit.org [Mon, 2 Apr 2012 02:43:17 +0000 (02:43 +0000)]
Clean up Document::canNavigate
https://bugs.webkit.org/show_bug.cgi?id=82282

Reviewed by Eric Seidel.

Source/WebCore:

This patch is just a minor clean up to Document::canNavigate. Eric
asked me to clean up the function when I moved it from FrameLoader. I'm
not sure this patch is much of a win, but at least the comments say
things that are more sensible now.

* dom/Document.cpp:
(WebCore::printNavigationErrorMessage):
(WebCore):
(WebCore::Document::canNavigate):

LayoutTests:

Update these test results to show that we're better at printing error
messages now.

* http/tests/security/no-popup-from-sandbox-top-expected.txt:
* http/tests/security/sandboxed-iframe-form-top-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdmin page should lexicologically sort tests
rniwa@webkit.org [Mon, 2 Apr 2012 02:12:17 +0000 (02:12 +0000)]
Admin page should lexicologically sort tests
https://bugs.webkit.org/show_bug.cgi?id=82849

Rubber-stamped by Hajime Morita.

* Websites/webkit-perf.appspot.com/js/admin.js:
* Websites/webkit-perf.appspot.com/js/config.js:
(sortProperties):
(fetchDashboardManifest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert an inadvertently committed change.
rniwa@webkit.org [Mon, 2 Apr 2012 01:55:00 +0000 (01:55 +0000)]
Revert an inadvertently committed change.

* Websites/webkit-perf.appspot.com/app.yaml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoperf-o-matic should have a way to hide some platforms and tests
rniwa@webkit.org [Mon, 2 Apr 2012 01:46:41 +0000 (01:46 +0000)]
perf-o-matic should have a way to hide some platforms and tests
https://bugs.webkit.org/show_bug.cgi?id=82842

Reviewed by Hajime Morita.

* Websites/webkit-perf.appspot.com/admin.html:
* Websites/webkit-perf.appspot.com/admin_handlers.py:
(AdminDashboardHandler.get_branches): Change the json format to allow platforms and tests to have
"hidden" boolean states.
(AdminDashboardHandler.get_platforms): Ditto.
(AdminDashboardHandler.get_builders): Just a cleanup. There is no clean for it to have a limit.
(AdminDashboardHandler.get_tests): Change the json format to add "hidden" boolean states.
(ChangeVisibilityHandler): Added.
(ChangeVisibilityHandler.post): Added. Changes the hidden-state (visibility) of a platform and a test.
* Websites/webkit-perf.appspot.com/app.yaml: Make sure everything under /admin/ requires admin privilege.
* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post): Don't emit LF after 'OK'.
* Websites/webkit-perf.appspot.com/css/admin.css: Added a bunch of rules for hide/show button.
* Websites/webkit-perf.appspot.com/js/admin.js:
(submitXHR): Extracted.
(createKeyNameReloader): Added hide/show button on each item and the corresponding ajax request.
* Websites/webkit-perf.appspot.com/json_generators.py:
(DashboardJSONGenerator.__init__): Skip hidden tests and platforms.
(ManifestJSONGenerator.__init__): Ditto.
* Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added tests to ensure perf-o-matic
doesn't include hidden tests and platforms in dashboard and manifest json responses.
(DashboardJSONGeneratorTest.test_value_with_hidden_platform_and_tesst):
(ManifestJSONGeneratorTest.test_value_two_tests):
(ManifestJSONGeneratorTest.test_value_with_hidden_platform_and_test):
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/models.py:
(Platform): Added the "hidden" property.
(Test): Ditto. Also removed the comment about this class only exists for efficiency purposes since that's
no longer true.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename notification properties and functions
jonlee@apple.com [Sun, 1 Apr 2012 23:15:44 +0000 (23:15 +0000)]
Rename notification properties and functions
https://bugs.webkit.org/show_bug.cgi?id=80482
<rdar://problem/10912432>

Reviewed by Kentaro Hara.

Source/WebCore:

Change method name to close(), and set tag property on Notifications, based on discussions in WG:
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

* notifications/Notification.cpp:
(WebCore::Notification::~Notification): Use close().
(WebCore::Notification::close):
* notifications/Notification.h:
(Notification):
(WebCore::Notification::cancel): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use close().
(WebCore::Notification::replaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use tag().
(WebCore::Notification::setReplaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use setTag().
(WebCore::Notification::tag):
(WebCore::Notification::setTag):
* notifications/Notification.idl: Preserve cancel() and replaceID in ENABLE(LEGACY_NOTIFICATIONS), and
close() and tag in ENABLE(NOTIFICATIONS).

Source/WebKit/chromium:

* src/WebNotification.cpp:
(WebKit::WebNotification::replaceId): Refactor to call tag().

Source/WebKit/mac:

* WebView/WebNotification.h: Rename replaceID to tag.
* WebView/WebNotification.mm:
(-[WebNotification tag]):

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::show): Refactor to call tag().
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): Refactor to call tag().

Source/WebKit2:

Rename APIs to use tag.
* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyTag):
* UIProcess/API/C/WKNotification.h:
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::tag):
(WebNotification):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r112760.
eric@webkit.org [Sun, 1 Apr 2012 23:12:24 +0000 (23:12 +0000)]
Unreviewed, rolling out r112760.
http://trac.webkit.org/changeset/112760
https://bugs.webkit.org/show_bug.cgi?id=82795

Revert addition of webkitseamless.  I'll do this work on
GitHub instead to avoid any half-implemented feature concerns.

Source/WebCore:

* html/HTMLAttributeNames.in:
* html/HTMLIFrameElement.idl:

LayoutTests:

* fast/frames/seamless/resources/css-cascade-child.html: Removed.
* fast/frames/seamless/resources/nested-seamless.html: Removed.
* fast/frames/seamless/resources/square.html: Removed.
* fast/frames/seamless/seamless-basic-expected.txt: Removed.
* fast/frames/seamless/seamless-basic.html: Removed.
* fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
* fast/frames/seamless/seamless-css-cascade.html: Removed.
* fast/frames/seamless/seamless-nested-expected.txt: Removed.
* fast/frames/seamless/seamless-nested.html: Removed.
* fast/frames/seamless/seamless-sandbox-flag-expected.txt: Removed.
* fast/frames/seamless/seamless-sandbox-flag.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Simplify the code that gets accelerated compositing output onto the...
commit-queue@webkit.org [Sun, 1 Apr 2012 21:22:02 +0000 (21:22 +0000)]
[BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
https://bugs.webkit.org/show_bug.cgi?id=82845

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-01
Reviewed by Rob Buis.

RIM PR: 136381
The code accounted for a now obsolete setup where we used one OpenGL
window for accelerated compositing and one native window for backing
store output, and let the windowing system composite those two. In that
setup an optimization to try and only update the window that had
changed was viable.

Nowadays, we either use an offscreen surface for accelerated
compositing output, which we blend onto the window containing the
backing store output, or render both backing store and accelerated
compositing output directly to one OpenGL window. We always have to
blit the backingstore contents and draw the accelerated compositing
output every frame with these code paths, so don't try to be clever
about it.

Even when we use an OpenGL window, the compositing surface can be non-
null, so don't try to glFinish() and swap the compositing surface when
the GLES2Context is tied to a window.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
* WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::swapBuffers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a crash when closing a tab/window while the Web Inspector is stopped in the debugger.
timothy@apple.com [Sun, 1 Apr 2012 20:23:14 +0000 (20:23 +0000)]
Fix a crash when closing a tab/window while the Web Inspector is stopped in the debugger.

https://webkit.org/b/82846
rdar://problem/8133494

Reviewed by Yury Semikhatsky.

* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::didPause): Added assert for page and early return. Also assert that
m_pausedPage is null.
(WebCore::PageScriptDebugServer::didContinue): Page can be null if we are continuing because the Page closed.
So add a null check before using it. Added an assert that the page is null or m_pausedPage.
(WebCore::PageScriptDebugServer::didRemoveLastListener): Added assert for page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrected the expected results for this test.
mitz@apple.com [Sun, 1 Apr 2012 18:40:21 +0000 (18:40 +0000)]
Corrected the expected results for this test.

* platform/mac/fast/text/international/text-spliced-font-expected.png:
* platform/mac/fast/text/international/text-spliced-font-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Composite Font References is a new established standard (ISO/IEC...
mitz@apple.com [Sun, 1 Apr 2012 18:21:10 +0000 (18:21 +0000)]
Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).

When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.

To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

Added test LayoutTests/fast/text/international/text-spliced-font.html

* WebCore.exp.in:
Replaced obsolete FontPlatformData constructor entry.

* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.

(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.

* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.

(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.

(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.

(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.

* platform/graphics/SimpleFontData.h:
(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.

(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.

(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.

* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.

(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.

Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

A new test font of this kind as been added to the test tools for running the webkit-tests

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont

* DumpRenderTree/fonts/SampleFont.sfont: Added.

* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(activateTestingFonts):
Added the registration of the Composite Font Referene sample font

* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont

* WebKitTestRunner/fonts/SampleFont.sfont: Added.

LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

Added new LayoutTests/fast/text/international/text-spliced-font.html

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

* fast/text/international/text-spliced-font.html: Added.
* platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
* platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSupport the Network Information API
gyuyoung.kim@samsung.com [Sun, 1 Apr 2012 15:09:25 +0000 (15:09 +0000)]
Support the Network Information API
https://bugs.webkit.org/show_bug.cgi?id=73528

Reviewed by Adam Barth.

.:

Add network information API feature.

* Source/cmake/OptionsEfl.cmake: Add NETWORK_INFO feature.
* Source/cmakeconfig.h.cmake: Add NETWORK_INFO feature.

Source/WebCore:

Network Information APIs is to provide an interface for Web Applications to access
the underlying network information of device. In Web Application case, they need to know
what current network interface it uses. Because, it is important to know current network
information(bandwidth, metered) in mobile domain. Thus, Web Application can let user know
whether current network information via this new functionality. In addition, in streaming
service case, Web Application can control content resolution according to kind of network.

http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/index.html

Tests: networkinformation/add-listener-from-callback.html
       networkinformation/basic-all-types-of-events.html
       networkinformation/basic-operation.html
       networkinformation/event-after-navigation.html
       networkinformation/multiple-frames.html
       networkinformation/updates.html
       networkinformation/window-property.html

* CMakeLists.txt:
* Modules/networkinfo/NavigatorNetworkInfoConnection.cpp: Added.
(WebCore):
(WebCore::NavigatorNetworkInfoConnection::NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::~NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::from):
(WebCore::NavigatorNetworkInfoConnection::webkitConnection):
* Modules/networkinfo/NavigatorNetworkInfoConnection.h: Added.
(WebCore):
(NavigatorNetworkInfoConnection):
* Modules/networkinfo/NavigatorNetworkInfoConnection.idl: Added.
* Modules/networkinfo/NetworkInfo.cpp: Added.
(WebCore):
(WebCore::NetworkInfo::NetworkInfo):
* Modules/networkinfo/NetworkInfo.h: Added.
(WebCore):
(NetworkInfo):
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(WebCore::NetworkInfo::metered):
* Modules/networkinfo/NetworkInfoClient.h: Added.
(WebCore):
(NetworkInfoClient):
(WebCore::NetworkInfoClient::~NetworkInfoClient):
* Modules/networkinfo/NetworkInfoConnection.cpp: Added.
(WebCore):
(WebCore::NetworkInfoConnection::create):
(WebCore::NetworkInfoConnection::NetworkInfoConnection):
(WebCore::NetworkInfoConnection::~NetworkInfoConnection):
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
(WebCore::NetworkInfoConnection::didChangeNetworkInformation):
(WebCore::NetworkInfoConnection::addEventListener):
(WebCore::NetworkInfoConnection::removeEventListener):
(WebCore::NetworkInfoConnection::eventTargetData):
(WebCore::NetworkInfoConnection::ensureEventTargetData):
(WebCore::NetworkInfoConnection::interfaceName):
(WebCore::NetworkInfoConnection::suspend):
(WebCore::NetworkInfoConnection::resume):
(WebCore::NetworkInfoConnection::stop):
* Modules/networkinfo/NetworkInfoConnection.h: Added.
(WebCore):
(NetworkInfoConnection):
(WebCore::NetworkInfoConnection::scriptExecutionContext):
(WebCore::NetworkInfoConnection::canSuspend):
(WebCore::NetworkInfoConnection::refEventTarget):
(WebCore::NetworkInfoConnection::derefEventTarget):
* Modules/networkinfo/NetworkInfoConnection.idl: Added.
* Modules/networkinfo/NetworkInfoController.cpp: Added.
(WebCore):
(WebCore::NetworkInfoController::NetworkInfoController):
(WebCore::NetworkInfoController::~NetworkInfoController):
(WebCore::NetworkInfoController::create):
(WebCore::NetworkInfoController::addListener):
(WebCore::NetworkInfoController::removeListener):
(WebCore::NetworkInfoController::didChangeNetworkInformation):
(WebCore::NetworkInfoController::isActive):
(WebCore::NetworkInfoController::supplementName):
(WebCore::provideNetworkInfoTo):
* Modules/networkinfo/NetworkInfoController.h: Added.
(WebCore):
(NetworkInfoController):
(WebCore::NetworkInfoController::client):
(WebCore::NetworkInfoController::from):
* dom/EventNames.h:
(WebCore):
* dom/EventTargetFactory.in:
* testing/Internals.cpp:
(WebCore::Internals::setNetworkInformation):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit:

* PlatformEfl.cmake: Add dummy NetworkInfoClientEfl.cpp files in order to support network information API.

Source/WebKit/efl:

Add NetworkInfoClientEfl to support network information API. However,
functions are not implemented yet.

* WebCoreSupport/NetworkInfoClientEfl.cpp: Added.
(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore):
(WebCore::NetworkInfoClientEfl::~NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
* WebCoreSupport/NetworkInfoClientEfl.h: Added.
(NetworkInfoClientEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools:

Add network information API feature to build script.

* Scripts/build-webkit:

LayoutTests:

Add new test cases for network information API specification.
And also, skip this test cases for other ports.

* networkinformation/add-listener-from-callback-expected.txt: Added.
* networkinformation/add-listener-from-callback.html: Added.
* networkinformation/basic-all-types-of-events-expected.txt: Added.
* networkinformation/basic-all-types-of-events.html: Added.
* networkinformation/basic-operation-expected.txt: Added.
* networkinformation/basic-operation.html: Added.
* networkinformation/event-after-navigation-expected.txt: Added.
* networkinformation/event-after-navigation.html: Added.
* networkinformation/multiple-frames-expected.txt: Added.
* networkinformation/multiple-frames.html: Added.
* networkinformation/resources/event-after-navigation-new.html: Added.
* networkinformation/script-tests/add-listener-from-callback.js: Added.
(checkNetworkInformation):
(firstListener):
(secondListener):
(maybeFinishTest):
* networkinformation/script-tests/basic-all-types-of-events.js: Added.
(checkNetworkInformation):
* networkinformation/script-tests/basic-operation.js: Added.
* networkinformation/script-tests/event-after-navigation.js: Added.
* networkinformation/script-tests/multiple-frames.js: Added.
(checkNetworkInformation):
(checkChildNetworkInformation):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):
* networkinformation/script-tests/updates.js: Added.
(checkNetworkInformation):
(setNetworkInformation):
(firstListener):
(updateListener):
* networkinformation/script-tests/window-property.js: Added.
(hasOnConnectionProperty):
* networkinformation/updates-expected.txt: Added.
* networkinformation/updates.html: Added.
* networkinformation/window-property-expected.txt: Added.
* networkinformation/window-property.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath(...
leo.yang@torchmobile.com.cn [Sun, 1 Apr 2012 13:40:30 +0000 (13:40 +0000)]
[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath() in RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=81486

Reviewed by Rob Buis.

RenderThemeBlackBerry was using GraphicsContext::drawPath() that's added for BlackBerry internally.
But we already have fillPath() and strokePath() in GraphicsContext. So just substitute drawPath()
by them. Also fix a build issue by adding a #include line.

No functionalities changed, no new tests.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):
(WebCore::RenderThemeBlackBerry::paintButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable animVal support for SVGAnimatedEnumeration
zimmermann@webkit.org [Sun, 1 Apr 2012 12:09:14 +0000 (12:09 +0000)]
Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Source/WebCore:

Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.

One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.

This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.

Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>

at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.animVal.value = 45

       someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.baseVal.value = 45

at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.animVal.value = 90

       someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.baseVal.value = 45

at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO
       someMarkerElement.orientAngle.animVal.value = 0

       someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.baseVal.value = 45

 > 3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.animVal.value = 45

       someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
       someMarkerElement.orientAngle.baseVal.value = 45

We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.

Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.

Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html
       svg/animations/animate-marker-orient-from-angle-to-auto.html
       svg/animations/animate-marker-orient-to-angle.html
       svg/animations/svgenum-animation-1.html
       svg/animations/svgenum-animation-10.html
       svg/animations/svgenum-animation-11.html
       svg/animations/svgenum-animation-12.html
       svg/animations/svgenum-animation-13.html
       svg/animations/svgenum-animation-2.html
       svg/animations/svgenum-animation-3.html
       svg/animations/svgenum-animation-4.html
       svg/animations/svgenum-animation-5.html
       svg/animations/svgenum-animation-6.html
       svg/animations/svgenum-animation-7.html
       svg/animations/svgenum-animation-8.html
       svg/animations/svgenum-animation-9.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedAngle.h:
(WebCore):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedEnumeration.cpp: Added.
(WebCore):
(WebCore::enumerationValueForTargetAttribute):
(WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::constructFromString):
(WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedEnumerationAnimator::animValWillChange):
(WebCore::SVGAnimatedEnumerationAnimator::animValDidChange):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):
* svg/SVGAnimatedEnumeration.h:
(SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator):
(WebCore):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngleAndEnumeration):
(WebCore::SVGAnimatedType::createEnumeration):
(WebCore):
(WebCore::SVGAnimatedType::angleAndEnumeration):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGAnimatedType.h:
(SVGAnimatedType):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::executeAction):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGMarkerElement.cpp:
(WebCore):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.

* svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
* svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
* svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
* svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
* svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
* svg/animations/animate-marker-orient-to-angle.html: Added.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-marker-orient-to-angle.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgenum-animation-1.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-10.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-11.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svgenum-animation-12.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgenum-animation-13.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgenum-animation-2.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgenum-animation-3.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svgenum-animation-5.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-6.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgenum-animation-7.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-8.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svgenum-animation-9.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svgenum-animation-1-expected.txt: Added.
* svg/animations/svgenum-animation-1.html: Added.
* svg/animations/svgenum-animation-10-expected.txt: Added.
* svg/animations/svgenum-animation-10.html: Added.
* svg/animations/svgenum-animation-11-expected.txt: Added.
* svg/animations/svgenum-animation-11.html: Added.
* svg/animations/svgenum-animation-12-expected.txt: Added.
* svg/animations/svgenum-animation-12.html: Added.
* svg/animations/svgenum-animation-13-expected.txt: Added.
* svg/animations/svgenum-animation-13.html: Added.
* svg/animations/svgenum-animation-2-expected.txt: Added.
* svg/animations/svgenum-animation-2.html: Added.
* svg/animations/svgenum-animation-3-expected.txt: Added.
* svg/animations/svgenum-animation-3.html: Added.
* svg/animations/svgenum-animation-4-expected.txt: Added.
* svg/animations/svgenum-animation-4.html: Added.
* svg/animations/svgenum-animation-5-expected.txt: Added.
* svg/animations/svgenum-animation-5.html: Added.
* svg/animations/svgenum-animation-6-expected.txt: Added.
* svg/animations/svgenum-animation-6.html: Added.
* svg/animations/svgenum-animation-7-expected.txt: Added.
* svg/animations/svgenum-animation-7.html: Added.
* svg/animations/svgenum-animation-8-expected.txt: Added.
* svg/animations/svgenum-animation-8.html: Added.
* svg/animations/svgenum-animation-9-expected.txt: Added.
* svg/animations/svgenum-animation-9.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r112799.
ossy@webkit.org [Sun, 1 Apr 2012 08:25:40 +0000 (08:25 +0000)]
[Qt] Unreviewed gardening after r112799.

* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Do not generate custom signature for static methods.
commit-queue@webkit.org [Sun, 1 Apr 2012 08:23:31 +0000 (08:23 +0000)]
[chromium] Do not generate custom signature for static methods.
https://bugs.webkit.org/show_bug.cgi?id=79222

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-01
Reviewed by Kentaro Hara.

No new tests. Covered by existing tests when MEDIA_STREAM is disabled.

* bindings/scripts/CodeGeneratorV8.pm:
(RequiresCustomSignature):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
sfalken@apple.com [Sun, 1 Apr 2012 03:03:22 +0000 (03:03 +0000)]
Windows build fix.

* WebCore.vcproj/WebCore.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrevent opening external URLs in the Web Inspector's WebView.
timothy@apple.com [Sun, 1 Apr 2012 01:18:10 +0000 (01:18 +0000)]
Prevent opening external URLs in the Web Inspector's WebView.

All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView.

https://webkit.org/b/82812
rdar://problem/9488558

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath.
(-[WebInspectorWindowController inspectorPagePath]): Added.
(-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added.
Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page.

Source/WebKit2:

* UIProcess/WebInspectorProxy.cpp:
(WebKit::decidePolicyForNavigationAction): Added. Only allow non-main frame and the inspector page. All other URLs
will be opened in the inspected page.
(WebKit::WebInspectorProxy::createInspectorPage): Set the policy client and use decidePolicyForNavigationAction.
* UIProcess/WebInspectorProxy.h: Made inspectorPageURL and inspectorBaseURL public for decidePolicyForNavigationAction.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGenerate the flakiness dashboard's list of webkit.org builders from the buildbot...
ojan@chromium.org [Sat, 31 Mar 2012 23:33:40 +0000 (23:33 +0000)]
Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
https://bugs.webkit.org/show_bug.cgi?id=82839

Reviewed by Adam Barth.

Also, update various hard-coded lists for WIN7 and Lion ports.
This is necessary since the new list of builders grabbed off the
buildbot includes Lion.

* TestResultServer/static-dashboards/builders.js:
(generateWebkitBuildersFromBuilderList):
(xhr.onreadystatechange):
Don't use dashboard_base's request method to avoid layering violation.

* TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
(initBuilders):
(haveJsonFilesLoaded):
(g_handleBuildersListLoaded):
Block loading the JSON files for each builder until we actually have a list of builders.

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testPlatformAndBuildType):
(testGenerateWebkitBuildersFromBuilderList):
* TestResultServer/static-dashboards/timeline_explorer.html:
* TestResultServer/static-dashboards/treemap.html:
Delay generating the page until the builder list has loaded.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix complex strokes on CG platform
commit-queue@webkit.org [Sat, 31 Mar 2012 23:09:40 +0000 (23:09 +0000)]
Fix complex strokes on CG platform
https://bugs.webkit.org/show_bug.cgi?id=80423

Patch by Philip Rogers <pdr@google.com> on 2012-03-31
Reviewed by Eric Seidel.

This change fixes a mistake in r112667 where the CG platform did not properly handle
complex strokes. The mistake was to check for complex fills instead of complex strokes,
which resulted in all complex strokes rendering as black.

No new tests, this change is covered by the following existing tests that were regressed:
1) svg/custom/gradient-stroke-width.svg
2) svg/custom/transform-with-shadow-and-gradient.svg

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformStrokeEllipse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIf NRWT gets killed halfway through a run, it incorrectly reports tests that weren...
ojan@chromium.org [Sat, 31 Mar 2012 23:02:48 +0000 (23:02 +0000)]
If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Eric Seidel.

If we don't run a test, mark it as skipped.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._mark_interrupted_tests_as_skipped):
(Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOne more build fix after r112781 for Chromium Windows.
rniwa@webkit.org [Sat, 31 Mar 2012 21:37:44 +0000 (21:37 +0000)]
One more build fix after r112781 for Chromium Windows.
Don't copy zip .idb files.

* BuildSlaveSupport/built-product-archive:
(copyBuildFiles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't insert linebreaks into text input fields.
jochen@chromium.org [Sat, 31 Mar 2012 21:17:49 +0000 (21:17 +0000)]
Don't insert linebreaks into text input fields.
https://bugs.webkit.org/show_bug.cgi?id=81660

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/forms/textfield-no-linebreak.html

* editing/TypingCommand.cpp:
(canAppendNewLineFeed): Only assume that a linefeed can be appended, if
after the BeforeTextInserted event the event text is still a newline.

LayoutTests:

* fast/forms/textfield-no-linebreak.html: Added.
* fast/forms/textfield-no-linebreak-expected.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoYet another build fix after r112781 for Chromium Windows.
rniwa@webkit.org [Sat, 31 Mar 2012 20:24:20 +0000 (20:24 +0000)]
Yet another build fix after r112781 for Chromium Windows.
Run webkit-build-directory by perl explicitly.

* BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago32-bit plug-ins need to opt into magnified mode
andersca@apple.com [Sat, 31 Mar 2012 20:03:55 +0000 (20:03 +0000)]
32-bit plug-ins need to opt into magnified mode
https://bugs.webkit.org/show_bug.cgi?id=82837
<rdar://problem/9104840>

Reviewed by Simon Fraser.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
zimmermann@webkit.org [Sat, 31 Mar 2012 19:13:14 +0000 (19:13 +0000)]
LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469

Source/WebCore:

Fix regression from r112391. The test excerising this code path is skipped on Lion, due to a libxml2 bug.
I didn't notice I broke preserveAspectRatio parsing for many corner cases, revert to old logic.

* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parse):

LayoutTests:

Reviewed by Dirk Schulze.

Unskip test, as the regression is fixed.

* platform/qt/Skipped:
* svg/custom/preserve-aspect-ratio-syntax.svg:
    Remove one incorrect testcase (which was actually valid and thus doesn't result in a default pAR attribute value).
    Can't rebaseline this on Mac Lion, as its skipped to a libxml2 bug, which will be addressed soon.
* svg/dom/preserve-aspect-ratio-parser-expected.txt:
* svg/dom/preserve-aspect-ratio-parser.html: Switch numbers to constants, so this test is actually readable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCSSStyleRules should own their CSSStyleDeclarations
antti@apple.com [Sat, 31 Mar 2012 18:02:35 +0000 (18:02 +0000)]
CSSStyleRules should own their CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=82832

Reviewed by Andreas Kling.

Move the rule properties CSSOM wrapper ownership from the StylePropertySet to the rule itself.
This is preparation for bug 82728 (Split remaining CSSRules into internal and CSSOM types). This
temporarily grows the size of CSSStyleRule by a pointer (82728 will give the memory back and more)

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
(WebCore):
(WebCore::CSSFontFaceRule::style):
* css/CSSFontFaceRule.h:
(WebCore):
(CSSFontFaceRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::style):
* css/CSSPageRule.h:
(WebCore):
(CSSPageRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::style):
* css/CSSStyleRule.h:
(WebCore):
(CSSStyleRule):

    Make the rules own the property CSSOM wrapper.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::ref):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::deref):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::StyleRuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::ref):
(WebCore::InlineCSSStyleDeclaration::deref):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::clearParentRule):
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::parentRule):

    - Rename RuleCSSStyleDeclaration -> StyleRuleCSSStyleDeclaration
    - Make StyleRuleCSSStyleDeclaration use regular refcounting since
      it is no longer owned by the wrapped object.
    - Rename hasCSSOMWrapper() -> isMutable(), m_hasCSSOMWrapper -> m_ownsCSSOMWrapper
      to match the purpose.

(InlineCSSStyleDeclaration):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentElement):
* css/StylePropertySet.h:
(StylePropertySet):
(WebCore::StylePropertySet::isMutable):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112798 268f45cc-cd09-0410-ab3c-d52691b4dbfc