platform/upstream/dotnet/runtime.git
5 years agoRe-enable xunit warning 2002 dotnet/corefx#39696 (dotnet/corefx#39706)
Zoey McCullough [Fri, 26 Jul 2019 13:58:06 +0000 (06:58 -0700)]
Re-enable xunit warning 2002 dotnet/corefx#39696 (dotnet/corefx#39706)

* Removed null checks on value types and enabled xunit 2002

* Updated Fill_OpenDataReader_Throws to use range check

Updated Fill_OpenDataReader_Throws to use range check for passing path

* Removed uneeded asserts and updated others

- Removed any assert for a valuetype where it was succeeded by a value type assertion (e.g. Assert.Equal(1, 1))
- Updated reflection tests to check flags for the specified scenario

* Update src/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Update src/System.Reflection/tests/AssemblyNameTests.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Fixed failing reflection tests and removed Assert.NotNull for enum

* Pulled ruleset up from master to merge

* Cleaned up assert ordering for TestGuid

* Updated TestResponseWithoutContentEvents

- Asserted for 200 OK based on response from DefaultAzureServer + EmptyContentHandler

Commit migrated from https://github.com/dotnet/corefx/commit/c96e389f803b043753558878fefb575f3f85c934

5 years agoFix NRE when MatchEvaluator returns null (dotnet/corefx#39779)
Dan Moseley [Fri, 26 Jul 2019 05:27:18 +0000 (22:27 -0700)]
Fix NRE when MatchEvaluator returns null (dotnet/corefx#39779)

* Fix NRE when MatchEvaluator returns null

* Update Regex.Replace.Tests.cs

* Use fancy syntax

Commit migrated from https://github.com/dotnet/corefx/commit/98227597b152076cb02c55bb695c572c14284e32

5 years agoRe-enable CA1200 (avoid cref tag prefixes) (dotnet/corefx#39773)
Stephen Toub [Fri, 26 Jul 2019 02:04:39 +0000 (22:04 -0400)]
Re-enable CA1200 (avoid cref tag prefixes) (dotnet/corefx#39773)

* Re-enable CA1200 (avoid cref tag prefixes)

Specifying the prefix prevents the compiler from validating what comes after it.

* Fix netfx build

Commit migrated from https://github.com/dotnet/corefx/commit/58a4d24eb808936f7dc61e68265e968291470b42

5 years agoRe-enable CA1802 (use consts instead of readonly statics) (dotnet/corefx#39782)
Stephen Toub [Fri, 26 Jul 2019 02:02:21 +0000 (22:02 -0400)]
Re-enable CA1802 (use consts instead of readonly statics) (dotnet/corefx#39782)

* Re-enable CA1802 (use consts instead of readonly statics)

I enabled it only for privates and internals, as we've previously violated this in public surface area, and as everything goes through API review moving forward, didn't seem worthwhile fighting it and adding suppressions in various places.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/318b5941ba4e713155d82c674c7f5bd0e68faf7b

5 years agoRelax a mutex test condition (dotnet/corefx#39786)
Koundinya Veluri [Thu, 25 Jul 2019 22:21:00 +0000 (15:21 -0700)]
Relax a mutex test condition (dotnet/corefx#39786)

Fixes https://github.com/dotnet/corefx/issues/39694
- When doing a `WaitAny()` with mutexes that are expected to be abandoned and an event that is signaled, it has been seen in the CI on Windows that sometimes the `WaitAny()` may succeed due to event rather than identifying an abandoned mutex. The CLR doesn't do anything special and just delegates to the OS, the only way that could happen is if there could be a delay between the thread exiting and the mutex being released and abandoned. I haven't been able to repro that behavior or the test failure on my machine, it may not be easy to repro, even in the CI it fails only occasionally.
- It's not a bug as long as the mutex eventually gets released and abandoned. Relaxed the condition for `WaitAny()` with an event following a mutex to account for a delay.

Commit migrated from https://github.com/dotnet/corefx/commit/97d5957fc71853961082e22873d926269b291b92

5 years agoReduce memory usage of tests and fix asserts for escaped size (dotnet/corefx#39751)
Steve Harter [Thu, 25 Jul 2019 20:24:44 +0000 (15:24 -0500)]
Reduce memory usage of tests and fix asserts for escaped size (dotnet/corefx#39751)

Commit migrated from https://github.com/dotnet/corefx/commit/3e36efc9a3c3f22b87c5f33a25c0ad5dbfeb9396

5 years agoExclude System.Numerics.Tensors Symbol package from publishing (dotnet/corefx#39772)
William Godbe [Thu, 25 Jul 2019 19:18:53 +0000 (12:18 -0700)]
Exclude System.Numerics.Tensors Symbol package from publishing (dotnet/corefx#39772)

Commit migrated from https://github.com/dotnet/corefx/commit/83a6ce4e0ec24791277be6de3ca23d7fdfb56fe1

5 years agoMerge pull request dotnet/corefx#39745 from geoffkizer/requesterrorfix
Geoff Kizer [Thu, 25 Jul 2019 19:07:05 +0000 (12:07 -0700)]
Merge pull request dotnet/corefx#39745 from geoffkizer/requesterrorfix

HTTP2: fix race between request failure and response body read

Commit migrated from https://github.com/dotnet/corefx/commit/64a9e2ccf5e590e0a3a3d6dc9c2a7c828850c912

5 years agoAdd [Obsolete] to vbNewLine (dotnet/corefx#39753)
Charles Stoner [Thu, 25 Jul 2019 15:09:17 +0000 (08:09 -0700)]
Add [Obsolete] to vbNewLine (dotnet/corefx#39753)

Commit migrated from https://github.com/dotnet/corefx/commit/75c4a6ee39219480cfeb372c68fd72df90d63c86

5 years agoChange the default symmetric encryption algorithm for EnvelopedCms
Jeremy Barton [Thu, 25 Jul 2019 14:46:11 +0000 (07:46 -0700)]
Change the default symmetric encryption algorithm for EnvelopedCms

.NET Framework upgraded this for 4.8, .NET Core should for 3.0

Commit migrated from https://github.com/dotnet/corefx/commit/64b72f0474555e5039e22a399dbcac289368f68a

5 years agoMerge pull request dotnet/corefx#39632 from eiriktsarpalis/httpstress-segregate-clien...
Eirik Tsarpalis [Thu, 25 Jul 2019 11:12:15 +0000 (12:12 +0100)]
Merge pull request dotnet/corefx#39632 from eiriktsarpalis/httpstress-segregate-client-server

HttpStress: Allow standalone client and server processes

Commit migrated from https://github.com/dotnet/corefx/commit/b5483cb5280235a94b534c93e678e647cfcecd0c

5 years agoRe-enable xUnit1025 (duplicate InlineData) (dotnet/corefx#39737)
Stephen Toub [Thu, 25 Jul 2019 08:45:20 +0000 (04:45 -0400)]
Re-enable xUnit1025 (duplicate InlineData) (dotnet/corefx#39737)

Commit migrated from https://github.com/dotnet/corefx/commit/47d96f89df41ce18d3ba77b38007ec68f7f66fc6

5 years agoAuto-generate the reference assemblies to normalize them (dotnet/corefx#39681)
Ahson Khan [Thu, 25 Jul 2019 03:44:48 +0000 (20:44 -0700)]
Auto-generate the reference assemblies to normalize them (dotnet/corefx#39681)

* Update Microsoft.VisualBasic.Core ref

* Update System.Collections.Concurrent ref

* Update System.Collections.Immutable ref

* Update System.Collections ref

* Update System.ComponentModel.Composition ref

* Update System.Data.Common ref

* Update System.Data.OleDb ref

* Update System.Data.SqlClient ref for netcoreapp

* Update System.Diagnostics.DiagnosticSource ref and DiagnosticSourceActivity.cs

* Update System.IO.Packaging ref for netcoreapp

* Update System.IO.Pipelines ref

* Update System.Linq ref

* Update System.Net.Http ref

* Update System.Net.Security ref

* Update System.Numerics.Tensors ref

* Update System.Reflection.Emit for netcore

* Update System.Security.AccessControl ref

* Update System.Security.Permissions ref

* Update System.ServiceModel.Syndication ref

* Update System.Text.Encodings.Web ref

* Update System.Threading.Channels ref for netcoreapp

* Update System.Utf8String.Experimental ref

* Update System.Utf8String.Experimental csproj to reference new file.

* Upat eSystem.Runtime ref and Manual ref

* Update Microsoft.Bcl.AsyncInterfaces ref

* Disable warning CS8617 for missing nullability annotations within
explicit interface methods.

* Revert System.Runtime.cs back to what's in master.

* Update System.Runtime ref (single change - System.Char -> char).

* Revert System.Collections.Immutable back to what's in master (keep
readonly on private fields).

* Update System.Runtime ref and add comment in Manual ref file for
TypedReference.

Commit migrated from https://github.com/dotnet/corefx/commit/bdd0814360d4c3a58860919f292a306242f27da1

5 years agoEnable xunit2007 analyzer (dotnet/corefx#39740)
Viktor Hofer [Thu, 25 Jul 2019 02:03:09 +0000 (04:03 +0200)]
Enable xunit2007 analyzer (dotnet/corefx#39740)

Commit migrated from https://github.com/dotnet/corefx/commit/619f140e2f0e722a17f3797d532b21ace774ec2e

5 years agoRe-enable xUnit2008 (Assert.True with regex) (dotnet/corefx#39739)
Stephen Toub [Thu, 25 Jul 2019 01:58:45 +0000 (21:58 -0400)]
Re-enable xUnit2008 (Assert.True with regex) (dotnet/corefx#39739)

Commit migrated from https://github.com/dotnet/corefx/commit/e091ee920b211b28a9d8a7928ca3b15294789d82

5 years agoRe-enable xUnit1016 (public MemberDatas) (dotnet/corefx#39738)
Stephen Toub [Thu, 25 Jul 2019 00:46:54 +0000 (20:46 -0400)]
Re-enable xUnit1016 (public MemberDatas) (dotnet/corefx#39738)

Commit migrated from https://github.com/dotnet/corefx/commit/306fe9d60cc6db02a69d8ea6b88dde2b98fe8a7c

5 years agoOnly removing logs which throw invalid parameters exception from eventLogs (dotnet...
Anirudh Agnihotry [Thu, 25 Jul 2019 00:46:40 +0000 (17:46 -0700)]
Only removing logs which throw invalid parameters exception from eventLogs (dotnet/corefx#39705)

* only removing logs which throw invalid parametert exception from eventlogs

* using ordinalIgnoreCase, const name and improving comment

Commit migrated from https://github.com/dotnet/corefx/commit/70aeda2b5b7110ead0ea69dc83f3f47e5728db06

5 years agoparameter name corrected (dotnet/corefx#39744)
Anirudh Agnihotry [Thu, 25 Jul 2019 00:45:38 +0000 (17:45 -0700)]
parameter name corrected (dotnet/corefx#39744)

Commit migrated from https://github.com/dotnet/corefx/commit/32d791286263d58e84a587b4a8be0d7d1e667f05

5 years agoMark System.Numerics.Tensors package as nonshipping (dotnet/corefx#39743)
William Godbe [Wed, 24 Jul 2019 23:22:54 +0000 (16:22 -0700)]
Mark System.Numerics.Tensors package as nonshipping (dotnet/corefx#39743)

* Mark System.Numerics.Tensors package as nonshipping

* Consolidate ItemGroup definition

Commit migrated from https://github.com/dotnet/corefx/commit/a5026415f84efec9c4a51efb6a654be1c4a86070

5 years agofix race between request failure and response body read
Geoff Kizer [Wed, 24 Jul 2019 20:58:28 +0000 (13:58 -0700)]
fix race between request failure and response body read

Commit migrated from https://github.com/dotnet/corefx/commit/a327d792c1590bd9ef744c197dfbb311961d5eef

5 years agoRe-emable CA1507 (use nameof) (dotnet/corefx#39731)
Stephen Toub [Wed, 24 Jul 2019 17:14:01 +0000 (13:14 -0400)]
Re-emable CA1507 (use nameof) (dotnet/corefx#39731)

Commit migrated from https://github.com/dotnet/corefx/commit/c265373119bc0449d347862862b43de35a95b186

5 years agoEnable xunit2012 analyzer (dotnet/corefx#39730)
Viktor Hofer [Wed, 24 Jul 2019 16:20:57 +0000 (18:20 +0200)]
Enable xunit2012 analyzer (dotnet/corefx#39730)

Commit migrated from https://github.com/dotnet/corefx/commit/722ab9b7303ef14db74a1d09d464d180f18f512b

5 years agoAdd comment descriptions to remaining xunit analyzer suppressions (dotnet/corefx...
Stephen Toub [Wed, 24 Jul 2019 14:50:31 +0000 (10:50 -0400)]
Add comment descriptions to remaining xunit analyzer suppressions (dotnet/corefx#39725)

Commit migrated from https://github.com/dotnet/corefx/commit/c1dae31100118f358ac8bf8707a9017c17576356

5 years agoRe-enable CA1825 (zero-length array allocations) (dotnet/corefx#39708)
Stephen Toub [Wed, 24 Jul 2019 14:42:39 +0000 (10:42 -0400)]
Re-enable CA1825 (zero-length array allocations) (dotnet/corefx#39708)

Commit migrated from https://github.com/dotnet/corefx/commit/d0fc0a2b193d11645acc0fe72bbf1b97678a5161

5 years agoRe-enable CA2200 (rethrowing exceptions in catch blocks) (dotnet/corefx#39700)
Stephen Toub [Wed, 24 Jul 2019 11:33:20 +0000 (07:33 -0400)]
Re-enable CA2200 (rethrowing exceptions in catch blocks) (dotnet/corefx#39700)

Commit migrated from https://github.com/dotnet/corefx/commit/7b142543ce066ba684303837c2e9723b9e140d39

5 years agoEnable xunit2015 analyzer (dotnet/corefx#39714)
Viktor Hofer [Wed, 24 Jul 2019 11:25:58 +0000 (13:25 +0200)]
Enable xunit2015 analyzer (dotnet/corefx#39714)

Commit migrated from https://github.com/dotnet/corefx/commit/a7fa4b58be0b266d8fe680de34f9b1a3dab8523a

5 years agoMerge pull request dotnet/corefx#39638 from geoffkizer/streamshutdownfixes4
Geoff Kizer [Wed, 24 Jul 2019 09:28:18 +0000 (02:28 -0700)]
Merge pull request dotnet/corefx#39638 from geoffkizer/streamshutdownfixes4

HTTP2: Rework shutdown handling

Commit migrated from https://github.com/dotnet/corefx/commit/ca3fe6738ae6afc56e1f8fb5477a57a8dc2e183c

5 years agoaddress review feedback and fix test issue
Geoff Kizer [Wed, 24 Jul 2019 07:47:35 +0000 (00:47 -0700)]
address review feedback and fix test issue

Commit migrated from https://github.com/dotnet/corefx/commit/d6e6f52c928f56b424b08fcf6e08ea84a74748ab

5 years agoRe-enable CA1401 (public P/Invoke methods) (dotnet/corefx#39710)
Stephen Toub [Wed, 24 Jul 2019 07:45:28 +0000 (03:45 -0400)]
Re-enable CA1401 (public P/Invoke methods) (dotnet/corefx#39710)

Commit migrated from https://github.com/dotnet/corefx/commit/28e0be5f236b57027b66395fcef87d3c58e31424

5 years agoRe-enable CA2008 (tasks without a TaskScheduler) (dotnet/corefx#39707)
Stephen Toub [Wed, 24 Jul 2019 07:44:54 +0000 (03:44 -0400)]
Re-enable CA2008 (tasks without a TaskScheduler) (dotnet/corefx#39707)

Commit migrated from https://github.com/dotnet/corefx/commit/9958740c24865cad40dd84bcd8c416cea927e3cc

5 years agoRe-enable CA1821 (remove empty finalizers) (dotnet/corefx#39709)
Stephen Toub [Wed, 24 Jul 2019 07:42:36 +0000 (03:42 -0400)]
Re-enable CA1821 (remove empty finalizers) (dotnet/corefx#39709)

Commit migrated from https://github.com/dotnet/corefx/commit/4cdbbd9430a3e080eb0926f612c89ffe74ed6e7e

5 years agoUpdate dummy fields within the ref by auto-generating them from the source assembly...
Ahson Khan [Wed, 24 Jul 2019 06:28:07 +0000 (23:28 -0700)]
Update dummy fields within the ref by auto-generating them from the source assembly. (dotnet/corefx#39687)

* Update dummy fields within the ref by auto-generating them from the
source assembly.

* Address feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/c50b758727a041aec2dc959ee5ca2df5614a3c16

5 years agoUpgrade Roslyn analyzers (dotnet/corefx#39703)
Stephen Toub [Wed, 24 Jul 2019 03:10:17 +0000 (23:10 -0400)]
Upgrade Roslyn analyzers (dotnet/corefx#39703)

* Upgrade analyzer versions

We were years behind.

* Fix nameof warnings in System.ComponentModel.Annotations

* Disable all rules with failures

* Enable CA2007 (ConfigureAwait)

* Enable CA5373, 5379, 5384, and 5385 (weak crypto)

* Remove stale nuget analyzer packages consumed into main package

* Enable CA2002

Commit migrated from https://github.com/dotnet/corefx/commit/0f1fa092672a344b92c4bc440f3ab6232614a7f4

5 years agoUpdate package testing to test for 5.0 and use the SDK targeting pack for 3.0
Santiago Fernandez Madero [Fri, 19 Jul 2019 22:48:01 +0000 (15:48 -0700)]
Update package testing to test for 5.0 and use the SDK targeting pack for 3.0

Commit migrated from https://github.com/dotnet/corefx/commit/e733500d11ae73f5ddba17b75127f1b3033c470c

5 years agoRe-enable xunit warning 2004 (dotnet/corefx#39698)
Stephen Toub [Tue, 23 Jul 2019 21:05:15 +0000 (17:05 -0400)]
Re-enable xunit warning 2004 (dotnet/corefx#39698)

* Replace "Assert.Equal(true, " with "Assert.True("

* Replace "Assert.Equal(false, " with "Assert.False("

And fix a few Assert.Equal(true cases that deal with objects and thus need to be reverted.

* Replace "Assert.StrictEqual(true, " with "Assert.True("

* Revert a few changes where true/false was being compared to object

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/1296bc8386a7283e319ddf723282f16651f9ea5f

5 years agofix race in request body completion
Geoff Kizer [Tue, 23 Jul 2019 20:18:56 +0000 (13:18 -0700)]
fix race in request body completion

Commit migrated from https://github.com/dotnet/corefx/commit/29328b71b65abe3a199f0daf62f6ee71ca916e78

5 years agofix race with _requestBodyCancellationSource creation
Geoff Kizer [Tue, 23 Jul 2019 08:10:16 +0000 (01:10 -0700)]
fix race with _requestBodyCancellationSource creation

Commit migrated from https://github.com/dotnet/corefx/commit/7394185c0fc8a52bebf384b933b07c1eb1fba360

5 years agorework SendHeadersAsync to address various issues
Geoff Kizer [Tue, 23 Jul 2019 05:15:05 +0000 (22:15 -0700)]
rework SendHeadersAsync to address various issues

Commit migrated from https://github.com/dotnet/corefx/commit/2d5a9555d4888c82c653a9d7ad8368bc94adfdf2

5 years agoaddress review feedback
Geoff Kizer [Tue, 23 Jul 2019 03:25:59 +0000 (20:25 -0700)]
address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/752c1c8d8a01d22d52b1a320f9ed082049494045

5 years agocombine into single Cancel method on stream, and ensure Dispose cancels properly...
Geoff Kizer [Sat, 20 Jul 2019 17:02:45 +0000 (10:02 -0700)]
combine into single Cancel method on stream, and ensure Dispose cancels properly when response is not read to end

Commit migrated from https://github.com/dotnet/corefx/commit/5973d1ee6f3b616d2af2bc80527bdf8fe76ee210

5 years agorework shutdown handling
Geoff Kizer [Fri, 12 Jul 2019 11:41:05 +0000 (04:41 -0700)]
rework shutdown handling

Commit migrated from https://github.com/dotnet/corefx/commit/0cd73b77e1f31d48037b56deb0206f4e56b4232e

5 years agoRe-enable xunit warning 2003 (dotnet/corefx#39696)
Stephen Toub [Tue, 23 Jul 2019 19:49:33 +0000 (15:49 -0400)]
Re-enable xunit warning 2003 (dotnet/corefx#39696)

* Replace "Assert.Equal(null, " with "Assert.Null("

* Replace "Assert.NotEqual(null, " with "Assert.NotNull("

* Replace "Assert.Same(null, " with "Assert.Null("

* Replace "Assert.StrictEqual(null, " with "Assert.Null("

Commit migrated from https://github.com/dotnet/corefx/commit/6de660a02e335eefebfcc3c81ecb0013e2a8148e

5 years agoMerge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore
Eirik Tsarpalis [Tue, 23 Jul 2019 17:43:46 +0000 (18:43 +0100)]
Merge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore

Add .dockerignore file to the root of the repo

Commit migrated from https://github.com/dotnet/corefx/commit/e6a5951fb68a09598f1fc1826a94de212385c649

5 years agoMake AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)
Egor Bogatov [Tue, 23 Jul 2019 14:25:37 +0000 (17:25 +0300)]
Make AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)

Commit migrated from https://github.com/dotnet/corefx/commit/794bde4b8eb26047b6495af09a428e03e81e7e81

5 years agoadd license notice to new source files
Eirik Tsarpalis [Tue, 23 Jul 2019 13:59:02 +0000 (14:59 +0100)]
add license notice to new source files

Commit migrated from https://github.com/dotnet/corefx/commit/930dc991ca17b759d675c5015cd9c61bc8a725be

5 years agoDisable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet...
Stephen Toub [Tue, 23 Jul 2019 13:09:51 +0000 (09:09 -0400)]
Disable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet/corefx#39692)

Commit migrated from https://github.com/dotnet/corefx/commit/687f36489c19072cd5a19d48c099f53bbc871c4d

5 years agoRe-enable xunit warning 1006 (dotnet/corefx#39685)
Stephen Toub [Tue, 23 Jul 2019 06:39:47 +0000 (02:39 -0400)]
Re-enable xunit warning 1006 (dotnet/corefx#39685)

Regex search and replace for [InlineData()] with [Theory].

Commit migrated from https://github.com/dotnet/corefx/commit/b58a866ba8709d66eed52bb8ecb13966b7436a1d

5 years agoRe-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)
Stephen Toub [Mon, 22 Jul 2019 20:56:01 +0000 (16:56 -0400)]
Re-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)

* Re-enable all DisableXUnitAnalyzer test projects

* Remove TODO comment

Commit migrated from https://github.com/dotnet/corefx/commit/16f3eef83d6df4c9dbc0e2992dafbc9553db363d

5 years agoRe-enable ~20 xunit analyzers (dotnet/corefx#39671)
Stephen Toub [Mon, 22 Jul 2019 20:45:03 +0000 (16:45 -0400)]
Re-enable ~20 xunit analyzers (dotnet/corefx#39671)

* Re-enable ~20 xunit analyzers

All but one of these had no associated warnings firing.  I fixed one warning to be able to re-enable another analyzer.

* Fix netfx build failures

Commit migrated from https://github.com/dotnet/corefx/commit/c60b8172cfcd1e7f0d8104872f279781fd288b68

5 years agoCustom converter contravariant test coverage (dotnet/corefx#39558)
buyaa-n [Mon, 22 Jul 2019 18:43:03 +0000 (11:43 -0700)]
Custom converter contravariant test coverage (dotnet/corefx#39558)

* Custom converter contravariant test coverage

Commit migrated from https://github.com/dotnet/corefx/commit/27228368037aeaa27fc5220d7d12c0550a2ef9c3

5 years agoUpdate breaking changes doc with a few clarifications (dotnet/corefx#39665)
Stephen Toub [Mon, 22 Jul 2019 18:06:56 +0000 (14:06 -0400)]
Update breaking changes doc with a few clarifications (dotnet/corefx#39665)

Commit migrated from https://github.com/dotnet/corefx/commit/f25b89e05594b0e56e1bea7080c935908142e960

5 years agoAdd missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)
Stephen Toub [Mon, 22 Jul 2019 16:32:21 +0000 (12:32 -0400)]
Add missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)

Without these, we can end up with corrupt encoder/decoder state due to uninitialized fields.

Commit migrated from https://github.com/dotnet/corefx/commit/3c3b9ceee6e1416db6f1ddbc1ab0d0ffb67c16fa

5 years agoRemove unnecessary empty try { } blocks (dotnet/corefx#39664)
Stephen Toub [Mon, 22 Jul 2019 16:30:03 +0000 (12:30 -0400)]
Remove unnecessary empty try { } blocks (dotnet/corefx#39664)

Unnecessary in .NET Core code.  I didn't modify additional instances in libraries that target netstandard/netfx.

Commit migrated from https://github.com/dotnet/corefx/commit/ca795a928d210c78c6bbd3fa10eb35f4c093a5a4

5 years agostress server cleanups
Eirik Tsarpalis [Mon, 22 Jul 2019 12:03:17 +0000 (13:03 +0100)]
stress server cleanups

Commit migrated from https://github.com/dotnet/corefx/commit/358267704c7f6dc7a214353be151ea83e37f8fc7

5 years agofix build
Eirik Tsarpalis [Mon, 22 Jul 2019 10:20:21 +0000 (11:20 +0100)]
fix build

Commit migrated from https://github.com/dotnet/corefx/commit/01d3536ed7d2677f92f50c6fa53ccf3d8ca2f28c

5 years agoDisable DefaultPageSettings_Null_ReturnsExpected test (dotnet/corefx#39647)
Stephen Toub [Sun, 21 Jul 2019 01:45:58 +0000 (21:45 -0400)]
Disable DefaultPageSettings_Null_ReturnsExpected test (dotnet/corefx#39647)

Commit migrated from https://github.com/dotnet/corefx/commit/9bb93a61365db848aaf914b5dfb8d6684df3335e

5 years agoFix NullReferenceExceptions in IndentedTextWriter without writer (dotnet/corefx#39584)
Hugh Bellamy [Sun, 21 Jul 2019 00:59:51 +0000 (01:59 +0100)]
Fix NullReferenceExceptions in IndentedTextWriter without writer (dotnet/corefx#39584)

Commit migrated from https://github.com/dotnet/corefx/commit/52f0a9192d1fcf624252c79e1fe5aa057f1db719

5 years agoFix up cgroup2fs in Interop.MountPoints.FormatInfo (dotnet/corefx#39633)
Omair Majid [Sun, 21 Jul 2019 00:54:49 +0000 (20:54 -0400)]
Fix up cgroup2fs in Interop.MountPoints.FormatInfo (dotnet/corefx#39633)

`stat -fc %T /sys/fs/cgroup` calls this file system `cgroup2fs`

Add the cgroup2fs file system magic number. Available from:

  - https://www.kernel.org/doc/Documentation/cgroup-v2.txt
  - man 2 statfs

Move cgroup2fs next to cgroupfs in the drive type list, since it is also
DriveType.Ram.

Commit migrated from https://github.com/dotnet/corefx/commit/11416bd48af2c695dde9ef0057659249be10f12d

5 years agoPass CancellationToken from Http2Connection.SendHeadersAsync to StartWriteAsync ...
Stephen Toub [Sun, 21 Jul 2019 00:47:17 +0000 (20:47 -0400)]
Pass CancellationToken from Http2Connection.SendHeadersAsync to StartWriteAsync (dotnet/corefx#39635)

Commit migrated from https://github.com/dotnet/corefx/commit/9597dadcea747960aba304253370a17a2218208d

5 years agoDisable nullable warnings for netstandard and netfx (dotnet/corefx#39636)
Stephen Toub [Sat, 20 Jul 2019 12:47:08 +0000 (08:47 -0400)]
Disable nullable warnings for netstandard and netfx (dotnet/corefx#39636)

Commit migrated from https://github.com/dotnet/corefx/commit/e64cac6dcacf996f98f0b3f75fb7ad0c12f588f7

5 years agoPort some methods of the VB Interaction module (dotnet/corefx#39574)
Edison Henrique Andreassy [Sat, 20 Jul 2019 04:04:33 +0000 (01:04 -0300)]
Port some methods of the VB Interaction module (dotnet/corefx#39574)

Commit migrated from https://github.com/dotnet/corefx/commit/45851336efa3b754f427d00cef3d388357aed308

5 years agoRemove unnecessary use of volatile in PartitionerStatic (dotnet/corefx#39591)
Stephen Toub [Sat, 20 Jul 2019 01:09:49 +0000 (21:09 -0400)]
Remove unnecessary use of volatile in PartitionerStatic (dotnet/corefx#39591)

`SharedInt`, which is just an object wrapper around a `volatile int` was being used even though a) the objects weren't actually being shared, and b) the stored `int` was sometimes being passed by `ref` and thus losing its voliatility in some cases anyway.

(It's not entirely clear why an object is being used, regardless, but from the comments it appears to be due to concerns around false sharing.  Presumably cases were found where the enumerators were all allocated up-front resulting in these ints stored as part of the enumerator objects ending up on the same cache line, so they were moved to objects allocated on discrete threads during MoveNext to minimize that possibility.)

Commit migrated from https://github.com/dotnet/corefx/commit/7f21952eed6c421d6854bcce3c0a8f76f2d5de9b

5 years agoregular comment
Eirik Tsarpalis [Fri, 19 Jul 2019 23:15:59 +0000 (00:15 +0100)]
regular comment

Commit migrated from https://github.com/dotnet/corefx/commit/4e9a2648cd0a5f116af2ecef5879866688b034cb

5 years agoaddress feedback
Eirik Tsarpalis [Fri, 19 Jul 2019 23:12:18 +0000 (00:12 +0100)]
address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/1c3de2a6aee80cf5c56d4ac118ee8f7157a8d112

5 years agoHttpStress: Segregate Client & Server into separate classes and support running stand...
Eirik Tsarpalis [Fri, 19 Jul 2019 21:23:33 +0000 (22:23 +0100)]
HttpStress: Segregate Client & Server into separate classes and support running standalone servers and clients

Commit migrated from https://github.com/dotnet/corefx/commit/371f8f2ae76308c7aad6b98eb209d06f485c2c94

5 years agoDon't dispose StreamPipeWriter CancellationToken until after Flush (dotnet/corefx...
Justin Kotalik [Fri, 19 Jul 2019 19:53:12 +0000 (12:53 -0700)]
Don't dispose StreamPipeWriter CancellationToken until after Flush (dotnet/corefx#39610) (dotnet/corefx#39620)

Commit migrated from https://github.com/dotnet/corefx/commit/7431e4938c461f6e24cf3122c0b9ca4eb27e4dde

5 years agoRe-enable unicode host name test (dotnet/corefx#39606)
Stephen Toub [Fri, 19 Jul 2019 14:08:42 +0000 (10:08 -0400)]
Re-enable unicode host name test (dotnet/corefx#39606)

Site appears to be back up.

Commit migrated from https://github.com/dotnet/corefx/commit/1303d28179b4369cbfac43affd723fa6e0bc9554

5 years agoAvoid "async void" tests (dotnet/corefx#39613)
Stephen Toub [Fri, 19 Jul 2019 14:07:15 +0000 (10:07 -0400)]
Avoid "async void" tests (dotnet/corefx#39613)

Most of these are just because "async void" tests are rare and require special handling in xunit we needn't use.  But a few of these are plain wrong and were resulting in our not actually testing what we hoped to test.

Commit migrated from https://github.com/dotnet/corefx/commit/50d8c71bb6139f3c06dd820d6d757a095a9fe994

5 years agoAdd telemetry marker for tests (dotnet/corefx#39619)
Viktor Hofer [Fri, 19 Jul 2019 13:43:31 +0000 (15:43 +0200)]
Add telemetry marker for tests (dotnet/corefx#39619)

Commit migrated from https://github.com/dotnet/corefx/commit/cce2f2e92b75a42d07da123e091ac96fb47f44c5

5 years agoFix in System.Data.Common namespace, use correct WriteAttributeString API (dotnet...
Cheena Malhotra [Thu, 18 Jul 2019 22:45:54 +0000 (15:45 -0700)]
Fix in System.Data.Common namespace, use correct WriteAttributeString API (dotnet/corefx#39543)

Commit migrated from https://github.com/dotnet/corefx/commit/182bed51dec709b3b1b56a4f435e0727e5dea110

5 years agoRemove dead ifdef'd code from Microsoft.CSharp/VisualBasic (dotnet/corefx#39587)
Stephen Toub [Thu, 18 Jul 2019 18:23:46 +0000 (14:23 -0400)]
Remove dead ifdef'd code from Microsoft.CSharp/VisualBasic (dotnet/corefx#39587)

Commit migrated from https://github.com/dotnet/corefx/commit/9c2682f5899f280e3ca2e52569f84eaecb255647

5 years agoMove ConnectAsync_AddCustomHeaders_Success ClientWebSocket test to loopback (dotnet...
Stephen Toub [Thu, 18 Jul 2019 18:21:49 +0000 (14:21 -0400)]
Move ConnectAsync_AddCustomHeaders_Success ClientWebSocket test to loopback (dotnet/corefx#39589)

Commit migrated from https://github.com/dotnet/corefx/commit/83954bb1404c5bdfb56130c5a4994e5e05403beb

5 years agoFix ordering of visibility and abstract/virtual/override (dotnet/corefx#39590)
Stephen Toub [Thu, 18 Jul 2019 18:21:08 +0000 (14:21 -0400)]
Fix ordering of visibility and abstract/virtual/override (dotnet/corefx#39590)

To conform to expected style across corefx.

Commit migrated from https://github.com/dotnet/corefx/commit/b95ad3c0f9066fa426754bd6e3379fbaca24834e

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#39567)
dotnet-maestro[bot] [Thu, 18 Jul 2019 18:20:31 +0000 (11:20 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#39567)

* Update dependencies from https://github.com/dotnet/coreclr build 20190716.2

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19366.2
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19366.2

* Ignore System.Private.Corelib in netcoreapp3.0 package testing

Commit migrated from https://github.com/dotnet/corefx/commit/167bb417724b2338df492b417bdfea89d458e473

5 years agoCode coverage for JsonWriterHelper JsonWriter (dotnet/corefx#39407)
buyaa-n [Thu, 18 Jul 2019 17:59:35 +0000 (10:59 -0700)]
Code coverage for JsonWriterHelper JsonWriter (dotnet/corefx#39407)

* Code coverage for JsonWriterHelper JsonWriter

* Applying feedback

* Some updates was not saved for previous commit

* Remove not needed row, formatting

* Removing tests not needed anymore

* Applying feedback

Commit migrated from https://github.com/dotnet/corefx/commit/4cbad86c4e6aeaa135b9a569dbde9151180c40f5

5 years agoFold a bunch of CoreCLR's abandoned mutex tests into a parameterized test (dotnet...
Koundinya Veluri [Thu, 18 Jul 2019 17:48:31 +0000 (10:48 -0700)]
Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test (dotnet/corefx#39050)

Fold a bunch of CoreCLR's abandoned mutex tests into a parameterized test

- There are a large number of tests in CoreCLR with a lot of redundancy, timing issues, and which take unnecessarily long to run
- Folded a bunch of them into the existing parameterized test and improved it to cover more cases to replace the tests in CoreCLR that will be removed
- Coverage is not 100% equivalent, but I belive this sufficiently covers the necessary aspects of the tests in CoreCLR that will be removed

Commit migrated from https://github.com/dotnet/corefx/commit/fa722debec4c18a444a207171b686e40d7c0fc1a

5 years agoMake all events nullable (dotnet/corefx#39578)
Santiago Fernandez Madero [Thu, 18 Jul 2019 03:07:03 +0000 (20:07 -0700)]
Make all events nullable (dotnet/corefx#39578)

Commit migrated from https://github.com/dotnet/corefx/commit/ba2d62a24ea8574f40c43cd27cc384f079958a0c

5 years agoChange HttpStress app to highlight in red unchanged totals (dotnet/corefx#39576)
Stephen Toub [Wed, 17 Jul 2019 21:53:30 +0000 (17:53 -0400)]
Change HttpStress app to highlight in red unchanged totals (dotnet/corefx#39576)

When no additional operations have completed since the last time status was output, highlight that in red.

Commit migrated from https://github.com/dotnet/corefx/commit/53dc908890102d3a888ba603a06266b85d3f4a9b

5 years agoInclude file SafeHandleTest.cs into the project. (dotnet/corefx#39573)
David Cantu [Wed, 17 Jul 2019 20:39:10 +0000 (13:39 -0700)]
Include file SafeHandleTest.cs into the project. (dotnet/corefx#39573)

Commit migrated from https://github.com/dotnet/corefx/commit/9a29c851b33d904b5706e90c4f5309f2f8f1fece

5 years agoSpanify Cryptography.Base64Transform
Günther Foidl [Wed, 17 Jul 2019 18:06:17 +0000 (20:06 +0200)]
Spanify Cryptography.Base64Transform

So it can be non-allocating byte[] -> byte[], instead of allocating (temp. buffer) and copying with byte[] -> char[] -> byte[].

Commit migrated from https://github.com/dotnet/corefx/commit/d4a935c526f5f84d6136066bd554f619ed0b7476

5 years agoMove ASN.1 decoding/encoding out of PkcsPal
Filip Navara [Wed, 17 Jul 2019 18:05:00 +0000 (20:05 +0200)]
Move ASN.1 decoding/encoding out of PkcsPal

Both the Windows version and the AnyOS version will use the managed ASN.1/BER/DER code via PkcsHelpers.

Commit migrated from https://github.com/dotnet/corefx/commit/ccad56758140def8084943e5a8f2acabbf81d454

5 years agoSocket: improve cross-platform behavior on Dispose (dotnet/corefx#38804)
Tom Deseyn [Wed, 17 Jul 2019 15:48:33 +0000 (17:48 +0200)]
Socket: improve cross-platform behavior on Dispose (dotnet/corefx#38804)

* Add tests

* Don't skip SyncSendFileGetsCanceledByDispose on .NET Framework

* Implement using code from previous PR

* Update SocketErrors when CleanedUp for APM APIs

* Cleanup SO_TYPE socket length handling (Fixes https://github.com/dotnet/corefx/issues/38750)

* SyncSendFileGetsCanceledByDispose: remove SkipTargetFramework NetFramework

* PR feedback

* Fix comment typo

* Also wait for async operations, and wait longer on each retry

* clear sockaddr using memset

* Fix build

* Only perform CLOEXEC check for non-abortive close

Commit migrated from https://github.com/dotnet/corefx/commit/9b2f7a834691a3bbad2949181eec707dd4b5a13b

5 years agoIncrease connect timeout for Functional Tests (dotnet/corefx#39559)
v-jizho2 [Wed, 17 Jul 2019 03:37:31 +0000 (20:37 -0700)]
Increase connect timeout for Functional Tests (dotnet/corefx#39559)

Commit migrated from https://github.com/dotnet/corefx/commit/da3d086edde315db03ff9b04c2926ab22940d50c

5 years agoEnable HttpStress to target http.sys in addition to Kestrel (dotnet/corefx#39553)
Stephen Toub [Tue, 16 Jul 2019 23:31:47 +0000 (19:31 -0400)]
Enable HttpStress to target http.sys in addition to Kestrel (dotnet/corefx#39553)

Commit migrated from https://github.com/dotnet/corefx/commit/d34317fbfb4963e7d42b96c36c314e2af829c3c7

5 years agoAdd UnsafeRelaxedJsonEscaping static to JavascriptEncoder. (dotnet/corefx#39550)
Ahson Khan [Tue, 16 Jul 2019 23:18:22 +0000 (16:18 -0700)]
Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder. (dotnet/corefx#39550)

* Add UnsafeRelaxedJsonEscaping static to JavascriptEncoder.

* Remove duplicate test case and fix test name.

* Fix formatting nits and move the new class to a separate file.

* No need to special case single quote, and fix more formatting.

* Update the remarks section to call out the difference between Default
and Relaxed.

Commit migrated from https://github.com/dotnet/corefx/commit/30ece647dae7d9ddff8a24cdd615119fde259927

5 years agoUpdate branding in master to 5.0 (dotnet/corefx#39503)
William Godbe [Tue, 16 Jul 2019 22:47:57 +0000 (15:47 -0700)]
Update branding in master to 5.0 (dotnet/corefx#39503)

* Update branding in master to 5.0

* Revert to old AssemblyVersions

* Update to correct package versions

* Update Prerelease to alpha1

* Remove redundant PackageVersions

* Disable index check

* Update packageIndex

* Update PackageIndex again

* Revert incorrect packageIndex versions

Commit migrated from https://github.com/dotnet/corefx/commit/1acaa2017cfc64ef1aabcf3b19d0e097af692616

5 years agoMerge pull request dotnet/corefx#39343 from geoffkizer/enableremotetestsforhttp2
Geoff Kizer [Tue, 16 Jul 2019 22:09:58 +0000 (15:09 -0700)]
Merge pull request dotnet/corefx#39343 from geoffkizer/enableremotetestsforhttp2

ensure remote server HTTP2 tests are actually using HTTP2

Commit migrated from https://github.com/dotnet/corefx/commit/6ec67c15c3f213206e9cf66a2d69d274d3836e6b

5 years agoClean up date helper (dotnet/corefx#39548)
Layomi Akinrinade [Tue, 16 Jul 2019 21:48:53 +0000 (17:48 -0400)]
Clean up date helper (dotnet/corefx#39548)

Commit migrated from https://github.com/dotnet/corefx/commit/9711b084829db7b8f69b3d3eb9effa3d2bdc0699

5 years agoFix Utf8JsonWriter xml docs (dotnet/corefx#39092)
Santiago Fernandez Madero [Tue, 16 Jul 2019 21:15:10 +0000 (14:15 -0700)]
Fix Utf8JsonWriter xml docs (dotnet/corefx#39092)

* Fix Utf8JsonWriter xml docs

* PR Feedback

* PR Feedback

* PR Feedback put back remarks for ROS/string overrides

* Remove duplicate remarks

* PR Feedback

* PR Feedback, i.e. -> that is

Commit migrated from https://github.com/dotnet/corefx/commit/7b90f41828abea1d9db6d55403a849c2613d996d

5 years agoSpecify DateTimeKind.Utc in JSON tests to avoid ArgumentOutOfRangeException (dotnet...
Martin Björkström [Tue, 16 Jul 2019 21:01:13 +0000 (00:01 +0300)]
Specify DateTimeKind.Utc in JSON tests to avoid ArgumentOutOfRangeException (dotnet/corefx#39547)

Commit migrated from https://github.com/dotnet/corefx/commit/6cd505d9aaabe656707766dee22e9aec0404568f

5 years agodisable two slow tests that time out in CI
Geoff Kizer [Tue, 16 Jul 2019 19:16:58 +0000 (12:16 -0700)]
disable two slow tests that time out in CI

Commit migrated from https://github.com/dotnet/corefx/commit/3bf02562f062bdf0faf787f7cfe1d67539363ed5

5 years agoFix datetime bug (dotnet/corefx#39541)
Layomi Akinrinade [Tue, 16 Jul 2019 18:59:27 +0000 (14:59 -0400)]
Fix datetime bug (dotnet/corefx#39541)

Commit migrated from https://github.com/dotnet/corefx/commit/05c0f516cf20cd6ae108ba034984b0cdc740732e

5 years agoDo not over-escape writing Base64 strings within JSON using the writer. (dotnet/coref...
Ahson Khan [Tue, 16 Jul 2019 18:56:21 +0000 (11:56 -0700)]
Do not over-escape writing Base64 strings within JSON using the writer. (dotnet/corefx#39522)

Commit migrated from https://github.com/dotnet/corefx/commit/063e38c7bc66e076fdcc7521e4c69650baae9427

5 years agoAdd arm64 runtime ids for Fedora and RHEL 8
Omair Majid [Tue, 16 Jul 2019 18:44:51 +0000 (14:44 -0400)]
Add arm64 runtime ids for Fedora and RHEL 8

Both Fedora and RHEL 8 have arm64 (aka aarch64) among the primary/main
architectures they support.

Fedora includes aarch64 as a "Primary Architecture":
https://fedoraproject.org/wiki/Architectures#Primary_Architectures

RHEL 8 lists aarch64 right next to x86_64 in the developer download site:
https://developers.redhat.com/products/rhel/download

Commit migrated from https://github.com/dotnet/corefx/commit/ec18a81e92f531343ea754d355c6d2665d36c2ef

5 years agoChange callbacks to virtual from being abstract (dotnet/corefx#39526)
David Fowler [Tue, 16 Jul 2019 17:35:33 +0000 (10:35 -0700)]
Change callbacks to virtual from being abstract (dotnet/corefx#39526)

- Obsolete the callbacks as well

Commit migrated from https://github.com/dotnet/corefx/commit/51cd78434953683040f93e69ed2a889e476f5cac

5 years agoFix HttpStress GET Parameters operation to respect Kestrel max line length (dotnet...
Stephen Toub [Tue, 16 Jul 2019 17:04:40 +0000 (13:04 -0400)]
Fix HttpStress GET Parameters operation to respect Kestrel max line length (dotnet/corefx#39535)

* Fix HttpStress GET Parameters operation to respect Kestrel max line length

* Address PR feedback

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/bb0516a4f8d0c4d84eff2ba2a3ad0a4764ece9d2

5 years agoAdd negative tests for ValidateNumber
Jeremy Barton [Tue, 16 Jul 2019 16:49:08 +0000 (09:49 -0700)]
Add negative tests for ValidateNumber

With this change ValidateNumber gets to 100% block coverage.

Commit migrated from https://github.com/dotnet/corefx/commit/7fe5f15813aedc2144b348baa2f26e7289618a05

5 years agoAdd Encoder option to writer and serializer (dotnet/corefx#39524)
Steve Harter [Tue, 16 Jul 2019 16:29:20 +0000 (09:29 -0700)]
Add Encoder option to writer and serializer (dotnet/corefx#39524)

Commit migrated from https://github.com/dotnet/corefx/commit/bc10b53838bc84ac2b626e16eee1338183ee55c8

5 years agoRemove a few unnecessary !s (dotnet/corefx#39531)
Stephen Toub [Tue, 16 Jul 2019 15:10:12 +0000 (11:10 -0400)]
Remove a few unnecessary !s (dotnet/corefx#39531)

Commit migrated from https://github.com/dotnet/corefx/commit/2b6f38911bb45548c8d1db015526518276e6c888

5 years agoMerge pull request dotnet/corefx#39485 from eiriktsarpalis/httpstress-randomize-cance...
Eirik Tsarpalis [Tue, 16 Jul 2019 14:58:47 +0000 (15:58 +0100)]
Merge pull request dotnet/corefx#39485 from eiriktsarpalis/httpstress-randomize-cancellation

HttpStress: Randomize cancellation of requests

Commit migrated from https://github.com/dotnet/corefx/commit/e15d8dcb334ebd896cd2b23359d95c2ca679fdd9