Jaehyun Cho [Wed, 17 Apr 2019 01:41:43 +0000 (10:41 +0900)]
Revert "Revert "test/efl_ui_pager_scroll: fix demo""
This reverts commit
5742caa6016bf0ea852059546ded493c2d52b1a7.
To restore
30bd541bf264d369e2a96d27fa3ff5139c360e26 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:38 +0000 (10:41 +0900)]
Revert "Revert "efl_ui_pager: implement unpack_all/clear function""
This reverts commit
b28f1e034b7ecbe7966b0d2b9687d8e22245837c.
To restore
74c48f029632d2260816b4cb3de6dbb40a29f040 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:32 +0000 (10:41 +0900)]
Revert "Revert "efl_ui_pager: implement unpack_at function""
This reverts commit
a10e1bc597f00865514f30d84268963dcbf3f599.
To restore
913a5bff66dd7a58753ccae1474657ec33350e43 which implements
features during feature freeze period, the revert commit is reverted.
Hermet Park [Wed, 24 Apr 2019 05:01:06 +0000 (14:01 +0900)]
evas wbmp: fix wrong calc order.
Double check patch again, since my wrong logical thinking,
Every width must be considered to rounding up fiting 8 bits.
this new compuation must be correct.
Change-Id: I112b88560b97e7e413f24b6d17ecaff3588d280e
Hermet Park [Wed, 24 Apr 2019 04:19:12 +0000 (13:19 +0900)]
eolian: remove unreachable code.
Change-Id: I488e77800e2bc682a8b79268065f5f6500eefcb7
Hermet Park [Wed, 24 Apr 2019 01:18:57 +0000 (10:18 +0900)]
evas wbmp loader: coming previous patch with fixing wrong calc.
Those bits must be rounded if they are not fit to 8 bits.
Change-Id: I04fff0d46fb5228e2107ce0207cc8b1245ba678c
see:
68fe9ec6bf60b4730ad7fdbf2698dc7aa130b94d
Hermet Park [Tue, 23 Apr 2019 12:31:06 +0000 (21:31 +0900)]
evas wbmp: remove unnecessary size overflow.
since this patch
68fe9ec6bf60b4730ad7fdbf2698dc7aa130b94d
it checks size validation earlier,
this varification doesn't need anymore...
Change-Id: I395f664efebf6c0ccaaea1b5cd7882917ab276f5
Hermet Park [Tue, 23 Apr 2019 10:04:21 +0000 (19:04 +0900)]
evas image: check format more strong way for wbmp.
wbmp format doesn't have any tags for verifying file header,
It's easy to pass other format headers if they have the first 1 byte 0x0,
This ocassionally brings wrong result (= succeeed loading image),
if unknown file format is tried.
So, to make it sure, here verify the size of image additionally.
if the image size is not expected, It returns fail as the result.
This problem is actually happened in this scenario.
open any mpeg file with elm_image.
elm_image_file_set() will return true though it fails to read data.
since wbmp make it pass to succeed.
@fix
Change-Id: I56a117e1b161d1dd13c512cb9a48d92a7b6caf33
Jaehyun Cho [Fri, 19 Apr 2019 03:14:54 +0000 (12:14 +0900)]
efl_mono: install libeflcustomexportsmono.so to support EflSharp by meson
EflSharp application installed by dotnet requires
libeflcustomexportsmono.so files to be executed.
To support EflSharp application, libeflcustomexportsmono.so files are
installed without --enable-csharp-bindings option by meson build.
Change-Id: I00f6486e00f2dc6b4269c684df7c5ece462c8ff8
Shinwoo Kim [Mon, 22 Apr 2019 02:53:50 +0000 (11:53 +0900)]
Efl.Ui.Animation_View: remove double free
Following step makes SIGABORT by double free.
1. elm_animation_view_add
2. elm_animation_view_file_set
3. evas_object_del
The first free occurs in
(gdb) bt
#0 eina_stringshare_del
#1 _efl_ui_animation_view_efl_canvas_group_group_del
#2 efl_canvas_group_del
#3 evas_object_smart_del
#4 _efl_canvas_object_efl_object_invalidate
#5 efl_invalidate
#6 _efl_ui_widget_efl_object_invalidate
#7 efl_invalidate
#8 _efl_invalidate
#9 _efl_object_parent_set
#10 efl_parent_set
#11 efl_parent_set
#12 efl_del
#13 elm_main
#14 main
the second free occurs in
(gdb) bt
#0 eina_stringshare_del
#1 _efl_file_efl_object_destructor
#2 efl_destructor
#3 efl_destructor
#4 _efl_del_internal
#5 _efl_unref_internal
#6 efl_del
#7 evas_object_del
#8 _efl_ui_widget_efl_canvas_group_group_del
#9 efl_canvas_group_del
#10 efl_canvas_group_del
#11 evas_object_smart_del
#12 _efl_canvas_object_efl_object_invalidate
#13 efl_invalidate
#14 _efl_ui_widget_efl_object_invalidate
#15 efl_invalidate
#16 _efl_invalidate
#17 _efl_object_parent_set
#18 efl_parent_set
#19 efl_parent_set
#20 efl_del
#21 elm_main
#22 main
Change-Id: Iabedaacc6fc82f87e5d4d78bc4a20030419148aa
Woochanlee [Mon, 22 Apr 2019 09:48:26 +0000 (18:48 +0900)]
elm_genlist: Avoid edje recalc in no size, position changed case.
Change-Id: Id6019f34bcca5c4cdad3c9bef4a976c328517fef
Wonki Kim [Wed, 17 Apr 2019 10:27:30 +0000 (19:27 +0900)]
meson: modify meson definitions for gl_generic module
in tizen environment, gl_generic module can't be dynamically loadded,
because some symbols are not linked.
so this patch modify meson definitions to build gl_generic
as static linked library . it's workaround.
and also there are some sources that exist on tizen only. this patch appends them.
@tizen_only
Change-Id: I50a5ee74a684a93a102698cdb276e03e0b1d8134
Shinwoo Kim [Fri, 19 Apr 2019 08:18:26 +0000 (17:18 +0900)]
Revert "edje_calc: make INTP use TO_INT_ROUND"
Summary:
This reverts commit
be00af9bc3d534ede3965693618684fe38fd8786 which has
incorrect calculation. For more information please refer to:
https://phab.enlightenment.org/D8665
Reviewers: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8666
Change-Id: I878418da20ade0396ee218579452e7ded882ffa8
Taehyub Kim [Fri, 19 Apr 2019 07:17:03 +0000 (16:17 +0900)]
elc_popup: fix theme logic for the label in popup
Change-Id: Ibc3156f805532c36e2934cb78e962b9ae10ac6ff
Jaehyun Cho [Thu, 18 Apr 2019 07:35:23 +0000 (16:35 +0900)]
efl_mono: install libeflcustomexportsmono.so to support EflSharp
EflSharp application installed by dotnet requires
libeflcustomexportsmono.so files to be executed.
To support EflSharp application, libeflcustomexportsmono.so files are
installed without --enable-csharp-bindings option.
Change-Id: I3f4bcc95d86fb2366363b49db2c9b684a0dafac3
Shinwoo Kim [Thu, 18 Apr 2019 00:28:57 +0000 (09:28 +0900)]
doc: follow document policy for deprecated API
(1) The @deprecated should come first than other information.
(2) The @brief should follow just after @deprecated
(3) Use correct version information for ACR
Change-Id: Ia7bc8469bd89449fef80ca6ac284ec39bf0b589c
JunsuChoi [Thu, 18 Apr 2019 01:22:34 +0000 (10:22 +0900)]
vg_json: Set multiple mask from json
Summary:
This patch supports multiple masks for multiple attributes on a layer.
Make main_mask_layer and make each mask EFL_CANVAS_VG_CONTAINER_CLASS and connect them.
main_mask_layer is made for masks
The masks are composited into main_mask_layer in order.
main_mask_layer exists for the intersect option in last order
This can be optimized later, and is created and used temporarily in this patch.
Test Plan:
If there are three masks, they can be created as below.
mask_set(clayer, main_mask);
mask_set(main_mask, mask_1);
mask_set(mask_1, mask_2);
mask_set(mask_2, mask_3);
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, kimcinoo, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8507
Change-Id: I5a75640308a69e8e7e50800ff2444d6078c4fe4d
Taehyub Kim [Wed, 17 Apr 2019 07:52:13 +0000 (16:52 +0900)]
elm_notify: fix theme apply logic for new return value
Summary: fix theme apply logic for new return value
Test Plan: 1. run elementary_test for elm_notify and elm_popup
Reviewers: Jaehyun_Cho, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8628
Change-Id: I25deb0148fa7f49e597b016f00dc099480b0f430
Radoslaw Cybulski [Wed, 17 Apr 2019 12:20:14 +0000 (14:20 +0200)]
Remove warnings, when used legacy gesture enum
Change-Id: I22f4f3c48806473c1f7f4170d84bea805d82194d
Wonki Kim [Wed, 17 Apr 2019 07:35:11 +0000 (16:35 +0900)]
spec: remove a dependency on gnutls package.
efl doesn't use gnutls library for crypto lib.
so that this patch removes a dependency definition for it.
Change-Id: I08fcbe70f2acea613ca332f98425f27704d181f1
Shinwoo Kim [Wed, 17 Apr 2019 04:38:02 +0000 (13:38 +0900)]
Revert "Remove and update deprecated API"
This reverts commit
95be425c35e82b73058e7ec161cb7ce94fcea6ff.
The ACR-1373 is still ongoing.
Change-Id: I6decc97b7d5add811077fee0ef5f4af105505af2
Shinwoo Kim [Wed, 17 Apr 2019 03:47:20 +0000 (12:47 +0900)]
Migration: fix build errors
(1) Fix duplicate message definition error of po files
(2) Define EFL_BUILD to define EFL_PACK_LAYOUT_PROTECTED which makes lines
using efl_pack_layout_update do not have build error.
Change-Id: I0179d4c0f3b4133459359e2bc729efec0524b67b
Vincent Torri [Tue, 16 Apr 2019 16:59:10 +0000 (17:59 +0100)]
evil: remove tmp and home dir get
Summary: eina implement them for all OSes
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8621
Mike Blumenkrantz [Tue, 16 Apr 2019 12:55:11 +0000 (08:55 -0400)]
efl_ui_image: fix warning about calling smooth_scale_set on non-image
Summary: this is triggered during object construction when no image exists
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8617
Xavi Artigas [Tue, 16 Apr 2019 09:06:23 +0000 (11:06 +0200)]
docs: Typo
Lauro Moura [Mon, 15 Apr 2019 22:16:43 +0000 (19:16 -0300)]
cxx: Fix eldbus meta include name
Summary:
It should not conflict with Eldbus_Model header
Fixes T7805
Reviewers: vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7805
Differential Revision: https://phab.enlightenment.org/D8611
Lauro Moura [Mon, 15 Apr 2019 18:58:30 +0000 (15:58 -0300)]
csharp: Remove warning about clashing GetType() methods
Summary:
This changes the naming scheme to replace `GetType`/`SetType` methods
with `Get<CLASS>Type`/`Set<CLASS>Type`. Like `GetGestureType`.
Avoids cs compiler complaining of clashing with `System.Object.GetType`.
Fixes T7727
Reviewers: segfaultxavi, felipealmeida, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7727
Differential Revision: https://phab.enlightenment.org/D8609
Lauro Moura [Mon, 15 Apr 2019 18:45:40 +0000 (15:45 -0300)]
csharp: Remove unused variable `methods` warning.
Summary: Only generate it if there was at least one method registered.
Reviewers: vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8608
Lauro Moura [Mon, 15 Apr 2019 18:29:08 +0000 (15:29 -0300)]
csharp: Rename MarshalTest to MarshalEo
Summary: To better reflect its intent
Reviewers: segfaultxavi, vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8607
Lauro Moura [Mon, 15 Apr 2019 17:09:49 +0000 (14:09 -0300)]
csharp: Fix free_cb calling under dotnet.
Summary:
dotnet's GC seems to be more agressive, showing some issues that usually
do not appear when running under Mono's.
This commit uses for free_cb's the same scheme we already use for
regular Eo refs, using a GC handle to keep the cleaning callback alive.
Reviewers: vitor.sousa, felipealmeida, woohyun
Reviewed By: vitor.sousa
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8593
Xavi Artigas [Mon, 15 Apr 2019 12:58:23 +0000 (14:58 +0200)]
mono-docs: No need no blacklist *Concrete classes anymore
Lauro Moura [Mon, 15 Apr 2019 12:28:25 +0000 (14:28 +0200)]
csharp: Make concrete classes internal.
Summary:
They don't need to be public anymore. After merging other changes we can
try to actually remove them.
Fixes T7801
Reviewers: segfaultxavi, vitor.sousa, felipealmeida
Reviewed By: segfaultxavi, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7801
Differential Revision: https://phab.enlightenment.org/D8601
Carsten Haitzler (Rasterman) [Mon, 15 Apr 2019 12:33:46 +0000 (13:33 +0100)]
update po...
Vincent Torri [Mon, 15 Apr 2019 10:53:42 +0000 (11:53 +0100)]
Windows : fix the definition of EAPI
Summary:
with autotools, EFL_BUILD was passed to the preprocessor for libraries and binaries, which was wrong. Only libraries must have EFL_BUILD defined. See T7797 for an explanation
This also fix EAPI in Ecore_Getopt.g and Efl_UI.h
Also note that all the wayland and drm Makefile's have not been touched
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8602
Carsten Haitzler (Rasterman) [Fri, 12 Apr 2019 12:40:04 +0000 (13:40 +0100)]
elm test - add tests ofr other styles for panes provided by default
abdulleh Ghujeh [Mon, 15 Apr 2019 11:48:24 +0000 (13:48 +0200)]
Unreachable code
Summary: Removed condition that will never be fulfilled
Reviewers: ali.alzyod, bowonryu, woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8606
Yeongjong Lee [Mon, 15 Apr 2019 11:07:54 +0000 (13:07 +0200)]
gitignore: add elm_default_config.x
Summary: elm_default_config.x is created by build script.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8605
Xavi Artigas [Thu, 11 Apr 2019 10:40:21 +0000 (12:40 +0200)]
mono-docs: Allow derived classes to have external examples
Summary:
You can now have external example files for derived classes (Efl.Ui.Button.SetText)
as well as for base classes (Efl.IText.SetText).
If both files are present, both examples are embedded in the docs. The more
examples the better!
Examples for classes in-between the hierarchy (Efl.Ui.Widget.SetText) are not
picked up. Might be worth examining in the future.
Test Plan:
Create example files for both `Efl.Ui.Button.AutorepeatEnabled.cs` and `Efl.Ui.IAutorepeat.AutorepeatEnabled.cs`.
You should see both examples appearing in the docs.
Reviewers: lauromoura, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8597
Daniel Kolesa [Fri, 12 Apr 2019 13:48:36 +0000 (15:48 +0200)]
elua: add all missing eolian api bindings
Carsten Haitzler (Rasterman) [Fri, 12 Apr 2019 11:56:40 +0000 (12:56 +0100)]
evas - fix crash/junk pixel content but with tiled rotate at 270 + neon
@fix
Carsten Haitzler (Rasterman) [Fri, 12 Apr 2019 10:23:57 +0000 (11:23 +0100)]
evas common - tiled rotate - fix signedness of neon intrinsics - warning
Carsten Haitzler (Rasterman) [Fri, 12 Apr 2019 10:18:38 +0000 (11:18 +0100)]
evas common - convert - rotate tiled - fix const ptr warnings
Carsten Haitzler (Rasterman) [Fri, 12 Apr 2019 09:29:42 +0000 (10:29 +0100)]
evas map - mark npoints param as unused because it is remove warning
Yeongjong Lee [Fri, 12 Apr 2019 07:12:51 +0000 (09:12 +0200)]
efl_ui_widget: avoid calling null parent
Summary:
This will fix unnecessary warnings on P280.
Thanks to segfaultxavi for reporting.
ref T7796
Reviewers: zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7796
Differential Revision: https://phab.enlightenment.org/D8599
Vincent Torri [Thu, 11 Apr 2019 16:51:13 +0000 (17:51 +0100)]
elementary: rename ELEMENTARY_BUILD to EFL_BUILD like all other libs
Test Plan: compilation
Reviewers: cedric, raster, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8598
Jaehyun Cho [Thu, 11 Apr 2019 11:14:43 +0000 (20:14 +0900)]
efl_ui_list: fix to delete sub objects in efl_object_invalidate
widget's sub objects and callbacks should be deleted in
efl_object_invalidate instead of efl_object_destructor.
@fix
Xavi Artigas [Thu, 11 Apr 2019 11:18:33 +0000 (13:18 +0200)]
mono-docs: Properly indent code examples
First code line was indented differently by DocFX because of tabs,
whitespace or who knows what. This adds a newline after the <code>
tag so all code lines have the same indentation.
JunsuChoi [Thu, 11 Apr 2019 10:20:03 +0000 (19:20 +0900)]
efl_canvas_vg_container : Support mask tree for multiple mask.
Summary:
If another mask is set in the mask source, the rendering of the mask is performed in order.
The mask will render one buffer in order.
And depending on some types, the initial values of the buffers may be different. (alpha zero or 255).
If the implementation for masking is
efl_canvas_vg_node_mask_set(layer, mask1, MASKADD);
efl_canvas_vg_node_mask_set(mask1, mask2, MASKSUBSTRACT);
efl_canvas_vg_node_mask_set(mask3, mask4, MASKINTERSECT);
Supports rendering for consecutive masks.
Reviewers: Hermet, cedric
Reviewed By: Hermet
Subscribers: #reviewers, #committers, smohanty, kimcinoo
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8517
JunsuChoi [Thu, 11 Apr 2019 10:12:40 +0000 (19:12 +0900)]
ector_software_rasterizer: Implement mask blending function.
Summary:
Add Mask blend function(Add, Substract, Intersect, Difference)
this blending function only use mask blending case.
Test Plan: N/A
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, kimcinoo, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8509
Xavi Artigas [Thu, 11 Apr 2019 08:38:40 +0000 (10:38 +0200)]
mono-docs: Allow embedding external examples
Summary:
New option added to eolian_gen: -e <dir>
This specifies a directory to search for examples. If a file is found with the
same name as an EFL C# class (e.g. Efl.Ui.Button.cs) or as an EFL C# method or
property (e.g. Efl.IText.Text.cs, Efl.IText.SetText.cs) its full
contents will be embedded in the documentation for that class or method within
<example> and <code> tags. This is, in turn, is parsed by DocFX and shown
in Example boxes in the generated pages.
If an example file is not found, no examples are embedded for that object.
If -e is not used, no examples are embedded for any object.
New option added to meson: mono-examples-dir to point to the examples directory.
This directory is then passed to eolian_mono through -e.
Do not use it (or define it to nothing) to disable example embedding.
No performance drop has been observed because of these extra tests.
Right now examples can only be given for base classes, not for derived ones
(i.e. Efl.IText.Text but not Efl.Ui.Button.Text). This will be addressed in a
later commit.
Feature
Depends on D8587
Test Plan:
Create an examples folder and put some files in it:
```
mkdir /tmp/examples
echo 'var button = new Efl.Ui.Button();' > /tmp/examples/Efl.Ui.Button.cs
echo 'button.AutoRepeatEnabled = true;' > /tmp/examples/Efl.Ui.IAutorepeat.AutorepeatEnabled.cs
echo 'button.SetAutoRepeatEnabled(true);' > /tmp/examples/Efl.Ui.IAutorepeat.SetAutorepeatEnabled.cs
```
Configure meson to embed examples and build:
```
meson configure -Dmono-examples-dir=/tmp/examples
ninja
```
Examine the generated efl_ui_button.eo.cs file to see embedded <example> tags,
or run DocFX and bask in the glory of documentation pages with examples:
```
cd doc/docfx
./gendoc.sh
```
Reviewers: lauromoura, felipealmeida, vitor.sousa, zmike, bu5hm4n
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8592
Xavi Artigas [Thu, 11 Apr 2019 08:37:33 +0000 (10:37 +0200)]
efl-mono: Allow doc XML tags to be nested
Summary:
This allows inserting nested tags like:
<example><code>bla bla bla</code></example>
The generate_tag_example() is currently unused but serves as an example.
Depends on D8585
Test Plan:
Not much, unless you want to manually call generate_tag_example()
(Which I have done, and it works, I promise).
Reviewers: lauromoura, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: vitor.sousa, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8587
Xavi Artigas [Thu, 11 Apr 2019 08:36:53 +0000 (10:36 +0200)]
efl-mono: Allow generating doc refs for methods without class
Summary:
Methods without a class (global) make the previous code crash because
func.klass contains something (it cannot be NULL because it is a reference)
but you cannot make much calls on this something.
Test Plan: Currently there are no such references, but I need this working for upcoming patches.
Reviewers: lauromoura, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: vitor.sousa, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8585
JunsuChoi [Thu, 11 Apr 2019 08:18:10 +0000 (17:18 +0900)]
svg_parse: Support gradient when <defs/> is not declared.
Summary:
Even if linear or radius gradient is declared,
it will not be output if there is no <defs/>
It can be supported because it stores the declared gradient in loader.gradient.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8591
JunsuChoi [Thu, 11 Apr 2019 05:48:05 +0000 (14:48 +0900)]
vg_common_svg : Add missing eet data descriptor
Summary:
Add descriptor to get the value of user_space,
which is a member of Svg_Style_Gradient.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8594
Boris Faure [Wed, 10 Apr 2019 20:45:52 +0000 (22:45 +0200)]
ecore_imf: do not loop forever on shutdown when there is no more a display
@fix
Boris Faure [Wed, 10 Apr 2019 20:44:59 +0000 (22:44 +0200)]
meson: set ENABLE_XIM if the xim module is compiled
Boris Faure [Wed, 10 Apr 2019 20:44:14 +0000 (22:44 +0200)]
ecore_imf: better to check whether the module is compiled
Boris Faure [Wed, 10 Apr 2019 20:40:55 +0000 (22:40 +0200)]
meson: skip trailing dot if any + more posix compliant
Lauro Moura [Wed, 10 Apr 2019 18:04:22 +0000 (15:04 -0300)]
csharp: Fix GetUserMethods and NativeClass
Summary:
- Should only search for methods locally.
- dotnet requires passing false to GetAttributes
- Also added a check when the class overrides no Eo ops.
Reviewers: felipealmeida, vitor.sousa, woohyun
Reviewed By: felipealmeida, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8588
Carsten Haitzler (Rasterman) [Wed, 10 Apr 2019 15:09:04 +0000 (16:09 +0100)]
ecore drm2 - handle possible NULL fb when doing a flip
Xavi Artigas [Wed, 10 Apr 2019 14:23:38 +0000 (16:23 +0200)]
efl-mono: Fix eolian_mono help
It was a blatant copy&paste of eolian_cxx :D
Xavi Artigas [Wed, 10 Apr 2019 14:09:15 +0000 (16:09 +0200)]
docs: Remove silly [[[ typos
Carsten Haitzler (Rasterman) [Wed, 10 Apr 2019 14:03:21 +0000 (15:03 +0100)]
meson - oops - used sh not dash
Carsten Haitzler (Rasterman) [Wed, 10 Apr 2019 14:02:47 +0000 (15:02 +0100)]
meson - evas loader confg install script - make it /bin/sh compliant
Carsten Haitzler (Rasterman) [Wed, 10 Apr 2019 10:16:05 +0000 (11:16 +0100)]
edje example edc - remove misleading signals that aren't used
JunsuChoi [Wed, 10 Apr 2019 09:03:05 +0000 (18:03 +0900)]
svg_parse: Change initial value of gradientUnits of linearGradient
Summary:
The initial value of gradientUnits is objectBoundingBox.
If userSpaceOnUse is declared, change user_space to true.
We do not have to recalculate each value by this change.
The default unit for linear x1, y1, x2, y2 is percentages.
This can be a value from 0 to 1. If svg want to use a value between 0 and 100, it must have a '%' symbol
That is accroding to gradientUnits in here
https://www.w3.org/TR/2015/WD-SVG2-
20150915/pservers.html#LinearGradientElementGradientUnitsAttribute
Test Plan:
cd ./src/examples/edje
edje_cc -beta svg.edc && gcc -o svg-test svg-test.c `pkg-config --libs --cflags evas ecore ecore-evas edje`
Reviewers: Hermet, smohanty
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8589
JunsuChoi [Wed, 10 Apr 2019 08:39:36 +0000 (17:39 +0900)]
svg_parse: The percentage gradient value divide by view's size
Summary:
The default unit of gradient value is percentage.
This can be a value from 0 to 1.
If svg use the '%' symbol, we must divide by 100.
And it must be calculated the same as any other case.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8590
Felipe Magno de Almeida [Tue, 9 Apr 2019 21:37:01 +0000 (18:37 -0300)]
efl-mono: Add test and fix problem with private dynamic types passed as parameters
Summary:
The code that searches the type dynamically fails instead of falling
back to Efl.Object. Now it fallbacks to Efl.Object.
Fixes T7783
Reviewers: bu5hm4n, vitor.sousa, segfaultxavi, woohyun, Jaehyun_Cho, YOhoho, lauromoura
Reviewed By: vitor.sousa, lauromoura
Subscribers: lauromoura, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7783
Differential Revision: https://phab.enlightenment.org/D8574
Lauro Moura [Tue, 9 Apr 2019 19:23:03 +0000 (16:23 -0300)]
csharp: Add some null checks.
Summary:
- Check for nullness when getting stuff from C# to C
- We should return null when wrapping a NULL pointer instead of throwing
an exception
Reviewers: felipealmeida, vitor.sousa, woohyun
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8580
Felipe Magno de Almeida [Tue, 9 Apr 2019 14:16:17 +0000 (11:16 -0300)]
efl-mono: Make override of methods only for methods that are defined by the user
Summary:
Instead of overriding every method and making the callback to C, we
just override the methods that are found by reflection on the type.
Reviewers: bu5hm4n, vitor.sousa, segfaultxavi, woohyun, Jaehyun_Cho, YOhoho, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8579
Felipe Magno de Almeida [Tue, 9 Apr 2019 14:07:50 +0000 (11:07 -0300)]
efl-mono: Fix --enable-mono-beta for tests
Reviewers: bu5hm4n, vitor.sousa, segfaultxavi, woohyun, Jaehyun_Cho, YOhoho, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8573
Vincent Torri [Tue, 9 Apr 2019 14:05:18 +0000 (10:05 -0400)]
unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation
Summary:
* some variables were defined, only when fork() was available
* since Eina.h is included unconditionally, add Eina path in Makefile_Evil.am
Test Plan: compilation
Reviewers: zmike, cedric, raster, devilhorns
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8586
Vincent Torri [Tue, 9 Apr 2019 11:34:19 +0000 (12:34 +0100)]
eldbus unit test: fix warnings
Summary: include libgen.h so that basename() is declared
Test Plan: compilation
Reviewers: cedric, raster, zmike, devilhorns
Subscribers: #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8583
Jaehyun Cho [Mon, 8 Apr 2019 14:28:18 +0000 (16:28 +0200)]
configure: fix build error of efl_custom_exports_mono.c
Reviewers: woohyun, lauromoura, akanad
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8577
Jaeun Choi [Mon, 8 Apr 2019 09:35:57 +0000 (18:35 +0900)]
elm_panel/efl_ui_panel: disable scrolling when obj is disabled
panels were still scrollable while disabled.
this patch fixes it.
Hermet Park [Mon, 8 Apr 2019 06:02:47 +0000 (15:02 +0900)]
evas map: disable anti_aliasing.
We need a proper interface to toggle high-quality mapping,
until that, we disable the anti_aliasing feature.
Since adjecent polygons(such as textpath) shouldn't get this aa feature.
Hermet Park [Mon, 8 Apr 2019 05:53:47 +0000 (14:53 +0900)]
evas map: remove redundant code.
Remove old anti-alias code since high quality map is replaced with new one.
New anti-aliasing is logically same but having a regression bug,
it should be stablized.
Hermet Park [Mon, 8 Apr 2019 04:21:07 +0000 (13:21 +0900)]
canvas map: introduce a new texture mapping for better quality.
Summary:
This new implementation of evas map texture mapping
is designed for high quality rendering same level to GL.
If you use a high-end device, performance is not too bad, you can turn this on.
You might have practical image quality even in software rendering.
Since this implementation still have a few optimization points (+simd)
and stablizings, it may be useful in somewhat limited envrionments right now.
However the functionality definitely works fine, so please turn this on by
demand (anti_alias + smooth) for a while.
{
F3667773} {
F3667776} {
F3667778}
Reviewers: #committers, devilhorns, raster
Reviewed By: #committers, raster
Subscribers: raster, devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8106
Mike Blumenkrantz [Mon, 8 Apr 2019 04:19:56 +0000 (13:19 +0900)]
tests: add evas render test for callbacks
Summary:
verify that all callbacks can be incrementally added and triggered during a
sync render (which is the rendering used in unit testing)
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D8505
Hermet Park [Mon, 8 Apr 2019 04:15:45 +0000 (13:15 +0900)]
canvas vg: code refactoring.
Summary: Remove unnecessary argument of an internal function.
Reviewers: #committers, jsuya, cedric
Reviewed By: #committers, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8530
Wonki Kim [Mon, 15 Apr 2019 07:10:33 +0000 (16:10 +0900)]
scroll_mgr: fix a type for some vars to be portable
Summary:
char type can be singed or unsinged according to the standard.
variables for keeping sign value should be sign, and that is the reason
why this patch modify a type for some variables explictly.
Reviewers: eagleeye
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8604
Change-Id: I26054743fe8c184cc02b49bebe0301214c162e94
Hosang Kim [Fri, 12 Apr 2019 11:04:29 +0000 (20:04 +0900)]
efl_ui_widget: _on_sub_obj_hide callback should be called when object is
hidden.
Change-Id: I2802dba654060e3a228e4a0baa6b73f30adfb887
Woochanlee [Fri, 12 Apr 2019 05:56:03 +0000 (14:56 +0900)]
efl_ui_widget: Fix disabled set calling without meaning.
The efl_ui_widget_disabled_set calling even the state is not change when widget create and destroy.
It broken backward compatibility.
T7799
@fix
https://phab.enlightenment.org/D8600
Change-Id: Ib3be163cebf77e86f1aaa510e75454611d6911ce
Myoungwoon Roy, Kim [Fri, 12 Apr 2019 04:58:37 +0000 (13:58 +0900)]
efl: Fix dereference null return value
Change-Id: I7f22cb7dbcd70f0124d2f95b381075cb07f6acad
Inhong Han [Tue, 9 Apr 2019 10:42:00 +0000 (19:42 +0900)]
ecore_imf: change the description of preedit_type
Change-Id: I54f4efb4afaece4ed3ffbff9d841d237e587de30
Shinwoo Kim [Tue, 12 Mar 2019 06:34:59 +0000 (15:34 +0900)]
Remove and update deprecated API
[Remove]
ecore_input_joystick_init
ecore_input_joystick_shutdown
elm_ctxpopup_direction_available_get
elm_win_profiles_set
[Update]
evas_out_add
evas_output_del
evas_output_view_set
evas_output_view_get
Change-Id: I6a9c49801fc395526bf375922625f50a13e38dd9
Jaehyun Cho [Fri, 5 Apr 2019 02:30:05 +0000 (11:30 +0900)]
elementary: fix not to call duplicate theme set
Summary:
Theme is set during finalize in Efl.Ui.Layout_Base.
Therefore, it is not necessary to call theme set function if the widget
inherits Efl.Ui.Layout_Base and its klass is properly set.
Reviewers: zmike, bu5hm4n, eagleeye, akanad, SanghyeonLee, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8559
Change-Id: I5401c827bb9c7b46e675e01c57e9ca8508580b89
Hermet Park [Mon, 8 Apr 2019 06:02:47 +0000 (15:02 +0900)]
evas map: disable anti_aliasing.
We need a proper interface to toggle high-quality mapping,
until that, we disable the anti_aliasing feature.
Since adjecent polygons(such as textpath) shouldn't get this aa feature.
Change-Id: I8667d728f07a41539ae9c312eee763204e79c16e
Hermet Park [Mon, 8 Apr 2019 05:53:47 +0000 (14:53 +0900)]
evas map: remove redundant code.
Remove old anti-alias code since high quality map is replaced with new one.
New anti-aliasing is logically same but having a regression bug,
it should be stablized.
Change-Id: Idd654768d24b15c15ce035e958fceece15ae4ece
Hermet Park [Mon, 8 Apr 2019 04:16:24 +0000 (13:16 +0900)]
efl_ui_textpath : enable anti-alising for better quality.
Summary:
Current textpath on sw rendering is too jiggled,
quaility is very poor to use.
This option uses better quality texture mapping logic
in order to improve the image quality.
Depends on D8106
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8465
Change-Id: I572c3fc6c65880807e91fbfb0abd70d7cabfcb8b
Hermet Park [Mon, 8 Apr 2019 04:21:07 +0000 (13:21 +0900)]
canvas map: introduce a new texture mapping for better quality.
Summary:
This new implementation of evas map texture mapping
is designed for high quality rendering same level to GL.
If you use a high-end device, performance is not too bad, you can turn this on.
You might have practical image quality even in software rendering.
Since this implementation still have a few optimization points (+simd)
and stablizings, it may be useful in somewhat limited envrionments right now.
However the functionality definitely works fine, so please turn this on by
demand (anti_alias + smooth) for a while.
{
F3667773} {
F3667776} {
F3667778}
Reviewers: #committers, devilhorns, raster
Reviewed By: #committers, raster
Subscribers: raster, devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8106
Change-Id: I52a50097afb3fd3c427d9026387452383971b5c6
Wonki Kim [Mon, 8 Apr 2019 03:58:18 +0000 (12:58 +0900)]
spec: modify hard-coded version name according to changes on upstream
there is a hard-coded filename for specify a file to archieve as rpm package.
this patch modify it according to changes version name on upstream.
Change-Id: I6f1323ef9543bdd70e4896c541f4f439837bd162
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 13:47:35 +0000 (14:47 +0100)]
tests - remove one of the eina strtod tests as libc is failing
see the comments above the test explaining why it's removed (libc
fails, not eina and having our tests fail because eina is a bit more
robust than libc is not a sane thing to have). but here is the comment
for git history spelunking:
this test isn't viable because libc actually fails the conversion (testing
glibc 2.28 on arch linux). either libc doesn't like the space at the start
thus doesn't skip it but assumes END of numbver string thus not converting
and returning NULL, or it doesn't like InFiNiTyfoo in some way, but either
way this test shows eina to be more robust and do some kind of conversion
and libc to fail and return NULL from strtod into the string pointer. it
also doesnt return an infinite fp thus hitting the default: case and thus
failing etc. ... so all in all remove the test as all it does it cause
failures and if anything shows libc to be failing more than eina.
@fix
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 13:14:55 +0000 (14:14 +0100)]
tests - fix check header to always include eina due to windows
windows means HAVE_FORK is false... thus missing eina.h and now we
have macros that use eina calls always... so this fixes nbuild of
tests on windows
@fix
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 12:08:40 +0000 (13:08 +0100)]
remove vpath test for user dir the test was broken and fixing is insane
so this test fails on windows as getuid isn't there... so this fixes
the windows bild: fix T7728 ... but it also would have failed if $HOME
didn't match what was in the passwd file, and other fallback cases if
they were triggered.
but ... to make this test stay it would have to also change the logic
- check $HOME env first, then pwent entry, if that fails /tmp/UID and
if that fails use /tmp ... the test would effectively be a copy &
paste of the vpath code at which point this is really pointless where
testing is copying the exact (or almost exat) same code into the test.
this is ignoring the #ifdef fun of martching ifdefs that vary on
windows.
the problem is this kind of api is defined very much by the system it
runs on and the environment and situation, so the test has to be as
complex. realistically, instead of copying & pasting the code across
and now having 2 bits of code to possibly mantain (change the lib src
then the test needs changes too as it's a copy & paste), it's just
saner not to have a test for this kind of siutation and accept the
reality of the situation.
@fix
Cedric BAIL [Tue, 2 Apr 2019 22:24:03 +0000 (15:24 -0700)]
eio: do not fail in case of early ECANCEL.
Actually with directory that contain a lot of file and the right order for them,
you would end up getting what you are looking for before you have triggered all
the future callback. In that case, all the future callback are cancelled and
we will get that notification. The test is not failing in this case as we already
got what we wanted.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8541
Cedric BAIL [Thu, 28 Mar 2019 21:09:54 +0000 (14:09 -0700)]
elementary: fix error path during shutdown of fileselector.
During shutdown, sometimes, we can have an error generated on the object
while it is invalidating, but before it is invalidated. This lead to
properties on the object to change to an error state and trigger the
properties changed logic. At this point, the parent has already been
destroyed and we don't really have anything more to do. So let's not
do anything.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8502
Cedric BAIL [Thu, 28 Mar 2019 19:44:31 +0000 (12:44 -0700)]
elementary: it seems I forgot to initialize some meaningful boolean.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8501
Jaehyun Cho [Fri, 5 Apr 2019 04:05:37 +0000 (04:05 +0000)]
elementary: fix not to call duplicate theme set
Theme is set during finalize in Efl.Ui.Layout_Base.
Therefore, it is not necessary to call theme set function if the widget
inherits Efl.Ui.Layout_Base and its klass is properly set.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8559
Mike Blumenkrantz [Sat, 6 Apr 2019 00:17:27 +0000 (20:17 -0400)]
add EFL_VERSION_1_23 define