Andy Ayers [Fri, 20 May 2016 00:33:10 +0000 (17:33 -0700)]
Merge pull request dotnet/coreclr#5067 from AndyAyersMS/CalleeHashInXml
Inliner: small changes to inline xml
Commit migrated from https://github.com/dotnet/coreclr/commit/
174d6355db5ab8405097793f5600bbc336e0c562
Jiyoung Giuliana Yun [Fri, 20 May 2016 00:01:53 +0000 (09:01 +0900)]
Fix case-sensitive issue on Linux (dotnet/coreclr#5086)
Fix dotnet/coreclr#5035
The file paths should be case-sensitive on Linux.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
ec5f215aff689ff4db698cfc11d9e48691398f67
Sejong Oh [Thu, 19 May 2016 23:21:42 +0000 (16:21 -0700)]
Merge pull request dotnet/coreclr#4963 from sejongoh/vector3_clear_upperbits
Vector3 clear upperbits
Commit migrated from https://github.com/dotnet/coreclr/commit/
9d7254efd6d1ef5d7c9aa8583eb1f6cccff6dfbc
Tarek Mahmoud Sayed [Thu, 19 May 2016 23:09:03 +0000 (16:09 -0700)]
Remove the wrong optimization from the string initialization (dotnet/coreclr#5107)
The string initilaization misteknly setting some flag for characters under 0x80
the fix here is just remove this part (per Jan Kotas recommendation)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e00c86e744d1db8737b5e52ac7111b1aab82e8c
Jan Kotas [Thu, 19 May 2016 23:08:39 +0000 (16:08 -0700)]
Merge pull request dotnet/coreclr#5106 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
1205aa01a485a49c4856e1637b1f7e87d12cd30a
Joel Hendrix [Thu, 19 May 2016 22:18:56 +0000 (15:18 -0700)]
Merge pull request dotnet/coreclr#5074 from jhendrixMSFT/master
Add sign.builds projects to facilitate real signing in official builds.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fffe097e4a0b21b618543078a8fa19aec3d55856
Kyungwoo Lee [Thu, 19 May 2016 21:48:42 +0000 (14:48 -0700)]
Merge pull request dotnet/coreclr#5099 from kyulee1/fixr2r
ARM64: Fix R2R EntryPoint for Intrinsic
Commit migrated from https://github.com/dotnet/coreclr/commit/
00d3f3e45ee5648d8315c817b2e4bc0a76e4af4c
Russ Keldorph [Thu, 19 May 2016 21:39:49 +0000 (14:39 -0700)]
Merge pull request dotnet/coreclr#5098 from RussKeldorph/objects
Mark doublealign test as incompatible with GCStress
Commit migrated from https://github.com/dotnet/coreclr/commit/
257d8e5a26d597ca920250c80527f1f08270dc22
Russ Keldorph [Thu, 19 May 2016 21:39:09 +0000 (14:39 -0700)]
Merge pull request dotnet/coreclr#5100 from RussKeldorph/gcstress
Fix GCStress=0xC when build(tests).cmd called from outside root
Commit migrated from https://github.com/dotnet/coreclr/commit/
c48ac3e5cc8b100e808bc186aa98838bf7f49f61
Gaurav Khanna [Thu, 19 May 2016 19:54:30 +0000 (12:54 -0700)]
Merge pull request dotnet/coreclr#5091 from gkhanna79/Fix4531
Make Microsoft.NetCore.JIT package dependency of CoreCLR package
Commit migrated from https://github.com/dotnet/coreclr/commit/
c446e514885e91171cd77dc6d8a9b2cf9d6ca93b
Sejong OH [Fri, 13 May 2016 00:06:45 +0000 (17:06 -0700)]
Initialize unused upper bits of Vector3 arguments and return registers for
Linux
JIT requires the unused upper bits to be cleared but native compiler
doesn't clear the upper bits. This changes clear those bits for Reverse
PInvoke arguments and PInvoke return.
Commit migrated from https://github.com/dotnet/coreclr/commit/
eb4c7a280a00b344a9bb4d35172d0a0936ec5bdd
Alex Ghiondea [Thu, 19 May 2016 19:17:41 +0000 (12:17 -0700)]
Checking in on behalf of JKuhne
Fixing build break in K caused by the long file path work.
[tfs-changeset: 1606374]
Commit migrated from https://github.com/dotnet/coreclr/commit/
9acb5d6f68f7e0590e8be2542efdc8cc241dcec0
Joel Hendrix [Thu, 19 May 2016 18:33:21 +0000 (11:33 -0700)]
Add sign.builds projects to facilitate real signing in official builds.
New build project, sign.builds, is to be built post building of binaries
so that they can be real-signed in the official build.
Updated some project files with the correct strong name certificate.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b784c2a3b1de97a8ee164d70207a9ba172d1f41
Russ Keldorph [Thu, 19 May 2016 17:44:38 +0000 (10:44 -0700)]
Fix GCStress=0xC when build(tests).cmd called from outside root
Use absolute path intead of relative path when invoking
setup-runtime-dependencies.cmd, which is required for GCStress=0xC to
work.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e688eb0d58b2fd32a0247a87d8d92abf09e7d04
Sean Gillespie [Thu, 19 May 2016 17:17:17 +0000 (10:17 -0700)]
Merge pull request dotnet/coreclr#4991 from swgillespie/gcsimulator-buildandrun
Switch GCSimulator to BuildAndRun so that a shell wrapper gets generated
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f456bb8ddcb0310a2499bf8d04391e632177481
Mike McLaughlin [Thu, 19 May 2016 17:14:56 +0000 (10:14 -0700)]
Implement source/line number support for Exception.StackTrace. (dotnet/coreclr#5078)
* Implement source/line number support for Exception.StackTrace.
Uses a new helper class (StackTraceSymbols) in System.Diagnostics.StackTrace assembly
to get source/line info for portable PDBs. On Windows both types of pdbs are support;
on xplat only portable PDBs.
The first part of the work is in the GetStackFramesInternal pinvoke to return the neccessary
info needed by the portable pdb reader: MethodToken, assembly path, loaded PE image address
and if in-memory symbol file, the address.
The second part is in the StackFrameHelper in mscorlib. It attempts to load the System.Diagnostics.StackTrace,
gets the new type and creates a delegate to the helper function which is called for each stack
frame.
* Code review feedback.
Commit migrated from https://github.com/dotnet/coreclr/commit/
76837be7f1216bc0a970b20c30db006c9e6dacbe
William Godbe [Thu, 19 May 2016 17:13:10 +0000 (10:13 -0700)]
Merge pull request dotnet/coreclr#5031 from wtgodbe/pipelineFix
Update build scripts to fix small errors
Commit migrated from https://github.com/dotnet/coreclr/commit/
8efc544d19b2cf893c7a8972d8d5cba234430074
Kyungwoo Lee [Thu, 19 May 2016 16:51:56 +0000 (09:51 -0700)]
ARM64: Fix R2R EntryPoint for Intrinsic
This is fix for missing case that we should handle call that needs to pass
indirect cell address. The call appears in rationalizer, which is
originally an intrinsic when we import it.
I also refactor the code so that when we set entryPoint we ensure
tagging such information on the tree.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b71ba43f66481c00a229f81149c6a95f17cb47c0
Russ Keldorph [Thu, 19 May 2016 17:09:22 +0000 (10:09 -0700)]
Mark doublealign test as incompatible with GCStress
The test makes assumptions about allocation alignment that cannot be
expected to hold under GCStress, particularly on 32-bit platforms.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe2ec86eda24faef8fb5ec499b851b9a2a7c0a48
SaeHie Park [Thu, 19 May 2016 16:25:00 +0000 (01:25 +0900)]
ARM, SOS: correct IP and SP value in ClrStack command (dotnet/coreclr#5077)
This fixes casting 64bit pointer value in 32bit machines
that show wrong IP and SP values in ClrStack command.
Related Issue: dotnet/coreclr#5037
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6aa7748182c468dc4e78b29382617befaea6a6a
Russ Keldorph [Thu, 19 May 2016 14:55:38 +0000 (07:55 -0700)]
Merge pull request dotnet/coreclr#5057 from RussKeldorph/smallframe
Exclude smallFrame for JIT32
Commit migrated from https://github.com/dotnet/coreclr/commit/
819eadd96c7cc3f2bbfe4115c056b6cef7f34495
Senthil [Thu, 19 May 2016 06:48:34 +0000 (23:48 -0700)]
Merge pull request dotnet/coreclr#5001 from AlexGhiondea/ReadAppContextOverrides
Introduce a way to override AppContext switches from the project.json
Commit migrated from https://github.com/dotnet/coreclr/commit/
456e30ed5c734f7cc803105f1fdbdfa9fac10c89
Jan Kotas [Thu, 19 May 2016 04:47:22 +0000 (21:47 -0700)]
Merge pull request dotnet/coreclr#5076 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
a4e871e26d7978c3024442e2c96f43083ce83057
mkborg [Thu, 19 May 2016 04:44:54 +0000 (08:44 +0400)]
Skip configuration with skipnative option. (dotnet/coreclr#5059)
Fixes dotnet/coreclr#4022.
Commit migrated from https://github.com/dotnet/coreclr/commit/
eafbe6ef0952db40e71fbfddba2397c185ef8064
Gaurav Khanna [Thu, 19 May 2016 04:38:48 +0000 (21:38 -0700)]
Make Microsoft.NetCore.JIT package dependency of CoreCLR package
Commit migrated from https://github.com/dotnet/coreclr/commit/
c773914a8cde128510e1750e2aa206807522838c
Kyungwoo Lee [Thu, 19 May 2016 03:36:50 +0000 (20:36 -0700)]
Merge pull request dotnet/coreclr#5073 from kyulee1/newtest
ARM64: New Test Binary Update
Commit migrated from https://github.com/dotnet/coreclr/commit/
cf5bc14d24a48bbb1a4b302aa1ef2217f447dccb
Kyungwoo Lee [Thu, 19 May 2016 01:30:55 +0000 (18:30 -0700)]
Merge pull request dotnet/coreclr#5020 from kyulee1/imp
ARM64: Enable End-To-End ReadyToRun (R2R) Crossgen
Commit migrated from https://github.com/dotnet/coreclr/commit/
6f69c6da157622b08ec48b23da48d75afbf55426
Kyungwoo Lee [Wed, 18 May 2016 21:10:57 +0000 (14:10 -0700)]
ARM64: New Test Binary Update
Currently 135 of 9661 are failing.
Those are marked as EXPECTED_FAIL.
~55: mcc failed due to differnet struct calling convetion
~13: regression from the prior tests: marked as EXPECTED_FAIL;REGRESS
~22: failures from new tests: marked as NEW;EXPECTED_FAIL
~45: HFA
Tests.lst head now contains git hash number which tells us what version
we use to build such binaries. This is also used to dispatch different test folder in the lab.
Commit migrated from https://github.com/dotnet/coreclr/commit/
10cbbf046f6443ad74d3c0ff4a6468acc833be50
sbomer [Wed, 18 May 2016 23:40:12 +0000 (16:40 -0700)]
Port from tfs: onload exception debugger crash fix (dotnet/coreclr#4868)
The ExceptionHijackPersonalityRoutine was retrieving a context from a
particular stack frame, but the calling conventions for the function
executing in that frame allow it to overwrite the context. This was
causing the debugger to crash for exceptions thrown from the onload
method in winforms on x64.
The fix is to instead retrieve the context from the previous stack
frame, whose layout is set up explicitly in ExceptionHijack.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1d6f7abbc5dd716cea4dc75b3da8043b9759ded
Bruce Forstall [Wed, 18 May 2016 23:18:38 +0000 (16:18 -0700)]
Merge pull request dotnet/coreclr#5070 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
cc70bf864bb915c0541cfba86f8998fc905174b5
Sean Gillespie [Mon, 16 May 2016 18:53:07 +0000 (11:53 -0700)]
Switch GCSimulator to BuildAndRun so that a shell wrapper gets generated
Commit migrated from https://github.com/dotnet/coreclr/commit/
cecf706ee162973df21eab7315b425e7c96ff977
wtgodbe [Tue, 17 May 2016 23:27:35 +0000 (16:27 -0700)]
Update build scripts to fix small errors
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9117c44ad2a370df9b3d337dca9283877387f08
Alex Ghiondea [Wed, 18 May 2016 21:57:00 +0000 (14:57 -0700)]
Explicitly reference the file containing the mscorlib reference assembly.
[tfs-changeset: 1606007]
Commit migrated from https://github.com/dotnet/coreclr/commit/
93926c831889efd914e786c7ca1a8a9db44050b8
Aditya Mandaleeka [Wed, 18 May 2016 21:51:05 +0000 (14:51 -0700)]
Merge pull request dotnet/coreclr#5039 from adityamandaleeka/sigterm_chaining
Put SIGTERM registration behind a PAL initialization flag
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9dff80a222f30d1ff74e9ad1d5b8cdcb953897a
Hugh Bellamy [Wed, 18 May 2016 21:27:37 +0000 (22:27 +0100)]
Cache GetLowerBound in Array.Reverse and Array.Sort (dotnet/coreclr#5019)
- Avoids calling internal native method 4 times per sort: 2 times is
enough
- Avoids calling internal native method 2 times per reverse: 1 time is
enough
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2fb9c1cead47d21723a137e6fc13ba4577c5c66
Kyungwoo Lee [Sat, 14 May 2016 20:06:57 +0000 (13:06 -0700)]
ARM64: Enable End-To-End ReadyToRun (R2R) Crossgen
Fixes https://github.com/dotnet/coreclr/issues/4649
The immediate issues was NYI on genEmitHelperCalls. The initial
implementation for the missing part was enough to just crossgen System.dll.
But running tests revealed various issues in crossgened binaries (R2R).
Most common user/helper calls in R2R are represented as indirect calls
similar to interface call using virtual stub dispatch cell --
thunk/helper needs a indirect cell address to update the final target
address on the data location. `IsDelayLoadHelper` and `IsLazyHelper` belong to
this case.
Instead of passing such parameter, x64/x86 uses an encoding trick -- it
assumes the call is dispatched like `call [addr]`. So from the return
address, runtime could extract indirect cell address. Unfortunately this is not
an option for arm64 (actually arm as well but I haven't fixed it in this
change) where indirect call on memory is not encodable.
So, I made the following changes:
1. For the call requiring that needs to pass indirect cell address, I
tagged the call tree via `setR2RRelativeIndir`. Tried to be comprehensive,
but I may miss something. Currently, it includes a regular call and
various helpers for (virtual) load function pointer/static data access, etc.
Hopely we change JIT/EE interface somehow that gives us such explicit information.
2. Use the X11 to record indirect cell address for such call tree in
lower similar to VSD.
3. Fixed encodings `ZapIndirectHelperThunk`. In particular the immediate
value/offset for `ldr` should be scaled down 4 times since HW will scale
it 4 times.
4. Implement `genEmitHelperCalls` for indirect case. This is not the case requiring indirect
cell address. This is the case we inlined the indirect helper thunk for
the speed. I'm seeing the case for size opt helper call, we invoke a
direct call to such thunk which actually uses x12 to dispatch the final
target. Likewise, I used x12 for this expansion which seems a trash register that is not
overlapped with arugments with jit helpers like writer barriers.
With this change, I've tested various cases/scenraios locally.
Also I've verified all tests are passed against mscorlib.ni.dll and System.ni.dll.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3165d8e5bfddd78028c9eb2b5ea3ec995c71a849
Rama krishnan Raghupathy [Wed, 18 May 2016 21:17:54 +0000 (14:17 -0700)]
Merge pull request dotnet/coreclr#5069 from ramarag/R2RCleanup
Removing hard coded path Fixes dotnet/coreclr#5065
Commit migrated from https://github.com/dotnet/coreclr/commit/
a338ace5295674f967054dd5452a9a7c379e33ad
Yi Zhang (CLR) [Wed, 18 May 2016 20:36:13 +0000 (13:36 -0700)]
Merge pull request dotnet/coreclr#5048 from yizhang82/hostpath-fix
Move NATIVE_DLL_SEARCH_DIRECTORIES probing earlier right before we pr…
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d5171c791f03e9b27e7f3370778e6d3debef40a
Russ Keldorph [Wed, 18 May 2016 20:10:28 +0000 (13:10 -0700)]
Merge pull request dotnet/coreclr#5044 from RussKeldorph/lifetime2
Fix and reenable lifetime2
Commit migrated from https://github.com/dotnet/coreclr/commit/
298ab3215d1c2cd34b96b3b2a0253d5a25fed47f
James Ko [Wed, 18 May 2016 20:09:33 +0000 (16:09 -0400)]
Remove Encoding FEATURE_* defines from mscorlib (dotnet/coreclr#5026)
* Remove Encoding FEATURE_* defines from mscorlib
* Remove strange character from Encoding.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cd92b2da7b3aac86598e7b8d7b6fad063239b6b
Rama Krishnan Raghupathy [Wed, 18 May 2016 19:28:20 +0000 (12:28 -0700)]
Removing hard coded path
Commit migrated from https://github.com/dotnet/coreclr/commit/
384667276402262556cbb805bceab42cc3389ac7
Bruce Forstall [Wed, 18 May 2016 19:33:06 +0000 (12:33 -0700)]
Merge pull request dotnet/coreclr#5062 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c441feb2cb34cce5cc8b76a11d8860eb462836e
Rahul Kumar [Wed, 18 May 2016 19:16:50 +0000 (12:16 -0700)]
Merge pull request dotnet/coreclr#5036 from rahku/fixes
Fix for issue# 3651
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbab51323adafc986914e8a94b47db643d313ee6
Andy Ayers [Fri, 13 May 2016 07:39:14 +0000 (00:39 -0700)]
Inliner: small changes to inline xml
Emit the hash for callees, and check it during replay.
Capture the root method name, and do a simple Xml-safe conversion.
Add a missing newline to the banner message announcing that the replay
policy is in effect.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7b753d51a17415b7723c85e0aaa0a649f71d2eb0
Venkata Sivaramakrishna Ramadugu [Wed, 18 May 2016 17:59:02 +0000 (10:59 -0700)]
Fix to Jit32 test b46659.exe failure.
Here is the git hub issue: https://github.com/dotnet/coreclr/issues/4547
The repro case is
i = -111
while ( i > 0)
{
// another nested loop goes here
}
return 100
After assertionProp, due to while loop condition lot of blocks/stmts get deleted as unreachable but optLoopCount is never decremented. Later when optLoopCodeMotion() gets called, it iterates through optLoopTable[] and tries to access head
if ((loopRmv & loopBit) ||
tail == 0 ||
head->bbTreeList == 0 )
Since entire method reduces to a single basic block, head will be nullptr and accessing head->bbTreeList is leading to an AV.
Fix: As a safe fix for RTM, also check whether head is nullptr.
[tfs-changeset: 1605919]
Commit migrated from https://github.com/dotnet/coreclr/commit/
3bb9ddf1c6318655d9e6f46f29af02e0648fcebc
Jeremy Kuhne [Wed, 18 May 2016 17:41:27 +0000 (10:41 -0700)]
Merge pull request dotnet/coreclr#4902 from JeremyKuhne/WindowsLongPath
Allow long paths in CoreCLR managed code
Commit migrated from https://github.com/dotnet/coreclr/commit/
08832577f09faf9176de87bf49765ae7bbdf8e62
Bruce Forstall [Wed, 18 May 2016 17:33:28 +0000 (10:33 -0700)]
Rollback CSdotnet/coreclr#1603899 that led to a JIT assert ngen'ing System.Windows.Forms.dll
====================
007551: Merge pull request dotnet/coreclr#1241 from mikedn/modopt
Extend the DIV/MOD dividend into RDX:RAX only if needed
====================
Assert failure(PID 33656 [0x00008378], Thread: 17792 [0x4580]): Assertion failed 'addr->OperIsAddrMode() || (addr->IsCnsIntOrI() && addr->isContained()) || !addr->isContained()' in 'System.Windows.Forms.CheckedListBox:OnDrawItem(ref):this' (IL size 1216)
File: e:\dd\projectk\src\ndp\clr\src\jit\emitxarch.cpp Line: 2698
Image: C:\Windows\Microsoft.NET\Framework64\v4.0.rb1605209\mscorsvw.exe
The tree:
***** BB41, stmt 82 (embedded)
( 6, 8) [003723] ------------ * stmtExpr void (embedded) (IL 0x109... ???)
N1045 ( 3, 2) [000115] ------------ | /--* lclVar ref V00 this u:2 REG rcx $80
N1047 ( 1, 4) [002642] ------------ | +--* const long 344 field offset Fseq[idealCheckSize] REG NA $10b
N1049 ( 4, 6) [002643] -------N---- | /--* + byref REG NA $356
N1051 ( 6, 8) [000116] ----GO------ | /--* indir int REG rcx <l:$685, c:$2ef>
N1053 ( 6, 8) [003669] DA--GO------ \--* st.lclVar int V172 cse1 rcx REG rcx RV
During codegen:
Generating BB41, stmt 71 Holding variables: [rbx rsi rdi r12-r15]
Generating: N1043 ( 3, 2) [000114] ------------ * lclVar int V05 loc3 u:3 r12 (last use) REG r12 RV $31a
Generating: N1045 ( 3, 2) [000115] ------------ * lclVar ref V00 this u:2 REG rcx $80
IN00db: mov rcx, gword ptr [V00 rbp+10H]
GC regs:
00000040 {rsi} =>
00000042 {rcx rsi}
Generating: N1047 ( 1, 4) [002642] ------------ * const long 344 field offset Fseq[idealCheckSize] REG NA $10b
Generating: N1049 ( 4, 6) [002643] -------N---- * + byref REG NA $356
Generating: N1051 ( 6, 8) [000116] ----GO------ * indir int REG rcx <l:$685, c:$2ef>
... assert ...
(This is rollback dotnet/coreclr#2: the TFS/GitHub mirror unfortunately undid rollback CSdotnet/coreclr#1605814 with CSdotnet/coreclr#1605840. This change should avoid that problem.)
[tfs-changeset: 1605917]
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce8e7e3a0d6ad3dd34a8b3487c8068e49c6b45e0
Russ Keldorph [Wed, 18 May 2016 17:22:45 +0000 (10:22 -0700)]
Exclude smallframe for JIT32
This test was flagged as incompatible with COMPlus_JITMinOpts in the
previous test harness. It doesn't fail for RyuJIT, though, even under
MinOpts, so, rather than disabling it everywhere under MinOpts, I'm only
disabling it for JIT32.
Fixes dotnet/coreclr#4548
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc6049df68a2cded5b6afacd9b977f159febf2d1
Fadi Hanna [Wed, 18 May 2016 17:18:53 +0000 (10:18 -0700)]
Porting the changes to support generic dictionaries lookups in R2R images to the JIT32 implementation, to support the x86 architecture.
All of the changes in importer.cpp were ported from JIT\importer.cpp, which was merged to the coreclr master branch last Friday evening (reviewed and signed-off in a PR on GitHub).
The remaining changes include:
1) Adjusting #ifdefs to enable the x86 scenario
2) Implementation of the R2R stub for generic dictionary lookups
3) Small change in prestub.cpp required for x86 to work correctly
[tfs-changeset: 1605906]
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d78bb285816c69f39c016950d3add07f650483e
Alex Ghiondea [Wed, 18 May 2016 16:21:25 +0000 (09:21 -0700)]
Explicitly specify the location from where to pick up the model.corelib.xml
[tfs-changeset: 1605881]
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ab27c57d093f073429117e6312108bc9ed2e171
Dongyun Jin [Wed, 18 May 2016 15:44:36 +0000 (00:44 +0900)]
Fix Interop TCs to use long long instead of long (dotnet/coreclr#5054)
Some TCs were using long for 64bit variable.
While it is correct on x86, long is 32bit on ARM.
Fix TCs to use long long instead so that they can pass on ARM as well.
Fix dotnet/coreclr#5053
Signed-off-by: Dongyun Jin <dongyun.jin@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7704374e683a8d3644a0640010936a22296967a
Bruce Forstall [Wed, 18 May 2016 14:19:23 +0000 (07:19 -0700)]
Merge pull request dotnet/coreclr#5055 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
4716d27c9550f4ce24f32e6248b4b350fe1e08ac
John Chen [Wed, 18 May 2016 09:46:23 +0000 (02:46 -0700)]
Fix crossgen /createpdb when input filename is given without path (dotnet/coreclr#5045)
Fix a bug in "crossgen /createpdb" command that can cause it to fail
if the input filename is given without a path.
Commit migrated from https://github.com/dotnet/coreclr/commit/
acd2bba2231e07f006846b44e790c5073d7c6019
Swaroop Sridhar [Wed, 18 May 2016 09:44:44 +0000 (02:44 -0700)]
ARM64: Fix LR update in a few stubs (dotnet/coreclr#5013)
Fix LR capture/restore in a few stubs helpers.
This change fixed failures in 6 GC tests under GCStress.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7e9bd0570ed853e7fcf524537388b1bc43ce086f
Stephen Toub [Wed, 18 May 2016 09:43:08 +0000 (05:43 -0400)]
Add private properties for debugger access to Task fields (dotnet/coreclr#5024)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e4d83dff604197c78f7de2e01e51674f90932209
Jan Kotas [Wed, 18 May 2016 09:37:56 +0000 (02:37 -0700)]
Add missing method contract
[tfs-changeset: 1605842]
Commit migrated from https://github.com/dotnet/coreclr/commit/
1bbb6e4941b26053ec81be3f5bedf187fc336076
James Ko [Wed, 18 May 2016 09:19:30 +0000 (05:19 -0400)]
String.Equals: Don't typecast if object refs are the same (dotnet/coreclr#5021)
Commit migrated from https://github.com/dotnet/coreclr/commit/
32a621023b6ddd639e8aa4d1ab749d87c558c40a
Jan Kotas [Wed, 18 May 2016 09:18:20 +0000 (02:18 -0700)]
Merge pull request dotnet/coreclr#5050 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
681fa0cdce34d28cfe844dc5788da1c37fc40271
Rama krishnan Raghupathy [Wed, 18 May 2016 07:59:10 +0000 (00:59 -0700)]
Merge pull request dotnet/coreclr#5028 from ramarag/R2Rtests
Guard Crossgen Test Runtime logic with RunCrossGen Env
this fixes https://github.com/dotnet/coreclr/issues/3759
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3fc0101166fd9bbd878bda8c5a83e3fa4b4b18b
Matt Ellis [Wed, 18 May 2016 06:39:18 +0000 (23:39 -0700)]
Add missing .gitmirrorall file
[tfs-changeset: 1605815]
Commit migrated from https://github.com/dotnet/coreclr/commit/
103b370789ed107639e77b2e47028e1621243d12
Yi Zhang [Wed, 18 May 2016 06:01:51 +0000 (23:01 -0700)]
Move NATIVE_DLL_SEARCH_DIRECTORIES probing earlier right before we probe for absolute path and assembly path. This is needed to make sure servicing directories (set in NATIVE_DLL_SEARCH_DIRECTORIES by host) are honored correctly before everything else, along with rest of the NATIVE_DLL_SEARCH_DIRECTORIES probing path. In order to preserve compat with UWP host, I kept the rest of the interop probing logic even when NATIVE_DLL_SEARCH_DIRECTORIES probing path is specified.
To my horror I discovered the fact that we actually never set hmod when loading DLL from NATIVE_DLL_SEARCH_DIRECTORIES probing, and the probably the only saving grace is that our ultimate fallback LoadLibrary call after that would "just work" and return the HMODULE we just loaded... This is now fixed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
63dda33bc66c04ed24eb17e75b69dcfb0a6485a5
Gaurav Khanna [Wed, 18 May 2016 05:50:26 +0000 (22:50 -0700)]
Merge pull request dotnet/coreclr#5034 from dotnet/revert-4969-RelaxALC
Revert "Enable overriding assemblies from TPA"
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a0396065857a0292fafbdfc357f0830f71ea99b
tijoytom [Wed, 18 May 2016 05:36:25 +0000 (22:36 -0700)]
Merge pull request dotnet/coreclr#5016 from tijoytom/master
[Do not Merge]Renaming ZeroFreeAllocMemUTF8 to ZeroFreeCoTaskMemUTF8
Commit migrated from https://github.com/dotnet/coreclr/commit/
06b47df44b35cd545398c446919b89de2c5d14f0
tijoytom [Wed, 18 May 2016 05:29:45 +0000 (22:29 -0700)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Commit migrated from https://github.com/dotnet/coreclr/commit/
ccc289b60b9a95ee28cdc56e5c785f607e34b1cf
Kshama Pawar [Wed, 18 May 2016 04:50:56 +0000 (21:50 -0700)]
Merge pull request dotnet/coreclr#5032 from kspawa/r2rngen
Treat R2R images as NI for profiling
Commit migrated from https://github.com/dotnet/coreclr/commit/
0177a7affbe3c09c0be8b753e1907612fff62d46
Russ Keldorph [Wed, 18 May 2016 04:33:51 +0000 (21:33 -0700)]
Fix and reenable lifetime2
lifetime2 is another questionable test case that relies on lifetime
guarantees that don't exist. Per our convention, force optimization on
and mark it as "optimization sensitive" to make a best effort to get it to
pass.
Fixes dotnet/coreclr#1037
Commit migrated from https://github.com/dotnet/coreclr/commit/
63694e982108508057ce0a1d02e43019997292ed
Geunsik Lim [Wed, 18 May 2016 02:44:23 +0000 (11:44 +0900)]
Linux/ARM: Change default clang version from 3.5 to 3.6 (dotnet/coreclr#4928)
In case of the cross compilation on the ubuntu 14.04 x64
for Linux/ARM, the default version of clang/llvm that is
generated by "#> sudo ./cross/build-rootfs.sh arm" command
is 3.6 without 3.5 as following:
u14.04@x64> ls ./coreclr/cross/rootfs/arm/usr/lib/clang/3.6
include lib
u14.04@x64> ls ./coreclr/cross/rootfs/arm/usr/lib/llvm-3.6/
bin build include lib share
Let's keep the clang/llvm version consistently by moving
the default version from 'clang3.5' to 'clang3.6' at build-time
for Linux/ARM.
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
f39cef776f14ca0c4004e384bd4f331f07fe3e69
Rahul Kumar [Wed, 18 May 2016 02:26:06 +0000 (19:26 -0700)]
Fix for issue# 3651
Commit migrated from https://github.com/dotnet/coreclr/commit/
e8ad0d136fedc30ac31d2d38648ae81cda88af89
Gaurav Khanna [Wed, 18 May 2016 01:46:21 +0000 (18:46 -0700)]
Revert "Enable overriding assemblies from TPA"
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1df1851846e35703c9b0606748fe90423af464f
Rama Krishnan Raghupathy [Sat, 14 May 2016 02:41:46 +0000 (19:41 -0700)]
Guard Crossgen Test Runtime logic with RunCrossGen Env
Adds Semaphores to prevent race conditions
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc3168d8d4dd2cf60cdcfad4c8a9a68174612eff
Pat Gavlin [Wed, 18 May 2016 00:19:37 +0000 (17:19 -0700)]
Merge pull request dotnet/coreclr#4994 from pgavlin/gh4912.PAGE_SIZE.jit
Encapsulate or replace references to CORINFO_PAGE_SIZE.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e78338ef715dc6fd89d9cbd0bf93c7f88d211c20
Pat Gavlin [Wed, 18 May 2016 00:18:07 +0000 (17:18 -0700)]
Merge pull request dotnet/coreclr#5015 from pgavlin/jitOnDllHooks
Remove jitOnDllProcess{Attach,Detach}.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ed1bde4534e2093f3f4dac949c07f358bdd01044
James Ko [Wed, 18 May 2016 00:16:32 +0000 (20:16 -0400)]
Add more help options to corerun (dotnet/coreclr#4973)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f4fe31a03dca4ede37bd6451d0c81365ee9ee7e4
James Ko [Wed, 18 May 2016 00:12:15 +0000 (20:12 -0400)]
Remove redundant Rank checks from SZArrayHelper/Enumerator (dotnet/coreclr#5022)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c96cd5643e4eb9bdc1e59f4b651baaf49bc942b8
Aditya Mandaleeka [Wed, 18 May 2016 00:06:28 +0000 (17:06 -0700)]
Put SIGTERM registration behind a PAL initialization flag.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9eb779c20731a1d560ca76f48a6cd327b02dd03
Dongyun Jin [Wed, 18 May 2016 00:01:05 +0000 (09:01 +0900)]
Some test cases require more than 2GB RAM (dotnet/coreclr#4778)
Some test cases try to allocate 2GB, which is huge
for some testing environments.
Fix dotnet/coreclr#4714
Signed-off-by: Dongyun Jin <dongyun.jin@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
b78e02a61c537a554906f5c8ec936492e55a525c
Kshama Pawar [Tue, 17 May 2016 23:42:35 +0000 (16:42 -0700)]
Treat R2R images as NI for profiling
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c425e520615f7546befcf10693fbdd02b4aa492
Aditya Mandaleeka [Tue, 17 May 2016 23:37:35 +0000 (16:37 -0700)]
Merge pull request dotnet/coreclr#4995 from adityamandaleeka/reenable_native_callable
Reenable NativeCallable test on x86 legacy backend
Commit migrated from https://github.com/dotnet/coreclr/commit/
988835820b229b406069b34c93204acd17845f4b
Aditya Mandaleeka [Tue, 17 May 2016 23:35:45 +0000 (16:35 -0700)]
Update contributing-workflow.md
Fix broken link to CODE_OWNERS file.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2b9ff45af4aaac65a9b07a1bdcb5299e8671e010
Dmitri-Botcharnikov [Tue, 17 May 2016 23:21:36 +0000 (03:21 +0400)]
Fix breakpoints on jitted code for Linux/ARM (dotnet/coreclr#5014)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a92eac6b4b635285525c80dcd9dadf3616d96370
noahfalk [Tue, 17 May 2016 23:18:15 +0000 (16:18 -0700)]
Start using CODE_OWNERS.TXT (dotnet/coreclr#5027)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1d80088b7ced953c7b9de1a29f4d77cb039dd8d2
Jose Perez Rodriguez [Tue, 17 May 2016 22:21:08 +0000 (17:21 -0500)]
Enable Checksum csc param for mscorlib (dotnet/coreclr#4996)
Enable Checksum csc param for mscorlib
Commit migrated from https://github.com/dotnet/coreclr/commit/
c396cf15da1ddbf1fd7dcf256357adac44829679
noahfalk [Tue, 17 May 2016 22:10:20 +0000 (15:10 -0700)]
Merge pull request dotnet/coreclr#4954 from kvochko/sos_tests
Added tests for libsosplugin
Commit migrated from https://github.com/dotnet/coreclr/commit/
4da260c3ffe401021b2e16dc8e29d4261c13da54
tijoytom [Tue, 17 May 2016 22:03:35 +0000 (15:03 -0700)]
updating model.corlib.xml
Commit migrated from https://github.com/dotnet/coreclr/commit/
20f179df2381b31f3bb6e9d36a8fce8e692d93bb
tijoytom [Tue, 17 May 2016 22:01:38 +0000 (15:01 -0700)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Commit migrated from https://github.com/dotnet/coreclr/commit/
417f93764b1ab79e4c048db626b90a8ec7d6e18e
William Godbe [Tue, 17 May 2016 21:07:45 +0000 (14:07 -0700)]
Merge pull request dotnet/coreclr#5023 from wtgodbe/pipeline
Add dev workflow scripts for build pipeline
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef78a67d1ced9fdf25beed75845c687951b46fcf
wtgodbe [Wed, 27 Apr 2016 21:35:45 +0000 (14:35 -0700)]
Add dev workflow scripts for build pipeline
Commit migrated from https://github.com/dotnet/coreclr/commit/
8568bf1d9722657c602a1f1fe0148e28a93ea8ce
AlexGhiondea [Tue, 17 May 2016 20:45:59 +0000 (13:45 -0700)]
Merge pull request dotnet/coreclr#4874 from gkhanna79/SPC_S1
Add support for System.Private.CoreLib to be core library
Commit migrated from https://github.com/dotnet/coreclr/commit/
41a4ad5054cf877db6aa331855b43ad8678a93ad
Sejong Oh [Tue, 17 May 2016 20:35:32 +0000 (13:35 -0700)]
Merge pull request dotnet/coreclr#4999 from sejongoh/avoid_ti_method_check
Add typeInfo::GetMehtod2 to avoid checking GetType == TI_METHOD.
Commit migrated from https://github.com/dotnet/coreclr/commit/
80f3d4f3a73abff6c90b331bc7b3eb97d365cf2c
Pat Gavlin [Mon, 16 May 2016 21:05:17 +0000 (14:05 -0700)]
Encapsulate or replace references to CORINFO_PAGE_SIZE.
This symbol will be replaced with a new field in CORINFO_EE_INFO as part of dotnet/coreclr#4912.
These changes prepare the JIT and EE for that change by (respectively) encapsulating
references to CORINFO_PAGE_SIZE in Compiler::eeGetPageSize and replacing
CORINFO_PAGE_SIZE with OS_PAGE_SIZE.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e8ee195d3fc8e6cbece1e0a69fc0586149a21a2f
Pat Gavlin [Tue, 17 May 2016 16:05:04 +0000 (09:05 -0700)]
Remove jitOnDllProcess{Attach,Detach}.
These functions have been obviated by a more clearly-defined JIT
startup and shutdown interface.
This fixes a crash in coreclr.dll during DLL unload: the runtime was
calling jitOnDllProcessDetach (which calls jitShutdown) without having
called jitStartup to initialized the JIT.
Commit migrated from https://github.com/dotnet/coreclr/commit/
265a27c75cada08509a5f0474cdb2938902370c0
Fadi Hanna [Tue, 17 May 2016 18:51:14 +0000 (11:51 -0700)]
Implementing the Unix calling convention for the generic dictionary access stubs in R2R (dotnet/coreclr#4998)
Commit migrated from https://github.com/dotnet/coreclr/commit/
182bea3c657856c90e9c5c0bab32bdc63c35352e
Sejong OH [Mon, 16 May 2016 22:42:07 +0000 (15:42 -0700)]
Add typeInfo::GetMehtod2 to avoid checking GetType == TI_METHOD.
If FEATURE_CORECLR is enabled, the pointer type is not known to be a method pointer type when GetMethod is called in the importer.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e664c56ec991b9d73a00a0628e114d0c2b0dfec
Sejong Oh [Tue, 17 May 2016 18:16:27 +0000 (11:16 -0700)]
Merge pull request dotnet/coreclr#4789 from sejongoh/always_download_coredistools
Always download coredistools package
Commit migrated from https://github.com/dotnet/coreclr/commit/
bdae3b2145cd0b427cd0efb4d254f10655133fe7
Yi Zhang (CLR) [Tue, 17 May 2016 17:12:04 +0000 (10:12 -0700)]
Merge pull request dotnet/coreclr#5008 from yizhang82/dllimportpath-fix2
Enable DefaultDllImportSearchPathsAttribute in CoreCLR Windows. Host …
Commit migrated from https://github.com/dotnet/coreclr/commit/
a47cf1cba1018875aff41f90bc8eddef7963218d
Carol Eidt [Tue, 17 May 2016 16:41:30 +0000 (09:41 -0700)]
Merge pull request dotnet/coreclr#5002 from CarolEidt/Long32Doc
Document about supporting long on 32-bit architectures.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0f8053d72670ce815f49906c98deeb5f71f4a1c1
James Ko [Tue, 17 May 2016 15:46:08 +0000 (11:46 -0400)]
Optimize Array.GetLength, GetUpperBound, GetLowerBound (dotnet/coreclr#4993)
... if the argument is 0. As the rank will always be greater, this is safe.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee683a09634c967240bd63b3c925d6a99e0ac014
Matt Warren [Tue, 17 May 2016 15:42:25 +0000 (16:42 +0100)]
Update StringObject comment in object.h (dotnet/coreclr#5011)
* m_ArrayLength is no longer present (I did a search of the source and couldn't find it), so this comment is misleading.
* Also removing mis-leading comment about high two bits of field
Commit migrated from https://github.com/dotnet/coreclr/commit/
1cb362e337c062a6f5945e6c8afd18b6830aeb75
Jan Kotas [Tue, 17 May 2016 15:36:57 +0000 (08:36 -0700)]
Move notion of restricted physical memory behind the GCToOSInterface (dotnet/coreclr#5007)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0f94239fadf20295b4fc7e8935ffd27a289f9d5e
Russ Keldorph [Tue, 17 May 2016 15:32:15 +0000 (08:32 -0700)]
Merge pull request dotnet/coreclr#4997 from RussKeldorph/fix3379
Rename some IL tests whose names conflicted with C# tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
8162628ae3bcbe805abf9266f67d4c42880bc2e8