profile/ivi/qtbase.git
11 years agoMac: Don't crash if language preferences can't be retrieved.
Eike Ziller [Tue, 17 Jul 2012 09:19:02 +0000 (11:19 +0200)]
Mac: Don't crash if language preferences can't be retrieved.

That can happen when e.g. running an application with sudo.

Task-number: QTBUG-26547
Change-Id: Ib16ef7798ebcd1c9b8d661dd2e3ce3aadc393489
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
11 years agoStabilize the QHeaderView test.
Friedemann Kleint [Tue, 31 Jul 2012 07:06:50 +0000 (09:06 +0200)]
Stabilize the QHeaderView test.

The test has a member QWidget *topLevel which it recreates
and shows in init() without waiting for it to be exposed
although it is not used in every test case. This apparently
interferes with some tests that create separate top levels.
Do not show in init(), delete the topLevel.
Add wait to the cases where the topLevel is shown.

Change-Id: Ib428020b36dc82991d41e68478fd583bdfb004c7
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
11 years agoAccessibility: fix updates for models with rootIndex set.
Frederik Gladhorn [Wed, 25 Jul 2012 15:22:26 +0000 (17:22 +0200)]
Accessibility: fix updates for models with rootIndex set.

The accessible table/list implementation would ignore
when a root index is set, resulting in trying to use row/column
for the top level index, leading to accessing invalid indexes.

(cherry picked from commit def2ee829435c705055733a0f99c0ca44a012c50)

Conflicts:

src/plugins/accessible/widgets/itemviews.cpp

Change-Id: Ic2745ab3e262ccee2d43e0d532e165d2958f519e
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
11 years agobuild host tools in release mode again
Joerg Bornemann [Mon, 30 Jul 2012 11:52:01 +0000 (13:52 +0200)]
build host tools in release mode again

CONFIG does not contain build_all anymore,
thus we need to check QT_CONFIG in bootstrap.pr{i,o}.

Change-Id: Ia505fa101adc49f185908ca575d3211caed612db
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agotst_qwidget task reference fixed
Joerg Bornemann [Mon, 30 Jul 2012 10:56:34 +0000 (12:56 +0200)]
tst_qwidget task reference fixed

Change-Id: I8d65f5912bfc2daa1e35be33a3c4d986508eebeb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
11 years agoadd configure options for debug/release OpenSSL
Peter Kümmel [Thu, 26 Jul 2012 15:16:29 +0000 (17:16 +0200)]
add configure options for debug/release OpenSSL

msvc cannot use the same library for debug and release builds
if openssl libraries are linked statically into the network library.

Change-Id: Ic27ede2d9531b94aff4c50c1699947ce72caf286
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agoremove second argument from $$eval() (access to global scope)
Oswald Buddenhagen [Tue, 24 Jul 2012 15:09:14 +0000 (17:09 +0200)]
remove second argument from $$eval() (access to global scope)

sam added this based on a vague notion of backwards compatibility when
he fixed the function to use the local scope, but it kind of makes no
sense - there is very little reason for accessing the global scope from
within a function. google doesn't find any relevant hits except our
source code, so let's just nuke it.

Change-Id: Ie957bb47b531f7e9b5dfcceb4e09f65dd826b422
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agodon't set -rpath-link in qmodule.pri
Oswald Buddenhagen [Mon, 23 Jul 2012 12:04:43 +0000 (14:04 +0200)]
don't set -rpath-link in qmodule.pri

qt.prf takes care of that already

Change-Id: Ibc426583a007edbbe2f53cc21ce676eb60b33485
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agorun processPrlFiles() over QMAKE_LIBS_PRIVATE as well
Oswald Buddenhagen [Fri, 20 Jul 2012 13:34:54 +0000 (15:34 +0200)]
run processPrlFiles() over QMAKE_LIBS_PRIVATE as well

there is no reason why private libs should not have prls resolved.

the two variables are resolved independently, so it's possible that
(even more) libraries will appear duplicated on the linker command line,
but that seems easiest for the time being.

Change-Id: I9070ba53808a0661fa72949db8111106b7aca487
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoinline MakefileGenerator::processPrlVariable()
Oswald Buddenhagen [Fri, 20 Jul 2012 13:31:14 +0000 (15:31 +0200)]
inline MakefileGenerator::processPrlVariable()

the visitor-pattern like approach is not needed any more

Change-Id: I990db681cbeee91d89ecba97745a8104595247e7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agomake the windows prl processing more like the unix variant
Oswald Buddenhagen [Fri, 20 Jul 2012 13:23:01 +0000 (15:23 +0200)]
make the windows prl processing more like the unix variant

it's more elegant, and more similar code is better.

Change-Id: I2b8b036cb70a932fd171e23cf7d3389188401924
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoremove apparently useless code
Oswald Buddenhagen [Fri, 20 Jul 2012 13:04:39 +0000 (15:04 +0200)]
remove apparently useless code

it wouldn't actually *do* anything, as l is not a reference. i cannot
figure out the original intention, so let's just drop it.

Change-Id: Ic0a3457a1872cde827259ee5530959120456e934
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agostub out MakefileGenerator::processPrlFiles()
Oswald Buddenhagen [Fri, 20 Jul 2012 10:29:21 +0000 (12:29 +0200)]
stub out MakefileGenerator::processPrlFiles()

the unix and windows variants don't rely on it.
not making it purely virtual only because the project generator inherits
MakefileGenerator as well but does not need an implementation.

Change-Id: I80099b3f5d07cd037b408cf1099c58ff3a2904cd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoSearch the include paths for json files containing plugin info
Lars Knoll [Fri, 20 Jul 2012 10:39:53 +0000 (12:39 +0200)]
Search the include paths for json files containing plugin info

This fixes shadow builds with autogenerated .json files as
e.g. used by Qt Creator.

Change-Id: Ibb783b05d97d996100da4b0dca859fa3f310dc83
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
11 years agoStabilize QWidget-test alienwidgets on XCB.
Friedemann Kleint [Mon, 30 Jul 2012 20:54:08 +0000 (22:54 +0200)]
Stabilize QWidget-test alienwidgets on XCB.

Use QTRY_VERIFY for the mappped attribute check.

Change-Id: I3cbde9122405bf7067f3702193e80636edc8c5c6
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
11 years agoqclass_lib_map.h: Fix include of the QDeclarativeView widget.
Friedemann Kleint [Mon, 30 Jul 2012 10:10:58 +0000 (12:10 +0200)]
qclass_lib_map.h: Fix include of the QDeclarativeView widget.

Task-number: QTBUG-25196

Change-Id: If25c4df29297435b159706257d9f37a9ef2f3d7a
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
11 years agoAlign the CP949 codec name with ICU
Lars Knoll [Mon, 30 Jul 2012 07:27:19 +0000 (09:27 +0200)]
Align the CP949 codec name with ICU

It's name is windows-949 according to ICU. Keep
CP949 as an alias for compatibility with Qt 4.

Change-Id: I115ba2593da6f7b47e25136c3fadb19c7f798ff0
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoFixes to the qdom autotest
Lars Knoll [Mon, 30 Jul 2012 07:26:03 +0000 (09:26 +0200)]
Fixes to the qdom autotest

Don't rely on a black list of codecs for the serialization
test. This breaks badly when new codecs get added to Qt
(e.g. through ICU). Instead use a white list of known
codecs that can encode/decode the test data.

Change-Id: I1dc55a25e852198bb935f070a4a21e8369f56268
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoAdd missing namespace macros
Lars Knoll [Fri, 27 Jul 2012 07:05:43 +0000 (09:05 +0200)]
Add missing namespace macros

Change-Id: I7cfeece0914b03b6113207de96b931dc54377f77
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoSmall doc fixes about the list of supported codecs.
Lars Knoll [Wed, 25 Jul 2012 11:04:19 +0000 (13:04 +0200)]
Small doc fixes about the list of supported codecs.

Change-Id: I98b8ec9d5de9e69f1bb6187b4d820d61f7ce03e5
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoDo not preload any codecs anymore when using ICU
Lars Knoll [Wed, 25 Jul 2012 10:57:15 +0000 (12:57 +0200)]
Do not preload any codecs anymore when using ICU

When using ICU we can now avoid pre loading any codecs
at startup. Instead QTextCodecs will always be created
lazily when first asked for.

Change-Id: Ic668f2824700896d2eca7d0de54f978404826163
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoAdd a factory method to QIsciiCodec and fix the names
Lars Knoll [Wed, 25 Jul 2012 10:54:56 +0000 (12:54 +0200)]
Add a factory method to QIsciiCodec and fix the names

Make the names all lower case to be in line with what ICU
reports. Add a factory method to create the codecs according
to their name.

Change-Id: Ia3dddaa7701a0645d9d8fbcb52f1f8d58f79cf98
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoUse ICU instead of iconv/windows codecs for the locale
Lars Knoll [Wed, 25 Jul 2012 08:17:44 +0000 (10:17 +0200)]
Use ICU instead of iconv/windows codecs for the locale

With ICU there's no need to use the windows locale or iconv
codecs anymore as locale codecs.

Change-Id: I50c94a97ed6acbf4c6f05b2a88593a57ebfa8342
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoMake codecForLocale atomic
Lars Knoll [Wed, 25 Jul 2012 08:16:59 +0000 (10:16 +0200)]
Make codecForLocale atomic

Change-Id: I8017b1c2aa1df8d613e83919a945fd5f320713d6
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoICU code page conversion support
Lars Knoll [Fri, 20 Jul 2012 22:31:37 +0000 (00:31 +0200)]
ICU code page conversion support

Use ICU to do code page conversion instead of the
builtin text codecs. With this QTextCodec simply
becomes a wrapper around ICU's ucnv_* methods.

We only keep our own codecs for UTF-*, ISO-8859-1,
ISO-8859-15 for performance reasons, and for TSCII
and iscii-* because they aren't supported by ICU.

Change-Id: I4fc49eba55cf772b9772c6dac606a47a44346a60
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoRename some codecs to be in line with ICU
Lars Knoll [Sat, 21 Jul 2012 21:34:07 +0000 (23:34 +0200)]
Rename some codecs to be in line with ICU

Change-Id: If523d2a12ef64c79e3860da1f430f128d24ff600
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoDisable iconv on utf-8 based platforms
Lars Knoll [Fri, 20 Jul 2012 19:22:47 +0000 (21:22 +0200)]
Disable iconv on utf-8 based platforms

There's no need to use iconv on Mac,
iOS, Android or QNX, as all these
platforms are fully utf-8 based.

Change-Id: I2a03c8dea72ad91f6ec83da0a838de20e46babef
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoLazily initialize iconv in the iconv codec
Lars Knoll [Fri, 20 Jul 2012 18:49:13 +0000 (20:49 +0200)]
Lazily initialize iconv in the iconv codec

Avoid dlopen'ing libiconv and initializing
it's members until the codec gets used for
the first time. This avoids some memory
and startup time overhead in case we can
use the utf8 codec instead of iconv.

It also removes a circular dependency
between codec initialization during app
startup.

Change-Id: I119c010c288dc59ab32279d8a213ae1f4347cace
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoUse utf-8 as the locale codec where it makes sense
Lars Knoll [Fri, 20 Jul 2012 09:02:40 +0000 (11:02 +0200)]
Use utf-8 as the locale codec where it makes sense

Use utf8 as the fallback codec in case we can't determine
something else instead of latin1.
Also use utf8 for Mac, iOS, Android and QNX.

Change-Id: I15dc85d2406b1ebdfacff25f45f8b6854c52b97e
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoRemove encoding detection according to LANG
Lars Knoll [Fri, 20 Jul 2012 08:54:25 +0000 (10:54 +0200)]
Remove encoding detection according to LANG

This code is left over from the 90's, and should not
get used anymore. In all relevant cases we will use UTF-8
or iconv nowadays.

Change-Id: Ie3776f671de33f782fa77f6359bf6e105bd9c1b8
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoMove the text codec list to qcoreglobaldata.
Lars Knoll [Fri, 20 Jul 2012 08:00:52 +0000 (10:00 +0200)]
Move the text codec list to qcoreglobaldata.

This removes some global statics in QTextCodec and
makes the code better to maintain in the longer term.

Remove QT_NO_THREAD defines around mutexes as this
isn't required in Qt 5 anymore.

Change-Id: I15ede75f53b16f134f4053f3188c4b47e86fcd8a
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoEnsure that QAtomicPointer of forward-declared classes works
Thiago Macieira [Fri, 27 Jul 2012 14:28:36 +0000 (16:28 +0200)]
Ensure that QAtomicPointer of forward-declared classes works

This is working, but let's just be sure by adding a testcase.

Change-Id: I8c6b5ded0c7b6c90645dbf70a7ce6c1ba447a284
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
11 years agoQtNetwork: Better detection of connection failures on Windows
Martin Petersson [Thu, 12 Jul 2012 10:52:17 +0000 (12:52 +0200)]
QtNetwork: Better detection of connection failures on Windows

If the error code from WSAConnect is WSAEWOULDBLOCK, then the
operation proceeds but the outcome is not known at that time. We then
check SO_ERROR's value to detect errors. But if that call returns 0
this could indicate that the value is still not know. In this case
we try one more time to increase the chance of getting the correct
value.

This fixed the tst_QNetworkReply::getFromUnreachableIp auto test
on Windows.

Change-Id: I25008aca062b2f823e3d93ebb0ae456d7e4a6ecc
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
11 years agoQUrl: document that setIdnWhitelist isn't thread-safe
Marc Mutz [Sat, 28 Jul 2012 23:04:08 +0000 (01:04 +0200)]
QUrl: document that setIdnWhitelist isn't thread-safe

This is a forward-port of 6b10fc91 from Qt 4.

Change-Id: I58878bf24e4f1b50ebfd0457c37eef58696f4a4c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoMake benchmarks compile without QtWidgets
Rohan McGovern [Mon, 30 Jul 2012 03:58:52 +0000 (13:58 +1000)]
Make benchmarks compile without QtWidgets

Ensure benchmarks which need QtWidgets are gracefully disabled when
that module is unavailable.

Fixed one unnecessary usage of "QT+=widgets".

Change-Id: I8031b5dca585749f0f4d22e0637adc3f57f4e418
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
11 years agoqdoc: Added safety checks to findUnambiguousTarget()
Martin Smith [Thu, 26 Jul 2012 12:16:58 +0000 (14:16 +0200)]
qdoc: Added safety checks to findUnambiguousTarget()

This is a blind attempt to fix QTBUG-26615. I can't
reproduce the crash on OSX.

Task nr: QTBUG-26615

Change-Id: Ifc6b68b7f302b9cd7d02129be8ae56841a35e5de
Reviewed-by: Martin Smith <martin.smith@nokia.com>
11 years agofix QEventLoop qdoc errors
Jeremy Katz [Fri, 27 Jul 2012 14:20:52 +0000 (16:20 +0200)]
fix QEventLoop qdoc errors

Change-Id: I17bb720d539a7ccf5d9a3b20853897ff052fc8a6
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agotests: fixed check for QtOpenGL
Rohan McGovern [Mon, 30 Jul 2012 03:45:51 +0000 (13:45 +1000)]
tests: fixed check for QtOpenGL

contains(QT_CONFIG,opengl) tells whether Qt itself is able to use
OpenGL, which is not the same thing as whether the QtOpenGL API is
available. Make the check correct; fixes compilation when Qt is
configured with -no-widgets (which also disables QtOpenGL).

Change-Id: Iaa296c2b10650971ef4846f8bc6f44761fadcf7c
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
11 years agotests: disable qstandarditemmodel test when building without QtWidgets
Rohan McGovern [Mon, 30 Jul 2012 03:44:10 +0000 (13:44 +1000)]
tests: disable qstandarditemmodel test when building without QtWidgets

This test uses QTreeView.

Change-Id: I6ba56ad6ec3687a5b90d516be10d6f88e248d53d
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
11 years agotests: removed QtWidgets dependency from tst_qsignalmapper
Rohan McGovern [Mon, 30 Jul 2012 03:13:44 +0000 (13:13 +1000)]
tests: removed QtWidgets dependency from tst_qsignalmapper

This test was using some QSpinBox instances to generate signals for
testing. Use our own QtTestObject to generate the signals instead.

Change-Id: I3714955ae040d541c3b613a478945c38a18be18d
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
11 years agoQNX: Reduce dependency on QtWidgets
Kevin Krammer [Sun, 29 Jul 2012 08:46:12 +0000 (10:46 +0200)]
QNX: Reduce dependency on QtWidgets

Use QObject::inherits() to check if the current input focus object is
a numerical input instead of trying to cast.

Change-Id: Ie476fba3d2f9f20a1ce0328043430cb6a96a8a3d
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
11 years agoSend the native scancode in evdevkeyboard
Laszlo Agocs [Wed, 25 Jul 2012 11:36:16 +0000 (14:36 +0300)]
Send the native scancode in evdevkeyboard

Until now the native scancode was not specified which meant
when qwindow-compositor (or any other Qt-based compositor using
the standard Wayland protocol, i.e. sendKeyPress() and such) tried
to send the native scancode over to the clients, all it got was a
code of 0.

This fixes keyboard input when running qwindow-compositor on top
of kms and EvdevKeyboard.

Change-Id: I5d9a882f249634fb7584900b5f298f794befee3b
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
11 years agoDocument QEvent::EnterEditFocus and QEvent::LeaveEditFocus properly.
Mitch Curtis [Fri, 27 Jul 2012 08:48:48 +0000 (10:48 +0200)]
Document QEvent::EnterEditFocus and QEvent::LeaveEditFocus properly.

These enums are only accessible if QT_KEYPAD_NAVIGATION is defined.

Task-number: QTBUG-15631
Change-Id: Ifa826ac8f2bf28225572e0c664f18ffa5e78c302
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoremoved duplicated docs in android qsharedmemory and systemsemaphore
Jeremy Katz [Fri, 27 Jul 2012 12:10:20 +0000 (14:10 +0200)]
removed duplicated docs in android qsharedmemory and systemsemaphore

Qdoc sees all source and header files, rather than the subset selected
by qmake. This leads to qdoc errors when the same functions are
documented in multiple implementations.

In the cases fixed here, all documentation was duplicated, so no
information was lost.

Change-Id: Id7f8e2e617862a3778d0b05b38d8811aad456ac5
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
11 years agoSpecialize QTypeInfo for QUrlTwoFlags to mark it PRIMITIVE.
Stephen Kelly [Wed, 25 Jul 2012 15:17:14 +0000 (17:17 +0200)]
Specialize QTypeInfo for QUrlTwoFlags to mark it PRIMITIVE.

QTypeInfoMerger combines the typeinfos for the (PRIMITIVE) flag arguments.

Change-Id: I5abf00489491d099f2bf7ba25c191a771a383d78
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
11 years agoMark the QFlag and QIncompatibleFlag as primitive.
Stephen Kelly [Wed, 25 Jul 2012 15:05:56 +0000 (17:05 +0200)]
Mark the QFlag and QIncompatibleFlag as primitive.

Change-Id: I7dab4d029e7840fe4778a750a8dd7367675d7a27
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agodo not look for frameworks in library path
Oswald Buddenhagen [Thu, 19 Jul 2012 15:52:29 +0000 (17:52 +0200)]
do not look for frameworks in library path

it's just wrong

Change-Id: Ia21e9fb7e67623d6c4f70eab1f76360624ba314b
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoinsert explicit library search paths before system search paths
Oswald Buddenhagen [Thu, 19 Jul 2012 15:50:59 +0000 (17:50 +0200)]
insert explicit library search paths before system search paths

... as the linker does.

Change-Id: I4a030d9e2f281b892b78ba25b11f6df6b0893712
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agolook into /Library/Frameworks as well in processPrlFiles()
Oswald Buddenhagen [Thu, 19 Jul 2012 16:50:05 +0000 (18:50 +0200)]
look into /Library/Frameworks as well in processPrlFiles()

Change-Id: I445b9d1d3cd349eb7981b1aec824e6878b0c16e7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agounify default search paths between findLibraries() & processPrlFiles()
Oswald Buddenhagen [Thu, 19 Jul 2012 16:49:40 +0000 (18:49 +0200)]
unify default search paths between findLibraries() & processPrlFiles()

i see no reason why they should deviate

Change-Id: Iaa0445b79a95d348f51df74a74c7c89216c468ec
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agofix lookup of libraries with a full path but without extension
Oswald Buddenhagen [Thu, 19 Jul 2012 16:32:16 +0000 (18:32 +0200)]
fix lookup of libraries with a full path but without extension

given that nobody noticed so far how broken this was, this doesn't
appear to be a particularly common path. but anyway ...

Change-Id: Ic17b239d724a4d69ff414a24be2e8588732bc8dd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agodon't actually resolve frameworks in findLibraries()
Oswald Buddenhagen [Wed, 25 Jul 2012 11:51:26 +0000 (13:51 +0200)]
don't actually resolve frameworks in findLibraries()

the code wouldn't actually *do* anything with them, because it was
completely broken. didn't seem to hurt, so just remove it.
we still need to parse -framework, though, so we don't do funny things
with its possible argument.

Change-Id: Ia3266538612d3314a72f4965ee9c1ea2d3046ac9
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agofix host vs. makefile directory separator mess
Oswald Buddenhagen [Wed, 25 Jul 2012 08:51:44 +0000 (10:51 +0200)]
fix host vs. makefile directory separator mess

the system path separator and shell are bound to the host system
(system() will use cmd even on mingw with sh.exe in path).
the makefiles otoh may depend on what the qmakespec defines.

consequently, add $$system_path() and $$system_quote() (for use with
system() & $$system()). $$native_path() is renamed to $$shell_path() and
should be used with $$shell_quote() to produce command lines in
makefiles.
$$QMAKE_DIR_SEP needs to be applied to Option::dir_sep right after
parsing the spec, so it is available to $$shell_{path,quote}().

Change-Id: If3db4849e7f96068cf03a32348a24f3a72d6292c
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
11 years agoMake 'nmake qmake' work with the stub (fast) Makefiles
Thiago Macieira [Fri, 27 Jul 2012 13:39:49 +0000 (15:39 +0200)]
Make 'nmake qmake' work with the stub (fast) Makefiles

Without this, if you ran 'nmake qmake' or 'jom qmake' in qtbase's
top directory, it would simply tell you that 'qmake' was up to date.
After all, there is a directory called 'qmake' there.

Change-Id: I6cdb405e8106c137ecbab27923e524b924b19c84
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
11 years agoWork on the QWidget-autotest.
Friedemann Kleint [Thu, 26 Jul 2012 12:04:09 +0000 (14:04 +0200)]
Work on the QWidget-autotest.

- Introduce smart pointers to delete widgets and resources
  to ensure tests are not affected by left-over widgets
  also in case of failure.
- Replace deprecated QTest::qWaitForWindowShown() by
  QTest::qWaitForWindowExposed() and use QVERIFY,
  remove some hard-coded timeouts.
- Set some titles and object names.
- Add verbose debug output of event lists in tests
  childEvents.
- Set minimum sizes on widgets to avoid Windows warnings.
- Stabilize GDIWidget, trigger on first event only.

Change-Id: I64119a2e7113e4a9f0156d00c72ce0935d03bb81
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoQDebug: Add getter/setter for auto-insert-spaces.
David Faure [Fri, 27 Jul 2012 11:53:16 +0000 (13:53 +0200)]
QDebug: Add getter/setter for auto-insert-spaces.

This is useful for inserting a string without space-handling, given that
dbg.nospace() followed by dbg.space() inserts a space.

It's also useful for QDebug operators for custom types, so that they
can disable space handling and then restore to whatever it was before
(rather than forcing it to space() mode).

Change-Id: I9d72e9ffbcbc581ed093168752c29af924405b33
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoQDebug: adjust documentation of space(), nospace() and maybeSpace()
David Faure [Fri, 27 Jul 2012 12:20:42 +0000 (14:20 +0200)]
QDebug: adjust documentation of space(), nospace() and maybeSpace()

Reality is that they control a "current mode" in the stream, not a
"bool that remembers if the last character was a space".

Change-Id: Ic907c34bcb458039b73ddff48021e19f0c24c78c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoCorrect method name referred to in QFont's detailed description.
Mitch Curtis [Fri, 27 Jul 2012 08:58:17 +0000 (10:58 +0200)]
Correct method name referred to in QFont's detailed description.

The detailed description of the QFont class reference contains
the wrong method name (and link) setPointSizeFloat().
This change replaces it with the correct name: setPointSizeF().

Task-number: QTBUG-15536
Change-Id: Ieb2e398b8e1d0b637a6bac16a3ec48522c5dddc1
Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>
11 years agoqdoc: Updated qdoc manual and qdoc guide
Martin Smith [Fri, 27 Jul 2012 10:22:05 +0000 (12:22 +0200)]
qdoc: Updated qdoc manual and qdoc guide

These documents now include the \qmltype and
\instantiates commands, and the \qmlclass command
is deprecated.

Task nr: QTBUG-26648

Change-Id: I62da273be51609e651e33b9088e1667e4c6c1e76
Reviewed-by: Jerome Pasion <jerome.pasion@nokia.com>
11 years agomerge QMAKE_LIBDIR into QMAKE_LIBS early
Oswald Buddenhagen [Mon, 16 Jul 2012 12:29:48 +0000 (14:29 +0200)]
merge QMAKE_LIBDIR into QMAKE_LIBS early

dealing with the directories separately doesn't buy us anything. it's
easier to mix them into the libs, as that contains some paths, too, both
in projects and in prl files.

this brings the windows generators in line with the unix ones.

Change-Id: I1f58f7edd8e21d28bfabf04384bac2e315aaf446
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agounifiy initialization of QMAKE_LIBS{,_PRIVATE} among windows generators
Oswald Buddenhagen [Mon, 16 Jul 2012 12:04:50 +0000 (14:04 +0200)]
unifiy initialization of QMAKE_LIBS{,_PRIVATE} among windows generators

Change-Id: Ib24ec6e290bfb277232c2483768c1b863f961462
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoclean up fixTargetExt()
Oswald Buddenhagen [Mon, 16 Jul 2012 11:02:57 +0000 (13:02 +0200)]
clean up fixTargetExt()

there doesn't appear to be a point in having the function virtual; the
part in the mingw generator can be inlined somewhere else just fine.

Change-Id: I50d66d505095b43fce601928c6240a684389a4b7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agode-virtualize some more functions
Oswald Buddenhagen [Mon, 16 Jul 2012 10:48:22 +0000 (12:48 +0200)]
de-virtualize some more functions

they are not re-implemented anywhere

Change-Id: I444a967bb39ec6b5994747c9fa3f605b4c53ce4f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agodispose of QMAKE_LIBDIR_FLAGS, "demote" QMAKE_FRAMEWORKPATH_FLAGS
Oswald Buddenhagen [Fri, 13 Jul 2012 11:16:39 +0000 (13:16 +0200)]
dispose of QMAKE_LIBDIR_FLAGS, "demote" QMAKE_FRAMEWORKPATH_FLAGS

merge their content as early as possible into QMAKE_LIBS. that's where
they ultimately end up anyway, and this approach is way simpler.
QMAKE_FRAMEWORKPATH_FLAGS is also used for the compiler flags, so it
remains as such in this second function.

Change-Id: Idc3ba4a9b2569fce3252d5f5ddc3f6ebf93650cf
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agoremove duplicate -L flags in findLibraries()
Oswald Buddenhagen [Fri, 13 Jul 2012 11:09:30 +0000 (13:09 +0200)]
remove duplicate -L flags in findLibraries()

unlike duplicated -l options, duplicated -L options are really redundant.

Change-Id: I4fa42d8ee2f10c6e6263457d9bb97291e13685ef
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agounify handling of non-standard linker -L flags
Oswald Buddenhagen [Fri, 13 Jul 2012 11:08:26 +0000 (13:08 +0200)]
unify handling of non-standard linker -L flags

findLibraries() now consistently expands to the linker-specific syntax,
and processPrlFiles() expects that syntax.

Change-Id: Ifd7b51d01378c91d6f2b132aca33629f21ca72f9
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
11 years agomake sure that the stale header removal works the first time around
Oswald Buddenhagen [Tue, 17 Jul 2012 13:39:54 +0000 (15:39 +0200)]
make sure that the stale header removal works the first time around

sort backwards by ascii, so that the lowercase headers come first -
otherwise the camelcase headers would survive the first round, as they
include the lowercase forwarding headers which were not deleted yet.

Change-Id: Iece2788206d31a11428f38da8d8f9f4d0b6dc992
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agoFix crash in QVariant::canConvert().
Volker Krause [Fri, 27 Jul 2012 08:59:47 +0000 (10:59 +0200)]
Fix crash in QVariant::canConvert().

When containing a QObject (or sub-class) pointer and trying to convert
to a QObject pointer canConvert() did dereference the pointer without
checking for it being null.

Change-Id: Ie274e54f2f817f2b6c5df64504f8af6359b8f38d
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
11 years agofix QVariant qdoc error - mark const QVariant::data_ptr() internal
Jeremy Katz [Thu, 26 Jul 2012 15:16:26 +0000 (17:16 +0200)]
fix QVariant qdoc error - mark const QVariant::data_ptr() internal

Change-Id: I1df93780f271ce06c3aa10c4bdcc1c2a43097b72
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoFix QUrlQuery qdoc errors
Jeremy Katz [Thu, 26 Jul 2012 15:09:08 +0000 (17:09 +0200)]
Fix QUrlQuery qdoc errors

Add missing documentation for toString() and operator!=
Mark data_ptr() and associated typedef internal
and some qdoc tag usage issues

Change-Id: I0ad5a2c767fb742d9a86ae259c0c11a0f5db64b4
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoIntroduce QTypeInfoMerger.
Jędrzej Nowacki [Mon, 4 Jun 2012 14:52:32 +0000 (16:52 +0200)]
Introduce QTypeInfoMerger.

QTypeInfoMerger class was created to allow "inheriting" QTypeInfo
traits. The class implementation was based on the QTypeInfo<QPair<>>
specialization, therefore the specialization was refactored to
use the new class.

Change-Id: I4ff3e5eac1d55da086dad84274cce2b2c0a721be
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoexamples: fixed compile with -no-widgets
Rohan McGovern [Thu, 26 Jul 2012 06:29:13 +0000 (16:29 +1000)]
examples: fixed compile with -no-widgets

Disable a few examples depending on widgets which had previously been
missed.

Change-Id: Ic9c7cda94f690ee9d541c742997b7db9ace40fe0
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
11 years agoImplement implicit constructors for built-in classes.
Stephen Kelly [Tue, 24 Jul 2012 14:10:52 +0000 (16:10 +0200)]
Implement implicit constructors for built-in classes.

Change-Id: I6b0b104bc1da3252d014615c50b81830de42e722
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
11 years agoDescribe an example usage of stretch in QSizePolicy documentation.
Mitch Curtis [Wed, 25 Jul 2012 12:57:20 +0000 (14:57 +0200)]
Describe an example usage of stretch in QSizePolicy documentation.

Martin Pejcoch suggested QSizePolicy's setVerticalStretch and
setHorizontalStretch functions be better documented. This change
gives sample usages.

Task-number: QTBUG-18373
Change-Id: I54da8605f5e9e5f405c145b78865402baf78eee7
Reviewed-by: Martin Pejcoch <martin.pejcoch@nokia.com>
Reviewed-by: Geir Vattekar <geir.vattekar@nokia.com>
11 years agoAdd QCocoaAutoReleasePool to QCocoaMenu::setText
Morten Johan Sorvig [Fri, 25 May 2012 07:40:19 +0000 (09:40 +0200)]
Add QCocoaAutoReleasePool to QCocoaMenu::setText

Change-Id: Ia47d79d400c6c4dcd7a49595f05ddafb5a256fad
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
11 years agofix QMimeDatabase qdoc errors
Jeremy Katz [Thu, 26 Jul 2012 17:31:10 +0000 (19:31 +0200)]
fix QMimeDatabase qdoc errors

Some of the \sa lines were missing () after function names.
Document MatchMode and the deprecated mimeTypeForNameAndData()

Change-Id: I468b9741908beb7be5723a8bb927e5418fc1c344
Reviewed-by: David Faure <faure@kde.org>
11 years agoQtNetwork: unbreak QT_NO_SSL build
Marc Mutz [Wed, 25 Jul 2012 23:10:50 +0000 (01:10 +0200)]
QtNetwork: unbreak QT_NO_SSL build

The Q_DECLARE_METATYPE()s were outside of #ifndef QT_NO_SSL for classes
that are defined inside.

Expand the #ifndef block.

Change-Id: I45b73a24032fb2a79fd80d91282b782daa8a8f68
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
11 years agoFix several QUrl qdoc errors
Jeremy Katz [Thu, 26 Jul 2012 12:52:42 +0000 (14:52 +0200)]
Fix several QUrl qdoc errors

Change-Id: I2b89751ed2ec54f3b992c5fc4b39539d521c3404
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoFix position of mouse events generated from touch events.
Andrew den Exter [Thu, 26 Jul 2012 04:25:30 +0000 (14:25 +1000)]
Fix position of mouse events generated from touch events.

In touch event terminology the global position is the screenPos,
scenePos is the windowPos.

Fixes a tst_qdeclarativepincharea test failure in qtquick1.

Change-Id: Ie98fe12be8cbedc9b019913b066e7c4bce75278d
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com>
11 years agoFix MSVC 64bit warnings about truncation from size_t to int.
Friedemann Kleint [Thu, 26 Jul 2012 07:14:26 +0000 (09:14 +0200)]
Fix MSVC 64bit warnings about truncation from size_t to int.

Change-Id: I9aea91aeb9f71817e9cc612d41351dbc98056500
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
11 years agoStabilize tst_QMenu::tearOff().
Friedemann Kleint [Wed, 25 Jul 2012 13:34:47 +0000 (15:34 +0200)]
Stabilize tst_QMenu::tearOff().

Introduce QTRY_VERIFY for frequently failing test.

Change-Id: I38a6420574c4dde20fd7fa484681514543bd70cb
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
11 years agoStabilize tst_QCompleter::QTBUG_14292_filesystem.
Friedemann Kleint [Wed, 25 Jul 2012 13:18:19 +0000 (15:18 +0200)]
Stabilize tst_QCompleter::QTBUG_14292_filesystem.

Make sure the test subdirectories are actually visible
in the file model before the tests start.

Change-Id: If640456bba4362b19d7ad9d9184736c2eb8d3bde
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
11 years agoBase 'FileSystem' test helper class on QTemporaryDir.
Friedemann Kleint [Wed, 25 Jul 2012 09:47:26 +0000 (11:47 +0200)]
Base 'FileSystem' test helper class on QTemporaryDir.

This avoids test instabilities and prevents test directories
from being cluttered with temporary files. Change tests
accordingly. Remove unused createLink() method.

Change-Id: I843c28ab81c8a476c71c5211a7479b22d3d9fc93
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
11 years agoQMetaTypeId2::IsBuiltIn: (new) template meta-function to check for built-in types
Marc Mutz [Fri, 20 Jul 2012 13:46:40 +0000 (15:46 +0200)]
QMetaTypeId2::IsBuiltIn: (new) template meta-function to check for built-in types

This allows to check whether QMetaTypeId2::MetaType exists, and can help
turn run-time into compile-time expressions, even without constexpr support,
or in situations where constexpr can't be used (because you can't overload
on it). This was designed for the QMetaType::registerConversion feature,
but it's much more widely applicable.

Change-Id: Iafa04add04bcb531b3f7fe3e751c7e91ee6a3bc0
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
11 years agoQFileInfo: remove synchronisation macro
Marc Mutz [Tue, 24 Jul 2012 16:00:54 +0000 (18:00 +0200)]
QFileInfo: remove synchronisation macro

Staged after all other modules have removed their
Q_DECLARE_METATYPE(QFileInfo) copies.

Change-Id: I9ac42fcc5f333dd6e8b92c8755610f88cb7267a0
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
11 years agoFixup the plugin documentation
Lars Knoll [Thu, 26 Jul 2012 11:56:14 +0000 (13:56 +0200)]
Fixup the plugin documentation

Move the plugin howto from qtdoc to corelib where
it belongs. Fix the snippets and remove all
remaining references to Q_EXPORT_PLUGIN

Task-number: QTBUG-26237
Change-Id: I43dce2ffa42193b7a992fa1a0f2fcb2f633037b2
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoqdoc: Changed \qmlclass to \qmltype, added \instantiates
Martin Smith [Thu, 26 Jul 2012 08:48:42 +0000 (10:48 +0200)]
qdoc: Changed \qmlclass to \qmltype, added \instantiates

The \qmlclass qdoc command is now deprecated. Use \qmltype instead.
\qmlclass had two arguments, the QML type name and, if the QML type
was elemental, the name of the C++ class that the QML element
instantiates. The \qmltype command has only one argument, the QML type
name.

If the QML type is elemental, then the \qmltype command should be
followed by a \instantiates context command in the same qdoc
comment. e.g.:

\qmltype Item
\instantiates QDeclarativeItem

When the developer does not include the \instantiates command for an
elemental QML type, qdoc will no longer be able to detect that the C++
class name is missing, and qdoc will no longer be able to detect when
the name specified for a \qmlproperty of the elemental QML type has
the wrong name.

Task nr: QTBUG-26648

Change-Id: Ia60872a35113a6f615bfc751ce1e9db6279dfb8e
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoRevert "QDoc: Allow '0' to be used as 2nd arg for \qmlclass."
Casper van Donderen [Thu, 26 Jul 2012 08:05:52 +0000 (10:05 +0200)]
Revert "QDoc: Allow '0' to be used as 2nd arg for \qmlclass."

This reverts commit 50dfd15dcc49d12c5335a37999aef041d7fdfaae.
The change is not necessary anymore, since a new solution using
\instantiates in in the works, having two ways to do exactly the same
thing is not necessary.

Change-Id: I6e139d760372fc6177023c470850418b2385fccd
Reviewed-by: Martin Smith <martin.smith@nokia.com>
11 years agoFix some typos.
Frederik Schwarzer [Wed, 25 Jul 2012 20:52:11 +0000 (22:52 +0200)]
Fix some typos.

Change-Id: I3c3c96fbbc19e2a69ac2f22618f15f5262718e50
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoQtNetwork: use nullary version of qRegisterMetaType<T>("T")
Marc Mutz [Fri, 20 Jul 2012 08:56:54 +0000 (10:56 +0200)]
QtNetwork: use nullary version of qRegisterMetaType<T>("T")

Using the nullary version has the advantage that multiple calls
during a program run are much more efficient, since an inlined
atomic is used to store the result. It also ensures that
Q_DECLARE_METATYPE(T) has been used, whereas qRegisterMetaType<T>("T")
will happily register anything. So I've added the macro where it
was missing, or moved it to a central place when it existed
hidden.

In tst_qnetworkreply, this became a bit tricky, because a private
header is conditionally included, so moved the Q_DECLARE_METATYPE()
into a conditional section, too.

Change-Id: I71484523e4277f4697b7d4b2ddc3505375162727
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
11 years agoAdded note to QTransform::isRotating
Ali Akhtarzada [Mon, 23 Jul 2012 12:59:51 +0000 (14:59 +0200)]
Added note to QTransform::isRotating

Rotation of 180 or 360 is treated as a scaling transform

Task-number: QTCREATORBUG-7651

Change-Id: I44077de0a4a90a87d2d9e8499c1920da1ed066c9
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
11 years agoMake the operator| for QUrl with QIncompatibleFlag constexpr.
Stephen Kelly [Wed, 25 Jul 2012 13:46:26 +0000 (15:46 +0200)]
Make the operator| for QUrl with QIncompatibleFlag constexpr.

Change-Id: I7780af7ef0d5e191e2715c40bf0ffbb6d376f1a2
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
11 years agoFix debug and release build for Windows CE
Andreas Holzammer [Wed, 25 Jul 2012 14:19:05 +0000 (16:19 +0200)]
Fix debug and release build for Windows CE

Change-Id: Idc3faa2c65f3e87aadf75c0c79f1581a24aff8ca
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agoRemove usage of deprecated qWaitForWindowShown(QWidget *) method.
Friedemann Kleint [Tue, 24 Jul 2012 12:29:01 +0000 (14:29 +0200)]
Remove usage of deprecated qWaitForWindowShown(QWidget *) method.

Remove usages from autotests with the exception of
widgets/kernel, widgets/widgets and widgets/graphicsview.

Change-Id: I917b2857ed0cd07a6b3dbcd69244f558086c6586
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
11 years agotst_qmetatype: fix two more unused typedefs (GCC 4.8 warning)
Marc Mutz [Wed, 25 Jul 2012 13:27:59 +0000 (15:27 +0200)]
tst_qmetatype: fix two more unused typedefs (GCC 4.8 warning)

Also check the return value of
DefaultValueFactory<QMetaType::Void>::create(), the same way it's
done in testCreateHelper<QMetaType::Void>().

Change-Id: I3e6d7fca4ea74dbe65009f2eb2c64a1b3a370d68
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
11 years agoFix copypasto: iconv -> cups.
Stephen Kelly [Wed, 25 Jul 2012 13:23:46 +0000 (15:23 +0200)]
Fix copypasto: iconv -> cups.

Introduced in eba0efe10ea90dec7a8b1e95017b0203b899af95

Change-Id: I6bfbf884f66057955d62db6266cf11b399edf965
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agoDe-inline QItemEditorCreatorBase destructor.
Stephen Kelly [Tue, 24 Jul 2012 14:22:03 +0000 (16:22 +0200)]
De-inline QItemEditorCreatorBase destructor.

Virtual destructors on public exported API should not be inline.

Change-Id: I05bff0412ac97d2d8bd3cf8944f4fff2cb619f54
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
11 years agoRemove Qt5 to-do remark
Gatis Paeglis [Wed, 20 Jun 2012 08:26:52 +0000 (10:26 +0200)]
Remove Qt5 to-do remark

Removing Qt5 to-do remark since GraphicsView is considered done and this
change is not performance critical.

Task-number: QTBUG-25089
Change-Id: Ib6e59290a628d27d7e623d221e7100f2e11d13f9
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
11 years agofix syntax error in static plugin assembly code
Oswald Buddenhagen [Tue, 24 Jul 2012 12:39:53 +0000 (14:39 +0200)]
fix syntax error in static plugin assembly code

Change-Id: Ib7662c5529432663df06eea509dc3479cea01050
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
11 years agofix syntax error in breakpad support
Oswald Buddenhagen [Tue, 24 Jul 2012 12:38:06 +0000 (14:38 +0200)]
fix syntax error in breakpad support

Change-Id: I7964615814377ae4fd9c7da897978100c9294835
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>