platform/upstream/libSkiaSharp.git
9 years agoFold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw
kkinnunen [Fri, 16 Jan 2015 13:04:36 +0000 (05:04 -0800)]
Fold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw

Fold alpha of a save layer call to the subsequent draw call paint, even when
the draw call paint color is already non-opaque.

Comparing the difference of the unoptimized and the optimized call pattern
with all (layer alpha, draw alpha) combinations, this produces
off-by-one pixels ~50% of the time.

Reduces layers of current desk_carsvg.skp (recorded with cross-process
picture image filters allowed) from 122 to 115.

BUG=skia:3119

Review URL: https://codereview.chromium.org/840483005

9 years agoadd gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org...
reed [Fri, 16 Jan 2015 13:01:16 +0000 (05:01 -0800)]
add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/)"

fixed memory leak

This reverts commit 04f07fcbfddbe8ca97d29053554a01c66d44ece2.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/854163002

9 years agoUpdate SKP version
skia.buildbots [Fri, 16 Jan 2015 12:44:24 +0000 (04:44 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/855003003

9 years agoRevert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview...
mtklein [Fri, 16 Jan 2015 03:11:55 +0000 (19:11 -0800)]
Revert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview.chromium.org/805643004/)

Reason for revert:
fixed!

Original issue's description:
> Add temporary blacklist debugging.
>
> Not sure why blacklists don't seem to work on bots.  They look right.
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f77156e1925cd5d5504070fe5533a4c456732c1b

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/851903003

9 years agoRevert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromi...
mtklein [Fri, 16 Jan 2015 02:36:07 +0000 (18:36 -0800)]
Revert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/)

Reason for revert:
==31530==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 224 byte(s) in 2 object(s) allocated from:
    #0 0x7febb223f65b in operator new(unsigned long) (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x35865b)
    #1 0x7febb3483c56 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:9
    #2 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
    #3 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
    #4 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
    #5 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
    #6 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
    #7 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
    #8 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
    #9 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
    #10 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311

Indirect leak of 699528 byte(s) in 2 object(s) allocated from:
    #0 0x7febb22214ab in __interceptor_malloc (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x33a4ab)
    #1 0x7febb473e3c6 in sk_malloc_flags(unsigned long, unsigned int) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:54:15
    #2 0x7febb473e19a in sk_malloc_throw(unsigned long) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:40:12
    #3 0x7febb3483c94 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:18
    #4 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
    #5 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
    #6 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
    #7 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
    #8 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
    #9 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
    #10 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
    #11 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
    #12 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311

Original issue's description:
> add gm to show miplevels
>
> BUG=skia:
> TBR=
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/a598f4b773f066a939e0216a116c179b90550727

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/854103004

9 years agoforce a build with fixed --blacklist
mtklein [Fri, 16 Jan 2015 02:28:53 +0000 (18:28 -0800)]
force a build with fixed --blacklist

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/850413003

9 years agoadd gm to show miplevels
reed [Fri, 16 Jan 2015 02:09:15 +0000 (18:09 -0800)]
add gm to show miplevels

BUG=skia:
TBR=

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/849173004

9 years agoAdd temporary blacklist debugging.
mtklein [Fri, 16 Jan 2015 00:21:24 +0000 (16:21 -0800)]
Add temporary blacklist debugging.

Not sure why blacklists don't seem to work on bots.  They look right.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/805643004

9 years agonewlines after failures
mtklein [Thu, 15 Jan 2015 23:47:33 +0000 (15:47 -0800)]
newlines after failures

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/853123003

9 years agoTotally serialize gpu tests on Windows.
mtklein [Thu, 15 Jan 2015 22:20:41 +0000 (14:20 -0800)]
Totally serialize gpu tests on Windows.

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/845193006

9 years agoTurn back on image and subset sources now that they're blacklisted on Android.
mtklein [Thu, 15 Jan 2015 21:58:56 +0000 (13:58 -0800)]
Turn back on image and subset sources now that they're blacklisted on Android.

To land after https://codereview.chromium.org/850403002/

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/857483003

9 years agoDM: add basic --blacklist <config> <srcType> <name> functionality.
mtklein [Thu, 15 Jan 2015 21:44:22 +0000 (13:44 -0800)]
DM: add basic --blacklist <config> <srcType> <name> functionality.

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/817573005

9 years agoremove suppressions (CL was reverted)
reed [Thu, 15 Jan 2015 21:02:03 +0000 (13:02 -0800)]
remove suppressions (CL was reverted)

BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True

Review URL: https://codereview.chromium.org/837633007

9 years agoturn back on gpu tests
mtklein [Thu, 15 Jan 2015 20:46:02 +0000 (12:46 -0800)]
turn back on gpu tests

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/817573004

9 years agoRevert "choose better mip level"
reed [Thu, 15 Jan 2015 20:37:30 +0000 (12:37 -0800)]
Revert "choose better mip level"

This reverts commit 09544fcf9611be6efc0c38ab9d9a3f82181341fb.

BUG=skia:
TBR=
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/849173003

9 years agoRemove obsolete mac_gpu
sergiyb [Thu, 15 Jan 2015 20:33:04 +0000 (12:33 -0800)]
Remove obsolete mac_gpu

BUG=chromium:426897
R=kbr@google.com,phajdan@google.com,reed@google.com

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/812963003

9 years agoSketch DM refactor.
mtklein [Thu, 15 Jan 2015 18:56:12 +0000 (10:56 -0800)]
Sketch DM refactor.

BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

Review URL: https://codereview.chromium.org/788243008

9 years agoMove XferEffects class to GrCustomXfermode file
egdaniel [Thu, 15 Jan 2015 18:52:32 +0000 (10:52 -0800)]
Move XferEffects class to GrCustomXfermode file

BUG=skia:

Review URL: https://codereview.chromium.org/844913003

9 years agoSkPictureShader should handle negative scaling gracefully.
fmalita [Thu, 15 Jan 2015 18:45:56 +0000 (10:45 -0800)]
SkPictureShader should handle negative scaling gracefully.

Let's not choke on inverted tiles.

BUG=chromium:447707
R=robertphillips@google.com,reed@google.com

Review URL: https://codereview.chromium.org/852213002

9 years agoRevert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium...
mtklein [Thu, 15 Jan 2015 18:15:02 +0000 (10:15 -0800)]
Revert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium.org/788243008/)

Reason for revert:
plenty of data

Original issue's description:
> Sketch DM refactor.
>
> BUG=skia:3255
>
>
> I think this supports everything DM used to, but has completely refactored how
> it works to fit the design in the bug.
>
> Configs like "tiles-gpu" are automatically wired up.
>
> I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
> files, a few new files, and one new file that shares a name with a deleted file
> (DM.cpp).
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

TBR=bsalomon@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3255

Review URL: https://codereview.chromium.org/853883004

9 years agomore GMs to rebase?
Mike Klein [Thu, 15 Jan 2015 17:17:14 +0000 (12:17 -0500)]
more GMs to rebase?

TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/789933003

9 years agoSketch DM refactor.
mtklein [Thu, 15 Jan 2015 16:30:25 +0000 (08:30 -0800)]
Sketch DM refactor.

BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/788243008

9 years agothese GM names are ridiculous
Mike Klein [Thu, 15 Jan 2015 16:24:38 +0000 (11:24 -0500)]
these GM names are ridiculous

TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/852193003

9 years agoWhy are we afraid of saveLayer() bounds?
mtklein [Thu, 15 Jan 2015 16:08:10 +0000 (08:08 -0800)]
Why are we afraid of saveLayer() bounds?

They're only hints.  We can ignore them in this optimization.
My only hesitation is that this pattern doesn't seem to happen in our .skps.

BUG=skia:

Review URL: https://codereview.chromium.org/849243002

9 years agochoose better mip level
reed [Thu, 15 Jan 2015 16:01:40 +0000 (08:01 -0800)]
choose better mip level

BUG=skia:

Review URL: https://codereview.chromium.org/845793005

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 15:49:25 +0000 (07:49 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/845873005

9 years agoAdd include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build
egdaniel [Thu, 15 Jan 2015 15:05:02 +0000 (07:05 -0800)]
Add include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build

BUG=skia:

Review URL: https://codereview.chromium.org/852193002

9 years agoUse device-space stroke width for SkDraw::drawRect() quick-reject
fmalita [Thu, 15 Jan 2015 14:01:23 +0000 (06:01 -0800)]
Use device-space stroke width for SkDraw::drawRect() quick-reject

The stroke width needs to be CTM-adjusted when applied to device space
rects.

BUG=skia:3313
R=reed@google.com

Review URL: https://codereview.chromium.org/801353008

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 13:40:51 +0000 (05:40 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/852163002

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 07:06:12 +0000 (23:06 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/855473003

9 years agoRebaseline 6 GMs after crrev.com/841763005
fmalita [Thu, 15 Jan 2015 02:11:17 +0000 (18:11 -0800)]
Rebaseline 6 GMs after crrev.com/841763005

BUG=skia:3299
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/852053004

9 years agoa few ignores for nvprmsaa4
joshualitt [Thu, 15 Jan 2015 00:05:09 +0000 (16:05 -0800)]
a few ignores for nvprmsaa4

TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/850143003

9 years agoupdate images after texture cache change
Brian Salomon [Wed, 14 Jan 2015 22:55:18 +0000 (17:55 -0500)]
update images after texture cache change

Review URL: https://codereview.chromium.org/852913002

9 years agofMaxTexCoords is unused in Release builds
mtklein [Wed, 14 Jan 2015 22:18:54 +0000 (14:18 -0800)]
fMaxTexCoords is unused in Release builds

BUG=skia:

Review URL: https://codereview.chromium.org/853643005

9 years agopossible bug fix for nvpr
joshualitt [Wed, 14 Jan 2015 21:51:18 +0000 (13:51 -0800)]
possible bug fix for nvpr

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/850953003

9 years agoadd sample for filter quality
reed [Wed, 14 Jan 2015 21:16:26 +0000 (13:16 -0800)]
add sample for filter quality

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/788163007

9 years agoAdd Arithmetic mode xp.
egdaniel [Wed, 14 Jan 2015 20:53:01 +0000 (12:53 -0800)]
Add Arithmetic mode xp.

BUG=skia:

Review URL: https://codereview.chromium.org/837633005

9 years agoseparate out the scaline-choosing to simplify chooseProcs
reed [Wed, 14 Jan 2015 20:28:22 +0000 (12:28 -0800)]
separate out the scaline-choosing to simplify chooseProcs

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/796063007

9 years agofix link reference in docs
jcgregorio [Wed, 14 Jan 2015 20:03:01 +0000 (12:03 -0800)]
fix link reference in docs

BUG=skia:
NOTRIES=1
TBR=halcanary

Review URL: https://codereview.chromium.org/853703003

9 years agoAdd reference material for the style of markdown we use.
jcgregorio [Wed, 14 Jan 2015 19:26:29 +0000 (11:26 -0800)]
Add reference material for the style of markdown we use.

Preview here: http://skiadocs.com:8000/dev/tools/markdown?cl=853493004

Note that the image won't show up, that's a known issue with the way patching in CLs works.

BUG=skia:

Review URL: https://codereview.chromium.org/853493004

9 years agoMove Gpu ArithmeticMode xfer effect to _gpu files.
egdaniel [Wed, 14 Jan 2015 18:49:18 +0000 (10:49 -0800)]
Move Gpu ArithmeticMode xfer effect to _gpu files.

BUG=skia:

Review URL: https://codereview.chromium.org/827163004

9 years agoMake uncached textures uncached from the get go.
bsalomon [Wed, 14 Jan 2015 18:42:08 +0000 (10:42 -0800)]
Make uncached textures uncached from the get go.

This avoids the problem of a newly created uncached texture causing a purge of cached resources.

BUG=chromium:445885

Review URL: https://codereview.chromium.org/846303002

9 years agoAdd repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy
robertphillips [Wed, 14 Jan 2015 17:44:02 +0000 (09:44 -0800)]
Add repro GM for  GPU clipped-AA vs. non-AA drawRect discrepancy

In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.

BUG=423834

Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff

Review URL: https://codereview.chromium.org/839883003

9 years agoDM can see into src/gpu. No need for relative include.
mtklein [Wed, 14 Jan 2015 17:25:01 +0000 (09:25 -0800)]
DM can see into src/gpu.  No need for relative include.

BUG=skia:

Review URL: https://codereview.chromium.org/853613004

9 years agoRemove self-assignment in a test.
mtklein [Wed, 14 Jan 2015 16:49:10 +0000 (08:49 -0800)]
Remove self-assignment in a test.

BUG=skia:

Review URL: https://codereview.chromium.org/853723002

9 years agoMore changes to bring together path / geo procs
joshualitt [Wed, 14 Jan 2015 16:12:47 +0000 (08:12 -0800)]
More changes to bring together path / geo procs

BUG=skia:

Review URL: https://codereview.chromium.org/820783005

9 years agoSwitch to a more complete method of filtering hoisted layers
robertphillips [Wed, 14 Jan 2015 16:08:21 +0000 (08:08 -0800)]
Switch to a more complete method of filtering hoisted layers

Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992

Review URL: https://codereview.chromium.org/842323003

9 years agoDo some minor pre cleanup work before converting all xfermodes to XPs.
egdaniel [Wed, 14 Jan 2015 16:05:11 +0000 (08:05 -0800)]
Do some minor pre cleanup work before converting all xfermodes to XPs.

BUG=skia:

Review URL: https://codereview.chromium.org/853543003

9 years agoupstream hooking into google3 crash handler for better stacktraces
mtklein [Wed, 14 Jan 2015 14:38:28 +0000 (06:38 -0800)]
upstream hooking into google3 crash handler for better stacktraces

BUG=skia:

Review URL: https://codereview.chromium.org/821643006

9 years agoUpdate SKP version
skia.buildbots [Wed, 14 Jan 2015 13:14:15 +0000 (05:14 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/812283007

9 years agoupstream google3 include paths for jsoncpp
mtklein [Wed, 14 Jan 2015 13:02:39 +0000 (05:02 -0800)]
upstream google3 include paths for jsoncpp

BUG=skia:

No public API changes
TBR=reed@google.com

Review URL: https://codereview.chromium.org/853613002

9 years agoRemove incremental draw optimization from SkDebugCanvas
kkinnunen [Wed, 14 Jan 2015 07:09:19 +0000 (23:09 -0800)]
Remove incremental draw optimization from SkDebugCanvas

The SkDebugCanvas can be (or is currently) being used to draw to multiple
different canvases. If this use-case is intended, then storing draw
-related state in the canvas causes bugs.

Remove incremental draw from SkDebugCanvas. It can only optimize the
case where draw command index is advanced, no other changes are done
and no visualization is used. This case is not that critical, as it
happens only once per new frame at most. It causes bugs, because
one SkDebugCanvas is used to draw to multiple canvases.

Leave the draw to canvas in same state as it was passed in.

This fixes the debugger bugs where:
 * Old, stale image would stay on the raster canvas when a new image is
 loaded. Also happened with resizes.

 * Proper image for overdraw filter would be visible only for the first
   frame

Review URL: https://codereview.chromium.org/844493003

9 years agodebugger: SW rasterize the picture only when it changes
kkinnunen [Wed, 14 Jan 2015 06:49:02 +0000 (22:49 -0800)]
debugger: SW rasterize the picture only when it changes

Rasterize the picture only when it changes, not every time
raster widget paints itself.

Removes include SkForceLinking.h while organizing the SkDebuggerGUI.cpp
includes.

This is part of the work trying to remove bugs that come from
SkDebugCanvas stateful draw. Part of the state comes from some
optimization that this tries to reproduce in a different way.

Review URL: https://codereview.chromium.org/839743003

9 years agodelete the dreaded TransitionView
reed [Wed, 14 Jan 2015 03:43:04 +0000 (19:43 -0800)]
delete the dreaded TransitionView

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/850843002

9 years agorebase + ignores
joshualitt [Wed, 14 Jan 2015 02:54:00 +0000 (18:54 -0800)]
rebase + ignores

NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/841873007

9 years agorebase of expectations
joshualitt [Wed, 14 Jan 2015 01:50:27 +0000 (17:50 -0800)]
rebase of expectations

TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/847313002

9 years agofix for winvdows nvpr
joshualitt [Wed, 14 Jan 2015 01:05:03 +0000 (17:05 -0800)]
fix for winvdows nvpr

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/804023005

9 years agoMove most of the transform logic into the primitive processors
joshualitt [Tue, 13 Jan 2015 23:02:10 +0000 (15:02 -0800)]
Move most of the transform logic into the primitive processors

BUG=skia:

Review URL: https://codereview.chromium.org/822423004

9 years agorename blitrow::proc and add (uncalled) hook for colorproc16
reed [Tue, 13 Jan 2015 21:51:00 +0000 (13:51 -0800)]
rename blitrow::proc and add (uncalled) hook for colorproc16

BUG=skia:3302

Review URL: https://codereview.chromium.org/847443003

9 years agoAllow -DGOOGLE3 to bypass our normal platform intrinsic dispatch.
mtklein [Tue, 13 Jan 2015 21:27:25 +0000 (13:27 -0800)]
Allow -DGOOGLE3 to bypass our normal platform intrinsic dispatch.

The current code that pound-includes another define doesn't seem to be working there.

BUG=skia:

No API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/820643005

9 years agofix for FB fetch on nexus 10 ES3.0
joshualitt [Tue, 13 Jan 2015 21:13:59 +0000 (13:13 -0800)]
fix for FB fetch on nexus 10 ES3.0

BUG=skia:3304

Review URL: https://codereview.chromium.org/807143006

9 years agoAdd pageset for ugamsolutions.com
rmistry [Tue, 13 Jan 2015 19:52:28 +0000 (11:52 -0800)]
Add pageset for ugamsolutions.com

BUG=skia:3306
NOTRY=true

Review URL: https://codereview.chromium.org/851743004

9 years agoRevert of Switch to a more complete method of filtering hoisted layers (patchset...
robertphillips [Tue, 13 Jan 2015 18:54:37 +0000 (10:54 -0800)]
Revert of Switch to a more complete method of filtering hoisted layers (patchset #1 id:1 of https://codereview.chromium.org/842323003/)

Reason for revert:
nanobench woes

Original issue's description:
> Switch to a more complete method of filtering hoisted layers
>
> Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992

TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/851773002

9 years agoallow simple
mtklein [Tue, 13 Jan 2015 18:51:36 +0000 (10:51 -0800)]
allow simple

BUG=skia:

Review URL: https://codereview.chromium.org/824753006

9 years agoSwitch to a more complete method of filtering hoisted layers
robertphillips [Tue, 13 Jan 2015 18:37:55 +0000 (10:37 -0800)]
Switch to a more complete method of filtering hoisted layers

Review URL: https://codereview.chromium.org/842323003

9 years agonamespace {} trick for SK_DECLARE_STATIC_ONCE
mtklein [Tue, 13 Jan 2015 16:40:23 +0000 (08:40 -0800)]
namespace {} trick for SK_DECLARE_STATIC_ONCE

Like all our other SK_DECLARE_STATIC_*, it's usually not a thread-safe
thing to put inside a function.  Adding namespace {} prevents that
syntactically.

Needs https://codereview.chromium.org/841263004/ to land first.

BUG=chromium:447890

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/806473006

9 years agoHide ARM assembly memset symbols.
torne [Tue, 13 Jan 2015 16:37:34 +0000 (08:37 -0800)]
Hide ARM assembly memset symbols.

Prevent these symbols from being exported from any library which
includes skia by marking them .hidden, as they are implementation
details of skia.

BUG=skia:3303

Review URL: https://codereview.chromium.org/831663004

9 years agoSimplify SkInstCnt
mtklein [Tue, 13 Jan 2015 16:22:43 +0000 (08:22 -0800)]
Simplify SkInstCnt

This code requires fewer macros to use it (just one), has less code in macro
definitions, and has simpler synchronization code (just atomic ints, no SkOnce,
no SkMutex, etc.)

A minor downside, we lose indentation and reverse-ordering in the final report:
  Leaked SkRefCntBase: 7
     Leaked SkFontMgr: 1
     Leaked SkWeakRefCnt: 1
         Leaked SkTypeface: 1
     Leaked SkFlattenable: 3
         Leaked SkXfermode: 3
     Leaked SkPathRef: 1
     Leaked SkPixelRef: 1
         Leaked SkMallocPixelRef: 1
becomes
  Leaked SkXfermode: 3
  Leaked SkMallocPixelRef: 1
  Leaked SkPixelRef: 1
  Leaked SkPathRef: 1
  Leaked SkFlattenable: 3
  Leaked SkTypeface: 1
  Leaked SkWeakRefCnt: 1
  Leaked SkFontMgr: 1
  Leaked SkRefCntBase: 7

This is motivated by wanting to land https://codereview.chromium.org/806473006/,
which makes sure all static use of SkOnce are in global scope.  The current
implementation of SkInstCnt uses them in function scope, which isn't safe.
BUG=skia:

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/841263004

9 years agoGeneric PDF shader fallback
fmalita [Tue, 13 Jan 2015 16:06:11 +0000 (08:06 -0800)]
Generic PDF shader fallback

Instead of ignoring unsupported shaders (and essentially filling with
solid black), convert them to bitmap shaders using on-the-fly
rasterization.

BUG=skia:3299
R=reed@google.com,halcanary@google.com

Review URL: https://codereview.chromium.org/841763005

9 years agoIn SkPDFDocument::emitPDF(), stop pre-calculating file offsets.
halcanary [Tue, 13 Jan 2015 15:12:57 +0000 (07:12 -0800)]
In SkPDFDocument::emitPDF(), stop pre-calculating file offsets.

* Add Streamer utility class which measures the current
  pdf offset by calling SkWStream::bytesWritten(). Calls
  SkPDFCatalog::setFileOffset() and SkPDFObject::emit() at
  the same time to guarantee that everything works out.

* SkPDFCatalog::setFileOffset() no longer calculates the
  object's size.

* SkPDFCatalog::setSubstituteResourcesOffsets() removed.

* SkPDFCatalog::emitSubstituteResources() removed and
  getSubstituteList() made public in its place.

* Remove SkPDFPage::getPageSize and SkPDFPage::emitPage.
  Replace with SkPDFPage::getContentStream().

* SkPDFObject::getOutputSize no longer virtual, only used in
  unit tests.  All SkPDFObject subclasses getOutputSize()
  overrides removed.

* SkPDFObject::getIndirectOutputSize removed.

* PDFPrimitivesTest updated for new functions.

Review URL: https://codereview.chromium.org/846023003

9 years agoUpdate SKP version
skia.buildbots [Tue, 13 Jan 2015 12:26:37 +0000 (04:26 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/819403005

9 years agoremove NewTexture?
reed [Tue, 13 Jan 2015 12:00:55 +0000 (04:00 -0800)]
remove NewTexture?

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/831323005

9 years agoRevert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy (patchset #2 id:20001...
robertphillips [Tue, 13 Jan 2015 02:26:01 +0000 (18:26 -0800)]
Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy (patchset #2 id:20001 of https://codereview.chromium.org/839883003/)

Reason for revert:
This CL introduces rendering conflicts with hairlines (i.e., the hairlines get overwritten). These conflicts are particularly visible on the following GMs (for the Ubuntu and Android gpu configs):

coloremoji & complexclip2_rrect_bw

Original issue's description:
> Fix GPU clipped-AA vs. non-AA drawRect discrepancy
>
> In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff

TBR=bsalomon@google.com,jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=423834

Review URL: https://codereview.chromium.org/847033002

9 years agoFix GPU clipped-AA vs. non-AA drawRect discrepancy
robertphillips [Mon, 12 Jan 2015 23:50:38 +0000 (15:50 -0800)]
Fix GPU clipped-AA vs. non-AA drawRect discrepancy

In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.

BUG=423834

Review URL: https://codereview.chromium.org/839883003

9 years agoSIMPLE_GM generates less code
halcanary [Mon, 12 Jan 2015 23:27:46 +0000 (15:27 -0800)]
SIMPLE_GM generates less code

Review URL: https://codereview.chromium.org/811703005

9 years agoChange function signature of SkPDFObject::emitObject.
halcanary [Mon, 12 Jan 2015 18:07:50 +0000 (10:07 -0800)]
Change function signature of SkPDFObject::emitObject.

Replace virutal SkPDFObject::emitObject(s, c, true) with non-virtual
SkPDFObject::emitIndirectObject(s, c), since none of the subclasses do
(or should do) anything different.

Replace object->emitObject(s, c, false) with object->emitObject(s, c)

This is one step in simplifying the SkPDFObject interface to allow for
the next step in refactoring.

Review URL: https://codereview.chromium.org/827733004

9 years agoFix overlap test for 64-bit pointers in SkMatrix
qiankun.miao [Mon, 12 Jan 2015 15:50:25 +0000 (07:50 -0800)]
Fix overlap test for 64-bit pointers in SkMatrix

BUG=skia:3297

Review URL: https://codereview.chromium.org/803493008

9 years agoRemove SK_SUPPORT_LEGACY_GRADIENT_PRECISION
fmalita [Mon, 12 Jan 2015 14:20:39 +0000 (06:20 -0800)]
Remove SK_SUPPORT_LEGACY_GRADIENT_PRECISION

No longer used by Chromium.

BUG=447870
R=reed@google.com

Review URL: https://codereview.chromium.org/824063004

9 years agoUpdate SKP version
skia.buildbots [Mon, 12 Jan 2015 06:29:47 +0000 (22:29 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/846843002

9 years agoUpdate SKP version
skia.buildbots [Sun, 11 Jan 2015 06:58:16 +0000 (22:58 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/828243004

9 years agoadd stroke params to c api
reed [Sun, 11 Jan 2015 01:59:31 +0000 (17:59 -0800)]
add stroke params to c api

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/848553002

9 years agoadd --rasterPDF flag to DM
halcanary [Sat, 10 Jan 2015 19:18:04 +0000 (11:18 -0800)]
add --rasterPDF flag to DM

If no rasterizer is compiled in, this flag does nothing.  Default
value (true) gives the same behavior as before.

Review URL: https://codereview.chromium.org/830333005

9 years agoUpdate SKP version
skia.buildbots [Sat, 10 Jan 2015 07:07:53 +0000 (23:07 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/845093003

9 years agoremove (dead) SK_SUPPORT_LEGACY_DRAWDATA and SK_SUPPORT_LEGACY_CANVAS_VIRTUAL
reed [Fri, 9 Jan 2015 22:17:40 +0000 (14:17 -0800)]
remove (dead) SK_SUPPORT_LEGACY_DRAWDATA and SK_SUPPORT_LEGACY_CANVAS_VIRTUAL

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/844053002

9 years agoDocument some skia perf interesting queries.
jcgregorio [Fri, 9 Jan 2015 18:35:52 +0000 (10:35 -0800)]
Document some skia perf interesting queries.

Preview here: http://skiadocs.com:8000/dev/tools/skiaperf?cl=839303002

BUG=skia:

Review URL: https://codereview.chromium.org/839303002

9 years agoFix up all the easy virtual ... SK_OVERRIDE cases.
mtklein [Fri, 9 Jan 2015 18:06:39 +0000 (10:06 -0800)]
Fix up all the easy virtual ... SK_OVERRIDE cases.

This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases.  We'll have to manually clean up the rest
over time unless I level up in regexes.

for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end

BUG=skia:

Review URL: https://codereview.chromium.org/806653007

9 years agoCan't include SkTypes.h from ports/
Mike Klein [Fri, 9 Jan 2015 17:29:08 +0000 (12:29 -0500)]
Can't include SkTypes.h from ports/

BUG=skia:

Review URL: https://codereview.chromium.org/847533002

9 years agoUse error-checking mutexes in Debug builds.
mtklein [Fri, 9 Jan 2015 17:02:44 +0000 (09:02 -0800)]
Use error-checking mutexes in Debug builds.

Upside:   our deadlock detection is now thread-safe.
Downside: static mutexes on Macs won't have deadlock detection until we drop 10.6.

BUG=skia:3294

Review URL: https://codereview.chromium.org/816833005

9 years agorebaseline after conic change
reed [Fri, 9 Jan 2015 16:36:42 +0000 (08:36 -0800)]
rebaseline after conic change

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/840333002

9 years agoPictureNestingBench: stay in ints.
mtklein [Fri, 9 Jan 2015 16:33:36 +0000 (08:33 -0800)]
PictureNestingBench: stay in ints.

BUG=skia:

Review URL: https://codereview.chromium.org/784173004

9 years agoUpstream custom freetype embolding strength from Android
djsollen [Fri, 9 Jan 2015 16:18:13 +0000 (08:18 -0800)]
Upstream custom freetype embolding strength from Android

BUG=skia:2377

Review URL: https://codereview.chromium.org/839243002

9 years agoRemove SkTileGrid (except for TileGridInfo).
mtklein [Fri, 9 Jan 2015 14:41:48 +0000 (06:41 -0800)]
Remove SkTileGrid (except for TileGridInfo).

TBR=reed@google.com

BUG=skia:3085

Review URL: https://codereview.chromium.org/845623002

9 years agorebaseline NexusPlayer after conic fix
reed [Fri, 9 Jan 2015 14:36:49 +0000 (06:36 -0800)]
rebaseline NexusPlayer after conic fix

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/843063003

9 years agoremove unneeded flags
reed [Fri, 9 Jan 2015 14:09:32 +0000 (06:09 -0800)]
remove unneeded flags

BUG=skia:

Review URL: https://codereview.chromium.org/842203002

9 years agoUpdate SKP version
skia.buildbots [Fri, 9 Jan 2015 07:13:52 +0000 (23:13 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/843933002

9 years agoAdd a favicon for docs.
jcgregorio [Thu, 8 Jan 2015 21:42:13 +0000 (13:42 -0800)]
Add a favicon for docs.

BUG=skia:

Review URL: https://codereview.chromium.org/845593002

9 years agorebaseline after crrev.com/840653002
halcanary [Thu, 8 Jan 2015 20:36:30 +0000 (12:36 -0800)]
rebaseline after crrev.com/840653002

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/838183003

9 years agoModify transparency_check GM to always tile correctly.
halcanary [Thu, 8 Jan 2015 20:11:42 +0000 (12:11 -0800)]
Modify transparency_check GM to always tile correctly.

Review URL: https://codereview.chromium.org/842013002

9 years agoAdd Linux quick start docs
jcgregorio [Thu, 8 Jan 2015 19:28:51 +0000 (11:28 -0800)]
Add Linux quick start docs

Preview: http://skiadocs.com:8000/user/quick/linux?cl=846523002

BUG=skia:

Review URL: https://codereview.chromium.org/846523002

9 years agorebaseline after change to GM:c_gms
reed [Thu, 8 Jan 2015 19:08:36 +0000 (11:08 -0800)]
rebaseline after change to GM:c_gms

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/843843002