Cedric Bail [Fri, 27 Sep 2019 05:19:38 +0000 (14:19 +0900)]
evas: fix memory leak with Efl.Canvas.Vg
Summary:
It is not correct to change the parent and hope that refcount will work
for you. The parent chain is a decision made by the user, not something
a widget can touch. Only ref count are to be used when given an outside
object. As things where not triggering destruction, there was also no
point where the image buffer would be getting to zero and be freed. This
commit also fix this.
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10169
Jaehyun Cho [Fri, 27 Sep 2019 03:21:48 +0000 (23:21 -0400)]
theme: remove efl.track.slider and efl.track2.slider from efl_ui_slider
Summary:
efl_ui_slider does not support popup which shows the current value.
Therefore, efl.track.slider and efl.track2.slider swallows which set the
popup size and position are not required in efl_ui_slider.
Reviewers: zmike, woohyun
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10216
Mike Blumenkrantz [Thu, 26 Sep 2019 22:00:05 +0000 (18:00 -0400)]
evas/object; fix null deref
Summary:
_efl_canvas_object_clipper_prev_reset() derefs obj->cur
CID 1396985
Depends on D10211
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10212
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:59 +0000 (17:59 -0400)]
eio/dir: fix null deref
Summary:
above cases may fail, causing target to be null
CID 1399103
Depends on D10210
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10211
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:54 +0000 (17:59 -0400)]
efl_ui/image fix null derefs
Summary:
CID 1405781, 1405780
Depends on D10209
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10210
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:49 +0000 (17:59 -0400)]
efl_ui/scroll_manager: fix null derefs
Summary:
CID 1405811, 1405804
Depends on D10208
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10209
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:43 +0000 (17:59 -0400)]
efl_ui/table: handle case where table has no items
Summary:
CID 1399086
Depends on D10207
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10208
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:38 +0000 (17:59 -0400)]
ecore_evas/convert: fix div by zero
Summary:
if one is 0, the printf line will divide by it
CID 1403900
Depends on D10206
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10207
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:34 +0000 (17:59 -0400)]
tests/eina: outdent code
Summary:
this is a very important coverity issue.
CID 1400838
Depends on D10205
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10206
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:29 +0000 (17:59 -0400)]
eina/list: move dead code inside corresponding #ifdef
Summary:
this is debug code
CID 1404753, 1404745
Depends on D10204
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10205
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:24 +0000 (17:59 -0400)]
tests/strbuf: call va_end for varargs
Summary: CID 1400792
Reviewers: brunobelo
Reviewed By: brunobelo
Subscribers: brunobelo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10204
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:19 +0000 (17:59 -0400)]
epp: remove extra variable passed in format specifier
Summary: CID 1402674
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10203
Bruno da Silva Belo [Thu, 26 Sep 2019 21:48:20 +0000 (18:48 -0300)]
eolian_cxx: Possible infinite loop, if called.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10200
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment
Depends on D10197
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10199
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23
Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing
ref T8231
Depends on D10196
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10197
Change-Id: I79bb8f1ad664172b1dd136cfc071f20a66a7467e
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles
Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10196
Change-Id: Icf3a44ea37afef6804108971c4a117cd08324cba
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check
Summary:
coverage++
Depends on D10194
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10195
Change-Id: Iac8dddaa348cc08a6cee94090be35b4bc98d91f3
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10194
Change-Id: I21f9bb740ff0316866fd5e0060ef8ed287fa2c97
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10193
Change-Id: I8d39246bf4276ce4a6880f214b36bae422f7d7f7
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10192
Change-Id: Ida519eed1ac99c8ecc7f07e1ba0ce7583d6110d9
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window
Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10014
Change-Id: Ic69aa45cdbf6a9cd125edc32f98b28616af8e709
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window
Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10013
Change-Id: I8d88315a36d8b74e6839d9648f6581a3c3a65875
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window
Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing
Depends on D9899
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10012
Change-Id: Iedae76203dc28ad3e496eeaf300513ae423552d6
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly
Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed
fix T7838
Depends on D10014
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7838
Differential Revision: https://phab.enlightenment.org/D9900
Change-Id: Ife7e3217461e06ef5f711d5ee57cf8587c56c137
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code
Summary:
handle cases where null params could be passed and cause crashes
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9899
Change-Id: I784f393ee7f93fb5b1c914dfb5d79f23a6999847
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const
Change-Id: I9a0442d0d9c8c3e0c801b8f8e2baa38052b528e9
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model
Summary:
stabilzed Efl.Generic_Model
depends on D10188
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10189
Change-Id: I34e7eece539fea71057d1d6e77fffeadddb3cb03
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View
Summary:
Efl.Ui.View is base infrastructure interface of MVVM.
fixes T7578
Reviewers: zmike, cedric, segfaultxavi, bu5hm4n
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7578
Differential Revision: https://phab.enlightenment.org/D10188
Change-Id: Iccf2d4faf276d0e454eaf6e95b8335c5f4a3ed5c
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency
Change-Id: I7f3e09d39d32b8dcb3c35ba1085756acb6b90b54
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Change-Id: I71ea138db0959c178c5d496fcdb4a93bbeaceba8
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events
this is just a button and not the full clickable struct
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.
Reviewers: zmike, segfaultxavi, bu5hm4n
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10186
Change-Id: I036c10c301d223b4cd1cec0c5ae415f5ad2f9ed3
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value
Summary:
When invalid object comes, the return value should be
EINA_FALSE.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10185
Change-Id: Ib2f71f30594bbf02434c6ee4accceb091a65c90d
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10187
Change-Id: Ia7e1f46f9f089afc237557ca64ab857317a20253
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable
Summary:
fixes T7871
fixes T7852
This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.
Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: SanghyeonLee, cedric
Tags: #efl
Maniphest Tasks: T7871, T7852
Differential Revision: https://phab.enlightenment.org/D10184
Change-Id: I734b272411e3fc9ebb79d907f171528849219c10
Radoslaw Cybulski [Fri, 6 Sep 2019 09:54:20 +0000 (11:54 +0200)]
atspi: add stop reading command
Adds stop reading command over dbus, which cancels all quened readings
(including one in progress if any). Additional passed argument, boolean
flag, when set to false limits cancelling only to discardable readings.
Change-Id: I1ff8571edbaf0513da9d710c9eea16846aba62d4
Hosang Kim [Wed, 25 Sep 2019 09:33:00 +0000 (18:33 +0900)]
evas_events: fix usage of last mouse
Change-Id: Ifa21646cf43f969c347ca7fe4127309f2920ddf4
Jongmin Lee [Thu, 26 Sep 2019 21:57:18 +0000 (06:57 +0900)]
build: resolve migration build errors
Change-Id: I588c4a50424c77b980136c89b31a25d28c452c68
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment
Depends on D10197
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10199
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23
Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing
ref T8231
Depends on D10196
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10197
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles
Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10196
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check
Summary:
coverage++
Depends on D10194
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10195
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10194
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10193
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10192
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window
Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10014
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window
Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10013
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window
Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing
Depends on D9899
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10012
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly
Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed
fix T7838
Depends on D10014
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7838
Differential Revision: https://phab.enlightenment.org/D9900
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code
Summary:
handle cases where null params could be passed and cause crashes
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9899
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model
Summary:
stabilzed Efl.Generic_Model
depends on D10188
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10189
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View
Summary:
Efl.Ui.View is base infrastructure interface of MVVM.
fixes T7578
Reviewers: zmike, cedric, segfaultxavi, bu5hm4n
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7578
Differential Revision: https://phab.enlightenment.org/D10188
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events
this is just a button and not the full clickable struct
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.
Reviewers: zmike, segfaultxavi, bu5hm4n
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10186
Change-Id: If8039795398b3681c7329d8103d196d02393612b
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value
Summary:
When invalid object comes, the return value should be
EINA_FALSE.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10185
Change-Id: I3b2434528d68e8570308b25049442d07f4174a86
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10187
Change-Id: I27ae9dcc4030b26ffc124f11a66c4fc7bf1436e9
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable
Summary:
fixes T7871
fixes T7852
This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.
Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: SanghyeonLee, cedric
Tags: #efl
Maniphest Tasks: T7871, T7852
Differential Revision: https://phab.enlightenment.org/D10184
Marcel Hollerbach [Thu, 26 Sep 2019 09:16:24 +0000 (18:16 +0900)]
efl_ui_*selectable: unify these APIs with the same c_prefix
Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.
ref T7871
Reviewers: SanghyeonLee, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7871
Differential Revision: https://phab.enlightenment.org/D10183
SangHyeon Jade Lee [Thu, 26 Sep 2019 08:38:37 +0000 (10:38 +0200)]
efl_ui : add document comment on efl_ui_item_clickable event data
Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10181
Cedric Bail [Thu, 26 Sep 2019 01:59:29 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Item_Clickable.
Summary: Depends on D10177
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10173
Cedric Bail [Thu, 26 Sep 2019 01:59:25 +0000 (21:59 -0400)]
elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Summary: Depends on D10176
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10177
Cedric Bail [Thu, 26 Sep 2019 01:59:20 +0000 (21:59 -0400)]
elementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Summary: Depends on D10175
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10176
Cedric Bail [Thu, 26 Sep 2019 01:59:14 +0000 (21:59 -0400)]
elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Summary: Depends on D10171
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10175
Cedric Bail [Thu, 26 Sep 2019 01:59:09 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Collection_View.
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8261
Differential Revision: https://phab.enlightenment.org/D10171
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:38 +0000 (17:56 -0400)]
api: mark Efl.Ui.Image_Zoomable stable
Summary:
ref T7875
Depends on D10125
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D10126
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:33 +0000 (17:56 -0400)]
api: mark Efl.Gfx.Image_Load_Controller stable
Summary:
fix T7876
Depends on D10124
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7876
Differential Revision: https://phab.enlightenment.org/D10125
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:29 +0000 (17:56 -0400)]
api: mark efl.gfx.image and related types stable
Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7929, T7927, T7926, T7875
Differential Revision: https://phab.enlightenment.org/D10124
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:17 +0000 (17:56 -0400)]
theme: migrate all efl,anim,activate (and similar) signals to efl,state,animation,activated
Summary:
ref T8231
Depends on D10166
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10167
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:11 +0000 (17:56 -0400)]
theme: efl,state,anim,stop -> efl,state,animating,stopped
Summary:
ref T8231
Depends on D10165
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10166
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:06 +0000 (17:56 -0400)]
api: efl,state,busy,(start|stop) -> efl,state,busy,(started|stopped)
Summary:
ref T8231
Depends on D10163
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10165
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:01 +0000 (17:56 -0400)]
theme: remove unused scroller group
Summary:
this is just copied from legacy but not used for anything
ref T8231
Depends on D10162
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10163
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:55 +0000 (17:55 -0400)]
theme: use more explicit signal names for C <- theme scrollbar signals
Summary:
ref T8231
Depends on D10161
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10162
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:50 +0000 (17:55 -0400)]
theme: efl,action,clicked -> efl,action,click
Summary:
action signals should infinitives
ref T8231
Depends on D10160
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10161
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:45 +0000 (17:55 -0400)]
theme: use more explicit signal names for C -> theme scrollbar signals
Summary:
ref T8231
Depends on D10159
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10160
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:40 +0000 (17:55 -0400)]
theme: use 'visible' style signals for spin_button button/entry visibility
Summary:
ref T8231
Depends on D10158
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10159
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:35 +0000 (17:55 -0400)]
theme: efl,state,(content|text),(set|unset) -> efl,(content|text),(set|unset)
Summary:
this is versioned, so the correct signal will always be emitted for the theme
version that is provided
ref T8231
Depends on D10164
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10158
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:29 +0000 (17:55 -0400)]
efl_ui/layout: add mechanism for deferring versioned theme signals
Summary:
the theme version isn't available until the theme has been applied, so
we can create an array of all the pending signals and defer them until
such time as we get a theme or destroy the object
this is internal and can be reworked at a later time as needed
ref T8231
Depends on D10157
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10164
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:24 +0000 (17:55 -0400)]
api: move eo-based radio and check widgets to use selectable signal names
Summary:
this is a more standardized name
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10157
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:19 +0000 (17:55 -0400)]
theme: /efl,orient,(horizontal|vertical)/efl,state,(horizontal|vertical)/
Summary:
these signals aren't actually used by anything, just changing for grep
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10156
WooHyun Jung [Thu, 26 Sep 2019 10:27:09 +0000 (19:27 +0900)]
efl_ui_win: add validation check to return legacy default value
This should be reverted when https://phab.enlightenment.org/D10187
is updated.
@tizen_fix
Change-Id: I990dab1313aebdfde2a8cc1e9b89d2fff0983863
WooHyun Jung [Thu, 26 Sep 2019 10:26:08 +0000 (19:26 +0900)]
efl_ui_image: fix a wrong return value of legacy API
This should be reverted when https://phab.enlightenment.org/D10186
is updated.
@tizen_fix
Change-Id: Ifdfbd9685f13ea428661c3644cd708fac2e8ec3d
WooHyun Jung [Thu, 26 Sep 2019 10:24:24 +0000 (19:24 +0900)]
edje_legacy: add validation check to return legacy default value
This should be reverted when https://phab.enlightenment.org/D10185
is updated
@tizen_fix
Change-Id: I8e42c74420d2cf0ea218ca3ae29d2480663538f1
WooHyun Jung [Thu, 26 Sep 2019 08:11:05 +0000 (17:11 +0900)]
Revert "slider: delete unnecessary tizen only code"
This reverts commit
c8633f099a438b1f99ae94d350b3554b0ded218a.
Change-Id: Ib2e87a3ceeec4fec7d164f9b9aed862873fbee66
Jongmin Lee [Wed, 25 Sep 2019 21:36:28 +0000 (06:36 +0900)]
bulild: resolve build error caused by te use of efl_player_start/stop API
change the use of efl_player_start/stop to efl_player_playing_set
Change-Id: I7ece1dc749716bcd4b4caaa49656e139a07864ce
Cedric Bail [Wed, 25 Sep 2019 15:05:38 +0000 (12:05 -0300)]
ecore: stabilize Efl.Loop_Model
Summary:
T8270
Depends on D10138
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10139
Cedric Bail [Wed, 25 Sep 2019 15:03:27 +0000 (12:03 -0300)]
ecore: stabilize Efl.Composite_Model.
Summary: Depends on D10137
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10138
Cedric Bail [Wed, 25 Sep 2019 15:02:14 +0000 (12:02 -0300)]
elementary: stabilize Efl.Ui.View_Model
Summary:
T8268
Depends on D10136
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10137
Cedric Bail [Wed, 25 Sep 2019 15:00:28 +0000 (12:00 -0300)]
efl: stabilize Efl.Model
Summary:
T8267
Depends on D10135
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10136
Cedric Bail [Wed, 25 Sep 2019 14:59:45 +0000 (11:59 -0300)]
efl: stabilize Efl.Ui.Factory_Bind
Summary:
T8264
Depends on D10134
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10135
projects / platform / upstream / efl.git / log