skia.buildbots [Sat, 31 Jan 2015 07:00:10 +0000 (23:00 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
875243006
bungeman [Sat, 31 Jan 2015 03:58:19 +0000 (19:58 -0800)]
Update dump code in FontConfigParser test.
This code is still quite useful for debugging, but has bit rotted.
Update to match current structure of code.
Review URL: https://codereview.chromium.org/
890073002
bungeman [Fri, 30 Jan 2015 23:35:09 +0000 (15:35 -0800)]
Convert FamilyData to Skia style field names.
The Skia convention is to prefix field names with 'f'.
This change is mostly mechanical.
Review URL: https://codereview.chromium.org/
892733002
bungeman [Fri, 30 Jan 2015 23:24:49 +0000 (15:24 -0800)]
Do not leak FamilyData in Android SkFontMgr.
Currently, it appears one FamilyData is leaking per scanned file.
This also cleans up the hanging currentFamily memory management.
Review URL: https://codereview.chromium.org/
889943005
reed [Fri, 30 Jan 2015 22:54:38 +0000 (14:54 -0800)]
export SkImageInfo
BUG=skia:
Review URL: https://codereview.chromium.org/
893603005
bungeman [Fri, 30 Jan 2015 22:52:58 +0000 (14:52 -0800)]
Do not add indirection to XML_Parser.
The expat type XML_Parser is already a pointer, so pass it by value
instead of by indirection.
Review URL: https://codereview.chromium.org/
880783003
robertphillips [Fri, 30 Jan 2015 22:44:22 +0000 (14:44 -0800)]
Revert of Add device space "nudge" to gpu draws (patchset #6 id:90001 of https://codereview.chromium.org/
877473005/)
Reason for revert:
Blink layout tests this time :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/
2d55d07501c56310f97d2092d789a2bc9fa01b78
>
> Committed: https://skia.googlesource.com/skia/+/
b9329991426d0b77ea194a380d72d73fb855308a
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/
886153002
mtklein [Fri, 30 Jan 2015 21:22:23 +0000 (13:22 -0800)]
Suggestions and merge in the other CL.
I had some suggestions on the subset CL, and took the opportunity to rebase it
against head and merge in the other color type CL.
BUG=skia:
Review URL: https://codereview.chromium.org/
893703002
scroggo [Fri, 30 Jan 2015 21:16:02 +0000 (13:16 -0800)]
Reland "remove unused SkAvoidXfermode"
(patchset #2 id:20001 of https://codereview.chromium.org/
860583002/)
SkAvoidXfermode has been moved into Android, so it is safe to remove.
Review URL: https://codereview.chromium.org/
890893003
brucedawson [Fri, 30 Jan 2015 20:57:50 +0000 (12:57 -0800)]
Disable the noisiest /analyze warning in Chrome. ~3,700/12,000
Decades ago Intel decided that the bsr (Bit Scan Reverse) instruction
should have undefined results if its argument is zero. This probably
makes the instruction harder to implement and it definitely makes it
more difficult to use.
In SkCLZ_portable it requires a check for a zero argument, but despite
that check /analyze still warns that _BitScanReverse might fail
(because it doesn't know what can cause failures). Because this warning
occurs in a frequently included header file it ends up being very noisy,
accounting for ~30% of all warnings (before deduplication).
Suppressing this useless warning will make the raw results easier to
look through.
Review URL: https://codereview.chromium.org/
872673007
bsalomon [Fri, 30 Jan 2015 20:43:44 +0000 (12:43 -0800)]
Move npot resizing out of GrContext and simplify GrContext texture functions.
Review URL: https://codereview.chromium.org/
882223003
caryclark [Fri, 30 Jan 2015 20:37:02 +0000 (12:37 -0800)]
First cut at cleaning up Sergio's example code and moving some common code to SkWindow.
Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot.
Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part.
Review URL: https://codereview.chromium.org/
890873003
mtklein [Fri, 30 Jan 2015 19:42:31 +0000 (11:42 -0800)]
DM: paths as implict strings too.
BUG=skia:
Review URL: https://codereview.chromium.org/
891823002
robertphillips [Fri, 30 Jan 2015 19:24:50 +0000 (11:24 -0800)]
Add device space "nudge" to gpu draws
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Committed: https://skia.googlesource.com/skia/+/
2d55d07501c56310f97d2092d789a2bc9fa01b78
Review URL: https://codereview.chromium.org/
877473005
halcanary [Fri, 30 Jan 2015 19:00:12 +0000 (11:00 -0800)]
DM::NullSink
Motivation: The null sink can act as a control for experiments.
Review URL: https://codereview.chromium.org/
873723007
halcanary [Fri, 30 Jan 2015 17:58:58 +0000 (09:58 -0800)]
dm: allow multiple --images flags, allow single files
Review URL: https://codereview.chromium.org/
872993005
fmalita [Fri, 30 Jan 2015 17:03:29 +0000 (09:03 -0800)]
Initial SVG backend stubbing
This adds SkSVGDevice and a small utility for converting SKP files to SVG (skp2svg).
R=reed@google.com,jcgregorio@google.com
BUG=skia:3368
Review URL: https://codereview.chromium.org/
892533002
scroggo [Fri, 30 Jan 2015 15:34:48 +0000 (07:34 -0800)]
Remove unused globalRef/globalUnref.
BUG=skia:1482
Review URL: https://codereview.chromium.org/
887993003
halcanary [Fri, 30 Jan 2015 15:31:19 +0000 (07:31 -0800)]
dm: allow multiple --skp flags, allow single files
Review URL: https://codereview.chromium.org/
885353002
scroggo [Fri, 30 Jan 2015 15:14:03 +0000 (07:14 -0800)]
Remove unused hasLocalMatrix.
This method is not called anywhere on Android or Chrome, and it
has a FIXME that it may not be correct.
A client can still getLocalMatrix().isIdentity() if they need this
information. (It has the same FIXME, and perhaps we should revisit
it. In the meantime, this convenience method is not needed.)
Review URL: https://codereview.chromium.org/
882443007
halcanary [Fri, 30 Jan 2015 15:00:42 +0000 (07:00 -0800)]
documentation: Writing Unit and Rendering Tests
Review URL: https://codereview.chromium.org/
885133002
scroggo [Fri, 30 Jan 2015 14:19:44 +0000 (06:19 -0800)]
Define SK_OVERRIDE when building for Android framework.
Review URL: https://codereview.chromium.org/
868243003
skia.buildbots [Fri, 30 Jan 2015 06:57:53 +0000 (22:57 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
893513002
herb [Fri, 30 Jan 2015 04:31:04 +0000 (20:31 -0800)]
Start SampleApp documentation
BUG=skia:359
Review URL: https://codereview.chromium.org/
883203003
qiankun.miao [Fri, 30 Jan 2015 02:36:52 +0000 (18:36 -0800)]
Remove always true if statement and commented out code in GrBitmapTextContext
BUG=skia:
Review URL: https://codereview.chromium.org/
873473008
qiankun.miao [Fri, 30 Jan 2015 02:35:25 +0000 (18:35 -0800)]
Clean up commented out code in GrDistanceFieldTextContext
SkCLZ isn't used any more. Just remove it.
BUG=skia:
Review URL: https://codereview.chromium.org/
888533004
scroggo [Thu, 29 Jan 2015 21:52:13 +0000 (13:52 -0800)]
Update comment for SkMallocPixelRef::NewWithProc.
Add a comment about using a NULL ReleaseProc.
BUG=skia:2185
Review URL: https://codereview.chromium.org/
885573005
reed [Thu, 29 Jan 2015 20:59:11 +0000 (12:59 -0800)]
share code between arcTo and addArc, update dox
BUG=skia:
Review URL: https://codereview.chromium.org/
863123005
fmalita [Thu, 29 Jan 2015 20:24:24 +0000 (12:24 -0800)]
Conservative blob bounds cleanup
* drop SK_SUPPORT_LEGACY_BLOB_BOUNDS
* remove horizontal & fully position tight bounds support (always using
conservative bounds now)
* special-case horizontal run bounds logic to avoid unnecessary vertical
min-maxing
R=reed@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/
858153007
reed [Thu, 29 Jan 2015 20:03:58 +0000 (12:03 -0800)]
reorg some path routines, preparing to switch arcs to conics
BUG=skia:
Review URL: https://codereview.chromium.org/
887783002
mtklein [Thu, 29 Jan 2015 20:03:53 +0000 (12:03 -0800)]
Make SkWriter32::snapshotAsData() a dumb copy.
SkWriter32::snapshotAsData() is no longer performance critical.
It's only used when we're serializing to disk.
BUG=skia:2289
Review URL: https://codereview.chromium.org/
875403005
scroggo [Thu, 29 Jan 2015 19:58:51 +0000 (11:58 -0800)]
Remove SkProxyCanvas.
SkProxyCanvas is redundant with SkNWayCanvas, and means another class
we have to keep in sync with the SkCanvas interface.
Remove tests which use an SkProxyCanvas.
Requires a change to chromium.
BUG=skia:3279
BUG=skia:500
Review URL: https://codereview.chromium.org/
886813002
scroggo [Thu, 29 Jan 2015 19:58:45 +0000 (11:58 -0800)]
SkStream::read() only returns 0 at end.
All implementations behave this way, so respect it.
BUG=skia:2936
Review URL: https://codereview.chromium.org/
888703002
reed [Thu, 29 Jan 2015 18:48:16 +0000 (10:48 -0800)]
add new gm for SkPath::addArc()
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
888663002
caryclark [Thu, 29 Jan 2015 18:44:35 +0000 (10:44 -0800)]
remove experimental pixman files
these files have never worked, and contain nother of value
R=reed@google.com
Review URL: https://codereview.chromium.org/
890703002
caryclark [Thu, 29 Jan 2015 18:43:09 +0000 (10:43 -0800)]
The original instantiation of pathops was in the experimental/Intersection directory. Anything of value has been copied into the mainline.
The obsolete gyp files are also included, along with a pixman test that never functioned but accidentally referenced some of these deleted files.
Review URL: https://codereview.chromium.org/
867213004
humper [Thu, 29 Jan 2015 18:26:37 +0000 (10:26 -0800)]
enable subpixel text on the subpixel translate sample
BUG=skia:
Review URL: https://codereview.chromium.org/
885783006
bsalomon [Thu, 29 Jan 2015 18:07:32 +0000 (10:07 -0800)]
Use draws instead of clears as temporary workaround for Qualcomm stencil clear bug
Review URL: https://codereview.chromium.org/
885863003
caryclark [Thu, 29 Jan 2015 17:59:53 +0000 (09:59 -0800)]
fix bit rotted code to create test font
BUG=skia:3080
R=reed@google.com
Review URL: https://codereview.chromium.org/
884873007
jcgregorio [Thu, 29 Jan 2015 17:55:14 +0000 (09:55 -0800)]
Add docs for running docserver locally.
BUG=skia:3346
Review URL: https://codereview.chromium.org/
891483002
caryclark [Thu, 29 Jan 2015 17:45:44 +0000 (09:45 -0800)]
fix parsing SVG strings to paths with comma delimiters
BUG=skia:583
R=reed@google.com
Review URL: https://codereview.chromium.org/
885103002
bsalomon [Thu, 29 Jan 2015 17:34:18 +0000 (09:34 -0800)]
Apply prePathMatrix in SkGpuDevice as view matrix preconcat when possible
BUG=skia:3055
Review URL: https://codereview.chromium.org/
886713006
fmalita [Thu, 29 Jan 2015 15:44:24 +0000 (07:44 -0800)]
More win64 warning fixes.
TBR=bsalomon@google.com
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
887713002
bsalomon [Thu, 29 Jan 2015 15:13:20 +0000 (07:13 -0800)]
Fix win64 warnings.
TBR=joshualitt@google.com
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
884253004
mlee [Thu, 29 Jan 2015 14:22:41 +0000 (06:22 -0800)]
skia: blend32_16_row for neon version
This includes blend32_16_row neon implementation
for aarch32 and aarch64.
For performance,
blend32_16_row is called in following tests in nanobench.
- Xfermode_SrcOver
- tablebench
- rotated_rects_bw_alternating_transparent_and_opaque_srcover
- rotated_rects_bw_changing_transparent_srcover
- rotated_rects_bw_same_transparent_srcover
- luma_colorfilter_large
- luma_colorfilter_small
- chart_bw
I can see perf increase in following two tests, especially. For others, looks
similar.
For each, I tried to run two times.
1) Xfermode_SrcOver
<org>
- D/skia ( 2000): 3M 57 17.3µs 17.4µs 17.4µs 17.7µs 1%
█▃▂▃▂▂▂▁▃▂ 565 Xfermode_SrcOver
- D/skia ( 1915): 3M 70 13.5µs 16.9µs 16.7µs 18.8µs 9%
▆█▄▅█▁▅▅▆▄ 565 Xfermode_SrcOver
<new>
- D/skia ( 2000): 3M 8 11.6µs 11.8µs 12.1µs 14.4µs 7%
▃█▁▁▂▁▁▁▂▂ 565 Xfermode_SrcOver
- D/skia ( 2004): 3M 62 10.3µs 12.9µs 13µs 15.2µs 11%
█▅▅▆▁▅▅▅▇▃ 565 Xfermode_SrcOver
2)
luma_colorfilter_large
<org>
- D/skia ( 2000): 159M 8 136µs 136µs 136µs 139µs 1%
█▃▁▂▁▁▁▁▁▁ 565 luma_colorfilter_large
- D/skia ( 1915): 158M 2 135µs 177µs 182µs 269µs 22%
▆▃█▁▁▃▃▃▃▃ 565 luma_colorfilter_large
<new>
- D/skia ( 2000): 157M 5 84.2µs 85.3µs 87.5µs 110µs 9%
█▁▂▁▁▁▁▁▁▁ 565 luma_colorfilter_large
- D/skia ( 2004): 159M 6 84.7µs 110µs 112µs 144µs 18%
█▄▇▁▁▄▃▄▄▆ 565 luma_colorfilter_large
Review URL: https://codereview.chromium.org/
847363002
robertphillips [Thu, 29 Jan 2015 01:37:33 +0000 (17:37 -0800)]
Revert of Add device space "nudge" to gpu draws (patchset #5 id:70001 of https://codereview.chromium.org/
877473005/)
Reason for revert:
Chrome pixel test :(
Original issue's description:
> Add device space "nudge" to gpu draws
>
> This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
>
> BUG=423834
>
> Committed: https://skia.googlesource.com/skia/+/
2d55d07501c56310f97d2092d789a2bc9fa01b78
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=423834
Review URL: https://codereview.chromium.org/
890433003
robertphillips [Thu, 29 Jan 2015 01:33:45 +0000 (17:33 -0800)]
Revert of Remove 'f' from 0.05f in shader code (patchset #1 id:1 of https://codereview.chromium.org/
888483002/)
Reason for revert:
Chrome pixel test
Original issue's description:
> Remove 'f' from 0.05f in shader code
>
> TBR=bsalomon@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/
1726997861fac8daa8213d1a51d5c8fbe44428d1
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
890433002
mtklein [Wed, 28 Jan 2015 23:32:24 +0000 (15:32 -0800)]
Revert of DM::SKPSrc::size() reports correct size. (patchset #3 id:40001 of https://codereview.chromium.org/
863243005/)
Reason for revert:
Still no good on Chrome OS bot:
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/628/steps/dm/logs/stdio
Original issue's description:
> DM::SKPSrc::size() reports correct size.
>
> Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048.
>
> Motivation:
> Improve PDF testing by printing the entire SKP.
>
> Source: http://crrev.com/
863243004
>
> BUG=skia:3365
>
> Committed: https://skia.googlesource.com/skia/+/
441b10eac09a1f44983e35da827a6b438a409e63
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot,Test-ChromeOS-Alex-GMA3150-x86-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
d4dd58e43ca4551531ad6a9f54bfc5632ea45a80
TBR=halcanary@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3365
Review URL: https://codereview.chromium.org/
886543005
robertphillips [Wed, 28 Jan 2015 23:19:53 +0000 (15:19 -0800)]
Remove 'f' from 0.05f in shader code
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
888483002
robertphillips [Wed, 28 Jan 2015 22:41:57 +0000 (14:41 -0800)]
Add device space "nudge" to gpu draws
This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too.
BUG=423834
Review URL: https://codereview.chromium.org/
877473005
hcm [Wed, 28 Jan 2015 22:16:43 +0000 (14:16 -0800)]
authors update- add herb and reorganize
BUG=skia:
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
881993002
herb [Wed, 28 Jan 2015 22:12:12 +0000 (14:12 -0800)]
Make char hash dynamic when needed.
BUG=skia:
Review URL: https://codereview.chromium.org/
880383002
mtklein [Wed, 28 Jan 2015 21:59:42 +0000 (13:59 -0800)]
DM::SKPSrc::size() reports correct size.
Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048.
Motivation:
Improve PDF testing by printing the entire SKP.
Source: http://crrev.com/
863243004
BUG=skia:3365
Committed: https://skia.googlesource.com/skia/+/
441b10eac09a1f44983e35da827a6b438a409e63
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot
Review URL: https://codereview.chromium.org/
863243005
reed [Wed, 28 Jan 2015 21:28:53 +0000 (13:28 -0800)]
Use murmur3 finisher to improve font hash efficiency.
Add dump() method to inspect glyphcache strikes.
Murmur addition improves hash efficient roughly 50%
BUG=skia:
Review URL: https://codereview.chromium.org/
877113002
sugoi [Wed, 28 Jan 2015 21:15:32 +0000 (13:15 -0800)]
Fixed clusterfuzz issue
BUG=448423
Review URL: https://codereview.chromium.org/
881423002
jvanverth [Wed, 28 Jan 2015 21:08:40 +0000 (13:08 -0800)]
Use distance fields for glyphs > 256 pt, before switching to paths.
BUG=452313
Review URL: https://codereview.chromium.org/
862403004
joshualitt [Wed, 28 Jan 2015 20:53:54 +0000 (12:53 -0800)]
GrBatchPrototype
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
d15e4e45374275c045572b304c229237c4a82be4
Committed: https://skia.googlesource.com/skia/+/
d5a7db4a867c7e6ccf8451a053d987b470099198
Review URL: https://codereview.chromium.org/
845103005
mtklein [Wed, 28 Jan 2015 20:04:08 +0000 (12:04 -0800)]
Revert of DM::SKPSrc::size() reports correct size. (patchset #1 id:1 of https://codereview.chromium.org/
863243005/)
Reason for revert:
OOM on 32-bit machines.
Original issue's description:
> DM::SKPSrc::size() reports correct size.
>
> Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048.
>
> Motivation:
> Improve PDF testing by printing the entire SKP.
>
> Source: http://crrev.com/
863243004
>
> BUG=skia:3365
>
> Committed: https://skia.googlesource.com/skia/+/
441b10eac09a1f44983e35da827a6b438a409e63
TBR=halcanary@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3365
Review URL: https://codereview.chromium.org/
884743003
halcanary [Wed, 28 Jan 2015 19:45:58 +0000 (11:45 -0800)]
DM::PDFSink::draw excercises multi-page pdf
BUG=skia:3365
Review URL: https://codereview.chromium.org/
881343002
reed [Wed, 28 Jan 2015 19:44:48 +0000 (11:44 -0800)]
add more checks for computing clamp counts, remove dead code
BUG=448299
Review URL: https://codereview.chromium.org/
886473003
bsalomon [Wed, 28 Jan 2015 19:39:48 +0000 (11:39 -0800)]
Fix wrapped content keys for npot textures.
Review URL: https://codereview.chromium.org/
879193002
mtklein [Wed, 28 Jan 2015 19:35:18 +0000 (11:35 -0800)]
Fold gmtoskp into DM, as --src gm --config skp.
BUG=skia:
Review URL: https://codereview.chromium.org/
885733002
mtklein [Wed, 28 Jan 2015 19:12:25 +0000 (11:12 -0800)]
DM::SKPSrc::size() reports correct size.
Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048.
Motivation:
Improve PDF testing by printing the entire SKP.
Source: http://crrev.com/
863243004
BUG=skia:3365
Review URL: https://codereview.chromium.org/
863243005
joshualitt [Wed, 28 Jan 2015 19:08:00 +0000 (11:08 -0800)]
dstread gm
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
883053002
senorblanco [Wed, 28 Jan 2015 19:01:06 +0000 (11:01 -0800)]
Add a flag to flush the canvases during SkMultiPictureDraw::draw().
This is necessary for multisampling, so that each multisampled render
target resolves before Chrome's compositor attempts to draw the
texture.
BUG=skia:
Review URL: https://codereview.chromium.org/
878653004
fmalita [Wed, 28 Jan 2015 18:56:06 +0000 (10:56 -0800)]
Conservative SkTextBlob bounds.
Compute cheaper/more conservative text blob bounds based on the typeface
maximum glyph bbox.
BUG=chromium:451401
R=reed@google.com,bungeman@google.com
Review URL: https://codereview.chromium.org/
886473002
skia.buildbots [Wed, 28 Jan 2015 18:56:00 +0000 (10:56 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
879203002
mtklein [Wed, 28 Jan 2015 17:39:10 +0000 (09:39 -0800)]
Add a script to fetch the latest SKPs.
I keep forgetting how best to do this.
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
880283002
mtklein [Wed, 28 Jan 2015 15:20:28 +0000 (07:20 -0800)]
add a paranoid assert
NOTREECHECKS=true
BUG=chromium:399842
Review URL: https://codereview.chromium.org/
881253003
joshualitt [Wed, 28 Jan 2015 14:54:30 +0000 (06:54 -0800)]
Revert of GrBatchPrototype (patchset #32 id:630001 of https://codereview.chromium.org/
845103005/)
Reason for revert:
One last try to fix mac perf regression
Original issue's description:
> GrBatchPrototype
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
d15e4e45374275c045572b304c229237c4a82be4
>
> Committed: https://skia.googlesource.com/skia/+/
d5a7db4a867c7e6ccf8451a053d987b470099198
TBR=bsalomon@google.com,kkinnunen@nvidia.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
877393002
joshualitt [Wed, 28 Jan 2015 00:27:12 +0000 (16:27 -0800)]
whitespace
NOTREECHECKS=True
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
885443003
mtklein [Tue, 27 Jan 2015 23:39:19 +0000 (15:39 -0800)]
Revert of patch from issue
885453002 at patchset 20001 (crrev.com/
885453002#ps20001) (patchset #1 id:1 of https://codereview.chromium.org/
881953002/)
Reason for revert:
==32435==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x621000d8cd00
Lots of info here:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN/builds/1198/steps/dm/logs/stdio
Original issue's description:
> patch from issue
885453002 at patchset 20001 (http://crrev.com/
885453002#ps20001)
>
> Make the char cache dynamic in SkGlyphCache
> because it is rarely used.
>
> Landing on behalf of Herb.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
95faa61d63a6f62916f6f7be58c4624da8357e3b
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
881023003
joshualitt [Tue, 27 Jan 2015 23:39:06 +0000 (15:39 -0800)]
GrBatchPrototype
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
d15e4e45374275c045572b304c229237c4a82be4
Review URL: https://codereview.chromium.org/
845103005
mtklein [Tue, 27 Jan 2015 23:10:17 +0000 (15:10 -0800)]
patch from issue
885453002 at patchset 20001 (crrev.com/
885453002#ps20001)
Make the char cache dynamic in SkGlyphCache
because it is rarely used.
Landing on behalf of Herb.
BUG=skia:
Review URL: https://codereview.chromium.org/
881953002
mtklein [Tue, 27 Jan 2015 22:46:26 +0000 (14:46 -0800)]
add -r to DM
$ out/Debug/dm -w good
$ out/Debug/dm -r good -w bad && echo "hooray no diffs!"
BUG=skia:
Review URL: https://codereview.chromium.org/
863093003
mtklein [Tue, 27 Jan 2015 22:35:18 +0000 (14:35 -0800)]
SSE4 opaque blend using intrinsics instead of assembly.
Since we had such a hard time with the assembly versions of this blit (to the
point that we have them completely disabled everywhere), I thought I'd take
a shot at writing a version of the blit using intrinsics.
The key feature of SSE4 we're exploiting is that we can use ptest (_mm_test*)
to skip the blend when the 16 src pixels we consider each loop are all opaque
or all transparent. _mm_shuffle_epi8 from SSSE3 also lends a hand to extract
all those alphas.
It's worth looking to see if we can backport this type of logic to SSE2 using
_mm_movemask_epi8, or up to 32 pixels at a time using AVX.
My local performance testing doesn't show this to be an unambiguous win
(there are probably microbenchmarks and SKPs where we'd be better off just
powering through the blend rather than looking at alphas), but the potential
does seem tantalizing enough to let skiaperf vet it on the bots. (< 1.0x is a win.)
DM says it draws pixel perfect compare to the old code.
Microbenchmarks:
bitmap_RGBA_8888_A_source_stripes_two 14us -> 14.4us 1.03x
bitmap_RGBA_8888_A_source_stripes_three 14.3us -> 14.5us 1.01x
bitmap_RGBA_8888_scale_bilerp 61.9us -> 62.2us 1.01x
bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp 102us -> 101us 0.99x
bitmap_RGBA_8888_scale_rotate_bilerp 103us -> 101us 0.99x
bitmap_RGBA_8888_scale 18.4us -> 18.2us 0.99x
bitmap_RGBA_8888_A_scale_rotate_bicubic 71us -> 70us 0.99x
bitmap_RGBA_8888_update_scale_rotate_bilerp 103us -> 101us 0.99x
bitmap_RGBA_8888_A_scale_rotate_bilerp 112us -> 109us 0.98x
bitmap_RGBA_8888_update_volatile 5.72us -> 5.58us 0.98x
bitmap_RGBA_8888 5.73us -> 5.58us 0.97x
bitmap_RGBA_8888_update 5.78us -> 5.6us 0.97x
bitmap_RGBA_8888_A_scale_bilerp 70.7us -> 68us 0.96x
bitmap_RGBA_8888_A_scale_bicubic 23.7us -> 21.8us 0.92x
bitmap_RGBA_8888_A 13.9us -> 10.9us 0.78x
bitmap_RGBA_8888_A_source_opaque 14us -> 6.29us 0.45x
bitmap_RGBA_8888_A_source_transparent 14us -> 3.65us 0.26x
Running over our ~70 SKP web page captures, this looks like we spend 0.7x
the time in S32A_Opaque_BlitRow compared to the SSE2 version, which should
be a decent predictor of real-world impact.
BUG=chromium:399842
Committed: https://skia.googlesource.com/skia/+/
04bc91b972417038fecfa87c484771eac2b9b785
CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
Review URL: https://codereview.chromium.org/
874863002
bungeman [Tue, 27 Jan 2015 19:01:42 +0000 (11:01 -0800)]
Remove unused methods from SkScalerContext.
The methods getLocalMatrixWithoutTextSize and
getSingleMatrixWithoutTextSize on SkScalerContext were added as a
temporary measure for CoreText issues. Now that the CoreText
SkScalerContext is using other means to fix these issues more completely,
remove these now unused methods.
Review URL: https://codereview.chromium.org/
883833002
bungeman [Tue, 27 Jan 2015 18:41:17 +0000 (10:41 -0800)]
SkFontHost_FreeType takes advantage of SkStreamAsset.
With recent changes, SkTypeface now deals in SkStreamAsset instead of
SkStream. Take advantage of this for performance with FreeType.
Review URL: https://codereview.chromium.org/
882763002
bsalomon [Tue, 27 Jan 2015 17:56:04 +0000 (09:56 -0800)]
Fix GPU resource cache related assertions.
Review URL: https://codereview.chromium.org/
879963003
djsollen [Tue, 27 Jan 2015 17:01:01 +0000 (09:01 -0800)]
Setup Android framework builds to use the appropriate shared lib defines.
Review URL: https://codereview.chromium.org/
864043005
halcanary [Tue, 27 Jan 2015 16:38:35 +0000 (08:38 -0800)]
sk_tool_utils::draw_checkerboard uses SkXfermode::kSrc_Mode to fix valgrind error.
Review URL: https://codereview.chromium.org/
877103002
jvanverth [Tue, 27 Jan 2015 16:19:33 +0000 (08:19 -0800)]
Use highp for distance field texture coordinates.
Addresses issues with wavy text (probably due to low-precision aliasing)
BUG=429080
Review URL: https://codereview.chromium.org/
879603003
reed [Tue, 27 Jan 2015 15:26:51 +0000 (07:26 -0800)]
fix gm to not rely on SkColor's swizzle == SkPMColor's
BUG=skia:3361
Review URL: https://codereview.chromium.org/
873983009
joshualitt [Tue, 27 Jan 2015 14:41:33 +0000 (06:41 -0800)]
Revert of GrBatchPrototype (patchset #30 id:570001 of https://codereview.chromium.org/
845103005/)
Reason for revert:
creates large performance regression
Original issue's description:
> GrBatchPrototype
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
d15e4e45374275c045572b304c229237c4a82be4
TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
862823004
robertphillips [Tue, 27 Jan 2015 14:17:22 +0000 (06:17 -0800)]
Add ClipDrawMatch SampleApp slide
This slide can be used to find and diagnose discrepancies between BW clipping and drawing.
BUG=skia:423834
Review URL: https://codereview.chromium.org/
872363003
bungeman [Tue, 27 Jan 2015 13:39:10 +0000 (05:39 -0800)]
SkTypeface to use SkStreamAsset.
SkTypeface already requires typeface streams to support SkStreamAsset
in practice, and in practice all users are already supplying them.
Review URL: https://codereview.chromium.org/
869763002
reed [Tue, 27 Jan 2015 13:01:50 +0000 (05:01 -0800)]
speedup mipmap building
mipmap_build benchmark:
before: 3.36ms
after: 2.20ms
BUG=skia:
Review URL: https://codereview.chromium.org/
873393002
kkinnunen [Tue, 27 Jan 2015 08:30:18 +0000 (00:30 -0800)]
Make stencil buffers uncached for uncached render target textures
Make new stencil buffers of uncached render target textures not affect the
cache budgets. This is consistent with render buffer storage of uncached
render target textures.
Affects only newly created stencil buffers. An uncached render target
might still receive a cached stencil buffer if such is available from
cache.
BUG=skia:3119
BUG=skia:3301
Review URL: https://codereview.chromium.org/
859013002
skia.buildbots [Tue, 27 Jan 2015 07:08:55 +0000 (23:08 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
882613002
mtklein [Tue, 27 Jan 2015 02:55:58 +0000 (18:55 -0800)]
Split src/opts source lists out of opts.gyp.
This should make it easier to keep our opts.gyp in sync with Chrome's GYP and GN.
BUG=skia:
Landing this without review as a mega-tryjob.
TBR=reed@google.com
Committed: https://skia.googlesource.com/skia/+/
c98fe3aa4f8c97c462c0eb6d9106fc37e48d7f82
Review URL: https://codereview.chromium.org/
870353003
mtklein [Tue, 27 Jan 2015 02:15:31 +0000 (18:15 -0800)]
Revert of Split src/opts source lists out of opts.gyp. (patchset #1 id:1 of https://codereview.chromium.org/
870353003/)
Reason for revert:
Android Makefiles broken
Original issue's description:
> Split src/opts source lists out of opts.gyp.
>
> This should make it easier to keep our opts.gyp in sync with Chrome's GYP and GN.
>
> BUG=skia:
>
> Landing this without review as a mega-tryjob.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
c98fe3aa4f8c97c462c0eb6d9106fc37e48d7f82
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
880783002
mtklein [Tue, 27 Jan 2015 02:05:37 +0000 (18:05 -0800)]
Split src/opts source lists out of opts.gyp.
This should make it easier to keep our opts.gyp in sync with Chrome's GYP and GN.
BUG=skia:
Landing this without review as a mega-tryjob.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
870353003
bungeman [Mon, 26 Jan 2015 22:32:09 +0000 (14:32 -0800)]
Revert of SSE4 opaque blend using intrinsics instead of assembly. (patchset #14 id:260001 of https://codereview.chromium.org/
874863002/)
Reason for revert:
This kills Mac 10.6 bots.
FAILED: c++ -MMD -MF obj/src/opts/opts_sse4.SkBlitRow_opts_SSE4.o.d -DSK_INTERNAL -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=1 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_BUILD_FOR_MAC -DSK_CRASH_HANDLER -DSK_DEVELOPER=1 -I../../src/core -I../../src/utils -I../../include/c -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/utils/mac -I../../include/effects -O0 -gdwarf-2 -mmacosx-version-min=10.6 -arch x86_64 -mssse3 -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wno-unused-parameter -Wno-invalid-offsetof -msse4.1 -c ../../src/opts/SkBlitRow_opts_SSE4.cpp -o obj/src/opts/opts_sse4.SkBlitRow_opts_SSE4.o
../../src/opts/SkBlitRow_opts_SSE4.cpp:15:27: warning: x86intrin.h: No such file or directory
../../src/opts/SkBlitRow_opts_SSE4.cpp: In function 'void S32A_Opaque_BlitRow32_SSE4(SkPMColor*, const SkPMColor*, int, U8CPU)':
../../src/opts/SkBlitRow_opts_SSE4.cpp:40: error: '_mm_testz_si128' was not declared in this scope
../../src/opts/SkBlitRow_opts_SSE4.cpp:45: error: '_mm_testc_si128' was not declared in this scope
Original issue's description:
> SSE4 opaque blend using intrinsics instead of assembly.
>
> Since we had such a hard time with the assembly versions of this blit (to the
> point that we have them completely disabled everywhere), I thought I'd take
> a shot at writing a version of the blit using intrinsics.
>
> The key feature of SSE4 we're exploiting is that we can use ptest (_mm_test*)
> to skip the blend when the 16 src pixels we consider each loop are all opaque
> or all transparent. _mm_shuffle_epi8 from SSSE3 also lends a hand to extract
> all those alphas.
>
> It's worth looking to see if we can backport this type of logic to SSE2 using
> _mm_movemask_epi8, or up to 32 pixels at a time using AVX.
>
> My local performance testing doesn't show this to be an unambiguous win
> (there are probably microbenchmarks and SKPs where we'd be better off just
> powering through the blend rather than looking at alphas), but the potential
> does seem tantalizing enough to let skiaperf vet it on the bots. (< 1.0x is a win.)
>
> DM says it draws pixel perfect compare to the old code.
>
> Microbenchmarks:
> bitmap_RGBA_8888_A_source_stripes_two 14us -> 14.4us 1.03x
> bitmap_RGBA_8888_A_source_stripes_three 14.3us -> 14.5us 1.01x
> bitmap_RGBA_8888_scale_bilerp 61.9us -> 62.2us 1.01x
> bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp 102us -> 101us 0.99x
> bitmap_RGBA_8888_scale_rotate_bilerp 103us -> 101us 0.99x
> bitmap_RGBA_8888_scale 18.4us -> 18.2us 0.99x
> bitmap_RGBA_8888_A_scale_rotate_bicubic 71us -> 70us 0.99x
> bitmap_RGBA_8888_update_scale_rotate_bilerp 103us -> 101us 0.99x
> bitmap_RGBA_8888_A_scale_rotate_bilerp 112us -> 109us 0.98x
> bitmap_RGBA_8888_update_volatile 5.72us -> 5.58us 0.98x
> bitmap_RGBA_8888 5.73us -> 5.58us 0.97x
> bitmap_RGBA_8888_update 5.78us -> 5.6us 0.97x
> bitmap_RGBA_8888_A_scale_bilerp 70.7us -> 68us 0.96x
> bitmap_RGBA_8888_A_scale_bicubic 23.7us -> 21.8us 0.92x
> bitmap_RGBA_8888_A 13.9us -> 10.9us 0.78x
> bitmap_RGBA_8888_A_source_opaque 14us -> 6.29us 0.45x
> bitmap_RGBA_8888_A_source_transparent 14us -> 3.65us 0.26x
>
> Running over our ~70 SKP web page captures, this looks like we spend 0.7x
> the time in S32A_Opaque_BlitRow compared to the SSE2 version, which should
> be a decent predictor of real-world impact.
>
> BUG=chromium:399842
>
> Committed: https://skia.googlesource.com/skia/+/
04bc91b972417038fecfa87c484771eac2b9b785
TBR=henrik.smiding@intel.com,mtklein@google.com,herb@google.com,reed@google.com,thakis@chromium.org,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:399842
Review URL: https://codereview.chromium.org/
874033004
bungeman [Mon, 26 Jan 2015 22:08:52 +0000 (14:08 -0800)]
Add sbix font to coloremoji gm.
Review URL: https://codereview.chromium.org/
797043002
mtklein [Mon, 26 Jan 2015 22:06:42 +0000 (14:06 -0800)]
SSE4 opaque blend using intrinsics instead of assembly.
Since we had such a hard time with the assembly versions of this blit (to the
point that we have them completely disabled everywhere), I thought I'd take
a shot at writing a version of the blit using intrinsics.
The key feature of SSE4 we're exploiting is that we can use ptest (_mm_test*)
to skip the blend when the 16 src pixels we consider each loop are all opaque
or all transparent. _mm_shuffle_epi8 from SSSE3 also lends a hand to extract
all those alphas.
It's worth looking to see if we can backport this type of logic to SSE2 using
_mm_movemask_epi8, or up to 32 pixels at a time using AVX.
My local performance testing doesn't show this to be an unambiguous win
(there are probably microbenchmarks and SKPs where we'd be better off just
powering through the blend rather than looking at alphas), but the potential
does seem tantalizing enough to let skiaperf vet it on the bots. (< 1.0x is a win.)
DM says it draws pixel perfect compare to the old code.
Microbenchmarks:
bitmap_RGBA_8888_A_source_stripes_two 14us -> 14.4us 1.03x
bitmap_RGBA_8888_A_source_stripes_three 14.3us -> 14.5us 1.01x
bitmap_RGBA_8888_scale_bilerp 61.9us -> 62.2us 1.01x
bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp 102us -> 101us 0.99x
bitmap_RGBA_8888_scale_rotate_bilerp 103us -> 101us 0.99x
bitmap_RGBA_8888_scale 18.4us -> 18.2us 0.99x
bitmap_RGBA_8888_A_scale_rotate_bicubic 71us -> 70us 0.99x
bitmap_RGBA_8888_update_scale_rotate_bilerp 103us -> 101us 0.99x
bitmap_RGBA_8888_A_scale_rotate_bilerp 112us -> 109us 0.98x
bitmap_RGBA_8888_update_volatile 5.72us -> 5.58us 0.98x
bitmap_RGBA_8888 5.73us -> 5.58us 0.97x
bitmap_RGBA_8888_update 5.78us -> 5.6us 0.97x
bitmap_RGBA_8888_A_scale_bilerp 70.7us -> 68us 0.96x
bitmap_RGBA_8888_A_scale_bicubic 23.7us -> 21.8us 0.92x
bitmap_RGBA_8888_A 13.9us -> 10.9us 0.78x
bitmap_RGBA_8888_A_source_opaque 14us -> 6.29us 0.45x
bitmap_RGBA_8888_A_source_transparent 14us -> 3.65us 0.26x
Running over our ~70 SKP web page captures, this looks like we spend 0.7x
the time in S32A_Opaque_BlitRow compared to the SSE2 version, which should
be a decent predictor of real-world impact.
BUG=chromium:399842
Review URL: https://codereview.chromium.org/
874863002
halcanary [Mon, 26 Jan 2015 21:46:41 +0000 (13:46 -0800)]
site/dev/contrib/directory <= https://status.skia.org/
NOTRY=true
Review URL: https://codereview.chromium.org/
876873002
joshualitt [Mon, 26 Jan 2015 21:30:10 +0000 (13:30 -0800)]
GrBatchPrototype
BUG=skia:
Review URL: https://codereview.chromium.org/
845103005
derekf [Mon, 26 Jan 2015 20:59:06 +0000 (12:59 -0800)]
Remove clear function from SkGPipe
Clear no longer exists. (It's now a drawPaint call)
Review URL: https://codereview.chromium.org/
881563002
halcanary [Mon, 26 Jan 2015 20:49:00 +0000 (12:49 -0800)]
s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/
BUG=skia:
Review URL: https://codereview.chromium.org/
873333004
halcanary [Mon, 26 Jan 2015 20:38:59 +0000 (12:38 -0800)]
site/dev/contrib/revert formatting and details
NOTRY=true
Review URL: https://codereview.chromium.org/
873483004