platform/upstream/dotnet/runtime.git
5 years agoRemove DEBUG-only TraceSource/Switch usage from corefx (dotnet/corefx#41177)
Stephen Toub [Wed, 18 Sep 2019 20:43:25 +0000 (16:43 -0400)]
Remove DEBUG-only TraceSource/Switch usage from corefx (dotnet/corefx#41177)

A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time, but some of it is keeping these types from being trimmed in a default MVC app.

Commit migrated from https://github.com/dotnet/corefx/commit/80adc8b87163dfe77d5b4262ea7970cc2de87f46

5 years agoUpdate unix-instructions.md
Maryam Ariyan [Wed, 18 Sep 2019 20:35:33 +0000 (13:35 -0700)]
Update unix-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/2c5f652ea6a883bc032db18a8a2401db9f66f523

5 years agoUpdate unix-instructions.md
Maryam Ariyan [Wed, 18 Sep 2019 20:03:01 +0000 (13:03 -0700)]
Update unix-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/a18b1ba2cf6fb9377ccd3d4e263ea84d75c23842

5 years agoFix trimming of System.Net.Ping (dotnet/corefx#41180)
Stephen Toub [Wed, 18 Sep 2019 19:29:16 +0000 (15:29 -0400)]
Fix trimming of System.Net.Ping (dotnet/corefx#41180)

It has an ILLinkTrim.xml file that was keeping a type around for testing, but that's apparently keeping the assembly from being trimmed in a published app.

Commit migrated from https://github.com/dotnet/corefx/commit/64c7228b941d1402009c57441a5a8c634d0e6843

5 years agoFix the filename used by the VerifyCrlCache test (dotnet/corefx#41173)
Jeremy Barton [Wed, 18 Sep 2019 16:37:51 +0000 (09:37 -0700)]
Fix the filename used by the VerifyCrlCache test (dotnet/corefx#41173)

The VerifyCrlCache test, which is a manual test, is looking for the old cache key.
This change updates it to the new cache key, and makes the test pass again.

Commit migrated from https://github.com/dotnet/corefx/commit/395f42ffa645efd067fd790712b48061c0236523

5 years agoimprove span.StartsWith(span) test coverage (dotnet/corefx#41169)
Adam Sitnik [Wed, 18 Sep 2019 15:47:51 +0000 (17:47 +0200)]
improve span.StartsWith(span) test coverage (dotnet/corefx#41169)

Commit migrated from https://github.com/dotnet/corefx/commit/b8d1e0620e6ed6355d76d118c6fa609e7f7cc049

5 years agoAllow X509Chain to replace the root trust list when building a chain
Zach Read [Wed, 18 Sep 2019 15:31:26 +0000 (10:31 -0500)]
Allow X509Chain to replace the root trust list when building a chain

This enables users of X509Chain to specify a priori a set of trusted root authorities, which is used in place of the default root authorities.

By explicitly specifying the root authorities the caller enables revocation checking for normally untrusted roots, and simplifies the certificate acceptance by having the chain engine tell them if the root matched, vs doing a post-build check (in the case of cross-certified authorities this even tells the chain engine which path to prefer).

Commit migrated from https://github.com/dotnet/corefx/commit/e70e76159b3f34e4e35d241daf39d4f57f4bd82c

5 years agoAnnotate System.ComponentModel for nullable (dotnet/corefx#41160)
buyaa-n [Wed, 18 Sep 2019 14:31:39 +0000 (07:31 -0700)]
Annotate System.ComponentModel for nullable (dotnet/corefx#41160)

* Annotate System.ComponentModel for nullable

* Applying feedback

Commit migrated from https://github.com/dotnet/corefx/commit/90870e3120f4998a70546798b02c4c903df2f4df

5 years agoRemove some ActiveIssueAttributes (dotnet/corefx#41163)
Santiago Fernandez Madero [Wed, 18 Sep 2019 14:31:20 +0000 (07:31 -0700)]
Remove some ActiveIssueAttributes (dotnet/corefx#41163)

Commit migrated from https://github.com/dotnet/corefx/commit/9f4fa8c6d1b581676f24af429bc64867cb623c78

5 years agoAdd missing tag to XML comments (dotnet/corefx#41162)
Frank Buckley [Wed, 18 Sep 2019 00:59:41 +0000 (01:59 +0100)]
Add missing tag to XML comments (dotnet/corefx#41162)

Commit migrated from https://github.com/dotnet/corefx/commit/4ca1feeeb484e8a7089ce8a9d377703ad5b8a53e

5 years agoAdd Culture Cloning Test (dotnet/corefx#41124)
Tarek Mahmoud Sayed [Tue, 17 Sep 2019 18:19:40 +0000 (11:19 -0700)]
Add Culture Cloning Test (dotnet/corefx#41124)

* Add Culture Cloning Test

This test to validate the calendar instances inside the culture after colning.

* Address the feedback

* More feedback addressing

* More Feedback Addressing

Commit migrated from https://github.com/dotnet/corefx/commit/65edbb39dd737e8529a343f385d2600e482b7ff3

5 years agoRemove System.Net.Requests dependency from System.Private.Xml (dotnet/corefx#41111)
Stephen Toub [Tue, 17 Sep 2019 14:43:51 +0000 (10:43 -0400)]
Remove System.Net.Requests dependency from System.Private.Xml (dotnet/corefx#41111)

* Remove System.Net.Requests dependency from System.Private.Xml

Anything that uses System.Xml ends up implicitly referencing this .dll, which in a trimmed default MVC app is 97K.  The only thing it's used for is as part of XmlResolver to download the specified url.  We can instead remove the usage of WebRequest.Create and replace it with usage of HttpClient, which is already brought in because System.Net.Requests uses it to implement HttpWebRequest.

* Address PR feedback

And other minor cleanup.  Also fix uap build.

Commit migrated from https://github.com/dotnet/corefx/commit/f873a33056ab318c02d295f816065a3d2ad3736b

5 years agoRemove unused files from System.Net.Http (dotnet/corefx#41155)
Stephen Toub [Tue, 17 Sep 2019 14:17:49 +0000 (10:17 -0400)]
Remove unused files from System.Net.Http (dotnet/corefx#41155)

Commit migrated from https://github.com/dotnet/corefx/commit/e9836aa6bdd40d76d8cf3534e491d90421c4bd9a

5 years agoFix a typo in DictionaryImportsReceiveMetadataFromNestedAdapters test name (dotnet...
Matt Galbraith [Tue, 17 Sep 2019 13:26:21 +0000 (06:26 -0700)]
Fix a typo in DictionaryImportsReceiveMetadataFromNestedAdapters test name (dotnet/corefx#41149)

Commit migrated from https://github.com/dotnet/corefx/commit/9200a1714863e53be53dc4406f493b2ea810c291

5 years agoimprove socket timout tests (dotnet/corefx#41078)
Tomas Weinfurt [Tue, 17 Sep 2019 13:16:25 +0000 (06:16 -0700)]
improve socket timout tests (dotnet/corefx#41078)

* improve socket timout tests

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/938b24dc397e11eab8688deca71ecd13ffc6fa4a

5 years agoSupport nullable values in dictionaries (dotnet/corefx#40991)
Layomi Akinrinade [Tue, 17 Sep 2019 12:38:41 +0000 (08:38 -0400)]
Support nullable values in dictionaries (dotnet/corefx#40991)

* Support nullable values in dictionaries

* Address review feedback

* Address feedback

* Defer dictionary key escaping to writer

Commit migrated from https://github.com/dotnet/corefx/commit/a308e93b1f1303be7eab5ce2b8ed11e66cc8e01e

5 years agoRemove allocations from Dns.* (dotnet/corefx#41061)
Stephen Toub [Tue, 17 Sep 2019 12:20:14 +0000 (08:20 -0400)]
Remove allocations from Dns.* (dotnet/corefx#41061)

This started as an effort to reduce the size of System.Net.NameResolution.dll when publishing a trimmed app.  It's not that big to begin with, but it's carrying around a copy of all of the IAsyncResult helper types, because the Get*Async methods are currently wrappers for the Begin/End* methods.

This PR inverts that, wrapping the Begin/End* methods instead around the Get*Async methods, using the same TaskToApm helper we use in other places in corefx for the same purpose.  This makes the Get*Async methods faster and lighterweight, but it does increase the number/amount of allocation in the Begin/End* APIs.  Since these are considered legacy, I normally would consider that a good trade, however we still use these Begin/End methods in a few places in System.Net.Sockets, and I didn't want to regress those use cases.

So, this also then trims some additional fat, which helps the Get*Async cases even further, and gets the Begin/End* to be even better than before the change.  This includes not allocating an IPHostEntry when we're just going to unwrap it and return its addresses, computing the exact IPAddress[] size we need rather than using a List<> to grow it and ToArray to create the actual array, avoiding creating the HostName if we don't need it, and avoiding an unnecessary SafeHandle allocation.

As part of this, I also noticed that we had some bugs in how some of our interop structures on Windows were defined.  In particular, fields that in the native types were size_t were defined as int rather than IntPtr in the managed code.  It appears we were saved by padding, but I fixed it regardless.

And as long as I was changing pretty much everything else, where I was touching code I also cleaned up some legacy style stuff.

Commit migrated from https://github.com/dotnet/corefx/commit/a55e95cbd9fca7ce5b3ad34c583642a35f42cd63

5 years agoAdd missing dummy types to reference assemblies (dotnet/corefx#41147)
Santiago Fernandez Madero [Tue, 17 Sep 2019 05:10:48 +0000 (22:10 -0700)]
Add missing dummy types to reference assemblies (dotnet/corefx#41147)

Commit migrated from https://github.com/dotnet/corefx/commit/4aea703673e942756c02b222e6b5babaf8612a25

5 years agoRemove use of non-generic Queue/Stack in System.Private.Xml (dotnet/corefx#41142)
Stephen Toub [Tue, 17 Sep 2019 01:04:03 +0000 (21:04 -0400)]
Remove use of non-generic Queue/Stack in System.Private.Xml (dotnet/corefx#41142)

This is the only reason these types are brought into a trimmed default MVC app.

Commit migrated from https://github.com/dotnet/corefx/commit/6347f35dad5fc7a967d5ab1202e8fbaf0ac7d252

5 years agoRemove use of RuntimeReflectionExtensions from Microsoft.CSharp (dotnet/corefx#41143)
Stephen Toub [Tue, 17 Sep 2019 00:38:32 +0000 (20:38 -0400)]
Remove use of RuntimeReflectionExtensions from Microsoft.CSharp (dotnet/corefx#41143)

* Remove use of RuntimeReflectionExtensions from Microsoft.CSharp

The wrappers aren't adding any benefit and are causing us to pull in the extensions type unnecessarily (and doing unnecessary null checks); just call the underlying methods directly.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/4dd07b79be316cf8421a51e0ed6b4a145713080e

5 years agoFix SqlParameter with xml schema construction (dotnet/corefx#41008)
Wraith2 [Mon, 16 Sep 2019 19:48:10 +0000 (20:48 +0100)]
Fix SqlParameter with xml schema construction (dotnet/corefx#41008)

Commit migrated from https://github.com/dotnet/corefx/commit/cd0576dad5fcfe73aeda81a0a81972843734e525

5 years agoRemove System.Net.Http dependency on System.Text.RegularExpressions (dotnet/corefx...
Stephen Toub [Mon, 16 Sep 2019 18:56:59 +0000 (14:56 -0400)]
Remove System.Net.Http dependency on System.Text.RegularExpressions (dotnet/corefx#41110)

* Remove System.Net.Http dependency on System.Text.RegularExpressions

This dependency is the only reason we end up with a 105K System.Text.RegularExpressions.dll as part of a trimmed new MVC app.  Regex is used in the case where on Windows a bypass list is provided, in which case each item in the list is changed into a regex, which is then evaluated against each url provided to SocketsHttpHandler.  But the patterns usable are simple: the only special character recognized is an asterisk, which can map to zero or more of any character.  So, we can instead employ a simple processor for such patterns, which then eliminates the need to reference System.Text.RegularExpressions.dll from System.Net.Http.dll.  It also happens to be faster.

* Address PR feedback

* Update src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/0e65e923689962f9634b5948d15f995140cc7c93

5 years agoSerialization performance improvements (dotnet/corefx#41098)
Steve Harter [Mon, 16 Sep 2019 16:20:43 +0000 (11:20 -0500)]
Serialization performance improvements (dotnet/corefx#41098)

Commit migrated from https://github.com/dotnet/corefx/commit/017a038abaabedcbbc61c85c9f7405f588ca3b46

5 years agoUpdate dogfooding.md to include other blob feeds required for dogfooding (dotnet...
Ganbarukamo41 [Mon, 16 Sep 2019 16:15:28 +0000 (01:15 +0900)]
Update dogfooding.md to include other blob feeds required for dogfooding (dotnet/corefx#41123)

* Update dogfooding.md to include other feeds

* Add a few more blob feeds that are listed in https://github.com/dotnet/core-sdk#installers-and-binaries, which are required to properly dogfood nightly SDKs
  * For example, adding only the core blob may result in build failures due to failures restoring packages that are distributed from ASP.NET feeds
* Replace MyGet with dotnet-blob feeds, since MyGet isn't used anymore

* Remove duplicate feed that's added by mistake

Commit migrated from https://github.com/dotnet/corefx/commit/115035527ef4179425be7116756cf4e69e9f4a79

5 years agoUpdated VS code debugging instructions (dotnet/corefx#41138)
Marie Píchová [Mon, 16 Sep 2019 16:12:14 +0000 (18:12 +0200)]
Updated VS code debugging instructions (dotnet/corefx#41138)

* Updated VS code debugging instructions.

* Moved debugging instructions into developer-guide.md (PR comment).

Commit migrated from https://github.com/dotnet/corefx/commit/a8f4393940c3f01218d115aae7628cf60d8d8fc3

5 years agoRe-enable macOS 10.14 in CI
Viktor Hofer [Mon, 16 Sep 2019 16:09:22 +0000 (18:09 +0200)]
Re-enable macOS 10.14 in CI

Commit migrated from https://github.com/dotnet/corefx/commit/cc0cc906fac8638e78115aa0f7478c654d155b52

5 years agoPossible overflow in Partitioner dotnet/corefx#40201 (dotnet/corefx#41066)
marcnet80 [Sat, 14 Sep 2019 19:36:07 +0000 (22:36 +0300)]
Possible overflow in Partitioner dotnet/corefx#40201 (dotnet/corefx#41066)

* Possible overflow in Partitioner dotnet/corefx#40201

https://github.com/dotnet/corefx/issues/40201

* Possible overflow in Partitioner dotnet/corefx#40201

https://github.com/dotnet/corefx/issues/40201

* Possible overflow in Partitioner dotnet/corefx#40201

https://github.com/dotnet/corefx/issues/40201

* Possible overflow in Partitioner dotnet/corefx#40201

https://github.com/dotnet/corefx/issues/40201

* Possible overflow in Partitioner dotnet/corefx#40201

https://github.com/dotnet/corefx/issues/40201

Commit migrated from https://github.com/dotnet/corefx/commit/36370ae660d385deef9c2dc25f72852bc4b9194e

5 years agoDisable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds (dotnet/corefx...
David Shulman [Sat, 14 Sep 2019 15:50:30 +0000 (08:50 -0700)]
Disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds (dotnet/corefx#41109)

The remote server "revoked.badssl.com" has a certificate which is not only revoked but also
now untrusted since it has expired.

Disabling test for now

Contributes to dotnet/corefx#41108

Commit migrated from https://github.com/dotnet/corefx/commit/8350134a21960df364517c9c766937ae47bf76c5

5 years agoRemove unnecessary passing of RegexOptions.None to Regex ctor (dotnet/corefx#41101)
Stephen Toub [Sat, 14 Sep 2019 02:30:37 +0000 (22:30 -0400)]
Remove unnecessary passing of RegexOptions.None to Regex ctor (dotnet/corefx#41101)

Commit migrated from https://github.com/dotnet/corefx/commit/f07730eedb1f7e2cb5e178d988bc2255f7ce7021

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41089)
dotnet-maestro[bot] [Fri, 13 Sep 2019 19:53:32 +0000 (19:53 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41089)

* Update dependencies from https://github.com/dotnet/coreclr build 20190912.7

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19462.7
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19462.7
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19462.7

* Fix Environment.WorkingSet tests for coreclr update

Commit migrated from https://github.com/dotnet/corefx/commit/a3dbe06e55084c12450288db4ea12a1e7fd36144

5 years agoAnnotate System.Collections.NonGeneric for nullable (dotnet/corefx#41036)
buyaa-n [Fri, 13 Sep 2019 14:26:27 +0000 (07:26 -0700)]
Annotate System.Collections.NonGeneric for nullable (dotnet/corefx#41036)

* Annotate System.Collections.NonGeneric for nullable

* Removing unnessecarry constant

* Marked CaseInsensitiveHashCodeProvider as Obsolete

* Removing NullableAttributes defintion as it was already added

* Applying feedback

* Revert "Applying feedback"

* Applying feedback

Commit migrated from https://github.com/dotnet/corefx/commit/001420e80489bf8e456d8bfb9aa22d5a02de0988

5 years agouse configuration for invalid host name (dotnet/corefx#41083)
Tomas Weinfurt [Fri, 13 Sep 2019 13:40:36 +0000 (06:40 -0700)]
use configuration for invalid host name (dotnet/corefx#41083)

Commit migrated from https://github.com/dotnet/corefx/commit/19ea63fee517327e1f6fbfa730300ddef5ef8a3b

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41023)
dotnet-maestro[bot] [Fri, 13 Sep 2019 10:15:01 +0000 (10:15 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41023)

* Update dependencies from https://github.com/dotnet/coreclr build 20190910.9

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19460.9
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19460.9
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19460.9

* Update dependencies from https://github.com/dotnet/coreclr build 20190911.7

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19461.7
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19461.7
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19461.7

* Update StringComparerTests.netcoreapp.cs

Commit migrated from https://github.com/dotnet/corefx/commit/fdb13cc7ee134a17fb36a038b57795b7e2225274

5 years agoDisable macOS 10.14 in CI again
Viktor Hofer [Fri, 13 Sep 2019 09:29:49 +0000 (11:29 +0200)]
Disable macOS 10.14 in CI again

One machine is not patched correctly and causes builds to fail.

Commit migrated from https://github.com/dotnet/corefx/commit/767467e72a372b31be44ee08e161b19e846c191a

5 years agoEnable Regex compiler to be trimmed (dotnet/corefx#41075)
Stephen Toub [Fri, 13 Sep 2019 00:21:41 +0000 (20:21 -0400)]
Enable Regex compiler to be trimmed (dotnet/corefx#41075)

Today an app that just does:
```C#
Console.WriteLine(Regex.IsMatch("12345", "0*[1-9][0-9]*"));
```
and is trimmed will end up publishing a 105K System.Text.RegularExpression.dll, including the regex compiler for when the RegexOptions.Compiled is used.  We can refactor the constructors such that the compiler only ends up getting rooted when one of the ctors that takes options is used.  After this PR, if you don't pass RegexOptions, the 105K drops to 85K.

Commit migrated from https://github.com/dotnet/corefx/commit/31a5bba0e79a5ae875f691d70ec3b9789691136d

5 years agomaking debugging easier (dotnet/corefx#41067)
Anirudh Agnihotry [Thu, 12 Sep 2019 21:23:37 +0000 (14:23 -0700)]
making debugging easier (dotnet/corefx#41067)

Commit migrated from https://github.com/dotnet/corefx/commit/03b2cb81fcd893c38d9b717d5b93ca7eba59fc2e

5 years agoImprove deserialization perf with changes to property name lookup (dotnet/corefx...
Steve Harter [Thu, 12 Sep 2019 20:47:56 +0000 (15:47 -0500)]
Improve deserialization perf with changes to property name lookup (dotnet/corefx#40998)

Commit migrated from https://github.com/dotnet/corefx/commit/d3c6628c2594b496ebc17526576cb164fc5fc0bf

5 years agoFix icon entry selection (dotnet/corefx#41048)
Jeremy Kuhne [Thu, 12 Sep 2019 20:21:59 +0000 (13:21 -0700)]
Fix icon entry selection (dotnet/corefx#41048)

* We weren't checking the color depth properly when choosing an icon entry to extract from an icon file.

Fix, and add a test.

Commit migrated from https://github.com/dotnet/corefx/commit/3a5b86f21b498067fa920842adaf228e39b6e35a

5 years agomake sure BindDuringTcpWait_Succeeds does not run with other tests (dotnet/corefx...
Tomas Weinfurt [Thu, 12 Sep 2019 18:48:41 +0000 (11:48 -0700)]
make sure BindDuringTcpWait_Succeeds does not run with other tests (dotnet/corefx#40958)

* make sure BindDuringTcpWait_Succeeds does not run with other tests

* add partial to  NoParallelTests class

* add empty class to CollectionDefinition

Commit migrated from https://github.com/dotnet/corefx/commit/b384d34bcd4674bc0df08a333a4973de8e2ac7ae

5 years agoAdd Runtime IDs for Fedora 32
Omair Majid [Thu, 12 Sep 2019 17:57:14 +0000 (13:57 -0400)]
Add Runtime IDs for Fedora 32

Commit migrated from https://github.com/dotnet/corefx/commit/86fc9e751c424278a9c4e163e0a71a9d7e30c8e7

5 years agoAdd example of strong API proposal (dotnet/corefx#41042)
Carlos Sanchez Lopez [Wed, 11 Sep 2019 20:38:29 +0000 (13:38 -0700)]
Add example of strong API proposal (dotnet/corefx#41042)

Commit migrated from https://github.com/dotnet/corefx/commit/452c93e38097b53f19516486fda4f3b1f16334cf

5 years agoadd links to the new Profiling docs (dotnet/corefx#41018)
Adam Sitnik [Wed, 11 Sep 2019 20:34:27 +0000 (22:34 +0200)]
add links to the new Profiling docs (dotnet/corefx#41018)

Commit migrated from https://github.com/dotnet/corefx/commit/dc71f95667cabd5ad0f7a051c974e0d312b243e8

5 years agoadd few StartsWith edge case test cases (dotnet/corefx#41016)
Adam Sitnik [Wed, 11 Sep 2019 19:57:23 +0000 (21:57 +0200)]
add few StartsWith edge case test cases (dotnet/corefx#41016)

* add Hungarian edge case for IsPrefix

* add InvariantCulture.CompareInfo.IsPrefix("o\u0308", "o") edge case

Commit migrated from https://github.com/dotnet/corefx/commit/e32d9a2664a59eccbcbe5a4044cffbdd96538b5b

5 years agoadd IsPrefix test cases for Platforms differences (dotnet/corefx#41017)
Adam Sitnik [Wed, 11 Sep 2019 19:56:55 +0000 (21:56 +0200)]
add IsPrefix test cases for Platforms differences (dotnet/corefx#41017)

Commit migrated from https://github.com/dotnet/corefx/commit/728aceca7464e964719fc99ef585e63cbb95f44d

5 years agoimprove two http2 tests (dotnet/corefx#40797)
Tomas Weinfurt [Wed, 11 Sep 2019 19:16:01 +0000 (12:16 -0700)]
improve two http2 tests (dotnet/corefx#40797)

Commit migrated from https://github.com/dotnet/corefx/commit/9eed67227c2d0766c1b7fe40fa8a1a97097e3beb

5 years agoFix SerialStream.Flush on Unix (dotnet/corefx#40896)
Krzysztof Wicher [Wed, 11 Sep 2019 18:34:57 +0000 (11:34 -0700)]
Fix SerialStream.Flush on Unix (dotnet/corefx#40896)

* Fix SerialStream.Flush

* Only wait for write queue to drain on Flush

* add test case with reproted scenario

Commit migrated from https://github.com/dotnet/corefx/commit/45dba6ea7a49a9945a5ad497cfc3de2ec1246683

5 years agoJsonDocument documenation fix (dotnet/corefx#40994)
Katarzyna Bułat [Wed, 11 Sep 2019 18:23:17 +0000 (11:23 -0700)]
JsonDocument documenation fix (dotnet/corefx#40994)

* JsonDocument documenation fix

* comma added

Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/0354194175bb8d609000b463f402942db7235f0a

5 years agoGiven examples and made points explicit (dotnet/corefx#41012)
Mandar Sahasrabuddhe [Wed, 11 Sep 2019 04:29:44 +0000 (09:59 +0530)]
Given examples and made points explicit (dotnet/corefx#41012)

Made certain points explicit by giving examples or specifying acronyms in brackets where the words they stand for, appear for first time.

Commit migrated from https://github.com/dotnet/corefx/commit/76f566a281bbe979e80cbbb3a48ddf522cdcb4e1

5 years agoAvoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while escaping in...
Ahson Khan [Wed, 11 Sep 2019 00:49:22 +0000 (17:49 -0700)]
Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while escaping in Utf8JsonWriter. (dotnet/corefx#40996)

* Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while
escaping in Utf8JsonWriter.

* Fix white space typo in the test expected string.

* Guard against empty spans where an implementation of JavascriptEncoder
might not handle null ptrs correctly.

* Cleanup tests to avoid some duplication.

* Some more test clean up.

Commit migrated from https://github.com/dotnet/corefx/commit/ee9995f31b684a0c6e5488eceb2500bf0057da89

5 years agoUse slow path for CallInstruction returning enum value (dotnet/corefx#40976)
Charles Stoner [Wed, 11 Sep 2019 00:31:41 +0000 (17:31 -0700)]
Use slow path for CallInstruction returning enum value (dotnet/corefx#40976)

* Use slow path for CallInstruction returning enum value

* Fix assert

Commit migrated from https://github.com/dotnet/corefx/commit/f2daf45473553c19cc7b3dd4bb3f2033080a254c

5 years agoDelete unused ItemGroup (dotnet/corefx#40983)
Jan Kotas [Tue, 10 Sep 2019 22:10:25 +0000 (15:10 -0700)]
Delete unused ItemGroup (dotnet/corefx#40983)

Moved to CoreLib

Commit migrated from https://github.com/dotnet/corefx/commit/0ebca43a4db8d5ddaf2e9fd0df359a262b61c0ce

5 years agoRe-enable macOS 10.13 (dotnet/corefx#40980)
Viktor Hofer [Tue, 10 Sep 2019 18:23:02 +0000 (20:23 +0200)]
Re-enable macOS 10.13 (dotnet/corefx#40980)

Commit migrated from https://github.com/dotnet/corefx/commit/7b0e8cc8d66275de148f7310a7116de00d814cd0

5 years agoFix namespace typo in Tasks test (dotnet/corefx#40974)
Stephen Toub [Tue, 10 Sep 2019 15:36:35 +0000 (11:36 -0400)]
Fix namespace typo in Tasks test (dotnet/corefx#40974)

Commit migrated from https://github.com/dotnet/corefx/commit/02bebd69dcac53a7b903d605ce43fd28cd5ee0e9

5 years agoAdd test for IComponent typeconverter register in TypeDescriptor (dotnet/corefx#40959)
Santiago Fernandez Madero [Tue, 10 Sep 2019 13:37:09 +0000 (06:37 -0700)]
Add test for IComponent typeconverter register in TypeDescriptor (dotnet/corefx#40959)

Commit migrated from https://github.com/dotnet/corefx/commit/d1eeba90af85dd203aa27adbb30a28e45b54e23d

5 years agoAdd CodeDom.CodeValidator tests and fix some bugs (dotnet/corefx#39585)
Hugh Bellamy [Mon, 9 Sep 2019 23:30:51 +0000 (00:30 +0100)]
Add CodeDom.CodeValidator tests and fix some bugs (dotnet/corefx#39585)

* Add CodeDom.CodeValidator tests and fix some bugs

* Fix netfx tests

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/50e8db3cabbfb6ad0fc0702b3db25491a95c72a5

5 years agoMinor deserialization perf improvements for collections (dotnet/corefx#40889)
Steve Harter [Mon, 9 Sep 2019 21:55:47 +0000 (16:55 -0500)]
Minor deserialization perf improvements for collections (dotnet/corefx#40889)

Commit migrated from https://github.com/dotnet/corefx/commit/27ddbe99ccc32122141b81045ac670c3a0d1a45a

5 years agoWritable JSON API changes (dotnet/corefx#40673)
Katarzyna Bułat [Mon, 9 Sep 2019 21:53:38 +0000 (14:53 -0700)]
Writable JSON API changes (dotnet/corefx#40673)

* implicit operators moved to JsonNode
* JsonNull introduced
* JsonObject rewritten to use JsonObjectProperty
* JsonElement.ObjectEnumerator changed to use _current instead of _enumerator
* iterative DeepCopy implemented
* code reorganized
* parse implemented
* JsonDocumentOptions added to JsonNode.Parse
* WriteTo and ToJsonString added
* specification adjusted
* string comparison added
* JsosReadonlyDomWriteTests reused
* code coverage improved
* minor other fixes
* review comments included

Commit migrated from https://github.com/dotnet/corefx/commit/37b37395481b635c15eaa3454e52b72ab91de4ef

5 years agoAllow more of ConsolePal to be linked away (dotnet/corefx#40944)
Stephen Toub [Mon, 9 Sep 2019 21:47:36 +0000 (17:47 -0400)]
Allow more of ConsolePal to be linked away (dotnet/corefx#40944)

If an app just uses Console.Write*, it's currently still pulling in support for stdin and stderr, because of the GetUseFileAPIs choke point.

Commit migrated from https://github.com/dotnet/corefx/commit/d733b29ce6fccd7e64bc351e97cce68a9b91bb17

5 years agoUse ThrowHelper in Utf8JsonReader.GetGuid so that the deserializer can catch the...
Ahson Khan [Mon, 9 Sep 2019 21:26:54 +0000 (14:26 -0700)]
Use ThrowHelper in Utf8JsonReader.GetGuid so that the deserializer can catch the exception and re-throw JsonException. (dotnet/corefx#40938)

* Use ThrowHelper in Utf8JsonReader.GetGuid so that the deserializer can
catch the exception and re-throw JsonException.

* Fix the typo in the enum used and added more test cases.

Commit migrated from https://github.com/dotnet/corefx/commit/5bec8c841ec0ab366a99361bc9d4540022e7fa02

5 years agoReplace HashHelpers.Combine with HashCode.Combine in netcoreapp projects (dotnet...
Stephen Toub [Mon, 9 Sep 2019 20:44:56 +0000 (16:44 -0400)]
Replace HashHelpers.Combine with HashCode.Combine in netcoreapp projects (dotnet/corefx#40935)

Commit migrated from https://github.com/dotnet/corefx/commit/8c221ca346b64e1e80ab4bde240b0f479bd203fc

5 years agoMark System.Data.SqlClient as archived component (dotnet/corefx#40946)
Jan Kotas [Mon, 9 Sep 2019 18:21:50 +0000 (11:21 -0700)]
Mark System.Data.SqlClient as archived component (dotnet/corefx#40946)

Commit migrated from https://github.com/dotnet/corefx/commit/f5574287ee7e9ef785ee6849bad7916871bebd81

5 years agoRemove ProjectGUIDs from project files and Project and Name attributes from P2Ps...
Viktor Hofer [Mon, 9 Sep 2019 16:21:25 +0000 (18:21 +0200)]
Remove ProjectGUIDs from project files and Project and Name attributes from P2Ps (dotnet/corefx#40926)

* Remove ProjectGUIDs from P2Ps

* Remove ProjectGUIDs from project files

Commit migrated from https://github.com/dotnet/corefx/commit/c22714d65151968a17c3b232748880d5e7961dee

5 years agofix of a minor typo in System.Threading.Channels.ChannelReader docs (dotnet/corefx...
itrofimow [Mon, 9 Sep 2019 14:27:44 +0000 (17:27 +0300)]
fix of a minor typo in System.Threading.Channels.ChannelReader docs (dotnet/corefx#40943)

Commit migrated from https://github.com/dotnet/corefx/commit/061d05b8df6295a9253d2bae423d89538a3b9132

5 years agoAdd tests relating to TypeDescriptor (dotnet/corefx#38938)
Hugh Bellamy [Mon, 9 Sep 2019 02:54:57 +0000 (03:54 +0100)]
Add tests relating to TypeDescriptor (dotnet/corefx#38938)

Commit migrated from https://github.com/dotnet/corefx/commit/cc51975a897cb803f1ad76b6b93b2ebd4581bca4

5 years agoCleanup drawing primitives (dotnet/corefx#40019)
Hugh Bellamy [Mon, 9 Sep 2019 02:18:22 +0000 (03:18 +0100)]
Cleanup drawing primitives (dotnet/corefx#40019)

Commit migrated from https://github.com/dotnet/corefx/commit/5bc243aa2040a1dbf63df1dd099124ade64ed5ce

5 years agoAdd more TypeConverter tests (dotnet/corefx#38945)
Hugh Bellamy [Mon, 9 Sep 2019 00:40:26 +0000 (01:40 +0100)]
Add more TypeConverter tests (dotnet/corefx#38945)

* Add more TypeConverter tests

* Add more ReferenceConverter tests and fix bugs

Commit migrated from https://github.com/dotnet/corefx/commit/ae987068bb07d7b8af458874d74714083a84618c

5 years agoDisable OSX.1013.Amd64.Open in CI (dotnet/corefx#40927)
Viktor Hofer [Sun, 8 Sep 2019 12:52:08 +0000 (14:52 +0200)]
Disable OSX.1013.Amd64.Open in CI (dotnet/corefx#40927)

Commit migrated from https://github.com/dotnet/corefx/commit/f0d5faf69b832646240b1b30797587ab35ffd03b

5 years agoIncrease helix timeout on Windows clients (dotnet/corefx#40913)
Viktor Hofer [Sun, 8 Sep 2019 11:24:35 +0000 (13:24 +0200)]
Increase helix timeout on Windows clients (dotnet/corefx#40913)

* Increase helix timeout on Windows clients

Depending on the ARM64 windows queue utilization, clients sometimes take longer than the current timeout. Increasing temporarily until the queue has more machines.

* Update windows.yml

* Update windows.yml

Commit migrated from https://github.com/dotnet/corefx/commit/ba5b90b95269548f8011e36e13b7f58acb62b4b8

5 years agoAdd missing dummy primitive to ReadOnlySequence<T>.Enumerator (dotnet/corefx#40910)
Santiago Fernandez Madero [Sat, 7 Sep 2019 14:54:58 +0000 (07:54 -0700)]
Add missing dummy primitive to ReadOnlySequence<T>.Enumerator (dotnet/corefx#40910)

Commit migrated from https://github.com/dotnet/corefx/commit/59c6b1ab96aa2e99ed6ecb33a8bcf9283ce1ea27

5 years agoRemove Redundant dependency of microsoft.netcoreapp.platforms (dotnet/corefx#40907)
Anirudh Agnihotry [Sat, 7 Sep 2019 01:50:05 +0000 (18:50 -0700)]
Remove Redundant dependency of microsoft.netcoreapp.platforms  (dotnet/corefx#40907)

* remove extra dependency

* removing microsoft.netcore.targets

Commit migrated from https://github.com/dotnet/corefx/commit/9e8d47c6e548dcacd71cb83133bbf49f74be90ac

5 years agoDisable ToolboxBitmatAttribute test in netfx (dotnet/corefx#40901)
Santiago Fernandez Madero [Fri, 6 Sep 2019 21:56:56 +0000 (14:56 -0700)]
Disable ToolboxBitmatAttribute test in netfx (dotnet/corefx#40901)

Commit migrated from https://github.com/dotnet/corefx/commit/937e7d6d7eb6f1413aa48d14961d8f0c8a061e0e

5 years agoFix Select.Count bug that iterates twice (dotnet/corefx#40718)
Stephen Toub [Fri, 6 Sep 2019 19:45:09 +0000 (15:45 -0400)]
Fix Select.Count bug that iterates twice (dotnet/corefx#40718)

* Add System.Linq tests to validate enumerator lifecycle

* Fix bug with Select(...).Count() on an IPartition

It currently ends up potentially enumerating the source twice.

* Remove unnecessary source inputs in lifecycle tests

Commit migrated from https://github.com/dotnet/corefx/commit/8455fd2d9bd46fc8b97fe86f907d2a8ae748443f

5 years agoRemove misleading test condition variable for registry (dotnet/corefx#40887)
Viktor Hofer [Fri, 6 Sep 2019 19:06:28 +0000 (21:06 +0200)]
Remove misleading test condition variable for registry (dotnet/corefx#40887)

Commit migrated from https://github.com/dotnet/corefx/commit/d88152f91a5b08534873868afe93ddc3c840f76f

5 years agoDisable two flaky EventLog tests (dotnet/corefx#40876)
Viktor Hofer [Fri, 6 Sep 2019 19:04:52 +0000 (21:04 +0200)]
Disable two flaky EventLog tests (dotnet/corefx#40876)

Commit migrated from https://github.com/dotnet/corefx/commit/9d5b200c6088d9dc038c64ec051596170731dbab

5 years agoMake "remote" more CultureInfo.CurrentCulture setting tests (dotnet/corefx#40891)
Stephen Toub [Fri, 6 Sep 2019 19:04:17 +0000 (15:04 -0400)]
Make "remote" more CultureInfo.CurrentCulture setting tests (dotnet/corefx#40891)

Commit migrated from https://github.com/dotnet/corefx/commit/002d62b53343ae9b24310681c349913b97d30202

5 years agoDisable two networking tests on UAP (dotnet/corefx#40875)
Viktor Hofer [Fri, 6 Sep 2019 16:42:03 +0000 (18:42 +0200)]
Disable two networking tests on UAP (dotnet/corefx#40875)

* Disable timeout sensitive networking test on UAP

Disabling GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream on UAP

* Update HttpClientHandlerTest.Cancellation.cs

Commit migrated from https://github.com/dotnet/corefx/commit/9161098ade5075a8c126b2d7eb98abbeadff2961

5 years agoFix some low-hanging fruit boxing in JsonSerializer (dotnet/corefx#40867)
Stephen Toub [Fri, 6 Sep 2019 16:19:02 +0000 (12:19 -0400)]
Fix some low-hanging fruit boxing in JsonSerializer (dotnet/corefx#40867)

It's boxing lots of dictionary enumerators and KeyValuePairs.  Stop doing that.

Commit migrated from https://github.com/dotnet/corefx/commit/447f76f251d72a6d5e9bc102523937d05f929095

5 years agoAdd license header to S.R.CS.Unsafe (dotnet/corefx#40886)
Michal Strehovský [Fri, 6 Sep 2019 15:51:56 +0000 (17:51 +0200)]
Add license header to S.R.CS.Unsafe (dotnet/corefx#40886)

Commit migrated from https://github.com/dotnet/corefx/commit/b42c65ee76c35a63124a6b8e887bbd25c0d263df

5 years agouse type for Http2LoopbackServer.CreateServer (dotnet/corefx#40863)
Tomas Weinfurt [Fri, 6 Sep 2019 04:27:05 +0000 (21:27 -0700)]
use type for Http2LoopbackServer.CreateServer (dotnet/corefx#40863)

Commit migrated from https://github.com/dotnet/corefx/commit/b46ebcb9a2408f9826c103ce6b340b419d948512

5 years agoupdate SendAsync_ConcurentSendReceive_Ok to use DuplexContent (dotnet/corefx#40858)
Tomas Weinfurt [Thu, 5 Sep 2019 23:49:16 +0000 (16:49 -0700)]
update SendAsync_ConcurentSendReceive_Ok to use DuplexContent (dotnet/corefx#40858)

Commit migrated from https://github.com/dotnet/corefx/commit/88017f967529d30272ad75028e5538f35087e451

5 years agoAddress a couple non-functional nits (dotnet/corefx#40854)
Steve Harter [Thu, 5 Sep 2019 22:45:41 +0000 (17:45 -0500)]
Address a couple non-functional nits (dotnet/corefx#40854)

Commit migrated from https://github.com/dotnet/corefx/commit/4390a665c2fe082007f6bd25be0e055307ee5573

5 years agoAllow NetworkStream.WriteAsync calls to be canceled asynchronously (dotnet/corefx...
Stephen Toub [Thu, 5 Sep 2019 20:51:34 +0000 (16:51 -0400)]
Allow NetworkStream.WriteAsync calls to be canceled asynchronously (dotnet/corefx#40839)

In 3.0 we added the necessary support for this, and for Socket.WriteAsync calls we're appropriately passing the CancellationToken through, but we missed doing so for NetworkStream.WriteAsync, which takes a slightly different code path through AwaitableSocketAsyncEventArgs.

Commit migrated from https://github.com/dotnet/corefx/commit/0a5b9286854c8bbb10677d730b0fe25425da562c

5 years agoUpdate Stable Version info on package index (dotnet/corefx#40780)
Jose Perez Rodriguez [Thu, 5 Sep 2019 18:57:18 +0000 (11:57 -0700)]
Update Stable Version info on package index (dotnet/corefx#40780)

* Upate Stable Version info on package index

* Re-adding back package version which was unlisted

Commit migrated from https://github.com/dotnet/corefx/commit/95c10ccf3f17e35339070a5ecacdc44366585643

5 years agoFix TypeConverter for IComponent (dotnet/corefx#40837)
Hugh Bellamy [Thu, 5 Sep 2019 18:21:59 +0000 (19:21 +0100)]
Fix TypeConverter for IComponent (dotnet/corefx#40837)

Commit migrated from https://github.com/dotnet/corefx/commit/3cc18081e24acdcfe7db737400a2dc702e314395

5 years agoRaise JsonException when PolicyProperty is null (dotnet/corefx#40501)
Adeel Mujahid [Thu, 5 Sep 2019 14:45:49 +0000 (17:45 +0300)]
Raise JsonException when PolicyProperty is null (dotnet/corefx#40501)

Commit migrated from https://github.com/dotnet/corefx/commit/5dbbdfa0f924f02754a464d492a2116ad9f5752b

5 years agoUse options.Encoder when serializing dictionary keys and property names (dotnet/coref...
Steve Harter [Thu, 5 Sep 2019 14:41:47 +0000 (09:41 -0500)]
Use options.Encoder when serializing dictionary keys and property names (dotnet/corefx#40787)

Commit migrated from https://github.com/dotnet/corefx/commit/7829d4acc8303a42e222415c7eb829fc3f8264cc

5 years agoMatch src param name of BrotliEncoder.GetMaxCompressedLength to ref param name (dotne...
Carlos Sanchez Lopez [Thu, 5 Sep 2019 12:49:13 +0000 (05:49 -0700)]
Match src param name of BrotliEncoder.GetMaxCompressedLength to ref param name (dotnet/corefx#40822)

* Make the name of the parameter in the BrotliEncoder.GetMaxCompressedLength src match the name of the parameter in the ref.

* Update unit test validating parameter name.

Commit migrated from https://github.com/dotnet/corefx/commit/c668e96cb0886d13a051d8021a3c3147e7daa15c

5 years agoSupport PAC scripts that return multiple proxies (dotnet/corefx#40082)
Cory Nelson [Thu, 5 Sep 2019 09:11:47 +0000 (02:11 -0700)]
Support PAC scripts that return multiple proxies (dotnet/corefx#40082)

* Support PAC scripts that return multiple proxies.

Resolves dotnet/corefx#39370

Commit migrated from https://github.com/dotnet/corefx/commit/5e97c2b50ac2b18909606ce3ea14c3e7e61db7e8

5 years agoReduce number of PFX loads in System.Net tests (dotnet/corefx#40821)
Stephen Toub [Thu, 5 Sep 2019 01:03:34 +0000 (21:03 -0400)]
Reduce number of PFX loads in System.Net tests (dotnet/corefx#40821)

* Reduce number of PFX loads in System.Net tests

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/838832e2ecac9f81b5a5649bfac2fc835db76c1e

5 years agoFix | SqlClient fix for managed encryption connection failure (dotnet/corefx#40732)
Wraith2 [Wed, 4 Sep 2019 23:52:07 +0000 (00:52 +0100)]
Fix | SqlClient fix for managed encryption connection failure (dotnet/corefx#40732)

Commit migrated from https://github.com/dotnet/corefx/commit/30decee8aa72ce93eec0394e94f05a86cec7ab9d

5 years agofix more tests to work with http2 (dotnet/corefx#39019)
Tomas Weinfurt [Wed, 4 Sep 2019 23:48:34 +0000 (16:48 -0700)]
fix more tests to work with http2 (dotnet/corefx#39019)

* fix cancelation tests to work with http2

* fix more tests and feedback from review

* feedback from review

* fix issues with missing connection: close

* update body check

* feedback from review

* fix resolve

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/5108d9245b891deeb36a164f434f4fb6975c8baf

5 years agoAdd round-trip test to JsonSerializer with overflow that needs to be escaped. (dotnet...
Ahson Khan [Wed, 4 Sep 2019 23:01:41 +0000 (16:01 -0700)]
Add round-trip test to JsonSerializer with overflow that needs to be escaped. (dotnet/corefx#40793)

* Add round-trip test to JsonSerializer with overflow that needs to be
escaped.

* Used escaped property names and add a test for serializer/writer
interop.

Commit migrated from https://github.com/dotnet/corefx/commit/76031d2f8ed714b54e0e7bbd7020f111b6c9c023

5 years agoRemove `readonly` from two `GCHandle` fields (dotnet/corefx#40807)
Stephen Toub [Wed, 4 Sep 2019 21:46:09 +0000 (17:46 -0400)]
Remove `readonly` from two `GCHandle` fields (dotnet/corefx#40807)

Due to the `readonly`, the mutations performed by `Free` will be done on a copy rather than on the data stored in the field.

Commit migrated from https://github.com/dotnet/corefx/commit/437ce88edeb835e1dbe94c6d418b6169b69745fb

5 years agoDelete Box.cs from System.Threading.Tasks.Parallel (dotnet/corefx#40808)
Stephen Toub [Wed, 4 Sep 2019 17:56:14 +0000 (13:56 -0400)]
Delete Box.cs from System.Threading.Tasks.Parallel (dotnet/corefx#40808)

We can just use `StrongBox<T>`.

Commit migrated from https://github.com/dotnet/corefx/commit/0b572f1a7ec2f691a424d0c6dd403e11191ca8c5

5 years agoRemove reflection from ThreadPoolHelpers test class (dotnet/corefx#40810)
Stephen Toub [Wed, 4 Sep 2019 16:24:03 +0000 (12:24 -0400)]
Remove reflection from ThreadPoolHelpers test class (dotnet/corefx#40810)

Commit migrated from https://github.com/dotnet/corefx/commit/c9a124635dbfc0ec3958f06093cd5196b00b47b1

5 years agoDisable FileSystemWatcher_File_Create_ForceLoopRestart test (dotnet/corefx#40804)
Stephen Toub [Wed, 4 Sep 2019 14:33:35 +0000 (10:33 -0400)]
Disable FileSystemWatcher_File_Create_ForceLoopRestart test (dotnet/corefx#40804)

Commit migrated from https://github.com/dotnet/corefx/commit/aea8a56edf54228029b0f9ddf369e4d4f82f4446

5 years agoMove wildcard bind in Socket.ConnectAsync to be Windows-only (dotnet/corefx#40767)
Stephen Toub [Wed, 4 Sep 2019 14:33:13 +0000 (10:33 -0400)]
Move wildcard bind in Socket.ConnectAsync to be Windows-only (dotnet/corefx#40767)

* Move wildcard bind in Socket.ConnectAsync to be Windows-only

It's necessary to use ConnectEx; it's not necessary on Unix.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8a1fc9d6b3c9b85a881e220a9f9193b72c0e801b

5 years agoFix the max token size threshold to correctly compute to 125MB for Base64 bytes....
Ahson Khan [Wed, 4 Sep 2019 05:24:28 +0000 (22:24 -0700)]
Fix the max token size threshold to correctly compute to 125MB for Base64 bytes. (dotnet/corefx#40792)

* Fix the max token size threshold to correctly compute to 125MB for
Base64 bytes.

* Rename constant to fix transpose error: Base46 -> Base64

* Enable the outerloop tests for windows and osx only and update to use
platform specific new line.

Commit migrated from https://github.com/dotnet/corefx/commit/1511f723f7adfe82cef72460df45dc4422d303c6

5 years agoDisable XML crypto test failing on Windows 10 (dotnet/corefx#40775)
Stephen Toub [Wed, 4 Sep 2019 04:04:25 +0000 (00:04 -0400)]
Disable XML crypto test failing on Windows 10 (dotnet/corefx#40775)

Commit migrated from https://github.com/dotnet/corefx/commit/70b4d01e18236c925c2d44d49fff7cbb4919dc43

5 years agoFix several recently added StyleCop tuple rules (dotnet/corefx#40794)
Stephen Toub [Wed, 4 Sep 2019 03:51:50 +0000 (23:51 -0400)]
Fix several recently added StyleCop tuple rules (dotnet/corefx#40794)

Commit migrated from https://github.com/dotnet/corefx/commit/06007cdedee9cfb096d884016a99e3a64bdccb45