Armin Novak [Thu, 20 Feb 2020 07:07:35 +0000 (08:07 +0100)]
Added fallbacks for primitives auto detection.
When using primitives auto detection it was possible that no
primitive implementation was chosen at all.
This now skips broken implementations and falls back to generic
primitives if no other implementation does work.
Armin Novak [Wed, 19 Feb 2020 16:00:36 +0000 (17:00 +0100)]
Check length of TPKT header for plausibility.
Armin Novak [Mon, 2 Mar 2020 07:40:40 +0000 (08:40 +0100)]
Implemented del_device by vid/pid
Armin Novak [Fri, 28 Feb 2020 12:45:26 +0000 (13:45 +0100)]
Cleaned up USB redirection
* Removed obsolete searchman
* Unified device add and virtual channel add
* Unified device id generation
Armin Novak [Wed, 26 Feb 2020 11:24:25 +0000 (12:24 +0100)]
Fix #5910: USB hotplug added device wrong
When a USB device was added via hotplug add_device was called
with wrong arguments.
David Fort [Mon, 2 Mar 2020 08:09:15 +0000 (09:09 +0100)]
Merge pull request #5931 from akallabeth/rpm_nightly_fix
Disable GSS/KRB5 support
Armin Novak [Mon, 2 Mar 2020 07:43:59 +0000 (08:43 +0100)]
Disable GSS/KRB5 support
Kerberos support in FreeRDP is not working, deactivate it. Fixes #5930
Martin Fleisz [Fri, 28 Feb 2020 10:22:36 +0000 (11:22 +0100)]
Fix possible NULL pointer access crash
Armin Novak [Thu, 27 Feb 2020 15:54:17 +0000 (16:54 +0100)]
Updated CMake channel detection
* Now both, dynamic and static channel entries can be defined by
a single channel.
* Added better logging to distinguish between static and dynamic
channel messages.
Martin Fleisz [Thu, 27 Feb 2020 11:12:20 +0000 (12:12 +0100)]
Add dynamic channel part for rdpsnd channel
Martin Fleisz [Fri, 28 Feb 2020 10:50:40 +0000 (11:50 +0100)]
Merge pull request #5920 from akallabeth/rdpsnd_crash_fix
Fix #5885: Check for division by zero
Martin Fleisz [Fri, 28 Feb 2020 08:55:29 +0000 (09:55 +0100)]
Merge pull request #5922 from akallabeth/channel_drdynvc_fi
Replaced CMake list find with loop to fix build issues.
Mark Karpeles [Thu, 27 Feb 2020 15:21:29 +0000 (00:21 +0900)]
fix FindFFmpeg.cmake: locating avcodec not using pkgconfig variable
Armin Novak [Thu, 27 Feb 2020 09:10:04 +0000 (10:10 +0100)]
Fix #5885: Check for division by zero
Armin Novak [Thu, 27 Feb 2020 10:18:54 +0000 (11:18 +0100)]
Replaced CMake list find with loop to fix build issues.
Bernhard Miklautz [Thu, 27 Feb 2020 09:29:29 +0000 (10:29 +0100)]
Merge pull request #5921 from akallabeth/nightly_optimise
Revert to RelWithDebInfo for debian.
Armin Novak [Thu, 27 Feb 2020 08:39:09 +0000 (09:39 +0100)]
Revert to RelWithDebInfo for debian.
Martin Fleisz [Wed, 26 Feb 2020 15:18:46 +0000 (16:18 +0100)]
Merge pull request #5907 from akallabeth/cmake_channel_dependency_fix
Cmake channel dependency fix
Armin Novak [Wed, 26 Feb 2020 13:35:45 +0000 (14:35 +0100)]
Deactivated URBDRC for mac and windows builds.
Martin Fleisz [Wed, 26 Feb 2020 13:48:41 +0000 (14:48 +0100)]
Merge pull request #5915 from akallabeth/gfx_versions
Updated RDPGFX_CAPVERSION_106 according to errata 2018-12-10
Martin Fleisz [Wed, 26 Feb 2020 13:41:46 +0000 (14:41 +0100)]
Merge pull request #5906 from akallabeth/tsmf_disable_for_good
Made CHANNEL_TSMF optional and deprecated.
Armin Novak [Wed, 26 Feb 2020 13:09:53 +0000 (14:09 +0100)]
Updated RDPGFX_CAPVERSION_106 according to errata 2018-12-10
Norbert Federa [Wed, 26 Feb 2020 11:24:21 +0000 (12:24 +0100)]
egfx: the gfx reset grahics pdu is optional
Since the EGFX Reset Graphics PDU seems to be optional,
the graphicsReset variable (which is updated in that PDU's handler)
should be removed from the rdp_gdi struct with the next change
in public headers (as in freerdp v3).
There are still some clients that expect and check it and therefore
we keep it for now, initialized with TRUE.
sdas
Armin Novak [Tue, 25 Feb 2020 14:21:16 +0000 (15:21 +0100)]
Made CHANNEL_TSMF optional and deprecated.
Armin Novak [Wed, 26 Feb 2020 12:53:25 +0000 (13:53 +0100)]
Deactivate USB redirection for IOS and ANDROID by default.
Ondrej Holy [Wed, 26 Feb 2020 10:12:46 +0000 (11:12 +0100)]
Do not advertise /usb in help output if the channel is not built
The help output advertise an option and an example for usb redirection
regardless of the fact whether the urbdrc channel was built or not.
This is confusing for people. Let's do not show /usb in help if it is
not built.
Kobi Mizrachi [Mon, 3 Feb 2020 08:44:25 +0000 (10:44 +0200)]
server: proxy: client: change ClientFree->ContextFree
Kobi Mizrachi [Sun, 2 Feb 2020 13:15:28 +0000 (15:15 +0200)]
server: proxy: support static vc passthrough
Kobi Mizrachi [Sun, 2 Feb 2020 13:01:38 +0000 (15:01 +0200)]
core: channels: add API to get channel name/id
Armin Novak [Tue, 25 Feb 2020 16:36:26 +0000 (17:36 +0100)]
drdynvc: reorder filepaths when adding channels
Armin Novak [Tue, 25 Feb 2020 15:38:31 +0000 (16:38 +0100)]
Promoted usb, printer and smartcard dependencies to recommended
Armin Novak [Tue, 25 Feb 2020 15:17:47 +0000 (16:17 +0100)]
Fixed CMake channel dependencies for variables.
Martin Fleisz [Tue, 25 Feb 2020 14:56:07 +0000 (15:56 +0100)]
Merge pull request #5905 from akallabeth/pulse_audin_fix
audin pulse log states by name
Armin Novak [Tue, 25 Feb 2020 10:29:09 +0000 (11:29 +0100)]
audin pulse log states by name
Martin Fleisz [Tue, 25 Feb 2020 13:50:51 +0000 (14:50 +0100)]
Merge pull request #5707 from akallabeth/kbd_codepage
Added KeyboardCodePage option
Armin Novak [Mon, 24 Feb 2020 11:28:11 +0000 (12:28 +0100)]
Updated RDP_KEYBOARD_LAYOUT_TABLE
Regenerated with new fetch_language_identifiers.py, less manual
postprocessing required.
Armin Novak [Mon, 24 Feb 2020 11:12:26 +0000 (12:12 +0100)]
Fixed keyboard lang struct generation
* Fixed length hex strings
* Fill in missing elements with last valid
Armin Novak [Fri, 8 Nov 2019 14:42:05 +0000 (15:42 +0100)]
Added keyboard language codepages and listing option
Martin Fleisz [Fri, 21 Feb 2020 10:36:49 +0000 (11:36 +0100)]
Merge pull request #5732 from akallabeth/floatbar_button_fix
Fixed #5730: Decoupled floatbar button focus from click events.
Martin Fleisz [Fri, 21 Feb 2020 08:05:47 +0000 (09:05 +0100)]
Merge pull request #5901 from nfedera/add_connstate_active_timeout
core: fix endless loops waiting for activation
Norbert Federa [Thu, 20 Feb 2020 16:26:27 +0000 (17:26 +0100)]
core: fix endless loops waiting for activation
There are two loops polling the transport pdu receiver in non-blocking mode
when waiting for reaching CONNECTION_STATE_ACTIVE rdp state.
In case of an invalid pdu size in the tpkt header this leaded to an endless
loop, utilizing 100% of a cpu core.
Added a sleep and limited the max loop time to the tcp ack timout value.
Martin Fleisz [Thu, 20 Feb 2020 07:32:50 +0000 (08:32 +0100)]
Merge pull request #5899 from akallabeth/respect_abort_connect
End connection before user callbacks if aborted.
Armin Novak [Wed, 19 Feb 2020 15:44:42 +0000 (16:44 +0100)]
End connection before user callbacks if aborted.
If somewhere in freerdp_connect freerdp_abort_connect was called
the user callbacks Authenticate, GatewayAuthenticate and
Verify[Changed|X509]Certificate[Ex] must not be called.
Martin Fleisz [Wed, 19 Feb 2020 15:03:54 +0000 (16:03 +0100)]
Merge pull request #5898 from akallabeth/timezone_update_20200219
Updated timezones 2020-02-19
Armin Novak [Wed, 19 Feb 2020 14:24:16 +0000 (15:24 +0100)]
Updated timezones 2020-02-19
Martin Fleisz [Wed, 19 Feb 2020 09:54:02 +0000 (10:54 +0100)]
Merge pull request #5896 from akallabeth/cast_warning_fixes
Fixed #5895: cast warnings.
Martin Fleisz [Wed, 19 Feb 2020 09:50:41 +0000 (10:50 +0100)]
Merge pull request #5897 from akallabeth/flatpak_update
Updated flatpak build manifest
Armin Novak [Wed, 19 Feb 2020 09:28:46 +0000 (10:28 +0100)]
Updated flatpak build manifest
* Use platform 19.08
* Remove shared-modules, no longer required (udev is now part of the
platform)
* Switch PCSC source to github to avoid rate limitations.
Armin Novak [Wed, 19 Feb 2020 09:09:32 +0000 (10:09 +0100)]
Fixed #5895: cast warnings.
Armin Novak [Tue, 18 Feb 2020 10:54:28 +0000 (11:54 +0100)]
Fixed #5889: Only add descriptors wanted to select
Sergey Bronnikov [Tue, 18 Feb 2020 11:52:42 +0000 (14:52 +0300)]
Fix markup
Martin Fleisz [Tue, 18 Feb 2020 10:14:58 +0000 (11:14 +0100)]
Merge pull request #5890 from akallabeth/sample_client_install
Install sample client binary.
Armin Novak [Tue, 3 Dec 2019 13:51:13 +0000 (14:51 +0100)]
Fix channel linking for built in channels
Armin Novak [Tue, 3 Dec 2019 13:50:07 +0000 (14:50 +0100)]
Added some callbacks to dynamic channel
* Allow listener removal of channel during runtime
* Allow retrieval of channel name
Armin Novak [Mon, 16 Dec 2019 07:34:42 +0000 (08:34 +0100)]
working progressive Original Method DWT
Implemented decoding utilizing Original Method DWT
(See [MS-RDPEGFX] 3.2.8.1.2.2 Reduce-Extrapolate Method)
Armin Novak [Tue, 10 Dec 2019 15:19:20 +0000 (16:19 +0100)]
Refactored progressive codec.
Armin Novak [Tue, 18 Feb 2020 10:02:43 +0000 (11:02 +0100)]
Install sample client binary.
Sergey Bronnikov [Mon, 17 Feb 2020 11:22:56 +0000 (14:22 +0300)]
client: remove unused variable
Martin Fleisz [Sat, 15 Feb 2020 18:25:40 +0000 (19:25 +0100)]
Merge pull request #5885 from llyzs/rdpsnd_overrun
rdpsnd: implement buffer overrun detection.
Vic Lee [Fri, 14 Feb 2020 12:48:04 +0000 (20:48 +0800)]
rdpsnd: implement buffer overrun detection.
David Fort [Thu, 13 Feb 2020 15:12:50 +0000 (16:12 +0100)]
Merge pull request #5881 from akallabeth/win_disable_console
Disable windows console attach.
Bernhard Miklautz [Thu, 13 Feb 2020 14:39:27 +0000 (15:39 +0100)]
Merge pull request #5882 from akallabeth/sample_auth_only
Added /auth-only option to sample client.
Armin Novak [Thu, 13 Feb 2020 07:26:21 +0000 (08:26 +0100)]
Added /auth-only option to samle client.
In #5814 the option to use a connection test was expressed.
Adding this option to the sample client allows doing that without
X11 or similar around.
Armin Novak [Wed, 12 Feb 2020 14:45:19 +0000 (15:45 +0100)]
Disable windows console attach.
Martin Fleisz [Wed, 12 Feb 2020 09:16:54 +0000 (10:16 +0100)]
Merge pull request #5857 from akallabeth/scanbuild_fixes
Scanbuild fixes
Martin Fleisz [Tue, 11 Feb 2020 11:58:10 +0000 (12:58 +0100)]
Merge pull request #5877 from akallabeth/urbdrc_export_symbol_fix
Urbdrc export symbol fix
Armin Novak [Tue, 11 Feb 2020 11:41:07 +0000 (12:41 +0100)]
Exporting URBDRC symbols used by helper library
When building the usb channel with different shared libraries some
necessary symbols were not exported.
David Fort [Mon, 10 Feb 2020 13:57:46 +0000 (14:57 +0100)]
Merge pull request #5875 from akallabeth/smartcard_missing_null_check
Fix #5847: Missing length check to trace smartcard buffers.
Kobi Mizrachi [Tue, 4 Feb 2020 12:51:47 +0000 (14:51 +0200)]
core: server: fix a bad free in channel->queue cleanup
Armin Novak [Mon, 10 Feb 2020 13:28:38 +0000 (14:28 +0100)]
Fix #5847: Missing length check to trace smartcard buffers.
Martin Fleisz [Mon, 10 Feb 2020 11:08:55 +0000 (12:08 +0100)]
Merge pull request #5865 from akallabeth/write_cancelled_leak
Fix #5852: handle CHANNEL_EVENT_WRITE_CANCELLED
Martin Fleisz [Mon, 10 Feb 2020 09:40:55 +0000 (10:40 +0100)]
Merge pull request #5869 from llyzs/winmm_fixes
rdpsnd/winmm: fix some memory issues.
Kobi Mizrachi [Tue, 28 Jan 2020 13:36:21 +0000 (15:36 +0200)]
server: proxy: improve logs
David Fort [Fri, 7 Feb 2020 13:11:00 +0000 (14:11 +0100)]
Merge pull request #5830 from akallabeth/smartcard_updates
Smartcard updates
Vic Lee [Tue, 4 Feb 2020 09:56:07 +0000 (17:56 +0800)]
rdpsnd/winmm: fix some memory issues.
Armin Novak [Wed, 29 Jan 2020 07:52:25 +0000 (08:52 +0100)]
Fix #5852: handle CHANNEL_EVENT_WRITE_CANCELLED
When channels are cleaned up OpenHandle is most of the time
already 0. Ignore the argument checks for
CHANNEL_EVENT_WRITE_CANCELLED and CHANNEL_EVENT_WRITE_COMPLETE
only check where actually required (CHANNEL_EVENT_DATA_RECEIVED)
Armin Novak [Thu, 16 Jan 2020 10:31:13 +0000 (11:31 +0100)]
FreeRDP_WTSVirtualChannelOpen unify channel new/free
Kobi Mizrachi [Thu, 16 Jan 2020 09:25:43 +0000 (11:25 +0200)]
server: make sure all messages in channel->queue are freed when queue is freed
Kobi Mizrachi [Mon, 27 Jan 2020 06:23:28 +0000 (08:23 +0200)]
server: proxy: show indicative log on bind failure.
Armin Novak [Fri, 24 Jan 2020 12:41:27 +0000 (13:41 +0100)]
Added unified NDR pointer reading.
Armin Novak [Fri, 24 Jan 2020 12:23:40 +0000 (13:23 +0100)]
Fixed missing length checks for smartcard IRP read.
Martin Fleisz [Thu, 23 Jan 2020 14:39:28 +0000 (15:39 +0100)]
Merge pull request #5859 from mfleisz/multi_trans_fix
core: Always send CS_MULTITRANSPORT PDU to server
Martin Fleisz [Thu, 23 Jan 2020 14:16:14 +0000 (15:16 +0100)]
core: Always send CS_MULTITRANSPORT PDU to server
This PDU is required by Microsoft servers in order for bandwidth
management to work correctly. Even if we do not support multi-transport
for now we should just send a PDU with flags set to 0 to enable correct
handing of bandwidth measurement PDUs.
Armin Novak [Thu, 23 Jan 2020 09:50:37 +0000 (10:50 +0100)]
Fixed rdpei unused function warning.
Armin Novak [Thu, 23 Jan 2020 09:39:43 +0000 (10:39 +0100)]
Fixed smartcard type mismatches.
Armin Novak [Thu, 23 Jan 2020 08:21:22 +0000 (09:21 +0100)]
Fixed type of index variables.
Armin Novak [Thu, 23 Jan 2020 08:21:06 +0000 (09:21 +0100)]
Fixed type of index variable.
Armin Novak [Thu, 23 Jan 2020 08:20:33 +0000 (09:20 +0100)]
Fixed unused variable warning.
Armin Novak [Thu, 23 Jan 2020 08:20:08 +0000 (09:20 +0100)]
Fixed copy of opaque data
do not use strcncpy for opaque data.
Armin Novak [Thu, 23 Jan 2020 08:19:48 +0000 (09:19 +0100)]
Fixed unused argument warnings.
Armin Novak [Thu, 23 Jan 2020 08:09:35 +0000 (09:09 +0100)]
Added NULL checks to silence clang-scanbuild.
Armin Novak [Thu, 23 Jan 2020 08:06:19 +0000 (09:06 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 07:55:47 +0000 (08:55 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 07:53:40 +0000 (08:53 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 09:07:54 +0000 (10:07 +0100)]
Unified smartcart multistring conversion.
Armin Novak [Thu, 23 Jan 2020 08:48:20 +0000 (09:48 +0100)]
Fixed type mismatches on allocation.
Armin Novak [Thu, 23 Jan 2020 08:32:34 +0000 (09:32 +0100)]
Fixed smartcard_SetAttrib_Decode call type
Martin Fleisz [Thu, 23 Jan 2020 07:30:11 +0000 (08:30 +0100)]
Merge pull request #5856 from akallabeth/neon_ycocg
Fixed #5855: YCoCg to RGB conversion color order
Armin Novak [Wed, 22 Jan 2020 16:28:22 +0000 (17:28 +0100)]
Fixed #5855: YCoCg to RGB conversion color order
Martin Fleisz [Wed, 22 Jan 2020 12:13:51 +0000 (13:13 +0100)]
core: Fix and extend populate rdp file from settings
This PR contains the following changes:
- Get rid of unused SettingsModified array (kept in the settings struct for ABI
compatibility)
- Fix and extend freerdp_client_populate_rdp_file_form_settings (wrote <null> strings to the rdp file, missed a lot of settings)
- Set KeyboardHook default value to 2 (hook in fullscreen) just as mstsc
does