Michał Obrembski [Wed, 11 Feb 2015 12:36:54 +0000 (13:36 +0100)]
Fixed autofill enabled option
Autofill popup was shown even if Autofill was turned off
in browser settings. This fixes that behavior.
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I6c0763005be3a349c1be31b6709228bdb2c0a2e0
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Tomasz Czekala [Wed, 11 Feb 2015 09:31:18 +0000 (10:31 +0100)]
fixup! Implement support for autofill feature.
Fixes for the patch http://165.213.202.130:8080/#/c/73496/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9520
Reviewed by: Jaesik Chang, Kamil Klimek
Change-Id: Ia87fe79fe159b6e7b023db39fd39999aaed743fd
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Maciej Piotrowski [Tue, 10 Feb 2015 07:55:11 +0000 (08:55 +0100)]
Fix missing translation for menu option
There was missing title for Search in web option
in context menu of selected text.
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: Ib49b6420c03dfba38ae9d511799f5a3ecdb11eea
Signed-off-by: Maciej Piotrowski <m.piotrowski@samsung.com>
Lukasz Krok [Tue, 10 Feb 2015 11:59:41 +0000 (12:59 +0100)]
ewk_error_cancellation_get API added
The API job is to check if an error was caused by a cancellation.
In current chromium implementation such situtation is not possible,
after I8f4e828bfcc63377678e475f44131dbc749b9c7f change.
Thus, the API will always return EINA_FALSE.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11077
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: Iedcf80af17747ac3330be5ea3f6f4c1e457afeca
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Kamil Nowac [Mon, 2 Feb 2015 16:59:39 +0000 (17:59 +0100)]
Enable chromedriver build for selenium testing.
To get chromedriver build add --define "build_chromedriver 1" to
build_mobile.sh command line. There will be chromedriver rpm file in GBS root
folder.
Install on the device.
run chrome driver with script: start-chrome-driver.sh
Reviewed by: Antonio Gomes, Janusz Majnert, Kamil Klimek
Change-Id: I5c00bf71813f91f5b3a5f18c389d2bdeb8f916d3
Signed-off-by: Kamil Nowac <k.nowac@samsung.com>
Wojciech Wiśniewski [Tue, 20 Jan 2015 17:29:10 +0000 (18:29 +0100)]
Break pointer cycle between CookieManager and content::URLRequestContextGetterEfl.
These classes hold reference-counted pointers to each other. This was causing memory
leak.
Reviewed by: Daniel Waślicki, Janusz Majnert, Piotr Tworek, arno renevier
Change-Id: I2ea821715aac813c9e6e5f9d8c3122cf46d8ac75
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
Tomasz Czekala [Wed, 11 Feb 2015 11:00:02 +0000 (12:00 +0100)]
Fix crash when navigating with JavaScriptDialogManager
When JavaScriptDialog was present, going back to a previous page caused
crash, because in ~WebContentsImpl we check if dialog_manager_ is not NULL,
then we invoke WebContentsDestroyed on it. But dialog_manager_ is
not set to NULL when we release the manager in ~WebContentsDelegateEfl,
so web contents must be released before web contents delegate
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11031
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I6a6f8f9d92c99e92e4c2fab2711083cf15dc3b3d
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 14:34:16 +0000 (15:34 +0100)]
fixup! Set RenderWidgetHostImpl visibility depending on presence application on screen
The code makes sense on Mobile/TV where the application always occupies
the whole screen. In case of desktop where mutiple windows can be seen
at the same time, not so much. After the patch whenever the window is
unfocused its content disappears.
Reviewed by: Antonio Gomes, Kamil Klimek, SeungSeop Park, arno renevier
Change-Id: I021b09543d5143e8ed91c9a362d7ce4e16727a61
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
KangYong Park [Tue, 10 Feb 2015 08:17:22 +0000 (17:17 +0900)]
Update TestExpectations for layout_test in desktop (chromium-efl)
When running layout tests, a number of 4000 errors occur.
Those failures slow down a full layout test run.
Skip them temporarily, so we can manage new failures.
It is related to below patch.
- http://165.213.202.130:8080/#/c/74587/
Reviewed by: Antonio Gomes, Gyuyoung Kim, SeungSeop Park
Change-Id: I156155e0568dda12ef87333457b54fab727d2851
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 13:55:56 +0000 (14:55 +0100)]
fixup! Add support for focus UI in InputPicker
Don't use internal _Eo_Opaque type. When Evas.h is included Evas_Object
typedef should take care of that. Code using evas should use always use
Evas_Object directly.
Reviewed by: Kamil Klimek, Piotr Grad, SeungSeop Park
Change-Id: Iad2ed39f9280dc50719a15be298142bb990167f0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Robert Jadczak [Mon, 9 Feb 2015 16:40:22 +0000 (17:40 +0100)]
Return focus to ewk_view after closing input picker
Focus was not returned to ewk_view until user touched the screen.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8105
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: If1326a6adf61f583b95e48cfd8e4ea15572ae4e6
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 13:45:05 +0000 (14:45 +0100)]
Only disable parallel gyp execution in case it doesn't work
Currently we always disable parallel gyp execution when running gyp
inside of GBS. This done because on some targets (TV 2.2.1) parallel
excution does not work due to broken python multiprocessing support.
The problem is, parallel execution works fine on Mobile or TV 3.0 and
disabling it meks gyp runs longer than necessary.
This patch uses an alternative solution. Only disable parallel gyp mode
in case gyp run in parallel such mode. I've tested it on both Mobile 2.4
and TV 2.2.1 targets and both work fine with such solution. The
difference is, Mobile 2.4 gyp run is now faster than previously.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Grad, SeungSeop Park
Change-Id: Iff360c20b30435dd96255b393057ea3acfa9fa95
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Dongjun Kim [Wed, 11 Feb 2015 04:22:01 +0000 (13:22 +0900)]
Autoscroll issue after showing IME
Page is not resized if select picker menu hides item on page.
So we need to add function for auto-scroll after
"OnInputPanelStateChanged" and "HandleResize".
BUG: http://107.108.218.239/bugzilla/show_bug.cgi?id=10843
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: I2ad0a1e4830c8ead519feac10213baf9aa3a7d81
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 15:07:36 +0000 (16:07 +0100)]
uBrowser: Fix support for enabling/disbling back and forward buttons.
The idea is simple back and forward buttons should only be active when
there is actual history entry to navigate to. The feature is there, but
broken due two small bugs, fix them.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: I9f1529e23932e53af254d1b3181bc6bb2e2fb096
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Bartlomiej Gajda [Tue, 10 Feb 2015 11:47:27 +0000 (12:47 +0100)]
Add beta version of locale files for PL, and ko_KR.
[Note] Those are only for testing. Accuracy of translation
can not be guaranteed.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10689
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I2f51109e8a5a4f199d9a4b8f66e6f0a4c48dadaf
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Jongsoo Yoon [Tue, 10 Feb 2015 06:14:14 +0000 (15:14 +0900)]
Added Tizen Trace package for debugging
SQE usually use Tizen Trace for debugging.
So, it is needed to add "ttrace" package into chromium-efl
Bug : http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11213
Reviewed by: Piotr Tworek, joonhwan kwon
Change-Id: I1691caa149527b9b3e167d8e5cdd78a5514ada7e
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Anthony Liot [Sat, 7 Feb 2015 01:02:28 +0000 (17:02 -0800)]
Tizen 2.4 support the aliasing/msaa on Mali-400
The driver bug on Mali-400 was solved with the last driver
OpenGLES for Tizen 2.4
M0 device support both flags :
--gpu-rasterization-msaa-sample-count=4
--canvas-msaa-sample-count=4
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11081
Reviewed by: Antonio Gomes, Prashant Nevase, venu musham
Change-Id: I94cd50d05456bc345b56530f2187bf598c269f76
Signed-off-by: Anthony Liot <anthony.liot@samsung.com>
Tomasz Weglarski [Tue, 10 Feb 2015 09:23:43 +0000 (10:23 +0100)]
fixup! Fix SkBitmap::config() removal in chrome.
[Requirement] WCS-TC-130
This patch fixes Command::deserialize method.
Reviewed by: Hyunhak Kim, Kamil Klimek, Marcin Kolibabka, Piotr Grad, Piotr Tworek
Change-Id: I3410c70da4942f1f5513959ad0f42ef617cb80f9
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 15:10:32 +0000 (16:10 +0100)]
uBrowser: Use touch events by default when running in mobile mode.
The --mobile command line flag is useful to quickly test desktop build
of ubrowser in mobile-like configuration. Since tizen mobile uses touch
events by default also use them when ubrowser is started on desktop with
--mobile flag.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: I70ba80b76ba2f800cbcdd7cdd1cdc4f0aa6b7276
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Robert Jadczak [Mon, 9 Feb 2015 13:26:18 +0000 (14:26 +0100)]
Set initial value for auto contents detection flag
m_detectContentsAutomatically member of Ewk_Settings was not initialized.
Reviewed by: Antonio Gomes, Cho Andy, Piotr Grad
Change-Id: Ie6e97dea411ab927a40944a75377603061617ec5
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Piotr Tworek [Mon, 9 Feb 2015 14:08:20 +0000 (15:08 +0100)]
Remove dead comments and unnecesary warnings from command_line_efl
The code was commented out during M37 migration attempt. The warnings
were added to keep in mind the removed switches need to be investigated.
It's been good couple of months since that time and there is no
indication the swtiches are needed for M40. Remove the code and the
warnings as there is no good reason to keep them around any longer.
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I1162bd5a3fe379a9a2ba125c39ff1694d635ac2c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Grad [Mon, 9 Feb 2015 11:01:16 +0000 (12:01 +0100)]
Implementation for date/time picker
[Requirement] WCS-TC-164
Current implementation was showing only date picker when date/time picker was
requested. Also proper translation for headers were added.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8765
Reviewed by: Hyunhak Kim, Karol Furmaniak, Piotr Grad
Change-Id: Ibf5ff2e1a3053e45daab92fd5f69f3d805902c59
Signed-off-by: Piotr Grad <p.grad@samsung.com>
KangYong Park [Mon, 9 Feb 2015 06:47:58 +0000 (15:47 +0900)]
Allow layout_test to run on desktop with mesa software backends
Some people like to test content_shell and layout_test over ssh.
Unfortunately hardware accelerated OpenGL does not work over ssh.
The only working backend for such configuration is mesa llfmpipe/softpipe.
Those backends however are considered as unsupported and are blacklisted
by EFL. Fortunately EFL allows us to ignore it's blacklist through
EVAS_GL_NO_BLACKLIST environment variable.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek
Change-Id: Ie35a5c3ece69780e52ac07e5e5617b7e3cf09435
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Michał Obrembski [Mon, 9 Feb 2015 10:56:16 +0000 (11:56 +0100)]
Added translation of Javascript BeforeUnload Dialog.
[Requirement] WCS-TC-161
JavaScriptDialogManagerEfl has hardcoded message string,
which was used in Javascript BeforeUnloadDialog.
This hardcoded string was replaced with dgettext and
corresponding translations.
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: If1a2e6d81c8780352d8454898107d23c3e5154e8
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Grzegorz Spryszynski [Mon, 9 Feb 2015 12:25:56 +0000 (13:25 +0100)]
[M34-Merge] Not showing IME in URL Box when second tap to url box
[Problem] IME is not shown after changing focus from
edit field on page to browser url bar. After that tapping
on any edit field cause no IME displaying.
[Solution] Removing internal flag (holding information whether
keyboard is visible or not) from im_context_efl and replace it
with ecore_imf_context_input_panel_state_get call.
Original commit: 165.213.202.130:8080/#/c/71929
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11168
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: Ia19b84824cd7d509dd0056b9166b8058462e3d66
Signed-off-by: Grzegorz Spryszynski <g.spryszynsk@samsung.com>
Piotr Grad [Mon, 9 Feb 2015 11:39:56 +0000 (12:39 +0100)]
Select picker controls were to big
[Requirement] WCS-TC- 178
Modified edc file to fit latest efl version.
Reviewed by: Hyunhak Kim, Karol Furmaniak
Change-Id: I5392d2dc71773cdec75fd743b3a7eebf99ca1162
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Marcin Strakowski [Fri, 6 Feb 2015 14:22:03 +0000 (15:22 +0100)]
fixup! "Save link" option implementation.
Fix! Browser crash after choose "Save link" option with
context menu when Internet is not available.
I added protection against an empty pointer
and display of message about not success.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10651
Reviewed by: DONGJUN KiM, Piotr Grad
Change-Id: I3c59fa98c035ea0317eefad1d487341e5636edf6
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
Robert Jadczak [Thu, 5 Feb 2015 11:05:06 +0000 (12:05 +0100)]
Add an implementation of "auto contents detection"
Patch implements auto contents detection - Phone number and e-mail detection
with displaying corresponding options popup.
Together_with: Icb6e136c153cbb78056d0d0f95adc366777781b3
Together_with: Ia54a4f3b59a66f1a4227312855b51c17ad002c20
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10638
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: If36fa83390f7652f556e9633a8aca3eb4cd758b0
Signed-off-by: Robert Jadczak <r.jadczak@samsung.com>
Piotr Grad [Sat, 7 Feb 2015 10:22:44 +0000 (11:22 +0100)]
Add support for focus UI in InputPicker
This commit is refactored merge from m34 branch.
Class InputPicker uses now ColorSelector widget from elm for select color.
H/W keyboard can now change values in Color Picker.
Original commit: http://165.213.202.130:8080/#/c/70449/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9615
Reviewed by: Hyunhak Kim, Piotr Grad, Tomasz Węglarski
Change-Id: I84360792349677cd91a32618fa9a90746d369979
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Karol Furmaniak [Tue, 3 Feb 2015 11:13:00 +0000 (12:13 +0100)]
Hide Selection Handle when not in visible rect.
[Requirement] WCS TC 26
[Problem]: When text in input field overflows, selection
handle is still visible.
[Solution] Do not show selection handle when it is not in
visible rect.
Together_with: I7e9825e423d2cb90145273e36d5419abb854e565
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10692
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I74d29bd92a9bb0359fb0da20de6df120316a9675
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Bartlomiej Gajda [Fri, 6 Feb 2015 14:55:31 +0000 (15:55 +0100)]
Change locale to be handled at start of each process.
[Note] This is better place to handle both process locale files,
and it doesn't use hardcoded paths.
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I8fa12fa3411f3dd48bda5997d6c49ab36301b530
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Bartlomiej Gajda [Fri, 6 Feb 2015 11:24:02 +0000 (12:24 +0100)]
Revert "Get rid off "Webkit" locale text domain"
This reverts commit
da0ae7b9d88c28c09fa9f7c3a597ac92d0ba7a7b.
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: Idc8777bcb8f44f540e82f10ed2fd4071615e2fa0
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
s.prutskov [Thu, 5 Feb 2015 14:01:41 +0000 (15:01 +0100)]
Set RenderWidgetHostImpl visibility depending on presence application on screen
The key press handlers for "XF86Phone" and "XF86PowerOff" are removed.
Instead callbacks for EVAS_CALLBACK_CANVAS_FOCUS_IN (app canvas became visible)
and EVAS_CALLBACK_CANVAS_FOCUS_OUT (app canvas became invisible) are added.
Such approach presumes, that actions on application presence/absence on
screen shouldn't depend on key by which it was removed or brought to screen.
Now it depends on fact that application is shown or hidden. It resolves the
problem when screen became motionless after making screenshot (by pressing
"XF86Phone" + "XF86PowerOff")
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10327
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I28d2d206e9fa5464f5d8cf9bc376ae745d7aa61f
Signed-off-by: s.prutskov <s.prutskov@samsung.com>
Arnaud Renevier [Fri, 6 Feb 2015 19:35:39 +0000 (11:35 -0800)]
fixup! uBrowser: Reference EWK browser application
When /bin/sh is not bash (for example, when it's dash), trying to launch
ubrowser.sh will result in errors "pushd: not found", "popd: not found"
and such.
This is because ubrowser.sh sources build/common.sh which contains
bashisms.
This patch launches ubrowser.sh with bash, and therefore prevents those
problems.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I0b51bc9695b35d11cec08fe40ef73d1941012844
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Grad [Sat, 7 Feb 2015 13:50:24 +0000 (14:50 +0100)]
fixup! H/W keyboard connection between browser and webview.
We have to hardcode value for key 'down' and 'up' as they are mismatched
with VK_.
Reviewed by: Hyunhak Kim, Piotr Grad, Tomasz Węglarski
Change-Id: I4d496617973fd872bddf8c12d73041d66e3048de
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Bartlomiej Gajda [Fri, 6 Feb 2015 12:36:07 +0000 (13:36 +0100)]
Fix build warnings regarding wrong order of initialization.
[Note] We should not have any warnings, as they might confuse developers, or be hidden errors.
Reviewed by: Hyunhak Kim, Piotr Grad, Piotr Tworek
Change-Id: Ica05788847bdd38e61335a900600d7f2f04d1ac2
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
Karol Furmaniak [Fri, 6 Feb 2015 11:00:09 +0000 (12:00 +0100)]
fixup! Implement "certificate,pem,set" callback.
[Problem]: Crash when certificate is not valid.
[Solution]: Release scoped_ptr when policy decision is supended.
Reviewed by: Gyuyoung Kim, Jaesik Chang, Piotr Grad
Change-Id: I36d2c6026987df7452c8c704d6e077854c8754fa
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Kamil Klimek [Sat, 7 Feb 2015 08:41:41 +0000 (17:41 +0900)]
fixup! Fix ewk shutdown procedure
Releasing default context if present.
EWK UT does not release default context anymore.
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: I724cc1809fe09f61dccd44012272e4c30342a403
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Marcin Krakowiak [Fri, 6 Feb 2015 15:50:30 +0000 (16:50 +0100)]
H/W keyboard connection between browser and webview.
[Requirement] WCS-TC-126
This patch adds implementation for passing focus to app in case when key down
event with UP or DOWN key was not handled on chromium side.
Reviewed by: Hyunhak Kim, Piotr Grad
Change-Id: I5a7c623416df31e2581107fe345ccaecfa80f405
Signed-off-by: Marcin Krakowiak <m.krakowiak@samsung.com>
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Tomasz Czekala [Fri, 6 Feb 2015 12:25:13 +0000 (13:25 +0100)]
Fix crash in HandlePolicyResponseOnUIThread when WebContents is NULL
In some situtations it was possible that HandlePolicyResponseOnUIThread
was called after related WebContents was already gone or when there was
no WebContents assigned to the Response
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9527
Reviewed by: Jaesik Chang, Janusz Majnert, Kamil Klimek, Piotr Grad, Piotr Tworek
Change-Id: Idb65a2684373a6a21543591f857a53d544090ac7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Grad [Fri, 6 Feb 2015 12:04:47 +0000 (13:04 +0100)]
Improper display of datepicker
[Requirement] WCS-TC-164
Modified control.edc file for date picker to fit latest platform image.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8765
Reviewed by: Hyunhak Kim, Karol Furmaniak, Marcin Krakowiak, Piotr Grad
Change-Id: Ia28c9174e5526274c1f87c49a5c3b1c50aef37c0
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Piotr Tworek [Fri, 6 Feb 2015 10:59:51 +0000 (11:59 +0100)]
fixup! Implement "certificate,pem,set" callback.
ContentBrowserClient::SetCertificatePem is called by chromium on IO
thread. We can't invoke EWK certificate,pem,set callback from non UI
threads. EWK is not a thread safe API. Also the code was triggering
asserts in chromium on every single https site I could find.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11023
Reviewed by: Antonio Gomes, Kamil Klimek, SeungSeop Park
Change-Id: I121cbda6f9aca3e3a0749bb0b62981cb5dfc5952
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 6 Feb 2015 11:29:12 +0000 (12:29 +0100)]
Make sure ELM_ACCEL is also set when running ubrowser on mobile
Since the EFL was upgraded to 1.12 on Tizen 2.4 the ELM_ACCEL needs to
be also when running the app on the target. Without it elementary tries
to use software rendering backend and creating Evas_GL fails in
RWHV_EFL.
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: I936df969bedb14d9027dd305ee982a7be84468f0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Fri, 6 Feb 2015 12:30:18 +0000 (13:30 +0100)]
Add support for "webprocess,crashed" EWK callback
It seems a little bit of code was lost while migrating some patches from
M34 to M40. According to EWK WebKit2 implementation the engine should
invoke "webprocess,crashed" callback whenever the webprocess crashes.
In case the callback is not handled by the EWK API user the engine should
show a simple page informing the user about the problematic situation.
Reviewed by: Janusz Majnert, Kamil Klimek, arno renevier
Change-Id: I39b9a7e4ee16606503f06b95c226dd4559b27b2a
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Konrad Zdunczyk [Wed, 4 Feb 2015 10:34:10 +0000 (11:34 +0100)]
Fix autozoom after autofocus
Webview was zoomed on text field after receiving autofocus by textfield (eg. google.com)
Autozoom should be done only after tap on textfield.
Autofocus is detected after fix and zoom isn't done.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10608
Reviewed by: Antonio Gomes, Daniel Waślicki, Piotr Tworek
Change-Id: Ie29bd6ef6b905b03bef2d95135eb4812bf34ea30
Signed-off-by: Konrad Zdunczyk <k.zdunczyk@samsung.com>
Karol Furmaniak [Wed, 28 Jan 2015 12:28:31 +0000 (13:28 +0100)]
Large handle is not appear after single tap on edit field.
[Requirement] WCS TC30
[Problem]: After single tap on edit field large
handler is not appear.
[Solution]: Added showing large handle (without context menu)
after tap on edit field.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10693
Reviewed by: Antonio Gomes, Jaesik Chang, Piotr Grad
Change-Id: Ideaa17f92329338a0a2be9166a5c56c3766dd0f0
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
SeungSeop Park [Thu, 5 Feb 2015 14:56:27 +0000 (23:56 +0900)]
Remove 'gclient sync' step in sync_repo.sh unless specified to do it
Patch changes sync_repos.sh to sync only s-* repos because
it's time consuming to run gclient sync (and runhook) step.
You can run the gclient step as usual by 'sync_repo.sh --reset'.
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I7d1ce54e5bb933210bc6c689f561f0a91d483479
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
JeongYeon Lee [Thu, 5 Feb 2015 02:38:05 +0000 (11:38 +0900)]
Create chromium-efl data path
Currently on Tizen chromium-efl wants to store temporary data
like application data, cache, databases etc. in /opt/usr/apps/chromium-efl.
It is path returned by Tizen's app_get_data_path function. The problem
is that Tizen does not create this path automatically during installation.
/opt/usr/apps requires root privileges in order to write. When we launch
any browser application from home screen, it runs as app user, which
has limited privileges. Of course when it tries to create some files
it fails, because of lack of required privilages. This patch creates
mentioned path after installation, which is done with root privileges
and allows us to create specific directory and change it's rights.
There is no possibility to replace hardcoded directory path with some
variable which keeps data directory, because it's not stored anywhere
in the environment.
Reviewed by: Antonio Gomes, Gyuyoung Kim, Kamil Klimek, Piotr Tworek, SeungSeop Park, Taeeun Kim
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10606
Change-Id: I068024323375d2f00c88f1862da3874721a75cb9
Signed-off-by: JeongYeon Lee <jywings.lee@samsung.com>
Piotr Tworek [Thu, 5 Feb 2015 16:30:52 +0000 (17:30 +0100)]
fixup! Changed policy decision mechanism to use content resource throttle API
Remove incorrect DCHECK. There won't be any response headers for a
request in case it was loaded thorugh protocols like file://. An easy
way to trigger the DCHECK is to simply run:
./out.x64/Debug/ubrowser <path to some html file>
Reviewed by: Piotr Grad, SeungSeop Park
Change-Id: Icb7cd589d759ab47df06d706156f3763e93089d3
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Marcin Strakowski [Fri, 30 Jan 2015 13:25:06 +0000 (14:25 +0100)]
"Save link" option implementation.
[Requirement] WCS TC 56
Until now Save link/image was working only when it was implemented on
browser side. Currently we have to handle this due to lack of such impl.
in reference browser. This commit adds proper implementation together
with notification alert upon save.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10651
Reviewed by: Hyunhak Kim, Jaesik Chang, Piotr Grad
Change-Id: Ic5d2e7cc41be87e73247cd0f97c159906443a9f7
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
Youngcheol Kang [Thu, 5 Feb 2015 00:26:01 +0000 (09:26 +0900)]
Remove gbs supplement repo for Tizen 2.4 mobile
We have to remove the supplement repo to make SPIN and BETA
build environment identically.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11058
Reviewed by: Piotr Grad, Piotr Tworek, joonhwan kwon
Change-Id: I4393f33bcf30a7e75aee8bb96c03cd46941133b1
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Kamil Klimek [Sat, 31 Jan 2015 11:18:31 +0000 (12:18 +0100)]
fixup! Implement support for autofill feature.
Implementation of autofill support was causing crashes at exit. It was
caused by direct dependency of autofill::PersonalDataManager on Prefs
that belong to BrowserContext - BrowserContext had shorter lifespan than
autofill::PersonalDataManager.
Another wrong aproach was making autofill::PersonalDataManager a
singleton. Because of dependency on BrowserContext it could not be
singleton. I've changed it to be created per BrowserContext and properly
respect IsOffTheRecord property. autofill::PersonalDataManager is
destroyed before related BrowserContext.
Reviewed by: Janusz Majnert, Piotr Grad, SeungSeop Park
Change-Id: I70a0209c55f19c1e20c223d5c077ff14a08f6b0c
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Karol Furmaniak [Tue, 3 Feb 2015 13:56:38 +0000 (14:56 +0100)]
Navigate forward button is disabled.
[Problem]: After navigate with "back" button forward button
is still disabled.
[Solution]: Invoking BackForwardListChangedCallback depends on
back/forward list count difference.
Unnecessary condition was removed.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10900
Reviewed by: Jaesik Chang, Piotr Grad, arno renevier
Change-Id: I080925a6ee8b42345fd5bd8df8d39d45ec1a489f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Tomasz Czekala [Thu, 5 Feb 2015 10:44:40 +0000 (11:44 +0100)]
Fix exception 'std::out_of_range' in 'basic_string::replace'
In EWebView::GetPlatformLocale we didn't check if string returned by
setlocale(LC_CTYPE, 0) has character '_', we assumed it has, and it seems
this assumption was wrong
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11070
Reviewed by: Daniel Waślicki, Filip Piechocki, Jaesik Chang, Piotr Tworek
Change-Id: I8baddfad7a66a9356ad44e3bc2c3b3c6f312e8f7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Venugopal S M [Thu, 5 Feb 2015 10:57:56 +0000 (16:27 +0530)]
[MSE]Changing audio elememt for playback on mobile.
M0 device for Tizen 2.4 is having audio elements ffdec_aac and
ffdec_mp3. Using the same for Audio playback.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10781
Reviewed by: Hyungsun Ryu, SeungSeop Park, Sharath Kamath
Change-Id: I96ae080b33fe34370c25171c1fd911901ecfc414
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
Youngcheol Kang [Thu, 5 Feb 2015 00:17:20 +0000 (09:17 +0900)]
Change default gbs repo to SPIN's latest for mobile
We decided again to use the latest SPIN repo for mobile build
(arm & i586) not snapshot repo of specific date.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11057
Reviewed by: Piotr Grad, joonhwan kwon
Change-Id: Ic255a7ef03d57c5711ced1e5c4f7eaf85f2b3619
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Michał Pakuła vel Rutka [Tue, 27 Jan 2015 14:20:12 +0000 (15:20 +0100)]
Introduce "content,size,changed" callback
EwkHostMsg_DidChangeContentSize was sent by a function which is fired by
a timer registered in RenderViewObserver::DidUpdateLayout. The presence of
the timer sometimes caused the situation when DidChangeContentsSize message
was sent after DidFinishLoad.
This behaviour causes utc_ewk_view_contents_size_get_p test to fail, as it
asumes that contents size value is up to date when "load,finished" callback is
fired.
To avoid this situation "contents,size,changed" callback is added (previously
implemented in WebKit-EFL), which informs an application about the change.
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: Ib7b51f9f7bd158b5c71279895b2f340c36e827d2
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
msu.koo [Wed, 21 Jan 2015 06:38:45 +0000 (15:38 +0900)]
[Tizen][WebRTC][M0] Enable video capture port on M0
On M0 target, camera supports I420 output.
This patch make Tizen video camera port independent
from platform camera output format.
Reviewed by: Min-Soo Koo, SeungSeop Park, Sharath Kamath
Change-Id: Ibcfb1c0ca72b5d0ece02c2adeb23622fb112a255
Signed-off-by: msu.koo <msu.koo@samsung.com>
Piotr Tworek [Mon, 8 Dec 2014 14:34:07 +0000 (15:34 +0100)]
uBrowser: Reference EWK browser application
This is basically my attempt at implementing more usable test
application for for chromium-ewk. Currently efl_webview_app is rather
limited and it's codebase is messy. It's main adventage is it works on
both Tizen and desktop. Mini browser has a few more features but it
only runs on tizen. Personally, I consider it's code to be of similar
quality as efl_webview_app.
uBrowser on the other hand works on both tizen and desktop, has simiar
feature set on both platforms and tries to split the code into smaller
chunks that are hopefully easier to understand and maintain. Compared to
mini_browser it's currently missing 2 features:
1. It does not support vibration. (I could not get it work on
mini_browser, but the code is there)
2. It does not have any find in page funcionality. (Mini browser has one
button that allows users search for hardcoded word 'google')
What is more important however, uBrowser does support multi window mode.
It's possible to open/close/switch between windows. I consider this
feature important because I've started the whole project when I had to
debug some multi-window related problems and none of the existing apps
made it easy. After that I just kept adding new features whenever I needed
them and they were either not available or did not work well enough in
other apps.
The app is far from finished and it probably has a few bugs. Still, I
decided there is no point in keeping it for myself any longer. It's nicely
separated from other EWK components and does not take a long time to
build. Hopefully other people will add even more features to it. At some
point it may even replace old reference EWK apps.
Reviewed by: Antonio Gomes, Kamil Klimek, arno renevier
Change-Id: I5f9cbdc9cb9e6bd801d3d02feff1ad02e97569b5
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 4 Feb 2015 11:41:49 +0000 (12:41 +0100)]
Make sure chromiuma-ewk targets provides efl_webprocess
The fact that we have a seperate binary for a renderer process is an
implementation detail of chromium-efl. Higher lever layers like EWK
should not expose such detail to the apps. Applications should depend on
chromium-ewk, but shouldn't need to depend on chromium-ewk dependencies.
Reviewed by: Antonio Gomes, Daniel Waślicki, Kamil Klimek
Change-Id: I9dc5c61e4f19b9cde1a67ed19e6a14c9b4720e13
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Tworek [Wed, 4 Feb 2015 13:01:32 +0000 (14:01 +0100)]
Allow efl_webview_app to run on desktop with mesa software backends
Some people like to test efl_webview_app over ssh. Unfortunately
hardware accelerated OpenGL does not work over ssh. The only working
backend for such configuration is mesa llfmpipe/softpipe. Those backends
however are considered as unsupported and are blacklisted by EFL.
Fortunately EFL allows us to ignore it's blacklist through
EVAS_GL_NO_BLACKLIST environment variable.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10918
Reviewed by: Antonio Gomes, Kamil Klimek
Change-Id: I6bc14e5303e94b9c911afa107435608ea423060c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Jongsoo Yoon [Wed, 4 Feb 2015 10:26:55 +0000 (19:26 +0900)]
Revert "Not display mini_browser icon."
This reverts commit
6624b0b9d451fc85cc84e30c061d90094f327e93.
[Temporary Patch]
Currently, Behavior of Reference browser is abnormal.
So, set mini_browser as default browser for some time.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10744
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek
Change-Id: Ib32bf7632a2f0c15a8311e3b07aa69c442b6cb3f
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Antonio Gomes [Tue, 3 Feb 2015 23:16:49 +0000 (15:16 -0800)]
Use ld gold for all targets on non-tv builds.
Patch enables linker gold for all targets on mobile builds,
and completely disables it for TV builds.
Reason is that TV build environment has the following problems
with gold linker:
[ 661s] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between //usr/lib/libc_nonshared.a(atexit.oS) and output
[ 661s] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/gcc/armv7l-tizen-linux-gnueabi/4.8.3/crtendS.o and output
[ 661s] /home/abuild/rpmbuild/BUILD/chromium-efl-40.2214.38.51/build/prebuild/ld:
error: DIV usage mismatch between /usr/lib/crtn.o and output
This partly merges http://165.213.202.130:8080/#/c/73747/,
from Piotr Tworek <p.tworek@samsung.com>.
Original patch aimed at fixing linking and packaging
of binaries larger than 2Gb. As this does not affect yet
beta/m40 branch, these specific bits of the patch were not
merged.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6629
Reviewed by: KC Park, Piotr Tworek, arno renevier
Change-Id: I6cb46c74d4a25047d92ae8f30ec9484befd44699
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Prashant Nevase [Wed, 4 Feb 2015 10:52:28 +0000 (16:22 +0530)]
Implement gpu driver bug handling mechanism for tizen.
This is base patch which makes driver bug handling mechanism and
black listing mechanism up on tizen platform.
Gpu driver bug list is taken from Android. In many cases Android has
fixes in the driver on latest versions of Android (probably > 4.4).
In current patch these are not resolved as we need to check and verify
each individual bug and test on the tizen platforms, which can be
carried out in subsequent patches later.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10994
Reviewed by: Antonio Gomes, venu musham
Change-Id: I27855664d70b225bc73a62dd6c751ec344f86bc6
Signed-off-by: Prashant Nevase <prashant.n@samsung.com>
Youngsoo Choi [Wed, 4 Feb 2015 07:12:40 +0000 (16:12 +0900)]
Upversion to capi-system-info-0.2.0-8.13
[issue]
The header 'version_system_info.h' does not exist,
in capi-system-info-0.2.0-8.x that tizen v3.0 supports.
It has been renamed to 'system_info.h'.
Following error is coming in tizen v3.0 build.
>> fatal error: system_info_internal.h: No such file or directory
[resolve]
The header 'system_info.h' is defined for tizen v3.0 build.
Reviewed by: Antonio Gomes, KC Park
Change-Id: Iac00b46685e05855a2b895193a60e8748e348083
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Wojciech Wiśniewski [Mon, 19 Jan 2015 16:44:35 +0000 (17:44 +0100)]
Really set URLRequestContextGetter inside CookieManager.
CookieManager has member pointer into URLRequestContextGetter (request_context_getter_),
but because of the way objects of these classes were created, this pointer was never
properly initialized (it was always set to NULL). This patch makes it initialize properly.
Reviewed by: Daniel Waślicki, Janusz Majnert, Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I1b55be86288b82d34bc34edc1970c84c0a60af15
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
Tomasz Czekala [Mon, 2 Feb 2015 08:46:37 +0000 (09:46 +0100)]
Fix user agent getter
User agent getter was returning a pointer to a local variable, that was already
out of scope, when the pointer was returned and the pointed memory was often
overridden, so it wasn't possible to read valid user agent string. This patch
adds local string that holds current user agent, what partly fixes this issue.
After second call of user agent string getter, the string is overridden, so the
previously returned pointer is no longer valid, but fixing that requires
changing the architecture of the EWK API
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10844
Reviewed by: Jaesik Chang, Janusz Majnert, Piotr Tworek
Change-Id: I6eacce32b521254f5171f51e8ac7efb011df004e
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Grad [Tue, 3 Feb 2015 20:47:33 +0000 (21:47 +0100)]
Get rid off "Webkit" locale text domain
[Requirement] WCS TC 1-57
This commit removes need for Webkit domain locale dependency.
Before we were mapping "Webkit" domain to "browser" domain which was redundant.
This was causing translation to not work when text domain for browser changed
it's path.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10689
Reviewed by: Antonio Gomes, Karol Furmaniak
Change-Id: Ic13fa7f92c02e7064931a4b9d55534518a82df7f
Signed-off-by: Piotr Grad <p.grad@samsung.com>
msu.koo [Tue, 3 Feb 2015 01:01:12 +0000 (10:01 +0900)]
fixup! [Tizen][WebRTC] Handle video_facing variable on media device enumeration
- Removed hard-coded device id, name.
- Fix missmatched device id on WebContentDelegateEfl.
- Set default WebRTC camera to Primary(back) camera.
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I0093715746caa2a9ffff8f91336b7c28159a9d62
Signed-off-by: msu.koo <msu.koo@samsung.com>
Karol Furmaniak [Fri, 30 Jan 2015 13:48:28 +0000 (14:48 +0100)]
Remove forwarding shift key events and fix keycode conversion.
[Requirement] WCS TC 90
There was unnecessary shift key event forwarding what causes
wrong events dispatching.
Now after press "A" letter, events are:
keydown
keydown
keypress
composition-end
input
keyup
keyup
but it should be:
keydown
keypress
composition-end
input
keyup
This patch fix this.
Added conversion of keycode.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10687
Reviewed by: Antonio Gomes, Piotr Grad
Change-Id: I892c065edc7490ee66425787d59a6596a4adc0d4
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Dominik Duda [Sat, 31 Jan 2015 12:22:52 +0000 (13:22 +0100)]
Implement "certificate,pem,set" callback.
Original commit:
http://165.213.202.130:8080/#/c/69732/3
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I5375ec9be49518080ec0674d267f99a367d7154e
Signed-off-by: Dominik Duda <d.duda@samsung.com>
Wojciech Bielawski [Tue, 3 Feb 2015 10:17:27 +0000 (11:17 +0100)]
Enable vibration API to be used in mini_browser and efl_webview_app for tizen 2.4
Haptic API usage was disabled in tizen 2.4. This patch enables existing
implementation to be used in mini_browser and efl_webview_app also for tizen 2.4.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10735
Reviewed by: Antonio Gomes, Gyuyoung Kim, joonhwan kwon
Change-Id: I776e484a95053570260fcd4fabaeeb500a064dd3
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Mikolaj Czyzewski [Mon, 15 Dec 2014 16:13:26 +0000 (17:13 +0100)]
Modified utc_gtest_run.sh to run tests one by one.
Changed script for running utc tests so it could handle segfaults.
Previously while running multiple tests when one test had ended with a segfault
the rest of them didn't execute. Now all the test are run one by one.
Tests can be run in a four different ways:
-single test
./utc_gtest_run.sh -s utc_blink_ewk_view_visibility_set.POS_TEST1
-set of tests
./utc_gtest_run.sh -s utc_blink_ewk_view_user_agent*
-tests listed in the file (each test_name/API_function in separate line)
./utc_gtest_run.sh -l file
-all tests
./utc_gtest_run.sh -a
To generate list of all tests:
./utc_gtest_run.sh -g (to stdout)
./utc_gtest_run.sh -g > all_tests.txt
./utc_gtest_run.sh -g | grep ewk_view > ewk_view_tests.txt
The test results are generated in /opt/usr/utc_results/unittest-result-{DATE}-{TIME}
To parse the results:
./utc_gtest_run.sh -p /opt/usr/utc_results/unittest-result-{DATE}-{TIME}
This creates file unittest-result-{DATE}-{TIME}.txt in current directory.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: Ia399e62e59f6af0b061cc03ed313b793ab990073
Signed-off-by: Mikolaj Czyzewski <m.czyzewski@samsung.com>
Lukasz Krok [Thu, 29 Jan 2015 12:23:57 +0000 (13:23 +0100)]
Fix for rest of utc_blink_ewk_error* tests
The utc_blink_ewk_error* tests previous implementation
intention was to cause load error by cancelling resource loading.
As cancelling loading is normal situation, it shouldn't be treated
as error. It was corrected in I8f4e828bfcc63377678e475f44131dbc749b9c7f
change. Because of the change utc_blink_ewk_error_code_get* tests
stopped to pass.
This commit removes resource loading cancellation from tests logic.
Instead of google.com, "page_that_does_not_exist" is now set as url.
Such url usage causes SERVICE_TEMPORARILY_UNAVAILABLE error code.
If device has no network connection, NETWORK_ERROR code is produced.
One test suite - utc_blink_ewk_error_code_get* was already adapted
with a change: I1503f966bd782815760ca6a7fbf129d1e1400102
This patch adapts rest of the tests which have this problem.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10191
Reviewed by: Antonio Gomes, Jaesik Chang, Janusz Majnert, Kamil Klimek
Change-Id: Idda9f18ecd9fbb0ba0b351c6abd65abc7782dad9
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Tomasz Czekala [Fri, 30 Jan 2015 09:07:35 +0000 (10:07 +0100)]
Fix unittests for ewk_settings_text_autosizing_font_scale_factor_set_func
ewk_settings_text_autosizing_font_scale_factor_set_func expects the argument to
be a double value, but was provided a boolean, that was converted to double, but
the unittest was treating in wrong way
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9535
Reviewed by: Hyunhak Kim, Piotr Tworek
Change-Id: I1863d0b8b2f4d6a2365e854f78b56ad0f4538754
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Youngsoo Choi [Mon, 2 Feb 2015 01:58:40 +0000 (10:58 +0900)]
Upversion to elementary-1.7.x
[issue]
The elementary API was changed from version 1.7.x.
[resolve]
This patch meets followings.
Tizen v2.2.1 supports following method.
EAPI Eina_Bool elm_drop_target_del(Evas_Object *obj);
Tizen versions later than Tizen v2.2.1 support following method.
EAPI Eina_Bool elm_drop_target_del(
Evas_Object *obj, Elm_Sel_Format format,
Elm_Drag_State entercb, void *enterdata,
Elm_Drag_State leavecb, void *leavedata,
Elm_Drag_Pos poscb, void *posdata,
Elm_Drop_Cb dropcb, void *dropdata);
Reviewed by: Antonio Gomes, KC Park
Change-Id: I91680bdf2df2452b832ab152c9cc00c6eaaf37c9
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
uzair.jaleel [Wed, 4 Feb 2015 06:00:43 +0000 (11:30 +0530)]
Fix for hang on enabling zero copy
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: Prashant Nevase, venu musham
Change-Id: I807ed39f86b9457044ec1b9e864d45a37c563002
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Jongsoo Yoon [Tue, 3 Feb 2015 05:57:44 +0000 (14:57 +0900)]
Update S_TRUNK_OWNERS of chromium-efl
Update Reviewers.
Modified: S_TRUNK_OWNERS
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10764
Reviewed by: Kamil Klimek, Piotr Grad, Piotr Tworek, Prashant Nevase, jong chul park
Change-Id: Iedf2b14c39326e14bc322d4bd2e9de66f348f3ee
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Youngcheol Kang [Mon, 2 Feb 2015 11:02:20 +0000 (20:02 +0900)]
Change default gbs repo to SPIN's
20150201.1 version for mobile
We will make use of the SPIN's
20150201.1 repo of specific date
for Tizen 2.4 mobile build (arm & i586), instead of the latest repo.
Reviewed by: Antonio Gomes, Piotr Tworek, joonhwan kwon
Change-Id: I22f7a95f81598400b73413b8723c6db54e5d1c18
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
amit.kumar8 [Tue, 20 Jan 2015 15:27:17 +0000 (20:57 +0530)]
[M34-Merge] Adding trace buttons for trace mechanism
Adding Trace buttons for taking runtime traces in m40.
Original patch: http://165.213.202.130:8080/#/c/72299/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10574
Reviewed by: Antonio Gomes, Prashant Nevase
Change-Id: If64012e3340a7e2527f0161da810eb36d25b82c3
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Wojciech Wiśniewski [Tue, 20 Jan 2015 13:17:08 +0000 (14:17 +0100)]
Make pointers into CookieManager thread-safe.
CookieManager class was used mostly through WeakPtr pointers.
These pointers are not thread-safe (they should be dereferenced
and destroyed only in the same thread they were created).
Because CookieManager class is used both from UI and IO browser
threads, it was causing assertion fails in debug builds.
This patch changes WeakPtrs to thread-safe version of scoped_refptrs.
Reviewed by: Daniel Waślicki, Piotr Tworek, SeungSeop Park, arno renevier
Change-Id: I54b7500083e1d54f7cbac223a50f7a9cd5eff95b
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
hyungsun.ryu [Thu, 29 Jan 2015 04:00:09 +0000 (13:00 +0900)]
[SPIN] Enable CAPI port for MediaElement
CAPI regarding X11 can be used since Jan 21. Patch enables the CAPI
port for MediaElement again, and adjusts for the header difference
won Tizen 2.4 (player_internal.h)
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I5c047f72e51e3550168a6942a7f928ac1e9ecaa5
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
Dongjun Kim [Mon, 2 Feb 2015 05:56:55 +0000 (14:56 +0900)]
[M34-Merge] Change the order of parameter in SetWidgetInfo.
The order of parameter was reversed in our latest code.
- parameter from WRT : (widgetHandle, scale, theme, encodedBundle)
- parameter in SetWidgetInfo : (widgetHandle, scale, encodedBundle, theme)
We need to change it for TCT fail in WRT.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9368
Reviewed by: Hyunhak Kim, Janusz Majnert, Piotr Grad, Piotr Tworek
Change-Id: If69b2ab3f2dd16492723456189a5a157adfa289c
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
msu.koo [Wed, 21 Jan 2015 07:30:17 +0000 (16:30 +0900)]
fixup! [Tizen][MM][Webrtc] Video Capture Port using CAPI
This patch is to enable the tizen video capture port on mobile build only.
Together with: I62321a3b0cfba87da4f2acd5ee9e53e80427a4af
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: I55a08af9f9939ec5664815916e408607486544a4
Signed-off-by: msu.koo <msu.koo@samsung.com>
Wojciech Wiśniewski [Wed, 28 Jan 2015 13:59:57 +0000 (14:59 +0100)]
[M34-Merge]Add file:// protocol handler specific for WRT.
This patch is porting of following patches:
http://165.213.202.130:8080/#/c/70649/ by Zbigniew Kostrzewa
http://165.213.202.130:8080/#/c/70977/ by Marek Ruszczyński
http://165.213.202.130:8080/#/c/71786/ by Piotr Szawdyński
(second and third are fixups of the first)
Original commit message:
This commit extends file:// URI scheme to provide features
specific to WRT.
When Chromium launch originates from WRT then each reference
to a resource via file:// URI scheme results in an IPC message
sent from browser to renderer and back to give a chance to WRT
to modify the URI.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10412
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10405
Reviewed by: Jaesik Chang, Piotr Tworek, SeungSeop Park
Change-Id: Id875fd7b03a231a098f8277c6af5f2031da03861
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
Tomasz Czekala [Fri, 30 Jan 2015 07:33:51 +0000 (08:33 +0100)]
Fix invalid check in utc_blink_ewk_view_application_name_for_user_agent_set
When we call ewk_view_application_name_for_user_agent_set with application_name
as NULL, we expect to get default application name for user agent
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I9c8d4fccf3c55b99940d1413b45513f8d1c40819
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Jung-Ick Guack [Mon, 2 Feb 2015 00:05:07 +0000 (09:05 +0900)]
Revert "Add support for focus UI in InputPicker"
This reverts commit
10bccd14b1fa7b03f3933587b0df03813ea5bdd7.
Change-Id: I26ed0f8f965c1ec45b940cb0ca5a111ef00482de
Signed-off-by: Jung-Ick Guack <ji.guack@samsung.com>
Piotr Grad [Sat, 31 Jan 2015 14:20:43 +0000 (15:20 +0100)]
fixup! Provide URL address in NewWindowPolicyDecision object
Fix for build break.
Change-Id: I0b0b66b53170f3cf0c9eda86dba01d808c6c1523
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Daniel Waślicki [Thu, 29 Jan 2015 15:29:27 +0000 (16:29 +0100)]
Provide URL address in NewWindowPolicyDecision object
During creation of a WebContents asynchronously, we use
specific tizen_webview::PolicyDecision constructor, which does
not set almost any members of this class. After this patch
any client application that uses EWK API will be able to at least
check url, scheme and host of a new WebContents. It allows to
perform proper action regarding permitting or prohibitting new
window.
Together with: I8f6ddbd985526772332b7c35f0e61e2c1a3b950b
Change-Id: I8b75b509e8c922f5a1102dbd4c787b93ad54b88e
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Suchit Agrawal [Fri, 30 Jan 2015 13:09:15 +0000 (13:09 +0000)]
Enable parallel canvas by default.
Change-Id: Ifd39640888dc209fa7c82e444105ba604d079c8d
Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Marcin Krakowiak [Fri, 9 Jan 2015 13:30:59 +0000 (14:30 +0100)]
Add support for focus UI in InputPicker
This commit is refactored merge from m34 branch.
Class InputPicker uses now ColorSelector widget from elm for select color.
H/W keyboard can now change values in InputPicker.
Original commit: http://165.213.202.130:8080/#/c/70449/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9615
Change-Id: I8498e99bd45b4bd06d8f5ecca42a3af750e02625
Signed-off-by: Marcin Krakowiak <m.krakowiak@samsung.com>
Sebastian Stolinski [Fri, 30 Jan 2015 12:51:57 +0000 (13:51 +0100)]
fixup! [SPIN] Hotfix for build with gcc 4.6.3
This patch fixes problem with third_party/mesa compilation
when flag _enable_content_shell = 1 and gcc 4.6.3 is used.
Issues with keyword final are resolved.
Mesa repository is not a part of chromium repo
so git patch is prepared.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10841
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, SeungSeop Park
Change-Id: If54ed4441310c8be6c88a20aabd909d0623ab69e
Signed-off-by: Sebastian Stolinski <s.stolinski@samsung.com>
Daniel Waślicki [Fri, 30 Jan 2015 11:22:23 +0000 (12:22 +0100)]
Delay invocation UpdateWebkitPreferences
In current solution we have dependency loop which causes
segmentation fault. During initialization of EWebView, we
invoke a callback which should create and return new WebContents.
During this creation, in WebContentsViewEfl, EWebView's function
is called which expects that web_contents is already initialized.
It causes segmentation fault. Moreover in EWebView's function we have
to make sure that RenderView is already created. Thus solution to this
issue is to delay invocation of this function by posting task to
browser's UI thread.
Reviewed by: Antonio Gomes, DONGJUN KiM, Piotr Tworek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10439
Change-Id: Id0cbeafc08fd3bd9770a8d3968812d76e846509d
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Karol Furmaniak [Fri, 30 Jan 2015 07:10:02 +0000 (08:10 +0100)]
Remove unnecessary EwkViewMsg_SelectClosestWord IPC message.
IPC message EwkViewMsg_SelectClosestWord is not needed. There
is already ViewMsg_SelectClosestWord instead.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek
Change-Id: I309d3a773d7e2dc33134e6a27c4ccabe6d4243dd
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Jongsoo Yoon [Fri, 30 Jan 2015 08:31:37 +0000 (17:31 +0900)]
fixup! Update S_TRUNK_OWNERS of chromium-efl
Change-Id: I8c25f88b6ab6272dcf00d375b34bf641d8120398
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
msu.koo [Mon, 26 Jan 2015 09:51:02 +0000 (18:51 +0900)]
[Tizen][WebRTC] Handle video_facing variable on media device enumeration
This fix is required to support "facingMode" on WebRTC Spec.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10756
Reviewed by: SeungSeop Park, Venugopal S M
Change-Id: Ic3326686a9605645eed5fb073ce94a3225158be4
Signed-off-by: msu.koo <msu.koo@samsung.com>
Tomasz Czekala [Sun, 25 Jan 2015 11:03:41 +0000 (12:03 +0100)]
Fix possible memory corruptions in policy decision dispatching logic
In some cases suspended policy decisions could be deleted by new policy
decision events. This patch fixes that also providing some feedback for
policy decisions that can't be suspended at all.
This patch is a port of this patch:
http://165.213.202.130:8080/#/c/70024/
by Kamil Klimek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10629
Reviewed by: Piotr Tworek, arno renevier
Change-Id: I4431c4c8e9ec0deb4f7c76ea494ef47bec6de0d5
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Jongsoo Yoon [Thu, 29 Jan 2015 07:25:11 +0000 (16:25 +0900)]
fixup! Upgrade EFL version for desktop to 1.9.5.
Since the upgrade to EFL version 1.9.5, some dependency packages
need to be manually installed.
Steps were executed on the build machine.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10823
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I84798f2d422d4b22e5c288ea0bf83ba25e211096
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
hyunjune.kim [Tue, 27 Jan 2015 01:06:25 +0000 (10:06 +0900)]
Disable zygote if sandboxing is disabled.
Original patches:
1) Provide mechanism for disabling zygote process
http://165.213.202.130:8080/#/c/69365/
2) Provide mechanism for disabling sandbox process
http://165.213.202.130:8080/#/c/69549/
3) fixup! Provide mechanism for disabling Sandbox-IPC process.
http://165.213.202.130:8080/#/c/71123/4/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5385
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Ibaff8775a21e2eafd93b9c52184e7868452ab183
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
Karol Furmaniak [Thu, 29 Jan 2015 10:37:14 +0000 (11:37 +0100)]
[M34-Merge] Impl for open page in overview mode.
initialize_at_minimum_page_scale flag is set
with ewk_settings_auto_fitting_set value and
its solving all requirements.
This flag is passed to set loadWithOverviewMode field in WebSettings
via ApplyWebPreferences function.
Original patches:
http://165.213.202.130:8080/#/c/70208/
http://165.213.202.130:8080/#/c/70311/
Original author: Marcin Krakowiak <m.krakowiak@samsung.com>
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10660
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I7d4bd96ab4cbdd2321e1baa83db36c779c906a40
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>