platform/upstream/v8.git
11 years agoFast-forward version number on bleeding_edge. Now working on version 3.19.0.
danno@chromium.org [Tue, 7 May 2013 11:43:43 +0000 (11:43 +0000)]
Fast-forward version number on bleeding_edge. Now working on version 3.19.0.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/14580009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14567 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoadd weakcallback without persistent copying
dcarney@chromium.org [Tue, 7 May 2013 10:44:30 +0000 (10:44 +0000)]
add weakcallback without persistent copying

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14908004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14566 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix polymorphic to monomorphic load to take representation into account.
verwaest@chromium.org [Tue, 7 May 2013 10:32:23 +0000 (10:32 +0000)]
Fix polymorphic to monomorphic load to take representation into account.

Review URL: https://chromiumcodereview.appspot.com/14966005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoPerform incremental marking step after free-list allocation and clean-up incremental...
hpayer@chromium.org [Tue, 7 May 2013 09:48:42 +0000 (09:48 +0000)]
Perform incremental marking step after free-list allocation and clean-up incremental marking start condition.

BUG=

Review URL: https://codereview.chromium.org/14634007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14564 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoGenerators return boxed values
wingo@igalia.com [Tue, 7 May 2013 08:46:42 +0000 (08:46 +0000)]
Generators return boxed values

Generators now box their return values in object literals of the form

  { value: VAL, done: DONE }

where DONE is false for yield expressions, and true for return
statements.

BUG=v8:2355
TEST=mjsunit/harmony/generators-iteration
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/13870007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14563 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoremove use of WriteAscii for vtune
dcarney@chromium.org [Tue, 7 May 2013 07:23:39 +0000 (07:23 +0000)]
remove use of WriteAscii for vtune

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14900003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdded an extra flag that enables only ArrayBuffer.
dslomov@chromium.org [Mon, 6 May 2013 16:19:27 +0000 (16:19 +0000)]
Added an extra flag that enables only ArrayBuffer.

This makes Blink experimentation easier.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14884012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix incremental marking speed accelleration and start incremental marking when old...
hpayer@chromium.org [Mon, 6 May 2013 16:17:49 +0000 (16:17 +0000)]
Fix incremental marking speed accelleration and start incremental marking when old space is almost full when pretenuring objects.

BUG=

Review URL: https://codereview.chromium.org/14714004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14559 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert fix incremental marking speed accelleration and start incremental marking...
hpayer@chromium.org [Mon, 6 May 2013 13:39:54 +0000 (13:39 +0000)]
Revert fix incremental marking speed accelleration and start incremental marking when old space is almost full when pretenuring objects.

BUG=

Review URL: https://codereview.chromium.org/14988004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix incremental marking speed accelleration and start incremental marking when old...
hpayer@chromium.org [Mon, 6 May 2013 13:07:10 +0000 (13:07 +0000)]
Fix incremental marking speed accelleration and start incremental marking when old space is almost full when pretenuring objects.

BUG=

Review URL: https://codereview.chromium.org/14649014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14555 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMake v8 compilable without V8_USE_UNSAFE_HANDLES.
dcarney@chromium.org [Mon, 6 May 2013 13:01:03 +0000 (13:01 +0000)]
Make v8 compilable without V8_USE_UNSAFE_HANDLES.

Without this modification, we get this error: "dereferencing type-punned pointer
will break strict-aliasing rules" (GCC strict aliasing).

Also included small CcTest sanity fixes: isolate() cannot return anything else
than default_isolate().

BUG=
TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/14894006

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14554 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoParallel compilation fix: the optimizer thread shouldn't change the allow allocation...
mvstanton@chromium.org [Mon, 6 May 2013 10:59:17 +0000 (10:59 +0000)]
Parallel compilation fix: the optimizer thread shouldn't change the allow allocation state on AssertNoAllocation scopes.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/14796014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix occasional crash when lithium goes out of vregs.
mmassi@chromium.org [Mon, 6 May 2013 09:27:06 +0000 (09:27 +0000)]
Fix occasional crash when lithium goes out of vregs.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/14850013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14550 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Pretenure ASCII cons string in high promotion mode.
palfia@homejinni.com [Fri, 3 May 2013 23:55:08 +0000 (23:55 +0000)]
MIPS: Pretenure ASCII cons string in high promotion mode.

Port r14540 (c6093a6e)

BUG=

Review URL: https://codereview.chromium.org/14678006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Before comparing input with a constant smi in GenerateRecordCallTarget(), make...
palfia@homejinni.com [Fri, 3 May 2013 23:51:25 +0000 (23:51 +0000)]
MIPS: Before comparing input with a constant smi in GenerateRecordCallTarget(), make sure the input register is actually a smi.

Port r14547 (a2e764c7)

BUG=

Review URL: https://codereview.chromium.org/14597006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14548 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoBefore comparing input with a constant smi in GenerateRecordCallTarget(), make sure...
mvstanton@chromium.org [Fri, 3 May 2013 15:18:31 +0000 (15:18 +0000)]
Before comparing input with a constant smi in GenerateRecordCallTarget(), make sure the input register is actually a smi.

BUG=

Review URL: https://codereview.chromium.org/14803005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14547 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoCache first hint operand while building live ranges.
mstarzinger@chromium.org [Fri, 3 May 2013 14:58:06 +0000 (14:58 +0000)]
Cache first hint operand while building live ranges.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14771015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14546 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoDon't double unlink in DCE.
verwaest@chromium.org [Fri, 3 May 2013 13:39:11 +0000 (13:39 +0000)]
Don't double unlink in DCE.

Review URL: https://chromiumcodereview.appspot.com/14914004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14545 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agotoString() on generator functions prints with function*
wingo@igalia.com [Fri, 3 May 2013 13:01:28 +0000 (13:01 +0000)]
toString() on generator functions prints with function*

This CL adds a %FunctionIsGenerator runtime function, and uses it in the
function toString() implementation.

R=mstarzinger@chromium.org
BUG=v8:2355
TEST=mjsunit/harmony/generators-runtime

Review URL: https://codereview.chromium.org/14912002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRemove obsolete LiveRange::FirstPosWithHint helper.
mstarzinger@chromium.org [Fri, 3 May 2013 12:49:48 +0000 (12:49 +0000)]
Remove obsolete LiveRange::FirstPosWithHint helper.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14650016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14543 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRemove HLoadElements instruction and replace with use of more general HLoadNamedField...
titzer@chromium.org [Fri, 3 May 2013 12:21:16 +0000 (12:21 +0000)]
Remove HLoadElements instruction and replace with use of more general HLoadNamedField. This removes the need for both the hydrogen and lithium instructions and allows both kinds of loads to be GVN'd.

Review URL: https://codereview.chromium.org/14556020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14542 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoTurn on tracking of fields.
verwaest@chromium.org [Fri, 3 May 2013 11:05:54 +0000 (11:05 +0000)]
Turn on tracking of fields.

Review URL: https://chromiumcodereview.appspot.com/14771014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14541 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoPretenure ASCII cons string in high promotion mode.
hpayer@chromium.org [Fri, 3 May 2013 10:36:16 +0000 (10:36 +0000)]
Pretenure ASCII cons string in high promotion mode.

BUG=

Review URL: https://codereview.chromium.org/14451003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14540 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agod8 shell fix for r14530
dcarney@chromium.org [Fri, 3 May 2013 10:36:13 +0000 (10:36 +0000)]
d8 shell fix for r14530

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14907004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdd type checks to typed array property getters.
dslomov@chromium.org [Fri, 3 May 2013 09:59:50 +0000 (09:59 +0000)]
Add type checks to typed array property getters.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14650014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14538 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoImplement TypedArray.subarray method.
dslomov@chromium.org [Fri, 3 May 2013 09:43:44 +0000 (09:43 +0000)]
Implement TypedArray.subarray method.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14740017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14537 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRemove 'unanimous use observations' rule from Phi representation inference
jkummerow@chromium.org [Fri, 3 May 2013 08:50:48 +0000 (08:50 +0000)]
Remove 'unanimous use observations' rule from Phi representation inference

Review URL: https://codereview.chromium.org/14840014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14536 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoOverwrite the handler using Set.
verwaest@chromium.org [Fri, 3 May 2013 08:48:53 +0000 (08:48 +0000)]
Overwrite the handler using Set.
InsertAt apparently inserts by moving the other elements... that does not work.

Review URL: https://chromiumcodereview.appspot.com/14566007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoUse first position in LAllocator ordering heuristic.
mstarzinger@chromium.org [Fri, 3 May 2013 08:09:37 +0000 (08:09 +0000)]
Use first position in LAllocator ordering heuristic.

This changes the tiebreaker for LAllocator's ordering heuristic of
live ranges to use the first use position instead of the first hinted
use position. Searching for the first hinted position introduces
unnecessary overhead.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14855010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14534 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agodeprecate WriteAscii and MayContainNonAscii
dcarney@chromium.org [Fri, 3 May 2013 06:47:24 +0000 (06:47 +0000)]
deprecate WriteAscii and MayContainNonAscii

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14638003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14533 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agobuild fix for 14530
dcarney@chromium.org [Thu, 2 May 2013 22:00:39 +0000 (22:00 +0000)]
build fix for 14530

TBR=svenpanne@chromium.org
BUG=
TEST=

Review URL: https://codereview.chromium.org/14881002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoexpose AssertNoAllocation to api
dcarney@chromium.org [Thu, 2 May 2013 20:28:02 +0000 (20:28 +0000)]
expose AssertNoAllocation to api

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14625003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14531 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agofirst step to remove unsafe handles
dcarney@chromium.org [Thu, 2 May 2013 20:18:42 +0000 (20:18 +0000)]
first step to remove unsafe handles

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/12729023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Turn the load field code stub into a hydrogen code stub.
palfia@homejinni.com [Thu, 2 May 2013 18:25:16 +0000 (18:25 +0000)]
MIPS: Turn the load field code stub into a hydrogen code stub.

Port r14526 (7c581932)

BUG=

Review URL: https://codereview.chromium.org/14855008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14529 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoUse worklist to find out Phis that could not be truncated to int32
jkummerow@chromium.org [Thu, 2 May 2013 17:00:53 +0000 (17:00 +0000)]
Use worklist to find out Phis that could not be truncated to int32

Review URL: https://codereview.chromium.org/13950013

Patch from Haitao Feng <haitao.feng@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix typo in cctest.status
jkummerow@chromium.org [Thu, 2 May 2013 16:55:18 +0000 (16:55 +0000)]
Fix typo in cctest.status

Review URL: https://codereview.chromium.org/14854011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14527 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoTurn the load field code stub into a hydrogen code stub.
verwaest@chromium.org [Thu, 2 May 2013 16:32:47 +0000 (16:32 +0000)]
Turn the load field code stub into a hydrogen code stub.

Review URL: https://chromiumcodereview.appspot.com/14847004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoDetect truncating Phi uses of Phis with constant inputs
jkummerow@chromium.org [Thu, 2 May 2013 16:30:58 +0000 (16:30 +0000)]
Detect truncating Phi uses of Phis with constant inputs

Review URL: https://codereview.chromium.org/14260013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14525 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoCleanup IC heuristics.
verwaest@chromium.org [Thu, 2 May 2013 15:42:22 +0000 (15:42 +0000)]
Cleanup IC heuristics.

Review URL: https://chromiumcodereview.appspot.com/14611006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14524 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdding fast path for generalizing maps.
verwaest@chromium.org [Thu, 2 May 2013 15:41:02 +0000 (15:41 +0000)]
Adding fast path for generalizing maps.

Review URL: https://chromiumcodereview.appspot.com/14629005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14523 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoUpdate deprecated maps before generating optimized code.
verwaest@chromium.org [Thu, 2 May 2013 15:40:07 +0000 (15:40 +0000)]
Update deprecated maps before generating optimized code.

Review URL: https://chromiumcodereview.appspot.com/14847008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14522 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAlways tag number candidate as smi if it does not come from load-keyed.
verwaest@chromium.org [Thu, 2 May 2013 14:41:06 +0000 (14:41 +0000)]
Always tag number candidate as smi if it does not come from load-keyed.

Review URL: https://chromiumcodereview.appspot.com/14556007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAllow pathological zero-length typed arrays.
dslomov@chromium.org [Thu, 2 May 2013 13:51:03 +0000 (13:51 +0000)]
Allow pathological zero-length typed arrays.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14857002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRange checking bug in typed array constructor.
dslomov@chromium.org [Thu, 2 May 2013 13:30:57 +0000 (13:30 +0000)]
Range checking bug in typed array constructor.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14850011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14519 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMore typed array constructors.
dslomov@chromium.org [Thu, 2 May 2013 12:27:03 +0000 (12:27 +0000)]
More typed array constructors.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14845012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoImplementation of Uint8ClampedArray.
dslomov@chromium.org [Thu, 2 May 2013 11:36:48 +0000 (11:36 +0000)]
Implementation of Uint8ClampedArray.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14657003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14517 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoBump virtual register width in LUnallocated.
mstarzinger@chromium.org [Thu, 2 May 2013 11:22:32 +0000 (11:22 +0000)]
Bump virtual register width in LUnallocated.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14589008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14516 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAllow more virtual registers to be encoded in LUnallocated.
mstarzinger@chromium.org [Thu, 2 May 2013 09:51:07 +0000 (09:51 +0000)]
Allow more virtual registers to be encoded in LUnallocated.

This is a preparation which allows us to bump the virtual register width
from 15 to 18 bit without sacrificing width for other fields inside an
unallocated lithium operand.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14639008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Fix mjsunit/harmony/generators-iteration test failure.
palfia@homejinni.com [Tue, 30 Apr 2013 22:54:36 +0000 (22:54 +0000)]
MIPS: Fix mjsunit/harmony/generators-iteration test failure.

BUG=

Review URL: https://codereview.chromium.org/14695004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14512 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Allow setting debugger breakpoints on CompareNilICs
palfia@homejinni.com [Tue, 30 Apr 2013 19:09:33 +0000 (19:09 +0000)]
MIPS: Allow setting debugger breakpoints on CompareNilICs

Port r14487 (022d1fc3)

BUG=

Review URL: https://codereview.chromium.org/14662002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14509 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdd Value::Is* methods for typed arrays and ArrayBuffer
dslomov@chromium.org [Tue, 30 Apr 2013 18:53:27 +0000 (18:53 +0000)]
Add Value::Is* methods for typed arrays and ArrayBuffer

R=rossberg
BUG=

Committed https://code.google.com/p/v8/source/detail?r=14506

Review URL: https://codereview.chromium.org/13977018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14508 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert "Fix typo"
dslomov@chromium.org [Tue, 30 Apr 2013 18:49:20 +0000 (18:49 +0000)]
Revert "Fix typo"

This reverts commit r14506 (that was commited with a wrong description).

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14507 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix typo
dslomov@chromium.org [Tue, 30 Apr 2013 18:02:22 +0000 (18:02 +0000)]
Fix typo

R=rossberg@chromium.org

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14505

Review URL: https://codereview.chromium.org/13993029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14506 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix typo
dslomov@chromium.org [Tue, 30 Apr 2013 17:57:54 +0000 (17:57 +0000)]
Fix typo

R=rossberg@chromium.org

BUG=

Review URL: https://codereview.chromium.org/13993029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14505 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert "patch from issue 13993029"
dslomov@chromium.org [Tue, 30 Apr 2013 17:56:32 +0000 (17:56 +0000)]
Revert "patch from issue 13993029"

This reverts commit 2d49d456dd09a8f8ffae87f777d5f10b587534e8.
Revert patch with incorrect description

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14504 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agopatch from issue 13993029
dslomov@chromium.org [Tue, 30 Apr 2013 17:50:04 +0000 (17:50 +0000)]
patch from issue 13993029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14503 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert "frames.h/cc cleanup"
yurys@chromium.org [Tue, 30 Apr 2013 16:51:30 +0000 (16:51 +0000)]
Revert "frames.h/cc cleanup"

This reverts r14496 which broke tests in debug mode:

Command: /mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/Debug/cctest test-log/LogAccessorCallbacks --nobreak-on-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --testing_serialization_file=/mnt/data/b/build/slave/v8-linux-nosnap-debug/build/v8/out/.serdes/serdes_LogAccessorCallbacks
=== cctest/test-log/LogCallbacks ===
--- stderr ---

TBR=jkummerow@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/14651004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14502 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoPrepare push to trunk. Now working on version 3.18.6.
danno@chromium.org [Tue, 30 Apr 2013 16:36:14 +0000 (16:36 +0000)]
Prepare push to trunk.  Now working on version 3.18.6.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14646011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14497 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoframes.h/cc cleanup
yurys@chromium.org [Tue, 30 Apr 2013 14:37:18 +0000 (14:37 +0000)]
frames.h/cc cleanup

BUG=None
R=jkummerow@chromium.org, loislo@chromium.org

Review URL: https://codereview.chromium.org/14650002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14496 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoTwo bugfixes for hydrogen-based array constructors
mvstanton@chromium.org [Tue, 30 Apr 2013 13:43:45 +0000 (13:43 +0000)]
Two bugfixes for hydrogen-based array constructors

CacheInitialJSArrayMaps needs to be able to pick up where it left off,
as it can now be called from a handlfied context.

Disable incremental marking for CCTest SetJitCodeEventHandler, as it allocates
during compilation.

BUG=

Review URL: https://codereview.chromium.org/14642002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14495 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAccurate function prototypes for native calls from ARM simulator.
dslomov@chromium.org [Tue, 30 Apr 2013 11:34:43 +0000 (11:34 +0000)]
Accurate function prototypes for native calls from ARM simulator.

This is a resubmit of codereview.chromium.org/13818012 with the following modifications:
- src/x64/code-stubs-x64.cc for changes specific to Win64   calling conventions.
- src/sampler.cc for Native Client support

BUG=v8:2614

Committed: https://code.google.com/p/v8/source/detail?r=14491

Review URL: https://codereview.chromium.org/14305029

Patch from Brad Chen <bradchen@google.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert "Accurate function prototypes for native calls from ARM simulator."
dslomov@chromium.org [Tue, 30 Apr 2013 11:31:09 +0000 (11:31 +0000)]
Revert "Accurate function prototypes for native calls from ARM simulator."

This reverts commit r14991. (one file missing)

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14493 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRevert "Flag optimize-constructed-arrays turned on."
dslomov@chromium.org [Tue, 30 Apr 2013 11:23:34 +0000 (11:23 +0000)]
Revert "Flag optimize-constructed-arrays turned on."

This reverts commit r14491.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAccurate function prototypes for native calls from ARM simulator.
dslomov@chromium.org [Tue, 30 Apr 2013 11:16:40 +0000 (11:16 +0000)]
Accurate function prototypes for native calls from ARM simulator.

This is a resubmit of codereview.chromium.org/13818012 with the following modifications:
- src/x64/code-stubs-x64.cc for changes specific to Win64   calling conventions.
- src/sampler.cc for Native Client support

BUG=v8:2614

Review URL: https://codereview.chromium.org/14305029

Patch from Brad Chen <bradchen@google.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFlag optimize-constructed-arrays turned on.
mvstanton@chromium.org [Tue, 30 Apr 2013 08:22:05 +0000 (08:22 +0000)]
Flag optimize-constructed-arrays turned on.

This routes array construction through a hydrogen stub, and enables use of
allocation site info tracking.

BUG=

Review URL: https://codereview.chromium.org/14616010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMake UsePosition::hint immutable.
mstarzinger@chromium.org [Tue, 30 Apr 2013 08:21:52 +0000 (08:21 +0000)]
Make UsePosition::hint immutable.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14524008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14489 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix HConstant::InNewSpace() for parallel compilation.
mstarzinger@chromium.org [Tue, 30 Apr 2013 08:00:43 +0000 (08:00 +0000)]
Fix HConstant::InNewSpace() for parallel compilation.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/13977019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14488 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAllow setting debugger breakpoints on CompareNilICs
danno@chromium.org [Tue, 30 Apr 2013 07:56:09 +0000 (07:56 +0000)]
Allow setting debugger breakpoints on CompareNilICs

BUG=v8:2660
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14106011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14487 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoTypedArray(length) constructor
dslomov@chromium.org [Mon, 29 Apr 2013 16:16:31 +0000 (16:16 +0000)]
TypedArray(length) constructor

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14460008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14486 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix bug in CompareNil IC
danno@chromium.org [Mon, 29 Apr 2013 15:09:22 +0000 (15:09 +0000)]
Fix bug in CompareNil IC

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/13863022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix GCMole after r14476
dslomov@chromium.org [Mon, 29 Apr 2013 15:05:06 +0000 (15:05 +0000)]
Fix GCMole after r14476

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13945026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix beyond-heap load on x64 Crankshafted StringCharFromCode
danno@chromium.org [Mon, 29 Apr 2013 14:34:24 +0000 (14:34 +0000)]
Fix beyond-heap load on x64 Crankshafted StringCharFromCode

BUG=chromium:235311
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14387008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoShared build fix
dslomov@chromium.org [Mon, 29 Apr 2013 14:13:32 +0000 (14:13 +0000)]
Shared build fix

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14396004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoDo not use repeated subtractions in mod-i, it hurts performance in general.
svenpanne@chromium.org [Mon, 29 Apr 2013 13:45:34 +0000 (13:45 +0000)]
Do not use repeated subtractions in mod-i, it hurts performance in general.

ARM only: Check for -0 only when really necessary. Tiny code de-duplication.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14499011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAlso print the exception when mksnapshot failed to compile extra code.
svenpanne@chromium.org [Mon, 29 Apr 2013 11:49:24 +0000 (11:49 +0000)]
Also print the exception when mksnapshot failed to compile extra code.

Before, it would only print the exception when it failed to run the code

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/14031036

Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoRemove __ prefix from Harmony typed arrays implementation
dslomov@chromium.org [Mon, 29 Apr 2013 11:18:27 +0000 (11:18 +0000)]
Remove __ prefix from Harmony typed arrays implementation

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14402026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14477 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFirst cut at API for native Typed Arrays.
dslomov@chromium.org [Mon, 29 Apr 2013 11:09:03 +0000 (11:09 +0000)]
First cut at API for native Typed Arrays.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14195034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14476 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix build failure on Win64 since r14458.
mstarzinger@chromium.org [Mon, 29 Apr 2013 09:30:11 +0000 (09:30 +0000)]
Fix build failure on Win64 since r14458.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/14150019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14475 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Track storage types of instance variables.
palfia@homejinni.com [Fri, 26 Apr 2013 23:28:09 +0000 (23:28 +0000)]
MIPS: Track storage types of instance variables.

Port r14464 (70300e97) and r14470 (65af80fc)

BUG=

Review URL: https://codereview.chromium.org/14305024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: Lithium: avoid registers for constants when possible.
palfia@homejinni.com [Fri, 26 Apr 2013 23:26:52 +0000 (23:26 +0000)]
MIPS: Lithium: avoid registers for constants when possible.

Port r14460 (9e3dab0c)

BUG=

Review URL: https://codereview.chromium.org/14520016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix arm port of tracking field representations. Based on Rodolph Perfetta's comments
verwaest@chromium.org [Fri, 26 Apr 2013 19:21:54 +0000 (19:21 +0000)]
Fix arm port of tracking field representations. Based on Rodolph Perfetta's comments

BUG=

Review URL: https://chromiumcodereview.appspot.com/14522003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoMIPS: HasOnlyAsciiChars can return incorrect results. Fixup usages and rename.
palfia@homejinni.com [Fri, 26 Apr 2013 17:52:08 +0000 (17:52 +0000)]
MIPS: HasOnlyAsciiChars can return incorrect results. Fixup usages and rename.

Port r14453 (91869730)

BUG=

Review URL: https://codereview.chromium.org/14455010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoHConstant::InNewSpace() should be a constant function
mvstanton@chromium.org [Fri, 26 Apr 2013 15:48:13 +0000 (15:48 +0000)]
HConstant::InNewSpace() should be a constant function

BUG=

Review URL: https://codereview.chromium.org/14455004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix static initializers on x64
jkummerow@chromium.org [Fri, 26 Apr 2013 15:46:51 +0000 (15:46 +0000)]
Fix static initializers on x64

Review URL: https://codereview.chromium.org/14143009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoTrack storage types of instance variables.
verwaest@chromium.org [Fri, 26 Apr 2013 15:30:41 +0000 (15:30 +0000)]
Track storage types of instance variables.

Review URL: https://chromiumcodereview.appspot.com/14146005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix build failure on Win64 since r14458.
mstarzinger@chromium.org [Fri, 26 Apr 2013 15:10:34 +0000 (15:10 +0000)]
Fix build failure on Win64 since r14458.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14143008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoChange 'Parse error' to three more informative messages.
mvstanton@chromium.org [Fri, 26 Apr 2013 14:26:54 +0000 (14:26 +0000)]
Change 'Parse error' to three more informative messages.

Replace the 'unable_to_parse' key used in three places with three difference keys.
Provide three more informative and less ambiguous error messages in place of 'Parse error'.

Add three test/message cases to cover the new messages.

BUG=2636

Review URL: https://codereview.chromium.org/14161007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14462 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoremove IsOneByteConvertible
dcarney@chromium.org [Fri, 26 Apr 2013 14:08:18 +0000 (14:08 +0000)]
remove IsOneByteConvertible

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14298021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoLithium: avoid registers for constants when possible.
mvstanton@chromium.org [Fri, 26 Apr 2013 14:04:07 +0000 (14:04 +0000)]
Lithium: avoid registers for constants when possible.

BUG=

Review URL: https://codereview.chromium.org/14364010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdd assertion about module scopes to Scope::ContextChainLength.
mstarzinger@chromium.org [Fri, 26 Apr 2013 13:22:11 +0000 (13:22 +0000)]
Add assertion about module scopes to Scope::ContextChainLength.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/14513002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoAdd support for yield expressions
mstarzinger@chromium.org [Fri, 26 Apr 2013 12:09:32 +0000 (12:09 +0000)]
Add support for yield expressions

This CL extends the generator suspend and resume implementation to
capture values on the operand stack.

It factors out some helpers to measure and access the operand stack into
the JavaScriptFrame class.  It also refactors the suspend and resume
helpers to avoid handle allocation.

BUG=v8:2355
TEST=mjsunit/harmony/generators-iteration

Review URL: https://codereview.chromium.org/14348003

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoPrepare push to trunk. Now working on version 3.18.5.
danno@chromium.org [Fri, 26 Apr 2013 11:59:17 +0000 (11:59 +0000)]
Prepare push to trunk.  Now working on version 3.18.5.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/13886016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix yield inside with
mstarzinger@chromium.org [Fri, 26 Apr 2013 11:55:22 +0000 (11:55 +0000)]
Fix yield inside with

This patch makes it so that suspending generators always saves the
context.  Previously we erroneously assumed that if the operand stack
was empty, that the context would be unchanged, but that is not the case
with "with".

Fixing this brought out an interesting bug in the variable allocator.
Yield inside with will reference a context-allocated temporary holding
the generator object.  Before the fix, this object was looked up in the
with context instead of the function context, because with contexts were
not being simulated during full-codegen.  Previously this was OK as all
variables would be given LOOKUP allocation instead of CONTEXT, but the
context-allocated temporary invalidated this assumption.  The fix is to
simulate the context chain more accurately in full-codegen.

R=mstarzinger@chromium.org
BUG=v8:2355
TEST=mjsunit/harmony/generators-iteration

Review URL: https://codereview.chromium.org/14416011

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoHasOnlyAsciiChars can return incorrect results. Fixup usages and rename.
dcarney@chromium.org [Fri, 26 Apr 2013 11:34:44 +0000 (11:34 +0000)]
HasOnlyAsciiChars can return incorrect results. Fixup usages and rename.

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14509012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoforgot parends around macro arg
dcarney@chromium.org [Fri, 26 Apr 2013 10:52:14 +0000 (10:52 +0000)]
forgot parends around macro arg

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14334009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoBootstrapper code for constructed arrays needs to be handlefied
mvstanton@chromium.org [Fri, 26 Apr 2013 10:10:36 +0000 (10:10 +0000)]
Bootstrapper code for constructed arrays needs to be handlefied

BUG=

Review URL: https://codereview.chromium.org/14008004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14451 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoImplement support for Math.imul in Crankshaft.
mstarzinger@chromium.org [Fri, 26 Apr 2013 08:52:35 +0000 (08:52 +0000)]
Implement support for Math.imul in Crankshaft.

R=jkummerow@chromium.org
TEST=mjsunit/math-imul

Review URL: https://codereview.chromium.org/14471041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoFix test/build failures (win64 compile warning, isolate test parallel compilation...
mvstanton@chromium.org [Fri, 26 Apr 2013 08:49:20 +0000 (08:49 +0000)]
Fix test/build failures (win64 compile warning, isolate test parallel compilation failure, gcmole issue, isolate test intermittant failure)

BUG=

Review URL: https://codereview.chromium.org/14265024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoBetter handling of Phi nodes with constant inputs
jkummerow@chromium.org [Fri, 26 Apr 2013 08:47:02 +0000 (08:47 +0000)]
Better handling of Phi nodes with constant inputs

Review URL: https://codereview.chromium.org/14471034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11 years agoPrevent false positive from GCMole in DeferredFormatStackTrace.
mstarzinger@chromium.org [Fri, 26 Apr 2013 08:12:21 +0000 (08:12 +0000)]
Prevent false positive from GCMole in DeferredFormatStackTrace.

R=yangguo@chromium.org
TEST=gcmole

Review URL: https://codereview.chromium.org/14416010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14447 ce2b1a6d-e550-0410-aec6-3dcde31c8c00