fmalita [Wed, 19 Nov 2014 17:23:22 +0000 (09:23 -0800)]
Add an image filter row to GM:lcdtextprops
We should be disabling LCD text when rendering image filters, but
currently don't. Add a GM to capture this behavior.
R=reed@google.com
Review URL: https://codereview.chromium.org/
741433003
bsalomon [Wed, 19 Nov 2014 16:59:58 +0000 (08:59 -0800)]
Remove /arch:SSE2 from Win 64 Release builds
Review URL: https://codereview.chromium.org/
740733002
humper [Wed, 19 Nov 2014 16:32:19 +0000 (08:32 -0800)]
add runtime config option to retain stream for custom typefaces
BUG=skia:
Review URL: https://codereview.chromium.org/
729973004
joshualitt [Wed, 19 Nov 2014 16:24:09 +0000 (08:24 -0800)]
move GrGeometryProcessor to src
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
739943003
bsalomon [Wed, 19 Nov 2014 16:23:49 +0000 (08:23 -0800)]
Create GrOptDrawState before recording draw in GrInOrderDrawBuffer
Review URL: https://codereview.chromium.org/
739673002
reed [Wed, 19 Nov 2014 16:04:34 +0000 (08:04 -0800)]
Allow pictures to have a full bounds
This reverts commit
7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264.
BUG=skia:
Review URL: https://codereview.chromium.org/
738083002
reed [Wed, 19 Nov 2014 15:17:16 +0000 (07:17 -0800)]
Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/
736583004/)
Reason for revert:
needed to update legacy width() helpers
Original issue's description:
> allow pictures to have a full bounds
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
7e76bff26e7c74902841ca4f607eb0b24a833a4a
TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
722043005
reed [Wed, 19 Nov 2014 14:59:41 +0000 (06:59 -0800)]
allow pictures to have a full bounds
BUG=skia:
Review URL: https://codereview.chromium.org/
736583004
egdaniel [Wed, 19 Nov 2014 14:22:39 +0000 (06:22 -0800)]
Add processor name to comment when printing out shaders.
BUG=skia:
Review URL: https://codereview.chromium.org/
735153002
reed [Wed, 19 Nov 2014 13:03:18 +0000 (05:03 -0800)]
add roundOut that returns its result
BUG=skia:
Review URL: https://codereview.chromium.org/
742663002
skia.buildbots [Wed, 19 Nov 2014 07:06:53 +0000 (23:06 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
738003002
reed [Wed, 19 Nov 2014 02:06:45 +0000 (18:06 -0800)]
change roundOut() to take a dst, so we can use that signature to return IRect
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/
731373003
joshualitt [Wed, 19 Nov 2014 01:38:35 +0000 (17:38 -0800)]
setting patch_primitive_nvprmsaa4 on K1 to ignore
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
743563003
joshualitt [Tue, 18 Nov 2014 22:24:27 +0000 (14:24 -0800)]
drawinfo carries bufferinfo
BUG=skia:
Review URL: https://codereview.chromium.org/
737723003
Greg Humphreys [Tue, 18 Nov 2014 20:42:19 +0000 (15:42 -0500)]
ignore dashcubics test pending skia bug 2049
BUG=skia:2049
Review URL: https://codereview.chromium.org/
741533002
Greg Humphreys [Tue, 18 Nov 2014 20:23:05 +0000 (15:23 -0500)]
a few straggling rebaselines
BUG=skia:
Review URL: https://codereview.chromium.org/
738943003
Greg Humphreys [Tue, 18 Nov 2014 20:19:45 +0000 (15:19 -0500)]
more rebaselines for the perspective test server
BUG=skia:
Review URL: https://codereview.chromium.org/
727063004
Greg Humphreys [Tue, 18 Nov 2014 20:15:27 +0000 (15:15 -0500)]
rebaseline new GTX images from drive update on linux
BUG=skia:
TBR=borenet
NOTRY=true
Review URL: https://codereview.chromium.org/
735833002
robertphillips [Tue, 18 Nov 2014 19:53:02 +0000 (11:53 -0800)]
Add computation of saveLayer information to RecordingBench
In (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/
721883002/) I claimed the extra recording cost would be negligible. This CL attempts to put some numbers behind that.
Review URL: https://codereview.chromium.org/
741523002
halcanary [Tue, 18 Nov 2014 19:30:20 +0000 (11:30 -0800)]
skbug.com/3130 step 4 (include/utils/SkWGL.h gone for good)
BUG=skia:3130
Review URL: https://codereview.chromium.org/
729363003
reed [Tue, 18 Nov 2014 19:08:05 +0000 (11:08 -0800)]
wip for drawables
Idea:
1. in its mutable recording state, keep a table of drawables on the side, and store an index in the record list.
2. In "immediate-mode" draw, just call the clients drawable directly (need access to our private list to turn the stored index into a proc)
3. when we "snap", we replace the list of drawables with a list of (sub) pictures, and then during playback of the snapped picture, we invoke a private drawable which just calls "drawPicture" on the index'd subpicture.
Review URL: https://codereview.chromium.org/
727363003
reed [Tue, 18 Nov 2014 17:57:49 +0000 (09:57 -0800)]
rebaseline after dont-normalize-matrix cl
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
738743003
joshualitt [Tue, 18 Nov 2014 17:40:40 +0000 (09:40 -0800)]
fix for use of uninit variable
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
740463002
mtklein [Tue, 18 Nov 2014 17:32:36 +0000 (09:32 -0800)]
SkVarAlloc::approxBytesAllocated()
This is what I was getting at on the other CL.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
f27f1bcce50c8f95aea8469684a70b70c9baee09
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot
Review URL: https://codereview.chromium.org/
730193003
mtklein [Tue, 18 Nov 2014 17:27:49 +0000 (09:27 -0800)]
Prune SkRTree
- Propagate a bunch of constant parameters through.
- Delete code that's not used when bulk loading.
- Allocate all Nodes together.
- Stay in SkRect.
Doing a single malloc for the nodes can't not have improved memory usage.
Looks like this might improve record performance ~5%, probably mostly from
staying in SkRects. This finally dethrones building the BBH as the hot spot.
(Now it's mapping user bounds back to device bounds and adjusting for paints.)
Recording time changes from my MBP:
desk_rectangletransition.skp 11.5us -> 11.7us 1x
desk_forecastio.skp 115us -> 114us 0.98x
desk_booking.skp 550us -> 541us 0.98x
tabl_mercurynews.skp 176us -> 173us 0.98x
tabl_hsfi.skp 294us -> 287us 0.98x
desk_wordpress.skp 351us -> 343us 0.98x
tabl_worldjournal.skp 439us -> 426us 0.97x
tabl_gmail.skp 20.3us -> 19.7us 0.97x
desk_youtubetvvideo.skp 10.8us -> 10.4us 0.97x
desk_googleplus.skp 1.1ms -> 1.07ms 0.97x
tabl_slashdot.skp 106us -> 103us 0.97x
desk_jsfiddlebigcar.skp 26.7us -> 25.7us 0.96x
tabl_techmeme.skp 95.4us -> 91.7us 0.96x
tabl_deviantart.skp 133us -> 127us 0.96x
desk_pinterest.skp 40.6us -> 38.9us 0.96x
desk_carsvg.skp 195us -> 187us 0.96x
tabl_engadget.skp 376us -> 359us 0.96x
tabl_sahadan.skp 60.5us -> 57.5us 0.95x
tabl_culturalsolutions.skp 255us -> 242us 0.95x
tabl_gspro.skp 58.3us -> 55.5us 0.95x
desk_linkedin.skp 146us -> 138us 0.94x
desk_ebay.skp 192us -> 181us 0.94x
tabl_cnn.skp 467us -> 440us 0.94x
desk_jsfiddlehumperclip.skp 29.9us -> 28.1us 0.94x
desk_tigersvg.skp 43.2us -> 40.5us 0.94x
desk_yahooanswers.skp 131us -> 123us 0.94x
desk_googlespreadsheetdashed.skp 1.18ms -> 1.11ms 0.94x
desk_blogger.skp 193us -> 181us 0.94x
tabl_mozilla.skp 1.82ms -> 1.7ms 0.94x
tabl_mlb.skp 145us -> 136us 0.93x
mobi_wikipedia.skp 577us -> 539us 0.93x
tabl_frantzen.skp 54.1us -> 50.4us 0.93x
desk_baidu.skp 87.9us -> 81.9us 0.93x
desk_techcrunch.skp 224us -> 209us 0.93x
desk_sfgate.skp 206us -> 192us 0.93x
tabl_ukwsj.skp 269us -> 250us 0.93x
desk_facebook.skp 316us -> 293us 0.93x
desk_gmailthread.skp 205us -> 190us 0.93x
tabl_googlecalendar.skp 158us -> 147us 0.93x
tabl_digg.skp 382us -> 354us 0.93x
desk_amazon.skp 106us -> 98.5us 0.93x
tabl_androidpolice.skp 693us -> 642us 0.93x
tabl_nytimes.skp 206us -> 191us 0.92x
desk_gws.skp 124us -> 114us 0.92x
desk_youtube.skp 255us -> 235us 0.92x
tabl_cuteoverload.skp 583us -> 537us 0.92x
desk_oldinboxapp.skp 18us -> 16.6us 0.92x
desk_mobilenews.skp 297us -> 273us 0.92x
tabl_pravda.skp 168us -> 154us 0.92x
tabl_vnexpress.skp 236us -> 217us 0.92x
desk_css3gradients.skp 202us -> 185us 0.92x
tabl_gamedeksiam.skp 508us -> 464us 0.91x
desk_wowwiki.skp 1.02ms -> 929us 0.91x
desk_espn.skp 209us -> 191us 0.91x
desk_chalkboard.skp 315us -> 284us 0.9x
desk_mapsvg.skp 607us -> 543us 0.89x
desk_pokemonwiki.skp 5.18ms -> 4.62ms 0.89x
desk_samoasvg.skp 335us -> 298us 0.89x
desk_youtubetvbrowse.skp 10.1us -> 8.59us 0.85x
BUG=skia:3085, skia:2834
Review URL: https://codereview.chromium.org/
734723002
mtklein [Tue, 18 Nov 2014 16:15:23 +0000 (08:15 -0800)]
Revert of SkVarAlloc::approxBytesAllocated (patchset #5 id:80001 of https://codereview.chromium.org/
730193003/)
Reason for revert:
Android needs dlmalloc_usable_size().
Original issue's description:
> SkVarAlloc::approxBytesAllocated()
>
> This is what I was getting at on the other CL.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
f27f1bcce50c8f95aea8469684a70b70c9baee09
>
> CQ_EXTRA_TRYBOTS=Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
741443002
bsalomon [Tue, 18 Nov 2014 15:36:19 +0000 (07:36 -0800)]
minor cleanup in GrGpu.h
Review URL: https://codereview.chromium.org/
731073003
reed [Tue, 18 Nov 2014 15:32:26 +0000 (07:32 -0800)]
rebaseline perspective gm after matrix dont-renormalize-cl
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
741433002
mtklein [Tue, 18 Nov 2014 15:24:14 +0000 (07:24 -0800)]
SkVarAlloc::approxBytesAllocated()
This is what I was getting at on the other CL.
BUG=skia:
Review URL: https://codereview.chromium.org/
730193003
reed [Tue, 18 Nov 2014 14:04:37 +0000 (06:04 -0800)]
don't normalize after perspective concat
BUG=skia:
Review URL: https://codereview.chromium.org/
734513004
kkinnunen [Tue, 18 Nov 2014 13:13:48 +0000 (05:13 -0800)]
Remove unused NVPR related GL tokens
Remove unused NVPR related GL tokens.
Also replace GR_GL_PATH_INITIAL_END_CAP and GR_GL_PATH_TERMINAL_END_CAP
with a single call setting GR_GL_PATH_END_CAPS. Skia does not and
probably will not have different initial and terminal caps. This came up
in the review of command buffer implementation of the extension.
If more NVPR features will be used, the respective tokens can be added
back per implemented feature.
Review URL: https://codereview.chromium.org/
723453002
kkinnunen [Tue, 18 Nov 2014 12:50:50 +0000 (04:50 -0800)]
Do not calculate many sierpinski fractals for each nanobench run unless needed
Removes work done by the constructors of picture_nesting benches,
and moves the work to the Benchmark::onPreDraw override.
This avoids PictureNesting::sierpinsky showing up in profile traces
when profiling other benches.
Review URL: https://codereview.chromium.org/
725523002
skia.buildbots [Tue, 18 Nov 2014 07:03:57 +0000 (23:03 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
733323002
reed [Tue, 18 Nov 2014 02:24:33 +0000 (18:24 -0800)]
more baselines for blur2rects
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
715223003
joshualitt [Tue, 18 Nov 2014 01:59:49 +0000 (17:59 -0800)]
one more rebase on k1
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
734243002
joshualitt [Tue, 18 Nov 2014 00:48:12 +0000 (16:48 -0800)]
rebase nvpr after ds on stack
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
726103004
joshualitt [Mon, 17 Nov 2014 22:22:48 +0000 (14:22 -0800)]
Drawstate on stack
BUG=skia:
Review URL: https://codereview.chromium.org/
732693002
reed [Mon, 17 Nov 2014 21:53:14 +0000 (13:53 -0800)]
baselines for blur2rects
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
733233002
bsalomon [Mon, 17 Nov 2014 20:15:56 +0000 (12:15 -0800)]
Reduce the amount of validation in GrResourceCache2
BUG=chromium:433711
Review URL: https://codereview.chromium.org/
737533002
robertphillips [Mon, 17 Nov 2014 20:11:42 +0000 (12:11 -0800)]
Fix yet another convexicator issue
This CL fixes the case where a bad initial vector (i.e., nearly zero) managed to short circuit all of the convexicator's logic. The initial bad vector would become the last vector and then never get displaced.
The history of this is:
https://codereview.chromium.org/
298973004/
Switched the convexicator to not advance the last vector when the cross product wasn't significant
https://codereview.chromium.org/
573763002/
Fixed a bug (crbug.com/412640) wherein a zero area path was being incorrectly categorized as convex b.c. opposite but equal vectors were not signaling concavity.
BUG=433683
Review URL: https://codereview.chromium.org/
727283003
scroggo [Mon, 17 Nov 2014 18:29:18 +0000 (10:29 -0800)]
Really enable deprecation warnings for Android framework.
Left out of a previous CL to reenable.
(We had the define added in two places for some reason...)
Review URL: https://codereview.chromium.org/
728503002
borenet [Mon, 17 Nov 2014 17:59:53 +0000 (09:59 -0800)]
Remove bug_chomper
It has been moved into buildbot repo.
BUG=skia:
Review URL: https://codereview.chromium.org/
731123003
bsalomon [Mon, 17 Nov 2014 17:33:27 +0000 (09:33 -0800)]
Allow GPU resources to not be counted against the cache budget.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
721353002
bsalomon [Mon, 17 Nov 2014 16:54:04 +0000 (08:54 -0800)]
Rebase GM on win7 after res cache change.
TBR=
Review URL: https://codereview.chromium.org/
733133003
robertphillips [Mon, 17 Nov 2014 16:16:15 +0000 (08:16 -0800)]
Make BBH parameter to SkRecordComputeLayers and SkRecordFillBounds optional
Chromium creates a picture to contain their picture pile in order to use MultiPictureDraw. They currently do not create a bounding box for that picture but I still need layer information for it. This change allows Chromium to continue without a BBH but still have layer information.
In the future, the brute force BBH might be suitable for their use case.
Please see gpu_raster_worker_pool.cc in (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/
721883002/) for where this is happening in Chromium.
Review URL: https://codereview.chromium.org/
733963004
egdaniel [Mon, 17 Nov 2014 15:45:53 +0000 (07:45 -0800)]
Use DrawStates ProcOptInfo when creating the Optimized Draw State.
BUG=skia:
Review URL: https://codereview.chromium.org/
726693002
reed [Mon, 17 Nov 2014 15:41:35 +0000 (07:41 -0800)]
tweak gm to show fractional offsets
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
728403002
bsalomon [Mon, 17 Nov 2014 15:34:06 +0000 (07:34 -0800)]
Correct accounting for wrapped resources
BUG=skia:2889
Review URL: https://codereview.chromium.org/
720033004
mtklein [Mon, 17 Nov 2014 14:45:18 +0000 (06:45 -0800)]
More SkPicture cleanup
- move field declarations together and pack them a little tighter
- get rid of fData
- remove dead code in debugger, including unused SkPicturePlayback subclass
There are now no more long-lived SkPictureData! (Really, there never were,
but now we don't pretend to support them.)
BUG=skia:
No API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
725143002
Greg Humphreys [Mon, 17 Nov 2014 14:42:09 +0000 (09:42 -0500)]
Revert "move SkPDFD*.h from include to src"
This reverts commit
693024300f79ff3fb497ddee1043b609ddf521a4.
was breaking canary build
BUG=skia:
Review URL: https://codereview.chromium.org/
731173002
halcanary [Mon, 17 Nov 2014 14:26:21 +0000 (06:26 -0800)]
move SkPDFD*.h from include to src
BUG=278148
Review URL: https://codereview.chromium.org/
727343002
reed [Mon, 17 Nov 2014 14:15:42 +0000 (06:15 -0800)]
separate c headers
BUG=skia:
Review URL: https://codereview.chromium.org/
728323002
sugoi [Mon, 17 Nov 2014 13:45:55 +0000 (05:45 -0800)]
Added missing validation
BUG=433359
Review URL: https://codereview.chromium.org/
729583002
skia.buildbots [Mon, 17 Nov 2014 06:31:01 +0000 (22:31 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
731003004
halcanary [Sun, 16 Nov 2014 16:26:54 +0000 (08:26 -0800)]
Move SkDocument_PDF.cpp into pdf.gypi - now standard PDF API
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
714223002
skia.buildbots [Sun, 16 Nov 2014 06:52:04 +0000 (22:52 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
734493002
halcanary [Sat, 15 Nov 2014 14:11:18 +0000 (06:11 -0800)]
skbug.com/3130 step 1 (to fix chromium roll)
BUG=skia:3130
TBR=djsollen@google.com, bsalomon@google.com
Review URL: https://codereview.chromium.org/
729173002
skia.buildbots [Sat, 15 Nov 2014 06:56:33 +0000 (22:56 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
730833002
halcanary [Sat, 15 Nov 2014 01:22:05 +0000 (17:22 -0800)]
Fix Chromium roll broken by crrev.com/
728823002
Review URL: https://codereview.chromium.org/
727783004
joshualitt [Sat, 15 Nov 2014 00:00:38 +0000 (16:00 -0800)]
Push creation of default GP to the caller
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
715903002
scroggo [Fri, 14 Nov 2014 22:49:34 +0000 (14:49 -0800)]
Fix Android framework build.
When we define SK_BUILD_FOR_ANDROID, we don't define it to anything,
so
#if SK_BUILD_FOR_ANDROID
is not a meaningful check. Instead, use #ifdef.
TBR=caryclark@google.com, djsollen@google.com
Review URL: https://codereview.chromium.org/
728013002
reed [Fri, 14 Nov 2014 22:39:29 +0000 (14:39 -0800)]
disable gammatext gm for a while, looking for other flakes
BUG=skia:
Review URL: https://codereview.chromium.org/
725303002
bsalomon [Fri, 14 Nov 2014 21:59:57 +0000 (13:59 -0800)]
Guard high water cache stats vars by GR_CACHE_STATS
TBR=halcanary@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
729753003
bsalomon [Fri, 14 Nov 2014 21:33:09 +0000 (13:33 -0800)]
Make GrResourceCache2 responsible for calling release, abandon, and ~.
BUG=skia:2889
TBR=robertphillips@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
729683002
halcanary [Fri, 14 Nov 2014 21:24:18 +0000 (13:24 -0800)]
SkDocument SK_API
Review URL: https://codereview.chromium.org/
726073002
bsalomon [Fri, 14 Nov 2014 20:10:14 +0000 (12:10 -0800)]
Replace GrResourceCache with GrResourceCache2.
BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/
66a450f21a3da174b7eed89a1d5fc8591e8b6ee6
Committed: https://skia.googlesource.com/skia/+/
407aa584d183c1bf314f5defd1cf0202e8a96c89
Review URL: https://codereview.chromium.org/
716143004
reed [Fri, 14 Nov 2014 19:59:10 +0000 (11:59 -0800)]
update gm to place inner rect on fractional boundary
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
730673002
bsalomon [Fri, 14 Nov 2014 19:31:13 +0000 (11:31 -0800)]
Fix ref-cnting bug in GrContext::readRenderTargetPixels
TBR=egdaniel@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
732713002
djsollen [Fri, 14 Nov 2014 19:11:46 +0000 (11:11 -0800)]
Enable unused param checking for public includes.
This CL cleans up the existing violations and enables the
build time check to ensure that we don't regress.
The motiviation behind this change is to allow clients who include
our headers to be able to build with this warning enabled.
Review URL: https://codereview.chromium.org/
726923002
djsollen [Fri, 14 Nov 2014 18:52:53 +0000 (10:52 -0800)]
Enforce pure virtual behavior for onMatchFamilyStyleCharacter
All impls that previously did not define the functions have been
updated to return NULL.
NOTRY=true
Review URL: https://codereview.chromium.org/
728873002
mtklein [Fri, 14 Nov 2014 17:22:40 +0000 (09:22 -0800)]
Don't pass null to memcmp.
This will allow us to add nonnull-attribute to the UBSAN bot.
We are in fact hitting a case where one of the arguments is null and the other
not, which seems dicey. I think the scenario is comparing the empty pathref
with another path ref that's just been COWed, without any verbs or points yet.
BUG=skia:
Review URL: https://codereview.chromium.org/
732643002
reed [Fri, 14 Nov 2014 16:27:40 +0000 (08:27 -0800)]
add gm for 2-rects and blur
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
728863002
qiankun.miao [Fri, 14 Nov 2014 16:23:53 +0000 (08:23 -0800)]
Optimize SkAlphaMulQ_SSE2
These two mask clear are useless, because _mm_srli_epi16 fills high byte
of each word with 0.
BUG=skia:
Review URL: https://codereview.chromium.org/
724333003
mtklein [Fri, 14 Nov 2014 15:50:51 +0000 (07:50 -0800)]
Steal ASAN skimage expectations for UBSAN.
NOTRY=true
BUG=skia:3096
Review URL: https://codereview.chromium.org/
731553002
djsollen [Fri, 14 Nov 2014 15:21:29 +0000 (07:21 -0800)]
Move WGL header from include to src
NOTRY=true
Review URL: https://codereview.chromium.org/
728823002
bsalomon [Fri, 14 Nov 2014 14:47:39 +0000 (06:47 -0800)]
Revert of Replace GrResourceCache with GrResourceCache2. (patchset #7 id:120001 of https://codereview.chromium.org/
716143004/)
Reason for revert:
broken again
Original issue's description:
> Replace GrResourceCache with GrResourceCache2.
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/
66a450f21a3da174b7eed89a1d5fc8591e8b6ee6
>
> Committed: https://skia.googlesource.com/skia/+/
407aa584d183c1bf314f5defd1cf0202e8a96c89
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889
Review URL: https://codereview.chromium.org/
726913002
bsalomon [Fri, 14 Nov 2014 14:29:40 +0000 (06:29 -0800)]
Replace GrResourceCache with GrResourceCache2.
BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/
66a450f21a3da174b7eed89a1d5fc8591e8b6ee6
Review URL: https://codereview.chromium.org/
716143004
djsollen [Fri, 14 Nov 2014 13:52:50 +0000 (05:52 -0800)]
Cleanup the XML directory in public includes.
Review URL: https://codereview.chromium.org/
722343002
skia.buildbots [Fri, 14 Nov 2014 07:05:53 +0000 (23:05 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
732443002
tfarina [Thu, 13 Nov 2014 22:49:59 +0000 (14:49 -0800)]
Cleanup: Delete SkFlattenableBuffers header.
It is empty. cs.chromium.org shows no one is including it.
BUG=skia:3108
R=reed@google.com
Review URL: https://codereview.chromium.org/
722943002
reed [Thu, 13 Nov 2014 22:39:58 +0000 (14:39 -0800)]
remove unused kLCD_MaskFormat
BUG=skia:
Review URL: https://codereview.chromium.org/
728673002
fmalita [Thu, 13 Nov 2014 22:05:58 +0000 (14:05 -0800)]
Observe surface LCD settings in SkBaseDevice::drawTextBlob()
We're currently overwriting the paint LCD text flag based on the the run
font data => this cancels any LCD filtering we might have performed
higher up the stack.
BUG=423362
R=reed@google.com
Review URL: https://codereview.chromium.org/
718913003
mtklein [Thu, 13 Nov 2014 21:55:22 +0000 (13:55 -0800)]
Cap SkVarAlloc's desired block at 64K.
This means we can store fLgMinSize in 4 bits (TBD).
Local perf comparison calls this harmless-to-slightly-helpful. Nothing to get
excited about, but seems to certainly not harm perf.
BUG=skia:
Review URL: https://codereview.chromium.org/
722293003
bsalomon [Thu, 13 Nov 2014 21:47:06 +0000 (13:47 -0800)]
Don't use /ZI on 64 bit windows
Review URL: https://codereview.chromium.org/
728633002
bsalomon [Thu, 13 Nov 2014 21:33:28 +0000 (13:33 -0800)]
Revert of Replace GrResourceCache with GrResourceCache2. (patchset #6 id:100001 of https://codereview.chromium.org/
716143004/)
Reason for revert:
Breaking stuff
Original issue's description:
> Replace GrResourceCache with GrResourceCache2.
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/
66a450f21a3da174b7eed89a1d5fc8591e8b6ee6
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889
Review URL: https://codereview.chromium.org/
715333003
bsalomon [Thu, 13 Nov 2014 21:19:10 +0000 (13:19 -0800)]
Replace GrResourceCache with GrResourceCache2.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
716143004
bungeman [Thu, 13 Nov 2014 21:06:27 +0000 (13:06 -0800)]
Remove SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX.
This define was added with "Always round text position correctly."
9447103029273a9f8dd7f5997e8af7a1e3ee7488 . The affected clients
have been rebaselined and this is no longer defined anywhere.
Review URL: https://codereview.chromium.org/
722333002
mtklein [Thu, 13 Nov 2014 20:54:35 +0000 (12:54 -0800)]
Unsuppress freetype, which may be our gammatext problem.
BUG=skia:
Review URL: https://codereview.chromium.org/
721333003
djsollen [Thu, 13 Nov 2014 20:52:35 +0000 (12:52 -0800)]
Cleanup public includes directory.
This CL updates various files in the includes directory to ensure that (1) they do
not depend on headers in /src and (2) that they minimize their dependence on external
headers.
To ensure that we don't regress this behavior a new build target has been added to
build a single cpp file that contains all* public includes and is compiled with
only those directories in the include path.
* The exception is those includes that depend on OS specific headers
BUG=skia:2941
NOTRY=true
Review URL: https://codereview.chromium.org/
721903002
reed [Thu, 13 Nov 2014 20:46:24 +0000 (12:46 -0800)]
clean up dead code
BUG=skia:
Review URL: https://codereview.chromium.org/
722113003
mtklein [Thu, 13 Nov 2014 20:41:14 +0000 (12:41 -0800)]
Deparameterize SkVarAlloc.
SkRecord performance is not sensitive to these values, so we can cut some
storage. This rearranges the space-remaining logic to use a count of bytes
left rather than a pointer to the end, cutting memory usage a little more.
An SkVarAlloc used to weigh 20 or 32 bytes which now becomes 16 or 24.
I think if I think about it a bit more I can trim off that Block* too,
getting us to 12 or 16 bytes.
Because we now just always grow by doubling, this CL switches from storing
fSmallest to its log base 2. This has the nice effect of never having to worry
about it overflowing, and means we can probably squeeze it down into a byte
if we want, even 6 bits.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
bc415389855888af5a1282ca4b6bee30afa3d69d
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
Review URL: https://codereview.chromium.org/
721313002
reed [Thu, 13 Nov 2014 20:41:02 +0000 (12:41 -0800)]
rename filterTextFlags to disableLCD
Under the hood, add SkPixelGeometry to the CreateInfo for new devices, allowing them to see their geometry (SkDeviceProperties) up front, rather than having it changed later.
The only exception is for devices that are used on the root-layer, where we don't see the device until after the fact (at least as long as we allow clients to attach a device to a canvas externally).
We also filter the geometry when we're creating a layer, so we can disable LCD text automatically if the layer is not marked as opaque.
NOTRY=True
-- gammatext flake?
Review URL: https://codereview.chromium.org/
719253002
Florin Malita [Thu, 13 Nov 2014 20:00:03 +0000 (15:00 -0500)]
Fully disable lcdtextprops
R=reed@google.com
TBR=jcgregorio@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
723253002
cdalton [Thu, 13 Nov 2014 19:54:20 +0000 (11:54 -0800)]
Combine similar DrawPaths calls in GrInOrderDrawBuffer
Combines adjacent DrawPaths commands into one single call when a
conservative set of conditions are met. The end result is that whole
paragraphs can be drawn with a single call to
gliStencilThenCoverFillPathInstancedNV(), rather than one call for
each line.
BUG=skia:
Review URL: https://codereview.chromium.org/
712223002
fmalita [Thu, 13 Nov 2014 19:29:07 +0000 (11:29 -0800)]
Disable GM:lcdtextprops on 565
The new GM is failing on 565/pipe. Disabling to get the tree green.
R=reed@google.com,jcgregorio@google.com
Review URL: https://codereview.chromium.org/
722153004
mtklein [Thu, 13 Nov 2014 19:23:36 +0000 (11:23 -0800)]
Revert of Deparameterize SkVarAlloc. (patchset #6 id:100001 of https://codereview.chromium.org/
721313002/)
Reason for revert:
Unit test failures on 32-bit machines.
test Record_Alignment: ../../tests/RecordTest.cpp:100 is_aligned(record.alloc<uint64_t>())
Original issue's description:
> Deparameterize SkVarAlloc.
>
> SkRecord performance is not sensitive to these values, so we can cut some
> storage. This rearranges the space-remaining logic to use a count of bytes
> left rather than a pointer to the end, cutting memory usage a little more.
>
> An SkVarAlloc used to weigh 20 or 32 bytes which now becomes 16 or 24.
>
> I think if I think about it a bit more I can trim off that Block* too,
> getting us to 12 or 16 bytes.
>
> Because we now just always grow by doubling, this CL switches from storing
> fSmallest to its log base 2. This has the nice effect of never having to worry
> about it overflowing, and means we can probably squeeze it down into a byte
> if we want, even 6 bits.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
bc415389855888af5a1282ca4b6bee30afa3d69d
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
718203006
bungeman [Thu, 13 Nov 2014 19:21:30 +0000 (11:21 -0800)]
Roll gyp.
Summary of changes available at:
https://chromium.googlesource.com/external/gyp/+log/
3917682a16d5c19ff3576a8be0ffdb3a332954b1..
f1c42f73e4cc2912460aab113f9cd31ee3fafd38
Review URL: https://codereview.chromium.org/
724883002
djsollen [Thu, 13 Nov 2014 19:12:41 +0000 (11:12 -0800)]
Cleanup GrContextFactory and make it's subclasses private
Review URL: https://codereview.chromium.org/
723183002
caryclark [Thu, 13 Nov 2014 19:08:52 +0000 (11:08 -0800)]
disable a couple of new fuzz378 tests on android
these tests fail on a nexus 9 in release only. It's probably related
to the fused multiply-add instruction
TBR=
Review URL: https://codereview.chromium.org/
722303002
egdaniel [Thu, 13 Nov 2014 19:00:34 +0000 (11:00 -0800)]
Add GrProcOptInfo class to track various output information for color and coverage stages.
BUG=skia:
Review URL: https://codereview.chromium.org/
719203002