platform/upstream/dotnet/runtime.git
8 years agoFix MulticastInterface_Set_ValidIndex_Success failures on non-Windows platforms....
Eric Eilebrecht [Thu, 16 Jun 2016 23:14:21 +0000 (16:14 -0700)]
Fix MulticastInterface_Set_ValidIndex_Success failures on non-Windows platforms. (dotnet/corefx#9471)

This test assumed that the "loopback" interface was always at index 1, which is not true on Linux/OSX/etc.  This change makes that assumption explicitly Windows-only, while allowing the "any interface" case to run on all platforms.

Commit migrated from https://github.com/dotnet/corefx/commit/212783dd5e84051675b65fa69ae1809d01f1c8c6

8 years agoMerge pull request dotnet/corefx#9479 from stephentoub/threadingtasks_testtime
Stephen Toub [Thu, 16 Jun 2016 22:05:44 +0000 (18:05 -0400)]
Merge pull request dotnet/corefx#9479 from stephentoub/threadingtasks_testtime

Reduce System.Threading.Tasks.Tests from ~140s to ~10s

Commit migrated from https://github.com/dotnet/corefx/commit/7b526135f8ea65dcb9ffdaf6cc4257b8a2298b86

8 years agoMerge pull request dotnet/corefx#9473 from karajas/updateBT
Karthik Rajasekaran [Thu, 16 Jun 2016 21:56:43 +0000 (14:56 -0700)]
Merge pull request dotnet/corefx#9473 from karajas/updateBT

Update BuildTools version to 1.0.26-prerelease-00516-05

Commit migrated from https://github.com/dotnet/corefx/commit/2c31ba75426d2b731338a73b3231944d8b2d675b

8 years agoReduce System.Threading.Tasks.Tests from ~140s to ~10s
Stephen Toub [Thu, 16 Jun 2016 21:00:30 +0000 (17:00 -0400)]
Reduce System.Threading.Tasks.Tests from ~140s to ~10s

As with https://github.com/dotnet/corefx/pull/9468 and https://github.com/dotnet/corefx/pull/9466, this commit focuses on reducing the total, outerloop running time of our worst-offending test suites.  This one is on the System.Threading.Tasks tests.  Some of the tests are not in good shape, e.g. it's not clear to me that the TaskCancelWaitTests are actually verifying everything they should, even though they're spending a lot of time doing it.

Changes:
- Reduced artificially long wait times in TaskAwaiter, IAsyncResult, TaskCancelWaitTests, TaskStatusTests, CESchedulerPairTests, and Coverage tests
- Reduced size of workload in TaskCancelWaitTests, TaskContinueWithAllAnyTests, and TaskWaitAllAnyTests
- Ensured that the ThreadPool was ramped up to serve several tests expecting more threads available
- Removed some unnecessary spinning

Commit migrated from https://github.com/dotnet/corefx/commit/a6f8d2f00a841ecb78ec0dfec723d10d9a88a5fa

8 years agoMerge pull request dotnet/corefx#9468 from stephentoub/threading_testtime
Stephen Toub [Thu, 16 Jun 2016 21:01:19 +0000 (17:01 -0400)]
Merge pull request dotnet/corefx#9468 from stephentoub/threading_testtime

Reduce System.Threading.Tests from ~650s to ~8s

Commit migrated from https://github.com/dotnet/corefx/commit/777bed7557c6066a480608f8cef112f4e4406e2c

8 years agoMerge pull request dotnet/corefx#9466 from stephentoub/parallelloop_testtime
Eric Mellino [Thu, 16 Jun 2016 20:17:10 +0000 (13:17 -0700)]
Merge pull request dotnet/corefx#9466 from stephentoub/parallelloop_testtime

Reduce System.Threading.Tasks.Parallel.Tests from ~200s to ~6s

Commit migrated from https://github.com/dotnet/corefx/commit/0779bf6c4dd4286ac14437b90647ff8eb878c054

8 years agoMerge pull request dotnet/corefx#9453 from corivera/RefactorManualTests
Cory Rivera [Thu, 16 Jun 2016 19:45:21 +0000 (12:45 -0700)]
Merge pull request dotnet/corefx#9453 from corivera/RefactorManualTests

Refactor SqlClient ManualTests to fetch connection strings from environment variables.

Commit migrated from https://github.com/dotnet/corefx/commit/7a3d9ccaa4b02aea738352ff303c977e15d215ce

8 years agoUpdate BuildTools version to 1.0.26-prerelease-00516-05
Karthik Rajasekaran [Thu, 16 Jun 2016 19:25:40 +0000 (12:25 -0700)]
Update BuildTools version to 1.0.26-prerelease-00516-05

Commit migrated from https://github.com/dotnet/corefx/commit/8b4aba69bc61a2748f42b5da895ae77a0bce9e84

8 years agoMerge pull request dotnet/corefx#9443 from jcouv/netstandard
Eric StJohn [Thu, 16 Jun 2016 19:08:31 +0000 (12:08 -0700)]
Merge pull request dotnet/corefx#9443 from jcouv/netstandard

ValueTuple: Lowering framework dependency to netstandard1.0

Commit migrated from https://github.com/dotnet/corefx/commit/95f4d067c8ba4ebd6e4d2f0f2c1589e1ead92854

8 years agoFixing DevWorkflow Scripts given that corerun is not present in the tool runtime...
Jose Perez Rodriguez [Thu, 16 Jun 2016 18:09:53 +0000 (11:09 -0700)]
Fixing DevWorkflow Scripts given that corerun is not present in the tool runtime anymore (dotnet/corefx#9469)

Commit migrated from https://github.com/dotnet/corefx/commit/b4482113f33249394a508a9f82f8d1219c624dc4

8 years agoReduce System.Threading.Tests from ~650s to ~8s
Stephen Toub [Thu, 16 Jun 2016 17:07:02 +0000 (13:07 -0400)]
Reduce System.Threading.Tests from ~650s to ~8s

As with https://github.com/dotnet/corefx/pull/9466, a few tactical changes to significantly reduce the outerloop running time of the System.Threading.Tests suites (lots of work could be done to further improve/overhaul these tests, but that wasn't my goal):
- Two barrier tests were taking several minutes.  Reduced the number of iterations from 10,000 to 10.  A few iterations helps to verify intended behavior; more than that is a stress test that doesn't belong in the functional suite.
- Reduced explicit timeouts in a ReaderWriterLockSlim test
- Reduced timeouts in some SemaphoreSlim tests.  As part of this I split up a few tests into [Theory]s in order to help identify where the actual problem was.
- SpinLock tests were getting throttled by the ThreadPool; changed them to use new threads rather than pool threads.  As with above, I also split some of these tests into [Theory]s to help identify where exactly the problem was.

Commit migrated from https://github.com/dotnet/corefx/commit/c6da03a7e0cb81c4150147782dd3a6be6142b26c

8 years agoAdding windows phone 8
Julien Couvreur [Thu, 16 Jun 2016 16:15:35 +0000 (09:15 -0700)]
Adding windows phone 8

Commit migrated from https://github.com/dotnet/corefx/commit/11b687a2c9f68e7344e602992229856526606341

8 years agoMerge pull request dotnet/corefx#9459 from ericstj/buildBaseline
Eric StJohn [Thu, 16 Jun 2016 16:09:32 +0000 (09:09 -0700)]
Merge pull request dotnet/corefx#9459 from ericstj/buildBaseline

Ensure we build Microsoft.Private.PackageBaseline

Commit migrated from https://github.com/dotnet/corefx/commit/8148702e8c356c41f837fc248c178506811f8407

8 years agoReduce System.Threading.Tasks.Parallel.Tests from ~200s to ~6s
Stephen Toub [Thu, 16 Jun 2016 15:54:47 +0000 (11:54 -0400)]
Reduce System.Threading.Tasks.Parallel.Tests from ~200s to ~6s

Various areas of these tests could really stand to be rewritten.   This commit does not attempt to do that.  Rather, my goal was to significantly reduce the running time of the tests.  Today, with outerloop enabled, they take ~200 seconds.  This commit gets that down to ~6 seconds.

Three small changes:
- Some of the tests were relying on a barrier to ensure that all tasks had started before any proceeded.  This resulted in a long delay while the thread pool ramped up slowly to having the desired number of threads.  I put in place a little hack to force it to quickly ramp up.
- Some of the tests were explicitly waiting for 1 seconds.  I lowered that to 0.01 seconds.  This is an example of it not being clear why the delay exists at all, but regardless, this shaves off a lot of time.
- ~25 of the TestFor_Boundary [InlineData]s were specifying a very high workload count that was resulting in each of them taking 6-8 seconds to run.  This is unnecessary, as it's of little value to the testing to have a delegate just chewing up CPU for long periods of time.  I've simply deleted them.

Commit migrated from https://github.com/dotnet/corefx/commit/4285ffaa6237b0f637572cbf9707b2f86da21107

8 years agoEnsure we build Microsoft.Private.PackageBaseline
Eric St. John [Thu, 16 Jun 2016 05:56:30 +0000 (22:56 -0700)]
Ensure we build Microsoft.Private.PackageBaseline

This stopped building when we moved to VSO builds.

Commit migrated from https://github.com/dotnet/corefx/commit/868e5799119f4f77262c564db977b217806f449c

8 years agoMerge pull request dotnet/corefx#9447 from joperezr/UpdateBuildTools
Eric StJohn [Thu, 16 Jun 2016 04:51:59 +0000 (21:51 -0700)]
Merge pull request dotnet/corefx#9447 from joperezr/UpdateBuildTools

Updating BuildTools to use sharedRuntime

Commit migrated from https://github.com/dotnet/corefx/commit/bb551f0f4337be8db46c64886d7139d9dc6241f1

8 years agoMerge pull request dotnet/corefx#9446 from davidsh/flow_timeouts
Stephen Toub [Thu, 16 Jun 2016 02:36:12 +0000 (22:36 -0400)]
Merge pull request dotnet/corefx#9446 from davidsh/flow_timeouts

Flow HttpClient timeouts and cancellation to the response stream

Commit migrated from https://github.com/dotnet/corefx/commit/cffe60fcec1f85f755f41562b0c207700fdbc043

8 years agoCleanup some System.Linq tests (dotnet/corefx#8817)
Hugh Bellamy [Thu, 16 Jun 2016 02:33:08 +0000 (03:33 +0100)]
Cleanup some System.Linq tests (dotnet/corefx#8817)

* Cleanup some System.Linq tests

Also fix a missing [Fact] in Average_NullableDouble

Commit migrated from https://github.com/dotnet/corefx/commit/fbb2b6d9adea4658731f936c71b3ac8f0b8a0063

8 years agoMerge pull request dotnet/corefx#9434 from CIPop/ns
Cristian Pop [Thu, 16 Jun 2016 01:54:13 +0000 (18:54 -0700)]
Merge pull request dotnet/corefx#9434 from CIPop/ns

Fixing NegotiateStream Windows Interop. Adding NTLM and Kerberos remote tests.

Commit migrated from https://github.com/dotnet/corefx/commit/2e1349ed08443ea0184a01404eb3ee63497b3f92

8 years agoRename DDDataTypes test to DDDataTypesTest to explicitly show that it's a test class.
Cory Rivera [Thu, 16 Jun 2016 00:47:41 +0000 (17:47 -0700)]
Rename DDDataTypes test to DDDataTypesTest to explicitly show that it's a test class.

Commit migrated from https://github.com/dotnet/corefx/commit/d593a25839ccae756158f581d0dc1c9f68f755ec

8 years agoConvert MultipleResultsTest class to a non-static class, since it has non-constant...
Cory Rivera [Thu, 16 Jun 2016 00:42:05 +0000 (17:42 -0700)]
Convert MultipleResultsTest class to a non-static class, since it has non-constant global variables.

Commit migrated from https://github.com/dotnet/corefx/commit/dc47374ab4802830120d8b34695afb0348e77cef

8 years agoRefactor SqlClient ManualTests to fetch connection strings from environment variables...
Cory Rivera [Thu, 16 Jun 2016 00:09:39 +0000 (17:09 -0700)]
Refactor SqlClient ManualTests to fetch connection strings from environment variables, rather than an XML file. This change also allows ManualTests to be built and run automatically, but no actual tests will be run if the connection strings aren't present.

Commit migrated from https://github.com/dotnet/corefx/commit/79ff80a0b2022459d150d8e95c332c4cd7199946

8 years agoMerge pull request dotnet/corefx#9436 from stephentoub/websocket_testtime
Stephen Toub [Wed, 15 Jun 2016 22:31:49 +0000 (18:31 -0400)]
Merge pull request dotnet/corefx#9436 from stephentoub/websocket_testtime

Significantly reduce running time of WebSocket.Client tests

Commit migrated from https://github.com/dotnet/corefx/commit/f65ced2f2e8f77a4f9b9d916767660c7dda11fa5

8 years agoFixing NegotiateStream Windows Interop. Adding NTLM and Kerberos remote tests.
Cristian Pop [Fri, 10 Jun 2016 23:12:27 +0000 (16:12 -0700)]
Fixing NegotiateStream Windows Interop. Adding NTLM and Kerberos remote tests.

Commit migrated from https://github.com/dotnet/corefx/commit/cd2541b899e48721833ef66b5cbb0ef1da19baaf

8 years agoMerge pull request dotnet/corefx#9302 from Priya91/ellismg-pr
Matt Galbraith [Wed, 15 Jun 2016 21:49:26 +0000 (14:49 -0700)]
Merge pull request dotnet/corefx#9302 from Priya91/ellismg-pr

Mark tests which require elevation - rebased

Commit migrated from https://github.com/dotnet/corefx/commit/355c90ea255af65054f68ea03a49e293a2a5b861

8 years agoUpdating BuildTools to use sharedRuntime
Jose Perez Rodriguez [Wed, 15 Jun 2016 21:43:59 +0000 (14:43 -0700)]
Updating BuildTools to use sharedRuntime

Commit migrated from https://github.com/dotnet/corefx/commit/e62f6ba3ca04ab6459d8d04f2975703b36d4bcb1

8 years agoFlow HttpClient timeouts and cancellation to the response stream
Stephen Toub [Thu, 2 Jun 2016 18:35:46 +0000 (14:35 -0400)]
Flow HttpClient timeouts and cancellation to the response stream

Basically this is the same as PR dotnet/corefx#9102.  We reverted that PR when the
internal ToF tests started failing. But it was determined that the
failure was due to infrastructure which is now fixed via
https://github.com/dotnet/coreclr/pull/5695

Commit migrated from https://github.com/dotnet/corefx/commit/48ab6ce6334db48cc83ddf41bf2a63e45192d2ae

8 years agoMark tests that require elevation
Matt Ellis [Mon, 30 May 2016 23:24:35 +0000 (16:24 -0700)]
Mark tests that require elevation

Commit migrated from https://github.com/dotnet/corefx/commit/fd6a8fcc94fe9aaaecb77dc9bddb333c340378dd

8 years agoMerge pull request dotnet/corefx#9129 from karajas/karajas/NetStandardCoreFx
Karthik Rajasekaran [Wed, 15 Jun 2016 19:38:40 +0000 (12:38 -0700)]
Merge pull request dotnet/corefx#9129 from karajas/karajas/NetStandardCoreFx

Update CoreFX tests to compile against netstandard1.3 and deploy for platform

Commit migrated from https://github.com/dotnet/corefx/commit/bf09ee1e3e16e084f5506ab5342a085af83d6268

8 years agoImport dotnet5.1 instead of 5.2
Julien Couvreur [Wed, 15 Jun 2016 18:48:41 +0000 (11:48 -0700)]
Import dotnet5.1 instead of 5.2

Commit migrated from https://github.com/dotnet/corefx/commit/87b3934e5025638ffbdb48385d0a50312c660bb3

8 years agoIncluding buildtools as a source and update perf versions
Karthik Rajasekaran [Wed, 8 Jun 2016 03:36:56 +0000 (20:36 -0700)]
Including buildtools as a source and update perf versions

Updating xunit.netcore.extensions to Microsoft.xunit.netcore.extensions

Commit migrated from https://github.com/dotnet/corefx/commit/099bc04f8a21d2c2d941ae359afbcde126c4d05a

8 years agoUpdate CoreFX tests to compile against a minimum of netstandard1.3 and add supports...
Karthik Rajasekaran [Fri, 3 Jun 2016 22:58:45 +0000 (15:58 -0700)]
Update CoreFX tests to compile against a minimum of netstandard1.3 and add supports clauses for tests

CoreFX tests will now compile against netstandard1.3 as references and will now deploy for the platforms listed in their respective supports clause, provided the appropriate TestTFM is passed in.  The supports are fully listed inside runtime.json in the new TestSuite metapackage in buildtools. The tests will default to netcoreapp1.0 as their TestTFM.

CoreFx test projects now utilise a test csproj to pkgproj reference which determine the appropriate compile time and runtime assets needed.

Dependent on https://github.com/dotnet/buildtools/pull/770

Commit migrated from https://github.com/dotnet/corefx/commit/b4841454de7ddcd75e92e2bb24ebb238a82df43f

8 years agoMerge pull request dotnet/corefx#9441 from karajas/fixExpectedVersion
Karthik Rajasekaran [Wed, 15 Jun 2016 18:19:25 +0000 (11:19 -0700)]
Merge pull request dotnet/corefx#9441 from karajas/fixExpectedVersion

Fix System.Diagnostics.Debug.SymbolReader\src\project.json expected versions

Commit migrated from https://github.com/dotnet/corefx/commit/c1c59ed0aa53b6a78cdf9f5ffa258af95d6fd924

8 years agoLowering framework dependency to netstandard1.0
Julien Couvreur [Wed, 15 Jun 2016 18:13:34 +0000 (11:13 -0700)]
Lowering framework dependency to netstandard1.0

Commit migrated from https://github.com/dotnet/corefx/commit/e93aa387457620e32ae0d7731d4b87544e215647

8 years agoFix System.Diagnostics.Debug.SymbolReader\src\project.json expected version of Micros...
Karthik Rajasekaran [Wed, 15 Jun 2016 17:10:27 +0000 (10:10 -0700)]
Fix System.Diagnostics.Debug.SymbolReader\src\project.json expected version of Microsoft.TargetingPack.Private.NETNative and Microsoft.TargetingPack.Private.CoreCLR

Commit migrated from https://github.com/dotnet/corefx/commit/f928a57f1126b1f11dcaaa7b40a6ebe79ca1e2ee

8 years agoMerge pull request dotnet/corefx#9377 from stephentoub/multipartcontent_readstream
Stephen Toub [Wed, 15 Jun 2016 16:40:00 +0000 (12:40 -0400)]
Merge pull request dotnet/corefx#9377 from stephentoub/multipartcontent_readstream

Override HttpContent.CreateContentReadStreamAsync in MultipartContent

Commit migrated from https://github.com/dotnet/corefx/commit/bfdd0b7694a99838760fbccc8185ee53c7b451cd

8 years agoMerge pull request dotnet/corefx#9437 from stephentoub/datetime_tests
Stephen Toub [Wed, 15 Jun 2016 16:39:47 +0000 (12:39 -0400)]
Merge pull request dotnet/corefx#9437 from stephentoub/datetime_tests

Fix several DateTimeOffset tests in various timezones

Commit migrated from https://github.com/dotnet/corefx/commit/190d7e998da57c019d03f17fe00c2f14415b0ca7

8 years agoMerge pull request dotnet/corefx#9281 from Dmitri-Botcharnikov/symbol-reader
Mike McLaughlin [Wed, 15 Jun 2016 16:24:24 +0000 (09:24 -0700)]
Merge pull request dotnet/corefx#9281 from Dmitri-Botcharnikov/symbol-reader

System.Diagnostics.Debug.SymbolReader assembly for reading Portable PDB on Linux.

Commit migrated from https://github.com/dotnet/corefx/commit/7167f2282d8706c2025c85529a456497615bfb07

8 years agoFix several DateTimeOffset tests in various timezones
Stephen Toub [Wed, 15 Jun 2016 13:49:06 +0000 (09:49 -0400)]
Fix several DateTimeOffset tests in various timezones

Commit migrated from https://github.com/dotnet/corefx/commit/6b4402c7195aa0727415f05fb003decfe8a4c430

8 years agoMerge pull request dotnet/corefx#9412 from stephentoub/websocket_networkstream
Stephen Toub [Wed, 15 Jun 2016 15:40:38 +0000 (11:40 -0400)]
Merge pull request dotnet/corefx#9412 from stephentoub/websocket_networkstream

More perf improvements for managed WebSocket client on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/774f53694f91f8ff2d2025314a82c746d2a94f08

8 years agoEnsure correct exception is thrown in several situations
Stephen Toub [Wed, 15 Jun 2016 03:19:08 +0000 (23:19 -0400)]
Ensure correct exception is thrown in several situations

- Our closing the socket may trigger our own pending receive to return successfully with 0 bytes read, as if the other end had closed the connection.  We need to treat this as an ObjectDisposedException to match the Windows behavior.
- If the Socket ends with an operation canceled code, we should throw an OperationCanceledException to match the Windows behavior.
- When using wss (https), we use an SslStream, and if the underlying stream is disposed of, SslStream may throw an InvalidOperationException due to the connection no longer being authenticated.  That needs to be translated into the appropriate exception type to match Windows behavior.

Commit migrated from https://github.com/dotnet/corefx/commit/2e59fabb707f8f3437d69bfdf683d1ae1b38fcd5

8 years agoAddress PR feedback
Stephen Toub [Tue, 14 Jun 2016 20:40:34 +0000 (16:40 -0400)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5c5c349ddbe40d62731c8772b24d69db96a71c88

8 years agoFix stream disposal causing test failures
Stephen Toub [Tue, 14 Jun 2016 20:38:31 +0000 (16:38 -0400)]
Fix stream disposal causing test failures

Two issues, one preexisting this change and one introduced by it.
- Preexisting: TcpClient on Unix simulates socket.Connect(string host, int port) by creating a new Socket for each possible address we're attempting to connect to.  As a result, if the TcpClient is Dispose'd before the connection is successful, we won't yet have stored the actual Socket into the TcpClient and we won't end up Dispose'ing the Socket.  Then subsequent attempts to send/receive on that socket will continue, as they will be operating on a valid Socket.
- New: Previously the Socket would end up being Dispose'd of when we Dispose'd of the TcpClient we were holding on to.  now that Dispose happens via the NetworkStream.  But we weren't passing ownsSocket: true to the NetworkStream, so when it was Dispose'd, it wasn't Dispose'ing of the Socket, resulting in similar hangs when trying to send/receive in abort scenarios.

Commit migrated from https://github.com/dotnet/corefx/commit/270a831355b9a58913652320f8f6e0a610275d8f

8 years agoDelete unused resources in Strings.resx
Stephen Toub [Tue, 14 Jun 2016 11:57:42 +0000 (07:57 -0400)]
Delete unused resources in Strings.resx

Commit migrated from https://github.com/dotnet/corefx/commit/4e3f738215c3e3051dad1d849d67a493f1b35279

8 years agoMake WebSocketReceiveResult's fields readonly
Stephen Toub [Tue, 14 Jun 2016 11:46:51 +0000 (07:46 -0400)]
Make WebSocketReceiveResult's fields readonly

And delete a bit of dead code.

Commit migrated from https://github.com/dotnet/corefx/commit/88b5e73c265127fc7f2cbde63cae36921036ec85

8 years agoUse nameof in ClientWebSocket
Stephen Toub [Tue, 14 Jun 2016 11:43:09 +0000 (07:43 -0400)]
Use nameof in ClientWebSocket

Happened to notice these while doing perf work.

Commit migrated from https://github.com/dotnet/corefx/commit/7961871d88950d75d9eb414528a047025a582a40

8 years agoInline EnsureBufferContainsHeaderAsync into ReceiveAsyncPrivate
Stephen Toub [Tue, 14 Jun 2016 00:14:05 +0000 (20:14 -0400)]
Inline EnsureBufferContainsHeaderAsync into ReceiveAsyncPrivate

Avoids an extra async method (and its associated allocations) on the path where we typically end up yielding waiting for data to arrive.

Commit migrated from https://github.com/dotnet/corefx/commit/c241cc4ca59b8d4ebabc567e333f1a4d9f4767e3

8 years agoRemove base class from ManagedWebSocket
Stephen Toub [Mon, 13 Jun 2016 21:43:00 +0000 (17:43 -0400)]
Remove base class from ManagedWebSocket

It's an internal type, so there's no need for the base class or the virtual methods.  Also, since WebSocket is public, we want to avoid folks being able to cast Task.AsyncState to WebSocket and call methods on this internal object directly, just as a precaution against strange misuse.

Commit migrated from https://github.com/dotnet/corefx/commit/0f21c072c80c3eee7ac199fd01b763a670a225e7

8 years agoOptimize SendFrameAsync to minimize allocations
Stephen Toub [Mon, 13 Jun 2016 21:39:29 +0000 (17:39 -0400)]
Optimize SendFrameAsync to minimize allocations

The previous commit was beneficial in avoiding one large set of overhead, but it also has a flaw that, due to a current behavior in Sockets, sending to a socket inevitably completes asynchronously, which means SendFrameAsync almost always hits an await that yields.  Since this is a very important code path, until the Socket issue can be addressed, we can optimize the common case to minimize the costs involved.

Commit migrated from https://github.com/dotnet/corefx/commit/3e795b025f10cd7c3382b06cbabba82d2094d2f5

8 years agoUse custom network stream in managed WebSockets on Unix
Stephen Toub [Mon, 13 Jun 2016 18:43:41 +0000 (14:43 -0400)]
Use custom network stream in managed WebSockets on Unix

We only need to support a single read and a single write at a time, which means we can create two SocketAsyncEventArgs instances and repeatedly reuse them for all read and write operations on the stream.  This avoids a significant amount of the overhead involved in reading/writing with the network.

Commit migrated from https://github.com/dotnet/corefx/commit/7a2acc72a6b4ede8a7fa82e83b2a58e00e7e2b82

8 years agoMerge pull request dotnet/corefx#9435 from dotnet-bot/UpdateDependencies20160615052234
Stephen Toub [Wed, 15 Jun 2016 13:49:49 +0000 (09:49 -0400)]
Merge pull request dotnet/corefx#9435 from dotnet-bot/UpdateDependencies20160615052234

Updating External dependencies to rc4-24215-00

Commit migrated from https://github.com/dotnet/corefx/commit/de6fd1b7bc0c16a6a0b821de1222c0e82c41f3a2

8 years agoMove classes to their own files
Stephen Toub [Wed, 15 Jun 2016 13:33:28 +0000 (09:33 -0400)]
Move classes to their own files

No logic was changed.  Simply separated out each class into its own file.

Commit migrated from https://github.com/dotnet/corefx/commit/f1caf0ab01184951093e5ee4d701ea1d4159358d

8 years agoReduce running time of WebSocket.Client tests
Stephen Toub [Wed, 15 Jun 2016 13:22:32 +0000 (09:22 -0400)]
Reduce running time of WebSocket.Client tests

They currently take around ~40s on my laptop.  We can easily reduce this significantly by splitting the single test class into multiple test classes, allowing the default xunit parallelism to run them with more concurrency.  On my quad-core, such that xunit by default allows four tests to run concurrently, the tests now take ~10s.  This commit moves some of the shared logic into a base class, and then essentially replaces the regions with classes.  No test logic was changed at all.

Commit migrated from https://github.com/dotnet/corefx/commit/2a0819b66da873ee41c1ba30d93c3332bd39271b

8 years agoUpdating External dependencies to rc4-24215-00
dotnet-bot [Wed, 15 Jun 2016 05:22:34 +0000 (05:22 +0000)]
Updating External dependencies to rc4-24215-00

Commit migrated from https://github.com/dotnet/corefx/commit/e844045b0aa346774f9df364e8c4c70a80d32d5c

8 years agoOverride HttpContent.CreateContentReadStreamAsync in MultipartContent
Stephen Toub [Sun, 12 Jun 2016 23:53:14 +0000 (19:53 -0400)]
Override HttpContent.CreateContentReadStreamAsync in MultipartContent

MultipartContent doesn't override CreateContentReadStreamAsync.  This means that a ReadAsStreamAsync operation will end up serializing all of the content to a MemoryStream, which can be problematic for very large content, preventing such content from being uploaded with some HttpClientHandlers.  This change overrides CreateContentReadStreamAsync to use a custom stream that delegates to all of the inner streams from each content.

Commit migrated from https://github.com/dotnet/corefx/commit/b1d20b427fb68f468740b5ad55c04d41064e1396

8 years agoMerge pull request dotnet/corefx#9432 from dotnet-bot/UpdateDependencies20160615011052
Stephen Toub [Wed, 15 Jun 2016 03:19:34 +0000 (23:19 -0400)]
Merge pull request dotnet/corefx#9432 from dotnet-bot/UpdateDependencies20160615011052

Updating CoreFx dependencies to rc4-24215-01

Commit migrated from https://github.com/dotnet/corefx/commit/15b3bd569cf94c7bece0fa70f91c780d3162eb94

8 years agoUpdating CoreFx dependencies to rc4-24215-01
Stephen Toub [Wed, 15 Jun 2016 02:31:09 +0000 (22:31 -0400)]
Updating CoreFx dependencies to rc4-24215-01

Commit migrated from https://github.com/dotnet/corefx/commit/8539c5c0e3fc42084ac06d7e4b6734df7fcf2932

8 years agoMerge pull request dotnet/corefx#9431 from dotnet-bot/UpdateDependencies20160615121538
Stephen Toub [Wed, 15 Jun 2016 02:03:28 +0000 (22:03 -0400)]
Merge pull request dotnet/corefx#9431 from dotnet-bot/UpdateDependencies20160615121538

Updating CoreClr dependencies to rc4-24215-01

Commit migrated from https://github.com/dotnet/corefx/commit/66865945a6f8994e6bcb2adb550e7b2b5cde4179

8 years agoUpdating CoreClr dependencies to rc4-24215-01
dotnet-bot [Wed, 15 Jun 2016 00:15:38 +0000 (00:15 +0000)]
Updating CoreClr dependencies to rc4-24215-01

Commit migrated from https://github.com/dotnet/corefx/commit/589f0fd89cc7f0f7d475c25343ce8db34dfacf30

8 years agoMerge pull request dotnet/corefx#9421 from dotnet-bot/UpdateDependencies20160614071234
Stephen Toub [Tue, 14 Jun 2016 22:42:19 +0000 (18:42 -0400)]
Merge pull request dotnet/corefx#9421 from dotnet-bot/UpdateDependencies20160614071234

Updating CoreFx dependencies to rc4-24214-04

Commit migrated from https://github.com/dotnet/corefx/commit/0747c3a2b3f6fb9859bf85173652d69f56a540d3

8 years agoMerge pull request dotnet/corefx#9414 from stephentoub/test9357
Stephen Toub [Tue, 14 Jun 2016 19:24:59 +0000 (15:24 -0400)]
Merge pull request dotnet/corefx#9414 from stephentoub/test9357

Add test for posting FormUrlEncodedContent with HttpClient

Commit migrated from https://github.com/dotnet/corefx/commit/56c1611d51121d0e1fe951e68f198cbd1bedea15

8 years agoUpdating CoreFx dependencies to rc4-24214-04
dotnet-bot [Tue, 14 Jun 2016 19:12:33 +0000 (19:12 +0000)]
Updating CoreFx dependencies to rc4-24214-04

Commit migrated from https://github.com/dotnet/corefx/commit/c7fb2cef475f365a384d53b26d4c5612c91fff62

8 years agoMerge pull request dotnet/corefx#9415 from dotnet-bot/UpdateDependencies20160614040743
Stephen Toub [Tue, 14 Jun 2016 17:22:02 +0000 (13:22 -0400)]
Merge pull request dotnet/corefx#9415 from dotnet-bot/UpdateDependencies20160614040743

Updating CoreClr dependencies to rc4-24214-03

Commit migrated from https://github.com/dotnet/corefx/commit/4d6e18872de9386625324c30d600e242a4d6705c

8 years agoUpdating CoreClr dependencies to rc4-24214-03
dotnet-bot [Tue, 14 Jun 2016 16:07:43 +0000 (16:07 +0000)]
Updating CoreClr dependencies to rc4-24214-03

Commit migrated from https://github.com/dotnet/corefx/commit/01d82cedccadf56051b369fbd8089ee4d5ad7ead

8 years agoMerge pull request dotnet/corefx#9411 from dotnet-bot/UpdateDependencies20160614011408
Stephen Toub [Tue, 14 Jun 2016 15:42:52 +0000 (11:42 -0400)]
Merge pull request dotnet/corefx#9411 from dotnet-bot/UpdateDependencies20160614011408

Updating CoreFx dependencies to rc4-24214-03

Commit migrated from https://github.com/dotnet/corefx/commit/658e81b3b866863f8cb06169dc8ab086c6919098

8 years agoAdd test for dotnet/corefx#9357
Stephen Toub [Tue, 14 Jun 2016 15:06:36 +0000 (11:06 -0400)]
Add test for dotnet/corefx#9357

Commit migrated from https://github.com/dotnet/corefx/commit/ab02479780441c1ab1b995e50492c592fbc9f7a9

8 years agoUpdating CoreFx dependencies to rc4-24214-03
dotnet-bot [Tue, 14 Jun 2016 13:14:07 +0000 (13:14 +0000)]
Updating CoreFx dependencies to rc4-24214-03

Commit migrated from https://github.com/dotnet/corefx/commit/22efb2a5f992c25a9f215a13968d14c6903aa1d4

8 years agoMerge pull request dotnet/corefx#9405 from dotnet-bot/UpdateDependencies20160614071701
Stephen Toub [Tue, 14 Jun 2016 12:08:10 +0000 (08:08 -0400)]
Merge pull request dotnet/corefx#9405 from dotnet-bot/UpdateDependencies20160614071701

Updating CoreFx dependencies to rc4-24214-02

Commit migrated from https://github.com/dotnet/corefx/commit/8b969f3c864a1f23eb9a2fb1ebc6709b83f5857e

8 years agoUpdate CoreFX and External Dependencies to 24214-02 and 24214-00
Stephen Toub [Tue, 14 Jun 2016 11:14:56 +0000 (07:14 -0400)]
Update CoreFX and External Dependencies to 24214-02 and 24214-00

Commit migrated from https://github.com/dotnet/corefx/commit/d5dcad160fbe8b7a8cb4e37cda58b9beac5da47d

8 years agoMerge pull request dotnet/corefx#9406 from dotnet-bot/UpdateDependencies20160614080656
Stephen Toub [Tue, 14 Jun 2016 10:58:39 +0000 (06:58 -0400)]
Merge pull request dotnet/corefx#9406 from dotnet-bot/UpdateDependencies20160614080656

Updating CoreClr dependencies to rc4-24214-02

Commit migrated from https://github.com/dotnet/corefx/commit/d2c08909e6790f4281c4302d03f27b0ea6af706b

8 years agoFix SymbolReader after review.
Dmitri Botcharnikov [Tue, 14 Jun 2016 09:14:55 +0000 (12:14 +0300)]
Fix SymbolReader after review.

Commit migrated from https://github.com/dotnet/corefx/commit/5bd91b9ade15872bd373385da84d5b7955598788

8 years agoUpdating CoreClr dependencies to rc4-24214-02
dotnet-bot [Tue, 14 Jun 2016 08:06:56 +0000 (08:06 +0000)]
Updating CoreClr dependencies to rc4-24214-02

Commit migrated from https://github.com/dotnet/corefx/commit/6eee40accbcf630128b133dd8525ee5b7d8ac3f0

8 years agoMerge pull request dotnet/corefx#9396 from CIPop/CIPop-debugdocs
Stephen Toub [Tue, 14 Jun 2016 01:31:40 +0000 (21:31 -0400)]
Merge pull request dotnet/corefx#9396 from CIPop/CIPop-debugdocs

Update windows-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/b4ec441341d9c258eba91c8c140b5c1763c1547d

8 years agoUpdate windows-instructions.md
Cristian Pop [Mon, 13 Jun 2016 23:01:16 +0000 (16:01 -0700)]
Update windows-instructions.md

The debugging extension is now copied in the test folder.

Commit migrated from https://github.com/dotnet/corefx/commit/7fefc299f58813447bf4d621eb2468c085873ead

8 years agoMerge pull request dotnet/corefx#9395 from stephentoub/fix_build_break
Stephen Toub [Mon, 13 Jun 2016 22:55:18 +0000 (18:55 -0400)]
Merge pull request dotnet/corefx#9395 from stephentoub/fix_build_break

Fix build break

Commit migrated from https://github.com/dotnet/corefx/commit/0d1bd5b24f2b25d7e7472ec25953d1943b3d6b58

8 years agoFix build break
Stephen Toub [Mon, 13 Jun 2016 22:52:11 +0000 (18:52 -0400)]
Fix build break

Commit migrated from https://github.com/dotnet/corefx/commit/10e64eb18455998190a8a1a20c576d8e2ab3084f

8 years agoMerge pull request dotnet/corefx#9391 from AtsushiKan/fid
Atsushi Kanamori [Mon, 13 Jun 2016 21:22:44 +0000 (14:22 -0700)]
Merge pull request dotnet/corefx#9391 from AtsushiKan/fid

OidInfo.cs Interop guidelines (part 2)

Commit migrated from https://github.com/dotnet/corefx/commit/bddba0dcf2decd22900f1a8a0944408d3b852fd5

8 years agoMerge pull request dotnet/corefx#9043 from justinvp/credentialcache_allocations
David Shulman [Mon, 13 Jun 2016 21:15:08 +0000 (14:15 -0700)]
Merge pull request dotnet/corefx#9043 from justinvp/credentialcache_allocations

Reduce System.Net.CredentialCache allocations

Commit migrated from https://github.com/dotnet/corefx/commit/90e61f2de82c64e9b83241c42bf1238ca9a8b531

8 years agoOidInfo.cs Interop guidelines (part 2)
Atsushi Kanamori [Mon, 13 Jun 2016 20:18:24 +0000 (13:18 -0700)]
OidInfo.cs Interop guidelines (part 2)

Fixes dotnet/corefx#1820

Commit migrated from https://github.com/dotnet/corefx/commit/1cfd37f12b4487bde486d544363b3d94529421d9

8 years agoMerge pull request dotnet/corefx#9390 from dotnet-bot/UpdateDependencies20160613071843
Stephen Toub [Mon, 13 Jun 2016 20:07:09 +0000 (16:07 -0400)]
Merge pull request dotnet/corefx#9390 from dotnet-bot/UpdateDependencies20160613071843

Updating CoreFx dependencies to rc4-24213-04

Commit migrated from https://github.com/dotnet/corefx/commit/d7ebf210be076072f846f754967402947cc13668

8 years agoMerge pull request dotnet/corefx#9371 from stephentoub/websockets_perf
Stephen Toub [Mon, 13 Jun 2016 20:06:58 +0000 (16:06 -0400)]
Merge pull request dotnet/corefx#9371 from stephentoub/websockets_perf

Remove some allocations from unix WebSocket client

Commit migrated from https://github.com/dotnet/corefx/commit/7b138290a2a02d5c1509fcc51f56929780c00c5d

8 years agoUpdating CoreFx dependencies to rc4-24213-04
dotnet-bot [Mon, 13 Jun 2016 19:18:43 +0000 (19:18 +0000)]
Updating CoreFx dependencies to rc4-24213-04

Commit migrated from https://github.com/dotnet/corefx/commit/50ef40f12ed40a7c497169826297ac61a121aa26

8 years agoMerge pull request dotnet/corefx#9301 from MattGal/FixTestDependencyVersions
Matt Galbraith [Mon, 13 Jun 2016 18:29:09 +0000 (11:29 -0700)]
Merge pull request dotnet/corefx#9301 from MattGal/FixTestDependencyVersions

Update versions in test project.json files to prevent failures due to downgrading

Commit migrated from https://github.com/dotnet/corefx/commit/62c01f58689a9325eba854b091da64dd34147aae

8 years agoAddress PR feedback
Stephen Toub [Mon, 13 Jun 2016 17:53:20 +0000 (13:53 -0400)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ae1fef34fbfd2ab7a97172958bcd08b809c874e1

8 years agoMerge pull request dotnet/corefx#9388 from dotnet-bot/UpdateDependencies20160613043310
Stephen Toub [Mon, 13 Jun 2016 17:30:38 +0000 (13:30 -0400)]
Merge pull request dotnet/corefx#9388 from dotnet-bot/UpdateDependencies20160613043310

Updating CoreClr dependencies to rc4-24213-03

Commit migrated from https://github.com/dotnet/corefx/commit/892776d6c5316ac069867f3db661edc788b31da3

8 years agoUpdate versions in test project.json files to prevent downgrading. Should eventually...
Matt Galbraith [Thu, 9 Jun 2016 23:04:43 +0000 (16:04 -0700)]
Update versions in test project.json files to prevent downgrading.  Should eventually also have build-time validation for this.

Commit migrated from https://github.com/dotnet/corefx/commit/77b5065fa52d817482e15b4efc3e13b5af72ae63

8 years agoMerge pull request dotnet/corefx#9384 from stephentoub/socket_unix_delegates
Stephen Toub [Mon, 13 Jun 2016 16:51:58 +0000 (12:51 -0400)]
Merge pull request dotnet/corefx#9384 from stephentoub/socket_unix_delegates

Avoid send/receive delegate allocations with SocketAsyncEventArgs on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/43760b9e7907326d4af41f88c6f8747eecff98ab

8 years agoUpdating CoreClr dependencies to rc4-24213-03
dotnet-bot [Mon, 13 Jun 2016 16:33:10 +0000 (16:33 +0000)]
Updating CoreClr dependencies to rc4-24213-03

Commit migrated from https://github.com/dotnet/corefx/commit/c3d2fb16e1c5e41b1d993eb487b1b807a0670ae1

8 years agoMerge pull request dotnet/corefx#9387 from AtsushiKan/oidinfo
Atsushi Kanamori [Mon, 13 Jun 2016 16:02:06 +0000 (09:02 -0700)]
Merge pull request dotnet/corefx#9387 from AtsushiKan/oidinfo

OidInfo.cs interop guidelines (part 1)

Commit migrated from https://github.com/dotnet/corefx/commit/e40c3a59b43c7182748a623f08b51d916c9fc7e1

8 years agoMerge pull request dotnet/corefx#9385 from dotnet-bot/UpdateDependencies20160613011154
Stephen Toub [Mon, 13 Jun 2016 15:49:18 +0000 (11:49 -0400)]
Merge pull request dotnet/corefx#9385 from dotnet-bot/UpdateDependencies20160613011154

Updating CoreFx dependencies to rc4-24213-03

Commit migrated from https://github.com/dotnet/corefx/commit/d80601370f7a56828eb002700472718e71b3f826

8 years agoOidInfo.cs interop guidelines (part 1)
Atsushi Kanamori [Mon, 13 Jun 2016 15:32:05 +0000 (08:32 -0700)]
OidInfo.cs interop guidelines (part 1)

We'll keep this as one method collection to keep the usability benefit it already has (a self-contained piece without dependencies.)

This PR handles the file rename only (so we can track the change more easily.)

Next PR will do the namespace/type rename.

Commit migrated from https://github.com/dotnet/corefx/commit/156e77762d34b189f113088f0c7d27d777f631d2

8 years agoUpdating CoreFx dependencies to rc4-24213-03
dotnet-bot [Mon, 13 Jun 2016 13:11:54 +0000 (13:11 +0000)]
Updating CoreFx dependencies to rc4-24213-03

Commit migrated from https://github.com/dotnet/corefx/commit/210cf6dd24dac2e501d64079e922c9d9313ab56b

8 years agoAvoid send/receive delegate allocations with SocketAsyncEventArgs on Unix
Stephen Toub [Mon, 13 Jun 2016 12:26:22 +0000 (08:26 -0400)]
Avoid send/receive delegate allocations with SocketAsyncEventArgs on Unix

Every send/receive operation on a Socket on Unix when using SocketAsyncEventArgs is allocating a new delegate.  Since the whole point of SocketAsyncEventArgs is to cache state and ammortize the costs of things across multiple operations, it's better to create the delegate once and reuse it for all operations.

Commit migrated from https://github.com/dotnet/corefx/commit/fde89bd80826a5ad01554660aeb0f3f5c3af1b2e

8 years agoMerge pull request dotnet/corefx#9382 from dotnet-bot/UpdateDependencies20160613081022
Stephen Toub [Mon, 13 Jun 2016 11:41:02 +0000 (07:41 -0400)]
Merge pull request dotnet/corefx#9382 from dotnet-bot/UpdateDependencies20160613081022

Updating CoreClr dependencies to rc4-24213-02

Commit migrated from https://github.com/dotnet/corefx/commit/c159f6ff3c275125f299daf2e8a5bbe19f45adae

8 years agoUpdating CoreFx dependencies to rc4-24213-02
Stephen Toub [Mon, 13 Jun 2016 10:15:41 +0000 (06:15 -0400)]
Updating CoreFx dependencies to rc4-24213-02

Commit migrated from https://github.com/dotnet/corefx/commit/05b479256dfa89188c5cd66579114eb21794a6b2

8 years agoUpdating CoreClr dependencies to rc4-24213-02
dotnet-bot [Mon, 13 Jun 2016 08:10:22 +0000 (08:10 +0000)]
Updating CoreClr dependencies to rc4-24213-02

Commit migrated from https://github.com/dotnet/corefx/commit/e64eebab303588cb7e85045b737320c65957e45d

8 years agoMerge pull request dotnet/corefx#9380 from dotnet-bot/UpdateDependencies20160613052259
Stephen Toub [Mon, 13 Jun 2016 10:10:45 +0000 (06:10 -0400)]
Merge pull request dotnet/corefx#9380 from dotnet-bot/UpdateDependencies20160613052259

Updating External dependencies to rc4-24213-00

Commit migrated from https://github.com/dotnet/corefx/commit/9293806adfde395405994bd4620922d7423a6ac8

8 years agoUpdating External dependencies to rc4-24213-00
dotnet-bot [Mon, 13 Jun 2016 05:22:59 +0000 (05:22 +0000)]
Updating External dependencies to rc4-24213-00

Commit migrated from https://github.com/dotnet/corefx/commit/5ecabfa487b921941e27442e3d2ed63cad8eed65

8 years agoMerge pull request dotnet/corefx#9378 from dotnet-bot/UpdateDependencies20160613121031
Stephen Toub [Mon, 13 Jun 2016 03:28:57 +0000 (23:28 -0400)]
Merge pull request dotnet/corefx#9378 from dotnet-bot/UpdateDependencies20160613121031

Updating CoreClr dependencies to rc4-24213-01

Commit migrated from https://github.com/dotnet/corefx/commit/26dac760c000d3b49d7308668293c678b41ea46a

8 years agoUpdating CoreClr dependencies to rc4-24213-01
dotnet-bot [Mon, 13 Jun 2016 00:10:31 +0000 (00:10 +0000)]
Updating CoreClr dependencies to rc4-24213-01

Commit migrated from https://github.com/dotnet/corefx/commit/5fd1861a7c2c49a71b47bfd27f720d1874404158