Sebastian Dröge [Mon, 30 Dec 2013 09:14:09 +0000 (10:14 +0100)]
audio/video-info: Initialize the complete struct to 0 in the beginning
Instead of only initializing some parts in some code paths. Also
makes it easier to use the reserved bits of the structs later.
https://bugzilla.gnome.org/show_bug.cgi?id=720810
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 22:48:06 +0000 (19:48 -0300)]
audiobasesrc: Bunch of cosmetic/grammar fixes
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:58:43 +0000 (18:58 -0300)]
audiobasesrc: Retarget FIXME to 2.0
Properly fixing this one would break API.
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:54:39 +0000 (18:54 -0300)]
audiobase*: Drop trailing withespaces
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:53:13 +0000 (18:53 -0300)]
audiobasesrc: Break some too long lines
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:41:59 +0000 (18:41 -0300)]
audiobasesrc: Add FIXME for times in NSECONDS
Timebase is in nanoseconds pretty much everywhere else
Jan Schmidt [Thu, 26 Dec 2013 12:21:45 +0000 (23:21 +1100)]
audiodecoder: Choose a default initial caps before sending GAP
If there are no caps from the audio decoder when handling a GAP
event - as when one is received right at the start on a DVD without
initial audio - then choose any default caps for downstream and
then send the GAP, so the audio sink has a configured format in
which to start the ringbuffer.
Also, make the audio sink reject a GAP without caps with a clearer
error message.
Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=603921
Wim Taymans [Thu, 26 Dec 2013 16:41:00 +0000 (17:41 +0100)]
rtsptransport: add more profiles
Add support for Feedback profiles
Wim Taymans [Wed, 25 Dec 2013 09:45:11 +0000 (10:45 +0100)]
video-frame: fix plane copy for index plane
Move the code to handle the index plane in the _copy_plane.
Lionel Landwerlin [Tue, 24 Dec 2013 01:20:25 +0000 (01:20 +0000)]
colorbalance: add missing annotation for list_channels()
https://bugzilla.gnome.org/show_bug.cgi?id=720999
Sebastian Dröge [Mon, 23 Dec 2013 13:54:02 +0000 (14:54 +0100)]
videoconvert: Fix I420 to BGRA fast-path alpha setting
This fast-path was adding 128 to every component including
alpha while it should only be done for all components except
alpha. This caused wrong alpha values to be generated.
Also remove the high-quality I420 to BGRA fast-path as it needs
the same fix, which causes an additional instruction, which causes
orc to emit more than 96 variables, which then just crashes.
This can only be fixed in orc by breaking ABI and allowing more
variables.
Tim-Philipp Müller [Sun, 22 Dec 2013 22:33:26 +0000 (22:33 +0000)]
Automatic update of common submodule
From dbedaa0 to d48bed3
Tim-Philipp Müller [Sun, 22 Dec 2013 21:56:03 +0000 (21:56 +0000)]
po: set gettext domain in Makevars so we don't have to patch the generated Makefile.in.in
https://bugzilla.gnome.org/show_bug.cgi?id=705455
Tim-Philipp Müller [Sun, 22 Dec 2013 22:07:43 +0000 (22:07 +0000)]
tests: make git ignore new test binary
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:06:25 +0000 (18:06 -0300)]
gstaudiobasesink: Always reset last_align
Should be done for all the reset_sync() cases. Not
only for the READY to PAUSED one.
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 21:02:42 +0000 (18:02 -0300)]
gstaudiobasesink: Reset last_align to 0, not -1
This is the expected behavior in READY -> PAUSED
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 20:58:43 +0000 (17:58 -0300)]
gstaudiobasesink: Always reset avg_skew on _reset
Only case in which it wasn't (READY to PAUSED) should
have had this value reseted too.
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 20:10:44 +0000 (17:10 -0300)]
gstaudiobasesink: Retarget FIXME to 2.0
Properly fixing this one would break API
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 18:13:54 +0000 (15:13 -0300)]
gstaudiobasesink: Factor out reset sync routine
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 04:06:33 +0000 (01:06 -0300)]
gstaudiobasesink: Drop dead _sink_async_play() code
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 04:03:14 +0000 (01:03 -0300)]
gstaudiobasesink: Break some too long lines
Reynaldo H. Verdejo Pinochet [Fri, 20 Dec 2013 03:09:22 +0000 (00:09 -0300)]
gstaudiobasesink: Cosmetics, grammar/spelling
- Drop repeated 'yet' from debug msg
- Drop repeated 'to' from param desc
- Some spelling
Edward Hervey [Fri, 20 Dec 2013 13:41:45 +0000 (08:41 -0500)]
audio/video: Initialize all {audio|video}info fields
Fixes "Unitialized Scalar Variable" issues reported by Coverity.
Has the added advantage of detecting whether somebody *does* use those
fields (ending up with a invalid address).
https://bugzilla.gnome.org/show_bug.cgi?id=720810
Reynaldo H. Verdejo Pinochet [Thu, 19 Dec 2013 20:41:31 +0000 (17:41 -0300)]
gstaudiobasesink: Refactor alignment computation for clarity
Sebastian Dröge [Wed, 18 Dec 2013 14:52:09 +0000 (15:52 +0100)]
subparse: Add unit test for LRC subtitles
Sebastian Dröge [Wed, 18 Dec 2013 14:24:02 +0000 (15:24 +0100)]
subparse: Add support for parsing LRC subtitles
https://bugzilla.gnome.org/show_bug.cgi?id=678590
Sebastian Dröge [Wed, 18 Dec 2013 14:07:47 +0000 (15:07 +0100)]
subparse: Add typefinder for LRC subtitles
Aleix Conchillo Flaqué [Tue, 10 Dec 2013 21:54:28 +0000 (13:54 -0800)]
sdp: parse encryption key field
* gst-libs/gst/sdp/gstsdpmessage.c: parse encryption key field (k).
https://bugzilla.gnome.org/show_bug.cgi?id=720215
Stefan Sauer [Tue, 17 Dec 2013 17:04:33 +0000 (18:04 +0100)]
pbutils: add typefinder and descriptions for audio/x-xi
xi files can be read by libsndfile.
Stefan Sauer [Tue, 17 Dec 2013 17:03:40 +0000 (18:03 +0100)]
descriptions: longer version of two audio codec descriptions
Sebastian Dröge [Tue, 17 Dec 2013 16:25:07 +0000 (17:25 +0100)]
video-format: Document usage of GST_VIDEO_FORMAT_ENCODED
This must only ever be used in caps in combination with a non-system
memory GstCapsFeatures, and where it does not make sense to specify
any of the other video formats. Examples of this would be in gst-vaapi.
Sebastian Dröge [Tue, 17 Dec 2013 16:23:19 +0000 (17:23 +0100)]
Revert "video: specify/restrict usage of GST_VIDEO_FORMAT_ENCODED"
This reverts commit
5fcdabd907ca45595b64131bbae0ea963e259a7c.
Instead of making it impossible to use the ENCODED format we should
just document that it must not be used for capsfeature-less caps.
Also this commit broke API/ABI.
Sebastian Dröge [Tue, 17 Dec 2013 16:09:02 +0000 (17:09 +0100)]
videoencoder: Release the allocator on hard resets
Julien Isorce [Mon, 16 Dec 2013 15:53:41 +0000 (15:53 +0000)]
videodecoder: release buffer pool and allocator on full reset
It allows to release the buffer pool sooner (i.e. when going
to GST_STATE_READY). Previously it was released in finalize.
Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=720389
Todd Agulnick [Mon, 16 Dec 2013 05:01:42 +0000 (21:01 -0800)]
Some compiler warning fixes to satisfy XCode compiler
https://bugzilla.gnome.org/show_bug.cgi?id=720513
Sebastian Dröge [Mon, 16 Dec 2013 10:35:12 +0000 (11:35 +0100)]
vorbistag: Read image-type from the GstSample info struct
But for backwards compatibility keep reading it from the caps and only
use the info struct if the caps don't contain the image-type.
Sebastian Dröge [Fri, 13 Dec 2013 13:36:41 +0000 (14:36 +0100)]
videodecoder: gst_video_decoder_release_frame() is available since 1.2.2
Tim-Philipp Müller [Fri, 13 Dec 2013 10:06:25 +0000 (10:06 +0000)]
tools: play: allow parse-launch strings for audio and video sink
Julien Isorce [Thu, 12 Dec 2013 12:42:59 +0000 (13:42 +0100)]
rtpbasepayload: change SSRC on GstRTPCollision event
Change our SSRC and update the caps when we receive a GstRTPCollision
event from downstream.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711560
Julien Isorce [Thu, 12 Dec 2013 12:06:30 +0000 (13:06 +0100)]
rtpbasepayload: implement src_event function
Add a srcpad event handler and call the src_event vmethod.
Edward Hervey [Wed, 11 Dec 2013 15:49:35 +0000 (16:49 +0100)]
video: specify/restrict usage of GST_VIDEO_FORMAT_ENCODED
GST_VIDEO_FORMAT_ENCODED was added to support *extracting* video-related
information (like width, height, framerate,...) from caps.
It is __NOT__ intended to be used as a format field on video/x-raw caps.
Sebastian Rasmussen [Mon, 9 Dec 2013 23:13:55 +0000 (00:13 +0100)]
tests: Add test for rtpbasepayload/-depayload
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720162
Sebastian Rasmussen [Mon, 9 Dec 2013 23:56:07 +0000 (00:56 +0100)]
rtpbuffer: Allow subbuffering of empty buffers
See https://bugzilla.gnome.org/show_bug.cgi?id=720162
Sebastian Dröge [Mon, 9 Dec 2013 15:34:22 +0000 (16:34 +0100)]
convertframe: Fix indention
Sebastian Dröge [Mon, 9 Dec 2013 15:33:40 +0000 (16:33 +0100)]
videoencoder: Add sink_query() src_query() virtual functions
Based on the videodecoder change by Nicolas Dufresne and applied
here for consistency.
https://bugzilla.gnome.org/show_bug.cgi?id=720103
Nicolas Dufresne [Wed, 27 Nov 2013 21:39:52 +0000 (16:39 -0500)]
videodecoder: Add sink_query() src_query() virtual
https://bugzilla.gnome.org/show_bug.cgi?id=720103
Tim-Philipp Müller [Mon, 9 Dec 2013 13:55:28 +0000 (13:55 +0000)]
tools: play: fix compiler warning on windows
Olivier Crête [Sat, 7 Dec 2013 00:27:04 +0000 (19:27 -0500)]
videocodecframe: Correct function name in doc
Olivier Crête [Fri, 6 Dec 2013 21:23:46 +0000 (16:23 -0500)]
videoencoder: Remove gst_video_encoder_set/get_discont
They've never existed outside the header file.
Sebastian Rasmussen [Wed, 4 Dec 2013 00:08:13 +0000 (01:08 +0100)]
docs: add missing files for distribution
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720015
Wim Taymans [Thu, 5 Dec 2013 15:17:22 +0000 (16:17 +0100)]
audiobasesink: handle the RESYNC flag
Also resync when a buffer with the RESYNC flag is seen.
Julien Isorce [Thu, 5 Dec 2013 14:39:57 +0000 (14:39 +0000)]
audiodec/enc: clear reconfigure flag if negotiate succeeds
So that it avoids to send an allocation query twice.
One from an early call to gst_audio_encoder_negotiate from a
subclass, then one from gst_audio_encoder_allocate_output_buffer.
Which means that previously gst_audio_encoder_negotiate was not
clearing the GST_PAD_FLAG_NEED_RECONFIGURE even on success.
Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=719684
Julien Isorce [Thu, 5 Dec 2013 14:31:25 +0000 (14:31 +0000)]
videodec/enc: clear reconfigure flag if negotiate succeeds
So that it avoids to send an allocation query twice.
One from an early call to gst_video_encoder_negotiate from a
subclass, then one from gst_video_encoder_allocate_output_frame.
Which means that previously gst_video_encoder_negotiate was not
clearing the GST_PAD_FLAG_NEED_RECONFIGURE even on success.
Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=719684
Sebastian Dröge [Thu, 5 Dec 2013 10:39:07 +0000 (11:39 +0100)]
theoradec: Use new gst_video_decoder_set_needs_format() API
Sebastian Dröge [Thu, 5 Dec 2013 10:37:09 +0000 (11:37 +0100)]
audiodecoder: Use FALSE instead of 0
Sebastian Dröge [Thu, 5 Dec 2013 10:34:36 +0000 (11:34 +0100)]
videodecoder: Add API to allow subclasses to specify that they needs caps before any buffers
Sebastian Dröge [Thu, 5 Dec 2013 10:25:47 +0000 (11:25 +0100)]
videoencoder: Return not-negotiated if we don't have caps when the first buffer arrives
Otherwise things like filesrc ! jpegenc ! fakesink just crash with
a segmentation fault because subclasses expect caps to be there.
Mark Nauwelaerts [Wed, 4 Dec 2013 18:24:08 +0000 (19:24 +0100)]
audiodecoder: no fallback to segment start for reverse playback
See https://bugzilla.gnome.org/show_bug.cgi?id=709965
Justin Joy [Wed, 4 Dec 2013 15:27:14 +0000 (00:27 +0900)]
convertframe: Fix trivial memory leak in debug statement
gst_element_get_name() requires the caller to g_free() the return value
https://bugzilla.gnome.org/show_bug.cgi?id=719850
Mark Nauwelaerts [Mon, 2 Dec 2013 19:35:04 +0000 (20:35 +0100)]
audiodecoder: use segment start as fallback ts if no other available
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=709965
Mark Nauwelaerts [Sun, 1 Dec 2013 11:37:52 +0000 (12:37 +0100)]
videodecoder: add new API to docs and defs
Mark Nauwelaerts [Tue, 26 Nov 2013 19:50:33 +0000 (20:50 +0100)]
videodecoder: make _release_frame external API
... so subclasses can release a frame all the way (also from frame list)
without having to pass through _finish_frame or _drop_frame.
The latter may not be applicable, or may or may not have already
been called for the frame in question.
See https://bugzilla.gnome.org/show_bug.cgi?id=693772
Mark Nauwelaerts [Tue, 26 Nov 2013 19:51:58 +0000 (20:51 +0100)]
videodecoder: fix spelling error in debug message
Wim Taymans [Fri, 29 Nov 2013 16:30:09 +0000 (17:30 +0100)]
uridecodebin: copy sticky events
Wim Taymans [Fri, 29 Nov 2013 16:26:13 +0000 (17:26 +0100)]
decodebin2: copy sticky events
Sebastian Dröge [Fri, 29 Nov 2013 12:32:55 +0000 (13:32 +0100)]
theoraparse: Fix event handling
Send CAPS event before any SEGMENT events or any other events
that must come in order after the CAPS event.
Tim-Philipp Müller [Fri, 29 Nov 2013 09:04:20 +0000 (09:04 +0000)]
tools: gst-play: quit on Q or Esc key
Tim-Philipp Müller [Thu, 28 Nov 2013 16:22:01 +0000 (16:22 +0000)]
tcp: fix compilation with MSVC
error C2440 at line 165 of gsttcpserversink.c
type cast error: cannot convert from GSocket* to GstMultiSinkHandle
Wim Taymans [Thu, 28 Nov 2013 10:25:20 +0000 (11:25 +0100)]
decodebin2: activate ghost pad before targetting
Activate the decodebin2 pad before setting the target. This makes sure
that the events are copied.
Matthew Waters [Thu, 21 Nov 2013 11:54:42 +0000 (22:54 +1100)]
videometa: add GstVideoGLTextureUploadMeta buffer pool option
allows configuration of whether GstVideoGLTextureUploadMeta is
added to buffers resulting from a buffer pool. This is sperate
to the caps feature in that an element may want to add the upload
meta itself rather than allowing the buffer pool to.
https://bugzilla.gnome.org/show_bug.cgi?id=712798
Sebastian Dröge [Tue, 26 Nov 2013 11:29:30 +0000 (12:29 +0100)]
audiodecoder: error out if no frames are decoded before eos
Raise an error in case no frames are decoded before EOS and we
have input, meaning that data was received but it was somehow invalid.
Based on the videodecoder change, merged here for consistency.
https://bugzilla.gnome.org/show_bug.cgi?id=711094
Sebastian Dröge [Tue, 26 Nov 2013 11:20:33 +0000 (12:20 +0100)]
audiodecoder: Allow using -1 for infinite tolerated errors
Allows using -1 to make audiodecoder never post an error message
after decoding errors.
Based on the videodecoder change, merged here for consistency.
https://bugzilla.gnome.org/show_bug.cgi?id=711094
Sebastian Dröge [Tue, 26 Nov 2013 11:03:24 +0000 (12:03 +0100)]
playsink: Fix visualizations if no visualization plugin was set
https://bugzilla.gnome.org/show_bug.cgi?id=712280
Thiago Santos [Tue, 29 Oct 2013 17:40:23 +0000 (14:40 -0300)]
videodecoder: error out if no frames are decoded before eos
Raise an error in case no frames are decoded before EOS and we
have input, meaning that data was received but it was somehow invalid.
https://bugzilla.gnome.org/show_bug.cgi?id=711094
Thiago Santos [Tue, 29 Oct 2013 17:11:51 +0000 (14:11 -0300)]
videodecoder: allow using -1 for infinite tolerated errors
Allows using -1 to make videodecoder never post an error message
after decoding errors.
https://bugzilla.gnome.org/show_bug.cgi?id=711094
Tim-Philipp Müller [Sun, 24 Nov 2013 14:38:25 +0000 (14:38 +0000)]
tools: play: implement seeking via console in interactive mode
Arrow left and right to seek back of forward.
Tim-Philipp Müller [Sun, 24 Nov 2013 14:33:24 +0000 (14:33 +0000)]
tools: play: fix endless loop on unhandled keys
When debugging output is not enabled.
Tim-Philipp Müller [Sun, 24 Nov 2013 13:49:04 +0000 (13:49 +0000)]
tools: play: add keyboard controls for next/previous item in list
Make the '>' and '<' keys skip to the next or previous item in
the playlist.
Tim-Philipp Müller [Sun, 24 Nov 2013 01:08:48 +0000 (01:08 +0000)]
tools: play: add --interactive switch and basic keyboard handling
Only pause/play with spacebar for now.
Sebastian Dröge [Sat, 23 Nov 2013 10:25:28 +0000 (11:25 +0100)]
typefind: Add typefinder for OpenEXR
Mark Nauwelaerts [Thu, 21 Nov 2013 20:33:59 +0000 (21:33 +0100)]
videodecoder: avoid descending output timestamps
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712796
Tim-Philipp Müller [Fri, 22 Nov 2013 21:00:21 +0000 (21:00 +0000)]
tools: play: add --shuffle command line option
Tim-Philipp Müller [Thu, 21 Nov 2013 16:34:25 +0000 (16:34 +0000)]
tests: add unit test for samiparser issue
https://bugzilla.gnome.org/show_bug.cgi?id=712805
Jihyun Cho [Thu, 21 Nov 2013 13:04:46 +0000 (22:04 +0900)]
subparse: fix null pointer access in sami parser
https://bugzilla.gnome.org/show_bug.cgi?id=712805
Tim-Philipp Müller [Thu, 21 Nov 2013 15:19:47 +0000 (15:19 +0000)]
subparse: g_memmove() is deprecated
Just use plain memmove(), g_memmove() is deprecated in
recent GLib versions.
https://bugzilla.gnome.org/show_bug.cgi?id=712811
Tim-Philipp Müller [Mon, 18 Nov 2013 19:27:14 +0000 (19:27 +0000)]
tests: fix input-selector-test
Update for pad template name changes.
Tim-Philipp Müller [Mon, 18 Nov 2013 16:03:07 +0000 (16:03 +0000)]
tests: fix appsrc test with latest GLib version
With the latest GLib, g_source_remove() complains about not finding
the timeout source with the given ID here, since it was already
destroyed by returning FALSE from the timeout callback. Also return
FALSE from the bus watches when we don't want to be called any more.
Tim-Philipp Müller [Sat, 16 Nov 2013 13:06:37 +0000 (13:06 +0000)]
docs: remove old 0.10 Since markers
They're just confusing.
Tim-Philipp Müller [Sat, 16 Nov 2013 12:29:04 +0000 (12:29 +0000)]
docs: cosmetic since marker fixes
Mark Nauwelaerts [Sat, 16 Nov 2013 14:24:48 +0000 (15:24 +0100)]
audioencoder: also set output buffer DTS
Reynaldo H. Verdejo Pinochet [Thu, 14 Nov 2013 04:53:31 +0000 (01:53 -0300)]
typefind: Fix identification of some MPEG files
Make sure we begin by peeking at MPEG2_MAX_PROBE_LENGTH
bytes.
Fixes:
https://bugzilla.gnome.org/show_bug.cgi?id=678011
Sebastian Dröge [Wed, 13 Nov 2013 19:12:48 +0000 (20:12 +0100)]
rtpbuffer: Fix gst_rtp_buffer_ext_timestamp() with clang 5 on iOS/ARM
The bitwise NOT operator is not defined on signed integers.
Thanks to Wim Taymans for finding the cause.
https://bugzilla.gnome.org/show_bug.cgi?id=711819
Tim-Philipp Müller [Tue, 12 Nov 2013 18:58:43 +0000 (18:58 +0000)]
tests: fix race in streamsynchronizer test
Wait for thread to exit before starting to free the
to_push list, otherwise thread might check the final
to_push->next node only after we've freed it already.
Sreerenj Balachandran [Mon, 11 Nov 2013 12:10:53 +0000 (14:10 +0200)]
videodecoder: try to negotiate the buffer pool even though there is no o/p format
We could have allocation query before caps event and even without caps inside
the query. In such cases , the downstream can return a bufferpool object with
out actually configuring it. This feature is helpful to negotiate the bufferpool
with out knowing the output video format. For eg: some hardware accelerated
decoders can interpret the o/p video format only after it finishes the decoding
of one buffer at least.
https://bugzilla.gnome.org/show_bug.cgi?id=687183
Tom Greenwood [Thu, 7 Nov 2013 15:03:34 +0000 (15:03 +0000)]
appsrc: Fix deadlock that may occur when multiple threads access appsrc at once
https://bugzilla.gnome.org/show_bug.cgi?id=711550
Wim Taymans [Mon, 4 Nov 2013 08:55:17 +0000 (09:55 +0100)]
tagdemux: accumulate buffers in adapter
Accumulate buffers in an adapter instead of appending them because append causes
a lot of memcpys.
Keep track of the last tagsize and accumulate enough data before attempting to
parse more data.
This patch implements a minimal amount of changes in order to not change the
behaviour. We should really rewrite the tag handling and trimming using
the adapter API instead of merging and trimming into a buffer.
Sebastian Dröge [Wed, 6 Nov 2013 11:16:31 +0000 (12:16 +0100)]
adder: Free consistency checker instance in test_live_seeking test
Sebastian Dröge [Wed, 6 Nov 2013 11:01:14 +0000 (12:01 +0100)]
adder: Release some request pads properly in the unit test
Tim-Philipp Müller [Tue, 5 Nov 2013 11:18:01 +0000 (11:18 +0000)]
Automatic update of common submodule
From 865aa20 to dbedaa0
Alessandro Decina [Mon, 4 Nov 2013 10:34:38 +0000 (11:34 +0100)]
discoverer: fix build after last commit
Add a forward declaration for my_g_string_append_printf that specifies
G_GNUC_PRINTF. Turn off indent on it as it drives gst-indent crazy.