Dheeraj Reddy [Thu, 26 Dec 2019 19:25:19 +0000 (00:55 +0530)]
elm_genlist: Fix looping in case first or last item is disabled.
Summary:
Issue with item focus in loop-up when last item is disabled,
check is added to get previous valid item in this case.
Similar change added to loop-down handling.
Change-Id: I2c7b413f29d84b2f5b82d207532c183865082f12
Signed-off-by: Dheeraj Reddy <dheeraj.sj@samsung.com>
Myoungwoon Roy, Kim [Tue, 24 Dec 2019 14:24:07 +0000 (09:24 -0500)]
docs: Fix a typo in guideline about deprecated API
Summary: Fix a typo (elm_textpath_circluar_set -> elm_textpath_circular_set)
Test Plan: Revise documentation only
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10962
Stefan Schmidt [Tue, 24 Dec 2019 14:23:29 +0000 (09:23 -0500)]
examples: js: use correct var to display user name
Summary:
screen_name was used to for both displays, user name and screen name.
Fix this typo and make sure the user_name variable is actually used.
Depends on D10886
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, ProhtMeyhet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10934
Stefan Schmidt [Tue, 24 Dec 2019 14:23:22 +0000 (09:23 -0500)]
examples: js: make sure we declare all variables
Summary:
Avoiding local variables to be declared global and shared automatically.
Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, zmike
Reviewed By: zmike
Subscribers: zmike, ProhtMeyhet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10884
Stefan Schmidt [Tue, 24 Dec 2019 14:23:14 +0000 (09:23 -0500)]
examples: js: ensure we finish all statements with a semicolon
Summary:
JS interpreters seems to be forgiving for these but the majority of the
js code examples already use semicolons. Make it consistent and fix up
the missing places.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10882
Cedric BAIL [Tue, 24 Dec 2019 14:20:11 +0000 (09:20 -0500)]
elementary: enforce container type check for efl_ui_item_index_get and improve documentation.
Summary: Depends on D10927
Reviewers: bu5hm4n, segfaultxavi, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: zmike, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8351
Differential Revision: https://phab.enlightenment.org/D10945
Stefan Schmidt [Thu, 21 Nov 2019 15:51:45 +0000 (16:51 +0100)]
examples_check: remove double dictionary
Same thing as two lines below.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10886
Ali Alzyod [Tue, 24 Dec 2019 08:17:31 +0000 (17:17 +0900)]
efl_text_cursor: assign source textobject to destination on cursor_copy
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10951
a.srour [Tue, 24 Dec 2019 07:34:14 +0000 (16:34 +0900)]
Efl.Text.Cursor: Fix line_jump_by return logic
Summary:
From documentation `line_jump_by` should return `EINA_TRUE` if cursor moved, and `EINA_FALSE` if not moved.
But the current behaviour is reversed, so this should fix it.
Reviewers: ali.alzyod, segfaultxavi, woohyun
Subscribers: AbdullehGhujeh, #committers, cedric, #reviewers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10946
Bowon Ryu [Tue, 24 Dec 2019 02:36:49 +0000 (11:36 +0900)]
evas_object_textblock: remove unreachable code
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.
Test Plan: N/A
Reviewers: ali.alzyod, woohyun, jsuya
Reviewed By: jsuya
Subscribers: jsuya, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10961
Change-Id: I2f464965547a75eae6c7796a47547578257b69f5
JunsuChoi [Tue, 24 Dec 2019 01:54:04 +0000 (10:54 +0900)]
evas_vg_cache: Prevent memory leak
Summary: free hash_key pointer
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10960
Change-Id: I532df49864c8ca9a1070ff84a90d03a60092d268
Carsten Haitzler (Rasterman) [Tue, 24 Dec 2019 00:22:37 +0000 (00:22 +0000)]
ecore-x - fix fallbacks to use capital X in lib name
thanks peter. fixes T8543
@fix
Felipe Magno de Almeida [Mon, 23 Dec 2019 22:26:33 +0000 (07:26 +0900)]
eolian: inherit since information from struct and enum to field
Summary:
If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.
Reviewers: jptiz, Jaehyun_Cho, woohyun, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10948
Bowon Ryu [Tue, 24 Dec 2019 02:36:49 +0000 (11:36 +0900)]
evas_object_textblock: remove unreachable code
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.
Test Plan: N/A
Reviewers: ali.alzyod, woohyun, jsuya
Reviewed By: jsuya
Subscribers: jsuya, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10961
Change-Id: Ib217d15d5a0a011a3a97c2d45cff35e3d61d31df
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Yeongjong Lee [Tue, 24 Dec 2019 02:14:49 +0000 (11:14 +0900)]
eolian_mono: restore removed code to replace WidgetFocus with Focus
This code was removed during migration.
ref
ecaafb08e8b825321d4051133e8b50853311386e
@tizen_fix
Change-Id: I74a83829993608d64488068052c62838a5f37886
JunsuChoi [Tue, 24 Dec 2019 01:54:04 +0000 (10:54 +0900)]
evas_vg_cache: Prevent memory leak
Summary: free hash_key pointer
Test Plan: N/A
Reviewers: Hermet, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10960
Change-Id: Idd9f37271bcb63eb998dfe80526c2045598431c7
Prasoon Singh [Tue, 10 Dec 2019 12:22:01 +0000 (17:52 +0530)]
[OneUI1.5] spinner: Add list view spinner
Change-Id: I685003cf7020bb22db20c80c602f82c381808ca8
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
godlytalias14573465 [Thu, 19 Dec 2019 13:06:15 +0000 (18:36 +0530)]
[Genlist] Support for skipping item queue
Issue: Whether to use style or new API for the item skipping support
Change-Id: If43ffafa94b263018e2a3cdf6944eb5373917b9c
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
godlytalias14573465 [Mon, 16 Dec 2019 14:25:32 +0000 (19:55 +0530)]
[OneUI1.5] Genlist Bottom margin
Change-Id: Iaa6914138168713244fd0b98fb10904e07d53c49
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Yeongjong Lee [Thu, 19 Dec 2019 02:46:11 +0000 (02:46 +0000)]
eina_mono: make internal classes internal
This hide internal classes..
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10912
Yeongjong Lee [Fri, 20 Dec 2019 10:24:29 +0000 (10:24 +0000)]
eo_mono: make BindingEntityAttribute internal
`BindingEntityAttribute` is used internally to check whether the object is
generated binding classes or not.
API user should use protected `IsGeneratedBindingClass` instead.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10937
Yeongjong Lee [Fri, 20 Dec 2019 11:00:45 +0000 (11:00 +0000)]
eo_mono: make Eo.Globals internal
All members of `Eo.Globals` are already `internal`.
It is unnecessary for `Eo.Globals` to be `public`.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10938
Yeongjong Lee [Mon, 23 Dec 2019 08:18:02 +0000 (08:18 +0000)]
eolian_mono: check extension part/property existence before generate ExtensionMethods
Empty ExtensionMethods class won't be generated.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10954
Lauro Moura [Fri, 20 Dec 2019 01:35:23 +0000 (01:35 +0000)]
csharp: Property Indexer implementation
Use Indexers to use brackets, eg [i], syntax.
Keys now can be used as following:
var someVal = obj.SomeProperty[key];
obj.SomeProperty[key] = someNewVal;
And for multiple keys:
var someVal = obj.SomeProperty[(key1, key2)];
obj.SomeProperty[(key1, key2)] = someNewVal;
T8384
Reviewed-by: WooHyun Jung <wh0705.jung@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10791
ali [Fri, 20 Dec 2019 06:13:36 +0000 (06:13 +0000)]
edje_entry: avoid strstr undefined behaviour
strstr behaviour is undefined when passing null to it, we will check if null is passed, then skip.
elm_entry had issue, where crash happened when click on link for example.
elementry_test -> entry -> click on link (crash will happened)
T8535
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10877
Bruno da Silva Belo [Wed, 18 Dec 2019 20:42:08 +0000 (20:42 +0000)]
c#: Fixing ca2208 for Eina.List.
Some ca's warning reactivated.
ref T8428
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10911
WooHyun Jung [Mon, 23 Dec 2019 08:50:17 +0000 (17:50 +0900)]
Revert "eolian: inherit since information from struct to field"
This reverts commit
f349510941a81649cbd040774c3d4939429e3293.
This patch is causing some "ninja test" errors, so the errors
should be fixed first.
JunsuChoi [Mon, 23 Dec 2019 08:39:21 +0000 (17:39 +0900)]
Elm_Transit: Fix wrong intervention progress value
Summary:
If progress_value_set is called more than once, an error value occurs.
The intervention progress must use progress that
does not apply the previous intervention progress.
Test Plan:
meson_option.txt -> remove json in evas-loaders-disabler option
elementary_test -to "animation view"
Click Play -> Play back -> Play
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10907
SangHyeon Jade Lee [Mon, 23 Dec 2019 07:21:10 +0000 (16:21 +0900)]
eolian_mono : add verb unselect on naming helper.
Summary:
currently select is verb and mono name is exposed SelectAll
but unselect is non-verb and mono name is exposed AllUnselect.
to fix this differencies, add unselect in the verb list.
Reviewers: segfaultxavi, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10952
Change-Id: I054f6e7e30a8951f8a3cce7d0d8cdb80f8ba7e37
Hermet Park [Mon, 23 Dec 2019 06:42:17 +0000 (15:42 +0900)]
ui image: fix scale_method expand behavior.
As efl_gfx_image_expand specification,
it scales the image to cover the entire object area on one axis
while maintaining the aspect ratio though image may become larger than the object.
Thus, this option must work as one of fit_width / fit_height
by detertimining either way.
Previously, it was logically wrong.
@fix
Change-Id: I20f874392f5cc3e876546eff7b016185926a7fba
Felipe Magno de Almeida [Mon, 23 Dec 2019 01:21:30 +0000 (10:21 +0900)]
eolian: inherit since information from struct to field
Summary:
If struct field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.
Reviewers: jptiz, Jaehyun_Cho, woohyun, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10948
Change-Id: I7e88d078a0ed43f4bee0cd36ce83781f4b8de883
Felipe Magno de Almeida [Mon, 23 Dec 2019 01:21:30 +0000 (10:21 +0900)]
eolian: inherit since information from struct to field
Summary:
If struct field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.
Reviewers: jptiz, Jaehyun_Cho, woohyun, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10948
Change-Id: I1dfd0ae6dad6f119d8873f6d2aff94398285f803
SangHyeon Jade Lee [Mon, 23 Dec 2019 06:43:14 +0000 (15:43 +0900)]
eolian_mono : add verb unselect on naming helper.
Summary:
currently select is verb and mono name is exposed SelectAll
but unselect is non-verb and mono name is exposed AllUnselect.
to fix this differencies, add unselect in the verb list.
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10952
Change-Id: Ic031a374cd7047e25ae74f3ae2ba921ef1dcf682
Hermet Park [Mon, 23 Dec 2019 06:42:17 +0000 (15:42 +0900)]
ui image: fix scale_method expand behavior.
As efl_gfx_image_expand specification,
it scales the image to cover the entire object area on one axis
while maintaining the aspect ratio though image may become larger than the object.
Thus, this option must work as one of fit_width / fit_height
by detertimining either way.
Previously, it was logically wrong.
@fix
Change-Id: I43a21681bc6ffbdf69a349f4793fb597658623aa
godlytalias14573465 [Mon, 9 Dec 2019 15:15:42 +0000 (20:45 +0530)]
Scroller: Tunning for allowing flick to just one item
Change-Id: Ic4100f7339be893b78148c9dfd821449f548abfb
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Signed-off-by: ChulHeon Jeong <ch.jeong47@samsung.com>
Bruno da Silva Belo [Tue, 17 Dec 2019 19:29:58 +0000 (19:29 +0000)]
c#: Implement IList to Eina.Array.
ref T8488
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10785
Marcel Hollerbach [Tue, 17 Dec 2019 09:07:14 +0000 (10:07 +0100)]
efl_ui_item: use signals from the theme and not object
the problem here is that when we are using the signals from the object,
then the edje object itself will receive press/unpress events before
any content that is swallowed into the edje object.
This means, that no clickable content, added to a item could be clicked
without selecting / unselecting the item. Which was a problem.
With this commit the theme is sending signals which are then passed to
the efl.input.clickable mixin, this way, the part is stacked below the
added content, which means, clickable content will not select / unselect
the item anymore.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10892
Marcel Hollerbach [Fri, 20 Dec 2019 15:13:58 +0000 (16:13 +0100)]
efl_ui_layout: add API to check out the theme_version
this new API returns the theme version specified in the loaded theme.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10944
ali [Fri, 20 Dec 2019 13:04:18 +0000 (14:04 +0100)]
efl.ui.textbox: rename _disabled properties into _enabled
Reviewers: segfaultxavi, woohyun, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D10923
Jaehyun Cho [Fri, 20 Dec 2019 12:48:17 +0000 (13:48 +0100)]
efl_ui_widget: add description of widget parts
Summary:
Description of the widget parts, shadow and background, is added for
documentation.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10940
ali [Fri, 20 Dec 2019 11:45:31 +0000 (12:45 +0100)]
efl.canvas.textblock: update eo file documentation
Summary: T8460
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10936
Ali Alzyod [Fri, 20 Dec 2019 11:35:13 +0000 (12:35 +0100)]
efl_text_attribute_factory: rename to efl_text_formatter
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8455
Differential Revision: https://phab.enlightenment.org/D10925
ali [Fri, 20 Dec 2019 08:49:41 +0000 (09:49 +0100)]
efl.text.style: rename methods/properties and add text_ prefix
Summary:
efl.text.style: rename methods and properties
this change will avoid conflict in the future with other interfaces or class methods.
```
Efl.Text_Style.text_color { set; get; }
Efl.Text_Style.text_backing_type { set; get; }
Efl.Text_Style.text_background_color { set; get;} //this was backing_color
Efl.Text_Style.text_underline_type { set; }
Efl.Text_Style.text_underline_color { set; get; }
Efl.Text_Style.text_underline2_color { set; get; }
Efl.Text_Style.text_underline_dashed_color { set; get; }
Efl.Text_Style.text_underline_height { set; }
Efl.Text_Style.text_underline_dashed_width { set; }
Efl.Text_Style.text_underline_dashed_gap { set; }
Efl.Text_Style.text_strikethrough_type { set; }
Efl.Text_Style.text_strikethrough_color { set; get; }
Efl.Text_Style.text_effect_type { set; }
Efl.Text_Style.text_shadow_direction { set; }
Efl.Text_Style.text_outline_color { set; get; }
Efl.Text_Style.text_shadow_color { set; get; }
Efl.Text_Style.text_glow_color { set; get; }
Efl.Text_Style.text_glow2_color { set; get; }
```
T8533
Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike, cedric
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10897
Jaehyun Cho [Fri, 20 Dec 2019 08:44:41 +0000 (09:44 +0100)]
csharp: add documentation of class Efl.Eo.Config in iwrapper
Summary: Description and since efl version of the class Efl.Eo.Config is added.
Reviewers: YOhoho, lauromoura, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10933
Yeongjong Lee [Fri, 20 Dec 2019 08:37:55 +0000 (17:37 +0900)]
efl_interface: add @since tag for Efl_Model_Children_Event
Summary: @since tag is necessary for stabilized class.
Reviewers: SanghyeonLee, segfaultxavi
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10930
Stefan Schmidt [Thu, 21 Nov 2019 15:51:23 +0000 (16:51 +0100)]
python: remove not needed imports in various python scripts
Should not be much harm but could help to have the minimum imports
needed when used in deployment.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10885
Jaehyun Cho [Fri, 20 Dec 2019 05:25:38 +0000 (14:25 +0900)]
eolian_mono: change Constants class to static class
Summary:
Since Constants class contains static readonly values only, the
Constants class is actually a static class.
Therefore, Constants class is changed from public partial class to
public static partial class.
ref T8398
Reviewers: YOhoho, lauromoura
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10929
SangHyeon Jade Lee [Wed, 11 Dec 2019 07:05:43 +0000 (07:05 +0000)]
efl_interface : stablized Efl_Model_Children_Event
for mvvm publishing, this structure need to be out of beta.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10856
Marcel Hollerbach [Tue, 17 Dec 2019 09:10:56 +0000 (10:10 +0100)]
efl_ui_layout: check theme version better
when we are having the version 1.23.99 we are preparing the release that
is going to be released with version 1.24. With this commit we can
declare theme versions to be for 1.24 which the version number is 1.23.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10891
a.srour [Wed, 18 Dec 2019 08:33:30 +0000 (08:33 +0000)]
Fix textblock style when "lang=x" is presented
This patch should fix `textblock`'s style issue when `lang` property presented, also fix leak when changing font_lang property in `Efl.Canvas.Text`
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10896
Xavi Artigas [Tue, 17 Dec 2019 13:17:00 +0000 (13:17 +0000)]
Remove @beta from Efl.Canvas.Animation classes
Ref T8436
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10894
Xavi Artigas [Tue, 17 Dec 2019 13:15:33 +0000 (13:15 +0000)]
Remove @beta from Efl.Interpolator classes
All of them, except the divisor interpolator, because I still don't
know what it does.
Ref T8445
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10893
Woochanlee [Thu, 19 Dec 2019 09:43:36 +0000 (09:43 +0000)]
eina_hash: Move hash_free_cb to avoid memory leak.
Call hash_free_cb after finish deletion.
ref T8530
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10918
Felipe Magno de Almeida [Wed, 4 Dec 2019 01:27:56 +0000 (01:27 +0000)]
Fix invalid XML comment in efl_mono.dll.config
Use <!-- and --> to comment the license files
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10790
Yeongjong Lee [Fri, 20 Dec 2019 08:24:14 +0000 (17:24 +0900)]
efl_wearable: add @since tag for placeholder item
Change-Id: I77e665157f16f35078093226b62826deab89c150
Hermet Park [Thu, 19 Dec 2019 11:27:11 +0000 (20:27 +0900)]
ector software: catch up losing tasks among the threads.
This is a subsequent change after
8465904c19ea3de2c94c25259ca6a75d0241b4f1.
The major change is almost same but just for gradient stuff.
Change-Id: I2d8e177953d225bb05ee3d60c9a3806bdd180047
Marcel Hollerbach [Thu, 19 Dec 2019 09:50:52 +0000 (10:50 +0100)]
efl_content: equip the tests with more lifetime checks
this can be used to detect more lifetime issues, which catched errors in
efl.ui.panel and efl.ui.scroller.
ref T8536
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10921
Marcel Hollerbach [Thu, 19 Dec 2019 09:50:25 +0000 (10:50 +0100)]
efl_ui_scroller: remove from the sub_object list on unset
this should fix lifetime issues with Efl.Ui.Scroller
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10920
Marcel Hollerbach [Thu, 19 Dec 2019 09:46:16 +0000 (10:46 +0100)]
efl_ui_panel: fix Efl.Content implementation
It appears that content has been deleted, even if it has been unset
before. This also fixes event emission on content_unset.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10919
Cedric BAIL [Wed, 18 Dec 2019 19:34:00 +0000 (11:34 -0800)]
elementary: make sure Efl.Ui.Multi_Selectable_Index_Range use unsigned int for index too.
T8469
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10910
Ali Alzyod [Thu, 19 Dec 2019 15:07:12 +0000 (16:07 +0100)]
efl.text.cursor: clean eo files from comments
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10926
Hermet Park [Thu, 19 Dec 2019 11:27:11 +0000 (20:27 +0900)]
ector software: catch up losing tasks among the threads.
This is a subsequent change after
8465904c19ea3de2c94c25259ca6a75d0241b4f1.
The major change is almost same but just for gradient stuff.
Carsten Haitzler (Rasterman) [Thu, 19 Dec 2019 10:33:37 +0000 (10:33 +0000)]
evas textblock - use snprintf to limit buffer and have buffer big enough
the buffer wasn't big enough for all possible content anyway and it
didn't use snprintf, so large values of i could overflow... pointed to
by warning. fix that warning.
Hosang Kim [Thu, 19 Dec 2019 06:14:15 +0000 (06:14 +0000)]
scroller: add missing efl_content_unset
When efl_content_unset(scroller) is called, efl_content_unset for Efl.Ui.Pan class should be called also.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10906
Yeongjong Lee [Thu, 19 Dec 2019 08:42:55 +0000 (09:42 +0100)]
efl: add @since tags for stabilized classes
Summary: Add missing @since tags.
Test Plan: meson build
Reviewers: bu5hm4n, cedric, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: q66, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10917
Hermet Park [Thu, 19 Dec 2019 08:01:25 +0000 (17:01 +0900)]
ector software: catch up losing tasks among the threads.
Summary:
ector sw uses thread pool internally to process rle job parallel.
First of all, we lost task handles which allocated to each threads,
we must free the task data after thread done.
Secondly, tasks can be managed by one shape instance,
the instance can't catch upon multiple instances alive.
only last task can be attached to the shape instance.
Thus, obvisouly the instance doesn't expect to handle multiple tasks
at the same time, one instance only take care of one task on threading pool.
Reviewers: jsuya, cedric, smohanty, kimcinoo
Reviewed By: jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10916
Change-Id: Ie83102879e82e9cc04456d89ac7f025883b691a7
Yeongjong Lee [Thu, 19 Dec 2019 07:30:53 +0000 (16:30 +0900)]
csharp: remove unused code in workaround
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10914
Yeongjong Lee [Thu, 19 Dec 2019 07:30:48 +0000 (16:30 +0900)]
eolina_mono: prevent empty ExtensionMethods class
Test Plan:
Check the code below is removed from `efl_ui_box_stack.eo.cs`.
```
#if EFL_BETA
#pragma warning disable CS1591
public static class CoreUI_UIBoxStack_ExtensionMethods {
}
#pragma warning restore CS1591
#endif
```
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10905
SangHyeon Jade Lee [Thu, 19 Dec 2019 09:58:15 +0000 (18:58 +0900)]
efl_ui : remove @beta for wearable placeholder item
Change-Id: I9a380a066fb579459cbc9d7070bd657a4155a404
Hermet Park [Thu, 19 Dec 2019 08:01:25 +0000 (17:01 +0900)]
ector software: catch up losing tasks among the threads.
Summary:
ector sw uses thread pool internally to process rle job parallel.
First of all, we lost task handles which allocated to each threads,
we must free the task data after thread done.
Secondly, tasks can be managed by one shape instance,
the instance can't catch upon multiple instances alive.
only last task can be attached to the shape instance.
Thus, obvisouly the instance doesn't expect to handle multiple tasks
at the same time, one instance only take care of one task on threading pool.
Reviewers: jsuya, cedric, smohanty, kimcinoo
Reviewed By: jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10916
Change-Id: I529b567cdda99eac2847b1c4758e113f358cd93d
Yeongjong Lee [Thu, 19 Dec 2019 07:13:21 +0000 (16:13 +0900)]
efl_ui_win: add beta tag for Win_Effect_Type, Win_Conformant_Property beta
They didn't have any dependencies in eo-world.
@tizen_fix
Change-Id: I92d17ba2246ac0f0d524d6281f1a221e90da690e
Yeongjong Lee [Thu, 19 Dec 2019 06:34:31 +0000 (15:34 +0900)]
efl_input_device: remove unused Efl.Input.Device_Subtype
since
16ebf472fd9534196e553373adf876da487547d9,
`Efl.Input.Device_Subtype` was removed.
@tizen_fix
Change-Id: Icd586b9f148d80eaa3c9e1ee5d6c78419536d24d
Yeongjong Lee [Wed, 18 Dec 2019 12:10:09 +0000 (21:10 +0900)]
efl_ui_widget: stablized tizen focus methods
`focus_next_object_set`
`focus_next_object_get`
`focused_object`
`focus_move_policy`
`focus_cycle`
Those methods will be used in csharp.
@tizen_fix
Change-Id: I1cd4ea57c680e60faf23b6233a0375f52661ef06
Yeongjong Lee [Wed, 18 Dec 2019 12:00:03 +0000 (21:00 +0900)]
efl_ui_widget: add widget_focus property to handle focus
`WidgetFocus` will change to `Focus` in csharp.
@tizen_fix
Change-Id: I163f0475182731fb033cf8e4a0e60ed8cae7de69
Marcel Hollerbach [Wed, 18 Dec 2019 16:18:35 +0000 (17:18 +0100)]
efl_ui_format: make this usable with the standard behaviour of accessors
a accessor is never delivering a value, only the pointer to a value.
This makes format working with accessors for list array carray.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10909
Marcel Hollerbach [Wed, 18 Dec 2019 16:15:09 +0000 (17:15 +0100)]
eina_accessor: make carray accessor work properly
a accessor is not really helpfull if it operates like the carray
accessor before this commit. What it was doing is to fill the content of
the "current line" into the data pointer. In a carray the
"current line" is the content of its carray-member.
However, accessors like for inarray array list or inlist do work
completly differently. They are returning the pointer to the "current
line" not the value of the current line.
The only case where this worked is efl_ui_format.c which was only tested
with this accessor, and this accessor also only worked with this
accessor.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10908
Cedric BAIL [Fri, 13 Dec 2019 01:13:30 +0000 (17:13 -0800)]
efl: make sure all index for Efl_Model are unsigned int.
T8469
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10869
Chris Michael [Wed, 18 Dec 2019 15:28:06 +0000 (10:28 -0500)]
tests/ecore_wl2: Fix memory leak
Coverity reports that we leak 'ret_rots' here because
ecore_wl2_window_available_rotations_get allocates space for the
return, so we should free this here.
Fixes CID1408025
Xavi Artigas [Wed, 18 Dec 2019 15:10:17 +0000 (16:10 +0100)]
docs: Formatting issues in Efl.Text.Attribute.Factory
Xavi Artigas [Wed, 18 Dec 2019 15:06:15 +0000 (16:06 +0100)]
docs: Fix typos and whitespace in Efl.Text_Cursor
Xavi Artigas [Wed, 18 Dec 2019 14:17:28 +0000 (15:17 +0100)]
docs: Polish Efl.Text_Interactive docs
Ref T8521
Ref D10711
Xavi Artigas [Wed, 18 Dec 2019 14:03:05 +0000 (15:03 +0100)]
elm_test: small whitespace issue
Lauro Moura [Wed, 18 Dec 2019 13:36:29 +0000 (10:36 -0300)]
csharp: Fix passing acessor with ownership
Summary:
When passing an owned acessor from a converted collection we need a way
to unpin the passed data when the accessor is freed.
This commits adds a thin wrapper around the CArray accessor that unpins
the data when freed.
Depends on D10900
Reviewers: YOhoho, felipealmeida
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers, jptiz, brunobelo
Tags: #efl
Maniphest Tasks: T8486
Differential Revision: https://phab.enlightenment.org/D10901
Lauro Moura [Tue, 17 Dec 2019 17:34:01 +0000 (14:34 -0300)]
csharp: Fix accessor IEnumerable implementation.
Summary:
Fixed after `data_get` marshalling changed (correctly) the data
parameter to `out IntPtr` instead of manually marshalling the double
pointer.
The existing test (`basic_accessor_list`) passed due to the empty
enumerable behavior, which made the `foreach` running no iterations.
Reviewers: brunobelo, jptiz, felipealmeida, YOhoho
Reviewed By: jptiz, YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10900
Hermet Park [Wed, 18 Dec 2019 12:51:54 +0000 (21:51 +0900)]
evas vg: fix memory leak.
Change-Id: Ib25cb4e801b50593ecb56fdff01c82023b80a0d5
Stefan Schmidt [Thu, 12 Dec 2019 10:05:16 +0000 (11:05 +0100)]
ci: refactor the early exit on specific build jobs
Should be no functional change only making all early checks a bit
shorter.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10866
Stefan Schmidt [Mon, 9 Dec 2019 13:41:17 +0000 (14:41 +0100)]
ci: refactor configuration script
Re-factor if-else block for easier reading, update comments and check
that we are on osx when executing that part.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10865
Stefan Schmidt [Thu, 12 Dec 2019 08:30:13 +0000 (09:30 +0100)]
ci: travis: merge two if clauses
A left-over from the various works in this file. All of these commands
are under the same conditions.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10864
Stefan Schmidt [Fri, 15 Nov 2019 08:29:24 +0000 (09:29 +0100)]
ci: enable benchmark target again
It only runs after efl is installed and we need to ensure running with
Elm buffer engine in our docker build for the graphical collection
benchmark.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10848
Stefan Schmidt [Mon, 9 Dec 2019 15:39:34 +0000 (16:39 +0100)]
benchmarks: increase timeout value for running elementary benchmarks
Default is 30s and I run into timeouts all the time. Increasing it to
60s for the elementary benchmarks. On my local machine its around 45s
for the slower one.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10847
Hermet Park [Wed, 18 Dec 2019 12:51:54 +0000 (21:51 +0900)]
evas vg: fix memory leak.
Change-Id: Iccf1217e14a1c3e62e8cbb97f3b7ce2df74a9e7c
Seoyeon Kim [Wed, 18 Dec 2019 10:44:06 +0000 (19:44 +0900)]
Evas_GL: Update tizen document URL
- According to the address change of tizen documents,
the site URL in Evas_GL.h should be updated.
Change-Id: I4ff4ce1f35b5fe860e917922b78301b1dec5923c
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Ali Alzyod [Tue, 17 Dec 2019 14:54:49 +0000 (15:54 +0100)]
efl.text.format: rename methods and properties
Summary:
efl.text.format: rename methods and properties
this change will avoid conflict in the future with other interfaces or class methods.
T8533
Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10895
Yeongjong Lee [Tue, 17 Dec 2019 14:34:41 +0000 (11:34 -0300)]
csharp : add move tag info to EinaAccessor, EinaIterator converter
Summary:
Included commits in devs/lauromoura/remove_eina_mono-rebased
```
commit
ed6679db1901c710cc6ddb50e7001cfd20caa77a
Author: Lauro Moura <lauromoura@expertisesolutions.com.br>
Date: Mon Dec 2 13:58:04 2019 -0300
csharp: add move information to EnumerableToAccessor
Still need to fix the converted accessor ownership, maybe by creating a
custom accessor class that released the pinned memory when is freed.
```
ref T8486
Depends On D10878
Co-authored-by: Lauro Moura <lauromoura@expertisesolutions.com.br>
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8486
Differential Revision: https://phab.enlightenment.org/D10879
Yeongjong Lee [Tue, 17 Dec 2019 14:34:30 +0000 (11:34 -0300)]
eina_mono: replace EinaAccessor and EinaIerator with IEnumerable
Summary:
Eina.Accessor<T> => System.Collections.IEnumerable<T>
Eina.Iterator<T> => System.Collections.IEnumerable<T>
Unit test will work with D10879.
ref T8486
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8486
Differential Revision: https://phab.enlightenment.org/D10878
Stefan Schmidt [Tue, 17 Dec 2019 14:33:45 +0000 (11:33 -0300)]
examples: js: fix variable name
Summary:
Simple mispell in the example.
Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, lauromoura
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10883
Bruno da Silva Belo [Tue, 17 Dec 2019 14:00:09 +0000 (11:00 -0300)]
csharp: Suppressing non-events Raise methods.
Summary: ref T8390
Reviewers: lauromoura, felipealmeida, YOhoho, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8390
Differential Revision: https://phab.enlightenment.org/D10717
Bruno da Silva Belo [Tue, 17 Dec 2019 13:56:42 +0000 (10:56 -0300)]
csharp:Suppressing Warning and Add suffix collection.
Summary: ref T8408
Reviewers: lauromoura, felipealmeida, YOhoho, jptiz
Reviewed By: jptiz
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8408
Differential Revision: https://phab.enlightenment.org/D10669
Xavi Artigas [Fri, 13 Dec 2019 10:47:47 +0000 (11:47 +0100)]
docs: Add detailed text styling information
Summary:
More detailed descriptions for each attribute.
Relationship between attributes.
Default values.
Links to direct API methods for the corresponding property.
General text overhaul and formatting.
Test Plan: Builds and passes tests. Generate docgen or DocFX documentation and enjoy your new Text styling descriptions!
Reviewers: ali.alzyod
Reviewed By: ali.alzyod
Subscribers: AbdullehGhujeh, cedric, #reviewers, #committers, woohyun, bu5hm4n
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10873
Xavi Artigas [Tue, 17 Dec 2019 12:53:25 +0000 (13:53 +0100)]
docs: Add missing docs for Efl.Canvas.Object_Animation
projects / platform / upstream / efl.git / log