tonyg@chromium.org [Tue, 7 Feb 2012 16:55:19 +0000 (16:55 +0000)]
Unreviewed, more svg rebaselines following change in r106918.
* platform/chromium-linux/svg/text/text-text-05-t-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 7 Feb 2012 16:43:23 +0000 (16:43 +0000)]
Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994
"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* public/WebWidget.h:
(WebWidget):
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 16:28:17 +0000 (16:28 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810
* platform/qt/Skipped: Skip one more test because of this bug.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 16:18:30 +0000 (16:18 +0000)]
Encode radius, force and rotationAngle in WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=77986
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
* Shared/WebEvent.h:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
* Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 16:16:16 +0000 (16:16 +0000)]
Unreviewed gardening after r106898. Update platform specific expected results
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 16:13:37 +0000 (16:13 +0000)]
Unreviewed, rolling out r106932.
http://trac.webkit.org/changeset/106932
https://bugs.webkit.org/show_bug.cgi?id=77988
Breaks Mac bots (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorHistory.cpp: Removed.
* inspector/InspectorHistory.h: Removed.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):
* inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
* inspector/elements/undo-dom-edits-2-expected.txt: Removed.
* inspector/elements/undo-dom-edits-2.html: Removed.
* inspector/elements/undo-dom-edits-expected.txt: Removed.
* inspector/elements/undo-dom-edits.html: Removed.
* inspector/styles/undo-add-property-expected.txt: Removed.
* inspector/styles/undo-add-property.html: Removed.
* inspector/styles/undo-change-property-expected.txt: Removed.
* inspector/styles/undo-change-property.html: Removed.
* inspector/styles/undo-property-toggle-expected.txt: Removed.
* inspector/styles/undo-property-toggle.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 16:09:43 +0000 (16:09 +0000)]
[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985
Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/MockTouchPoint.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 16:00:58 +0000 (16:00 +0000)]
Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984
Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.
* .gitignore: Ignore temp files created by Qt Creator and KDevelop.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 15:55:39 +0000 (15:55 +0000)]
[GTK] Broken "HTML5 <scoped style>" detection
https://bugs.webkit.org/show_bug.cgi?id=77979
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.
* configure.ac: Fix wrong variable for HTML5 <style scoped> detection
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 7 Feb 2012 15:54:43 +0000 (15:54 +0000)]
Unreviewed, a couple more chromium rebaselines after r106918.
* platform/chromium-mac-leopard/svg/hixie/perf/006-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 7 Feb 2012 15:51:56 +0000 (15:51 +0000)]
Unreviewed, more chromium rebaselines as a result of change in r106918.
* platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
* platform/chromium-mac-leopard/svg/filters/filter-width-update-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
* platform/chromium-mac-leopard/svg/hixie/perf/005-expected.png: Removed.
* platform/chromium-mac-leopard/svg/hixie/perf/007-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/filter-width-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
* platform/chromium-mac/svg/filters/filter-width-update-expected.png: Removed.
* platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
* platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
* platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
* platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
* svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt.
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 15:46:55 +0000 (15:46 +0000)]
[GTK] Build failure with --enable-web-audio
https://bugs.webkit.org/show_bug.cgi?id=77978
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.list.am: Include AudioSourceProviderClient.h
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 7 Feb 2012 15:46:14 +0000 (15:46 +0000)]
Unreviewed chromium rebaseline to account for change in r106918.
* platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png: Added.
* platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/text-text-05-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt.
* platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt.
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt:
* platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png.
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png.
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png.
* platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
* platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:
* platform/chromium-win/svg/hixie/perf/001-expected.png:
* platform/chromium-win/svg/hixie/perf/001-expected.txt:
* platform/chromium-win/svg/hixie/perf/002-expected.png:
* platform/chromium-win/svg/hixie/perf/002-expected.txt:
* platform/chromium-win/svg/text/append-text-node-to-tspan-expected.png: Added.
* platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt: Added.
* platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.png: Added.
* platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt: Added.
* platform/chromium-win/svg/text/text-text-05-t-expected.png:
* platform/chromium-win/svg/text/text-text-05-t-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/chromium-win/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
* platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
* platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
* svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
* svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Tue, 7 Feb 2012 15:33:58 +0000 (15:33 +0000)]
[Qt] [WK2] Fix the debug build after r106920
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 15:29:34 +0000 (15:29 +0000)]
[Qt] Unreviewed gardening. Update platform specific expected files after r106918.
* platform/qt/Skipped: Unskip non-existing tests.
* platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
* platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/qt/svg/carto.net/tabgroup-expected.png:
* platform/qt/svg/carto.net/tabgroup-expected.txt:
* platform/qt/svg/carto.net/window-expected.png:
* platform/qt/svg/carto.net/window-expected.txt:
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
* platform/qt/svg/filters/filter-width-update-expected.png:
* platform/qt/svg/filters/filter-width-update-expected.txt:
* platform/qt/svg/hixie/perf/003-expected.png:
* platform/qt/svg/hixie/perf/003-expected.txt:
* platform/qt/svg/hixie/perf/004-expected.png:
* platform/qt/svg/hixie/perf/004-expected.txt:
* platform/qt/svg/hixie/perf/005-expected.png:
* platform/qt/svg/hixie/perf/005-expected.txt:
* platform/qt/svg/hixie/perf/006-expected.png:
* platform/qt/svg/hixie/perf/006-expected.txt:
* platform/qt/svg/zoom/page/zoom-background-images-expected.png:
* platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 15:27:08 +0000 (15:27 +0000)]
Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 7 Feb 2012 15:22:03 +0000 (15:22 +0000)]
[GTK] Include gdk-pixbuf in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=77980
Reviewed by Gustavo Noronha Silva.
* gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 15:16:55 +0000 (15:16 +0000)]
[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-07
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Tue, 7 Feb 2012 14:52:17 +0000 (14:52 +0000)]
Unreviewed gardening.
* platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 14:32:35 +0000 (14:32 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
No new tests. (build fix)
* platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 7 Feb 2012 14:00:24 +0000 (14:00 +0000)]
Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.
Tests: inspector/elements/undo-dom-edits-2.html
inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCSSAgent.cpp:
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore):
(WebCore::InspectorDOMAgent::markUndoableState):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):
* inspector/InspectorHistory.cpp: Added.
(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):
* inspector/InspectorHistory.h: Added.
(WebCore):
(InspectorHistory):
(Action):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):
* inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):
* inspector/elements/undo-dom-edits-2-expected.txt: Added.
* inspector/elements/undo-dom-edits-2.html: Added.
* inspector/elements/undo-dom-edits-expected.txt: Added.
* inspector/elements/undo-dom-edits.html: Added.
* inspector/styles/undo-add-property-expected.txt: Added.
* inspector/styles/undo-add-property.html: Added.
* inspector/styles/undo-change-property-expected.txt: Added.
* inspector/styles/undo-change-property.html: Added.
* inspector/styles/undo-property-toggle-expected.txt: Added.
* inspector/styles/undo-property-toggle.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 13:41:30 +0000 (13:41 +0000)]
[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-07
Reviewed by Rob Buis.
1. rename clientIsOk to isClientAvailable.
2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from
release build but keep available in debug build.
No changes in behavior, so no new tests.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Tue, 7 Feb 2012 13:09:46 +0000 (13:09 +0000)]
[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111
Reviewed by Simon Hausmann.
Move the initialization of the interaction engine to componentComplete
in preparation of switching to a Flickable based content positioning
for the touch based WebView.
Suspend the page and delay the dispatch of load success on startup until
the component finished initialization. With this patch instantiating the
WebView in C++ is only possible by creating a QDeclarativeComponent as
the initialization depends on the componentComplete method being called.
Also return valid default values in the viewport info functions if the
interaction engine is not yet initialized because the viewport info
component could finish initialization earlier than the WebView, which
results in QML warnings during MiniBrowser startup.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
* UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::dispatchLoadSucceeded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 12:55:46 +0000 (12:55 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 7 Feb 2012 12:52:48 +0000 (12:52 +0000)]
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
LayoutTests:
* inspector/profiler/heap-snapshot.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 12:44:42 +0000 (12:44 +0000)]
[Qt] New svg/hittest tests introduced in r106882 fail
https://bugs.webkit.org/show_bug.cgi?id=77964
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped: Skip failing tests until fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 7 Feb 2012 12:43:10 +0000 (12:43 +0000)]
Unreviewed, rolling out r106909.
http://trac.webkit.org/changeset/106909
https://bugs.webkit.org/show_bug.cgi?id=77965
~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Tue, 7 Feb 2012 12:29:28 +0000 (12:29 +0000)]
REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
<http://webkit.org/b/77952>
Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.
The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes ("style" and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.
* dom/Element.h:
(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):
* dom/StyledElement.h:
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 7 Feb 2012 12:23:12 +0000 (12:23 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.
No new tests. (build fix).
* platform/qt/FileSystemQt.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 7 Feb 2012 12:12:03 +0000 (12:12 +0000)]
Unreviewed, GTK svg rebaseline after r106918.
* platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
* platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/gtk/svg/carto.net/tabgroup-expected.txt:
* platform/gtk/svg/carto.net/window-expected.txt:
* platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt:
* platform/gtk/svg/filters/filter-width-update-expected.txt:
* platform/gtk/svg/text/text-text-05-t-expected.txt:
* platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
* platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 11:50:37 +0000 (11:50 +0000)]
Unreviewed, rolling out r106915.
http://trac.webkit.org/changeset/106915
https://bugs.webkit.org/show_bug.cgi?id=77961
because 106912 was rolled out (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 11:45:29 +0000 (11:45 +0000)]
[EFL][WK2] Add ModuleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=63608
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-07
Reviewed by Andreas Kling.
Add first version of ModuleEfl.cpp including load(), unload() and platformFunctionPointer().
* Platform/Module.h:
* Platform/efl/ModuleEfl.cpp: Added.
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 11:42:39 +0000 (11:42 +0000)]
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
No new tests. (Not applicable)
Added OS-specific implementation for retrieving the free disk space.
* platform/FileSystem.h:
(WebCore):
* platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):
(WebCore):
Source/WebKit2:
First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 11:19:23 +0000 (11:19 +0000)]
[Qt] Prevent early test termination with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=77945
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.
QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.
* DumpRenderTree/qt/main.cpp:
(main): Don't quit on last window closed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 7 Feb 2012 11:19:19 +0000 (11:19 +0000)]
Rewrite SVG tests to make extensive use of display() in repaint tests
https://bugs.webkit.org/show_bug.cgi?id=77736
Reviewed by Andreas Kling.
Convert all tests in svg/ (except svg/custom & svg/dynamic-updates) that exercise repainting to use the
fast/repaint/resources/repaint.js harness, which forces a layout, and calls layoutTestController.display()
before executing the actual repaint test, so that repaint rectangles are properly tracked and shown (white
areas that are redrawn, on top of the gray background, painted over the web view after the initial painting).
Previously SVG tests used to work like this: (using an HTML example, but it doesn't matter)
<html><body><svg><rect/><script>function change() { rect.setAttribute(...); layoutTestController.notifyDone(); } setTimeout(change, 0); </script></svg></body></html>
We expected that the initial painting was done, before change() as called. This is unreliable for various reasons:
- the timeout is not guaranteed to fire after the document loaded, it may happen inbetween on eg. a slow connection.
- nor is it guaranteed that the document has painted initially before we enter change().
This leads to the current regressions -- if we break repainting, we can't see it in the current layout tests, as the
initial painting always happens after change() executed in trunk, at least on a fast machine.
In order to make repaint testing reliable we have to use following scheme:
<html><body onload="runRepaintTest()"><svg><rect/><script>function repaintTest() { rect.setAttribute(...); }</script></svg></body></html>
runRepaintTest() is provided by the repaint.js harness and does:
if (window.layoutTestController) {
document.body.offsetTop;
layoutTestController.display();
repaintTest();
} else {
setTimeout(repaintTest, 100);
}
Using this harness outside of DRT allows to test SVG repainting tests in the browser as well, as the repainting changes
aren't immediately fired (0ms timer) but instead delayed by 100ms, so a visual "flash" is visible, if something changes.
For DRT it does two things. First it forces Document::updateLayout() to be called, and then forces the web view to paint
immediately, and then it starts tracking any repaint rects, that are fired _after_ the initial painting, which are then
highlighted in the pixel test dump later on. Using display() is the only way to get reliable painting results across
DRT/WebKitTestRunner, and to get rid of the flakiness.
All *.xml/*.html/*.htm/*.xhtml tests which excersise repainting can be moved to use runRepaintTest() from repaint.js.
<body> needs to be changed to <body onload="runRepaintTest()">, and the timeouts & waitUntilDone/notifyDone calls can
be removed from the tests, leading to much nicer testcases, removing lots of boilerplate.
Pure *.svg tests unfortunately can't use <svg onload="runRepaintTest()"> at the moment, due timing differences between
the HTML load and the SVGLoad event, that's out of scope for this bug report. To remove any hacks from the testcases
themselves, I centralized following work-around in a new function in repaint.js, and let all *.svg tests use it.
function runSVGRepaintTest() {
if (window.layoutTestController) {
layoutTestController.waitUntilDone();
setTimeout(runRepaintTest, 0);
} else
runRepaintTest();
}
runRepaintTest() has to be called from a timer at the moment, as the SVGLoad event fires earlier as HTML load event.
Before that is fixed, we have to use <svg onload="runSVGRepaintTest()"> instead of <svg onload="runRepaintTest()">
and append: layoutTestController.notifyDone() to the repaintTest() functions in the testcases. That should explain
the testcase differences between pure-SVG and non-pure-SVG tests, and why I treated them differently. This approach
is unfortunately as flakey as the old, so to make pure *.svg tests test repainting reliable, the bug needs to be fixed.
Note that svg/custom, and svg/dynamic-updates will be fixed in another chunk, as they also require large amounts
of rebaselines.
* fast/repaint/resources/repaint.js:
(runRepaintTest):
(runSVGRepaintTest):
* platform/chromium/test_expectations.txt:
* platform/mac/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/mac/svg/as-image/animated-svg-as-image-expected.png:
* platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
* platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
* platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* platform/mac/svg/as-object/embedded-svg-size-changes-expected.png:
* platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
* platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png:
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
* platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
* platform/mac/svg/carto.net/tabgroup-expected.png:
* platform/mac/svg/carto.net/tabgroup-expected.txt:
* platform/mac/svg/carto.net/window-expected.png:
* platform/mac/svg/carto.net/window-expected.txt:
* platform/mac/svg/css/shadow-changes-expected.png:
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png:
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
* platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
* platform/mac/svg/filters/filter-refresh-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.txt:
* platform/mac/svg/filters/invalidate-on-child-layout-expected.png:
* platform/mac/svg/hixie/perf/001-expected.png:
* platform/mac/svg/hixie/perf/002-expected.png:
* platform/mac/svg/hixie/perf/003-expected.png:
* platform/mac/svg/hixie/perf/003-expected.txt:
* platform/mac/svg/hixie/perf/004-expected.png:
* platform/mac/svg/hixie/perf/004-expected.txt:
* platform/mac/svg/hixie/perf/005-expected.png:
* platform/mac/svg/hixie/perf/005-expected.txt:
* platform/mac/svg/hixie/perf/006-expected.png:
* platform/mac/svg/hixie/perf/006-expected.txt:
* platform/mac/svg/hixie/perf/007-expected.png:
* platform/mac/svg/hixie/perf/007-expected.txt:
* platform/mac/svg/repaint/filter-child-repaint-expected.png:
* platform/mac/svg/repaint/image-href-change-expected.png:
* platform/mac/svg/repaint/image-with-clip-path-expected.png:
* platform/mac/svg/text/append-text-node-to-tspan-expected.png:
* platform/mac/svg/text/modify-text-node-in-tspan-expected.png:
* platform/mac/svg/text/remove-text-node-from-tspan-expected.png:
* platform/mac/svg/text/remove-tspan-from-text-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.txt:
* platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
* platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
* platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
* platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
* platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
* platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* svg/as-background-image/animated-svg-as-background.html:
* svg/as-background-image/resources/animated-rect-relative-size.svg:
* svg/as-background-image/svg-as-background-5.html:
* svg/as-background-image/svg-background-partial-redraw.html:
* svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
* svg/as-image/animated-svg-as-image-same-image.html:
* svg/as-image/animated-svg-as-image.html:
* svg/as-image/resources/animated-rect-fixed-size-2.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-same-image.svg.
* svg/as-image/resources/animated-rect-fixed-size.svg:
* svg/as-image/resources/animated-rect-relative-size.svg:
* svg/as-image/resources/animated-rect-same-image.svg:
* svg/as-image/svg-image-change-content-size.xhtml:
* svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
* svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
* svg/as-object/embedded-svg-size-changes.html:
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
* svg/as-object/nested-embedded-svg-size-changes.html:
* svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
* svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
* svg/carto.net/tabgroup.svg:
* svg/carto.net/window.svg:
* svg/css/shadow-changes.svg:
* svg/dom/SVGPathSegList-segment-modification.svg:
* svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
* svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
* svg/dom/SVGRectElement/rect-modify-rx.svg:
* svg/filters/animate-fill-expected.png:
* svg/filters/animate-fill.svg:
* svg/filters/feImage-reference-invalidation-expected.png:
* svg/filters/feImage-reference-invalidation.svg:
* svg/filters/feImage-target-add-to-document-expected.png:
* svg/filters/feImage-target-add-to-document.svg:
* svg/filters/feImage-target-changes-id-expected.png:
* svg/filters/feImage-target-changes-id.svg:
* svg/filters/feImage-target-id-change-expected.png:
* svg/filters/feImage-target-id-change.svg:
* svg/filters/feImage-target-reappend-to-document-expected.png:
* svg/filters/feImage-target-reappend-to-document.svg:
* svg/filters/feImage-target-remove-from-document-expected.png:
* svg/filters/feImage-target-remove-from-document.svg:
* svg/filters/filter-refresh.svg:
* svg/filters/filter-width-update.svg:
* svg/filters/invalidate-on-child-layout.svg:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:
* svg/hixie/perf/007.xml:
* svg/hixie/perf/resources/smallcats.gif: Added.
* svg/repaint/container-repaint-expected.png:
* svg/repaint/container-repaint.svg:
* svg/repaint/filter-child-repaint.svg:
* svg/repaint/image-href-change.svg:
* svg/repaint/image-with-clip-path.svg:
* svg/text/append-text-node-to-tspan.html:
* svg/text/modify-text-node-in-tspan.html:
* svg/text/remove-text-node-from-tspan.html:
* svg/text/remove-tspan-from-text.html:
* svg/text/text-text-05-t.svg:
* svg/transforms/animated-path-inside-transformed-html.xhtml:
* svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/page/absolute-sized-document-scrollbars.svg:
* svg/zoom/page/relative-sized-document-scrollbars.svg:
* svg/zoom/page/zoom-background-image-tiled.html:
* svg/zoom/page/zoom-background-images.html:
* svg/zoom/page/zoom-coords-viewattr-01-b.svg:
* svg/zoom/page/zoom-foreignObject.svg:
* svg/zoom/page/zoom-getBoundingClientRect.xhtml:
* svg/zoom/page/zoom-hixie-mixed-008.xml:
* svg/zoom/page/zoom-hixie-mixed-009.xml:
* svg/zoom/page/zoom-hixie-rendering-model-004.xhtml:
* svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html:
* svg/zoom/page/zoom-mask-with-percentages.svg:
* svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
* svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html:
* svg/zoom/page/zoom-svg-as-background-with-relative-size.html:
* svg/zoom/page/zoom-svg-as-image.html:
* svg/zoom/page/zoom-svg-as-object.html:
* svg/zoom/page/zoom-svg-as-relative-image.html:
* svg/zoom/page/zoom-svg-float-border-padding.xml:
* svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml:
* svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml:
* svg/zoom/page/zoom-svg-through-object-with-auto-size.html:
* svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml:
* svg/zoom/page/zoom-svg-through-object-with-override-size.html:
* svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml:
* svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled:
* svg/zoom/page/zoom-zoom-coords.xhtml:
* svg/zoom/resources/testPageZoom.js:
(repaintTest):
* svg/zoom/resources/testTextZoom.js:
(repaintTest):
* svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
* svg/zoom/text/absolute-sized-document-scrollbars.svg:
* svg/zoom/text/relative-sized-document-scrollbars.svg:
* svg/zoom/text/zoom-coords-viewattr-01-b.svg:
* svg/zoom/text/zoom-foreignObject.svg:
* svg/zoom/text/zoom-hixie-mixed-008.xml:
* svg/zoom/text/zoom-hixie-mixed-009.xml:
* svg/zoom/text/zoom-hixie-rendering-model-004.xhtml:
* svg/zoom/text/zoom-svg-float-border-padding.xml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 7 Feb 2012 11:10:53 +0000 (11:10 +0000)]
[Inspector] Add the Nokia N9 user agent
https://bugs.webkit.org/show_bug.cgi?id=77949
Reviewed by Simon Hausmann.
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 7 Feb 2012 10:29:57 +0000 (10:29 +0000)]
[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=77953
Reviewed by Andreas Kling.
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 10:22:44 +0000 (10:22 +0000)]
GTK & QT Rebaseline after r106912.
https://bugs.webkit.org/show_bug.cgi?id=77942
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 09:44:25 +0000 (09:44 +0000)]
Unreviewed, rolling out r106912.
http://trac.webkit.org/changeset/106912
https://bugs.webkit.org/show_bug.cgi?id=77947
"AppleWebKit build is broken" (Requested by haraken on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):
* html/DOMURL.h:
(WebCore::DOMURL::create):
(DOMURL):
* html/DOMURL.idl:
* html/PublicURLManager.h: Removed.
* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::webkitURL):
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
(WebCore::WorkerContext::webkitURL):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:
LayoutTests:
* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 08:54:04 +0000 (08:54 +0000)]
Unreviewed, rolling out r106862.
http://trac.webkit.org/changeset/106862
https://bugs.webkit.org/show_bug.cgi?id=77510
Mac build fails if we manually remove generated code
* DerivedSources.make:
* bindings/scripts/generate-bindings.pl:
(generateEmptyHeaderAndCpp):
* bindings/scripts/resolve-supplemental.pl:
* bindings/scripts/update-idl-needs-rebuild.pl: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 08:18:40 +0000 (08:18 +0000)]
Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.
Source/WebCore:
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:
LayoutTests:
Added test to check if createObjectURL & revokeObjectURL are static functions.
* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 7 Feb 2012 08:16:09 +0000 (08:16 +0000)]
http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=77661
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 7 Feb 2012 08:09:09 +0000 (08:09 +0000)]
Fix build on Mac with '--shadow-dom'.
https://bugs.webkit.org/show_bug.cgi?id=77940
Reviewed by Hajime Morita.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 07:25:04 +0000 (07:25 +0000)]
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.
ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.
No new tests, no change in behavior.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 07:22:36 +0000 (07:22 +0000)]
[EFL] Define to prevent a single backing-store application from calling the tiled view function.
https://bugs.webkit.org/show_bug.cgi?id=77842
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.
The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_frame_view_creation_notify):
* ewk/ewk_view_tiled.cpp:
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 07:09:28 +0000 (07:09 +0000)]
Remove Element::ensureShadowRoot export.
https://bugs.webkit.org/show_bug.cgi?id=77932
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
Removes Element::ensureShadowRoot export.
No new tests, no change in behavior.
* WebCore.exp.in:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 7 Feb 2012 06:33:38 +0000 (06:33 +0000)]
http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908
Reviewed by Eric Seidel.
Before this patch, the output of this test depended on the state of the
global cookie store. When running tests in parallel, the cookie store
is shared by multiple tests, and so its state varies from run to run.
This patch changes this test to look only for the specific cookie used
by this test, which should make the test more reliable when run in
parallel with other tests.
* http/tests/security/xssAuditor/cookie-injection-expected.txt:
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 7 Feb 2012 05:45:01 +0000 (05:45 +0000)]
Unreviewed. Web Inspector: rename Artificial to Synthetic according to v8 patch r10614.
* inspector/front-end/DetailedHeapshotGridNodes.js:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isSynthetic):
(WebInspector.HeapSnapshot.prototype._init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 05:44:19 +0000 (05:44 +0000)]
[EFL] Adopt C++ style using camelCase and full variable names.
https://bugs.webkit.org/show_bug.cgi?id=76378
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.
Modify the code to use camelCase and spell out variable names instead of using abbreviations.
Modify the comments which do not match with actual parameters and correct misspelled words.
Adopt EFL Coding style in header files.
The logic of the code is not changed.
* ewk/ewk_cookies.h:
* ewk/ewk_frame.cpp:
(ewk_frame_selection_get):
(ewk_frame_feed_focus_in):
(EWKPrivate::coreFrame):
* ewk/ewk_frame.h:
* ewk/ewk_history.cpp:
(ewk_history_item_new):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):
* ewk/ewk_network.h:
* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_move):
(_ewk_tiled_backing_store_smart_resize):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
* ewk/ewk_tiled_backing_store.h:
(_Ewk_Tile):
* ewk/ewk_tiled_matrix.cpp:
(_Ewk_Tile_Matrix):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_free):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):
* ewk/ewk_tiled_matrix.h:
* ewk/ewk_tiled_model.cpp:
(tile_account):
(ewk_tile_updates_process):
(ewk_tile_unused_cache_tile_put):
(ewk_tile_unused_cache_dbg):
* ewk/ewk_tiled_model.h:
* ewk/ewk_util.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_pre_render_region):
(ewk_view_pre_render_region):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_get):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_get):
(ewk_view_zoom_range_set):
* ewk/ewk_view.h:
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_smart_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Tue, 7 Feb 2012 05:09:11 +0000 (05:09 +0000)]
[BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77927
Reviewed by Antonio Gomes.
WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API.
GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should
use the d pointer directly because the client is internal implementation.
No functionalities changed, no new tests.
* blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::GeolocationControllerClientBlackBerry):
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):
* blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h:
(WebKit):
(GeolocationControllerClientBlackBerry):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 7 Feb 2012 04:47:15 +0000 (04:47 +0000)]
Implement querySelector on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=77714
Reviewed by Dimitri Glazkov.
Source/WebCore:
* dom/SelectorQuery.cpp:
(WebCore::nodeIsRootNodeOfTreeScope):
(WebCore):
(WebCore::SelectorDataList::execute):
LayoutTests:
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 7 Feb 2012 04:41:08 +0000 (04:41 +0000)]
[GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308
.:
Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.
* GNUmakefile.am: TextureMapperGL implies USE(TEXTURE_MAPPER)
* configure.ac: Only allow enabling the GL version of TextureMapper on X11.
Source/WebCore:
Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.
No new tests. This will be covered by accelerated compositing and
3D CSS transform tests eventually.
* GNUmakefile.list.am: Added some files necessary to build TextureMapperGL.
* platform/graphics/cairo/TextureMapperGLCairo.cpp: Added implementations.
* platform/graphics/cairo/TextureMapperGLCairo.h: Updated member list.
* platform/graphics/gtk/WindowGLContext.h: Added.
* platform/graphics/gtk/WindowGLContextGLX.cpp: Added.
* platform/graphics/opengl/TextureMapperGL.cpp: Use the GL shims on GTK.
Source/WebKit/gtk:
Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.
* GNUmakefile.am: Add AcceleratedCompositingContextGL to the list.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext): Added some members for AcceleratedCompositingContextGL.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added empty implementations
for GraphicsLayerClient. This is only used for the GL variant.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp: Added.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::performAllPendingScrolls): Update the root layer while scrolling.
(WebKit::ChromeClient::paint): Update the root layer after painting.
* webkit/webkitwebsettings.cpp: Added an enable-accelerated-compositing setting.
* webkit/webkitwebsettingsprivate.h: Ditto.
* webkit/webkitwebview.cpp:
(webkit_web_view_draw): Call into TextureMapper now.
(webkit_web_view_realize): Use gdk_window_ensure_native here.
(webkit_web_view_update_settings): Support the new enable-accelerated-compositing setting.
(webkit_web_view_settings_notify): Ditto.
Source/WebKit2:
Reviewed by Alejandro G. Castro.
Fix the WebKit2 + AC build for GTK+.
* GNUmakefile.am: Add some missing source files.
* UIProcess/DrawingAreaProxy.cpp:
(WebKit): Add USE(TILED_BACKING_STORE) to the guard.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage): Ditto.
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea): Ditto.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit): Ditto.
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 7 Feb 2012 04:26:17 +0000 (04:26 +0000)]
Change baselinePosition and lineHeight to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=77905
Reviewed by Eric Seidel.
Change the virtual baselinePosition and lineHeight methods to return
LayoutUnits as they are both computed from the height and top/bottom
margins (or width and left/right margins for vertical text), all of
which are LayoutUnits.
No new tests.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::baselinePosition):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::baselinePosition):
* platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::baselinePosition):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):
* rendering/RenderListMarker.h:
(RenderListMarker):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
* rendering/RenderSlider.h:
(RenderSlider):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/mathml/RenderMathMLFraction.h:
(RenderMathMLFraction):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
* rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::baselinePosition):
* rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wangxianzhu@chromium.org [Tue, 7 Feb 2012 04:16:50 +0000 (04:16 +0000)]
Avoid Page::updateViewportArguments() if the causing frame is not the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387
Reviewed by Kenneth Rohde Christiansen.
* dom/Document.cpp:
(WebCore::Document::processViewport):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):
* dom/Document.h:
(Document):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedIntoDocument):
* page/Frame.cpp:
(WebCore::Frame::setDocument):
* page/Page.cpp:
(WebCore::Page::viewportArguments):
(WebCore):
* page/Page.h:
(Page):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Tue, 7 Feb 2012 04:05:21 +0000 (04:05 +0000)]
js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from
worker to document.
https://bugs.webkit.org/show_bug.cgi?id=76762
Reviewed by Ojan Vafai.
* fast/filesystem/resources/async-operations.js:
* fast/filesystem/resources/directory-entry-to-uri.js:
* fast/filesystem/resources/file-entry-to-uri-sync.js:
* fast/filesystem/resources/file-entry-to-uri.js:
* fast/filesystem/resources/file-from-file-entry-sync.js:
* fast/filesystem/resources/file-from-file-entry.js:
* fast/filesystem/resources/file-writer-abort-continue.js:
* fast/filesystem/resources/file-writer-abort-depth.js:
* fast/filesystem/resources/file-writer-abort.js:
* fast/filesystem/resources/file-writer-events.js:
* fast/filesystem/resources/file-writer-gc-blob.js:
* fast/filesystem/resources/file-writer-sync-truncate-extend.js:
* fast/filesystem/resources/file-writer-sync-write-overlapped.js:
* fast/filesystem/resources/file-writer-truncate-extend.js:
* fast/filesystem/resources/file-writer-write-overlapped.js:
* fast/filesystem/resources/fs-worker-common.js:
* fast/filesystem/resources/fs-worker-test-util.js: Removed.
* fast/filesystem/resources/simple-persistent-sync.js:
* fast/filesystem/resources/simple-persistent.js:
* fast/filesystem/resources/simple-readonly.js:
* fast/filesystem/resources/simple-required-arguments-getdirectory.js:
* fast/filesystem/resources/simple-required-arguments-getfile.js:
* fast/filesystem/resources/simple-required-arguments-getmetadata.js:
* fast/filesystem/resources/simple-required-arguments-remove.js:
* fast/filesystem/resources/simple-temporary-sync.js:
* fast/filesystem/resources/simple-temporary.js:
* fast/filesystem/resources/sync-operations.js:
* fast/filesystem/workers/async-operations.html:
* fast/filesystem/workers/file-entry-to-uri-sync.html:
* fast/filesystem/workers/file-from-file-entry-sync.html:
* fast/filesystem/workers/file-from-file-entry.html:
* fast/filesystem/workers/file-writer-events.html:
* fast/filesystem/workers/file-writer-gc-blob.html:
* fast/filesystem/workers/file-writer-sync-truncate-extend.html:
* fast/filesystem/workers/file-writer-sync-write-overlapped.html:
* fast/filesystem/workers/file-writer-truncate-extend.html:
* fast/filesystem/workers/file-writer-write-overlapped.html:
* fast/filesystem/workers/simple-persistent-sync.html:
* fast/filesystem/workers/simple-persistent.html:
* fast/filesystem/workers/simple-temporary-sync.html:
* fast/filesystem/workers/simple-temporary.html:
* fast/filesystem/workers/sync-operations.html:
* fast/js/resources/js-test-pre.js:
(testPassed):
(testFailed):
(finishJSTest):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):
* storage/indexeddb/basics-workers.html:
* storage/indexeddb/resources/basics.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 7 Feb 2012 04:01:34 +0000 (04:01 +0000)]
Unreviewed gardening.
* platform/chromium-mac-snowleopard/fast/canvas/check-stale-putImageData-expected.png: Added.
Yet another font difference.
* platform/chromium/test_expectations.txt: Added LEOPARD to the list of flaky platforms.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 7 Feb 2012 03:52:01 +0000 (03:52 +0000)]
http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=65567
Reviewed by Eric Seidel.
My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).
This patch simplifies the test in the hopes of removing the flakiness.
* http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
* http/tests/security/mixedContent/insecure-script-in-iframe.html:
* http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 7 Feb 2012 03:20:31 +0000 (03:20 +0000)]
Fix some miscellaneous 'make dist' error for WebKitGTK+.
Source/WebCore:
* GNUmakefile.list.am: Add some missing Shadow DOM files to the
source list.
Source/WebKit2:
* GNUmakefile.am: Do not distribute generated files.
Tools:
* MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
files should not be distributed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 7 Feb 2012 03:11:29 +0000 (03:11 +0000)]
http/tests/security/mixedContent/insecure-image-in-main-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77904
Reviewed by Darin Adler.
My theory is that the extra log message is caused by the preload
scanner requesting the image, which might occur if the test is running
extremely slowly (as it might on a debug bot).
This patch simplifies the test in the hopes of removing the flakiness.
* http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
* http/tests/security/mixedContent/insecure-image-in-main-frame.html:
* http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 02:55:24 +0000 (02:55 +0000)]
Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by Anders Carlsson.
* platform/graphics/Region.cpp:
(WebCore::Region::contains):
(WebCore):
* platform/graphics/Region.h:
(Region):
(Shape):
(WebCore::operator==):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 02:43:22 +0000 (02:43 +0000)]
Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852
Reviewed by Adam Barth.
This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.
[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)
No tests. No change in behavior.
* bindings/scripts/CodeGenerator.pm:
(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedArray.idl:
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSTransformValue.idl:
* dom/DOMCoreException.idl:
* dom/Document.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* fileapi/FileException.idl:
* fileapi/OperationNotAllowedException.idl:
* html/HTMLFormElement.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLRenderingContext.idl:
* inspector/JavaScriptCallFrame.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/Console.idl:
* page/DOMWindow.idl:
* page/Location.idl:
* storage/IDBCursor.idl:
* storage/IDBDatabaseException.idl:
* storage/IDBObjectStore.idl:
* storage/SQLException.idl:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGException.idl:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGGradientElement.idl:
* xml/XMLHttpRequestException.idl:
* xml/XPathException.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 7 Feb 2012 02:24:29 +0000 (02:24 +0000)]
[chromium] canvas demo is slow due to unnecessary resource cleanups
https://bugs.webkit.org/show_bug.cgi?id=77135
Reviewed by Kenneth Russell.
Source/WebCore:
This defers dropping a ManagedTexture until it is evicted by the manager, the layer is destroyed, the
TextureManager is destroyed, or the layer is added to a CCLayerTreeHost that has a different texture manager. In
particular, removing a layer from a CCLayerTreeHost and then adding it back to the same host does not drop any
ManagedTextures unless the manager has to evict it for other reasons. This provides a big speedup on sites that
rebuild the compositing tree frequently.
New unit test added for ManagedTexture / TextureManager interaction.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerTreeHost):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::setTextureManager):
(WebCore):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):
* platform/graphics/chromium/ManagedTexture.h:
(ManagedTexture):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/TiledLayerChromium.h:
Source/WebKit/chromium:
* tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
* tests/TextureManagerTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 7 Feb 2012 02:21:09 +0000 (02:21 +0000)]
Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702
Reviewed by Andreas Kling.
Include min/max/stdev in test runs when available to be shown on the perf-o-matic.
Also merge a change to config.js and increment the version number by 1 (unreviewed).
* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/js/config.js:
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 02:04:09 +0000 (02:04 +0000)]
Unreviewed, rolling out r106883.
http://trac.webkit.org/changeset/106883
https://bugs.webkit.org/show_bug.cgi?id=77852
build failure around Chromium V8 bindings
* bindings/scripts/CodeGenerator.pm:
(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedArray.idl:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSTransformValue.idl:
* dom/DOMCoreException.idl:
* dom/Document.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* fileapi/FileException.idl:
* fileapi/OperationNotAllowedException.idl:
* html/HTMLFormElement.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLRenderingContext.idl:
* inspector/JavaScriptCallFrame.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/Console.idl:
* page/DOMWindow.idl:
* page/Location.idl:
* storage/IDBCursor.idl:
* storage/IDBDatabaseException.idl:
* storage/IDBObjectStore.idl:
* storage/SQLException.idl:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGException.idl:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGGradientElement.idl:
* xml/XMLHttpRequestException.idl:
* xml/XPathException.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 01:58:16 +0000 (01:58 +0000)]
WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654
Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/drawingbuffer-test.html
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 7 Feb 2012 01:42:01 +0000 (01:42 +0000)]
Unreviewed gardening.
* DEPS: Rolling the DEPS to get the apple_webkit update
and fix the Chromium build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Tue, 7 Feb 2012 01:39:09 +0000 (01:39 +0000)]
Port some indexeddb layout tests to workers.
https://bugs.webkit.org/show_bug.cgi?id=77805
Reviewed by Tony Chang.
* storage/indexeddb/index-basics-workers-expected.txt: Added.
* storage/indexeddb/index-basics-workers.html: Added.
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt: Added.
* storage/indexeddb/objectstore-basics-workers.html: Added.
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/resources/index-basics.js: Copied from LayoutTests/storage/indexeddb/index-basics.html.
(test):
(setVersion):
(deleteExisting):
(addData):
(addData2):
(addData3):
(getData):
(getObjectData):
(getObjectData2):
(getObjectData3):
(getDataFail):
(getObjectDataFail):
(getObjectData4):
(openKeyCursor):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last.try.get testFailed):
(last):
* storage/indexeddb/resources/objectstore-basics.js: Copied from LayoutTests/storage/indexeddb/objectstore-basics.html.
(test):
(openSuccess):
(setVersionSuccess):
(createIndex):
(testSetVersionAbort):
(createAnotherIndex):
(checkMetadata):
(addData):
(addDateSuccess):
(addSuccess):
(addAgainFailure):
(getSuccess):
(getSuccessDateKey):
(removeSuccess):
(removeSuccessButFalse):
(testPreConditions.request.onsuccess):
(testPreConditions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 01:37:43 +0000 (01:37 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::optionsObjectCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 7 Feb 2012 01:36:25 +0000 (01:36 +0000)]
Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
https://bugs.webkit.org/show_bug.cgi?id=77891
Reviewed by Darin Adler.
Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
directories to properly use LayoutUnits vs ints.
No new tests. No new behavior.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* dom/Clipboard.h:
(WebCore::Clipboard::dragLocation):
(Clipboard):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
* dom/DocumentMarkerController.h:
* dom/Element.cpp:
(WebCore::Element::screenRect):
* dom/Element.h:
(Element):
* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect):
* editing/RenderedPosition.h:
(WebCore::RenderedPosition::absoluteRect):
(RenderedPosition):
* editing/VisiblePosition.h:
(VisiblePosition):
* inspector/DOMNodeHighlighter.cpp:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
* loader/SubframeLoader.h:
(SubframeLoader):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
* page/Frame.cpp:
(WebCore::Frame::nodeImage):
* page/win/FrameCGWin.cpp:
(WebCore::Frame::nodeImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Tue, 7 Feb 2012 01:33:27 +0000 (01:33 +0000)]
Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852
Reviewed by Adam Barth.
This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.
[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)
No tests. No change in behavior.
* bindings/scripts/CodeGenerator.pm:
(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedArray.idl:
* bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.
(WebCore):
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedArray.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSTransformValue.idl:
* dom/DOMCoreException.idl:
* dom/Document.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* fileapi/FileException.idl:
* fileapi/OperationNotAllowedException.idl:
* html/HTMLFormElement.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLRenderingContext.idl:
* inspector/JavaScriptCallFrame.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/Console.idl:
* page/DOMWindow.idl:
* page/Location.idl:
* storage/IDBCursor.idl:
* storage/IDBDatabaseException.idl:
* storage/IDBObjectStore.idl:
* storage/SQLException.idl:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGException.idl:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGGradientElement.idl:
* xml/XMLHttpRequestException.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 01:30:50 +0000 (01:30 +0000)]
RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931
Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-06
Reviewed by Darin Adler.
Source/WebCore:
Adding support for rounded zero-length endcaps for SVG path hit
testing.
Tests: svg/hittest/zero-length-butt-cap-path.xhtml
svg/hittest/zero-length-round-cap-path.xhtml
svg/hittest/zero-length-square-cap-path.xhtml
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):
LayoutTests:
New tests for hit testing against an SVG path of zero length with
endcaps.
* svg/hittest/zero-length-butt-cap-path-expected.txt: Added.
* svg/hittest/zero-length-butt-cap-path.xhtml: Added.
* svg/hittest/zero-length-round-cap-path-expected.txt: Added.
* svg/hittest/zero-length-round-cap-path.xhtml: Added.
* svg/hittest/zero-length-square-cap-path-expected.txt: Added.
* svg/hittest/zero-length-square-cap-path.xhtml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 01:09:43 +0000 (01:09 +0000)]
Add webGLErrorsToConsoleEnabled Settings flag
https://bugs.webkit.org/show_bug.cgi?id=77696
Patch by Gregg Tavares <gman@google.com> on 2012-02-06
Reviewed by Kenneth Russell.
No new tests as there is no change in behavior.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
(WebCore::Settings::webGLErrorsToConsoleEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 7 Feb 2012 01:07:59 +0000 (01:07 +0000)]
Convert PopupMenuClient::clientPadding over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77798
Reviewed by Eric Seidel.
Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.
Source/WebCore:
No new tests.
* platform/PopupMenuClient.h:
(PopupMenuClient):
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
* rendering/RenderTextControlSingleLine.h:
Source/WebKit/chromium:
* src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):
* src/AutofillPopupMenuClient.h:
(AutofillPopupMenuClient):
* tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 7 Feb 2012 01:07:32 +0000 (01:07 +0000)]
ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/
10811325>
Reviewed by Gavin Barraclough.
Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.
This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 00:55:15 +0000 (00:55 +0000)]
Fix color animations by value
https://bugs.webkit.org/show_bug.cgi?id=77812
Patch by Philip Rogers <pdr@google.com> on 2012-02-06
Reviewed by Darin Adler.
Source/WebCore:
Test: svg/animations/animate-color-fill-from-by.html
* svg/SVGAnimatedColor.cpp:
(WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues):
LayoutTests:
* svg/animations/animate-color-fill-from-by-expected.txt: Added.
* svg/animations/animate-color-fill-from-by.html: Added.
* svg/animations/script-tests/animate-color-fill-from-by.js: Added.
(checkFillColor):
(sample1):
(sample2):
(sample3):
(executeTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 7 Feb 2012 00:53:23 +0000 (00:53 +0000)]
Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.
Reviewed by Martin Robinson.
* tests/test_utils.c:
(testutils_relative_chdir):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 7 Feb 2012 00:52:02 +0000 (00:52 +0000)]
REGRESSION (r104303): Clicking inline video controls gives the video a focus ring
https://bugs.webkit.org/show_bug.cgi?id=77288
Reviewed by Darin Adler.
Source/WebCore:
Test: media/video-mouse-focus.html
Do not allow media elements to be focused by mouse click by overriding isMouseFocusable
and returning false.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isMouseFocusable):
* html/HTMLMediaElement.h:
LayoutTests:
* media/video-mouse-focus-expected.txt: Added.
* media/video-mouse-focus.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 7 Feb 2012 00:43:26 +0000 (00:43 +0000)]
Source/WebCore: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/
10211995>
Reviewed by Kenneth Russell.
Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
we only want to flash scrollers when the window becomes visible.
* WebCore.exp.in:
* page/FocusController.cpp:
(WebCore::FocusController::FocusController):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContainingWindowIsVisible):
(WebCore):
* page/FocusController.h:
(FocusController):
(WebCore::FocusController::containingWindowIsVisible):
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.
Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/
10211995>
Reviewed by Kenneth Russell.
* WebView/WebView.mm:
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
Call FocusController::setContainingWindowIsVisible.
Source/WebKit2: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
Reviewed by Kenneth Russell.
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowVisibility]):
Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
Call -[WKView updateWindowVisibility].
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setWindowIsVisible):
Call FocusController::setContainingWindowIsVisible.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 00:41:31 +0000 (00:41 +0000)]
postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893
Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.
Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Feb 2012 00:38:43 +0000 (00:38 +0000)]
WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149
Source/WebCore:
Make sure that WebGL methods returning strings don't return null when
they run successfully.
Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/functions-returning-strings.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::ensureNotNull):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
LayoutTests:
Imported the WebGL conformance test related to this.
Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.
* fast/canvas/webgl/functions-returning-strings-expected.txt: Added.
* fast/canvas/webgl/functions-returning-strings.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Tue, 7 Feb 2012 00:34:18 +0000 (00:34 +0000)]
Refactor Mac platform implementation of the Pasteboard class.
https://bugs.webkit.org/show_bug.cgi?id=77567
The goal of this change is to remove the majority of the methods in
the class interface that are Mac specific.
writeSelectionForTypes has been left to support OS X services.
Some of the methods have been turned into static functions.
The method asURL was being used only by the DragData class and its
implementation has been moved there.
This is a first step in the direction of removing NSPasteboard access from
the WebProcess for WebKit2 (https://bugs.webkit.org/show_bug.cgi?id=77259)
leaving the WebKit1 behavior unchanged.
Reviewed by Alexey Proskuryakov.
No new tests. No changes in behavior.
* platform/Pasteboard.h: Removed most of the Mac specific methods.
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writeURL):
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asURL): Moved code from PasteboardMac.mm. Removed FIXME
because we only want to handle the case of single file, otherwise the user
doesn't know which of the files has been chosen.
* platform/mac/PasteboardMac.mm:
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment): Now a static function.
(WebCore::Pasteboard::writeImage):
(WebCore::documentFragmentWithImageResource): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 7 Feb 2012 00:25:16 +0000 (00:25 +0000)]
[chromium] Drop tiles completely outside of layer bounds when resizing to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=77910
Reviewed by Kenneth Russell.
Source/WebCore:
When resizing a tiled layer to a smaller size, drop all tiles that lie completely outside the new layer bounds.
This avoids attempting to access out-of-bounds tiles when iterating over all tiles in the tiler, which triggers
ASSERT()s, as well as saves some memory.
New unit test added to TiledLayerChromiumTest.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::invalidateRect):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::setBounds):
Source/WebKit/chromium:
Adds test for resizing a layer to cover fewer tiles. Test hits ASSERT()s without any code changes.
* tests/TiledLayerChromiumTest.cpp:
(::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 7 Feb 2012 00:08:27 +0000 (00:08 +0000)]
Revert r106859. It was completely bogus.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 6 Feb 2012 23:44:33 +0000 (23:44 +0000)]
[PerformanceTests] Each Dromaeo test needs its landing html.
https://bugs.webkit.org/show_bug.cgi?id=77504
Reviewed by Ryosuke Niwa.
PerformanceTests:
- Added landing pages for each test which are listed in MANIFEST.json
- Removed some tests which depends on the library whose license is incompatible to WebKit.
- Added local copy of corresponding library. And replace the references to the remote sources
to the local copies.
- Removed old library files under Dromaeo/resources/dromaeo/web/lib/.
- Skipped Sunsupier and v8 test. Such JS centric test should have its own test instead of
running as a part of Dromaeo.
* Dromaeo/cssquery-dojo.html: Added.
* Dromaeo/cssquery-jquery.html: Added.
* Dromaeo/cssquery-prototype.html: Added.
* Dromaeo/dom-attr.html: Added.
* Dromaeo/dom-modify.html: Added.
* Dromaeo/dom-traverse.html: Added.
* Dromaeo/dromaeo-3d-cube.html: Added.
* Dromaeo/dromaeo-core-eval.html: Added.
* Dromaeo/dromaeo-object-array.html: Added.
* Dromaeo/dromaeo-object-regexp.html: Added.
* Dromaeo/dromaeo-object-string.html: Added.
* Dromaeo/dromaeo-string-base64.html: Added.
* Dromaeo/jslib-attr-jquery.html: Added.
* Dromaeo/jslib-attr-prototype.html: Added.
* Dromaeo/jslib-event-jquery.html: Added.
* Dromaeo/jslib-event-prototype.html: Added.
* Dromaeo/jslib-modify-jquery.html: Added.
* Dromaeo/jslib-modify-prototype.html: Added.
* Dromaeo/jslib-style-jquery.html: Added.
* Dromaeo/jslib-style-prototype.html: Added.
* Dromaeo/jslib-traverse-jquery.html: Added.
* Dromaeo/jslib-traverse-prototype.html: Added.
* Dromaeo/resources/dromaeo/web/lib/dojo.js: Removed.
* Dromaeo/resources/dromaeo/web/lib/dojo-1.6.1.js: Added.
* Dromaeo/resources/dromaeo/web/lib/jquery.js: Removed.
* Dromaeo/resources/dromaeo/web/lib/jquery-1.6.4.js: Added.
* Dromaeo/resources/dromaeo/web/lib/mootools.js: Removed.
* Dromaeo/resources/dromaeo/web/lib/prototype.js: Removed.
* Dromaeo/resources/dromaeo/web/lib/prototype-1.7.js: Added.
* Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html:
* Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Removed.
* Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
* Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html:
* Dromaeo/sunspider-3d-morph.html: Added.
* Dromaeo/sunspider-3d-raytrace.html: Added.
* Dromaeo/sunspider-access-binary-trees.html: Added.
* Dromaeo/sunspider-access-fannkuch.html: Added.
* Dromaeo/sunspider-access-nbody.html: Added.
* Dromaeo/sunspider-access-nsieve.html: Added.
* Dromaeo/sunspider-bitops-3bit-bits-in-byte.html: Added.
* Dromaeo/sunspider-bitops-bits-in-byte.html: Added.
* Dromaeo/sunspider-bitops-bitwise-and.html: Added.
* Dromaeo/sunspider-bitops-nsieve-bits.html: Added.
* Dromaeo/sunspider-controlflow-recursive.html: Added.
* Dromaeo/sunspider-crypto-aes.html: Added.
* Dromaeo/sunspider-crypto-md5.html: Added.
* Dromaeo/sunspider-crypto-sha1.html: Added.
* Dromaeo/sunspider-date-format-tofte.html: Added.
* Dromaeo/sunspider-date-format-xparb.html: Added.
* Dromaeo/sunspider-math-cordic.html: Added.
* Dromaeo/sunspider-math-partial-sums.html: Added.
* Dromaeo/sunspider-math-spectral-norm.html: Added.
* Dromaeo/sunspider-regexp-dna.html: Added.
* Dromaeo/sunspider-string-fasta.html: Added.
* Dromaeo/sunspider-string-tagcloud.html: Added.
* Dromaeo/sunspider-string-unpack-code.html: Added.
* Dromaeo/sunspider-string-validate-input.html: Added.
* Dromaeo/v8-crypto.html: Added.
* Dromaeo/v8-deltablue.html: Added.
* Dromaeo/v8-earley-boyer.html: Added.
* Dromaeo/v8-raytrace.html: Added.
* Dromaeo/v8-richards.html: Added.
* Skipped:
Tools:
Added an ignorable pattern which happens in some Dromaeo tests.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 6 Feb 2012 23:23:43 +0000 (23:23 +0000)]
zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::zvmul):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 6 Feb 2012 23:14:11 +0000 (23:14 +0000)]
REGRESSION(r106756): 10% performance hit on DOM/Template.
<http://webkit.org/b/77831>
Reviewed by Ryosuke Niwa.
Let the StylePropertySet used for element attribute style have the element as its parent.
This is accomplished by adding an m_parentIsElement bit to StylePropertySet and sharing
some of the internal logic with inline styles.
In the end, this means that CSSParser will now pick up the document's CSSValuePool when
parsing properties for attribute styles, which fixes the perf regression from r106756.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::contextStyleSheet):
Find contextStyleSheet via the parentElement() when there is one.
(WebCore::StylePropertySet::setNeedsStyleRecalc):
Always set FullStyleChange for attribute style mutations. We can probably use the
same lighter invalidation as inline styles, but that's a topic for another patch.
* css/StylePropertySet.h:
(WebCore::StylePropertySet::createInline):
(WebCore::StylePropertySet::createAttributeStyle):
(WebCore::StylePropertySet::parentRuleInternal):
(WebCore::StylePropertySet::clearParentRule):
(StylePropertySet):
(WebCore::StylePropertySet::parentElement):
(WebCore::StylePropertySet::clearParentElement):
Added m_parentIsElement bit and update assertions as appropriate to not just
cover the inline style case. Added a createAttributeStyle() helper to create
a StylePropertySet for use as Element::attributeStyle().
* dom/StyledElement.h:
* dom/ElementAttributeData.h:
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttributeStyle):
Use StylePropertySet::createAttributeStyle().
* dom/StyledElement.cpp:
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
Remove setNeedsStyleRecalc() calls since that is now handled automatically by
StylePropertySet's mutation methods.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 6 Feb 2012 23:10:54 +0000 (23:10 +0000)]
In AppleWebKit, stop rebuilding IDLs that need not to be rebuilt
https://bugs.webkit.org/show_bug.cgi?id=77510
Reviewed by Adam Barth.
Currently, if any IDL file is updated, all IDL files are rebuilt.
This patch stops rebuilding IDL files which are not modified nor
whose supplemental dependencies are not changed.
The new build flow is as follows:
supplemental.dep : $(ALL_IDLS)
perl resolve-supplemental.pl ...
%.idl-needs-rebuild : %.idl supplemental.dep
perl update-idl-needs-rebuild.pl ...
JS%.cpp : %.idl-needs-rebuild
perl generate-bindings.pl ...
resolve-supplemental.pl generates the following supplemental.dep.
The number in () is the last access timestamp of the file.
A.idl(1200)
B.idl(1000) B-supplemental1.idl(800) B-supplemental2.idl(1200)
C.idl(1000)
update-idl-needs-rebuild.pl for X.idl touches X.idl-needs-rebuild,
if X.idl-needs-rebuild is older than X.idl or the IDL files which are
supplementing X.idl. For example, if the timestamps of A.idl-needs-rebuild,
B.idl-needs-rebuild and C.idl-needs-rebuild are all 1000, then A.idl-needs-rebuild
and B.idl-needs-rebuild will be touched.
Even if no IDL files are modified, update-idl-needs-rebuild.pl can run for all IDL files,
but generate-bindings.pl won't run. If any IDL file is updated, resolve-supplemental.pl
will run once, update-idl-needs-rebuild.pl will run for all IDL files, and
generate-bindings.pl will run for the IDL files which are modified or whose
dependencies are changed.
No tests. I manually confirmed the followings:
- Touch Element.idl, then only Element.idl is rebuilt
- Touch DOMWindow.idl, then only DOMWindow.idl is rebuilt
- Touch DOMWindowWebAudio.idl, then only DOMWindow.idl and DOMWindowWebAudio.idl are rebuilt
* DerivedSources.make: Modified the build flow as described above.
* bindings/scripts/generate-bindings.pl: Modified to read an IDL file path from .idl-needs-rebuild.
* bindings/scripts/update-idl-needs-rebuild.pl: Added. Touches X.idl-needs-rebuild if
the X.idl-needs-rebuild is older than X.idl or the IDL files which are supplementing X.idl.
(touch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 6 Feb 2012 23:10:17 +0000 (23:10 +0000)]
Unreviewed, chromium expectations update.
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904
Test is not flaky on XP.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-06
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Mon, 6 Feb 2012 23:08:52 +0000 (23:08 +0000)]
Windows build fix
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 6 Feb 2012 23:02:17 +0000 (23:02 +0000)]
Chromium build fix after r106836.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 6 Feb 2012 23:00:32 +0000 (23:00 +0000)]
AudioBus need to support stereo->mono down mix in copyFrom sumFrom etc.
https://bugs.webkit.org/show_bug.cgi?id=77609
Patch by Wei James <james.wei@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.
Test: webaudio/stereo2mono-down-mixing.html
* platform/audio/AudioBus.cpp:
(WebCore):
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 6 Feb 2012 22:55:26 +0000 (22:55 +0000)]
[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862
No sign of this test timing out in recent history, and significant
performance work has been done since it was filed. Unmarking as SLOW/PASS.
Reviewed by Tony Chang.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Mon, 6 Feb 2012 22:54:41 +0000 (22:54 +0000)]
[filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881
Reviewed by Adam Barth.
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystem::crackFileSystemURL):
Add the new code path, taken only if innerURL is present.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Mon, 6 Feb 2012 22:39:36 +0000 (22:39 +0000)]
Unreviewed gardening.
More font differences that need a rebaseline.
* platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Removed.
* platform/chromium-linux/fast/canvas/check-stale-putImageData-expected.png: Added.
* platform/chromium-win/fast/canvas/check-stale-putImageData-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 6 Feb 2012 22:35:17 +0000 (22:35 +0000)]
[Chromium] rebaseline test on win/mac after enabling paint opaque tracking for draw culling
https://bugs.webkit.org/show_bug.cgi?id=77497
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by James Robinson.
* platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 6 Feb 2012 22:32:52 +0000 (22:32 +0000)]
http/tests/security/mixedContent/insecure-plugin-in-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77901
Reviewed by Eric Seidel.
This test fails occationally because of the order of the frame load
callbacks. Now that we log mixed content errors to the console, we
don't need to dump the frame load callbacks in this test.
* http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
* http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdn@chromium.org [Mon, 6 Feb 2012 22:30:09 +0000 (22:30 +0000)]
Source/WebCore: Add RefPtrs for parent and sibling counter nodes
https://bugs.webkit.org/show_bug.cgi?id=75212
Reviewed by Adam Barth.
Test: fast/css/counters/reparent-table-children-with-counters-crash.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::updateCounters):
LayoutTests: Test for crash when counter nodes are reparented outside of tables
https://bugs.webkit.org/show_bug.cgi?id=75212
Reviewed by Adam Barth.
* fast/css/counters/reparent-table-children-with-counters-crash-expected.txt: Added.
* fast/css/counters/reparent-table-children-with-counters-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 6 Feb 2012 22:26:29 +0000 (22:26 +0000)]
Unreviewed fix for the new API test that is failing -
WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
builds.
* tests/testwebinspector.c:
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Mon, 6 Feb 2012 22:17:44 +0000 (22:17 +0000)]
Fix for burning SL tree
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 6 Feb 2012 22:17:23 +0000 (22:17 +0000)]
According to the flakiness dashboard, these tests do appear to be
successfully de-flaked.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
projects / profile / ivi / webkit-efl.git / log