fmalita@google.com [Thu, 1 May 2014 13:32:21 +0000 (13:32 +0000)]
Add fmalita@chromium.org to CQ_COMMITTERS.
R=rmistry@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
267693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14496
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:56:19 +0000 (12:56 +0000)]
Support unknown Android target devices via environment variables.
This is useful for working with prototypes and uncommon devices.
NOTRY=true
R=djsollen@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
263673004
git-svn-id: http://skia.googlecode.com/svn/trunk@14495
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:54:25 +0000 (12:54 +0000)]
Display the color at a point.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
261533006
git-svn-id: http://skia.googlecode.com/svn/trunk@14494
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:32:39 +0000 (12:32 +0000)]
Rename expectations for Valgrind bot: ATI5770->GTX550Ti
This will likely cause GM failures, since the GPU has changed.
BUG=skia:2506
R=caryclark@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
265773004
git-svn-id: http://skia.googlecode.com/svn/trunk@14493
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 1 May 2014 03:04:54 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14492
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 23:29:02 +0000 (23:29 +0000)]
add default impl for context methods on shader
These are reasonable return values, since both of these methods can return a known value (0)
which means that no context can be created. This also makes it easier for chrome's subclasses
which already do not want to create a context, but having them actually overridden makes
changing the virtual signatures much harder.
BUG=skia:
R=scroggo@google.com, dominikg@google.com, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
262703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14491
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 21:46:38 +0000 (21:46 +0000)]
Rebaseline tileimagefilter on IntelRhb post-r14432.
TBR=caryclark@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
267573004
git-svn-id: http://skia.googlecode.com/svn/trunk@14490
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:34:14 +0000 (21:34 +0000)]
remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
267573003
git-svn-id: http://skia.googlecode.com/svn/trunk@14489
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:32:37 +0000 (21:32 +0000)]
rebaseline_server: ignore builders we don't have any expectations for
(SkipBuildbotRuns)
BUG=skia:2486
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
269543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14488
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:10:13 +0000 (21:10 +0000)]
one valgrind.supp to rule them all.
R=mtklein@google.com, robertphillips@google.com, borenet@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
268473004
git-svn-id: http://skia.googlecode.com/svn/trunk@14487
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:30 +0000 (20:47 +0000)]
DM: run child tasks that are already on the CPU threadpool serially
These tasks tend to do similar things with similar sized bitmaps, so running
them serially means we tend to hold 2x bitmaps at a time (golden and
comparison) instead of (1+k)x bitmaps (golden and k concurrent comparisons).
We still migrate GPU task's children over to the main CPU thread pool,
because they'll run faster there and free up capacity on the GPU thread.
Before
Debug: 54s, 2.9G peak
Release: 13s, 2.4G peak
After
Debug: 48s, 1.5G peak
Release: 15s, 2.0G peak
BUG=skia:2478
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
261593008
git-svn-id: http://skia.googlecode.com/svn/trunk@14486
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:22 +0000 (20:47 +0000)]
try /LARGEADDRESSAWARE to give Windows 32-bit builds access to more RAM.
BUG=skia:2478
R=borenet@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
258403006
git-svn-id: http://skia.googlecode.com/svn/trunk@14485
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 19:55:51 +0000 (19:55 +0000)]
make gitignore happy with symlinks
See https://codereview.chromium.org/
139473002 for similar CL.
R=djsollen@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
267543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14484
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 19:38:51 +0000 (19:38 +0000)]
Set ulimits for the compile stage.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
265453010
git-svn-id: http://skia.googlecode.com/svn/trunk@14483
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 19:20:42 +0000 (19:20 +0000)]
Add Valgrind suppressions for nvidia driver.
Did we recently switch the machine Valgrind runs on from an ati card to
an nvidia one?
BUG=skia:
R=bsalomon@google.com, borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
266473010
git-svn-id: http://skia.googlecode.com/svn/trunk@14482
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 18:24:16 +0000 (18:24 +0000)]
Rename SK_DEBUGBREAK to SK_ALWAYSBREAK
Committed: http://code.google.com/p/skia/source/detail?r=14473
R=caryclark@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
263553012
git-svn-id: http://skia.googlecode.com/svn/trunk@14481
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:54:00 +0000 (16:54 +0000)]
Fix bug with starting at the home page.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
260773002
git-svn-id: http://skia.googlecode.com/svn/trunk@14480
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:51:51 +0000 (16:51 +0000)]
Avoid undefined behavior and enable asserts in ClampTest.
The old code here wasn't being careful to avoid int32_t overflow in slow_check. Fix that.
R_ASSERT hasn't been doing anything for a while. As a result, there are a couple bugs in SkClampRange, marked as such and commented out. The asserts also weren't quite passing, so I fixed them up (allowing 0xFFFF to be considered either as part of the ramp or part of V1.)
BUG=skia:2481
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
260523004
git-svn-id: http://skia.googlecode.com/svn/trunk@14479
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:49:34 +0000 (16:49 +0000)]
Turn off warnings as errors, also allow c++11 extensions.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
262603005
git-svn-id: http://skia.googlecode.com/svn/trunk@14478
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:34:43 +0000 (16:34 +0000)]
remove inverse_paths from ignored tests
new expectations have been checked in
https://codereview.chromium.org/
264653003
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
265453009
git-svn-id: http://skia.googlecode.com/svn/trunk@14477
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:27:21 +0000 (16:27 +0000)]
Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK (https://codereview.chromium.org/
263553012/)
Reason for revert:
Broke windows bot
Original issue's description:
> Rename SK_DEBUGBREAK to SK_ALWAYSBREAK
>
> Committed: http://code.google.com/p/skia/source/detail?r=14473
R=caryclark@google.com, reed@google.com
TBR=caryclark@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
260763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14476
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:15:49 +0000 (16:15 +0000)]
unsuppress inverse_paths gm images
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
264653003
git-svn-id: http://skia.googlecode.com/svn/trunk@14475
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:14:10 +0000 (16:14 +0000)]
Set TCP keepalive for MySQL connections.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
268473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14474
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 16:14:04 +0000 (16:14 +0000)]
Rename SK_DEBUGBREAK to SK_ALWAYSBREAK
R=caryclark@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
263553012
git-svn-id: http://skia.googlecode.com/svn/trunk@14473
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 16:11:50 +0000 (16:11 +0000)]
Update the list of bots in rebaseline.py.
This script was not updated for the new Ubuntu bots. Also, it was
attempting to rebaseline some bots for which we don't keep results
(NVPR, ASAN).
R=borenet@google.com, borenet
Review URL: https://codereview.chromium.org/
267483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14472
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 15:55:14 +0000 (15:55 +0000)]
Eliminate SkPicture-related flags Chromium no longer requires
This was originally reverted in r14349 (Restore SkPicture-related guard flags for Chrome - https://codereview.chromium.org/
255543004/) due to Android WebView compile failures. These failures should be fixed in Chromium r267210 (Fixing Chromium Android build's reliance on old SkPicture recording API - https://codereview.chromium.org/
251843005/)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
254333003
git-svn-id: http://skia.googlecode.com/svn/trunk@14471
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 15:54:29 +0000 (15:54 +0000)]
Use SkDebugf to print when GrContext can't be created for a config.
Also, don't label it an "Error". New output matches that of GM.
BUG=skia:2494
R=caryclark@google.com, bensong@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
264563008
git-svn-id: http://skia.googlecode.com/svn/trunk@14470
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 15:29:53 +0000 (15:29 +0000)]
refresh expectations for android intel conical gradients
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
260513005
git-svn-id: http://skia.googlecode.com/svn/trunk@14469
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 15:22:47 +0000 (15:22 +0000)]
un-ignore image-surface GM results
NOTRY=True
TBR=reed@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
264623004
git-svn-id: http://skia.googlecode.com/svn/trunk@14468
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 15:18:53 +0000 (15:18 +0000)]
New Ubuntu baselines for tileimagefilter GM post-r14432.
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/
254323003
git-svn-id: http://skia.googlecode.com/svn/trunk@14467
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 15:17:01 +0000 (15:17 +0000)]
rebaseline but with known incorrectness
BUG=skia:2497
NOTRY=True
TBR=bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
266473006
git-svn-id: http://skia.googlecode.com/svn/trunk@14466
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 14:59:38 +0000 (14:59 +0000)]
rebaseline GM changes to image-surface
NOTRY=True
TBR=caryclark@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
254283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14465
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 14:58:46 +0000 (14:58 +0000)]
Cleanup of SSE optimization files.
General cleanup of optimization files for x86/SSEx.
Renamed the opts_check_SSE2.cpp file to _x86, since it's not specific
to SSE2. Commented out the ColorRect32 optimization, since it's
disabled anyway, to make it more visible.
Also fixed a lot of indentation, inclusion guards, spelling,
copyright headers, braces, whitespace, and sorting of includes.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
264603002
git-svn-id: http://skia.googlecode.com/svn/trunk@14464
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 14:56:29 +0000 (14:56 +0000)]
DM: when 32-bit, disable pathops internal threading by default
Before this change, when limited to 4G, pathops threaded tests were the weak
link RAM-consumption-wise (in thread-local font caches) up until about 12
cores, where other problems begin to pile up too.
Tested by running:
ulimit -Sv 4194304
out/Debug/dm --threads N [--pathOpsSingleThread]
After this, we're _probably_ good to go on 32-bit machines with 8 cores.
BUG=skia:2478
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
265593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14463
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 14:35:57 +0000 (14:35 +0000)]
New baselines for tileimagefilter GM after r14432.
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/
260753002
git-svn-id: http://skia.googlecode.com/svn/trunk@14462
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 14:33:04 +0000 (14:33 +0000)]
remove rebaselined tests from ignore file
this removes the lines corresponding to this rebaseline CL
Change committed as 14447
https://codereview.chromium.org/
263473002/
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
262583005
git-svn-id: http://skia.googlecode.com/svn/trunk@14461
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 14:17:00 +0000 (14:17 +0000)]
Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL
R=robertphillips@google.com, reed@google.com, mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
257393004
git-svn-id: http://skia.googlecode.com/svn/trunk@14460
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 14:11:29 +0000 (14:11 +0000)]
Rebaselines post-r14433.
Update testimagefilters GM on SGX540 GPU and matrixconvolution GM on
Win7 (perspective).
TBR=caryclark@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
261533004
git-svn-id: http://skia.googlecode.com/svn/trunk@14459
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 13:37:48 +0000 (13:37 +0000)]
fix cubic/line intersection; add skp tests
BUG=skia:2488
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
252243003
git-svn-id: http://skia.googlecode.com/svn/trunk@14458
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 13:20:45 +0000 (13:20 +0000)]
Turn on quilt mode in DM.
- Rename TileGrid -> Quilt to avoid the name overload.
- Tag all failing GMs with kSkipTiled_Flag.
You may be wondering, do any GMs pass? Yes, some do! And that trends towards all of them as we increase --quiltTile.
Two GMs only fail in --quilt mode in 565. Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.)
BUG=skia:2477
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
256373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14457
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 13:19:28 +0000 (13:19 +0000)]
Remove the unused SkCachePreload_arm
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
263553008
git-svn-id: http://skia.googlecode.com/svn/trunk@14456
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 13:18:12 +0000 (13:18 +0000)]
Backfill unit tests for SkRecord
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
251133008
git-svn-id: http://skia.googlecode.com/svn/trunk@14455
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 12:56:40 +0000 (12:56 +0000)]
bench rebase after eeaeafe
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
260713003
git-svn-id: http://skia.googlecode.com/svn/trunk@14454
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 30 Apr 2014 03:05:25 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14453
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 01:26:04 +0000 (01:26 +0000)]
Fail to create GrContext when we get a NULL for a GL/GLSL version string
BUG=368107
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
254083002
git-svn-id: http://skia.googlecode.com/svn/trunk@14452
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 00:46:29 +0000 (00:46 +0000)]
Increase picture bench inner loop iteration to 10 for testing number stableness.
BUG=skia:2473
NOTRY=true
R=caryclark@google.com
TBR=caryclark@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
254093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14451
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 21:46:59 +0000 (21:46 +0000)]
fix bitmap shader leak in gm
this was introduced in https://codereview.chromium.org/
245963010
this was detected by caryclark@ by examining the result of valgrind on the skia buildbots
BUG=skia:1976
R=caryclark@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
255253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14450
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 21:28:04 +0000 (21:28 +0000)]
rebaseline perf expectations after r14443
bench rebase test 4610a46
BUG=skia:2466
R=bensong@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
263483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14449
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 21:00:06 +0000 (21:00 +0000)]
Revert of Improve Android scripts: (https://codereview.chromium.org/
254923003/)
Reason for revert:
errors
Original issue's description:
> Improve Android scripts:
>
> * android_gdbserver:
> - Don't complain if $GDB_TMP_DIR already exists
> - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.
>
> * android_run_skia:
> - Move resource files onto the device.
> - Change to tmp directory before executing program.
>
> * android_make, android_setup:
> - stop assuming PWD is skia source directory.
>
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=14442
R=djsollen@google.com, scroggo@google.com
TBR=djsollen@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
254073003
git-svn-id: http://skia.googlecode.com/svn/trunk@14448
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 20:44:12 +0000 (20:44 +0000)]
update yunchao suppressed expectations
R=reed@android.com
TBR=reed
NOTRY=true
NOTREECHECK=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
263473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14447
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 20:32:36 +0000 (20:32 +0000)]
rebaseline perf expectations after r14443
bench rebase test 4610a46
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
258393002
git-svn-id: http://skia.googlecode.com/svn/trunk@14446
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 20:12:21 +0000 (20:12 +0000)]
adb_push_if_needed - make target directory if it does not exist.
(fixes error introduced in 21a6d13.)
NOTRY=true
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
255263002
git-svn-id: http://skia.googlecode.com/svn/trunk@14445
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 20:06:22 +0000 (20:06 +0000)]
Move GrGLInterface function ptr setup into a common function for all OpenGL GrGLInterface factories (but not GLES yet).
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
254713006
git-svn-id: http://skia.googlecode.com/svn/trunk@14444
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 19:39:22 +0000 (19:39 +0000)]
reland r14391 ('fix contents of render_pictures JSON summary')
BUG=skia:2043,skia:2044,skia:1942,skia:2466
R=caryclark@google.com
TBR=caryclark
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
262453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14443
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 19:09:58 +0000 (19:09 +0000)]
Improve Android scripts:
* android_gdbserver:
- Don't complain if $GDB_TMP_DIR already exists
- Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.
* android_run_skia:
- Move resource files onto the device.
- Change to tmp directory before executing program.
* android_make, android_setup:
- stop assuming PWD is skia source directory.
NOTRY=true
R=djsollen@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
254923003
git-svn-id: http://skia.googlecode.com/svn/trunk@14442
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 19:04:21 +0000 (19:04 +0000)]
android_gdbserver - fix warning about missing shared library symbols
The warning was:
warning: Could not load shared library symbols for 4 libraries,
e.g. /system/bin/linker. Use the "info sharedlibrary" command to
see the complete listing.
Fixed by grabbing all of those libraries along with libc.so.
NOTRY=true
R=scroggo@google.com, djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
255193003
git-svn-id: http://skia.googlecode.com/svn/trunk@14441
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 17:22:54 +0000 (17:22 +0000)]
Move setup of SkPictCopyInfo into SkPicture::clone
This refactoring seemed sufficiently fraught that I've broken it out of a larger patch to move fBitmapHeap out of SkPictureRecord/SkPicturePlayback and into SkPicture.
SkPicturePlayback's friending of SkPicture should be temporary and just allows SkPicture to access items that will be moving into it soon.
R=scroggo@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
256653006
git-svn-id: http://skia.googlecode.com/svn/trunk@14440
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 17:11:19 +0000 (17:11 +0000)]
Fix buildbot_globals.py: Retrieve the file from our repo mirror
BUG=skia:2480
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
254013003
git-svn-id: http://skia.googlecode.com/svn/trunk@14439
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 16:44:00 +0000 (16:44 +0000)]
DM's rtree picture replay mode can ignore kSkippedTiled_Flag safely.
tested: out/Debug/dm && out/Release/dm
BUG=skia:2477
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
253733006
git-svn-id: http://skia.googlecode.com/svn/trunk@14438
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 16:25:36 +0000 (16:25 +0000)]
fix cycle_colortypes so we can test 565
TBR=bsalomon@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
255133004
git-svn-id: http://skia.googlecode.com/svn/trunk@14437
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 15:56:36 +0000 (15:56 +0000)]
Rename expectations for renamed bots (Ubuntu13.10)
BUG=skia:2449
NOTRY=true
R=epoger@google.com
TBR=epoger
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
259263002
git-svn-id: http://skia.googlecode.com/svn/trunk@14436
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 15:36:33 +0000 (15:36 +0000)]
ARM Skia NEON patches - 36 - Color32
Convert Color32 to intrinsics
This change is performance-neutral for high values of count and is
a big improvement for values smaller than 64.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, borenet@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
258173005
git-svn-id: http://skia.googlecode.com/svn/trunk@14435
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 15:35:23 +0000 (15:35 +0000)]
Fixed issue found by clusterfuzz
An integer overflow was causing an issue when reading a string with a very large (or negative) size.
BUG=367764
R=senorblanco@google.com, senorblanco@chromium.org, reed@google.com, borenet@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
255693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14434
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 15:34:03 +0000 (15:34 +0000)]
Don't bother doing the empty clip check in SkRecordDraw.
On Mike's suggestion, I tested out not doing any empty-clip check at all in
SkRecordDraw, given that mostly we'll do that again anyway inside SkCanvas.
Most SKPs are identical to the status quo, whether bot or silk, played back in tiles
or full. Average playback performance, both arithmetic and geometric mean, is also
unchanged.
A handful of SKPs do draw faster or slower reliably, particularly when tiled. E.g. a
cnn tile draws about 40% faster, a cuteoverload tile about 20% slower. Their profiles
look pretty much the same before and after, so I can't really explain the changes.
I'd say, given that performance is mostly identical and very identical in bulk,
we might as well remove this code. It's nice to keep SkRecordDraw as dumb as possible.
BUG=skia:2378
R=reed@google.com, fmalita@chromium.org, mtklein@google.com, borenet@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
258183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14433
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 29 Apr 2014 15:20:39 +0000 (15:20 +0000)]
Implement bounds traversals for tile and matrix convolution filters.
Add a new GM that exercises tiled drawing all pixel-moving filters
(and some non-pixel-moving ones) and compares it against non-tiled
drawing of the same filters. Fixing this test revealed that tile and
matrix convolution filters had no onFilterBounds() traversals
(test-driven development FTW). Tile requires (conservatively) the
bounds to include the whole source rect, since it may end up in the
result. Matrix convolution requires the bounds to be offset by the
kernel size and target.
R=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
258243005
git-svn-id: http://skia.googlecode.com/svn/trunk@14432
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 29 Apr 2014 15:20:16 +0000 (15:20 +0000)]
add asAShadowBlur for android to drawlooper
BUG=skia:
R=djsollen@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
253633003
git-svn-id: http://skia.googlecode.com/svn/trunk@14431
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 12:18:38 +0000 (12:18 +0000)]
bench rebase test 1c74374
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
260363002
git-svn-id: http://skia.googlecode.com/svn/trunk@14430
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 04:41:33 +0000 (04:41 +0000)]
fix leaks in blurrrect -- this should address the valgrind issues.
BUG=skia:
R=caryclark@google.com
TBR=caryclark
Author: humper@google.com
Review URL: https://codereview.chromium.org/
256273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14429
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 29 Apr 2014 03:05:14 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14428
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 00:39:45 +0000 (00:39 +0000)]
Explicitly include gyp_gen/android_framework_gyp.
Add __init__.py to gyp_gen and explicitly include android_framework_gyp
from there.
Fixes a bug where after moving that file, python was looking for it in
its old location, where there was a compiled version of the file.
BUG=skia:2468
R=epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
251903003
git-svn-id: http://skia.googlecode.com/svn/trunk@14427
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 29 Apr 2014 00:38:39 +0000 (00:38 +0000)]
Remove dependency of views on angle
Just like with http://code.google.com/p/skia/source/detail?r=13618,
listing angle.gyp as a dependency when in the Android tree (i.e.
w/o third_party/externals) causes gyp_to_android.py to fail.
(See http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/229/steps/Merge/logs/stdio
for example failure.)
Fortunately, views (and views_animated) has no need to depend directly
on angle.
R=bungeman@google.com, bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com
BUG=skia:2447
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
253773004
git-svn-id: http://skia.googlecode.com/svn/trunk@14426
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 21:04:32 +0000 (21:04 +0000)]
add SK_API to include/record
Failed builders https://codereview.chromium.org/
225023031/ at PS 24 look like they're failing because we're not exposing these symbols when Skia's a dynamic library.
BUG=skia:2378
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
253883003
git-svn-id: http://skia.googlecode.com/svn/trunk@14425
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 21:03:34 +0000 (21:03 +0000)]
Add a magnifier lens to the image.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
252993003
git-svn-id: http://skia.googlecode.com/svn/trunk@14424
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 20:34:48 +0000 (20:34 +0000)]
fix android logal gm for filltypespersp
BUG=skia:
NOTRY=true
TBR=borenet
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
253743005
git-svn-id: http://skia.googlecode.com/svn/trunk@14423
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 20:20:43 +0000 (20:20 +0000)]
Adds a blacklist of SKPs to exclude from bench expectations.
BUG=skia:2469
NOTRY=true
NOTREECHECKS=true
R=caryclark@google.com
TBR=caryclark@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
260053007
git-svn-id: http://skia.googlecode.com/svn/trunk@14422
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 20:17:48 +0000 (20:17 +0000)]
Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
The current implementation relies on soon-to-be-deprecated
kClip_SaveFlag behavior. Updated to use default save flags
(kMatrixClip_SaveFlag) and stop assuming that the matrix survives
restore() calls.
R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com
Committed: http://code.google.com/p/skia/source/detail?r=14319
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
246893005
git-svn-id: http://skia.googlecode.com/svn/trunk@14421
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:49:24 +0000 (19:49 +0000)]
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
Committed: http://code.google.com/p/skia/source/detail?r=14404
R=bsalomon@google.com, reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14420
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:49:00 +0000 (19:49 +0000)]
Simplify empty-clip check.
No measurable playback speed difference, but simpler code.
This makes sense: I'm seeing SkRecordDraw at ~0.25% of playback cost. We can
pretty much do whatever we want in there for free if it helps avoid real work.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
260143002
git-svn-id: http://skia.googlecode.com/svn/trunk@14419
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:41:24 +0000 (19:41 +0000)]
Rename GR_GL_GET_PROC macros in mesa and unix GrGLInterface factories to be more consistent with other platforms.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
258693008
git-svn-id: http://skia.googlecode.com/svn/trunk@14418
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:41:17 +0000 (19:41 +0000)]
Add --timescale to bench_record and bench_playback.
Default bench_record to report us, bench_playback ms.
BUG=skia:2378
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
253843004
git-svn-id: http://skia.googlecode.com/svn/trunk@14417
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:41:01 +0000 (19:41 +0000)]
First version of gpuveto testing script
This CL just sketches out the structure of the gpuveto testing process. Two big areas for improvement are:
render the picture in tiles and label as unsuitable if any gpu tile is slower than raster
decide on whether tilegrid is used or not
As expected the current gpuveto heuristic isn't so good:
predicted suitable unsuitable
-------------------------------------------
actual suitable 10 17
actual unsuitable 15 27
R=rmistry@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
257723003
git-svn-id: http://skia.googlecode.com/svn/trunk@14416
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 19:40:53 +0000 (19:40 +0000)]
Add chrome_changes file
BUG=skia:2457
R=epoger@google.com, bsalomon@google.com, robertphillips@google.com, bungeman@google.com, reed@google.com, skia-team@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
252523002
git-svn-id: http://skia.googlecode.com/svn/trunk@14415
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 18:21:24 +0000 (18:21 +0000)]
revert humper changes
https://skia.googlesource.com/skia.git/+/
24e91ba3029a3a1fb60cab3ae4e68c3c44776f25
https://skia.googlesource.com/skia.git/+/
a36c78240e14aeb130a97c43f3992ea19696b929
NOTREECHECKS=true
BUG=skia:
R=caryclark@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
256803011
git-svn-id: http://skia.googlecode.com/svn/trunk@14414
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 18:17:16 +0000 (18:17 +0000)]
bench rebase test 472f830
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
255023002
git-svn-id: http://skia.googlecode.com/svn/trunk@14413
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 16:26:47 +0000 (16:26 +0000)]
update expectations on linux bots that have recently come on line
BUG=skia:
R=borenet@google.com
TBR=borenet
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
250803019
git-svn-id: http://skia.googlecode.com/svn/trunk@14412
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 16:25:35 +0000 (16:25 +0000)]
move common blur types into central header
BUG=skia:
R=scroggo@google.com, djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
253833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14411
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 16:19:45 +0000 (16:19 +0000)]
Start using type traits in src/record instead of macros.
Simplified skip logic by always running clip commands. No performance difference on bot or silk SKPs.
BUG=skia:2378
R=bungeman@google.com, fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
258693006
git-svn-id: http://skia.googlecode.com/svn/trunk@14410
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 16:02:23 +0000 (16:02 +0000)]
spelling fix
BUG=skia:
R=caryclark@google.com
TBR=caryclark
Author: humper@google.com
Review URL: https://codereview.chromium.org/
259043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14409
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 16:00:30 +0000 (16:00 +0000)]
Generate tests/Android.mk from gyp
gyp/apptype_console.gypi:
Don't include console app dependencies when building for Android framework.
gyp/tests.gyp:
Add/remove libraries for framework build.
platform_tools/android/bin/android_framework_gyp.py:
Moved to gyp_gen.
clean_up_gypd_files moved to this script.
platform_tools/android/bin/gyp_to_android.py:
Call new function for generating tool makefile.
Set LOCAL_MODULE.
platform_tools/android/gyp_gen/gypd_parser.py:
Support relative paths.
platform_tools/android/gyp_gen/makefile_writer.py:
Factor out helper functions to be used by tool writer.
LOCAL_MODULE is set elsewhere.
platform_tools/android/gyp_gen/tool_makefile_writer.py:
Multipurpose file for writing makefiles for tools. Should be able to use
it mostly unchanged for bench, gm, etc.
platform_tools/android/gyp_gen/vars_dict_lib.py:
Make the comments follow the style guide.
Add set().
Rename __li to __ordered_set
More/update tests:
platform_tools/android/tests/android_framework_gyp_tests.py
platform_tools/android/tests/expectations/Android.mk
platform_tools/android/tests/expectations/tool/Android.mk
platform_tools/android/tests/expectations/write_local_vars_append_arm
platform_tools/android/tests/expectations/write_local_vars_append_foo
platform_tools/android/tests/expectations/write_local_vars_append_no_name
platform_tools/android/tests/expectations/write_local_vars_no_append_arm
platform_tools/android/tests/expectations/write_local_vars_no_append_foo
platform_tools/android/tests/expectations/write_local_vars_no_append_no_name
platform_tools/android/tests/gyp_to_android_tests.py
platform_tools/android/tests/makefile_writer_tests.py
platform_tools/android/tests/ordered_set_tests.py
platform_tools/android/tests/test_variables.py
BUG=skia:2447
May require an update to the bot to remove pyc files.
R=halcanary@google.com, djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
235883015
git-svn-id: http://skia.googlecode.com/svn/trunk@14408
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 15:33:31 +0000 (15:33 +0000)]
Add git revision info to the titlebar
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
258033006
git-svn-id: http://skia.googlecode.com/svn/trunk@14407
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 15:30:50 +0000 (15:30 +0000)]
bench rebase test cced37d
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
250963003
git-svn-id: http://skia.googlecode.com/svn/trunk@14406
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 15:30:02 +0000 (15:30 +0000)]
use BenchTimer, print in µs
BUG=skia:2378
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
257563006
git-svn-id: http://skia.googlecode.com/svn/trunk@14405
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 15:09:14 +0000 (15:09 +0000)]
Fast path for blurred round rects -- blur a small 9patch rect on the CPU
And nonlinearly stretch the resulting texture across proxy geometry.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com, reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
248613004
git-svn-id: http://skia.googlecode.com/svn/trunk@14404
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 15:07:50 +0000 (15:07 +0000)]
Properly enable S32_D16_filter_DX_SSE2 optimization.
Currently, the S32_D16_filter_DX_SSE2 optimization is only used in
configurations where the maximum SSE level is SSE2.
This patch enables it for higher levels, as well as fixing a color
conversion bug when the subpixels are converted into RGB565 format.
Also, refactored the function a bit, to make future modifications
less error-prone.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14333
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
239453010
git-svn-id: http://skia.googlecode.com/svn/trunk@14403
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 14:56:32 +0000 (14:56 +0000)]
Add pathops and capture stderr so we can get SkDebugf output.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
252863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14402
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 14:55:39 +0000 (14:55 +0000)]
Move SkShader::fLocalMatrix into SkShader constructor.
As a first step towards removing SkShader::setLocalMatrix, which will make
SkShader thread-safe, remove calls to setLocalMatrix that happen immediately
after the shader is being created. Instead, pass the matrix into the constructor
or factory method.
BUG=skia:1976
R=scroggo@google.com, reed@google.com, skyostil@google.com, mtklein@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
245963010
git-svn-id: http://skia.googlecode.com/svn/trunk@14401
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 14:44:54 +0000 (14:44 +0000)]
Revert of Fast path for blurred round rects -- blur a small 9patch rect on the CPU (https://codereview.chromium.org/
248613004/)
Reason for revert:
Looks like this causes unit tests to fail with a zero constructor like this one: http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/2326/steps/RunTests/logs/stdio
Original issue's description:
> Fast path for blurred round rects -- blur a small 9patch rect on the CPU
> And nonlinearly stretch the resulting texture across proxy geometry.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14392
R=bsalomon@google.com, reed@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
258893010
git-svn-id: http://skia.googlecode.com/svn/trunk@14400
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Apr 2014 14:07:10 +0000 (14:07 +0000)]
Revert of fix contents of render_pictures JSON summary (https://codereview.chromium.org/
259703002/)
Reason for revert:
This appears to have caused regressions such as this one: http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release/builds/2117/steps/CheckForRegressions/logs/stdio
Original issue's description:
> fix contents of render_pictures JSON summary
>
> BUG=skia:2043,skia:2044,skia:1942
>
> Committed: http://code.google.com/p/skia/source/detail?r=14391
R=scroggo@google.com, epoger@google.com
TBR=epoger@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2043,skia:2044,skia:1942
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
251103004
git-svn-id: http://skia.googlecode.com/svn/trunk@14399
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 28 Apr 2014 14:06:01 +0000 (14:06 +0000)]
Add missing include for r14397.
git-svn-id: http://skia.googlecode.com/svn/trunk@14398
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 28 Apr 2014 13:58:35 +0000 (13:58 +0000)]
Create SkGlyphCache globals with SkOnce.
VC++ will have magic statics with VS2014, but does not currently have them.
The thread unsafe implementation was causing the DirectWrite bots to randomly
crash when running multi-threaded tests, as gGlobals could be seen as NULL.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
252713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14397
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log