machenbach [Wed, 20 May 2015 12:49:13 +0000 (05:49 -0700)]
Revert of Set lower allocation limit in idle notification only if no GC happend recently. (patchset #2 id:20001 of https://codereview.chromium.org/
1143113002/)
Reason for revert:
[Sheriff] MSAN not happy:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2352
Original issue's description:
> Set lower allocation limit in idle notification only if no GC happend recently.
>
> BUG=475674
> LOG=n
>
> Committed: https://crrev.com/
35e3489e8f70c7ad5973324ad3cfa4ab27059ab4
> Cr-Commit-Position: refs/heads/master@{#28506}
TBR=ulan@chromium.org,hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475674
Review URL: https://codereview.chromium.org/
1145113003
Cr-Commit-Position: refs/heads/master@{#28511}
danno [Wed, 20 May 2015 12:48:02 +0000 (05:48 -0700)]
Generalize builtins inlining flag to allow forced inlining of any function
Review URL: https://codereview.chromium.org/
1140743004
Cr-Commit-Position: refs/heads/master@{#28510}
jacob.bramley [Wed, 20 May 2015 12:37:35 +0000 (05:37 -0700)]
ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412).
These trigger warnings on cross-builds under GCC.
BUG=
Review URL: https://codereview.chromium.org/
1151463002
Cr-Commit-Position: refs/heads/master@{#28509}
ulan [Wed, 20 May 2015 12:10:09 +0000 (05:10 -0700)]
Take freed handles into account when scheduling idle GCs.
BUG=
Review URL: https://codereview.chromium.org/
1145103002
Cr-Commit-Position: refs/heads/master@{#28508}
jacob.bramley [Wed, 20 May 2015 11:04:34 +0000 (04:04 -0700)]
[ARM64] [turbofan] Use 'mvn' rather than an equivalent 'orn'.
`mvn xd, xn` is an architectural alias for `orn xd, xzr, xm`, so this
doesn't change code generation at all, but it's tidier and it addresses
a TODO.
BUG=
Review URL: https://codereview.chromium.org/
1151483002
Cr-Commit-Position: refs/heads/master@{#28507}
hpayer [Wed, 20 May 2015 10:59:45 +0000 (03:59 -0700)]
Set lower allocation limit in idle notification only if no GC happend recently.
BUG=475674
LOG=n
Review URL: https://codereview.chromium.org/
1143113002
Cr-Commit-Position: refs/heads/master@{#28506}
bmeurer [Wed, 20 May 2015 10:13:02 +0000 (03:13 -0700)]
[turbofan] Add streaming operator for opcodes to ease debugging.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1147973002
Cr-Commit-Position: refs/heads/master@{#28505}
jochen [Wed, 20 May 2015 09:47:57 +0000 (02:47 -0700)]
Initialize "weakness_type" field in global handles
BUG=4122
R=vogelheim@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1143143002
Cr-Commit-Position: refs/heads/master@{#28504}
erikcorry [Wed, 20 May 2015 09:44:21 +0000 (02:44 -0700)]
Remove 64-bit unclean line from heap size estimation
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1133243006
Cr-Commit-Position: refs/heads/master@{#28503}
erikcorry [Wed, 20 May 2015 09:43:10 +0000 (02:43 -0700)]
Regularize namespace closing curlies
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1143133002
Cr-Commit-Position: refs/heads/master@{#28502}
jochen [Wed, 20 May 2015 08:59:43 +0000 (01:59 -0700)]
Update ReturnValue to take non-deprecated versions of handles
R=vogelheim@chromium.org
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/
1145063002
Cr-Commit-Position: refs/heads/master@{#28501}
dslomov [Wed, 20 May 2015 08:08:26 +0000 (01:08 -0700)]
[destructuring] Implement BindingArrayPattern
(everything except Spread is implemeneted)
R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1139603005
Cr-Commit-Position: refs/heads/master@{#28500}
yangguo [Wed, 20 May 2015 07:38:19 +0000 (00:38 -0700)]
Introduce extras export object.
BUG=
Review URL: https://codereview.chromium.org/
1140333003
Cr-Commit-Position: refs/heads/master@{#28499}
paul.lind [Wed, 20 May 2015 07:13:07 +0000 (00:13 -0700)]
Fix another -Wsign-compare bug with GCC 4.9.2.
BUG=
Review URL: https://codereview.chromium.org/
1147923002
Cr-Commit-Position: refs/heads/master@{#28498}
rossberg [Wed, 20 May 2015 07:07:54 +0000 (00:07 -0700)]
Reland "[strong] Object literals create strong objects"
(patchset #4 id:60001 of https://codereview.chromium.org/
1134333005/)"
This reverts commit
81c080ef8e7c1a38622b870b351bb1e11b6c8a62.
Patchset #1 is the original CL.
Patchset #2 fixes a handlification bug that caused the crash.
R=dslomov@chromium.org
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/
1143813002
Cr-Commit-Position: refs/heads/master@{#28497}
svenpanne [Wed, 20 May 2015 05:56:06 +0000 (22:56 -0700)]
Fixed various simulator-related space leaks.
Alas, this involved quite a bit of copy-n-paste between the
architectures, but this is caused by the very convoluted
relationships, lifetimes and distribution of responsibilities. This
should really be cleaned up by moving code around and using STL maps,
but that's not really a priority right now.
Bonus: Fixed leaks in the ARM64 disassembler tests.
Review URL: https://codereview.chromium.org/
1132943007
Cr-Commit-Position: refs/heads/master@{#28496}
Daniel Ehrenberg [Wed, 20 May 2015 01:09:21 +0000 (18:09 -0700)]
Implement %TypedArray%.{lastI,i}ndexOf
This patch adds the two TypedArray methods indexOf and lastIndexOf,
which are similar to the methods on Arrays. Tests are ported from
arrays as well.
BUG=v8:3578
LOG=Y
R=arv@chromium.org
Review URL: https://codereview.chromium.org/
1141763004
Patch from Daniel Ehrenberg <dehrenberg@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#28495}
Daniel Ehrenberg [Wed, 20 May 2015 00:56:15 +0000 (17:56 -0700)]
Implement %TypedArray%.prototype.sort
The sort method of TypedArrays sorts in numerical order by default.
This patch implements sorting based on Arrays and adds a test.
The length of %TypedArray%.prototype.sort, like Array.prototype.sort,
seems to be unspecified in ES6, so this patch lets it have the value
1, to match our interpretation for Array.prototype.sort (though 0
would also be a sensible length).
R=arv@chromium.org
BUG=v8:3578
LOG=Y
Review URL: https://codereview.chromium.org/
1148513002
Patch from Daniel Ehrenberg <dehrenberg@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#28494}
Daniel Ehrenberg [Wed, 20 May 2015 00:38:59 +0000 (17:38 -0700)]
Implement %TypedArray%.reverse
This patch adds the reverse method to TypedArrays, together with a
test. The test also runs for normal Arrays, since I didn't see a
test for reversing dense arrays.
BUG=v8:3578
LOG=Y
R=arv@chromium.org
Review URL: https://codereview.chromium.org/
1132723008
Patch from Daniel Ehrenberg <dehrenberg@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#28493}
mbrandy [Tue, 19 May 2015 20:24:17 +0000 (13:24 -0700)]
PPC: [strong] Function arity check should be based on required parameters
Port
78f0452d310221ac74b6221140d376d8302c4579
Original commit message:
Also check whether the arguments count is smaller than the number of
required parameters which is the same as the SharedFunctionInfo length.
R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1133093004
Cr-Commit-Position: refs/heads/master@{#28492}
arv [Tue, 19 May 2015 18:44:18 +0000 (11:44 -0700)]
[strong] Function arity check should be based on required parameters
Also check whether the arguments count is smaller than the number of
required parameters which is the same as the SharedFunctionInfo length.
BUG=v8:4102
LOG=N
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1133933003
Cr-Commit-Position: refs/heads/master@{#28491}
ulan [Tue, 19 May 2015 18:12:18 +0000 (11:12 -0700)]
Restore NothingOrDone action in idle time handler.
This also adjusts transitioning between modes so that crbug.com/460090 remains fixed.
BUG=chromium:489323, chromium:460090
LOG=NO
Review URL: https://codereview.chromium.org/
1141393002
Cr-Commit-Position: refs/heads/master@{#28490}
machenbach [Tue, 19 May 2015 16:56:00 +0000 (09:56 -0700)]
Revert of Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} (patchset #2 id:20001 of https://codereview.chromium.org/
1139663005/)
Reason for revert:
[Sheriff] Breaks win nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6872
Original issue's description:
> Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight}
>
> This patch adds implementations for additional TypedArray methods
> from the ES6 spec, together with tests adapted from array code.
>
> R=arv@chromium.org
> BUG=v8:3578
> LOG=Y
>
> Committed: https://crrev.com/
59ef8c5f3282f01b5990b3a46a2a3a829b699a13
> Cr-Commit-Position: refs/heads/master@{#28488}
TBR=arv@chromium.org,dehrenberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3578
Review URL: https://codereview.chromium.org/
1143833002
Cr-Commit-Position: refs/heads/master@{#28489}
dehrenberg [Tue, 19 May 2015 16:32:48 +0000 (09:32 -0700)]
Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight}
This patch adds implementations for additional TypedArray methods
from the ES6 spec, together with tests adapted from array code.
R=arv@chromium.org
BUG=v8:3578
LOG=Y
Review URL: https://codereview.chromium.org/
1139663005
Cr-Commit-Position: refs/heads/master@{#28488}
dslomov [Tue, 19 May 2015 16:27:21 +0000 (09:27 -0700)]
[destructuring] Support computed property names in patterns.
R=arv@chromium.org,rossberg@chromium.org
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1129083009
Cr-Commit-Position: refs/heads/master@{#28487}
mstarzinger [Tue, 19 May 2015 16:14:47 +0000 (09:14 -0700)]
[turbofan] Fix over-restictive assertion in code generator.
R=titzer@chromium.org
TEST=mjsunit/regress/regress-crbug-489293
BUG=chromium:489293
LOG=n
Review URL: https://codereview.chromium.org/
1142873005
Cr-Commit-Position: refs/heads/master@{#28486}
mstarzinger [Tue, 19 May 2015 15:10:34 +0000 (08:10 -0700)]
[turbofan] Turn JSIntrinsicLowering into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer. It will allow us to deal
with exception continuations correctly.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1134663006
Cr-Commit-Position: refs/heads/master@{#28485}
wingo [Tue, 19 May 2015 14:51:10 +0000 (07:51 -0700)]
Reapply "Resolve references to "this" the same way as normal variables""
This reapplies https://codereview.chromium.org/
1136073002, along with
the followups:
Remove Scope::scope_uses_this_ flag
https://codereview.chromium.org/
1128963005
and
PPC: Resolve references to "this" the same way as normal variables
https://codereview.chromium.org/
1134073003
R=rossberg@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/
1136883006
Cr-Commit-Position: refs/heads/master@{#28458}
Review URL: https://codereview.chromium.org/
1140633003
Cr-Commit-Position: refs/heads/master@{#28484}
Michael Achenbach [Tue, 19 May 2015 14:44:15 +0000 (16:44 +0200)]
Whitespace change to test new test suite.
Cr-Commit-Position: refs/heads/master@{#28483}
dslomov [Tue, 19 May 2015 14:29:50 +0000 (07:29 -0700)]
[destructuring] Implement initializers in patterns.
R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1146683002
Cr-Commit-Position: refs/heads/master@{#28482}
sergiyb [Tue, 19 May 2015 14:05:55 +0000 (07:05 -0700)]
Removed project_bases_legacy_from_git_repo_url from V8
This is not necessary because V8 is a Git-based project and relpath doesn't need
to be computed.
R=akuegel@chromium.org, machenbach@chromium.org
BUG=471767
LOG=N
Review URL: https://codereview.chromium.org/
1149453002
Cr-Commit-Position: refs/heads/master@{#28481}
ishell [Tue, 19 May 2015 12:52:02 +0000 (05:52 -0700)]
Another regression test for resolving references to "this" in strict mode.
BUG=chromium:487105
LOG=N
Review URL: https://codereview.chromium.org/
1136123010
Cr-Commit-Position: refs/heads/master@{#28480}
machenbach [Tue, 19 May 2015 11:51:02 +0000 (04:51 -0700)]
[test] Make test as flaky
BUG=v8:4127
LOG=n
TBR=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
1146683003
Cr-Commit-Position: refs/heads/master@{#28479}
brettw [Tue, 19 May 2015 11:36:37 +0000 (04:36 -0700)]
Make the snapshot a public dependency of v8.
Adds a chain of public dependencies from the v8 target to the snapshot target.
A future version of GN will validate that any files taken as inputs to a step
were generated by public dependencies of that target. Some targets in Chrome
depend on the results of the snapshot.
Review URL: https://codereview.chromium.org/
1138953007
Cr-Commit-Position: refs/heads/master@{#28478}
jkummerow [Tue, 19 May 2015 11:35:02 +0000 (04:35 -0700)]
Fix has_pending_exception logic in API's Array::CloneElementAt
BUG=v8:4103
LOG=y
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
1138723003
Cr-Commit-Position: refs/heads/master@{#28477}
erikcorry [Tue, 19 May 2015 11:19:53 +0000 (04:19 -0700)]
Adjust benchmark framework to avoid spending 50% of time on 'new Date'
R=dslomov@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1133843007
Cr-Commit-Position: refs/heads/master@{#28476}
jkummerow [Tue, 19 May 2015 11:09:09 +0000 (04:09 -0700)]
Update safe_math_impl.h
Porting Chromium's https://codereview.chromium.org/
1142783002/ to fix a division-by-zero bug.
BUG=chromium:488302
LOG=n
Review URL: https://codereview.chromium.org/
1135293003
Cr-Commit-Position: refs/heads/master@{#28475}
ssid [Tue, 19 May 2015 11:01:41 +0000 (04:01 -0700)]
Adding api to get last gc object statistics for chrome://tracing.
For dumping the number of objects and size of objects alive after the
last gc into chrome://tracing memory dumps, this CL adds new api to
get these number for each isolate.
Note: Chrome should be run with --js-flags='--track_gc_object_stats
--noincremental-marking' for object tracking.
BUG=476013
LOG=Y
Review URL: https://codereview.chromium.org/
1113233002
Cr-Commit-Position: refs/heads/master@{#28474}
wingo [Tue, 19 May 2015 10:58:01 +0000 (03:58 -0700)]
Revert of Reapply "Resolve references to "this" the same way as normal variables"" (patchset #2 id:20001 of https://codereview.chromium.org/
1136883006/)
Reason for revert:
Something is deserializing "this" declarations as Variable::NORMAL and not Variable::THIS https://codereview.chromium.org/
1136123010/
Original issue's description:
> Reapply "Resolve references to "this" the same way as normal variables""
>
> This reapplies https://codereview.chromium.org/
1136073002, along with
> the followups:
>
> Remove Scope::scope_uses_this_ flag
> https://codereview.chromium.org/
1128963005
>
> and
>
> PPC: Resolve references to "this" the same way as normal variables
> https://codereview.chromium.org/
1134073003
>
> R=yangguo@chromium.org, rossberg@chromium.org
> LOG=N
> BUG=
>
> Committed: https://crrev.com/
1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099
> Cr-Commit-Position: refs/heads/master@{#28458}
TBR=rossberg@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1146733002
Cr-Commit-Position: refs/heads/master@{#28473}
Djordje.Pesic [Tue, 19 May 2015 10:35:24 +0000 (03:35 -0700)]
Reland "MIPS: Add float instructions and test coverage, part one"
Implement assembler, disassembler tests for all instructions for mips32 and mips64. Additionally, add missing single precision float instructions for r2 and r6 architecture variants in assembler, simulator and disassembler with corresponding tests.
Review URL: https://codereview.chromium.org/
1147493002
Cr-Commit-Position: refs/heads/master@{#28472}
balazs.kilvady [Tue, 19 May 2015 10:22:13 +0000 (03:22 -0700)]
MIPS: [turbofan] Support Float[32|64]Min and Float[32|64]Max.
MIPS64r6 and MIPS32r6 support for min and max and Float64Max machine operators.
BUG=
Review URL: https://codereview.chromium.org/
1027193002
Cr-Commit-Position: refs/heads/master@{#28471}
bradnelson [Tue, 19 May 2015 10:14:49 +0000 (03:14 -0700)]
Adding ecmascript simd tests.
Relying on the polyfill for now.
BUG=v8:4124
LOG=N
R=bbudge@chromium.org,machenbach@chromium.org
TEST=trybots
Review URL: https://codereview.chromium.org/
1147743004
Cr-Commit-Position: refs/heads/master@{#28470}
chunyang.dai [Tue, 19 May 2015 10:05:35 +0000 (03:05 -0700)]
X87: Reapply "Resolve references to "this" the same way as normal variables""
port
1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099 (r28458).
original commit message:
This reapplies https://codereview.chromium.org/
1136073002, along with
the followups:
Remove Scope::scope_uses_this_ flag
https://codereview.chromium.org/
1128963005
and
PPC: Resolve references to "this" the same way as normal variables
https://codereview.chromium.org/
1134073003
BUG=
Review URL: https://codereview.chromium.org/
1135233003
Cr-Commit-Position: refs/heads/master@{#28469}
mstarzinger [Tue, 19 May 2015 09:57:54 +0000 (02:57 -0700)]
[turbofan] Turn JSTypedLowering into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer. It will allow us to deal
with exception continuations correctly.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1134303003
Cr-Commit-Position: refs/heads/master@{#28468}
chunyang.dai [Tue, 19 May 2015 09:56:41 +0000 (02:56 -0700)]
X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag.
port
323ced9e272e234d19db13d407b5bb9da266681d (r28422).
original commit message:
BUG=
Review URL: https://codereview.chromium.org/
1142713007
Cr-Commit-Position: refs/heads/master@{#28467}
bmeurer [Tue, 19 May 2015 09:11:30 +0000 (02:11 -0700)]
[turbofan] Carefully update frame states during inlining.
During inlining we should pay attention to only rewire the outer frame
states of the inlinee, but leave any inner frame states of the inlinee
untouched. Otherwise we might run into trouble once we start caching
graphs, or do getter/setter inlining.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1134973006
Cr-Commit-Position: refs/heads/master@{#28466}
titzer [Tue, 19 May 2015 08:58:43 +0000 (01:58 -0700)]
[turbofan] Support vector IC feedback in the JSTypeFeedbackTable.
R=mvstanton@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1133113004
Cr-Commit-Position: refs/heads/master@{#28465}
machenbach [Tue, 19 May 2015 07:36:12 +0000 (00:36 -0700)]
Revert of [strong] Object literals create strong objects (patchset #4 id:60001 of https://codereview.chromium.org/
1134333005/)
Reason for revert:
[Sheriff] Segmentation fault on arm64 with nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1990
Original issue's description:
> [strong] Object literals create strong objects
>
> R=dslomov@chromium.org
> BUG=v8:3956
> LOG=N
>
> Committed: https://crrev.com/
fe6598cffb82ec4180dcc2e2310e77d07a803f96
> Cr-Commit-Position: refs/heads/master@{#28444}
TBR=dslomov@chromium.org,arv@chromium.org,rossberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3956
Review URL: https://codereview.chromium.org/
1135493006
Cr-Commit-Position: refs/heads/master@{#28464}
jkummerow [Tue, 19 May 2015 07:32:56 +0000 (00:32 -0700)]
Fix harmless HGraph verification failure after hoisting inlined bounds checks
BUG=chromium:487608
LOG=y
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
1133343003
Cr-Commit-Position: refs/heads/master@{#28463}
svenpanne [Tue, 19 May 2015 05:56:45 +0000 (22:56 -0700)]
Use USE_SIMULATOR when appropriate.
Review URL: https://codereview.chromium.org/
1142043003
Cr-Commit-Position: refs/heads/master@{#28462}
yangguo [Tue, 19 May 2015 04:56:19 +0000 (21:56 -0700)]
Do not clear stepping after DebugEvaluate.
Clearing stepping was originally introduced in http://codereview.chromium.org/7889039
But DebugEvaluate now also uses a DisableBreak scope, which makes sure we don't step
inside the evaluated code.
R=yurys@chromium.org
BUG=chromium:467180
LOG=N
Review URL: https://codereview.chromium.org/
1129363003
Cr-Commit-Position: refs/heads/master@{#28461}
v8-autoroll [Tue, 19 May 2015 03:22:26 +0000 (20:22 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
a01f3daa088378f5ae90e37e5673d963b63d05dc
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1136643007
Cr-Commit-Position: refs/heads/master@{#28460}
horo [Tue, 19 May 2015 03:11:33 +0000 (20:11 -0700)]
[V8] Added Script::is_opaque flag for embedders
When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response.
We need to treat the messages from such script resource as opaque.
Committed: https://crrev.com/
7a599c5e1242d3c5ab7515ee149623da90ae69ec
Cr-Commit-Position: refs/heads/master@{#28445}
Review URL: https://codereview.chromium.org/
1140673002
Cr-Commit-Position: refs/heads/master@{#28459}
wingo [Mon, 18 May 2015 20:16:24 +0000 (13:16 -0700)]
Reapply "Resolve references to "this" the same way as normal variables""
This reapplies https://codereview.chromium.org/
1136073002, along with
the followups:
Remove Scope::scope_uses_this_ flag
https://codereview.chromium.org/
1128963005
and
PPC: Resolve references to "this" the same way as normal variables
https://codereview.chromium.org/
1134073003
R=yangguo@chromium.org, rossberg@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/
1136883006
Cr-Commit-Position: refs/heads/master@{#28458}
dslomov [Mon, 18 May 2015 20:15:08 +0000 (13:15 -0700)]
[destructuring] More tests for object literal pattern
R=arv@chromium.org,rossberg@chromium.org
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1139773005
Cr-Commit-Position: refs/heads/master@{#28457}
dehrenberg [Mon, 18 May 2015 20:13:56 +0000 (13:13 -0700)]
Add TypedArray.from method
This function creates a new way to make TypedArrays based on existing
iterable or Array-like objects, analogous to Array.from. The patch
implements the function and adds tests.
R=arv@chromium.org
BUG=v8:3578
LOG=Y
Review URL: https://codereview.chromium.org/
1132163011
Cr-Commit-Position: refs/heads/master@{#28456}
ishell [Mon, 18 May 2015 19:41:26 +0000 (12:41 -0700)]
ARM64: Propagate notification about aborted compilation from RegExpEngine to MacroAssembler.
BUG=chromium:489290
LOG=Y
Review URL: https://codereview.chromium.org/
1145653004
Cr-Commit-Position: refs/heads/master@{#28455}
caitpotter88 [Mon, 18 May 2015 15:52:57 +0000 (08:52 -0700)]
[parser] report SyntaxError if rest parameter used in Setter MethodDefinition
BUG=v8:4107, v8:2159
LOG=N
R=arv@chromium.org
Review URL: https://codereview.chromium.org/
1141223002
Cr-Commit-Position: refs/heads/master@{#28454}
ishell [Mon, 18 May 2015 15:50:38 +0000 (08:50 -0700)]
Fixed SEGV that could happen if an exception is thrown during bootstrapping.
BUG=chromium:487974
LOG=N
Review URL: https://codereview.chromium.org/
1145703002
Cr-Commit-Position: refs/heads/master@{#28453}
titzer [Mon, 18 May 2015 15:49:20 +0000 (08:49 -0700)]
[turbofan] Fix Node::TrimInputCount() followed by Node::AppendInput() bug.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1132353004
Cr-Commit-Position: refs/heads/master@{#28452}
machenbach [Mon, 18 May 2015 15:11:05 +0000 (08:11 -0700)]
[test] Refactoring: Remove code duplication in perf runner.
BUG=484208
LOG=n
TBR=kjellander@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1139833003
Cr-Commit-Position: refs/heads/master@{#28451}
machenbach [Mon, 18 May 2015 15:04:00 +0000 (08:04 -0700)]
Update change log to match roll branch.
NOTRY=true
Review URL: https://codereview.chromium.org/
1140603005
Cr-Commit-Position: refs/heads/master@{#28450}
machenbach [Mon, 18 May 2015 14:54:54 +0000 (07:54 -0700)]
Revert of [V8] Added Script::is_opaque flag for embedders (patchset #5 id:80001 of https://codereview.chromium.org/
1140673002/)
Reason for revert:
[Sheriff] Breaks chromium win compilation:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/96
Original issue's description:
> [V8] Added Script::is_opaque flag for embedders
>
> When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response.
> We need to treat the messages from such script resource as opaque.
>
> Committed: https://crrev.com/
7a599c5e1242d3c5ab7515ee149623da90ae69ec
> Cr-Commit-Position: refs/heads/master@{#28445}
TBR=mkwst@chromium.org,jochen@chromium.org,yangguo@chromium.org,horo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1135343005
Cr-Commit-Position: refs/heads/master@{#28449}
machenbach [Mon, 18 May 2015 14:41:13 +0000 (07:41 -0700)]
[release-tools] Add more jobs to clusterfuzz check.
This will send automatic email notifications about reliable
failures from the respective jobs.
NOTRY=true
Review URL: https://codereview.chromium.org/
1147713002
Cr-Commit-Position: refs/heads/master@{#28448}
arv [Mon, 18 May 2015 14:18:51 +0000 (07:18 -0700)]
[strong] Fix super in strong classes
The functions of strong classes are born non extensible. But, when
the class is created we need to add an own private symbol representing
the [[HomeObject]] slot in the spec.
Like for the hidden_string property, we allow adding private own
symbols to non extensible objects.
BUG=v8:4077
LOG=N
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1138603003
Cr-Commit-Position: refs/heads/master@{#28447}
bradnelson [Mon, 18 May 2015 14:11:22 +0000 (07:11 -0700)]
Add --download-data-only option to run-test.py
The simd.js benchmarks reside in the same repository
that holds the compliance tests.
Adding an option to run-test.py to download test data
and exit, so that a recipe to run the simd.js
benchmarks can call run-test.py with this option
to fetch the test data.
BUG=https://code.google.com/p/v8/issues/detail?id=4124
LOG=N
TEST=manual verification it works.
NOTRY=true
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1140353002
Cr-Commit-Position: refs/heads/master@{#28446}
horo [Mon, 18 May 2015 13:54:41 +0000 (06:54 -0700)]
[V8] Added Script::is_opaque flag for embedders
When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response.
We need to treat the messages from such script resource as opaque.
Review URL: https://codereview.chromium.org/
1140673002
Cr-Commit-Position: refs/heads/master@{#28445}
rossberg [Mon, 18 May 2015 13:23:30 +0000 (06:23 -0700)]
[strong] Object literals create strong objects
R=dslomov@chromium.org
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/
1134333005
Cr-Commit-Position: refs/heads/master@{#28444}
verwaest [Mon, 18 May 2015 13:15:09 +0000 (06:15 -0700)]
Remove undefined-check from GetElementWithReceiver
BUG=
Review URL: https://codereview.chromium.org/
1145693002
Cr-Commit-Position: refs/heads/master@{#28443}
verwaest [Mon, 18 May 2015 12:36:49 +0000 (05:36 -0700)]
Reland "Mark internal AccessorInfo properties as 'special data properties'"
This reverts commit
ac5336baca8c1ee45be0157aa1d4f9a178d75bb6.
BUG=
Review URL: https://codereview.chromium.org/
1138483005
Cr-Commit-Position: refs/heads/master@{#28442}
titzer [Mon, 18 May 2015 11:54:11 +0000 (04:54 -0700)]
[turbofan] JSTypeFeedbackSpecializer is now an AdvancedReducer.
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1136413002
Cr-Commit-Position: refs/heads/master@{#28441}
dusan.milosavljevic [Mon, 18 May 2015 10:55:44 +0000 (03:55 -0700)]
MIPS: Fix bogus line in assembler test.
TEST=cctest/test-assembler-mips/MIPS11
BUG=
Review URL: https://codereview.chromium.org/
1133663007
Cr-Commit-Position: refs/heads/master@{#28440}
yangguo [Mon, 18 May 2015 08:34:05 +0000 (01:34 -0700)]
Migrate error messages, part 12.
Review URL: https://codereview.chromium.org/
1130133003
Cr-Commit-Position: refs/heads/master@{#28439}
v8-autoroll [Mon, 18 May 2015 03:25:43 +0000 (20:25 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
26185eb8de21f4755350a246d30bca8cd5a12deb
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1132373004
Cr-Commit-Position: refs/heads/master@{#28438}
machenbach [Sun, 17 May 2015 16:50:27 +0000 (09:50 -0700)]
Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #2 id:20001 of https://codereview.chromium.org/
1123163005/)
Reason for revert:
[Sheriff] Blocks current roll:
https://codereview.chromium.org/
1124403007/
Bisection (https://codereview.chromium.org/
1142753002/) points to this CL.
Original issue's description:
> Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling.
>
> BUG=
>
> Committed: https://crrev.com/
188297160d2b82a4e2a206ebbddfc21dd99a9d8d
> Cr-Commit-Position: refs/heads/master@{#28369}
TBR=rossberg@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1142763002
Cr-Commit-Position: refs/heads/master@{#28437}
machenbach [Sun, 17 May 2015 06:21:47 +0000 (23:21 -0700)]
Revert of Debugger: preserve stepping state after evaluating breakpoint condition. (patchset #1 id:1 of https://codereview.chromium.org/
1132643004/)
Reason for revert:
[Sheriff] This breaks TSAN (makes some tests marked as flaky permanently fail):
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/3882
Original issue's description:
> Debugger: preserve stepping state after evaluating breakpoint condition.
>
> R=ulan@chromium.org, yurys@chromium.org
> BUG=chromium:467180
> LOG=N
TBR=ulan@chromium.org,yurys@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:467180
Review URL: https://codereview.chromium.org/
1130123007
Cr-Commit-Position: refs/heads/master@{#28436}
hablich [Sun, 17 May 2015 06:08:31 +0000 (23:08 -0700)]
Update version to 4.5
BUG=
TBR=machenbach@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1123393006
Cr-Commit-Position: refs/heads/master@{#28435}
v8-autoroll [Sun, 17 May 2015 03:24:58 +0000 (20:24 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
ec43def7c912c4a6bfadaf9e500bfb05da263f6f
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1139293002
Cr-Commit-Position: refs/heads/master@{#28434}
v8-autoroll [Sat, 16 May 2015 03:26:39 +0000 (20:26 -0700)]
Update V8 DEPS.
Rolling v8/third_party/icu to
5788e2736b3bc642994b6351a6096124895afa01
Rolling v8/tools/clang to
e11ef3ee3eecde207b8a38916b34fde40352f466
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1138003006
Cr-Commit-Position: refs/heads/master@{#28433}
yangguo [Fri, 15 May 2015 22:51:08 +0000 (15:51 -0700)]
Debugger: preserve stepping state after evaluating breakpoint condition.
R=ulan@chromium.org, yurys@chromium.org
BUG=chromium:467180
LOG=N
Review URL: https://codereview.chromium.org/
1132643004
Cr-Commit-Position: refs/heads/master@{#28432}
mbrandy [Fri, 15 May 2015 17:41:08 +0000 (10:41 -0700)]
PPC: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag.
Port
323ced9e272e234d19db13d407b5bb9da266681d
R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1132513007
Cr-Commit-Position: refs/heads/master@{#28431}
hpayer [Fri, 15 May 2015 17:04:48 +0000 (10:04 -0700)]
Clean-up aligned allocation logic.
BUG=
Review URL: https://codereview.chromium.org/
1138643005
Cr-Commit-Position: refs/heads/master@{#28430}
hpayer [Fri, 15 May 2015 16:08:47 +0000 (09:08 -0700)]
Shrink active semi-space and uncommit other semi-space only in idle memory mode.
BUG=chromium:483147
LOG=n
Review URL: https://codereview.chromium.org/
1140693003
Cr-Commit-Position: refs/heads/master@{#28429}
hpayer [Fri, 15 May 2015 16:06:21 +0000 (09:06 -0700)]
Make sure that idle scavenges are just performed when enough objects are allocated in new space.
BUG=
Review URL: https://codereview.chromium.org/
1138643003
Cr-Commit-Position: refs/heads/master@{#28428}
domenic [Fri, 15 May 2015 15:32:54 +0000 (08:32 -0700)]
Fix V8 extras js2c pipeline
570fca61 introduced a regression that caused minification etc. to be
applied to V8 extras.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1125103003
Cr-Commit-Position: refs/heads/master@{#28427}
arv [Fri, 15 May 2015 15:09:46 +0000 (08:09 -0700)]
[es6] Iterators and generators should "extend" %IteratorPrototype%
All the builtin iterators as well as the generator objects have an
object called %IteratorPrototype% in the spec between them and
%ObjectPrototype%.
BUG=v8:3568
LOG=N
Review URL: https://codereview.chromium.org/
1128233008
Cr-Commit-Position: refs/heads/master@{#28426}
erikcorry [Fri, 15 May 2015 14:48:17 +0000 (07:48 -0700)]
Remove release-mode assert that has out-stayed its welcome
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1127333004
Cr-Commit-Position: refs/heads/master@{#28425}
yangguo [Fri, 15 May 2015 13:57:36 +0000 (06:57 -0700)]
Add regression test for resolving "this" in debug evaluate.
R=hablich@chromium.org
BUG=chromium:487289
LOG=N
Review URL: https://codereview.chromium.org/
1137293002
Cr-Commit-Position: refs/heads/master@{#28424}
yangguo [Fri, 15 May 2015 13:32:32 +0000 (06:32 -0700)]
Migrate error messages, part 11.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1140053002
Cr-Commit-Position: refs/heads/master@{#28423}
mvstanton [Fri, 15 May 2015 13:25:25 +0000 (06:25 -0700)]
Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag.
BUG=
Review URL: https://codereview.chromium.org/
1129853002
Cr-Commit-Position: refs/heads/master@{#28422}
mvstanton [Fri, 15 May 2015 13:05:08 +0000 (06:05 -0700)]
Bug: Runtime_GrowArrayElements provoked unnecessary lazy deopt.
Unnecessary, and unhandled as well.
BUG=488398
R=jarin@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
1141163004
Cr-Commit-Position: refs/heads/master@{#28421}
yangguo [Fri, 15 May 2015 13:00:31 +0000 (06:00 -0700)]
Store fewer arrays in the context snapshot.
This slightly reduces the initial context size.
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/
1146523002
Cr-Commit-Position: refs/heads/master@{#28420}
bmeurer [Fri, 15 May 2015 12:17:15 +0000 (05:17 -0700)]
[turbofan] Pass closure as node to FrameState.
First step towards support for inlining based on SharedFunctionInfo
instead of JSFunction.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1134713004
Cr-Commit-Position: refs/heads/master@{#28419}
ishell [Fri, 15 May 2015 10:40:04 +0000 (03:40 -0700)]
Map::ReconfigureProperty() should mark map as unstable when there is an element kind transition somewhere in the middle of the transition tree.
BUG=chromium:485548
LOG=N
Review URL: https://codereview.chromium.org/
1128043005
Cr-Commit-Position: refs/heads/master@{#28418}
dslomov [Fri, 15 May 2015 09:56:31 +0000 (02:56 -0700)]
[destructuring] Adapting PatternRewriter to work in C-style for-statements.
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1128043006
Cr-Commit-Position: refs/heads/master@{#28417}
hpayer [Fri, 15 May 2015 07:48:16 +0000 (00:48 -0700)]
When context disposal rate is high and we cannot perform a full GC, we do nothing until the context disposal rate becomes lower.
BUG=chromium:473351
LOG=n
Review URL: https://codereview.chromium.org/
1118303004
Cr-Commit-Position: refs/heads/master@{#28416}
yangguo [Fri, 15 May 2015 07:42:40 +0000 (00:42 -0700)]
Reland "Prevent stack overflow in the serializer/deserializer."
TBR=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1124403006
Cr-Commit-Position: refs/heads/master@{#28415}
jochen [Fri, 15 May 2015 07:37:15 +0000 (00:37 -0700)]
Remove static logging of memory allocations
We want to move to a world where there's no Isolate::Current but we
always knows which isolate we're in. There's no way we can teach this
info to the C++ allocator.
BUG=none
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1128023005
Cr-Commit-Position: refs/heads/master@{#28414}
paul.lind [Fri, 15 May 2015 06:49:46 +0000 (23:49 -0700)]
Fix Heap::AllocateFillerObject() to use double alignment param.
This is called from Runtime, and was dropping the requested alignment
for doubles. Needed for upcoming MIPS CL to remove some more
workarounds for load/store doubles.
BUG=
Review URL: https://codereview.chromium.org/
1131123003
Cr-Commit-Position: refs/heads/master@{#28413}
martyn.capewell [Fri, 15 May 2015 05:13:15 +0000 (22:13 -0700)]
ARM64: Enable shorten-64-to-32 warning
Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
that arise.
BUG=
Review URL: https://codereview.chromium.org/
1131573006
Cr-Commit-Position: refs/heads/master@{#28412}