platform/upstream/libSkiaSharp.git
8 years agoCheck scalar to fixed conversions with axes.
benjaminwagner [Thu, 25 Feb 2016 20:20:40 +0000 (12:20 -0800)]
Check scalar to fixed conversions with axes.

In SkTypeface_FreeType::Scanner::computeAxisValues, check for
out-of-range values before converting to SkFixed.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709403003

Review URL: https://codereview.chromium.org/1709403003

8 years agoFully check basis vectors for extent degeneracy.
bungeman [Thu, 25 Feb 2016 19:34:10 +0000 (11:34 -0800)]
Fully check basis vectors for extent degeneracy.

The test for 'nearly singular matrix' in SkScalerContext::computeMatrices
is actually a check to see if anything will draw. Unfortunately, the
current test only checks when the a skew causes nothing to draw. This
adds the check for when the scale causes nothing to draw.

BUG=skia:4998
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735613002

Review URL: https://codereview.chromium.org/1735613002

8 years agoMove urlhandlers out of skiaserve.cpp
joshualitt [Thu, 25 Feb 2016 19:28:18 +0000 (11:28 -0800)]
Move urlhandlers out of skiaserve.cpp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737643003

Review URL: https://codereview.chromium.org/1737643003

8 years agoSkia Filter Quality and Scaling Metrics
ericrk [Thu, 25 Feb 2016 19:21:57 +0000 (11:21 -0800)]
Skia Filter Quality and Scaling Metrics

Adds histogram metrics to log the filter quality and scale factor of
each image draw. To make the data easier to consume, this is broken
down into a number of individual histograms:
- Filter quality across all draw calls
- Scale amount across all draw calls
- Scale amount per filter quality (4 histograms total)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686203002

Review URL: https://codereview.chromium.org/1686203002

8 years agoDeduplicate axis value resolving code.
bungeman [Thu, 25 Feb 2016 19:20:01 +0000 (11:20 -0800)]
Deduplicate axis value resolving code.

The code was originally written for Android, but is now implemented
more generally by the FreeType scanner to be shared between all
FreeType backed typefaces. This removes the now duplicate code in the
Android font manager and uses the shared code instead.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726213004

Review URL: https://codereview.chromium.org/1726213004

8 years agoCreate Response namespace for skiaserve response functions
joshualitt [Thu, 25 Feb 2016 19:09:36 +0000 (11:09 -0800)]
Create Response namespace for skiaserve response functions

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1739763002

Review URL: https://codereview.chromium.org/1739763002

8 years agoHide GrPipelineBuilder from GrOvalRenderer
robertphillips [Thu, 25 Feb 2016 19:03:52 +0000 (11:03 -0800)]
Hide GrPipelineBuilder from GrOvalRenderer

Limiting the reach of GrPipelineBuilder is always good.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726223008

Review URL: https://codereview.chromium.org/1726223008

8 years agoAdd a DM flag to limit the types of Codec decodes
scroggo [Thu, 25 Feb 2016 19:03:47 +0000 (11:03 -0800)]
Add a DM flag to limit the types of Codec decodes

When the flag "simpleCodec" is set to true, we will only decode
to the canvas colortype and to a scale of 1. No SkAndroidCodec or
BRDCodec tests are run. This makes it easier to find the simple
case when running locally.

Clean up some SkImageDecoder references along the way.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735743003

Review URL: https://codereview.chromium.org/1735743003

8 years agoMake skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
robertphillips [Thu, 25 Feb 2016 18:58:49 +0000 (10:58 -0800)]
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732263003

BUG=skia:4691

Review URL: https://codereview.chromium.org/1732263003

8 years agoMove some methods to SkiaServe's Request, this is still very leaky
joshualitt [Thu, 25 Feb 2016 18:50:28 +0000 (10:50 -0800)]
Move some methods to SkiaServe's Request, this is still very leaky

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733813004

Review URL: https://codereview.chromium.org/1733813004

8 years agoCleanups related to SkFixed.
benjaminwagner [Thu, 25 Feb 2016 18:28:11 +0000 (10:28 -0800)]
Cleanups related to SkFixed.

This CL relands https://codereview.chromium.org/1683743005/ with two fixes:
  - Removing the test for vertical text. Vertical text doesn't work on Windows and breakText isn't supported for non-trivial text.
  - Omit PaintBreakTextTest in Google3 because we don't have the correct font setup yet.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005

Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

patch from issue 1683743005 at patchset 120001 (http://crrev.com/1683743005#ps120001)

Review URL: https://codereview.chromium.org/1739453002

8 years agoMv DRRect drawing code from GrDrawContext into SkGpuDevice
robertphillips [Thu, 25 Feb 2016 17:28:08 +0000 (09:28 -0800)]
Mv DRRect drawing code from GrDrawContext into SkGpuDevice

This is a TODO left over from https://codereview.chromium.org/1731413002/ (Hide GrDrawTarget from GrOvalRenderer). It is desireable since the GrDrawContext doesn't, in general, manipulate GrFragmentProcessors.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733993003

Review URL: https://codereview.chromium.org/1733993003

8 years agoMove Request to its own file in preparation for numerous cleanups
joshualitt [Thu, 25 Feb 2016 16:37:54 +0000 (08:37 -0800)]
Move Request to its own file in preparation for numerous cleanups

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738483003

Review URL: https://codereview.chromium.org/1738483003

8 years agoMove Budgeted enum out of SkSurface, use in GrTextureProvider
bsalomon [Thu, 25 Feb 2016 16:33:02 +0000 (08:33 -0800)]
Move Budgeted enum out of SkSurface, use in GrTextureProvider

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005

Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Review URL: https://codereview.chromium.org/1728093005

8 years agoAdd stub for new method to GrVkGpu
jvanverth [Thu, 25 Feb 2016 15:59:45 +0000 (07:59 -0800)]
Add stub for new method to GrVkGpu
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1736983003

Review URL: https://codereview.chromium.org/1736983003

8 years agoUse kSubpixelRounding in one missed location.
bungeman [Thu, 25 Feb 2016 15:07:32 +0000 (07:07 -0800)]
Use kSubpixelRounding in one missed location.

The kSubpixelRounding macro was created to clarify a block of code,
but one simplification was missed.

Review URL: https://codereview.chromium.org/1733843002

8 years agouse the favicon on debugger.skia.org
jcgregorio [Thu, 25 Feb 2016 15:02:13 +0000 (07:02 -0800)]
use the favicon on debugger.skia.org

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734913002

Review URL: https://codereview.chromium.org/1734913002

8 years ago10.9 is no more
mtklein [Thu, 25 Feb 2016 14:52:18 +0000 (06:52 -0800)]
10.9 is no more

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732353002

Review URL: https://codereview.chromium.org/1732353002

8 years agoRevert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset...
bsalomon [Thu, 25 Feb 2016 14:52:12 +0000 (06:52 -0800)]
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )

Reason for revert:
Need workaround for chrome to build

Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1734043002

8 years agoUpdate shaderc lib and use single combined lib
Greg Daniel [Thu, 25 Feb 2016 14:47:33 +0000 (09:47 -0500)]
Update shaderc lib and use single combined lib

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737653002
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/1737653002

8 years agoMove Budgeted enum out of SkSurface, use in GrTextureProvider
bsalomon [Thu, 25 Feb 2016 14:33:26 +0000 (06:33 -0800)]
Move Budgeted enum out of SkSurface, use in GrTextureProvider

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005

Review URL: https://codereview.chromium.org/1728093005

8 years agoAdd -lrt flag for ChromeOS to enable the usage of clock_gettime. Enable RawCodec...
yujieqin [Thu, 25 Feb 2016 13:42:30 +0000 (05:42 -0800)]
Add -lrt flag for ChromeOS to enable the usage of clock_gettime. Enable RawCodec for ChromeOS

BUG=b/26813410
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733223002

Review URL: https://codereview.chromium.org/1733223002

8 years agoImplement support for using GL ES 3.0 with command buffer
kkinnunen [Thu, 25 Feb 2016 10:03:43 +0000 (02:03 -0800)]
Implement support for using GL ES 3.0 with command buffer

Adds a new 'api': --config gpu(api=commandbuffer3) for dm/nanobench.

BUG=skia:4943
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684413003

Review URL: https://codereview.chromium.org/1684413003

8 years agotrim DM fat
mtklein [Thu, 25 Feb 2016 03:07:07 +0000 (19:07 -0800)]
trim DM fat

 - cuts out a few fringe features like logs and notes tallies
 - moves vetos and blacklisting earlier so they're never really seen
 - many string strength reductions, either to const SkString& or const char*

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1727363004

Review URL: https://codereview.chromium.org/1727363004

8 years agoFix ~,! typo when clearing kRenderTarget flag
Brian Salomon [Thu, 25 Feb 2016 02:55:47 +0000 (21:55 -0500)]
Fix ~,! typo when clearing kRenderTarget flag

TBR=brucedawson@chromium.org,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1727413004

Review URL: https://codereview.chromium.org/1727413004 .

8 years agoDM: assert we ran as many tasks as we thought we would
mtklein [Thu, 25 Feb 2016 02:00:23 +0000 (18:00 -0800)]
DM: assert we ran as many tasks as we thought we would

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731783003

Review URL: https://codereview.chromium.org/1731783003

8 years agoUnit Tests: eliminate stray SkDebugf()s.
halcanary [Thu, 25 Feb 2016 01:59:16 +0000 (17:59 -0800)]
Unit Tests: eliminate stray SkDebugf()s.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733113002

Review URL: https://codereview.chromium.org/1733113002

8 years agoSkPDF: fix scalar serialization
halcanary [Wed, 24 Feb 2016 23:46:46 +0000 (15:46 -0800)]
SkPDF: fix scalar serialization

BUG=skia:4868
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720863003

Review URL: https://codereview.chromium.org/1720863003

8 years agoAdd skia.conf (configuration file that supports printShaders, etc...) to .gitignore
brianosman [Wed, 24 Feb 2016 23:38:48 +0000 (15:38 -0800)]
Add skia.conf (configuration file that supports printShaders, etc...) to .gitignore

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734563003

Review URL: https://codereview.chromium.org/1734563003

8 years agoAdd 4f linear gradient benches
fmalita [Wed, 24 Feb 2016 23:32:57 +0000 (15:32 -0800)]
Add 4f linear gradient benches

Plus some more regular tiling mode variations and random cleanups.

R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728283003

Review URL: https://codereview.chromium.org/1728283003

8 years agoSkPDF/Bench: add bench for SkPDFSharedStream (deflate)
halcanary [Wed, 24 Feb 2016 23:17:19 +0000 (15:17 -0800)]
SkPDF/Bench: add bench for SkPDFSharedStream (deflate)

Also, simplify gyp.

BUG=skia:5009
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730833003

Review URL: https://codereview.chromium.org/1730833003

8 years agoAdd wrapBackendTextureAsRenderTarget API
ericrk [Wed, 24 Feb 2016 22:49:51 +0000 (14:49 -0800)]
Add wrapBackendTextureAsRenderTarget API

Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
 * wrapBackendTexture - wraps a texture into a GrTexture. Depending on
   flags, this GrTexture can be converted to a GrRenderTarget. Skia
   manages the render target objects it may create to provide a render
   target for the texture. This allows Skia to create stencil buffers
   if needed and manager MSAA resolves.
 * wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
   object cannot be converted to a GrTexture. Skia does not manage
   the render target objects for such a GrRenderTarget, and as such
   cannot attach stencil buffers or perform MSAA resolves on the
   created GrRenderTarget.

Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.

While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.

To address this, a new function is created:
 * wrapBackendTextureAsRenderTarget - wraps a texture into a
   GrRenderTarget. As with wrapBackendTexture, the created render
   target objects are fully managed by Skia. Unlike wrapBackendTexture
   no GrTexture is created, and the created object will never be
   textured from.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709163003

Review URL: https://codereview.chromium.org/1709163003

8 years agoHide GrDrawTarget from GrOvalRenderer
robertphillips [Wed, 24 Feb 2016 21:36:56 +0000 (13:36 -0800)]
Hide GrDrawTarget from GrOvalRenderer

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731413002

Review URL: https://codereview.chromium.org/1731413002

8 years agoRethink DM output
mtklein [Wed, 24 Feb 2016 20:28:32 +0000 (12:28 -0800)]
Rethink DM output

Instead of printing out each task as it finishes, or as it starts and as it finishes, periodically print out what we're up to.

Example output:
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6436/steps/dm/logs/stdio

BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730943003

Review URL: https://codereview.chromium.org/1730943003

8 years agoAdded a flag that forces SampleApp to continuously redraw, even in non-animated tests...
brianosman [Wed, 24 Feb 2016 19:47:47 +0000 (11:47 -0800)]
Added a flag that forces SampleApp to continuously redraw, even in non-animated tests. Helpful when profiling or debugging.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731853003

Review URL: https://codereview.chromium.org/1731853003

8 years agoRound to nearest in ScalarTo256.
benjaminwagner [Wed, 24 Feb 2016 18:57:47 +0000 (10:57 -0800)]
Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion on https://codereview.chromium.org/1691403002.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723483004

Review URL: https://codereview.chromium.org/1723483004

8 years agoDocumentation: sync-and-gyp design document
halcanary [Wed, 24 Feb 2016 18:50:35 +0000 (10:50 -0800)]
Documentation: sync-and-gyp design document

NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/design/sync-and-gyp?cl=1736483002

Review URL: https://codereview.chromium.org/1736483002

8 years agoChange SkUnitScalarClampToByte to more accurate implementation.
benjaminwagner [Wed, 24 Feb 2016 18:07:52 +0000 (10:07 -0800)]
Change SkUnitScalarClampToByte to more accurate implementation.

The previous implementation was likely more efficient when SkScalar was SkFixed.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691403002

Review URL: https://codereview.chromium.org/1691403002

8 years agoremove debugging printf
reed [Wed, 24 Feb 2016 17:32:40 +0000 (09:32 -0800)]
remove debugging printf

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725173003

NOTRY=True
TBR=

Review URL: https://codereview.chromium.org/1725173003

8 years agoSkPDF/Bench: add bench for SkPDFCreateBitmapObject
halcanary [Wed, 24 Feb 2016 17:25:58 +0000 (09:25 -0800)]
SkPDF/Bench: add bench for SkPDFCreateBitmapObject

BUG=skia:5009

Review URL: https://codereview.chromium.org/1729943003

8 years agofixup GLPrograms textblob todo
joshualitt [Wed, 24 Feb 2016 17:23:03 +0000 (09:23 -0800)]
fixup GLPrograms textblob todo

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730253002

Review URL: https://codereview.chromium.org/1730253002

8 years agofix path ops fuzz bug
caryclark [Wed, 24 Feb 2016 17:03:07 +0000 (09:03 -0800)]
fix path ops fuzz bug

If one path is empty and the other has extreme values, the
intermediate coincident paths cannot be resolved, but triggers
an assert that a data structure unexpectedly has zero-length.

Tunnel this failure back up to the top and return that the
entire path op fails.

A future optimization could detect the empty path and avoid
this, allowing the op to succeed -- not sure that it's worth
the additional logic though.

TBR=reed@google.com
BUG=535151
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730293002

Review URL: https://codereview.chromium.org/1730293002

8 years agoTurn off DM --pre_log on the bots. Too spammy.
mtklein [Wed, 24 Feb 2016 16:58:27 +0000 (08:58 -0800)]
Turn off DM --pre_log on the bots.  Too spammy.

BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734703002

Review URL: https://codereview.chromium.org/1734703002

8 years agoUse ARM fixes for SDF encoding.
jvanverth [Wed, 24 Feb 2016 16:33:10 +0000 (08:33 -0800)]
Use ARM fixes for SDF encoding.

This pulls out the encoding fixes by Joel Liang from
https://codereview.chromium.org/1643143002/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726763002

Review URL: https://codereview.chromium.org/1726763002

8 years agoRevert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://coder...
benjaminwagner [Wed, 24 Feb 2016 16:29:11 +0000 (08:29 -0800)]
Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ )

Reason for revert:
New test is failing on Windows.

Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
>
> Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c

TBR=mtklein@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632

Review URL: https://codereview.chromium.org/1724283003

8 years agoRevert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview...
ethannicholas [Wed, 24 Feb 2016 16:19:04 +0000 (08:19 -0800)]
Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/1720963002/ )

Reason for revert:
This is in the blamelist for Visualbench failures:

https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035

and seems the most likely candidate for the failure, so I am tentatively reverting.

Original issue's description:
> Include glGetMultisamplefv API
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
>
> Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4

TBR=bsalomon@google.com,joshualitt@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1731333002

8 years agoextend xfermodes gm to include 3 custom modes
reed [Wed, 24 Feb 2016 16:18:42 +0000 (08:18 -0800)]
extend xfermodes gm to include 3 custom modes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1736523002

Review URL: https://codereview.chromium.org/1736523002

8 years agoEnsure the Gaussian tail of circle blurs goes to zero.
benjaminwagner [Wed, 24 Feb 2016 15:51:33 +0000 (07:51 -0800)]
Ensure the Gaussian tail of circle blurs goes to zero.

Compare blurcircle GM masked so that values <255 are white and =255 are black:
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-before.png
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-after.png

This is a spinoff of https://codereview.chromium.org/1691403002, which was previously causing more "rectangles" in this GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723383002

Review URL: https://codereview.chromium.org/1723383002

8 years agoCleanups related to SkFixed.
benjaminwagner [Wed, 24 Feb 2016 14:51:52 +0000 (06:51 -0800)]
Cleanups related to SkFixed.

Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.

Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.

Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005

Review URL: https://codereview.chromium.org/1683743005

8 years agosimplify/unify xferproc api
reed [Wed, 24 Feb 2016 14:21:36 +0000 (06:21 -0800)]
simplify/unify xferproc api

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721223002

Review URL: https://codereview.chromium.org/1721223002

8 years agoCreate new GM to target translations problems in GrAtlasTextContext
joshualitt [Wed, 24 Feb 2016 13:49:55 +0000 (05:49 -0800)]
Create new GM to target translations problems in GrAtlasTextContext

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721833005

Review URL: https://codereview.chromium.org/1721833005

8 years agoRetire SkShader::kSupports4f_Flag
fmalita [Wed, 24 Feb 2016 03:02:20 +0000 (19:02 -0800)]
Retire SkShader::kSupports4f_Flag

No longer used except in one test.

Introduce kPrefers4f_Flag instead.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726983002

Review URL: https://codereview.chromium.org/1726983002

8 years agoSkia schedule on skia.org
hcm [Wed, 24 Feb 2016 00:26:03 +0000 (16:26 -0800)]
Skia schedule on skia.org

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726253002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1726253002
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1726253002

8 years agoInclude glGetMultisamplefv API
cdalton [Tue, 23 Feb 2016 21:38:47 +0000 (13:38 -0800)]
Include glGetMultisamplefv API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002

Review URL: https://codereview.chromium.org/1720963002

8 years agoUpdate 4f linear gradient selection heuristic
fmalita [Tue, 23 Feb 2016 21:26:28 +0000 (13:26 -0800)]
Update 4f linear gradient selection heuristic

Use the 4f context when

  * dest type is 4f
  * there's no perpective

Keeping the define and testing flag overrides for now.

R=reed@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725793003

Review URL: https://codereview.chromium.org/1725793003

8 years agoMove SkPackBits to src/effects.
bungeman [Tue, 23 Feb 2016 20:55:20 +0000 (12:55 -0800)]
Move SkPackBits to src/effects.

Prior to this change SkPackBits.h was in include/core and SkPackBits.cpp
in src/core. However, SkPackBits appears to have been written
specifically as an implementation detail of the SkTableColorFilter
effect. This change moves SkPackBits out of core and into effects, which
is the only current user.

Review URL: https://codereview.chromium.org/1722173003

8 years agoSimplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc.
benjaminwagner [Tue, 23 Feb 2016 18:44:31 +0000 (10:44 -0800)]
Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc.

All callers of (the result of) SkPaint::getDrawCacheProc were passing zero as the last two arguments. This is the same as (the result of) SkPaint::getMeasureCacheProc(true).

Per bungeman, make this typedef a member of SkPaint.

Although the typedef is technically public, the only uses are private, so this is not really an API change.

TBR=reed
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718423002

Review URL: https://codereview.chromium.org/1718423002

8 years agoAdd a handler to DM to print out what was running when we crash.
mtklein [Tue, 23 Feb 2016 18:39:36 +0000 (10:39 -0800)]
Add a handler to DM to print out what was running when we crash.

This is an experiment to see if we can use something like this
rather than today's extremely verbose logging.

Now, hopefully something crashes.

BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725543002

Review URL: https://codereview.chromium.org/1725543002

8 years agomake transformed rrect radii fit rectangle
caryclark [Tue, 23 Feb 2016 18:32:40 +0000 (10:32 -0800)]
make transformed rrect radii fit rectangle

one more case caught by 1M skps
R=herb@google.com,reed@google.com
BUG=skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722483003

Review URL: https://codereview.chromium.org/1722483003

8 years agoRemove unnecessary GOOGLE3 ifdefs from SkRawCodec
msarett [Tue, 23 Feb 2016 16:21:21 +0000 (08:21 -0800)]
Remove unnecessary GOOGLE3 ifdefs from SkRawCodec

These should be fine now that SkJpegCodec is building in GOOGLE3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718343002

Review URL: https://codereview.chromium.org/1718343002

8 years agoUpdate SK_IMAGE_VERSION to 3
msarett [Tue, 23 Feb 2016 16:14:19 +0000 (08:14 -0800)]
Update SK_IMAGE_VERSION to 3

This includes two new test wbmps (that came from clients of BitmapFactory).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722263002

Review URL: https://codereview.chromium.org/1722263002

8 years agoMove SkUtils.h to src/core.
bungeman [Tue, 23 Feb 2016 15:34:25 +0000 (07:34 -0800)]
Move SkUtils.h to src/core.

Review URL: https://codereview.chromium.org/1722703003

8 years agoadded 'visible' attribute to skiaserve JSON
ethannicholas [Tue, 23 Feb 2016 14:53:37 +0000 (06:53 -0800)]
added 'visible' attribute to skiaserve JSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726663002

Review URL: https://codereview.chromium.org/1726663002

8 years agoUse new API instead of the deprecated ones.
yujieqin [Tue, 23 Feb 2016 14:49:38 +0000 (06:49 -0800)]
Use new API instead of the deprecated ones.

This change will allow us to remove the old API in follow up clean up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002

Review URL: https://codereview.chromium.org/1728553002

8 years agoUpdate PIEX: Prepares support for uncompressed thumbnails
yujieqin [Tue, 23 Feb 2016 14:18:14 +0000 (06:18 -0800)]
Update PIEX: Prepares support for uncompressed thumbnails

The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.

BUG=b/26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002

Review URL: https://codereview.chromium.org/1723123002

8 years agoTurn on TURBO_HAS_CROP for Android framework
msarett [Tue, 23 Feb 2016 13:48:01 +0000 (05:48 -0800)]
Turn on TURBO_HAS_CROP for Android framework

https://buganizer.corp.google.com/u/0/issues/27290496
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721953002

Review URL: https://codereview.chromium.org/1721953002

8 years agoMake DM failures fatal
msarett [Tue, 23 Feb 2016 13:37:25 +0000 (05:37 -0800)]
Make DM failures fatal

We should now only be pushing Srcs for tests that we expect
to succeed.  So any failures should be treated as errors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719293002

Review URL: https://codereview.chromium.org/1719293002

8 years agoAdd dest type hint to SkShader::ContextRec
fmalita [Tue, 23 Feb 2016 01:19:04 +0000 (17:19 -0800)]
Add dest type hint to SkShader::ContextRec

Let SkBlitter decide which dst type is optimal (PMColor vs PM4f), and
pass that info to shaders.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724503002

Review URL: https://codereview.chromium.org/1724503002

8 years agoremove unnecessary copies
mtklein [Tue, 23 Feb 2016 00:56:00 +0000 (16:56 -0800)]
remove unnecessary copies

these used to matter with pass-by-ref

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721153002

Review URL: https://codereview.chromium.org/1721153002

8 years agoRun no CPU benches in Debug trybots.
mtklein [Mon, 22 Feb 2016 22:59:59 +0000 (14:59 -0800)]
Run no CPU benches in Debug trybots.

They seem to just be wasting time on the CQ.

Hacking this into nanobench_flags.py makes it easy to back out.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720223002

Review URL: https://codereview.chromium.org/1720223002

8 years agoBetter encapsulation and vector calling convention.
herb [Mon, 22 Feb 2016 22:48:21 +0000 (14:48 -0800)]
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723683002

Review URL: https://codereview.chromium.org/1723683002

8 years agoFix DM_INCLUDES after https://codereview.chromium.org/1688543002
benjaminwagner [Mon, 22 Feb 2016 21:30:39 +0000 (13:30 -0800)]
Fix DM_INCLUDES after https://codereview.chromium.org/1688543002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719253002

Review URL: https://codereview.chromium.org/1719253002

8 years agoOnly use fake gamma with linear devices.
bungeman [Mon, 22 Feb 2016 21:20:28 +0000 (13:20 -0800)]
Only use fake gamma with linear devices.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711223003

Review URL: https://codereview.chromium.org/1711223003

8 years agoAdd spans for matrix ops.
herb [Mon, 22 Feb 2016 21:13:28 +0000 (13:13 -0800)]
Add spans for matrix ops.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722703002

Review URL: https://codereview.chromium.org/1722703002

8 years agofix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes()
bsalomon [Mon, 22 Feb 2016 21:09:26 +0000 (13:09 -0800)]
fix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724493002

Review URL: https://codereview.chromium.org/1724493002

8 years agoFix unsigned short UVs for Vulkan.
jvanverth [Mon, 22 Feb 2016 21:05:51 +0000 (13:05 -0800)]
Fix unsigned short UVs for Vulkan.

Modifies the attribute type to match GL.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723633003

Review URL: https://codereview.chromium.org/1723633003

8 years agoFix gyp-and-sync for windows
bsalomon [Mon, 22 Feb 2016 20:59:53 +0000 (12:59 -0800)]
Fix gyp-and-sync for windows
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715423003

Review URL: https://codereview.chromium.org/1715423003

8 years agofix misc asserts and checks found by fuzzer
reed [Mon, 22 Feb 2016 20:50:25 +0000 (12:50 -0800)]
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719993002

Review URL: https://codereview.chromium.org/1719993002

8 years agoallow move/zero-line/close to draw caps
caryclark [Mon, 22 Feb 2016 20:44:54 +0000 (12:44 -0800)]
allow move/zero-line/close to draw caps

R=fmalita@chromium.org
BUG=skia:4784
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720953002

Review URL: https://codereview.chromium.org/1720953002

8 years agokill gm now that we can test srgb on all gms
reed [Mon, 22 Feb 2016 20:29:04 +0000 (12:29 -0800)]
kill gm now that we can test srgb on all gms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719963004

TBR=

Review URL: https://codereview.chromium.org/1719963004

8 years agoUse new jpeg_crop_scanlines() API to optimize jpeg subset decodes
msarett [Mon, 22 Feb 2016 20:27:46 +0000 (12:27 -0800)]
Use new jpeg_crop_scanlines() API to optimize jpeg subset decodes

This was adapted from:
https://codereview.chromium.org/1530933003

Subset Decode Runtime (Original / Optimized) on Nexus 6P
TopLeft     0.51x
TopRight    0.56x
Middle      0.71x
BottomLeft  0.79x
BottomRight 0.79x

BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719073002

Review URL: https://codereview.chromium.org/1719073002

8 years agoIncorporate Vulkan files into main gpu.gyp/gpu.gypi
bsalomon [Mon, 22 Feb 2016 20:13:19 +0000 (12:13 -0800)]
Incorporate Vulkan files into main gpu.gyp/gpu.gypi

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718273002

Review URL: https://codereview.chromium.org/1718273002

8 years agoUse unorm shorts for texture coordinates when rendering text.
jvanverth [Mon, 22 Feb 2016 19:25:32 +0000 (11:25 -0800)]
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

Review URL: https://codereview.chromium.org/1713693002

8 years agoSimplify calculations in AADistanceFieldPathBatch::writePathVertices.
benjaminwagner [Mon, 22 Feb 2016 19:10:33 +0000 (11:10 -0800)]
Simplify calculations in AADistanceFieldPathBatch::writePathVertices.

No API changes.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715063002
TBR=reed

Review URL: https://codereview.chromium.org/1715063002

8 years agoAllow client to force an SkImage snapshot to be unique (and uniquely own its backing...
bsalomon [Mon, 22 Feb 2016 19:02:58 +0000 (11:02 -0800)]
Allow client to force an SkImage snapshot to be unique (and uniquely own its backing store).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686163002

Review URL: https://codereview.chromium.org/1686163002

8 years agoAdd ContextRec param to SkShader::contextSize()
fmalita [Mon, 22 Feb 2016 18:39:41 +0000 (10:39 -0800)]
Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002

Review URL: https://codereview.chromium.org/1720933002

8 years agoremove dead unpremul checks
reed [Mon, 22 Feb 2016 18:25:45 +0000 (10:25 -0800)]
remove dead unpremul checks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715333004

Review URL: https://codereview.chromium.org/1715333004

8 years agoFix to bazel build file to exclude vulkan files
egdaniel [Mon, 22 Feb 2016 18:07:54 +0000 (10:07 -0800)]
Fix to bazel build file to exclude vulkan files

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723593002

Review URL: https://codereview.chromium.org/1723593002

8 years agoskia.org internal links: Add link to Google3 Autoroller doc.
benjaminwagner [Mon, 22 Feb 2016 17:31:38 +0000 (09:31 -0800)]
skia.org internal links: Add link to Google3 Autoroller doc.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1720943003

Review URL: https://codereview.chromium.org/1720943003

8 years agoInitial linear gradient 4f impl
fmalita [Mon, 22 Feb 2016 17:12:33 +0000 (09:12 -0800)]
Initial linear gradient 4f impl

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688543002

Review URL: https://codereview.chromium.org/1688543002

8 years agoadded mode=cpu|gpu to skiaserve JSON
ethannicholas [Mon, 22 Feb 2016 16:59:57 +0000 (08:59 -0800)]
added mode=cpu|gpu to skiaserve JSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719973002

Review URL: https://codereview.chromium.org/1719973002

8 years agoFix nanobench SKP flushes between loops
cdalton [Mon, 22 Feb 2016 16:08:25 +0000 (08:08 -0800)]
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715873002

Review URL: https://codereview.chromium.org/1715873002

8 years agoAdd gl_SampleMask functionality to fragment builders
cdalton [Mon, 22 Feb 2016 15:55:44 +0000 (07:55 -0800)]
Add gl_SampleMask functionality to fragment builders

Adds methods for overriding and masking a fragment's sample mask.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003

Committed: https://skia.googlesource.com/skia/+/533cefe5b9c7cec2592fc7ca00ee4cf69a26c094

Review URL: https://codereview.chromium.org/1690963003

8 years agoRevert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https...
ethannicholas [Mon, 22 Feb 2016 15:42:18 +0000 (07:42 -0800)]
Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1719913002/ )

Reason for revert:
Looks to be causing failures in LayerTreeHostFilters* tests (https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/177297/steps/cc_unittests%20%28with%20patch%29/logs/stdio).

Original issue's description:
> fix misc asserts and checks found by fuzzer
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/653db51b440491b0fb1908bf5a43dcc89c90044d

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1721743002

8 years agoRemove vulkan files from cmake build
egdaniel [Mon, 22 Feb 2016 15:19:10 +0000 (07:19 -0800)]
Remove vulkan files from cmake build

TBR=bsalomon@google.com
NOTRY=True

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717313002

Review URL: https://codereview.chromium.org/1717313002

8 years agoclean-up dead code
reed [Mon, 22 Feb 2016 14:59:37 +0000 (06:59 -0800)]
clean-up dead code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719773002

Review URL: https://codereview.chromium.org/1719773002

8 years agoAdd vulkan files into skia repo. This is an incomplete backend with only partial...
Greg Daniel [Mon, 22 Feb 2016 14:56:40 +0000 (09:56 -0500)]
Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.

R=robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:4955
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002

Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f

Review URL: https://codereview.chromium.org/1718693002

8 years agolots of sRGB and F16 blits
reed [Mon, 22 Feb 2016 14:42:31 +0000 (06:42 -0800)]
lots of sRGB and F16 blits

- generalize F16 xfermode procs
- spriteblits for F16 and sRGB
- saveLayer now respects colortype and profiletype

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686013002

Review URL: https://codereview.chromium.org/1685203002

8 years agofix misc asserts and checks found by fuzzer
reed [Mon, 22 Feb 2016 14:34:47 +0000 (06:34 -0800)]
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002

TBR=

Review URL: https://codereview.chromium.org/1719913002

8 years agoadd SkGraphics::PurageAllCaches
reed [Mon, 22 Feb 2016 14:19:54 +0000 (06:19 -0800)]
add SkGraphics::PurageAllCaches

BUG=skia:4755
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722603002

TBR=

Review URL: https://codereview.chromium.org/1722603002