mtklein [Tue, 13 Sep 2016 18:17:58 +0000 (11:17 -0700)]
Remove clear /data/local/tmp steps.
These were intended to prevent GN and GYP Android bots from stomping on
each other. Turns out, they don't, even without this... they're writing
most files to completely separate paths:
- GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
in /data/local/tmp;
- GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
don't overlap GYP's.
So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2340473002
Review-Url: https://codereview.chromium.org/
2340473002
csmartdalton [Tue, 13 Sep 2016 17:41:49 +0000 (10:41 -0700)]
Add ContextOptions field to SkCommandLineConfigGpu
Reduces duplicate code by computing the ContextOptions in one spot.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2337163002
Review-Url: https://codereview.chromium.org/
2337163002
fmalita [Tue, 13 Sep 2016 17:00:23 +0000 (10:00 -0700)]
Use sk_sp text blob APIs
SkTextBlobBuilder::build() -> make()
SkAutoTUnref<const SkTextBlob> -> sk_sp<SkTextBlob>
drawTextBlob(const SkTextBlob*) -> drawTextBlob(const sk_sp<SkTextBlob>&)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2335493005
Review-Url: https://codereview.chromium.org/
2335493005
egdaniel [Tue, 13 Sep 2016 16:54:11 +0000 (09:54 -0700)]
Lots of little cleanup improvements to Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336763002
Review-Url: https://codereview.chromium.org/
2336763002
msarett [Tue, 13 Sep 2016 16:04:11 +0000 (09:04 -0700)]
Implement Fill() for incomplete decodes to RGBA_F16
Before this patch, we would hit an SkASSERT(false).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2335203002
Review-Url: https://codereview.chromium.org/
2335203002
kjlubick [Tue, 13 Sep 2016 15:48:27 +0000 (08:48 -0700)]
Add Nexus5 to CQ as an experiment
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2332353002
Review-Url: https://codereview.chromium.org/
2332353002
brianosman [Tue, 13 Sep 2016 15:24:56 +0000 (08:24 -0700)]
Add tests for gamma correction of gradient stops to gamma GM
Includes three different cases to exercise different cases in Ganesh.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336973003
Review-Url: https://codereview.chromium.org/
2336973003
reed [Tue, 13 Sep 2016 15:09:45 +0000 (08:09 -0700)]
add pipecanvas
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2201323003
Review-Url: https://codereview.chromium.org/
2201323003
halcanary [Tue, 13 Sep 2016 15:08:38 +0000 (08:08 -0700)]
SkPDF: SkTypeface_FreeType ToUnicode table improvement.
Currently the SkTypeface_FreeType::onGetAdvancedTypefaceMetrics
synthesized glyph to Unicode mapping returns the Unicode point
of the last character to map to the glyph. In practice it is
better to guess the first character to map to the glyph instead.
BUG=359065
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2329953003
Review-Url: https://codereview.chromium.org/
2329953003
mtklein [Tue, 13 Sep 2016 14:20:47 +0000 (07:20 -0700)]
I missed an infra_step, pushing directories.
NOTREECHECKS=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2337793003
Review-Url: https://codereview.chromium.org/
2337793003
msarett [Tue, 13 Sep 2016 14:08:15 +0000 (07:08 -0700)]
Encode kIndex8 to PNG more efficiently
Only write non-opaque alpha values to the tRNS chunk.
BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2330053002
Review-Url: https://codereview.chromium.org/
2330053002
mtklein [Tue, 13 Sep 2016 12:49:16 +0000 (05:49 -0700)]
Mark infra steps as infra_step in GN recipe flavors.
NOTREECHECKS=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2329943004
Review-Url: https://codereview.chromium.org/
2329943004
robertphillips [Tue, 13 Sep 2016 00:25:50 +0000 (17:25 -0700)]
Fixup SkRRectsGaussianEdgeShader's shaders
This fixes some visual artifacts in the original CL.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2335783003
Review-Url: https://codereview.chromium.org/
2335783003
fmalita [Tue, 13 Sep 2016 00:06:47 +0000 (17:06 -0700)]
[SVGDom] Initial linear gradient support
Kind of a big change, to connect several new bits into something useful:
* ID tracking & lookup
* new asPaint() node virtual to support shader (and in the future filter) based paint servers
* <defs>, <linearGradient> and <stop> element support
* 'href', 'offset', 'stop-color', 'stop-opacity' attribute support
* IRI/FuncIRI and rgb(...) parsing
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2327233003
Review-Url: https://codereview.chromium.org/
2327233003
mikejurka [Mon, 12 Sep 2016 23:51:58 +0000 (16:51 -0700)]
Change shared_sources.gni to use relative path
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2333923003
Review-Url: https://codereview.chromium.org/
2333923003
msarett [Mon, 12 Sep 2016 22:49:37 +0000 (15:49 -0700)]
Disable png encodes from Alpha8, Float16
These don't behave as we would want anyway. They just copy
to N32, and then encode.
BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2332743003
Review-Url: https://codereview.chromium.org/
2332743003
mtklein [Mon, 12 Sep 2016 22:15:44 +0000 (15:15 -0700)]
Alternate approach to turn on freetype in Fuchsia.
What do you think of this? It's basically what you wrote, factored differently.
Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.
Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target. No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.
We (obviously?) don't have Fuchsia builders, so I've got to rely on you for sanity testing this.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2333913002
Review-Url: https://codereview.chromium.org/
2333913002
msarett [Mon, 12 Sep 2016 21:30:03 +0000 (14:30 -0700)]
Support RGBA/BGRA Premul/Unpremul from SkPNGImageEncoder
BUG=skia:5616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2325223002
Review-Url: https://codereview.chromium.org/
2325223002
borenet [Mon, 12 Sep 2016 21:02:13 +0000 (14:02 -0700)]
Add back the GalaxyS3 and GalaxyS4 entries in recipes
S3 is needed for some recipe simulation stuff and in general having
these present does not hurt us.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336513003
Review-Url: https://codereview.chromium.org/
2336513003
bsalomon [Mon, 12 Sep 2016 20:42:18 +0000 (13:42 -0700)]
Remove unused GrGLSLGeometryProcessor::emitTransform variation
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2338453002
Review-Url: https://codereview.chromium.org/
2338453002
liyuqian [Mon, 12 Sep 2016 20:00:50 +0000 (13:00 -0700)]
Revert of SkLiteRecorder: don't tell SkCanvas about clips (patchset #1 id:1 of https://codereview.chromium.org/
2227833004/ )
Reason for revert:
This CL breaks Android CTS tests CanvasStateTests#testClipPathReturnValues, CanvasStateTests#testClipRectReturnValues, and CanvasStateTests#testQuickReject.
Reverting it won't significantly affect Android's performance. See the following test result of testInvalidateTree Jank test. (Derek said that this is the only test closely related to this CL.)
**After reverting**
INSTRUMENTATION_STATUS: gfx-max-slow-draw=0.0
INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=72.
96467105972435
INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-max-missed-vsync=73.
56181150550796
INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=69.0
INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=69.0
INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0
INSTRUMENTATION_STATUS: gfx-max-jank=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.0
INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69
INSTRUMENTATION_STATUS: gfx-avg-jank=100.0
INSTRUMENTATION_STATUS_CODE: -1
.
Test results for InstrumentationTestRunner=.
Time: 77.404
**Before Reverting**
gfx-max-slow-draw=1.
1135857461024499
INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=70.
79687591131983
INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-max-missed-vsync=76.
94174757281553
INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=67.
66666666666667
INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=67.
66666666666667
INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0
INSTRUMENTATION_STATUS: gfx-max-jank=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.
5317509395832639
INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69
INSTRUMENTATION_STATUS: gfx-avg-jank=100.0
INSTRUMENTATION_STATUS_CODE: -1
.
Test results for InstrumentationTestRunner=.
Time: 77.411
OK (1 test)
Original issue's description:
> SkLiteRecorder: don't tell SkCanvas about clips
>
> If no one reads our clip, and we don't expect quickReject() to help,
> we can probably get away without maintaining a proper clip stack.
>
> This puts us at about 0.6-0.7x of previous record cost.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2227833004
>
> Committed: https://skia.googlesource.com/skia/+/
8369e32a05543c2619b1d7e740fe6ff6d2f03af3
TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
Review-Url: https://codereview.chromium.org/
2335773002
bsalomon [Mon, 12 Sep 2016 19:56:58 +0000 (12:56 -0700)]
Remove base class for installed transforms in GrPrimitiveProcessor
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336723002
Review-Url: https://codereview.chromium.org/
2336723002
mtklein [Mon, 12 Sep 2016 19:24:38 +0000 (12:24 -0700)]
GN: Android perf/tests
Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts.
The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware.
The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both.
I have omitted a few steps that may be important, but which are easy independent follow-ups:
- running as root
- locking clocks
- waiting on battery levels
- fancier wait-for-ready than adb wait-for-usb-device
It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later.
As of PS 41 or so, it looks like the trybots are all behaving as expected.
We should expect no new images in Gold. Can we see trybots in Perf yet?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2320153002
CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot
Review-Url: https://codereview.chromium.org/
2320153002
brianosman [Mon, 12 Sep 2016 19:07:25 +0000 (12:07 -0700)]
Gamut transformation of the paint color in Ganesh
Conversion from sRGB to destination gamut is going to be very common,
so I'm caching that xform (if there is one) on the draw context.
Results verified in the gamut GM (two more boxes correct).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2330553003
Review-Url: https://codereview.chromium.org/
2330553003
bsalomon [Mon, 12 Sep 2016 19:07:17 +0000 (12:07 -0700)]
Match Android framework's non-AA point and line offset
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336623002
Review-Url: https://codereview.chromium.org/
2336623002
robertphillips [Mon, 12 Sep 2016 19:02:16 +0000 (12:02 -0700)]
Add shader-based GaussianEdgeShader for reveal case
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2321713004
Review-Url: https://codereview.chromium.org/
2321713004
bsalomon [Mon, 12 Sep 2016 19:02:11 +0000 (12:02 -0700)]
Remove GrPrimitiveProcessor::hasTransformedLocalCoords
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2327613002
Review-Url: https://codereview.chromium.org/
2327613002
reed [Mon, 12 Sep 2016 19:01:44 +0000 (12:01 -0700)]
change SkStreams to work with sk_sp<SkData> instead of SkData*
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2333713002
Review-Url: https://codereview.chromium.org/
2333713002
borenet [Mon, 12 Sep 2016 18:56:37 +0000 (11:56 -0700)]
Fix device cfg for GalaxyS7
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2330093002
Review-Url: https://codereview.chromium.org/
2330093002
halcanary [Mon, 12 Sep 2016 18:56:28 +0000 (11:56 -0700)]
Documentation: MSKP
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2332783002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2332783002
Review-Url: https://codereview.chromium.org/
2332783002
egdaniel [Mon, 12 Sep 2016 18:51:29 +0000 (11:51 -0700)]
Add workaround for Adreno copyImageToBuffer calls on Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2328823003
Review-Url: https://codereview.chromium.org/
2328823003
borenet [Mon, 12 Sep 2016 18:51:26 +0000 (11:51 -0700)]
Run recipes.py with --timestamps
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2330123002
Review-Url: https://codereview.chromium.org/
2330123002
jvanverth [Mon, 12 Sep 2016 17:09:16 +0000 (10:09 -0700)]
Fix GaussianEdgeShader GLSL code
Implicit conversion of int constants to float is not always
guaranteed
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2328263004
TBR=herbderby@google.com
NOTRY=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/
2328263004
bsalomon [Mon, 12 Sep 2016 16:30:36 +0000 (09:30 -0700)]
Remove unneeded GrGLSLTransformedCoordsArray type
Rename GrGLSLFragmentBuilder::ensureFSCoords2D to ensureCoords2D and make it take an arbitrary GrShaderVar.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324663004
Review-Url: https://codereview.chromium.org/
2324663004
ethannicholas [Mon, 12 Sep 2016 16:15:53 +0000 (09:15 -0700)]
Revert of Turned on SkSL->GLSL compiler (patchset #12 id:220001 of https://codereview.chromium.org/
2288033003/ )
Reason for revert:
Compilation errors on some bots.
Original issue's description:
> Turned on SkSL->GLSL compiler
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
>
> Committed: https://skia.googlesource.com/skia/+/
9b0fe3d125f237d9884732a48414fa85fc71b4e3
TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2337553002
bsalomon [Mon, 12 Sep 2016 16:05:48 +0000 (09:05 -0700)]
Remove unneeded bounds outset in GrDrawContext::drawVertices.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2329403004
Review-Url: https://codereview.chromium.org/
2329403004
brianosman [Mon, 12 Sep 2016 16:05:14 +0000 (09:05 -0700)]
glTexStorage requires sized formats, ensure that we're following that rule
In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2336613002
Review-Url: https://codereview.chromium.org/
2336613002
bsalomon [Mon, 12 Sep 2016 15:55:38 +0000 (08:55 -0700)]
Remove ability to skip coord transform comparison in pipeline comparison.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2316413003
Review-Url: https://codereview.chromium.org/
2316413003
halcanary [Mon, 12 Sep 2016 15:55:29 +0000 (08:55 -0700)]
SkPDF: refactor & code cleanup ahead of https://crrev.com/
2322403002
SkPDFDevice::GraphicStateEntry: remove unnecessary fFont and
fTextSize.
SkPDFDevice::updateFont(): replace with update_font() and inlined
code. De-duplicate this block of code.
SkPDFResourceDict::GetResourceTypePrefix function made public: removes
need for temporary SkString returned by
SkPDFResourceDict::getResourceName()
GlyphPositioner: delay writing intial matrix until first glyph.
Assert that widechars is a constant.
SkPDFFont::FontType(): make public so that PDFDevice can know about
multibyte status.
SkPDFFont::countStretch() removed, and the stretch loop flattened.
*no changes in PDF output*
BUG=skia:5434
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2327953002
Review-Url: https://codereview.chromium.org/
2327953002
brianosman [Mon, 12 Sep 2016 15:50:19 +0000 (08:50 -0700)]
Two changes:
1. Remove special premul handling from gamut xform code
Alpha is a constant, so the gamut transformation results remain unchanged
(it distributes across the linear matrix multiply).
2. Use SkMatrix44 rather than array of floats
Preserves semantic intention, and makes upcoming code (where we transform
colors on the CPU by that matrix) simpler.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2329553002
Review-Url: https://codereview.chromium.org/
2329553002
ethannicholas [Mon, 12 Sep 2016 15:50:13 +0000 (08:50 -0700)]
Turned on SkSL->GLSL compiler
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2288033003
Review-Url: https://codereview.chromium.org/
2288033003
jvanverth [Mon, 12 Sep 2016 14:51:04 +0000 (07:51 -0700)]
Update SampleAndroidShadows to use algorithm closer to Android OpenGL
Includes:
* Update light position to be at a similar distance to Android OS
* Scale spot shadows correctly
* Compute stroke shapes and radii correctly
* Allow for larger blur radius for shadows
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319003003
TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/
2319003003
reed [Mon, 12 Sep 2016 13:32:07 +0000 (06:32 -0700)]
helper to SkRect to create from SkISize
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2332733002
TBR=
NOTREECHECKS=True
NOTRY=True
Review-Url: https://codereview.chromium.org/
2332733002
reed [Mon, 12 Sep 2016 13:31:48 +0000 (06:31 -0700)]
check for identity in translate
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2331943002
TBR=
NOTREECHECKS=True
NOTRY=True
Review-Url: https://codereview.chromium.org/
2331943002
reed [Mon, 12 Sep 2016 13:31:05 +0000 (06:31 -0700)]
fix code behind SK_SUPPORT_LEGACY_MINOR_EFFECT_PTR
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2337433002
TBR=
NOTREECHECKS=True
NOTRY=True
Review-Url: https://codereview.chromium.org/
2337433002
reed [Sun, 11 Sep 2016 12:40:31 +0000 (05:40 -0700)]
use expected name for setDrawLooper/getDrawLooper
Needed for future pipe cl.
Next cl should be to guard the looper entirely (since its deprecated)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2326173002
TBR=
Review-Url: https://codereview.chromium.org/
2326173002
update-skps [Sun, 11 Sep 2016 09:21:46 +0000 (02:21 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2334483002
Review-Url: https://codereview.chromium.org/
2334483002
halcanary [Sat, 10 Sep 2016 14:01:53 +0000 (07:01 -0700)]
SkPDF: SkShaper_primitive uses new textblob API
This will enable me to test the new API in unit tests without
depending on HarfBuzz (after https://crrev.com/
2322403002 lands).
TBR=
BUG=skia:5434
Review-Url: https://codereview.chromium.org/
2332473003
carlosk [Fri, 9 Sep 2016 23:15:19 +0000 (16:15 -0700)]
Adds missing and removes duplicate tracing macros.
This fixes the missing tracing nested instant call without any arguments and
removes the duplicate of the one with 2 arguments.
This is a follow up on https://crrev.com/
2326483004
BUG=645308
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2321283002
NOPRESUBMIT=true
CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot
Review-Url: https://codereview.chromium.org/
2321283002
vjiaoblack [Fri, 9 Sep 2016 18:58:19 +0000 (11:58 -0700)]
made point lights linear attenuation; also fixed point light depth bug
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2323383002
Review-Url: https://codereview.chromium.org/
2323383002
halcanary [Fri, 9 Sep 2016 18:41:59 +0000 (11:41 -0700)]
SkPDF/Tests: imporve test coverage.
Also: make sure that all SkPDF unit tests are named SkPDF_* to
make testing changes to SkPDF easier. Other cleanup.
Add test: SkPDF_pdfa_document to verify that flag in public API
works.
SkPDF_JpegIdentification test: test slightly malformed JPEGs to
verify that all code paths work.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2322133003
Review-Url: https://codereview.chromium.org/
2322133003
brianosman [Fri, 9 Sep 2016 18:30:55 +0000 (11:30 -0700)]
Fix color gamut xform matrices in GPU code
Now that we're not storing them transposed, we can plumb them to the
shader column-major all the way, and then multiply colors on the right, as
it should be.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2326093002
Review-Url: https://codereview.chromium.org/
2326093002
mtklein [Fri, 9 Sep 2016 18:07:45 +0000 (11:07 -0700)]
GN: port a few missing Android bits from GYP.
The SK_GAMMA_ defines change text rendering on Android.
This is how they're set in GYP for Android... everyone else is default (sRGB).
Linking AndroidSkDebugToStdOut.o causes SkDebugf to go to both logcat and
stdout on Android. Without it, it only goes to logcat. The file has no effect
on non-Android platforms.
BUG=skia:
Review-Url: https://codereview.chromium.org/
2323353002
brianosman [Fri, 9 Sep 2016 17:36:17 +0000 (10:36 -0700)]
Fix storage of gamut transform matrices in SkColorSpace
We were effectively storing the transpose, which made all of our
operations on individual colors, and our concatenation of matrices
awkward and backwards.
I'm planning to push this further into Ganesh, where I had incorrectly
adjusted to the previous layout, treating colors as row vectors in the
shaders.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324843003
Review-Url: https://codereview.chromium.org/
2324843003
caryclark [Fri, 9 Sep 2016 16:37:57 +0000 (09:37 -0700)]
Skip adding coincident edges found
during curve intersection if their
ends are nearly the same.
Loosen conic/line intersection point
check.
Detect when coincident points are
unordered. This means that points
a/b/c on one curve may appear in
b/c/a order on the opposite curve.
Restructure addMissing to return
success and return if a coincidence
was added as a parameter.
With this, tiger part a works.
Tiger part b exposes bugs around
tight quads that are nearly coincident
with themselves, and are coincident
with something else.
The greedy coicident matcher
may cause the point order to be
out of sync.
Still working out what to do in
this case.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2321773002
Review-Url: https://codereview.chromium.org/
2321773002
vjiaoblack [Fri, 9 Sep 2016 16:22:39 +0000 (09:22 -0700)]
Added in Radial Shadows
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2311223004
Review-Url: https://codereview.chromium.org/
2311223004
msarett [Fri, 9 Sep 2016 14:48:05 +0000 (07:48 -0700)]
Delete some LUTs from SkColorSpaceXform
No need to keep these around. In the rare case that these are
needed, we can just go ahead and build them.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2326043002
Review-Url: https://codereview.chromium.org/
2326043002
caryclark [Fri, 9 Sep 2016 14:41:36 +0000 (07:41 -0700)]
fix fuzzer
Earlier fix aborted coincident loop on wrong condition.
This aborts only when it reaches the end, and then
propagates the error out correctly.
TBR=reed@google.com
BUG=644680, 644684
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2327053002
Review-Url: https://codereview.chromium.org/
2327053002
borenet [Fri, 9 Sep 2016 12:37:29 +0000 (05:37 -0700)]
Fix issues in assets scripts
- Delete unconditionally uses 'gsutil'
- args.gsutil not plumbed properly
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2326663002
Review-Url: https://codereview.chromium.org/
2326663002
halcanary [Fri, 9 Sep 2016 12:34:55 +0000 (05:34 -0700)]
SkPDF: implement drawTextBlob()
Pass new fields from https://skia.googlesource.com/skia/+/4f0a23a into
SkPDFDevice::internalDrawText() (a later CL will use
them for /ActualText.
No change in PDF output.
BUG=skia:5434
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2300393002
Review-Url: https://codereview.chromium.org/
2300393002
halcanary [Thu, 8 Sep 2016 22:04:38 +0000 (15:04 -0700)]
SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.
Also, minor code refactoring.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2258233002
Committed: https://skia.googlesource.com/skia/+/
fce190647285423bf36c44bca09db78a6af30f9f
Review-Url: https://codereview.chromium.org/
2258233002
kjlubick [Thu, 8 Sep 2016 20:04:30 +0000 (13:04 -0700)]
Fix strange failures on Android N
We were seeing problems where dm ended with exit code 0, but the step still failed.
It seems they changed what N returns when a thing completes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319843003
TBR=bugsbunny
Review-Url: https://codereview.chromium.org/
2319843003
bsalomon [Thu, 8 Sep 2016 19:35:32 +0000 (12:35 -0700)]
Benchmarks for testing changes to GrResourceCache replacement policy when over budget.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2317263002
Review-Url: https://codereview.chromium.org/
2317263002
msarett [Thu, 8 Sep 2016 18:55:16 +0000 (11:55 -0700)]
Checking for valid colorType, alphaType, colorSpace in SkCodec
* Refactor to share code between SkPngCodec and SkWebpCodec
* Didn't end up sharing with SkJpegCodec but did refactor
that code a bit
* Disallow conversions to F16 with non-linear color spaces
* Fail to decode if we fail to create a SkColorSpaceXform
(should be an assert soon). We used to fallback on a
legacy decode if we failed to create the transform.
* A bunch of name changes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319293003
Committed: https://skia.googlesource.com/skia/+/
7a9900d6d34e437bb24beb5524a1f6488ae138c9
Review-Url: https://codereview.chromium.org/
2319293003
bsalomon [Thu, 8 Sep 2016 18:28:59 +0000 (11:28 -0700)]
Move prepareForExternalIO implementation from GrContext to GrDrawingManager
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324473002
Review-Url: https://codereview.chromium.org/
2324473002
mtklein [Thu, 8 Sep 2016 18:22:09 +0000 (11:22 -0700)]
Apple devices do not support CRC32 instructions. Don't believe Clang's lies.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2322033002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2322033002
msarett [Thu, 8 Sep 2016 17:54:34 +0000 (10:54 -0700)]
Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec (patchset #2 id:100001 of https://codereview.chromium.org/
2319293003/ )
Reason for revert:
Broken perf bots
Original issue's description:
> Checking for valid colorType, alphaType, colorSpace in SkCodec
>
> * Refactor to share code between SkPngCodec and SkWebpCodec
> * Didn't end up sharing with SkJpegCodec but did refactor
> that code a bit
> * Disallow conversions to F16 with non-linear color spaces
> * Fail to decode if we fail to create a SkColorSpaceXform
> (should be an assert soon). We used to fallback on a
> legacy decode if we failed to create the transform.
> * A bunch of name changes
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319293003
>
> Committed: https://skia.googlesource.com/skia/+/
7a9900d6d34e437bb24beb5524a1f6488ae138c9
TBR=scroggo@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2328663002
msarett [Thu, 8 Sep 2016 17:14:04 +0000 (10:14 -0700)]
Checking for valid colorType, alphaType, colorSpace in SkCodec
* Refactor to share code between SkPngCodec and SkWebpCodec
* Didn't end up sharing with SkJpegCodec but did refactor
that code a bit
* Disallow conversions to F16 with non-linear color spaces
* Fail to decode if we fail to create a SkColorSpaceXform
(should be an assert soon). We used to fallback on a
legacy decode if we failed to create the transform.
* A bunch of name changes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319293003
Review-Url: https://codereview.chromium.org/
2319293003
brianosman [Thu, 8 Sep 2016 17:10:11 +0000 (10:10 -0700)]
Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ().
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2323003002
Review-Url: https://codereview.chromium.org/
2323003002
mtklein [Thu, 8 Sep 2016 17:03:21 +0000 (10:03 -0700)]
GN: add a helper script for running Android builds
Think of this as the spiritual equivalent of platform_tools/android/bin/android_run_skia, but for GN and easier to type.
Cutting down the debug symbols makes Android builds about 1/4 the size.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2323833002
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=
2323833002
Review-Url: https://codereview.chromium.org/
2323833002
brianosman [Thu, 8 Sep 2016 16:33:50 +0000 (09:33 -0700)]
Push usage of GrColor4f into OverrideInput
Just a change to preserve precision.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324553002
Review-Url: https://codereview.chromium.org/
2324553002
mtklein [Thu, 8 Sep 2016 16:30:20 +0000 (09:30 -0700)]
most is fine for *SAN bots now
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2326553002
Review-Url: https://codereview.chromium.org/
2326553002
ethannicholas [Thu, 8 Sep 2016 16:19:51 +0000 (09:19 -0700)]
removed const from ASTVarDeclaration::fName to avoid a Chromium build failure
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2325673002
Review-Url: https://codereview.chromium.org/
2325673002
mtklein [Thu, 8 Sep 2016 16:19:00 +0000 (09:19 -0700)]
Clean up target_os=llvm now that it does nothing.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2317373004
Review-Url: https://codereview.chromium.org/
2317373004
robertphillips [Thu, 8 Sep 2016 16:02:43 +0000 (09:02 -0700)]
Add GM/slide to simulate Android-style reveal clip
Hopefully, this will let us play w/ geometric and shader-based solutions.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2316593003
Committed: https://skia.googlesource.com/skia/+/
ffac5c4aae18fc706e4077763c190a89c8507fb0
Review-Url: https://codereview.chromium.org/
2316593003
halcanary [Thu, 8 Sep 2016 15:58:37 +0000 (08:58 -0700)]
Tests: DiscardableMemory test no longer relies on global state
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2323013002
Review-Url: https://codereview.chromium.org/
2323013002
mtklein [Thu, 8 Sep 2016 15:49:08 +0000 (08:49 -0700)]
SkLiteDL: drawAsLayer()
This more or less the API you were thinking?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2315283002
Review-Url: https://codereview.chromium.org/
2315283002
mtklein [Thu, 8 Sep 2016 15:39:34 +0000 (08:39 -0700)]
GN: add sanitize arg
Attempt to take over all *SAN builds.
MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py.
I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier
to use locally.
The compile steps should be much faster now. We no longer build CMake
and Clang for every run, instead using the clang_linux CIPD package. This
removes the need for all the third_party/externals/llvm/... dependencies.
Similarly, since we're using the clang_linux package, we no longer depend
on Chrome's Clang, and thus no longer need to sync chromium on these bots.
Instead of packaging up MSAN libraries and llvm-symbolizer in the compile
output, I have the test / perf bots also depend on the clang_linux package.
These do not vary from build to build.
No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja
all track changes to xsan.blacklist without our help.
This has the incidental effect of upgrading the compiler used by *SAN
bots from Clang 3.8 to Clang 3.9.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2289343002
Review-Url: https://codereview.chromium.org/
2289343002
mtklein [Thu, 8 Sep 2016 13:59:44 +0000 (06:59 -0700)]
Flesh out SkOpts namespaces.
This makes it easier to see the baseline CPU feature settings for a build when looking at a stack trace or profile. This fills out all the features we currently
might care about.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2318313003
Review-Url: https://codereview.chromium.org/
2318313003
borenet [Thu, 8 Sep 2016 13:55:59 +0000 (06:55 -0700)]
Asset management: Download from GS store instead of CIPD
This avoids strange CIPD symlink/permissions issues
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2321623003
Review-Url: https://codereview.chromium.org/
2321623003
mtklein [Thu, 8 Sep 2016 13:49:05 +0000 (06:49 -0700)]
GN: do not set default GN args
It's just visual noise... this should make future gn_flavor.py
changes show fewer incidental diffs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324573002
Review-Url: https://codereview.chromium.org/
2324573002
Ravi Mistry [Thu, 8 Sep 2016 13:08:44 +0000 (09:08 -0400)]
Further increase run_benchmark timeout
Looks like the chromium page sets still hit the 10 min timeout.
BUG=skia:5700
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342
# This code is not exercised by trybots.
NOTRY=true
Change-Id: I57aba4c1541a840d7e4e97112a6485abc20aa3c7
Reviewed-on: https://skia-review.googlesource.com/2342
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
msarett [Thu, 8 Sep 2016 13:05:35 +0000 (06:05 -0700)]
Add color xform support to SkWebpCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2294993002
Committed: https://skia.googlesource.com/skia/+/
828ed1777da74692d0c8a5834017929f5aedcc6b
Review-Url: https://codereview.chromium.org/
2294993002
msarett [Thu, 8 Sep 2016 11:57:53 +0000 (04:57 -0700)]
Delete deprecated GammaNamed
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2320893002
Review-Url: https://codereview.chromium.org/
2320893002
mtklein [Thu, 8 Sep 2016 02:04:36 +0000 (19:04 -0700)]
GN: default to -O1
In a GN world we are no longer tied to the Debug/Release dichotomy of
GYP, and extra_cflags makes it trivially easy to override any flags we
set by default. These two together mean we don't have to make the default
Debug build pointlessly unoptimized.
-O1 takes negligibly longer to compile than -O0, doesn't make debugging
difficult, and the code is considerably better. DM runs ~4x faster this way.
Backstory: I just re-noticed we do this for our Debug MSAN builds, which has
had a serious wall-time slimming effect. I was about to restore it to my GN
MSAN builds when I realized, hey, maybe we should do this for all builds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2322753002
Review-Url: https://codereview.chromium.org/
2322753002
msarett [Thu, 8 Sep 2016 01:55:49 +0000 (18:55 -0700)]
Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGamma
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319293002
Review-Url: https://codereview.chromium.org/
2319293002
msarett [Thu, 8 Sep 2016 01:53:14 +0000 (18:53 -0700)]
Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of https://codereview.chromium.org/
2294993002/ )
Reason for revert:
Windows bots hate it when I upload new images.
Original issue's description:
> Add color xform support to SkWebpCodec
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2294993002
>
> Committed: https://skia.googlesource.com/skia/+/
828ed1777da74692d0c8a5834017929f5aedcc6b
TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2318253004
msarett [Thu, 8 Sep 2016 01:05:24 +0000 (18:05 -0700)]
Add color xform support to SkWebpCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2294993002
Review-Url: https://codereview.chromium.org/
2294993002
ethannicholas [Wed, 7 Sep 2016 20:37:16 +0000 (13:37 -0700)]
refactored SkSL VarDeclaration handling
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2312233002
Review-Url: https://codereview.chromium.org/
2312233002
halcanary [Wed, 7 Sep 2016 19:56:45 +0000 (12:56 -0700)]
android_skp_capture.sh
NOTRY=true
TBR=
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324543002
Review-Url: https://codereview.chromium.org/
2324543002
mtklein [Wed, 7 Sep 2016 19:26:53 +0000 (12:26 -0700)]
clang_linux: also build an MSAN libc++
This will be used by MSAN bots: build with -stdlib=libc++,
then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2324503002
Review-Url: https://codereview.chromium.org/
2324503002
msarett [Wed, 7 Sep 2016 19:03:53 +0000 (12:03 -0700)]
Delete SkColorSpace::gammaNamed() from public API
Move fGammaNamed to SkColorSpace_Base.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2318663003
Review-Url: https://codereview.chromium.org/
2318663003
egdaniel [Wed, 7 Sep 2016 18:56:59 +0000 (11:56 -0700)]
Merge building of program desc in Vulkan into one step
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2318143002
Review-Url: https://codereview.chromium.org/
2318143002
robertphillips [Wed, 7 Sep 2016 18:34:05 +0000 (11:34 -0700)]
Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 id:100001 of https://codereview.chromium.org/
2316593003/ )
Reason for revert:
Shader compilation failure
Original issue's description:
> Add GM/slide to simulate Android-style reveal clip
>
> Hopefully, this will let us play w/ geometric and shader-based solutions.
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2316593003
>
> Committed: https://skia.googlesource.com/skia/+/
ffac5c4aae18fc706e4077763c190a89c8507fb0
TBR=jvanverth@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2316303002
brianosman [Wed, 7 Sep 2016 18:30:47 +0000 (11:30 -0700)]
Add minimal support for readPixels in raster F16
Still doesn't support doing premul <-> unpremul conversions, but handles
the simple cases (which would previously always fail). Fixes the new gamut
gm (partially) in f16 config.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2321673002
Review-Url: https://codereview.chromium.org/
2321673002
msarett [Wed, 7 Sep 2016 18:23:28 +0000 (11:23 -0700)]
Use demux API in SkWebpCodec
* Necessary to read ICC profiles
* Will be necessary to implement animation
* Requires consolidated data with length
Doesn't affect decode performance (thought I believe
our performance tests only cover SkStreams with memory
bases).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2311793004
Review-Url: https://codereview.chromium.org/
2311793004
robertphillips [Wed, 7 Sep 2016 17:34:06 +0000 (10:34 -0700)]
Add GM/slide to simulate Android-style reveal clip
Hopefully, this will let us play w/ geometric and shader-based solutions.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2316593003
Review-Url: https://codereview.chromium.org/
2316593003
bsalomon [Wed, 7 Sep 2016 17:02:04 +0000 (10:02 -0700)]
Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.
Consolidates all flush actions into GrDrawingManager and makes GrContext::flush a passthrough.
Removes the unused and untested discard flush variation.
Replaces the indirect overbudget callback mechanism of GrResourceCache with a flag set by resource cache when it wants to flush that is checked after each draw by GrDrawContext.
Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating whether it triggered the
flush that just occurred.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2307053002
Committed: https://skia.googlesource.com/skia/+/
1dbb207babecdae8f1f74ed9d9900c73064df744
Review-Url: https://codereview.chromium.org/
2307053002
halcanary [Wed, 7 Sep 2016 16:05:25 +0000 (09:05 -0700)]
SkPDF: remove unused fallback clipping code
This code is untested and unnecessary.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2319653002
Review-Url: https://codereview.chromium.org/
2319653002
borenet [Wed, 7 Sep 2016 15:34:13 +0000 (08:34 -0700)]
Run install-sysroot script before 'gn gen' on PDFium bot
BUG=skia:5727
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2317013002
Review-Url: https://codereview.chromium.org/
2317013002