Jeremy Barton [Thu, 13 Sep 2018 23:04:39 +0000 (16:04 -0700)]
Remove the ActiveIssue attribute from a disabled-but-passing test (dotnet/corefx#32286)
The MultiComponentRdn test was indirectly fixed by switching from the
P/Invoke-based X500NameEncoder.OpenSslDecode to
X500NameEncoder.ManagedDecode.
Commit migrated from https://github.com/dotnet/corefx/commit/
29e9efb3e4639921c62a46b82e9d6edd2faa3e5c
Grant [Thu, 13 Sep 2018 22:20:39 +0000 (15:20 -0700)]
Change calls from string.IndexOf to string.Contains (CoreFX) (dotnet/corefx#32249)
* Update call sites
* More call sites
* Another callsite
* More call sites
* CR fixes - revert src/Common/src/CoreLib/*
* Spurious fix
* Revert string.Contains where platform may not be NetCore21
* nit
* More reverts
* More reverts
* More reverts
* Revert
* Remove comments
* Revert
Commit migrated from https://github.com/dotnet/corefx/commit/
6ffca612323448f1488a6c63b86b69611b4286d9
Steve Pfister [Thu, 13 Sep 2018 21:24:34 +0000 (17:24 -0400)]
Added InstanceDescriptor check back into DateTimeConverter.ConvertTo (dotnet/corefx#31558)
Commit migrated from https://github.com/dotnet/corefx/commit/
78933dea05bd0b2cd0714de018f7c6b363f65246
Marco Rossignoli [Thu, 13 Sep 2018 20:48:20 +0000 (22:48 +0200)]
Add retry policy to ProfileOptimization test (dotnet/corefx#31810)
* add retry policy
* add write test on profile file path location
* address PR feedback
* cleanup code
Commit migrated from https://github.com/dotnet/corefx/commit/
065bed2fb74ebed6798990e65b88e67c0b47429b
Viktor Hofer [Thu, 13 Sep 2018 20:45:37 +0000 (22:45 +0200)]
Make Image, Bitmap, Metafile and Icon serializable (dotnet/corefx#30817)
* Make Image, Bitmap, Metafile and Icon serializable
* Fix build error because of different namings on Unix & Windows
* Add Unix MemoryStream handling for serialization
* Simplify Icon deserialization logic
* Fix rename build break
* Fix build break again
* Add serialization tests for System.Drawing types
* Remove unnecessary null check in Icon
* Remove Debug fail invocations in Image deserialization
* Disable blob comparison for Drawing types
* Disable system.drawing.common binary formatter tests for uap since is a turd assembly
* Fix nano failures
* Fix typo in FindEncoderForFormat call
* Fix Windows test failures
* Fix unix deserialization where nativeImage pointer was not being set and update blobs
* Update metafile comment on why we skip it
Commit migrated from https://github.com/dotnet/corefx/commit/
11c54f3bd947b8ceb41b51440379c49cf777248f
Josh Free [Thu, 13 Sep 2018 20:38:24 +0000 (13:38 -0700)]
Add Ubuntu 18.10 (Cosmic Cuttlefish)
Add Ubuntu 18.10 to Microsoft.NETCore.Platforms
Fixes dotnet/corefx#32282
Commit migrated from https://github.com/dotnet/corefx/commit/
321a87d9dffb4de480599895f55afd4093bc6613
Jeremy Barton [Thu, 13 Sep 2018 20:30:34 +0000 (13:30 -0700)]
Read SSL_CERT_FILE contents before SSL_CERT_DIR contents
The OpenSSL commandline utility (openssl verify) uses the "single file" lookup
before the directory contents lookup in both OpenSSL 1.0.2 and 1.1.0. Normally,
this doesn't matter, as the contents between the two are normally not in conflict.
The certificates on SLES 15 and Fedora 28, however, seem to use the plain X509
data ("BEGIN CERTIFICATE") as the "by file" multi-PEM, and newly use
trust-specified certificates ("BEGIN TRUSTED CERTIFICATE") contents in the
directory lookup.
When a certificate gets loaded with explicit trust settings, any trust not
explicitly permitted is implicitly denied. Our X509Chain class uses the default
trust for the trust decision (X509_TRUST_DEFAULT), which means it does a
check for the "any extended key usage" trust. That purpose is not present
in the certificates we're seeing now, meaning we get
X509_V_ERR_CERT_REJECTED as the response from the chain, but the CLI
tool gets a successful response.
By changing the order to be "file first" we match the behavior of the CLI tool.
Commit migrated from https://github.com/dotnet/corefx/commit/
717c57fcb98460ed3d90955dcc9ef28a1371a23a
Geoff Kizer [Thu, 13 Sep 2018 19:09:20 +0000 (12:09 -0700)]
Merge pull request dotnet/corefx#32211 from jbhensley/huffman-test
Added additional unit test scenario to Huffman encoding tests
Commit migrated from https://github.com/dotnet/corefx/commit/
0a51fb5ff782f2f27ec4241feedfb90699de7361
Wes Haggard [Thu, 13 Sep 2018 17:18:04 +0000 (10:18 -0700)]
Update library-servicing document (dotnet/corefx#32267)
Add more information about AssemblyVersion
Commit migrated from https://github.com/dotnet/corefx/commit/
ddba280627d67badb8aa6954f6227952a05943fd
dotnet-maestro-bot [Thu, 13 Sep 2018 17:17:46 +0000 (10:17 -0700)]
Update CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26912-03, beta-26913-00, beta-26913-00, respectively (dotnet/corefx#32275)
Commit migrated from https://github.com/dotnet/corefx/commit/
18792ab9968a8d54150235215b767d4dde4f8af3
Filip Navara [Thu, 13 Sep 2018 16:19:12 +0000 (18:19 +0200)]
Optimize public key imports for OpenSSL and Common Crypto
* Optimize RSA and DSA key imports for Common Crypto and OpenSSL.
* Convert key imports to use ReadOnlySpan.
Commit migrated from https://github.com/dotnet/corefx/commit/
713420b9fbe2a86be3a8032c8185a7f5ef308290
Filip Navara [Thu, 13 Sep 2018 15:09:26 +0000 (17:09 +0200)]
Unify code for AttributeAsn and X501AttributeAsn
* Declare AttributeAsn.AttrValues as SetOf instead of encoding it manually.
* Replace X501AttributeAsn with AttributeAsn.
Commit migrated from https://github.com/dotnet/corefx/commit/
35320e086b5f159d74737558f4e3806c53dfaf8c
Jan Kotas [Thu, 13 Sep 2018 00:02:53 +0000 (17:02 -0700)]
Delete dead files (dotnet/corefx#32265)
Commit migrated from https://github.com/dotnet/corefx/commit/
bdd4e0bad42f02538b5d5163484caf8abeebc65f
Wes Haggard [Wed, 12 Sep 2018 22:37:37 +0000 (15:37 -0700)]
Merge pull request dotnet/corefx#32264 from AfsanehR/updateMasterVersion
Update assembly and package version for new API
Commit migrated from https://github.com/dotnet/corefx/commit/
09e413092dbde9ac573c7c53cd9c104b525e0468
Jeremy Barton [Wed, 12 Sep 2018 22:36:08 +0000 (15:36 -0700)]
Add SignerIdentifierType.NoSignature support to SignedCms
This also changes the zero-argument ComputeSignature and moves the PNSE
to later in the flow, since it is successful when the document was in implicit
NoSignature mode.
Commit migrated from https://github.com/dotnet/corefx/commit/
8cfcb3d75922db94d822080d76903c6316fc0665
Santiago Fernandez Madero [Wed, 12 Sep 2018 21:17:24 +0000 (14:17 -0700)]
Remove System.Buffers package (dotnet/corefx#32096)
* Remove System.Buffers package and harvest System.IO.Pipelines for ns1.3
* Run UpdateVSConfigurations
* Harvest Security.Cryptography.Cng ns1.3 and ns1.4 implementations
Commit migrated from https://github.com/dotnet/corefx/commit/
b09c098f2e0c7934dac8a4c7e38a5bf249a5b955
Grant [Wed, 12 Sep 2018 21:13:49 +0000 (14:13 -0700)]
Ref Assembly for MemoryExtensions.Contains (CoreFX) (dotnet/corefx#32176)
* Create methods on ref assembly
* Force rebuild
* Revert
* Update callsite for span
* Units
* CR fix
* Move Unit
Commit migrated from https://github.com/dotnet/corefx/commit/
559d0165a0f3a3e0981c89199b18ae02e52c084c
Afsaneh Rafighi [Wed, 12 Sep 2018 20:36:46 +0000 (13:36 -0700)]
update Assembly and package version in master branch
Commit migrated from https://github.com/dotnet/corefx/commit/
56b2fc177ab1924fdd3222f9c747e2e405bc6656
jbhensley [Wed, 12 Sep 2018 20:05:08 +0000 (13:05 -0700)]
Fix whitespace
Commit migrated from https://github.com/dotnet/corefx/commit/
a64edcab4735be20171206366ebeb878db0aac10
William Godbe [Wed, 12 Sep 2018 19:08:42 +0000 (12:08 -0700)]
Fix AssemblyVersion update instructions (dotnet/corefx#32200)
* Fix AssemblyVersion update instructions
* Add documentation for editing packageIndex.json
Commit migrated from https://github.com/dotnet/corefx/commit/
5104246d865d64b9bc501c5cbcf5dfd52486681a
Wes Haggard [Wed, 12 Sep 2018 16:11:25 +0000 (09:11 -0700)]
Merge pull request dotnet/corefx#32257 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreFx to preview1-26912-03 (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
a284d80f0efc13007d6fcfa61094b274f811b442
Atsushi Kanamori [Wed, 12 Sep 2018 14:33:54 +0000 (07:33 -0700)]
Make AttributeType virtual and add MakeGenericSignatureType (dotnet/corefx#32133)
Fixes https://github.com/dotnet/corefx/issues/31614
Fixes https://github.com/dotnet/corefx/issues/31798
Commit migrated from https://github.com/dotnet/corefx/commit/
88a076dcecd4e3f6a117f9fb929e756170c7c9b1
dotnet-maestro-bot [Wed, 12 Sep 2018 14:23:04 +0000 (07:23 -0700)]
Update CoreFx to preview1-26912-03
Commit migrated from https://github.com/dotnet/corefx/commit/
488967075b271ca467bc25cf29f7d6bbf81afdac
Filip Navara [Wed, 12 Sep 2018 14:13:00 +0000 (16:13 +0200)]
System.Security: Use RandomNumberGenerator.Fill (dotnet/corefx#32223)
* Use RandomNumberGenerator.Fill instead of creating RandomNumberGenerator objects.
* Remove unnecessary argument to AsSpan.
Commit migrated from https://github.com/dotnet/corefx/commit/
1657319e4c0e3beb5ed37bbf4bee8d0cd145c5fb
dotnet-maestro-bot [Wed, 12 Sep 2018 14:12:40 +0000 (07:12 -0700)]
Update CoreClr, CoreSetup to preview1-26912-04, preview1-26912-01, respectively (dotnet/corefx#32254)
Commit migrated from https://github.com/dotnet/corefx/commit/
5a06284ea6d32e8b0090c73711c9b8123e75e5df
dotnet-maestro-bot [Wed, 12 Sep 2018 10:12:07 +0000 (03:12 -0700)]
Update BuildTools, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03211-01, preview1-26911-04, beta-26912-00, beta-26912-00, respectively (dotnet/corefx#32242)
Commit migrated from https://github.com/dotnet/corefx/commit/
b326827fef31a3629f9419498ae4e85562ef5a54
Morgan Brown [Wed, 12 Sep 2018 04:57:52 +0000 (21:57 -0700)]
Build managed code and packages for WebAssembly/netcoreappaot (dotnet/corefx#32045)
Adds support for a WebAssembly netcoreappaot configuration for building managed libraries and packages. This is enough to produce a package of libraries that CoreRT's WebAssembly implementation can consume.
Commit migrated from https://github.com/dotnet/corefx/commit/
2b868f80c307a514dfafb7eb166dad3dbc2ed26b
David Shulman [Wed, 12 Sep 2018 03:18:16 +0000 (20:18 -0700)]
Disable nt auth tests on Nano (dotnet/corefx#32247)
The recent PR dotnet/corefx#32146 added these new tests. But they fail on Nano SKU because HttpListener is not supported since http.sys is not present on Nano.
Commit migrated from https://github.com/dotnet/corefx/commit/
9772bdfd5f61ab6587cdc93efc51f6e0101b24bc
Santiago Fernandez Madero [Wed, 12 Sep 2018 01:54:33 +0000 (18:54 -0700)]
Add conditional attribute tests to ensure we're always running conditional tests (dotnet/corefx#32241)
* Add conditional attribute tests to ensure we're always running conditional tests
* Add licence headers
* Remove fixture and use static fields
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
9c847e3b1bbc3a0e5b27a0ca3125937a83eff929
Maryam Ariyan [Wed, 12 Sep 2018 00:09:17 +0000 (20:09 -0400)]
Update json file adding Mojave 10.14 (dotnet/corefx#32244)
Update json file adding Mojave 10.14
Commit migrated from https://github.com/dotnet/corefx/commit/
e47c59aecc1d12e571aa382b06d4e1b03e88b9b8
Viktor Hofer [Tue, 11 Sep 2018 23:23:06 +0000 (01:23 +0200)]
Update VS 2017 Command Line install instructions
Commit migrated from https://github.com/dotnet/corefx/commit/
60a6bbdd646b214ea71b5bfbb0a55eb41eb5eae2
Coen Munckhof [Tue, 11 Sep 2018 22:14:53 +0000 (00:14 +0200)]
Update Base64Encoder.cs (dotnet/corefx#32189)
fix typo in documentation
Commit migrated from https://github.com/dotnet/corefx/commit/
d6ebd1b9b568fe8b03b527bced05ab0b194e548e
Geoff Kizer [Tue, 11 Sep 2018 22:07:21 +0000 (15:07 -0700)]
HttpClient: add simple nt auth tests (dotnet/corefx#32212)
* add basic nt auth tests
* address review feedback and disable tests on non-Windows platforms
Commit migrated from https://github.com/dotnet/corefx/commit/
860509c967c8566b36fc134b5ea001489e2289b3
Jan Kotas [Tue, 11 Sep 2018 15:54:34 +0000 (08:54 -0700)]
Delete moved files, port cleanup from CoreCLR and CoreRT
Commit migrated from https://github.com/dotnet/corefx/commit/
e42d3f741af98d9292ac0a9bdd2a139336ba53a4
Tomas Weinfurt [Tue, 11 Sep 2018 20:31:53 +0000 (13:31 -0700)]
detect permission problem and handle exception accordingly (dotnet/corefx#32214)
Commit migrated from https://github.com/dotnet/corefx/commit/
50ff25e9198f3737fa51bcc62c2941f0910bb809
dotnet-maestro-bot [Tue, 11 Sep 2018 16:46:06 +0000 (09:46 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26911-04, preview1-26911-04, preview1-26911-01, beta-26911-00, beta-26911-00, respectively (dotnet/corefx#32213)
Commit migrated from https://github.com/dotnet/corefx/commit/
fb01f93d5d6716f4c66708c5bc23a01cf6042e1d
Andrii Kurdiumov [Tue, 11 Sep 2018 10:01:25 +0000 (16:01 +0600)]
Verify that multiplication is also match IEEE expectations on the optimizations
Commit migrated from https://github.com/dotnet/corefx/commit/
360d4d3f63ff5bee882ad5dcdc5d003a35e0ee6a
Andrii Kurdiumov [Sun, 9 Sep 2018 16:50:53 +0000 (22:50 +0600)]
Reduce amount of compare operations and add comments
Commit migrated from https://github.com/dotnet/corefx/commit/
d84177294fec054ff5f1a02780114a5a87eab4e5
Andrii Kurdiumov [Sun, 9 Sep 2018 05:19:43 +0000 (11:19 +0600)]
Sync results from optimized and non-potimized versions
Commit migrated from https://github.com/dotnet/corefx/commit/
8e058d7a1e5b12c4aef75d0378adbab9f953f26d
Andrii Kurdiumov [Fri, 31 Aug 2018 22:34:23 +0000 (04:34 +0600)]
Add explicit testing of corner cases
Commit migrated from https://github.com/dotnet/corefx/commit/
7cc6531dc0ba2a42131e739cf02b37d5e13e23af
Andrii Kurdiumov [Sat, 21 Jul 2018 10:30:25 +0000 (13:30 +0300)]
Add comment with explanantion why implementation don't use simpler formula
Commit migrated from https://github.com/dotnet/corefx/commit/
758df390c79f4408db5d143b74ecf070a4ef9ba4
Andrii Kurdiumov [Sat, 21 Jul 2018 10:28:27 +0000 (13:28 +0300)]
Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
3102789301f35f9f7a6b0f0bd8006f7bbff92cf7
Andrii Kurdiumov [Sat, 21 Jul 2018 08:40:38 +0000 (11:40 +0300)]
Sync validation logic of full Complex division with division by double
For validation purposes Complex / double translated to Complex / Complex
to pass tests with existing test data
Commit migrated from https://github.com/dotnet/corefx/commit/
7c486d62915bb84ad0e5c7f5a89e927cb5c5ae9c
Andrii Kurdiumov [Sat, 2 Jun 2018 12:17:50 +0000 (18:17 +0600)]
Addede mixed Complex/double arithmetic operators to Complex
Implementation of simplified cases for performing math operations on the Complex
Closes dotnet/corefx#15927
Commit migrated from https://github.com/dotnet/corefx/commit/
68c127e5017500d24d6fb6ddfe6f7d0c31636c09
Michal Strehovský [Tue, 11 Sep 2018 13:43:35 +0000 (15:43 +0200)]
Add ThrowNoDefaultConstructorForCollectionException (dotnet/corefx#32132)
This method is referenced from the code generated by SerializationAssemblyGenerator on .NET Native.
Without this method, valid user code might end up with following warning:
```
MSBUILD : warning : ILTransform : warning ILT0003: Method 'Type647.ReadArrayOfstringFromXml(XmlReaderDelegator, XmlOb
jectSerializerReadContext, XmlDictionaryString, XmlDictionaryString, CollectionDataContract)' will always throw an exception due to the missing method 'XmlObjectSerializerReadContext.ThrowNoDefaultConstructorForCollectionException(Type)'
in assembly 'System.Private.DataContractSerialization'. There may have been a missing assembly, or a dependency on a more recent Windows SDK release. [d:\dd\pn1\src\QA\ToF\tests\FX\Conformance\System.Runtime.Serialization.Json\4.0.0.0\DataContractJsonSerializerTests.csproj]
```
References to this method were added in changeset 1530459 on Project N TFS side. I wasn't able to find any history of SGuy adding this code on the CoreFX side. So I assume this never worked - we just never noticed the compiler warning.
Commit migrated from https://github.com/dotnet/corefx/commit/
796fa98646559be01b9a14e37be0eb0a1ee92d1f
jbhensley [Tue, 11 Sep 2018 00:21:11 +0000 (17:21 -0700)]
Added test to emit EOS in the middle of an otherwise valid sequence.
Commit migrated from https://github.com/dotnet/corefx/commit/
673c537c39f69df985e1f42a3861d57bd431764d
Jiayi Yu [Mon, 10 Sep 2018 23:06:40 +0000 (16:06 -0700)]
Support hexBinary type (dotnet/corefx#32141)
*Port a few functions from full framework to support read/write hexbinary type and add tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8d65bd36a6d3d3cfdf1aa32cbb8c45cce25d9c95
Filip Navara [Mon, 10 Sep 2018 21:42:56 +0000 (23:42 +0200)]
Remove last usages of DerSequenceReader/DerEncoder/AsnSerializer
* Convert remainder of S.S.C.X509Certificates to use ASNXML/AsnReader/AsnWriter instead of DerSequenceReader/DerEncoder.
* Convert X509ExtensionAsn to code generator. Remove last usages of ASN serializer from code base.
* Remove DerEncoder, DerSequenceReader and related tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
4630572a4af4326f2d8bf983a5dc346d25c5238b
Geoff Kizer [Mon, 10 Sep 2018 21:37:05 +0000 (14:37 -0700)]
Merge pull request dotnet/corefx#32146 from geoffkizer/ntauthfix
fix nt auth handling when we receive a 401 after auth completes
Commit migrated from https://github.com/dotnet/corefx/commit/
2c8be59ed4405dbdd91777f79763cb2f1384729e
Karel Zikmund [Mon, 10 Sep 2018 20:35:34 +0000 (13:35 -0700)]
Update Reflection ownership
Commit migrated from https://github.com/dotnet/corefx/commit/
042981c23df0d55fb7b837450a2679353984d92f
William Godbe [Mon, 10 Sep 2018 18:03:30 +0000 (11:03 -0700)]
Add document for servicing libraries (dotnet/corefx#32168)
* Add document for servicing libraries
* Address feedback
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
906033ace5eaf28eb671bcdd2ce3f262595a9a85
dotnet-maestro-bot [Mon, 10 Sep 2018 17:38:24 +0000 (10:38 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26910-04, preview1-26910-04, preview1-26910-01, beta-26910-00, beta-26910-00, respectively (dotnet/corefx#32191)
Commit migrated from https://github.com/dotnet/corefx/commit/
2c16175aaa2bcd5e1144ea8a25e094e092fa4479
Paulo Janotti [Sat, 8 Sep 2018 18:26:00 +0000 (11:26 -0700)]
Remove the known issue for macOS
As expected the issue on macOS was fixed by removing the usage of coverlet.tracker.dll in coverlet.msbuild 2.3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
52121c8d0376dcb0f69570e793b6d40232ccabf9
dotnet-maestro-bot [Sat, 8 Sep 2018 15:31:29 +0000 (08:31 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26908-04, preview1-26908-04, preview1-26908-01, respectively (dotnet/corefx#32183)
Commit migrated from https://github.com/dotnet/corefx/commit/
12b8c4173212e087eeb6e0e07400fc070801aa68
Wes Haggard [Sat, 8 Sep 2018 03:23:54 +0000 (20:23 -0700)]
Merge pull request dotnet/corefx#31824 from ViktorHofer/portableRemove
Remove portable- targetgroups
Commit migrated from https://github.com/dotnet/corefx/commit/
ad2723fbd98b76fcb52637fa3a213b1a40429d44
Paulo Janotti [Sat, 8 Sep 2018 03:02:01 +0000 (20:02 -0700)]
Get coverlet perf gains and remove copy of tracker (dotnet/corefx#32172)
Commit migrated from https://github.com/dotnet/corefx/commit/
6912105856e9da37b298a14b469ffb871326860b
dotnet-maestro-bot [Sat, 8 Sep 2018 02:49:42 +0000 (19:49 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03208-01, preview1-26908-01, preview1-26908-01, preview1-26907-05, respectively (dotnet/corefx#32173)
Commit migrated from https://github.com/dotnet/corefx/commit/
7e0cbf1f27d8420a3f89f7a293de145f1cd26cd2
Wes Haggard [Sat, 8 Sep 2018 02:35:08 +0000 (19:35 -0700)]
Merge pull request dotnet/corefx#32177 from weshaggard/UpdateSDK
Update to released SDK
Commit migrated from https://github.com/dotnet/corefx/commit/
8971f384e0c9bb967386a3a9e64b97fb886ab3d2
Wes Haggard [Sat, 8 Sep 2018 01:21:48 +0000 (18:21 -0700)]
Merge pull request dotnet/corefx#32148 from weshaggard/HarvestNSRefs
Harvest the netstandard2.0 refs for the crypto libraries
Commit migrated from https://github.com/dotnet/corefx/commit/
e62249f4e10c35a0cffe13044929c030bd1d590a
Wes Haggard [Sat, 8 Sep 2018 01:15:25 +0000 (18:15 -0700)]
Update to released SDK
As part of this we need to disable a roslyn analyzer to workaround
https://github.com/dotnet/roslyn-analyzers/issues/1804.
Commit migrated from https://github.com/dotnet/corefx/commit/
4865c849d582e24478f08a224aa1f915bfcfbcde
Tomas Weinfurt [Fri, 7 Sep 2018 23:18:14 +0000 (16:18 -0700)]
client side ALPN for OSX (dotnet/corefx#31905)
* ALPN client side for OSX
* rework code to use new API introduced in 10.13.4 + feedback from review
* reviews feedback round 2
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
219ea1bea0f12660398a75160b1d68c2885696fd
Luqun Lou [Fri, 7 Sep 2018 23:01:25 +0000 (16:01 -0700)]
Add Public API Marshal.GetEndComSlot and Marshal.IsTypeVisibleFromCom (dotnet/corefx#31815)
Commit migrated from https://github.com/dotnet/corefx/commit/
0ae9863e1db8da810a34a28951e1d4f45f316fce
Tomas Weinfurt [Fri, 7 Sep 2018 22:40:47 +0000 (15:40 -0700)]
minimal support for serial port on Linux. part 2. (dotnet/corefx#30903)
* minimal support for serial port on Linux
* feedback from review
* rename SerialStream -> SerialStream.Windows
* some fixes and improvements
Commit migrated from https://github.com/dotnet/corefx/commit/
ed4e3eafae1f454011732cadf734060c8e262c59
Wes Haggard [Fri, 7 Sep 2018 21:36:05 +0000 (14:36 -0700)]
Merge pull request dotnet/corefx#32137 from weshaggard/FixBuildingProjectRefsInVS
Fix building project references in VS
Commit migrated from https://github.com/dotnet/corefx/commit/
161433fc8eb87c0706d18a2f25af5441c7cea696
Filip Navara [Fri, 7 Sep 2018 21:21:26 +0000 (23:21 +0200)]
Avoid unnecessary Oid lookups in AsnReader
* Use `new Oid(value, null)` in AsnReader to let FriendlyName be populated on demand and remove the skipFriendlyName parameter from ReadObjectIdentifier.
* Remove the AsnSerializer support for PopulateFriendlyName(=false) as there's no option anymore.
Commit migrated from https://github.com/dotnet/corefx/commit/
a0bfefddf0fba1244fefb58ae79cf56a1f853629
Wes Haggard [Thu, 6 Sep 2018 22:25:16 +0000 (15:25 -0700)]
Harvest the netstandard2.0 refs for the crypto libraries
The crypto libaries currently have a frozen API surface for
netstandard2.0 because they are either inbox or harvesting
older platforms that support that API surface. Given that we
should simply harvest the NS references to avoid them from adding
apis they don't support everywhere.
System.Security.Cryptography.Xml depends on System.Security.Cryptography.Pkcs
for netstandard build so we need to restore it to the targeting pack.
Commit migrated from https://github.com/dotnet/corefx/commit/
c4d179a9cb721973ebe1d11f2d253f606ef4b4d5
Tanner Gooding [Fri, 7 Sep 2018 15:36:41 +0000 (08:36 -0700)]
Fixing up the UTF8Formatter and some tests to properly handle -0.0
Commit migrated from https://github.com/dotnet/corefx/commit/
e328f2b8bb3d7f69c921d8e422ace26b7fd9182a
dotnet-maestro-bot [Fri, 7 Sep 2018 13:54:28 +0000 (06:54 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26907-04, preview1-26907-04, preview1-26907-01, beta-26907-00, beta-26907-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
9fca37a2cbeb0eb7da54f24dfa07a7af9e2af418
Viktor Hofer [Fri, 7 Sep 2018 19:08:02 +0000 (21:08 +0200)]
Disable failing IO PathFeatures tests on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
99aa6e69c24a39d6b7588bc0ce29207267e92afc
Viktor Hofer [Fri, 7 Sep 2018 18:00:55 +0000 (20:00 +0200)]
Fix apartment tests for netfx due to differnet file extension
Commit migrated from https://github.com/dotnet/corefx/commit/
317ddd17e185af36888d487a4cda935470e2186b
Viktor Hofer [Fri, 7 Sep 2018 15:30:11 +0000 (17:30 +0200)]
Update XUnitExtensions
Commit migrated from https://github.com/dotnet/corefx/commit/
f553bbc1642c7ddf1d4015964d1302bb9af8fddf
Filip Navara [Fri, 7 Sep 2018 17:59:36 +0000 (19:59 +0200)]
Convert [DSA/RSA/Ecc]SecurityTransforms and X509SignatureGenerators to new ASN.1 APIs
This changes a lot of types designed for AsnSerializer to use the AsnXml code generator, and moves a number of those types from S.S.C.Algorithms to Common because the SecurityTransforms types are dual-compiled.
The workflow is similar to:
* Change all of the SecurityTransforms types to use the new types added during the key import/export feature.
* Change those types to use AsnXml generated code instead of AsnSerializer
* Move the types to Common source to fix S.S.C.X509Certificates build breaks
* Now that the types are already included in S.S.C.X509Certificates, make X509SignatureGenerator types use them, too.
Commit migrated from https://github.com/dotnet/corefx/commit/
a0cfc0492df974ebb2b9293e4d5640e1c1505263
Alfred Rossi [Fri, 7 Sep 2018 15:18:30 +0000 (11:18 -0400)]
Fix incorrect IEEE conversion buffer size for ECDsaCmsSignature.
For EC curves with a keysize which is not a multiple of 8 the calculation under-allocated.
The most likely culprit is secp521r1.
Commit migrated from https://github.com/dotnet/corefx/commit/
775c9f1415be3403864fe2804a9c5e16074d2d68
Geoff Kizer [Fri, 7 Sep 2018 03:54:06 +0000 (20:54 -0700)]
Merge pull request dotnet/corefx#32043 from geoffkizer/huffmantests
Fix Huffman decoding issue and add Huffman decoding tests
Commit migrated from https://github.com/dotnet/corefx/commit/
1b89c108d90f197a477ac8b79a4b8e35ac59b44d
dotnet-maestro-bot [Fri, 7 Sep 2018 03:32:29 +0000 (20:32 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26907-01, preview1-26907-01, preview1-26906-05, respectively (dotnet/corefx#32149)
Commit migrated from https://github.com/dotnet/corefx/commit/
032cc324f9f3c6d6fee7ca01e7aa8e3a4969deb9
Paulo Janotti [Fri, 7 Sep 2018 03:03:02 +0000 (20:03 -0700)]
Missed renamed file for coverage runs (dotnet/corefx#32151)
Commit migrated from https://github.com/dotnet/corefx/commit/
5d561e3bcf84551a9544007400af2fda803e405e
Jeremy Kuhne [Fri, 7 Sep 2018 01:11:06 +0000 (18:11 -0700)]
Add perf tests to System.IO (dotnet/corefx#31552)
* Add perf tests to System.IO
Add tests for measuring format writes for StreamWriter.
* Add a test validating dispatching of format calls when overridden.
Commit migrated from https://github.com/dotnet/corefx/commit/
1e1f421c8e57cbd317800e0a10287488bb05c808
Jeremy Kuhne [Fri, 7 Sep 2018 00:35:52 +0000 (17:35 -0700)]
Fix extract out of directory (dotnet/corefx#32127)
* Fix extract out of directory
Without ensuring a trailing directory separator you cannot compare paths for nesting. `/Foo/Bar` does not contain `/Foo/Barber`, but does contain `/Foo/Bar/Bell`. This adds the separator and tests.
* Skip new test on NetFX
Commit migrated from https://github.com/dotnet/corefx/commit/
a0fcd23ace1c8d692988cd0da4391cf7bf5e0ce6
Geoff Kizer [Thu, 6 Sep 2018 23:37:24 +0000 (16:37 -0700)]
fix typos
Commit migrated from https://github.com/dotnet/corefx/commit/
8e8a58be46c3c86452f5552ab861e59aef34db98
spshant [Thu, 6 Sep 2018 22:15:10 +0000 (15:15 -0700)]
Merge pull request dotnet/corefx#32128 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
d349e8d12df38d2e77bbbf59659f1b07e56cf9dd
Geoff Kizer [Thu, 6 Sep 2018 22:07:15 +0000 (15:07 -0700)]
fix issue
Commit migrated from https://github.com/dotnet/corefx/commit/
4225461e4ef5ad802e491a4ffc2e231ea604e8cc
Geoff Kizer [Thu, 6 Sep 2018 22:01:53 +0000 (15:01 -0700)]
fix tests to use Span
Commit migrated from https://github.com/dotnet/corefx/commit/
c77e291abc15e646d5223c4dc84f547f9858f923
Geoff Kizer [Thu, 6 Sep 2018 21:29:41 +0000 (14:29 -0700)]
use Span
Commit migrated from https://github.com/dotnet/corefx/commit/
1a852933092cce0e6f8be6c34457b1c509965ce9
Geoff Kizer [Fri, 31 Aug 2018 05:50:18 +0000 (22:50 -0700)]
fix Huffman decoding issue and add Huffman decoding tests
Commit migrated from https://github.com/dotnet/corefx/commit/
e5388b2fd7f9ab29800426f843b0c026b49ba7e4
Geoff Kizer [Thu, 6 Sep 2018 20:54:19 +0000 (13:54 -0700)]
fix ntlm auth: don't drain when we receive a 401 after auth completes
Commit migrated from https://github.com/dotnet/corefx/commit/
09f7b70e0eb3361847f4e13a8ee14aa3b1609a1f
Fei Peng [Tue, 4 Sep 2018 22:56:42 +0000 (15:56 -0700)]
Rename CarryLessMultiply to CarrylessMultiply
Commit migrated from https://github.com/dotnet/corefx/commit/
749d932b928ab2125cf2b98473a1bf4cde31ccd0
Viktor Hofer [Thu, 23 Aug 2018 22:46:31 +0000 (00:46 +0200)]
Make System.ValueTuple full facade assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
12ea7a38de4319a1c4d697981cd4aaf5af1ca00b
Wes Haggard [Thu, 6 Sep 2018 17:21:09 +0000 (10:21 -0700)]
Fix building project references in VS
For corefx project builds we rely on passing the configuration
property to project references so the correct configuration can
be selected. However when building in VS it clears that property
for some reason. To fix this we are going to explicitly set
ShouldUnsetParentConfigurationAndPlatform=false for our projects
when we annotate them to prevent them from being unset.
Commit migrated from https://github.com/dotnet/corefx/commit/
ad08052b1626557bb5f901014163378cfbff20df
Viktor Hofer [Fri, 17 Aug 2018 14:20:21 +0000 (16:20 +0200)]
Remove portable- targetgroups
Commit migrated from https://github.com/dotnet/corefx/commit/
98ac84426d99fdf61dcea78dfe8663c666095822
dotnet-maestro-bot [Thu, 6 Sep 2018 13:02:29 +0000 (06:02 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
587b3ecb52c261e0f27b711f303f25a7c93adf11
dotnet-maestro-bot [Wed, 5 Sep 2018 17:37:34 +0000 (10:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03205-01, preview1-26905-04, preview1-26905-03, preview1-26905-03, beta-26905-00, beta-26905-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
219a6c71c80ba8b5b06a2a767121a49930f38cd7
Krzysztof Wicher [Wed, 5 Sep 2018 21:07:59 +0000 (14:07 -0700)]
Update TCFullEndElement.cs (dotnet/corefx#32107)
Commit migrated from https://github.com/dotnet/corefx/commit/
f78adfa78f388972e5d64a68187dd540c219f2f6
Wes Haggard [Wed, 5 Sep 2018 21:04:47 +0000 (14:04 -0700)]
Merge pull request dotnet/corefx#31856 from jnm2/document_stateless_struct_breaking_change_rule
Document breaking change rule for stateless structs
Commit migrated from https://github.com/dotnet/corefx/commit/
b1c02c9558c9c2d4b667f372a3f48d8b6a9c2421
jnm2 [Tue, 21 Aug 2018 00:49:36 +0000 (20:49 -0400)]
Document breaking change rule for stateless structs
Commit migrated from https://github.com/dotnet/corefx/commit/
7444297ba077452d87bbbc5a4e5aab38069e2a54
Tanner Gooding [Sun, 26 Aug 2018 02:04:10 +0000 (19:04 -0700)]
Enabling some skipped math and mathf tests
Commit migrated from https://github.com/dotnet/corefx/commit/
5d7f2469f4ef37e6bc6846f85d9ea55570002c8f
Filip Navara [Wed, 5 Sep 2018 14:27:22 +0000 (16:27 +0200)]
Convert GeneralNameAsn to ASNXML generation
This changes the GeneralNameAsn type and all of its field types to ASNXML generated code, fixing the lack of tags on EdiPartyNameAsn in the process.
It also replaces the manual reading of GeneralName in AppleAsnFormatter, reducing the use of the legacy DerSequenceReader type.
Commit migrated from https://github.com/dotnet/corefx/commit/
3e817a4dbed0776dff7f91723906e95237892c0e
Dan Moseley [Wed, 5 Sep 2018 02:44:42 +0000 (19:44 -0700)]
Make flaky serialport test OuterLoop (dotnet/corefx#32104)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a3202082dfa74cd0c47dec1c0d2a8ab44d5fa2c
Marco Rossignoli [Tue, 4 Sep 2018 22:35:41 +0000 (00:35 +0200)]
Add System.Diagnostics.PerformanceData namespace (dotnet/corefx#31474)
* move System.Diagnostics.PerformanceData from netfx
* updates
* use type aliases, fix style, cleanup
* remove CAS attributes
* nit: extralines
* Add tests
* update tests
* update tests
* update tests,use type aliases, cleanup
* address PR feedback
* address some of PR feedback
* address some of PR feedback
* address some of PR feedback
* address PR feedback
* added retry/dispose
* update tests
* try to run new test in isolated process
* revert changes to other tests, add retry on new test
* fix netfx test fail, add comments
Commit migrated from https://github.com/dotnet/corefx/commit/
610e9c82ed930e7473e478ecb96e000a32ff7908
Dan Moseley [Tue, 4 Sep 2018 22:21:28 +0000 (15:21 -0700)]
Fix ServiceController name population perf (dotnet/corefx#32072)
* Fix ServiceController name population perf
* Split tests
* Remove dead field
* Remove new use of DangerousGetHandle
* SafeHandle all the things!
* VSB dotnet/corefx#1
* VSB dotnet/corefx#2
* Fix GLE
* Initialize machineName in ctor
* Test for empty name ex
* Null names
* Inadvertent edit
* Unix build
* Move interop into class
* Reverse SafeHandle for HAllocGlobal
* Fix tests
* Disable test for NETFX
* CR feedback
* Pattern matching on VSB
* Direct call
* typo
Commit migrated from https://github.com/dotnet/corefx/commit/
76c8587e935fb501d57b10de44826e1f99b69236
Jeremy Barton [Tue, 4 Sep 2018 19:53:06 +0000 (12:53 -0700)]
Add hybrid support for OpenSSL 1.0 and 1.1
This changes the functional code to use OpenSSL 1.1 API in the places where the API changed. "apibridge" provides equivalent methods for the OpenSSL 1.0 environment.
The following configurations have been tested:
* Non-portable against OpenSSL 1.0
* Non-portable against OpenSSL 1.1
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.1
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.1
In opensslshim, the PER_FUNCTION_BLOCK macro style has been broken up into a named purposes:
* REQUIRED_FUNCTION(fn)
* API that we use unconditionally, regardless of version
* Formerly PER_FUNCTION_BLOCK(fn, true)
* NEW_REQUIRED_FUNCTION(fn)
* API that we use unconditionally in paths that only exist against OpenSSL 1.1, is not probed for when the runtime is 1.0
* LIGHTUP_FUNCTION(fn)
* API that might not exist, must be probed with API_EXISTS checks before being utilized
* Formerly PER_FUNCTION_BLOCK(fn, false)
* FALLBACK_FUNCTION(fn)
* API that is required on OpenSSL 1.1, and when not found will bind to a method named local_#fn in the shim library
* RENAMED_FUNCTION(fn,oldfn)
* Handles a rename with no signature change from oldfn to newfn, binds appropriately based on the runtime library.
* LEGACY_FUNCTION(fn)
* API that we use unconditionally in paths that only exist against OpenSSL 1.0, is not probed for when the runtime is 1.1.
Two new #defines are available, but ideally need no further usage:
* NEED_OPENSSL_1_0
* Defined when building portable, or on non-portable when the headers are OpenSSL 1.0
* NEED_OPENSSL_1_1
* Defined when building portable, or on non-portable when the headers are OpenSSL 1.1
Commit migrated from https://github.com/dotnet/corefx/commit/
901ff58aee521984e8791f9f7d51fabfd31f910e