Lars Knoll [Tue, 16 Oct 2012 13:37:31 +0000 (15:37 +0200)]
More conversions to new calling convention
Change-Id: I6002715cc3f5c22d90a9ade6ae2152c2c3c8ebb2
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 13:10:47 +0000 (15:10 +0200)]
Converting more methods to the new calling convention
Change-Id: I5199a9e5439644cc259f131c8b0ba6a941989615
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 12:17:36 +0000 (14:17 +0200)]
Converting more runtime methods.
Change-Id: I9e5d73004e377cff2819cb82240d50e73c8bda94
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 11:40:02 +0000 (13:40 +0200)]
Convert Value constructors to new calling convention
Change-Id: I433f72666499e660618b061cfcf3407f5f9bb166
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 11:13:44 +0000 (13:13 +0200)]
Convert string literals to new calling convention
Change-Id: I8dd6b1975351c36230ed512c55944c9b748ca38b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 10:56:50 +0000 (12:56 +0200)]
Further convert runtime methods to the new calling convention
Value bassed argument passing.
Change-Id: I95e49ae301221e36946c2ce4f25081461513a6bb
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 16 Oct 2012 10:27:14 +0000 (12:27 +0200)]
Start changing signatures of the runtime to being value based.
Value's should be passed by value and returned by value between JIT
and the JS runtime. This should give us better performance on
x86_64 and ARM.
Change-Id: I4fa286c6164f0143adb72d07c737fa273c8a5eb6
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Tue, 16 Oct 2012 08:19:23 +0000 (10:19 +0200)]
Optimize boolean test
Use != 0 instead of == 1, as it allows for a more efficient encoding
on ia32/amd64 (using test eax, eax)
Change-Id: I7a29139d8e6e9b843bf8df6f20f5ef7cc9b2e8cc
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Tue, 16 Oct 2012 11:11:59 +0000 (13:11 +0200)]
Get rid of compiler warning.
Change-Id: I3b92819ac1bf8e4f98c266d4136ed05235e06faf
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Mon, 15 Oct 2012 20:32:06 +0000 (22:32 +0200)]
Do not return booleans from methods called by JIT generated code
For a boolean, only one byte of the the value returned in the
register is defined. But the compiled code afterwards does a
32 bit comparison with 0 or 1, leading to random failures
depending on compiler optimisation settings.
Instead we now consistently return uints, and all boolean
tests in the JIT generated code have to be done as
branch32((Not)Equal, register, TrustedImm32(0)). Never
compare against 1 to avoid potential problems.
Change-Id: I9d7545dd6705bca82dc49f1eedb329fffb86cdb7
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Mon, 15 Oct 2012 18:34:21 +0000 (20:34 +0200)]
Clean up callee save register push/pop code to have less #ifdefs
Change-Id: Id4286de7716d7093473ab9e5d2e5d95be8f69efe
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Mon, 15 Oct 2012 10:45:48 +0000 (12:45 +0200)]
Disable fastmalloc
Change-Id: I9b65c0b237463b81b04d8745476a5c002ea9af12
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Fri, 12 Oct 2012 12:56:21 +0000 (14:56 +0200)]
Fix: change struct JSGlobalData into a class and fix forward decls.
Change-Id: I3d414282cafd51e813dc9e53cc2f5b1d9163efb3
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Fri, 12 Oct 2012 12:31:50 +0000 (14:31 +0200)]
Fix for LLVM 3.2.
Change-Id: I79dfe5e41267fabbddea7a753685a864de5979cd
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Fri, 12 Oct 2012 12:31:29 +0000 (14:31 +0200)]
Fix darwin-ism to make it compile on Macs.
Change-Id: I7a018ad552764914085e3c89e9ea7e582ca230a7
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Sat, 13 Oct 2012 13:49:44 +0000 (15:49 +0200)]
[moth] Add missing IR::AluOp -> ALUFunction mappings
Change-Id: Icf5d15579ef05a6b6fb46fbcb40abd69fadb7898
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Sat, 13 Oct 2012 13:45:35 +0000 (15:45 +0200)]
Fix build on ia32
Use the q constraint instead of r to ensure we get a register valid
for seto. This should also work on amd64, but I haven't tested.
Change-Id: I6da5916db0f35a05a709a127c0dd5cb134284a79
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 12:30:52 +0000 (14:30 +0200)]
Silence some compiler warnings
Tweaks taken from upstream :)
Change-Id: Iae73ec0aa35c2e2a0e78422e0636ac7d99c8303c
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 12:24:45 +0000 (14:24 +0200)]
Prospective Mac build fix
Define ahead of time which "feature" set we want, i.e. no LLINT/DFG/JIT
code but only ENABLE(ASSEMBLER). Otherwise Platform.h will make a choice
for us depending on the platform.
Change-Id: I372dc690ecbc624e9d589f6f10078a7647fcb570
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Erik Verbruggen [Fri, 12 Oct 2012 11:45:35 +0000 (13:45 +0200)]
Fix LLVM build
Change-Id: I7ae00a5e90087182d9f7d939db0a036c120e3b9b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 10:15:10 +0000 (12:15 +0200)]
Prospective Mac OS X build fix
open_memstream is not supported beyond Linux it seems, so do the
symbol replacing disassembly printing only on Linux.
Change-Id: I1eff6db9e10bd0ebbc06e967a61f998ee42438a8
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 08:12:24 +0000 (10:12 +0200)]
Add missing license headers
Change-Id: I59d602a0f2c1fefb03994ed32a3d697b176791ff
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 07:23:17 +0000 (09:23 +0200)]
Clean up arithmetic operation calls
Don't repeat calls to generateFunctionCall but use a helper macro to
get the name.
Change-Id: I394b1980cbd67f3ca94fc41402de2d5b99c45016
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Fri, 12 Oct 2012 06:52:51 +0000 (08:52 +0200)]
Store booleans as 32 bit integers
The old code was giving valgrind warnings, because
we loaded the boolean (1 byte) as a 32 bit integer.
Instead simply store all booleans as 32 bit ints
to avoid the warnings.
Change-Id: I46c7f9fc9d8dfe52afd9bab2dbab8923aaa630f8
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 12 Oct 2012 06:51:02 +0000 (08:51 +0200)]
Send all debug output to stderr
qDebug() was used for part of the logging, which
uses stderr. Send everything else there as well.
Change-Id: I363dff3d2e4dd6f95bf0347f1df589ae2528fd32
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 12 Oct 2012 06:48:33 +0000 (08:48 +0200)]
Handle Integer_Type in a switch statement
Change-Id: I8e00636f0896cec7d18d645dd70db8a100bf5560
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 11 Oct 2012 19:19:08 +0000 (21:19 +0200)]
Remove almost all uses of __qmljs_init_string
Change-Id: I88130ec39958c75b70d898a352423908ac2ef1d4
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 11 Oct 2012 14:50:37 +0000 (16:50 +0200)]
Remove __qmljs_init_(number|boolean)
Change-Id: Iae59dfea39e44931bb2f7a6436bd2f1491bbf843
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 11 Oct 2012 14:39:17 +0000 (16:39 +0200)]
Introduce an integer type for Value
The type is not being used yet, but all runtime
methods should be updated and able to deal with
integer Values correctly.
In addition started to clean up the use of some of
__qmljs_* Value constructors.
Change-Id: I1cb2169a5731f6adcc990dcbc92bc96aa008079f
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Fri, 12 Oct 2012 06:58:29 +0000 (08:58 +0200)]
Fix: make it possible to change the used LLVM installation.
If either the LLVM_INSTALL_DIR environment variable or the qmake
variable are set, use that to find the llvm-config utility. Changing
those is easier than modifying your path. Can be used if you have more
than one LLVM installation installed.
Change-Id: I24265b397e21f468ece61392a112de9a50c67c5a
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 12 Oct 2012 06:25:02 +0000 (08:25 +0200)]
Fix stack corruption on ia32
On ia32 sizeof(void*) < sizeof(Value), so we need to subtract
sizeof(Value) instead of sizeof(void*) before reaching the first
temp.
Added comments to explain the offsets.
Change-Id: Iefbb1dc762fdf36d73002c52dc9c471ec15ff403
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Wed, 10 Oct 2012 20:40:16 +0000 (22:40 +0200)]
Initial build fixes for arm
Lars Knoll [Thu, 11 Oct 2012 07:14:14 +0000 (09:14 +0200)]
Fix a crash when generating optimised code
The base operation for OpInplaceAnd is OpBitAnd,
not OpAnd.
Simon Hausmann [Wed, 10 Oct 2012 19:48:27 +0000 (21:48 +0200)]
Implement copyValue using a single load/store pair in the common case of copying temps
Simon Hausmann [Wed, 10 Oct 2012 19:28:13 +0000 (21:28 +0200)]
Simplify boolean conditional jumps
* Expect the boolean value to be in Gpr0, which means after the __qmljs_to_boolean
call the move(ReturnValueRegister, Gpr0) becomes a noop
* Instead of loading the true/1 into a register, use it as immediate value in the cmp
Simon Hausmann [Wed, 10 Oct 2012 19:25:40 +0000 (21:25 +0200)]
Make conditional jumps more readable
Simon Hausmann [Wed, 10 Oct 2012 19:22:34 +0000 (21:22 +0200)]
Fix ia32 build: make loadArgument available on all archs for copyValue
Lars Knoll [Wed, 10 Oct 2012 19:15:43 +0000 (21:15 +0200)]
Fix stack corruption
The position of temporaries on the stack was
off by 1, leading to us overwriting other r14, that gets
pushed to the stack after we have allocated space for temps.
Lars Knoll [Wed, 10 Oct 2012 12:02:50 +0000 (14:02 +0200)]
Simplify function header and footer on x86-64
Generate a few instructions less per function call.
Lars Knoll [Wed, 10 Oct 2012 11:46:12 +0000 (13:46 +0200)]
Emit code for copying values
Remove __qmljs_copy in the process.
Simon Hausmann [Wed, 10 Oct 2012 11:22:47 +0000 (13:22 +0200)]
Work around gcc bug on amd64 with function pointer assignment
Simon Hausmann [Wed, 10 Oct 2012 11:19:32 +0000 (13:19 +0200)]
Ignore generated files
Simon Hausmann [Wed, 10 Oct 2012 11:19:17 +0000 (13:19 +0200)]
Remove old assembler
Lars Knoll [Wed, 10 Oct 2012 11:10:07 +0000 (13:10 +0200)]
Make it really work for 64 bit.
crypto.js passes now :)
Simon Hausmann [Wed, 10 Oct 2012 09:42:38 +0000 (11:42 +0200)]
More 64-bit fixes
Simon Hausmann [Wed, 10 Oct 2012 09:04:53 +0000 (11:04 +0200)]
Rudimentary amd64 port
Simon Hausmann [Wed, 10 Oct 2012 08:27:04 +0000 (10:27 +0200)]
Fix rethrow
Simon Hausmann [Tue, 9 Oct 2012 08:31:54 +0000 (10:31 +0200)]
Remove generated code
Simon Hausmann [Tue, 9 Oct 2012 08:28:59 +0000 (10:28 +0200)]
Fix compilation on amd64 (not working yet, just building)
Simon Hausmann [Tue, 9 Oct 2012 08:05:27 +0000 (10:05 +0200)]
Centralize value copying
Simon Hausmann [Tue, 9 Oct 2012 07:59:02 +0000 (09:59 +0200)]
Save and restore context register before calls
Simon Hausmann [Tue, 9 Oct 2012 07:06:12 +0000 (09:06 +0200)]
More debug info
Simon Hausmann [Tue, 9 Oct 2012 06:17:47 +0000 (08:17 +0200)]
First shot at more readable call instructions in output
Simon Hausmann [Tue, 9 Oct 2012 05:41:36 +0000 (07:41 +0200)]
Remember linked function names in prep for future debug help
Simon Hausmann [Mon, 8 Oct 2012 19:58:24 +0000 (21:58 +0200)]
Fix array subscript write: add missing context pointer argument to qmljs_set_element call
Simon Hausmann [Mon, 8 Oct 2012 18:22:31 +0000 (20:22 +0200)]
Use posix_memalign to ensure assert(!(code & 15))
Simon Hausmann [Mon, 8 Oct 2012 18:21:40 +0000 (20:21 +0200)]
Implement executalble memory using mmap
Simon Hausmann [Mon, 8 Oct 2012 08:25:21 +0000 (10:25 +0200)]
Fix non-release builds
Simon Hausmann [Sun, 7 Oct 2012 20:14:01 +0000 (22:14 +0200)]
Add missing return
Simon Hausmann [Sun, 7 Oct 2012 20:10:27 +0000 (22:10 +0200)]
Implement missing movs
Simon Hausmann [Sun, 7 Oct 2012 20:02:41 +0000 (22:02 +0200)]
implement visitExp
Simon Hausmann [Sun, 7 Oct 2012 20:02:06 +0000 (22:02 +0200)]
Implement construct property/value
Simon Hausmann [Sun, 7 Oct 2012 19:57:10 +0000 (21:57 +0200)]
Implement call value and property
Simon Hausmann [Sun, 7 Oct 2012 19:43:29 +0000 (21:43 +0200)]
Port remaining code to better function call mechanism
Simon Hausmann [Sun, 7 Oct 2012 17:45:40 +0000 (19:45 +0200)]
Fix closure init
Simon Hausmann [Fri, 5 Oct 2012 09:48:05 +0000 (11:48 +0200)]
Simplify more function calls
Simon Hausmann [Fri, 5 Oct 2012 09:35:46 +0000 (11:35 +0200)]
further call simplification
Simon Hausmann [Fri, 5 Oct 2012 09:13:54 +0000 (11:13 +0200)]
Simpler approach to function calls
Simon Hausmann [Fri, 5 Oct 2012 09:02:54 +0000 (11:02 +0200)]
Simplify passing temps as method arguments
Simon Hausmann [Fri, 5 Oct 2012 06:09:12 +0000 (08:09 +0200)]
A bit more inplace assignment implemented
Simon Hausmann [Fri, 5 Oct 2012 05:55:05 +0000 (07:55 +0200)]
Generate the code for copying the argments earlier, to avoid register clobbering between __qmljs_copy calls
Simon Hausmann [Thu, 4 Oct 2012 21:23:50 +0000 (23:23 +0200)]
Implement constructActivationProperty
Simon Hausmann [Thu, 4 Oct 2012 20:50:01 +0000 (22:50 +0200)]
Implement mov unop
Simon Hausmann [Thu, 4 Oct 2012 20:46:42 +0000 (22:46 +0200)]
Implement binop mov
Simon Hausmann [Thu, 4 Oct 2012 20:13:34 +0000 (22:13 +0200)]
Implement mov as string
Simon Hausmann [Thu, 4 Oct 2012 20:08:22 +0000 (22:08 +0200)]
Sprinkle a few more notImplemented()
Simon Hausmann [Thu, 4 Oct 2012 20:02:43 +0000 (22:02 +0200)]
Implement more of cjump
Simon Hausmann [Thu, 4 Oct 2012 19:48:38 +0000 (21:48 +0200)]
Add missing returns
Simon Hausmann [Thu, 4 Oct 2012 19:40:33 +0000 (21:40 +0200)]
Fix argument addressing to be in the right order
Simon Hausmann [Thu, 4 Oct 2012 19:40:17 +0000 (21:40 +0200)]
Fix move temp -> temp
Simon Hausmann [Thu, 4 Oct 2012 17:24:22 +0000 (19:24 +0200)]
Implemented part of visitCJump
Simon Hausmann [Tue, 2 Oct 2012 06:56:49 +0000 (08:56 +0200)]
Cleanup
Simon Hausmann [Tue, 2 Oct 2012 06:55:18 +0000 (08:55 +0200)]
Implement callActivationProperty, mov with target as name and closure init
Simon Hausmann [Tue, 2 Oct 2012 06:53:47 +0000 (08:53 +0200)]
Fix generation of multiple functions
Sine we can't reset the MacroAssembler properly right now, reconstruct
the isel for every function.
Simon Hausmann [Tue, 2 Oct 2012 06:52:38 +0000 (08:52 +0200)]
Fix stupid off-by-one in address calculation of temporaries on the stack
Simon Hausmann [Tue, 2 Oct 2012 05:21:38 +0000 (07:21 +0200)]
Simplified function call helpers
Simon Hausmann [Tue, 2 Oct 2012 04:49:49 +0000 (06:49 +0200)]
Prospective jump support
Simon Hausmann [Mon, 1 Oct 2012 20:52:05 +0000 (22:52 +0200)]
Implement basic name lookup
Simon Hausmann [Mon, 1 Oct 2012 20:35:53 +0000 (22:35 +0200)]
Implement simple value storage
Simon Hausmann [Mon, 1 Oct 2012 20:03:59 +0000 (22:03 +0200)]
Fix ret argumet passing
Simon Hausmann [Mon, 1 Oct 2012 20:02:20 +0000 (22:02 +0200)]
cleanup, squash
Simon Hausmann [Mon, 1 Oct 2012 19:59:09 +0000 (21:59 +0200)]
Call helper
Simon Hausmann [Mon, 1 Oct 2012 19:39:25 +0000 (21:39 +0200)]
correct temp handling
Simon Hausmann [Mon, 1 Oct 2012 07:29:20 +0000 (09:29 +0200)]
Cleanups, some rudimentary stubs so that "return 42" can be compiled :)
Simon Hausmann [Wed, 26 Sep 2012 19:46:30 +0000 (21:46 +0200)]
Fix code ownership
Simon Hausmann [Sun, 23 Sep 2012 08:44:12 +0000 (10:44 +0200)]
Add udis86 support
Simon Hausmann [Sun, 23 Sep 2012 08:28:13 +0000 (10:28 +0200)]
Initial import of MASM
laknoll [Thu, 20 Sep 2012 08:28:43 +0000 (10:28 +0200)]
Fix division operation
laknoll [Wed, 19 Sep 2012 19:08:47 +0000 (21:08 +0200)]
Proper NaN boxing for Value
All JS types are now encoded in a 8 byte data
structure. We use the 52 bits that are unused
when a double is a NaN to encode all other types
that can be stored inside a double.
This is being done by using a few bits to determine
the type, and up to 48 bits for data. This works
even on x64, as addresses (ie. pointers) are limited
to 48 bits on these platforms.
For most other types (except doubles), we store the
data in the lower 32 bits of the double.
Roberto Raggi [Tue, 26 Jun 2012 13:36:03 +0000 (15:36 +0200)]
Initial work on `eval'.