platform/upstream/libSkiaSharp.git
11 years agoRevert 7625 until after M26 due to a mix of perf changes.
bsalomon@google.com [Fri, 8 Feb 2013 21:22:44 +0000 (21:22 +0000)]
Revert 7625 until after M26 due to a mix of perf changes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7683 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix uninitialized Render Target origin issue in debugger
robertphillips@google.com [Fri, 8 Feb 2013 21:22:09 +0000 (21:22 +0000)]
Fix uninitialized Render Target origin issue in debugger

https://codereview.appspot.com/7314066/

git-svn-id: http://skia.googlecode.com/svn/trunk@7682 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up some out of order initialization warnings.
scroggo@google.com [Fri, 8 Feb 2013 21:16:19 +0000 (21:16 +0000)]
Clean up some out of order initialization warnings.

Review URL: https://codereview.appspot.com/7321043

git-svn-id: http://skia.googlecode.com/svn/trunk@7681 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding option to SkTileGrid for specifying border pixels.
junov@chromium.org [Fri, 8 Feb 2013 21:03:30 +0000 (21:03 +0000)]
Adding option to SkTileGrid for specifying border pixels.

The purpose of this patch is to make it possible for the chromium compositor to
generate a TileGrid structure that is better suited for scaled playback.
Review URL: https://codereview.appspot.com/7300072

git-svn-id: http://skia.googlecode.com/svn/trunk@7680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enabled performance checking on Windows
robertphillips@google.com [Fri, 8 Feb 2013 20:09:56 +0000 (20:09 +0000)]
Re-enabled performance checking on Windows

https://codereview.appspot.com/7309065/

git-svn-id: http://skia.googlecode.com/svn/trunk@7679 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOptimize building gradient cache for when we know alpha is always 0xFF.
reed@google.com [Fri, 8 Feb 2013 19:48:12 +0000 (19:48 +0000)]
Optimize building gradient cache for when we know alpha is always 0xFF.
remove old build guard for dithering.
Review URL: https://codereview.appspot.com/7309064

git-svn-id: http://skia.googlecode.com/svn/trunk@7678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for using ANGLE in bench_pictures.
scroggo@google.com [Fri, 8 Feb 2013 19:38:21 +0000 (19:38 +0000)]
Add support for using ANGLE in bench_pictures.

BUG=https://code.google.com/p/skia/issues/detail?id=1012

Other cleanups:
Remove setDeviceType from PictureBenchmark, since it is unnecessary.
Dereference PictureRenderer::fGrContext when done with it.
Make PictureRenderer::fGrContext and PictureRenderer::fGrContextFactory private, since they are not used by subclasses.

Review URL: https://codereview.appspot.com/7314063

git-svn-id: http://skia.googlecode.com/svn/trunk@7677 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoves redundant and wrong check.
bensong@google.com [Fri, 8 Feb 2013 19:02:21 +0000 (19:02 +0000)]
Removes redundant and wrong check.
Review URL: https://codereview.appspot.com/7308072

git-svn-id: http://skia.googlecode.com/svn/trunk@7676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes indentation error.
bensong@google.com [Fri, 8 Feb 2013 18:53:24 +0000 (18:53 +0000)]
Fixes indentation error.
Review URL: https://codereview.appspot.com/7307077

git-svn-id: http://skia.googlecode.com/svn/trunk@7674 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes a bug that didn't address new perfdata location.
bensong@google.com [Fri, 8 Feb 2013 18:47:02 +0000 (18:47 +0000)]
Fixes a bug that didn't address new perfdata location.
Review URL: https://codereview.appspot.com/7299070

git-svn-id: http://skia.googlecode.com/svn/trunk@7673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build on Macos
humper@google.com [Fri, 8 Feb 2013 18:44:27 +0000 (18:44 +0000)]
fix build on Macos

BUG=

Review URL: https://codereview.appspot.com/7320043

git-svn-id: http://skia.googlecode.com/svn/trunk@7672 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Mac compile warnings. Temporarily removed random gorilla test.
jvanverth@google.com [Fri, 8 Feb 2013 18:28:47 +0000 (18:28 +0000)]
Fix for Mac compile warnings. Temporarily removed random gorilla test.

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd Random unit tests.
jvanverth@google.com [Fri, 8 Feb 2013 17:13:09 +0000 (17:13 +0000)]
Add Random unit tests.

https://codereview.appspot.com/7306066/

git-svn-id: http://skia.googlecode.com/svn/trunk@7670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd .swp files to gitignore.
scroggo@google.com [Fri, 8 Feb 2013 16:59:59 +0000 (16:59 +0000)]
Add .swp files to gitignore.

Make git ignore .swp files (generated while editing in vim).

Review URL: https://codereview.appspot.com/7309059

git-svn-id: http://skia.googlecode.com/svn/trunk@7669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a bench for SkBicubicImageFilter.
senorblanco@chromium.org [Fri, 8 Feb 2013 16:40:14 +0000 (16:40 +0000)]
Add a bench for SkBicubicImageFilter.

Review URL: https://codereview.appspot.com/7312056

git-svn-id: http://skia.googlecode.com/svn/trunk@7668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 8 Feb 2013 07:16:45 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove compile time option to use different types for text vertices.
bsalomon@google.com [Thu, 7 Feb 2013 22:00:29 +0000 (22:00 +0000)]
Remove compile time option to use different types for text vertices.
Review URL: https://codereview.appspot.com/7309060

git-svn-id: http://skia.googlecode.com/svn/trunk@7658 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable new GL error checking in ~SkGLContext
robertphillips@google.com [Thu, 7 Feb 2013 21:16:41 +0000 (21:16 +0000)]
Temporarily disable new GL error checking in ~SkGLContext

https://codereview.appspot.com/7308064/

git-svn-id: http://skia.googlecode.com/svn/trunk@7657 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable.
bsalomon@google.com [Thu, 7 Feb 2013 21:02:36 +0000 (21:02 +0000)]
Remove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7312061

git-svn-id: http://skia.googlecode.com/svn/trunk@7656 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAddress google3 compiler warning
robertphillips@google.com [Thu, 7 Feb 2013 21:02:23 +0000 (21:02 +0000)]
Address google3 compiler warning

https://codereview.appspot.com/7308063/

git-svn-id: http://skia.googlecode.com/svn/trunk@7655 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup debugger's handling of bad input files
robertphillips@google.com [Thu, 7 Feb 2013 20:39:40 +0000 (20:39 +0000)]
Cleanup debugger's handling of bad input files

https://codereview.appspot.com/7308062/

git-svn-id: http://skia.googlecode.com/svn/trunk@7654 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoonly take the vertical special-case for gradients when dx is exactly 0, as a
reed@google.com [Thu, 7 Feb 2013 20:28:49 +0000 (20:28 +0000)]
only take the vertical special-case for gradients when dx is exactly 0, as a
zoomed gradient can have a very small dx, but be no where near to vertical.

http://code.google.com/p/skia/issues/detail?id=1101
Review URL: https://codereview.appspot.com/7310059

git-svn-id: http://skia.googlecode.com/svn/trunk@7653 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_DUMP_TEXTURE_UPLOADS
bsalomon@google.com [Thu, 7 Feb 2013 20:21:39 +0000 (20:21 +0000)]
Remove GR_DUMP_TEXTURE_UPLOADS

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7300062

git-svn-id: http://skia.googlecode.com/svn/trunk@7652 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly turn on one gpu timer in PictureBenchmark tool
robertphillips@google.com [Thu, 7 Feb 2013 20:20:27 +0000 (20:20 +0000)]
Only turn on one gpu timer in PictureBenchmark tool

https://codereview.appspot.com/7310060/

git-svn-id: http://skia.googlecode.com/svn/trunk@7651 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_AGGRESSIVE_SHADER_OPTS build option.
bsalomon@google.com [Thu, 7 Feb 2013 19:53:49 +0000 (19:53 +0000)]
Remove GR_AGGRESSIVE_SHADER_OPTS build option.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7312058

git-svn-id: http://skia.googlecode.com/svn/trunk@7650 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkBits2Float in SkRandom
bsalomon@google.com [Thu, 7 Feb 2013 19:52:30 +0000 (19:52 +0000)]
Use SkBits2Float in SkRandom

https://codereview.appspot.com/7266044/

git-svn-id: http://skia.googlecode.com/svn/trunk@7648 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnhance GL error checking for non-Ganesh GL calls
robertphillips@google.com [Thu, 7 Feb 2013 19:45:46 +0000 (19:45 +0000)]
Enhance GL error checking for non-Ganesh GL calls

https://codereview.appspot.com/7312057/

git-svn-id: http://skia.googlecode.com/svn/trunk@7647 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix errors when compiling with -Wall -Werror on Android.
djsollen@google.com [Thu, 7 Feb 2013 18:58:35 +0000 (18:58 +0000)]
Fix errors when compiling with -Wall -Werror on Android.

This CL also turns those features on by default on Android

Review URL: https://codereview.appspot.com/7313049

git-svn-id: http://skia.googlecode.com/svn/trunk@7645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore fixes for ios build.
bsalomon@google.com [Thu, 7 Feb 2013 17:01:39 +0000 (17:01 +0000)]
More fixes for ios build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7643 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix iOS build.
bsalomon@google.com [Thu, 7 Feb 2013 16:23:58 +0000 (16:23 +0000)]
Attempt to fix iOS build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7642 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporary patch to BenchPictures gpu timing problem
robertphillips@google.com [Thu, 7 Feb 2013 16:21:22 +0000 (16:21 +0000)]
Temporary patch to BenchPictures gpu timing problem

https://codereview.appspot.com/7311059/

git-svn-id: http://skia.googlecode.com/svn/trunk@7641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove legacy names no longer referenced in Chrome and WebKit.
bsalomon@google.com [Thu, 7 Feb 2013 14:43:04 +0000 (14:43 +0000)]
Remove legacy names no longer referenced in Chrome and WebKit.
Review URL: https://codereview.appspot.com/7311055

git-svn-id: http://skia.googlecode.com/svn/trunk@7640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 7 Feb 2013 13:13:41 +0000 (13:13 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a perf regression introduced by r7594: when computing a texture cache key, use...
senorblanco@chromium.org [Thu, 7 Feb 2013 00:35:25 +0000 (00:35 +0000)]
Fix a perf regression introduced by r7594:  when computing a texture cache key, use the resolved (Top or Bottom) surface origin, never Default, otherwise we never get a cache hit.

Covered by polygon, path benches.  See also:  https://code.google.com/p/chromium/issues/detail?id=174749.

Review URL: https://codereview.appspot.com/7299059

git-svn-id: http://skia.googlecode.com/svn/trunk@7635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed warning/error in PictureRenderer.cpp
robertphillips@google.com [Thu, 7 Feb 2013 00:13:34 +0000 (00:13 +0000)]
Fixed warning/error in PictureRenderer.cpp

TBR by scroggo@google.com

git-svn-id: http://skia.googlecode.com/svn/trunk@7634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn picture rendering tools, draw the entire scaled image.
scroggo@google.com [Wed, 6 Feb 2013 22:32:57 +0000 (22:32 +0000)]
In picture rendering tools, draw the entire scaled image.

If --scale is used, limit the size of the image drawn to the
scaled picture size, rather than the original picture size.

BUG=https://code.google.com/p/skia/issues/detail?id=1095

Review URL: https://codereview.appspot.com/7307054

git-svn-id: http://skia.googlecode.com/svn/trunk@7633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix function not predeclared warning on Mac.
bsalomon@google.com [Wed, 6 Feb 2013 21:44:21 +0000 (21:44 +0000)]
Fix function not predeclared warning on Mac.

TBR=robertphillips@google.com
Review URL: https://codereview.appspot.com/7314048

git-svn-id: http://skia.googlecode.com/svn/trunk@7632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorver r7626, might trigger for some strange reason a heap corruption
edisonn@google.com [Wed, 6 Feb 2013 21:42:34 +0000 (21:42 +0000)]
rver r7626, might trigger for some strange reason a heap corruption

git-svn-id: http://skia.googlecode.com/svn/trunk@7631 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes a bug introduced by the new per-tile bench log format.
bensong@google.com [Wed, 6 Feb 2013 20:59:14 +0000 (20:59 +0000)]
Fixes a bug introduced by the new per-tile bench log format.
Review URL: https://codereview.appspot.com/7301056

git-svn-id: http://skia.googlecode.com/svn/trunk@7630 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
bensong@google.com [Wed, 6 Feb 2013 20:51:55 +0000 (20:51 +0000)]
Updates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
Sample command: bench/gen_skp_ranges.py -r 7621:7621
It is slow due to cloud storage slowness. You can download the bench logs using gsutil and set the -d flag to make it super fast.
Review URL: https://codereview.appspot.com/7307052

git-svn-id: http://skia.googlecode.com/svn/trunk@7629 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for sign mismatch warning/error
robertphillips@google.com [Wed, 6 Feb 2013 20:42:14 +0000 (20:42 +0000)]
Fix for sign mismatch warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@7628 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd overdraw visualization to the debugger
robertphillips@google.com [Wed, 6 Feb 2013 20:13:54 +0000 (20:13 +0000)]
Add overdraw visualization to the debugger

https://codereview.appspot.com/7267043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7627 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a true Set class. Current use case is to be used with Pdf generator.
edisonn@google.com [Wed, 6 Feb 2013 18:54:13 +0000 (18:54 +0000)]
Add a true Set class. Current use case is to be used with Pdf generator.
Review URL: https://codereview.appspot.com/6749054

git-svn-id: http://skia.googlecode.com/svn/trunk@7626 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_STATIC_RECT_VB
bsalomon@google.com [Wed, 6 Feb 2013 18:53:12 +0000 (18:53 +0000)]
Remove GR_STATIC_RECT_VB
Review URL: https://codereview.appspot.com/7304055

git-svn-id: http://skia.googlecode.com/svn/trunk@7625 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-tests: generate JSON expectations, in addition to image expectations
epoger@google.com [Wed, 6 Feb 2013 18:41:04 +0000 (18:41 +0000)]
gm self-tests: generate JSON expectations, in addition to image expectations
Review URL: https://codereview.appspot.com/7310050

git-svn-id: http://skia.googlecode.com/svn/trunk@7624 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix WritePixels test on ANGLE.
bsalomon@google.com [Wed, 6 Feb 2013 18:17:50 +0000 (18:17 +0000)]
Fix WritePixels test on ANGLE.

Don't upload BGRA to RGBA if not supported (ES2 w/ EXT BGRA extension).

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7305046

git-svn-id: http://skia.googlecode.com/svn/trunk@7622 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn --timeIndividualTiles back on in bench_pictures
borenet@google.com [Wed, 6 Feb 2013 16:27:38 +0000 (16:27 +0000)]
Turn --timeIndividualTiles back on in bench_pictures
Review URL: https://codereview.appspot.com/7299049

git-svn-id: http://skia.googlecode.com/svn/trunk@7620 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger builds after master restart
borenet@google.com [Wed, 6 Feb 2013 16:08:05 +0000 (16:08 +0000)]
Whitespace change to trigger builds after master restart

git-svn-id: http://skia.googlecode.com/svn/trunk@7618 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB
jvanverth@google.com [Wed, 6 Feb 2013 13:45:11 +0000 (13:45 +0000)]
Set vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB

git-svn-id: http://skia.googlecode.com/svn/trunk@7612 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSmall code cleaup: remove redundant if
edisonn@google.com [Wed, 6 Feb 2013 13:43:58 +0000 (13:43 +0000)]
Small code cleaup: remove redundant if
unreviewd, comment from previous cl

git-svn-id: http://skia.googlecode.com/svn/trunk@7611 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck for self-assignment in operator=
reed@google.com [Wed, 6 Feb 2013 12:47:14 +0000 (12:47 +0000)]
check for self-assignment in operator=

git-svn-id: http://skia.googlecode.com/svn/trunk@7610 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 6 Feb 2013 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7608 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotweak to spacing, to trigger build
mike@reedtribe.org [Wed, 6 Feb 2013 03:43:57 +0000 (03:43 +0000)]
tweak to spacing, to trigger build

git-svn-id: http://skia.googlecode.com/svn/trunk@7607 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
edisonn@google.com [Tue, 5 Feb 2013 23:13:39 +0000 (23:13 +0000)]
If the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
Review URL: https://codereview.appspot.com/7313045

git-svn-id: http://skia.googlecode.com/svn/trunk@7605 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix calls to setVertexSourceToBuffer
robertphillips@google.com [Tue, 5 Feb 2013 22:55:18 +0000 (22:55 +0000)]
Fix calls to setVertexSourceToBuffer

git-svn-id: http://skia.googlecode.com/svn/trunk@7604 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bench crash (calling method on NULL object).
bsalomon@google.com [Tue, 5 Feb 2013 21:32:06 +0000 (21:32 +0000)]
Fix bench crash (calling method on NULL object).
Review URL: https://codereview.appspot.com/7305048

git-svn-id: http://skia.googlecode.com/svn/trunk@7603 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReinstate r7546: fix unused variable warning
jvanverth@google.com [Tue, 5 Feb 2013 21:05:04 +0000 (21:05 +0000)]
Reinstate r7546: fix unused variable warning

https://codereview.appspot.com/7309051

git-svn-id: http://skia.googlecode.com/svn/trunk@7602 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImproved compartmentalization of filter tool's optimizations & add new optimization
robertphillips@google.com [Tue, 5 Feb 2013 20:51:49 +0000 (20:51 +0000)]
Improved compartmentalization of filter tool's optimizations & add new optimization

https://codereview.appspot.com/7294049/

git-svn-id: http://skia.googlecode.com/svn/trunk@7601 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove vertex layout from GeometrySrcState to GrDrawState.
jvanverth@google.com [Tue, 5 Feb 2013 20:33:30 +0000 (20:33 +0000)]
Move vertex layout from GeometrySrcState to GrDrawState.

Also adds AutoStateRestore member to AutoGeometryPush to push DrawState as well
as GeometrySrcState. And removed vertex layout as an argument to a number of
functions -- they will get vertex layout info from the current DrawState.

Review URL: https://codereview.appspot.com/7286047

git-svn-id: http://skia.googlecode.com/svn/trunk@7600 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix master IP in submit_try
borenet@google.com [Tue, 5 Feb 2013 20:26:31 +0000 (20:26 +0000)]
Fix master IP in submit_try

Unreviewed.  Should have this reference:
http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7314045

git-svn-id: http://skia.googlecode.com/svn/trunk@7598 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7595 due to housekeeper warning-as-error.
bsalomon@google.com [Tue, 5 Feb 2013 20:09:41 +0000 (20:09 +0000)]
Revert r7595 due to housekeeper warning-as-error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7596 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enable static asserts with windows warning fix.
bsalomon@google.com [Tue, 5 Feb 2013 20:04:38 +0000 (20:04 +0000)]
Re-enable static asserts with windows warning fix.

git-svn-id: http://skia.googlecode.com/svn/trunk@7595 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets. Note that the default behaviour...
senorblanco@chromium.org [Tue, 5 Feb 2013 19:50:46 +0000 (19:50 +0000)]
Implement support for origin-TopLeft render targets. Note that the default behaviour remains the same:  textures default to origin-TopLeft, render targets default to origin-BottomLeft, and backend textures default to origin-BottomLeft. However, the caller can override the default by setting fOrigin in GrTextureDesc, GrBackendTextureDesc or GrBackendRenderTargetDesc.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7594 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for issue 1029: Debugger opens files with ^O, but crashes when opening files...
jvanverth@google.com [Tue, 5 Feb 2013 19:44:07 +0000 (19:44 +0000)]
Fix for issue 1029: Debugger opens files with ^O, but crashes when opening files through other methods

Don't append leading '/' if path is local

git-svn-id: http://skia.googlecode.com/svn/trunk@7593 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets in GL backend.
scroggo@google.com [Tue, 5 Feb 2013 19:22:27 +0000 (19:22 +0000)]
Implement support for origin-TopLeft render targets in GL backend.

Committed: https://code.google.com/p/skia/source/detail?r=7545

Reverted in r7571; re-opening.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7592 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix some 64 bit warnings on mac.
scroggo@google.com [Tue, 5 Feb 2013 18:49:00 +0000 (18:49 +0000)]
Fix some 64 bit warnings on mac.

SkAAClip:
Change fDataSize to a size_t, since that is how it is used in all
cases.

SkAlphaRuns.cpp:
Use SkToS32 when subtracting a pointer from another pointer to
return an int.

BUG=http://code.google.com/p/skia/issues/detail?id=1103

Review URL: https://codereview.appspot.com/7314043

git-svn-id: http://skia.googlecode.com/svn/trunk@7591 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix unbalanced Shader set/endContext calls in drawVertices
djsollen@google.com [Tue, 5 Feb 2013 17:00:02 +0000 (17:00 +0000)]
Fix unbalanced Shader set/endContext calls in drawVertices

Review URL: https://codereview.appspot.com/7309047

git-svn-id: http://skia.googlecode.com/svn/trunk@7588 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agohide the static-assert block altogether, until we can find a construct that
reed@google.com [Tue, 5 Feb 2013 16:42:28 +0000 (16:42 +0000)]
hide the static-assert block altogether, until we can find a construct that
doesn't have warngs on mac or windows

git-svn-id: http://skia.googlecode.com/svn/trunk@7586 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix (new annoying) warning (mac only I think)
reed@google.com [Tue, 5 Feb 2013 16:18:20 +0000 (16:18 +0000)]
fix (new annoying) warning (mac only I think)

git-svn-id: http://skia.googlecode.com/svn/trunk@7583 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve...
bsalomon@google.com [Tue, 5 Feb 2013 16:14:15 +0000 (16:14 +0000)]
Make windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve gl functions. Instead load the GL library and use GetProcAddress.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7308047

git-svn-id: http://skia.googlecode.com/svn/trunk@7582 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoActually fix angle GLPrograms test.
bsalomon@google.com [Tue, 5 Feb 2013 15:44:21 +0000 (15:44 +0000)]
Actually fix angle GLPrograms test.

git-svn-id: http://skia.googlecode.com/svn/trunk@7578 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRestore variable to release builds.
jvanverth@google.com [Tue, 5 Feb 2013 14:15:31 +0000 (14:15 +0000)]
Restore variable to release builds.

git-svn-id: http://skia.googlecode.com/svn/trunk@7572 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r7545 (render target origin change) due to layout test issues (see https...
robertphillips@google.com [Tue, 5 Feb 2013 14:05:06 +0000 (14:05 +0000)]
Reverting r7545 (render target origin change) due to layout test issues (see https://codereview.chromium.org/12210002/)

git-svn-id: http://skia.googlecode.com/svn/trunk@7571 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 5 Feb 2013 07:02:01 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7567 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove define for SK_IGNORE_GRADIENT_DITHER_FIX to trigger rebaselines
mike@reedtribe.org [Tue, 5 Feb 2013 02:58:00 +0000 (02:58 +0000)]
remove define for SK_IGNORE_GRADIENT_DITHER_FIX to trigger rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@7564 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageF...
senorblanco@chromium.org [Mon, 4 Feb 2013 22:57:21 +0000 (22:57 +0000)]
Nuke SkSingleInputImageFilter.  99% of its functionality was refactored into SkImageFilterUtils in https://code.google.com/p/skia/source/detail?r=7467, so it has outlived its usefulness.

Review URL: https://codereview.appspot.com/7277055

git-svn-id: http://skia.googlecode.com/svn/trunk@7563 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkToS32 to turn a ptrdiff_t into an int (on 64bit build)
reed@google.com [Mon, 4 Feb 2013 22:40:28 +0000 (22:40 +0000)]
use SkToS32 to turn a ptrdiff_t into an int (on 64bit build)

git-svn-id: http://skia.googlecode.com/svn/trunk@7562 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse XQuartz's version of OSMesa rather than Mac SDK's. It is newer and has a fix...
bsalomon@google.com [Mon, 4 Feb 2013 22:17:13 +0000 (22:17 +0000)]
Use XQuartz's version of OSMesa rather than Mac SDK's. It is newer and has a fix for a bug that unit tests and GM trigger.

git-svn-id: http://skia.googlecode.com/svn/trunk@7561 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove vestiges of 32BIT_GRADIENT flag, as we always dither gradients now
reed@google.com [Mon, 4 Feb 2013 21:03:11 +0000 (21:03 +0000)]
remove vestiges of 32BIT_GRADIENT flag, as we always dither gradients now
(even in chrome)
Review URL: https://codereview.appspot.com/7281049

git-svn-id: http://skia.googlecode.com/svn/trunk@7558 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd kMultiply_Mode to switch statement (fix warning)
reed@google.com [Mon, 4 Feb 2013 20:46:08 +0000 (20:46 +0000)]
add kMultiply_Mode to switch statement (fix warning)

git-svn-id: http://skia.googlecode.com/svn/trunk@7556 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoland https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS...
reed@google.com [Mon, 4 Feb 2013 20:06:00 +0000 (20:06 +0000)]
land https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS spec

git-svn-id: http://skia.googlecode.com/svn/trunk@7553 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimplify and speed up SkIntroSort.
bungeman@google.com [Mon, 4 Feb 2013 19:54:15 +0000 (19:54 +0000)]
Simplify and speed up SkIntroSort.
https://codereview.appspot.com/7273048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7552 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCommit file missing from r7550
bsalomon@google.com [Mon, 4 Feb 2013 18:46:49 +0000 (18:46 +0000)]
Commit file missing from r7550

git-svn-id: http://skia.googlecode.com/svn/trunk@7551 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix GLPrograms test on ANGLE bot.
bsalomon@google.com [Mon, 4 Feb 2013 18:39:24 +0000 (18:39 +0000)]
Attempt to fix GLPrograms test on ANGLE bot.

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7281050

git-svn-id: http://skia.googlecode.com/svn/trunk@7550 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGo from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
reed@google.com [Mon, 4 Feb 2013 18:21:23 +0000 (18:21 +0000)]
Go from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
compute the "dithered" version of a color to just a graduated fixed-point-round.
Also, add this new dither to conical and sweep, which before had no dithering.

Disabled for now using SK_IGNORE_GRADIENT_DITHER_FIX. Will enable this and
and rebaseline skia.

http://code.google.com/p/skia/issues/detail?id=1098
Review URL: https://codereview.appspot.com/7248046

git-svn-id: http://skia.googlecode.com/svn/trunk@7549 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoextend gradient_create bench to test opaque and alpha gradient ramps
reed@google.com [Mon, 4 Feb 2013 18:09:58 +0000 (18:09 +0000)]
extend gradient_create bench to test opaque and alpha gradient ramps

git-svn-id: http://skia.googlecode.com/svn/trunk@7548 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocleanup: use DEF_BENCH macro
reed@google.com [Mon, 4 Feb 2013 18:00:54 +0000 (18:00 +0000)]
cleanup: use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7547 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix unused variable warning
reed@google.com [Mon, 4 Feb 2013 17:59:02 +0000 (17:59 +0000)]
fix unused variable warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7546 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets in GL backend.
senorblanco@chromium.org [Mon, 4 Feb 2013 17:29:51 +0000 (17:29 +0000)]
Implement support for origin-TopLeft render targets in GL backend.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7545 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new gms for shallow_gradient, in preparation for improving their quality
reed@google.com [Mon, 4 Feb 2013 16:56:15 +0000 (16:56 +0000)]
add new gms for shallow_gradient, in preparation for improving their quality

git-svn-id: http://skia.googlecode.com/svn/trunk@7544 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange comment to avoid warning (don't end line comment with '\').
bungeman@google.com [Mon, 4 Feb 2013 16:24:44 +0000 (16:24 +0000)]
Change comment to avoid warning (don't end line comment with '\').

git-svn-id: http://skia.googlecode.com/svn/trunk@7542 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Mon, 4 Feb 2013 16:22:06 +0000 (16:22 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GPU unit tests use GrContexts of different GL types.
bsalomon@google.com [Mon, 4 Feb 2013 16:13:32 +0000 (16:13 +0000)]
Make GPU unit tests use GrContexts of different GL types.
Review URL: https://codereview.appspot.com/7281046

git-svn-id: http://skia.googlecode.com/svn/trunk@7540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd sk_ignore_unused_variable to avoid warnings.
bungeman@google.com [Mon, 4 Feb 2013 15:58:08 +0000 (15:58 +0000)]
Add sk_ignore_unused_variable to avoid warnings.
https://codereview.appspot.com/7218045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7539 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
reed@google.com [Mon, 4 Feb 2013 14:57:28 +0000 (14:57 +0000)]
add benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
those based on special-casing stroking for single-contour-convex shapes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 4 Feb 2013 14:06:49 +0000 (14:06 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Mon, 4 Feb 2013 12:57:42 +0000 (12:57 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7533 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove kStyleCount out of Style enum, and into its own, to avoid
mike@reedtribe.org [Mon, 4 Feb 2013 05:17:10 +0000 (05:17 +0000)]
move kStyleCount out of Style enum, and into its own, to avoid
1. someone passing kStyleCount as a parameter
2. warnings about not handling all enum values in a switch

We should probably move to remove kCountFoo from all of our enums for these reasons.

git-svn-id: http://skia.googlecode.com/svn/trunk@7532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH macro
mike@reedtribe.org [Mon, 4 Feb 2013 05:05:36 +0000 (05:05 +0000)]
use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7531 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Sun, 3 Feb 2013 21:04:27 +0000 (21:04 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7530 2bbb7eff-a529-9590-31e7-b0007b416f81