commit-bot@chromium.org [Thu, 8 Aug 2013 10:51:45 +0000 (10:51 +0000)]
ARM Skia NEON patches - 11 - Blitter_RGB16
Blitter_RGB16: fixes and improvements
- fix alpha calculation: it was still using the old version of
SkAlpha255To256. 11 more tests pass in gm.
- clean a lot the code: the existing code was "a bit" messy with
a lot of duplicated hardcoded constants, got rid of all this.
- improve speed a little: part of it as a side-effect of the change
in the way alpha is calculated but also by grouping loads and stores.
One "issue" was present and still remains: the NEON code doesn't give
the same result as the black blitter on black. It accounts for dozens
of mismatches in gm. Is this considered "not too bad"? Would you be
interested in a NEON version of the black blitter? The current
comments seem to indicate that the black blitter is here only to give
a performance boost when NEON is not presents so I didn't write a NEON
version.
BUG=
R=djsollen@google.com, tomhudson@google.com, reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/
18666005
git-svn-id: http://skia.googlecode.com/svn/trunk@10635
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 8 Aug 2013 07:01:20 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10634
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 Aug 2013 02:52:05 +0000 (02:52 +0000)]
Use Path Ops to generate PDF clips
R=vandebo@chromium.org, edisonn@google.com, caryclark@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
21161003
git-svn-id: http://skia.googlecode.com/svn/trunk@10633
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 7 Aug 2013 22:36:29 +0000 (22:36 +0000)]
Revert r10603 (Remove operator== from SkPaint) due to Chrome failures
git-svn-id: http://skia.googlecode.com/svn/trunk@10632
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 7 Aug 2013 21:36:15 +0000 (21:36 +0000)]
New baselines for imagefiltersbase, after r10626.
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/
22623004
git-svn-id: http://skia.googlecode.com/svn/trunk@10631
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 7 Aug 2013 21:11:57 +0000 (21:11 +0000)]
pdfviewer: absolute minimal; to al least render (even if poorly) ICC based color spaces, based on RGB
Review URL: https://codereview.chromium.org/
22624002
git-svn-id: http://skia.googlecode.com/svn/trunk@10630
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 21:09:13 +0000 (21:09 +0000)]
Beginning work to refactor jpeg tile decoding.
Keep common code together, so we can fix bugs in tile and normal decode
simultaneously.
Convert if-then chains to switch statements for readability.
Add getBitmapConfig, common to both normal and tile decode, which
ensures that they behave the same. getBitmapConfig uses the code
originally in onDecode, so subsetting grayscale into A8 now works.
In getBitmapConfig, handle JCS_YCCK properly.
Fix a bug where requesting A8 from a JCS_CMYK image would
result in a total failure to decode, since we would change
out_color_space to an invalid choice.
Factor common code for applying dither and changing the
out_color_space into apply_dither_mode (final name TBD). Skips
CMYK like normal decoding did before.
BUG=skia:1472
BUG=https://b.corp.google.com/issue?id=9466275
BUG=https://b.corp.google.com/issue?id=9189955
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
22290002
git-svn-id: http://skia.googlecode.com/svn/trunk@10629
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 21:02:32 +0000 (21:02 +0000)]
Fix failure exits from JPEG onBuildTileIndex.
The setjmp exited without deleting the SkJPEGImageIndex, and
another exit condition deleted the huffman index even though
it had not been created yet. Create member functions on
SkJPEGImageIndex to make the jpeg calls so it can keep track
of what has been created, and avoid destroying anything else.
Remove unnecessary lines to set values to their default values.
Move all SkJPEGImageIndex code entirely inside #ifdef ANDROID
blocks, since no piece of it is used except by ANDROID only
code.
BUG=skia:1471
R=djsollen@google.com, mtklein@google.com
Review URL: https://codereview.chromium.org/
21891007
git-svn-id: http://skia.googlecode.com/svn/trunk@10628
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 20:23:26 +0000 (20:23 +0000)]
Update GM baselines for 8888->4444 fix.
Review URL: https://codereview.chromium.org/
22621002
git-svn-id: http://skia.googlecode.com/svn/trunk@10627
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 7 Aug 2013 20:00:55 +0000 (20:00 +0000)]
Upstreaming DropShadowImageFilter into skia, from Blink
GM imagefiltersbase will need rebaselining after this change
R=senorblanco@chromium.org
Committed: https://code.google.com/p/skia/source/detail?r=10583
Review URL: https://codereview.chromium.org/
22258005
git-svn-id: http://skia.googlecode.com/svn/trunk@10626
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 19:53:53 +0000 (19:53 +0000)]
Support decoding subsets from JPG on Android.
Previously we only supported it for the framework. Making this
change allows us to test subset decoding in skimage, to make sure
we don't break it.
Will require rebaselining android skimage results.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
21612003
git-svn-id: http://skia.googlecode.com/svn/trunk@10625
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 19:43:45 +0000 (19:43 +0000)]
Fix BGRA readback on Android
R=bsalomon@google.com, robertphillips@google.com
Author: snorp@snorp.net
Review URL: https://chromiumcodereview.appspot.com/
22522002
git-svn-id: http://skia.googlecode.com/svn/trunk@10624
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 19:39:56 +0000 (19:39 +0000)]
Fix build.
Use SkIntToScalar.
Reflect that 8888 can be copied to 4444 in BitmapCopyTest.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@10623
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 7 Aug 2013 19:17:53 +0000 (19:17 +0000)]
Restore SkPath(const SkPath&) to copy the generation ID on Android.
BUG=
R=bsalomon@google.com, bungeman@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
22471002
git-svn-id: http://skia.googlecode.com/svn/trunk@10622
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 7 Aug 2013 19:16:05 +0000 (19:16 +0000)]
Add downsample from 8888 to 4444.
Extend SkBitmap::copyTo to copy from a source with
SkARGB_8888_Config to a destination bitmap with
SkARGB_4444_Config.
BUG=http://code.google.com/p/chromium/issues/detail?id=245774
R=reed@google.com
Review URL: https://codereview.chromium.org/
22350003
git-svn-id: http://skia.googlecode.com/svn/trunk@10621
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 7 Aug 2013 18:57:24 +0000 (18:57 +0000)]
More GM rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@10620
2bbb7eff-a529-9590-31e7-
b0007b416f81
dierk@google.com [Wed, 7 Aug 2013 18:12:46 +0000 (18:12 +0000)]
Rebaselining GM's for gradient GM change.
rebaselining gm's
BUG=
Review URL: https://codereview.chromium.org/
22391004
git-svn-id: http://skia.googlecode.com/svn/trunk@10619
2bbb7eff-a529-9590-31e7-
b0007b416f81
zachr@google.com [Wed, 7 Aug 2013 18:06:39 +0000 (18:06 +0000)]
add ui for mutli-rebaselining
R=epoger@google.com
Review URL: https://codereview.chromium.org/
22580004
git-svn-id: http://skia.googlecode.com/svn/trunk@10618
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 7 Aug 2013 18:04:15 +0000 (18:04 +0000)]
pdfviewer: fix font rotation issues
Review URL: https://codereview.chromium.org/
22407005
git-svn-id: http://skia.googlecode.com/svn/trunk@10617
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 17:43:05 +0000 (17:43 +0000)]
Mark dashing gpu as expected to fail on win7/gpu/intel
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
22407004
git-svn-id: http://skia.googlecode.com/svn/trunk@10616
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 7 Aug 2013 17:09:22 +0000 (17:09 +0000)]
Add getFamilyNames to SkTypeface.
Committed: https://code.google.com/p/skia/source/detail?r=10589
Committed: https://code.google.com/p/skia/source/detail?r=10592
Committed: https://code.google.com/p/skia/source/detail?r=10608
Review URL: https://codereview.chromium.org/
21716005
git-svn-id: http://skia.googlecode.com/svn/trunk@10615
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 17:03:09 +0000 (17:03 +0000)]
gm/bitmapcopy: create the bitmap in a secondary canvas, since the one in which we draw might be backed by PDF and then accessBitmap does not work.
R=borenet@google.com, jvanverth@google.com
Author: edisonn@google.com
Review URL: https://chromiumcodereview.appspot.com/
22353006
git-svn-id: http://skia.googlecode.com/svn/trunk@10614
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 7 Aug 2013 16:52:05 +0000 (16:52 +0000)]
Ignore gif_test.gif, take two. Add missing comma.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@10613
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 16:22:47 +0000 (16:22 +0000)]
Add SkCanvas::drawPosTextBounded.
This allows subclasses which need bounding box information to get it
from the caller if it has already been computed.
BUG=chromium:269080
R=reed@google.com, tomhudson@chromium.org, tomhudson@google.com
Author: jbroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22585002
git-svn-id: http://skia.googlecode.com/svn/trunk@10612
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 7 Aug 2013 16:07:43 +0000 (16:07 +0000)]
Try to ignore gif_test.gif in skimage test
git-svn-id: http://skia.googlecode.com/svn/trunk@10610
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 7 Aug 2013 15:56:51 +0000 (15:56 +0000)]
Reverting r10608 (Add getFamilyNames to SkTypeface) due to compilation failures
git-svn-id: http://skia.googlecode.com/svn/trunk@10609
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 7 Aug 2013 15:46:29 +0000 (15:46 +0000)]
Add getFamilyNames to SkTypeface.
Committed: https://code.google.com/p/skia/source/detail?r=10589
Committed: https://code.google.com/p/skia/source/detail?r=10592
Review URL: https://codereview.chromium.org/
21716005
git-svn-id: http://skia.googlecode.com/svn/trunk@10608
2bbb7eff-a529-9590-31e7-
b0007b416f81
zachr@google.com [Wed, 7 Aug 2013 15:43:04 +0000 (15:43 +0000)]
download and rebaseline images using server
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/
20654006
git-svn-id: http://skia.googlecode.com/svn/trunk@10607
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 15:35:35 +0000 (15:35 +0000)]
Allow multiple images for flaky dashing GM on intel/win7/gpu
R=epoger@google.com
Review URL: https://codereview.chromium.org/
22327004
git-svn-id: http://skia.googlecode.com/svn/trunk@10606
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 7 Aug 2013 15:30:09 +0000 (15:30 +0000)]
enable SK_FONTHOST_USES_FONTMGR for mac and win. linux fontmgr not ready
BUG=
Review URL: https://codereview.chromium.org/
22406004
git-svn-id: http://skia.googlecode.com/svn/trunk@10605
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:13 +0000 (15:22 +0000)]
Mozilla diabolical clamp case added to gm/gradients.cpp
Added diabolical clamp case.
BUG=
R=reed@google.com
Author: dierk@google.com
Review URL: https://chromiumcodereview.appspot.com/
22484002
git-svn-id: http://skia.googlecode.com/svn/trunk@10604
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:05 +0000 (15:22 +0000)]
Remove operator== from SkPaint
R=mtklein@google.com, reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/
21949007
git-svn-id: http://skia.googlecode.com/svn/trunk@10603
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 13:34:26 +0000 (13:34 +0000)]
Revert "rebaseline gpu dashing on win7"
This reverts commit r10577.
git-svn-id: http://skia.googlecode.com/svn/trunk@10602
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 13:34:14 +0000 (13:34 +0000)]
Revert "Add blend optimization helpers and use to convert rect draws to clears."
This reverts commit r10537.
git-svn-id: http://skia.googlecode.com/svn/trunk@10601
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 13:34:08 +0000 (13:34 +0000)]
Revert "Sanitizing source files in Housekeeper-Nightly"
This reverts commit r10594.
git-svn-id: http://skia.googlecode.com/svn/trunk@10600
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 7 Aug 2013 13:34:01 +0000 (13:34 +0000)]
Revert "Rebaseline flaky non AA lines on intel/win/gpu"
This reverts commit r10566.
git-svn-id: http://skia.googlecode.com/svn/trunk@10599
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 7 Aug 2013 11:56:16 +0000 (11:56 +0000)]
pdfviewer: /Pattern color space, uses the matrix of the last content stream, not the global matrix.
Review URL: https://codereview.chromium.org/
22460004
git-svn-id: http://skia.googlecode.com/svn/trunk@10595
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 7 Aug 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10594
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 7 Aug 2013 03:17:12 +0000 (03:17 +0000)]
Work around broken SkFontMgr_fontconfig.cpp for test.
git-svn-id: http://skia.googlecode.com/svn/trunk@10593
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 7 Aug 2013 02:45:25 +0000 (02:45 +0000)]
Add getFamilyNames to SkTypeface.
Committed: https://code.google.com/p/skia/source/detail?r=10589
Review URL: https://codereview.chromium.org/
21716005
git-svn-id: http://skia.googlecode.com/svn/trunk@10592
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 Aug 2013 00:07:51 +0000 (00:07 +0000)]
Move SkComposeImageFilter into its own {.h, .cpp} files
In http://crrev.com/
21154002, SkComposeImageFilter will be used
outside of tests. Consequently, this moves SkComposeImageFilter from
SkTestImageFilters.{h, cpp} into its own {.h, .cpp} files.
BUG=181613
R=senorblanco@chromium.org
Author: ajuma@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22438003
git-svn-id: http://skia.googlecode.com/svn/trunk@10591
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 23:31:44 +0000 (23:31 +0000)]
Reverting r10589: Add getFamilyNames to SkTypeface
git-svn-id: http://skia.googlecode.com/svn/trunk@10590
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 6 Aug 2013 22:53:04 +0000 (22:53 +0000)]
Add getFamilyNames to SkTypeface.
Review URL: https://codereview.chromium.org/
21716005
git-svn-id: http://skia.googlecode.com/svn/trunk@10589
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 6 Aug 2013 21:48:44 +0000 (21:48 +0000)]
pdfviewer: load image pain settings (like transparency), pass the page number, report failure if at least one render fails, and check that xref section starts with xref keyword.
Review URL: https://codereview.chromium.org/
22465006
git-svn-id: http://skia.googlecode.com/svn/trunk@10588
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 21:12:59 +0000 (21:12 +0000)]
Reverting r10583: Upstreaming DropShadowImageFilter into skia, from Blink
git-svn-id: http://skia.googlecode.com/svn/trunk@10587
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 6 Aug 2013 20:47:52 +0000 (20:47 +0000)]
Regenerate bitmaps before each draw in tilemodes_npot GM
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
22415004
git-svn-id: http://skia.googlecode.com/svn/trunk@10586
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 6 Aug 2013 20:32:29 +0000 (20:32 +0000)]
Re-organize Android scripts
Addresses https://code.google.com/p/skia/issues/detail?id=1486
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
22411004
git-svn-id: http://skia.googlecode.com/svn/trunk@10585
2bbb7eff-a529-9590-31e7-
b0007b416f81
george@mozilla.com [Tue, 6 Aug 2013 20:16:34 +0000 (20:16 +0000)]
Change SkPreConfig.h to recognise uppercase PPC/PPC64.
git-svn-id: http://skia.googlecode.com/svn/trunk@10584
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 6 Aug 2013 20:01:40 +0000 (20:01 +0000)]
Upstreaming DropShadowImageFilter into skia, from Blink
GM imagefiltersbase will need rebaselining after this change
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
22258005
git-svn-id: http://skia.googlecode.com/svn/trunk@10583
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 6 Aug 2013 19:35:48 +0000 (19:35 +0000)]
Remove invalid expectation.
Fixes build.
git-svn-id: http://skia.googlecode.com/svn/trunk@10582
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 6 Aug 2013 18:56:53 +0000 (18:56 +0000)]
Add config option to skimage.
Allows testing 565 and A8, in addition to 8888.
Also makes the preference consistent for each test (in one run).
BUG=skia:1465
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
22297007
git-svn-id: http://skia.googlecode.com/svn/trunk@10579
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 6 Aug 2013 18:51:30 +0000 (18:51 +0000)]
Do not fail skimage on missing expectations.
This will allow adding new images to test without turning the bots
red.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
22301006
git-svn-id: http://skia.googlecode.com/svn/trunk@10578
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 6 Aug 2013 18:46:56 +0000 (18:46 +0000)]
rebaseline gpu dashing on win7
git-svn-id: http://skia.googlecode.com/svn/trunk@10577
2bbb7eff-a529-9590-31e7-
b0007b416f81
george@mozilla.com [Tue, 6 Aug 2013 18:35:00 +0000 (18:35 +0000)]
Add a default value for SK_OVERRIDE in SkPostConfig.h
Review URL: https://chromiumcodereview.appspot.com/
22288002
git-svn-id: http://skia.googlecode.com/svn/trunk@10576
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 6 Aug 2013 18:32:29 +0000 (18:32 +0000)]
Annotate SK_COMPILE_ASSERT's typedef as permissibly unused, to fix GCC 4.8 build warning. Patch originally by dholbert.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
22285002
git-svn-id: http://skia.googlecode.com/svn/trunk@10575
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 18:28:25 +0000 (18:28 +0000)]
One last rebaseline to try to get Nexus-10 GMs green.
Unreviewed.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10574
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 Aug 2013 18:13:01 +0000 (18:13 +0000)]
Tweak -mssse3 on Mac a little.
Using OTHER_CPLUSPLUSFLAGS instead of OTHER_CFLAGS will append -mssse3 into the
argument list instead of overwriting as the old note warns about. (So it's
actually there twice now for the files in opts_ssse3, and we can still build if
we remove -mssse3 from common_conditions.gypi.)
We could also just delete this clause entirely given that
common_conditions.gypi sets it anyway. Which do you think is best? This code
won't compile unless _someone_ has set -mssse3. Seems to me the redundancy
helps communicate that and protect against changes in common_conditions.gypi.
BUG=
R=epoger@google.com, bungeman@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
21279005
git-svn-id: http://skia.googlecode.com/svn/trunk@10573
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 17:30:28 +0000 (17:30 +0000)]
Fix mime-type on expectations.
Rebaseline one DirectWrite GM.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10570
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 16:34:38 +0000 (16:34 +0000)]
Rebaseline Nexus-10 GMs... again.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10568
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 6 Aug 2013 16:06:14 +0000 (16:06 +0000)]
Revert Accidental commit "patch from issue
20151002"
This reverts commit r10565.
git-svn-id: http://skia.googlecode.com/svn/trunk@10567
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 6 Aug 2013 16:04:42 +0000 (16:04 +0000)]
Rebaseline flaky non AA lines on intel/win/gpu
git-svn-id: http://skia.googlecode.com/svn/trunk@10566
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 6 Aug 2013 16:04:39 +0000 (16:04 +0000)]
patch from issue
20151002
git-svn-id: http://skia.googlecode.com/svn/trunk@10565
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 6 Aug 2013 15:42:15 +0000 (15:42 +0000)]
Move toolchain setup into a function in android_setup.sh
Addresses https://code.google.com/p/skia/issues/detail?id=1486
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
22339008
git-svn-id: http://skia.googlecode.com/svn/trunk@10563
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 Aug 2013 15:07:23 +0000 (15:07 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.
Committed: http://code.google.com/p/skia/source/detail?r=10537
R=robertphillips@google.com, jvanverth@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
21877006
git-svn-id: http://skia.googlecode.com/svn/trunk@10562
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 6 Aug 2013 14:17:16 +0000 (14:17 +0000)]
Rebaseline Nexus 10 GMs
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10561
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 6 Aug 2013 13:47:54 +0000 (13:47 +0000)]
Normalize indents in android_setup.sh
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
22422002
git-svn-id: http://skia.googlecode.com/svn/trunk@10560
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 6 Aug 2013 12:20:38 +0000 (12:20 +0000)]
N7 Performance Trigger rebaselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10557
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 6 Aug 2013 12:19:38 +0000 (12:19 +0000)]
Fix race condition when locking/unlocking pixels.
R=reed@google.com
Review URL: https://codereview.chromium.org/
22235002
git-svn-id: http://skia.googlecode.com/svn/trunk@10556
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 6 Aug 2013 12:17:53 +0000 (12:17 +0000)]
Ubuntu Performance trigger rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10555
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 6 Aug 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@10554
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 5 Aug 2013 23:08:19 +0000 (23:08 +0000)]
old compiler is dumb
BUG=
Review URL: https://codereview.chromium.org/
22318002
git-svn-id: http://skia.googlecode.com/svn/trunk@10553
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 22:31:20 +0000 (22:31 +0000)]
revise SkTDynamicHash and add unit tests
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
22292004
git-svn-id: http://skia.googlecode.com/svn/trunk@10552
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 22:08:50 +0000 (22:08 +0000)]
pdfviewer: remove debug traces
Review URL: https://codereview.chromium.org/
22284004
git-svn-id: http://skia.googlecode.com/svn/trunk@10551
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 5 Aug 2013 21:47:24 +0000 (21:47 +0000)]
Rebaseline imagemagnifier GM for Nexus-4
git-svn-id: http://skia.googlecode.com/svn/trunk@10549
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 20:45:40 +0000 (20:45 +0000)]
pdfviewer: debug code for crash
Review URL: https://codereview.chromium.org/
22269002
git-svn-id: http://skia.googlecode.com/svn/trunk@10548
2bbb7eff-a529-9590-31e7-
b0007b416f81
egdaniel@google.com [Mon, 5 Aug 2013 20:43:12 +0000 (20:43 +0000)]
Separate quad UV calculation from bloat_quad
For GPU hairlines move UV calculation on vertices for quads to its
own function outside of bloat_quad. This is done since conics share
the bloat quad function and don't need to do this calcuation.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
22043006
git-svn-id: http://skia.googlecode.com/svn/trunk@10547
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 5 Aug 2013 20:29:59 +0000 (20:29 +0000)]
Remove warning comment from SkImageFilter.
R=reed@google.com
Review URL: https://codereview.chromium.org/
22236002
git-svn-id: http://skia.googlecode.com/svn/trunk@10546
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 20:25:57 +0000 (20:25 +0000)]
Minor sk_memset{16|32}_SSE2 optimization.
Using explicitly indexed references allows some compilers to generate more efficient loops. For gcc 4.6.3:
613c18: 83 ea 10 sub $0x10,%edx
613c1b: 66 0f 7f 07 movdqa %xmm0,(%rdi)
613c1f: 66 0f 7f 47 10 movdqa %xmm0,0x10(%rdi)
613c24: 66 0f 7f 47 20 movdqa %xmm0,0x20(%rdi)
613c29: 66 0f 7f 47 30 movdqa %xmm0,0x30(%rdi)
613c2e: 48 83 c7 40 add $0x40,%rdi
613c32: 83 fa 0f cmp $0xf,%edx
613c35: 7f e1 jg 613c18 <_Z16sk_memset32_SSE2Pjji+0x38>
vs. previous:
613c18: 83 ea 10 sub $0x10,%edx
613c1b: 66 0f 7f 07 movdqa %xmm0,(%rdi)
613c1f: 66 0f 7f 47 10 movdqa %xmm0,0x10(%rdi)
613c24: 66 0f 7f 47 20 movdqa %xmm0,0x20(%rdi)
613c29: 48 83 c7 40 add $0x40,%rdi
613c2d: 83 fa 0f cmp $0xf,%edx
613c30: 66 0f 7f 47 f0 movdqa %xmm0,-0x10(%rdi)
613c35: 7f e1 jg 613c18 <_Z16sk_memset32_SSE2Pjji+0x38>
This yields a 0.2% - 1% improvement with the memset micro benchmarks, presumably due to avoiding a stall on the next store after the %rdi increment.
R=reed@google.com, senorblanco@chromium.org
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
21703003
git-svn-id: http://skia.googlecode.com/svn/trunk@10545
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 19:42:56 +0000 (19:42 +0000)]
GPU Font Cache improvements:
- If a strike has multiple atlases, check all for room for a new glyph
- Mark remaining atlases unused after a purge, then check for an unused
atlas before purging (reduces TextContext flushes and ghosting)
- Hide Atlas management a little better inside AtlasMgr
R=robertphillips@google.com, bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
21594005
git-svn-id: http://skia.googlecode.com/svn/trunk@10544
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 5 Aug 2013 18:27:23 +0000 (18:27 +0000)]
Revert "Add blend optimization helpers and use to convert rect draws to clears."
This reverts commit r10537.
git-svn-id: http://skia.googlecode.com/svn/trunk@10542
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 18:18:06 +0000 (18:18 +0000)]
pdfviewer: add virtual destructor for SkPdfFont
Review URL: https://codereview.chromium.org/
22239002
git-svn-id: http://skia.googlecode.com/svn/trunk@10541
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 17:59:11 +0000 (17:59 +0000)]
pdfviewer: fix typo
Review URL: https://codereview.chromium.org/
22076007
git-svn-id: http://skia.googlecode.com/svn/trunk@10540
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 17:26:11 +0000 (17:26 +0000)]
pdfviewer: set backdround to transparent, and add an app to chop transparent content in png files.
Review URL: https://codereview.chromium.org/
21981008
git-svn-id: http://skia.googlecode.com/svn/trunk@10538
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 16:55:55 +0000 (16:55 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.
R=robertphillips@google.com, jvanverth@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
21877006
git-svn-id: http://skia.googlecode.com/svn/trunk@10537
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 16:53:50 +0000 (16:53 +0000)]
Added ctm matrix to GPU path
There should be no changes in behavior caused by this cl, it just adds the ctm matrix to filterImageGPU so that it may be used for scaling on all platforms when it is implemented on the blink side.
BUG=
R=senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22209002
git-svn-id: http://skia.googlecode.com/svn/trunk@10536
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 16:31:27 +0000 (16:31 +0000)]
Fix OverdrawFilter not set on first call to SkDebugCanvas::drawTo()
R=robertphillips@google.com
Author: egraether@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
21789005
git-svn-id: http://skia.googlecode.com/svn/trunk@10535
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 5 Aug 2013 16:23:23 +0000 (16:23 +0000)]
pdfviewer: add indexed rbg image support, enhanche caching(setData) for SkPdfObject
Review URL: https://codereview.chromium.org/
21738005
git-svn-id: http://skia.googlecode.com/svn/trunk@10534
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Mon, 5 Aug 2013 14:50:31 +0000 (14:50 +0000)]
Temporarily disable GpuTestPath.
git-svn-id: http://skia.googlecode.com/svn/trunk@10532
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 5 Aug 2013 13:38:28 +0000 (13:38 +0000)]
Enable SkUtilsArm on all ARM platforms and always use NDK compliant NEON detection on Android.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
22193002
git-svn-id: http://skia.googlecode.com/svn/trunk@10530
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 13:30:59 +0000 (13:30 +0000)]
Actually flush the path stencil transform when the matrix changes
Fixes many tests to match the master gm more closely. Examples of fixes:
mixed_xfermodes, strokes_poly, gradients_view_perspective, strokes_round,
... .
Total 58 differing results.
BUG=1479
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
22176002
git-svn-id: http://skia.googlecode.com/svn/trunk@10529
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 13:28:55 +0000 (13:28 +0000)]
Fix a crash on stroking empty paths with nv_path_rendering enabled
Fix the crash by defining that GrPathRenderer::drawPath and
GrPathRenderer::stencilPath are called only with non-empty paths.
Adds a new test "GpuDrawPath" and tests the condition.
BUG=1477
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
22173002
git-svn-id: http://skia.googlecode.com/svn/trunk@10528
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 Aug 2013 13:23:13 +0000 (13:23 +0000)]
Avoid counting verbs twice in SkPath::isEmpty()
Remove redundant call to SkPathRef::countVerbs. The intention was
probably to count points. Instead, assert that all two-verb paths
begin with a 'move' and that if the second verb is a 'line', then the
point count is indeed two.
BUG=1478
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/
22171002
git-svn-id: http://skia.googlecode.com/svn/trunk@10527
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 Aug 2013 15:09:23 +0000 (15:09 +0000)]
In preparation for make Chromium's skia.gyp use pdf.gypi.
R=edisonn@google.com, djsollen@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
21952002
git-svn-id: http://skia.googlecode.com/svn/trunk@10526
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 4 Aug 2013 15:00:58 +0000 (15:00 +0000)]
N7 Performance trigger rebaselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10525
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 2 Aug 2013 20:54:46 +0000 (20:54 +0000)]
Delete image-based rebaselining tool; we have switched to checksums
R=borenet@google.com
Review URL: https://codereview.chromium.org/
21901004
git-svn-id: http://skia.googlecode.com/svn/trunk@10524
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 2 Aug 2013 20:24:48 +0000 (20:24 +0000)]
pdfviewer: implementation of one type of pattern - simple tile patern, colored, with xstep and ystep positive.
Review URL: https://codereview.chromium.org/
21919003
git-svn-id: http://skia.googlecode.com/svn/trunk@10523
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 2 Aug 2013 19:54:28 +0000 (19:54 +0000)]
correctly copy constant coverage from GrPaint to GrDrawState
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
21924006
git-svn-id: http://skia.googlecode.com/svn/trunk@10522
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 Aug 2013 19:10:06 +0000 (19:10 +0000)]
Adds poppler and dependencies to DEPS. This is a pre-CL for
20220002, and getting DEPS committed first is necessary to get the trybots to run on the larger CL (since the trybots do 'gclient sync' before patching).
R=vandebo@chromium.org, edisonn@google.com, djsollen@chromium.org, bungeman@chromium.org, djsollen@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
21945002
git-svn-id: http://skia.googlecode.com/svn/trunk@10521
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 2 Aug 2013 19:08:52 +0000 (19:08 +0000)]
Create AJAX live-viewer of expected-vs-actual GM results
R=zachr@google.com
Review URL: https://codereview.chromium.org/
20526007
git-svn-id: http://skia.googlecode.com/svn/trunk@10520
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 2 Aug 2013 16:09:10 +0000 (16:09 +0000)]
Restore a default timer to bench_pictures.
https://codereview.chromium.org/
19862002 removed the default timer
to display from PictureBenchmark. Restore a default by putting it
in the flag description.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
21567005
git-svn-id: http://skia.googlecode.com/svn/trunk@10516
2bbb7eff-a529-9590-31e7-
b0007b416f81