Bengu Li [Tue, 21 Apr 2015 22:40:41 +0000 (15:40 -0700)]
Merge pull request #766 from libengu/cmov
Add test cases in directory Directed/cmov
Bengu Li [Tue, 21 Apr 2015 18:42:30 +0000 (11:42 -0700)]
Add test cases in directory Directed/cmov
Add test cases in directory Directed/cmov. Logical operator
tests where many of the operations emit cmov instruciton on
x86\x64. Related proj, config, and sln files added and updated.
Passed build, buildtest, runtest.
Carol Eidt [Tue, 21 Apr 2015 18:23:21 +0000 (11:23 -0700)]
Merge pull request #752 from CarolEidt/PrecedenceFixes
Issue #609 & #610: Fix precedence issues
Jan Kotas [Tue, 21 Apr 2015 05:29:04 +0000 (22:29 -0700)]
Merge pull request #754 from jkotas/unnecessaryfile
Delete unnecessary .gitmirror file
Jan Kotas [Tue, 21 Apr 2015 05:23:07 +0000 (22:23 -0700)]
Delete unnecessary .gitmirror file
Jan Kotas [Tue, 21 Apr 2015 05:21:28 +0000 (22:21 -0700)]
Merge pull request #753 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Tue, 21 Apr 2015 04:09:22 +0000 (21:09 -0700)]
Use more appropriate mirror setting for src\corefx
[tfs-changeset: 1457001]
Jan Kotas [Tue, 21 Apr 2015 02:19:46 +0000 (19:19 -0700)]
Merge pull request #745 from bartonjs/crypto-interop-library
Create native interop library System.Security.Cryptography.Native
Bengu Li [Mon, 20 Apr 2015 23:26:51 +0000 (16:26 -0700)]
Merge pull request #746 from libengu/TestCheckedCtor
Add CSharp Base/Peer Constructor test cases
Jeremy Barton [Mon, 20 Apr 2015 23:03:44 +0000 (16:03 -0700)]
Create native interop library System.Security.Cryptography.Native
Bengu Li [Mon, 20 Apr 2015 21:38:27 +0000 (14:38 -0700)]
Add CSharp Base/Peer Constructor test cases
Add CSharp Base/Peer Constructor test cases. Related proj, config,
and sln files added and updated. Passed build, buildtest, runtest.
Carol Eidt [Mon, 20 Apr 2015 19:19:29 +0000 (12:19 -0700)]
Issue #609 & #610: Fix precedence issues
Near line 6089 in importer.cpp, enforcing the precedence indicated by
the indentation resulted in no diffs, which at first seemed surprising.
However, this is because we never encounter the other mask values
without calli.
Near line 10483, this is where we convert (dup, stloc) to (stloc, ldloc).
This was clearly intended only for non-debug mode, but the original code
in the importer was like this:
if (!opts.compDbgCode &&
(nextOpcode == CEE_STLOC) ||
(nextOpcode == CEE_STLOC_S) ||
((nextOpcode >= CEE_STLOC_0) &&
(nextOpcode <= CEE_STLOC_3)))
{
insertLdloc = true;
Due to the fact that the parens don't support the apparent intended
precedence, the condition is equivalent to:
if ((!opts.compDbgCode && (nextOpcode == CEE_STLOC) ||
(nextOpcode == CEE_STLOC_S) ||
((nextOpcode >= CEE_STLOC_0) && (nextOpcode <= CEE_STLOC_3)))
Changing it the apparent original meaning caused regressions. This is
because it is often cheaper to load a local (i.e. the insertLdloc case)
than to do a dup, which may 1) cause a temp to be created to store the
value on the stack, or 2) result in a tree (e.g. a large constant) which
is cloneable but which is more expensive in code bytes than a ldloc.
The original code clearly intended to do this only in the non-debug case,
but with the incorrect parens it was doing it for any short stloc. I'm
not sure that it is 100% OK to do this transformation on dbg code, but
we've apparently been doing it for some time (it's the same way in
jit32).
Adding the apparently intended parens caused regressions (158392 bytes
over all the MCH files). The change in this shelveset has a net
improvement (3848 bytes over all jitAsmDiffs). (Doing this
transformation in all cases, i.e. just eliminating the !opts.compDbgCode,
causes zero diffs, indicating that we don't have any instances of dups
followed by non-short stlocs.)
Fix #609
Fix #610
John Chen [Mon, 20 Apr 2015 16:21:19 +0000 (09:21 -0700)]
Merge pull request #742 from dotnet-bot/from-tfs
Merge changes from TFS
John Chen [Mon, 20 Apr 2015 15:36:31 +0000 (08:36 -0700)]
Enable build crossgen.exe from build.cmd.
Adds and modifies CMakeLists.txt files to enable building of crossgen.exe from build.cmd for x64 processor on Windows. Also adds a step in build.cmd to generate native image for mscorlib.
[tfs-changeset: 1456454]
Matt Ellis [Mon, 20 Apr 2015 05:17:54 +0000 (22:17 -0700)]
Merge pull request #736 from ellismg/hardcode-utf8-in-pal
Hardcode CP_ACP to UTF-8 on Linux
Rich Lander [Sat, 18 Apr 2015 15:27:24 +0000 (08:27 -0700)]
Merge pull request #727 from richlander/rich-docs
Add Book of the Runtime docs
Jan Vorlicek [Sat, 18 Apr 2015 13:18:27 +0000 (15:18 +0200)]
Merge pull request #733 from stephentoub/temp_path
Make GetTempPathA/W first check TMPDIR
Bengu Li [Sat, 18 Apr 2015 06:15:57 +0000 (23:15 -0700)]
Merge pull request #738 from libengu/AddJITCSETests
Add JIT CSE tests
Bengu Li [Sat, 18 Apr 2015 04:39:09 +0000 (21:39 -0700)]
Add JIT CSE tests
Add JIT CSE (common sub-expression elimination) optimization tests.
Related proj, config, and sln files added and updated. Passed build,
buildtest, runtest. Code went through Microsoft internal process
to meet open-source requirements.
Jan Kotas [Sat, 18 Apr 2015 02:51:43 +0000 (19:51 -0700)]
Merge pull request #737 from janvorli/fix-div-overflow-exception
Ensure we differentiate between division by zero and overflow
Jan Vorlicek [Thu, 16 Apr 2015 12:04:29 +0000 (14:04 +0200)]
Ensure we differentiate between division by zero and overflow
This change implements parsing of the IDIV instruction operand so that
we can find whether an integer division error was a division by zero or
an integer overflow.
It replaces the previous functionality that was implemented for OSX only
and was incomplete (it didn't handle memory operands) and partially incorrect
(not handling R8..R15 properly).
dotnet-bot [Fri, 17 Apr 2015 22:06:12 +0000 (15:06 -0700)]
Add DAC Notes Book of the Runtime doc
dotnet-bot [Fri, 17 Apr 2015 20:33:56 +0000 (13:33 -0700)]
Add Threading Book of the Runtime doc
Stephen Toub [Fri, 17 Apr 2015 19:54:28 +0000 (15:54 -0400)]
Simplify a bit of logic in GetTempPathA
Matt Ellis [Wed, 1 Apr 2015 02:22:10 +0000 (19:22 -0700)]
Hardcode CP_ACP to UTF-8 on Linux
Previously, on Linux, the PAL would attempt to detect the current codepage via
setlocale and maintained a mapping from LC_TYPES to Win32 locale names.
On OSX, we didn't do any of this, instead we always used UTF-8 as the
current codepage.
This change moves to this model on Linux as well, something we want to
do because it will enable us to use Ansi marshalling during PInvoke to
marshall UTF-8 data to native code (which is common when interoping with
existing native libraries on Linux) and allows us to remove a bunch of
code we don't want to carry forward from the PAL.
Sergiy Kuryata [Fri, 17 Apr 2015 17:59:25 +0000 (10:59 -0700)]
Merge pull request #730 from josteink/freebsd-linking
CoreClr: Fix FreeBSD linking-issues.
dotnet-bot [Fri, 17 Apr 2015 16:25:02 +0000 (09:25 -0700)]
Add Profiling Book of the Runtime doc
dotnet-bot [Fri, 17 Apr 2015 04:49:33 +0000 (21:49 -0700)]
Add Exceptions Book of the Runtime doc
David Wrighton [Thu, 16 Apr 2015 21:59:15 +0000 (14:59 -0700)]
Add Type System Book of the Runtime doc
Jan Kotas [Fri, 17 Apr 2015 16:34:25 +0000 (09:34 -0700)]
Merge pull request #734 from josteink/freebsd-fpregs
Fix up final FPU-registers for FreeBSD x86_64.
Jostein Kjønigsen [Fri, 10 Apr 2015 06:09:06 +0000 (06:09 +0000)]
Fix up final FPU-registers for FreeBSD x86_64.
FreeBSD now builds without compilation errors. For FreeBSD and glory!
, ,
/( )`
\ \___ / |
/- _ `-/ '
(/\/ \ \ /\
/ / | ` \
O O ) / |
`-^--'`< '
(_.) _ ) /
`.___/` /
`-----' /
<----. __ / __ \
<----|====O)))==) \) /====
<----' `--' `.__,' \
| |
\ / /\
______( (_ / \______/
,' ,-----' |
`--{__________)
This closes https://github.com/dotnet/coreclr/issues/594#issuecomment-
93995183
Stephen Toub [Fri, 17 Apr 2015 13:09:48 +0000 (09:09 -0400)]
Make GetTempPathA/W first check TMPDIR
Today GetTempPathA/W are hardcoded to return /tmp/. This commit makes them first consult the TMPDIR environment variable, using its value if it exists.
This also overhauls the tests for GetTempPathA/W, which were out-of-date with regards to the existing implementation and which were excluded from PAL test runs.
Jostein Kjønigsen [Fri, 17 Apr 2015 08:13:28 +0000 (08:13 +0000)]
CoreClr: Fix FreeBSD linking-issues.
This fix brings the build almost up to 100% (from 35%), where it fails due to PIC-errors.
Mike McLaughlin [Fri, 17 Apr 2015 03:00:46 +0000 (20:00 -0700)]
Merge pull request #729 from mikem8361/clrstackfix
The ICorDebug version of sos ClrStack command stopped working
Jan Kotas [Fri, 17 Apr 2015 00:08:29 +0000 (17:08 -0700)]
Merge pull request #723 from janvorli/fix-dangling-else
Fix dangling else warnings
Mike McLaughlin [Thu, 16 Apr 2015 23:46:49 +0000 (16:46 -0700)]
The ICorDebug version of sos ClrStack command ("sos ClrStack -i") stopped working. The existing was enumerating
all the modules in the target process to find the coreclr module, but under linux we just picked the first module found
because given just the base address of the module, it isn't easy to determine correct module given the context and
constrains the debugshim code ran. We were lucky and picked the correct module but now the order has changed
which broke this command.
The fix is to just get the address for coreclr and create the ICorDebug interface from that instead of enumerating all the modules.
Jan Kotas [Thu, 16 Apr 2015 23:44:16 +0000 (16:44 -0700)]
Merge pull request #701 from janvorli/fix-freebsd-rc-issue
Fix .rc processing issue on FreeBSD
Jan Kotas [Thu, 16 Apr 2015 23:43:20 +0000 (16:43 -0700)]
Merge pull request #726 from janvorli/fix-copyright-headers
Add missing MIT license headers
Jan Vorlicek [Thu, 16 Apr 2015 23:35:47 +0000 (01:35 +0200)]
Fix the return macro on Windows
There seems to be a bug in the VC++ compiler that causes the
following error to occur:
ex.cpp(492): fatal error C1061: compiler limit : blocks nested too deeply
There seems to be no nesting when I look at preprocessed source of the ex.cpp
and it builds fine on Unix.
To make the Windows build happy, I have left the return macro definition
for MSVC as it was before my change and only changed it for other compilers.
Jan Kotas [Thu, 16 Apr 2015 23:08:24 +0000 (16:08 -0700)]
Merge pull request #721 from pgavlin/CorWarnings
Fix two sources of warnings in cor{,info}.h
Jan Kotas [Thu, 16 Apr 2015 23:02:12 +0000 (16:02 -0700)]
Merge pull request #724 from ellismg/use-libcoreclr-for-some-apis
PInvoke to libcoreclr for three APIs
Matt Ellis [Thu, 16 Apr 2015 22:32:31 +0000 (15:32 -0700)]
Merge pull request #722 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Vorlicek [Thu, 16 Apr 2015 22:00:58 +0000 (00:00 +0200)]
Add missing MIT license headers
.rc and .def files were missing the MIT license headers, so this
change adds them.
Matt Ellis [Thu, 16 Apr 2015 21:33:00 +0000 (14:33 -0700)]
PInvoke to libcoreclr for three APIs
After pulling the PAL out of the runtime, we redirected all the PInvokes
which were going to libcoreclr to libcoreclrpal. It turns out that
CoTaskMemAlloc, CoTaskMemFree and CoCreateGuid are still exported by the
runtime itself and not the PAL.
Update the three PInvokes for these functions from managed code to point
at the runtime itself.
Jan Vorlicek [Thu, 16 Apr 2015 21:29:48 +0000 (23:29 +0200)]
Fix dangling else warnings
This change fixes all dangling else warnings and removes the
compiler flag that was disabling their reporting.
Jan Vorlicek [Thu, 16 Apr 2015 20:49:19 +0000 (22:49 +0200)]
Merge pull request #691 from josteink/freebsd-threading
PAL: Fix threading on FreeBSD.
Sedar Gokbulut [Thu, 16 Apr 2015 20:44:15 +0000 (13:44 -0700)]
Fix for the build break. I had moved UAP Host under a folder whcih is built only for x86. I'm changing the dirs.proj's to build the UAPHost for all architectures.
I verified that UAPHost gets built on x86coresys and armcoresys, whille VSIntegration and MSBuildTask folders gets built only on x86coresys.
[tfs-changeset: 1454192]
Pat Gavlin [Thu, 16 Apr 2015 20:26:55 +0000 (13:26 -0700)]
Fix two sources of warnings in cor{,info}.h
- cor.h was incorrectly casting a pointer-to-const to a
pointer-to-non-const.
- corinfo.h contained a 0-sized array, which is not standard C++,
and therefore generates a warning on compilers without MSVC
extensions enabled. Using a 1-sized array (which is already done
elsewhere in the same file) prevents this warning.
Jostein Kjønigsen [Mon, 13 Apr 2015 07:35:54 +0000 (07:35 +0000)]
PAL: Fix threading on FreeBSD.
Matt Ellis [Thu, 16 Apr 2015 18:23:29 +0000 (11:23 -0700)]
Merge pull request #719 from ellismg/preload-pal-from-corerun
Explicitly load libcoreclrpal in corerun
Matt Ellis [Thu, 16 Apr 2015 17:58:41 +0000 (10:58 -0700)]
Explicitly load libcoreclrpal in corerun
libcoreclr has a dependency on libcoreclrpal, but libcoreclrpal is
usually not on the path the loader probes, since it is SxS with the
runtime itself.
Instead of forcing LD_LIBRARY_PATH to be set just have corerun load the
PAL from the same folder as the runtime before loading libcoreclr.
Fixes #709
Jan Kotas [Thu, 16 Apr 2015 13:39:55 +0000 (06:39 -0700)]
Merge pull request #718 from janvorli/cleanup-safecrt
Cleanup safecrt in PAL
Jan Vorlicek [Thu, 16 Apr 2015 12:48:04 +0000 (14:48 +0200)]
Cleanup safecrt in PAL
The safecrt code in PAL was heavily sprinkled with #ifdefs for POSITIONAL_PARAMETERS
(that we never define) and _SAFECRT_IMPL (which is always defined in the PAL code).
This change cleans that up by removing checks of those ifdefs.
Also, I've found that the src/pal/src/safecrt/crtdefs.h is not used anywhere,
so I am removing it as well.
Rich Lander [Thu, 16 Apr 2015 01:38:41 +0000 (18:38 -0700)]
Merge pull request #714 from richlander/rich-readme
Update README to accomodate wiki move
Jan Vorlicek [Thu, 16 Apr 2015 01:26:21 +0000 (03:26 +0200)]
Merge pull request #716 from janvorli/fix-tailcall
Fix issue with the disabled tail calls via helpers
Jan Vorlicek [Thu, 16 Apr 2015 00:58:28 +0000 (02:58 +0200)]
Fix issue with the disabled tail calls via helpers
This change fixes an issue that occured after I've disabled tail calls via
helpers. The problem was that the goto to NO_TAIL_CALL needs to happen
before the GTF_CALL_M_TAILCALL flag is set, otherwise the jitter
doesn't emit any call.
Jan Vorlicek [Thu, 16 Apr 2015 00:27:46 +0000 (02:27 +0200)]
Merge pull request #715 from janvorli/remove-long-double
Remove long double support from safecrt routines in PAL
Jan Kotas [Thu, 16 Apr 2015 00:15:29 +0000 (17:15 -0700)]
Merge pull request #713 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Vorlicek [Wed, 15 Apr 2015 23:53:17 +0000 (01:53 +0200)]
Remove long double support from safecrt routines in PAL
This change removes the long double support from the safecrt
printf style routines in PAL. The existing support was effectively
disabled anyways, we didn't have similar support in the non-safe
printf style functions and coreclr has no need to print long doubles.
Rich Lander [Wed, 15 Apr 2015 23:43:18 +0000 (16:43 -0700)]
Update README to accomodate wiki move
Pallavi Taneja [Wed, 15 Apr 2015 23:38:11 +0000 (16:38 -0700)]
This change makes System.Runtime.InteropServices.FormatterSerives public and __DynamicallyInvokable to unblock serialization engine that reflects on this type during deserializatoin. This is import to unblock the F5 debugging using coreclr bits.
[tfs-changeset: 1453460]
Rich Lander [Wed, 15 Apr 2015 23:19:30 +0000 (16:19 -0700)]
Merge pull request #712 from bendono/dnx-doc
Fixed several grammar and spelling mistakes.
Ben Monroe [Wed, 15 Apr 2015 21:31:32 +0000 (06:31 +0900)]
Fixed several grammar and spelling mistakes.
Rich Lander [Wed, 15 Apr 2015 17:55:55 +0000 (10:55 -0700)]
Merge pull request #662 from richlander/rich-wiki
Move subset of wiki files to coreclr repo
Matt Mitchell [Wed, 15 Apr 2015 14:51:21 +0000 (07:51 -0700)]
Merge pull request #707 from ellismg/fix-689
Use "x64" and not "amd64" in build.sh
Jan Kotas [Wed, 15 Apr 2015 10:22:38 +0000 (03:22 -0700)]
Merge pull request #706 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Ellis [Wed, 15 Apr 2015 07:44:22 +0000 (00:44 -0700)]
Use "x64" and not "amd64" in build.sh
The help text for build.sh said that you should pass "x64" as a
paramter for the build architecture. However, the script was looking
for amd64. Update the script to look for x64 since that's what we use
everywhere else (and the behavior you got if you didn't pass an
argument to this script.)
Fixes #689
Sedar Gokbulut [Wed, 15 Apr 2015 05:11:02 +0000 (22:11 -0700)]
Moving UAP Host sources out from coreclr\hosts to where it'll be residing together with other UAP components
[tfs-changeset: 1452859]
Mike McLaughlin [Wed, 15 Apr 2015 04:59:08 +0000 (21:59 -0700)]
Merge pull request #705 from ellismg/mscorlib-pal-rename
Update PAL name
Matt Ellis [Wed, 15 Apr 2015 01:56:24 +0000 (18:56 -0700)]
Rename "CoreClrPal" to "coreclrpal"
Simply change the case of the library the PAL lives in so that is all
lowercase.
Matt Ellis [Wed, 15 Apr 2015 00:55:10 +0000 (17:55 -0700)]
Update PAL name
As of
19d02824, the Win32 functions exported by the PAL are now in
libCoreClrPal instead of libcoreclr itself. Update mscorlib's PInvokes
to match this change.
Mike McLaughlin [Tue, 14 Apr 2015 23:57:21 +0000 (16:57 -0700)]
Merge pull request #704 from mikem8361/sharepal
Create shared PAL module and change all the modules to use it
Mike McLaughlin [Tue, 14 Apr 2015 19:29:13 +0000 (12:29 -0700)]
Create shared PAL module and change all the debugger modules and coreclr to use it.
Richard Lander [Sun, 12 Apr 2015 23:51:23 +0000 (16:51 -0700)]
Rename and re-title wiki documents
Richard Lander [Wed, 1 Apr 2015 18:28:06 +0000 (11:28 -0700)]
Change pathing in documentation to match build update
Matthew Whilden [Wed, 1 Apr 2015 00:28:44 +0000 (17:28 -0700)]
Adding note about installing mono packages built from source and not from the official location
Richard Lander [Tue, 14 Apr 2015 21:03:09 +0000 (14:03 -0700)]
Update Windows instructions
Richard Lander [Sat, 11 Apr 2015 19:56:41 +0000 (12:56 -0700)]
Update instructions to match Linux
Jan Kotas [Wed, 25 Mar 2015 02:34:49 +0000 (19:34 -0700)]
Updated Linux instructions
Jan Vorlicek [Tue, 24 Mar 2015 19:58:45 +0000 (20:58 +0100)]
Updated Linux instructions
Richard Lander [Tue, 24 Mar 2015 18:06:36 +0000 (11:06 -0700)]
Rename OSX instructions
Matt Ellis [Thu, 19 Mar 2015 20:53:37 +0000 (13:53 -0700)]
Updated Linux instructions
Richard Lander [Tue, 17 Mar 2015 16:26:34 +0000 (09:26 -0700)]
Improve readability of Linux instructions
Richard Lander [Mon, 16 Mar 2015 07:18:26 +0000 (00:18 -0700)]
Initial OS X instructions
Richard Lander [Tue, 14 Apr 2015 21:02:50 +0000 (14:02 -0700)]
Correct test instructions
- Correct running test instructions
- Add links for Linux and Mac OS X builds.
Matt Ellis [Wed, 4 Mar 2015 23:08:55 +0000 (15:08 -0800)]
Updated Building and Running CoreCLR on Linux
Jan Vorlicek [Fri, 20 Feb 2015 23:33:52 +0000 (00:33 +0100)]
Updated Building and Running CoreCLR on Linux
AlexGhiondea [Fri, 20 Feb 2015 20:18:14 +0000 (12:18 -0800)]
Created Testing across repos
Jan Kotas [Sat, 7 Feb 2015 20:22:18 +0000 (12:22 -0800)]
Updated Building and Running CoreCLR on Linux
Matt Ellis [Sat, 7 Feb 2015 00:05:49 +0000 (16:05 -0800)]
Created Building and Running CoreCLR on Linux
Jan Kotas [Tue, 14 Apr 2015 20:01:23 +0000 (13:01 -0700)]
Merge pull request #702 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Tue, 14 Apr 2015 20:00:55 +0000 (13:00 -0700)]
Merge pull request #703 from janvorli/implement-jit-tailcall
Disable JIT_TailCall invocation on Unix
Matt Ellis [Tue, 14 Apr 2015 17:14:26 +0000 (10:14 -0700)]
Mirror subfolders for unixcorerun.
My previous change introduced a new subfolder to unixcorerun, but I forgot to update the .gitmirror file to a .gitmirrrorall file.
[tfs-changeset: 1452317]
Mike McLaughlin [Tue, 14 Apr 2015 16:51:19 +0000 (09:51 -0700)]
Merge pull request #697 from mikem8361/dactablefix
Add back security class vtables to dac global table
Jan Vorlicek [Tue, 14 Apr 2015 15:35:44 +0000 (17:35 +0200)]
Fix .rc processing issue on FreeBSD
This change fixes issue that occurs on FreeBSD when compiling the
.rc files into the gettext format. For some reason, the shell
expression evaluation returns the resulting resource id as a string
datatype. That leads to a failure when trying to format the result
as a hex number using sprintf.
The change ensures that if that happens, the type is changed to numeric.
Jan Kotas [Tue, 14 Apr 2015 15:36:25 +0000 (08:36 -0700)]
Merge pull request #699 from jkotas/readonlycollections
Enable generic IReadOnlyCollection interfaces on array for Unix
Jan Vorlicek [Tue, 14 Apr 2015 11:32:51 +0000 (13:32 +0200)]
Disable JIT_TailCall invocation on Unix
This change prevents jitter from performing tail calls in case the tail call
would require a tailcall helper.
The reason is that we don't have the JIT_TailCall function implemented for Unix
and even if we did, the underlying function to copy the arguments, the
StubLinkerCPU::CreateTailCallCopyArgsThunk, would be difficult to port to Unix due
to the fact that it assumes that va_list is represented as the parameters
being placed in memory one after another while on Unix, it is an opaque structure.
Jan Kotas has recommended to disable this kind of tail calls on Unix and
create a work item to refactor the way these tail calls are implemented.
Besides these Unix specific issues, the current implementation has performance
and maintainability issues, according to Jan Kotas.
Jan Vorlicek [Tue, 14 Apr 2015 08:18:57 +0000 (10:18 +0200)]
Merge pull request #696 from stephentoub/path_invalid_chars
Update Path.InvalidFileNameChars on Unix
Jan Kotas [Tue, 14 Apr 2015 07:29:57 +0000 (00:29 -0700)]
Merge pull request #694 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Tue, 14 Apr 2015 07:25:45 +0000 (00:25 -0700)]
Enable generic IReadOnlyCollection interfaces on array for Unix
IReadOnlyCollection support on array was incorrectly enabled for COM interop only