André Roth [Thu, 18 Sep 2014 18:59:27 +0000 (15:59 -0300)]
libdvbv5: MPEG TS parser documentation
Add javadoc markups at mpeg_ts.h, in order to generate documentation.
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
André Roth [Thu, 18 Sep 2014 19:00:13 +0000 (16:00 -0300)]
libdvbv5: use hyperlinks in doxygen PDF
Hyperlinks make the produced PDF nicer to use.
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Mauro Carvalho Chehab [Thu, 18 Sep 2014 09:38:19 +0000 (06:38 -0300)]
libdvbv5: Create doxygen docs for mpeg_es.h
While here, fix two typos and add documentation for a missing
var.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
André Roth [Wed, 17 Sep 2014 20:02:24 +0000 (22:02 +0200)]
libdvbv5: MPEG ES parser documentation
Documents the table parser for the MPEG-TS Elementary Stream.
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Tue, 16 Sep 2014 00:19:38 +0000 (21:19 -0300)]
libdvbv5: revert an ABI breakage
While changeset
a2c7b05cf8d7 kept the same API, it broke ABI,
as a binary-compiled utility would complain about some missing
symbols:
+#MISSING: 1.4.0+r2502-63~ubuntu14.10.1# dvb_fe_open2@Base 1.4.0
+#MISSING: 1.4.0+r2502-63~ubuntu14.10.1# dvb_fe_open@Base 1.4.0
So, return the inline functions back to the library.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Hans Verkuil [Mon, 15 Sep 2014 12:14:31 +0000 (14:14 +0200)]
v4l-helpers.h: fix control ioctls checks
Fix the check whether certain control ioctls exist. This should work
better with older kernels that return -EINVAL if an ioctl does not
exist.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Hans Verkuil [Mon, 15 Sep 2014 12:04:45 +0000 (14:04 +0200)]
v4l2-ctl: fix control support for old kernels.
For old kernels that return -EINVAL if QUERY_EXT_CTRL does not exist
no controls are reported anymore. Add an explicit test whether
QUERY_EXT_CTRL exists.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 17:29:36 +0000 (14:29 -0300)]
update dvb-fe-tool Doxygen documentation
The documentation for dvb-fe-tool is currently outdated.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 15:01:45 +0000 (12:01 -0300)]
dvb-fe-tool: implement acoustic mode
if --accoustical is used, it will produce a bip whose frequency
is function of the received signal.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 16:44:12 +0000 (13:44 -0300)]
dvb-fe-tool: Colorize the status report
Using different colors to represent different QoS helps the user
when adjusting an antena.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 16:43:54 +0000 (13:43 -0300)]
libdvbv5: export dvb_fe_retrieve_quality()
This function can be useful outside. So, export it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 16:18:26 +0000 (13:18 -0300)]
libdvbv5: Re-add the status name at the stats report
Changeset
d3558a8a8e made the status to disappear.
The main issue that it were trying to fix is that the len were
calculated wrong, but the reason is because len is a pointer,
so it should have been incremented as a pointer, with:
*len += size
This patch fix it properly, and make the status name to reappear.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 14:39:01 +0000 (11:39 -0300)]
libdvbv5: fix a nasty bug when printing stats
Depending on the stats condition, the statistics line is not
printed, because the buffer pointer is incremented twice.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 13:59:39 +0000 (10:59 -0300)]
dvb-fe-tool: add femon parameter
Add a parameter to do frontend monitoring.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 13:49:58 +0000 (10:49 -0300)]
libdvbv5: Don't double-free the file name
At some error conditions at dvb-fe.c, dvb_v5_free() is called,
plus an extra free(). This causes a core dump, due to
double-free. Remove the extra free().
While here, improve the error message when the ENUM_DELSYS
doesn't work fine.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 13:14:24 +0000 (10:14 -0300)]
dvb-fe-tool: add support to open DVB FE in read only mode
This tool can be used to inspect the frontend. So, add support
to open an already opened frontend.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 14 Sep 2014 12:52:29 +0000 (09:52 -0300)]
libdvbv5: Add support for opening FE on read only mode
Currently, all frontend opens happen on R/W mode. That
prevents some types of usage where it is desired to just
monitor an interface without touching it, like what femon
does.
So, add a new method to allow doing that.
Ideally, we should also add (or fix/check) support for
O_NONBLOCK mode, but this would require more efforts.
So, for now, add a todo entry about that.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
André Roth [Sat, 13 Sep 2014 21:00:36 +0000 (18:00 -0300)]
libdvbv5: fix dvb_fe_dummy()
initialize the parms structure correctly
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
André Roth [Sat, 13 Sep 2014 20:08:28 +0000 (17:08 -0300)]
libdvbv5: fix satellite LNBf handling
the LNBf is part of the public structure, remove it from
dvb_v5_fe_parms_priv.
fix typo for C++.
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
André Roth [Sat, 13 Sep 2014 20:08:27 +0000 (17:08 -0300)]
libdvbv5: cleanup logging, some memory checks
- use loginfo in hexdump
- use C comments
- memory checking in desc_sat and desc_service
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 13 Sep 2014 15:25:36 +0000 (12:25 -0300)]
Add support for VDR format (only for output)
VDR has its own special format, that doesn't fit into the normal
oneline parsers. So, it requires its own code to parse.
Add support for it, as used on vdr 2.1.6.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 13 Sep 2014 12:16:58 +0000 (09:16 -0300)]
libdvbv5: fix a typo at ASTRA 1E extended LNBf
Instead of EXTENDED, it was written EXTENDEDU.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 13 Sep 2014 11:50:41 +0000 (08:50 -0300)]
dvb-fe-tool: Fix verbosity and comment unused option
dvb-fe-tool is too verbose when setting a new delivery system,
or when getting parameters.
Also, the random property set is currently not implemented.
Comment its code.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 13 Sep 2014 11:33:38 +0000 (08:33 -0300)]
doxygen: add dvbv5-tools to the documentation
The dvbv5-tools are good examples on how to use the library.
Add them to the documentation.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 13 Sep 2014 11:32:01 +0000 (08:32 -0300)]
libdvbv5: add a missing macro to dvb_table group for documentation
Minor fix: one of the macros of atsc_eit.h to the dvb_table
group.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Hans Verkuil [Sat, 13 Sep 2014 09:48:44 +0000 (11:48 +0200)]
cv4l-helpers: add missing ioctls
This adds all remaining relevant ioctls to the cv4l_fd class.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Hans Verkuil [Sat, 13 Sep 2014 09:08:34 +0000 (11:08 +0200)]
qv4l2: the helper now zeroes bytesperline
So we no longer need to do it in qv4l2.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Hans Verkuil [Sat, 13 Sep 2014 09:07:40 +0000 (11:07 +0200)]
(c)v4l-helpers: zero bytesperline, swap arg order
When calling try/s_fmt optionally zero bytesperline.
Also swap the order of the last two arguments of v4l_format_s_bytesperline
and v4l_format_s_sizeimage to be consistent with other helper functions.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Gregor Jasny [Fri, 12 Sep 2014 11:26:36 +0000 (13:26 +0200)]
buildsystem: Use latest ax_prog_doxygen from GNU Autoconf Archive
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Mauro Carvalho Chehab [Fri, 12 Sep 2014 01:51:27 +0000 (22:51 -0300)]
libdvbv5: group documentation into modules
In order to help digging into the documentation, put each
documented block into a group.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 12 Sep 2014 00:26:09 +0000 (21:26 -0300)]
libdvbv5 documentation review
General cleanup at the libdvbv5 documentation, in order to fix
some minor issues.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 22:35:56 +0000 (19:35 -0300)]
libdvbv5: add support for mgt.h
With that, all tables are documented via doxygen.
We're still missing documentation for the desc_*.h headers.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 22:20:16 +0000 (19:20 -0300)]
libdvbv5: add documentation for cat.h and atsc_header.h
Add tags for doxygen to process those two headers.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 21:16:31 +0000 (18:16 -0300)]
libdvbv5: don't use DVB_DESC_HEADER() macro
This macro was a very bad idea, as it causes doxygen to produce
wrong data. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 20:37:46 +0000 (17:37 -0300)]
libdvbv5: don't use ATSC_HEADER() macro
This macro was a very bad idea, as it causes doxygen to produce
wrong data. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 20:28:40 +0000 (17:28 -0300)]
libdvbv5: add documentation for ATSC EIT.
ATSC EIT is different than the DVB EIT table. Document it, and
be sure that the DVB EIT table will be better described.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 18:50:43 +0000 (15:50 -0300)]
libdvbv5: Add a mainpage to the documentation
Let's add a mainpage to the documentation, and do some
cleanup on other pages.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 17:38:09 +0000 (14:38 -0300)]
libdvbv5: Add documentation for EIT DVB parser
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 16:56:13 +0000 (13:56 -0300)]
libdvbv5: add documentation for crc32.h
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 16:47:38 +0000 (13:47 -0300)]
libdvbv5: add documentation for the NIT table parser
Add doxygen documentation for nit.h.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 16:47:24 +0000 (13:47 -0300)]
libdvbv5: some documentation fixups for sdt.h
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 16:09:43 +0000 (13:09 -0300)]
libdvbv5: add documentation for sdt.h
Add doxygen documentation for the contents of sdt.h.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 16:09:34 +0000 (13:09 -0300)]
libdvbv5: fix some issues at PAT documentation
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 15:47:42 +0000 (12:47 -0300)]
libdvbv5: better comment the descriptors
Add a @brief to each descriptor at descriptors.h, explaining from
what spec the descriptor came.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 02:19:24 +0000 (23:19 -0300)]
libdvbv5: add doxygen tags to pmt.h
Add documentation for the MPEG-TS PMT table parser
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 15:22:59 +0000 (12:22 -0300)]
libdvbv5: fix some cut-and-paste errors at documentation
Forgot to rename some fields while cut-and-pasting from vct.h.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 01:47:46 +0000 (22:47 -0300)]
doxygen_libdvbv5.cfg: add header.h, vct.h and pat.h
Add those 3 headers to doxygen documentation generator.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 01:47:23 +0000 (22:47 -0300)]
libdvbv5: add doxygen tags to pat.h
Add documentation for the MPEG-TS table parser
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 01:15:35 +0000 (22:15 -0300)]
libdvbv5: add doxygen tags to vct.h
Add documentation for the ATSC VCT table parser
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Thu, 11 Sep 2014 01:14:50 +0000 (22:14 -0300)]
libdvbv5: add doxygen tags for header.h
Add documentation for the MPEG-TS headers.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Hans Verkuil [Wed, 10 Sep 2014 07:14:03 +0000 (09:14 +0200)]
v4l2-compliance: fix buffer state test
This test checks that a buffer can only be in a single state,
i.e. it can't be both QUEUED and DONE. But it also counted ERROR
as a separate state, but that's incorrect. ERROR is a separate
flag, independent of state.
Fix this test accordingly.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Gregor Jasny [Mon, 8 Sep 2014 07:40:27 +0000 (09:40 +0200)]
Start v4l-utils 1.5.0 development cycle
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Mon, 8 Sep 2014 06:58:54 +0000 (08:58 +0200)]
Prepare for 1.4.0 release
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 18:07:29 +0000 (15:07 -0300)]
libdvbv5 doxygen: Some improvements for dvb-scan.h and descriptors.h
There are some troubles caused by a wrong macro expansion at
doxygen. Fix them.
Also, tag the code examples as such.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 14:51:58 +0000 (11:51 -0300)]
libdvbv5: Add more data about the descriptors definition
Better document descriptors.h by adding the specs used by the
descriptors found on this header at the javadoc macro.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Gregor Jasny [Sun, 7 Sep 2014 17:35:11 +0000 (19:35 +0200)]
ir-keytable: Genrate stable map file by sorting directory before parsing
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Sun, 7 Sep 2014 16:59:21 +0000 (18:59 +0200)]
v4l2-ctl: Distribute vivid-tpg.h.patch
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Sun, 7 Sep 2014 16:55:21 +0000 (18:55 +0200)]
media-ctl: process pkgconfig files
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Sun, 7 Sep 2014 16:51:04 +0000 (18:51 +0200)]
contrib: Add au0828 directory to extra distribution list
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Sun, 7 Sep 2014 16:46:50 +0000 (18:46 +0200)]
libdvbv5: Add dvb-fe-priv.h to sources list
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Gregor Jasny [Sun, 7 Sep 2014 16:40:56 +0000 (18:40 +0200)]
libdvbv5: Add doxygen config file to distribution list
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 14:45:46 +0000 (11:45 -0300)]
libdvbv5: add documentation for descriptors.h
Add javadoc headers to document the content of descriptors.h,
and makes doxygen to generate the data (almost) properly.
Not sure why, but struct dvb_descriptor is not being
parsed properly by doxygen.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 14:03:46 +0000 (11:03 -0300)]
libdvbv5: get rid of bcd_to_int()
This function used to be needed by some descriptors, but it
is now unused. Remove it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 14:02:33 +0000 (11:02 -0300)]
libdvbv5: Provide a quality indicator for DVB-T
Add a logic to provide a quality indicator for DVB-T
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 13:44:19 +0000 (10:44 -0300)]
libdvbv5: Fix dvb_get_pmt_pid()
A previous patch broke it, by not renaming the name of the
file descriptor. Also, don't close the descriptor on error.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 13:21:05 +0000 (10:21 -0300)]
libdvbv5 doxygen: Fix a few file descriptions
Some file descriptions weren't ok. Fix them.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 12:24:00 +0000 (09:24 -0300)]
libdvbv5: improve doxygen documentation
Add more tags to the header files, in order to improve the
documentation output.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 11:48:35 +0000 (08:48 -0300)]
libdvbv5: fix dvb_get_pmt_pid API
All functions on the demux API uses an opened fd, except for
dvb_get_pmt_pid() that were using a filename.
Change it to make the API coherent.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 05:22:44 +0000 (02:22 -0300)]
libdvbv5: Properly document macros at dvb-v5-std.h
Macros require some special things to be properly parsed
by doxygen.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 05:15:19 +0000 (02:15 -0300)]
libdvbv5: Fix function definitions at doxygen book
Parsing functions require some changes, otherwise the files
aren't properly parsed by doxygen.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 04:25:13 +0000 (01:25 -0300)]
Ignore the generate doxygen-doc directory
This directory is autogenerated by the doxygen targets.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 04:16:15 +0000 (01:16 -0300)]
libdvbv5: Improve doxygen format
Use a better template to generate Doxygen documentation.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 02:16:44 +0000 (23:16 -0300)]
Add support to generate Doxygen documentation for libdvbv5
Add a way to auto-generate documentation for libdvbv5 using
Doxygen.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 01:10:29 +0000 (22:10 -0300)]
libdvbv5: Convert documentation to javadoc format
We were using the documentation format as described inside
the Kernel. However, using javadoc format makes easier for
some tools like doxygen to parse. So, use it instead.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 03:28:38 +0000 (00:28 -0300)]
libdvbv5: Document the last undocumented structs at dvb-file.h
With this addition, Doxygen should now be able to generate
documentation for all structs at the selected files.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 00:23:47 +0000 (21:23 -0300)]
libdvbv5: Document the libdvbv5 properties
Document the userspace properties defined inside libdvbv5.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sun, 7 Sep 2014 00:01:03 +0000 (21:01 -0300)]
libdvbv5: add documentation for the DVB scan functions
Explain how the DVB scan functions should be used, and
provide some usage examples.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 23:29:27 +0000 (20:29 -0300)]
libdvbv5: remove unused parameter at dvb_scan_alloc_handler_table()
The verbose parameter is never used. Remove it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 22:46:01 +0000 (19:46 -0300)]
libdvbv5: Remove an unused parameter at struct dvb_v5_descriptors
verbose field is only initialized but never used. Remove it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 22:32:34 +0000 (19:32 -0300)]
libdvbv5: Document dvb-log.h and dvb-sat.h
Add documentation to those two additional headers.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 21:49:22 +0000 (18:49 -0300)]
libdvbv5: Add documentation for other functions at dvb-file.h
Add description for the functions related to properties filling,
and ancillary functions at dvb-file.h.
The only two functions missing descriptions are the ones that
are mostly internal to the library (yet, they might be useful
externally, so let's keep them at the public header).
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 16:11:51 +0000 (13:11 -0300)]
libdvbv5: add documentation about format read/write functions
Document the most useful functions to read/write DVB channel
files.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 15:56:38 +0000 (12:56 -0300)]
libdvbv5: move PTABLE macro to the *.c files
This macro is not generic enough to be part of the library.
Also, its name can cause conflicts with other packages.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 15:40:23 +0000 (12:40 -0300)]
libdvbv5: rename enum file_formats to dvb_file_formats
file_formats is a too generic name, and can conflict with some
other symbol defined on another library.
So, rename it to dvb_file_formats.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 15:32:50 +0000 (12:32 -0300)]
dvb-file.h: prepend parsing structs with "dvb_"
In order to avoid possible conflicts with other APIs, let's
prepend everything with dvb_.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 15:02:51 +0000 (12:02 -0300)]
libdvbv5: Add a description for DVB file entries
Start documenting the contents of dvb-file.h. On this patch,
adds documentation to the structs that are visible by
most libdvbv5 applications.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 14:34:15 +0000 (11:34 -0300)]
libdvbv5: rename struct el_pid
This name is not good enough, as this struct name is
visible outside the DVB API. So, better name it.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 13:47:31 +0000 (10:47 -0300)]
libdvbv5: add documentation for dvb-demux.h
Now that we're exposing the library, better to have some
documentation for it.
While here, update the copyrights at the header.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 05:24:08 +0000 (02:24 -0300)]
dvbv5-zap: remove an unused var
status var is never used at get_show_stats().
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 05:13:44 +0000 (02:13 -0300)]
dvbv5-zap: Be sure to get stats before printing
On several places, the application is just showing the last value.
Be sure to refresh the stats before printing.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 04:51:10 +0000 (01:51 -0300)]
dvbv5-zap: keep monitoring stats at DVB record mode
Instead of just waiting, keep monitoring the DVB stats.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 03:24:43 +0000 (00:24 -0300)]
libdvbv5: fix a corner case reported by Coverity
As Coverity reports:
305 if (table->size) {
306 for (j = 0; j < table->size; j++)
>>> CID 1237263: Dereference after null check (FORWARD_NULL)
>>> Passing null pointer "p" to "strcasecmp", which dereferences it.
307 if (!table->table[j] || !strcasecmp(table->table[j], p))
308 break;
This actually never happens in practice, as table->size is always
zero when the default_value is set (with is the only case where
the code can be called.
Yet, to avoid potential future issues, add an extra check if
the pointer p is valid.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Sat, 6 Sep 2014 03:28:50 +0000 (00:28 -0300)]
libdvbv5: Fix the property limits check
As reported by Coverity:
474 if (cmd >= DTV_USER_COMMAND_START && cmd <= DTV_MAX_STAT_COMMAND)
>>> CID 1237264: Out-of-bounds read (OVERRUN)
>>> Overrunning array "dvb_user_attr_names" of 13 8-byte elements at element index 260 (byte offset 2080) using index "cmd - 256" (which evaluates to 260).
475 return dvb_user_attr_names[cmd - DTV_USER_COMMAND_START];
476 return NULL;
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 18:50:43 +0000 (15:50 -0300)]
libdvbv5: make sure that all needed properties are filled
Sometimes, some DVB files don't have all properties. Instead of
not initializing them and causing latter problems, initialize
such vars with default values.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 16:03:44 +0000 (13:03 -0300)]
libdvbv5: add support for PLS code/mode for file read/write
Those parameters are found on some DVB-S2 tables at the
dtv-scan-tables. Those aren't used by libdvbv5, but we need to
parse, in order to preserve those fields when reading/writing
files with the legacy format.
So, add partial support for them.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 16:00:37 +0000 (13:00 -0300)]
libdvbv5: MIS default should be zero
On DVB-S2, when MIS is not specified, that means that it should
be equal to zero. Fix it at the legacy import logic.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 15:49:17 +0000 (12:49 -0300)]
libdvbv5: use default values if an entry is missing
On optional properties, instead of generating an error, just
use the default value on writing.
Also fixes a bug where it goes past the end of the table, when
a property is not found.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 14:51:53 +0000 (11:51 -0300)]
libdvbv5: avoid checking past data
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 14:42:44 +0000 (11:42 -0300)]
libdvbv5: Fix the error message when a props is not found
The acessed data when a property is not found on write
format oneline is wrong. Use dvb_cmd_name() to get the right
one, and uses the field that came from table->prop.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Mauro Carvalho Chehab [Fri, 5 Sep 2014 14:24:23 +0000 (11:24 -0300)]
libdvbv5: Add MIS to DVB-S2 properties
MIS is a property of DVB-S2 standard. Add it to the
list of the valid properties.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>