platform/upstream/dotnet/runtime.git
5 years agoTest for Exception.ToString() calling derived implementation (dotnet/corefx#37960)
Dan Moseley [Fri, 31 May 2019 23:38:29 +0000 (16:38 -0700)]
Test for Exception.ToString() calling derived implementation (dotnet/corefx#37960)

* Test for Exception.ToString()

* Ensure Message is not present

Commit migrated from https://github.com/dotnet/corefx/commit/0d2ee6c1db6038adb776565af81ff944423a6fb3

5 years agoEnsure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)
Cory Nelson [Fri, 31 May 2019 23:25:33 +0000 (16:25 -0700)]
Ensure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)

* Resolves dotnet/corefx#30747 ensuring pointer alignment.

* Make mods unsigned so optimizer will translate them to AND. Use BitOperations.RotateRight rather than custom implementation.

* Reduce code size; improve perf on unaligned data.

* Fix length check.

* Address review suggestions:

Use MemoryMarshal.GetReference rather than pinning the span directly.
Add Debug.Assert() to improve maintainability.
Prefer a larger indent mountain over goto.

Commit migrated from https://github.com/dotnet/corefx/commit/9ec6bfa8c5045fb2c0affe8870ea238ca5f57f37

5 years agoAdded test cases for Activator.CreateInstance<T> (dotnet/corefx#38032)
Yoh Deadfall [Fri, 31 May 2019 23:24:39 +0000 (02:24 +0300)]
Added test cases for Activator.CreateInstance<T> (dotnet/corefx#38032)

Commit migrated from https://github.com/dotnet/corefx/commit/0837ff6ca8e494ac7a8c64316b2ce28744f42223

5 years agoFix mutating static issue (dotnet/corefx#38124)
Jeremy Kuhne [Fri, 31 May 2019 22:34:21 +0000 (15:34 -0700)]
Fix mutating static issue (dotnet/corefx#38124)

The default options static was getting mutated. Moving to ReadStack which doesn't have this issue.

Commit migrated from https://github.com/dotnet/corefx/commit/a39a2bf44291880935121c9e656cffd35b1ef250

5 years agoadd support for 100-continue for H/2 (dotnet/corefx#36884)
Tomas Weinfurt [Fri, 31 May 2019 21:39:12 +0000 (14:39 -0700)]
add support for 100-continue for H/2 (dotnet/corefx#36884)

* expect100

* updates

* remove dead code

* fix tests

* use configured value for allowExpect100ToContinue timer

* feedback from review

* dispose expect100Timer

* feedback from review

* feedback from review

* feedback from review

* small updates to sync up with master changes

* add concurent send/recive and more tests

* fix netfx

* feedback from review

* feedback from review

* feedback from review

* feedback from review

* feedback from review

* kick ci

Commit migrated from https://github.com/dotnet/corefx/commit/b4fa2006c2e9757e4446e3fdad413bdbf265eedc

5 years ago Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection...
Santiago Fernandez Madero [Fri, 31 May 2019 21:31:55 +0000 (14:31 -0700)]
 Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet/corefx#35772)" (dotnet/corefx#38115)

* Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet/corefx#35772)"

This reverts commit dotnet/corefx@b705522753f09d501762cca6c45d6bd031c112d7.

* Baseline API Compat errors

* Fix baseline vs netstandard

Commit migrated from https://github.com/dotnet/corefx/commit/d2506266dffcf6d83af11d192fa87435048614cb

5 years agoAdd support for immutable dictionaries (dotnet/corefx#37710)
Layomi Akinrinade [Fri, 31 May 2019 20:59:08 +0000 (16:59 -0400)]
Add support for immutable dictionaries (dotnet/corefx#37710)

* Add support for immutable dictionaries

* Some clean up

* Address review comments

* Address review comments

* Remove commented out code

* Move object property infos to JsonSerializerOptions

* Re-add immutable test

* Cache IsImmutableDict bool

* More immutable support

* Modify processing enumerable or dictionary check

* Correct handle end dictionary checks

* Re-add dict tests

* React to changes from master

Commit migrated from https://github.com/dotnet/corefx/commit/616b849f801f3124b2f64919b03601233eaa9124

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38099)
dotnet-maestro[bot] [Fri, 31 May 2019 20:25:15 +0000 (13:25 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38099)

* Update dependencies from https://github.com/dotnet/coreclr build 20190530.2

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19280.2
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19280.2
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19280.2

* Expose, test, and use Environment.TickCount64

* Back out change to WinInetProxyHelper.cs

Commit migrated from https://github.com/dotnet/corefx/commit/06f25eaa8592b49c65373d0cdcbdac9a4bdf0f35

5 years agofixing image Convertion from icon (dotnet/corefx#38108)
Anirudh Agnihotry [Fri, 31 May 2019 19:02:41 +0000 (12:02 -0700)]
fixing image Convertion from icon (dotnet/corefx#38108)

Commit migrated from https://github.com/dotnet/corefx/commit/fd90e2845c688115d1ddb54a05a2c16a7f8710a5

5 years agoAdd JsonSerializer overload that takes Utf8JsonReader. (dotnet/corefx#38088)
Ahson Khan [Fri, 31 May 2019 18:57:15 +0000 (11:57 -0700)]
Add JsonSerializer overload that takes Utf8JsonReader. (dotnet/corefx#38088)

* Initial commit of serializer overload that takes reader.

* Move utf8jsonreader api to a new file.

* Add more reader tests and update some exception cases.

* Add start of WriteValue API.

* Add the new files that were missed in previous commit.

* Remove writer related changes.

Commit migrated from https://github.com/dotnet/corefx/commit/1c1b78f7ec1d04aeac059d3d4e4c975d3a3ad23e

5 years agoAdd (de)serialization support for Base64 string as Byte array (dotnet/corefx#38106)
Steve Harter [Fri, 31 May 2019 18:55:12 +0000 (11:55 -0700)]
Add (de)serialization support for Base64 string as Byte array (dotnet/corefx#38106)

* Add (de)serialization for Base64 string as Byte array

* Review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/a7ad25c7749cbd8ede10119a2e0ab43276192d8e

5 years agoCheck regex timeout in loops and repetitions (dotnet/corefx#38091)
Viktor Hofer [Fri, 31 May 2019 18:51:09 +0000 (20:51 +0200)]
Check regex timeout in loops and repetitions (dotnet/corefx#38091)

* Check regex timeout in loops and repetitions

Check the regex timeout in SetLoop and SetRepetition opcodes to avoid
the timeout not being handled.

* PR feedback and fix OOM

Commit migrated from https://github.com/dotnet/corefx/commit/40f031a7c7a8241f92a9f6d7f269dc99228d2893

5 years agoUpdate package index and harvest props to reflect WinHttpHandler update (dotnet/coref...
Santiago Fernandez Madero [Fri, 31 May 2019 18:50:12 +0000 (11:50 -0700)]
Update package index and harvest props to reflect WinHttpHandler update (dotnet/corefx#38083)

* Update package index and harvest props to reflect WinHttpHandler updte

* Fix packageIndex

* Update Package index for missing stable package 4.3.3 entry

Commit migrated from https://github.com/dotnet/corefx/commit/e7987803c5b9b5d57d3f98b242839a826a19a00d

5 years agoAdd tests for double-encoded URLs to both UrlDecode() methods (dotnet/corefx#37881)
William Godbe [Fri, 31 May 2019 18:48:31 +0000 (11:48 -0700)]
Add tests for double-encoded URLs to both UrlDecode() methods (dotnet/corefx#37881)

* Add tests for double-encoded URLs to both UrlDecode() methods

* Make test cases more clear

Commit migrated from https://github.com/dotnet/corefx/commit/b2fd315c40330e09d34d269792884f6544ab3fe6

5 years agoAdding net461 target to Microsoft.Bcl.* packages (dotnet/corefx#38104)
Jose Perez Rodriguez [Fri, 31 May 2019 18:43:52 +0000 (11:43 -0700)]
Adding net461 target to Microsoft.Bcl.* packages (dotnet/corefx#38104)

* Adding net461 target to Microsoft.Bcl.* packages

* Adding System.Text.Json net461 target as well

Commit migrated from https://github.com/dotnet/corefx/commit/fdab38c206fe545b53d043f81be574cdbe9b5b8c

5 years agoRemoving the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41...
Tanner Gooding [Fri, 31 May 2019 18:40:07 +0000 (11:40 -0700)]
Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class (dotnet/corefx#38102)

* Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class

* Adding a MatchingRefApiCompatBaseline for System.Runtime.Intrinsics

Commit migrated from https://github.com/dotnet/corefx/commit/39c1f79962039f605cf00700df003e26788757c2

5 years ago[System.Text.Json]Improve error output for unsupported scenarios in System.Text.Json...
Marco Rossignoli [Fri, 31 May 2019 18:33:00 +0000 (20:33 +0200)]
[System.Text.Json]Improve error output for unsupported scenarios in System.Text.Json.Serialization (dotnet/corefx#38061)

* custom exception for parameterless constructors

* add polymorphic interface exception

* fix ReflectionMaterializer

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/792eb85f70a7060777b7cc0c0ef860a3e6f69090

5 years agoFix IPv6Address parsing (dotnet/corefx#37734)
William Godbe [Fri, 31 May 2019 16:34:10 +0000 (09:34 -0700)]
Fix IPv6Address parsing (dotnet/corefx#37734)

* Fix IPv6Address parsing

* Update src/System.Net.Primitives/src/System/Net/IPAddressParser.cs

Co-Authored-By: Karel Zikmund <karelz@microsoft.com>
* Use System.Diagnostics, Remove duplicate function, fix method header in Fake

* Fix deletion of call to Parse()

* Fix call to Parse()

* Fix tests to account for NetFx runs

* Fix Syntax

Commit migrated from https://github.com/dotnet/corefx/commit/f8c382f76955e8da9f0cf314d5945a5af34d72b7

5 years ago Fix Loop in System.Private.Uri (dotnet/corefx#38076)
William Godbe [Fri, 31 May 2019 16:33:19 +0000 (09:33 -0700)]
 Fix Loop in System.Private.Uri (dotnet/corefx#38076)

* Fix Loop in System.Private.Uri

* Mark variables in test project as private

* Disable test on NetFx

Commit migrated from https://github.com/dotnet/corefx/commit/0f2fa63930a26fbb70fbb6601c6d23c9c263d08b

5 years agoskip oledb for outerloop failures (dotnet/corefx#38090)
Maryam Ariyan [Fri, 31 May 2019 15:36:59 +0000 (08:36 -0700)]
skip oledb for outerloop failures (dotnet/corefx#38090)

Commit migrated from https://github.com/dotnet/corefx/commit/8b590bc41ebbb7f51f733f40e04e03e8619ca23a

5 years agoDisable ObjectTests.Write test (dotnet/corefx#38101)
Stephen Toub [Fri, 31 May 2019 15:27:03 +0000 (11:27 -0400)]
Disable ObjectTests.Write test (dotnet/corefx#38101)

Commit migrated from https://github.com/dotnet/corefx/commit/24e256f364e4a2133b03dbe9b0a3ee0069eb77b9

5 years agousing double to avoild multplication overflow (dotnet/corefx#38079)
Anirudh Agnihotry [Fri, 31 May 2019 15:17:45 +0000 (08:17 -0700)]
using double to avoild multplication overflow (dotnet/corefx#38079)

Commit migrated from https://github.com/dotnet/corefx/commit/655be420da4094ffed95ffa661a37225a3d7c6c9

5 years agoUpdate ProjectNTfs to beta-27731-00 (dotnet/corefx#38089)
dotnet-maestro-bot [Fri, 31 May 2019 13:13:21 +0000 (06:13 -0700)]
Update ProjectNTfs to beta-27731-00 (dotnet/corefx#38089)

Commit migrated from https://github.com/dotnet/corefx/commit/0d09364875814e037304dc783516600498ca553b

5 years agoMerge pull request dotnet/corefx#38013 from lmolkova/lmolkova/fixActivityIdWorngFlags
Noah Falk [Fri, 31 May 2019 09:59:01 +0000 (02:59 -0700)]
Merge pull request dotnet/corefx#38013 from lmolkova/lmolkova/fixActivityIdWorngFlags

Fix wrong Activity.Id serialization - flags are not inherited from parent

Commit migrated from https://github.com/dotnet/corefx/commit/46ed80dc71d2b449a7db8c86f9cf14d175f8fead

5 years agoAdd Base64 APIs to Utf8JsonReader, Utf8JsonWriter, and JsonElement (dotnet/corefx...
Ahson Khan [Fri, 31 May 2019 05:13:31 +0000 (22:13 -0700)]
Add Base64 APIs to Utf8JsonReader, Utf8JsonWriter, and JsonElement (dotnet/corefx#38048)

* Add Utf8JsonWriter Base64 APIs.

* Add Utf8JsonReader Base64 APIs.

* Add JsonElement Base64 APIs.

* Update API shape based on review.

* Auto-generate the ref assembly.

* Address PR feedback so far.

* Add escaping step and update length counters accordingly.

* Add JsonWriter API tests.

* Add JsonReader and JsonElement tests.

Commit migrated from https://github.com/dotnet/corefx/commit/82408cd90f4d4573d502e8df2ca437b35e6a37f7

5 years agoAdd read ahead logic for streams. (dotnet/corefx#38039)
Jeremy Kuhne [Fri, 31 May 2019 05:00:36 +0000 (22:00 -0700)]
Add read ahead logic for streams. (dotnet/corefx#38039)

* Add read ahead logic for streams.

When reading a jaon object or array from a stream into an object we need to TrySkip to ensure that we have all the needed data for the JsonDocument to create a JsonElement. This is only necessary  if we haven't already drained the stream.

* Track state correctly

We need to track consumed separately so we can requeue the reader properly after skipping. Add more stream tests.

* Clarify comments and other feedback.

* Fix comment

Commit migrated from https://github.com/dotnet/corefx/commit/f6b010d2a0bdab94953d519a60d882ff805eea36

5 years agoSimplify DbProviderFactory feature detection code. (dotnet/corefx#38070)
Bradley Grainger [Fri, 31 May 2019 02:43:33 +0000 (19:43 -0700)]
Simplify DbProviderFactory feature detection code. (dotnet/corefx#38070)

Commit migrated from https://github.com/dotnet/corefx/commit/5a611ecf50891df3201a94372a4f622a9d4cfa30

5 years agoSystem.Text.Json is not inbox on netfx (dotnet/corefx#38077)
William Godbe [Fri, 31 May 2019 00:50:28 +0000 (17:50 -0700)]
System.Text.Json is not inbox on netfx (dotnet/corefx#38077)

Commit migrated from https://github.com/dotnet/corefx/commit/40983e222a2fe12156360550275f89155a3cfc9c

5 years agoMerge pull request dotnet/corefx#37972 from ViktorHofer/NSTestRemoval
Viktor Hofer [Thu, 30 May 2019 22:26:01 +0000 (00:26 +0200)]
Merge pull request dotnet/corefx#37972 from ViktorHofer/NSTestRemoval

Replace netstandard test project tfms with implementations

Commit migrated from https://github.com/dotnet/corefx/commit/30ca4113ed07fc78060a0c9d3f95eee4fe8f8ee3

5 years agoMerge remote-tracking branch 'upstream/master' into NSTestRemoval
Viktor Hofer [Thu, 30 May 2019 22:21:15 +0000 (00:21 +0200)]
Merge remote-tracking branch 'upstream/master' into NSTestRemoval

Commit migrated from https://github.com/dotnet/corefx/commit/1743e47216aa698ffe91148f4db2078accf6030a

5 years agoPR feedback nits
Viktor Hofer [Thu, 30 May 2019 22:19:45 +0000 (00:19 +0200)]
PR feedback nits

Commit migrated from https://github.com/dotnet/corefx/commit/13ad3d0b841a611e775f51bd66375c9587584a72

5 years agoChange JsonException.Path to be a json-based path (dotnet/corefx#37938)
Steve Harter [Thu, 30 May 2019 21:44:37 +0000 (14:44 -0700)]
Change JsonException.Path to be a json-based path (dotnet/corefx#37938)

Commit migrated from https://github.com/dotnet/corefx/commit/02f649e60f3a8ea0b947ea0eaf64f2fa3c287816

5 years agoFixing issue where assemblies would build againsta lower version of a contract than...
Jose Perez Rodriguez [Thu, 30 May 2019 21:30:02 +0000 (14:30 -0700)]
Fixing issue where assemblies would build againsta lower version of a contract than what their package depends on. (dotnet/corefx#37993)

Commit migrated from https://github.com/dotnet/corefx/commit/8ce7c476a07f4f9d753906927beac93981aff301

5 years agoUsing reflection to add handler for user preference events (dotnet/corefx#37853)
Anirudh Agnihotry [Thu, 30 May 2019 20:15:16 +0000 (13:15 -0700)]
Using reflection to add handler for user preference events (dotnet/corefx#37853)

* using reflection to add handler for user preference events

* adding comments, correcting typo and using GetType

* adding debug.asserts

* pushing down color translator

* using open unbound delegate pointing directly to getter method of the eventargs category property

* No longer using colorTable on netcoreapp 2.1 in system.Drawing.Common

* reverting the use of extension method.

* doing  s_color check first and adding null check for category getter

* missing semicolon

* improving comments and adding tests

* removing extra using

* using already defined known color

* skipping the test on nano and non-windows platform

* introducing a custom property

Commit migrated from https://github.com/dotnet/corefx/commit/d24b3e33e66bfd0733f9c01fa810336d76a8872f

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38057)
dotnet-maestro[bot] [Thu, 30 May 2019 19:15:38 +0000 (15:15 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38057)

* Update dependencies from https://github.com/dotnet/coreclr build 20190529.4

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19279.4
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19279.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19279.4

* Expose TrimEndingDirectorySeparator

* Disable new tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/88f4967b84d20f6ea6da037cef6fd82119e76900

5 years agoAddress leftover feedback related to Skip/TrySkip APIs. (dotnet/corefx#38044)
Ahson Khan [Thu, 30 May 2019 19:14:53 +0000 (12:14 -0700)]
Address leftover feedback related to Skip/TrySkip APIs. (dotnet/corefx#38044)

* Address leftover feedback related to Skip/TrySkip APIs.

* Add some more commas.

* Fix comment nit.

Commit migrated from https://github.com/dotnet/corefx/commit/0aad50252f0f6e3e62fc050f2c4e6225005b6b63

5 years agoUpdate float converter and related tests (dotnet/corefx#37894)
Steve Harter [Thu, 30 May 2019 14:35:25 +0000 (07:35 -0700)]
Update float converter and related tests (dotnet/corefx#37894)

Commit migrated from https://github.com/dotnet/corefx/commit/adc16f3d53b18467d5ed92fd1b988b0c21901ab9

5 years agoHarden failing EventLog.Clear test
Viktor Hofer [Thu, 30 May 2019 13:14:44 +0000 (15:14 +0200)]
Harden failing EventLog.Clear test

Commit migrated from https://github.com/dotnet/corefx/commit/97d29c9a1a4a23607b328925fbd5b2cfca7eb0b4

5 years agoDisable building tests on uapaot
Viktor Hofer [Thu, 30 May 2019 10:04:19 +0000 (12:04 +0200)]
Disable building tests on uapaot

Commit migrated from https://github.com/dotnet/corefx/commit/32086409d0ca7441048ac4790496195765d1b583

5 years agoAdd validation target for netstandard
Viktor Hofer [Thu, 30 May 2019 03:02:40 +0000 (05:02 +0200)]
Add validation target for netstandard

Commit migrated from https://github.com/dotnet/corefx/commit/7c51e15fab50e8b3492d80dbc6b8a15db744dfa1

5 years agoReplace netstandard test projects with tfms
Viktor Hofer [Mon, 27 May 2019 23:01:17 +0000 (01:01 +0200)]
Replace netstandard test projects with tfms

Netstandard test projects are broken by design and don't support the
Microsoft.Net.Test.SDK. Replacing the netstandard tfm with the concrete
implementation tfms.

Commit migrated from https://github.com/dotnet/corefx/commit/d29c16c99c6045ee67444a7a693dd4476861c463

5 years agoCache the escaped property names (dotnet/corefx#37909)
Steve Harter [Thu, 30 May 2019 13:41:20 +0000 (06:41 -0700)]
Cache the escaped property names (dotnet/corefx#37909)

* Cache the escaped property names

* don't pass JsonEncodedText by reference

Commit migrated from https://github.com/dotnet/corefx/commit/7a76510746112df1d4d4b97609df2fc9bd47d30a

5 years agoAdd feature detection properties to DbProviderFactory
Shay Rojansky [Thu, 30 May 2019 10:50:02 +0000 (12:50 +0200)]
Add feature detection properties to DbProviderFactory

CanCreateDataAdapter, CanCreateCommandBuilder

Closes dotnet/corefx#35564

Commit migrated from https://github.com/dotnet/corefx/commit/60d65afa0160a0b27e8df6b8f450ead8ab7f4214

5 years agoAdd async methods in System.Data.Common, implement IAsyncDisposable
Shay Rojansky [Thu, 30 May 2019 09:13:53 +0000 (11:13 +0200)]
Add async methods in System.Data.Common, implement IAsyncDisposable

Closes dotnet/corefx#35012

Commit migrated from https://github.com/dotnet/corefx/commit/22dd87ec3c17dfdc09469dfc222b384ac8c553a2

5 years agoIgnore some System.Runtime tests on Mono (dotnet/corefx#37358)
Egor Bogatov [Thu, 30 May 2019 11:12:54 +0000 (14:12 +0300)]
Ignore some System.Runtime tests on Mono (dotnet/corefx#37358)

* Add SkipOnTargetFramework(Mono) here and there

Commit migrated from https://github.com/dotnet/corefx/commit/75329f4886ca235119014c8724e1e8af94b8e37a

5 years agoHandle nullable attributes on platforms that lack them
Stephen Toub [Thu, 30 May 2019 05:05:11 +0000 (01:05 -0400)]
Handle nullable attributes on platforms that lack them

Commit migrated from https://github.com/dotnet/corefx/commit/b2097cbdcb26f7f317252334ddcce101a20b7f3d

5 years agoUpdate ProjectNTfs to beta-27730-00 (dotnet/corefx#38045)
dotnet-maestro-bot [Thu, 30 May 2019 11:09:22 +0000 (04:09 -0700)]
Update ProjectNTfs to beta-27730-00 (dotnet/corefx#38045)

Commit migrated from https://github.com/dotnet/corefx/commit/f121f062a25796292eaf4da8074e8b4c3dda55ee

5 years agoHttpCorrelationProtocol docs update: Add notice about W3C trace-context and deprecate...
Liudmila Molkova [Thu, 30 May 2019 03:37:52 +0000 (20:37 -0700)]
HttpCorrelationProtocol docs update: Add notice about W3C trace-context and deprecate flat-id spec (dotnet/corefx#38025)

* Update HttpCorrelationProtocol.md

Commit migrated from https://github.com/dotnet/corefx/commit/e23119d577e644d2c2a25419c88c1181681358e0

5 years agoRemove source package related comments on internal APIs and csproj/props file. (dotne...
Ahson Khan [Thu, 30 May 2019 03:28:27 +0000 (20:28 -0700)]
Remove source package related comments on internal APIs and csproj/props file. (dotnet/corefx#38004)

* Remove source package related xml comments on internal APIs.

* Update comments in csproj and related files to remove source package.

* Add some more json reader tests around different json numbers.

Commit migrated from https://github.com/dotnet/corefx/commit/0110344cd384bcfaffed2385cd9df87d956bd68b

5 years agoDisable warning suppressions related to missing XML comments within (dotnet/corefx...
Ahson Khan [Thu, 30 May 2019 03:25:13 +0000 (20:25 -0700)]
Disable warning suppressions related to missing XML comments within (dotnet/corefx#38037)

S.T.Json.

Commit migrated from https://github.com/dotnet/corefx/commit/a2afbfffc439b775086aeca71951312e15c8281e

5 years agoEnable Microsoft.Diagnostics.Runtime to be used by tests
Stephen Toub [Thu, 30 May 2019 01:41:03 +0000 (21:41 -0400)]
Enable Microsoft.Diagnostics.Runtime to be used by tests

Commit migrated from https://github.com/dotnet/corefx/commit/1a60edc784c89a8370d1f9539944f5c95261e7a8

5 years agoUpdate to use alpine3.9 in PRs
Viktor Hofer [Wed, 29 May 2019 17:08:27 +0000 (19:08 +0200)]
Update to use alpine3.9 in PRs

Commit migrated from https://github.com/dotnet/corefx/commit/aa9db0538e8407f94fd780652dca05e82256fa0c

5 years agoEnable MaxConnectionsPerServer_WaitingConnectionsAreCancelable again (dotnet/corefx...
Tomas Weinfurt [Thu, 30 May 2019 02:33:18 +0000 (19:33 -0700)]
Enable MaxConnectionsPerServer_WaitingConnectionsAreCancelable again (dotnet/corefx#37933)

* enable MaxConnectionsPerServer_WaitingConnectionsAreCancelable afain

* skip with curl handler

Commit migrated from https://github.com/dotnet/corefx/commit/c6fc43c6f2b92d8e13a444217f29368159e015eb

5 years agoMerge pull request dotnet/corefx#37900 from ViktorHofer/MoveToolsConfig
Viktor Hofer [Wed, 29 May 2019 23:57:43 +0000 (01:57 +0200)]
Merge pull request dotnet/corefx#37900 from ViktorHofer/MoveToolsConfig

Move dotnet-tools config

Commit migrated from https://github.com/dotnet/corefx/commit/bd492f2084f9c6be6af5338f29a54e1c3bc65599

5 years agoRemove some dependencies from source build (dotnet/corefx#37730)
Eric StJohn [Wed, 29 May 2019 23:32:10 +0000 (16:32 -0700)]
Remove some dependencies from source build (dotnet/corefx#37730)

* Remove some dependencies from source build

* Add back GenAPI for sourcebuild

We cannot remove GenAPI as it is needed for generating platform-not-supported
assemblies.

We will need handle this differently.  The tentative plan is that sourcebuild
will have two phases.  During the first phase we can use GenAPI and generate
source for not-supported assemblies and save it off in some location.  In the
second phase of source build (OfflineBuild=true) we won't use GenAPI and instead
will read the sources from this location.

Commit migrated from https://github.com/dotnet/corefx/commit/ecfb60b67d09b992f24af0625305299710bc128f

5 years agoMerge branch 'master' into MoveToolsConfig
Viktor Hofer [Wed, 29 May 2019 22:55:24 +0000 (00:55 +0200)]
Merge branch 'master' into MoveToolsConfig

Commit migrated from https://github.com/dotnet/corefx/commit/693be82ccc0cac5c66aad0b37a9c3ac9263233ce

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38020)
dotnet-maestro[bot] [Wed, 29 May 2019 21:28:48 +0000 (17:28 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38020)

* Update dependencies from https://github.com/dotnet/coreclr build 20190528.71

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19278.71
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19278.71
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19278.71

* Expose nullable attributes

* Fix several nullable warnings due to nullable attribute changes

* Adjust build for ProjectNtfs bits not being current

Commit migrated from https://github.com/dotnet/corefx/commit/a977a24310055828d789520377b555ffd5df2835

5 years agoAdd test to validate dotnet/corefx#37567. (dotnet/corefx#38030)
Jeremy Kuhne [Wed, 29 May 2019 21:13:53 +0000 (14:13 -0700)]
Add test to validate dotnet/corefx#37567. (dotnet/corefx#38030)

Commit migrated from https://github.com/dotnet/corefx/commit/8ab18539bf0591f0e726cd295c3e06d1434eec14

5 years agoAdd test to validate dotnet/corefx#36167 is fixed. (dotnet/corefx#38029)
Jeremy Kuhne [Wed, 29 May 2019 21:09:55 +0000 (14:09 -0700)]
Add test to validate dotnet/corefx#36167 is fixed. (dotnet/corefx#38029)

Commit migrated from https://github.com/dotnet/corefx/commit/1e642d1107f05268545e59533a4fe77ea2cdf303

5 years agoAdd readonly modifiers to SequenceReader. (dotnet/corefx#37718)
Jeremy Kuhne [Wed, 29 May 2019 21:09:09 +0000 (14:09 -0700)]
Add readonly modifiers to SequenceReader. (dotnet/corefx#37718)

* Add readonly modifiers to SequenceReader.

Clearly marking where we don't mutate faciliates passing stack allocated spans and allows composing additional helpers that also want to describe that they don't mutate.

* Address some feedback

* Cache length again

* Change to compare to < 0

* put back the private field stripped out by the tool

* Add dummy primitive for SequenceReader

Commit migrated from https://github.com/dotnet/corefx/commit/0bae12c1967eaee2f1b20421df768e70d73da69c

5 years agoimprove reliability of HttpListenerFactory by verifying that Connect works (dotnet...
Tomas Weinfurt [Wed, 29 May 2019 20:56:49 +0000 (13:56 -0700)]
improve reliability of HttpListenerFactory by verifying that Connect works (dotnet/corefx#38009)

Commit migrated from https://github.com/dotnet/corefx/commit/c04be1ef5bf77f370ff7282a7bd6bf0342ea54b8

5 years agoRe-generate System.Collections ref assembly against implementation (dotnet/corefx...
Santiago Fernandez Madero [Wed, 29 May 2019 20:54:26 +0000 (13:54 -0700)]
Re-generate System.Collections ref assembly against implementation (dotnet/corefx#38005)

Commit migrated from https://github.com/dotnet/corefx/commit/837efeb37d25146f73d22952d4bbf84c1b216bcd

5 years agoAvoid .ToArray() in JsonSerializer .NET Standard implementation (dotnet/corefx#37976)
Adam Sitnik [Wed, 29 May 2019 16:58:07 +0000 (09:58 -0700)]
Avoid .ToArray() in JsonSerializer .NET Standard implementation (dotnet/corefx#37976)

* PooledBufferWriter<T> is always used as byte buffer, make it PooledByteBufferWriter to be able to call stream.Write(bytes)

* avoid expensive .ToArray in .NET Standard implementation

* rename

Commit migrated from https://github.com/dotnet/corefx/commit/e3a4edabd12b5f7dc9be20136cc867bbe67f1f7c

5 years agoExclude xunit.core.dll
Viktor Hofer [Wed, 29 May 2019 16:13:52 +0000 (18:13 +0200)]
Exclude xunit.core.dll

Commit migrated from https://github.com/dotnet/corefx/commit/f5cf3f1093fa49e2e40ca4d32f9eb79d8b5983ab

5 years agoMerge branch 'MoveToolsConfig' of https://github.com/ViktorHofer/corefx into MoveTool...
Viktor Hofer [Wed, 29 May 2019 15:53:21 +0000 (17:53 +0200)]
Merge branch 'MoveToolsConfig' of https://github.com/ViktorHofer/corefx into MoveToolsConfig

Commit migrated from https://github.com/dotnet/corefx/commit/6ff8890ea77087e7315436dd96306d6c2442877e

5 years agoRemove SSL cancellation workaround from SocketsHttpHandler (dotnet/corefx#37990)
Stephen Toub [Wed, 29 May 2019 15:30:52 +0000 (11:30 -0400)]
Remove SSL cancellation workaround from SocketsHttpHandler (dotnet/corefx#37990)

Both sockets cancellation and SslStream auth cancellation have been implemented.

Commit migrated from https://github.com/dotnet/corefx/commit/46800900077920534038be00d7bc73236e1a5fa7

5 years agoBase64 encoding with simd-support (dotnet/corefx#34529)
Günther Foidl [Wed, 29 May 2019 15:29:31 +0000 (17:29 +0200)]
Base64 encoding with simd-support (dotnet/corefx#34529)

* Optimized scalar code-path

* Fixed label names

* Implemented vectorized versions

* Added reference to source of algorithm

* Added back missing namespace

* Unsafe.Add instead of Unsafe.Subtract

Fixed build-failure (https://ci3.dot.net/job/dotnet_corefx/job/master/job/linux-musl-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/8247/console)
Seems like the internal Unsafe doesn't have a Subtract method, so use Add instead.

* Added THIRD-PARTY-NOTICES

* PR Feedback

* THIRD-PARTY-NOTICES in repo-base instead instead in folder

Cf. https://github.com/dotnet/corefx/pull/34529#issuecomment-453510246

* PR Feedback

* https://github.com/dotnet/corefx/pull/34529#discussion_r247200659
* https://github.com/dotnet/corefx/pull/34529#discussion_r247214904

* Rewritten to use raw-pointers instead of GC-tracked refs

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r247197669

* Initialized the static fields directly (i.e. w/o cctor)

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r247193419

* Added a test for decoding a (encoded) Guid

The case with decoding encoded 16 bytes was not covered by tests, so a wrong code got commited before, resulting
in DestinationTooSmall instead of the correct Done.

* EncodingMap / DecodingMap as byref instead of pointer

So got rid of the `rep stosd` in the prolog. Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r248075157

* PR Feedback

* https://github.com/dotnet/corefx/pull/34529#discussion_r262165689

* Debug.Fail instead throwing for the assertion

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r263894301

* ROSpan for static data

* ROS for lookup maps

* In decode avoided stack spill and hoisted zero-vector outside the loops

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287613894

* Assert assumption about destLength

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287605561

* Added comments from original source and some changes to variable names

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287606634 and https://github.com/dotnet/corefx/pull/34529#discussion_r287606714

* Use TestZ instead of MoveMask in AVX2-path

Cf. https://github.com/dotnet/corefx/pull/34529#discussion_r287825385

* Fixed too complicated mask2F creation

Improved the version done in dotnet/corefx@c8b6cb3387ca856f52d246ad260172c8fe1d9dcd, so the static data isn't needed and code is more compact and readable.

Commit migrated from https://github.com/dotnet/corefx/commit/036e0a64bd190e80f1685c3b267e495b03bb2962

5 years agoReact to xunit runner changes in arcade
Viktor Hofer [Wed, 29 May 2019 12:09:24 +0000 (14:09 +0200)]
React to xunit runner changes in arcade

Commit migrated from https://github.com/dotnet/corefx/commit/78aa3760d304388f0e66d1d4e87c0f638fec0c7f

5 years agoMove dotnet-tools config
Viktor Hofer [Thu, 23 May 2019 17:41:11 +0000 (19:41 +0200)]
Move dotnet-tools config

Commit migrated from https://github.com/dotnet/corefx/commit/1e67bf524952958ac361fc525a6eebece16b15fa

5 years agoUpdate ProjectNTfs to beta-27729-00
dotnet-maestro-bot [Wed, 29 May 2019 05:45:54 +0000 (22:45 -0700)]
Update ProjectNTfs to beta-27729-00

Commit migrated from https://github.com/dotnet/corefx/commit/5dc4a0875331970d9b7435f07f5c4eedf57d93a3

5 years agoFix wrong Activity.Id serialization - 00 flags are used
Liudmila Molkova [Wed, 29 May 2019 07:35:31 +0000 (00:35 -0700)]
Fix wrong Activity.Id serialization - 00 flags are used

Commit migrated from https://github.com/dotnet/corefx/commit/c524b4da0f5cf4181fb9f30ae75ad29ef05ff018

5 years agoDisable sporadically failing GetGCMemoryInfo test (dotnet/corefx#37995)
Stephen Toub [Wed, 29 May 2019 00:46:45 +0000 (20:46 -0400)]
Disable sporadically failing GetGCMemoryInfo test (dotnet/corefx#37995)

Commit migrated from https://github.com/dotnet/corefx/commit/c7d48ca7732b7717e84d8375588d83866104ef58

5 years agoMake AuthenticateAsClient/ServerAsync cancellation token optional (dotnet/corefx...
Stephen Toub [Wed, 29 May 2019 00:44:47 +0000 (20:44 -0400)]
Make AuthenticateAsClient/ServerAsync cancellation token optional (dotnet/corefx#37996)

Commit migrated from https://github.com/dotnet/corefx/commit/2f28708788d67eb9943cd14a39df4bc87298418e

5 years agoImprove SocketAddress.ToString() performance (dotnet/corefx#37973)
Stephen Toub [Wed, 29 May 2019 00:40:11 +0000 (20:40 -0400)]
Improve SocketAddress.ToString() performance (dotnet/corefx#37973)

* Improve SocketAddress.ToString() performance

* Disable test on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/7508b75b843d89f6df5e5789c65a3cc23b94b757

5 years agoCreating common security policy
Barry Dorrans [Tue, 28 May 2019 22:21:46 +0000 (15:21 -0700)]
Creating common security policy

Commit migrated from https://github.com/dotnet/corefx/commit/c0629b395e8cfe632fcf1bd75e9de1a02cbb514c

5 years agoRemove socket cancellation workarounds on Unix from System.IO.Pipes (dotnet/corefx...
Stephen Toub [Tue, 28 May 2019 21:46:40 +0000 (17:46 -0400)]
Remove socket cancellation workarounds on Unix from System.IO.Pipes (dotnet/corefx#37988)

Commit migrated from https://github.com/dotnet/corefx/commit/ac24849e0404b9a7caba56fd398dbe6c5dbede0a

5 years agoImprove Debug.Assert in ConcurrentBag (dotnet/corefx#37986)
Stephen Toub [Tue, 28 May 2019 20:42:32 +0000 (16:42 -0400)]
Improve Debug.Assert in ConcurrentBag (dotnet/corefx#37986)

To try to help track down a spurious assert failure.

Commit migrated from https://github.com/dotnet/corefx/commit/3ca2657708840510873d8564c182ed06e92d87f6

5 years agoMake JsonPropertyNameAttribute.Name readonly (dotnet/corefx#37829)
Maryam Ariyan [Tue, 28 May 2019 19:27:20 +0000 (12:27 -0700)]
Make JsonPropertyNameAttribute.Name readonly (dotnet/corefx#37829)

Rename ctor arg to name

Fixes: dotnet/corefx#37552

Commit migrated from https://github.com/dotnet/corefx/commit/e8990ae04e4ef62f5ccb143352472c9b4d5d5968

5 years agoAdd Skip and TrySkip APIs to Utf8JsonReader with tests. (dotnet/corefx#37793)
Ahson Khan [Tue, 28 May 2019 19:26:08 +0000 (12:26 -0700)]
Add Skip and TrySkip APIs to Utf8JsonReader with tests. (dotnet/corefx#37793)

* Add Skip and TrySkip APIs to Utf8JsonReader with tests.

* Auto-generate the ref assembly.

* Remove new lines and update bytes consumed to avoid adjusting OS specific offsets.

* Add IsFinalBlock public property.

* Break up the skip/try skip method into helpers.

* Add more direct tests and update impl to avoid unnecessary struct copy.

Commit migrated from https://github.com/dotnet/corefx/commit/2f2aca43ef9d24c794255c3ef5d0238dc479652b

5 years agoUser-Agent header is ignored in "CONNECT" requests (dotnet/corefx#37785)
Marco Rossignoli [Tue, 28 May 2019 16:36:25 +0000 (18:36 +0200)]
User-Agent header is ignored in "CONNECT" requests  (dotnet/corefx#37785)

* flow UserAgent on CONNECT

* Apply Stephen feedback

* address PR feedback

* update test

* fix style

Commit migrated from https://github.com/dotnet/corefx/commit/1064d0352c007fd2d8fb32d7f6e286fbb6d41264

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37953)
dotnet-maestro[bot] [Tue, 28 May 2019 16:34:33 +0000 (12:34 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37953)

* Update dependencies from https://github.com/dotnet/coreclr build 20190524.71

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19274.71
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19274.71
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19274.71

* Fix Monitoring tests to reflect newly implemented support

* Fix StringBuilder tests to reflect updated unsupported braces behavior

* Update dependencies from https://github.com/dotnet/coreclr build 20190527.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6.19277.72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6.19277.72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6.19277.72

* Fix ordering of retrieving process time values in Monitoring test

Commit migrated from https://github.com/dotnet/corefx/commit/f90b73ebf00fbe3a4e97fa6445bb69a69985a800

5 years agoMerge pull request dotnet/corefx#37975 from dotnet-maestro-bot/master-UpdateDependencies
Viktor Hofer [Tue, 28 May 2019 12:47:49 +0000 (14:47 +0200)]
Merge pull request dotnet/corefx#37975 from dotnet-maestro-bot/master-UpdateDependencies

Update ProjectNTfs to beta-27728-00 (master)

Commit migrated from https://github.com/dotnet/corefx/commit/8d1149c3c73cbb650014ccffe2136bad1287b216

5 years agoUpdate ProjectNTfs to beta-27728-00
dotnet-maestro-bot [Tue, 28 May 2019 05:44:43 +0000 (22:44 -0700)]
Update ProjectNTfs to beta-27728-00

Commit migrated from https://github.com/dotnet/corefx/commit/6033b11330ec30e378b17dc636cb667d103090ac

5 years agoMove dotnet-tools config
Viktor Hofer [Thu, 23 May 2019 17:41:11 +0000 (19:41 +0200)]
Move dotnet-tools config

Commit migrated from https://github.com/dotnet/corefx/commit/248f09549518a3e83d1428a94a202ed3bc01fafb

5 years agoMove tests with external servers to outerloop (dotnet/corefx#37934)
Tomas Weinfurt [Mon, 27 May 2019 21:48:04 +0000 (14:48 -0700)]
Move tests with external servers to outerloop (dotnet/corefx#37934)

* move tests with external servers to outerloop

* fix Set_ValidValues_Success

Commit migrated from https://github.com/dotnet/corefx/commit/d58a8ade31b4731759c92df00d0f6398c52f3d83

5 years agoMerge pull request dotnet/corefx#37950 from dotnet/darc-master-201ad320-f5b9-4f45...
Viktor Hofer [Mon, 27 May 2019 07:57:12 +0000 (00:57 -0700)]
Merge pull request dotnet/corefx#37950 from dotnet/darc-master-201ad320-f5b9-4f45-bcaa-3bd13b56ebcf

[master] Update dependencies from dotnet/arcade

Commit migrated from https://github.com/dotnet/corefx/commit/5dd3196b5af24be242019ac1c5eb9344dfd5e155

5 years agoUpdate ProjectNTfs to beta-27727-00 (dotnet/corefx#37961)
dotnet-maestro-bot [Mon, 27 May 2019 07:06:48 +0000 (00:06 -0700)]
Update ProjectNTfs to beta-27727-00 (dotnet/corefx#37961)

Commit migrated from https://github.com/dotnet/corefx/commit/ba19505d72fdd39e9a4f5ca1be1fa2084f76bf0f

5 years agoRemove custom restore for arcade
Viktor Hofer [Mon, 27 May 2019 06:45:38 +0000 (08:45 +0200)]
Remove custom restore for arcade

Commit migrated from https://github.com/dotnet/corefx/commit/c31734ad51d054919d27fe83847ad656e095b974

5 years agoUpdate xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties (dotnet...
Krzysztof Wicher [Sat, 25 May 2019 16:25:15 +0000 (09:25 -0700)]
Update xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties (dotnet/corefx#37910)

* Update xml doc comment for JsonSerializerOptions.IgnoreReadOnlyProperties

* 'Note:' -> '<remarks>'

* Update src/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/corefx/commit/a59cb1a773af5bf651f461546ac1d89a92519278

5 years agoUse Thread instead of Task.Run in some Task tests (dotnet/corefx#37932)
Tarek Mahmoud Sayed [Fri, 24 May 2019 22:05:04 +0000 (15:05 -0700)]
Use Thread instead of Task.Run in some Task tests (dotnet/corefx#37932)

Stephen Toub pointed that it is possible when using Task.Run, there could be some ThreadLocal fields on the thread executing the task holding a reference to the object we are trying to GC collect and finalize. The fix here is use Thread objects instead of Task.

Commit migrated from https://github.com/dotnet/corefx/commit/bf7dbd6d37285a147dd30f5dfca6582046dcabc7

5 years agoFix binary bitwise operators with resized BitArray (dotnet/corefx#37876)
Ganbarukamo41 [Fri, 24 May 2019 16:40:58 +0000 (01:40 +0900)]
Fix binary bitwise operators with resized BitArray (dotnet/corefx#37876)

* fix binary bitwise operators with resized bitarray
* Use `Length` property instead of array.Length to avoid operating on unused area
* Add tests for binary bitwise operators using resized bitarrays

* Revert micro-optimisations

Commit migrated from https://github.com/dotnet/corefx/commit/3232bbdf246257690cb2710609de6ff9aa3412ce

5 years agoRe-generate System.Runtime.InteropServices ref source against implementation (dotnet...
Santiago Fernandez Madero [Fri, 24 May 2019 16:20:48 +0000 (09:20 -0700)]
Re-generate System.Runtime.InteropServices ref source against implementation (dotnet/corefx#37914)

* Re-generate System.Runtime.InteropServices ref source against implementation

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/564ced2a4cfcb02c1efc1e0da83c54f2b9073ea4

5 years agorename ToBytes to ToUtf8Bytes (dotnet/corefx#37912)
Anirudh Agnihotry [Fri, 24 May 2019 15:50:13 +0000 (08:50 -0700)]
rename ToBytes to ToUtf8Bytes (dotnet/corefx#37912)

Commit migrated from https://github.com/dotnet/corefx/commit/4e342b94a06e21604cd805d0340ef871adc47c43

5 years agoUpdate ProjectNTfs to beta-27724-00 (dotnet/corefx#37921)
dotnet-maestro-bot [Fri, 24 May 2019 14:03:33 +0000 (07:03 -0700)]
Update ProjectNTfs to beta-27724-00 (dotnet/corefx#37921)

Commit migrated from https://github.com/dotnet/corefx/commit/555d6e7991cec1f03b8782bd3fa4cfe5e7bcaa4d

5 years agofix dotnet/corefx#36798 by updating PipeReader doc comment (dotnet/corefx#37919)
Andrew Stanton-Nurse [Fri, 24 May 2019 13:50:01 +0000 (06:50 -0700)]
fix dotnet/corefx#36798 by updating PipeReader doc comment (dotnet/corefx#37919)

Fixes dotnet/corefx#36798

Corrects an inaccurate doc comment in System.IO.Pipelines.PipeReader

Commit migrated from https://github.com/dotnet/corefx/commit/cbc9701436853421b389e118e410e7470c887353

5 years agoAddress dotnet/corefx#37794 by removing "UTF-16" when not needed in System.Text.Json...
Christopher Watford [Fri, 24 May 2019 03:59:39 +0000 (23:59 -0400)]
Address dotnet/corefx#37794 by removing "UTF-16" when not needed in System.Text.Json docs (dotnet/corefx#37866)

* Remove UTF-16 notes from summary and param comments dotnet/corefx#37794

* Remove UTF-16 references from JsonEncodedText comments

* Address PR review comments by @ahsonkhan

Commit migrated from https://github.com/dotnet/corefx/commit/c539d6c627b169d45f0b4cf1826b560cd0862abe

5 years agoFix typo in JsonSerializer api documentation. (dotnet/corefx#37917)
Ahson Khan [Fri, 24 May 2019 03:14:50 +0000 (20:14 -0700)]
Fix typo in JsonSerializer api documentation. (dotnet/corefx#37917)

Commit migrated from https://github.com/dotnet/corefx/commit/57337477528b0b3344c4f190ea0ad85d5bc19cd0

5 years agoSupport unlimited array dimensions (dotnet/corefx#37867)
Steve Harter [Thu, 23 May 2019 20:46:19 +0000 (13:46 -0700)]
Support unlimited array dimensions (dotnet/corefx#37867)

Commit migrated from https://github.com/dotnet/corefx/commit/025bb33e27b15d973e8be430a9329309ecac37d3

5 years agoAdd nowarns for reference assemblies to be annotated with nullable warnings (dotnet...
Santiago Fernandez Madero [Thu, 23 May 2019 20:02:46 +0000 (13:02 -0700)]
Add nowarns for reference assemblies to be annotated with nullable warnings (dotnet/corefx#37901)

Commit migrated from https://github.com/dotnet/corefx/commit/41489a93acf3f36abcaaaea2003a8fdbb577cf35

5 years agoAdd logging at the Task timeout tests (dotnet/corefx#37874)
Tarek Mahmoud Sayed [Thu, 23 May 2019 15:40:39 +0000 (08:40 -0700)]
Add logging at the Task timeout tests (dotnet/corefx#37874)

We need to get more info to understand what is going on when the test timeout. Also, we are now FailFast to have the test runs create a debugger dump at least when running on Linux platforms. Hopefully this can help in the diagnostics

Commit migrated from https://github.com/dotnet/corefx/commit/510ab9e6433ff0df29e0ae080140f4f2c1b69abd