Milian Wolff [Thu, 27 Nov 2014 17:23:44 +0000 (18:23 +0100)]
Fixup handling of posix_memaling.
The return value of zero indicates success here. This should fix
some inconsistencies on applications that use this function.
Milian Wolff [Thu, 27 Nov 2014 17:23:38 +0000 (18:23 +0100)]
Don't print 0B leaked lines.
Milian Wolff [Thu, 27 Nov 2014 17:19:36 +0000 (18:19 +0100)]
Properly take cfree into account.
Milian Wolff [Thu, 27 Nov 2014 16:46:11 +0000 (17:46 +0100)]
Ensure we only ever initialize once.
Milian Wolff [Thu, 27 Nov 2014 16:40:10 +0000 (17:40 +0100)]
Use the same error handler for both init error callbacks.
This happens rarely, and the error message is still helpful.
Milian Wolff [Thu, 27 Nov 2014 16:37:39 +0000 (17:37 +0100)]
Fixup callback handlers, the wrong data was passed in.
Milian Wolff [Thu, 27 Nov 2014 16:30:58 +0000 (17:30 +0100)]
Cleanup: get rid of obsolete isExe member in module.
It is only required for the call to backtrace_fileline_initialize.
Milian Wolff [Thu, 27 Nov 2014 14:50:16 +0000 (15:50 +0100)]
Add seconds elapsed to heaptrack log for future evaluation.
Milian Wolff [Fri, 17 Oct 2014 12:59:58 +0000 (14:59 +0200)]
Support building against libunwind from different include directory
Milian Wolff [Tue, 25 Nov 2014 16:12:05 +0000 (17:12 +0100)]
Delete obsolete files.
These are used in VOGL, but not in heaptrack, so get rid of them.
Milian Wolff [Tue, 25 Nov 2014 15:55:22 +0000 (16:55 +0100)]
Support atomic functions if possible.
Milian Wolff [Mon, 24 Nov 2014 16:22:40 +0000 (17:22 +0100)]
Prevent crashes in apps using QProcess.
Milian Wolff [Wed, 19 Nov 2014 12:33:01 +0000 (13:33 +0100)]
Prevent issues and file corruption when tracking a forking process.
Thankfully there is pthread_atfork which can be used to get notified
about fork calls. We stop heaptrack before forking and only continue
it in the parent process. In the child process we stop heaptrack
alltogether.
TODO: make it possible to track child processes.
Milian Wolff [Tue, 18 Nov 2014 19:04:47 +0000 (20:04 +0100)]
Also use LineReader in heaptrack_interpret.
Milian Wolff [Tue, 18 Nov 2014 18:44:20 +0000 (19:44 +0100)]
Be more forgiving when encountering bad data.
Still no clue where the bad data comes from though...
Milian Wolff [Tue, 18 Nov 2014 17:44:58 +0000 (18:44 +0100)]
Optimize findAllocation calls by leveraging monotonicity of indices.
By comparing the incoming trace index to the largest index we so
far encountered, we can already decide whether:
a) if the index is equal to the largest one, the same location is used
repeatedly, i.e. in a loop, and we can directly return the last item.
b) if the index is larger than the last known one, we'll definitely
not find it and can thus insert directly and return
c) only if the index is lower than the last index do we actually need
to do a binary search.
This yields a small but noticeable speedup from ~14.5s to 13.4s for
one of my files.
Milian Wolff [Tue, 18 Nov 2014 17:01:12 +0000 (18:01 +0100)]
Slightly cleanup and optimize LineReader::readHex
Milian Wolff [Tue, 18 Nov 2014 16:42:27 +0000 (17:42 +0100)]
minor cleanup
Milian Wolff [Tue, 18 Nov 2014 16:41:20 +0000 (17:41 +0100)]
Don't fill sizeHistogram if we are not going to print it.
Milian Wolff [Tue, 18 Nov 2014 16:28:13 +0000 (17:28 +0100)]
Introduce optimized reader class for faster reading of hex numbers.
In my benchmark on a big data file this reduces the runtime of
heaptrack_print from 24s to 16s. The whole function is pretty simple
so I'm willing to sacrifice simplicity for this big performance win.
Milian Wolff [Tue, 18 Nov 2014 15:40:35 +0000 (16:40 +0100)]
Improve error checking when reading data file.
Milian Wolff [Tue, 18 Nov 2014 15:03:17 +0000 (16:03 +0100)]
Format byte sizes to KB/MB/GB/TB.
Milian Wolff [Tue, 18 Nov 2014 13:10:18 +0000 (14:10 +0100)]
Fallback to __libc_start_main when main is not found.
Milian Wolff [Tue, 18 Nov 2014 13:10:07 +0000 (14:10 +0100)]
Change the output format slightly for better readability.
Milian Wolff [Tue, 18 Nov 2014 12:44:54 +0000 (13:44 +0100)]
Merge allocations from equivalent locations.
Equivalent means the data is the same except for the instruction pointer
address itself. Useful when we are missing some debug information.
Milian Wolff [Tue, 18 Nov 2014 11:09:59 +0000 (12:09 +0100)]
Cleanup code and also initialize fileline only once.
This fixes a regression when looking at kdepim with heaptrack.
Milian Wolff [Mon, 17 Nov 2014 19:18:09 +0000 (20:18 +0100)]
Reduce looping
Milian Wolff [Mon, 17 Nov 2014 18:51:23 +0000 (19:51 +0100)]
Only call backtrace_create_state once per file.
Also improve the checks for overlapping libraries which was wrong.
Combined this drastically cuts the memory consumption and improve
the runtime of the heaptrack_interpret process again.
Milian Wolff [Mon, 17 Nov 2014 17:59:34 +0000 (18:59 +0100)]
Fix more issues related to improper backtrace symbol lookups.
We now clear the list of known modules also in heaptrack_interpret
and really forget about all modules. This ensures we don't keep
invalid modules around and improperly associate instruction pointer
addresses to these modules.
This fixes the heaptrack usage for me on larger applications such
as KMail or plasma-desktop (KDE4).
Milian Wolff [Mon, 17 Nov 2014 17:32:48 +0000 (18:32 +0100)]
Take each PT_LOAD dlpi_phdr as its own module.
This fixes some issues with incorrect backtrace symbols when shared
libraries are used, as the new example shows. Before e.g. libc.so
overlapped with many other libraries and incorrectly chosen to
find the backtrace symbol. With this patch, this issue is gone.
Milian Wolff [Mon, 17 Nov 2014 16:16:57 +0000 (17:16 +0100)]
Add whitespace before lib name.
Milian Wolff [Mon, 17 Nov 2014 16:16:45 +0000 (17:16 +0100)]
Fix warning about missing debug infos in linux-vdso.so.N
Milian Wolff [Mon, 8 Sep 2014 08:37:23 +0000 (10:37 +0200)]
Check for main index while reading the data in.
Milian Wolff [Mon, 8 Sep 2014 08:23:16 +0000 (10:23 +0200)]
Skip operator new etc. when encountering the trace.
This makes it much simpler and all backtraces are filtered automatically.
Milian Wolff [Sat, 6 Sep 2014 22:42:18 +0000 (00:42 +0200)]
Write histogram to file specified by cli argument
Milian Wolff [Sat, 6 Sep 2014 22:24:05 +0000 (00:24 +0200)]
Improve the output to better understand what the numbers mean.
David Faure [Sat, 6 Sep 2014 21:22:24 +0000 (23:22 +0200)]
Fix compilation on OpenSUSE
David Faure [Sat, 6 Sep 2014 21:05:34 +0000 (23:05 +0200)]
Fix compilation when passing flags on the command line as well
Milian Wolff [Fri, 5 Sep 2014 08:18:25 +0000 (10:18 +0200)]
Skip all operator new locations, even when the IP differs.
This was occurring in a real-world data file for me, where
operator new(unsigned long) was encountered twice at different IPs.
Milian Wolff [Thu, 4 Sep 2014 15:57:41 +0000 (17:57 +0200)]
Don't get confused by operator<, <<, > and >>.
Milian Wolff [Tue, 26 Aug 2014 00:44:08 +0000 (02:44 +0200)]
Share code.
Milian Wolff [Tue, 26 Aug 2014 00:37:58 +0000 (02:37 +0200)]
Make it possible to switch between merged and non-merged backtraces.
Milian Wolff [Tue, 26 Aug 2014 00:30:18 +0000 (02:30 +0200)]
Add some comments, esp. about implementing better trace merging.
Milian Wolff [Tue, 26 Aug 2014 00:26:23 +0000 (02:26 +0200)]
remove obsolete debug output
Milian Wolff [Tue, 26 Aug 2014 00:21:05 +0000 (02:21 +0200)]
Add implicit values to program options.
Milian Wolff [Tue, 26 Aug 2014 00:16:43 +0000 (02:16 +0200)]
Merge code to print merged backtraces :)
C++' pointer-to-member is a really powerful feature - wow!
Milian Wolff [Tue, 26 Aug 2014 00:01:56 +0000 (02:01 +0200)]
Prettify output of top-allocator places.
TODO: do something similar in the other places as well.
Milian Wolff [Mon, 25 Aug 2014 23:45:03 +0000 (01:45 +0200)]
Merge allocation data by instruction pointer.
This is safe to do except for the peak memory consumption where
we cannot ignore the temporal dependency.
Otherwise this greatly improves the output as multiple calls to the
same function from different places get merged and thus show up
as one fat data point, instead of multiple thinner ones.
Milian Wolff [Mon, 25 Aug 2014 23:04:13 +0000 (01:04 +0200)]
Skip operator new(unsigned long) (and new[]) from start of backtraces.
Milian Wolff [Mon, 25 Aug 2014 22:21:52 +0000 (00:21 +0200)]
Make indices typesafe.
Milian Wolff [Mon, 25 Aug 2014 22:01:51 +0000 (00:01 +0200)]
Fix name of variables.
Milian Wolff [Mon, 25 Aug 2014 21:56:32 +0000 (23:56 +0200)]
Add a bit of recursion to the callgraph test debugee
Milian Wolff [Mon, 25 Aug 2014 21:51:58 +0000 (23:51 +0200)]
Fix regression and properly stop backtraces at main function again.
Milian Wolff [Mon, 25 Aug 2014 21:39:17 +0000 (23:39 +0200)]
Cleanup code and reduce duplication.
Milian Wolff [Mon, 25 Aug 2014 21:33:11 +0000 (23:33 +0200)]
Split trace and instruction pointer data.
The debug info for a ip is only required once, whereas a trace
contains the mapping between an IP and the parent IP, which can
be outputted many times in different combinations.
This way we don't call the libbacktrace functions as often and
decrease the file size, at the cost of memory consumption during
the debugee run (in heaptrack_interpret). The memory consumption
significantly decreases in heaptrack_print though.
Milian Wolff [Mon, 25 Aug 2014 20:19:55 +0000 (22:19 +0200)]
Reduce amount of cout flushing.
std::endl also flushes the output which is pretty bad for performance.
Instead, only use endl when it makes sense, i.e. between output blocks.
Milian Wolff [Mon, 25 Aug 2014 20:17:21 +0000 (22:17 +0200)]
Cleanup code: encapsulate data reading and make more stuff private.
Milian Wolff [Sun, 24 Aug 2014 14:45:06 +0000 (16:45 +0200)]
Add test for call graphs, this should be merged better.
Milian Wolff [Mon, 25 Aug 2014 17:18:12 +0000 (19:18 +0200)]
Improve headings of different output sections.
Milian Wolff [Mon, 25 Aug 2014 16:52:16 +0000 (18:52 +0200)]
Take dlclose into account and update module cache accordingly.
Milian Wolff [Mon, 25 Aug 2014 16:38:04 +0000 (18:38 +0200)]
Make it possible to validate the correctness of allocation overloads.
This is still flaky, apparently some function related to TLS allocation is missing.
Milian Wolff [Mon, 25 Aug 2014 16:06:13 +0000 (18:06 +0200)]
Improve output of -h
Milian Wolff [Mon, 25 Aug 2014 16:06:04 +0000 (18:06 +0200)]
Do not clash --print-histogram with --help.
Milian Wolff [Mon, 25 Aug 2014 15:57:47 +0000 (17:57 +0200)]
Do not link directly to libheaptrack.
The interpreter is important for useful data imo.
Milian Wolff [Mon, 25 Aug 2014 15:57:28 +0000 (17:57 +0200)]
Shorten template identifiers by default.
Milian Wolff [Mon, 25 Aug 2014 15:57:00 +0000 (17:57 +0200)]
Use boost::program_options and make output configurable.
Milian Wolff [Mon, 25 Aug 2014 13:46:37 +0000 (15:46 +0200)]
Simplify code, we use the std namespace.
Milian Wolff [Mon, 25 Aug 2014 13:42:12 +0000 (15:42 +0200)]
Simplify code a bit.
Milian Wolff [Mon, 25 Aug 2014 13:35:07 +0000 (15:35 +0200)]
Output pointer adresses without 0x prefix.
This just needlessly increases the file size.
We now cast to uintptr_t and output as %lx.
Milian Wolff [Mon, 25 Aug 2014 13:24:41 +0000 (15:24 +0200)]
Do not output function, file and line index for unknown locations.
The null value is the default anyways and we do not need to
output that information and can thereby decrease the filesize a bit
for debugees with many occasions of missing debug information.
Milian Wolff [Sat, 23 Aug 2014 15:30:48 +0000 (17:30 +0200)]
Also show individual peak allocations.
Milian Wolff [Sat, 23 Aug 2014 15:23:55 +0000 (17:23 +0200)]
Also show top-ten allocation places (ignoring deallocations).
Milian Wolff [Sat, 23 Aug 2014 15:16:48 +0000 (17:16 +0200)]
Use %p to print out ptr addresses.
Milian Wolff [Mon, 11 Aug 2014 22:12:05 +0000 (00:12 +0200)]
Add some debug output to show whats currently going on.
Milian Wolff [Wed, 13 Aug 2014 14:00:18 +0000 (16:00 +0200)]
Optimize: don't sync cin/cout/cerr with stdio for our single-threaded c++ apps.
Milian Wolff [Wed, 13 Aug 2014 12:11:30 +0000 (14:11 +0200)]
Cleanup code a bit.
Milian Wolff [Wed, 13 Aug 2014 09:55:25 +0000 (11:55 +0200)]
Add comment on why we use stdio here.
Milian Wolff [Wed, 13 Aug 2014 08:52:17 +0000 (10:52 +0200)]
Fixup check for executable debuggee.
Call which first to also find the exe in PATH.
Milian Wolff [Sun, 10 Aug 2014 15:15:12 +0000 (17:15 +0200)]
Add heaptrack --help.
Milian Wolff [Sun, 10 Aug 2014 14:57:49 +0000 (16:57 +0200)]
Cleanup output messages to make it simpler to understand heaptrack.
Milian Wolff [Sun, 10 Aug 2014 14:50:57 +0000 (16:50 +0200)]
Install heaptrack shell script and use the proper paths therein.
We get the relative paths from the install directory to our lib
and libexec target folders and write that into the shell script.
Milian Wolff [Wed, 6 Aug 2014 21:19:14 +0000 (23:19 +0200)]
Some more cleanup and restructuring.
Milian Wolff [Wed, 6 Aug 2014 20:49:54 +0000 (22:49 +0200)]
Rename to heaptrack and start cleaning up the code structure.
Milian Wolff [Wed, 6 Aug 2014 20:31:56 +0000 (22:31 +0200)]
Remove mallocinfo code, it's in the old repo.
Milian Wolff [Sun, 3 Aug 2014 19:22:47 +0000 (21:22 +0200)]
Directly evaluate the backtrace data.
This makes the final data interpretable even when the binary or
any library changes in between. It also makes it possible to ship
the data file to an external computer for further evaluation.
Milian Wolff [Sat, 7 Jun 2014 00:45:28 +0000 (02:45 +0200)]
Hide anything above __libc_start_main as its garbage.
Milian Wolff [Thu, 5 Jun 2014 13:31:48 +0000 (15:31 +0200)]
Use named pipe to compress output data on the fly.
This is plain awesome imo :) Really easy to get implemented and
the evaluation code is also more or less untouched thanks to Boost's
iostreams library with nice support for gzip data.
Milian Wolff [Thu, 5 Jun 2014 10:22:23 +0000 (12:22 +0200)]
Fixup example code, use proper delete[].
Milian Wolff [Wed, 4 Jun 2014 17:47:02 +0000 (19:47 +0200)]
Do not output new IP id.
The data is outputted in a sequentail way and thus this information is obsolete.
Milian Wolff [Wed, 4 Jun 2014 17:43:08 +0000 (19:43 +0200)]
Directly link malloctrace into test executables.
Milian Wolff [Wed, 4 Jun 2014 16:37:43 +0000 (18:37 +0200)]
Output all numbers in hex form.
This reduces the output data file size slightly and simplifies the
evaluation code as we do not have to switch between different
formats all the time.
Milian Wolff [Wed, 4 Jun 2014 16:34:04 +0000 (18:34 +0200)]
Do not output 0x prefix for addresses.
This reduces the size of the output data files.
Milian Wolff [Wed, 4 Jun 2014 16:25:30 +0000 (18:25 +0200)]
Decrease runtime memory overhead by getting rid of AllocationInfo.
We now output every allocation's ptr and only output it for a free.
This not only reduces the runtime CPU overhead, but also drastically
reduces the memory overhead as the relatively large AllocationInfo
map is not required anymore.
The size of the output data files increases, but the cost seems to
be bearable and worth the reduces memory overhead imo.
Milian Wolff [Wed, 4 Jun 2014 13:03:46 +0000 (15:03 +0200)]
realloc with nullptr is the same as pure malloc.
In such a case, don't handle the realloc like a free followed by a
malloc. It's just the malloc then.
Milian Wolff [Wed, 4 Jun 2014 12:18:14 +0000 (14:18 +0200)]
Store backtrace information in a memory efficient tree structure.
Instead of storing all individual traces that ever call any of the
allocation functions, we now store a tree of instruction pointers.
The tree is constructed from top-to-bottom and each node representing
an instruction pointer gets associated with a unique index. This
index is enough to reconstruct the backtrace from that point by
iterating over the parent indices, which is now done in the evaluation
program.
A nice side effect is that the data file becomes smaller for bigger
application evaluation runs, as common parts at the beginning of
every allocation trace can be implicitly shared.
Milian Wolff [Mon, 2 Jun 2014 18:33:23 +0000 (20:33 +0200)]
Cleanup code and make it explicitly work with the unw_backtrace api.
Milian Wolff [Mon, 2 Jun 2014 17:20:37 +0000 (19:20 +0200)]
Use unw_backtrace instead of manual unw_step loop.
The former is potentially much more performant but may require some
work on libunwind, which I'm currently investigating.
Milian Wolff [Mon, 2 Jun 2014 14:50:02 +0000 (16:50 +0200)]
Add warning about unknown executable format
Milian Wolff [Sat, 31 May 2014 23:34:32 +0000 (01:34 +0200)]
Enable per-thread unwind caching.
This is much more performant as libunwind will not also add another
serialization point, it will also trigger calls to sigprocmask for
every mutex lock/unlock.
Milian Wolff [Sat, 31 May 2014 23:16:54 +0000 (01:16 +0200)]
Refactor DUMP_MALLOC_TRACE_OUTPUT handling.
Now we can set it to stderr or stdout/- to print directly to the
console. Other files get $$ replaced by the PID of the host app.
This allows us to set DUMP_MALLOC_TRACE_OUTPUT to /dev/null to
disable output.