platform/upstream/efl.git
4 years agoEdje: Add color class feature for textblock properties.
Subodh Kumar [Tue, 3 Dec 2019 11:48:18 +0000 (17:18 +0530)]
Edje: Add color class feature for textblock properties.

These properties were missing, as underline color is being used used heavily.
There is link pressed effect feature which requires color class for underline color.
Also link pressed effect works on link tag. So link tag is provided by default and if app
wants to customises the color then whole style needs to be rrecreated so replacing
color code for link tag will work as aspected.

Change-Id: I04e826a64610981a0491d753a855d5c8984fc259

4 years agoefl_ui_widget: restore legacy focus of scrollable 40/219640/1
Yeongjong Lee [Sun, 8 Dec 2019 22:50:33 +0000 (07:50 +0900)]
efl_ui_widget: restore legacy focus of scrollable

restore legacy focus calculation removed from the commit below.

ref e337c53348829799e0dcac26af50e988e1b759a8

@tizen_fix

Change-Id: I08e182697795451a3381038995163df420900d1f

4 years agoevas_text: retain legacy behaviour accepted/tizen/unified/20191209.144131 submit/tizen/20191208.221329
ali [Fri, 6 Dec 2019 20:14:29 +0000 (20:14 +0000)]
evas_text: retain legacy behaviour

This will retain old legacy behaviour (No Eina Checks).

Warnings will be generated when using elementary test, unless we retain old behaviour
https://phab.enlightenment.org/D10716#203305

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10826

4 years agoimf - make xim+scim the defaults not xim+ibus due to ibus being broken
Carsten Haitzler (Rasterman) [Fri, 6 Dec 2019 20:51:26 +0000 (20:51 +0000)]
imf - make xim+scim the defaults not xim+ibus due to ibus being broken

at leats ibus seems to just not work for me on arch at least  - even
with gtk apps, but scim does, so maybe make scim the main thing again?
also allows glib to be off by default. :)

4 years agoecore_x: remove support XGesture extension
Stefan Schmidt [Fri, 6 Dec 2019 19:40:20 +0000 (14:40 -0500)]
ecore_x: remove support XGesture extension

Summary:
This was a X11 extension mainly developed for Tizen. By now I can only
find it packaged by Gentoo as the only Linux distribution and Tizen is
now longer using it either. Bringing it up during EDD and on the mailing
list did not come up with any users.
I think we can go ahead and deprecate the API and remove the
functionality.

Reviewers: raster, cedric, devilhorns, zmike

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10823

4 years agoglib - enable by default again - ibus imf needs it
Carsten Haitzler (Rasterman) [Fri, 6 Dec 2019 19:27:25 +0000 (19:27 +0000)]
glib - enable by default again - ibus imf needs it

4 years agoelm_code: set box align correctly
Marcel Hollerbach [Fri, 6 Dec 2019 18:19:38 +0000 (19:19 +0100)]
elm_code: set box align correctly

sometimes the resize size is not in line with the size of the outer
widget, in this case the box should align its children at the very top,
otherwise the cursor grid is falling out of sync with the text content.

4 years agoefl_canvas_object_animation: support duration 0
Jaehyun Cho [Fri, 6 Dec 2019 16:27:06 +0000 (16:27 +0000)]
efl_canvas_object_animation: support duration 0

The duration of animation means how long the animation is executed.
Therefore, if duration is 0, then the final state of animation should be
applied to the target object immediately.

In this case, if final_state_keep is true, then the final state of
animation is preserved. Otherwise, the final state of animation is not
preserved.

ref T8436, T8513

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10812

4 years agoelementary: Fix declaration of CV managers getters
Lauro Moura [Fri, 6 Dec 2019 14:57:52 +0000 (14:57 +0000)]
elementary: Fix declaration of CV managers getters

This should convey better their intention of the setting taking
ownership of the passed value and the getter returning just a view to
them.

Fixes T8514

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10824

4 years agoefl: stabilize Efl.Gfx.Arrangement
Yeongjong Lee [Mon, 11 Nov 2019 05:48:24 +0000 (05:48 +0000)]
efl: stabilize Efl.Gfx.Arrangement

ref T7864

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10642

4 years agofocus: modify a formula to calculate focus region to show
Wonki Kim [Fri, 6 Dec 2019 08:29:26 +0000 (08:29 +0000)]
focus: modify a formula to calculate focus region to show

if there was a spacer around elm.swallow.content of scroller,
position of pan object would be different with position of the scroller obj.

this patch modifies a fomular that calculates some points relative to scroller
to a fomular that calculates the points relative to pan obj.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10745

4 years agocollection_view: fix a potentional error
Wonki Kim [Fri, 6 Dec 2019 08:30:51 +0000 (08:30 +0000)]
collection_view: fix a potentional error

assign signed int value on bigger unsigned variable
can make information of the varaible lost.
this patch fix the problem.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10723

4 years agoci: re-enable cxx bindings for CI builds again
Stefan Schmidt [Wed, 4 Dec 2019 16:25:19 +0000 (17:25 +0100)]
ci: re-enable cxx bindings for CI builds again

While cxx bindings are enabled by default we had them turned off on the
CI builds due to the amount of memory they used in the examples
building/linking. This often had lead to the case where the Travis build
failed due too little resources on the Travis nodes for it.

I have not seen this stalls during linking on my machine for a while now
and my tests on Travis do also not show this. Time to enable them again
and if the problem comes back we can revert.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10822

4 years agoevas vector: add one comment todo.
Hermet Park [Fri, 6 Dec 2019 09:58:54 +0000 (18:58 +0900)]
evas vector: add one comment todo.

4 years agoefl_ui_alert_popup: remove beta for efl_ui_alert_popup_title
Taehyub Kim [Fri, 6 Dec 2019 08:49:52 +0000 (17:49 +0900)]
efl_ui_alert_popup: remove beta for efl_ui_alert_popup_title

Summary: remove the title part beta tag for the efl ui alert popup

Reviewers: Jaehyun_Cho, zmike, bu5hm4n, segfaultxavi

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10820

4 years agoExample: Add efl-cavnas-vg-simple for unified API
JunsuChoi [Fri, 6 Dec 2019 07:51:07 +0000 (16:51 +0900)]
Example: Add efl-cavnas-vg-simple for unified API

Summary: Add Evas vector graphcis example based on unified APIs

Test Plan:
build
./build/src/examples/evas/efl-canvas-vg-simple

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10819

4 years agoevas vg: remove build warning
JunsuChoi [Fri, 6 Dec 2019 06:56:34 +0000 (15:56 +0900)]
evas vg: remove build warning

Remove parameter already deleted

Change-Id: I0d71ef01525376b1e52bf695a459ce21aab8a362

4 years agoevas vg: --remove log
Hermet Park [Fri, 6 Dec 2019 06:30:50 +0000 (15:30 +0900)]
evas vg: --remove log

4 years agovg ector: Call a pair of ector begin/end for ector buffer drawing.
Hermet Park [Fri, 6 Dec 2019 06:22:56 +0000 (15:22 +0900)]
vg ector: Call a pair of ector begin/end for ector buffer drawing.

While we render vector drawing on ector,it uses ector buffers for subsequent compositions.
In this sequence, it switches ector buffer with a composition target,
while resuing the global ector context.

Previously, it trickly switched ector buffer, it broke the ector begin/end pair.
Now, it needs to recover global ector buffer once the composition finished.
Thus ector buffer need to return the current pixels information for this.

4 years agoector_software_rasterizer: use dynamic array by span size.
JunsuChoi [Fri, 6 Dec 2019 01:37:31 +0000 (10:37 +0900)]
ector_software_rasterizer: use dynamic array by span size.

Summary:
When use with intersect mask, if span_count over span array size, composition is to be wrong.
So, In this case, we use dynamic array by span_count.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: vtorri, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10748

4 years agoelm_label: Emit click signal on acivate action on label
JunsuChoi [Fri, 6 Dec 2019 01:30:34 +0000 (10:30 +0900)]
elm_label: Emit click signal on acivate action on label

Summary: In accessibility enabled case click signal of legacy label is not triggered.

Test Plan: N/A

Reviewers: Hermet, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10803

4 years agoevas_events: fix wrong condition of proxy event behavior.
Hosang Kim [Fri, 6 Dec 2019 01:21:35 +0000 (10:21 +0900)]
evas_events: fix wrong condition of proxy event behavior.

Summary:
If source_events is false, Evas object doesn't repeat events to source.
But events is always repeated to source in multi touch case.

Reviewers: Hermet, raster, cedric

Reviewed By: Hermet

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10807

4 years agoRevert "[Tizen5.5] Edje: Add color class feature for textblock properties."
Jongmin Lee [Sun, 8 Dec 2019 21:56:16 +0000 (06:56 +0900)]
Revert "[Tizen5.5] Edje: Add color class feature for textblock properties."

This reverts commit e0c9fef500b658530fb16bad70a0f96913fec9d9.

4 years agoRevert "elm_label: Emit click signal on acivate action on label"
Jongmin Lee [Sun, 8 Dec 2019 21:56:00 +0000 (06:56 +0900)]
Revert "elm_label: Emit click signal on acivate action on label"

This reverts commit 4afbff17dd803c5eb9920cca9c1e7898dbe367a7.

Change-Id: I6fa1ebc82c993ab91639a4085c0e6fffb13f0174

4 years agobuild: fix build warnings related to const qualifier 76/219576/3
Yeongjong Lee [Fri, 6 Dec 2019 07:01:02 +0000 (16:01 +0900)]
build: fix build warnings related to const qualifier

Change-Id: Iaa392fe228c379c878f61b03a80d6a0a67e75a76

4 years agoefl_ui: fix build warnings of focus_manager functions 80/219480/3
Yeongjong Lee [Thu, 5 Dec 2019 07:17:29 +0000 (16:17 +0900)]
efl_ui: fix build warnings of focus_manager functions

@tizen_fix

Change-Id: I6b8a4e5af21159367ee4cc70ba16b37d9d3c8a93

4 years agoevas_events: remove unused tizen_only variables 79/219479/2
Yeongjong Lee [Thu, 5 Dec 2019 02:29:45 +0000 (11:29 +0900)]
evas_events: remove unused tizen_only variables

@tizne_fix

Change-Id: Ib0755787495e060ee6b1066fae834152ce12633c

4 years agoevas vg: remove build warning
JunsuChoi [Fri, 6 Dec 2019 06:56:34 +0000 (15:56 +0900)]
evas vg: remove build warning

Remove parameter already deleted

Change-Id: I5ed106c2575ede766baf8a9f729096b8ef395236

4 years agoevas vg: --remove log 74/219574/1
Hermet Park [Fri, 6 Dec 2019 06:30:50 +0000 (15:30 +0900)]
evas vg: --remove log

Change-Id: Ia093f1ffd1e07b1806e92bab742c7fb1f2b74dea

4 years agovg ector: Call a pair of ector begin/end for ector buffer drawing. 73/219573/1
Hermet Park [Fri, 6 Dec 2019 06:22:56 +0000 (15:22 +0900)]
vg ector: Call a pair of ector begin/end for ector buffer drawing.

While we render vector drawing on ector,it uses ector buffers for subsequent compositions.
In this sequence, it switches ector buffer with a composition target,
while resuing the global ector context.

Previously, it trickly switched ector buffer, it broke the ector begin/end pair.
Now, it needs to recover global ector buffer once the composition finished.
Thus ector buffer need to return the current pixels information for this.

Change-Id: I8029ad548660fe614923857af9520e67bd9344a1

4 years agoelm_label: Remove tizen only 44/219544/2
JunsuChoi [Fri, 6 Dec 2019 01:56:11 +0000 (10:56 +0900)]
elm_label: Remove tizen only

4afbff patch has been applied to open source.
Therefore, delete tizen only.
Open source patch to be migrated will be empty patch.

Change-Id: I98224acdaef1559a2099d8f6a2b237d1226b297c
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
4 years ago[Tizen5.5] Edje: Add color class feature for textblock properties.
Subodh Kumar [Tue, 3 Dec 2019 11:48:18 +0000 (17:18 +0530)]
[Tizen5.5] Edje: Add color class feature for textblock properties.

These properties were missing, as underline color is being used used heavily.
There is link pressed effect feature which requires color class for underline color.
Also link pressed effect works on link tag. So link tag is provided by default and if app
wants to customises the color then whole style needs to be rrecreated so replacing
color code for link tag will work as aspected.

Change-Id: I04e826a64610981a0491d753a855d5c8984fc259

4 years agoelm_label: Emit click signal on acivate action on label
Prasoon Singh [Wed, 4 Dec 2019 11:46:21 +0000 (17:16 +0530)]
elm_label: Emit click signal on acivate action on label

In screen-reader enabled case click signal of label is not triggered.

Change-Id: I218944122ba9747f7fb7ab425559ad1fc331f34e
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
4 years agoUpdating french translation accepted/tizen/unified/20191206.121258 submit/tizen/20191205.205324
maxerba [Thu, 5 Dec 2019 17:06:12 +0000 (18:06 +0100)]
Updating french translation

4 years agoEctor: Prevent access to NULL
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL

Summary: ector thread can called *data(task) after deleting task object.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10804

Change-Id: I05d5226ec7b950214f398f66d0ca82e430099cb5

4 years agoefl_text_attribute_factory: update documention
Ali Alzyod [Thu, 5 Dec 2019 09:37:57 +0000 (10:37 +0100)]
efl_text_attribute_factory: update documention

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10806

4 years agoEctor: Prevent access to NULL 12/219512/3
JunsuChoi [Thu, 5 Dec 2019 11:25:25 +0000 (20:25 +0900)]
Ector: Prevent access to NULL

Summary: ector thread can called *data(task) after deleting task object.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10804

Change-Id: I9e7b4893fc58a9670f2ac60e9b632cf9969c22c3

4 years agoRevert "ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings." 56/219456/3
Taehyub Kim [Thu, 5 Dec 2019 05:15:16 +0000 (14:15 +0900)]
Revert "ecore_audio, ecore_buffer, ecore_wl2 : Fix build warnings."

This patch cause the ecore_buffer_register tc break,
then this need to revert temporary.

This reverts commit f8f770ebf854d725b3bf8a2ec10f7526960fd5e2.

Change-Id: I75e6cbf3654dfbc62941715fe7272846f2ac93e7

4 years agobuild: remove gstreamer 0.10 support submit/tizen/20191204.213652
Jongmin Lee [Wed, 4 Dec 2019 21:34:48 +0000 (06:34 +0900)]
build: remove gstreamer 0.10 support

Change-Id: I83824b7553ed13d17a640049f1077b710c30572a

4 years agoexotic: remove left-overs from Exotic support
Stefan Schmidt [Thu, 28 Nov 2019 08:59:41 +0000 (09:59 +0100)]
exotic: remove left-overs from Exotic support

This seems to have been gone a long time ago and only references left
that have not been disturbing the build. Time to clean up!

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10793

4 years agoedje: Add text change signal
Subodh Kumar [Tue, 3 Dec 2019 10:56:00 +0000 (10:56 +0000)]
edje: Add text change signal

There is no way to know about text changes in edc.
This signal will help developer to know about text changes
and do some operation based on that.

@feature

Co-authored-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10780

4 years agoemotion & evas: remove gstreamer 0.10 support
Stefan Schmidt [Wed, 30 Oct 2019 16:09:20 +0000 (17:09 +0100)]
emotion & evas: remove gstreamer 0.10 support

We have Gstreamer 1.x support for a long time already. We used to keep
this around as fallback. By now Linux distributions start to actually no
longer ship the Gstreamer 0.10.x packages and upstream has not seen a
release in in 5 years. Time to remove it on our side as well.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10779

4 years agoesacpe: remove library from tree
Stefan Schmidt [Fri, 1 Nov 2019 08:35:09 +0000 (09:35 +0100)]
esacpe: remove library from tree

This has not been used for a while and is not even buildable after our
switch to meson. It was a niche to start with given that it needed the
PS3 OS to run on. I asked for any remaining users at EDD and on the list
but heard nothing. Time to remove.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10778

4 years agoelementary: small improvement on example migrating them to newer unified API.
Cedric BAIL [Sat, 23 Nov 2019 09:09:13 +0000 (01:09 -0800)]
elementary: small improvement on example migrating them to newer unified API.

4 years agocode comments: annoying typos
Xavi Artigas [Wed, 4 Dec 2019 17:22:25 +0000 (18:22 +0100)]
code comments: annoying typos

4 years agoefl_canvas_animation_group: show that playing backwards is also working
Marcel Hollerbach [Wed, 4 Dec 2019 16:45:25 +0000 (17:45 +0100)]
efl_canvas_animation_group: show that playing backwards is also working

Summary:
playing backwards is also working, this is simply shown here, the
handcrafted backwards animation wasnt showing the correct animation
either.
Depends on D10799

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10802

4 years agoEfl.Canvas.Animation: Rename repeat_count to play_count
Xavi Artigas [Wed, 4 Dec 2019 16:25:45 +0000 (17:25 +0100)]
Efl.Canvas.Animation: Rename repeat_count to play_count

Summary:
play_count is a tad simpler to understand, since it means the TOTAL number of
times the animation will play.
The default value is now 1, and 0 means INFINITE (instead of -1). This allows
removing yet another constant from header files.

Depends on D10799

Test Plan: Everything builds and passes tests. Elm_test Animation.Repeat has been adjusted accordingly.

Reviewers: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10800

4 years agocharp: Require mono bindings when using dotnet
Lauro Moura [Wed, 6 Nov 2019 18:41:13 +0000 (18:41 +0000)]
charp: Require mono bindings when using dotnet

Allow using `-Ddotnet=true` to automatically pull `bindings=mono`.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10610

4 years agotests/layout: add unit test for legacy layout theme,changed signal
JunsuChoi [Wed, 27 Nov 2019 13:23:12 +0000 (08:23 -0500)]
tests/layout: add unit test for legacy layout theme,changed signal

split from D10744

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10751

4 years agoefl_ui/layout: unconditionally emit theme,changed event for legacy layouts
Mike Blumenkrantz [Wed, 27 Nov 2019 13:12:52 +0000 (08:12 -0500)]
efl_ui/layout: unconditionally emit theme,changed event for legacy layouts

this will automatically be optimized by smart callback internals and fix
emission of this event

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10750

4 years agotests/layout: add explicit test for implicit theme,changed emission
Mike Blumenkrantz [Tue, 26 Nov 2019 15:59:21 +0000 (10:59 -0500)]
tests/layout: add explicit test for implicit theme,changed emission

this must be emitted automatically during finalize if theme_set is
not directly called during construction

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10741

4 years agotests/layout: validate EFL_UI_LAYOUT_EVENT_THEME_CHANGED emission in theme test
Mike Blumenkrantz [Tue, 26 Nov 2019 15:54:36 +0000 (10:54 -0500)]
tests/layout: validate EFL_UI_LAYOUT_EVENT_THEME_CHANGED emission in theme test

ensure that this callback is emitted exactly one time if the theme is
set during construction

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10740

4 years agotests/layout: fix theme apply test for layout object
Mike Blumenkrantz [Tue, 26 Nov 2019 15:52:31 +0000 (10:52 -0500)]
tests/layout: fix theme apply test for layout object

the group previously used (efl/win/background) no longer exists, and
this test never verified that the theme_set call succeeded so this has
been failing silently for a long time

now we check and verify that the call succeeds in addition to using a
valid group

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10739

4 years agoefl_ui/layout: fix multiple emissions of theme,changed during construction
Mike Blumenkrantz [Tue, 26 Nov 2019 15:49:55 +0000 (10:49 -0500)]
efl_ui/layout: fix multiple emissions of theme,changed during construction

in the case where a layout object was created and had a theme manually set
with efl_ui_layout_theme_set() during construction, the layout would then
call theme_apply() a second time internally during finalize which, if the
theme has not changed (as can only be the case if this flag is unset),
results in a repeated theme_apply for the existing theme

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10738

4 years agoefl_ui/layout: fix typo in theme,changed event checking and fix this event
Mike Blumenkrantz [Tue, 26 Nov 2019 15:48:42 +0000 (10:48 -0500)]
efl_ui/layout: fix typo in theme,changed event checking and fix this event

this was a copy/paste error

ref 7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10737

4 years agoefl_ui_radio_box: declare stable
Marcel Hollerbach [Tue, 3 Dec 2019 13:47:31 +0000 (14:47 +0100)]
efl_ui_radio_box: declare stable

this was forgotten, the task for it (T8026) was even closed.

Differential Revision: https://phab.enlightenment.org/D10786

4 years agoefl_ui_mutli_selectable: stabelize interfaces
Marcel Hollerbach [Mon, 25 Nov 2019 12:33:44 +0000 (13:33 +0100)]
efl_ui_mutli_selectable: stabelize interfaces

these classes are after a long naming discussion stable.

fixes T7871
fixes T8265
fixes T7922

Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D10734

4 years agoefl_canvas_animation_group: remove implicit children behaviour
Marcel Hollerbach [Wed, 4 Dec 2019 13:20:43 +0000 (14:20 +0100)]
efl_canvas_animation_group: remove implicit children behaviour

you could set the duration of the group to all children, however, the
default behaviour was to not do that. This is however a bit probeblatic,
and needs to be more expclicit. If this is needed again, then this can
be reintroduced, however, not in this form.

ref T8437
Depends on D10798

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10799

4 years agoremove unsued macros
Marcel Hollerbach [Wed, 4 Dec 2019 09:23:23 +0000 (10:23 +0100)]
remove unsued macros

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10798

4 years agoefl_canvas_animation: use floating point infinite instead of macro
Marcel Hollerbach [Wed, 4 Dec 2019 09:20:38 +0000 (10:20 +0100)]
efl_canvas_animation: use floating point infinite instead of macro

the floating point infinite builtin should also work cross languages (so
this is better for bindings).

ref T8437

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10797

4 years agoefl_canvas_animation: add a standard value for duration of animations
Marcel Hollerbach [Wed, 4 Dec 2019 09:14:09 +0000 (10:14 +0100)]
efl_canvas_animation: add a standard value for duration of animations

before this commit the standard time was 0, which results in no
animation played at all. Now its 0.2 and a app that does not like it can
adjust it.

ref T8436

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10796

4 years agoefl_canvas_animation_group: use @property instead of method
Marcel Hollerbach [Wed, 4 Dec 2019 09:51:04 +0000 (10:51 +0100)]
efl_canvas_animation_group: use @property instead of method

this also refreshes the documentation of all this.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10795

4 years agoeolian: fix a parse bug where composites was treated as implements
Daniel Kolesa [Wed, 4 Dec 2019 15:04:19 +0000 (16:04 +0100)]
eolian: fix a parse bug where composites was treated as implements

In the specific case where you had "class A extends B composites C"
the correct composites branch was ignored and instead the implements
branch was used. This was entirely wrong/an oversight that did not
appear until now. Other combinations were handled correctly.

4 years agodocs: slight improvement for Efl.Decelerate_Interpolator
Xavi Artigas [Wed, 4 Dec 2019 14:58:04 +0000 (15:58 +0100)]
docs: slight improvement for Efl.Decelerate_Interpolator

4 years agoeolian: account for entire inheritance trees when compositing
Daniel Kolesa [Wed, 4 Dec 2019 14:30:17 +0000 (15:30 +0100)]
eolian: account for entire inheritance trees when compositing

When a class composites an interface, we need to ignore all of
its extends (and extends of those) as well as the main interface
when doing API checks, as composites essentially provides a
guarantee that this *will* be implemented at runtime, which
further extends to the whole inheritance tree of that interface.

Fixes T8491.

4 years agofix the wrong method signature for evas_textgrid
Taehyub Kim [Wed, 4 Dec 2019 10:12:48 +0000 (19:12 +0900)]
fix the wrong method signature for evas_textgrid

Summary:
fix the wrong method signature famliy font get and font size get for evas_textgrid
the method parameter should be changed to return type
@fix

Reviewers: Hermet, ali.alzyod, woohyun

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10794

4 years agoefl_canvas_animation_group: move from list to iterator
Marcel Hollerbach [Tue, 3 Dec 2019 15:00:29 +0000 (16:00 +0100)]
efl_canvas_animation_group: move from list to iterator

we should not use lists directly, ownership issues etc. etc..
This moves it to iterators

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10787

4 years agoedje_entry: converting plain_text to '*' using unicode units.
Bowon Ryu [Wed, 4 Dec 2019 08:09:33 +0000 (17:09 +0900)]
edje_entry: converting plain_text to '*' using unicode units.

Summary:
When converting plain_text to '*' in retrieve_surrounding_cb,
always convert it to '*' in 1 byte unit.

For example,
2 byte character is converted to "* *"
and 3 byte character is converted to "* * *"

However, this does not match the number of '*' printed in the entry.
Because, '*' in the entry is printed according to number of unicode characters.

This patch converts plain_text into unicode units
when converting plain_text to '*'

Test Plan: N/A

Reviewers: woohyun

Reviewed By: woohyun

Subscribers: cedric, #reviewers, jihoon, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10792

4 years agoRevert "ecore_buffer: Fix ABI break" 18/219318/1
Woochanlee [Wed, 4 Dec 2019 08:19:12 +0000 (17:19 +0900)]
Revert "ecore_buffer: Fix ABI break"

This reverts commit 2e3c342f1a9f5f60cc35072d6437d3d393e3d3b7.

Change-Id: Ibb0b8c582ce32df72f421063b6c3f0342cb10cc0

4 years agoecore_buffer: Fix ABI break 88/219288/2
Woochanlee [Wed, 4 Dec 2019 05:15:56 +0000 (14:15 +0900)]
ecore_buffer: Fix ABI break

Change-Id: I5639130566e4af80ad0c14c6235aff79c471677c

4 years agoFreeBSD: Link against OpenSSL in base. submit/tizen/20191203.210336
Alastair Poole [Tue, 3 Dec 2019 18:50:38 +0000 (18:50 +0000)]
FreeBSD: Link against OpenSSL in base.

Summary:
When pulling in OpenSSL and building against the
port there are some linker complications.

For example, doing a TLS HTTP transaction will
crash in libcurl which was built against
OpenSSL in base. If we link against FreeBSD's
OpenSSL these issues are resolved.

Test Plan:
On FreeBSD use the openssl port and build EFL
against it.

1) Upload a screenshot in E (segv).
2) Click on a link to image in terminology over
HTTPS (segv).

Reviewers: bu5hm4n, raster

Reviewed By: raster

Subscribers: cedric, Peter2121, #reviewers, q66, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10789

4 years agoEfl.Canvas.Gesture_Zoom: typo in docs
Xavi Artigas [Tue, 3 Dec 2019 17:03:56 +0000 (18:03 +0100)]
Efl.Canvas.Gesture_Zoom: typo in docs

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_title functions
Woochanlee [Tue, 3 Dec 2019 15:59:12 +0000 (10:59 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_title functions

Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_title functions

ref T8016
ref D10743

Reviewers: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8016

Differential Revision: https://phab.enlightenment.org/D10761

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_class functions
Woochanlee [Tue, 3 Dec 2019 15:49:37 +0000 (10:49 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_class functions

Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_class functions

ref T8016
ref D10743

Reviewers: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8016

Differential Revision: https://phab.enlightenment.org/D10759

4 years agoecore-wl2: Move ecore_wl2_window_buffer_transform_set to be internal
Christopher Michael [Tue, 3 Dec 2019 15:47:32 +0000 (10:47 -0500)]
ecore-wl2: Move ecore_wl2_window_buffer_transform_set to be internal

This function is unused outside of EFL internals, so there is no need
for it to be a public API.

ref T8013

4 years agoecore-wl2: Move ecore_wl2_window_buffer_attach to be internal
Christopher Michael [Tue, 3 Dec 2019 15:40:21 +0000 (10:40 -0500)]
ecore-wl2: Move ecore_wl2_window_buffer_attach to be internal

As this function is not used outside of EFL itself, it can be moved to
be internal and not an exposed API function

ref T8013

4 years agoEfl.Ui.Spotlight_Container: update docs after push/pop changes
Xavi Artigas [Tue, 3 Dec 2019 12:51:52 +0000 (12:51 +0000)]
Efl.Ui.Spotlight_Container: update docs after push/pop changes

Differential Revision: https://phab.enlightenment.org/D10784

4 years agoefl_ui_spotlight_manager_stack: fix positioning
Marcel Hollerbach [Tue, 3 Dec 2019 11:00:20 +0000 (12:00 +0100)]
efl_ui_spotlight_manager_stack: fix positioning

we also need to reemit the position of current active element. Otherwise
the indicator will display a wrong value.

This is already done in any other spotlight manager.

fixes T8499

Differential Revision: https://phab.enlightenment.org/D10782

4 years agoefl_ui_spotlight_container: reverse push and pop semantics
Marcel Hollerbach [Tue, 3 Dec 2019 10:48:56 +0000 (11:48 +0100)]
efl_ui_spotlight_container: reverse push and pop semantics

before this commit, push would add before the current element, pop would
return to the next higher element.
after this commit, push would add after the current element, pop would
return to the previous element.

ref T7991

Differential Revision: https://phab.enlightenment.org/D10781

4 years agoeina - threadqueue - revert series of comments that moved to mempools
Carsten Haitzler (Rasterman) [Tue, 3 Dec 2019 09:18:35 +0000 (09:18 +0000)]
eina - threadqueue - revert series of comments that moved to mempools

Revert "eina: remove no longer used function _eina_thread_queue_msg_block_real_free"
This reverts commit 695b44526c968787374fd421327422a6eea710a7.

Revert "eina/threadqueue: use mempool_del for hash free function"
This reverts commit b0cb3b935a8faf2d67bae38a54683946cb01d0b9.

Revert "eina_thread_queue: use normal mempools for block allocation"
This reverts commit 14ae3e3dec7866e74f2990dca417eac44da41058.

Why? Threadqueue is a highly performance sensitive API.
_eina_thread_queue_msg_block_new() may be called quite often. Doing a
hash lookup to then find a mempool handle to then allocate from was
not the same as what was there and was going to be far more costly.
This would have actual performance impact as we have to compute a hash
and rummage through a hash, hunt for an environment var too. The
original code looked at a spare block pool where blocks *MAY* be of
different sizes (not always the same size so using a mempool is
actually wrong and will stop threadqueue from being able to send
larger messages at all). If you send large messages, larger blocks would
have been allocated and put in this pool. In almost all cases the first
item in the pool would be big enough so we don't hunt and the find pulls
out the first memory, resets the fields that are needed and returns that
block. If it needs a bigger one, it does hunt. This is going to be
rare that such big blocks are needed so I never tried to optimize this
(but it could be done with an array of sizes to make a walk to find
the right sized element cheap if the need arises).

Performance dropped quite a lot. On aarch64 The above mempool usage
dropped message rate from 1037251 msg/sec to 610316. On x86 it was even
worse. It dropped from 2815775 msg/sec to 378653.

So backing this out sees the message rate is 7.4 times faster and on
aarch64 it's 1.7 times faster.

So moving to a mempool was actually just wrong (size is not always the
same). Also this ended up with a mempool of 64k for thread queue blocks even
if we only sent messages sporadically, as opposed to a single 4kb
block. So backing this out saves memory by only having 1 or 2 4k blocks
around most of the time, not a 64k mempool.

So the above patch then follow-on patches were done without accounting
for the performance implications. There were good reasons to do what I
did - because this code was highly tuned even to the point where I
used atomics instead of locks specifically to cut down some contention
overhead. Beware when you change something that there may be steep
performance implications. 7.4 times faster to go back to what was
there is a great example.

4 years agoelementary_test: remove duplicated file
Stefan Schmidt [Thu, 28 Nov 2019 14:39:43 +0000 (15:39 +0100)]
elementary_test: remove duplicated file

This file is identical with test_naviframe.c and has no reference in our
build system. Found by the use of the Duplo duplicated code checker
tool.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10777

4 years agogesture_manager: Changed function param to reduce internal function calls.
Woochanlee [Tue, 3 Dec 2019 07:14:29 +0000 (07:14 +0000)]
gesture_manager: Changed function param to reduce internal function calls.

The filter_event function calling a lot of times when it runs.

This can help performance by reducing the number of calls to the efl_data_scope_get() function.

Reviewed-by: Hermet Park <hermetpark@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10437

4 years agoecore_con: fix double close fd 04/218104/5
Hosang Kim [Tue, 19 Nov 2019 09:33:14 +0000 (18:33 +0900)]
ecore_con: fix double close fd

sometimes socket fd is closed twice.

@tizen_only

Change-Id: Ieb2c3e982160d10e6bd0333c82df4af34b0e1d18

4 years agocsharp: Simplify field_argument_assignment submit/tizen/20191202.210542
Lauro Moura [Mon, 2 Dec 2019 19:23:29 +0000 (16:23 -0300)]
csharp: Simplify field_argument_assignment

Summary: Avoid extra generator calls.

Reviewers: jptiz

Reviewed By: jptiz

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10774

4 years agofix jpeg loading which freed the wrong ptr
Carsten Haitzler (Rasterman) [Mon, 2 Dec 2019 19:53:31 +0000 (19:53 +0000)]
fix jpeg loading which freed the wrong ptr

fixes T8497
@fix

4 years agotests/ecore_wl2: Fix bad window test
Chris Michael [Mon, 2 Dec 2019 17:39:55 +0000 (12:39 -0500)]
tests/ecore_wl2: Fix bad window test

Small patch to fix issue where merge of patch did not go so well, and
thus caused Coverity to report an issue where window was not being
initialized.

ref T8016

fixes CID1408311

4 years agointroduce efl_ui_{pager/scroller}
Marcel Hollerbach [Mon, 2 Dec 2019 15:25:36 +0000 (16:25 +0100)]
introduce efl_ui_{pager/scroller}

They are just helpers, so a user does not need to handcreate spotlight
managers. This also leaves us the possibility of letting
spotlight_managers beeing @beta.

ref T7991

Differential Revision: https://phab.enlightenment.org/D10773

4 years agoefl_ui_test_spotlight: check correct transitions without animation
Marcel Hollerbach [Thu, 28 Nov 2019 18:31:04 +0000 (19:31 +0100)]
efl_ui_test_spotlight: check correct transitions without animation

this introduces the test requested in D10701. And checks that all
signals are correctly delivered even if animations are frozen

Differential Revision: https://phab.enlightenment.org/D10767

4 years agoefl_ui_spotlight_container: bring in min / max handling
Marcel Hollerbach [Thu, 28 Nov 2019 16:13:07 +0000 (17:13 +0100)]
efl_ui_spotlight_container: bring in min / max handling

the spotlight now is setting the overall correct min and max size on
itself. Additionally, the page size is now clamped to the size of the
container.

Correct min size of the container is defined to the MAX min size of all
the content.
The correct max size of the container is defined to the MIN max size of
all the content.

ref T7991

Differential Revision: https://phab.enlightenment.org/D10766

4 years agoefl_ui_spotlight: do not inherit from layout anymore
Marcel Hollerbach [Wed, 27 Nov 2019 17:34:40 +0000 (18:34 +0100)]
efl_ui_spotlight: do not inherit from layout anymore

before we inherited from layout, however the theme of the layout was
basically just the event part, and the holder part for the indicator.
The indicator part is going to be refactored into something else
anyways, since the indicator should be useable on other widgets as well.
Which means, only the event part is left, which is only used by the
scroller spotlight manager, (and now moved there).

With the move from this away we are saving round about 0.2KB of pure
edje accounting. Additionally, we are saving in perf 4% that is spend in
_efl_canvas_layout_efl_gfx_entity_size_set, which also makes this less
CPU intensive when resizing (Or even just starting is also enough).

ref T7991

Differential Revision: https://phab.enlightenment.org/D10765

4 years agoefl_ui_spotlight_indicator: make this undependend from the main widget
Marcel Hollerbach [Wed, 27 Nov 2019 17:30:00 +0000 (18:30 +0100)]
efl_ui_spotlight_indicator: make this undependend from the main widget

the main widget before presented a layout to hold the indicator,
however, for the causual case, this is not really needed. The indicator
itself is anyways going to be a more general prupose widget soon, where
the layout here can be taken as an starting point.

Additionally, this fixes general displaying of the indicator, before the
box padding refactor, a padding would have changed the minsize of the
mix, this is not the case anymore, which forces us to calculate the
minsize of the indicator theme.

Differential Revision: https://phab.enlightenment.org/D10764

4 years agoefl_ui_spotlight: move event rectangle
Marcel Hollerbach [Wed, 27 Nov 2019 16:04:24 +0000 (17:04 +0100)]
efl_ui_spotlight: move event rectangle

for now the eventrect was a swallow part, created by the container, set
to the edje layout. However, the only real user for this is the scroll
spotlight manager.
Which means, we have mostly unneeded element resized by edje, which is
quite an overhead. With this commit, this is moved to the scroll
manager, which makes the usage with stack and plain less memory heavy.

Differential Revision: https://phab.enlightenment.org/D10763

4 years agoefl_ui_spotlight: ensure correct positioning
Marcel Hollerbach [Wed, 27 Nov 2019 15:29:37 +0000 (16:29 +0100)]
efl_ui_spotlight: ensure correct positioning

if something is just repositioned, but not resized, it would not have
been placed correctly. This fixes that.

Differential Revision: https://phab.enlightenment.org/D10762

4 years agoefl_canvas_text: documentation for style set
Ali Alzyod [Mon, 2 Dec 2019 09:41:35 +0000 (10:41 +0100)]
efl_canvas_text: documentation for style set

Summary:
Depends on D10607

Original Material: https://www.enlightenment.org/_legacy_embed/evas_textblock_style_page.html

Reviewers: woohyun, segfaultxavi, AbdullehGhujeh

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10729

4 years agoefl_part: declare stable
Marcel Hollerbach [Mon, 2 Dec 2019 15:29:35 +0000 (16:29 +0100)]
efl_part: declare stable

Summary:
last release we declared efl_part.eo stable. But we accidently forgot
efl_part()...

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10772

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_aspect functions
Woochanlee [Mon, 2 Dec 2019 13:51:49 +0000 (08:51 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_aspect functions

Summary:
tests/ecore_wl2: Add test for ecore_wl2_window_aspect functions

ref T8016
ref D10743

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8016

Differential Revision: https://phab.enlightenment.org/D10747

4 years agoecore_wl2: Add APIs to get window properies.
Woochanlee [Mon, 2 Dec 2019 13:50:23 +0000 (08:50 -0500)]
ecore_wl2: Add APIs to get window properies.

Summary: Creates APIs to get property.

Reviewers: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10743

4 years agoRevert "Revert "evas map: diable high quality texture mapping feature.""
Hermet Park [Mon, 2 Dec 2019 11:40:28 +0000 (20:40 +0900)]
Revert "Revert "evas map: diable high quality texture mapping feature.""

This reverts commit 94c193e40b3111664344bf41beb22006bfab2670.

4 years agoeolian_gen: fix fallback 0 default values for slices
Daniel Kolesa [Mon, 2 Dec 2019 11:06:34 +0000 (12:06 +0100)]
eolian_gen: fix fallback 0 default values for slices

4 years agoeolian: emit correct c_name for keyword builtins
Daniel Kolesa [Mon, 2 Dec 2019 11:06:11 +0000 (12:06 +0100)]
eolian: emit correct c_name for keyword builtins