hyuna0213.jo [Tue, 16 May 2017 07:17:50 +0000 (16:17 +0900)]
Fixed memory leak on ocpayload.c
Fixed memory leak on ocpayload.c detected by static analysis
Change-Id: I3a8de43b8feff88509af6959f6b78b79eb8feb4c
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19937
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
saurabh.s9 [Thu, 18 May 2017 10:00:32 +0000 (15:30 +0530)]
[IOT-2294] Resolved saveTrustChain issue
Change-Id: Ib64f565304c78a281d082be1dd6cc99a73e3fdb9
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20029
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jihun Ha [Thu, 18 May 2017 10:37:37 +0000 (19:37 +0900)]
Fix some lines for proper coding convention.
Some brace locations are changed to better coding convention in scene manager
Change-Id: Id8edd9fbdf582ffcae1bfd8ba239e13a875f2068
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20037
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Oleksandr Dmytrenko [Thu, 18 May 2017 10:52:39 +0000 (13:52 +0300)]
[IOT-2324]warning fix 2
Warning fix in resource/csdk/security/provisioning
Change-Id: I3791fa427b04ac80a7e0847d4b13e6b121f74aa5
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20039
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Oleksandr Dmytrenko [Thu, 18 May 2017 09:58:00 +0000 (12:58 +0300)]
[IOT-2324]warning fix 1
Warning fix in resource/provisioning
Change-Id: I75664d7e2d083caab3eee222bef486a433a77e26
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20027
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Oleksandr Dmytrenko [Fri, 19 May 2017 11:54:35 +0000 (14:54 +0300)]
[IOT-2317] gDoxm NULL checks
Accessing global pointer variable gDoxm without NULL check fix
Change-Id: Ief964e6c941ef17a7a24fc07fb4f1807cfc07e0f
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20139
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
ol.beketov [Fri, 19 May 2017 11:42:37 +0000 (14:42 +0300)]
Fix return value in GetDtlsPskCredentials()
Fix return value in GetDtlsPskCredentials() from
credresource.c missed in patchset #19785
Change-Id: Id79111409f574ce49f037adb6602a4195666db0c
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20137
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Soemin Tjong [Fri, 3 Mar 2017 08:13:17 +0000 (00:13 -0800)]
Define OC_CALL (call convention for public APIs).
Set to __stdcall for WIN32.
Add to IPCA public APIs.
Other public APIs will be updated in separate commit.
Change-Id: I3201b7088eeb2227d2681847d20172825fbf4cae
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18169
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18847
saurabh.s9 [Thu, 11 May 2017 04:52:19 +0000 (10:22 +0530)]
[IOT-2131] Adding Method to create ACL id for Android App
Change-Id: I49658c8612f42b4d5caf90cce04e97d8e3315642
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19791
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
jihwan.seo [Fri, 19 May 2017 07:36:19 +0000 (16:36 +0900)]
Fix MessageQueue TC failure
Change-Id: I8a3ed1067f86a9a398b6b640ba738586cedf3f7e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20103
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Mats Wichmann [Fri, 10 Mar 2017 20:13:52 +0000 (13:13 -0700)]
Fix some filenames to be more Linux-friendly
Two filenames: one contains space, another an apostrophe,
interferes with easily running linux "find" on iotivity,
and there's no compelling reason why these characters are needed
in the names.
Change-Id: I85b554d874bed654a150915a23fb8b237e2f189a
Signed-off-by: Mats Wichmann <mats@linux.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19359
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
KIM JungYong [Tue, 16 May 2017 08:46:21 +0000 (17:46 +0900)]
Fix build warning on notification sample.
strcmp function is used but does not a including header.
in this patch string.h is included.
Change-Id: I37de71e3171c3586982c4173ef3c22864d82092b
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19945
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Philippe Coval [Tue, 9 May 2017 17:27:07 +0000 (19:27 +0200)]
simulator: Fix permission of sources
Change-Id: Iad9def49f47016435243c8ff44e2b052cd946ed2
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19827
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
jake [Thu, 18 May 2017 09:49:40 +0000 (18:49 +0900)]
Fix static analysis warnings on notification.
- Uninitialized variable is initialized
- Function strcpy is changed to strncpy
- When execution of equal operation, prevent copied it self
- Insert brace
Change-Id: I4de2c8cae30eea4c81cde1db7191788dc646b3dc
Signed-off-by: jake <jaehong2.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20025
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Senthil Kumar G S [Fri, 19 May 2017 15:11:10 +0000 (20:41 +0530)]
Updated mediator android application for secure mode.
In secure mode, mediator should send requests to the secure endpoint
of the easy-setup resource. Updated the sample to handle the same.
Change-Id: I5a27f06bcf2f8698d58e2b79049d7b342e303599
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20153
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Abhishek Sharma [Fri, 19 May 2017 16:22:45 +0000 (21:52 +0530)]
Unit tests enhancements for Proxy
Change-Id: I6c0285b3c8b396dde5337fe69c54a81ad610f2f3
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20155
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Tue, 16 May 2017 08:43:18 +0000 (17:43 +0900)]
Remove a build warning in easy-setup compilation
- The 3rd parameter of OCRepPayloadSetStringArray is one in "const char **"
type, not "char **"
- Align types to unsigned int in comparison
Change-Id: I391b29ac86f75928e4bea34077a38a2bea392b7e
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19941
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Oleksandr Dmytrenko [Fri, 19 May 2017 14:21:06 +0000 (17:21 +0300)]
[IOT-2319] Discovery Request fix
[CS][Csdk][Sample App] Discovery Request Crashed fix
Change-Id: Iffc7b61fce57dfab706122bc5649d3fd65ab0daa
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20151
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
saurabh.s9 [Thu, 18 May 2017 07:22:19 +0000 (12:52 +0530)]
[IOT-2265] [IOT-2142] [IOT-2164] Resolved Unowned device discovery in Android
Change-Id: Ic4327443832798ed3ce093566f1994216b84dad4
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20019
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Soemin Tjong [Tue, 9 May 2017 02:16:19 +0000 (19:16 -0700)]
IOT-2204: Fix IPCA compiler warnings on Linux
https://jira.iotivity.org/browse/IOT-2204
Change-Id: I523c947aba51b3d4d7b0b6e19745e783eab3eeeb
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19753
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Todd Malsbary [Wed, 17 May 2017 18:56:13 +0000 (11:56 -0700)]
IOT-2258: Allow secure and nonsecure endpoints with OCCreateResource.
Added new property flag OC_NONSECURE. To specify both secure and
nonsecure endpoints use OC_SECURE | OC_NONSECURE. The behavior when
neither flag is specified is OC_NONSECURE, the same as before this
change.
Bug: https://jira.iotivity.org/browse/IOT-2258
Change-Id: I12ffdff70a83455eff46d4464e234963063c4f35
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19995
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Dan Mihai [Tue, 16 May 2017 20:00:32 +0000 (13:00 -0700)]
IOT-2275 Windows: Disable the Cloud APIs
These APIs are not working on Windows.
Change-Id: I6c4869da290808fdb41d2d834a5dd1cbd0766744
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19967
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Ibrahim Esmat [Thu, 27 Apr 2017 16:13:35 +0000 (09:13 -0700)]
[IOT-2259] Windows: Handle Persistent Storage for UWP Apps
Changes to allow UWP apps that use IPCA to handle Persistent
Storage:
- Updated the SConscripts to point to store LIBS
- Added a UWP_APP env variable to enable building store DLLs
- Disabled gtest and other tests when building store DLLs
because gtest is heavily dependent on win32 APIs and DLLs
- Add code to set the sqlite3 temporary directory when building
for store DLLs (as required by sqlite3). This temporary
directory will be the appropriate temp directory.
- Add a platform helper function to get the best application
path to store the Persistent Storage files. IPCA uses this
helper function to get the path when opening PS files.
- Add capability to run.bat to build UWP DLLs
Change-Id: Iac3a2c9e9e2fd994b06e964254f2d394b15526aa
Signed-off-by: Ibrahim Esmat <iesmat@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19845
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Kevin Kane [Wed, 17 May 2017 23:13:26 +0000 (16:13 -0700)]
[IOT-2269] Do not include rowner property in csr resource CBOR
"rowner" property was being erroneously included in the CBOR
payload for the CSR resource, which caused the map in the
response to contain one more key/value pair than it should have.
This property should not be included as it is not part of the
specification for this resource.
Change-Id: I61a25535b79d21857b18f7f1f2bb077e8420b3f5
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20013
Reviewed-by: Alex Kelley <alexke@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Andrii Shtompel [Thu, 18 May 2017 11:10:45 +0000 (14:10 +0300)]
[IOT-2289] Add NULL check for acl param in OCProvisionACL
Change-Id: I5f950a890d4d7492795aced3dee4d6a052635361
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20043
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Andrii Shtompel [Thu, 18 May 2017 10:58:15 +0000 (13:58 +0300)]
[IOT-2291] Remove OCProvisionCRL from ocprovisioningmanager.h
Change-Id: I07415f840dac350beee008698d7b64f5bdae4517
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20041
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Ziran Sun [Thu, 13 Apr 2017 12:48:14 +0000 (13:48 +0100)]
Check for null alloc in rddatabase unit tests.
Bug: https://jira.iotivity.org/browse/IOT-2022
Change-Id: I6306e10d1c3ab1146e4588077cbe091f34089059
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19229
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
saurabh.s9 [Fri, 19 May 2017 08:37:28 +0000 (14:07 +0530)]
[IOT-2306] Direct pairing removed from provisioning java sample
Change-Id: I91d58d4f015cb12d114d995afbbe4e60649cf8c7
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20107
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Randeep Singh [Fri, 19 May 2017 05:19:48 +0000 (10:49 +0530)]
[IOT-2296] Removed unsupported menu option
Change-Id: Ie99a9d2b2d8181488cc49c7af4f1049e51a6537f
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20095
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Senthil Kumar G S [Wed, 17 May 2017 14:55:33 +0000 (20:25 +0530)]
Added unit test cases for missed out APIs of mediator in easy-setup.
Unit test case for requestToConnect and provisionCloudProperties APIs.
This improves code coverage as well.
Change-Id: Ice5f616150269c9b375d47a7dd3eb23c0fec95a5
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19991
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jaehong Jo [Mon, 8 May 2017 10:32:08 +0000 (19:32 +0900)]
[IOT-2171] Add string blank check logic.
Because space is not empty.
Change-Id: I8c422c20322bab8b7833fc0293cdd4d84cc90019
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19709
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Randeep Singh [Thu, 11 May 2017 15:17:06 +0000 (20:47 +0530)]
[IOT-2131] Resolved Sample App SignOut crash issue
Change-Id: Ieaa575d50ff467e705667930bc4f8e907532c795
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19805
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Dan Mihai [Thu, 18 May 2017 15:38:33 +0000 (08:38 -0700)]
Don't include cacommon.h in sample apps
cacommon.h is not a Public header.
This also fixes recent Windows build breaks:
ocserver.cpp
C:\Program Files (x86)\Windows Kits\8.1\include\shared\ws2def.h(100):
error C2220: warning treated as error - no 'object' file generated
C:\Program Files (x86)\Windows Kits\8.1\include\shared\ws2def.h(100):
warning C4005: 'AF_IPX': macro redefinition
C:\Program Files (x86)\Windows Kits\8.1\include\um\winsock.h(452):
note: see previous definition of 'AF_IPX'
C:\Program Files (x86)\Windows Kits\8.1\include\shared\ws2def.h(140):
warning C4005: 'AF_MAX': macro redefinition
...
Change-Id: I4c6ac41a5869c2dced1f38a8eed09c4ab42e2076
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20057
Reviewed-by: Ibrahim Esmat <iesmat@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Dan Mihai [Thu, 18 May 2017 14:43:09 +0000 (07:43 -0700)]
Fix Windows build break
Fixing:
resource\csdk\connectivity\src\adapter_util\ca_adapter_net_ssl.c(1345):
error C2220: warning treated as error - no 'object' file generated
resource\csdk\connectivity\src\adapter_util\ca_adapter_net_ssl.c(1345):
warning C4389: '!=': signed/unsigned mismatch
Change-Id: I42fb71ff8dd39e5db600068daf8ab2b41c6336ce
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20055
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Nathan Heldt-Sheller [Mon, 15 May 2017 15:53:29 +0000 (08:53 -0700)]
[IOT-2247] [IOT-2308] Clean up provisioning/sample/*.json files
The goal is to make the .json more readable an remove confusing extra
values.
I tried to leave them functionally identical, with
the exception that I merged the /doxm (Read, Update) and /roles
(Full Control) ACEs into a single ACE with permission 14
(Read, Update, Delete) which is sufficient for both /doxm and /roles.
I verified that at least JustWorks and Random PIN files work,
as well as security unittests.
Change-Id: Id4e7c94a7ce941b5e396b61096b89732aab1be4e
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19923
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
George Nash [Wed, 17 May 2017 20:36:36 +0000 (13:36 -0700)]
Revert commit that modified OCRepresentation and AttribueValue
The commit for [IOT-1583] had several unseen concequnces and
should not be on the 1.3-rel branch.
This change reverts that commit as well as two commits
that were made in responce to that commit.
Revert "resource: Avoid to expose internal headers"
This reverts commit
6303c498fcebe1304983e5a650e5e6ec712e0cab.
Revert "[IOT-2251] Resolve getValue() & setValue() APIs for argument string, Attribute Value"
This reverts commit
05671f38527acd30ff5a761b3c0a7cde933a0b17.
Revert "IOT-1583: Fixing /W3 warnings in /resource directory - part 5."
This reverts commit
924a7f267298aafc379ee0fa62871724e8afce19.
See also the following bugs
Bug: https://jira.iotivity.org/browse/IOT-2233
Bug: https://jira.iotivity.org/browse/IOT-2251
Bug: https://jira.iotivity.org/browse/IOT-2277
Bug: https://jira.iotivity.org/browse/IOT-1583
Bug: https://jira.iotivity.org/browse/IOT-2254
Change-Id: I6ca8fad887ff7a17a0bceacfe0ba2147d64c9394
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20007
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: Dan Mihai <Daniel.Mihai@microsoft.com>
ol.beketov [Thu, 18 May 2017 10:21:34 +0000 (13:21 +0300)]
[IOT-2285] Fix build failure
Fix build failure due to checkin
https://gerrit.iotivity.org/gerrit/19785
Change-Id: If9793e3b3219b71b12d53a1e66672863ab66d62e
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/20033
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Oleksandr Moliavko [Wed, 17 May 2017 13:52:06 +0000 (16:52 +0300)]
Fixes for issues found by SVACE in branch 1.3-rel
Change-Id: Ibdb076b2c35390fc0d38d578b0a1e2c8fc40dc54
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19983
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Andrii Shtompel [Wed, 17 May 2017 10:17:33 +0000 (13:17 +0300)]
[IOT-1818] Fix SetResult() usage in OwnerCredentialHandler()
Change-Id: Ia8a0535164e73fcc8e53ca9755717af701759e8c
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19977
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Ziran Sun [Tue, 2 May 2017 09:52:10 +0000 (10:52 +0100)]
Append accept format and accept version in options.
If accept format and accept version are not set via option headers,
set them to default value via stack functions.
These values will be passed to rcvdVendorSpecificHeaderOptions through
requestInfo.info.options.
Bug: https://jira.iotivity.org/browse/IOT-1973
Change-Id: I10f589cf3e18fc105640e1a27df5d50aa1b73298
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19535
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Glen Youngjin Kim [Tue, 16 May 2017 12:31:42 +0000 (21:31 +0900)]
Remove build warnings related to comparison between enums.
Change-Id: Iaff2e2312ab215c352a1573ba0dddb195afa73a3
Signed-off-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19951
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaewook Jung [Tue, 16 May 2017 11:10:51 +0000 (20:10 +0900)]
Remove build warnings
Change-Id: Ib22fda47f5e843bc753966c085942014d70d4922
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19949
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Soemin Tjong [Tue, 16 May 2017 16:38:47 +0000 (09:38 -0700)]
Fix build error for WITH_MQ=1.
Change-Id: I24652573cebe1b7a04c3c1c2ac765234377e8216
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19963
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
ol.beketov [Tue, 16 May 2017 15:32:08 +0000 (18:32 +0300)]
[IOT-2089] Realloc NULL checks added
Change-Id: Ie1b99a3815c8126e35576d4c3daa91c73ad66c6d
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19663
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
ol.beketov [Wed, 10 May 2017 14:56:36 +0000 (17:56 +0300)]
[IOT-2172] Length check before memcpy added
Change-Id: I539a8f21fd149b7d468d96b52e7bcadc964f6931
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19785
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Philippe Coval [Wed, 26 Apr 2017 07:57:11 +0000 (09:57 +0200)]
gtest: Use whereis instead of which
whereis command is more popular that which among GNU/Linux Distros:
Archlinux is not having which by default
For reference debian has them in different packages:
util-linux: /usr/bin/whereis
debianutils: /usr/bin/which
Bug: https://jira.iotivity.org/browse/IOT-2084
Change-Id: I1966a31df1281e7f28fb8ea40f3dc4514ba22713
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19345
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Abhishek Sharma [Tue, 16 May 2017 10:44:16 +0000 (16:14 +0530)]
[IOT-2202] Optimize memory allocation logic
Change-Id: I936752834dfd4c8f80525a773a2a92607a147702
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19947
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Ondrej Tomcik [Mon, 15 May 2017 09:10:34 +0000 (11:10 +0200)]
Implement reconnection and ping-pong between cloud services. Make
heartbeat configurable. Fix tests.
Change-Id: I2483f6548f906fd1cf780d63e1ce82fb2b66ca86
Signed-off-by: Ondrej Tomcik <ondrej.tomcik@kistler.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19907
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Philippe Coval [Mon, 15 May 2017 10:03:48 +0000 (12:03 +0200)]
resource: Avoid to expose internal headers
Change-Id: Ifa7b2c20e1b793b14d48557cc1d194be24fcd622
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19909
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Soemin Tjong [Wed, 10 May 2017 01:09:10 +0000 (18:09 -0700)]
IOT-2228: Stop observe once.
https://jira.iotivity.org/browse/IOT-2228
Prevent raised exception in OC library.
Change-Id: I8774cac155b446a166f574a2e5c357c6a53ba1f2
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19761
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Dan Mihai [Mon, 15 May 2017 18:53:57 +0000 (11:53 -0700)]
Fix Windows build break
Increase the default compiler limit. Error started with recent change
05671f38527acd30ff5a761b3c0a7cde933a0b17.
Fixing:
fatal error C1128: number of sections exceeded object file format
limit: compile with /bigobj.
Change-Id: I1e4c1284c7fb7057a14355d7362397ed2919c37d
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19961
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Andrii Shtompel [Sat, 13 May 2017 12:08:23 +0000 (15:08 +0300)]
Fix provisioning/unittest after apply #19593
Following changes were made for provisioning/unittest:
1. Use default SVR DB for client (from provisioning/sample)
2. Use default SVR DB for server1 (server_justworks.dat)
3. Use default SVR DB for server2 (server_justworks.dat) + set unique uuid
4. Increase timeout's to the same value's as in provisioning client
5. Increase from 3s to 5s servers initialization time
Change-Id: I5ae27fdd4e89163e0f437cdf05070dad7079dbb8
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19865
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Andrii Shtompel [Fri, 12 May 2017 13:14:52 +0000 (16:14 +0300)]
Fix provisioning unit tests
1. Fix SRPSaveOwnCertChainTestNullKey
2. Fix SRPSaveOwnCertChainTest
Change-Id: I7f669edca162ab87178817b131359bfc3b059c7b
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19829
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Nathan Heldt-Sheller [Sat, 13 May 2017 04:26:48 +0000 (21:26 -0700)]
[IOT-2224] ace2 Resource "wc" type
Implement phase-out of "*" href and replace with
"wc" types:
"*" = ALL_RESOURCES
"+" = ALL_DISCOVERABLE
"-" = ALL_NON_DISCOVERABLE
Add support for "wc" type to Policy Engine.
Change-Id: I738110de4d132dc5e60c73c79ad8e6b0d535d8d5
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19861
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Dan Mihai [Mon, 15 May 2017 17:59:35 +0000 (10:59 -0700)]
Fix Windows build break
Verify that the block data ID is smaller than UINT8_MAX, then cast
its value to uint8_t.
Fixes compiler warning/error:
resource\csdk\connectivity\src\cablockwisetransfer.c(893):
error C2220: warning treated as error - no 'object' file generated
resource\csdk\connectivity\src\cablockwisetransfer.c(893):
warning C4267: 'function': conversion from 'size_t' to 'uint8_t',
possible loss of data
scons: *** [out\windows\amd64\debug\resource\csdk\connectivity\src\cablockwisetransfer.obj] Error 2
Change-Id: Iae032d52614cf6d10b8ec229430dddbb6f8ee114
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19927
Reviewed-by: Ibrahim Esmat <iesmat@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Abhishek Sharma [Mon, 15 May 2017 12:07:07 +0000 (17:37 +0530)]
Fix broken build for Proxy
Change-Id: I97fcdc8510a10172b52567fbf2c99db19e490a78
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19917
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Tue, 16 May 2017 04:00:56 +0000 (13:00 +0900)]
Fix 'isCloudAccessible' API which returned a wrong value
"rt" property is written inside "rep" property.
Change-Id: I2cf76661d9c04b32587333a5aefb4474f863d3e7
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/18991
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Mushfiqul Islam Antu [Mon, 15 May 2017 11:46:04 +0000 (17:46 +0600)]
Updated Randompin resource di
Randompin Resource di has been changed to be same as justworks
resource di, which is causing fail in pair wise link menu of
provisioningclient app(As pairwise link is not supported for
2 different device with same di)
[Update] changed di to be visually distinct
Change-Id: Ibcf7d6f1d7e65a32ee7113ddaec958ab8073aa08
Signed-off-by: Mushfiqul Islam Antu <i.mushfiq@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19915
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Uze Choi [Tue, 2 May 2017 05:48:38 +0000 (05:48 +0000)]
NSConsumerTest2.cpp string typo
Sample application has string typo.
Change-Id: I8eb8c70e89199cb123dff1991759edb38056dec5
Reviewed-on: https://gerrit.iotivity.org/gerrit/19521
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Senthil Kumar G S [Thu, 11 May 2017 12:09:31 +0000 (17:39 +0530)]
[IOT-2117][Bug][Data loss] No check for snprintf return.
Added code to properly handle the return value of snprintf().
Change-Id: I12bb53e32279d0ac7c09740389e6d3124b19c4dc
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19657
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jaewook Jung [Mon, 15 May 2017 11:39:16 +0000 (20:39 +0900)]
Fix defects detected by static code analyzer
- 'addr' of CAEndpoint is a char array so the address of the array cannot
be null.
- 'requestData' is not dynamic-allocated memory.
Change-Id: Ibcb9f5011b01f19e4624b4d71dcb0181637480b3
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19913
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Senthil Kumar G S [Mon, 15 May 2017 15:28:18 +0000 (20:58 +0530)]
Fix for IOT-2253.
Perform Null check before calling the member functions of OC::OCSecureResource.
This patch solves the crash issue.
Change-Id: Ieb292eee8724bf5ceb2918de424c76c9b780fa16
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19921
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Dan Mihai [Mon, 15 May 2017 18:42:23 +0000 (11:42 -0700)]
Fix Windows build break.
Fixing:
D:\GitRoot\1.3-rel\extlibs\gtest\googletest-release-1.7.0\include\
gtest/gtest.h(1577): error C2220: warning treated as error -
no 'object' file generated
resource\csdk\connectivity\test\ssladapter_test.cpp(3194):
note: see reference to function template instantiation
'testing::AssertionResult testing::internal::CmpHelperNE<int,bool>(
const char *,const char *,const T1 &,const T2 &)' being compiled
with
[
T1=int,
T2=bool
]
D:\GitRoot\1.3-rel\extlibs\gtest\googletest-release-1.7.0\include\
gtest/gtest.h(1577): warning C4805: '!=': unsafe mix of type
'const int' and type 'const bool' in operation
Change-Id: I055105a058c16242ef17ee01a1e9267178a48751
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19929
Reviewed-by: Ibrahim Esmat <iesmat@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Kevin Kane [Mon, 15 May 2017 16:28:50 +0000 (09:28 -0700)]
[IOT-2257] Add OCGetACL2Resource to DLL exports on Windows
Change-Id: I8d9b95b466c3804963c1c0760488cc00ff883529
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19925
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Dan Mihai [Fri, 12 May 2017 22:45:08 +0000 (15:45 -0700)]
IOT-2242 Port recent TCP adapter fix to Windows
Port change
be6cd0c7bacf86e45c498d18633f360b55c5a036 to Windows.
Unfortunately, Jenkins ignored the Windows build error for that change.
Change-Id: I059fa2d6b3bdd345f490239ea8a89612dbe8ceb9
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19855
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Way Vadhanasin <wayvad@microsoft.com>
Philippe Coval [Fri, 12 May 2017 13:26:58 +0000 (15:26 +0200)]
build: Enable libc++ std::this_thread::sleep_for if unavailable
This was needed to support gcc-4.{6..7} on GNU/Linux Ubuntu 14
So I defined _GLIBCXX_USE_NANOSLEEP if not enabled at configure time,
To avoid messing up configurations it is only set for 4.7 and earlier,
but can extended to other versions if needed (4.8 seems OK).
Also config file is inserted before any header when it was needed.
Observed issue on Ubuntu 14.04.5 x86_64 with g++-4.7 package
(g++ (Ubuntu/Linaro 4.7.3-12ubuntu1) 4.7.3) is:
resource/src/InProcClientWrapper.cpp: \
In member function 'void OC::InProcClientWrapper::listeningFunc()': \
resource/src/InProcClientWrapper.cpp:107:13: \
error: 'sleep_for' is not a member of 'std::this_thread'
Bug: https://jira.iotivity.org/browse/IOT-2158
Change-Id: Ib63aa289e91cc5926946786ae2ce03525d83a37c
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19831
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Philippe Coval [Tue, 9 May 2017 17:27:29 +0000 (19:27 +0200)]
scene-manager: Fix permission of sources
Change-Id: I80afc952fc139154bcdad3097b3e3c24d7dcd3e5
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19911
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jaewook Jung [Thu, 11 May 2017 08:10:13 +0000 (17:10 +0900)]
[IOT-2170] Fixed an android crash error on OCAccountManager
Change-Id: Id698fe5fbff845a7a5c4ba7f77db56d37a712393
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19795
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Mushfiqu Islam Antu [Sun, 14 May 2017 13:38:48 +0000 (19:38 +0600)]
[IOT-2251] Resolve getValue() & setValue() APIs for argument string, Attribute Value
getValue() & setValue() APIs returned "no matching function argument" while being callled with the argument: string, AttributeValue
Previously this worked fine, this problem is being generated because of the commit:
https://gerrit.iotivity.org/gerrit/#/c/19585
Change-Id: Ibcf7d6f1d7e65a32ee7113ddaec958ab8073aa07
Signed-off-by: Mushfiqu Islam Antu <i.mushfiq@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19901
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Nathan Heldt-Sheller [Fri, 12 May 2017 04:33:07 +0000 (21:33 -0700)]
Update .json/.dat files for ocserverbasicops and occlientbasicops
Apps located in /resource/csdk/stack/samples/linux/secure directory.
Edited .json to conform to OCF 1.0 SVR schema (e.g. /acl2, /pstat.dos, etc.),
and re-encoded to CBOR using json2cbor.
Depends on 19593.
Change-Id: Ie06b5b349c727e85403b6b7f0a63242993682e4a
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19817
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Todd Malsbary [Mon, 24 Apr 2017 21:55:03 +0000 (14:55 -0700)]
[IOT-1940] Include Uri-Path in blockwise requests.
This is correctly done for unicast requests but not for multicast
requests.
Bug: https://jira.iotivity.org/browse/IOT-1940
Change-Id: I9fa2d498ec4bec0cece2a75c51be2a64e05ce5f5
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19263
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Todd Malsbary [Fri, 5 May 2017 22:20:15 +0000 (15:20 -0700)]
[IOT-2218] Encode empty arrays as 80 ([]), not 80 F6 ([null]).
Bug: https://jira.iotivity.org/browse/IOT-2218
Change-Id: Iaa0086ac69d02d2d36169efb3f304c71cefc7425
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19689
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Oleksandr Dmytrenko [Tue, 25 Apr 2017 11:43:02 +0000 (14:43 +0300)]
[IOT-2083] TLSAdapter.Test_11
Change-Id: I4d6379193291d01d50ecbca2df25a51dc20b75c8
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19255
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Philippe Coval [Tue, 9 May 2017 17:22:11 +0000 (19:22 +0200)]
notification: Fix permission of sources
Change-Id: Ice7d0015aa1780e65875a0c0bd3a3d35fcbe68bd
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19749
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Senthil Kumar G S [Sun, 14 May 2017 08:03:00 +0000 (13:33 +0530)]
[IOT-2250] Mediator Android App Crash Fix.
The problem occurred due to incorrect type casting in mediator android sdk.
Change-Id: I3723f3d70be4295328544ab0f9cb129a5ed326ec
Signed-off-by: Senthil Kumar G S <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19893
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Philippe Coval [Fri, 12 May 2017 18:50:10 +0000 (20:50 +0200)]
csdk: Include config header before any header
It was needed for g++-4.7
Bug: https://jira.iotivity.org/browse/IOT-2244
Change-Id: Iee671616a6e32824be45f1e9424b48e9e073b237
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19837
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Mats Wichmann <mats@linux.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Fri, 12 May 2017 22:23:44 +0000 (07:23 +0900)]
[IOT-2036] Update Easy-Setup SDK
Change host of Remote Enrollee if secured one exists
Change-Id: I08af7865fe98deb6f2008fc147dcaf842f3bbb8d
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19807
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Dmitriy Zhuravlev [Sat, 13 May 2017 10:02:36 +0000 (13:02 +0300)]
[IOT-2036] Disable DOS checking
Workaround to pass Easy-Setup samples
Change-Id: Ib62f8de9f8a039ec9c6d1f7e6eb0a2f5544a905c
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19863
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Dmitriy Zhuravlev [Sat, 13 May 2017 14:56:26 +0000 (17:56 +0300)]
[IOT-2036] Fix empty string device ID
Allow to load PSK suites in case of empty deviceId
Change-Id: Idaf55bb3624c2f1d1a1825b0cdcaaa1bdd7d5caf
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19867
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Senthil Kumar G S <senthil.gs@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
saurabh.s9 [Mon, 8 May 2017 09:06:57 +0000 (14:36 +0530)]
[IOT-2104] corrected misused OIC_LOG_V
Change-Id: I50e28232eaeb26d3d34ce068313a5c6c844cde7f
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19705
Reviewed-by: Mats Wichmann <mats@linux.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Nathan Heldt-Sheller [Wed, 3 May 2017 07:59:24 +0000 (00:59 -0700)]
[IOT-1895] [IOT-2179] [IOT-1957] /acl2 Resource
ACE2 adds the "wc" property to the "resource" type, and the
"conntype" property to the "subject" type, allowing for more
flexible wildcards, and removing possible unintended collisions.
/acl2 also conforms to a different schema, so the CBOR encode/
decode functions are updated.
The unit tests are currently still using oic.sec.ace structures,
and will need to be updated to oic.sec.ace2 (see IOT-2192)
Updated provisiongclient and provisioning .json/.dat files to
use /acl2.
[x] update OicSecAce_t to support ace2
[x] update OicSecResource_t to support */+/- rsrc wildcards
[x] update AclToCBORPayload() to support /acl2
[x] update JSONToAclBin() to support /acl2
[x] update CBORPayloadToAcl() to support /acl2
[x] remove /oic/sec/acl resource
[x] verify provclient/justworks using above revisions
[x] verify unitttest using above revisions
Change-Id: If5a7105ac223537cd2249cec519e5657f651da3e
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19593
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Dan Mihai [Fri, 12 May 2017 06:06:51 +0000 (23:06 -0700)]
[IOT-2236] Allow POST to /oic/sec/acl
Restore the old behavior of starting parsing the payload with
ehRet == OC_EH_OK. This behavior has been modified incorrectly
by recent change
170dceb649c7aab72a087feec0b3e37bd8829848.
Change-Id: I13e5aa1e5f3a840668182d36ffb58d309cd8c1ad
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19819
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Andrii Shtompel [Wed, 10 May 2017 12:49:03 +0000 (15:49 +0300)]
[IOT-2134] Delete "Change default database" menu item
Change-Id: I6b1baa009aaa97364e5d1cd25e50ae03f3345c74
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19783
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Dmitriy Zhuravlev [Tue, 9 May 2017 08:25:46 +0000 (11:25 +0300)]
[IOT-2036] Fix default error initialization
OC_EH_INTERNAL_SERVER_ERROR changed to OC_EH_OK in HandleACLPostRequest
since it does not change in positive cases
Change-Id: I51ea056dde853909681b07be6ce328e0657cac0f
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19739
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Oleksandr Dmytrenko [Mon, 8 May 2017 16:03:01 +0000 (19:03 +0300)]
[IOT-2136] OCCloudAclFindMyGroup: Member ID mandatory param
OCCloudAclFindMyGroup returns OC_STACK_INVALID param when Member ID is NULL
Change-Id: I5b3834b2b7dc7b2a479c2363f0423347a8b6c12f
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19715
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
ol.beketov [Thu, 4 May 2017 13:42:08 +0000 (16:42 +0300)]
[IOT-2092] Check null pointer before dereference
Change-Id: Ib8032c41e8910087be5c5b30fee9a7b4a3992f01
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19623
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Andrii Shtompel [Thu, 11 May 2017 12:13:18 +0000 (15:13 +0300)]
[IOT-2147] Disable 50-83 requests in CloudClient
Change-Id: I3c8fc1d162580b2590f46da10896bd0573b47d2a
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19797
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Andrii Shtompel [Wed, 10 May 2017 10:27:14 +0000 (13:27 +0300)]
[IOT-2137] Add aceId NULL check to OCCloudAcl functions
Change-Id: Id143d92e3fd2f12001ddc9f26eec91fc230f8143
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19777
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
hyuna0213.jo [Wed, 10 May 2017 05:09:08 +0000 (14:09 +0900)]
[IOT-2146] Fixed Thread-unsafe code in tcp adapter
- Remove potential thread safety bugs in catcpserver
Change-Id: I95dba029b47e2a14b3217565a401c631b0b84cc2
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19767
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: koushik girijala <g.koushik@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Soemin Tjong [Thu, 4 May 2017 01:45:35 +0000 (18:45 -0700)]
IoT-2208: fix IPCA to get device's DMV and PIID
https://jira.iotivity.org/browse/IOT-2208
IPCA should not use OCPlatform::getPropertyValue() to obtain the data
model versions and protocol independent ID of the remote server.
It is incorrect as they return the values of the local server
(i.e. the app's own device info).
Change-Id: I7e8f64d9c7ebebd1b9bb4ec9290fbbdd1e0fa412
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19645
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Dmitriy Zhuravlev [Fri, 5 May 2017 15:45:12 +0000 (18:45 +0300)]
[IOT-2036] Fix mediator sample app
In 1.2.1 secure port was common for all secure resources.
Update sample to use OCF 1.0 endpoint information.
Change-Id: I105f8097c69b15a89b7b799817e2887b575f2770
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19667
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Dmitriy Zhuravlev [Thu, 27 Apr 2017 12:37:40 +0000 (15:37 +0300)]
[IOT-2156] Fix secure client stack sample
Update sample to use IoTivity 1.3 OCEndpointPayload format
Change-Id: I5094d504f3dfe69622eecb767039480c27ab03df
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19365
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
ol.beketov [Fri, 5 May 2017 10:42:51 +0000 (13:42 +0300)]
Key buffer length fix
CA_SECURE_ENDPOINT_PUBLIC_KEY_MAX_LENGTH enlarged to
fix cloud client unability to connect to cloud.
Change-Id: Ic16c186c3e493aaca8f8a1817bbcc1a2b4f799c8
Signed-off-by: ol.beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19659
Reviewed-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Andrii Shtompel [Mon, 8 May 2017 16:10:51 +0000 (19:10 +0300)]
[IOT-1610] Add TCP secure port to CAGetAssignedPortNumber
Change-Id: Iedcedb015eeebf6ce8847a084f475c2c48ec4506
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19717
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Oleksii Beketov <ol.beketov@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Soemin Tjong [Mon, 8 May 2017 23:42:55 +0000 (16:42 -0700)]
IOT-2223: Fix build break.
https://jira.iotivity.org/browse/IOT-2223
Use strlen instead of strnlen_s.
Change-Id: I11e837da3d9e31e092093732f48f72b4171319a4
Signed-off-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19731
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Todd Malsbary [Fri, 5 May 2017 19:54:38 +0000 (12:54 -0700)]
Fix debug build with RD_MODE=CLIENT,SERVER.
Change-Id: Ieefb03c920ecdac3bd20411d6b00f885136c5cf3
Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19685
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Sushil Yadav [Tue, 9 May 2017 10:09:04 +0000 (15:39 +0530)]
[IOT-1893] Delete Request Logic Fixed.
Change-Id: I0df40af7c198e3e26aa5450da3489e5876628acc
Signed-off-by: Sushil Yadav <sushil.ky@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19743
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jung Seungho [Wed, 10 May 2017 09:24:33 +0000 (18:24 +0900)]
fixed interval time in keepalive resource and logic to disconnect after sign up
Change-Id: I4cbf263f6ca2bfdc2614d3678b309aaa32dfe239
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19771
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Yeonghun Nam <yeonghun.nam@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Randeep Singh [Wed, 3 May 2017 13:08:39 +0000 (18:38 +0530)]
[IOT-2124] Added check after OICCalloc
Change-Id: Ia0ea3e17b4a3357d8c40309fc62967a25c5f2365
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19591
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
arya.k [Fri, 5 May 2017 11:53:40 +0000 (17:23 +0530)]
[IOT-1891] [RI] Issue fix OBSERVE Cancellation High QoS
When cancel observe is requested by client, the callback should return
a sequence number greater than MAX_SEQUENCE_NUMBER, and with no observe
header option.
Currently it is returning 0 which is not correct.So stack has been
modified to return a higher sequence number with the callback
for cancel observe confirmed response.
Change-Id: I85ea87454e3ca96f22fe7e414189ec0be7ea8dd8
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/19651
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
projects / platform / upstream / iotivity.git / log