Arun Raghavan [Sun, 10 Apr 2011 10:54:33 +0000 (16:24 +0530)]
sink-input: Provide more information to client when format is lost
When the sink format changes and we kill the stream, clients need a way
to know (a) what device they should reconnect to, and (b) what the
stream running time was when the stream got killed (pa_stream_get_time()
won't work after the stream has been killed). This adds these two bits
of information in the event callback's proplist parameter.
Arun Raghavan [Sat, 9 Apr 2011 04:06:25 +0000 (09:36 +0530)]
format: Add correct sample spec conversion for E-AC3
IEC61937-encapsulated E-AC3 frames contain 6 audio blocks per substream,
which corresponds to 1536 samples contained a 24576-byte frame. To cope
with this, we maintain the s16le stereo sample spec, but quadruple the
sample rate so that the conversion remains accurate.
Arun Raghavan [Tue, 29 Mar 2011 11:46:08 +0000 (17:16 +0530)]
format: Export pa_format_info_is_compatible in API
This allows clients to perform checks between formats as well.
Arun Raghavan [Mon, 28 Mar 2011 03:16:40 +0000 (08:46 +0530)]
sink-input: Add a format-lost event
This event is emitted if the sink-input could not be moved to a new sink
because it doesn't support the format of the sink-input. Clients can
reconnect their stream with a different format if they wish or
gracefully exit.
Arun Raghavan [Mon, 28 Mar 2011 03:16:20 +0000 (08:46 +0530)]
sink-input: Don't restore volume for passthrough streams
Arun Raghavan [Mon, 28 Mar 2011 03:15:31 +0000 (08:45 +0530)]
sink-input: Don't print an error if a passthrough connection fails
The assertion message is misleading, since the passthrough connection
can fail for reasons the client has no control over (like other sink
inputs being connected).
Arun Raghavan [Wed, 16 Mar 2011 10:38:23 +0000 (16:08 +0530)]
core: Factor out passthrough checks into their own functions
Since we currently have two mechanisms to signal a passthrough
connection (non-PCM format or PA_SINK_INPUT_PASSTHROUGH flag), we move
all the related checks into functions and use those everywhere.
This makes things more consistent, and should we decide to get rid of
the flag, we only need to change pa_sink_input_*_is_passthrough()
accordingly.
Arun Raghavan [Wed, 9 Mar 2011 15:20:25 +0000 (20:50 +0530)]
format: Add a type for DTS
Arun Raghavan [Tue, 8 Mar 2011 18:01:59 +0000 (23:31 +0530)]
introspect: Get format of sink input
This gets the negotiated format of sink inputs in
pa_context_get_sink_input*(). Also prints the format in 'pactl list'.
Arun Raghavan [Tue, 8 Mar 2011 18:00:24 +0000 (23:30 +0530)]
introspect: Get formats for sinks
This gets the list of supported formats for a sink in
pa_context_get_sink_info*(). Also prints these in 'pactl list'.
Arun Raghavan [Tue, 8 Mar 2011 14:46:00 +0000 (20:16 +0530)]
stream: Add API to get a stream's pa_format_info
Arun Raghavan [Tue, 8 Mar 2011 14:45:36 +0000 (20:15 +0530)]
format: Add some convenience functions for printing
Arun Raghavan [Tue, 8 Mar 2011 14:44:46 +0000 (20:14 +0530)]
format: Const-ify some parameters
Arun Raghavan [Tue, 8 Mar 2011 08:52:24 +0000 (14:22 +0530)]
alsa: Reconfigure sink sample rate for passthrough inputs
When a passthrough sink-input is added, we need to reconfigure the
sink's sample rate since no resampling occurs. We revert to the original
rate when the passthrough sink-input is removed.
Arun Raghavan [Thu, 3 Mar 2011 13:32:45 +0000 (19:02 +0530)]
core: Suspend monitor when a sink enters passthrough mode
In most cases it is expected that clients cannot consume compressed
data from monitor sources, so we suspend the monitor source when the
sink goes into passthrough mode.
Eventually, when the extended API includes client notifications for
changed formats, we should emit a notification on the monitor so that
clients can decide what they want to do when this happens (disconnect or
consume the data anyway).
Arun Raghavan [Thu, 3 Mar 2011 13:05:14 +0000 (18:35 +0530)]
sink: Trivial typo fix in comment
Arun Raghavan [Thu, 3 Mar 2011 07:22:21 +0000 (12:52 +0530)]
alsa-mixer: Remove passthrough profiles
These aren't used any more - we handle passthrough mode in the iec958*
profiles now.
Arun Raghavan [Wed, 2 Mar 2011 07:24:02 +0000 (12:54 +0530)]
core: Fix some FIXMEs for the extended API
This adds some checks that I'd postponed and adds a
"should-be-good-enough" guess for tlength when using a compressed
format.
Arun Raghavan [Wed, 2 Mar 2011 06:08:01 +0000 (11:38 +0530)]
sink-input: Kill passthrough streams if moving to an unsupported sink
This will eventually be replaced by a hook to let clients know that the
stream has moved so that they can gracefully reconnect and renegotiate a
supported format.
Arun Raghavan [Wed, 2 Mar 2011 05:46:48 +0000 (11:16 +0530)]
sink: Fix leak in pa_sink_check_formats()
We weren't freeing the sink formats idxset.
Arun Raghavan [Wed, 2 Mar 2011 06:01:51 +0000 (11:31 +0530)]
format: Avoid some code duplication
We frequently need to free an idxset containing pa_format_infos, so
define an internal free function that can be used directly with this
(instead of defining it once-per-file).
Arun Raghavan [Wed, 2 Mar 2011 05:46:07 +0000 (11:16 +0530)]
sink-input: Don't assert on bad formats
Handles bad format input more gracefully and returns an error instead.
Arun Raghavan [Wed, 2 Mar 2011 05:30:49 +0000 (11:00 +0530)]
sink-input: Return NOTSUPPORTED if format negotiation fails
This is easier for clients to grok than INVALID.
Arun Raghavan [Wed, 2 Mar 2011 05:23:45 +0000 (10:53 +0530)]
sink-input: Minor cleanups
Removes a couple of warnings and simplifies the assertion logic that
verifies format negotiation was successful.
Arun Raghavan [Wed, 2 Mar 2011 05:21:56 +0000 (10:51 +0530)]
tests: Add a trivial test for the extended API
This is just sync-playback.c modified to use the extended API. We need
something more sophisticated for properly testing the compressed
formats, but that is a non-trivial task in itself.
Arun Raghavan [Tue, 1 Mar 2011 20:36:54 +0000 (02:06 +0530)]
sink: Remove PASSTHROUGH flag
This removes the passthrough flag from sinks since we will drop
exclusively passthrough sinks in favour of providing a list of formats
supported by each sink. We can still determine whether a sink is in
passthrough mode by checking if any non-PCM streams are attached to it.
Arun Raghavan [Tue, 1 Mar 2011 11:04:06 +0000 (16:34 +0530)]
format: Add convenience API to check if a format is PCM or not
Arun Raghavan [Mon, 28 Feb 2011 07:53:23 +0000 (13:23 +0530)]
core: Add extended stream API to support compressed formats
This is the beginning of work to support compressed formats natively in
PulseAudio. This adds a pa_stream_new_extended() that takes a format
structure, sends it to the server (=> protocol extension) and has the
server negotiate with the appropropriate sink to figure out what format
it should use.
This is work in progress, and works only with PCM streams. Actual
compressed format support in some sink needs to be implemented, and
extensive testing is required.
More details on how this is supposed to work is available at:
http://pulseaudio.org/wiki/PassthroughSupport
Arun Raghavan [Mon, 28 Feb 2011 07:30:20 +0000 (13:00 +0530)]
sink: Extend API for compressed formats support
This adds a get_formats() vfunc for sinks to provide a list of formats
they can support. pa_sink_check_formats() can be used during or after
routing to determine what formats from a stream the sink can support.
Arun Raghavan [Mon, 28 Feb 2011 05:23:41 +0000 (10:53 +0530)]
format: Add some properties and internal API
The properties will be used by clients to set the sample format,
sampling rate, etc. The functions will be used internally.
Arun Raghavan [Fri, 25 Feb 2011 07:05:14 +0000 (12:35 +0530)]
core: Add a pa_format_info structure
This will be used to represent the format of data provided by the client
for both compressed and PCM formats in a new extended API.
Arun Raghavan [Thu, 24 Feb 2011 09:16:01 +0000 (14:46 +0530)]
sample: Use PA_SAMPLE_INVALID instead of numeric value
Arun Raghavan [Fri, 25 Feb 2011 07:14:53 +0000 (12:44 +0530)]
sink: Trivial typo fix
Pierre-Louis Bossart [Tue, 8 Mar 2011 09:42:56 +0000 (15:12 +0530)]
sink-input: Don't resample passthrough inputs
Arun Raghavan [Mon, 2 May 2011 04:38:27 +0000 (10:08 +0530)]
filter-apply: Mark modules as being autoloaded
(Based on Colin's review) We mark modules as being autoloaded so that
they can handle this as a special case if needed (which is required by
module-echo-cancel for now). This inverts how things were done and makes
using these modules manually less error-prone.
Maarten Bosmans [Sat, 30 Apr 2011 19:46:30 +0000 (21:46 +0200)]
Make connect-stress test compile for win32
Maarten Bosmans [Sat, 30 Apr 2011 13:25:55 +0000 (15:25 +0200)]
build-system: Small fixes
Maarten Bosmans [Sat, 30 Apr 2011 13:25:54 +0000 (15:25 +0200)]
build-system: Rearrange database selection
Maarten Bosmans [Sat, 30 Apr 2011 13:25:53 +0000 (15:25 +0200)]
build-system: Replace some more conditionals with AS_IF
Maarten Bosmans [Sat, 30 Apr 2011 13:25:52 +0000 (15:25 +0200)]
build-system: Move dependency error messages to outer scope
Maarten Bosmans [Sat, 30 Apr 2011 13:25:51 +0000 (15:25 +0200)]
build-system: Move AC_DEFINE to separate line with AS_IF
Maarten Bosmans [Sat, 30 Apr 2011 13:25:50 +0000 (15:25 +0200)]
build-system: Use AS_IF macro for configure output
And add some HAVE_[feature] variables for clarity.
Maarten Bosmans [Sat, 30 Apr 2011 13:25:49 +0000 (15:25 +0200)]
build-system: Simplify AC_ARG_ENABLE usage
Make use of the enable_[feature] variable automatically defined
by AC_ARG_ENABLE instead of defining our own variable.
Colin Guthrie [Fri, 29 Apr 2011 15:40:50 +0000 (16:40 +0100)]
combine: Rename module-combine to module-combine-sink.
This also includes a compatibility module that will ultimately be removed in
a future release.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:07 +0000 (17:48 +0300)]
bluetooth: Only close SCO if status has changed
In case the io thread is starting there is no point on closing SCO just
to resume it latter when the source/sink changes to opened state.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:06 +0000 (17:48 +0300)]
bluetooth: Fix using pointer-pointer when appending an array as variant
pa_dbus_append_basic_array_variant_dict_entry should take the direct
pointer to the array.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:05 +0000 (17:48 +0300)]
bluetooth: Fix not updating sample spec when using Media API
When using transport configured via Media API sample spec needs to be
updated since codec configuration may affect it when e.g. headset
configure a different frequency or number of channels from default.
Arnaud Fontaine [Tue, 29 Mar 2011 20:57:28 +0000 (22:56 +0159)]
x11: More XCB fixes.
Commit 65ef80b fixed building with xcb-util >= 0.3.8, but the reply is never
checked (possible SIGSEGV if the reply is NULL) nor freed (memory leak at each
call of the functions).
Also, remove include and dependencies on xcb-atom, as it was only meaningful
for xcb_atom_get() and STRING, and depend instead on xcb >= 1.6 for
XCB_ATOM_STRING.
Tanu Kaskinen [Fri, 29 Apr 2011 10:58:43 +0000 (13:58 +0300)]
dbus: Fix the order of freeing stuff when unloading module-dbus-protocol.
Tanu Kaskinen [Fri, 29 Apr 2011 10:58:42 +0000 (13:58 +0300)]
dbus: Fix connection idxset freeing when unloading the module.
If u->connections isn't empty when module-dbus-protocol is
unloaded, then connection_free() is called for the
remaining connections when the idxset is freed.
connection_free() tries to remove the connection from the
idxset, but that fails, because the item has already been
removed from the idxset in this scenario.
The problem is solved by not trying to remove the connection
from the idxset in connection_free(). Instead, whoever wants
to delete connections, has to remove the connection from the
idxset in addition to calling connection_free().
Tanu Kaskinen [Fri, 29 Apr 2011 10:45:29 +0000 (13:45 +0300)]
match: Support for both merging and replacing proplist updates.
This patch adds a new update mode specifier that can be optionally
given in match rules after the regexp. Property list updates triggered
by the rule will honour the given mode. The two allowed modes are 'merge'
and 'replace', corresponding to PA_UPDATE_MERGE and PA_UPDATE_REPLACE
respectively. If omitted, the mode defaults to PA_UPDATE_MERGE, ie. to
the original behavior.
For example, to force 'media.role' to be overwritten with 'bar' for
streams matching foo you can use an entry like this:
foo replace "bar"
This will really overwrite media.role to bar even if it has already been
set to something else by the application.
Thanks to Krisztian Litkey for the original patch and the description
above. In addition to implementing the new feature, this patch fixes
a number of bugs in the parsing code.
Antti-Ville Jansson [Wed, 20 Apr 2011 12:56:29 +0000 (15:56 +0300)]
core: Drop empty gaps in the memblockq when playing data from it.
It's possible that the memblockq of a sink input is rewound to a negative read
index if the sink input is moved between sinks shortly after its creation. When
this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is
NULL and whose 'length' field indicates the length of the gap caused by the
negative read index. This will trigger an assert in play-memblockq.c.
If the memblockq had a silence memchunk, pa_memblockq_peek() would return
silence for the duration of the gap and the assert would be avoided. However,
this approach would prevent the sink input from being drained and is thus not
possible. Instead, we handle the aforementioned situation by dropping the gap
indicated by the 'length' field of the memchunk and by peeking the actual data
that comes after the gap.
This scenario seems to be quite rare in everyday use, but it causes a severe
bug in the handheld world. The assert can be triggered e.g. by loading two null
sinks, playing a sample from the cache to one of them and then moving the
created sink input between the two sinks. The rewinds done by the null sinks
seem to be quite long (I don't know if this is normal behaviour or something
fishy in module-null-sink).
See also:
6bd34156b130c07b130de10111a12ef6dab18b52
virtual-sink: Fix a crash when moving the sink to a new master right after setup.
https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-February/009105.html
Reproduce:
This problem can be reproduced with the following script:
SAMPLE_PATH="/usr/share/sounds/alsa/"
SAMPLE="Front_Left"
pactl remove-sample $SAMPLE 2> /dev/null
pactl upload-sample $SAMPLE_PATH$SAMPLE.wav
mod1=`pactl load-module module-null-sink sink_name=null1`
mod2=`pactl load-module module-null-sink sink_name=null2`
pactl play-sample $SAMPLE null1
input=`pactl list | grep "Sink Input #" | tail -n 1 | cut -d# -f2`
echo "Sample $SAMPLE playing as Sink Input #$input"
pactl move-sink-input $input null2
pactl move-sink-input $input null1
pactl unload-module $mod1
pactl unload-module $mod2
Tanu Kaskinen [Wed, 27 Apr 2011 10:08:38 +0000 (13:08 +0300)]
stream-restore: Enable database dumping if DEBUG_VOLUME is defined.
Marc-André Lureau [Wed, 27 Apr 2011 11:50:00 +0000 (14:50 +0300)]
module-null-source: New null-source module
Maciej Grela [Tue, 29 Mar 2011 20:57:28 +0000 (22:56 +0159)]
x11: Fix build errors with newest xcb-util.
The xcb_atom_get functions were removed from xcb-util. Changed these to
xcb_intern_atom/xcb_intern_atom_reply. Also, STRING is now
XCB_ATOM_STRING.
Arun Raghavan [Fri, 22 Apr 2011 14:27:29 +0000 (19:57 +0530)]
filter-heuristics: Match roles correctly
Arun Raghavan [Fri, 22 Apr 2011 12:14:50 +0000 (17:44 +0530)]
echo-cancel: Play nice with module-filter-*
With automaticl filter loading by module-filter-apply, setting the
virtual sink/source to have the "phone" intended role will break routing
when you first connect a phone stream to an ALSA device and then turn on
your Bluetooth headset. This happens because module-intended-roles
doesn't move a stream if it is already on a device that provides the
required role.
This patch introduces a "manual_load" parameter that is meant to be used
when not using module-filter-apply for loading the AEC module. If this
parameter is set, the virtual devices are given the "phone" role, else
we count on module-filter-heuristics to do the right thing.
Arun Raghavan [Fri, 22 Apr 2011 12:03:03 +0000 (17:33 +0530)]
filters: Handle filters on sources as well
This makes the core code in the filter-* modules generic enough to be
used on sources or sinks. We need special handling for modules that
introduce more than one sink (for now echo-cancel only).
Arun Raghavan [Thu, 21 Apr 2011 07:22:27 +0000 (12:52 +0530)]
filters: Handle stream moves properly
This makes sure that we handle streams moving between sinks properly. To
do this, we change the way the filter.* properties are handled a little
bit.
Firstly, this splits up the "filter.apply" property into two properties
- "filter.want" and "filter.apply". "filter.apply" acts as before - it
bypasses module-filter-heuristics and directly tells module-filter-apply
what filters are to be applied.
"filter.want" is used to tell module-filter-heuristics what filters the
client wants. The module then decides whether to actually apply the
filter or not (for now, this makes sure we don't apply echo-cancellation
even if requested on phone sinks (where it is assumed AEC is taken care
of or is not required).
Next, we also make sure that we track whether the client set
"filter.apply" or module-filter-heuristics did - and in the latter case,
we recalculate "filter.apply" and then have module-filter-apply apply
the filter if required. This introduces some evil in the form of causing
the move_finish callback to possibly trigger another move, but we
protect for this case (with a property) to be doubly sure of not causing
an infinite loop.
Arun Raghavan [Wed, 20 Apr 2011 12:15:26 +0000 (17:45 +0530)]
filter-heuristics: Only apply AEC if we're not already on a phone sink
This makes sure that we don't apply AEC on sinks that are already
connected to a "phone" device, the assumptiong being that anything
marked as such either doesn't have need it, or handles it itself.
Colin Guthrie [Fri, 22 Apr 2011 09:25:42 +0000 (10:25 +0100)]
test: Make the connect-stress less likely to bail out due to >32 streams.
When running two connect-stress tests at the same time the liklihood of >32 streams
per sink increases. All it takes is for an event sound to fire to trigger an abort of
the test.
This leaves just a little bit of wriggle room for a couple external streams.
Of course the overall problem is still there but this just makes it
slightly less likely without really affecting the test itself.
Daniel Mack [Fri, 22 Apr 2011 00:41:24 +0000 (02:41 +0200)]
build-sys: Make -isysroot and -mmacosx-version-min configurable
Tanu Kaskinen [Thu, 21 Apr 2011 05:06:53 +0000 (08:06 +0300)]
protocol-dbus: Fix some memory management bugs.
There were several memory leaks. In addition to those,
pa_dbus_protocol_add_interface() used a string from the
caller as a key to a hashmap, instead of a copy of the
string. This caused trouble when the caller freed the
string while the key was still in use in the hashmap.
Marc-André Lureau [Wed, 20 Apr 2011 12:22:46 +0000 (15:22 +0300)]
match: Match rule earlier, in SINK_INPUT_NEW
Marc-André Lureau [Wed, 20 Apr 2011 11:49:18 +0000 (14:49 +0300)]
match: Don't double free in case of missing table file
Daniel Mack [Fri, 22 Apr 2011 02:12:36 +0000 (04:12 +0200)]
module-coreaudio-device: Fix two build warnings
Daniel Mack [Fri, 22 Apr 2011 02:10:46 +0000 (04:10 +0200)]
module-coreaudio-device: Set the thread name to device name
This makes gdb's "info threads" better understandable
Daniel Mack [Fri, 22 Apr 2011 02:08:45 +0000 (04:08 +0200)]
module-coreaudio-device: Dispatch sink/source state messages from main loop
This fixes a long standing race condition when tearing down streams on
Mac OS X.
Daniel Mack [Fri, 22 Apr 2011 02:28:11 +0000 (04:28 +0200)]
thread-posix: Use pthread_(get|set)name_np() if available
Newer generations of libpthread have functions to set and get the thread
names. If available, use them.
Daniel Mack [Fri, 22 Apr 2011 00:27:35 +0000 (02:27 +0200)]
pulsecore:: Define _POSIX_C_SOURCE locally for rtclock on OSX
Defining this macro on a global level is disadvantageous for other APIs,
and as we need it for clock_gettime() only on Mac OS X, define it
locally in pulsecore/core-rtclock.c only.
Daniel Mack [Fri, 15 Apr 2011 17:35:25 +0000 (19:35 +0200)]
util: Implement pa_get_binary_name() for Mac OS X
Daniel Mack [Thu, 7 Apr 2011 10:59:52 +0000 (12:59 +0200)]
module-coreaudio-detect: Add 'ioproc_frames' parameter
This value is passed on to the instances of module-coreaudio-device that
are loaded upon device detection. The value is purely optional, as the
device module will fall back to to its default if it's not given.
Lennart Poettering [Thu, 21 Apr 2011 19:05:51 +0000 (21:05 +0200)]
memblockq: decode unset chunks as NULL chunks again
This fixes asserts beeing hit when see requests are posted via the
native protocol.
Arun Raghavan [Wed, 20 Apr 2011 08:15:48 +0000 (13:45 +0530)]
filter-apply: Make housekeeping optional
Adds an autoclean option (defaults to TRUE) that controls whether
module-filter-apply cleans up unused modules or not. This is useful in
cases where you know that a filter will be used often and thus can avoid
overhead from repeated module load/unload.
Colin Guthrie [Wed, 20 Apr 2011 08:25:31 +0000 (09:25 +0100)]
filter: Move the proplist defines into the central place and document them.
Marc-André Lureau [Tue, 19 Apr 2011 10:29:19 +0000 (13:29 +0300)]
tests: improve resampler test
Marc-André Lureau [Tue, 19 Apr 2011 06:46:45 +0000 (09:46 +0300)]
interpol-test: remove unused include getopt.h
Alexander Kurtz [Mon, 18 Apr 2011 08:28:05 +0000 (10:28 +0200)]
vala: More vala fixes
1. Remove the "has_destroy_function=false" attribute. It was only
necessary because of a bug in vala which is fixed in 0.12. [1]
2. Add sizes to all fixed-size arrays to make vala recognize them as
such. Using symbolic constants for this is not yet supported. [2]
3. CardInfo struct: Move the brackets in the list of available profiles
to the type to make it clear that this is a dynamically-sized array. [3]
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622773
[2] https://bugzilla.gnome.org/show_bug.cgi?id=647788
[3] http://0pointer.de/lennart/projects/pulseaudio/doxygen/structpa__card__info.html
Arun Raghavan [Sun, 17 Apr 2011 09:58:15 +0000 (15:28 +0530)]
volume: Get more data from volume tests
This makes the volume tests run in two loops and print the minimum,
maximum and standard deviation of readings from the inner loop. This
makes it easier to reason out performance drops (i.e. algorithmic
problems vs. other system issues such as processor contention).
Arun Raghavan [Tue, 12 Apr 2011 07:41:40 +0000 (13:11 +0530)]
stream-restore: Check for readability before reading volume
This avoids an assert in pa_sink_input_get_volume() when connecting a
passthrough stream.
Daniel Mack [Wed, 13 Apr 2011 17:51:49 +0000 (19:51 +0200)]
pa_poll(): Simplify detection of invalid fds in select() emulation mode
For systems which have a fcntl() implementation, we can simplify the
code which determines whether a file selector is valid in pa_poll().
The old code, which is harder to read and more expensive, stays around
for all platforms we need to emulate poll() for using select(), and
which don't provide fcntl(). IOW, for Windows.
On Mac OS X, however, the detection for bad fds via more select() calls
doesn't work, resulting in hung main loops, so the patch fixes a real
bug there.
Tanu Kaskinen [Fri, 15 Apr 2011 15:36:38 +0000 (18:36 +0300)]
sink-input: Check flat volume with pa_sink_flat_volume_enabled().
Checking just the flag doesn't work if the sink uses volume sharing, because
such sinks never have PA_SINK_FLAT_VOLUME set.
Colin Guthrie [Thu, 14 Apr 2011 11:05:45 +0000 (13:05 +0200)]
filter-heuristics: New module that applies some basic heuristics regarding filters.
At present the only heuristic is one to apply the echo-cancel filter
when dealing with phone streams.
Colin Guthrie [Thu, 14 Apr 2011 11:04:03 +0000 (13:04 +0200)]
filter-apply: New module to automatically load filter sinks (and move streams) based on sink-input property hints.
This module does not yet deal with modules that need matched inputs/outputs
(i.e. echo-cancel) but this will be added in due course.
Colin Guthrie [Thu, 14 Apr 2011 11:00:58 +0000 (13:00 +0200)]
equalizer: Use sink_master as the module argument rather than just
This brings more uniformity to arguments to match module-echo-cancel
(which needs both sink and source masters, hence the disambiguation).
This will allow other modules to load filters in a more uniform way
in the future without kludges to deal with variation in arguments.
Juho Hämäläinen [Mon, 4 Apr 2011 12:24:17 +0000 (15:24 +0300)]
bluetooth-device: fix rounding errors caused by few bt volume steps
When volume changes in bluetooth device PulseAudio volume is rounded
one too low, so if bluetooth headset changes volume and that volume
is immediately set again for bluetooth device, bluetooth step drifts
lower all the time. Volume is incremented by one in the conversion so
that we get right bluetooth step when re-applying volume.
Signed-off-by: Juho Hämäläinen <ext-juho.hamalainen@nokia.com>
Harri Mähönen [Tue, 5 Apr 2011 08:58:01 +0000 (11:58 +0300)]
stream-restore: add version to new entry.
Colin Guthrie [Tue, 5 Apr 2011 08:53:16 +0000 (09:53 +0100)]
doc: Fix typo
Tanu Kaskinen [Mon, 4 Apr 2011 11:51:16 +0000 (14:51 +0300)]
alsa: Fix log output to inform about positive base volumes correctly.
This fix was done for _set_port_cb() already, but the first fix didn't fix
setup_mixer(). Now that's done too.
Marc-André Lureau [Mon, 4 Apr 2011 11:33:35 +0000 (14:33 +0300)]
bluetooth: drop data every 500ms on oor condition
Michael Terry [Sun, 3 Apr 2011 12:42:44 +0000 (13:42 +0100)]
switch-on-connect: Add a new module to allow for hotplugged devices to be used by default.
This module implements a simply policy decision that any newly plugged
in devices should be used.
This is a reasonable approach and paprefs will be updated to allow for
this option to be turned on or off.
This is more or less a stop-gap solution. When priority lists are
implemented in the core, then policy modules may ultimately be
re-engineered to adjust the priority lists rather than doing any of
their own routing per-se.
Daniel Mack [Thu, 31 Mar 2011 12:37:40 +0000 (14:37 +0200)]
tests: add a connection stress test
This test is based on a threaded main loop and was written to hunt an
evil race condition.
Tanu Kaskinen [Thu, 31 Mar 2011 12:00:52 +0000 (15:00 +0300)]
bluetooth: Fix HSP volume handling.
Previously the userdata for the volume callbacks was saved to
pa_core.shared only once when loading module-bluetooth-device, and only when
the SCO over PCM feature was used. That breaks volume handling in cases where
the HSP profile is used without the SCO over PCM setup. Now the userdata is
set always when a sink or source is created, and removed when a sink or source
is removed.
Marc-André Lureau [Mon, 28 Mar 2011 12:35:17 +0000 (15:35 +0300)]
bluetooth: restore original sco_{sink, src}->set_volume when unloading
Marc-André Lureau [Mon, 28 Mar 2011 12:35:16 +0000 (15:35 +0300)]
bluetooth: fix set_volume_cb on sco over pcm
The current implementation is totally bogus, it cast the over_sink
userdata to the bluetooth-device userdata... It was failing nicely
because the previous code had a gentle safe-guard in u->profile ==
PROFILE_HSP, and u->profile was just random.
There is no easy way to associate additional data to a sink or
source. Two solutions seems possible: looking up loaded modules and
check which one was handling the sink/source, or using pa_shared. I
went for the second solution.
Marc-André Lureau [Mon, 28 Mar 2011 12:35:15 +0000 (15:35 +0300)]
bluetooth: use sco_sink/source to start with right state
Note from Tanu Kaskinen: I resolved some conflicts with newer upstream code, so
if this patch is broken, blame me..
Tanu Kaskinen [Mon, 28 Mar 2011 12:35:14 +0000 (15:35 +0300)]
bluetooth: Drop all "#ifdef NOKIA" directives.
The #ifdefs only added clutter. I don't see any reason to not compile the
SCO over PCM support in all the time.
Sean McNamara [Wed, 30 Mar 2011 17:41:02 +0000 (13:41 -0400)]
vala: ChannelMap has no destroy function.
Arun Raghavan [Wed, 30 Mar 2011 19:26:20 +0000 (00:56 +0530)]
bluetooth: Pull a2dp-codecs.h from BlueZ
This pulls a2dp-codecs.h from BlueZ which contains the capabilities
structures for SBC and MPEG. We currently have these manually added to
ipc.h, so pulling this header makes our files identical to upstream.
Tanu Kaskinen [Tue, 22 Mar 2011 10:23:19 +0000 (12:23 +0200)]
alsa-mixer: Check that the kernel driver returns consistent limits with both snd_mixer_selem_get_*_dB_range() and _ask_*_vol_dB().
The check is inspired by a driver that returned higher dB limit from
snd_mixer_selem_get_playback_dB_range() than what _ask_playback_vol_dB()
returned at maximum integer volume.