Russ Keldorph [Fri, 12 Feb 2016 13:35:22 +0000 (05:35 -0800)]
Merge pull request dotnet/coreclr#3088 from RussKeldorph/testwarn
Fix warnings in JIT test build
Commit migrated from https://github.com/dotnet/coreclr/commit/
1115b6f4999d88a48cffd73dbe92cd4252427268
Jan Kotas [Fri, 12 Feb 2016 06:08:41 +0000 (22:08 -0800)]
Merge pull request dotnet/coreclr#3150 from krytarowski/netbsd-support-42
Fix build issue on NetBSD: Include <stdlib.h> for alloca(3)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ff1fc83dab3cd3f7d5c448eea41e863c59ca4f6
Mike McLaughlin [Fri, 12 Feb 2016 03:44:31 +0000 (19:44 -0800)]
Merge pull request dotnet/coreclr#3146 from mikem8361/vso190301
Fix VSO bug dotnet/coreclr#190301 contract problems in DACRaiseException.
Commit migrated from https://github.com/dotnet/coreclr/commit/
58a96714860f3acab33ddbb22f572bff0ea6ad4b
Kamil Rytarowski [Fri, 12 Feb 2016 02:46:46 +0000 (03:46 +0100)]
Fix build issue on NetBSD: Include <stdlib.h> for alloca(3)
Header <alloca.h> isn't needed on other supported systems either.
/tmp/pkgsrc-tmp/wip/coreclr-git/work/coreclr/src/pal/src/file/directory.cpp:605:
warning: Warning: reference to the libc supplied alloca(3); this most likely will
not work. Please use the compiler provided version of alloca(3), by supplying the
appropriate compiler flags (e.g. not -std=c89).
$ uname -a
NetBSD chieftec 7.99.25 NetBSD 7.99.25 (GENERIC) dotnet/coreclr#0: Fri Dec 25 20:51:06 UTC 2015 root@chieftec:/tmp/netbsd-tmp/sys/arch/amd64/compile/GENERIC amd64
Commit migrated from https://github.com/dotnet/coreclr/commit/
3639bd23882a45f2248bc6296340dc76a0e21f33
Jan Vorlicek [Fri, 12 Feb 2016 01:31:15 +0000 (02:31 +0100)]
Merge pull request dotnet/coreclr#3076 from krytarowski/netbsd-support-37
Permit to inject additional CMake arguments via environment variables
Commit migrated from https://github.com/dotnet/coreclr/commit/
cb1effac01239c3af46a1d3917fb60f70b18b757
Mike McLaughlin [Thu, 11 Feb 2016 22:25:21 +0000 (14:25 -0800)]
Fix VSO bug dotnet/coreclr#190301 contract problems in DACRaiseException.
Added the proper contracts to the DAC notification functions.
Commit migrated from https://github.com/dotnet/coreclr/commit/
923c266972b80e563c54da6e0a8604edda6a0064
Jan Vorlicek [Fri, 12 Feb 2016 00:49:35 +0000 (01:49 +0100)]
Merge pull request dotnet/coreclr#3122 from krytarowski/netbsd-support-40
Fix build on NetBSD: Include <cstdarg> for va_list
Commit migrated from https://github.com/dotnet/coreclr/commit/
c39ac0e98bc69889192f1614203d6858de502472
Sivarv [Fri, 12 Feb 2016 00:22:45 +0000 (16:22 -0800)]
Merge pull request dotnet/coreclr#3136 from sivarv/simdfix2
Fix to issue dotnet/coreclr#2970
Commit migrated from https://github.com/dotnet/coreclr/commit/
7010341ff0fdf1e4ea65ede688f0ce92cc266cd8
Sejong Oh [Thu, 11 Feb 2016 23:32:03 +0000 (15:32 -0800)]
Merge pull request dotnet/coreclr#3082 from sejongoh/update_corefx_build_steps
Fixed corefx build failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
616b364172464ad443607c164b8cab4dfa9840ed
Stephen Toub [Thu, 11 Feb 2016 23:15:17 +0000 (18:15 -0500)]
Merge pull request dotnet/coreclr#3132 from stephentoub/taskscheduler_tracking
Track TaskSchedulers only when debugger attached
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffa6fdff2d5acc7cd385a55f185a25c5e8fa8ad7
Stephen Toub [Thu, 11 Feb 2016 23:15:06 +0000 (18:15 -0500)]
Merge pull request dotnet/coreclr#3139 from stephentoub/task_id_perf
Fix access to Task.Id while finishing continuations
Commit migrated from https://github.com/dotnet/coreclr/commit/
6ac7e9639630c60a7e102b0f8465179262e26550
Sejong Oh [Wed, 10 Feb 2016 01:20:06 +0000 (17:20 -0800)]
Updated build steps to fix corefx build issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
8a824f03eed59aba13884a32443bbac4a1715e4a
stephentoub [Thu, 11 Feb 2016 21:41:43 +0000 (16:41 -0500)]
Fix access to Task.Id while finishing continuations
Task.Id is lazily-initialized with an interlocked operation and we strive to avoid accessing it anywhere in Task's internals on hot paths, but apparently when some ETW logging was added around continuations, calls were added that access Task.Id even if logging is disabled. This is accounting for ~30% of the cycles consumed in a TCS Task's lifecycle! This commit fixes it by making sure these accesses to Id are guarded.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f92dc182d75c60abbfd5a20020462b11ae26e529
sivarv [Thu, 11 Feb 2016 19:39:05 +0000 (11:39 -0800)]
Fix to issue dotnet/coreclr#2970
The repro is a case of one of the method called is returning Vector3/4 type value.
On unix such a struct will gets returned in two registers and hence will
be assigned to a local by importer and marked as multiRegArgOrRet=1.
But it doesn't ensure that the local will not be register allocated.
For the repro case it gets register allocated.
IR: GT_LCL_FLD(tmp1) = GT_CALL returning SIMD12
Codgen routine genStoreRegisterReturnInLclVar() for stroing a struct returned in two registers to a lcl var or lcl_fld
is making the assumption that lcl var will be on stack not in a register.
This may not be true for SIMD structs returned in two registers.
For now to workaround Codegen limitation marking tmp1 as DoNoEnregister.
Fixes dotnet/coreclr#2970
Commit migrated from https://github.com/dotnet/coreclr/commit/
e977984e2bedd7fa35875a879baa0f4014639ff4
William Godbe [Thu, 11 Feb 2016 21:05:13 +0000 (13:05 -0800)]
Merge pull request dotnet/coreclr#3137 from wtgodbe/disable
Disable pri 1 tests failing in the CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
8a0dfa1ca160a43f22491ae635b21e77c0d61094
William Godbe [Thu, 11 Feb 2016 20:33:44 +0000 (12:33 -0800)]
Disable pri 1 tests failing in the CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
ac8e57afd3f7d605b30d9d13271e356bcfc36e98
stephentoub [Thu, 11 Feb 2016 18:06:41 +0000 (13:06 -0500)]
Track TaskSchedulers only when debugger attached
Today the base TaskScheduler ctor registers every created scheduler in a ConditionalWeakTable. This is then used in the internal TaskScheduler.GetTaskSchedulersForDebugger() to enable a debugger to find all of the schedulers that are active and then in turn find all tasks scheduled to them. However, for scenarios that involve creating many, many schedulers, this registration adds up to a non-trivial cost, both in time and space, and is only relevant for debugging. Plus, since this mechanism was introduced, Visual Studio has additional ways of tracking tasks for display in the Tasks window, e.g. ETW events.
This commit simply makes that registration more pay-for-play, only doing it if the debugger is attached at the time of the scheduler's creation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae413bc05a6021c5164cc34d899084bc2a2a0579
Matt Mitchell [Thu, 11 Feb 2016 16:27:48 +0000 (08:27 -0800)]
Merge pull request dotnet/coreclr#3119 from ellismg/add-rhel72
Add Red Hat Enterprise Linux 7.2 Runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
4181cfa65a889e98878bf879bd50e6ebcc0118c3
Jan Kotas [Thu, 11 Feb 2016 10:48:05 +0000 (02:48 -0800)]
Merge pull request dotnet/coreclr#3126 from jkotas/crossgen
Change crossgen defaults
Commit migrated from https://github.com/dotnet/coreclr/commit/
28e9c4c6b9fef89c7915f26d340618acfee6fe3b
Eugene Rozenfeld [Thu, 11 Feb 2016 08:00:26 +0000 (00:00 -0800)]
Merge pull request dotnet/coreclr#3120 from erozenfeld/MultToShiftVN1
Small correction for dotnet/coreclr#3067.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7055a710612cf5b96961608504db4e51daa38b7
Andy Ayers [Thu, 11 Feb 2016 07:29:34 +0000 (23:29 -0800)]
Merge pull request dotnet/coreclr#3127 from AndyAyersMS/FlakyTestDisable
Disable test causing Ubuntu failures
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e65b423aac5c05fdd89938d389c5ad654ef8db7
Andy Ayers [Thu, 11 Feb 2016 03:53:53 +0000 (19:53 -0800)]
Disable test causing Ubuntu failures
Fails because of mismatched System.IO versions. See dotnet/coreclr#3117 for some
discussion.
Commit migrated from https://github.com/dotnet/coreclr/commit/
dff431d1b8e3c6eb1fa53371d499a281ed7d7297
Jan Kotas [Thu, 11 Feb 2016 03:35:01 +0000 (19:35 -0800)]
Change crossgen defaults
Change crossgen to generate R2R images by default
Commit migrated from https://github.com/dotnet/coreclr/commit/
fcf9b1d7d7a0b16ae2e190e799d16794bc7d1f8a
Jan Kotas [Thu, 11 Feb 2016 02:47:45 +0000 (18:47 -0800)]
Merge pull request dotnet/coreclr#3118 from jkotas/buffercopy
Add a fast path for byte[] to Buffer.BlockCopy
Commit migrated from https://github.com/dotnet/coreclr/commit/
85c57caa006ac67bf29009b321e71047a7ab3646
Jan Kotas [Wed, 10 Feb 2016 17:18:13 +0000 (09:18 -0800)]
Add a fast path for byte[] to Buffer.BlockCopy
Commit migrated from https://github.com/dotnet/coreclr/commit/
9583ed789e1bb975766de4650093a8806d5537f3
Kamil Rytarowski [Thu, 11 Feb 2016 00:02:51 +0000 (01:02 +0100)]
Fix build on NetBSD: Include <cstdarg> for va_list
Commit migrated from https://github.com/dotnet/coreclr/commit/
528ff04a26894a3a106b39b424df512ecb3d8e18
Eugene Rozenfeld [Wed, 10 Feb 2016 23:50:41 +0000 (15:50 -0800)]
Small correction for dotnet/coreclr#3067.
The code to change multiplication to shift shouldn't be
under LEA_AVAILABLE since the code to process multiplication
by power of 2 isn't.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d8683b4411b007eb2614b7e4cb7147b5bfce6e15
Matt Ellis [Wed, 10 Feb 2016 22:55:34 +0000 (14:55 -0800)]
Add Red Had Enterprise Linux 7.2 Runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd1fc180e02b5edabbfe8b6d335be8a2e8224b73
Kamil Rytarowski [Mon, 8 Feb 2016 11:02:20 +0000 (12:02 +0100)]
Add new parameter with settable option: cmakeargs
This will allow to pass user-defined CMake arguments.
One of the users is pkgsrc, which defines it to following example string:
-DPYVERSSUFFIX:STRING=2.7 -DCMAKE_INSTALL_PREFIX:PATH=/usr/pkg \
-DCMAKE_MODULE_PATH:PATH=/tmp/pkgsrc-tmp/wip/coreclr-git/work/.buildlink/cmake-Modules \
-DCMAKE_SKIP_RPATH:BOOL=TRUE -DCMAKE_INSTALL_LIBDIR:PATH=lib \
-DCMAKE_INSTALL_MANDIR:PATH=man
Without these values unmodified build.sh won't integrate with pkgsrc as
expected.
Solution suggested by Jan Vorli (Microsoft)
While there, there was need to alter loop type to handle options passed to
arguments. As a bonus, new loop should be POSIX confirming.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fa6a2ab7f529a7f248a3ed8795ccfe0d6dcd373a
Mike McLaughlin [Wed, 10 Feb 2016 22:37:25 +0000 (14:37 -0800)]
Merge pull request dotnet/coreclr#3112 from mikem8361/sosfix
Fix SOS managed breakpoints when coreclr symbols are stripped.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e683c0b63dcfa2352679661db75a12d1837ba2da
Mike McLaughlin [Tue, 9 Feb 2016 01:47:31 +0000 (17:47 -0800)]
Fix SOS managed breakpoints when coreclr symbols are stripped.
Added a SOS DAC interface (ISOSDacInterface4::GetClrNotification) to get the exception
notification arguments instead of using the GetLastExceptionInformation function from the lldb
sosplugin that depends on coreclr symbols being present.
On the coreclr side, the clr notification arguments are saved in a global variable that is DAC
accessible. A critical section was added to protect this global variable while the special
exception is raised.
Setting the internal COMPlus_DebugBreakOnAssert environment variable causes 3 or 4 breaks in
the debugger with no reason. It was breaking in the function that was determining whether it
should break. I was using COMPlus_BreakOnEELoad=2 to break after coreclr was loaded and initialized
to set managed breakpoints and on a debug build it generates an assert (on release just a DebugBreak).
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d74570d33823d4734fa287bc21a81ff12f7b40a
Russ Keldorph [Sun, 7 Feb 2016 02:44:28 +0000 (18:44 -0800)]
Fix warnings in test build
```
warning : Layout specified for auto-layout class
C:\git\coreclr\tests\src\JIT\Directed\PREFIX\unaligned\1\add.ilproj
C:\git\coreclr\tests\src\JIT\Directed\PREFIX\volatile\1\add.ilproj
warning : Non-nested class has nested visibility (0x00000102), changed to non-nested (0x00000101)
C:\git\coreclr\tests\src\JIT\jit64\regress\vsw\153682\test.ilproj
warning : Reference to undeclared extern assembly '<assembly>'. Attempting autodetect
C:\git\coreclr\tests\src\JIT\Methodical\explicit\misc\_il_dbgrefarg_box_f8.ilproj (System.Console)
C:\git\coreclr\tests\src\JIT\Methodical\explicit\misc\_il_relrefarg_box_f8.ilproj (System.Console)
C:\git\coreclr\tests\src\JIT\Methodical\tailcall_v4\hijacking.ilproj (mscorlib, System.Threading, System.Threading.Thread)
warning : Undefined implementation in ExportedType '<type>' -- ExportType not emitted
C:\git\coreclr\tests\src\JIT\Regression\CLR-x86-JIT\V1-M09.5-PDC\b32879\b32879.ilproj (HiDad, _vbProject)
C:\git\coreclr\tests\src\JIT\Regression\CLR-x86-JIT\V1-M12-Beta2\b65423\b65423.ilproj (b1904)
warning C4311: 'type cast': pointer truncation from 'void *' to 'unsigned int' (+redundant C4302)
C:\git\coreclr\bin\Native\src\JIT\Directed\pinning\object-pin\mirror.vcxproj
```
Commit migrated from https://github.com/dotnet/coreclr/commit/
32f03c84a8f6cf8dfef2df5b2c725b7ab45c6077
William Godbe [Wed, 10 Feb 2016 18:10:15 +0000 (10:10 -0800)]
Merge pull request dotnet/coreclr#3107 from wtgodbe/reenable
Re-enable previously disabled tests that are now passing on non-Windows platforms
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3a008bf45b6cc8c150afd0416da59a5f23573f8
Jan Kotas [Wed, 10 Feb 2016 16:43:19 +0000 (08:43 -0800)]
Merge pull request dotnet/coreclr#3095 from krytarowski/netbsd-support-38
Add support for Floating Point registers in ucontext_t on NetBSD
Commit migrated from https://github.com/dotnet/coreclr/commit/
bf15d88c416ac70411d33574e0363a4c0f07c24f
Matt Mitchell [Wed, 10 Feb 2016 16:22:10 +0000 (08:22 -0800)]
Merge pull request dotnet/coreclr#3114 from mmitche/switch-to-auto
Switch to auto images
Commit migrated from https://github.com/dotnet/coreclr/commit/
57793e333933e1e00ce9ec00e5c3a9e3cec94410
Matt Mitchell [Wed, 10 Feb 2016 16:21:19 +0000 (08:21 -0800)]
Switch to auto images
Commit migrated from https://github.com/dotnet/coreclr/commit/
017985b332efed6a7f9f46b98c20f754e9b36e8f
Jan Kotas [Wed, 10 Feb 2016 03:06:50 +0000 (19:06 -0800)]
Merge pull request dotnet/coreclr#3110 from jkotas/event-tracing
Make Unix event tracing conditionally enabled
Commit migrated from https://github.com/dotnet/coreclr/commit/
149bc3f66f706ca8df5948a5786689c7b9ce1362
Sivarv [Wed, 10 Feb 2016 01:18:21 +0000 (17:18 -0800)]
Merge pull request dotnet/coreclr#3108 from sivarv/gcstressfix
Fix to gc-stress issue dotnet/coreclr#2921.
Commit migrated from https://github.com/dotnet/coreclr/commit/
26dfefb4e20bdd8050859eb7ffdbc5519757644d
Jan Kotas [Wed, 10 Feb 2016 01:15:06 +0000 (17:15 -0800)]
Make Unix event tracing conditionally enabled
Add condition around the expensive event tracing code to enable it conditionally only if the event tracing is enabled
Commit migrated from https://github.com/dotnet/coreclr/commit/
2cc21909465eeb065aa76deaee4bc83e9d59afcf
Brian Sullivan [Wed, 10 Feb 2016 00:53:57 +0000 (16:53 -0800)]
Merge pull request dotnet/coreclr#3106 from briansull/issue_3032
ARM64: For methods that have very large stack frames we need extra instructions
Commit migrated from https://github.com/dotnet/coreclr/commit/
a13e2ff442bbeebda5cea971f25a1e2b25a9db2e
Brian Sullivan [Tue, 9 Feb 2016 22:07:39 +0000 (14:07 -0800)]
For methods that have very large stack frames we need an extra instruction
to load the offset when encoding the prolog/epilog instructions for funclets
Fixes Issue dotnet/coreclr#3032
Incorporates code review feedback and provides a method called
genInstrWithConstant to handle the cases where we need extra instructions
Updated arm64\Tests.lst with additional tags:
MISSING_EXE, ISSUE_3104, ISSUE_3105 and NEED_TRIAGE
Commit migrated from https://github.com/dotnet/coreclr/commit/
787371b5fe156c6bba444f70e0557cabd846e781
sivarv [Tue, 9 Feb 2016 22:54:14 +0000 (14:54 -0800)]
Fix to gc-stress issue dotnet/coreclr#2921.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb196db9de2da567abf3b996230991a2042c9f9a
William Godbe [Tue, 9 Feb 2016 22:46:15 +0000 (14:46 -0800)]
Merge pull request dotnet/coreclr#3055 from wtgodbe/serverGC
Re-enable server GC & lengthen timeouts
Commit migrated from https://github.com/dotnet/coreclr/commit/
8d51f9e1fb1006046017c7131d12509a8a1bc00b
William Godbe [Tue, 9 Feb 2016 22:45:47 +0000 (14:45 -0800)]
Re-enable previously disabled tests that are now passing on non-Windows platforms
Commit migrated from https://github.com/dotnet/coreclr/commit/
70be5eb6aed128f755056351de44c2d8b8c81123
William Godbe [Sat, 6 Feb 2016 00:25:51 +0000 (16:25 -0800)]
Re-enable server GC & lengthen timeouts
Commit migrated from https://github.com/dotnet/coreclr/commit/
2bbf9d46f06e80176090df95d9649d107dc2fe1f
Jan Kotas [Tue, 9 Feb 2016 20:24:49 +0000 (12:24 -0800)]
Merge pull request dotnet/coreclr#3100 from AndyAyersMS/FixWarning
Fix const string literal warning
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa5bd5df3eed1e9b29bab847de88e4ec52984d2b
Carol Eidt [Tue, 9 Feb 2016 19:09:52 +0000 (11:09 -0800)]
Merge pull request dotnet/coreclr#3099 from CarolEidt/x86IntArgs
Constant and Popped Args for x86
Commit migrated from https://github.com/dotnet/coreclr/commit/
0cf8cc7b57261eb0908d87ad56207e13320cbd66
Matt Mitchell [Tue, 9 Feb 2016 18:59:11 +0000 (10:59 -0800)]
Merge pull request dotnet/coreclr#3102 from mmitche/add-llitchev-to-allowed
Add llitchev to allowed
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6ccc3a09e0b99e27c4e12ca7cd4ef62adb7ffb1
Matt Mitchell [Tue, 9 Feb 2016 18:27:11 +0000 (10:27 -0800)]
fixup
Commit migrated from https://github.com/dotnet/coreclr/commit/
d8db0bde56b2a4e9f746f1688769467be1bbf18e
Matt Mitchell [Tue, 9 Feb 2016 18:24:13 +0000 (10:24 -0800)]
Update arm triggers to be in line with others
Commit migrated from https://github.com/dotnet/coreclr/commit/
19444cf4dd7dfdb2e1423096239d5a75e0f3ef31
Carol Eidt [Tue, 9 Feb 2016 16:26:08 +0000 (08:26 -0800)]
Constant and Popped Args for x86
Add support for constant arguments,
and handle the case where the callee must pop the stack.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e7fe673b855ed497720fec322cd86b0d8b196e5d
Andy Ayers [Tue, 9 Feb 2016 16:46:16 +0000 (08:46 -0800)]
Fix const string literal warning
This came up during an FI from LLVM, testing LLILC, see microsoft/llvmdotnet/coreclr#140 .
Commit migrated from https://github.com/dotnet/coreclr/commit/
49ee4ba1398aa71ad494e94099d75a7c830b6fe9
Gaurav Khanna [Tue, 9 Feb 2016 06:31:27 +0000 (22:31 -0800)]
Merge pull request dotnet/coreclr#3096 from gkhanna79/MonoCheck
Check for Mono presence until CoreCLR 3090 is fixed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c0e184c8b51f823aa83682fd0f5173d89c8e57f2
Gaurav Khanna [Tue, 9 Feb 2016 04:39:51 +0000 (20:39 -0800)]
Check for Mono presence until CoreCLR 3090 is fixed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
127c86e4b40df00550474a74ef5413b8116c8802
Kamil Rytarowski [Tue, 9 Feb 2016 04:33:02 +0000 (05:33 +0100)]
Add support for Floating Point registers in ucontext_t on NetBSD
This code assumes x86_64 platform and modern fxsave style of FP regs.
i386 Floating Point registers ship with different flavors, what will be
handled once the 64-bit code will be finished.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cb0c4b86b3490a061c8d54e4226cad6caca83c9
Matt Ellis [Tue, 9 Feb 2016 04:23:23 +0000 (20:23 -0800)]
Merge pull request dotnet/coreclr#3086 from gkhanna79/CIMscorlib
Update CI to no longer request mscorlib build for osx/ubuntu on Windows.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ccae5006c489781fe9e34655f0a78c98788cda26
Jan Kotas [Tue, 9 Feb 2016 04:00:54 +0000 (20:00 -0800)]
Merge pull request dotnet/coreclr#3093 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
f494e8f56a05b12ca45f099bcff42aade91001ef
Jan Kotas [Tue, 9 Feb 2016 03:16:50 +0000 (19:16 -0800)]
Merge pull request dotnet/coreclr#3091 from jkotas/revert-workaround
Revert "Add un-prefixed signatures as temporary workaround"
Commit migrated from https://github.com/dotnet/coreclr/commit/
e7ba948b75160651b7a15ae0654813f05a85ee39
Andy Ayers [Tue, 9 Feb 2016 03:07:30 +0000 (19:07 -0800)]
Merge pull request dotnet/coreclr#3084 from AndyAyersMS/InlineRefactor2b
Inline refactor: revise checks in fgFindJumpTargets
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c57efd7362dc93d1e3d11448be280ca5f370140
Andy Ayers [Tue, 9 Feb 2016 03:07:12 +0000 (19:07 -0800)]
Merge pull request dotnet/coreclr#2905 from AndyAyersMS/NewILTests
Some tests for caller/callee type mismatches
Commit migrated from https://github.com/dotnet/coreclr/commit/
e7ca48d51e8265687a9e06188f440b6164c905be
Andy Ayers [Tue, 9 Feb 2016 01:56:43 +0000 (17:56 -0800)]
Merge pull request dotnet/coreclr#3083 from AndyAyersMS/InlineRefactor2a
Inliner refactoring: inline impAbortInline
Commit migrated from https://github.com/dotnet/coreclr/commit/
01cb1ae96011b577713a1b99901ba39988896cf0
Sivarv [Tue, 9 Feb 2016 01:35:59 +0000 (17:35 -0800)]
Merge pull request dotnet/coreclr#3087 from sivarv/master
Fix to SquareRootUInt16 test failure under JitStress=1/2
Commit migrated from https://github.com/dotnet/coreclr/commit/
ceb0a800ad650a36a32e543146669e9f3654e948
Eugene Rozenfeld [Mon, 8 Feb 2016 23:37:52 +0000 (15:37 -0800)]
Merge pull request dotnet/coreclr#3067 from erozenfeld/MultToShiftVN
Preserve value numbers when morphing multiplication into shift.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f087eb3bc9cae37b444d0b4d0b4487ffd11058bf
Gaurav Khanna (CLR) [Mon, 8 Feb 2016 20:16:01 +0000 (12:16 -0800)]
Update CI to no longer request mscorlib build for osx/ubuntu on Windows.
Commit migrated from https://github.com/dotnet/coreclr/commit/
10a478e3a1311993433c480cacead8c3d8e7e814
Jan Kotas [Mon, 8 Feb 2016 22:32:32 +0000 (14:32 -0800)]
Revert "Add un-prefixed signatures as temporary workaround"
This reverts commit dotnet/coreclr@
fb80bad2ed19970472ddefe539520abef42a52d0.
Commit migrated from https://github.com/dotnet/coreclr/commit/
93c5ea9014f1bf260689a19b069275ed7fc782b0
Koundinya Veluri [Mon, 8 Feb 2016 22:13:12 +0000 (14:13 -0800)]
Merge pull request dotnet/coreclr#2981 from kouvel/Fixes
Miscellaneous fixes
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d19b0c10135ffb4c4498a72a9062fa28a7ea013
Eugene Rozenfeld [Sat, 6 Feb 2016 07:09:43 +0000 (23:09 -0800)]
Preserve value numbers when morphing multiplication into shift.
This change fixes a morpher transformation of multiplication to shift
to preserve the value number of the tree since the new shift expression
will compute the same value as the old multiplication expression.
Without that change we were getting asserts in fgMoveOpsLeft,
which expects to see value numbers on trees it transforms.
Closes dotnet/coreclr#2920.
Commit migrated from https://github.com/dotnet/coreclr/commit/
96a998da1a158641a0e8f5a856db4a0ecd82a336
sivarv [Mon, 8 Feb 2016 21:03:11 +0000 (13:03 -0800)]
Fix to SquareRootUInt16 test failure under JitStress=1/2
JitStress=1/2 is inducing GS check as a result of which the Vector argument
gets shadow copied. But on the shadow copy lcl var SIMD specific state
is not set and as a result of which rationalization doesn't happen
properly leading to silent bad codegen.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e9ab14a51f0c4b40775b5f27eb6b13ebffea528c
Andy Ayers [Mon, 8 Feb 2016 20:23:57 +0000 (12:23 -0800)]
Inline refactor: revise checks in fgFindJumpTargets
In this method, the inliner will check for unsupported opcodes and
similar things. Refactor these checks to directly bail out if an
issue is discovered, rather than going to a common handler snippet.
There are two functionality changes:
First, if an unsupported opcode is found (currently: switch, jmp,
calli, localloc, cpblk, mkrefany, rethrow) mark the inlinee as
never inlinable, rather than just failing the current attempt.
This should not change externally visible behavior but will improve
jit TP marginally if such cases are common.
Second, for NETCF quirk handling, make sure to guard some of the
observations with a check that we're reading the IL for inlining.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ebbea0a31a72c0d455dc3124a88e400fb4b2c510
Aditya Mandaleeka [Mon, 8 Feb 2016 19:45:39 +0000 (11:45 -0800)]
Merge pull request dotnet/coreclr#2898 from adityamandaleeka/remove_sigprocmask
Use pthread_sigmask to change the mask of blocked signals.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d7c4ff7acf07d175366649652b512efa05065636
Andy Ayers [Mon, 8 Feb 2016 19:42:42 +0000 (11:42 -0800)]
Inliner refactoring: inline impAbortInline
Inline this helper method at its 3 call sites, and delete it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
433a137ee4f8519b912f2d920c962537ab2006cd
Pat Gavlin [Mon, 8 Feb 2016 18:53:02 +0000 (10:53 -0800)]
Fix build breaks in the CTP JIT.
These breaks were due to unguarded usage of constants that are not present in the CTP JIT/EE interface.
[tfs-changeset: 1573367]
Commit migrated from https://github.com/dotnet/coreclr/commit/
baeeb5704b57cd9828adaa6f435b2dd98d48bb8f
Matt Mitchell [Mon, 8 Feb 2016 18:50:27 +0000 (10:50 -0800)]
Merge pull request dotnet/coreclr#3050 from sejongoh/add_more_stress_modes_to_corefx_windows_testing
Add more JIT stress modes to corefx testing
Commit migrated from https://github.com/dotnet/coreclr/commit/
09bd376860d4d4add1ef55865a7aa78e2f51c52c
Gaurav Khanna [Mon, 8 Feb 2016 07:17:02 +0000 (23:17 -0800)]
Merge pull request dotnet/coreclr#3043 from gkhanna79/FixNugetPkg
Generate Microsoft.NETCore.Runtime.CoreCLR nuget packages
Commit migrated from https://github.com/dotnet/coreclr/commit/
d53cbfb384bfec32cb2b2d6cc7cc0a1f97acb7e3
Gaurav Khanna (CLR) [Fri, 5 Feb 2016 00:22:06 +0000 (16:22 -0800)]
Change to support Microsoft.NetCore.Runtime.CoreCLR nuget package generation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f025f9c678b7194d3b125d0cfa4f8c8e9d27beab
Jan Kotas [Sun, 7 Feb 2016 21:19:14 +0000 (13:19 -0800)]
Merge pull request dotnet/coreclr#3073 from krytarowski/netbsd-support-36
Make missing libunwind fatal on NetBSD
Commit migrated from https://github.com/dotnet/coreclr/commit/
cf663830ffe764fc3520da8ccc09e59329084c61
Kamil Rytarowski [Sun, 7 Feb 2016 17:37:33 +0000 (18:37 +0100)]
Make missing libunwind fatal on NetBSD
Commit migrated from https://github.com/dotnet/coreclr/commit/
3133bb4da1473a15defc1bd0c3cad3cc20e686a7
Jan Kotas [Sun, 7 Feb 2016 15:54:15 +0000 (07:54 -0800)]
Merge pull request dotnet/coreclr#2973 from krytarowski/netbsd-support-25
Disable FEATURE_HIJACK in NetBSD as unimplemented
Commit migrated from https://github.com/dotnet/coreclr/commit/
99e7f7c741a847454ab0ace1febd911378dcb464
Jan Kotas [Sun, 7 Feb 2016 15:40:38 +0000 (07:40 -0800)]
Merge pull request dotnet/coreclr#3072 from krytarowski/netbsd-support-35
Fix build on NetBSD: Support different versions of "struct reg"
Commit migrated from https://github.com/dotnet/coreclr/commit/
eb780edb581bf43baa951184a6b5c88ea0986465
Kamil Rytarowski [Sun, 7 Feb 2016 12:32:18 +0000 (13:32 +0100)]
Fix build on NetBSD: Support different versions of "struct reg"
FreeBSD style: ".r_rax"
NetBSD x86_64 style: ".regs[_R_RAX]"
NetBSD i386 style: "._r_eax" will be defined once the amd64 version will be
finished.
Commit migrated from https://github.com/dotnet/coreclr/commit/
93a5c5590fdba18c570136a68d6f6ecbbaf73374
Kamil Rytarowski [Tue, 2 Feb 2016 01:37:06 +0000 (02:37 +0100)]
Disable FEATURE_HIJACK in NetBSD as unimplemented
Solution suggested by Jan Kotas (Microsoft).
Commit migrated from https://github.com/dotnet/coreclr/commit/
652335e3de29e1c0752282ca9e1a988662af375b
Jan Kotas [Sun, 7 Feb 2016 05:52:43 +0000 (21:52 -0800)]
Merge pull request dotnet/coreclr#3071 from dotnet/revert-3062-instrumentation
Revert "Temporary instrumentation in native image loading"
Commit migrated from https://github.com/dotnet/coreclr/commit/
64744ed7e7581bb42841ce2554da73d736bb7013
Jan Kotas [Sun, 7 Feb 2016 05:52:35 +0000 (21:52 -0800)]
Merge pull request dotnet/coreclr#3070 from jkotas/crossgen-fix
Fix loading of native images on Unix
Commit migrated from https://github.com/dotnet/coreclr/commit/
d65abd8851a78dabd8a3bfee7b7d0c70de8fafc6
Jan Kotas [Sun, 7 Feb 2016 03:48:33 +0000 (19:48 -0800)]
Revert "Temporary instrumentation in native image loading"
Commit migrated from https://github.com/dotnet/coreclr/commit/
564fe6c1ddc0a531a0f751a71708686c3aacc175
Jan Kotas [Sun, 7 Feb 2016 03:40:58 +0000 (19:40 -0800)]
Fix loading of native images on Unix
R2R images that were compiled from architecture-specific IL images failed to load with bad image format exception on Unix. The fix is to take IMAGE_FILE_MACHINE_NATIVE_OS_OVERRIDE into account for the platform check.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbeed7cd9580ed1f8c2a6c04591361c89e36cb27
Jan Kotas [Sun, 7 Feb 2016 00:33:29 +0000 (16:33 -0800)]
Merge pull request dotnet/coreclr#3066 from gkhanna79/Fix3049
Fix for CoreCLR issue 3049
Commit migrated from https://github.com/dotnet/coreclr/commit/
3593fba90b24e871c145dd34c95cbf7c5c3dca57
Gaurav Khanna [Sat, 6 Feb 2016 22:10:46 +0000 (14:10 -0800)]
Fix for CoreCLR issue 3049
Commit migrated from https://github.com/dotnet/coreclr/commit/
10d60acdfa723aaae7710f8c72a9b5f6fda4391f
Jan Kotas [Sat, 6 Feb 2016 21:37:32 +0000 (13:37 -0800)]
Merge pull request dotnet/coreclr#3062 from jkotas/instrumentation
Temporary instrumentation in native image loading
Commit migrated from https://github.com/dotnet/coreclr/commit/
9b0a012c7fa644c253757e0c7e9223b73ed5c1ed
Jan Kotas [Sat, 6 Feb 2016 07:16:30 +0000 (23:16 -0800)]
Temporary instrumentation for PE file loading
Commit migrated from https://github.com/dotnet/coreclr/commit/
6a2d1589e62420904b8d859940ae9f12e4b3e5c7
Jan Kotas [Sat, 6 Feb 2016 18:14:11 +0000 (10:14 -0800)]
Merge pull request dotnet/coreclr#3059 from jkotas/intrinsics
Improve robustness of intrinsic fallback path
Commit migrated from https://github.com/dotnet/coreclr/commit/
405eb72a0f442a96ec814fd2a9995925b3b0b1ee
Stephen Toub [Sat, 6 Feb 2016 18:03:11 +0000 (13:03 -0500)]
Merge pull request dotnet/coreclr#3063 from dotnet/revert-3027-remove_security_checks
Revert "Remove useless security checks"
Commit migrated from https://github.com/dotnet/coreclr/commit/
eb1e835eff0b475af105c40d68eb33d898e495fb
Jan Kotas [Sat, 6 Feb 2016 16:51:57 +0000 (08:51 -0800)]
Merge pull request dotnet/coreclr#3061 from stephentoub/update_index
Tweak Enum.TryParse whitespace skipping slightly
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a07976ace6f380804678cb6a09d4ed40b485b1e
Jan Kotas [Sat, 6 Feb 2016 16:45:25 +0000 (08:45 -0800)]
Revert "Remove useless security checks"
Commit migrated from https://github.com/dotnet/coreclr/commit/
a5e803cf70d861022f3b6cddb9045edb8a222e78
Jan Kotas [Sat, 6 Feb 2016 15:45:09 +0000 (07:45 -0800)]
Merge pull request dotnet/coreclr#3060 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
555f1335c43decc9988b60c39827a1735663572d
stephentoub [Sat, 6 Feb 2016 15:04:43 +0000 (10:04 -0500)]
Tweak Enum.TryParse whitespace skipping slightly
As a simple addendum to my previous Enum.TryParse change, if the string
begins with whitespace, we already know where the whitespace ends, so we
don't need to retraverse it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f99876dd2443ce92ed417ec95e35a1e113f6dbed
Sejong Oh [Sat, 6 Feb 2016 10:59:01 +0000 (02:59 -0800)]
Merge pull request dotnet/coreclr#3048 from sejongoh/add_unit_test_for_issue_2580
Add unit test for issue 2580
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3844de3892fb09c215370aa7e50132f4b23de3b
Sejong Oh [Sat, 6 Feb 2016 10:58:17 +0000 (02:58 -0800)]
Add corefx baseline
Commit migrated from https://github.com/dotnet/coreclr/commit/
718f2790209c8bab0d9994b475b7855811dd322a
Sejong Oh [Fri, 5 Feb 2016 21:07:57 +0000 (13:07 -0800)]
Add unit test for issue 2580
- The test checks if code generation for ushort is correct.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4f4983dad272bc14ed9a1277f05bf22e4103c507
Jan Kotas [Sat, 6 Feb 2016 08:10:40 +0000 (00:10 -0800)]
Delete mdil support from coreclr
[tfs-changeset: 1573006]
Commit migrated from https://github.com/dotnet/coreclr/commit/
15a6b938357115e3b559927b70efe1a20db11234
Jan Kotas [Sat, 6 Feb 2016 07:09:29 +0000 (23:09 -0800)]
Improve robustness of intrinsic fallback path
- The fallback path for intrinsics nodes is assumed to be direct call. Verify this assumption using no_way assert instead of regular assert.
- Make VM to always tell the JIT to use direct calls for intrinsics, even in version resilient code
Commit migrated from https://github.com/dotnet/coreclr/commit/
caffa7b7d9d19deb67ce99b83d0edf0ce081775d