platform/upstream/libSkiaSharp.git
10 years agoOffer single-param version of deepCopyTo -- much easier to migrate to colortypes
commit-bot@chromium.org [Thu, 20 Feb 2014 19:08:07 +0000 (19:08 +0000)]
Offer single-param version of deepCopyTo -- much easier to migrate to colortypes

BUG=skia:
R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/167683006

git-svn-id: http://skia.googlecode.com/svn/trunk@13516 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for imageblurtiled GM.
senorblanco@chromium.org [Thu, 20 Feb 2014 18:44:17 +0000 (18:44 +0000)]
New baselines for imageblurtiled GM.

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/170303004

git-svn-id: http://skia.googlecode.com/svn/trunk@13515 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRe-enable imageresizetiled, but skip it in tilegrid and rtree.
senorblanco@chromium.org [Thu, 20 Feb 2014 17:17:57 +0000 (17:17 +0000)]
Re-enable imageresizetiled, but skip it in tilegrid and rtree.

This change makes kSkipTiled_Flag also skip --tileGrid and --rtree.
All GMs which were passing kSkipTiled_Flag before were also passing
kSkipPicture_Flag, which also skips tilegrid and rtree, so this should
have no effect on them, but provides a smaller hammer for GMs which
still want to test picture playback, but not tiling.

The exception is magnifier, which was passing only kSkipTiled_Flag,
but magnifier is an odd beast and not web-exposed, so I'm not worried
about reducing its coverage slightly.

R=scroggo@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/165723009

git-svn-id: http://skia.googlecode.com/svn/trunk@13514 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdates bench alert test output to match latest changes.
commit-bot@chromium.org [Thu, 20 Feb 2014 16:22:55 +0000 (16:22 +0000)]
Updates bench alert test output to match latest changes.

BUG=skia:2193
TBR=epoger@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/167703005

git-svn-id: http://skia.googlecode.com/svn/trunk@13513 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSeparates faster and slower bench alerts; sorts by delta.
commit-bot@chromium.org [Thu, 20 Feb 2014 15:58:32 +0000 (15:58 +0000)]
Separates faster and slower bench alerts; sorts by delta.

Separate faster and slower bench alerts; sort by delta.

BUG=skia:2193
NOTRY=true
R=epoger@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/172683002

git-svn-id: http://skia.googlecode.com/svn/trunk@13512 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpstream fix for DecodeBench.
commit-bot@chromium.org [Thu, 20 Feb 2014 15:41:17 +0000 (15:41 +0000)]
Upstream fix for DecodeBench.

Use SkBasename to get the basename.

Fixes a bug on Android where calling strrchar conflicts with
Android's setting for FORTIFY_SOURCE.

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/170783012

git-svn-id: http://skia.googlecode.com/svn/trunk@13511 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline bench after nightly Chrome update.
commit-bot@chromium.org [Thu, 20 Feb 2014 14:03:47 +0000 (14:03 +0000)]
Rebaseline bench after nightly Chrome update.

BUG=skia:2198
R=rmistry@google.com
TBR=scroggo@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/172263004

git-svn-id: http://skia.googlecode.com/svn/trunk@13510 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r13496 (Merge tomhudson and mtklein SkPaint shrinking approaches) due to...
robertphillips@google.com [Thu, 20 Feb 2014 13:08:17 +0000 (13:08 +0000)]
Reverting r13496 (Merge tomhudson and mtklein SkPaint shrinking approaches) due to memory leaks

git-svn-id: http://skia.googlecode.com/svn/trunk@13509 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 20 Feb 2014 03:01:56 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13508 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDisable imageresizetiled GM for now due to rtree and tilegrid failures.
senorblanco@chromium.org [Wed, 19 Feb 2014 22:36:32 +0000 (22:36 +0000)]
Disable imageresizetiled GM for now due to rtree and tilegrid failures.

TBR=scroggo@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/172793006

git-svn-id: http://skia.googlecode.com/svn/trunk@13507 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix CTM application in SkResizeImagefilter; implement bounds traversals.
senorblanco@chromium.org [Wed, 19 Feb 2014 22:10:12 +0000 (22:10 +0000)]
Fix CTM application in SkResizeImagefilter; implement bounds traversals.

SkResizeImageFilter resizes all the pixels from its input (subject to
the input's crop rect), but the offset to be applied was incorrect.
It should take the CTM into account, so that the origin of the resize is
the world space origin, unaffected by whatever clipping is applied.

New GM imageresizetiled exercises the behaviour under
impl-side-painting-like conditions, and existing GMs now have resize
cases added.

R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/168283006

git-svn-id: http://skia.googlecode.com/svn/trunk@13506 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "First draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilt...
senorblanco@chromium.org [Wed, 19 Feb 2014 22:08:36 +0000 (22:08 +0000)]
Revert "First draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilter.", aka r13504 (this was an erroneous commit).

BUG=skia:
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/172793005

git-svn-id: http://skia.googlecode.com/svn/trunk@13505 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFirst draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilter.
senorblanco@chromium.org [Wed, 19 Feb 2014 22:06:20 +0000 (22:06 +0000)]
First draft of computeFastBounds() and onFilterBounds() for SkResizeImageFilter.

git-svn-id: http://skia.googlecode.com/svn/trunk@13504 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix issue in image decoders where the bitmap config was not properly set.
djsollen@google.com [Wed, 19 Feb 2014 21:45:35 +0000 (21:45 +0000)]
Fix issue in image decoders where the bitmap config was not properly set.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/167763003

git-svn-id: http://skia.googlecode.com/svn/trunk@13503 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix bench to compile when SK_SUPPORTS_GPU is not provided as a compiler option
commit-bot@chromium.org [Wed, 19 Feb 2014 19:30:42 +0000 (19:30 +0000)]
Fix bench to compile when SK_SUPPORTS_GPU is not provided as a compiler option

In the case that SK_SUPPORTS_GPU is not provided to the compiler, the value is
either defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change
HairlinePathBench would test that value before including anything, which led to
build errors.

BUG=skia:
R=djsollen@google.com, bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/172103007

git-svn-id: http://skia.googlecode.com/svn/trunk@13502 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorevert to previous behavior in installPixels, allowing for NULL address
reed@google.com [Wed, 19 Feb 2014 16:57:29 +0000 (16:57 +0000)]
revert to previous behavior in installPixels, allowing for NULL address

BUG=skia:

Review URL: https://codereview.chromium.org/172603002

git-svn-id: http://skia.googlecode.com/svn/trunk@13501 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd f suffix to 0.5 to fix mac 10.6 warning
bsalomon@google.com [Wed, 19 Feb 2014 15:50:25 +0000 (15:50 +0000)]
Add f suffix to 0.5 to fix mac 10.6 warning

BUG=skia:2195

Review URL: https://codereview.chromium.org/172233004

git-svn-id: http://skia.googlecode.com/svn/trunk@13500 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: extract common unittest code, and rename tests/ -> testdata/
commit-bot@chromium.org [Wed, 19 Feb 2014 15:38:13 +0000 (15:38 +0000)]
rebaseline_server: extract common unittest code, and rename tests/ -> testdata/

NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/170803005

git-svn-id: http://skia.googlecode.com/svn/trunk@13499 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAnalytic rrect clip for cicular corners, radius >= 0.5
commit-bot@chromium.org [Wed, 19 Feb 2014 15:18:05 +0000 (15:18 +0000)]
Analytic rrect clip for cicular corners, radius >= 0.5

BUG=skia:2181
R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/171413004

git-svn-id: http://skia.googlecode.com/svn/trunk@13498 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis CL improves saveLayer handling in the SkMatrixClipStateMgr by:
commit-bot@chromium.org [Wed, 19 Feb 2014 15:11:23 +0000 (15:11 +0000)]
This CL improves saveLayer handling in the SkMatrixClipStateMgr by:

1) no longer storing the clip skip offsets in the stack (since saveLayers can force multiple clip states to be open at one time)

2) writing out only the clips that are relative to the saveLayer's clip state

3) updates the testing harness to accept a save/restore bracketing a saveLayer/restore (since clips have to be applied to the saveLayer's result upon restore)

R=bsalomon@google.com, epoger@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/164823003

git-svn-id: http://skia.googlecode.com/svn/trunk@13497 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMerge tomhudson and mtklein SkPaint shrinking approaches.
commit-bot@chromium.org [Wed, 19 Feb 2014 13:55:07 +0000 (13:55 +0000)]
Merge tomhudson and mtklein SkPaint shrinking approaches.

I think this is cherry picking the best parts of both our CLs.  We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc.  Paints are typically 1/3 their original size when flattened in the dictionary.

bench_record on my desktop looks promising.  Generally, looks faster.  (Best in monospace.)
a/b   skp                               before  after
0.83  desk_techcrunch.skp               0.29    0.24
0.83  tabl_gamedeksiam.skp              0.52    0.43
0.87  desk_carsvg.skp                   0.4     0.35
0.87  desk_googlehome.skp               0.038   0.033
0.87  desk_pokemonwiki.skp              3.9     3.4
0.88  desk_fontwipe.skp                 0.0089  0.0078
0.88  desk_googlespreadsheet.skp        0.16    0.14
0.89  desk_jsfiddlebigcar.skp           0.027   0.024
0.89  desk_tigersvg.skp                 0.038   0.034
0.89  desk_weather.skp                  0.19    0.17
0.89  tabl_engadget.skp                 0.37    0.33
0.89  tabl_googleblog.skp               0.28    0.25
0.9   desk_facebook.skp                 0.2     0.18
0.91  desk_mapsvg.skp                   0.45    0.41
0.91  desk_youtube.skp                  0.22    0.2
0.92  desk_forecastio.skp               0.12    0.11
0.92  desk_googlespreadsheetdashed.skp  0.49    0.45
0.92  desk_gws.skp                      0.13    0.12
0.92  desk_pinterest.skp                0.037   0.034
0.92  desk_twitter.skp                  0.25    0.23
0.92  tabl_culturalsolutions.skp        0.26    0.24
0.92  tabl_gspro.skp                    0.072   0.066
0.92  tabl_mercurynews.skp              0.26    0.24
0.93  desk_booking.skp                  0.46    0.43
0.93  desk_chalkboard.skp               0.28    0.26
0.93  desk_linkedin.skp                 0.14    0.13
0.93  desk_mobilenews.skp               0.28    0.26
0.93  tabl_cuteoverload.skp             0.46    0.43
0.93  tabl_deviantart.skp               0.15    0.14
0.93  tabl_gmail.skp                    0.029   0.027
0.93  tabl_googlecalendar.skp           0.15    0.14
0.93  tabl_mlb.skp                      0.15    0.14
0.94  desk_blogger.skp                  0.18    0.17
0.94  desk_jsfiddlehumperclip.skp       0.034   0.032
0.94  desk_wordpress.skp                0.33    0.31
0.94  desk_wowwiki.skp                  0.94    0.88
0.94  desk_yahooanswers.skp             0.17    0.16
0.94  desk_youtubetvvideo.skp           0.017   0.016
0.94  tabl_sahadan.skp                  0.093   0.087
0.94  tabl_worldjournal.skp             0.35    0.33
0.95  desk_css3gradients.skp            0.21    0.2
0.95  desk_gmailthread.skp              0.19    0.18
0.95  tabl_cnet.skp                     0.42    0.4
0.95  tabl_mozilla.skp                  1.9     1.8
0.95  tabl_pravda.skp                   0.19    0.18
0.96  mobi_wikipedia.skp                0.55    0.53
0.96  tabl_cnn.skp                      0.48    0.46
0.96  tabl_nofolo.skp                   0.05    0.048
0.97  desk_googleplus.skp               0.29    0.28
0.97  tabl_frantzen.skp                 0.059   0.057
0.97  tabl_onlinewsj.skp                0.38    0.37
0.97  tabl_slashdot.skp                 0.1     0.097
0.97  tabl_vnexpress.skp                0.29    0.28
0.99  desk_amazon.skp                   0.088   0.087
1     desk_baidu.skp                    0.097   0.099
1     desk_ebay.skp                     0.18    0.18
1     desk_espn.skp                     0.24    0.24
1     desk_oldinboxapp.skp              0.026   0.026
1     desk_rectangletransition.skp      0.014   0.014
1     desk_samoasvg.skp                 0.23    0.24
1     desk_yahoogames.skp               0.029   0.029
1     desk_yahoosports.skp              0.0033  0.0033
1     desk_youtubetvbrowse.skp          0.01    0.01
1     tabl_androidpolice.skp            0.65    0.65
1     tabl_digg.skp                     0.33    0.33
1     tabl_hsfi.skp                     0.32    0.32
1     tabl_nytimes.skp                  0.22    0.22
1     tabl_techmeme.skp                 0.069   0.072
1     tabl_ukwsj.skp                    0.35    0.35
1.1   desk_sfgate.skp                   0.25    0.28

BUG=skia:2190

Committed: http://code.google.com/p/skia/source/detail?r=13487

R=tomhudson@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/158913005

git-svn-id: http://skia.googlecode.com/svn/trunk@13496 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSSE2 implementation of S32A_D565_Opaque
commit-bot@chromium.org [Wed, 19 Feb 2014 03:09:52 +0000 (03:09 +0000)]
SSE2 implementation of S32A_D565_Opaque

microbenchmark of S32A_D565_Opaque() shows a 3x speedup after SSE optimization with various count on i7-3770.

BUG=
R=mtklein@google.com, reed@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/138163013

git-svn-id: http://skia.googlecode.com/svn/trunk@13495 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix iOS build -- pass colortype, not config
commit-bot@chromium.org [Tue, 18 Feb 2014 23:32:05 +0000 (23:32 +0000)]
fix iOS build -- pass colortype, not config

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/170743002

git-svn-id: http://skia.googlecode.com/svn/trunk@13494 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd link to how to generate new SKPs when increasing the picture version
commit-bot@chromium.org [Tue, 18 Feb 2014 22:08:16 +0000 (22:08 +0000)]
Add link to how to generate new SKPs when increasing the picture version

BUG=skia:2041
R=robertphillips@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/170923003

git-svn-id: http://skia.googlecode.com/svn/trunk@13493 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinstallPixels returns true if null-pixels -- devolving to setConfig
commit-bot@chromium.org [Tue, 18 Feb 2014 21:35:24 +0000 (21:35 +0000)]
installPixels returns true if null-pixels -- devolving to setConfig

fixes assumptions in chrome's ui_unittests: RenderTextTest.SelectionKeepsLigatures

R=robertphillips@google.com, bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/170713006

git-svn-id: http://skia.googlecode.com/svn/trunk@13492 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Merge tomhudson and mtklein SkPaint shrinking approaches. (https://coderevi...
commit-bot@chromium.org [Tue, 18 Feb 2014 18:41:16 +0000 (18:41 +0000)]
Revert of Merge tomhudson and mtklein SkPaint shrinking approaches. (https://codereview.chromium.org/158913005/)

Reason for revert:
Breaking the build - see https://code.google.com/p/skia/issues/detail?id=2190

Original issue's description:
> Merge tomhudson and mtklein SkPaint shrinking approaches.
>
> I think this is cherry picking the best parts of both our CLs.  We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc.  Paints are typically 1/3 their original size when flattened in the dictionary.
>
> bench_record on my desktop looks promising.  Generally, looks faster.  (Best in monospace.)
> a/b   skp                               before  after
> 0.83  desk_techcrunch.skp               0.29    0.24
> 0.83  tabl_gamedeksiam.skp              0.52    0.43
> 0.87  desk_carsvg.skp                   0.4     0.35
> 0.87  desk_googlehome.skp               0.038   0.033
> 0.87  desk_pokemonwiki.skp              3.9     3.4
> 0.88  desk_fontwipe.skp                 0.0089  0.0078
> 0.88  desk_googlespreadsheet.skp        0.16    0.14
> 0.89  desk_jsfiddlebigcar.skp           0.027   0.024
> 0.89  desk_tigersvg.skp                 0.038   0.034
> 0.89  desk_weather.skp                  0.19    0.17
> 0.89  tabl_engadget.skp                 0.37    0.33
> 0.89  tabl_googleblog.skp               0.28    0.25
> 0.9   desk_facebook.skp                 0.2     0.18
> 0.91  desk_mapsvg.skp                   0.45    0.41
> 0.91  desk_youtube.skp                  0.22    0.2
> 0.92  desk_forecastio.skp               0.12    0.11
> 0.92  desk_googlespreadsheetdashed.skp  0.49    0.45
> 0.92  desk_gws.skp                      0.13    0.12
> 0.92  desk_pinterest.skp                0.037   0.034
> 0.92  desk_twitter.skp                  0.25    0.23
> 0.92  tabl_culturalsolutions.skp        0.26    0.24
> 0.92  tabl_gspro.skp                    0.072   0.066
> 0.92  tabl_mercurynews.skp              0.26    0.24
> 0.93  desk_booking.skp                  0.46    0.43
> 0.93  desk_chalkboard.skp               0.28    0.26
> 0.93  desk_linkedin.skp                 0.14    0.13
> 0.93  desk_mobilenews.skp               0.28    0.26
> 0.93  tabl_cuteoverload.skp             0.46    0.43
> 0.93  tabl_deviantart.skp               0.15    0.14
> 0.93  tabl_gmail.skp                    0.029   0.027
> 0.93  tabl_googlecalendar.skp           0.15    0.14
> 0.93  tabl_mlb.skp                      0.15    0.14
> 0.94  desk_blogger.skp                  0.18    0.17
> 0.94  desk_jsfiddlehumperclip.skp       0.034   0.032
> 0.94  desk_wordpress.skp                0.33    0.31
> 0.94  desk_wowwiki.skp                  0.94    0.88
> 0.94  desk_yahooanswers.skp             0.17    0.16
> 0.94  desk_youtubetvvideo.skp           0.017   0.016
> 0.94  tabl_sahadan.skp                  0.093   0.087
> 0.94  tabl_worldjournal.skp             0.35    0.33
> 0.95  desk_css3gradients.skp            0.21    0.2
> 0.95  desk_gmailthread.skp              0.19    0.18
> 0.95  tabl_cnet.skp                     0.42    0.4
> 0.95  tabl_mozilla.skp                  1.9     1.8
> 0.95  tabl_pravda.skp                   0.19    0.18
> 0.96  mobi_wikipedia.skp                0.55    0.53
> 0.96  tabl_cnn.skp                      0.48    0.46
> 0.96  tabl_nofolo.skp                   0.05    0.048
> 0.97  desk_googleplus.skp               0.29    0.28
> 0.97  tabl_frantzen.skp                 0.059   0.057
> 0.97  tabl_onlinewsj.skp                0.38    0.37
> 0.97  tabl_slashdot.skp                 0.1     0.097
> 0.97  tabl_vnexpress.skp                0.29    0.28
> 0.99  desk_amazon.skp                   0.088   0.087
> 1     desk_baidu.skp                    0.097   0.099
> 1     desk_ebay.skp                     0.18    0.18
> 1     desk_espn.skp                     0.24    0.24
> 1     desk_oldinboxapp.skp              0.026   0.026
> 1     desk_rectangletransition.skp      0.014   0.014
> 1     desk_samoasvg.skp                 0.23    0.24
> 1     desk_yahoogames.skp               0.029   0.029
> 1     desk_yahoosports.skp              0.0033  0.0033
> 1     desk_youtubetvbrowse.skp          0.01    0.01
> 1     tabl_androidpolice.skp            0.65    0.65
> 1     tabl_digg.skp                     0.33    0.33
> 1     tabl_hsfi.skp                     0.32    0.32
> 1     tabl_nytimes.skp                  0.22    0.22
> 1     tabl_techmeme.skp                 0.069   0.072
> 1     tabl_ukwsj.skp                    0.35    0.35
> 1.1   desk_sfgate.skp                   0.25    0.28
>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13487

R=tomhudson@google.com, reed@google.com, mtklein@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/169183003

git-svn-id: http://skia.googlecode.com/svn/trunk@13491 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert changes which were breaking the build.
commit-bot@chromium.org [Tue, 18 Feb 2014 18:13:34 +0000 (18:13 +0000)]
Revert changes which were breaking the build.

Revert "Improve saveLayer handling in SkMatrixClipStateMgr"

This reverts commit f7d08ed626a4825317405c3708cf2896509209d6.

Revert "Compile fix for r13488 (Improve saveLayer handling in SkMatrixClipStateMgr)"

This reverts commit a48822f3ebe86056afc76c96da73c950c80c686a.

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=True

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/170973002

git-svn-id: http://skia.googlecode.com/svn/trunk@13490 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCompile fix for r13488 (Improve saveLayer handling in SkMatrixClipStateMgr)
robertphillips@google.com [Tue, 18 Feb 2014 17:53:28 +0000 (17:53 +0000)]
Compile fix for r13488 (Improve saveLayer handling in SkMatrixClipStateMgr)

git-svn-id: http://skia.googlecode.com/svn/trunk@13489 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImprove saveLayer handling in SkMatrixClipStateMgr
robertphillips@google.com [Tue, 18 Feb 2014 17:28:52 +0000 (17:28 +0000)]
Improve saveLayer handling in SkMatrixClipStateMgr

https://codereview.chromium.org/164823003/

git-svn-id: http://skia.googlecode.com/svn/trunk@13488 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMerge tomhudson and mtklein SkPaint shrinking approaches.
commit-bot@chromium.org [Tue, 18 Feb 2014 17:25:25 +0000 (17:25 +0000)]
Merge tomhudson and mtklein SkPaint shrinking approaches.

I think this is cherry picking the best parts of both our CLs.  We've got dirty bit tracking from Tom's, picture format stability from Mike's, etc.  Paints are typically 1/3 their original size when flattened in the dictionary.

bench_record on my desktop looks promising.  Generally, looks faster.  (Best in monospace.)
a/b   skp                               before  after
0.83  desk_techcrunch.skp               0.29    0.24
0.83  tabl_gamedeksiam.skp              0.52    0.43
0.87  desk_carsvg.skp                   0.4     0.35
0.87  desk_googlehome.skp               0.038   0.033
0.87  desk_pokemonwiki.skp              3.9     3.4
0.88  desk_fontwipe.skp                 0.0089  0.0078
0.88  desk_googlespreadsheet.skp        0.16    0.14
0.89  desk_jsfiddlebigcar.skp           0.027   0.024
0.89  desk_tigersvg.skp                 0.038   0.034
0.89  desk_weather.skp                  0.19    0.17
0.89  tabl_engadget.skp                 0.37    0.33
0.89  tabl_googleblog.skp               0.28    0.25
0.9   desk_facebook.skp                 0.2     0.18
0.91  desk_mapsvg.skp                   0.45    0.41
0.91  desk_youtube.skp                  0.22    0.2
0.92  desk_forecastio.skp               0.12    0.11
0.92  desk_googlespreadsheetdashed.skp  0.49    0.45
0.92  desk_gws.skp                      0.13    0.12
0.92  desk_pinterest.skp                0.037   0.034
0.92  desk_twitter.skp                  0.25    0.23
0.92  tabl_culturalsolutions.skp        0.26    0.24
0.92  tabl_gspro.skp                    0.072   0.066
0.92  tabl_mercurynews.skp              0.26    0.24
0.93  desk_booking.skp                  0.46    0.43
0.93  desk_chalkboard.skp               0.28    0.26
0.93  desk_linkedin.skp                 0.14    0.13
0.93  desk_mobilenews.skp               0.28    0.26
0.93  tabl_cuteoverload.skp             0.46    0.43
0.93  tabl_deviantart.skp               0.15    0.14
0.93  tabl_gmail.skp                    0.029   0.027
0.93  tabl_googlecalendar.skp           0.15    0.14
0.93  tabl_mlb.skp                      0.15    0.14
0.94  desk_blogger.skp                  0.18    0.17
0.94  desk_jsfiddlehumperclip.skp       0.034   0.032
0.94  desk_wordpress.skp                0.33    0.31
0.94  desk_wowwiki.skp                  0.94    0.88
0.94  desk_yahooanswers.skp             0.17    0.16
0.94  desk_youtubetvvideo.skp           0.017   0.016
0.94  tabl_sahadan.skp                  0.093   0.087
0.94  tabl_worldjournal.skp             0.35    0.33
0.95  desk_css3gradients.skp            0.21    0.2
0.95  desk_gmailthread.skp              0.19    0.18
0.95  tabl_cnet.skp                     0.42    0.4
0.95  tabl_mozilla.skp                  1.9     1.8
0.95  tabl_pravda.skp                   0.19    0.18
0.96  mobi_wikipedia.skp                0.55    0.53
0.96  tabl_cnn.skp                      0.48    0.46
0.96  tabl_nofolo.skp                   0.05    0.048
0.97  desk_googleplus.skp               0.29    0.28
0.97  tabl_frantzen.skp                 0.059   0.057
0.97  tabl_onlinewsj.skp                0.38    0.37
0.97  tabl_slashdot.skp                 0.1     0.097
0.97  tabl_vnexpress.skp                0.29    0.28
0.99  desk_amazon.skp                   0.088   0.087
1     desk_baidu.skp                    0.097   0.099
1     desk_ebay.skp                     0.18    0.18
1     desk_espn.skp                     0.24    0.24
1     desk_oldinboxapp.skp              0.026   0.026
1     desk_rectangletransition.skp      0.014   0.014
1     desk_samoasvg.skp                 0.23    0.24
1     desk_yahoogames.skp               0.029   0.029
1     desk_yahoosports.skp              0.0033  0.0033
1     desk_youtubetvbrowse.skp          0.01    0.01
1     tabl_androidpolice.skp            0.65    0.65
1     tabl_digg.skp                     0.33    0.33
1     tabl_hsfi.skp                     0.32    0.32
1     tabl_nytimes.skp                  0.22    0.22
1     tabl_techmeme.skp                 0.069   0.072
1     tabl_ukwsj.skp                    0.35    0.35
1.1   desk_sfgate.skp                   0.25    0.28

BUG=skia:
R=tomhudson@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/158913005

git-svn-id: http://skia.googlecode.com/svn/trunk@13487 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd param name w/ default arg to work around clang bug on mac 10.7
reed@google.com [Tue, 18 Feb 2014 16:40:42 +0000 (16:40 +0000)]
add param name w/ default arg to work around clang bug on mac 10.7

git-svn-id: http://skia.googlecode.com/svn/trunk@13486 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agostaticMethod -> StaticMethod
commit-bot@chromium.org [Tue, 18 Feb 2014 16:15:05 +0000 (16:15 +0000)]
staticMethod -> StaticMethod

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/166193006

git-svn-id: http://skia.googlecode.com/svn/trunk@13485 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: fail fast if skpdiff binary is not available
commit-bot@chromium.org [Tue, 18 Feb 2014 14:38:22 +0000 (14:38 +0000)]
rebaseline_server: fail fast if skpdiff binary is not available

NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/169943002

git-svn-id: http://skia.googlecode.com/svn/trunk@13484 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 18 Feb 2014 03:01:51 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13483 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoreplace SkBitmap::Config with SkColorType in gms
commit-bot@chromium.org [Mon, 17 Feb 2014 21:21:46 +0000 (21:21 +0000)]
replace SkBitmap::Config with SkColorType in gms

add helper installMaskPixels() to SkBitmap

BUG=skia:
R=halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/169913003

git-svn-id: http://skia.googlecode.com/svn/trunk@13482 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix another clipstack element !rect doesn't mean path bug.
commit-bot@chromium.org [Mon, 17 Feb 2014 19:50:02 +0000 (19:50 +0000)]
Fix another clipstack element !rect doesn't mean path bug.

BUG=skia:2183
R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/169763002

git-svn-id: http://skia.googlecode.com/svn/trunk@13481 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse factories instead of directly creating SkImageInfo.
bungeman@google.com [Mon, 17 Feb 2014 17:02:17 +0000 (17:02 +0000)]
Use factories instead of directly creating SkImageInfo.

R=reed@google.com

Review URL: https://codereview.chromium.org/169363007

git-svn-id: http://skia.googlecode.com/svn/trunk@13480 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix style nit in drawIRect
reed@google.com [Mon, 17 Feb 2014 16:28:05 +0000 (16:28 +0000)]
fix style nit in drawIRect

git-svn-id: http://skia.googlecode.com/svn/trunk@13479 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix spelling of class name in comment.
commit-bot@chromium.org [Mon, 17 Feb 2014 15:28:55 +0000 (15:28 +0000)]
Fix spelling of class name in comment.

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/76623004

git-svn-id: http://skia.googlecode.com/svn/trunk@13478 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange PictureRecord (and its private subclasses) to take size instead of device
commit-bot@chromium.org [Mon, 17 Feb 2014 15:28:00 +0000 (15:28 +0000)]
change PictureRecord (and its private subclasses) to take size instead of device

BUG=skia:
R=mtklein@google.com, scroggo@google.com, reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/168983003

git-svn-id: http://skia.googlecode.com/svn/trunk@13477 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agostill trying to kill setDevice: rename to setRootDevice (better name) and make private
commit-bot@chromium.org [Mon, 17 Feb 2014 15:24:26 +0000 (15:24 +0000)]
still trying to kill setDevice: rename to setRootDevice (better name) and make private

BUG=skia:
COLLABORATOR=reed@google.com
R=bsalomon@google.com, scroggo@google.com, reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/169023002

git-svn-id: http://skia.googlecode.com/svn/trunk@13476 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSmall fixes for auto generating Android.mk
commit-bot@chromium.org [Mon, 17 Feb 2014 15:22:26 +0000 (15:22 +0000)]
Small fixes for auto generating Android.mk

Turn off -Wno-c++11-extensions for Android. The Android framework does
not support this flag. Using it gives a bunch of warnings when building,
so remove it.

Remove skia_chrome_utils from framework. They are experimental and not
used by Android.

BUG=skia:1975
R=djsollen@google.com, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/164793002

git-svn-id: http://skia.googlecode.com/svn/trunk@13475 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove unnecessary includes.
commit-bot@chromium.org [Mon, 17 Feb 2014 14:20:43 +0000 (14:20 +0000)]
Remove unnecessary includes.

R=mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/163893002

git-svn-id: http://skia.googlecode.com/svn/trunk@13474 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse SkColorType instead of SkBitmap::Config in samplecode
commit-bot@chromium.org [Mon, 17 Feb 2014 02:55:57 +0000 (02:55 +0000)]
use SkColorType instead of SkBitmap::Config in samplecode

BUG=skia:
R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/169063002

git-svn-id: http://skia.googlecode.com/svn/trunk@13473 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhitespace change to test recent buildbot repo changes
commit-bot@chromium.org [Mon, 17 Feb 2014 01:47:14 +0000 (01:47 +0000)]
Whitespace change to test recent buildbot repo changes

BUG=skia:2139
TBR=

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/166183003

git-svn-id: http://skia.googlecode.com/svn/trunk@13472 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake canvas pass rrects along to clip stack
commit-bot@chromium.org [Sun, 16 Feb 2014 23:35:31 +0000 (23:35 +0000)]
Make canvas pass rrects along to clip stack

BUG=skia:2181
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/167283004

git-svn-id: http://skia.googlecode.com/svn/trunk@13470 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse SkColorType instead of SkBitmap::Config in views/effects
commit-bot@chromium.org [Sun, 16 Feb 2014 22:03:38 +0000 (22:03 +0000)]
use SkColorType instead of SkBitmap::Config in views/effects

R=scroggo@google.com, reed@google.com
TBR=scroggo

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/168843002

git-svn-id: http://skia.googlecode.com/svn/trunk@13469 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorestore old behavior of setPixels(): lockPixels after installPixels()
mike@reedtribe.org [Sun, 16 Feb 2014 20:54:21 +0000 (20:54 +0000)]
restore old behavior of setPixels(): lockPixels after installPixels()

git-svn-id: http://skia.googlecode.com/svn/trunk@13468 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake PDF clip code handle rrects.
commit-bot@chromium.org [Sun, 16 Feb 2014 16:01:14 +0000 (16:01 +0000)]
Make PDF clip code handle rrects.

Fixes bug introduced in https://code.google.com/p/skia/source/detail?r=13465
http://108.170.217.252:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/builds/1382/steps/RenderPdfs/logs/stdio

R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/166313003

git-svn-id: http://skia.googlecode.com/svn/trunk@13467 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix calling undef inline func build error
commit-bot@chromium.org [Sun, 16 Feb 2014 14:45:45 +0000 (14:45 +0000)]
fix calling undef inline func build error

Fixes error introduced in https://code.google.com/p/skia/source/detail?r=13465

R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/168893002

git-svn-id: http://skia.googlecode.com/svn/trunk@13466 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStore SkRRects in SkClipStack
commit-bot@chromium.org [Sun, 16 Feb 2014 13:25:24 +0000 (13:25 +0000)]
Store SkRRects in SkClipStack

BUG=skia:2181
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/163683002

git-svn-id: http://skia.googlecode.com/svn/trunk@13465 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sun, 16 Feb 2014 03:01:56 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13464 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange device factories to take SkImageInfo instead of SkBitmap::Config
commit-bot@chromium.org [Sun, 16 Feb 2014 00:59:25 +0000 (00:59 +0000)]
Change device factories to take SkImageInfo instead of SkBitmap::Config

patch from issue 167033002

BUG=skia:
R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/168653002

git-svn-id: http://skia.googlecode.com/svn/trunk@13463 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 15 Feb 2014 03:02:15 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13462 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImproved distance field sampling
commit-bot@chromium.org [Fri, 14 Feb 2014 21:48:29 +0000 (21:48 +0000)]
Improved distance field sampling

There are two different fixes here. First, it computes the distance value properly within the shader. Second, it handles anti-aliasing properly by doing a correction based on the gradient of the texture coordinates.

R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/149853002

git-svn-id: http://skia.googlecode.com/svn/trunk@13461 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhen the CTM has perspective the back-project method in quickRejectY goes haywire.
commit-bot@chromium.org [Fri, 14 Feb 2014 19:52:18 +0000 (19:52 +0000)]
When the CTM has perspective the back-project method in quickRejectY goes haywire.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/166873004

git-svn-id: http://skia.googlecode.com/svn/trunk@13460 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllowing Lanczos3 to be used in chromium
commit-bot@chromium.org [Fri, 14 Feb 2014 18:46:08 +0000 (18:46 +0000)]
Allowing Lanczos3 to be used in chromium

BUG=skia:
R=senorblanco@google.com, reed@google.com, humper@google.com, senorblanco@chromium.org, robertphillips@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/163663002

git-svn-id: http://skia.googlecode.com/svn/trunk@13459 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove border from GrAtlas entries, and associated copy.
commit-bot@chromium.org [Fri, 14 Feb 2014 18:41:47 +0000 (18:41 +0000)]
Remove border from GrAtlas entries, and associated copy.

BUG=skia:2178
R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/166483005

git-svn-id: http://skia.googlecode.com/svn/trunk@13458 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCleanup unref and null
commit-bot@chromium.org [Fri, 14 Feb 2014 17:27:10 +0000 (17:27 +0000)]
Cleanup unref and null

BUG=skia:
R=mtklein@google.com, scroggo@google.com, iancottrell@chromium.org

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/163053005

git-svn-id: http://skia.googlecode.com/svn/trunk@13457 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBug Fix for Intel atan on gpu sweep gradient
commit-bot@chromium.org [Fri, 14 Feb 2014 17:27:04 +0000 (17:27 +0000)]
Bug Fix for Intel atan on gpu sweep gradient

BUG=skia:2164
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/152233006

git-svn-id: http://skia.googlecode.com/svn/trunk@13456 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove deprecation of SkBaseDevice::config() so compile can proceed.
jvanverth@google.com [Fri, 14 Feb 2014 16:39:10 +0000 (16:39 +0000)]
Remove deprecation of SkBaseDevice::config() so compile can proceed.

TBR:reed@google.com

Review URL: https://codereview.chromium.org/163773004

git-svn-id: http://skia.googlecode.com/svn/trunk@13455 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of have DeferredDevice inherit from SkBaseDevice (https://codereview...
reed@google.com [Fri, 14 Feb 2014 15:23:15 +0000 (15:23 +0000)]
Revert "Revert of have DeferredDevice inherit from SkBaseDevice (https://codereview.chromium.org/165393006/)"

removed assert from lockPixels(), since that is called during setDevice()

This reverts commit 20bfc5337fa17cff52fb96b13af674c181e2c5a9.

BUG=skia:

Review URL: https://codereview.chromium.org/167003002

git-svn-id: http://skia.googlecode.com/svn/trunk@13454 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of have DeferredDevice inherit from SkBaseDevice (https://codereview.chromium...
commit-bot@chromium.org [Fri, 14 Feb 2014 15:18:36 +0000 (15:18 +0000)]
Revert of have DeferredDevice inherit from SkBaseDevice (https://codereview.chromium.org/165393006/)

Reason for revert:
broke tests

Original issue's description:
> have DeferredDevice inherit from SkBaseDevice
>
> mirror of 165813003
>
> BUG=skia:
>
> Committed: https://code.google.com/p/skia/source/detail?r=13452

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/163183011

git-svn-id: http://skia.googlecode.com/svn/trunk@13453 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agohave DeferredDevice inherit from SkBaseDevice
reed@google.com [Fri, 14 Feb 2014 14:41:28 +0000 (14:41 +0000)]
have DeferredDevice inherit from SkBaseDevice

mirror of 165813003

BUG=skia:

Review URL: https://codereview.chromium.org/165393006

git-svn-id: http://skia.googlecode.com/svn/trunk@13452 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for https://codereview.chromium.org/156113005/
commit-bot@chromium.org [Fri, 14 Feb 2014 14:29:22 +0000 (14:29 +0000)]
Rebaselines for https://codereview.chromium.org/156113005/

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, halcanary@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/166403004

git-svn-id: http://skia.googlecode.com/svn/trunk@13451 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjust allowed error from 0.5 to 2.5.
commit-bot@chromium.org [Fri, 14 Feb 2014 14:26:01 +0000 (14:26 +0000)]
Adjust allowed error from 0.5 to 2.5.

BUG=skia:2169
NOTRY=true
R=jvanverth@google.com
TBR=jvanverth@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/166233003

git-svn-id: http://skia.googlecode.com/svn/trunk@13450 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix valgrind suppressions (again)
robertphillips@google.com [Fri, 14 Feb 2014 14:08:05 +0000 (14:08 +0000)]
Fix valgrind suppressions (again)

https://codereview.chromium.org/166193003/

git-svn-id: http://skia.googlecode.com/svn/trunk@13449 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBuilder class for SkLayerDrawLooper.
commit-bot@chromium.org [Fri, 14 Feb 2014 10:06:42 +0000 (10:06 +0000)]
Builder class for SkLayerDrawLooper.

SkLayerDrawLooper provides methods like addLayer() to build up a linked list
of layers. Working towards making this class immutable, this patch introduces
the SkLayerDrawLooperBuilder class which is used to accumulate all the layers
first. Once all layers are in place, it creates a new SkLayerDrawLooper object
and hands over the list of layers to that object.

For now we keep the addLayer methods in SkLayerDrawLooper so we don't break
Chrome and Blink when this is landed. Once we've updated all users, we can
remove the methods.

BUG=skia:2141
R=reed@google.com, scroggo@google.com, mtklein@google.com, reed@chromium.org

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/133813005

git-svn-id: http://skia.googlecode.com/svn/trunk@13448 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 14 Feb 2014 03:02:05 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13447 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDefer deletion of our shaders until after linking the gl program to work around an...
commit-bot@chromium.org [Fri, 14 Feb 2014 00:03:38 +0000 (00:03 +0000)]
Defer deletion of our shaders until after linking the gl program to work around an Android emulator bug

R=bsalomon@google.com, brian@thesalomons.net, bsalomon
BUG=skia:

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/164973002

git-svn-id: http://skia.googlecode.com/svn/trunk@13446 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSmall adjustments of two bench ranges.
commit-bot@chromium.org [Thu, 13 Feb 2014 22:52:51 +0000 (22:52 +0000)]
Small adjustments of two bench ranges.

BUG=skia:2169
NOTRY=true
R=jvanverth@google.com
TBR=jvanverth@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/164843004

git-svn-id: http://skia.googlecode.com/svn/trunk@13445 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix debugging script for the SampleApp
commit-bot@chromium.org [Thu, 13 Feb 2014 22:31:48 +0000 (22:31 +0000)]
fix debugging script for the SampleApp

R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/164773002

git-svn-id: http://skia.googlecode.com/svn/trunk@13444 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoensure that opaque-only colortypes always report opaque-alphatype
commit-bot@chromium.org [Thu, 13 Feb 2014 22:30:38 +0000 (22:30 +0000)]
ensure that opaque-only colortypes always report opaque-alphatype

BUG=skia:
R=scroggo@google.com, djsollen@google.com, reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/164233006

git-svn-id: http://skia.googlecode.com/svn/trunk@13443 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoreplace setConfig+allocPixels with alloc-or-install-pixels
commit-bot@chromium.org [Thu, 13 Feb 2014 22:00:04 +0000 (22:00 +0000)]
replace setConfig+allocPixels with alloc-or-install-pixels

BUG=skia:
R=scroggo@google.com, halcanary@google.com, reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/164203003

git-svn-id: http://skia.googlecode.com/svn/trunk@13442 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding list of Skia's CQ committers
commit-bot@chromium.org [Thu, 13 Feb 2014 21:02:38 +0000 (21:02 +0000)]
Adding list of Skia's CQ committers

BUG=skia:2170
NOTRY=true
R=mtklein@google.com, hcm@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/163693003

git-svn-id: http://skia.googlecode.com/svn/trunk@13441 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse a bench alert algorithm with wider ranges. TBR=jvanverth NOTRY=true
commit-bot@chromium.org [Thu, 13 Feb 2014 20:40:56 +0000 (20:40 +0000)]
Use a bench alert algorithm with wider ranges. TBR=jvanverth NOTRY=true

BUG=skia:2169
R=jvanverth@google.com, bsalomon@google.com, robertphillips@google.com
TBR=jvanverth@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/164553002

git-svn-id: http://skia.googlecode.com/svn/trunk@13440 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed clusterfuzz found crash
commit-bot@chromium.org [Thu, 13 Feb 2014 18:46:13 +0000 (18:46 +0000)]
Fixed clusterfuzz found crash

BUG=343461
R=senorblanco@google.com, senorblanco@chromium.org, reed@chromium.org, reed@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/162943003

git-svn-id: http://skia.googlecode.com/svn/trunk@13439 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoARM Skia NEON patches - 27 - S32A_D565_Blend
commit-bot@chromium.org [Thu, 13 Feb 2014 18:37:35 +0000 (18:37 +0000)]
ARM Skia NEON patches - 27 - S32A_D565_Blend

BlitRow565: new intrinsics version of S32A_D565_Blend

This new version is basically a rewrite of the existing code with
a few speed and accuracy improvements. There is a switch to enable
pixel perfect results at the cost of a (quite big) decrease of
performances (disabled in this patch).

Here are the benchmark results (speedup vs. existing code):

+-------+------------+------------+
| count | Cortex -A9 | Cortex-A15 |
+-------+------------+------------+
| 1     | +103.6%    | +12%       |
+-------+------------+------------+
| 2     | +3.6%      | +21.6%     |
+-------+------------+------------+
| 4     | +0.8%      | -0.8%      |
+-------+------------+------------+
| 8     | +3.9%      | -1%        |
+-------+------------+------------+
| 16    | +14.7%     | +5.7%      |
+-------+------------+------------+
| 64    | +18.1%     | +13.2%     |
+-------+------------+------------+
| 256   | +16.3%     | +27.4%     |
+-------+------------+------------+
| 1024  | +78.2%     | +17.4%     |
+-------+------------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, halcanary@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/156113005

git-svn-id: http://skia.googlecode.com/svn/trunk@13438 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGyp flag to disable inlining.
commit-bot@chromium.org [Thu, 13 Feb 2014 18:36:36 +0000 (18:36 +0000)]
Gyp flag to disable inlining.

To turn off all inlining, rebuild after running the command

$ GYP_DEFINES=skia_disable_inlining=1 ./gyp_skia

Provides an initial value in one GM to avoid an uninitialized variable warning.

BUG=skia:2126
R=scroggo@google.com, mtklein@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/163363004

git-svn-id: http://skia.googlecode.com/svn/trunk@13437 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkWriter32: throw in the SkTDArray towel.
commit-bot@chromium.org [Thu, 13 Feb 2014 18:35:54 +0000 (18:35 +0000)]
SkWriter32: throw in the SkTDArray towel.

I think it's looking more clear we don't have a clean way to use SkTDArray in
SkWriter32.  We can't give SkWriter32 meaningful control over SkTDArray's
reallocation without making moot SkTDArray's raison d'etre.

Let's just use an SkAutoTMalloc<uint8_t> instead.  It wants SkWriter32 to
control it.  Also, it's lower overhead: SkAutoTMalloc<uint8_t> is just a smart
poiter: no size or capacity stored.

BUG=skia:
R=reed@google.com, iancottrell@google.com, reed@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/163983002

git-svn-id: http://skia.googlecode.com/svn/trunk@13436 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAnother try at updating expectations
jvanverth@google.com [Thu, 13 Feb 2014 18:34:56 +0000 (18:34 +0000)]
Another try at updating expectations

BUG=skia:

Review URL: https://codereview.chromium.org/163593004

git-svn-id: http://skia.googlecode.com/svn/trunk@13435 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examine
commit-bot@chromium.org [Thu, 13 Feb 2014 17:17:05 +0000 (17:17 +0000)]
rebaseline_server: create ImagePairSet-- holds a number of ImagePairs to examine

See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context

BUG=skia:1919
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/139343018

git-svn-id: http://skia.googlecode.com/svn/trunk@13434 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBench rebaseline to use narrower ranges. This also tests the new range calculation...
commit-bot@chromium.org [Thu, 13 Feb 2014 17:16:56 +0000 (17:16 +0000)]
Bench rebaseline to use narrower ranges. This also tests the new range calculation algorithm.

BUG=skia:2163
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/161563002

git-svn-id: http://skia.googlecode.com/svn/trunk@13433 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd peekPixels to SkCanvas and SkSurface
commit-bot@chromium.org [Thu, 13 Feb 2014 17:14:46 +0000 (17:14 +0000)]
add peekPixels to SkCanvas and SkSurface

fix reference to SkBaseDevice, which was only a problem in no-gpu build

This reverts commit 4fa44a6bf73891b21917fb90d02beef9143bffa3.

R=reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/163603003

git-svn-id: http://skia.googlecode.com/svn/trunk@13432 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd conicTo().
commit-bot@chromium.org [Thu, 13 Feb 2014 16:00:58 +0000 (16:00 +0000)]
Add conicTo().

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/161223002

git-svn-id: http://skia.googlecode.com/svn/trunk@13431 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd unit test for unbalanced save and restores in pictures.
commit-bot@chromium.org [Thu, 13 Feb 2014 16:00:51 +0000 (16:00 +0000)]
Add unit test for unbalanced save and restores in pictures.

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/150653010

git-svn-id: http://skia.googlecode.com/svn/trunk@13430 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate directions and lib paths for ninja.
commit-bot@chromium.org [Thu, 13 Feb 2014 15:30:06 +0000 (15:30 +0000)]
Update directions and lib paths for ninja.

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/161163003

git-svn-id: http://skia.googlecode.com/svn/trunk@13429 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org...
commit-bot@chromium.org [Thu, 13 Feb 2014 15:29:03 +0000 (15:29 +0000)]
Revert of add peekPixels to SkCanvas and SkSurface (https://codereview.chromium.org/161733002/)

Reason for revert:
compile issues with gm/xfermodes3

Original issue's description:
> add peekPixels to SkCanvas and SkSurface
>
> clone of https://codereview.chromium.org/159723006/
>
> Committed: https://code.google.com/p/skia/source/detail?r=13427

R=jvanverth@google.com
NOTREECHECKS=true
NOTRY=true

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/163823002

git-svn-id: http://skia.googlecode.com/svn/trunk@13428 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd peekPixels to SkCanvas and SkSurface
mike@reedtribe.org [Thu, 13 Feb 2014 15:11:11 +0000 (15:11 +0000)]
add peekPixels to SkCanvas and SkSurface

clone of https://codereview.chromium.org/159723006/

Review URL: https://codereview.chromium.org/161733002

git-svn-id: http://skia.googlecode.com/svn/trunk@13427 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoreplace setConfig+allocPixels with single call
mike@reedtribe.org [Thu, 13 Feb 2014 14:41:43 +0000 (14:41 +0000)]
replace setConfig+allocPixels with single call

BUG=skia:

Review URL: https://codereview.chromium.org/162643002

git-svn-id: http://skia.googlecode.com/svn/trunk@13426 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdated GM expectations for Win7-ShuttleA-HD2000
jvanverth@google.com [Thu, 13 Feb 2014 14:24:59 +0000 (14:24 +0000)]
Updated GM expectations for Win7-ShuttleA-HD2000

BUG=skia:2167

Review URL: https://codereview.chromium.org/163643002

git-svn-id: http://skia.googlecode.com/svn/trunk@13425 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 13 Feb 2014 03:01:57 +0000 (03:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13424 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoJust a bit of cleanup. This doesn't alter the matrix/clip stack manager's behavior...
commit-bot@chromium.org [Wed, 12 Feb 2014 23:22:15 +0000 (23:22 +0000)]
Just a bit of cleanup. This doesn't alter the matrix/clip stack manager's behavior or its memory consumption.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/161143002

git-svn-id: http://skia.googlecode.com/svn/trunk@13423 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEmpty expectations for bots affected by GM perspective switch
commit-bot@chromium.org [Wed, 12 Feb 2014 18:33:56 +0000 (18:33 +0000)]
Empty expectations for bots affected by GM perspective switch

BUG=skia:2146
R=epoger@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/149123009

git-svn-id: http://skia.googlecode.com/svn/trunk@13422 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of r13379 (Move fLastMoveToIndex from SkPath to SkPathRef - https://codereview...
commit-bot@chromium.org [Wed, 12 Feb 2014 17:44:30 +0000 (17:44 +0000)]
Revert of r13379 (Move fLastMoveToIndex from SkPath to SkPathRef - https://codereview.chromium.org/146913002/) due to image quality regression in Chromium. See crbug.com/343123 (Regression - UI issue observed for any "Notification infobars" in Chrome browser)

R=bsalomon@google.com
TBR=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/137863006

git-svn-id: http://skia.googlecode.com/svn/trunk@13421 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis CL doesn't radically change the behavior of the matrix\clip stack reducer. It...
commit-bot@chromium.org [Wed, 12 Feb 2014 15:48:04 +0000 (15:48 +0000)]
This CL doesn't radically change the behavior of the matrix\clip stack reducer. It just cleans up the matrix handling a bit.

R=bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/151033004

git-svn-id: http://skia.googlecode.com/svn/trunk@13420 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove width>=0 asserts, as clients rely on this (at least for testing)
reed@google.com [Wed, 12 Feb 2014 13:21:55 +0000 (13:21 +0000)]
remove width>=0 asserts, as clients rely on this (at least for testing)

git-svn-id: http://skia.googlecode.com/svn/trunk@13419 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 12 Feb 2014 03:02:04 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13418 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused deviceconfig from SkShader
mike@reedtribe.org [Wed, 12 Feb 2014 01:28:30 +0000 (01:28 +0000)]
remove unused deviceconfig from SkShader

git-svn-id: http://skia.googlecode.com/svn/trunk@13417 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoTempletized SkWriter32 readTAt() & overwriteTAt()
commit-bot@chromium.org [Tue, 11 Feb 2014 22:38:51 +0000 (22:38 +0000)]
Templetized SkWriter32 readTAt() & overwriteTAt()

Convert SkWriter32::{read,write}32At() to ::{read,overwrite}TAt<>() to allow
peeking/updating arbitrary records.

BUG=skia:
R=mtklein@google.com, reed@google.com, robertphillips@google.com, iancottrell@chromium.org

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/130913018

git-svn-id: http://skia.googlecode.com/svn/trunk@13416 2bbb7eff-a529-9590-31e7-b0007b416f81